 Nevertheless, seven years in the making, it was McCain's greatest legislative achievement and had become, in the words of one biographer, "one of the most famous pieces of federal legislation in modern American political history.