 Johnston was born in Glasgow.He began his football career as a junior at Cardiff City, turning professional in 1964 and making his debut at the end of the 1964–65 season at the age of 17.He was part of Cardiff's 1965 Welsh Cup-winning team.