 He won the Scottish Challenge Cup in 2007 and the Scottish First Division in 2009 with St. Johnstone.Milne began his career with Dundee, making two appearances midway through the club's 1997–98 Scottish First Division title-winning season.Failing to appear in the club's Scottish Premier League campaign the following season, Milne spent the entire 1999-00 campaign on loan at Forfar Athletic, scoring 16 goals in 35 league matches.