 Macdonald was a merchant, exporter and shipbuilder.He also was a director of the Cardigan Electric Company, the Cardigan Silver Fox Company Limited and the Georgetown Fish Company.In 1905, he married Marie Josephine MacDonald.