 Cunningham served as a lieutenant in the Royal Field Artillery during the First World War.Cunningham continued to be used infrequently by manager William Wilton before establishing himself in the Rangers team in 1918–19.He won seven League titles and played in Rangers' famous 1928 Scottish Cup Final triumph where they defeated Celtic 4–0 to win the trophy for the first time in 25 years.