 Born in Bartonholm, Ayrshire, Scotland, Orr was an inside-forward who played for Kilwinning Eglinton, Glossop North End and St Mirren before Newcastle United signed him in May 1901.He spent seven seasons on Tyneside helping the "Magpies" to the League title in both 1905 and 1907.He also appeared for the club in the 1906 FA Cup Final, where they succumbed to a 1–0 defeat by Everton.