 He practised as a defence solicitor for 21 years.In 2004 he became the first Solicitor Advocate from outside the Crown Office and Procurator Fiscal Service to be appointed as an Advocate Depute.He was appointed as a Senior Advocate Depute in 2006 and became a QC in 2007.