 Weir was born in London, Ontario, and played his amateur football with the London Lords intermediate league team.He had a 13-year career with the Alouettes from 1972 through 1982 and the Montreal Concordes from 1983 to 1984.He held the Alouettes' franchise record for most games with 203 until he was surpassed by Bryan Chiu in 2009.