 He made over 100 appearances for Glasgow Warriors from 1999 to 2008.Macfadyen played for Edinburgh Academicals at an amateur level before being signed for Glasgow Warriors.He played for London Scottish but the club went into administration and he returned to Scotland.