 In 1899, he was elected cashier; he became its president on January 11, 1916 and served until 1925.McFadden served as treasurer of the Pennsylvania Bankers' Association in 1906 and 1907, and as president in 1914 and 1915.He was appointed in 1914 by the agricultural societies of the State of Pennsylvania as a trustee of Pennsylvania State College.