 He began his career with Shawfield Juniors, and later played for Petershill, Benburb, Ashfield, Partick Thistle, and Ayr United before joining Football League side Bury in 1926–27.In 1928, he left Gigg Lane to play in the United States for Bethlehem Steel, supporting himself as a bookkeeper, and in 1930 he joined Irish side Dolphin.Later that year he returned to his native Scotland to join Heart of Midlothian.