 John Erskine married Lady Marjorie Hervey, the elder daughter of the 4th Marquess of Bristol, on 2 December 1919 and had four sons.On outbreak of the First World War, Erskine enlisted in the Scots Guards.By the end of the war he was a Major in the Argyll and Sutherland Highlanders.