 He was formerly a Deputy Minister in the Prime Minister's Department.He was the Member of Parliament for Taiping constituency, until losing in the 2008 Malaysian General Election to Nga Kor Ming a candidate from the opposition Democratic Action Party (DAP).Previously, he was a senator in the Malaysian bicameral parliament and a Deputy Minister of Housing and Local Government.