 After a curacy in Govan he was Rector of Hillington, Glasgow and then a lecturer at Edinburgh Theological College until 1963.He was Dean of Glasgow and Galloway until 1974 when he became its bishop.A noted ecclesiastical historian, he died in post.