 A right back, he played for the club 555 times in competitive matches between 1925 and 1946, earning ten league championship and six Scottish Cup winner's medals.Taking into account his appearances in war-time matches and friendlies, he made 940 appearances for the club in all, wearing the shirt more times than any other player, though John Greig is the record holder for appearances in official matches.After leaving Rangers, he acted as a coach at Clyde.