 His first charge was as minister at the parishes of Langholm, Ewes and Westerkirk.He then became minister at Riverside Parish Church, Dumbarton (1985-2001).He then served as minister of Aberlady and Gullane Parish Churches, East Lothian, until retiring in 2008.