 Barber was Shels top league scorer at the end of ten different seasons.At the end of the 2012 League of Ireland season Barber is twelfth in the all-time League of Ireland goalscoring list with 141 league goals 

Barber was capped twice by the Republic of Ireland national football team during his time with Shels in a World Cup qualifier in Spain and a friendly against Belgium.He was Rovers' assistant manager in the 1978–79 season.