 During his time with Shels, Barber scored a club record 126 league goals.He was part of Shels FAI Youth Cup-winning side in 1959 and went on to win the League of Ireland championship in 1962, and the FAI Cup in 1960 and 1963, beating Cork Hibernians 2–0 on both occasions.Barber scored in every round including the final in the 1960 cup win and in the 1962 cup final defeat to Shamrock Rovers.