 From 1958 to 1968 he was Professor of Civil Law at the University of Edinburgh and from 1968 to 1972 Professor of Scots Law.He was a part-time member of the Scottish Law Commission 1965-1972 and full-time 1972-1980.In 1980 he became the General Editor of the "Laws of Scotland