 His association with the University of Edinburgh began in 1920, and he rose to become Forbes Reader in Spanish and head of the Department of Hispanic Studies.His writings included a critical study of the Spanish novelist Perez Galdos and editions of classical Spanish works.He also lectured for the Ministry of Information and the British Council in Spain and South America.