 He signed for Rangers in 1952 after impressing manager Bill Struth whilst playing in a schoolboy international against England at Wembley; Struth signed him on a provisional contract in the summer of that year.Having spent time on loan with juvenile side Slateford Athletic and Junior team Broxburn Athletic, in 1954 he turned professional and made his debut for Rangers on 6 November against Kilmarnock, scoring two goals in a 6–0 win.He missed the next two seasons doing his national service.