 He was called to the Nova Scotia bar in 1945.He practised law with his father and with Ronald J. Macdonald.During World War II, Macdonald served with the Royal Canadian Electrical and Mechanical Engineers and with the Royal Canadian Ordnance Corps.