Fix + avoid calls to Smalltalk (use FileLocator instead)
MODIFY
src/PharoLauncher-Core.package/PhLTreeSelection.class/instance/pathFor.on..st
src/PharoLauncher-Core.package/PhLTreeSelection.class/instance/pathFor.on..st
private
pathFor: treeNodeModel on: collection
-
- treeNodeModel parentNode ifNotNil:
- [ :node |
- self pathFor: node on: collection ].
-
- collection add: treeNodeModel content name
\ No newline at end of file
+ | content |
+ treeNodeModel parentNode ifNotNil: [ :node | self pathFor: node on: collection ].
+ content := treeNodeModel content.
+ collection
+ add:
+ (content isString
+ ifTrue: [ content printString ]
+ ifFalse: [ content name ])
\ No newline at end of file

MODIFY
src/PharoLauncher-Core.package/PhLTreeSelection.class/instance/pathNameFor.on..st
src/PharoLauncher-Core.package/PhLTreeSelection.class/instance/pathNameFor.on..st
private
pathNameFor: treeNodeModel on: writeStream
-
- treeNodeModel parentNode ifNotNil: [ :node |
+ | content |
+ treeNodeModel parentNode
+ ifNotNil: [ :node |
self pathNameFor: node on: writeStream.
writeStream nextPut: $- ].
-
- writeStream nextPutAll: treeNodeModel content name
\ No newline at end of file
+ content := treeNodeModel content.
+ writeStream
+ nextPutAll:
+ (content isString
+ ifTrue: [ content printString ]
+ ifFalse: [ content name ])
\ No newline at end of file

MODIFY
src/PharoLauncher-Core.package/monticello.meta/categories.st
src/PharoLauncher-Core.package/monticello.meta/categories.st
@@ -3,3 +3,4 @@ SystemOrganization addCategory: 'PharoLauncher-Core-Commands'!
SystemOrganization addCategory: 'PharoLauncher-Core-Model'!
SystemOrganization addCategory: #'PharoLauncher-Core-Settings'!
SystemOrganization addCategory: 'PharoLauncher-Core-Settings'!
+gs'!

MODIFY
src/PharoLauncher-Tests-Download.package/PhLVirtualMachineTest.class/instance/testCanDetectExecutablePath.st
src/PharoLauncher-Tests-Download.package/PhLVirtualMachineTest.class/instance/testCanDetectExecutablePath.st
@@ -2,7 +2,7 @@ tests
testCanDetectExecutablePath
"WARNING: this test is Linux specific!"
| vm vmFolder |
- vmFolder := Smalltalk imageDirectory asFileReference / 'pharo-vm'.
+ vmFolder := FileLocator imageDirectory asFileReference / 'pharo-vm'.
vm := PhLVirtualMachine directory: vmFolder.
self
assert: vm executablePath

MODIFY
src/PharoLauncher-Tests-Download.package/PhLVirtualMachineTest.class/instance/testCanDetectVMDirectory.st
src/PharoLauncher-Tests-Download.package/PhLVirtualMachineTest.class/instance/testCanDetectVMDirectory.st
tests
testCanDetectVMDirectory
"WARNING: this test is Linux specific!"
+
| vm |
- vm := PhLVirtualMachine directory: Smalltalk imageDirectory asFileReference / 'pharo-vm'.
+ vm := PhLVirtualMachine directory: FileLocator imageDirectory asFileReference / 'pharo-vm'.
self
assert: vm vmFolderPath
- equals: Smalltalk vmDirectory fullName
\ No newline at end of file
+ equals: FileLocator vmDirectory
\ No newline at end of file

Fix #171 + avoid calls to Smalltalk (use FileLocator instead)