Remove the Webhook settiing of cert-manager
The no-webhook version was removed since 0.15, this flag became
non functional since then and will always install the webhook
MODIFY
docs/configuration-reference/components/cert-manager.md
docs/configuration-reference/components/cert-manager.md
@@ -23,7 +23,6 @@ cert-manager component configuration example:
component "cert-manager" {
email = "example@example.com"
namespace = "cert-manager"
- webhooks = false
}
```
@@ -35,7 +34,6 @@ Table of all the arguments accepted by the component.
|-------------------|----------------------------------------------------------------|:------------:|:------:|:--------:|
| `email` | Email used for certificates to receive expiry notifications. | - | string | true |
| `namespace` | Namespace to deploy the cert-manager into. | cert-manager | string | false |
-| `webhooks` | Controls if webhooks should be deployed. | true | bool | false |
| `service_monitor` | Specifies how metrics can be retrieved from a set of services. | false | bool | false |

MODIFY
pkg/components/cert-manager/component.go
pkg/components/cert-manager/component.go
@@ -35,7 +35,6 @@ const (
type component struct {
Email string `hcl:"email,attr"`
Namespace string `hcl:"namespace,optional"`
- Webhooks bool `hcl:"webhooks,optional"`
ServiceMonitor bool `hcl:"service_monitor,optional"`
}
@@ -45,15 +44,12 @@ type component struct {
func NewConfig() *component {
return &component{
Namespace: "cert-manager",
- Webhooks: true,
ServiceMonitor: false,
}
}
const chartValuesTmpl = `
email: {{.Email}}
-webhook:
- enabled: {{.Webhooks}}
{{ if .ServiceMonitor }}
prometheus:
servicemonitor:
@@ -103,7 +99,7 @@ func (c *component) Metadata() components.Metadata {
Name: c.Namespace,
},
Helm: components.HelmMetadata{
- // Cert-manager registers admission webhooks, so we should wait for the webhook to
+ // cert-manager registers admission webhooks, so we should wait for the webhook to
// become ready before proceeding with installing other components, as it may fail.
// If webhooks are registered with 'failurePolicy: Fail', then kube-apiserver will reject
// creating objects requiring the webhook until the webhook itself becomes ready. So if the

Remove the Webhook settiing of cert-manager

The no-webhook version was removed since 0.15, this flag became
non functional since then and will always install the webhook

Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>