disable reuseAddr by default
Summary:
SO_REUSEADDR for UDP has few corner cases (see
https://www.spinics.net/lists/netdev/msg206437.html)
There's no reason to enable this by default
MODIFY
quic/server/QuicReusePortUDPSocketFactory.h
quic/server/QuicReusePortUDPSocketFactory.h
@@ -21,7 +21,8 @@ class QuicReusePortUDPSocketFactory : public QuicUDPSocketFactory {
override {
auto sock = std::make_unique<folly::AsyncUDPSocket>(evb);
sock->setReusePort(true);
+ sock->setReuseAddr(false);
return sock;
}
};
-}
+} // namespace quic

disable reuseAddr by default

Summary:
SO_REUSEADDR for UDP has few corner cases (see
https://www.spinics.net/lists/netdev/msg206437.html)
There's no reason to enable this by default

Reviewed By: siyengar, lnicco

Differential Revision: D17401298

fbshipit-source-id: 2dc88052e8df52841162107e4f0ee87cb3536517