Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery  Re: ForEach Command struggle..  by
tfrayner (Curate) on Nov 01, 2001 at 05:37 UTC
( #122477=note: print w/ replies, xml ) Need Help??  in reply to
ForEach Command struggle..  Okay, here goes...  First off, you
would really benefit from use strict. I know that gets said a
lot around here, but it's also true. You appear to be using
symbolic references (i.e. terms such as
${$locationold}{online}++ in this context), also Not a Good
Thing, since apart from anything else they're easily mistaken
for hard refs, and it's not obvious what they're pointing to
unless you're very careful.  I've not dug into the code perhaps
as far as I should, but a couple of things stand out. The $place
and $title variables are used only once, suggesting a typo (use
strict helps here. Really. It saves me on a daily basis). Also,
I'm not sure about what you're splitting on. You say it should
be '|+|', but your first split is using 'x' as the delimiter