audio effects: fix heap overflow

Check consistency of effect command reply sizes before
copying to reply address.

Also add null pointer check on reply size.
Also remove unused parameter warning.

Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4
(cherry picked from commit 0f714a464d2425afe00d6450535e763131b40844)

uint32_t BassGetStrength(EffectContext *pContext){

 LVM_ControlParams_t ActiveParams; /* Current control Parameters */
    LVM_ReturnStatus_en     LvmStatus = LVM_SUCCESS; /* Function call status */
 /* Get the current settings */
 LvmStatus = LVM_GetControlParameters(pContext->pBundledContext->hInstance,
 &ActiveParams);

    LVM_ERROR_CHECK(LvmStatus, "LVM_GetControlParameters", "BassGetStrength")
 if(LvmStatus != LVM_SUCCESS) return -EINVAL;


 /* Check that the strength returned matches the strength that was set earlier */
 if(ActiveParams.BE_EffectLevel !=
 (LVM_INT16)((15*pContext->pBundledContext->BassStrengthSaved)/1000)){
        ALOGV("\tLVM_ERROR : BassGetStrength module strength does not match savedStrength %d %d\n",
 ActiveParams.BE_EffectLevel, pContext->pBundledContext->BassStrengthSaved);
 return -EINVAL;
 }

 return pContext->pBundledContext->BassStrengthSaved;
} /* end BassGetStrength */

uint32_t BassGetStrength(EffectContext *pContext){

 LVM_ControlParams_t ActiveParams; /* Current control Parameters */
    LVM_ReturnStatus_en     LvmStatus = LVM_SUCCESS; /* Function call status */
 /* Get the current settings */
 LvmStatus = LVM_GetControlParameters(pContext->pBundledContext->hInstance,
 &ActiveParams);

    LVM_ERROR_CHECK(LvmStatus, "LVM_GetControlParameters", "BassGetStrength")
 if(LvmStatus != LVM_SUCCESS) return -EINVAL;


 /* Check that the strength returned matches the strength that was set earlier */
 if(ActiveParams.BE_EffectLevel !=
 (LVM_INT16)((15*pContext->pBundledContext->BassStrengthSaved)/1000)){
        ALOGV("\tLVM_ERROR : BassGetStrength module strength does not match savedStrength %d %d\n",
 ActiveParams.BE_EffectLevel, pContext->pBundledContext->BassStrengthSaved);
 return -EINVAL;
 }

 return pContext->pBundledContext->BassStrengthSaved;
} /* end BassGetStrength */
