Coverity: Fixing pass by value.
CID=101462, 101458, 101437, 101471, 101467

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/9006023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115257 0039d316-1c4b-4281-b951-d872f2087c98
string16 ExtensionInstallUI::Prompt::GetDialogTitle(
    const Extension* extension) const {
  if (type_ == INSTALL_PROMPT) {
    return l10n_util::GetStringUTF16(extension->is_app() ?
        IDS_EXTENSION_INSTALL_APP_PROMPT_TITLE :
        IDS_EXTENSION_INSTALL_EXTENSION_PROMPT_TITLE);
  } else if (type_ == INLINE_INSTALL_PROMPT) {
    return l10n_util::GetStringFUTF16(
      kTitleIds[type_], l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
  } else {
    return l10n_util::GetStringUTF16(kTitleIds[type_]);
  }
}

string16 ExtensionInstallUI::Prompt::GetDialogTitle(
    const Extension* extension) const {
  if (type_ == INSTALL_PROMPT) {
    return l10n_util::GetStringUTF16(extension->is_app() ?
        IDS_EXTENSION_INSTALL_APP_PROMPT_TITLE :
        IDS_EXTENSION_INSTALL_EXTENSION_PROMPT_TITLE);
  } else if (type_ == INLINE_INSTALL_PROMPT) {
    return l10n_util::GetStringFUTF16(
      kTitleIds[type_], l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
  } else {
    return l10n_util::GetStringUTF16(kTitleIds[type_]);
  }
}
