{"action":"created","comment":{"url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/comments/41978118","id":41978118,"diff_hunk":"@@ -34,14 +34,22 @@ public sealed class ObservableAsPropertyHelper<T> : IHandleObservableErrors, IDi\n         /// changes, typically this will call the ViewModel's\n         /// RaisePropertyChanged method.</param>\n         /// <param name=\"initialValue\">The initial value of the property.</param>\n+        /// <param name=\"subscribeImmediately\">\n+        /// A value indicating, whether the <see cref=\"ObservableAsPropertyHelper{T}\"/> \n+        /// should immediately subscribe to the source <paramref name=\"observable\"/>, or not.\n+        /// \n+        /// If this parameter is <c>false</c>, the <see cref=\"ObservableAsPropertyHelper{T}\"/> \n+        /// subscribes to the <paramref name=\"observable\"/> when the first <see cref=\"Value\"/> is requested.\n+        /// </param>\n         /// <param name=\"scheduler\">The scheduler that the notifications will be\n         /// provided on - this should normally be a Dispatcher-based scheduler\n         /// (and is by default)</param>\n         public ObservableAsPropertyHelper(\n             IObservable<T> observable, \n             Action<T> onChanged, \n-            T initialValue = default(T), \n-            IScheduler scheduler = null) : this(observable, onChanged, null, initialValue, scheduler) {}\n+            T initialValue = default(T),\n+            bool subscribeImmediately = false,","path":"ReactiveUI/ObservableAsPropertyHelper.cs","position":20,"original_position":20,"commit_id":"30ee57af7549a3d61207a07f9c404344c0372307","original_commit_id":"30ee57af7549a3d61207a07f9c404344c0372307","user":{"login":"WilkaH","id":1788792,"avatar_url":"https://avatars.githubusercontent.com/u/1788792?v=3","gravatar_id":"","url":"https://api.github.com/users/WilkaH","html_url":"https://github.com/WilkaH","followers_url":"https://api.github.com/users/WilkaH/followers","following_url":"https://api.github.com/users/WilkaH/following{/other_user}","gists_url":"https://api.github.com/users/WilkaH/gists{/gist_id}","starred_url":"https://api.github.com/users/WilkaH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilkaH/subscriptions","organizations_url":"https://api.github.com/users/WilkaH/orgs","repos_url":"https://api.github.com/users/WilkaH/repos","events_url":"https://api.github.com/users/WilkaH/events{/privacy}","received_events_url":"https://api.github.com/users/WilkaH/received_events","type":"User","site_admin":false},"body":"Inserting `subscribeImmediately` here, rather than adding at the end does mean it'll break any code expecting this position to be a scheduler. I know breaking changes are acceptable in a major version bump, but is passing true here going to be more likely than wanting to specify a scheduler?\r\n\r\nIt might be worth adding this ctor as an overload, so we keep the scheduler at position 4 as well as adding this new flag.\r\n\r\nThe same comments apply to `ToProperty(..)`","created_at":"2015-10-14T10:36:47Z","updated_at":"2015-10-14T10:36:47Z","html_url":"https://github.com/reactiveui/ReactiveUI/pull/969#discussion_r41978118","pull_request_url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969","_links":{"self":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/comments/41978118"},"html":{"href":"https://github.com/reactiveui/ReactiveUI/pull/969#discussion_r41978118"},"pull_request":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969"}}},"pull_request":{"url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969","id":47634956,"html_url":"https://github.com/reactiveui/ReactiveUI/pull/969","diff_url":"https://github.com/reactiveui/ReactiveUI/pull/969.diff","patch_url":"https://github.com/reactiveui/ReactiveUI/pull/969.patch","issue_url":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/969","number":969,"state":"open","locked":false,"title":"[RFC] Add the \"subscribeImmediately\" parameter to the ObservableAsPropertyHelper class","user":{"login":"flagbug","id":964691,"avatar_url":"https://avatars.githubusercontent.com/u/964691?v=3","gravatar_id":"","url":"https://api.github.com/users/flagbug","html_url":"https://github.com/flagbug","followers_url":"https://api.github.com/users/flagbug/followers","following_url":"https://api.github.com/users/flagbug/following{/other_user}","gists_url":"https://api.github.com/users/flagbug/gists{/gist_id}","starred_url":"https://api.github.com/users/flagbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagbug/subscriptions","organizations_url":"https://api.github.com/users/flagbug/orgs","repos_url":"https://api.github.com/users/flagbug/repos","events_url":"https://api.github.com/users/flagbug/events{/privacy}","received_events_url":"https://api.github.com/users/flagbug/received_events","type":"User","site_admin":false},"body":"When this parameter is set to true, the ObservableAsPropertyHelper\r\nimmediately subscribes to the source sequence.","created_at":"2015-10-14T09:17:47Z","updated_at":"2015-10-14T10:36:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68f39c5c93aae775effe95f129ad83d8b85b6e45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969/commits","review_comments_url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969/comments","review_comment_url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/969/comments","statuses_url":"https://api.github.com/repos/reactiveui/ReactiveUI/statuses/30ee57af7549a3d61207a07f9c404344c0372307","head":{"label":"flagbug:oaph-subscribe-immediately","ref":"oaph-subscribe-immediately","sha":"30ee57af7549a3d61207a07f9c404344c0372307","user":{"login":"flagbug","id":964691,"avatar_url":"https://avatars.githubusercontent.com/u/964691?v=3","gravatar_id":"","url":"https://api.github.com/users/flagbug","html_url":"https://github.com/flagbug","followers_url":"https://api.github.com/users/flagbug/followers","following_url":"https://api.github.com/users/flagbug/following{/other_user}","gists_url":"https://api.github.com/users/flagbug/gists{/gist_id}","starred_url":"https://api.github.com/users/flagbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagbug/subscriptions","organizations_url":"https://api.github.com/users/flagbug/orgs","repos_url":"https://api.github.com/users/flagbug/repos","events_url":"https://api.github.com/users/flagbug/events{/privacy}","received_events_url":"https://api.github.com/users/flagbug/received_events","type":"User","site_admin":false},"repo":{"id":16869554,"name":"ReactiveUI","full_name":"flagbug/ReactiveUI","owner":{"login":"flagbug","id":964691,"avatar_url":"https://avatars.githubusercontent.com/u/964691?v=3","gravatar_id":"","url":"https://api.github.com/users/flagbug","html_url":"https://github.com/flagbug","followers_url":"https://api.github.com/users/flagbug/followers","following_url":"https://api.github.com/users/flagbug/following{/other_user}","gists_url":"https://api.github.com/users/flagbug/gists{/gist_id}","starred_url":"https://api.github.com/users/flagbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagbug/subscriptions","organizations_url":"https://api.github.com/users/flagbug/orgs","repos_url":"https://api.github.com/users/flagbug/repos","events_url":"https://api.github.com/users/flagbug/events{/privacy}","received_events_url":"https://api.github.com/users/flagbug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flagbug/ReactiveUI","description":"An MVVM framework for .NET that integrates the Reactive Extensions (Rx) framework","fork":true,"url":"https://api.github.com/repos/flagbug/ReactiveUI","forks_url":"https://api.github.com/repos/flagbug/ReactiveUI/forks","keys_url":"https://api.github.com/repos/flagbug/ReactiveUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flagbug/ReactiveUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flagbug/ReactiveUI/teams","hooks_url":"https://api.github.com/repos/flagbug/ReactiveUI/hooks","issue_events_url":"https://api.github.com/repos/flagbug/ReactiveUI/issues/events{/number}","events_url":"https://api.github.com/repos/flagbug/ReactiveUI/events","assignees_url":"https://api.github.com/repos/flagbug/ReactiveUI/assignees{/user}","branches_url":"https://api.github.com/repos/flagbug/ReactiveUI/branches{/branch}","tags_url":"https://api.github.com/repos/flagbug/ReactiveUI/tags","blobs_url":"https://api.github.com/repos/flagbug/ReactiveUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flagbug/ReactiveUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flagbug/ReactiveUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/flagbug/ReactiveUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flagbug/ReactiveUI/statuses/{sha}","languages_url":"https://api.github.com/repos/flagbug/ReactiveUI/languages","stargazers_url":"https://api.github.com/repos/flagbug/ReactiveUI/stargazers","contributors_url":"https://api.github.com/repos/flagbug/ReactiveUI/contributors","subscribers_url":"https://api.github.com/repos/flagbug/ReactiveUI/subscribers","subscription_url":"https://api.github.com/repos/flagbug/ReactiveUI/subscription","commits_url":"https://api.github.com/repos/flagbug/ReactiveUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/flagbug/ReactiveUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/flagbug/ReactiveUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/flagbug/ReactiveUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/flagbug/ReactiveUI/contents/{+path}","compare_url":"https://api.github.com/repos/flagbug/ReactiveUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flagbug/ReactiveUI/merges","archive_url":"https://api.github.com/repos/flagbug/ReactiveUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flagbug/ReactiveUI/downloads","issues_url":"https://api.github.com/repos/flagbug/ReactiveUI/issues{/number}","pulls_url":"https://api.github.com/repos/flagbug/ReactiveUI/pulls{/number}","milestones_url":"https://api.github.com/repos/flagbug/ReactiveUI/milestones{/number}","notifications_url":"https://api.github.com/repos/flagbug/ReactiveUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flagbug/ReactiveUI/labels{/name}","releases_url":"https://api.github.com/repos/flagbug/ReactiveUI/releases{/id}","created_at":"2014-02-15T19:07:41Z","updated_at":"2015-06-02T16:32:05Z","pushed_at":"2015-10-14T09:16:52Z","git_url":"git://github.com/flagbug/ReactiveUI.git","ssh_url":"git@github.com:flagbug/ReactiveUI.git","clone_url":"https://github.com/flagbug/ReactiveUI.git","svn_url":"https://github.com/flagbug/ReactiveUI","homepage":"http://www.reactiveui.net","size":70388,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"rxui6-master"}},"base":{"label":"reactiveui:rxui7-master","ref":"rxui7-master","sha":"b83995062c1f50bad01d9a6e644fc1f2b1d28308","user":{"login":"reactiveui","id":2327577,"avatar_url":"https://avatars.githubusercontent.com/u/2327577?v=3","gravatar_id":"","url":"https://api.github.com/users/reactiveui","html_url":"https://github.com/reactiveui","followers_url":"https://api.github.com/users/reactiveui/followers","following_url":"https://api.github.com/users/reactiveui/following{/other_user}","gists_url":"https://api.github.com/users/reactiveui/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveui/subscriptions","organizations_url":"https://api.github.com/users/reactiveui/orgs","repos_url":"https://api.github.com/users/reactiveui/repos","events_url":"https://api.github.com/users/reactiveui/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveui/received_events","type":"Organization","site_admin":false},"repo":{"id":715082,"name":"ReactiveUI","full_name":"reactiveui/ReactiveUI","owner":{"login":"reactiveui","id":2327577,"avatar_url":"https://avatars.githubusercontent.com/u/2327577?v=3","gravatar_id":"","url":"https://api.github.com/users/reactiveui","html_url":"https://github.com/reactiveui","followers_url":"https://api.github.com/users/reactiveui/followers","following_url":"https://api.github.com/users/reactiveui/following{/other_user}","gists_url":"https://api.github.com/users/reactiveui/gists{/gist_id}","starred_url":"https://api.github.com/users/reactiveui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactiveui/subscriptions","organizations_url":"https://api.github.com/users/reactiveui/orgs","repos_url":"https://api.github.com/users/reactiveui/repos","events_url":"https://api.github.com/users/reactiveui/events{/privacy}","received_events_url":"https://api.github.com/users/reactiveui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactiveui/ReactiveUI","description":"A MVVM framework that integrates with the Reactive Extensions for .NET to create elegant, testable User Interfaces that run on any mobile or desktop platform. Supports Xamarin.iOS, Xamarin.Android, Xamarin.Mac, WPF, Windows Forms, Windows Phone 8 and Windows Store apps.","fork":false,"url":"https://api.github.com/repos/reactiveui/ReactiveUI","forks_url":"https://api.github.com/repos/reactiveui/ReactiveUI/forks","keys_url":"https://api.github.com/repos/reactiveui/ReactiveUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactiveui/ReactiveUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactiveui/ReactiveUI/teams","hooks_url":"https://api.github.com/repos/reactiveui/ReactiveUI/hooks","issue_events_url":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/events{/number}","events_url":"https://api.github.com/repos/reactiveui/ReactiveUI/events","assignees_url":"https://api.github.com/repos/reactiveui/ReactiveUI/assignees{/user}","branches_url":"https://api.github.com/repos/reactiveui/ReactiveUI/branches{/branch}","tags_url":"https://api.github.com/repos/reactiveui/ReactiveUI/tags","blobs_url":"https://api.github.com/repos/reactiveui/ReactiveUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactiveui/ReactiveUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactiveui/ReactiveUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactiveui/ReactiveUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactiveui/ReactiveUI/statuses/{sha}","languages_url":"https://api.github.com/repos/reactiveui/ReactiveUI/languages","stargazers_url":"https://api.github.com/repos/reactiveui/ReactiveUI/stargazers","contributors_url":"https://api.github.com/repos/reactiveui/ReactiveUI/contributors","subscribers_url":"https://api.github.com/repos/reactiveui/ReactiveUI/subscribers","subscription_url":"https://api.github.com/repos/reactiveui/ReactiveUI/subscription","commits_url":"https://api.github.com/repos/reactiveui/ReactiveUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactiveui/ReactiveUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactiveui/ReactiveUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactiveui/ReactiveUI/contents/{+path}","compare_url":"https://api.github.com/repos/reactiveui/ReactiveUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactiveui/ReactiveUI/merges","archive_url":"https://api.github.com/repos/reactiveui/ReactiveUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactiveui/ReactiveUI/downloads","issues_url":"https://api.github.com/repos/reactiveui/ReactiveUI/issues{/number}","pulls_url":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls{/number}","milestones_url":"https://api.github.com/repos/reactiveui/ReactiveUI/milestones{/number}","notifications_url":"https://api.github.com/repos/reactiveui/ReactiveUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactiveui/ReactiveUI/labels{/name}","releases_url":"https://api.github.com/repos/reactiveui/ReactiveUI/releases{/id}","created_at":"2010-06-11T05:24:29Z","updated_at":"2015-10-14T09:09:51Z","pushed_at":"2015-10-14T09:17:48Z","git_url":"git://github.com/reactiveui/ReactiveUI.git","ssh_url":"git@github.com:reactiveui/ReactiveUI.git","clone_url":"https://github.com/reactiveui/ReactiveUI.git","svn_url":"https://github.com/reactiveui/ReactiveUI","homepage":"http://www.reactiveui.net","size":86794,"stargazers_count":1788,"watchers_count":1788,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":120,"forks":408,"open_issues":120,"watchers":1788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969"},"html":{"href":"https://github.com/reactiveui/ReactiveUI/pull/969"},"issue":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/969"},"comments":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/issues/969/comments"},"review_comments":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969/comments"},"review_comment":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/pulls/969/commits"},"statuses":{"href":"https://api.github.com/repos/reactiveui/ReactiveUI/statuses/30ee57af7549a3d61207a07f9c404344c0372307"}}}}