{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/39628995","id":39628995,"diff_hunk":"@@ -243,6 +243,12 @@ static int checkout_action_common(\n \t\tif (delta->new_file.mode == GIT_FILEMODE_LINK && wd != NULL)\n \t\t\t*action |= CHECKOUT_ACTION__REMOVE;\n \n+\t\t/* if the file is on disk and doesn't match our mode, force update */\n+\t\tif (wd &&\n+\t\t\tGIT_PERMS_IS_EXEC(wd->mode) ^\n+\t\t\tGIT_PERMS_IS_EXEC(delta->new_file.mode))","path":"src/checkout.c","position":7,"original_position":7,"commit_id":"7fee2ecfe369e712dd1f4eecd2d2914e5b91747a","original_commit_id":"7fee2ecfe369e712dd1f4eecd2d2914e5b91747a","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"absolutely zero advantage.  yay for 2am pull requests.","created_at":"2015-09-16T13:31:53Z","updated_at":"2015-09-16T13:31:53Z","html_url":"https://github.com/libgit2/libgit2/pull/3429#discussion_r39628995","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3429","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/39628995"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3429#discussion_r39628995"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3429"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3429","id":45133609,"html_url":"https://github.com/libgit2/libgit2/pull/3429","diff_url":"https://github.com/libgit2/libgit2/pull/3429.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3429.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3429","number":3429,"state":"open","locked":false,"title":"Checkout: handle mode changes","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"As reported in #3158, we do not quite handle mode changes correctly in checkout.  We will always set execute bits properly, but we fail to *unset* execute bits.\r\n\r\nThis ports the unit tests that were mentioned in #3158.  It does not take the fix that was mentioned in that issue, though, as it was heavy-handed.  Instead, we simply delete the old file and let `p_open` set the mode for us and drop any notion of trying to `chmod`.  (This is handy since we were not providing the umask properly, nor is there a sane way to query the umask in a thread safe manner across architectures.)  \r\n\r\nFixes #3158 \r\n","created_at":"2015-09-16T05:50:21Z","updated_at":"2015-09-16T13:31:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ca4466db51575df2541b0d9383022802b7c33b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3429/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3429/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3429/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/7fee2ecfe369e712dd1f4eecd2d2914e5b91747a","head":{"label":"ethomson:checkout_chmod","ref":"checkout_chmod","sha":"7fee2ecfe369e712dd1f4eecd2d2914e5b91747a","user":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"repo":{"id":6315414,"name":"libgit2","full_name":"ethomson/libgit2","owner":{"login":"ethomson","id":1130014,"avatar_url":"https://avatars.githubusercontent.com/u/1130014?v=3","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethomson/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/ethomson/libgit2","forks_url":"https://api.github.com/repos/ethomson/libgit2/forks","keys_url":"https://api.github.com/repos/ethomson/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethomson/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethomson/libgit2/teams","hooks_url":"https://api.github.com/repos/ethomson/libgit2/hooks","issue_events_url":"https://api.github.com/repos/ethomson/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/ethomson/libgit2/events","assignees_url":"https://api.github.com/repos/ethomson/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/ethomson/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/ethomson/libgit2/tags","blobs_url":"https://api.github.com/repos/ethomson/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethomson/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethomson/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethomson/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethomson/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/ethomson/libgit2/languages","stargazers_url":"https://api.github.com/repos/ethomson/libgit2/stargazers","contributors_url":"https://api.github.com/repos/ethomson/libgit2/contributors","subscribers_url":"https://api.github.com/repos/ethomson/libgit2/subscribers","subscription_url":"https://api.github.com/repos/ethomson/libgit2/subscription","commits_url":"https://api.github.com/repos/ethomson/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethomson/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethomson/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethomson/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethomson/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/ethomson/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethomson/libgit2/merges","archive_url":"https://api.github.com/repos/ethomson/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethomson/libgit2/downloads","issues_url":"https://api.github.com/repos/ethomson/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/ethomson/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/ethomson/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/ethomson/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethomson/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/ethomson/libgit2/releases{/id}","created_at":"2012-10-21T00:45:28Z","updated_at":"2015-03-30T13:32:43Z","pushed_at":"2015-09-16T05:46:46Z","git_url":"git://github.com/ethomson/libgit2.git","ssh_url":"git@github.com:ethomson/libgit2.git","clone_url":"https://github.com/ethomson/libgit2.git","svn_url":"https://github.com/ethomson/libgit2","homepage":"http://libgit2.github.com","size":23950,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"b1f6c0b6fa8bbb0c9c11a4d09c731a7f7c311558","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","created_at":"2010-09-10T16:17:48Z","updated_at":"2015-09-16T09:49:04Z","pushed_at":"2015-09-16T05:50:21Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":124368,"stargazers_count":5107,"watchers_count":5107,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1219,"mirror_url":null,"open_issues_count":125,"forks":1219,"open_issues":125,"watchers":5107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3429"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3429"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3429"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3429/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3429/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3429/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/7fee2ecfe369e712dd1f4eecd2d2914e5b91747a"}}}}