{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/1146","labels_url":"https://api.github.com/repos/prometheus/prometheus/issues/1146/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/1146/comments","events_url":"https://api.github.com/repos/prometheus/prometheus/issues/1146/events","html_url":"https://github.com/prometheus/prometheus/pull/1146","id":109899304,"number":1146,"title":"Add a \"reload configurations\" button on status page.","user":{"login":"roymiloh","id":4408911,"avatar_url":"https://avatars.githubusercontent.com/u/4408911?v=3","gravatar_id":"","url":"https://api.github.com/users/roymiloh","html_url":"https://github.com/roymiloh","followers_url":"https://api.github.com/users/roymiloh/followers","following_url":"https://api.github.com/users/roymiloh/following{/other_user}","gists_url":"https://api.github.com/users/roymiloh/gists{/gist_id}","starred_url":"https://api.github.com/users/roymiloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roymiloh/subscriptions","organizations_url":"https://api.github.com/users/roymiloh/orgs","repos_url":"https://api.github.com/users/roymiloh/repos","events_url":"https://api.github.com/users/roymiloh/events{/privacy}","received_events_url":"https://api.github.com/users/roymiloh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T22:27:23Z","updated_at":"2015-10-06T17:44:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/1146","html_url":"https://github.com/prometheus/prometheus/pull/1146","diff_url":"https://github.com/prometheus/prometheus/pull/1146.diff","patch_url":"https://github.com/prometheus/prometheus/pull/1146.patch"},"body":"Currently the route always returns 200, due independent gorotine which reloads the configurations.\r\n\r\nShould we have another channel that signals the caller goroutine when [`reloadConfig`](https://github.com/prometheus/prometheus/blob/master/cmd/prometheus/main.go#L131) terminates?\r\n\r\nI'll appreciate it if someone with permissions creates a new branch for that feature so I can work with.\r\n\r\nP.S I've also created a new section for js files (at the end of the body, [it's better](http://stackoverflow.com/a/24070373)), not used yet but in status page."},"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/issues/comments/145942560","html_url":"https://github.com/prometheus/prometheus/pull/1146#issuecomment-145942560","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/1146","id":145942560,"user":{"login":"roymiloh","id":4408911,"avatar_url":"https://avatars.githubusercontent.com/u/4408911?v=3","gravatar_id":"","url":"https://api.github.com/users/roymiloh","html_url":"https://github.com/roymiloh","followers_url":"https://api.github.com/users/roymiloh/followers","following_url":"https://api.github.com/users/roymiloh/following{/other_user}","gists_url":"https://api.github.com/users/roymiloh/gists{/gist_id}","starred_url":"https://api.github.com/users/roymiloh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roymiloh/subscriptions","organizations_url":"https://api.github.com/users/roymiloh/orgs","repos_url":"https://api.github.com/users/roymiloh/repos","events_url":"https://api.github.com/users/roymiloh/events{/privacy}","received_events_url":"https://api.github.com/users/roymiloh/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T17:44:46Z","updated_at":"2015-10-06T17:44:46Z","body":"Definitely :+1: \r\n\r\nThanks for reviewing. My thoughts on this goroutine are clear, `reloadConfig` already returns an indication - why not using it?"}}