{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1","id":43529025,"html_url":"https://github.com/kwoxer/Arda-Maps/pull/1","diff_url":"https://github.com/kwoxer/Arda-Maps/pull/1.diff","patch_url":"https://github.com/kwoxer/Arda-Maps/pull/1.patch","issue_url":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/1","number":1,"state":"closed","locked":false,"title":"Merged with version v3.0 (47b4dc) ","user":{"login":"cool-Blue","id":8417135,"avatar_url":"https://avatars.githubusercontent.com/u/8417135?v=3","gravatar_id":"","url":"https://api.github.com/users/cool-Blue","html_url":"https://github.com/cool-Blue","followers_url":"https://api.github.com/users/cool-Blue/followers","following_url":"https://api.github.com/users/cool-Blue/following{/other_user}","gists_url":"https://api.github.com/users/cool-Blue/gists{/gist_id}","starred_url":"https://api.github.com/users/cool-Blue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cool-Blue/subscriptions","organizations_url":"https://api.github.com/users/cool-Blue/orgs","repos_url":"https://api.github.com/users/cool-Blue/repos","events_url":"https://api.github.com/users/cool-Blue/events{/privacy}","received_events_url":"https://api.github.com/users/cool-Blue/received_events","type":"User","site_admin":false},"body":"Hi, sorry for the delay, I was busy with other stuff.\r\nThis version has all your later changes and fixes the bugs you saw.  They were happening in screens other than familytree and were due to familytree event listeners not being switched off.  I had added a listener to detect when the info panel is activated and this was firing when you click on a map region.  Now fixed.\r\n\r\nDetailed logging of the issues are in [my old repo](https://github.com/cool-Blue/SO-Questions/issues), these are all closed out by this release.  I'll close that repo later and use my fork of yours in future.\r\n\r\nI have done basic testing but please confirm that it works the way you want and let me know otherwise.\r\n\r\n--------------------\r\n## Release Notes ##\r\n\r\n>_note: add ?w=1 to the end of the url when viewing difs, it will suppress formatting changes!_\r\n> e.g. https://github.com/kwoxer/Arda-Maps/pull/1/files?w=1\r\n\r\n### info.css\r\n- added inforelations ul style\r\n\r\n### info.js\r\n#### Theme\r\n  - add an event to signal changes in width of the info window\r\n     this is to allow family tree to adjust the center of it's graph\r\n- wrapped in infoState object\r\n- added an events object (so far only includes widthChange\r\n  function toggle\r\n  - added to encapsulate #infobutton.click behaviour\r\n  - also emits the widthChange event\r\n- moved #infobutton.click code into toggle\r\n  function width\r\n  - added\r\n  return width, show and events. events also bound directly to the return object\r\n\r\nfamilytree\r\n  Theme\r\n  - When a search list entry is clicked, highlight and center the node\r\n  - Make this the CONTROLLER, eliminate references between orientdb and familytree-d3 all directed through here\r\n  - Listen for graph_init event from familytree-d3 and init width change listener for infoState\r\n\r\n### orientdb.js\r\n#### Theme\r\n - Make this the MODEL and all interaction via the CONTROLLER, no reference needed for familytree-d3\r\n - Use d3.map to manage link tables on the nodes instead of link counting\r\n   (this is to support future communications between nodes and links)\r\n - Allow for asynchronous fetches for single nodes, fetches are staged and then later retrieved\r\n - Simplified interface with info.js using infoState object\r\n - Add asynchronous get for updating relationships in the info panel\r\n   (TODO add relationsPanel property to infoState)\r\n - Fixed a bug in the locations update for the info panel\r\n   (TODO add locationsPanel property to infoState)\r\n - Added generalise list management function\r\n   (TODO use this for all lists and move management code to infoState)\r\n\r\n### familytree-d3.js\r\n#### Theme\r\n  - Make this a VIEW object and send all signalling via the CONTROLLER\r\n  - Add behaviour to center a selected node and highlight it\r\n  - Encapsulate force state and behaviour in fdg\r\n  - Eliminate hard references to the parent object (familytree)\r\n  - Removed all unnecessary properties exposed on familytree\r\n  - Moved all zoom and drag management into zoomableSVG\r\n  - Expose internal state and behaviour by direct binding onto fdg and family tree (use d3.rebind)\r\n  - Add start, end and progress events for force, emitted from tick\r\n  - Eliminate switch statements, use hash tables instead\r\n  - Eliminate the need to access familytree events via .events, bind directly onto famillytree\r\n\r\n### index.html\r\n- set version to 3.a\r\n- moved info.js above orientdb.js","created_at":"2015-08-27T15:11:50Z","updated_at":"2015-08-29T08:59:23Z","closed_at":"2015-08-29T08:59:23Z","merged_at":"2015-08-29T08:59:23Z","merge_commit_sha":"4368f05f0a55ebf56b6b8b51fe770a088189d865","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/1/comments","statuses_url":"https://api.github.com/repos/kwoxer/Arda-Maps/statuses/11214d90a3cfccc45a9fc0f9e556fe0dc2a5b928","head":{"label":"cool-Blue:master","ref":"master","sha":"11214d90a3cfccc45a9fc0f9e556fe0dc2a5b928","user":{"login":"cool-Blue","id":8417135,"avatar_url":"https://avatars.githubusercontent.com/u/8417135?v=3","gravatar_id":"","url":"https://api.github.com/users/cool-Blue","html_url":"https://github.com/cool-Blue","followers_url":"https://api.github.com/users/cool-Blue/followers","following_url":"https://api.github.com/users/cool-Blue/following{/other_user}","gists_url":"https://api.github.com/users/cool-Blue/gists{/gist_id}","starred_url":"https://api.github.com/users/cool-Blue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cool-Blue/subscriptions","organizations_url":"https://api.github.com/users/cool-Blue/orgs","repos_url":"https://api.github.com/users/cool-Blue/repos","events_url":"https://api.github.com/users/cool-Blue/events{/privacy}","received_events_url":"https://api.github.com/users/cool-Blue/received_events","type":"User","site_admin":false},"repo":{"id":41486155,"name":"Arda-Maps","full_name":"cool-Blue/Arda-Maps","owner":{"login":"cool-Blue","id":8417135,"avatar_url":"https://avatars.githubusercontent.com/u/8417135?v=3","gravatar_id":"","url":"https://api.github.com/users/cool-Blue","html_url":"https://github.com/cool-Blue","followers_url":"https://api.github.com/users/cool-Blue/followers","following_url":"https://api.github.com/users/cool-Blue/following{/other_user}","gists_url":"https://api.github.com/users/cool-Blue/gists{/gist_id}","starred_url":"https://api.github.com/users/cool-Blue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cool-Blue/subscriptions","organizations_url":"https://api.github.com/users/cool-Blue/orgs","repos_url":"https://api.github.com/users/cool-Blue/repos","events_url":"https://api.github.com/users/cool-Blue/events{/privacy}","received_events_url":"https://api.github.com/users/cool-Blue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cool-Blue/Arda-Maps","description":"Interactive Tolkien Maps","fork":true,"url":"https://api.github.com/repos/cool-Blue/Arda-Maps","forks_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/forks","keys_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/teams","hooks_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/hooks","issue_events_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/issues/events{/number}","events_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/events","assignees_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/assignees{/user}","branches_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/branches{/branch}","tags_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/tags","blobs_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/statuses/{sha}","languages_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/languages","stargazers_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/stargazers","contributors_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/contributors","subscribers_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/subscribers","subscription_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/subscription","commits_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/contents/{+path}","compare_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/merges","archive_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/downloads","issues_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/issues{/number}","pulls_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/pulls{/number}","milestones_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/milestones{/number}","notifications_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/labels{/name}","releases_url":"https://api.github.com/repos/cool-Blue/Arda-Maps/releases{/id}","created_at":"2015-08-27T12:47:28Z","updated_at":"2015-08-27T12:47:41Z","pushed_at":"2015-08-27T14:54:02Z","git_url":"git://github.com/cool-Blue/Arda-Maps.git","ssh_url":"git@github.com:cool-Blue/Arda-Maps.git","clone_url":"https://github.com/cool-Blue/Arda-Maps.git","svn_url":"https://github.com/cool-Blue/Arda-Maps","homepage":"http://arda-maps.org/","size":221956,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kwoxer:master","ref":"master","sha":"036e41dfccaf5c6f748b04868b71b8b1b8d94f83","user":{"login":"kwoxer","id":1167229,"avatar_url":"https://avatars.githubusercontent.com/u/1167229?v=3","gravatar_id":"","url":"https://api.github.com/users/kwoxer","html_url":"https://github.com/kwoxer","followers_url":"https://api.github.com/users/kwoxer/followers","following_url":"https://api.github.com/users/kwoxer/following{/other_user}","gists_url":"https://api.github.com/users/kwoxer/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoxer/subscriptions","organizations_url":"https://api.github.com/users/kwoxer/orgs","repos_url":"https://api.github.com/users/kwoxer/repos","events_url":"https://api.github.com/users/kwoxer/events{/privacy}","received_events_url":"https://api.github.com/users/kwoxer/received_events","type":"User","site_admin":false},"repo":{"id":41023287,"name":"Arda-Maps","full_name":"kwoxer/Arda-Maps","owner":{"login":"kwoxer","id":1167229,"avatar_url":"https://avatars.githubusercontent.com/u/1167229?v=3","gravatar_id":"","url":"https://api.github.com/users/kwoxer","html_url":"https://github.com/kwoxer","followers_url":"https://api.github.com/users/kwoxer/followers","following_url":"https://api.github.com/users/kwoxer/following{/other_user}","gists_url":"https://api.github.com/users/kwoxer/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoxer/subscriptions","organizations_url":"https://api.github.com/users/kwoxer/orgs","repos_url":"https://api.github.com/users/kwoxer/repos","events_url":"https://api.github.com/users/kwoxer/events{/privacy}","received_events_url":"https://api.github.com/users/kwoxer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwoxer/Arda-Maps","description":"Interactive Tolkien Maps","fork":false,"url":"https://api.github.com/repos/kwoxer/Arda-Maps","forks_url":"https://api.github.com/repos/kwoxer/Arda-Maps/forks","keys_url":"https://api.github.com/repos/kwoxer/Arda-Maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwoxer/Arda-Maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwoxer/Arda-Maps/teams","hooks_url":"https://api.github.com/repos/kwoxer/Arda-Maps/hooks","issue_events_url":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/events{/number}","events_url":"https://api.github.com/repos/kwoxer/Arda-Maps/events","assignees_url":"https://api.github.com/repos/kwoxer/Arda-Maps/assignees{/user}","branches_url":"https://api.github.com/repos/kwoxer/Arda-Maps/branches{/branch}","tags_url":"https://api.github.com/repos/kwoxer/Arda-Maps/tags","blobs_url":"https://api.github.com/repos/kwoxer/Arda-Maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwoxer/Arda-Maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwoxer/Arda-Maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwoxer/Arda-Maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwoxer/Arda-Maps/statuses/{sha}","languages_url":"https://api.github.com/repos/kwoxer/Arda-Maps/languages","stargazers_url":"https://api.github.com/repos/kwoxer/Arda-Maps/stargazers","contributors_url":"https://api.github.com/repos/kwoxer/Arda-Maps/contributors","subscribers_url":"https://api.github.com/repos/kwoxer/Arda-Maps/subscribers","subscription_url":"https://api.github.com/repos/kwoxer/Arda-Maps/subscription","commits_url":"https://api.github.com/repos/kwoxer/Arda-Maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwoxer/Arda-Maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwoxer/Arda-Maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwoxer/Arda-Maps/contents/{+path}","compare_url":"https://api.github.com/repos/kwoxer/Arda-Maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwoxer/Arda-Maps/merges","archive_url":"https://api.github.com/repos/kwoxer/Arda-Maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwoxer/Arda-Maps/downloads","issues_url":"https://api.github.com/repos/kwoxer/Arda-Maps/issues{/number}","pulls_url":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls{/number}","milestones_url":"https://api.github.com/repos/kwoxer/Arda-Maps/milestones{/number}","notifications_url":"https://api.github.com/repos/kwoxer/Arda-Maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwoxer/Arda-Maps/labels{/name}","releases_url":"https://api.github.com/repos/kwoxer/Arda-Maps/releases{/id}","created_at":"2015-08-19T08:48:24Z","updated_at":"2015-08-19T20:49:45Z","pushed_at":"2015-08-29T08:59:22Z","git_url":"git://github.com/kwoxer/Arda-Maps.git","ssh_url":"git@github.com:kwoxer/Arda-Maps.git","clone_url":"https://github.com/kwoxer/Arda-Maps.git","svn_url":"https://github.com/kwoxer/Arda-Maps","homepage":"http://arda-maps.org/","size":221956,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1"},"html":{"href":"https://github.com/kwoxer/Arda-Maps/pull/1"},"issue":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/1"},"comments":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kwoxer/Arda-Maps/statuses/11214d90a3cfccc45a9fc0f9e556fe0dc2a5b928"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kwoxer","id":1167229,"avatar_url":"https://avatars.githubusercontent.com/u/1167229?v=3","gravatar_id":"","url":"https://api.github.com/users/kwoxer","html_url":"https://github.com/kwoxer","followers_url":"https://api.github.com/users/kwoxer/followers","following_url":"https://api.github.com/users/kwoxer/following{/other_user}","gists_url":"https://api.github.com/users/kwoxer/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoxer/subscriptions","organizations_url":"https://api.github.com/users/kwoxer/orgs","repos_url":"https://api.github.com/users/kwoxer/repos","events_url":"https://api.github.com/users/kwoxer/events{/privacy}","received_events_url":"https://api.github.com/users/kwoxer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1186,"deletions":992,"changed_files":6}}