{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/34717990","id":34717990,"diff_hunk":"@@ -1,58 +1,63 @@\n # Killer facts about triangles AWW YEAH\n class Triangle\n-\tattr_accessor :side1,:side2,:side3\n-\n-\tdef initialize(side1,side2,side3)\n-\t\t@side1,@side2,@side3 = side1,side2,side3\n-\tend\n-\n-\tdef equilateral()\n-\t\treturn side1 == side2 && side2 == side3\n-\tend\n-\n-\tdef isosceles()\n-\t\treturn [side1,side2,side3].uniq.length == 2\n-\tend\n-\n-\tdef scalene()\n-\t\tunless ! (equilateral || isosceles)\n-\t    false\n-\t  else\n-\t    true\n-\t  end\n-\tend\n-\n-\tdef recite_facts\n-\t\tputs 'This triangle is equilateral!' if equilateral\n-\t\tputs 'This triangle is isosceles! Also, that word is hard to type.' if isosceles \n-\t\tputs 'This triangle is scalene and mathematically boring.' if scalene \n-\n-\t\tangles = self.calculate_angles(side1,side2,side3)\n-\t\tputs 'The angles of this triangle are ' + angles.join(',')\n-\n-\t\tputs 'This triangle is also a right triangle!' if angles.include? 90\n-\t\tputs ''\n-\tend\n-\n-\tdef calculate_angles(a,b,c)\n-\t\tangleA = radians_to_degrees(Math.acos((b**2 + c**2 - a**2) / (2.0 * b * c)))\n-\t\tangleB = radians_to_degrees(Math.acos((a**2 + c**2 - b**2) / (2.0 * a * c)))\n-\t\tangleC = radians_to_degrees(Math.acos((a**2 + b**2 - c**2) / (2.0 * a * b)))\n-\n-\t\treturn [angleA, angleB, angleC]\n-\tend\n-\n-\tdef radians_to_degrees(rads)\n-\t\treturn (rads * 180 / Math::PI).round\n-\tend\n+  attr_accessor :side1, :side2, :side3\n+\n+  def initialize(side1, side2, side3)\n+    @side1 = side1\n+    @side2 = side2\n+    @side3 = side3\n+  end\n+\n+  def equilateral?\n+    [side1, side2, side3].uniq.length == 1\n+  end\n+\n+  def isosceles?\n+    [side1, side2, side3].uniq.length == 2\n+  end\n+\n+  def triangle_type\n+    if equilateral?\n+      'This triangle is equilateral!'\n+    elsif isosceles?\n+      'This triangle is isosceles! Also, that word is hard to type.'\n+    else\n+      'This triangle is scalene and mathematically boring.'\n+    end\n+  end\n+\n+  def recite_facts\n+    puts triangle_type\n+\n+    angles = calculate_angles(side1, side2, side3)\n+\n+    puts 'The angles of this triangle are ' + angles.join(', ')\n+    puts 'This triangle is also a right triangle!' if angles.include?(90)\n+    puts\n+  end\n+\n+  def calculate_angles(a, b, c)\n+    angle_a = calculate_angle(a, b, c)\n+    angle_b = calculate_angle(b, a, c)\n+    angle_c = calculate_angle(c, a, b)\n+    %w(angle_a angle_b angle_c)","path":"triangle_facts/triangle_facts.rb","position":88,"original_position":88,"commit_id":"1a45010170961c1afec558cae0f46101c57f1730","original_commit_id":"1a45010170961c1afec558cae0f46101c57f1730","user":{"login":"djkotowski","id":2326295,"avatar_url":"https://avatars.githubusercontent.com/u/2326295?v=3","gravatar_id":"","url":"https://api.github.com/users/djkotowski","html_url":"https://github.com/djkotowski","followers_url":"https://api.github.com/users/djkotowski/followers","following_url":"https://api.github.com/users/djkotowski/following{/other_user}","gists_url":"https://api.github.com/users/djkotowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djkotowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkotowski/subscriptions","organizations_url":"https://api.github.com/users/djkotowski/orgs","repos_url":"https://api.github.com/users/djkotowski/repos","events_url":"https://api.github.com/users/djkotowski/events{/privacy}","received_events_url":"https://api.github.com/users/djkotowski/received_events","type":"User","site_admin":false},"body":"This doesn't work.  Run the code and check the output.","created_at":"2015-07-15T19:19:48Z","updated_at":"2015-07-15T19:19:48Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/818#discussion_r34717990","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/34717990"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/818#discussion_r34717990"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818","id":40057421,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/818","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/818.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/818.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/818","number":818,"state":"open","locked":false,"title":"Triangle Facts","user":{"login":"ssapra","id":1894216,"avatar_url":"https://avatars.githubusercontent.com/u/1894216?v=3","gravatar_id":"","url":"https://api.github.com/users/ssapra","html_url":"https://github.com/ssapra","followers_url":"https://api.github.com/users/ssapra/followers","following_url":"https://api.github.com/users/ssapra/following{/other_user}","gists_url":"https://api.github.com/users/ssapra/gists{/gist_id}","starred_url":"https://api.github.com/users/ssapra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssapra/subscriptions","organizations_url":"https://api.github.com/users/ssapra/orgs","repos_url":"https://api.github.com/users/ssapra/repos","events_url":"https://api.github.com/users/ssapra/events{/privacy}","received_events_url":"https://api.github.com/users/ssapra/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-15T19:02:38Z","updated_at":"2015-07-15T19:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b34b9be762448d099fc75fc7b14ec8dc7eaf2846","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/818/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/1a45010170961c1afec558cae0f46101c57f1730","head":{"label":"ssapra:master","ref":"master","sha":"1a45010170961c1afec558cae0f46101c57f1730","user":{"login":"ssapra","id":1894216,"avatar_url":"https://avatars.githubusercontent.com/u/1894216?v=3","gravatar_id":"","url":"https://api.github.com/users/ssapra","html_url":"https://github.com/ssapra","followers_url":"https://api.github.com/users/ssapra/followers","following_url":"https://api.github.com/users/ssapra/following{/other_user}","gists_url":"https://api.github.com/users/ssapra/gists{/gist_id}","starred_url":"https://api.github.com/users/ssapra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssapra/subscriptions","organizations_url":"https://api.github.com/users/ssapra/orgs","repos_url":"https://api.github.com/users/ssapra/repos","events_url":"https://api.github.com/users/ssapra/events{/privacy}","received_events_url":"https://api.github.com/users/ssapra/received_events","type":"User","site_admin":false},"repo":{"id":39095853,"name":"level_up_exercises","full_name":"ssapra/level_up_exercises","owner":{"login":"ssapra","id":1894216,"avatar_url":"https://avatars.githubusercontent.com/u/1894216?v=3","gravatar_id":"","url":"https://api.github.com/users/ssapra","html_url":"https://github.com/ssapra","followers_url":"https://api.github.com/users/ssapra/followers","following_url":"https://api.github.com/users/ssapra/following{/other_user}","gists_url":"https://api.github.com/users/ssapra/gists{/gist_id}","starred_url":"https://api.github.com/users/ssapra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssapra/subscriptions","organizations_url":"https://api.github.com/users/ssapra/orgs","repos_url":"https://api.github.com/users/ssapra/repos","events_url":"https://api.github.com/users/ssapra/events{/privacy}","received_events_url":"https://api.github.com/users/ssapra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssapra/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/ssapra/level_up_exercises","forks_url":"https://api.github.com/repos/ssapra/level_up_exercises/forks","keys_url":"https://api.github.com/repos/ssapra/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssapra/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssapra/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/ssapra/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/ssapra/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/ssapra/level_up_exercises/events","assignees_url":"https://api.github.com/repos/ssapra/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/ssapra/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/ssapra/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/ssapra/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssapra/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssapra/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssapra/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssapra/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/ssapra/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/ssapra/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/ssapra/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/ssapra/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/ssapra/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/ssapra/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssapra/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssapra/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssapra/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssapra/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/ssapra/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssapra/level_up_exercises/merges","archive_url":"https://api.github.com/repos/ssapra/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssapra/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/ssapra/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/ssapra/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/ssapra/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/ssapra/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssapra/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/ssapra/level_up_exercises/releases{/id}","created_at":"2015-07-14T19:24:32Z","updated_at":"2015-07-14T19:24:32Z","pushed_at":"2015-07-15T18:58:32Z","git_url":"git://github.com/ssapra/level_up_exercises.git","ssh_url":"git@github.com:ssapra/level_up_exercises.git","clone_url":"https://github.com/ssapra/level_up_exercises.git","svn_url":"https://github.com/ssapra/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":160360,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"057b4969214f82f6a79748501b269e1dc296f49b","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-07-09T21:47:15Z","pushed_at":"2015-07-15T19:02:38Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":160360,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":18,"forks":124,"open_issues":18,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/818"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/818"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/818/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/818/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/1a45010170961c1afec558cae0f46101c57f1730"}}}}