{"comment":{"url":"https://api.github.com/repos/dropwizard/dropwizard/comments/9799652","html_url":"https://github.com/dropwizard/dropwizard/commit/dbe1fe4f631b0d70f2b346be2aed23112e3c3648#commitcomment-9799652","id":9799652,"user":{"login":"arteam","id":1717632,"avatar_url":"https://avatars.githubusercontent.com/u/1717632?v=3","gravatar_id":"","url":"https://api.github.com/users/arteam","html_url":"https://github.com/arteam","followers_url":"https://api.github.com/users/arteam/followers","following_url":"https://api.github.com/users/arteam/following{/other_user}","gists_url":"https://api.github.com/users/arteam/gists{/gist_id}","starred_url":"https://api.github.com/users/arteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arteam/subscriptions","organizations_url":"https://api.github.com/users/arteam/orgs","repos_url":"https://api.github.com/users/arteam/repos","events_url":"https://api.github.com/users/arteam/events{/privacy}","received_events_url":"https://api.github.com/users/arteam/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"dbe1fe4f631b0d70f2b346be2aed23112e3c3648","created_at":"2015-02-18T13:46:13Z","updated_at":"2015-02-18T13:46:13Z","body":"The problem is that `dropwizard-jdbi` and `dropwizard-hibernate` depend on the tomcat-jdbc\r\n[DataSourceFactory] (https://github.com/dropwizard/dropwizard/blob/master/dropwizard-db/src/main/java/io/dropwizard/db/DataSourceFactory.java) implementation. So custom pool implementations should depend on this class also.\r\n\r\nIt would better if `DataSourceFactory` were an interface and the tomcat-jdbc implementation were in a separate module from `dropwizard-db`."}}