{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/37979149","id":37979149,"diff_hunk":"@@ -45,15 +48,16 @@\n \tprivate ModuleLauncher moduleLauncher;\n \n \t@Override\n-\tpublic void run(ApplicationArguments applicationArguments) throws Exception {\n-\t\tString[] launchedModules = moduleLauncherProperties.getModules();\n+\tpublic void run(String... unused) throws Exception {","path":"spring-cloud-stream-module-launcher/src/main/java/org/springframework/cloud/stream/module/launcher/ModuleLauncherRunner.java","position":31,"original_position":31,"commit_id":"65054e2b0e819772db71507592600e6d9d9c0a8c","original_commit_id":"65054e2b0e819772db71507592600e6d9d9c0a8c","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"My point was exactly to showcase the fact that we're not relying on just the command-line args. I'd settle for something that doesn't even have them if I was sure about the lifecycle (notice how I downgraded from ApplicationRunner already).\r\nI can replace this with a comment if that's ok with you","created_at":"2015-08-26T13:14:18Z","updated_at":"2015-08-26T13:14:18Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/110#discussion_r37979149","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/37979149"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/110#discussion_r37979149"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110","id":43391323,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/110","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/110.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/110.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/110","number":110,"state":"open","locked":false,"title":"Use the full Environment for module args","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"This PR does a couple of things:\n* Use the full environment for module arguments lookup, as some environments\nsuch as CF don't allow passing (lengthy) command line args\n* Extract the logic for namespacing those arguments to a dedicated component\nwith 2 methods that are the inverse of each other","created_at":"2015-08-26T11:28:57Z","updated_at":"2015-08-26T13:14:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7a403facd91f81f71caba9316c1c11dbba30b35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/110/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/65054e2b0e819772db71507592600e6d9d9c0a8c","head":{"label":"ericbottard:ModuleArgGeneralization","ref":"ModuleArgGeneralization","sha":"65054e2b0e819772db71507592600e6d9d9c0a8c","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":39128345,"name":"spring-cloud-stream","full_name":"ericbottard/spring-cloud-stream","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/ericbottard/spring-cloud-stream","forks_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-cloud-stream/releases{/id}","created_at":"2015-07-15T09:32:07Z","updated_at":"2015-07-15T09:32:08Z","pushed_at":"2015-08-26T11:29:23Z","git_url":"git://github.com/ericbottard/spring-cloud-stream.git","ssh_url":"git@github.com:ericbottard/spring-cloud-stream.git","clone_url":"https://github.com/ericbottard/spring-cloud-stream.git","svn_url":"https://github.com/ericbottard/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-streams/","size":1699,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"76633720624de1e1142835b04a5eba5a8a634512","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Messaging Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","created_at":"2015-07-08T15:51:38Z","updated_at":"2015-08-12T17:56:32Z","pushed_at":"2015-08-26T11:29:23Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream/","size":2786,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":10,"forks":15,"open_issues":10,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/110"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/110"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/65054e2b0e819772db71507592600e6d9d9c0a8c"}}}}