{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38703433","id":38703433,"diff_hunk":"@@ -0,0 +1,15 @@\n+SET @s = (SELECT IF(\n+    (SELECT COUNT(*)\n+        FROM INFORMATION_SCHEMA.COLUMNS\n+        WHERE table_name = 'realmlist'\n+        AND table_schema = DATABASE()\n+        AND column_name = 'address6'\n+    ) > 0,\n+    \"SELECT 1\",\n+    \"ALTER TABLE realmlist ADD address6 VARCHAR(255) NOT NULL DEFAULT ''\"\n+));\n+\n+PREPARE stmt FROM @s;\n+EXECUTE stmt;\n+DEALLOCATE PREPARE stmt;\n+","path":"sql/updates/auth/2015_09_02_00_auth.sql","position":15,"original_position":15,"commit_id":"6a8cf0d1b51e4f643eb97be04f7d0197027cbb7d","original_commit_id":"6a8cf0d1b51e4f643eb97be04f7d0197027cbb7d","user":{"login":"DDuarte","id":530940,"avatar_url":"https://avatars.githubusercontent.com/u/530940?v=3","gravatar_id":"","url":"https://api.github.com/users/DDuarte","html_url":"https://github.com/DDuarte","followers_url":"https://api.github.com/users/DDuarte/followers","following_url":"https://api.github.com/users/DDuarte/following{/other_user}","gists_url":"https://api.github.com/users/DDuarte/gists{/gist_id}","starred_url":"https://api.github.com/users/DDuarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDuarte/subscriptions","organizations_url":"https://api.github.com/users/DDuarte/orgs","repos_url":"https://api.github.com/users/DDuarte/repos","events_url":"https://api.github.com/users/DDuarte/events{/privacy}","received_events_url":"https://api.github.com/users/DDuarte/received_events","type":"User","site_admin":false},"body":"Any reason not to execute the query directly? Also missing change in auth_database.sql file","created_at":"2015-09-03T22:20:00Z","updated_at":"2015-09-03T22:20:00Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15422#discussion_r38703433","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/38703433"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15422#discussion_r38703433"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422","id":44164276,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/15422","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15422.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15422.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15422","number":15422,"state":"open","locked":false,"title":"[WIP] ipv6 support for bnetserver and worldserver","user":{"login":"TonyHoyle","id":263573,"avatar_url":"https://avatars.githubusercontent.com/u/263573?v=3","gravatar_id":"","url":"https://api.github.com/users/TonyHoyle","html_url":"https://github.com/TonyHoyle","followers_url":"https://api.github.com/users/TonyHoyle/followers","following_url":"https://api.github.com/users/TonyHoyle/following{/other_user}","gists_url":"https://api.github.com/users/TonyHoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyHoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyHoyle/subscriptions","organizations_url":"https://api.github.com/users/TonyHoyle/orgs","repos_url":"https://api.github.com/users/TonyHoyle/repos","events_url":"https://api.github.com/users/TonyHoyle/events{/privacy}","received_events_url":"https://api.github.com/users/TonyHoyle/received_events","type":"User","site_admin":false},"body":"This is ipv6 support.  It works on my system and should be OK on non-ipv6 systems - I've written it such that it avoids touching ipv6 code if it's not configured to do so (to avoid nasties like partially configured routing and such).\r\n\r\nTo enable ipv6 on the worldserver, just set address6 in auth.realmlist (and of course enable it on the client).\r\n\r\nThere's also support for ipv6 the bnetserver although the current blizzzard client always connects over ipv4 for this even when a good ipv6 connection is available.. I anticipate they'll add it soon anyway and it's not many extra lines.\r\n\r\nTo enable it in the bnetserver change the BindIP to '::' or '::1' depending on whether you're using a global or loopback address.\r\n\r\nTodo: \r\n\r\n* Test on machines with no ipv6/no v6 routing.  I've tried to code defensively but there's no substitute for a proper test\r\n* Test on Windows... unfortunately I have no easy way to compile on that platform.\r\n","created_at":"2015-09-03T22:16:25Z","updated_at":"2015-09-03T22:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce3caee73b85c9b094ae890e3956e4573ca6253a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15422/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/6a8cf0d1b51e4f643eb97be04f7d0197027cbb7d","head":{"label":"TonyHoyle:6.x","ref":"6.x","sha":"6a8cf0d1b51e4f643eb97be04f7d0197027cbb7d","user":{"login":"TonyHoyle","id":263573,"avatar_url":"https://avatars.githubusercontent.com/u/263573?v=3","gravatar_id":"","url":"https://api.github.com/users/TonyHoyle","html_url":"https://github.com/TonyHoyle","followers_url":"https://api.github.com/users/TonyHoyle/followers","following_url":"https://api.github.com/users/TonyHoyle/following{/other_user}","gists_url":"https://api.github.com/users/TonyHoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyHoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyHoyle/subscriptions","organizations_url":"https://api.github.com/users/TonyHoyle/orgs","repos_url":"https://api.github.com/users/TonyHoyle/repos","events_url":"https://api.github.com/users/TonyHoyle/events{/privacy}","received_events_url":"https://api.github.com/users/TonyHoyle/received_events","type":"User","site_admin":false},"repo":{"id":41824153,"name":"TrinityCore","full_name":"TonyHoyle/TrinityCore","owner":{"login":"TonyHoyle","id":263573,"avatar_url":"https://avatars.githubusercontent.com/u/263573?v=3","gravatar_id":"","url":"https://api.github.com/users/TonyHoyle","html_url":"https://github.com/TonyHoyle","followers_url":"https://api.github.com/users/TonyHoyle/followers","following_url":"https://api.github.com/users/TonyHoyle/following{/other_user}","gists_url":"https://api.github.com/users/TonyHoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/TonyHoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TonyHoyle/subscriptions","organizations_url":"https://api.github.com/users/TonyHoyle/orgs","repos_url":"https://api.github.com/users/TonyHoyle/repos","events_url":"https://api.github.com/users/TonyHoyle/events{/privacy}","received_events_url":"https://api.github.com/users/TonyHoyle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TonyHoyle/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/TonyHoyle/TrinityCore","forks_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/forks","keys_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/events","assignees_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/merges","archive_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TonyHoyle/TrinityCore/releases{/id}","created_at":"2015-09-02T19:49:50Z","updated_at":"2015-09-02T19:50:04Z","pushed_at":"2015-09-03T22:06:50Z","git_url":"git://github.com/TonyHoyle/TrinityCore.git","ssh_url":"git@github.com:TonyHoyle/TrinityCore.git","clone_url":"https://github.com/TonyHoyle/TrinityCore.git","svn_url":"https://github.com/TonyHoyle/TrinityCore","homepage":"http://www.trinitycore.org","size":372640,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"6.x"}},"base":{"label":"TrinityCore:6.x","ref":"6.x","sha":"8652f4b4de5ed02c89f9db91367125a04ce52dd4","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-09-03T19:17:35Z","pushed_at":"2015-09-03T22:16:25Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":856347,"stargazers_count":2947,"watchers_count":2947,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3088,"mirror_url":null,"open_issues_count":1133,"forks":3088,"open_issues":1133,"watchers":2947,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15422"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15422"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15422/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15422/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/6a8cf0d1b51e4f643eb97be04f7d0197027cbb7d"}}}}