{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/43630737","id":43630737,"diff_hunk":"@@ -32,15 +21,11 @@ void* Host_GetRenderHandle()\n \treturn (void*)(g_main_window->GetRenderWidget()->winId());\n }\n \n-void Host_RequestRenderWindowSize(int w, int h)\n-{\n-\tDRenderWidget* render_widget = g_main_window->GetRenderWidget();\n-\tqApp->postEvent(render_widget, new QResizeEvent(QSize(w, h), render_widget->size()));\n-}\n+void Host_RequestRenderWindowSize(int w, int h) {}\n \n bool Host_RendererHasFocus()\n {\n-\treturn g_main_window->RenderWidgetHasFocus();\n+\treturn g_main_window->GetRenderWidget()->isActiveWindow();","path":"Source/Core/DolphinQt/Host.cpp","position":51,"original_position":51,"commit_id":"0aa6149892b5f23bdbdfe9f0c71c1ce33d22a90f","original_commit_id":"0aa6149892b5f23bdbdfe9f0c71c1ce33d22a90f","user":{"login":"waddlesplash","id":2175324,"avatar_url":"https://avatars.githubusercontent.com/u/2175324?v=3","gravatar_id":"","url":"https://api.github.com/users/waddlesplash","html_url":"https://github.com/waddlesplash","followers_url":"https://api.github.com/users/waddlesplash/followers","following_url":"https://api.github.com/users/waddlesplash/following{/other_user}","gists_url":"https://api.github.com/users/waddlesplash/gists{/gist_id}","starred_url":"https://api.github.com/users/waddlesplash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waddlesplash/subscriptions","organizations_url":"https://api.github.com/users/waddlesplash/orgs","repos_url":"https://api.github.com/users/waddlesplash/repos","events_url":"https://api.github.com/users/waddlesplash/events{/privacy}","received_events_url":"https://api.github.com/users/waddlesplash/received_events","type":"User","site_admin":false},"body":"This doesn't always return true if the RenderWidget is a child of the main window instead of its own window, IME. I could be misremembering that, though.","created_at":"2015-11-02T14:07:12Z","updated_at":"2015-11-02T14:07:12Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3221#discussion_r43630737","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/43630737"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3221#discussion_r43630737"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221","id":49398037,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3221","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3221.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3221.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3221","number":3221,"state":"open","locked":false,"title":"[WIP] Basic Qt GUI","user":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"body":"I figure this is a pretty good place to stop and take stock before I implement more features.\r\n\r\n**Next Steps:**\r\n\r\n1. Make it work on Windows/Mac. It's only tested on my Linux box.\r\n2. Test what I have thoroughly before continuing.\r\n3. Move m_games_table to its own file as a subclass of QTableWidget.\r\n4. Ditto for m_render_widget, and also allow it to be its own window and fullscreen.\r\n5. GameFile.h/cpp is pretty low quality.\r\n6. I copy or reload many small images rather than storing them statically. Same with many strings.\r\n7. There are plenty of things in MainWindow.cpp that can be refactored.\r\n\r\n![screenshot](https://cloud.githubusercontent.com/assets/7368979/10875247/fc29939a-80e4-11e5-81f7-61839cfbea27.jpg)\r\nI greyed out unimplemented buttons Full Screen, Screen Shot, Settings, Graphics, and Controllers.\r\n\r\n![screenshot2](https://cloud.githubusercontent.com/assets/7368979/10875252/1486665c-80e5-11e5-856f-244b8b3c5cfc.jpg)\r\n","created_at":"2015-11-02T06:12:01Z","updated_at":"2015-11-02T14:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"684585d1f9cb289cce268663f41e37dc577db997","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3221/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0aa6149892b5f23bdbdfe9f0c71c1ce33d22a90f","head":{"label":"spxtr:DolphinQt","ref":"DolphinQt","sha":"0aa6149892b5f23bdbdfe9f0c71c1ce33d22a90f","user":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"repo":{"id":45321636,"name":"dolphin","full_name":"spxtr/dolphin","owner":{"login":"spxtr","id":7368979,"avatar_url":"https://avatars.githubusercontent.com/u/7368979?v=3","gravatar_id":"","url":"https://api.github.com/users/spxtr","html_url":"https://github.com/spxtr","followers_url":"https://api.github.com/users/spxtr/followers","following_url":"https://api.github.com/users/spxtr/following{/other_user}","gists_url":"https://api.github.com/users/spxtr/gists{/gist_id}","starred_url":"https://api.github.com/users/spxtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxtr/subscriptions","organizations_url":"https://api.github.com/users/spxtr/orgs","repos_url":"https://api.github.com/users/spxtr/repos","events_url":"https://api.github.com/users/spxtr/events{/privacy}","received_events_url":"https://api.github.com/users/spxtr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spxtr/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/spxtr/dolphin","forks_url":"https://api.github.com/repos/spxtr/dolphin/forks","keys_url":"https://api.github.com/repos/spxtr/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spxtr/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spxtr/dolphin/teams","hooks_url":"https://api.github.com/repos/spxtr/dolphin/hooks","issue_events_url":"https://api.github.com/repos/spxtr/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/spxtr/dolphin/events","assignees_url":"https://api.github.com/repos/spxtr/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/spxtr/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/spxtr/dolphin/tags","blobs_url":"https://api.github.com/repos/spxtr/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spxtr/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spxtr/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spxtr/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spxtr/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/spxtr/dolphin/languages","stargazers_url":"https://api.github.com/repos/spxtr/dolphin/stargazers","contributors_url":"https://api.github.com/repos/spxtr/dolphin/contributors","subscribers_url":"https://api.github.com/repos/spxtr/dolphin/subscribers","subscription_url":"https://api.github.com/repos/spxtr/dolphin/subscription","commits_url":"https://api.github.com/repos/spxtr/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spxtr/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spxtr/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spxtr/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spxtr/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/spxtr/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spxtr/dolphin/merges","archive_url":"https://api.github.com/repos/spxtr/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spxtr/dolphin/downloads","issues_url":"https://api.github.com/repos/spxtr/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/spxtr/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/spxtr/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/spxtr/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spxtr/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/spxtr/dolphin/releases{/id}","created_at":"2015-10-31T23:20:16Z","updated_at":"2015-10-31T23:20:53Z","pushed_at":"2015-11-02T10:09:43Z","git_url":"git://github.com/spxtr/dolphin.git","ssh_url":"git@github.com:spxtr/dolphin.git","clone_url":"https://github.com/spxtr/dolphin.git","svn_url":"https://github.com/spxtr/dolphin","homepage":"https://dolphin-emu.org/","size":226336,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"55c5ab5a2123d3749556c832c416d38a62f56151","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-11-02T10:15:16Z","pushed_at":"2015-11-02T10:57:51Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":312506,"stargazers_count":1753,"watchers_count":1753,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":544,"mirror_url":null,"open_issues_count":86,"forks":544,"open_issues":86,"watchers":1753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3221"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3221"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3221/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3221/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0aa6149892b5f23bdbdfe9f0c71c1ce33d22a90f"}}}}