{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/validation/issues/126","labels_url":"https://api.github.com/repos/aurelia/validation/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/validation/issues/126/comments","events_url":"https://api.github.com/repos/aurelia/validation/issues/126/events","html_url":"https://github.com/aurelia/validation/pull/126","id":103915811,"number":126,"title":"Typescript","user":{"login":"JeroenVinke","id":2189477,"avatar_url":"https://avatars.githubusercontent.com/u/2189477?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenVinke","html_url":"https://github.com/JeroenVinke","followers_url":"https://api.github.com/users/JeroenVinke/followers","following_url":"https://api.github.com/users/JeroenVinke/following{/other_user}","gists_url":"https://api.github.com/users/JeroenVinke/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenVinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenVinke/subscriptions","organizations_url":"https://api.github.com/users/JeroenVinke/orgs","repos_url":"https://api.github.com/users/JeroenVinke/repos","events_url":"https://api.github.com/users/JeroenVinke/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenVinke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-30T09:55:08Z","updated_at":"2015-09-11T05:11:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aurelia/validation/pulls/126","html_url":"https://github.com/aurelia/validation/pull/126","diff_url":"https://github.com/aurelia/validation/pull/126.diff","patch_url":"https://github.com/aurelia/validation/pull/126.patch"},"body":"https://github.com/aurelia/validation/pull/122 changes the way aurelia-validation is compiled by concatenating all files, and refactoring is needed in order to get this working.\r\n\r\nThis PR also concatenates all validation files, but does this only to generate the d.ts file. The concatenated file is never outputted. The generated d.ts file is copied to all dist directories (commonjs, amd etc).\r\n\r\nA few notes, index.js has to be excluded from the concatenation because it was throwing in a few imports in the generated d.ts which caused it to be invalid. so the configure method in index.js can't be typed using this approach. \r\n\r\nI also don't know what `.pipe(tools.sortFiles()) ` does, but it's throwing an error when enabling it. Everything still works when this is disabled though. https://github.com/aurelia/validation/commit/7579adf14bd0c65e721013fcf44b0749c236cf35#diff-40e62be8220b9aeab02f5a664980bd73R21 Error is here: https://gist.github.com/JeroenVinke/58a108b43eb110e154bd\r\n\r\nIt's not possible to change the outdir of the babel-dts-generator, so the gulp task is a bit complexer because of this. Currently the d.ts file is outputted to `dist/aurelia-validation/aurelia-validation.d.ts`. This directory is removed at the end of the `build` task, after the definition file has been copied to all dist directories\r\n\r\nThis is the output if you apply the changes in this PR: [output](http://i.imgur.com/YnH64yZ.png). and this is the generated definition: https://gist.github.com/JeroenVinke/729d9c12f8de7b8396f2\r\n"},"comment":{"url":"https://api.github.com/repos/aurelia/validation/issues/comments/139453735","html_url":"https://github.com/aurelia/validation/pull/126#issuecomment-139453735","issue_url":"https://api.github.com/repos/aurelia/validation/issues/126","id":139453735,"user":{"login":"PWKad","id":4238393,"avatar_url":"https://avatars.githubusercontent.com/u/4238393?v=3","gravatar_id":"","url":"https://api.github.com/users/PWKad","html_url":"https://github.com/PWKad","followers_url":"https://api.github.com/users/PWKad/followers","following_url":"https://api.github.com/users/PWKad/following{/other_user}","gists_url":"https://api.github.com/users/PWKad/gists{/gist_id}","starred_url":"https://api.github.com/users/PWKad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PWKad/subscriptions","organizations_url":"https://api.github.com/users/PWKad/orgs","repos_url":"https://api.github.com/users/PWKad/repos","events_url":"https://api.github.com/users/PWKad/events{/privacy}","received_events_url":"https://api.github.com/users/PWKad/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T05:11:31Z","updated_at":"2015-09-11T05:11:31Z","body":"@JeroenVinke @nomack84 We really need you all to have a unified front on the .d.ts files - can you get together to decided which PR is best to merge?  If we need an arbitrator let me know and I'm sure @cmichaelgraham can help decide which approach is best, but lets get the type definitions in place ASAP.\r\n\r\nAlso there were a ton of issues with linting and such that had to be resolved, is it feasible to re-base these changes on top of those?  If not and you all can come up with an agreed upon method I will rebase those changes on these."}}