{"action":"created","issue":{"url":"https://api.github.com/repos/AOEpeople/mpmd/issues/4","labels_url":"https://api.github.com/repos/AOEpeople/mpmd/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/AOEpeople/mpmd/issues/4/comments","events_url":"https://api.github.com/repos/AOEpeople/mpmd/issues/4/events","html_url":"https://github.com/AOEpeople/mpmd/issues/4","id":53729840,"number":4,"title":"Inverted diff when overriding code in local codepool?","user":{"login":"real34","id":75968,"avatar_url":"https://avatars.githubusercontent.com/u/75968?v=3","gravatar_id":"","url":"https://api.github.com/users/real34","html_url":"https://github.com/real34","followers_url":"https://api.github.com/users/real34/followers","following_url":"https://api.github.com/users/real34/following{/other_user}","gists_url":"https://api.github.com/users/real34/gists{/gist_id}","starred_url":"https://api.github.com/users/real34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real34/subscriptions","organizations_url":"https://api.github.com/users/real34/orgs","repos_url":"https://api.github.com/users/real34/repos","events_url":"https://api.github.com/users/real34/events{/privacy}","received_events_url":"https://api.github.com/users/real34/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-08T09:23:13Z","updated_at":"2015-02-05T08:16:10Z","closed_at":null,"body":"It seems that diff is inverted in the Code Pool Override Report (`-` instead of `+`). I wanted to check whether it was a bug or a feature and if you think it should be fixed I'll work on a patch.\r\n\r\n## To reproduce\r\n\r\n* create a file in `app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php` of a Magento application\r\n* comment the line `Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));` (~ L159)\r\n* Install the latest version (master branch - 2062e4dd1190dedab0b2ffd4a1067928da8192f3)\r\n* run `n98-magerun mpmd:codepooloverrides foo.html`\r\n\r\n## What happens\r\n\r\nThe \"Changed files (differentFileContent)\" of the \"Comparing local and core\" section contains the following diff for `/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php`:\r\n\r\n```php\r\n--- /path/to/app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php\t2012-01-20 00:00:00.000000000 +0100\r\n+++ /path/to/app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php\t2012-01-09 00:00:00.000000000 +0100\r\n@@ -159,7 +159,7 @@\r\n             'required' => true,\r\n         ))->setRule($model)->setRenderer(Mage::getBlockSingleton('rule/actions'));\r\n \r\n-        //Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));\r\n+        Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));\r\n \r\n         $form->setValues($model->getData());\r\n```\r\n\r\n## Expected\r\n\r\nFor more consistency with Core Hacks Report, the diff should read:\r\n\r\n```php\r\n--- /path/to/app/code/core/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php\t2012-01-09 00:00:00.000000000 +0100\r\n+++ /path/to/app/code/local/Mage/Adminhtml/Block/Promo/Quote/Edit/Tab/Actions.php\t2012-01-20 00:00:00.000000000 +0100\r\n@@ -159,7 +159,7 @@\r\n             'required' => true,\r\n         ))->setRule($model)->setRenderer(Mage::getBlockSingleton('rule/actions'));\r\n\r\n-        Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form)); \r\n+        //Mage::dispatchEvent('adminhtml_block_salesrule_actions_prepareform', array('form' => $form));\r\n \r\n         $form->setValues($model->getData());\r\n```\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/AOEpeople/mpmd/issues/comments/73009689","html_url":"https://github.com/AOEpeople/mpmd/issues/4#issuecomment-73009689","issue_url":"https://api.github.com/repos/AOEpeople/mpmd/issues/4","id":73009689,"user":{"login":"real34","id":75968,"avatar_url":"https://avatars.githubusercontent.com/u/75968?v=3","gravatar_id":"","url":"https://api.github.com/users/real34","html_url":"https://github.com/real34","followers_url":"https://api.github.com/users/real34/followers","following_url":"https://api.github.com/users/real34/following{/other_user}","gists_url":"https://api.github.com/users/real34/gists{/gist_id}","starred_url":"https://api.github.com/users/real34/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/real34/subscriptions","organizations_url":"https://api.github.com/users/real34/orgs","repos_url":"https://api.github.com/users/real34/repos","events_url":"https://api.github.com/users/real34/events{/privacy}","received_events_url":"https://api.github.com/users/real34/received_events","type":"User","site_admin":false},"created_at":"2015-02-05T08:16:10Z","updated_at":"2015-02-05T08:16:10Z","body":"Any thoughts?"}}