{"action":"created","comment":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/26210875","id":26210875,"diff_hunk":"@@ -40,8 +40,8 @@ FloatPoint2D: cover {\n \tround: func -> This { This new(this x round(), this y round()) }\n \tceiling: func -> This { This new(this x ceil(), this y ceil()) }\n \tfloor: func -> This { This new(this x floor(), this y floor()) }\n-\tminimum: func (ceiling: This) -> This { This new(this x minimum(ceiling x), this y minimum(ceiling y)) }\n-\tmaximum: func (floor: This) -> This { This new(this x maximum(floor x), this y maximum(floor y)) }\n+\tminimum: func (ceiling: This) -> This { This new(Float minimum(this x, ceiling x), Float minimum(this y, ceiling y)) }\n+\tmaximum: func (floor: This) -> This { This new(Float maximum(this x, floor x), Float maximum(this y, floor y)) }","path":"source/math/FloatPoint2D.ooc","position":7,"original_position":7,"commit_id":"bec6258b62c663bfc0bad0f66555af26d19a543c","original_commit_id":"bec6258b62c663bfc0bad0f66555af26d19a543c","user":{"login":"alexandersundin","id":11058058,"avatar_url":"https://avatars.githubusercontent.com/u/11058058?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandersundin","html_url":"https://github.com/alexandersundin","followers_url":"https://api.github.com/users/alexandersundin/followers","following_url":"https://api.github.com/users/alexandersundin/following{/other_user}","gists_url":"https://api.github.com/users/alexandersundin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandersundin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandersundin/subscriptions","organizations_url":"https://api.github.com/users/alexandersundin/orgs","repos_url":"https://api.github.com/users/alexandersundin/repos","events_url":"https://api.github.com/users/alexandersundin/events{/privacy}","received_events_url":"https://api.github.com/users/alexandersundin/received_events","type":"User","site_admin":false},"body":"Before the changes the methods returned the second parameter, calling minimum(a,b) would return b, regardless of the x- and y-magnitudes of the parameters. With the changes the methods return a FloatPoint2D consisting of the largest/smallest magnitude of x and y .\r\n\r\nExample:\r\nGiven the points a=(-1,1) and b=(1,-1), calling minimum(a,b) would give the following result:\r\nBefore changes: (1,-1)\r\nAfter changes: (-1,-1)","created_at":"2015-03-11T13:25:02Z","updated_at":"2015-03-11T13:25:02Z","html_url":"https://github.com/cogneco/ooc-kean/pull/144#discussion_r26210875","pull_request_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/26210875"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/144#discussion_r26210875"},"pull_request":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144","id":30937654,"html_url":"https://github.com/cogneco/ooc-kean/pull/144","diff_url":"https://github.com/cogneco/ooc-kean/pull/144.diff","patch_url":"https://github.com/cogneco/ooc-kean/pull/144.patch","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/144","number":144,"state":"open","locked":false,"title":"Added plot library","user":{"login":"alexandersundin","id":11058058,"avatar_url":"https://avatars.githubusercontent.com/u/11058058?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandersundin","html_url":"https://github.com/alexandersundin","followers_url":"https://api.github.com/users/alexandersundin/followers","following_url":"https://api.github.com/users/alexandersundin/following{/other_user}","gists_url":"https://api.github.com/users/alexandersundin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandersundin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandersundin/subscriptions","organizations_url":"https://api.github.com/users/alexandersundin/orgs","repos_url":"https://api.github.com/users/alexandersundin/repos","events_url":"https://api.github.com/users/alexandersundin/events{/privacy}","received_events_url":"https://api.github.com/users/alexandersundin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-11T12:18:46Z","updated_at":"2015-03-11T13:25:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2fcce452626fa500c8c16362bae64a805724d8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144/commits","review_comments_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144/comments","review_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/144/comments","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/bec6258b62c663bfc0bad0f66555af26d19a543c","head":{"label":"alexandersundin:master","ref":"master","sha":"bec6258b62c663bfc0bad0f66555af26d19a543c","user":{"login":"alexandersundin","id":11058058,"avatar_url":"https://avatars.githubusercontent.com/u/11058058?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandersundin","html_url":"https://github.com/alexandersundin","followers_url":"https://api.github.com/users/alexandersundin/followers","following_url":"https://api.github.com/users/alexandersundin/following{/other_user}","gists_url":"https://api.github.com/users/alexandersundin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandersundin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandersundin/subscriptions","organizations_url":"https://api.github.com/users/alexandersundin/orgs","repos_url":"https://api.github.com/users/alexandersundin/repos","events_url":"https://api.github.com/users/alexandersundin/events{/privacy}","received_events_url":"https://api.github.com/users/alexandersundin/received_events","type":"User","site_admin":false},"repo":{"id":31066561,"name":"ooc-kean","full_name":"alexandersundin/ooc-kean","owner":{"login":"alexandersundin","id":11058058,"avatar_url":"https://avatars.githubusercontent.com/u/11058058?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandersundin","html_url":"https://github.com/alexandersundin","followers_url":"https://api.github.com/users/alexandersundin/followers","following_url":"https://api.github.com/users/alexandersundin/following{/other_user}","gists_url":"https://api.github.com/users/alexandersundin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandersundin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandersundin/subscriptions","organizations_url":"https://api.github.com/users/alexandersundin/orgs","repos_url":"https://api.github.com/users/alexandersundin/repos","events_url":"https://api.github.com/users/alexandersundin/events{/privacy}","received_events_url":"https://api.github.com/users/alexandersundin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandersundin/ooc-kean","description":"ooc port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/alexandersundin/ooc-kean","forks_url":"https://api.github.com/repos/alexandersundin/ooc-kean/forks","keys_url":"https://api.github.com/repos/alexandersundin/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandersundin/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandersundin/ooc-kean/teams","hooks_url":"https://api.github.com/repos/alexandersundin/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/alexandersundin/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/alexandersundin/ooc-kean/events","assignees_url":"https://api.github.com/repos/alexandersundin/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/alexandersundin/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/alexandersundin/ooc-kean/tags","blobs_url":"https://api.github.com/repos/alexandersundin/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandersundin/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandersundin/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandersundin/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandersundin/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandersundin/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/alexandersundin/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/alexandersundin/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/alexandersundin/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/alexandersundin/ooc-kean/subscription","commits_url":"https://api.github.com/repos/alexandersundin/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandersundin/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandersundin/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandersundin/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandersundin/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/alexandersundin/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandersundin/ooc-kean/merges","archive_url":"https://api.github.com/repos/alexandersundin/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandersundin/ooc-kean/downloads","issues_url":"https://api.github.com/repos/alexandersundin/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/alexandersundin/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandersundin/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandersundin/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandersundin/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/alexandersundin/ooc-kean/releases{/id}","created_at":"2015-02-20T13:45:33Z","updated_at":"2015-03-11T12:17:33Z","pushed_at":"2015-03-11T12:17:33Z","git_url":"git://github.com/alexandersundin/ooc-kean.git","ssh_url":"git@github.com:alexandersundin/ooc-kean.git","clone_url":"https://github.com/alexandersundin/ooc-kean.git","svn_url":"https://github.com/alexandersundin/ooc-kean","homepage":"","size":6262,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cogneco:master","ref":"master","sha":"a0cc566bc5d225d0ce5edf98e00e2d160909aa2b","user":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"cogneco/ooc-kean","owner":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cogneco/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/cogneco/ooc-kean","forks_url":"https://api.github.com/repos/cogneco/ooc-kean/forks","keys_url":"https://api.github.com/repos/cogneco/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cogneco/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cogneco/ooc-kean/teams","hooks_url":"https://api.github.com/repos/cogneco/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/cogneco/ooc-kean/events","assignees_url":"https://api.github.com/repos/cogneco/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/cogneco/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/cogneco/ooc-kean/tags","blobs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cogneco/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/cogneco/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/cogneco/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/cogneco/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/cogneco/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/cogneco/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/cogneco/ooc-kean/subscription","commits_url":"https://api.github.com/repos/cogneco/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/cogneco/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/cogneco/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/cogneco/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cogneco/ooc-kean/merges","archive_url":"https://api.github.com/repos/cogneco/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cogneco/ooc-kean/downloads","issues_url":"https://api.github.com/repos/cogneco/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/cogneco/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/cogneco/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/cogneco/ooc-kean/releases{/id}","created_at":"2014-10-15T13:42:17Z","updated_at":"2015-03-09T15:00:20Z","pushed_at":"2015-03-09T15:00:20Z","git_url":"git://github.com/cogneco/ooc-kean.git","ssh_url":"git@github.com:cogneco/ooc-kean.git","clone_url":"https://github.com/cogneco/ooc-kean.git","svn_url":"https://github.com/cogneco/ooc-kean","homepage":"","size":7898,"stargazers_count":2,"watchers_count":2,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/144"},"issue":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/144"},"comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/cogneco/ooc-kean/statuses/bec6258b62c663bfc0bad0f66555af26d19a543c"}}}}