{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/134","labels_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/134/comments","events_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/134/events","html_url":"https://github.com/Microsoft/Windows-universal-samples/pull/134","id":101415936,"number":134,"title":"Adapted to work on all W10 devices and form factors in the same way","user":{"login":"shinsenai","id":13431249,"avatar_url":"https://avatars.githubusercontent.com/u/13431249?v=3","gravatar_id":"","url":"https://api.github.com/users/shinsenai","html_url":"https://github.com/shinsenai","followers_url":"https://api.github.com/users/shinsenai/followers","following_url":"https://api.github.com/users/shinsenai/following{/other_user}","gists_url":"https://api.github.com/users/shinsenai/gists{/gist_id}","starred_url":"https://api.github.com/users/shinsenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinsenai/subscriptions","organizations_url":"https://api.github.com/users/shinsenai/orgs","repos_url":"https://api.github.com/users/shinsenai/repos","events_url":"https://api.github.com/users/shinsenai/events{/privacy}","received_events_url":"https://api.github.com/users/shinsenai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rkarman","id":12519882,"avatar_url":"https://avatars.githubusercontent.com/u/12519882?v=3","gravatar_id":"","url":"https://api.github.com/users/rkarman","html_url":"https://github.com/rkarman","followers_url":"https://api.github.com/users/rkarman/followers","following_url":"https://api.github.com/users/rkarman/following{/other_user}","gists_url":"https://api.github.com/users/rkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/rkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkarman/subscriptions","organizations_url":"https://api.github.com/users/rkarman/orgs","repos_url":"https://api.github.com/users/rkarman/repos","events_url":"https://api.github.com/users/rkarman/events{/privacy}","received_events_url":"https://api.github.com/users/rkarman/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-08-17T13:01:22Z","updated_at":"2015-08-19T16:35:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/pulls/134","html_url":"https://github.com/Microsoft/Windows-universal-samples/pull/134","diff_url":"https://github.com/Microsoft/Windows-universal-samples/pull/134.diff","patch_url":"https://github.com/Microsoft/Windows-universal-samples/pull/134.patch"},"body":"I've adapted the sample to work as a Universal app. There is no need to use separate images and code for PC/tablets and phones. The main changes are:\r\n\r\n1) Use Canvas instead of Viewbox: it might work with Viewbox as well, but couldn't find a reliable way\r\n2) Use DisplayInformation.GetForCurrentView().ResolutionScale to calculate the appropriate form factor for the image (AFAIK on phones the splashImageRect numbers are referred to the base resolution and have to be scaled to match the actual device resolution)\r\n3) Make use only of one image (Asset/splash-sdk.png), no need to have a separate portrait version for phones\r\n\r\nI've tested it on a Surface Pro 3 and on three of the emulators coming with VS2015 (WVGA, WXGA and 1028p).\r\n\r\nPlease fell free to use all or part or nothing of my proposed code. Thanks for your all your effort with these samples."},"comment":{"url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/comments/132687591","html_url":"https://github.com/Microsoft/Windows-universal-samples/pull/134#issuecomment-132687591","issue_url":"https://api.github.com/repos/Microsoft/Windows-universal-samples/issues/134","id":132687591,"user":{"login":"rkarman","id":12519882,"avatar_url":"https://avatars.githubusercontent.com/u/12519882?v=3","gravatar_id":"","url":"https://api.github.com/users/rkarman","html_url":"https://github.com/rkarman","followers_url":"https://api.github.com/users/rkarman/followers","following_url":"https://api.github.com/users/rkarman/following{/other_user}","gists_url":"https://api.github.com/users/rkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/rkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkarman/subscriptions","organizations_url":"https://api.github.com/users/rkarman/orgs","repos_url":"https://api.github.com/users/rkarman/repos","events_url":"https://api.github.com/users/rkarman/events{/privacy}","received_events_url":"https://api.github.com/users/rkarman/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T16:35:04Z","updated_at":"2015-08-19T16:35:04Z","body":"Thank you for your contribution shinsenai! The updates are in line with what I had in mind when first reading your reported issue (#126) and I have asked the repository owner to accept your pull request."}}