{"action":"created","comment":{"url":"https://api.github.com/repos/projectbuendia/client/pulls/comments/43921761","id":43921761,"diff_hunk":"@@ -168,7 +167,18 @@ void addObservations(List<Obs> observations) {\n             }\n         }\n \n-        /** Returns a column for a given date. Creates a new column, if it does not exist yet */\n+        /** Ensures that columns are shown for any days in which an order is prescribed. */\n+        void addOrders(List<Order> orders) {\n+            for (Order order : orders) {\n+                if (order.stop != null) {\n+                    for (DateTime dt = order.start; !dt.isAfter(order.stop.plusDays(1)); dt = dt.plusDays(1)) {","path":"app/src/main/java/org/projectbuendia/client/ui/chart/ChartRenderer.java","position":70,"original_position":70,"commit_id":"ea7a6cf9c9b660c2d6c2792d022efb35736bfd17","original_commit_id":"ea7a6cf9c9b660c2d6c2792d022efb35736bfd17","user":{"login":"zestyping","id":236086,"avatar_url":"https://avatars.githubusercontent.com/u/236086?v=3","gravatar_id":"","url":"https://api.github.com/users/zestyping","html_url":"https://github.com/zestyping","followers_url":"https://api.github.com/users/zestyping/followers","following_url":"https://api.github.com/users/zestyping/following{/other_user}","gists_url":"https://api.github.com/users/zestyping/gists{/gist_id}","starred_url":"https://api.github.com/users/zestyping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestyping/subscriptions","organizations_url":"https://api.github.com/users/zestyping/orgs","repos_url":"https://api.github.com/users/zestyping/repos","events_url":"https://api.github.com/users/zestyping/events{/privacy}","received_events_url":"https://api.github.com/users/zestyping/received_events","type":"User","site_admin":false},"body":"Yes, that sounds right!  (I think the UI for this is not that great and we\nmight want to get rid of the STOP to make it more like the paper charts\nthey use.  But that's for later.)\n\nOn Wed, Nov 4, 2015 at 10:05 AM, Leonardo Lima de Vasconcellos <\nnotifications@github.com> wrote:\n\n> In app/src/main/java/org/projectbuendia/client/ui/chart/ChartRenderer.java\n> <https://github.com/projectbuendia/client/pull/72#discussion_r43915620>:\n>\n> > @@ -168,7 +167,18 @@ void addObservations(List<Obs> observations) {\n> >              }\n> >          }\n> >\n> > -        /** Returns a column for a given date. Creates a new column, if it does not exist yet */\n> > +        /** Ensures that columns are shown for any days in which an order is prescribed. */\n> > +        void addOrders(List<Order> orders) {\n> > +            for (Order order : orders) {\n> > +                if (order.stop != null) {\n> > +                    for (DateTime dt = order.start; !dt.isAfter(order.stop.plusDays(1)); dt = dt.plusDays(1)) {\n>\n> @zestyping <https://github.com/zestyping> I added the\n> order.stop.plusDays(1) to make the STOP day appear for a future order. Is\n> that ok? If so it will be ready to merge!\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/projectbuendia/client/pull/72/files#r43915620>.\n>\n","created_at":"2015-11-04T18:53:58Z","updated_at":"2015-11-04T18:53:58Z","html_url":"https://github.com/projectbuendia/client/pull/72#discussion_r43921761","pull_request_url":"https://api.github.com/repos/projectbuendia/client/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/comments/43921761"},"html":{"href":"https://github.com/projectbuendia/client/pull/72#discussion_r43921761"},"pull_request":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/projectbuendia/client/pulls/72","id":47448563,"html_url":"https://github.com/projectbuendia/client/pull/72","diff_url":"https://github.com/projectbuendia/client/pull/72.diff","patch_url":"https://github.com/projectbuendia/client/pull/72.patch","issue_url":"https://api.github.com/repos/projectbuendia/client/issues/72","number":72,"state":"open","locked":false,"title":"Fix insertion of empty columns; display column gaps.","user":{"login":"zestyping","id":236086,"avatar_url":"https://avatars.githubusercontent.com/u/236086?v=3","gravatar_id":"","url":"https://api.github.com/users/zestyping","html_url":"https://github.com/zestyping","followers_url":"https://api.github.com/users/zestyping/followers","following_url":"https://api.github.com/users/zestyping/following{/other_user}","gists_url":"https://api.github.com/users/zestyping/gists{/gist_id}","starred_url":"https://api.github.com/users/zestyping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestyping/subscriptions","organizations_url":"https://api.github.com/users/zestyping/orgs","repos_url":"https://api.github.com/users/zestyping/repos","events_url":"https://api.github.com/users/zestyping/events{/privacy}","received_events_url":"https://api.github.com/users/zestyping/received_events","type":"User","site_admin":false},"body":"This determines the columns to drop a bit more efficiently, and also displays a grey gap to show that columns are missing.","created_at":"2015-10-12T18:11:36Z","updated_at":"2015-11-04T18:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8edc6634c1f85c1f91c36cfb5685f58be87d911d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectbuendia/client/pulls/72/commits","review_comments_url":"https://api.github.com/repos/projectbuendia/client/pulls/72/comments","review_comment_url":"https://api.github.com/repos/projectbuendia/client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectbuendia/client/issues/72/comments","statuses_url":"https://api.github.com/repos/projectbuendia/client/statuses/ea7a6cf9c9b660c2d6c2792d022efb35736bfd17","head":{"label":"projectbuendia:feature/ping-column-gaps","ref":"feature/ping-column-gaps","sha":"ea7a6cf9c9b660c2d6c2792d022efb35736bfd17","user":{"login":"projectbuendia","id":13339011,"avatar_url":"https://avatars.githubusercontent.com/u/13339011?v=3","gravatar_id":"","url":"https://api.github.com/users/projectbuendia","html_url":"https://github.com/projectbuendia","followers_url":"https://api.github.com/users/projectbuendia/followers","following_url":"https://api.github.com/users/projectbuendia/following{/other_user}","gists_url":"https://api.github.com/users/projectbuendia/gists{/gist_id}","starred_url":"https://api.github.com/users/projectbuendia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectbuendia/subscriptions","organizations_url":"https://api.github.com/users/projectbuendia/orgs","repos_url":"https://api.github.com/users/projectbuendia/repos","events_url":"https://api.github.com/users/projectbuendia/events{/privacy}","received_events_url":"https://api.github.com/users/projectbuendia/received_events","type":"Organization","site_admin":false},"repo":{"id":33972326,"name":"client","full_name":"projectbuendia/client","owner":{"login":"projectbuendia","id":13339011,"avatar_url":"https://avatars.githubusercontent.com/u/13339011?v=3","gravatar_id":"","url":"https://api.github.com/users/projectbuendia","html_url":"https://github.com/projectbuendia","followers_url":"https://api.github.com/users/projectbuendia/followers","following_url":"https://api.github.com/users/projectbuendia/following{/other_user}","gists_url":"https://api.github.com/users/projectbuendia/gists{/gist_id}","starred_url":"https://api.github.com/users/projectbuendia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectbuendia/subscriptions","organizations_url":"https://api.github.com/users/projectbuendia/orgs","repos_url":"https://api.github.com/users/projectbuendia/repos","events_url":"https://api.github.com/users/projectbuendia/events{/privacy}","received_events_url":"https://api.github.com/users/projectbuendia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectbuendia/client","description":"Android client app","fork":false,"url":"https://api.github.com/repos/projectbuendia/client","forks_url":"https://api.github.com/repos/projectbuendia/client/forks","keys_url":"https://api.github.com/repos/projectbuendia/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectbuendia/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectbuendia/client/teams","hooks_url":"https://api.github.com/repos/projectbuendia/client/hooks","issue_events_url":"https://api.github.com/repos/projectbuendia/client/issues/events{/number}","events_url":"https://api.github.com/repos/projectbuendia/client/events","assignees_url":"https://api.github.com/repos/projectbuendia/client/assignees{/user}","branches_url":"https://api.github.com/repos/projectbuendia/client/branches{/branch}","tags_url":"https://api.github.com/repos/projectbuendia/client/tags","blobs_url":"https://api.github.com/repos/projectbuendia/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectbuendia/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectbuendia/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectbuendia/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectbuendia/client/statuses/{sha}","languages_url":"https://api.github.com/repos/projectbuendia/client/languages","stargazers_url":"https://api.github.com/repos/projectbuendia/client/stargazers","contributors_url":"https://api.github.com/repos/projectbuendia/client/contributors","subscribers_url":"https://api.github.com/repos/projectbuendia/client/subscribers","subscription_url":"https://api.github.com/repos/projectbuendia/client/subscription","commits_url":"https://api.github.com/repos/projectbuendia/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectbuendia/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectbuendia/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectbuendia/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectbuendia/client/contents/{+path}","compare_url":"https://api.github.com/repos/projectbuendia/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectbuendia/client/merges","archive_url":"https://api.github.com/repos/projectbuendia/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectbuendia/client/downloads","issues_url":"https://api.github.com/repos/projectbuendia/client/issues{/number}","pulls_url":"https://api.github.com/repos/projectbuendia/client/pulls{/number}","milestones_url":"https://api.github.com/repos/projectbuendia/client/milestones{/number}","notifications_url":"https://api.github.com/repos/projectbuendia/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectbuendia/client/labels{/name}","releases_url":"https://api.github.com/repos/projectbuendia/client/releases{/id}","created_at":"2015-04-15T04:01:52Z","updated_at":"2015-10-26T18:09:27Z","pushed_at":"2015-11-04T18:03:25Z","git_url":"git://github.com/projectbuendia/client.git","ssh_url":"git@github.com:projectbuendia/client.git","clone_url":"https://github.com/projectbuendia/client.git","svn_url":"https://github.com/projectbuendia/client","homepage":null,"size":7823,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":25,"forks":24,"open_issues":25,"watchers":34,"default_branch":"dev"}},"base":{"label":"projectbuendia:dev","ref":"dev","sha":"f07dc8b93ef1520ab0e1c3180678d0fd0ce51a03","user":{"login":"projectbuendia","id":13339011,"avatar_url":"https://avatars.githubusercontent.com/u/13339011?v=3","gravatar_id":"","url":"https://api.github.com/users/projectbuendia","html_url":"https://github.com/projectbuendia","followers_url":"https://api.github.com/users/projectbuendia/followers","following_url":"https://api.github.com/users/projectbuendia/following{/other_user}","gists_url":"https://api.github.com/users/projectbuendia/gists{/gist_id}","starred_url":"https://api.github.com/users/projectbuendia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectbuendia/subscriptions","organizations_url":"https://api.github.com/users/projectbuendia/orgs","repos_url":"https://api.github.com/users/projectbuendia/repos","events_url":"https://api.github.com/users/projectbuendia/events{/privacy}","received_events_url":"https://api.github.com/users/projectbuendia/received_events","type":"Organization","site_admin":false},"repo":{"id":33972326,"name":"client","full_name":"projectbuendia/client","owner":{"login":"projectbuendia","id":13339011,"avatar_url":"https://avatars.githubusercontent.com/u/13339011?v=3","gravatar_id":"","url":"https://api.github.com/users/projectbuendia","html_url":"https://github.com/projectbuendia","followers_url":"https://api.github.com/users/projectbuendia/followers","following_url":"https://api.github.com/users/projectbuendia/following{/other_user}","gists_url":"https://api.github.com/users/projectbuendia/gists{/gist_id}","starred_url":"https://api.github.com/users/projectbuendia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectbuendia/subscriptions","organizations_url":"https://api.github.com/users/projectbuendia/orgs","repos_url":"https://api.github.com/users/projectbuendia/repos","events_url":"https://api.github.com/users/projectbuendia/events{/privacy}","received_events_url":"https://api.github.com/users/projectbuendia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectbuendia/client","description":"Android client app","fork":false,"url":"https://api.github.com/repos/projectbuendia/client","forks_url":"https://api.github.com/repos/projectbuendia/client/forks","keys_url":"https://api.github.com/repos/projectbuendia/client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectbuendia/client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectbuendia/client/teams","hooks_url":"https://api.github.com/repos/projectbuendia/client/hooks","issue_events_url":"https://api.github.com/repos/projectbuendia/client/issues/events{/number}","events_url":"https://api.github.com/repos/projectbuendia/client/events","assignees_url":"https://api.github.com/repos/projectbuendia/client/assignees{/user}","branches_url":"https://api.github.com/repos/projectbuendia/client/branches{/branch}","tags_url":"https://api.github.com/repos/projectbuendia/client/tags","blobs_url":"https://api.github.com/repos/projectbuendia/client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectbuendia/client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectbuendia/client/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectbuendia/client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectbuendia/client/statuses/{sha}","languages_url":"https://api.github.com/repos/projectbuendia/client/languages","stargazers_url":"https://api.github.com/repos/projectbuendia/client/stargazers","contributors_url":"https://api.github.com/repos/projectbuendia/client/contributors","subscribers_url":"https://api.github.com/repos/projectbuendia/client/subscribers","subscription_url":"https://api.github.com/repos/projectbuendia/client/subscription","commits_url":"https://api.github.com/repos/projectbuendia/client/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectbuendia/client/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectbuendia/client/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectbuendia/client/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectbuendia/client/contents/{+path}","compare_url":"https://api.github.com/repos/projectbuendia/client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectbuendia/client/merges","archive_url":"https://api.github.com/repos/projectbuendia/client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectbuendia/client/downloads","issues_url":"https://api.github.com/repos/projectbuendia/client/issues{/number}","pulls_url":"https://api.github.com/repos/projectbuendia/client/pulls{/number}","milestones_url":"https://api.github.com/repos/projectbuendia/client/milestones{/number}","notifications_url":"https://api.github.com/repos/projectbuendia/client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectbuendia/client/labels{/name}","releases_url":"https://api.github.com/repos/projectbuendia/client/releases{/id}","created_at":"2015-04-15T04:01:52Z","updated_at":"2015-10-26T18:09:27Z","pushed_at":"2015-11-04T18:03:25Z","git_url":"git://github.com/projectbuendia/client.git","ssh_url":"git@github.com:projectbuendia/client.git","clone_url":"https://github.com/projectbuendia/client.git","svn_url":"https://github.com/projectbuendia/client","homepage":null,"size":7823,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":25,"forks":24,"open_issues":25,"watchers":34,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/72"},"html":{"href":"https://github.com/projectbuendia/client/pull/72"},"issue":{"href":"https://api.github.com/repos/projectbuendia/client/issues/72"},"comments":{"href":"https://api.github.com/repos/projectbuendia/client/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectbuendia/client/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/projectbuendia/client/statuses/ea7a6cf9c9b660c2d6c2792d022efb35736bfd17"}}}}