{"action":"created","issue":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/431","labels_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/431/comments","events_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/431/events","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/431","id":110822207,"number":431,"title":"Use Polymer.dom in app.js. Fixes Gh-379","user":{"login":"robdodson","id":1066253,"avatar_url":"https://avatars.githubusercontent.com/u/1066253?v=3","gravatar_id":"","url":"https://api.github.com/users/robdodson","html_url":"https://github.com/robdodson","followers_url":"https://api.github.com/users/robdodson/followers","following_url":"https://api.github.com/users/robdodson/following{/other_user}","gists_url":"https://api.github.com/users/robdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/robdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robdodson/subscriptions","organizations_url":"https://api.github.com/users/robdodson/orgs","repos_url":"https://api.github.com/users/robdodson/repos","events_url":"https://api.github.com/users/robdodson/events{/privacy}","received_events_url":"https://api.github.com/users/robdodson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/labels/dont-merge-just-yet","name":"dont-merge-just-yet","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"addyosmani","id":110953,"avatar_url":"https://avatars.githubusercontent.com/u/110953?v=3","gravatar_id":"","url":"https://api.github.com/users/addyosmani","html_url":"https://github.com/addyosmani","followers_url":"https://api.github.com/users/addyosmani/followers","following_url":"https://api.github.com/users/addyosmani/following{/other_user}","gists_url":"https://api.github.com/users/addyosmani/gists{/gist_id}","starred_url":"https://api.github.com/users/addyosmani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addyosmani/subscriptions","organizations_url":"https://api.github.com/users/addyosmani/orgs","repos_url":"https://api.github.com/users/addyosmani/repos","events_url":"https://api.github.com/users/addyosmani/events{/privacy}","received_events_url":"https://api.github.com/users/addyosmani/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-10-10T23:17:13Z","updated_at":"2015-10-21T09:48:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/pulls/431","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/431","diff_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/431.diff","patch_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/431.patch"},"body":"This PR switches `app.js` over to using Polymer's Shady DOM API for querying the document (https://www.polymer-project.org/1.0/docs/devguide/local-dom.html#dom-api). This should preserve Shadow boundaries. I believe moving forward if you're querying the DOM you'll always want to use  `Polymer.dom` methods.\r\n\r\nThis should fix https://github.com/PolymerElements/polymer-starter-kit/issues/379 as it's now querying the Light DOM `paper-scroll-header-panel` and using its API to scroll, instead of the `mainContainer` element which should be hidden by Shadow DOM.\r\n\r\n@samccone @chuckh @addyosmani PTAL"},"comment":{"url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/comments/149840551","html_url":"https://github.com/PolymerElements/polymer-starter-kit/pull/431#issuecomment-149840551","issue_url":"https://api.github.com/repos/PolymerElements/polymer-starter-kit/issues/431","id":149840551,"user":{"login":"robdodson","id":1066253,"avatar_url":"https://avatars.githubusercontent.com/u/1066253?v=3","gravatar_id":"","url":"https://api.github.com/users/robdodson","html_url":"https://github.com/robdodson","followers_url":"https://api.github.com/users/robdodson/followers","following_url":"https://api.github.com/users/robdodson/following{/other_user}","gists_url":"https://api.github.com/users/robdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/robdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robdodson/subscriptions","organizations_url":"https://api.github.com/users/robdodson/orgs","repos_url":"https://api.github.com/users/robdodson/repos","events_url":"https://api.github.com/users/robdodson/events{/privacy}","received_events_url":"https://api.github.com/users/robdodson/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T09:48:28Z","updated_at":"2015-10-21T09:48:28Z","body":"@addyosmani ah I see the problem. It's here: https://github.com/PolymerElements/polymer-starter-kit/pull/431/files#diff-685dfa901a119f6590e773891ffd6052R15\r\n\r\nPolymer isn't loaded yet on Safari or FF because the imports are async. I think the two fixes would be to either move everything inside WebComponentsReady callback or don't use the `doc` variable and spinkle `Polymer.dom` calls everywhere which doesn't feel very DRY to me. wdyt?"}}