{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments/31415402","id":31415402,"diff_hunk":"@@ -0,0 +1,50 @@\n+# This file is copied to spec/ when you run 'rails generate rspec:install'\n+ENV['RAILS_ENV'] ||= 'test'\n+require 'spec_helper'\n+require File.expand_path('../../config/environment', __FILE__)\n+require 'rspec/rails'\n+# Add additional requires below this line. Rails is not loaded until this point!\n+\n+# Requires supporting ruby files with custom matchers and macros, etc, in\n+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are\n+# run as spec files by default. This means that files in spec/support that end\n+# in _spec.rb will both be required and run as specs, causing the specs to be\n+# run twice. It is recommended that you do not name files matching this glob to\n+# end with _spec.rb. You can configure this pattern with the --pattern\n+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.\n+#\n+# The following line is provided for convenience purposes. It has the downside\n+# of increasing the boot-up time by auto-requiring all files in the support\n+# directory. Alternatively, in the individual `*_spec.rb` files, manually\n+# require only the support files necessary.\n+#\n+# Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }\n+\n+# Checks for pending migrations before tests are run.\n+# If you are not using ActiveRecord, you can remove this line.","path":"spec/rails_helper.rb","position":24,"original_position":24,"commit_id":"e6374e9cf08067bebcbb86bf061d23700c5406ea","original_commit_id":"e6374e9cf08067bebcbb86bf061d23700c5406ea","user":{"login":"SteveMarshall","id":2210,"avatar_url":"https://avatars.githubusercontent.com/u/2210?v=3","gravatar_id":"","url":"https://api.github.com/users/SteveMarshall","html_url":"https://github.com/SteveMarshall","followers_url":"https://api.github.com/users/SteveMarshall/followers","following_url":"https://api.github.com/users/SteveMarshall/following{/other_user}","gists_url":"https://api.github.com/users/SteveMarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveMarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveMarshall/subscriptions","organizations_url":"https://api.github.com/users/SteveMarshall/orgs","repos_url":"https://api.github.com/users/SteveMarshall/repos","events_url":"https://api.github.com/users/SteveMarshall/events{/privacy}","received_events_url":"https://api.github.com/users/SteveMarshall/received_events","type":"User","site_admin":false},"body":"… either that, or make it clear they're auto-generated… or make Rake generate them and not commit the artefacts, or something?","created_at":"2015-06-01T10:49:11Z","updated_at":"2015-06-01T10:49:11Z","html_url":"https://github.com/ministryofjustice/prison-visits/pull/216#discussion_r31415402","pull_request_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments/31415402"},"html":{"href":"https://github.com/ministryofjustice/prison-visits/pull/216#discussion_r31415402"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216","id":36311965,"html_url":"https://github.com/ministryofjustice/prison-visits/pull/216","diff_url":"https://github.com/ministryofjustice/prison-visits/pull/216.diff","patch_url":"https://github.com/ministryofjustice/prison-visits/pull/216.patch","issue_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/216","number":216,"state":"open","locked":false,"title":"Upgrade to latest version of Rails (4.2.1)","user":{"login":"threedaymonk","id":17347,"avatar_url":"https://avatars.githubusercontent.com/u/17347?v=3","gravatar_id":"","url":"https://api.github.com/users/threedaymonk","html_url":"https://github.com/threedaymonk","followers_url":"https://api.github.com/users/threedaymonk/followers","following_url":"https://api.github.com/users/threedaymonk/following{/other_user}","gists_url":"https://api.github.com/users/threedaymonk/gists{/gist_id}","starred_url":"https://api.github.com/users/threedaymonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threedaymonk/subscriptions","organizations_url":"https://api.github.com/users/threedaymonk/orgs","repos_url":"https://api.github.com/users/threedaymonk/repos","events_url":"https://api.github.com/users/threedaymonk/events{/privacy}","received_events_url":"https://api.github.com/users/threedaymonk/received_events","type":"User","site_admin":false},"body":"We want to deliver emails out of the main request-response cycle so that delays or availability problems with the email provider do not affect the web experience. Rails 4.2 builds in `deliver_later` functionality that achieves this. This PR does not actually implement out-of-band email delivery, but puts in place the system upgrades that are a prerequisite.","created_at":"2015-05-27T14:51:34Z","updated_at":"2015-06-01T10:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"731e3380ed83178a55830937f3809c0270ccaf82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/216/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/e6374e9cf08067bebcbb86bf061d23700c5406ea","head":{"label":"ministryofjustice:upgrades","ref":"upgrades","sha":"e6374e9cf08067bebcbb86bf061d23700c5406ea","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":20570322,"name":"prison-visits","full_name":"ministryofjustice/prison-visits","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits","description":"","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits/releases{/id}","created_at":"2014-06-06T16:24:26Z","updated_at":"2015-05-08T13:08:25Z","pushed_at":"2015-05-29T12:44:50Z","git_url":"git://github.com/ministryofjustice/prison-visits.git","ssh_url":"git@github.com:ministryofjustice/prison-visits.git","clone_url":"https://github.com/ministryofjustice/prison-visits.git","svn_url":"https://github.com/ministryofjustice/prison-visits","homepage":"https://www.prisonvisits.service.gov.uk","size":10507,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"e811c98b0ddf5c0299630432dd6f59daebffc9a9","user":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":20570322,"name":"prison-visits","full_name":"ministryofjustice/prison-visits","owner":{"login":"ministryofjustice","id":2203574,"avatar_url":"https://avatars.githubusercontent.com/u/2203574?v=3","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/prison-visits","description":"","fork":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits","forks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/forks","keys_url":"https://api.github.com/repos/ministryofjustice/prison-visits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/prison-visits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/prison-visits/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/prison-visits/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/prison-visits/events","assignees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/prison-visits/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/prison-visits/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/prison-visits/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/prison-visits/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/prison-visits/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/prison-visits/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/prison-visits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/prison-visits/merges","archive_url":"https://api.github.com/repos/ministryofjustice/prison-visits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/prison-visits/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/prison-visits/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/prison-visits/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/prison-visits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/prison-visits/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/prison-visits/releases{/id}","created_at":"2014-06-06T16:24:26Z","updated_at":"2015-05-08T13:08:25Z","pushed_at":"2015-05-29T12:44:50Z","git_url":"git://github.com/ministryofjustice/prison-visits.git","ssh_url":"git@github.com:ministryofjustice/prison-visits.git","clone_url":"https://github.com/ministryofjustice/prison-visits.git","svn_url":"https://github.com/ministryofjustice/prison-visits","homepage":"https://www.prisonvisits.service.gov.uk","size":10507,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216"},"html":{"href":"https://github.com/ministryofjustice/prison-visits/pull/216"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/216"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/prison-visits/statuses/e6374e9cf08067bebcbb86bf061d23700c5406ea"}}}}