{"action":"created","comment":{"url":"https://api.github.com/repos/Rademade/light_resizer/pulls/comments/41527655","id":41527655,"diff_hunk":"@@ -0,0 +1,82 @@\n+# -*- encoding : utf-8 -*-\n+require 'spec_helper'\n+\n+describe 'Middleware' do\n+\n+  context 'when request is for resize' do\n+\n+    context 'when resized image does not exist' do\n+\n+      context 'when all dimensions are allowed' do\n+\n+        context 'when without crop' do\n+\n+          before(:each) do\n+            visit '/uploads/test/light_resizer/200x200/dragon.jpg'\n+          end\n+\n+          it 'has status 200' do\n+            expect(page.status_code).to eq(200)\n+          end\n+\n+        end\n+\n+        context 'when with crop' do\n+\n+          before(:each) do\n+            visit '/uploads/test/light_resizer/crop/200x200/dragon.jpg'\n+          end\n+\n+          it 'has status 200' do\n+            expect(page.status_code).to eq(200)\n+          end\n+\n+        end\n+\n+      end\n+\n+      context 'when allowed dimensions set' do\n+\n+        before(:each) do\n+          LightResizer.configuration.allowed_dimensions = [[200, 200], [300, 200], [200, 300]]\n+        end\n+\n+        context 'when dimension is allowed' do\n+","path":"spec/features/middleware_spec.rb","position":45,"original_position":45,"commit_id":"6a61259aafc41f2708178330c7bec6d875b02e47","original_commit_id":"6a61259aafc41f2708178330c7bec6d875b02e47","user":{"login":"Rademade-review","id":13473820,"avatar_url":"https://avatars.githubusercontent.com/u/13473820?v=3","gravatar_id":"","url":"https://api.github.com/users/Rademade-review","html_url":"https://github.com/Rademade-review","followers_url":"https://api.github.com/users/Rademade-review/followers","following_url":"https://api.github.com/users/Rademade-review/following{/other_user}","gists_url":"https://api.github.com/users/Rademade-review/gists{/gist_id}","starred_url":"https://api.github.com/users/Rademade-review/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rademade-review/subscriptions","organizations_url":"https://api.github.com/users/Rademade-review/orgs","repos_url":"https://api.github.com/users/Rademade-review/repos","events_url":"https://api.github.com/users/Rademade-review/events{/privacy}","received_events_url":"https://api.github.com/users/Rademade-review/received_events","type":"User","site_admin":false},"body":"Extra empty line detected at block body beginning.","created_at":"2015-10-08T15:25:05Z","updated_at":"2015-10-08T15:25:05Z","html_url":"https://github.com/Rademade/light_resizer/pull/4#discussion_r41527655","pull_request_url":"https://api.github.com/repos/Rademade/light_resizer/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/comments/41527655"},"html":{"href":"https://github.com/Rademade/light_resizer/pull/4#discussion_r41527655"},"pull_request":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Rademade/light_resizer/pulls/4","id":47167315,"html_url":"https://github.com/Rademade/light_resizer/pull/4","diff_url":"https://github.com/Rademade/light_resizer/pull/4.diff","patch_url":"https://github.com/Rademade/light_resizer/pull/4.patch","issue_url":"https://api.github.com/repos/Rademade/light_resizer/issues/4","number":4,"state":"open","locked":false,"title":"Refactor/image optimizer","user":{"login":"Praffesor","id":7316153,"avatar_url":"https://avatars.githubusercontent.com/u/7316153?v=3","gravatar_id":"","url":"https://api.github.com/users/Praffesor","html_url":"https://github.com/Praffesor","followers_url":"https://api.github.com/users/Praffesor/followers","following_url":"https://api.github.com/users/Praffesor/following{/other_user}","gists_url":"https://api.github.com/users/Praffesor/gists{/gist_id}","starred_url":"https://api.github.com/users/Praffesor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Praffesor/subscriptions","organizations_url":"https://api.github.com/users/Praffesor/orgs","repos_url":"https://api.github.com/users/Praffesor/repos","events_url":"https://api.github.com/users/Praffesor/events{/privacy}","received_events_url":"https://api.github.com/users/Praffesor/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-08T15:24:26Z","updated_at":"2015-10-08T15:25:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a288586f3726586b53e5c44eaa78871dffd422c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Rademade/light_resizer/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Rademade/light_resizer/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Rademade/light_resizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rademade/light_resizer/issues/4/comments","statuses_url":"https://api.github.com/repos/Rademade/light_resizer/statuses/6a61259aafc41f2708178330c7bec6d875b02e47","head":{"label":"Rademade:refactor/image-optimizer","ref":"refactor/image-optimizer","sha":"6a61259aafc41f2708178330c7bec6d875b02e47","user":{"login":"Rademade","id":6436057,"avatar_url":"https://avatars.githubusercontent.com/u/6436057?v=3","gravatar_id":"","url":"https://api.github.com/users/Rademade","html_url":"https://github.com/Rademade","followers_url":"https://api.github.com/users/Rademade/followers","following_url":"https://api.github.com/users/Rademade/following{/other_user}","gists_url":"https://api.github.com/users/Rademade/gists{/gist_id}","starred_url":"https://api.github.com/users/Rademade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rademade/subscriptions","organizations_url":"https://api.github.com/users/Rademade/orgs","repos_url":"https://api.github.com/users/Rademade/repos","events_url":"https://api.github.com/users/Rademade/events{/privacy}","received_events_url":"https://api.github.com/users/Rademade/received_events","type":"Organization","site_admin":false},"repo":{"id":18641574,"name":"light_resizer","full_name":"Rademade/light_resizer","owner":{"login":"Rademade","id":6436057,"avatar_url":"https://avatars.githubusercontent.com/u/6436057?v=3","gravatar_id":"","url":"https://api.github.com/users/Rademade","html_url":"https://github.com/Rademade","followers_url":"https://api.github.com/users/Rademade/followers","following_url":"https://api.github.com/users/Rademade/following{/other_user}","gists_url":"https://api.github.com/users/Rademade/gists{/gist_id}","starred_url":"https://api.github.com/users/Rademade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rademade/subscriptions","organizations_url":"https://api.github.com/users/Rademade/orgs","repos_url":"https://api.github.com/users/Rademade/repos","events_url":"https://api.github.com/users/Rademade/events{/privacy}","received_events_url":"https://api.github.com/users/Rademade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rademade/light_resizer","description":"Rack middleware for image resizer. Can be integrated with CarrierWave.","fork":false,"url":"https://api.github.com/repos/Rademade/light_resizer","forks_url":"https://api.github.com/repos/Rademade/light_resizer/forks","keys_url":"https://api.github.com/repos/Rademade/light_resizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rademade/light_resizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rademade/light_resizer/teams","hooks_url":"https://api.github.com/repos/Rademade/light_resizer/hooks","issue_events_url":"https://api.github.com/repos/Rademade/light_resizer/issues/events{/number}","events_url":"https://api.github.com/repos/Rademade/light_resizer/events","assignees_url":"https://api.github.com/repos/Rademade/light_resizer/assignees{/user}","branches_url":"https://api.github.com/repos/Rademade/light_resizer/branches{/branch}","tags_url":"https://api.github.com/repos/Rademade/light_resizer/tags","blobs_url":"https://api.github.com/repos/Rademade/light_resizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rademade/light_resizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rademade/light_resizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rademade/light_resizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rademade/light_resizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Rademade/light_resizer/languages","stargazers_url":"https://api.github.com/repos/Rademade/light_resizer/stargazers","contributors_url":"https://api.github.com/repos/Rademade/light_resizer/contributors","subscribers_url":"https://api.github.com/repos/Rademade/light_resizer/subscribers","subscription_url":"https://api.github.com/repos/Rademade/light_resizer/subscription","commits_url":"https://api.github.com/repos/Rademade/light_resizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rademade/light_resizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rademade/light_resizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rademade/light_resizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rademade/light_resizer/contents/{+path}","compare_url":"https://api.github.com/repos/Rademade/light_resizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rademade/light_resizer/merges","archive_url":"https://api.github.com/repos/Rademade/light_resizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rademade/light_resizer/downloads","issues_url":"https://api.github.com/repos/Rademade/light_resizer/issues{/number}","pulls_url":"https://api.github.com/repos/Rademade/light_resizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Rademade/light_resizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Rademade/light_resizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rademade/light_resizer/labels{/name}","releases_url":"https://api.github.com/repos/Rademade/light_resizer/releases{/id}","created_at":"2014-04-10T15:28:30Z","updated_at":"2015-06-30T09:00:35Z","pushed_at":"2015-10-08T15:24:27Z","git_url":"git://github.com/Rademade/light_resizer.git","ssh_url":"git@github.com:Rademade/light_resizer.git","clone_url":"https://github.com/Rademade/light_resizer.git","svn_url":"https://github.com/Rademade/light_resizer","homepage":"","size":836,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"Rademade:master","ref":"master","sha":"509d61d4b91392f34ccec940bad370c1404d8327","user":{"login":"Rademade","id":6436057,"avatar_url":"https://avatars.githubusercontent.com/u/6436057?v=3","gravatar_id":"","url":"https://api.github.com/users/Rademade","html_url":"https://github.com/Rademade","followers_url":"https://api.github.com/users/Rademade/followers","following_url":"https://api.github.com/users/Rademade/following{/other_user}","gists_url":"https://api.github.com/users/Rademade/gists{/gist_id}","starred_url":"https://api.github.com/users/Rademade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rademade/subscriptions","organizations_url":"https://api.github.com/users/Rademade/orgs","repos_url":"https://api.github.com/users/Rademade/repos","events_url":"https://api.github.com/users/Rademade/events{/privacy}","received_events_url":"https://api.github.com/users/Rademade/received_events","type":"Organization","site_admin":false},"repo":{"id":18641574,"name":"light_resizer","full_name":"Rademade/light_resizer","owner":{"login":"Rademade","id":6436057,"avatar_url":"https://avatars.githubusercontent.com/u/6436057?v=3","gravatar_id":"","url":"https://api.github.com/users/Rademade","html_url":"https://github.com/Rademade","followers_url":"https://api.github.com/users/Rademade/followers","following_url":"https://api.github.com/users/Rademade/following{/other_user}","gists_url":"https://api.github.com/users/Rademade/gists{/gist_id}","starred_url":"https://api.github.com/users/Rademade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rademade/subscriptions","organizations_url":"https://api.github.com/users/Rademade/orgs","repos_url":"https://api.github.com/users/Rademade/repos","events_url":"https://api.github.com/users/Rademade/events{/privacy}","received_events_url":"https://api.github.com/users/Rademade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Rademade/light_resizer","description":"Rack middleware for image resizer. Can be integrated with CarrierWave.","fork":false,"url":"https://api.github.com/repos/Rademade/light_resizer","forks_url":"https://api.github.com/repos/Rademade/light_resizer/forks","keys_url":"https://api.github.com/repos/Rademade/light_resizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rademade/light_resizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rademade/light_resizer/teams","hooks_url":"https://api.github.com/repos/Rademade/light_resizer/hooks","issue_events_url":"https://api.github.com/repos/Rademade/light_resizer/issues/events{/number}","events_url":"https://api.github.com/repos/Rademade/light_resizer/events","assignees_url":"https://api.github.com/repos/Rademade/light_resizer/assignees{/user}","branches_url":"https://api.github.com/repos/Rademade/light_resizer/branches{/branch}","tags_url":"https://api.github.com/repos/Rademade/light_resizer/tags","blobs_url":"https://api.github.com/repos/Rademade/light_resizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rademade/light_resizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rademade/light_resizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rademade/light_resizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rademade/light_resizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Rademade/light_resizer/languages","stargazers_url":"https://api.github.com/repos/Rademade/light_resizer/stargazers","contributors_url":"https://api.github.com/repos/Rademade/light_resizer/contributors","subscribers_url":"https://api.github.com/repos/Rademade/light_resizer/subscribers","subscription_url":"https://api.github.com/repos/Rademade/light_resizer/subscription","commits_url":"https://api.github.com/repos/Rademade/light_resizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rademade/light_resizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rademade/light_resizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rademade/light_resizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rademade/light_resizer/contents/{+path}","compare_url":"https://api.github.com/repos/Rademade/light_resizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rademade/light_resizer/merges","archive_url":"https://api.github.com/repos/Rademade/light_resizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rademade/light_resizer/downloads","issues_url":"https://api.github.com/repos/Rademade/light_resizer/issues{/number}","pulls_url":"https://api.github.com/repos/Rademade/light_resizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Rademade/light_resizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Rademade/light_resizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rademade/light_resizer/labels{/name}","releases_url":"https://api.github.com/repos/Rademade/light_resizer/releases{/id}","created_at":"2014-04-10T15:28:30Z","updated_at":"2015-06-30T09:00:35Z","pushed_at":"2015-10-08T15:24:27Z","git_url":"git://github.com/Rademade/light_resizer.git","ssh_url":"git@github.com:Rademade/light_resizer.git","clone_url":"https://github.com/Rademade/light_resizer.git","svn_url":"https://github.com/Rademade/light_resizer","homepage":"","size":836,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/4"},"html":{"href":"https://github.com/Rademade/light_resizer/pull/4"},"issue":{"href":"https://api.github.com/repos/Rademade/light_resizer/issues/4"},"comments":{"href":"https://api.github.com/repos/Rademade/light_resizer/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rademade/light_resizer/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Rademade/light_resizer/statuses/6a61259aafc41f2708178330c7bec6d875b02e47"}}}}