{"action":"created","issue":{"url":"https://api.github.com/repos/beckermr/egret/issues/14","labels_url":"https://api.github.com/repos/beckermr/egret/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/beckermr/egret/issues/14/comments","events_url":"https://api.github.com/repos/beckermr/egret/issues/14/events","html_url":"https://github.com/beckermr/egret/pull/14","id":112498382,"number":14,"title":"added shear makers","user":{"login":"esheldon","id":621661,"avatar_url":"https://avatars.githubusercontent.com/u/621661?v=3","gravatar_id":"","url":"https://api.github.com/users/esheldon","html_url":"https://github.com/esheldon","followers_url":"https://api.github.com/users/esheldon/followers","following_url":"https://api.github.com/users/esheldon/following{/other_user}","gists_url":"https://api.github.com/users/esheldon/gists{/gist_id}","starred_url":"https://api.github.com/users/esheldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esheldon/subscriptions","organizations_url":"https://api.github.com/users/esheldon/orgs","repos_url":"https://api.github.com/users/esheldon/repos","events_url":"https://api.github.com/users/esheldon/events{/privacy}","received_events_url":"https://api.github.com/users/esheldon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-10-21T02:23:05Z","updated_at":"2015-11-15T23:20:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/beckermr/egret/pulls/14","html_url":"https://github.com/beckermr/egret/pull/14","diff_url":"https://github.com/beckermr/egret/pull/14.diff","patch_url":"https://github.com/beckermr/egret/pull/14.patch"},"body":"this code reworks how shear is specified in the config files and how shear PDFs are used in the code\r\n\r\nAn example config file is here\r\n\r\nhttps://github.com/esheldon/egretsims/blob/master/config/v10test.yaml"},"comment":{"url":"https://api.github.com/repos/beckermr/egret/issues/comments/156868498","html_url":"https://github.com/beckermr/egret/pull/14#issuecomment-156868498","issue_url":"https://api.github.com/repos/beckermr/egret/issues/14","id":156868498,"user":{"login":"beckermr","id":5296416,"avatar_url":"https://avatars.githubusercontent.com/u/5296416?v=3","gravatar_id":"","url":"https://api.github.com/users/beckermr","html_url":"https://github.com/beckermr","followers_url":"https://api.github.com/users/beckermr/followers","following_url":"https://api.github.com/users/beckermr/following{/other_user}","gists_url":"https://api.github.com/users/beckermr/gists{/gist_id}","starred_url":"https://api.github.com/users/beckermr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beckermr/subscriptions","organizations_url":"https://api.github.com/users/beckermr/orgs","repos_url":"https://api.github.com/users/beckermr/repos","events_url":"https://api.github.com/users/beckermr/events{/privacy}","received_events_url":"https://api.github.com/users/beckermr/received_events","type":"User","site_admin":false},"created_at":"2015-11-15T23:20:04Z","updated_at":"2015-11-15T23:20:04Z","body":"Getting back to this. Here are things I was trying to refer to.\r\n\r\n1. See this line in the example for how to pass the shear id into the medsmakers\r\n\r\nhttps://github.com/beckermr/egret/blob/master/egret/medsmakers.py#L14\r\n\r\nIn the simsimmaker, you would put this information here\r\n\r\nhttps://github.com/beckermr/egret/blob/master/egret/simpsimmakers.py#L41\r\n\r\nSomething like `extra_data = [('shear_id','i8')]`. You can see the psf per epoch extra data passed in there as well. (I also see a bug in my code here. The last one should be a += not an =!)\r\n\r\nOnce this is done, this line can be removed.\r\n\r\nhttps://github.com/beckermr/egret/pull/14/files#diff-8bec999b75078c12b96de901b488e2baR128\r\n\r\n2. Shear makers need to accept seeds and run their own rng. (I do think the rng framework needs work in egret, but this is what I have now.)\r\n\r\n3. In your commit, I was wondering about these lines starting here (and the ones above this)\r\n\r\nhttps://github.com/beckermr/egret/pull/14/files#diff-621496e2ea1fce6b40b218302b9a3175R22\r\n\r\nIt looks like you have leftover code from when the shear maker was instantiated from within the galaxymaker.\r\n\r\n \r\n\r\n"}}