{"action":"closed","number":1828,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828","id":45081385,"html_url":"https://github.com/jenkinsci/jenkins/pull/1828","diff_url":"https://github.com/jenkinsci/jenkins/pull/1828.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1828.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1828","number":1828,"state":"closed","locked":false,"title":"Improve readability of Jenkins.getTarget()","user":{"login":"deadmoose","id":132437,"avatar_url":"https://avatars.githubusercontent.com/u/132437?v=3","gravatar_id":"","url":"https://api.github.com/users/deadmoose","html_url":"https://github.com/deadmoose","followers_url":"https://api.github.com/users/deadmoose/followers","following_url":"https://api.github.com/users/deadmoose/following{/other_user}","gists_url":"https://api.github.com/users/deadmoose/gists{/gist_id}","starred_url":"https://api.github.com/users/deadmoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadmoose/subscriptions","organizations_url":"https://api.github.com/users/deadmoose/orgs","repos_url":"https://api.github.com/users/deadmoose/repos","events_url":"https://api.github.com/users/deadmoose/events{/privacy}","received_events_url":"https://api.github.com/users/deadmoose/received_events","type":"User","site_admin":false},"body":"The ~dozen inlined options and braceless conditional weren't the easiest\r\nto read, especially with the one compound statement in there. Took me a\r\nminute to convince myself that operator precedence & associativity\r\nreally made that work as intended.\r\n\r\nI *think* those strings could drop their slashes and be combined with\r\nthe other loop (e.g. go over\r\nSets.concat(ALWAYS_READABLE_PATHS, getUnprotectedRootActions()), but\r\nwithout spending more time confirming that, I'm leaving the behavior\r\nexactly the same as it was before.","created_at":"2015-09-15T17:58:40Z","updated_at":"2015-09-17T18:40:10Z","closed_at":"2015-09-17T18:40:10Z","merged_at":"2015-09-17T18:40:10Z","merge_commit_sha":"65f3e1d2f2f99e561a3e4f48e47214d1867973f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1828/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/9f5f292f3fe1dac2689c5d5437cca13c5b395473","head":{"label":"deadmoose:unprotected_urls","ref":"unprotected_urls","sha":"9f5f292f3fe1dac2689c5d5437cca13c5b395473","user":{"login":"deadmoose","id":132437,"avatar_url":"https://avatars.githubusercontent.com/u/132437?v=3","gravatar_id":"","url":"https://api.github.com/users/deadmoose","html_url":"https://github.com/deadmoose","followers_url":"https://api.github.com/users/deadmoose/followers","following_url":"https://api.github.com/users/deadmoose/following{/other_user}","gists_url":"https://api.github.com/users/deadmoose/gists{/gist_id}","starred_url":"https://api.github.com/users/deadmoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadmoose/subscriptions","organizations_url":"https://api.github.com/users/deadmoose/orgs","repos_url":"https://api.github.com/users/deadmoose/repos","events_url":"https://api.github.com/users/deadmoose/events{/privacy}","received_events_url":"https://api.github.com/users/deadmoose/received_events","type":"User","site_admin":false},"repo":{"id":26990460,"name":"jenkins","full_name":"deadmoose/jenkins","owner":{"login":"deadmoose","id":132437,"avatar_url":"https://avatars.githubusercontent.com/u/132437?v=3","gravatar_id":"","url":"https://api.github.com/users/deadmoose","html_url":"https://github.com/deadmoose","followers_url":"https://api.github.com/users/deadmoose/followers","following_url":"https://api.github.com/users/deadmoose/following{/other_user}","gists_url":"https://api.github.com/users/deadmoose/gists{/gist_id}","starred_url":"https://api.github.com/users/deadmoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadmoose/subscriptions","organizations_url":"https://api.github.com/users/deadmoose/orgs","repos_url":"https://api.github.com/users/deadmoose/repos","events_url":"https://api.github.com/users/deadmoose/events{/privacy}","received_events_url":"https://api.github.com/users/deadmoose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deadmoose/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/deadmoose/jenkins","forks_url":"https://api.github.com/repos/deadmoose/jenkins/forks","keys_url":"https://api.github.com/repos/deadmoose/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deadmoose/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deadmoose/jenkins/teams","hooks_url":"https://api.github.com/repos/deadmoose/jenkins/hooks","issue_events_url":"https://api.github.com/repos/deadmoose/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/deadmoose/jenkins/events","assignees_url":"https://api.github.com/repos/deadmoose/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/deadmoose/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/deadmoose/jenkins/tags","blobs_url":"https://api.github.com/repos/deadmoose/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deadmoose/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deadmoose/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/deadmoose/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deadmoose/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/deadmoose/jenkins/languages","stargazers_url":"https://api.github.com/repos/deadmoose/jenkins/stargazers","contributors_url":"https://api.github.com/repos/deadmoose/jenkins/contributors","subscribers_url":"https://api.github.com/repos/deadmoose/jenkins/subscribers","subscription_url":"https://api.github.com/repos/deadmoose/jenkins/subscription","commits_url":"https://api.github.com/repos/deadmoose/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/deadmoose/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/deadmoose/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/deadmoose/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/deadmoose/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/deadmoose/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deadmoose/jenkins/merges","archive_url":"https://api.github.com/repos/deadmoose/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deadmoose/jenkins/downloads","issues_url":"https://api.github.com/repos/deadmoose/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/deadmoose/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/deadmoose/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/deadmoose/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deadmoose/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/deadmoose/jenkins/releases{/id}","created_at":"2014-11-22T06:04:03Z","updated_at":"2014-11-22T06:04:22Z","pushed_at":"2015-09-15T17:57:17Z","git_url":"git://github.com/deadmoose/jenkins.git","ssh_url":"git@github.com:deadmoose/jenkins.git","clone_url":"https://github.com/deadmoose/jenkins.git","svn_url":"https://github.com/deadmoose/jenkins","homepage":"http://jenkins-ci.org/","size":87615,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"a00c3a7e0e36423fd11866029e814a8c8f9844eb","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-09-17T15:12:27Z","pushed_at":"2015-09-17T18:40:10Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":450152,"stargazers_count":4533,"watchers_count":4533,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2014,"mirror_url":null,"open_issues_count":119,"forks":2014,"open_issues":119,"watchers":4533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1828"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1828"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1828/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1828/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/9f5f292f3fe1dac2689c5d5437cca13c5b395473"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":31,"deletions":14,"changed_files":1}}