{"action":"created","issue":{"url":"https://api.github.com/repos/danmar/cppcheck/issues/628","labels_url":"https://api.github.com/repos/danmar/cppcheck/issues/628/labels{/name}","comments_url":"https://api.github.com/repos/danmar/cppcheck/issues/628/comments","events_url":"https://api.github.com/repos/danmar/cppcheck/issues/628/events","html_url":"https://github.com/danmar/cppcheck/pull/628","id":97060612,"number":628,"title":"Get rid of C4282 portability warning","user":{"login":"Dmitry-Me","id":1277095,"avatar_url":"https://avatars.githubusercontent.com/u/1277095?v=3","gravatar_id":"","url":"https://api.github.com/users/Dmitry-Me","html_url":"https://github.com/Dmitry-Me","followers_url":"https://api.github.com/users/Dmitry-Me/followers","following_url":"https://api.github.com/users/Dmitry-Me/following{/other_user}","gists_url":"https://api.github.com/users/Dmitry-Me/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitry-Me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitry-Me/subscriptions","organizations_url":"https://api.github.com/users/Dmitry-Me/orgs","repos_url":"https://api.github.com/users/Dmitry-Me/repos","events_url":"https://api.github.com/users/Dmitry-Me/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitry-Me/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-07-24T14:05:26Z","updated_at":"2015-07-25T09:54:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/danmar/cppcheck/pulls/628","html_url":"https://github.com/danmar/cppcheck/pull/628","diff_url":"https://github.com/danmar/cppcheck/pull/628.diff","patch_url":"https://github.com/danmar/cppcheck/pull/628.patch"},"body":"AppVeyor builds contain a lot of messages like this:\r\n\r\n>warning C4482: nonstandard extension used: enum 'ValueFlow::Value::ValueKind' used in qualified name\r\n\r\nwhich says this code is non-portable. gcc refuses to compile such code."},"comment":{"url":"https://api.github.com/repos/danmar/cppcheck/issues/comments/124829532","html_url":"https://github.com/danmar/cppcheck/pull/628#issuecomment-124829532","issue_url":"https://api.github.com/repos/danmar/cppcheck/issues/628","id":124829532,"user":{"login":"PKEuS","id":731902,"avatar_url":"https://avatars.githubusercontent.com/u/731902?v=3","gravatar_id":"","url":"https://api.github.com/users/PKEuS","html_url":"https://github.com/PKEuS","followers_url":"https://api.github.com/users/PKEuS/followers","following_url":"https://api.github.com/users/PKEuS/following{/other_user}","gists_url":"https://api.github.com/users/PKEuS/gists{/gist_id}","starred_url":"https://api.github.com/users/PKEuS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKEuS/subscriptions","organizations_url":"https://api.github.com/users/PKEuS/orgs","repos_url":"https://api.github.com/users/PKEuS/repos","events_url":"https://api.github.com/users/PKEuS/events{/privacy}","received_events_url":"https://api.github.com/users/PKEuS/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T09:54:38Z","updated_at":"2015-07-25T09:54:38Z","body":"> neat comment explaining why a warning is being manipulated\r\n\r\nThe reason is always the same if we disable a warning (on a global level): It only generates noise.\r\n\r\n> no risk of suppressions lost when upgrading a project\r\n\r\nThere is no such risk. Either the warning number changes, then it would affect the #pragma-solution as well, or it does not change, then the project file will be converted without losses.\r\n\r\n> Code already contains  #ifdef _MSC_VER .\r\n\r\nOnly in single files, not in a file included everywhere. There is #if defined(_MSC_VER) && defined(_DEBUG), but that is a different configuration to our preprocessor.\r\n\r\n"}}