{"action":"created","comment":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/23565903","id":23565903,"diff_hunk":"@@ -27,35 +27,16 @@ ListPlugin.prototype.bindEvents = function() {\n     var listPlugin = this,\n         wym = listPlugin._wym;\n \n-    // Bind a key listener so we can handle tabs\n-    // With jQuery 1.3, live() can be used to simplify handler logic\n-    jQuery(wym._doc).bind('keydown', listPlugin.handleKeyDown);\n-};\n-\n-/**\n- * Handle any tab presses when inside list items and indent/outdent.\n- */\n-ListPlugin.prototype.handleKeyDown = function(evt) {\n-    var doc = this,\n-        wym = WYMeditor.INSTANCES[doc.title],\n-        listPlugin = wym.listPlugin,\n-        container = wym.selectedContainer();\n-        name = container.tagName.toLowerCase();\n-    // We only care about tabs when we're inside a list\n-    if (name != \"li\") {\n-        return null;\n-    }\n-\n-    // Handle tab presses\n-    if (evt.which == WYMeditor.KEY_CODE.TAB) {\n-        if (evt.shiftKey) {\n-            wym.exec(WYMeditor.EXEC_COMMANDS.OUTDENT);\n-            return false; // Short-circuit normal tab behavior\n-        } else {\n+    wym.keyboard.combokeys.bind(\n+        \"tab\",\n+        function () {\n             wym.exec(WYMeditor.EXEC_COMMANDS.INDENT);\n-            return false;\n         }\n-    }\n-\n-    return null;\n+    );\n+    wym.keyboard.combokeys.bind(\n+        \"shift+tab\",\n+        function () {\n+            wym.exec(WYMeditor.EXEC_COMMANDS.OUTDENT);","path":"src/wymeditor/plugins/list/jquery.wymeditor.list.js","position":42,"original_position":42,"commit_id":"0d11d62045919b7ce670a9439a8ff974c93ab209","original_commit_id":"0d11d62045919b7ce670a9439a8ff974c93ab209","user":{"login":"winhamwr","id":56973,"avatar_url":"https://avatars.githubusercontent.com/u/56973?v=3","gravatar_id":"","url":"https://api.github.com/users/winhamwr","html_url":"https://github.com/winhamwr","followers_url":"https://api.github.com/users/winhamwr/followers","following_url":"https://api.github.com/users/winhamwr/following{/other_user}","gists_url":"https://api.github.com/users/winhamwr/gists{/gist_id}","starred_url":"https://api.github.com/users/winhamwr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winhamwr/subscriptions","organizations_url":"https://api.github.com/users/winhamwr/orgs","repos_url":"https://api.github.com/users/winhamwr/repos","events_url":"https://api.github.com/users/winhamwr/events{/privacy}","received_events_url":"https://api.github.com/users/winhamwr/received_events","type":"User","site_admin":false},"body":"And we don't need to short-circuit default behavior by returning false?","created_at":"2015-01-26T21:30:43Z","updated_at":"2015-01-26T21:30:43Z","html_url":"https://github.com/wymeditor/wymeditor/pull/624#discussion_r23565903","pull_request_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624","_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/23565903"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/624#discussion_r23565903"},"pull_request":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624"}}},"pull_request":{"url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624","id":24898954,"html_url":"https://github.com/wymeditor/wymeditor/pull/624","diff_url":"https://github.com/wymeditor/wymeditor/pull/624.diff","patch_url":"https://github.com/wymeditor/wymeditor/pull/624.patch","issue_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/624","number":624,"state":"open","locked":false,"title":"Combokeys","user":{"login":"mightyiam","id":635591,"avatar_url":"https://avatars.githubusercontent.com/u/635591?v=3","gravatar_id":"","url":"https://api.github.com/users/mightyiam","html_url":"https://github.com/mightyiam","followers_url":"https://api.github.com/users/mightyiam/followers","following_url":"https://api.github.com/users/mightyiam/following{/other_user}","gists_url":"https://api.github.com/users/mightyiam/gists{/gist_id}","starred_url":"https://api.github.com/users/mightyiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mightyiam/subscriptions","organizations_url":"https://api.github.com/users/mightyiam/orgs","repos_url":"https://api.github.com/users/mightyiam/repos","events_url":"https://api.github.com/users/mightyiam/events{/privacy}","received_events_url":"https://api.github.com/users/mightyiam/received_events","type":"User","site_admin":false},"body":null,"created_at":"2014-11-23T07:58:49Z","updated_at":"2015-01-26T21:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dda133b672b8f45ba3f2e1f1a2e46dfef1419465","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624/commits","review_comments_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624/comments","review_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/624/comments","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/0d11d62045919b7ce670a9439a8ff974c93ab209","head":{"label":"wymeditor:kb-shortcuts","ref":"kb-shortcuts","sha":"0d11d62045919b7ce670a9439a8ff974c93ab209","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2015-01-26T21:08:58Z","pushed_at":"2015-01-26T21:08:58Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":16941,"stargazers_count":484,"watchers_count":484,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":112,"forks":98,"open_issues":112,"watchers":484,"default_branch":"master"}},"base":{"label":"wymeditor:master","ref":"master","sha":"f798cf5c6c40bcd14820eb16d4f00024df214649","user":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":483659,"name":"wymeditor","full_name":"wymeditor/wymeditor","owner":{"login":"wymeditor","id":187598,"avatar_url":"https://avatars.githubusercontent.com/u/187598?v=3","gravatar_id":"","url":"https://api.github.com/users/wymeditor","html_url":"https://github.com/wymeditor","followers_url":"https://api.github.com/users/wymeditor/followers","following_url":"https://api.github.com/users/wymeditor/following{/other_user}","gists_url":"https://api.github.com/users/wymeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/wymeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wymeditor/subscriptions","organizations_url":"https://api.github.com/users/wymeditor/orgs","repos_url":"https://api.github.com/users/wymeditor/repos","events_url":"https://api.github.com/users/wymeditor/events{/privacy}","received_events_url":"https://api.github.com/users/wymeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wymeditor/wymeditor","description":"Pure js cross-browser WYSIWYM editor with a focus on the clean separation of content and styling.","fork":false,"url":"https://api.github.com/repos/wymeditor/wymeditor","forks_url":"https://api.github.com/repos/wymeditor/wymeditor/forks","keys_url":"https://api.github.com/repos/wymeditor/wymeditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wymeditor/wymeditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wymeditor/wymeditor/teams","hooks_url":"https://api.github.com/repos/wymeditor/wymeditor/hooks","issue_events_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/events{/number}","events_url":"https://api.github.com/repos/wymeditor/wymeditor/events","assignees_url":"https://api.github.com/repos/wymeditor/wymeditor/assignees{/user}","branches_url":"https://api.github.com/repos/wymeditor/wymeditor/branches{/branch}","tags_url":"https://api.github.com/repos/wymeditor/wymeditor/tags","blobs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wymeditor/wymeditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wymeditor/wymeditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/wymeditor/wymeditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wymeditor/wymeditor/statuses/{sha}","languages_url":"https://api.github.com/repos/wymeditor/wymeditor/languages","stargazers_url":"https://api.github.com/repos/wymeditor/wymeditor/stargazers","contributors_url":"https://api.github.com/repos/wymeditor/wymeditor/contributors","subscribers_url":"https://api.github.com/repos/wymeditor/wymeditor/subscribers","subscription_url":"https://api.github.com/repos/wymeditor/wymeditor/subscription","commits_url":"https://api.github.com/repos/wymeditor/wymeditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/wymeditor/wymeditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/wymeditor/wymeditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/wymeditor/wymeditor/issues/comments/{number}","contents_url":"https://api.github.com/repos/wymeditor/wymeditor/contents/{+path}","compare_url":"https://api.github.com/repos/wymeditor/wymeditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wymeditor/wymeditor/merges","archive_url":"https://api.github.com/repos/wymeditor/wymeditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wymeditor/wymeditor/downloads","issues_url":"https://api.github.com/repos/wymeditor/wymeditor/issues{/number}","pulls_url":"https://api.github.com/repos/wymeditor/wymeditor/pulls{/number}","milestones_url":"https://api.github.com/repos/wymeditor/wymeditor/milestones{/number}","notifications_url":"https://api.github.com/repos/wymeditor/wymeditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wymeditor/wymeditor/labels{/name}","releases_url":"https://api.github.com/repos/wymeditor/wymeditor/releases{/id}","created_at":"2010-01-22T10:50:59Z","updated_at":"2015-01-26T21:08:58Z","pushed_at":"2015-01-26T21:08:58Z","git_url":"git://github.com/wymeditor/wymeditor.git","ssh_url":"git@github.com:wymeditor/wymeditor.git","clone_url":"https://github.com/wymeditor/wymeditor.git","svn_url":"https://github.com/wymeditor/wymeditor","homepage":"http://wymeditor.github.io/wymeditor/","size":16941,"stargazers_count":484,"watchers_count":484,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":112,"forks":98,"open_issues":112,"watchers":484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624"},"html":{"href":"https://github.com/wymeditor/wymeditor/pull/624"},"issue":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/624"},"comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/issues/624/comments"},"review_comments":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624/comments"},"review_comment":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/wymeditor/wymeditor/pulls/624/commits"},"statuses":{"href":"https://api.github.com/repos/wymeditor/wymeditor/statuses/0d11d62045919b7ce670a9439a8ff974c93ab209"}}}}