{"action":"created","comment":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments/36550456","id":36550456,"diff_hunk":"@@ -100,7 +100,7 @@ AString cRsaPrivateKey::GetPubKeyDER(void)\n \t{\n \t\treturn AString();\n \t}\n-\treturn AString((const char *)(buf + sizeof(buf) - res), (size_t)res);\n+\treturn AString(static_cast<const char *>(static_cast<const void*>(buf + sizeof(buf) - res)), static_cast<size_t>(res));","path":"src/PolarSSL++/RsaPrivateKey.cpp","position":5,"original_position":5,"commit_id":"2cd6aca8d3655e14ea78091cf81e6eee878f60c7","original_commit_id":"2cd6aca8d3655e14ea78091cf81e6eee878f60c7","user":{"login":"madmaxoft","id":4388386,"avatar_url":"https://avatars.githubusercontent.com/u/4388386?v=3","gravatar_id":"","url":"https://api.github.com/users/madmaxoft","html_url":"https://github.com/madmaxoft","followers_url":"https://api.github.com/users/madmaxoft/followers","following_url":"https://api.github.com/users/madmaxoft/following{/other_user}","gists_url":"https://api.github.com/users/madmaxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/madmaxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madmaxoft/subscriptions","organizations_url":"https://api.github.com/users/madmaxoft/orgs","repos_url":"https://api.github.com/users/madmaxoft/repos","events_url":"https://api.github.com/users/madmaxoft/events{/privacy}","received_events_url":"https://api.github.com/users/madmaxoft/received_events","type":"User","site_admin":false},"body":"This should probably be a `reinterpret_cast`:\r\n```cpp\r\nreturn AString(reinterpret_cast<const char *>(buf + sizeof(buf) - res), static_cast<size_t>(res));\r\n```","created_at":"2015-08-07T19:01:40Z","updated_at":"2015-08-07T19:01:40Z","html_url":"https://github.com/cuberite/cuberite/pull/2417#discussion_r36550456","pull_request_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2417","_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments/36550456"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2417#discussion_r36550456"},"pull_request":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2417"}}},"pull_request":{"url":"https://api.github.com/repos/cuberite/cuberite/pulls/2417","id":41710908,"html_url":"https://github.com/cuberite/cuberite/pull/2417","diff_url":"https://github.com/cuberite/cuberite/pull/2417.diff","patch_url":"https://github.com/cuberite/cuberite/pull/2417.patch","issue_url":"https://api.github.com/repos/cuberite/cuberite/issues/2417","number":2417,"state":"open","locked":false,"title":"Fix compilation warnings related to implicit and old-style casts","user":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"body":"The compilation output on OS X is rather noisy. This PR tackles some of this by fixing old-style casts and changing some implicit casts into explicit ones.","created_at":"2015-08-05T18:34:49Z","updated_at":"2015-08-07T19:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b023e0b93de0fc4827c2ea9536f42347be5213b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2417/commits","review_comments_url":"https://api.github.com/repos/cuberite/cuberite/pulls/2417/comments","review_comment_url":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cuberite/cuberite/issues/2417/comments","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/2cd6aca8d3655e14ea78091cf81e6eee878f60c7","head":{"label":"mjhanninen:fix-clang-warnings","ref":"fix-clang-warnings","sha":"2cd6aca8d3655e14ea78091cf81e6eee878f60c7","user":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"repo":{"id":39391065,"name":"cuberite","full_name":"mjhanninen/cuberite","owner":{"login":"mjhanninen","id":82970,"avatar_url":"https://avatars.githubusercontent.com/u/82970?v=3","gravatar_id":"","url":"https://api.github.com/users/mjhanninen","html_url":"https://github.com/mjhanninen","followers_url":"https://api.github.com/users/mjhanninen/followers","following_url":"https://api.github.com/users/mjhanninen/following{/other_user}","gists_url":"https://api.github.com/users/mjhanninen/gists{/gist_id}","starred_url":"https://api.github.com/users/mjhanninen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjhanninen/subscriptions","organizations_url":"https://api.github.com/users/mjhanninen/orgs","repos_url":"https://api.github.com/users/mjhanninen/repos","events_url":"https://api.github.com/users/mjhanninen/events{/privacy}","received_events_url":"https://api.github.com/users/mjhanninen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjhanninen/cuberite","description":"A performant C++ Minecraft compatible game server","fork":true,"url":"https://api.github.com/repos/mjhanninen/cuberite","forks_url":"https://api.github.com/repos/mjhanninen/cuberite/forks","keys_url":"https://api.github.com/repos/mjhanninen/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjhanninen/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjhanninen/cuberite/teams","hooks_url":"https://api.github.com/repos/mjhanninen/cuberite/hooks","issue_events_url":"https://api.github.com/repos/mjhanninen/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/mjhanninen/cuberite/events","assignees_url":"https://api.github.com/repos/mjhanninen/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/mjhanninen/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/mjhanninen/cuberite/tags","blobs_url":"https://api.github.com/repos/mjhanninen/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjhanninen/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjhanninen/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjhanninen/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjhanninen/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/mjhanninen/cuberite/languages","stargazers_url":"https://api.github.com/repos/mjhanninen/cuberite/stargazers","contributors_url":"https://api.github.com/repos/mjhanninen/cuberite/contributors","subscribers_url":"https://api.github.com/repos/mjhanninen/cuberite/subscribers","subscription_url":"https://api.github.com/repos/mjhanninen/cuberite/subscription","commits_url":"https://api.github.com/repos/mjhanninen/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjhanninen/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjhanninen/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjhanninen/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjhanninen/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/mjhanninen/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjhanninen/cuberite/merges","archive_url":"https://api.github.com/repos/mjhanninen/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjhanninen/cuberite/downloads","issues_url":"https://api.github.com/repos/mjhanninen/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/mjhanninen/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/mjhanninen/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/mjhanninen/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjhanninen/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/mjhanninen/cuberite/releases{/id}","created_at":"2015-07-20T15:11:51Z","updated_at":"2015-07-20T15:11:55Z","pushed_at":"2015-08-07T17:17:53Z","git_url":"git://github.com/mjhanninen/cuberite.git","ssh_url":"git@github.com:mjhanninen/cuberite.git","clone_url":"https://github.com/mjhanninen/cuberite.git","svn_url":"https://github.com/mjhanninen/cuberite","homepage":"http://cuberite.org","size":77381,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cuberite:master","ref":"master","sha":"6fdc4a1ea3fd558244bdb39cd97971ad33b2cc5f","user":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"repo":{"id":11693709,"name":"cuberite","full_name":"cuberite/cuberite","owner":{"login":"cuberite","id":8973961,"avatar_url":"https://avatars.githubusercontent.com/u/8973961?v=3","gravatar_id":"","url":"https://api.github.com/users/cuberite","html_url":"https://github.com/cuberite","followers_url":"https://api.github.com/users/cuberite/followers","following_url":"https://api.github.com/users/cuberite/following{/other_user}","gists_url":"https://api.github.com/users/cuberite/gists{/gist_id}","starred_url":"https://api.github.com/users/cuberite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuberite/subscriptions","organizations_url":"https://api.github.com/users/cuberite/orgs","repos_url":"https://api.github.com/users/cuberite/repos","events_url":"https://api.github.com/users/cuberite/events{/privacy}","received_events_url":"https://api.github.com/users/cuberite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cuberite/cuberite","description":"A performant C++ Minecraft compatible game server","fork":false,"url":"https://api.github.com/repos/cuberite/cuberite","forks_url":"https://api.github.com/repos/cuberite/cuberite/forks","keys_url":"https://api.github.com/repos/cuberite/cuberite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cuberite/cuberite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cuberite/cuberite/teams","hooks_url":"https://api.github.com/repos/cuberite/cuberite/hooks","issue_events_url":"https://api.github.com/repos/cuberite/cuberite/issues/events{/number}","events_url":"https://api.github.com/repos/cuberite/cuberite/events","assignees_url":"https://api.github.com/repos/cuberite/cuberite/assignees{/user}","branches_url":"https://api.github.com/repos/cuberite/cuberite/branches{/branch}","tags_url":"https://api.github.com/repos/cuberite/cuberite/tags","blobs_url":"https://api.github.com/repos/cuberite/cuberite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cuberite/cuberite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cuberite/cuberite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cuberite/cuberite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cuberite/cuberite/statuses/{sha}","languages_url":"https://api.github.com/repos/cuberite/cuberite/languages","stargazers_url":"https://api.github.com/repos/cuberite/cuberite/stargazers","contributors_url":"https://api.github.com/repos/cuberite/cuberite/contributors","subscribers_url":"https://api.github.com/repos/cuberite/cuberite/subscribers","subscription_url":"https://api.github.com/repos/cuberite/cuberite/subscription","commits_url":"https://api.github.com/repos/cuberite/cuberite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cuberite/cuberite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cuberite/cuberite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cuberite/cuberite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cuberite/cuberite/contents/{+path}","compare_url":"https://api.github.com/repos/cuberite/cuberite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cuberite/cuberite/merges","archive_url":"https://api.github.com/repos/cuberite/cuberite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cuberite/cuberite/downloads","issues_url":"https://api.github.com/repos/cuberite/cuberite/issues{/number}","pulls_url":"https://api.github.com/repos/cuberite/cuberite/pulls{/number}","milestones_url":"https://api.github.com/repos/cuberite/cuberite/milestones{/number}","notifications_url":"https://api.github.com/repos/cuberite/cuberite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cuberite/cuberite/labels{/name}","releases_url":"https://api.github.com/repos/cuberite/cuberite/releases{/id}","created_at":"2013-07-26T19:56:59Z","updated_at":"2015-08-07T16:48:09Z","pushed_at":"2015-08-07T17:17:54Z","git_url":"git://github.com/cuberite/cuberite.git","ssh_url":"git@github.com:cuberite/cuberite.git","clone_url":"https://github.com/cuberite/cuberite.git","svn_url":"https://github.com/cuberite/cuberite","homepage":"http://cuberite.org","size":166491,"stargazers_count":713,"watchers_count":713,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":382,"forks":222,"open_issues":382,"watchers":713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2417"},"html":{"href":"https://github.com/cuberite/cuberite/pull/2417"},"issue":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2417"},"comments":{"href":"https://api.github.com/repos/cuberite/cuberite/issues/2417/comments"},"review_comments":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2417/comments"},"review_comment":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cuberite/cuberite/pulls/2417/commits"},"statuses":{"href":"https://api.github.com/repos/cuberite/cuberite/statuses/2cd6aca8d3655e14ea78091cf81e6eee878f60c7"}}}}