{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react/issues/3605","labels_url":"https://api.github.com/repos/facebook/react/issues/3605/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react/issues/3605/comments","events_url":"https://api.github.com/repos/facebook/react/issues/3605/events","html_url":"https://github.com/facebook/react/pull/3605","id":66826690,"number":3605,"title":"ReactEventListener.dispatchEvent should ignore non own documents.","user":{"login":"azproduction","id":483865,"avatar_url":"https://avatars.githubusercontent.com/u/483865?v=3","gravatar_id":"","url":"https://api.github.com/users/azproduction","html_url":"https://github.com/azproduction","followers_url":"https://api.github.com/users/azproduction/followers","following_url":"https://api.github.com/users/azproduction/following{/other_user}","gists_url":"https://api.github.com/users/azproduction/gists{/gist_id}","starred_url":"https://api.github.com/users/azproduction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azproduction/subscriptions","organizations_url":"https://api.github.com/users/azproduction/orgs","repos_url":"https://api.github.com/users/azproduction/repos","events_url":"https://api.github.com/users/azproduction/events{/privacy}","received_events_url":"https://api.github.com/users/azproduction/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-07T08:45:05Z","updated_at":"2015-04-22T17:57:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/3605","html_url":"https://github.com/facebook/react/pull/3605","diff_url":"https://github.com/facebook/react/pull/3605.diff","patch_url":"https://github.com/facebook/react/pull/3605.patch"},"body":"We are writing firefox sidebar plugin with React and faced some issues with dead objects. \r\n\r\nDue to overprivileged environment of plugin event can bubble/capture out of iframe. And if surrounded application has React instance it captures `event.target` of element of non own document. After reloading the iframe and trying to interact with iframe content it throws an exception about Firefox dead object(garbage collected DOM element).\r\n```\r\n+sidebar------+\r\n|React1       |\r\n|             |\r\n|  +iframe-+  |\r\n|  |React2 |  |\r\n|  |       |  |\r\n|  +-------+  |\r\n|             |\r\n+-------------+\r\n```\r\nAlso it could lead to an issue with the same `reactId`: `Error: Invariant Violation: ReactMount: Two valid but unequal nodes with the same data-reactid: .0`.\r\n\r\nPlease find the example Firefox plugin along with the souce code: https://dl.dropboxusercontent.com/u/37680916/react-bug.zip"},"comment":{"url":"https://api.github.com/repos/facebook/react/issues/comments/95284353","html_url":"https://github.com/facebook/react/pull/3605#issuecomment-95284353","issue_url":"https://api.github.com/repos/facebook/react/issues/3605","id":95284353,"user":{"login":"syranide","id":1714255,"avatar_url":"https://avatars.githubusercontent.com/u/1714255?v=3","gravatar_id":"","url":"https://api.github.com/users/syranide","html_url":"https://github.com/syranide","followers_url":"https://api.github.com/users/syranide/followers","following_url":"https://api.github.com/users/syranide/following{/other_user}","gists_url":"https://api.github.com/users/syranide/gists{/gist_id}","starred_url":"https://api.github.com/users/syranide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syranide/subscriptions","organizations_url":"https://api.github.com/users/syranide/orgs","repos_url":"https://api.github.com/users/syranide/repos","events_url":"https://api.github.com/users/syranide/events{/privacy}","received_events_url":"https://api.github.com/users/syranide/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T17:57:33Z","updated_at":"2015-04-22T17:57:33Z","body":"@zpao React officially supports rendering into iframes so separating by document seems like a no-go (and this would exclude shadow documents too I think?). Ultimately I think the solution is to drop `data-reactid` but it may take a while (but may be possible soonish). For now I've recommended people to use https://github.com/facebook/react/issues/2713#issuecomment-67462102. It could probably be built into the `data-reactid` itself (or at least publicly exposed for now), but at the cost of more overhead, so I'm not sure how keen you guys are on that."}}