{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/7139","labels_url":"https://api.github.com/repos/servo/servo/issues/7139/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/7139/comments","events_url":"https://api.github.com/repos/servo/servo/issues/7139/events","html_url":"https://github.com/servo/servo/pull/7139","id":100180341,"number":7139,"title":"Testable net load...","user":{"login":"samfoo","id":26163,"avatar_url":"https://avatars.githubusercontent.com/u/26163?v=3","gravatar_id":"","url":"https://api.github.com/users/samfoo","html_url":"https://github.com/samfoo","followers_url":"https://api.github.com/users/samfoo/followers","following_url":"https://api.github.com/users/samfoo/following{/other_user}","gists_url":"https://api.github.com/users/samfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/samfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samfoo/subscriptions","organizations_url":"https://api.github.com/users/samfoo/orgs","repos_url":"https://api.github.com/users/samfoo/repos","events_url":"https://api.github.com/users/samfoo/events{/privacy}","received_events_url":"https://api.github.com/users/samfoo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-merge","name":"S-awaiting-merge","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars.githubusercontent.com/u/27658?v=3","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-08-10T22:07:22Z","updated_at":"2015-08-28T00:38:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/7139","html_url":"https://github.com/servo/servo/pull/7139","diff_url":"https://github.com/servo/servo/pull/7139.diff","patch_url":"https://github.com/servo/servo/pull/7139.patch"},"body":"*The goal of this PR is to get early feedback on this before I go too far down the rabbit hole. This new code path is working, and there's several tests I've written as a proof of concept. There are still some regressions that I'll be fixing in the coming days.*\r\n\r\nI've abstracted out the request/response cycle so that it's no longer dependent on the Hyper request/response structs. Since request/response @ hyper are structs, not traits, it made mocking them for tests impossible.\r\n\r\nCurrent issues/concerns:\r\n\r\n* This relies on boxing the `HttpResponse` that gets returned from the `HttpRequester` because `HttpResponse` is unsized. I don't know if there's a more idiomatic rust-y way of doing this?\r\n* This relies on boxing the `Read` that is now returned from `load` for the same reason.\r\n* The devtools and resource manager channels are still passed into `load`. It might be easier to inject these as trait dependencies instead of chans as well?\r\n* Needs more tests.\r\n\r\n:tophat: \r\n\r\n#6727\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/7139)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/135592519","html_url":"https://github.com/servo/servo/pull/7139#issuecomment-135592519","issue_url":"https://api.github.com/repos/servo/servo/issues/7139","id":135592519,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2015-08-28T00:38:36Z","updated_at":"2015-08-28T00:38:36Z","body":":hourglass: Testing commit ea45530 with merge 5736012..."}}