{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/44017484","id":44017484,"diff_hunk":"@@ -0,0 +1,162 @@\n+/*\n+ * Copyright 2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.cloud.stream.module.dataset.sink;\n+\n+import org.springframework.beans.factory.annotation.Value;\n+import org.springframework.boot.context.properties.ConfigurationProperties;\n+\n+/**\n+ * Used to configure the HDFS Dataset Sink module options that are related to writing using Kite SDK.\n+ *\n+ * @author Thomas Risberg\n+ */\n+@SuppressWarnings(\"unused\")\n+@ConfigurationProperties\n+public class DatasetSinkProperties {\n+\n+\t/**\n+\t * The URI to use to access the Hadoop FileSystem.\n+\t */\n+\tprivate String fsUri;\n+\n+\t/**\n+\t * The base directory path where the files will be written in the Hadoop FileSystem.\n+\t */\n+\tprivate String directory = \"/tmp/hdfs-dataset-sink\";\n+\n+\t/**\n+\t * The sub-directory under the basePath where files will be written.\n+\t */\n+\t@Value(\"${spring.application.name:data}\")\n+\tprivate String namespace;\n+\n+\t/**\n+\t * Threshold in number of messages when file will be automatically flushed and rolled over.\n+\t */\n+\tprivate int batchSize = 10000;\n+\n+\t/**\n+\t * Idle timeout in milliseconds when Hadoop file resource is automatically closed.\n+\t */\n+\tprivate long idleTimeout = 0L;\n+\n+\t/**\n+\t * Whether null property values are allowed, if set to true then schema will use UNION for each field.\n+\t */\n+\tprivate boolean allowNullValues = false;\n+\n+\t/**\n+\t * The format to use, valid options are avro and parquet.\n+\t */\n+\tprivate String format = \"avro\";","path":"hdfs-dataset-sink/src/main/java/org/springframework/cloud/stream/module/dataset/sink/DatasetSinkProperties.java","position":65,"original_position":65,"commit_id":"06b0d42ad680e80ed5ca783b09c7b2be846d6c60","original_commit_id":"c735100d129d7051ce40f46e5cf34ba4e06963cd","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"myyyeaahhhh, but we have better DSL code completion with enums now :)\r\nLet's open a ticket to track those","created_at":"2015-11-05T14:35:59Z","updated_at":"2015-11-05T14:35:59Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58#discussion_r44017484","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/44017484"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58#discussion_r44017484"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58","id":49597490,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58","diff_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/58","number":58,"state":"open","locked":false,"title":"XD-3534 Add HDFS Dataset sink module","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"body":"- Ported existing Spring XD hdfs-dataset sink module","created_at":"2015-11-03T19:09:09Z","updated_at":"2015-11-05T14:35:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe485030a1bde6450758dc2a3790868d7c3d8e37","assignee":{"login":"jvalkeal","id":50398,"avatar_url":"https://avatars.githubusercontent.com/u/50398?v=3","gravatar_id":"","url":"https://api.github.com/users/jvalkeal","html_url":"https://github.com/jvalkeal","followers_url":"https://api.github.com/users/jvalkeal/followers","following_url":"https://api.github.com/users/jvalkeal/following{/other_user}","gists_url":"https://api.github.com/users/jvalkeal/gists{/gist_id}","starred_url":"https://api.github.com/users/jvalkeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvalkeal/subscriptions","organizations_url":"https://api.github.com/users/jvalkeal/orgs","repos_url":"https://api.github.com/users/jvalkeal/repos","events_url":"https://api.github.com/users/jvalkeal/events{/privacy}","received_events_url":"https://api.github.com/users/jvalkeal/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/58/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/06b0d42ad680e80ed5ca783b09c7b2be846d6c60","head":{"label":"trisberg:XD-3534-hdfs-dataset","ref":"XD-3534-hdfs-dataset","sha":"06b0d42ad680e80ed5ca783b09c7b2be846d6c60","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"repo":{"id":40381186,"name":"spring-cloud-stream-modules","full_name":"trisberg/spring-cloud-stream-modules","owner":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trisberg/spring-cloud-stream-modules","description":"","fork":true,"url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/releases{/id}","created_at":"2015-08-07T21:14:13Z","updated_at":"2015-08-07T21:14:13Z","pushed_at":"2015-11-04T20:32:18Z","git_url":"git://github.com/trisberg/spring-cloud-stream-modules.git","ssh_url":"git@github.com:trisberg/spring-cloud-stream-modules.git","clone_url":"https://github.com/trisberg/spring-cloud-stream-modules.git","svn_url":"https://github.com/trisberg/spring-cloud-stream-modules","homepage":null,"size":1131,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"29779f033bd38d62cbe5e5161621cff7af8170cf","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":40096018,"name":"spring-cloud-stream-modules","full_name":"spring-cloud/spring-cloud-stream-modules","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/releases{/id}","created_at":"2015-08-02T23:22:20Z","updated_at":"2015-11-05T11:55:52Z","pushed_at":"2015-11-05T11:47:29Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream-modules.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream-modules.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream-modules.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","homepage":null,"size":1951,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/58"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/58"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/06b0d42ad680e80ed5ca783b09c7b2be846d6c60"}}}}