{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/TwP/servolux/pulls/17","id":36521288,"html_url":"https://github.com/TwP/servolux/pull/17","diff_url":"https://github.com/TwP/servolux/pull/17.diff","patch_url":"https://github.com/TwP/servolux/pull/17.patch","issue_url":"https://api.github.com/repos/TwP/servolux/issues/17","number":17,"state":"closed","locked":false,"title":"Improving some error handling","user":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"body":"There is a proliferation of `rescue nil` in the servolux codebase. Although convenient, this style of rescue statement only serves to obscure legitimate errors in the application. Where possible I've gone through and replaced those calls with better error handling.","created_at":"2015-05-29T16:18:50Z","updated_at":"2015-05-29T16:31:31Z","closed_at":"2015-05-29T16:31:31Z","merged_at":"2015-05-29T16:31:31Z","merge_commit_sha":"c38145c9c29f4d2786f9753abe2d78789af24005","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TwP/servolux/pulls/17/commits","review_comments_url":"https://api.github.com/repos/TwP/servolux/pulls/17/comments","review_comment_url":"https://api.github.com/repos/TwP/servolux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TwP/servolux/issues/17/comments","statuses_url":"https://api.github.com/repos/TwP/servolux/statuses/eb6abbe05c70603ba0950ce06141965ae0cae02e","head":{"label":"TwP:improve-error-handling","ref":"improve-error-handling","sha":"eb6abbe05c70603ba0950ce06141965ae0cae02e","user":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"repo":{"id":229795,"name":"servolux","full_name":"TwP/servolux","owner":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/TwP/servolux","description":"Threads : Servers : Forks : Daemons","fork":false,"url":"https://api.github.com/repos/TwP/servolux","forks_url":"https://api.github.com/repos/TwP/servolux/forks","keys_url":"https://api.github.com/repos/TwP/servolux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TwP/servolux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TwP/servolux/teams","hooks_url":"https://api.github.com/repos/TwP/servolux/hooks","issue_events_url":"https://api.github.com/repos/TwP/servolux/issues/events{/number}","events_url":"https://api.github.com/repos/TwP/servolux/events","assignees_url":"https://api.github.com/repos/TwP/servolux/assignees{/user}","branches_url":"https://api.github.com/repos/TwP/servolux/branches{/branch}","tags_url":"https://api.github.com/repos/TwP/servolux/tags","blobs_url":"https://api.github.com/repos/TwP/servolux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TwP/servolux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TwP/servolux/git/refs{/sha}","trees_url":"https://api.github.com/repos/TwP/servolux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TwP/servolux/statuses/{sha}","languages_url":"https://api.github.com/repos/TwP/servolux/languages","stargazers_url":"https://api.github.com/repos/TwP/servolux/stargazers","contributors_url":"https://api.github.com/repos/TwP/servolux/contributors","subscribers_url":"https://api.github.com/repos/TwP/servolux/subscribers","subscription_url":"https://api.github.com/repos/TwP/servolux/subscription","commits_url":"https://api.github.com/repos/TwP/servolux/commits{/sha}","git_commits_url":"https://api.github.com/repos/TwP/servolux/git/commits{/sha}","comments_url":"https://api.github.com/repos/TwP/servolux/comments{/number}","issue_comment_url":"https://api.github.com/repos/TwP/servolux/issues/comments{/number}","contents_url":"https://api.github.com/repos/TwP/servolux/contents/{+path}","compare_url":"https://api.github.com/repos/TwP/servolux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TwP/servolux/merges","archive_url":"https://api.github.com/repos/TwP/servolux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TwP/servolux/downloads","issues_url":"https://api.github.com/repos/TwP/servolux/issues{/number}","pulls_url":"https://api.github.com/repos/TwP/servolux/pulls{/number}","milestones_url":"https://api.github.com/repos/TwP/servolux/milestones{/number}","notifications_url":"https://api.github.com/repos/TwP/servolux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TwP/servolux/labels{/name}","releases_url":"https://api.github.com/repos/TwP/servolux/releases{/id}","created_at":"2009-06-17T17:53:59Z","updated_at":"2015-05-06T08:00:51Z","pushed_at":"2015-05-29T16:31:31Z","git_url":"git://github.com/TwP/servolux.git","ssh_url":"git@github.com:TwP/servolux.git","clone_url":"https://github.com/TwP/servolux.git","svn_url":"https://github.com/TwP/servolux","homepage":"","size":312,"stargazers_count":193,"watchers_count":193,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":193,"default_branch":"master"}},"base":{"label":"TwP:master","ref":"master","sha":"aedf60035f180b8b0ef7e27ed89ae0e322e3360b","user":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"repo":{"id":229795,"name":"servolux","full_name":"TwP/servolux","owner":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/TwP/servolux","description":"Threads : Servers : Forks : Daemons","fork":false,"url":"https://api.github.com/repos/TwP/servolux","forks_url":"https://api.github.com/repos/TwP/servolux/forks","keys_url":"https://api.github.com/repos/TwP/servolux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TwP/servolux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TwP/servolux/teams","hooks_url":"https://api.github.com/repos/TwP/servolux/hooks","issue_events_url":"https://api.github.com/repos/TwP/servolux/issues/events{/number}","events_url":"https://api.github.com/repos/TwP/servolux/events","assignees_url":"https://api.github.com/repos/TwP/servolux/assignees{/user}","branches_url":"https://api.github.com/repos/TwP/servolux/branches{/branch}","tags_url":"https://api.github.com/repos/TwP/servolux/tags","blobs_url":"https://api.github.com/repos/TwP/servolux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TwP/servolux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TwP/servolux/git/refs{/sha}","trees_url":"https://api.github.com/repos/TwP/servolux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TwP/servolux/statuses/{sha}","languages_url":"https://api.github.com/repos/TwP/servolux/languages","stargazers_url":"https://api.github.com/repos/TwP/servolux/stargazers","contributors_url":"https://api.github.com/repos/TwP/servolux/contributors","subscribers_url":"https://api.github.com/repos/TwP/servolux/subscribers","subscription_url":"https://api.github.com/repos/TwP/servolux/subscription","commits_url":"https://api.github.com/repos/TwP/servolux/commits{/sha}","git_commits_url":"https://api.github.com/repos/TwP/servolux/git/commits{/sha}","comments_url":"https://api.github.com/repos/TwP/servolux/comments{/number}","issue_comment_url":"https://api.github.com/repos/TwP/servolux/issues/comments{/number}","contents_url":"https://api.github.com/repos/TwP/servolux/contents/{+path}","compare_url":"https://api.github.com/repos/TwP/servolux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TwP/servolux/merges","archive_url":"https://api.github.com/repos/TwP/servolux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TwP/servolux/downloads","issues_url":"https://api.github.com/repos/TwP/servolux/issues{/number}","pulls_url":"https://api.github.com/repos/TwP/servolux/pulls{/number}","milestones_url":"https://api.github.com/repos/TwP/servolux/milestones{/number}","notifications_url":"https://api.github.com/repos/TwP/servolux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TwP/servolux/labels{/name}","releases_url":"https://api.github.com/repos/TwP/servolux/releases{/id}","created_at":"2009-06-17T17:53:59Z","updated_at":"2015-05-06T08:00:51Z","pushed_at":"2015-05-29T16:31:31Z","git_url":"git://github.com/TwP/servolux.git","ssh_url":"git@github.com:TwP/servolux.git","clone_url":"https://github.com/TwP/servolux.git","svn_url":"https://github.com/TwP/servolux","homepage":"","size":312,"stargazers_count":193,"watchers_count":193,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TwP/servolux/pulls/17"},"html":{"href":"https://github.com/TwP/servolux/pull/17"},"issue":{"href":"https://api.github.com/repos/TwP/servolux/issues/17"},"comments":{"href":"https://api.github.com/repos/TwP/servolux/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/TwP/servolux/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/TwP/servolux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TwP/servolux/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/TwP/servolux/statuses/eb6abbe05c70603ba0950ce06141965ae0cae02e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"TwP","id":6323,"avatar_url":"https://avatars.githubusercontent.com/u/6323?v=3","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":3}}