{"action":"created","comment":{"url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/comments/34972441","id":34972441,"diff_hunk":"@@ -117,12 +118,33 @@ class Thread {\n     public writeTraceback(): void {\n         this.traceback = \"Traceback (most recent call last):\\n\" + this.traceback;\n         process.stdout.write(this.traceback);\n+        this.exit();\n     }\n \n-    // Output the traceback when thread cannot handle an exception, and exit the thread\n-    public throwException(): void {\n-        this.writeTraceback();\n-        this.exit();\n+    public throwException(f: Py_FrameObject): void {","path":"src/threading.ts","position":19,"original_position":19,"commit_id":"46f73ba695b00de58d611098209aef533e7516b8","original_commit_id":"46f73ba695b00de58d611098209aef533e7516b8","user":{"login":"jvilk","id":1141042,"avatar_url":"https://avatars.githubusercontent.com/u/1141042?v=3","gravatar_id":"","url":"https://api.github.com/users/jvilk","html_url":"https://github.com/jvilk","followers_url":"https://api.github.com/users/jvilk/followers","following_url":"https://api.github.com/users/jvilk/following{/other_user}","gists_url":"https://api.github.com/users/jvilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jvilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvilk/subscriptions","organizations_url":"https://api.github.com/users/jvilk/orgs","repos_url":"https://api.github.com/users/jvilk/repos","events_url":"https://api.github.com/users/jvilk/events{/privacy}","received_events_url":"https://api.github.com/users/jvilk/received_events","type":"User","site_admin":false},"body":"Why does `throwException` take a frame object? Why doesn't it take an exception object?\r\n\r\nI would expect that `thread.throwException(obj)` would attempt to throw `obj` on the thread, beginning with the frame at the top of the stack. You'd pass it into `tryCatchException`, which would check if the frame can handle the given exception.","created_at":"2015-07-20T07:29:00Z","updated_at":"2015-07-20T07:29:00Z","html_url":"https://github.com/plasma-umass/Ninia/pull/36#discussion_r34972441","pull_request_url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/comments/34972441"},"html":{"href":"https://github.com/plasma-umass/Ninia/pull/36#discussion_r34972441"},"pull_request":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36","id":40303583,"html_url":"https://github.com/plasma-umass/Ninia/pull/36","diff_url":"https://github.com/plasma-umass/Ninia/pull/36.diff","patch_url":"https://github.com/plasma-umass/Ninia/pull/36.patch","issue_url":"https://api.github.com/repos/plasma-umass/Ninia/issues/36","number":36,"state":"open","locked":false,"title":"Implement ArithmeticError and move exception code","user":{"login":"Mdrbhatti","id":6940905,"avatar_url":"https://avatars.githubusercontent.com/u/6940905?v=3","gravatar_id":"","url":"https://api.github.com/users/Mdrbhatti","html_url":"https://github.com/Mdrbhatti","followers_url":"https://api.github.com/users/Mdrbhatti/followers","following_url":"https://api.github.com/users/Mdrbhatti/following{/other_user}","gists_url":"https://api.github.com/users/Mdrbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mdrbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mdrbhatti/subscriptions","organizations_url":"https://api.github.com/users/Mdrbhatti/orgs","repos_url":"https://api.github.com/users/Mdrbhatti/repos","events_url":"https://api.github.com/users/Mdrbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/Mdrbhatti/received_events","type":"User","site_admin":false},"body":"- Move exception handling to frameobject\r\n- Implement ArithmeticError, ZeroDivisionError, AttributeError exceptions\r\n- Change trampoline frame callback to take exception argument","created_at":"2015-07-19T05:38:28Z","updated_at":"2015-07-20T07:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08ae186af633e492b0b2e45a7b457c4e2da04f70","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36/commits","review_comments_url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36/comments","review_comment_url":"https://api.github.com/repos/plasma-umass/Ninia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plasma-umass/Ninia/issues/36/comments","statuses_url":"https://api.github.com/repos/plasma-umass/Ninia/statuses/46f73ba695b00de58d611098209aef533e7516b8","head":{"label":"Mdrbhatti:master","ref":"master","sha":"46f73ba695b00de58d611098209aef533e7516b8","user":{"login":"Mdrbhatti","id":6940905,"avatar_url":"https://avatars.githubusercontent.com/u/6940905?v=3","gravatar_id":"","url":"https://api.github.com/users/Mdrbhatti","html_url":"https://github.com/Mdrbhatti","followers_url":"https://api.github.com/users/Mdrbhatti/followers","following_url":"https://api.github.com/users/Mdrbhatti/following{/other_user}","gists_url":"https://api.github.com/users/Mdrbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mdrbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mdrbhatti/subscriptions","organizations_url":"https://api.github.com/users/Mdrbhatti/orgs","repos_url":"https://api.github.com/users/Mdrbhatti/repos","events_url":"https://api.github.com/users/Mdrbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/Mdrbhatti/received_events","type":"User","site_admin":false},"repo":{"id":32214653,"name":"Ninia","full_name":"Mdrbhatti/Ninia","owner":{"login":"Mdrbhatti","id":6940905,"avatar_url":"https://avatars.githubusercontent.com/u/6940905?v=3","gravatar_id":"","url":"https://api.github.com/users/Mdrbhatti","html_url":"https://github.com/Mdrbhatti","followers_url":"https://api.github.com/users/Mdrbhatti/followers","following_url":"https://api.github.com/users/Mdrbhatti/following{/other_user}","gists_url":"https://api.github.com/users/Mdrbhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/Mdrbhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mdrbhatti/subscriptions","organizations_url":"https://api.github.com/users/Mdrbhatti/orgs","repos_url":"https://api.github.com/users/Mdrbhatti/repos","events_url":"https://api.github.com/users/Mdrbhatti/events{/privacy}","received_events_url":"https://api.github.com/users/Mdrbhatti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mdrbhatti/Ninia","description":"Python interpreter in JavaScript","fork":true,"url":"https://api.github.com/repos/Mdrbhatti/Ninia","forks_url":"https://api.github.com/repos/Mdrbhatti/Ninia/forks","keys_url":"https://api.github.com/repos/Mdrbhatti/Ninia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mdrbhatti/Ninia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mdrbhatti/Ninia/teams","hooks_url":"https://api.github.com/repos/Mdrbhatti/Ninia/hooks","issue_events_url":"https://api.github.com/repos/Mdrbhatti/Ninia/issues/events{/number}","events_url":"https://api.github.com/repos/Mdrbhatti/Ninia/events","assignees_url":"https://api.github.com/repos/Mdrbhatti/Ninia/assignees{/user}","branches_url":"https://api.github.com/repos/Mdrbhatti/Ninia/branches{/branch}","tags_url":"https://api.github.com/repos/Mdrbhatti/Ninia/tags","blobs_url":"https://api.github.com/repos/Mdrbhatti/Ninia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mdrbhatti/Ninia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mdrbhatti/Ninia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mdrbhatti/Ninia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mdrbhatti/Ninia/statuses/{sha}","languages_url":"https://api.github.com/repos/Mdrbhatti/Ninia/languages","stargazers_url":"https://api.github.com/repos/Mdrbhatti/Ninia/stargazers","contributors_url":"https://api.github.com/repos/Mdrbhatti/Ninia/contributors","subscribers_url":"https://api.github.com/repos/Mdrbhatti/Ninia/subscribers","subscription_url":"https://api.github.com/repos/Mdrbhatti/Ninia/subscription","commits_url":"https://api.github.com/repos/Mdrbhatti/Ninia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mdrbhatti/Ninia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mdrbhatti/Ninia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mdrbhatti/Ninia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mdrbhatti/Ninia/contents/{+path}","compare_url":"https://api.github.com/repos/Mdrbhatti/Ninia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mdrbhatti/Ninia/merges","archive_url":"https://api.github.com/repos/Mdrbhatti/Ninia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mdrbhatti/Ninia/downloads","issues_url":"https://api.github.com/repos/Mdrbhatti/Ninia/issues{/number}","pulls_url":"https://api.github.com/repos/Mdrbhatti/Ninia/pulls{/number}","milestones_url":"https://api.github.com/repos/Mdrbhatti/Ninia/milestones{/number}","notifications_url":"https://api.github.com/repos/Mdrbhatti/Ninia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mdrbhatti/Ninia/labels{/name}","releases_url":"https://api.github.com/repos/Mdrbhatti/Ninia/releases{/id}","created_at":"2015-03-14T13:59:27Z","updated_at":"2015-03-15T00:34:42Z","pushed_at":"2015-07-20T00:10:59Z","git_url":"git://github.com/Mdrbhatti/Ninia.git","ssh_url":"git@github.com:Mdrbhatti/Ninia.git","clone_url":"https://github.com/Mdrbhatti/Ninia.git","svn_url":"https://github.com/Mdrbhatti/Ninia","homepage":"","size":1281,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plasma-umass:master","ref":"master","sha":"96753208e828f2e7c0e57c86ae17282ca7aa3dbd","user":{"login":"plasma-umass","id":1880823,"avatar_url":"https://avatars.githubusercontent.com/u/1880823?v=3","gravatar_id":"","url":"https://api.github.com/users/plasma-umass","html_url":"https://github.com/plasma-umass","followers_url":"https://api.github.com/users/plasma-umass/followers","following_url":"https://api.github.com/users/plasma-umass/following{/other_user}","gists_url":"https://api.github.com/users/plasma-umass/gists{/gist_id}","starred_url":"https://api.github.com/users/plasma-umass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plasma-umass/subscriptions","organizations_url":"https://api.github.com/users/plasma-umass/orgs","repos_url":"https://api.github.com/users/plasma-umass/repos","events_url":"https://api.github.com/users/plasma-umass/events{/privacy}","received_events_url":"https://api.github.com/users/plasma-umass/received_events","type":"Organization","site_admin":false},"repo":{"id":31030189,"name":"Ninia","full_name":"plasma-umass/Ninia","owner":{"login":"plasma-umass","id":1880823,"avatar_url":"https://avatars.githubusercontent.com/u/1880823?v=3","gravatar_id":"","url":"https://api.github.com/users/plasma-umass","html_url":"https://github.com/plasma-umass","followers_url":"https://api.github.com/users/plasma-umass/followers","following_url":"https://api.github.com/users/plasma-umass/following{/other_user}","gists_url":"https://api.github.com/users/plasma-umass/gists{/gist_id}","starred_url":"https://api.github.com/users/plasma-umass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plasma-umass/subscriptions","organizations_url":"https://api.github.com/users/plasma-umass/orgs","repos_url":"https://api.github.com/users/plasma-umass/repos","events_url":"https://api.github.com/users/plasma-umass/events{/privacy}","received_events_url":"https://api.github.com/users/plasma-umass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plasma-umass/Ninia","description":"Python interpreter in JavaScript","fork":true,"url":"https://api.github.com/repos/plasma-umass/Ninia","forks_url":"https://api.github.com/repos/plasma-umass/Ninia/forks","keys_url":"https://api.github.com/repos/plasma-umass/Ninia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plasma-umass/Ninia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plasma-umass/Ninia/teams","hooks_url":"https://api.github.com/repos/plasma-umass/Ninia/hooks","issue_events_url":"https://api.github.com/repos/plasma-umass/Ninia/issues/events{/number}","events_url":"https://api.github.com/repos/plasma-umass/Ninia/events","assignees_url":"https://api.github.com/repos/plasma-umass/Ninia/assignees{/user}","branches_url":"https://api.github.com/repos/plasma-umass/Ninia/branches{/branch}","tags_url":"https://api.github.com/repos/plasma-umass/Ninia/tags","blobs_url":"https://api.github.com/repos/plasma-umass/Ninia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plasma-umass/Ninia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plasma-umass/Ninia/git/refs{/sha}","trees_url":"https://api.github.com/repos/plasma-umass/Ninia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plasma-umass/Ninia/statuses/{sha}","languages_url":"https://api.github.com/repos/plasma-umass/Ninia/languages","stargazers_url":"https://api.github.com/repos/plasma-umass/Ninia/stargazers","contributors_url":"https://api.github.com/repos/plasma-umass/Ninia/contributors","subscribers_url":"https://api.github.com/repos/plasma-umass/Ninia/subscribers","subscription_url":"https://api.github.com/repos/plasma-umass/Ninia/subscription","commits_url":"https://api.github.com/repos/plasma-umass/Ninia/commits{/sha}","git_commits_url":"https://api.github.com/repos/plasma-umass/Ninia/git/commits{/sha}","comments_url":"https://api.github.com/repos/plasma-umass/Ninia/comments{/number}","issue_comment_url":"https://api.github.com/repos/plasma-umass/Ninia/issues/comments{/number}","contents_url":"https://api.github.com/repos/plasma-umass/Ninia/contents/{+path}","compare_url":"https://api.github.com/repos/plasma-umass/Ninia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plasma-umass/Ninia/merges","archive_url":"https://api.github.com/repos/plasma-umass/Ninia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plasma-umass/Ninia/downloads","issues_url":"https://api.github.com/repos/plasma-umass/Ninia/issues{/number}","pulls_url":"https://api.github.com/repos/plasma-umass/Ninia/pulls{/number}","milestones_url":"https://api.github.com/repos/plasma-umass/Ninia/milestones{/number}","notifications_url":"https://api.github.com/repos/plasma-umass/Ninia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plasma-umass/Ninia/labels{/name}","releases_url":"https://api.github.com/repos/plasma-umass/Ninia/releases{/id}","created_at":"2015-02-19T18:35:36Z","updated_at":"2015-06-21T21:04:42Z","pushed_at":"2015-07-20T00:11:00Z","git_url":"git://github.com/plasma-umass/Ninia.git","ssh_url":"git@github.com:plasma-umass/Ninia.git","clone_url":"https://github.com/plasma-umass/Ninia.git","svn_url":"https://github.com/plasma-umass/Ninia","homepage":"","size":1537,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":5,"forks":15,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36"},"html":{"href":"https://github.com/plasma-umass/Ninia/pull/36"},"issue":{"href":"https://api.github.com/repos/plasma-umass/Ninia/issues/36"},"comments":{"href":"https://api.github.com/repos/plasma-umass/Ninia/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plasma-umass/Ninia/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/plasma-umass/Ninia/statuses/46f73ba695b00de58d611098209aef533e7516b8"}}}}