{"action":"created","comment":{"url":"https://api.github.com/repos/tumblr/collins/pulls/comments/24164478","id":24164478,"diff_hunk":"@@ -9,6 +9,7 @@ import util.concurrent.BackgroundProcessor\n \n import play.api.mvc._\n import play.api.libs.json._\n+import play.api.libs.concurrent.Execution.Implicits._","path":"app/controllers/AssetWebApi.scala","position":4,"original_position":4,"commit_id":"1b8174443dfc4ca9c745609df4e7da221e7bf93f","original_commit_id":"1b8174443dfc4ca9c745609df4e7da221e7bf93f","user":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"body":"AssetCancelProcessor needs an ExecutionContext since it is using Scala futures/Awaits to handle the Softlayer.cancelServer call.","created_at":"2015-02-05T14:06:09Z","updated_at":"2015-02-05T14:06:09Z","html_url":"https://github.com/tumblr/collins/pull/263#discussion_r24164478","pull_request_url":"https://api.github.com/repos/tumblr/collins/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/tumblr/collins/pulls/comments/24164478"},"html":{"href":"https://github.com/tumblr/collins/pull/263#discussion_r24164478"},"pull_request":{"href":"https://api.github.com/repos/tumblr/collins/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/tumblr/collins/pulls/263","id":28669214,"html_url":"https://github.com/tumblr/collins/pull/263","diff_url":"https://github.com/tumblr/collins/pull/263.diff","patch_url":"https://github.com/tumblr/collins/pull/263.patch","issue_url":"https://api.github.com/repos/tumblr/collins/issues/263","number":263,"state":"open","locked":false,"title":"replaced Twitter futures with Scala futures","user":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"body":"removed all Awaits except for one that is used by\r\nMultiCollins/BackgroundProcess\r\n\r\nThis is one PR which removes Twitter futures and uses Scala Futures/timeouts.  I removed all timeouts that were not connected to multi collins(not used), and for background processing(because changing BackgroundProcess to being asynchronous is not a trivial task).\r\n\r\nI have another branch off of this one which removes the finagle library entirely.  I will pr that one separately as I wanted to keep this one focused.","created_at":"2015-02-04T19:51:50Z","updated_at":"2015-02-05T14:06:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78766e1e5dda772c32d9cd1c9b0556cbd608f229","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tumblr/collins/pulls/263/commits","review_comments_url":"https://api.github.com/repos/tumblr/collins/pulls/263/comments","review_comment_url":"https://api.github.com/repos/tumblr/collins/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tumblr/collins/issues/263/comments","statuses_url":"https://api.github.com/repos/tumblr/collins/statuses/1b8174443dfc4ca9c745609df4e7da221e7bf93f","head":{"label":"nsauro:removed_twitter_futures_and_awaits","ref":"removed_twitter_futures_and_awaits","sha":"1b8174443dfc4ca9c745609df4e7da221e7bf93f","user":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"repo":{"id":30266885,"name":"collins","full_name":"nsauro/collins","owner":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsauro/collins","description":"groovy kind of love","fork":true,"url":"https://api.github.com/repos/nsauro/collins","forks_url":"https://api.github.com/repos/nsauro/collins/forks","keys_url":"https://api.github.com/repos/nsauro/collins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsauro/collins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsauro/collins/teams","hooks_url":"https://api.github.com/repos/nsauro/collins/hooks","issue_events_url":"https://api.github.com/repos/nsauro/collins/issues/events{/number}","events_url":"https://api.github.com/repos/nsauro/collins/events","assignees_url":"https://api.github.com/repos/nsauro/collins/assignees{/user}","branches_url":"https://api.github.com/repos/nsauro/collins/branches{/branch}","tags_url":"https://api.github.com/repos/nsauro/collins/tags","blobs_url":"https://api.github.com/repos/nsauro/collins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsauro/collins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsauro/collins/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsauro/collins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsauro/collins/statuses/{sha}","languages_url":"https://api.github.com/repos/nsauro/collins/languages","stargazers_url":"https://api.github.com/repos/nsauro/collins/stargazers","contributors_url":"https://api.github.com/repos/nsauro/collins/contributors","subscribers_url":"https://api.github.com/repos/nsauro/collins/subscribers","subscription_url":"https://api.github.com/repos/nsauro/collins/subscription","commits_url":"https://api.github.com/repos/nsauro/collins/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsauro/collins/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsauro/collins/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsauro/collins/issues/comments/{number}","contents_url":"https://api.github.com/repos/nsauro/collins/contents/{+path}","compare_url":"https://api.github.com/repos/nsauro/collins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsauro/collins/merges","archive_url":"https://api.github.com/repos/nsauro/collins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsauro/collins/downloads","issues_url":"https://api.github.com/repos/nsauro/collins/issues{/number}","pulls_url":"https://api.github.com/repos/nsauro/collins/pulls{/number}","milestones_url":"https://api.github.com/repos/nsauro/collins/milestones{/number}","notifications_url":"https://api.github.com/repos/nsauro/collins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsauro/collins/labels{/name}","releases_url":"https://api.github.com/repos/nsauro/collins/releases{/id}","created_at":"2015-02-03T22:00:35Z","updated_at":"2015-02-03T22:00:37Z","pushed_at":"2015-02-04T19:48:22Z","git_url":"git://github.com/nsauro/collins.git","ssh_url":"git@github.com:nsauro/collins.git","clone_url":"https://github.com/nsauro/collins.git","svn_url":"https://github.com/nsauro/collins","homepage":"tumblr.github.com/collins","size":224670,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tumblr:master","ref":"master","sha":"a3858c70f39be004f18b0574b0bbe040ad61f140","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":5252760,"name":"collins","full_name":"tumblr/collins","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/collins","description":"groovy kind of love","fork":false,"url":"https://api.github.com/repos/tumblr/collins","forks_url":"https://api.github.com/repos/tumblr/collins/forks","keys_url":"https://api.github.com/repos/tumblr/collins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/collins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/collins/teams","hooks_url":"https://api.github.com/repos/tumblr/collins/hooks","issue_events_url":"https://api.github.com/repos/tumblr/collins/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/collins/events","assignees_url":"https://api.github.com/repos/tumblr/collins/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/collins/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/collins/tags","blobs_url":"https://api.github.com/repos/tumblr/collins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/collins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/collins/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/collins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/collins/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/collins/languages","stargazers_url":"https://api.github.com/repos/tumblr/collins/stargazers","contributors_url":"https://api.github.com/repos/tumblr/collins/contributors","subscribers_url":"https://api.github.com/repos/tumblr/collins/subscribers","subscription_url":"https://api.github.com/repos/tumblr/collins/subscription","commits_url":"https://api.github.com/repos/tumblr/collins/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/collins/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/collins/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/collins/issues/comments/{number}","contents_url":"https://api.github.com/repos/tumblr/collins/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/collins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/collins/merges","archive_url":"https://api.github.com/repos/tumblr/collins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/collins/downloads","issues_url":"https://api.github.com/repos/tumblr/collins/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/collins/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/collins/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/collins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/collins/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/collins/releases{/id}","created_at":"2012-07-31T23:18:59Z","updated_at":"2015-02-03T14:15:23Z","pushed_at":"2015-02-03T14:15:23Z","git_url":"git://github.com/tumblr/collins.git","ssh_url":"git@github.com:tumblr/collins.git","clone_url":"https://github.com/tumblr/collins.git","svn_url":"https://github.com/tumblr/collins","homepage":"tumblr.github.com/collins","size":224670,"stargazers_count":270,"watchers_count":270,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":42,"forks":48,"open_issues":42,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tumblr/collins/pulls/263"},"html":{"href":"https://github.com/tumblr/collins/pull/263"},"issue":{"href":"https://api.github.com/repos/tumblr/collins/issues/263"},"comments":{"href":"https://api.github.com/repos/tumblr/collins/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/tumblr/collins/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/tumblr/collins/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tumblr/collins/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/tumblr/collins/statuses/1b8174443dfc4ca9c745609df4e7da221e7bf93f"}}}}