{"action":"closed","number":3224,"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224","id":28053645,"html_url":"https://github.com/angular-ui/bootstrap/pull/3224","diff_url":"https://github.com/angular-ui/bootstrap/pull/3224.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3224.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3224","number":3224,"state":"closed","locked":false,"title":"fix(accordion): Using angular.noop instead","user":{"login":"jrgleason","id":1319151,"avatar_url":"https://avatars.githubusercontent.com/u/1319151?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgleason","html_url":"https://github.com/jrgleason","followers_url":"https://api.github.com/users/jrgleason/followers","following_url":"https://api.github.com/users/jrgleason/following{/other_user}","gists_url":"https://api.github.com/users/jrgleason/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgleason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgleason/subscriptions","organizations_url":"https://api.github.com/users/jrgleason/orgs","repos_url":"https://api.github.com/users/jrgleason/repos","events_url":"https://api.github.com/users/jrgleason/events{/privacy}","received_events_url":"https://api.github.com/users/jrgleason/received_events","type":"User","site_admin":false},"body":"This is a rather small change, I would be more than happy to go a quick grep for other instances but should be a fairly small change. \r\n\r\nAccording to Angular docs, etc this seems to be the desired way to handle a noop function.\r\n\r\nhttps://docs.angularjs.org/api/ng/function/angular.noop","created_at":"2015-01-26T19:37:26Z","updated_at":"2015-03-09T05:36:38Z","closed_at":"2015-03-09T05:36:38Z","merged_at":null,"merge_commit_sha":"d39732d6e4dd7d73b2b8fe4b8f60f1a176b67a8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3224/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/bbd6220a7ca692b6ae74e6d2aafdfb68a3906bdf","head":{"label":"jrgleason:master","ref":"master","sha":"bbd6220a7ca692b6ae74e6d2aafdfb68a3906bdf","user":{"login":"jrgleason","id":1319151,"avatar_url":"https://avatars.githubusercontent.com/u/1319151?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgleason","html_url":"https://github.com/jrgleason","followers_url":"https://api.github.com/users/jrgleason/followers","following_url":"https://api.github.com/users/jrgleason/following{/other_user}","gists_url":"https://api.github.com/users/jrgleason/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgleason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgleason/subscriptions","organizations_url":"https://api.github.com/users/jrgleason/orgs","repos_url":"https://api.github.com/users/jrgleason/repos","events_url":"https://api.github.com/users/jrgleason/events{/privacy}","received_events_url":"https://api.github.com/users/jrgleason/received_events","type":"User","site_admin":false},"repo":{"id":29877182,"name":"bootstrap","full_name":"jrgleason/bootstrap","owner":{"login":"jrgleason","id":1319151,"avatar_url":"https://avatars.githubusercontent.com/u/1319151?v=3","gravatar_id":"","url":"https://api.github.com/users/jrgleason","html_url":"https://github.com/jrgleason","followers_url":"https://api.github.com/users/jrgleason/followers","following_url":"https://api.github.com/users/jrgleason/following{/other_user}","gists_url":"https://api.github.com/users/jrgleason/gists{/gist_id}","starred_url":"https://api.github.com/users/jrgleason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrgleason/subscriptions","organizations_url":"https://api.github.com/users/jrgleason/orgs","repos_url":"https://api.github.com/users/jrgleason/repos","events_url":"https://api.github.com/users/jrgleason/events{/privacy}","received_events_url":"https://api.github.com/users/jrgleason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrgleason/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/jrgleason/bootstrap","forks_url":"https://api.github.com/repos/jrgleason/bootstrap/forks","keys_url":"https://api.github.com/repos/jrgleason/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrgleason/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrgleason/bootstrap/teams","hooks_url":"https://api.github.com/repos/jrgleason/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/jrgleason/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/jrgleason/bootstrap/events","assignees_url":"https://api.github.com/repos/jrgleason/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/jrgleason/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/jrgleason/bootstrap/tags","blobs_url":"https://api.github.com/repos/jrgleason/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrgleason/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrgleason/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrgleason/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrgleason/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/jrgleason/bootstrap/languages","stargazers_url":"https://api.github.com/repos/jrgleason/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/jrgleason/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/jrgleason/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/jrgleason/bootstrap/subscription","commits_url":"https://api.github.com/repos/jrgleason/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrgleason/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrgleason/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrgleason/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrgleason/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/jrgleason/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrgleason/bootstrap/merges","archive_url":"https://api.github.com/repos/jrgleason/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrgleason/bootstrap/downloads","issues_url":"https://api.github.com/repos/jrgleason/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/jrgleason/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/jrgleason/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/jrgleason/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrgleason/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/jrgleason/bootstrap/releases{/id}","created_at":"2015-01-26T19:19:52Z","updated_at":"2015-01-26T19:35:59Z","pushed_at":"2015-01-26T19:35:59Z","git_url":"git://github.com/jrgleason/bootstrap.git","ssh_url":"git@github.com:jrgleason/bootstrap.git","clone_url":"https://github.com/jrgleason/bootstrap.git","svn_url":"https://github.com/jrgleason/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":3611,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"23936f9f6ec7170b56c7f13345ae022c74fa3034","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-03-09T05:36:29Z","pushed_at":"2015-03-09T05:36:28Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":15387,"stargazers_count":8049,"watchers_count":8049,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4272,"mirror_url":null,"open_issues_count":731,"forks":4272,"open_issues":731,"watchers":8049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3224"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3224"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3224/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3224/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/bbd6220a7ca692b6ae74e6d2aafdfb68a3906bdf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}