{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/30055676","id":30055676,"diff_hunk":"@@ -130,7 +142,7 @@ private[spark] class CoarseMesosSchedulerBackend(\n       command.setValue(\n         \"%s \\\"%s\\\" org.apache.spark.executor.CoarseGrainedExecutorBackend\"\n           .format(prefixEnv, runScript) +\n-        s\" --driver-url $driverUrl\" +\n+        s\" --driver-url $driverURL\" +\n         s\" --executor-id ${offer.getSlaveId.getValue}\" +","path":"core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala","position":69,"original_position":56,"commit_id":"4e831e27f48ce0f8cc36002af556330518fcc249","original_commit_id":"a68c3bf7fb9621bb9792e605aaf795b7867cbbba","user":{"login":"tnachen","id":67244,"avatar_url":"https://avatars.githubusercontent.com/u/67244?v=3","gravatar_id":"","url":"https://api.github.com/users/tnachen","html_url":"https://github.com/tnachen","followers_url":"https://api.github.com/users/tnachen/followers","following_url":"https://api.github.com/users/tnachen/following{/other_user}","gists_url":"https://api.github.com/users/tnachen/gists{/gist_id}","starred_url":"https://api.github.com/users/tnachen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnachen/subscriptions","organizations_url":"https://api.github.com/users/tnachen/orgs","repos_url":"https://api.github.com/users/tnachen/repos","events_url":"https://api.github.com/users/tnachen/events{/privacy}","received_events_url":"https://api.github.com/users/tnachen/received_events","type":"User","site_admin":false},"body":"Ah ok, I wasn't sure if you tested it before you changed it or not. With new executor ID it should be right. ","created_at":"2015-05-11T16:32:02Z","updated_at":"2015-05-11T16:32:02Z","html_url":"https://github.com/apache/spark/pull/4984#discussion_r30055676","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/4984","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/30055676"},"html":{"href":"https://github.com/apache/spark/pull/4984#discussion_r30055676"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/4984"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/4984","id":30966881,"html_url":"https://github.com/apache/spark/pull/4984","diff_url":"https://github.com/apache/spark/pull/4984.diff","patch_url":"https://github.com/apache/spark/pull/4984.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/4984","number":4984,"state":"open","locked":false,"title":"[SPARK-6287][MESOS] Add dynamic allocation to the coarse-grained Mesos scheduler","user":{"login":"dragos","id":133742,"avatar_url":"https://avatars.githubusercontent.com/u/133742?v=3","gravatar_id":"","url":"https://api.github.com/users/dragos","html_url":"https://github.com/dragos","followers_url":"https://api.github.com/users/dragos/followers","following_url":"https://api.github.com/users/dragos/following{/other_user}","gists_url":"https://api.github.com/users/dragos/gists{/gist_id}","starred_url":"https://api.github.com/users/dragos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragos/subscriptions","organizations_url":"https://api.github.com/users/dragos/orgs","repos_url":"https://api.github.com/users/dragos/repos","events_url":"https://api.github.com/users/dragos/events{/privacy}","received_events_url":"https://api.github.com/users/dragos/received_events","type":"User","site_admin":false},"body":"This is largely based on extracting the dynamic allocation parts from @tnachen's #3861.\r\n\r\n","created_at":"2015-03-11T17:40:26Z","updated_at":"2015-05-11T16:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f3689423c4f307d969c2574f69c9ffb7047b426","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/4984/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/4984/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/4984/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/4e831e27f48ce0f8cc36002af556330518fcc249","head":{"label":"dragos:issue/mesos-coarse-dynamicAllocation","ref":"issue/mesos-coarse-dynamicAllocation","sha":"4e831e27f48ce0f8cc36002af556330518fcc249","user":{"login":"dragos","id":133742,"avatar_url":"https://avatars.githubusercontent.com/u/133742?v=3","gravatar_id":"","url":"https://api.github.com/users/dragos","html_url":"https://github.com/dragos","followers_url":"https://api.github.com/users/dragos/followers","following_url":"https://api.github.com/users/dragos/following{/other_user}","gists_url":"https://api.github.com/users/dragos/gists{/gist_id}","starred_url":"https://api.github.com/users/dragos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragos/subscriptions","organizations_url":"https://api.github.com/users/dragos/orgs","repos_url":"https://api.github.com/users/dragos/repos","events_url":"https://api.github.com/users/dragos/events{/privacy}","received_events_url":"https://api.github.com/users/dragos/received_events","type":"User","site_admin":false},"repo":{"id":29976503,"name":"spark","full_name":"dragos/spark","owner":{"login":"dragos","id":133742,"avatar_url":"https://avatars.githubusercontent.com/u/133742?v=3","gravatar_id":"","url":"https://api.github.com/users/dragos","html_url":"https://github.com/dragos","followers_url":"https://api.github.com/users/dragos/followers","following_url":"https://api.github.com/users/dragos/following{/other_user}","gists_url":"https://api.github.com/users/dragos/gists{/gist_id}","starred_url":"https://api.github.com/users/dragos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragos/subscriptions","organizations_url":"https://api.github.com/users/dragos/orgs","repos_url":"https://api.github.com/users/dragos/repos","events_url":"https://api.github.com/users/dragos/events{/privacy}","received_events_url":"https://api.github.com/users/dragos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragos/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/dragos/spark","forks_url":"https://api.github.com/repos/dragos/spark/forks","keys_url":"https://api.github.com/repos/dragos/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragos/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragos/spark/teams","hooks_url":"https://api.github.com/repos/dragos/spark/hooks","issue_events_url":"https://api.github.com/repos/dragos/spark/issues/events{/number}","events_url":"https://api.github.com/repos/dragos/spark/events","assignees_url":"https://api.github.com/repos/dragos/spark/assignees{/user}","branches_url":"https://api.github.com/repos/dragos/spark/branches{/branch}","tags_url":"https://api.github.com/repos/dragos/spark/tags","blobs_url":"https://api.github.com/repos/dragos/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragos/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragos/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragos/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragos/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/dragos/spark/languages","stargazers_url":"https://api.github.com/repos/dragos/spark/stargazers","contributors_url":"https://api.github.com/repos/dragos/spark/contributors","subscribers_url":"https://api.github.com/repos/dragos/spark/subscribers","subscription_url":"https://api.github.com/repos/dragos/spark/subscription","commits_url":"https://api.github.com/repos/dragos/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragos/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragos/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragos/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragos/spark/contents/{+path}","compare_url":"https://api.github.com/repos/dragos/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragos/spark/merges","archive_url":"https://api.github.com/repos/dragos/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragos/spark/downloads","issues_url":"https://api.github.com/repos/dragos/spark/issues{/number}","pulls_url":"https://api.github.com/repos/dragos/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/dragos/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/dragos/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragos/spark/labels{/name}","releases_url":"https://api.github.com/repos/dragos/spark/releases{/id}","created_at":"2015-01-28T16:25:56Z","updated_at":"2015-01-28T16:26:12Z","pushed_at":"2015-05-11T16:31:28Z","git_url":"git://github.com/dragos/spark.git","ssh_url":"git@github.com:dragos/spark.git","clone_url":"https://github.com/dragos/spark.git","svn_url":"https://github.com/dragos/spark","homepage":null,"size":103298,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4f8a15519267ac205424270155254382cc2d3690","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-11T14:24:34Z","pushed_at":"2015-05-11T16:31:30Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1624766,"stargazers_count":3924,"watchers_count":3924,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3446,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":314,"forks":3446,"open_issues":314,"watchers":3924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/4984"},"html":{"href":"https://github.com/apache/spark/pull/4984"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/4984"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/4984/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/4984/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/4984/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/4e831e27f48ce0f8cc36002af556330518fcc249"}}}}