{"action":"closed","number":158,"pull_request":{"url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158","id":31666785,"html_url":"https://github.com/FluentLenium/FluentLenium/pull/158","diff_url":"https://github.com/FluentLenium/FluentLenium/pull/158.diff","patch_url":"https://github.com/FluentLenium/FluentLenium/pull/158.patch","issue_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/158","number":158,"state":"closed","locked":false,"title":"\"find\" method with only filters argument (#151)","user":{"login":"NozomiIto","id":4276719,"avatar_url":"https://avatars.githubusercontent.com/u/4276719?v=3","gravatar_id":"","url":"https://api.github.com/users/NozomiIto","html_url":"https://github.com/NozomiIto","followers_url":"https://api.github.com/users/NozomiIto/followers","following_url":"https://api.github.com/users/NozomiIto/following{/other_user}","gists_url":"https://api.github.com/users/NozomiIto/gists{/gist_id}","starred_url":"https://api.github.com/users/NozomiIto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NozomiIto/subscriptions","organizations_url":"https://api.github.com/users/NozomiIto/orgs","repos_url":"https://api.github.com/users/NozomiIto/repos","events_url":"https://api.github.com/users/NozomiIto/events{/privacy}","received_events_url":"https://api.github.com/users/NozomiIto/received_events","type":"User","site_admin":false},"body":"My concerns are:\r\n- New methods don't allow no argument \"find\" like `find().click()`. Users must explicitly specify \"\\*\" like\r\n   `find(\"*\").click()` if they should want to click all elements.\r\n- I added `FluentWait.until(cssSelecttor, filters)` method and `FluentWait.until(filters)` method.\r\n   Other idea to support no cssSelector \"until\" method is to add `FluentWait.until()` and recommend\r\n   to use this method like `await().until().withName(\"abc\").isPresent();`. But I didn't adopt this idea\r\n   since this may cause wrong usage like `await().until().isPresent();`.\r\n\r\nI also want to change README if this PR is accepted.\r\n","created_at":"2015-03-21T06:00:48Z","updated_at":"2015-04-08T15:09:07Z","closed_at":"2015-04-08T15:09:07Z","merged_at":"2015-04-08T15:09:07Z","merge_commit_sha":"9afcf92d9ecd91203a99dc31115e116fcea3720a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158/commits","review_comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158/comments","review_comment_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/158/comments","statuses_url":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/f4d2cd2719063a90cdad7e3ddc2659e67e23e325","head":{"label":"NozomiIto:filter-only-find2","ref":"filter-only-find2","sha":"f4d2cd2719063a90cdad7e3ddc2659e67e23e325","user":{"login":"NozomiIto","id":4276719,"avatar_url":"https://avatars.githubusercontent.com/u/4276719?v=3","gravatar_id":"","url":"https://api.github.com/users/NozomiIto","html_url":"https://github.com/NozomiIto","followers_url":"https://api.github.com/users/NozomiIto/followers","following_url":"https://api.github.com/users/NozomiIto/following{/other_user}","gists_url":"https://api.github.com/users/NozomiIto/gists{/gist_id}","starred_url":"https://api.github.com/users/NozomiIto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NozomiIto/subscriptions","organizations_url":"https://api.github.com/users/NozomiIto/orgs","repos_url":"https://api.github.com/users/NozomiIto/repos","events_url":"https://api.github.com/users/NozomiIto/events{/privacy}","received_events_url":"https://api.github.com/users/NozomiIto/received_events","type":"User","site_admin":false},"repo":{"id":30346534,"name":"FluentLenium","full_name":"NozomiIto/FluentLenium","owner":{"login":"NozomiIto","id":4276719,"avatar_url":"https://avatars.githubusercontent.com/u/4276719?v=3","gravatar_id":"","url":"https://api.github.com/users/NozomiIto","html_url":"https://github.com/NozomiIto","followers_url":"https://api.github.com/users/NozomiIto/followers","following_url":"https://api.github.com/users/NozomiIto/following{/other_user}","gists_url":"https://api.github.com/users/NozomiIto/gists{/gist_id}","starred_url":"https://api.github.com/users/NozomiIto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NozomiIto/subscriptions","organizations_url":"https://api.github.com/users/NozomiIto/orgs","repos_url":"https://api.github.com/users/NozomiIto/repos","events_url":"https://api.github.com/users/NozomiIto/events{/privacy}","received_events_url":"https://api.github.com/users/NozomiIto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NozomiIto/FluentLenium","description":"FluentLenium makes the writing of acceptance tests  in a fluent way possible using the power of  css selectors. ","fork":true,"url":"https://api.github.com/repos/NozomiIto/FluentLenium","forks_url":"https://api.github.com/repos/NozomiIto/FluentLenium/forks","keys_url":"https://api.github.com/repos/NozomiIto/FluentLenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NozomiIto/FluentLenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NozomiIto/FluentLenium/teams","hooks_url":"https://api.github.com/repos/NozomiIto/FluentLenium/hooks","issue_events_url":"https://api.github.com/repos/NozomiIto/FluentLenium/issues/events{/number}","events_url":"https://api.github.com/repos/NozomiIto/FluentLenium/events","assignees_url":"https://api.github.com/repos/NozomiIto/FluentLenium/assignees{/user}","branches_url":"https://api.github.com/repos/NozomiIto/FluentLenium/branches{/branch}","tags_url":"https://api.github.com/repos/NozomiIto/FluentLenium/tags","blobs_url":"https://api.github.com/repos/NozomiIto/FluentLenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NozomiIto/FluentLenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NozomiIto/FluentLenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/NozomiIto/FluentLenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NozomiIto/FluentLenium/statuses/{sha}","languages_url":"https://api.github.com/repos/NozomiIto/FluentLenium/languages","stargazers_url":"https://api.github.com/repos/NozomiIto/FluentLenium/stargazers","contributors_url":"https://api.github.com/repos/NozomiIto/FluentLenium/contributors","subscribers_url":"https://api.github.com/repos/NozomiIto/FluentLenium/subscribers","subscription_url":"https://api.github.com/repos/NozomiIto/FluentLenium/subscription","commits_url":"https://api.github.com/repos/NozomiIto/FluentLenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/NozomiIto/FluentLenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/NozomiIto/FluentLenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/NozomiIto/FluentLenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/NozomiIto/FluentLenium/contents/{+path}","compare_url":"https://api.github.com/repos/NozomiIto/FluentLenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NozomiIto/FluentLenium/merges","archive_url":"https://api.github.com/repos/NozomiIto/FluentLenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NozomiIto/FluentLenium/downloads","issues_url":"https://api.github.com/repos/NozomiIto/FluentLenium/issues{/number}","pulls_url":"https://api.github.com/repos/NozomiIto/FluentLenium/pulls{/number}","milestones_url":"https://api.github.com/repos/NozomiIto/FluentLenium/milestones{/number}","notifications_url":"https://api.github.com/repos/NozomiIto/FluentLenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NozomiIto/FluentLenium/labels{/name}","releases_url":"https://api.github.com/repos/NozomiIto/FluentLenium/releases{/id}","created_at":"2015-02-05T08:59:36Z","updated_at":"2015-03-19T08:42:48Z","pushed_at":"2015-04-08T14:59:49Z","git_url":"git://github.com/NozomiIto/FluentLenium.git","ssh_url":"git@github.com:NozomiIto/FluentLenium.git","clone_url":"https://github.com/NozomiIto/FluentLenium.git","svn_url":"https://github.com/NozomiIto/FluentLenium","homepage":"","size":1660,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FluentLenium:master","ref":"master","sha":"c9f8550697d9bbf72ebf74c425bf9d9588c198e9","user":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"repo":{"id":2088736,"name":"FluentLenium","full_name":"FluentLenium/FluentLenium","owner":{"login":"FluentLenium","id":1340573,"avatar_url":"https://avatars.githubusercontent.com/u/1340573?v=3","gravatar_id":"","url":"https://api.github.com/users/FluentLenium","html_url":"https://github.com/FluentLenium","followers_url":"https://api.github.com/users/FluentLenium/followers","following_url":"https://api.github.com/users/FluentLenium/following{/other_user}","gists_url":"https://api.github.com/users/FluentLenium/gists{/gist_id}","starred_url":"https://api.github.com/users/FluentLenium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FluentLenium/subscriptions","organizations_url":"https://api.github.com/users/FluentLenium/orgs","repos_url":"https://api.github.com/users/FluentLenium/repos","events_url":"https://api.github.com/users/FluentLenium/events{/privacy}","received_events_url":"https://api.github.com/users/FluentLenium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FluentLenium/FluentLenium","description":"FluentLenium makes the writing of acceptance tests  in a fluent way possible using the power of  css selectors. ","fork":false,"url":"https://api.github.com/repos/FluentLenium/FluentLenium","forks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/forks","keys_url":"https://api.github.com/repos/FluentLenium/FluentLenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FluentLenium/FluentLenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FluentLenium/FluentLenium/teams","hooks_url":"https://api.github.com/repos/FluentLenium/FluentLenium/hooks","issue_events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/events{/number}","events_url":"https://api.github.com/repos/FluentLenium/FluentLenium/events","assignees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/assignees{/user}","branches_url":"https://api.github.com/repos/FluentLenium/FluentLenium/branches{/branch}","tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/tags","blobs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/{sha}","languages_url":"https://api.github.com/repos/FluentLenium/FluentLenium/languages","stargazers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/stargazers","contributors_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contributors","subscribers_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscribers","subscription_url":"https://api.github.com/repos/FluentLenium/FluentLenium/subscription","commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/FluentLenium/FluentLenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/FluentLenium/FluentLenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/FluentLenium/FluentLenium/contents/{+path}","compare_url":"https://api.github.com/repos/FluentLenium/FluentLenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FluentLenium/FluentLenium/merges","archive_url":"https://api.github.com/repos/FluentLenium/FluentLenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FluentLenium/FluentLenium/downloads","issues_url":"https://api.github.com/repos/FluentLenium/FluentLenium/issues{/number}","pulls_url":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls{/number}","milestones_url":"https://api.github.com/repos/FluentLenium/FluentLenium/milestones{/number}","notifications_url":"https://api.github.com/repos/FluentLenium/FluentLenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FluentLenium/FluentLenium/labels{/name}","releases_url":"https://api.github.com/repos/FluentLenium/FluentLenium/releases{/id}","created_at":"2011-07-22T13:26:37Z","updated_at":"2015-04-08T14:38:21Z","pushed_at":"2015-04-08T15:09:07Z","git_url":"git://github.com/FluentLenium/FluentLenium.git","ssh_url":"git@github.com:FluentLenium/FluentLenium.git","clone_url":"https://github.com/FluentLenium/FluentLenium.git","svn_url":"https://github.com/FluentLenium/FluentLenium","homepage":"","size":3313,"stargazers_count":353,"watchers_count":353,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"open_issues_count":10,"forks":78,"open_issues":10,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158"},"html":{"href":"https://github.com/FluentLenium/FluentLenium/pull/158"},"issue":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/158"},"comments":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/FluentLenium/FluentLenium/statuses/f4d2cd2719063a90cdad7e3ddc2659e67e23e325"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MathildeLemee","id":794603,"avatar_url":"https://avatars.githubusercontent.com/u/794603?v=3","gravatar_id":"","url":"https://api.github.com/users/MathildeLemee","html_url":"https://github.com/MathildeLemee","followers_url":"https://api.github.com/users/MathildeLemee/followers","following_url":"https://api.github.com/users/MathildeLemee/following{/other_user}","gists_url":"https://api.github.com/users/MathildeLemee/gists{/gist_id}","starred_url":"https://api.github.com/users/MathildeLemee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathildeLemee/subscriptions","organizations_url":"https://api.github.com/users/MathildeLemee/orgs","repos_url":"https://api.github.com/users/MathildeLemee/repos","events_url":"https://api.github.com/users/MathildeLemee/events{/privacy}","received_events_url":"https://api.github.com/users/MathildeLemee/received_events","type":"User","site_admin":false},"comments":15,"review_comments":0,"commits":5,"additions":455,"deletions":1,"changed_files":10}}