{"action":"closed","number":1968,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968","id":38478727,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1968","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1968.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/1968.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1968","number":1968,"state":"closed","locked":false,"title":"Fix harvest logic running in addition to shearable logic","user":{"login":"modwizcode","id":369772,"avatar_url":"https://avatars.githubusercontent.com/u/369772?v=3","gravatar_id":"","url":"https://api.github.com/users/modwizcode","html_url":"https://github.com/modwizcode","followers_url":"https://api.github.com/users/modwizcode/followers","following_url":"https://api.github.com/users/modwizcode/following{/other_user}","gists_url":"https://api.github.com/users/modwizcode/gists{/gist_id}","starred_url":"https://api.github.com/users/modwizcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modwizcode/subscriptions","organizations_url":"https://api.github.com/users/modwizcode/orgs","repos_url":"https://api.github.com/users/modwizcode/repos","events_url":"https://api.github.com/users/modwizcode/events{/privacy}","received_events_url":"https://api.github.com/users/modwizcode/received_events","type":"User","site_admin":false},"body":"This pull request aims to fix two issues, the first is that onSheared runs in creative mode and the second is that in survival both the harvestBlock logic and the onSheared logic runs. In order to restore vanilla functionality this patch does two things.\r\n\r\n1. Adds a check into ItemShears to see if the player attempting to break a block with shears is in creative mode, aborting the shear logic if so.\r\n\r\n2. Keeps existing harvestBlock functionality while removing the base logic that destroys and drops the blocks letting forge handle that in onSheared.\r\n\r\nThis fixes https://github.com/SpongePowered/Sponge/issues/283 and makes forge behavior match vanilla. Note that shearing of entities likes sheep remains untouched because vanilla does drop wool in creative mode when shearing a sheep.\r\n\r\nThis probably also takes care of https://github.com/MinecraftForge/MinecraftForge/pull/1425 and https://github.com/MinecraftForge/MinecraftForge/issues/1308 if those issues weren't already fixed.","created_at":"2015-06-24T19:34:25Z","updated_at":"2015-07-31T19:57:05Z","closed_at":"2015-07-31T19:57:05Z","merged_at":"2015-07-31T19:57:05Z","merge_commit_sha":"dfe4edd175fc3fe041cdf282e81697eb95d1525c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1968/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/fe2c4c569de193ba4f6a2bdf0e12aaaebe4d918a","head":{"label":"modwizcode:master","ref":"master","sha":"fe2c4c569de193ba4f6a2bdf0e12aaaebe4d918a","user":{"login":"modwizcode","id":369772,"avatar_url":"https://avatars.githubusercontent.com/u/369772?v=3","gravatar_id":"","url":"https://api.github.com/users/modwizcode","html_url":"https://github.com/modwizcode","followers_url":"https://api.github.com/users/modwizcode/followers","following_url":"https://api.github.com/users/modwizcode/following{/other_user}","gists_url":"https://api.github.com/users/modwizcode/gists{/gist_id}","starred_url":"https://api.github.com/users/modwizcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modwizcode/subscriptions","organizations_url":"https://api.github.com/users/modwizcode/orgs","repos_url":"https://api.github.com/users/modwizcode/repos","events_url":"https://api.github.com/users/modwizcode/events{/privacy}","received_events_url":"https://api.github.com/users/modwizcode/received_events","type":"User","site_admin":false},"repo":{"id":38005891,"name":"MinecraftForge","full_name":"modwizcode/MinecraftForge","owner":{"login":"modwizcode","id":369772,"avatar_url":"https://avatars.githubusercontent.com/u/369772?v=3","gravatar_id":"","url":"https://api.github.com/users/modwizcode","html_url":"https://github.com/modwizcode","followers_url":"https://api.github.com/users/modwizcode/followers","following_url":"https://api.github.com/users/modwizcode/following{/other_user}","gists_url":"https://api.github.com/users/modwizcode/gists{/gist_id}","starred_url":"https://api.github.com/users/modwizcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modwizcode/subscriptions","organizations_url":"https://api.github.com/users/modwizcode/orgs","repos_url":"https://api.github.com/users/modwizcode/repos","events_url":"https://api.github.com/users/modwizcode/events{/privacy}","received_events_url":"https://api.github.com/users/modwizcode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/modwizcode/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/modwizcode/MinecraftForge","forks_url":"https://api.github.com/repos/modwizcode/MinecraftForge/forks","keys_url":"https://api.github.com/repos/modwizcode/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modwizcode/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modwizcode/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/modwizcode/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/modwizcode/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/modwizcode/MinecraftForge/events","assignees_url":"https://api.github.com/repos/modwizcode/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/modwizcode/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/modwizcode/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/modwizcode/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modwizcode/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modwizcode/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/modwizcode/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modwizcode/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/modwizcode/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/modwizcode/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/modwizcode/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/modwizcode/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/modwizcode/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/modwizcode/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/modwizcode/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/modwizcode/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/modwizcode/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/modwizcode/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/modwizcode/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modwizcode/MinecraftForge/merges","archive_url":"https://api.github.com/repos/modwizcode/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modwizcode/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/modwizcode/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/modwizcode/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/modwizcode/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/modwizcode/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modwizcode/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/modwizcode/MinecraftForge/releases{/id}","created_at":"2015-06-24T19:18:21Z","updated_at":"2015-06-24T19:18:25Z","pushed_at":"2015-06-24T19:29:36Z","git_url":"git://github.com/modwizcode/MinecraftForge.git","ssh_url":"git@github.com:modwizcode/MinecraftForge.git","clone_url":"https://github.com/modwizcode/MinecraftForge.git","svn_url":"https://github.com/modwizcode/MinecraftForge","homepage":"","size":81446,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MinecraftForge:master","ref":"master","sha":"b2033d642c9d32536000770cb117dfe35b236f75","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","created_at":"2012-01-30T01:35:01Z","updated_at":"2015-07-30T07:05:32Z","pushed_at":"2015-07-31T19:57:05Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":178768,"stargazers_count":1010,"watchers_count":1010,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":621,"mirror_url":null,"open_issues_count":202,"forks":621,"open_issues":202,"watchers":1010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/1968"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1968"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1968/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/1968/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/fe2c4c569de193ba4f6a2bdf0e12aaaebe4d918a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":3,"changed_files":3}}