{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/8462","labels_url":"https://api.github.com/repos/guardian/frontend/issues/8462/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/8462/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/8462/events","html_url":"https://github.com/guardian/frontend/pull/8462","id":59501171,"number":8462,"title":"Move commercial tests","user":{"login":"piuccio","id":680284,"avatar_url":"https://avatars.githubusercontent.com/u/680284?v=3","gravatar_id":"","url":"https://api.github.com/users/piuccio","html_url":"https://github.com/piuccio","followers_url":"https://api.github.com/users/piuccio/followers","following_url":"https://api.github.com/users/piuccio/following{/other_user}","gists_url":"https://api.github.com/users/piuccio/gists{/gist_id}","starred_url":"https://api.github.com/users/piuccio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piuccio/subscriptions","organizations_url":"https://api.github.com/users/piuccio/orgs","repos_url":"https://api.github.com/users/piuccio/repos","events_url":"https://api.github.com/users/piuccio/events{/privacy}","received_events_url":"https://api.github.com/users/piuccio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-02T16:04:09Z","updated_at":"2015-03-02T16:14:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/8462","html_url":"https://github.com/guardian/frontend/pull/8462","diff_url":"https://github.com/guardian/frontend/pull/8462.diff","patch_url":"https://github.com/guardian/frontend/pull/8462.patch"},"body":"That's the thing I hate about karma, tests don't run in isolation.\r\n\r\nTo make things slightly more resilient I've moved `commercial` out of `common`. This should avoid some conflicts.\r\n\r\nI've also fixed the viewport size for phantom. There's at least one commercial tests expecting the viewport to be that of a desktop. By default Phantom is at mobile breakpoint.\r\n\r\nI've checked the number of tests, before and after it's still 546, I haven't lost anything...\r\n\r\n@phamann @sndrs @rich-nguyen @someone-else-from-commercial?"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/76741321","html_url":"https://github.com/guardian/frontend/pull/8462#issuecomment-76741321","issue_url":"https://api.github.com/repos/guardian/frontend/issues/8462","id":76741321,"user":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?v=3","gravatar_id":"","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"created_at":"2015-03-02T16:14:41Z","updated_at":"2015-03-02T16:14:41Z","body":"what kind of conflicts?"}}