{"action":"created","comment":{"url":"https://api.github.com/repos/paixaop/node-sodium/pulls/comments/39717391","id":39717391,"diff_hunk":"@@ -23,34 +23,34 @@ using namespace v8;\n \n \n // get handle to the global object\n-Local<Object> globalObj = NanGetCurrentContext()->Global();\n+Local<Object> globalObj = Nan::GetCurrentContext()->Global();\n+\n+// Retrieve the buffer constructor function\n+Local<Function> bufferConstructor =\n+       Local<Function>::Cast(globalObj->Get(Nan::New<String>(\"Buffer\").ToLocalChecked()));\n \n-// Retrieve the buffer constructor function \n-Local<Function> bufferConstructor = \n-       Local<Function>::Cast(globalObj->Get(NanNew<String>(\"Buffer\")));\n-       \n \n // Check if a function argument is a node Buffer. If not throw V8 exception\n #define ARG_IS_BUFFER(i,msg) \\\n-    if (!Buffer::HasInstance(args[i])) { \\\n+    if (!Buffer::HasInstance(info[i])) { \\","path":"sodium.cc","position":19,"original_position":19,"commit_id":"62f5eea67c70458675836d13383dda932ddda26b","original_commit_id":"62f5eea67c70458675836d13383dda932ddda26b","user":{"login":"KenanSulayman","id":280212,"avatar_url":"https://avatars.githubusercontent.com/u/280212?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanSulayman","html_url":"https://github.com/KenanSulayman","followers_url":"https://api.github.com/users/KenanSulayman/followers","following_url":"https://api.github.com/users/KenanSulayman/following{/other_user}","gists_url":"https://api.github.com/users/KenanSulayman/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanSulayman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanSulayman/subscriptions","organizations_url":"https://api.github.com/users/KenanSulayman/orgs","repos_url":"https://api.github.com/users/KenanSulayman/repos","events_url":"https://api.github.com/users/KenanSulayman/events{/privacy}","received_events_url":"https://api.github.com/users/KenanSulayman/received_events","type":"User","site_admin":false},"body":"In nan 2.0, `NAN_METHOD` expands to a method signature with an argument list called `info` (as opposed to args in nan 1). See https://github.com/nodejs/nan/blob/f14e04a3492ede8ca2aac8f049a60c595d7bfbf2/nan.h#L1266 for further information.","created_at":"2015-09-17T07:28:16Z","updated_at":"2015-09-17T07:28:16Z","html_url":"https://github.com/paixaop/node-sodium/pull/55#discussion_r39717391","pull_request_url":"https://api.github.com/repos/paixaop/node-sodium/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/comments/39717391"},"html":{"href":"https://github.com/paixaop/node-sodium/pull/55#discussion_r39717391"},"pull_request":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/paixaop/node-sodium/pulls/55","id":45153655,"html_url":"https://github.com/paixaop/node-sodium/pull/55","diff_url":"https://github.com/paixaop/node-sodium/pull/55.diff","patch_url":"https://github.com/paixaop/node-sodium/pull/55.patch","issue_url":"https://api.github.com/repos/paixaop/node-sodium/issues/55","number":55,"state":"open","locked":false,"title":"Adds node 4.0.0 compatibility, updates and migrates to nan 2","user":{"login":"KenanSulayman","id":280212,"avatar_url":"https://avatars.githubusercontent.com/u/280212?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanSulayman","html_url":"https://github.com/KenanSulayman","followers_url":"https://api.github.com/users/KenanSulayman/followers","following_url":"https://api.github.com/users/KenanSulayman/following{/other_user}","gists_url":"https://api.github.com/users/KenanSulayman/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanSulayman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanSulayman/subscriptions","organizations_url":"https://api.github.com/users/KenanSulayman/orgs","repos_url":"https://api.github.com/users/KenanSulayman/repos","events_url":"https://api.github.com/users/KenanSulayman/events{/privacy}","received_events_url":"https://api.github.com/users/KenanSulayman/received_events","type":"User","site_admin":false},"body":"Yo,\r\n\r\nI was working with https://github.com/dazoe/ed25519 and found it being too much of a liability to maintain. Then I found out about sodium and migrated it so that it works with 4.0.0.\r\n\r\nAll tests pass.\r\n\r\nCheers and thanks for sodium","created_at":"2015-09-16T10:16:20Z","updated_at":"2015-09-17T07:28:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fffe0331c9d800c389af2c58dc819815640f6e2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paixaop/node-sodium/pulls/55/commits","review_comments_url":"https://api.github.com/repos/paixaop/node-sodium/pulls/55/comments","review_comment_url":"https://api.github.com/repos/paixaop/node-sodium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paixaop/node-sodium/issues/55/comments","statuses_url":"https://api.github.com/repos/paixaop/node-sodium/statuses/62f5eea67c70458675836d13383dda932ddda26b","head":{"label":"KenanSulayman:master","ref":"master","sha":"62f5eea67c70458675836d13383dda932ddda26b","user":{"login":"KenanSulayman","id":280212,"avatar_url":"https://avatars.githubusercontent.com/u/280212?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanSulayman","html_url":"https://github.com/KenanSulayman","followers_url":"https://api.github.com/users/KenanSulayman/followers","following_url":"https://api.github.com/users/KenanSulayman/following{/other_user}","gists_url":"https://api.github.com/users/KenanSulayman/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanSulayman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanSulayman/subscriptions","organizations_url":"https://api.github.com/users/KenanSulayman/orgs","repos_url":"https://api.github.com/users/KenanSulayman/repos","events_url":"https://api.github.com/users/KenanSulayman/events{/privacy}","received_events_url":"https://api.github.com/users/KenanSulayman/received_events","type":"User","site_admin":false},"repo":{"id":42579822,"name":"node-sodium","full_name":"KenanSulayman/node-sodium","owner":{"login":"KenanSulayman","id":280212,"avatar_url":"https://avatars.githubusercontent.com/u/280212?v=3","gravatar_id":"","url":"https://api.github.com/users/KenanSulayman","html_url":"https://github.com/KenanSulayman","followers_url":"https://api.github.com/users/KenanSulayman/followers","following_url":"https://api.github.com/users/KenanSulayman/following{/other_user}","gists_url":"https://api.github.com/users/KenanSulayman/gists{/gist_id}","starred_url":"https://api.github.com/users/KenanSulayman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KenanSulayman/subscriptions","organizations_url":"https://api.github.com/users/KenanSulayman/orgs","repos_url":"https://api.github.com/users/KenanSulayman/repos","events_url":"https://api.github.com/users/KenanSulayman/events{/privacy}","received_events_url":"https://api.github.com/users/KenanSulayman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KenanSulayman/node-sodium","description":"Port of the lib sodium encryption library to Node.js","fork":true,"url":"https://api.github.com/repos/KenanSulayman/node-sodium","forks_url":"https://api.github.com/repos/KenanSulayman/node-sodium/forks","keys_url":"https://api.github.com/repos/KenanSulayman/node-sodium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KenanSulayman/node-sodium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KenanSulayman/node-sodium/teams","hooks_url":"https://api.github.com/repos/KenanSulayman/node-sodium/hooks","issue_events_url":"https://api.github.com/repos/KenanSulayman/node-sodium/issues/events{/number}","events_url":"https://api.github.com/repos/KenanSulayman/node-sodium/events","assignees_url":"https://api.github.com/repos/KenanSulayman/node-sodium/assignees{/user}","branches_url":"https://api.github.com/repos/KenanSulayman/node-sodium/branches{/branch}","tags_url":"https://api.github.com/repos/KenanSulayman/node-sodium/tags","blobs_url":"https://api.github.com/repos/KenanSulayman/node-sodium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KenanSulayman/node-sodium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KenanSulayman/node-sodium/git/refs{/sha}","trees_url":"https://api.github.com/repos/KenanSulayman/node-sodium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KenanSulayman/node-sodium/statuses/{sha}","languages_url":"https://api.github.com/repos/KenanSulayman/node-sodium/languages","stargazers_url":"https://api.github.com/repos/KenanSulayman/node-sodium/stargazers","contributors_url":"https://api.github.com/repos/KenanSulayman/node-sodium/contributors","subscribers_url":"https://api.github.com/repos/KenanSulayman/node-sodium/subscribers","subscription_url":"https://api.github.com/repos/KenanSulayman/node-sodium/subscription","commits_url":"https://api.github.com/repos/KenanSulayman/node-sodium/commits{/sha}","git_commits_url":"https://api.github.com/repos/KenanSulayman/node-sodium/git/commits{/sha}","comments_url":"https://api.github.com/repos/KenanSulayman/node-sodium/comments{/number}","issue_comment_url":"https://api.github.com/repos/KenanSulayman/node-sodium/issues/comments{/number}","contents_url":"https://api.github.com/repos/KenanSulayman/node-sodium/contents/{+path}","compare_url":"https://api.github.com/repos/KenanSulayman/node-sodium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KenanSulayman/node-sodium/merges","archive_url":"https://api.github.com/repos/KenanSulayman/node-sodium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KenanSulayman/node-sodium/downloads","issues_url":"https://api.github.com/repos/KenanSulayman/node-sodium/issues{/number}","pulls_url":"https://api.github.com/repos/KenanSulayman/node-sodium/pulls{/number}","milestones_url":"https://api.github.com/repos/KenanSulayman/node-sodium/milestones{/number}","notifications_url":"https://api.github.com/repos/KenanSulayman/node-sodium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KenanSulayman/node-sodium/labels{/name}","releases_url":"https://api.github.com/repos/KenanSulayman/node-sodium/releases{/id}","created_at":"2015-09-16T10:09:55Z","updated_at":"2015-09-16T10:09:56Z","pushed_at":"2015-09-16T10:39:51Z","git_url":"git://github.com/KenanSulayman/node-sodium.git","ssh_url":"git@github.com:KenanSulayman/node-sodium.git","clone_url":"https://github.com/KenanSulayman/node-sodium.git","svn_url":"https://github.com/KenanSulayman/node-sodium","homepage":"","size":4835,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paixaop:master","ref":"master","sha":"30e73a1ff648bf6ad2d21596e63cf5e7df20d643","user":{"login":"paixaop","id":327006,"avatar_url":"https://avatars.githubusercontent.com/u/327006?v=3","gravatar_id":"","url":"https://api.github.com/users/paixaop","html_url":"https://github.com/paixaop","followers_url":"https://api.github.com/users/paixaop/followers","following_url":"https://api.github.com/users/paixaop/following{/other_user}","gists_url":"https://api.github.com/users/paixaop/gists{/gist_id}","starred_url":"https://api.github.com/users/paixaop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paixaop/subscriptions","organizations_url":"https://api.github.com/users/paixaop/orgs","repos_url":"https://api.github.com/users/paixaop/repos","events_url":"https://api.github.com/users/paixaop/events{/privacy}","received_events_url":"https://api.github.com/users/paixaop/received_events","type":"User","site_admin":false},"repo":{"id":14305394,"name":"node-sodium","full_name":"paixaop/node-sodium","owner":{"login":"paixaop","id":327006,"avatar_url":"https://avatars.githubusercontent.com/u/327006?v=3","gravatar_id":"","url":"https://api.github.com/users/paixaop","html_url":"https://github.com/paixaop","followers_url":"https://api.github.com/users/paixaop/followers","following_url":"https://api.github.com/users/paixaop/following{/other_user}","gists_url":"https://api.github.com/users/paixaop/gists{/gist_id}","starred_url":"https://api.github.com/users/paixaop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paixaop/subscriptions","organizations_url":"https://api.github.com/users/paixaop/orgs","repos_url":"https://api.github.com/users/paixaop/repos","events_url":"https://api.github.com/users/paixaop/events{/privacy}","received_events_url":"https://api.github.com/users/paixaop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paixaop/node-sodium","description":"Port of the lib sodium encryption library to Node.js","fork":false,"url":"https://api.github.com/repos/paixaop/node-sodium","forks_url":"https://api.github.com/repos/paixaop/node-sodium/forks","keys_url":"https://api.github.com/repos/paixaop/node-sodium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paixaop/node-sodium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paixaop/node-sodium/teams","hooks_url":"https://api.github.com/repos/paixaop/node-sodium/hooks","issue_events_url":"https://api.github.com/repos/paixaop/node-sodium/issues/events{/number}","events_url":"https://api.github.com/repos/paixaop/node-sodium/events","assignees_url":"https://api.github.com/repos/paixaop/node-sodium/assignees{/user}","branches_url":"https://api.github.com/repos/paixaop/node-sodium/branches{/branch}","tags_url":"https://api.github.com/repos/paixaop/node-sodium/tags","blobs_url":"https://api.github.com/repos/paixaop/node-sodium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paixaop/node-sodium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paixaop/node-sodium/git/refs{/sha}","trees_url":"https://api.github.com/repos/paixaop/node-sodium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paixaop/node-sodium/statuses/{sha}","languages_url":"https://api.github.com/repos/paixaop/node-sodium/languages","stargazers_url":"https://api.github.com/repos/paixaop/node-sodium/stargazers","contributors_url":"https://api.github.com/repos/paixaop/node-sodium/contributors","subscribers_url":"https://api.github.com/repos/paixaop/node-sodium/subscribers","subscription_url":"https://api.github.com/repos/paixaop/node-sodium/subscription","commits_url":"https://api.github.com/repos/paixaop/node-sodium/commits{/sha}","git_commits_url":"https://api.github.com/repos/paixaop/node-sodium/git/commits{/sha}","comments_url":"https://api.github.com/repos/paixaop/node-sodium/comments{/number}","issue_comment_url":"https://api.github.com/repos/paixaop/node-sodium/issues/comments{/number}","contents_url":"https://api.github.com/repos/paixaop/node-sodium/contents/{+path}","compare_url":"https://api.github.com/repos/paixaop/node-sodium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paixaop/node-sodium/merges","archive_url":"https://api.github.com/repos/paixaop/node-sodium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paixaop/node-sodium/downloads","issues_url":"https://api.github.com/repos/paixaop/node-sodium/issues{/number}","pulls_url":"https://api.github.com/repos/paixaop/node-sodium/pulls{/number}","milestones_url":"https://api.github.com/repos/paixaop/node-sodium/milestones{/number}","notifications_url":"https://api.github.com/repos/paixaop/node-sodium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paixaop/node-sodium/labels{/name}","releases_url":"https://api.github.com/repos/paixaop/node-sodium/releases{/id}","created_at":"2013-11-11T15:52:35Z","updated_at":"2015-09-12T20:07:38Z","pushed_at":"2015-09-16T10:37:58Z","git_url":"git://github.com/paixaop/node-sodium.git","ssh_url":"git@github.com:paixaop/node-sodium.git","clone_url":"https://github.com/paixaop/node-sodium.git","svn_url":"https://github.com/paixaop/node-sodium","homepage":"","size":4835,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":1,"forks":30,"open_issues":1,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/55"},"html":{"href":"https://github.com/paixaop/node-sodium/pull/55"},"issue":{"href":"https://api.github.com/repos/paixaop/node-sodium/issues/55"},"comments":{"href":"https://api.github.com/repos/paixaop/node-sodium/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paixaop/node-sodium/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/paixaop/node-sodium/statuses/62f5eea67c70458675836d13383dda932ddda26b"}}}}