{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/secp256k1/issues/64","labels_url":"https://api.github.com/repos/bitcoin/secp256k1/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/secp256k1/issues/64/comments","events_url":"https://api.github.com/repos/bitcoin/secp256k1/issues/64/events","html_url":"https://github.com/bitcoin/secp256k1/pull/64","id":43343142,"number":64,"title":"enable libsecp256k1_jni shared lib","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":59,"created_at":"2014-09-21T19:27:19Z","updated_at":"2015-05-07T01:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/secp256k1/pulls/64","html_url":"https://github.com/bitcoin/secp256k1/pull/64","diff_url":"https://github.com/bitcoin/secp256k1/pull/64.diff","patch_url":"https://github.com/bitcoin/secp256k1/pull/64.patch"},"body":"This enables a libsecp256k1_jni shared lib to be built. It depends on libsecp256k1.\r\n\r\n```./configure --enable-jni``` should be all it takes assuming your java environment is setup properly. For now, there's no way to specify where the includes should be found if they're not located in $JAVA_HOME/include, as I'm not sure if that's necessary or not.\r\n\r\nNotice that the lib has been renamed in the .java to reflect the lib's new name. This was done to match standard distro packaging names.\r\n\r\nThis is untested in a real java/jni build, verification that it actually works will be needed before merging."},"comment":{"url":"https://api.github.com/repos/bitcoin/secp256k1/issues/comments/99674989","html_url":"https://github.com/bitcoin/secp256k1/pull/64#issuecomment-99674989","issue_url":"https://api.github.com/repos/bitcoin/secp256k1/issues/64","id":99674989,"user":{"login":"faizkhan00","id":2230604,"avatar_url":"https://avatars.githubusercontent.com/u/2230604?v=3","gravatar_id":"","url":"https://api.github.com/users/faizkhan00","html_url":"https://github.com/faizkhan00","followers_url":"https://api.github.com/users/faizkhan00/followers","following_url":"https://api.github.com/users/faizkhan00/following{/other_user}","gists_url":"https://api.github.com/users/faizkhan00/gists{/gist_id}","starred_url":"https://api.github.com/users/faizkhan00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faizkhan00/subscriptions","organizations_url":"https://api.github.com/users/faizkhan00/orgs","repos_url":"https://api.github.com/users/faizkhan00/repos","events_url":"https://api.github.com/users/faizkhan00/events{/privacy}","received_events_url":"https://api.github.com/users/faizkhan00/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T01:45:31Z","updated_at":"2015-05-07T01:45:31Z","body":"hey @theuni , looking over your branch a bit, i'm wondering - - is it worthwhile to add implementations for these functions? I think that with the code we have in place it should be pretty safe (and i feel fairly confident) in bringing these to JNI (perhaps with additional tests as well) - thoughts there? \r\n```\r\n    secp256k1_ec_pubkey_decompress\r\n    secp256k1_ec_privkey_export\r\n    secp256k1_ec_privkey_import\r\n    secp256k1_ecdsa_sign_compact\r\n    secp256k1_ecdsa_recover_compact\r\n```\r\nPerhaps also `randomize()` but that would entail synchronization safety, which could be a good thing to have anyway"}}