{"action":"created","comment":{"url":"https://api.github.com/repos/allegro/hermes/pulls/comments/40188846","id":40188846,"diff_hunk":"@@ -43,9 +51,17 @@ public HybridSubscriptionMetricsRepository(GraphiteClient graphiteClient, Metric\n     @Override\n     public SubscriptionMetrics loadMetrics(TopicName topicName, String subscriptionName) {\n         String rateMetric = metricPath(topicName, subscriptionName);\n+        String timeouts = metricPathTimeouts(topicName, subscriptionName);\n+        String otherErrors = metricPathOtherErrors(topicName, subscriptionName);\n \n         GraphiteMetrics metrics = graphiteClient.readMetrics(rateMetric);\n \n+        List<String> httpStatusCodes = allHttpStatusCodeClasses()\n+                .map(code -> metricPathHttpStatuses(topicName, subscriptionName, code))\n+                .map(m -> graphiteClient.readMetrics(m)","path":"hermes-management/src/main/java/pl/allegro/tech/hermes/management/infrastructure/metrics/HybridSubscriptionMetricsRepository.java","position":32,"original_position":32,"commit_id":"4c73e21d01e21381bbef7103a8171e915733d2a4","original_commit_id":"4c73e21d01e21381bbef7103a8171e915733d2a4","user":{"login":"druminski","id":4473056,"avatar_url":"https://avatars.githubusercontent.com/u/4473056?v=3","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"body":"You have added 7 additional request to graphite. However GraphiteClient allows you to read different metrics in one request.","created_at":"2015-09-23T10:24:09Z","updated_at":"2015-09-23T10:24:09Z","html_url":"https://github.com/allegro/hermes/pull/213#discussion_r40188846","pull_request_url":"https://api.github.com/repos/allegro/hermes/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments/40188846"},"html":{"href":"https://github.com/allegro/hermes/pull/213#discussion_r40188846"},"pull_request":{"href":"https://api.github.com/repos/allegro/hermes/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/allegro/hermes/pulls/213","id":45759502,"html_url":"https://github.com/allegro/hermes/pull/213","diff_url":"https://github.com/allegro/hermes/pull/213.diff","patch_url":"https://github.com/allegro/hermes/pull/213.patch","issue_url":"https://api.github.com/repos/allegro/hermes/issues/213","number":213,"state":"open","locked":false,"title":"Added consumer status metrics to subscription metrics REST","user":{"login":"IvanVas","id":6050415,"avatar_url":"https://avatars.githubusercontent.com/u/6050415?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanVas","html_url":"https://github.com/IvanVas","followers_url":"https://api.github.com/users/IvanVas/followers","following_url":"https://api.github.com/users/IvanVas/following{/other_user}","gists_url":"https://api.github.com/users/IvanVas/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanVas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanVas/subscriptions","organizations_url":"https://api.github.com/users/IvanVas/orgs","repos_url":"https://api.github.com/users/IvanVas/repos","events_url":"https://api.github.com/users/IvanVas/events{/privacy}","received_events_url":"https://api.github.com/users/IvanVas/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-23T09:37:15Z","updated_at":"2015-09-23T10:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25035493a01926df712c06057747b9a2e074e186","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/allegro/hermes/pulls/213/commits","review_comments_url":"https://api.github.com/repos/allegro/hermes/pulls/213/comments","review_comment_url":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allegro/hermes/issues/213/comments","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/4c73e21d01e21381bbef7103a8171e915733d2a4","head":{"label":"allegro:205_consumer_response_metrics","ref":"205_consumer_response_metrics","sha":"4c73e21d01e21381bbef7103a8171e915733d2a4","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","created_at":"2015-05-15T08:11:16Z","updated_at":"2015-09-21T12:53:59Z","pushed_at":"2015-09-23T09:37:15Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":3082,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":22,"forks":15,"open_issues":22,"watchers":129,"default_branch":"master"}},"base":{"label":"allegro:develop","ref":"develop","sha":"c2b1ce039e09eb37acb549c8e7a2bf9fd14e53fb","user":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"repo":{"id":35662043,"name":"hermes","full_name":"allegro/hermes","owner":{"login":"allegro","id":562236,"avatar_url":"https://avatars.githubusercontent.com/u/562236?v=3","gravatar_id":"","url":"https://api.github.com/users/allegro","html_url":"https://github.com/allegro","followers_url":"https://api.github.com/users/allegro/followers","following_url":"https://api.github.com/users/allegro/following{/other_user}","gists_url":"https://api.github.com/users/allegro/gists{/gist_id}","starred_url":"https://api.github.com/users/allegro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegro/subscriptions","organizations_url":"https://api.github.com/users/allegro/orgs","repos_url":"https://api.github.com/users/allegro/repos","events_url":"https://api.github.com/users/allegro/events{/privacy}","received_events_url":"https://api.github.com/users/allegro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allegro/hermes","description":"Fast and reliable message broker built on top of Kafka.","fork":false,"url":"https://api.github.com/repos/allegro/hermes","forks_url":"https://api.github.com/repos/allegro/hermes/forks","keys_url":"https://api.github.com/repos/allegro/hermes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allegro/hermes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allegro/hermes/teams","hooks_url":"https://api.github.com/repos/allegro/hermes/hooks","issue_events_url":"https://api.github.com/repos/allegro/hermes/issues/events{/number}","events_url":"https://api.github.com/repos/allegro/hermes/events","assignees_url":"https://api.github.com/repos/allegro/hermes/assignees{/user}","branches_url":"https://api.github.com/repos/allegro/hermes/branches{/branch}","tags_url":"https://api.github.com/repos/allegro/hermes/tags","blobs_url":"https://api.github.com/repos/allegro/hermes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allegro/hermes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allegro/hermes/git/refs{/sha}","trees_url":"https://api.github.com/repos/allegro/hermes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allegro/hermes/statuses/{sha}","languages_url":"https://api.github.com/repos/allegro/hermes/languages","stargazers_url":"https://api.github.com/repos/allegro/hermes/stargazers","contributors_url":"https://api.github.com/repos/allegro/hermes/contributors","subscribers_url":"https://api.github.com/repos/allegro/hermes/subscribers","subscription_url":"https://api.github.com/repos/allegro/hermes/subscription","commits_url":"https://api.github.com/repos/allegro/hermes/commits{/sha}","git_commits_url":"https://api.github.com/repos/allegro/hermes/git/commits{/sha}","comments_url":"https://api.github.com/repos/allegro/hermes/comments{/number}","issue_comment_url":"https://api.github.com/repos/allegro/hermes/issues/comments{/number}","contents_url":"https://api.github.com/repos/allegro/hermes/contents/{+path}","compare_url":"https://api.github.com/repos/allegro/hermes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allegro/hermes/merges","archive_url":"https://api.github.com/repos/allegro/hermes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allegro/hermes/downloads","issues_url":"https://api.github.com/repos/allegro/hermes/issues{/number}","pulls_url":"https://api.github.com/repos/allegro/hermes/pulls{/number}","milestones_url":"https://api.github.com/repos/allegro/hermes/milestones{/number}","notifications_url":"https://api.github.com/repos/allegro/hermes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allegro/hermes/labels{/name}","releases_url":"https://api.github.com/repos/allegro/hermes/releases{/id}","created_at":"2015-05-15T08:11:16Z","updated_at":"2015-09-21T12:53:59Z","pushed_at":"2015-09-23T09:37:15Z","git_url":"git://github.com/allegro/hermes.git","ssh_url":"git@github.com:allegro/hermes.git","clone_url":"https://github.com/allegro/hermes.git","svn_url":"https://github.com/allegro/hermes","homepage":"http://hermes.allegro.tech","size":3082,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":22,"forks":15,"open_issues":22,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allegro/hermes/pulls/213"},"html":{"href":"https://github.com/allegro/hermes/pull/213"},"issue":{"href":"https://api.github.com/repos/allegro/hermes/issues/213"},"comments":{"href":"https://api.github.com/repos/allegro/hermes/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/allegro/hermes/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/allegro/hermes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allegro/hermes/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/allegro/hermes/statuses/4c73e21d01e21381bbef7103a8171e915733d2a4"}}}}