{"action":"created","issue":{"url":"https://api.github.com/repos/likeastore/ngDialog/issues/166","labels_url":"https://api.github.com/repos/likeastore/ngDialog/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/likeastore/ngDialog/issues/166/comments","events_url":"https://api.github.com/repos/likeastore/ngDialog/issues/166/events","html_url":"https://github.com/likeastore/ngDialog/pull/166","id":56942942,"number":166,"title":"Added accessibility improvements (keyboard focus management / ARIA attribute)","user":{"login":"richardszalay","id":229467,"avatar_url":"https://avatars.githubusercontent.com/u/229467?v=3","gravatar_id":"","url":"https://api.github.com/users/richardszalay","html_url":"https://github.com/richardszalay","followers_url":"https://api.github.com/users/richardszalay/followers","following_url":"https://api.github.com/users/richardszalay/following{/other_user}","gists_url":"https://api.github.com/users/richardszalay/gists{/gist_id}","starred_url":"https://api.github.com/users/richardszalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardszalay/subscriptions","organizations_url":"https://api.github.com/users/richardszalay/orgs","repos_url":"https://api.github.com/users/richardszalay/repos","events_url":"https://api.github.com/users/richardszalay/events{/privacy}","received_events_url":"https://api.github.com/users/richardszalay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-02-08T07:45:20Z","updated_at":"2015-02-19T02:16:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/likeastore/ngDialog/pulls/166","html_url":"https://github.com/likeastore/ngDialog/pull/166","diff_url":"https://github.com/likeastore/ngDialog/pull/166.diff","patch_url":"https://github.com/likeastore/ngDialog/pull/166.patch"},"body":"I've added some improvements on the accessibility front, specifically around focus management and aria attributes.\r\n\r\nThe keyboard focus works across the examples (incuding the nested dialogs) and has been tested in IE 11/Chrome 40/Firefox 37 for browsers and Windows Narrator and NVDA for screen readers.\r\n\r\nThe updates to the readme (and lesser extent, the code) should describe the changes sufficiently, but I thought I'd discuss some details that could be deemed controversial.\r\n\r\nFirstly, the keyboard focus support (specifically ``trapFocus``, which I've enabled by default) forces the first content element (eg. p tag) to be focusable if there aren't any actual-focusable elements. ~~This causes a focus rect to appear around it, which might cause some complains about styling (it can be disabled via CSS)~~ This has been resolved in the latest commit, but it forces `.css('outline','css')` on the element which might be controversial in its own right.\r\n\r\nSecondly, I've defaulted ``ariaAuto`` to ``true``, which will automatically apply aria attributes based on the available content. It's possible this could conflict with users that have applied aria attributes in their dialog content.\r\n\r\nIn both cases, my justification is that the vast majority of developers won't look at the accessibility side of things. I'd rather force the minority of accessibility-friendly developers to disable the features and have improved accessibility for the majority.\r\n\r\nHappy to discuss further."},"comment":{"url":"https://api.github.com/repos/likeastore/ngDialog/issues/comments/74988546","html_url":"https://github.com/likeastore/ngDialog/pull/166#issuecomment-74988546","issue_url":"https://api.github.com/repos/likeastore/ngDialog/issues/166","id":74988546,"user":{"login":"octavioamu","id":1358093,"avatar_url":"https://avatars.githubusercontent.com/u/1358093?v=3","gravatar_id":"","url":"https://api.github.com/users/octavioamu","html_url":"https://github.com/octavioamu","followers_url":"https://api.github.com/users/octavioamu/followers","following_url":"https://api.github.com/users/octavioamu/following{/other_user}","gists_url":"https://api.github.com/users/octavioamu/gists{/gist_id}","starred_url":"https://api.github.com/users/octavioamu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octavioamu/subscriptions","organizations_url":"https://api.github.com/users/octavioamu/orgs","repos_url":"https://api.github.com/users/octavioamu/repos","events_url":"https://api.github.com/users/octavioamu/events{/privacy}","received_events_url":"https://api.github.com/users/octavioamu/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T02:16:21Z","updated_at":"2015-02-19T02:16:21Z","body":"@richardszalay Ok, I'm using ngAria looks like this create some duplicate behavior only in the <a> not happening when the element is a button "}}