{"action":"created","issue":{"url":"https://api.github.com/repos/fsek/web/issues/261","labels_url":"https://api.github.com/repos/fsek/web/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/fsek/web/issues/261/comments","events_url":"https://api.github.com/repos/fsek/web/issues/261/events","html_url":"https://github.com/fsek/web/pull/261","id":111146201,"number":261,"title":"Reconfig devise","user":{"login":"davidwessman","id":6763624,"avatar_url":"https://avatars.githubusercontent.com/u/6763624?v=3","gravatar_id":"","url":"https://api.github.com/users/davidwessman","html_url":"https://github.com/davidwessman","followers_url":"https://api.github.com/users/davidwessman/followers","following_url":"https://api.github.com/users/davidwessman/following{/other_user}","gists_url":"https://api.github.com/users/davidwessman/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwessman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwessman/subscriptions","organizations_url":"https://api.github.com/users/davidwessman/orgs","repos_url":"https://api.github.com/users/davidwessman/repos","events_url":"https://api.github.com/users/davidwessman/events{/privacy}","received_events_url":"https://api.github.com/users/davidwessman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-10-13T09:53:17Z","updated_at":"2015-10-25T17:51:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fsek/web/pulls/261","html_url":"https://github.com/fsek/web/pull/261","diff_url":"https://github.com/fsek/web/pull/261.diff","patch_url":"https://github.com/fsek/web/pull/261.patch"},"body":"  - Starting to use email instead of username (this has caused a lot of confusion.\r\n  - Removing validations on user, not requiring name, but allowing to fill in more information at sign up.\r\n  - Adding feature tests for sign up, confirmation, password reset\r\n  - Removing all mentions of username\r\n\r\nReady to merge.\r\nWhat do you think? @fsek/admins \r\n"},"comment":{"url":"https://api.github.com/repos/fsek/web/issues/comments/150948359","html_url":"https://github.com/fsek/web/pull/261#issuecomment-150948359","issue_url":"https://api.github.com/repos/fsek/web/issues/261","id":150948359,"user":{"login":"jforberg","id":1269005,"avatar_url":"https://avatars.githubusercontent.com/u/1269005?v=3","gravatar_id":"","url":"https://api.github.com/users/jforberg","html_url":"https://github.com/jforberg","followers_url":"https://api.github.com/users/jforberg/followers","following_url":"https://api.github.com/users/jforberg/following{/other_user}","gists_url":"https://api.github.com/users/jforberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jforberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforberg/subscriptions","organizations_url":"https://api.github.com/users/jforberg/orgs","repos_url":"https://api.github.com/users/jforberg/repos","events_url":"https://api.github.com/users/jforberg/events{/privacy}","received_events_url":"https://api.github.com/users/jforberg/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T17:51:26Z","updated_at":"2015-10-25T17:51:26Z","body":"In general, branches should try to do just one thing. So next time maybe consider splitting it up. But leave it for now.\r\n\r\nIn general, if it ain't broke, don't fix it. But if you are \"passing by\" anyway then it is of course ok and a good habit to refactor it. Like in this case.\r\n\r\nContent-tag: while not outright wrong it just smells and is redundant. The point of a templating system is to generate HTML for you so you don't have to do it by hand. Outside of templating content-tag is necessary and totally ok to use."}}