{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/39022117","id":39022117,"diff_hunk":"@@ -185,3 +185,68 @@ func (l *PrivateNetList) All() bool {\n func (l *PrivateNetList) Specific(net string) bool {\n \treturn l.mapping[net]\n }\n+\n+type PrivateNetArgs struct {\n+\tmapping map[string]string","path":"common/common.go","position":6,"original_position":6,"commit_id":"8579ba95d0bdf3a6669a00e0894bcf67bb7b7dd1","original_commit_id":"8579ba95d0bdf3a6669a00e0894bcf67bb7b7dd1","user":{"login":"ppalucki","id":7300298,"avatar_url":"https://avatars.githubusercontent.com/u/7300298?v=3","gravatar_id":"","url":"https://api.github.com/users/ppalucki","html_url":"https://github.com/ppalucki","followers_url":"https://api.github.com/users/ppalucki/followers","following_url":"https://api.github.com/users/ppalucki/following{/other_user}","gists_url":"https://api.github.com/users/ppalucki/gists{/gist_id}","starred_url":"https://api.github.com/users/ppalucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppalucki/subscriptions","organizations_url":"https://api.github.com/users/ppalucki/orgs","repos_url":"https://api.github.com/users/ppalucki/repos","events_url":"https://api.github.com/users/ppalucki/events{/privacy}","received_events_url":"https://api.github.com/users/ppalucki/received_events","type":"User","site_admin":false},"body":"why not just \r\n```go\r\ntype PrivateNetArgs map[string]string\r\n```\r\n?\r\n\r\nI see the same pattern with existing `PrivateNetList` (explicit embedding and lazy initialization on Set()) - and I value in consistency (additionally I preffer xplicit `New` constructor, we don't need `.mapping == nil` checks anymore).","created_at":"2015-09-09T09:18:33Z","updated_at":"2015-09-09T09:18:33Z","html_url":"https://github.com/coreos/rkt/pull/1369#discussion_r39022117","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1369","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/39022117"},"html":{"href":"https://github.com/coreos/rkt/pull/1369#discussion_r39022117"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1369"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1369","id":44482809,"html_url":"https://github.com/coreos/rkt/pull/1369","diff_url":"https://github.com/coreos/rkt/pull/1369.diff","patch_url":"https://github.com/coreos/rkt/pull/1369.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1369","number":1369,"state":"open","locked":false,"title":"privatenet argument override","user":{"login":"steveeJ","id":1181362,"avatar_url":"https://avatars.githubusercontent.com/u/1181362?v=3","gravatar_id":"","url":"https://api.github.com/users/steveeJ","html_url":"https://github.com/steveeJ","followers_url":"https://api.github.com/users/steveeJ/followers","following_url":"https://api.github.com/users/steveeJ/following{/other_user}","gists_url":"https://api.github.com/users/steveeJ/gists{/gist_id}","starred_url":"https://api.github.com/users/steveeJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveeJ/subscriptions","organizations_url":"https://api.github.com/users/steveeJ/orgs","repos_url":"https://api.github.com/users/steveeJ/repos","events_url":"https://api.github.com/users/steveeJ/events{/privacy}","received_events_url":"https://api.github.com/users/steveeJ/received_events","type":"User","site_admin":false},"body":"Fixes #944.","created_at":"2015-09-08T21:04:03Z","updated_at":"2015-09-09T09:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"800510a929f2892bc93d6b3adf65173f85b2ba29","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1369/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1369/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1369/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/8579ba95d0bdf3a6669a00e0894bcf67bb7b7dd1","head":{"label":"steveeJ:privatenet-override-args","ref":"privatenet-override-args","sha":"8579ba95d0bdf3a6669a00e0894bcf67bb7b7dd1","user":{"login":"steveeJ","id":1181362,"avatar_url":"https://avatars.githubusercontent.com/u/1181362?v=3","gravatar_id":"","url":"https://api.github.com/users/steveeJ","html_url":"https://github.com/steveeJ","followers_url":"https://api.github.com/users/steveeJ/followers","following_url":"https://api.github.com/users/steveeJ/following{/other_user}","gists_url":"https://api.github.com/users/steveeJ/gists{/gist_id}","starred_url":"https://api.github.com/users/steveeJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveeJ/subscriptions","organizations_url":"https://api.github.com/users/steveeJ/orgs","repos_url":"https://api.github.com/users/steveeJ/repos","events_url":"https://api.github.com/users/steveeJ/events{/privacy}","received_events_url":"https://api.github.com/users/steveeJ/received_events","type":"User","site_admin":false},"repo":{"id":34967118,"name":"rkt","full_name":"steveeJ/rkt","owner":{"login":"steveeJ","id":1181362,"avatar_url":"https://avatars.githubusercontent.com/u/1181362?v=3","gravatar_id":"","url":"https://api.github.com/users/steveeJ","html_url":"https://github.com/steveeJ","followers_url":"https://api.github.com/users/steveeJ/followers","following_url":"https://api.github.com/users/steveeJ/following{/other_user}","gists_url":"https://api.github.com/users/steveeJ/gists{/gist_id}","starred_url":"https://api.github.com/users/steveeJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveeJ/subscriptions","organizations_url":"https://api.github.com/users/steveeJ/orgs","repos_url":"https://api.github.com/users/steveeJ/repos","events_url":"https://api.github.com/users/steveeJ/events{/privacy}","received_events_url":"https://api.github.com/users/steveeJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveeJ/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/steveeJ/rkt","forks_url":"https://api.github.com/repos/steveeJ/rkt/forks","keys_url":"https://api.github.com/repos/steveeJ/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveeJ/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveeJ/rkt/teams","hooks_url":"https://api.github.com/repos/steveeJ/rkt/hooks","issue_events_url":"https://api.github.com/repos/steveeJ/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/steveeJ/rkt/events","assignees_url":"https://api.github.com/repos/steveeJ/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/steveeJ/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/steveeJ/rkt/tags","blobs_url":"https://api.github.com/repos/steveeJ/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveeJ/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveeJ/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveeJ/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveeJ/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/steveeJ/rkt/languages","stargazers_url":"https://api.github.com/repos/steveeJ/rkt/stargazers","contributors_url":"https://api.github.com/repos/steveeJ/rkt/contributors","subscribers_url":"https://api.github.com/repos/steveeJ/rkt/subscribers","subscription_url":"https://api.github.com/repos/steveeJ/rkt/subscription","commits_url":"https://api.github.com/repos/steveeJ/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveeJ/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveeJ/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveeJ/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveeJ/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/steveeJ/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveeJ/rkt/merges","archive_url":"https://api.github.com/repos/steveeJ/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveeJ/rkt/downloads","issues_url":"https://api.github.com/repos/steveeJ/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/steveeJ/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/steveeJ/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/steveeJ/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveeJ/rkt/labels{/name}","releases_url":"https://api.github.com/repos/steveeJ/rkt/releases{/id}","created_at":"2015-05-02T23:42:32Z","updated_at":"2015-05-02T23:42:50Z","pushed_at":"2015-09-08T22:23:25Z","git_url":"git://github.com/steveeJ/rkt.git","ssh_url":"git@github.com:steveeJ/rkt.git","clone_url":"https://github.com/steveeJ/rkt.git","svn_url":"https://github.com/steveeJ/rkt","homepage":"","size":7653,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"0a02aec79c949ef589cedfb0d9e6003887d630e0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-09-09T08:43:04Z","pushed_at":"2015-09-09T00:37:39Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":17876,"stargazers_count":4641,"watchers_count":4641,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":155,"forks":380,"open_issues":155,"watchers":4641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1369"},"html":{"href":"https://github.com/coreos/rkt/pull/1369"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1369"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1369/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1369/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1369/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/8579ba95d0bdf3a6669a00e0894bcf67bb7b7dd1"}}}}