{"action":"created","comment":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/comments/47197132","id":47197132,"diff_hunk":"@@ -263,7 +265,30 @@ public function get($id)\n         if (!$this->offsetExists($id)) {\n             throw new ContainerValueNotFoundException(sprintf('Identifier \"%s\" is not defined.', $id));\n         }\n-        return $this->offsetGet($id);\n+        try {\n+            return $this->offsetGet($id);\n+        } catch (\\InvalidArgumentException $exception) {\n+            if ($this->exceptionThrownByContainer($exception)) {\n+                throw new SlimContainerException(","path":"Slim/Container.php","position":24,"original_position":24,"commit_id":"27b446e274bbb01f6c2fb6466eefc6571b2d7fe4","original_commit_id":"27b446e274bbb01f6c2fb6466eefc6571b2d7fe4","user":{"login":"akrabat","id":33135,"avatar_url":"https://avatars.githubusercontent.com/u/33135?v=3","gravatar_id":"","url":"https://api.github.com/users/akrabat","html_url":"https://github.com/akrabat","followers_url":"https://api.github.com/users/akrabat/followers","following_url":"https://api.github.com/users/akrabat/following{/other_user}","gists_url":"https://api.github.com/users/akrabat/gists{/gist_id}","starred_url":"https://api.github.com/users/akrabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrabat/subscriptions","organizations_url":"https://api.github.com/users/akrabat/orgs","repos_url":"https://api.github.com/users/akrabat/repos","events_url":"https://api.github.com/users/akrabat/events{/privacy}","received_events_url":"https://api.github.com/users/akrabat/received_events","type":"User","site_admin":false},"body":"This is a BC break. Currently, calling code can expect to catch an `\\InvalidArgumentException`, but this code changes that to a `\\RuntimeException`.","created_at":"2015-12-10T07:49:06Z","updated_at":"2015-12-10T07:49:06Z","html_url":"https://github.com/slimphp/Slim/pull/1663#discussion_r47197132","pull_request_url":"https://api.github.com/repos/slimphp/Slim/pulls/1663","_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments/47197132"},"html":{"href":"https://github.com/slimphp/Slim/pull/1663#discussion_r47197132"},"pull_request":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1663"}}},"pull_request":{"url":"https://api.github.com/repos/slimphp/Slim/pulls/1663","id":53058140,"html_url":"https://github.com/slimphp/Slim/pull/1663","diff_url":"https://github.com/slimphp/Slim/pull/1663.diff","patch_url":"https://github.com/slimphp/Slim/pull/1663.patch","issue_url":"https://api.github.com/repos/slimphp/Slim/issues/1663","number":1663,"state":"open","locked":false,"title":"ContainerInterop compliance improvement","user":{"login":"Sam-Burns","id":6594039,"avatar_url":"https://avatars.githubusercontent.com/u/6594039?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam-Burns","html_url":"https://github.com/Sam-Burns","followers_url":"https://api.github.com/users/Sam-Burns/followers","following_url":"https://api.github.com/users/Sam-Burns/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Burns/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Burns/subscriptions","organizations_url":"https://api.github.com/users/Sam-Burns/orgs","repos_url":"https://api.github.com/users/Sam-Burns/repos","events_url":"https://api.github.com/users/Sam-Burns/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Burns/received_events","type":"User","site_admin":false},"body":"Strict adherence to ContainerInterop standard w.r.t. exceptions","created_at":"2015-12-09T00:00:41Z","updated_at":"2015-12-10T07:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43f1c739472fcd57cd9bec76a6674ae57a51f39a","assignee":null,"milestone":{"url":"https://api.github.com/repos/slimphp/Slim/milestones/22","html_url":"https://github.com/slimphp/Slim/milestones/3.1.0","labels_url":"https://api.github.com/repos/slimphp/Slim/milestones/22/labels","id":1264830,"number":22,"title":"3.1.0","description":"","creator":{"login":"akrabat","id":33135,"avatar_url":"https://avatars.githubusercontent.com/u/33135?v=3","gravatar_id":"","url":"https://api.github.com/users/akrabat","html_url":"https://github.com/akrabat","followers_url":"https://api.github.com/users/akrabat/followers","following_url":"https://api.github.com/users/akrabat/following{/other_user}","gists_url":"https://api.github.com/users/akrabat/gists{/gist_id}","starred_url":"https://api.github.com/users/akrabat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akrabat/subscriptions","organizations_url":"https://api.github.com/users/akrabat/orgs","repos_url":"https://api.github.com/users/akrabat/repos","events_url":"https://api.github.com/users/akrabat/events{/privacy}","received_events_url":"https://api.github.com/users/akrabat/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2015-08-20T16:05:11Z","updated_at":"2015-12-09T16:19:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/slimphp/Slim/pulls/1663/commits","review_comments_url":"https://api.github.com/repos/slimphp/Slim/pulls/1663/comments","review_comment_url":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slimphp/Slim/issues/1663/comments","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/27b446e274bbb01f6c2fb6466eefc6571b2d7fe4","head":{"label":"Sam-Burns:3.x","ref":"3.x","sha":"27b446e274bbb01f6c2fb6466eefc6571b2d7fe4","user":{"login":"Sam-Burns","id":6594039,"avatar_url":"https://avatars.githubusercontent.com/u/6594039?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam-Burns","html_url":"https://github.com/Sam-Burns","followers_url":"https://api.github.com/users/Sam-Burns/followers","following_url":"https://api.github.com/users/Sam-Burns/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Burns/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Burns/subscriptions","organizations_url":"https://api.github.com/users/Sam-Burns/orgs","repos_url":"https://api.github.com/users/Sam-Burns/repos","events_url":"https://api.github.com/users/Sam-Burns/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Burns/received_events","type":"User","site_admin":false},"repo":{"id":47656371,"name":"Slim","full_name":"Sam-Burns/Slim","owner":{"login":"Sam-Burns","id":6594039,"avatar_url":"https://avatars.githubusercontent.com/u/6594039?v=3","gravatar_id":"","url":"https://api.github.com/users/Sam-Burns","html_url":"https://github.com/Sam-Burns","followers_url":"https://api.github.com/users/Sam-Burns/followers","following_url":"https://api.github.com/users/Sam-Burns/following{/other_user}","gists_url":"https://api.github.com/users/Sam-Burns/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam-Burns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam-Burns/subscriptions","organizations_url":"https://api.github.com/users/Sam-Burns/orgs","repos_url":"https://api.github.com/users/Sam-Burns/repos","events_url":"https://api.github.com/users/Sam-Burns/events{/privacy}","received_events_url":"https://api.github.com/users/Sam-Burns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sam-Burns/Slim","description":"Slim Framework source code","fork":true,"url":"https://api.github.com/repos/Sam-Burns/Slim","forks_url":"https://api.github.com/repos/Sam-Burns/Slim/forks","keys_url":"https://api.github.com/repos/Sam-Burns/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sam-Burns/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sam-Burns/Slim/teams","hooks_url":"https://api.github.com/repos/Sam-Burns/Slim/hooks","issue_events_url":"https://api.github.com/repos/Sam-Burns/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/Sam-Burns/Slim/events","assignees_url":"https://api.github.com/repos/Sam-Burns/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/Sam-Burns/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/Sam-Burns/Slim/tags","blobs_url":"https://api.github.com/repos/Sam-Burns/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sam-Burns/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sam-Burns/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sam-Burns/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sam-Burns/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/Sam-Burns/Slim/languages","stargazers_url":"https://api.github.com/repos/Sam-Burns/Slim/stargazers","contributors_url":"https://api.github.com/repos/Sam-Burns/Slim/contributors","subscribers_url":"https://api.github.com/repos/Sam-Burns/Slim/subscribers","subscription_url":"https://api.github.com/repos/Sam-Burns/Slim/subscription","commits_url":"https://api.github.com/repos/Sam-Burns/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sam-Burns/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sam-Burns/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sam-Burns/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sam-Burns/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/Sam-Burns/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sam-Burns/Slim/merges","archive_url":"https://api.github.com/repos/Sam-Burns/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sam-Burns/Slim/downloads","issues_url":"https://api.github.com/repos/Sam-Burns/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/Sam-Burns/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/Sam-Burns/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/Sam-Burns/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sam-Burns/Slim/labels{/name}","releases_url":"https://api.github.com/repos/Sam-Burns/Slim/releases{/id}","created_at":"2015-12-08T23:39:57Z","updated_at":"2015-12-08T23:39:58Z","pushed_at":"2015-12-10T02:03:17Z","git_url":"git://github.com/Sam-Burns/Slim.git","ssh_url":"git@github.com:Sam-Burns/Slim.git","clone_url":"https://github.com/Sam-Burns/Slim.git","svn_url":"https://github.com/Sam-Burns/Slim","homepage":"http://slimframework.com","size":4785,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"slimphp:3.x","ref":"3.x","sha":"fb0e176a2ff6cea2fce0a946d3c60683e6d834c1","user":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"repo":{"id":926544,"name":"Slim","full_name":"slimphp/Slim","owner":{"login":"slimphp","id":11195762,"avatar_url":"https://avatars.githubusercontent.com/u/11195762?v=3","gravatar_id":"","url":"https://api.github.com/users/slimphp","html_url":"https://github.com/slimphp","followers_url":"https://api.github.com/users/slimphp/followers","following_url":"https://api.github.com/users/slimphp/following{/other_user}","gists_url":"https://api.github.com/users/slimphp/gists{/gist_id}","starred_url":"https://api.github.com/users/slimphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slimphp/subscriptions","organizations_url":"https://api.github.com/users/slimphp/orgs","repos_url":"https://api.github.com/users/slimphp/repos","events_url":"https://api.github.com/users/slimphp/events{/privacy}","received_events_url":"https://api.github.com/users/slimphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slimphp/Slim","description":"Slim Framework source code","fork":false,"url":"https://api.github.com/repos/slimphp/Slim","forks_url":"https://api.github.com/repos/slimphp/Slim/forks","keys_url":"https://api.github.com/repos/slimphp/Slim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slimphp/Slim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slimphp/Slim/teams","hooks_url":"https://api.github.com/repos/slimphp/Slim/hooks","issue_events_url":"https://api.github.com/repos/slimphp/Slim/issues/events{/number}","events_url":"https://api.github.com/repos/slimphp/Slim/events","assignees_url":"https://api.github.com/repos/slimphp/Slim/assignees{/user}","branches_url":"https://api.github.com/repos/slimphp/Slim/branches{/branch}","tags_url":"https://api.github.com/repos/slimphp/Slim/tags","blobs_url":"https://api.github.com/repos/slimphp/Slim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slimphp/Slim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slimphp/Slim/git/refs{/sha}","trees_url":"https://api.github.com/repos/slimphp/Slim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slimphp/Slim/statuses/{sha}","languages_url":"https://api.github.com/repos/slimphp/Slim/languages","stargazers_url":"https://api.github.com/repos/slimphp/Slim/stargazers","contributors_url":"https://api.github.com/repos/slimphp/Slim/contributors","subscribers_url":"https://api.github.com/repos/slimphp/Slim/subscribers","subscription_url":"https://api.github.com/repos/slimphp/Slim/subscription","commits_url":"https://api.github.com/repos/slimphp/Slim/commits{/sha}","git_commits_url":"https://api.github.com/repos/slimphp/Slim/git/commits{/sha}","comments_url":"https://api.github.com/repos/slimphp/Slim/comments{/number}","issue_comment_url":"https://api.github.com/repos/slimphp/Slim/issues/comments{/number}","contents_url":"https://api.github.com/repos/slimphp/Slim/contents/{+path}","compare_url":"https://api.github.com/repos/slimphp/Slim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slimphp/Slim/merges","archive_url":"https://api.github.com/repos/slimphp/Slim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slimphp/Slim/downloads","issues_url":"https://api.github.com/repos/slimphp/Slim/issues{/number}","pulls_url":"https://api.github.com/repos/slimphp/Slim/pulls{/number}","milestones_url":"https://api.github.com/repos/slimphp/Slim/milestones{/number}","notifications_url":"https://api.github.com/repos/slimphp/Slim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slimphp/Slim/labels{/name}","releases_url":"https://api.github.com/repos/slimphp/Slim/releases{/id}","created_at":"2010-09-21T01:17:06Z","updated_at":"2015-12-10T07:37:01Z","pushed_at":"2015-12-10T02:03:18Z","git_url":"git://github.com/slimphp/Slim.git","ssh_url":"git@github.com:slimphp/Slim.git","clone_url":"https://github.com/slimphp/Slim.git","svn_url":"https://github.com/slimphp/Slim","homepage":"http://slimframework.com","size":6292,"stargazers_count":6118,"watchers_count":6118,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1142,"mirror_url":null,"open_issues_count":24,"forks":1142,"open_issues":24,"watchers":6118,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1663"},"html":{"href":"https://github.com/slimphp/Slim/pull/1663"},"issue":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1663"},"comments":{"href":"https://api.github.com/repos/slimphp/Slim/issues/1663/comments"},"review_comments":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1663/comments"},"review_comment":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slimphp/Slim/pulls/1663/commits"},"statuses":{"href":"https://api.github.com/repos/slimphp/Slim/statuses/27b446e274bbb01f6c2fb6466eefc6571b2d7fe4"}}}}