{"action":"created","comment":{"url":"https://api.github.com/repos/orientation/orientation/pulls/comments/41602288","id":41602288,"diff_hunk":"@@ -16,8 +16,10 @@\n     \"ORIENTATION_LOGO\": \"/assets/default_logo.svg\",\n     \"ORIENTATION_FAVICON\": \"/assets/default_favicon.png\",\n     \"ORIENTATION_DOMAIN\": \"REDACTED\",\n-    \"GOOGLE_SECRET\": \"REDACTED\",\n-    \"GOOGLE_KEY\": \"REDACTED\",\n+    \"OAUTH_PROVIDER_NAME\": \"REDACTED\",\n+    \"OAUTH_PROVIDER_SECRET\": \"REDACTED\",\n+    \"OAUTH_PROVIDER_KEY\": \"REDACTED\",\n+    \"OAUTH_PROVIDER_URL\": \"REDACTED\",","path":"app.json","position":9,"original_position":9,"commit_id":"87a723f287030dfdbeba5d7ad6ab8bd921f86599","original_commit_id":"87a723f287030dfdbeba5d7ad6ab8bd921f86599","user":{"login":"fuse","id":24833,"avatar_url":"https://avatars.githubusercontent.com/u/24833?v=3","gravatar_id":"","url":"https://api.github.com/users/fuse","html_url":"https://github.com/fuse","followers_url":"https://api.github.com/users/fuse/followers","following_url":"https://api.github.com/users/fuse/following{/other_user}","gists_url":"https://api.github.com/users/fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuse/subscriptions","organizations_url":"https://api.github.com/users/fuse/orgs","repos_url":"https://api.github.com/users/fuse/repos","events_url":"https://api.github.com/users/fuse/events{/privacy}","received_events_url":"https://api.github.com/users/fuse/received_events","type":"User","site_admin":false},"body":"Ok, can I just keep both ?","created_at":"2015-10-09T07:04:07Z","updated_at":"2015-10-09T07:04:07Z","html_url":"https://github.com/orientation/orientation/pull/203#discussion_r41602288","pull_request_url":"https://api.github.com/repos/orientation/orientation/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/orientation/orientation/pulls/comments/41602288"},"html":{"href":"https://github.com/orientation/orientation/pull/203#discussion_r41602288"},"pull_request":{"href":"https://api.github.com/repos/orientation/orientation/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/orientation/orientation/pulls/203","id":47162013,"html_url":"https://github.com/orientation/orientation/pull/203","diff_url":"https://github.com/orientation/orientation/pull/203.diff","patch_url":"https://github.com/orientation/orientation/pull/203.patch","issue_url":"https://api.github.com/repos/orientation/orientation/issues/203","number":203,"state":"open","locked":false,"title":"Allow OAuth with any provider","user":{"login":"fuse","id":24833,"avatar_url":"https://avatars.githubusercontent.com/u/24833?v=3","gravatar_id":"","url":"https://api.github.com/users/fuse","html_url":"https://github.com/fuse","followers_url":"https://api.github.com/users/fuse/followers","following_url":"https://api.github.com/users/fuse/following{/other_user}","gists_url":"https://api.github.com/users/fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuse/subscriptions","organizations_url":"https://api.github.com/users/fuse/orgs","repos_url":"https://api.github.com/users/fuse/repos","events_url":"https://api.github.com/users/fuse/events{/privacy}","received_events_url":"https://api.github.com/users/fuse/received_events","type":"User","site_admin":false},"body":"This is a proposal for more generic oauth provider as discussed in #201 \r\n\r\nI can confirm that it works for us, using our own SSO based on doorkeeper.","created_at":"2015-10-08T14:45:32Z","updated_at":"2015-10-09T07:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27515a314686bfe1ffb26351ed1673d7fd34b229","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/orientation/orientation/pulls/203/commits","review_comments_url":"https://api.github.com/repos/orientation/orientation/pulls/203/comments","review_comment_url":"https://api.github.com/repos/orientation/orientation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orientation/orientation/issues/203/comments","statuses_url":"https://api.github.com/repos/orientation/orientation/statuses/87a723f287030dfdbeba5d7ad6ab8bd921f86599","head":{"label":"fuse:develop","ref":"develop","sha":"87a723f287030dfdbeba5d7ad6ab8bd921f86599","user":{"login":"fuse","id":24833,"avatar_url":"https://avatars.githubusercontent.com/u/24833?v=3","gravatar_id":"","url":"https://api.github.com/users/fuse","html_url":"https://github.com/fuse","followers_url":"https://api.github.com/users/fuse/followers","following_url":"https://api.github.com/users/fuse/following{/other_user}","gists_url":"https://api.github.com/users/fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuse/subscriptions","organizations_url":"https://api.github.com/users/fuse/orgs","repos_url":"https://api.github.com/users/fuse/repos","events_url":"https://api.github.com/users/fuse/events{/privacy}","received_events_url":"https://api.github.com/users/fuse/received_events","type":"User","site_admin":false},"repo":{"id":43817840,"name":"orientation","full_name":"fuse/orientation","owner":{"login":"fuse","id":24833,"avatar_url":"https://avatars.githubusercontent.com/u/24833?v=3","gravatar_id":"","url":"https://api.github.com/users/fuse","html_url":"https://github.com/fuse","followers_url":"https://api.github.com/users/fuse/followers","following_url":"https://api.github.com/users/fuse/following{/other_user}","gists_url":"https://api.github.com/users/fuse/gists{/gist_id}","starred_url":"https://api.github.com/users/fuse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuse/subscriptions","organizations_url":"https://api.github.com/users/fuse/orgs","repos_url":"https://api.github.com/users/fuse/repos","events_url":"https://api.github.com/users/fuse/events{/privacy}","received_events_url":"https://api.github.com/users/fuse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fuse/orientation","description":"Fight information rot.","fork":true,"url":"https://api.github.com/repos/fuse/orientation","forks_url":"https://api.github.com/repos/fuse/orientation/forks","keys_url":"https://api.github.com/repos/fuse/orientation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuse/orientation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuse/orientation/teams","hooks_url":"https://api.github.com/repos/fuse/orientation/hooks","issue_events_url":"https://api.github.com/repos/fuse/orientation/issues/events{/number}","events_url":"https://api.github.com/repos/fuse/orientation/events","assignees_url":"https://api.github.com/repos/fuse/orientation/assignees{/user}","branches_url":"https://api.github.com/repos/fuse/orientation/branches{/branch}","tags_url":"https://api.github.com/repos/fuse/orientation/tags","blobs_url":"https://api.github.com/repos/fuse/orientation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuse/orientation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuse/orientation/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuse/orientation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuse/orientation/statuses/{sha}","languages_url":"https://api.github.com/repos/fuse/orientation/languages","stargazers_url":"https://api.github.com/repos/fuse/orientation/stargazers","contributors_url":"https://api.github.com/repos/fuse/orientation/contributors","subscribers_url":"https://api.github.com/repos/fuse/orientation/subscribers","subscription_url":"https://api.github.com/repos/fuse/orientation/subscription","commits_url":"https://api.github.com/repos/fuse/orientation/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuse/orientation/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuse/orientation/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuse/orientation/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuse/orientation/contents/{+path}","compare_url":"https://api.github.com/repos/fuse/orientation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuse/orientation/merges","archive_url":"https://api.github.com/repos/fuse/orientation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuse/orientation/downloads","issues_url":"https://api.github.com/repos/fuse/orientation/issues{/number}","pulls_url":"https://api.github.com/repos/fuse/orientation/pulls{/number}","milestones_url":"https://api.github.com/repos/fuse/orientation/milestones{/number}","notifications_url":"https://api.github.com/repos/fuse/orientation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuse/orientation/labels{/name}","releases_url":"https://api.github.com/repos/fuse/orientation/releases{/id}","created_at":"2015-10-07T13:32:52Z","updated_at":"2015-10-07T13:32:53Z","pushed_at":"2015-10-08T14:41:57Z","git_url":"git://github.com/fuse/orientation.git","ssh_url":"git@github.com:fuse/orientation.git","clone_url":"https://github.com/fuse/orientation.git","svn_url":"https://github.com/fuse/orientation","homepage":"http://orientation.io","size":8558,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"orientation:master","ref":"master","sha":"5836ae0695f221351eb367277933723c294ea3f1","user":{"login":"orientation","id":11703432,"avatar_url":"https://avatars.githubusercontent.com/u/11703432?v=3","gravatar_id":"","url":"https://api.github.com/users/orientation","html_url":"https://github.com/orientation","followers_url":"https://api.github.com/users/orientation/followers","following_url":"https://api.github.com/users/orientation/following{/other_user}","gists_url":"https://api.github.com/users/orientation/gists{/gist_id}","starred_url":"https://api.github.com/users/orientation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orientation/subscriptions","organizations_url":"https://api.github.com/users/orientation/orgs","repos_url":"https://api.github.com/users/orientation/repos","events_url":"https://api.github.com/users/orientation/events{/privacy}","received_events_url":"https://api.github.com/users/orientation/received_events","type":"Organization","site_admin":false},"repo":{"id":6251961,"name":"orientation","full_name":"orientation/orientation","owner":{"login":"orientation","id":11703432,"avatar_url":"https://avatars.githubusercontent.com/u/11703432?v=3","gravatar_id":"","url":"https://api.github.com/users/orientation","html_url":"https://github.com/orientation","followers_url":"https://api.github.com/users/orientation/followers","following_url":"https://api.github.com/users/orientation/following{/other_user}","gists_url":"https://api.github.com/users/orientation/gists{/gist_id}","starred_url":"https://api.github.com/users/orientation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orientation/subscriptions","organizations_url":"https://api.github.com/users/orientation/orgs","repos_url":"https://api.github.com/users/orientation/repos","events_url":"https://api.github.com/users/orientation/events{/privacy}","received_events_url":"https://api.github.com/users/orientation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orientation/orientation","description":"Fight information rot.","fork":false,"url":"https://api.github.com/repos/orientation/orientation","forks_url":"https://api.github.com/repos/orientation/orientation/forks","keys_url":"https://api.github.com/repos/orientation/orientation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orientation/orientation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orientation/orientation/teams","hooks_url":"https://api.github.com/repos/orientation/orientation/hooks","issue_events_url":"https://api.github.com/repos/orientation/orientation/issues/events{/number}","events_url":"https://api.github.com/repos/orientation/orientation/events","assignees_url":"https://api.github.com/repos/orientation/orientation/assignees{/user}","branches_url":"https://api.github.com/repos/orientation/orientation/branches{/branch}","tags_url":"https://api.github.com/repos/orientation/orientation/tags","blobs_url":"https://api.github.com/repos/orientation/orientation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orientation/orientation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orientation/orientation/git/refs{/sha}","trees_url":"https://api.github.com/repos/orientation/orientation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orientation/orientation/statuses/{sha}","languages_url":"https://api.github.com/repos/orientation/orientation/languages","stargazers_url":"https://api.github.com/repos/orientation/orientation/stargazers","contributors_url":"https://api.github.com/repos/orientation/orientation/contributors","subscribers_url":"https://api.github.com/repos/orientation/orientation/subscribers","subscription_url":"https://api.github.com/repos/orientation/orientation/subscription","commits_url":"https://api.github.com/repos/orientation/orientation/commits{/sha}","git_commits_url":"https://api.github.com/repos/orientation/orientation/git/commits{/sha}","comments_url":"https://api.github.com/repos/orientation/orientation/comments{/number}","issue_comment_url":"https://api.github.com/repos/orientation/orientation/issues/comments{/number}","contents_url":"https://api.github.com/repos/orientation/orientation/contents/{+path}","compare_url":"https://api.github.com/repos/orientation/orientation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orientation/orientation/merges","archive_url":"https://api.github.com/repos/orientation/orientation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orientation/orientation/downloads","issues_url":"https://api.github.com/repos/orientation/orientation/issues{/number}","pulls_url":"https://api.github.com/repos/orientation/orientation/pulls{/number}","milestones_url":"https://api.github.com/repos/orientation/orientation/milestones{/number}","notifications_url":"https://api.github.com/repos/orientation/orientation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orientation/orientation/labels{/name}","releases_url":"https://api.github.com/repos/orientation/orientation/releases{/id}","created_at":"2012-10-16T21:25:35Z","updated_at":"2015-10-03T00:11:19Z","pushed_at":"2015-10-09T01:23:57Z","git_url":"git://github.com/orientation/orientation.git","ssh_url":"git@github.com:orientation/orientation.git","clone_url":"https://github.com/orientation/orientation.git","svn_url":"https://github.com/orientation/orientation","homepage":"http://orientation.io","size":8558,"stargazers_count":218,"watchers_count":218,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":26,"forks":50,"open_issues":26,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orientation/orientation/pulls/203"},"html":{"href":"https://github.com/orientation/orientation/pull/203"},"issue":{"href":"https://api.github.com/repos/orientation/orientation/issues/203"},"comments":{"href":"https://api.github.com/repos/orientation/orientation/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/orientation/orientation/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/orientation/orientation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orientation/orientation/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/orientation/orientation/statuses/87a723f287030dfdbeba5d7ad6ab8bd921f86599"}}}}