{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/39235771","id":39235771,"diff_hunk":"@@ -158,20 +130,24 @@ else()\n endif()\n \n if(NOT ENABLE_GENERIC)\n-\tif(${CMAKE_SYSTEM_PROCESSOR} MATCHES \"^x86\" OR\n-\t   ${CMAKE_SYSTEM_PROCESSOR} MATCHES \"i.86\" OR\n-\t   ${CMAKE_SYSTEM_PROCESSOR} MATCHES \"amd64\" OR\n+\tstring(TOLOWER \"${CMAKE_SYSTEM_PROCESSOR}\" LOWERCASE_SYSTEM_PROCESSOR)\n+\tif(${LOWERCASE_SYSTEM_PROCESSOR} MATCHES \"^x86\" OR\n+\t   ${LOWERCASE_SYSTEM_PROCESSOR} MATCHES \"i.86\" OR\n+\t   ${LOWERCASE_SYSTEM_PROCESSOR} MATCHES \"amd64\" OR\n \t   APPLE)\n \t\tif(_ARCH_64)\n \t\t\tset(_M_X86 1)\n \t\t\tset(_M_X86_64 1)\n-\t\t\tadd_definitions(-D_M_X86=1 -D_M_X86_64=1 -msse2)\n+\t\t\tadd_definitions(-D_M_X86=1 -D_M_X86_64=1)\n+\t\t\tif(NOT MSVC)\n+\t\t\t\tadd_definitions(-msse2)","path":"CMakeLists.txt","position":53,"original_position":53,"commit_id":"f62f903b9502fe56db182bc818c48c435796f8e1","original_commit_id":"f62f903b9502fe56db182bc818c48c435796f8e1","user":{"login":"waddlesplash","id":2175324,"avatar_url":"https://avatars.githubusercontent.com/u/2175324?v=3","gravatar_id":"","url":"https://api.github.com/users/waddlesplash","html_url":"https://github.com/waddlesplash","followers_url":"https://api.github.com/users/waddlesplash/followers","following_url":"https://api.github.com/users/waddlesplash/following{/other_user}","gists_url":"https://api.github.com/users/waddlesplash/gists{/gist_id}","starred_url":"https://api.github.com/users/waddlesplash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waddlesplash/subscriptions","organizations_url":"https://api.github.com/users/waddlesplash/orgs","repos_url":"https://api.github.com/users/waddlesplash/repos","events_url":"https://api.github.com/users/waddlesplash/events{/privacy}","received_events_url":"https://api.github.com/users/waddlesplash/received_events","type":"User","site_admin":false},"body":"Probably not. Will remove.","created_at":"2015-09-11T02:10:55Z","updated_at":"2015-09-11T02:10:55Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3020#discussion_r39235771","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/39235771"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3020#discussion_r39235771"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020","id":44735081,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3020","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3020.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3020.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3020","number":3020,"state":"open","locked":false,"title":"Modify CMake build system to also support MSVC.","user":{"login":"waddlesplash","id":2175324,"avatar_url":"https://avatars.githubusercontent.com/u/2175324?v=3","gravatar_id":"","url":"https://api.github.com/users/waddlesplash","html_url":"https://github.com/waddlesplash","followers_url":"https://api.github.com/users/waddlesplash/followers","following_url":"https://api.github.com/users/waddlesplash/following{/other_user}","gists_url":"https://api.github.com/users/waddlesplash/gists{/gist_id}","starred_url":"https://api.github.com/users/waddlesplash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waddlesplash/subscriptions","organizations_url":"https://api.github.com/users/waddlesplash/orgs","repos_url":"https://api.github.com/users/waddlesplash/repos","events_url":"https://api.github.com/users/waddlesplash/events{/privacy}","received_events_url":"https://api.github.com/users/waddlesplash/received_events","type":"User","site_admin":false},"body":"Essentially just the build system portion of #2946 with some MSVC-centric changes.\r\n\r\nDoes not build because the PCH-less build on Windows is busted, and the old MSVC PCH CMake stuff was busted and I wasn't able to fix it.","created_at":"2015-09-11T00:25:19Z","updated_at":"2015-09-11T02:10:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9411cca80695eb5f188a0b68d11b5f0d932371cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3020/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f62f903b9502fe56db182bc818c48c435796f8e1","head":{"label":"waddlesplash:cmake_msvc","ref":"cmake_msvc","sha":"f62f903b9502fe56db182bc818c48c435796f8e1","user":{"login":"waddlesplash","id":2175324,"avatar_url":"https://avatars.githubusercontent.com/u/2175324?v=3","gravatar_id":"","url":"https://api.github.com/users/waddlesplash","html_url":"https://github.com/waddlesplash","followers_url":"https://api.github.com/users/waddlesplash/followers","following_url":"https://api.github.com/users/waddlesplash/following{/other_user}","gists_url":"https://api.github.com/users/waddlesplash/gists{/gist_id}","starred_url":"https://api.github.com/users/waddlesplash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waddlesplash/subscriptions","organizations_url":"https://api.github.com/users/waddlesplash/orgs","repos_url":"https://api.github.com/users/waddlesplash/repos","events_url":"https://api.github.com/users/waddlesplash/events{/privacy}","received_events_url":"https://api.github.com/users/waddlesplash/received_events","type":"User","site_admin":false},"repo":{"id":23736753,"name":"dolphin","full_name":"waddlesplash/dolphin","owner":{"login":"waddlesplash","id":2175324,"avatar_url":"https://avatars.githubusercontent.com/u/2175324?v=3","gravatar_id":"","url":"https://api.github.com/users/waddlesplash","html_url":"https://github.com/waddlesplash","followers_url":"https://api.github.com/users/waddlesplash/followers","following_url":"https://api.github.com/users/waddlesplash/following{/other_user}","gists_url":"https://api.github.com/users/waddlesplash/gists{/gist_id}","starred_url":"https://api.github.com/users/waddlesplash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waddlesplash/subscriptions","organizations_url":"https://api.github.com/users/waddlesplash/orgs","repos_url":"https://api.github.com/users/waddlesplash/repos","events_url":"https://api.github.com/users/waddlesplash/events{/privacy}","received_events_url":"https://api.github.com/users/waddlesplash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/waddlesplash/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/waddlesplash/dolphin","forks_url":"https://api.github.com/repos/waddlesplash/dolphin/forks","keys_url":"https://api.github.com/repos/waddlesplash/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/waddlesplash/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/waddlesplash/dolphin/teams","hooks_url":"https://api.github.com/repos/waddlesplash/dolphin/hooks","issue_events_url":"https://api.github.com/repos/waddlesplash/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/waddlesplash/dolphin/events","assignees_url":"https://api.github.com/repos/waddlesplash/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/waddlesplash/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/waddlesplash/dolphin/tags","blobs_url":"https://api.github.com/repos/waddlesplash/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/waddlesplash/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/waddlesplash/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/waddlesplash/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/waddlesplash/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/waddlesplash/dolphin/languages","stargazers_url":"https://api.github.com/repos/waddlesplash/dolphin/stargazers","contributors_url":"https://api.github.com/repos/waddlesplash/dolphin/contributors","subscribers_url":"https://api.github.com/repos/waddlesplash/dolphin/subscribers","subscription_url":"https://api.github.com/repos/waddlesplash/dolphin/subscription","commits_url":"https://api.github.com/repos/waddlesplash/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/waddlesplash/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/waddlesplash/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/waddlesplash/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/waddlesplash/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/waddlesplash/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/waddlesplash/dolphin/merges","archive_url":"https://api.github.com/repos/waddlesplash/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/waddlesplash/dolphin/downloads","issues_url":"https://api.github.com/repos/waddlesplash/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/waddlesplash/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/waddlesplash/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/waddlesplash/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/waddlesplash/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/waddlesplash/dolphin/releases{/id}","created_at":"2014-09-06T14:43:14Z","updated_at":"2014-09-12T00:23:46Z","pushed_at":"2015-09-11T00:26:51Z","git_url":"git://github.com/waddlesplash/dolphin.git","ssh_url":"git@github.com:waddlesplash/dolphin.git","clone_url":"https://github.com/waddlesplash/dolphin.git","svn_url":"https://github.com/waddlesplash/dolphin","homepage":null,"size":224614,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"3014feedc839d69931079ad3c4f645ef51055e1a","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-09-11T00:21:01Z","pushed_at":"2015-09-11T00:26:51Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":306722,"stargazers_count":1638,"watchers_count":1638,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":86,"forks":518,"open_issues":86,"watchers":1638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3020"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3020"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3020/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3020/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f62f903b9502fe56db182bc818c48c435796f8e1"}}}}