{"action":"closed","number":2267,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267","id":45629606,"html_url":"https://github.com/bbatsov/rubocop/pull/2267","diff_url":"https://github.com/bbatsov/rubocop/pull/2267.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/2267.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2267","number":2267,"state":"closed","locked":false,"title":"Correctly indicate command line options in DisabledConfigFormatter","user":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"body":"The aim of this branch is to ensure that `.rubocop_todo.yml` correctly indicates the command line options passed to it. However, the code changes are extremely ugly, and might break custom cops. Should some alternative approach be taken, either storing the command line arguments in `RuboCop::ConfigStore`, or just using ARGV within DisabledConfigFormatter?\r\n\r\nAn apparently redundant spec was deleted in the process.","created_at":"2015-09-22T06:10:51Z","updated_at":"2015-12-25T09:15:53Z","closed_at":"2015-12-25T09:15:53Z","merged_at":null,"merge_commit_sha":"470738329b2865cdf34887b81c1734fcfcef9805","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/2267/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/06fcda034d1042994d069f6582e9a793c9c7a1a4","head":{"label":"agrimm:hack/display-options-in-rubocop-todo","ref":"hack/display-options-in-rubocop-todo","sha":"06fcda034d1042994d069f6582e9a793c9c7a1a4","user":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"repo":{"id":13911232,"name":"rubocop","full_name":"agrimm/rubocop","owner":{"login":"agrimm","id":20378,"avatar_url":"https://avatars.githubusercontent.com/u/20378?v=3","gravatar_id":"","url":"https://api.github.com/users/agrimm","html_url":"https://github.com/agrimm","followers_url":"https://api.github.com/users/agrimm/followers","following_url":"https://api.github.com/users/agrimm/following{/other_user}","gists_url":"https://api.github.com/users/agrimm/gists{/gist_id}","starred_url":"https://api.github.com/users/agrimm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrimm/subscriptions","organizations_url":"https://api.github.com/users/agrimm/orgs","repos_url":"https://api.github.com/users/agrimm/repos","events_url":"https://api.github.com/users/agrimm/events{/privacy}","received_events_url":"https://api.github.com/users/agrimm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agrimm/rubocop","description":"An experimental Ruby code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/agrimm/rubocop","forks_url":"https://api.github.com/repos/agrimm/rubocop/forks","keys_url":"https://api.github.com/repos/agrimm/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agrimm/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agrimm/rubocop/teams","hooks_url":"https://api.github.com/repos/agrimm/rubocop/hooks","issue_events_url":"https://api.github.com/repos/agrimm/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/agrimm/rubocop/events","assignees_url":"https://api.github.com/repos/agrimm/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/agrimm/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/agrimm/rubocop/tags","blobs_url":"https://api.github.com/repos/agrimm/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agrimm/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agrimm/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/agrimm/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agrimm/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/agrimm/rubocop/languages","stargazers_url":"https://api.github.com/repos/agrimm/rubocop/stargazers","contributors_url":"https://api.github.com/repos/agrimm/rubocop/contributors","subscribers_url":"https://api.github.com/repos/agrimm/rubocop/subscribers","subscription_url":"https://api.github.com/repos/agrimm/rubocop/subscription","commits_url":"https://api.github.com/repos/agrimm/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/agrimm/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/agrimm/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/agrimm/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/agrimm/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/agrimm/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agrimm/rubocop/merges","archive_url":"https://api.github.com/repos/agrimm/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agrimm/rubocop/downloads","issues_url":"https://api.github.com/repos/agrimm/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/agrimm/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/agrimm/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/agrimm/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agrimm/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/agrimm/rubocop/releases{/id}","created_at":"2013-10-27T22:04:55Z","updated_at":"2015-10-09T11:48:49Z","pushed_at":"2015-11-14T08:31:58Z","git_url":"git://github.com/agrimm/rubocop.git","ssh_url":"git@github.com:agrimm/rubocop.git","clone_url":"https://github.com/agrimm/rubocop.git","svn_url":"https://github.com/agrimm/rubocop","homepage":"http://batsov.com/rubocop","size":10371,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"a03e5cfd1c3cffc3701ad752d4b8f09f29f86a73","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars.githubusercontent.com/u/103882?v=3","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","created_at":"2012-04-21T10:09:58Z","updated_at":"2015-12-25T06:21:57Z","pushed_at":"2015-12-25T04:06:05Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"","size":13340,"stargazers_count":5581,"watchers_count":5581,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":684,"mirror_url":null,"open_issues_count":58,"forks":684,"open_issues":58,"watchers":5581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/2267"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/2267"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/2267/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/2267/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/06fcda034d1042994d069f6582e9a793c9c7a1a4"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":1,"commits":1,"additions":145,"deletions":129,"changed_files":24}}