{"action":"created","comment":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/24718387","id":24718387,"diff_hunk":"@@ -59,46 +59,46 @@\n  * @SuppressWarnings(PMD.UnusedPrivateField)\n  */\n class BMGame {\n-    // properties -- all accessible, but written as private to enable the use of\n+    // properties -- all accessible, but written as protected to enable the use of\n     //               getters and setters\n-    private $gameId;                // game ID number in the database\n-    private $playerIdArray;         // array of player IDs\n-    private $nPlayers;              // number of players in the game\n-    private $roundNumber;           // current round number\n-    private $turnNumberInRound;     // current turn number in current round\n-    private $activePlayerIdx;       // index of the active player in playerIdxArray\n-    private $playerWithInitiativeIdx; // index of the player who won initiative\n-    private $buttonArray;           // buttons for all players\n-    private $activeDieArrayArray;   // active dice for all players\n-    private $attack;                // array('attackerPlayerIdx',\n+    protected $gameId;                // game ID number in the database\n+    protected $playerIdArray;         // array of player IDs\n+    protected $nPlayers;              // number of players in the game\n+    protected $roundNumber;           // current round number\n+    protected $turnNumberInRound;     // current turn number in current round\n+    protected $activePlayerIdx;       // index of the active player in playerIdxArray\n+    protected $playerWithInitiativeIdx; // index of the player who won initiative\n+    protected $buttonArray;           // buttons for all players\n+    protected $activeDieArrayArray;   // active dice for all players\n+    protected $attack;                // array('attackerPlayerIdx',","path":"src/engine/BMGame.php","position":26,"original_position":26,"commit_id":"82e8fa35cc344eb7594230dcb14cf62e6a6ccc69","original_commit_id":"82e8fa35cc344eb7594230dcb14cf62e6a6ccc69","user":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"body":"Why the change of all these variables from private to protected as part of this pull?  I don't see a problem with the change, but i don't understand what it had to do with Warrior.","created_at":"2015-02-15T00:05:50Z","updated_at":"2015-02-15T00:05:50Z","html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1520#discussion_r24718387","pull_request_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520","_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/24718387"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/1520#discussion_r24718387"},"pull_request":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520"}}},"pull_request":{"url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520","id":29092191,"html_url":"https://github.com/buttonmen-dev/buttonmen/pull/1520","diff_url":"https://github.com/buttonmen-dev/buttonmen/pull/1520.diff","patch_url":"https://github.com/buttonmen-dev/buttonmen/pull/1520.patch","issue_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1520","number":1520,"state":"open","locked":false,"title":"Implemented warrior skill","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=3","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"body":"Fixes #264.\r\n\r\nThis should fully enable the warrior skill. However, it will probably need extra unit testing, for example, responder tests for valid and invalid attacks.\r\n\r\nhttp://jenkins.buttonweavers.com:8080/job/buttonmen-blackshadowshade/624/ (assuming it passes)","created_at":"2015-02-11T13:56:14Z","updated_at":"2015-02-15T00:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11660aaa17341d6d14539aeeb94dc3e86a4637b3","assignee":{"login":"cgolubi1","id":2898207,"avatar_url":"https://avatars.githubusercontent.com/u/2898207?v=3","gravatar_id":"","url":"https://api.github.com/users/cgolubi1","html_url":"https://github.com/cgolubi1","followers_url":"https://api.github.com/users/cgolubi1/followers","following_url":"https://api.github.com/users/cgolubi1/following{/other_user}","gists_url":"https://api.github.com/users/cgolubi1/gists{/gist_id}","starred_url":"https://api.github.com/users/cgolubi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgolubi1/subscriptions","organizations_url":"https://api.github.com/users/cgolubi1/orgs","repos_url":"https://api.github.com/users/cgolubi1/repos","events_url":"https://api.github.com/users/cgolubi1/events{/privacy}","received_events_url":"https://api.github.com/users/cgolubi1/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520/commits","review_comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520/comments","review_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1520/comments","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/82e8fa35cc344eb7594230dcb14cf62e6a6ccc69","head":{"label":"blackshadowshade:264_warrior","ref":"264_warrior","sha":"82e8fa35cc344eb7594230dcb14cf62e6a6ccc69","user":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=3","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"repo":{"id":6902326,"name":"buttonmen","full_name":"blackshadowshade/buttonmen","owner":{"login":"blackshadowshade","id":2898401,"avatar_url":"https://avatars.githubusercontent.com/u/2898401?v=3","gravatar_id":"","url":"https://api.github.com/users/blackshadowshade","html_url":"https://github.com/blackshadowshade","followers_url":"https://api.github.com/users/blackshadowshade/followers","following_url":"https://api.github.com/users/blackshadowshade/following{/other_user}","gists_url":"https://api.github.com/users/blackshadowshade/gists{/gist_id}","starred_url":"https://api.github.com/users/blackshadowshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackshadowshade/subscriptions","organizations_url":"https://api.github.com/users/blackshadowshade/orgs","repos_url":"https://api.github.com/users/blackshadowshade/repos","events_url":"https://api.github.com/users/blackshadowshade/events{/privacy}","received_events_url":"https://api.github.com/users/blackshadowshade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blackshadowshade/buttonmen","description":"Buttonmen - an online dice game","fork":true,"url":"https://api.github.com/repos/blackshadowshade/buttonmen","forks_url":"https://api.github.com/repos/blackshadowshade/buttonmen/forks","keys_url":"https://api.github.com/repos/blackshadowshade/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackshadowshade/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackshadowshade/buttonmen/teams","hooks_url":"https://api.github.com/repos/blackshadowshade/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/blackshadowshade/buttonmen/events","assignees_url":"https://api.github.com/repos/blackshadowshade/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/blackshadowshade/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/blackshadowshade/buttonmen/tags","blobs_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackshadowshade/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/blackshadowshade/buttonmen/languages","stargazers_url":"https://api.github.com/repos/blackshadowshade/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/blackshadowshade/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/blackshadowshade/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/blackshadowshade/buttonmen/subscription","commits_url":"https://api.github.com/repos/blackshadowshade/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackshadowshade/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackshadowshade/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/blackshadowshade/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/blackshadowshade/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackshadowshade/buttonmen/merges","archive_url":"https://api.github.com/repos/blackshadowshade/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackshadowshade/buttonmen/downloads","issues_url":"https://api.github.com/repos/blackshadowshade/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/blackshadowshade/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/blackshadowshade/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/blackshadowshade/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackshadowshade/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/blackshadowshade/buttonmen/releases{/id}","created_at":"2012-11-28T13:25:42Z","updated_at":"2015-02-13T00:17:00Z","pushed_at":"2015-02-14T12:44:18Z","git_url":"git://github.com/blackshadowshade/buttonmen.git","ssh_url":"git@github.com:blackshadowshade/buttonmen.git","clone_url":"https://github.com/blackshadowshade/buttonmen.git","svn_url":"https://github.com/blackshadowshade/buttonmen","homepage":null,"size":41181,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buttonmen-dev:master","ref":"master","sha":"ed3a516c973f87c45672de3d70648bbcef6073bf","user":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?v=3","gravatar_id":"","url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":6877175,"name":"buttonmen","full_name":"buttonmen-dev/buttonmen","owner":{"login":"buttonmen-dev","id":2898279,"avatar_url":"https://avatars.githubusercontent.com/u/2898279?v=3","gravatar_id":"","url":"https://api.github.com/users/buttonmen-dev","html_url":"https://github.com/buttonmen-dev","followers_url":"https://api.github.com/users/buttonmen-dev/followers","following_url":"https://api.github.com/users/buttonmen-dev/following{/other_user}","gists_url":"https://api.github.com/users/buttonmen-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/buttonmen-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buttonmen-dev/subscriptions","organizations_url":"https://api.github.com/users/buttonmen-dev/orgs","repos_url":"https://api.github.com/users/buttonmen-dev/repos","events_url":"https://api.github.com/users/buttonmen-dev/events{/privacy}","received_events_url":"https://api.github.com/users/buttonmen-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buttonmen-dev/buttonmen","description":"Buttonmen - an online dice game","fork":false,"url":"https://api.github.com/repos/buttonmen-dev/buttonmen","forks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/forks","keys_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/teams","hooks_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/hooks","issue_events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/events{/number}","events_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/events","assignees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/assignees{/user}","branches_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/branches{/branch}","tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/tags","blobs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/refs{/sha}","trees_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/{sha}","languages_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/languages","stargazers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/stargazers","contributors_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contributors","subscribers_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscribers","subscription_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/subscription","commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/commits{/sha}","git_commits_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/git/commits{/sha}","comments_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/comments{/number}","issue_comment_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/comments/{number}","contents_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/contents/{+path}","compare_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/merges","archive_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/downloads","issues_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues{/number}","pulls_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls{/number}","milestones_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/milestones{/number}","notifications_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/labels{/name}","releases_url":"https://api.github.com/repos/buttonmen-dev/buttonmen/releases{/id}","created_at":"2012-11-27T03:55:05Z","updated_at":"2015-02-14T22:58:05Z","pushed_at":"2015-02-14T22:58:05Z","git_url":"git://github.com/buttonmen-dev/buttonmen.git","ssh_url":"git@github.com:buttonmen-dev/buttonmen.git","clone_url":"https://github.com/buttonmen-dev/buttonmen.git","svn_url":"https://github.com/buttonmen-dev/buttonmen","homepage":null,"size":42196,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":262,"forks":14,"open_issues":262,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520"},"html":{"href":"https://github.com/buttonmen-dev/buttonmen/pull/1520"},"issue":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1520"},"comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/issues/1520/comments"},"review_comments":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520/comments"},"review_comment":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/pulls/1520/commits"},"statuses":{"href":"https://api.github.com/repos/buttonmen-dev/buttonmen/statuses/82e8fa35cc344eb7594230dcb14cf62e6a6ccc69"}}}}