{"action":"closed","number":307,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/hiera/pulls/307","id":45350509,"html_url":"https://github.com/puppetlabs/hiera/pull/307","diff_url":"https://github.com/puppetlabs/hiera/pull/307.diff","patch_url":"https://github.com/puppetlabs/hiera/pull/307.patch","issue_url":"https://api.github.com/repos/puppetlabs/hiera/issues/307","number":307,"state":"closed","locked":false,"title":"(maint) Improve error message in read_file for filecache","user":{"login":"haus","id":98408,"avatar_url":"https://avatars.githubusercontent.com/u/98408?v=3","gravatar_id":"","url":"https://api.github.com/users/haus","html_url":"https://github.com/haus","followers_url":"https://api.github.com/users/haus/followers","following_url":"https://api.github.com/users/haus/following{/other_user}","gists_url":"https://api.github.com/users/haus/gists{/gist_id}","starred_url":"https://api.github.com/users/haus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haus/subscriptions","organizations_url":"https://api.github.com/users/haus/orgs","repos_url":"https://api.github.com/users/haus/repos","events_url":"https://api.github.com/users/haus/events{/privacy}","received_events_url":"https://api.github.com/users/haus/received_events","type":"User","site_admin":false},"body":"Previously if a type error occurred during the file_read, the error\r\nmessage would always say that the data retrieved is a string, and not\r\nthe expected type. This is because data comes from File.read, which\r\nreturns a string. Having the class of the data from the @cache object\r\nallows the error message to be more helpful and return the class of the\r\nparsed data instead of just 'String'.","created_at":"2015-09-17T22:36:10Z","updated_at":"2015-09-17T22:58:28Z","closed_at":"2015-09-17T22:58:28Z","merged_at":"2015-09-17T22:58:28Z","merge_commit_sha":"6b15e9900aba8e82ba1ef09fba35d074521151ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/307/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/307/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/hiera/issues/307/comments","statuses_url":"https://api.github.com/repos/puppetlabs/hiera/statuses/142ef3ff1c327e820bb0e7b7f845df993ded8619","head":{"label":"haus:maint/stable/improve_error_message","ref":"maint/stable/improve_error_message","sha":"142ef3ff1c327e820bb0e7b7f845df993ded8619","user":{"login":"haus","id":98408,"avatar_url":"https://avatars.githubusercontent.com/u/98408?v=3","gravatar_id":"","url":"https://api.github.com/users/haus","html_url":"https://github.com/haus","followers_url":"https://api.github.com/users/haus/followers","following_url":"https://api.github.com/users/haus/following{/other_user}","gists_url":"https://api.github.com/users/haus/gists{/gist_id}","starred_url":"https://api.github.com/users/haus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haus/subscriptions","organizations_url":"https://api.github.com/users/haus/orgs","repos_url":"https://api.github.com/users/haus/repos","events_url":"https://api.github.com/users/haus/events{/privacy}","received_events_url":"https://api.github.com/users/haus/received_events","type":"User","site_admin":false},"repo":{"id":4119452,"name":"hiera","full_name":"haus/hiera","owner":{"login":"haus","id":98408,"avatar_url":"https://avatars.githubusercontent.com/u/98408?v=3","gravatar_id":"","url":"https://api.github.com/users/haus","html_url":"https://github.com/haus","followers_url":"https://api.github.com/users/haus/followers","following_url":"https://api.github.com/users/haus/following{/other_user}","gists_url":"https://api.github.com/users/haus/gists{/gist_id}","starred_url":"https://api.github.com/users/haus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haus/subscriptions","organizations_url":"https://api.github.com/users/haus/orgs","repos_url":"https://api.github.com/users/haus/repos","events_url":"https://api.github.com/users/haus/events{/privacy}","received_events_url":"https://api.github.com/users/haus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haus/hiera","description":"Lightweight Pluggable Hierarchical Database","fork":true,"url":"https://api.github.com/repos/haus/hiera","forks_url":"https://api.github.com/repos/haus/hiera/forks","keys_url":"https://api.github.com/repos/haus/hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haus/hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haus/hiera/teams","hooks_url":"https://api.github.com/repos/haus/hiera/hooks","issue_events_url":"https://api.github.com/repos/haus/hiera/issues/events{/number}","events_url":"https://api.github.com/repos/haus/hiera/events","assignees_url":"https://api.github.com/repos/haus/hiera/assignees{/user}","branches_url":"https://api.github.com/repos/haus/hiera/branches{/branch}","tags_url":"https://api.github.com/repos/haus/hiera/tags","blobs_url":"https://api.github.com/repos/haus/hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haus/hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haus/hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/haus/hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haus/hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/haus/hiera/languages","stargazers_url":"https://api.github.com/repos/haus/hiera/stargazers","contributors_url":"https://api.github.com/repos/haus/hiera/contributors","subscribers_url":"https://api.github.com/repos/haus/hiera/subscribers","subscription_url":"https://api.github.com/repos/haus/hiera/subscription","commits_url":"https://api.github.com/repos/haus/hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/haus/hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/haus/hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/haus/hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/haus/hiera/contents/{+path}","compare_url":"https://api.github.com/repos/haus/hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haus/hiera/merges","archive_url":"https://api.github.com/repos/haus/hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haus/hiera/downloads","issues_url":"https://api.github.com/repos/haus/hiera/issues{/number}","pulls_url":"https://api.github.com/repos/haus/hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/haus/hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/haus/hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haus/hiera/labels{/name}","releases_url":"https://api.github.com/repos/haus/hiera/releases{/id}","created_at":"2012-04-24T00:11:09Z","updated_at":"2014-04-30T20:36:15Z","pushed_at":"2015-09-17T22:35:32Z","git_url":"git://github.com/haus/hiera.git","ssh_url":"git@github.com:haus/hiera.git","clone_url":"https://github.com/haus/hiera.git","svn_url":"https://github.com/haus/hiera","homepage":"http://projects.puppetlabs.com/projects/hiera/","size":733,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"e2f7ad8127a6ebb2168f50605a07b1f32110d350","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1845241,"name":"hiera","full_name":"puppetlabs/hiera","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/hiera","description":"Lightweight Pluggable Hierarchical Database","fork":false,"url":"https://api.github.com/repos/puppetlabs/hiera","forks_url":"https://api.github.com/repos/puppetlabs/hiera/forks","keys_url":"https://api.github.com/repos/puppetlabs/hiera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/hiera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/hiera/teams","hooks_url":"https://api.github.com/repos/puppetlabs/hiera/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/hiera/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/hiera/events","assignees_url":"https://api.github.com/repos/puppetlabs/hiera/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/hiera/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/hiera/tags","blobs_url":"https://api.github.com/repos/puppetlabs/hiera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/hiera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/hiera/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/hiera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/hiera/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/hiera/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/hiera/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/hiera/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/hiera/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/hiera/subscription","commits_url":"https://api.github.com/repos/puppetlabs/hiera/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/hiera/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/hiera/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/hiera/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/hiera/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/hiera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/hiera/merges","archive_url":"https://api.github.com/repos/puppetlabs/hiera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/hiera/downloads","issues_url":"https://api.github.com/repos/puppetlabs/hiera/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/hiera/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/hiera/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/hiera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/hiera/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/hiera/releases{/id}","created_at":"2011-06-04T00:48:22Z","updated_at":"2015-09-09T19:59:59Z","pushed_at":"2015-09-17T22:58:28Z","git_url":"git://github.com/puppetlabs/hiera.git","ssh_url":"git@github.com:puppetlabs/hiera.git","clone_url":"https://github.com/puppetlabs/hiera.git","svn_url":"https://github.com/puppetlabs/hiera","homepage":"http://projects.puppetlabs.com/projects/hiera/","size":2181,"stargazers_count":254,"watchers_count":254,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":1,"forks":167,"open_issues":1,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/307"},"html":{"href":"https://github.com/puppetlabs/hiera/pull/307"},"issue":{"href":"https://api.github.com/repos/puppetlabs/hiera/issues/307"},"comments":{"href":"https://api.github.com/repos/puppetlabs/hiera/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/hiera/statuses/142ef3ff1c327e820bb0e7b7f845df993ded8619"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}