{"action":"created","issue":{"url":"https://api.github.com/repos/amplab/tachyon/issues/1747","labels_url":"https://api.github.com/repos/amplab/tachyon/issues/1747/labels{/name}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1747/comments","events_url":"https://api.github.com/repos/amplab/tachyon/issues/1747/events","html_url":"https://github.com/amplab/tachyon/pull/1747","id":110673756,"number":1747,"title":"[TACHYON-1009] Write unit test for the tachyon.HeartbeatThread class","user":{"login":"robbenti","id":2085933,"avatar_url":"https://avatars.githubusercontent.com/u/2085933?v=3","gravatar_id":"","url":"https://api.github.com/users/robbenti","html_url":"https://github.com/robbenti","followers_url":"https://api.github.com/users/robbenti/followers","following_url":"https://api.github.com/users/robbenti/following{/other_user}","gists_url":"https://api.github.com/users/robbenti/gists{/gist_id}","starred_url":"https://api.github.com/users/robbenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbenti/subscriptions","organizations_url":"https://api.github.com/users/robbenti/orgs","repos_url":"https://api.github.com/users/robbenti/repos","events_url":"https://api.github.com/users/robbenti/events{/privacy}","received_events_url":"https://api.github.com/users/robbenti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-10-09T14:47:11Z","updated_at":"2015-10-12T14:06:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1747","html_url":"https://github.com/amplab/tachyon/pull/1747","diff_url":"https://github.com/amplab/tachyon/pull/1747.diff","patch_url":"https://github.com/amplab/tachyon/pull/1747.patch"},"body":"https://tachyon.atlassian.net/browse/TACHYON-1009\r\n\r\nHi All,\r\nThis is my proposal to test tachyon.HeartbeatThread.\r\nI've created a test class that checks the interval of every scheduled HeartbeatThread. That interval must be within a prefixed variance.\r\n\r\nFor instance, having the following time interval series (the heartbeat is 30ms):\r\n[34, 34, 34, 32, 33, 33, 34, 31, 32, 35, 32, 33, 32, 35, 34, 34, 35, 32, 34, 35, 33, 31, 35, 32, 35, 30, 34, 34, 33, 34, 35, 32, 31, 34, 34, 33, 34, 33, 35, 32, 34, 33, 32, 34, 33, 35, 32, 33, 34, 33, 32, 34, 35, 34, 32, 33, 35, 35, 33, 33]\r\nwe get a mean of 33.35 and a variance of 1.53 and that seems acceptable.\r\n\r\nPlease let me know if this test can be enough.\r\n\r\nMany thanks in advance,\r\nRoberto\r\n"},"comment":{"url":"https://api.github.com/repos/amplab/tachyon/issues/comments/147408627","html_url":"https://github.com/amplab/tachyon/pull/1747#issuecomment-147408627","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1747","id":147408627,"user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T14:06:50Z","updated_at":"2015-10-12T14:06:50Z","body":"Jenkins, test this please."}}