{"action":"closed","number":383,"pull_request":{"url":"https://api.github.com/repos/socketio/engine.io-client/pulls/383","id":32417156,"html_url":"https://github.com/socketio/engine.io-client/pull/383","diff_url":"https://github.com/socketio/engine.io-client/pull/383.diff","patch_url":"https://github.com/socketio/engine.io-client/pull/383.patch","issue_url":"https://api.github.com/repos/socketio/engine.io-client/issues/383","number":383,"state":"closed","locked":false,"title":"Enable supportsBinary when running as a node client","user":{"login":"Nibbler999","id":935710,"avatar_url":"https://avatars.githubusercontent.com/u/935710?v=3","gravatar_id":"","url":"https://api.github.com/users/Nibbler999","html_url":"https://github.com/Nibbler999","followers_url":"https://api.github.com/users/Nibbler999/followers","following_url":"https://api.github.com/users/Nibbler999/following{/other_user}","gists_url":"https://api.github.com/users/Nibbler999/gists{/gist_id}","starred_url":"https://api.github.com/users/Nibbler999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nibbler999/subscriptions","organizations_url":"https://api.github.com/users/Nibbler999/orgs","repos_url":"https://api.github.com/users/Nibbler999/repos","events_url":"https://api.github.com/users/Nibbler999/events{/privacy}","received_events_url":"https://api.github.com/users/Nibbler999/received_events","type":"User","site_admin":false},"body":"Currently engine.io-client base64 encodes binary payloads when running as a node client. This change makes it use buffers instead which improves performance.","created_at":"2015-04-01T13:11:31Z","updated_at":"2015-11-19T02:56:36Z","closed_at":"2015-11-19T02:56:36Z","merged_at":"2015-11-19T02:56:36Z","merge_commit_sha":"89d1c9b2a5723fc8105936d7ba385c6086c6e133","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/socketio/engine.io-client/pulls/383/commits","review_comments_url":"https://api.github.com/repos/socketio/engine.io-client/pulls/383/comments","review_comment_url":"https://api.github.com/repos/socketio/engine.io-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socketio/engine.io-client/issues/383/comments","statuses_url":"https://api.github.com/repos/socketio/engine.io-client/statuses/dc0482a839d079296556c1a5b53d77146ffb543a","head":{"label":"Nibbler999:binary-node-client","ref":"binary-node-client","sha":"dc0482a839d079296556c1a5b53d77146ffb543a","user":{"login":"Nibbler999","id":935710,"avatar_url":"https://avatars.githubusercontent.com/u/935710?v=3","gravatar_id":"","url":"https://api.github.com/users/Nibbler999","html_url":"https://github.com/Nibbler999","followers_url":"https://api.github.com/users/Nibbler999/followers","following_url":"https://api.github.com/users/Nibbler999/following{/other_user}","gists_url":"https://api.github.com/users/Nibbler999/gists{/gist_id}","starred_url":"https://api.github.com/users/Nibbler999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nibbler999/subscriptions","organizations_url":"https://api.github.com/users/Nibbler999/orgs","repos_url":"https://api.github.com/users/Nibbler999/repos","events_url":"https://api.github.com/users/Nibbler999/events{/privacy}","received_events_url":"https://api.github.com/users/Nibbler999/received_events","type":"User","site_admin":false},"repo":{"id":33209809,"name":"engine.io-client","full_name":"Nibbler999/engine.io-client","owner":{"login":"Nibbler999","id":935710,"avatar_url":"https://avatars.githubusercontent.com/u/935710?v=3","gravatar_id":"","url":"https://api.github.com/users/Nibbler999","html_url":"https://github.com/Nibbler999","followers_url":"https://api.github.com/users/Nibbler999/followers","following_url":"https://api.github.com/users/Nibbler999/following{/other_user}","gists_url":"https://api.github.com/users/Nibbler999/gists{/gist_id}","starred_url":"https://api.github.com/users/Nibbler999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nibbler999/subscriptions","organizations_url":"https://api.github.com/users/Nibbler999/orgs","repos_url":"https://api.github.com/users/Nibbler999/repos","events_url":"https://api.github.com/users/Nibbler999/events{/privacy}","received_events_url":"https://api.github.com/users/Nibbler999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nibbler999/engine.io-client","description":"","fork":true,"url":"https://api.github.com/repos/Nibbler999/engine.io-client","forks_url":"https://api.github.com/repos/Nibbler999/engine.io-client/forks","keys_url":"https://api.github.com/repos/Nibbler999/engine.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nibbler999/engine.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nibbler999/engine.io-client/teams","hooks_url":"https://api.github.com/repos/Nibbler999/engine.io-client/hooks","issue_events_url":"https://api.github.com/repos/Nibbler999/engine.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/Nibbler999/engine.io-client/events","assignees_url":"https://api.github.com/repos/Nibbler999/engine.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/Nibbler999/engine.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/Nibbler999/engine.io-client/tags","blobs_url":"https://api.github.com/repos/Nibbler999/engine.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nibbler999/engine.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nibbler999/engine.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nibbler999/engine.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nibbler999/engine.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Nibbler999/engine.io-client/languages","stargazers_url":"https://api.github.com/repos/Nibbler999/engine.io-client/stargazers","contributors_url":"https://api.github.com/repos/Nibbler999/engine.io-client/contributors","subscribers_url":"https://api.github.com/repos/Nibbler999/engine.io-client/subscribers","subscription_url":"https://api.github.com/repos/Nibbler999/engine.io-client/subscription","commits_url":"https://api.github.com/repos/Nibbler999/engine.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nibbler999/engine.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nibbler999/engine.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nibbler999/engine.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nibbler999/engine.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/Nibbler999/engine.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nibbler999/engine.io-client/merges","archive_url":"https://api.github.com/repos/Nibbler999/engine.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nibbler999/engine.io-client/downloads","issues_url":"https://api.github.com/repos/Nibbler999/engine.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/Nibbler999/engine.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Nibbler999/engine.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Nibbler999/engine.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nibbler999/engine.io-client/labels{/name}","releases_url":"https://api.github.com/repos/Nibbler999/engine.io-client/releases{/id}","created_at":"2015-03-31T21:03:44Z","updated_at":"2015-03-31T21:03:44Z","pushed_at":"2015-05-30T22:48:44Z","git_url":"git://github.com/Nibbler999/engine.io-client.git","ssh_url":"git@github.com:Nibbler999/engine.io-client.git","clone_url":"https://github.com/Nibbler999/engine.io-client.git","svn_url":"https://github.com/Nibbler999/engine.io-client","homepage":"http://socket.io","size":1347,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"socketio:master","ref":"master","sha":"e5908fce1e868f9be45740a09c788152fbdf3268","user":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"repo":{"id":2804440,"name":"engine.io-client","full_name":"socketio/engine.io-client","owner":{"login":"socketio","id":10566080,"avatar_url":"https://avatars.githubusercontent.com/u/10566080?v=3","gravatar_id":"","url":"https://api.github.com/users/socketio","html_url":"https://github.com/socketio","followers_url":"https://api.github.com/users/socketio/followers","following_url":"https://api.github.com/users/socketio/following{/other_user}","gists_url":"https://api.github.com/users/socketio/gists{/gist_id}","starred_url":"https://api.github.com/users/socketio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socketio/subscriptions","organizations_url":"https://api.github.com/users/socketio/orgs","repos_url":"https://api.github.com/users/socketio/repos","events_url":"https://api.github.com/users/socketio/events{/privacy}","received_events_url":"https://api.github.com/users/socketio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socketio/engine.io-client","description":"","fork":false,"url":"https://api.github.com/repos/socketio/engine.io-client","forks_url":"https://api.github.com/repos/socketio/engine.io-client/forks","keys_url":"https://api.github.com/repos/socketio/engine.io-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socketio/engine.io-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socketio/engine.io-client/teams","hooks_url":"https://api.github.com/repos/socketio/engine.io-client/hooks","issue_events_url":"https://api.github.com/repos/socketio/engine.io-client/issues/events{/number}","events_url":"https://api.github.com/repos/socketio/engine.io-client/events","assignees_url":"https://api.github.com/repos/socketio/engine.io-client/assignees{/user}","branches_url":"https://api.github.com/repos/socketio/engine.io-client/branches{/branch}","tags_url":"https://api.github.com/repos/socketio/engine.io-client/tags","blobs_url":"https://api.github.com/repos/socketio/engine.io-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socketio/engine.io-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socketio/engine.io-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/socketio/engine.io-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socketio/engine.io-client/statuses/{sha}","languages_url":"https://api.github.com/repos/socketio/engine.io-client/languages","stargazers_url":"https://api.github.com/repos/socketio/engine.io-client/stargazers","contributors_url":"https://api.github.com/repos/socketio/engine.io-client/contributors","subscribers_url":"https://api.github.com/repos/socketio/engine.io-client/subscribers","subscription_url":"https://api.github.com/repos/socketio/engine.io-client/subscription","commits_url":"https://api.github.com/repos/socketio/engine.io-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/socketio/engine.io-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/socketio/engine.io-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/socketio/engine.io-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/socketio/engine.io-client/contents/{+path}","compare_url":"https://api.github.com/repos/socketio/engine.io-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socketio/engine.io-client/merges","archive_url":"https://api.github.com/repos/socketio/engine.io-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socketio/engine.io-client/downloads","issues_url":"https://api.github.com/repos/socketio/engine.io-client/issues{/number}","pulls_url":"https://api.github.com/repos/socketio/engine.io-client/pulls{/number}","milestones_url":"https://api.github.com/repos/socketio/engine.io-client/milestones{/number}","notifications_url":"https://api.github.com/repos/socketio/engine.io-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socketio/engine.io-client/labels{/name}","releases_url":"https://api.github.com/repos/socketio/engine.io-client/releases{/id}","created_at":"2011-11-18T18:04:11Z","updated_at":"2015-11-18T20:44:00Z","pushed_at":"2015-11-19T02:56:36Z","git_url":"git://github.com/socketio/engine.io-client.git","ssh_url":"git@github.com:socketio/engine.io-client.git","clone_url":"https://github.com/socketio/engine.io-client.git","svn_url":"https://github.com/socketio/engine.io-client","homepage":"http://socket.io","size":1730,"stargazers_count":365,"watchers_count":365,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":27,"forks":182,"open_issues":27,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socketio/engine.io-client/pulls/383"},"html":{"href":"https://github.com/socketio/engine.io-client/pull/383"},"issue":{"href":"https://api.github.com/repos/socketio/engine.io-client/issues/383"},"comments":{"href":"https://api.github.com/repos/socketio/engine.io-client/issues/383/comments"},"review_comments":{"href":"https://api.github.com/repos/socketio/engine.io-client/pulls/383/comments"},"review_comment":{"href":"https://api.github.com/repos/socketio/engine.io-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socketio/engine.io-client/pulls/383/commits"},"statuses":{"href":"https://api.github.com/repos/socketio/engine.io-client/statuses/dc0482a839d079296556c1a5b53d77146ffb543a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rauchg","id":13041,"avatar_url":"https://avatars.githubusercontent.com/u/13041?v=3","gravatar_id":"","url":"https://api.github.com/users/rauchg","html_url":"https://github.com/rauchg","followers_url":"https://api.github.com/users/rauchg/followers","following_url":"https://api.github.com/users/rauchg/following{/other_user}","gists_url":"https://api.github.com/users/rauchg/gists{/gist_id}","starred_url":"https://api.github.com/users/rauchg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauchg/subscriptions","organizations_url":"https://api.github.com/users/rauchg/orgs","repos_url":"https://api.github.com/users/rauchg/repos","events_url":"https://api.github.com/users/rauchg/events{/privacy}","received_events_url":"https://api.github.com/users/rauchg/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}