{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/24409194","id":24409194,"diff_hunk":"@@ -37,7 +38,7 @@\n     long iteration = 0;\n \n     public AbstractWorkerTask() {\n-        this.selector = createOperationSelector();\n+        this.selector = createOperationSelectorBuilder().build();","path":"stabilizer/src/main/java/com/hazelcast/stabilizer/worker/tasks/AbstractWorkerTask.java","position":24,"original_position":24,"commit_id":"5a8a0970843f933def2ecdcc37df45c515cae712","original_commit_id":"5a8a0970843f933def2ecdcc37df45c515cae712","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"I don't think this belongs in the abstract worker. I want to prevent adding too much framework and certainly want to prevent forcing a user to implement methods if he doesn't care about them.\r\n\r\nAfaik the OperationSelector can also be initialized when the worker is created in the concrete subclass\r\n\r\n```\r\nclass FooWorker extends AbstractWorker{\r\n     OperationSelector<FoOOPeration> selector = selectorBuilder.newInstance();\r\n     ....\r\n}\r\n```","created_at":"2015-02-10T12:48:08Z","updated_at":"2015-02-10T12:48:08Z","html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497#discussion_r24409194","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/24409194"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497#discussion_r24409194"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497","id":28923478,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497","diff_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497.diff","patch_url":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/497","number":497,"state":"open","locked":false,"title":"Improved OperationSelector performance","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"Improved `OperationSelector` performance by creating an `OperationSelectorBuilder` which constructs a thread-safe `OperationSelector` instance with immutable data structures.\r\n\r\nTo prevent contention on the `Random` instance a new instance is created for each `Worker` in all tests which use `OperationSelector`.\r\n\r\nShould fix #485.","created_at":"2015-02-09T14:19:53Z","updated_at":"2015-02-10T12:48:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdc5c39ed0018062bce9770ef37e5c2e262f5ceb","assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/milestones/4","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/milestones/4/labels","id":774943,"number":4,"title":"0.4","description":"","creator":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":129,"state":"open","created_at":"2014-09-02T08:12:11Z","updated_at":"2015-02-10T11:24:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/497/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/5a8a0970843f933def2ecdcc37df45c515cae712","head":{"label":"Donnerbart:improveOperationSelectorPerformance","ref":"improveOperationSelectorPerformance","sha":"5a8a0970843f933def2ecdcc37df45c515cae712","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":26756293,"name":"hazelcast-stabilizer","full_name":"Donnerbart/hazelcast-stabilizer","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast-stabilizer/releases{/id}","created_at":"2014-11-17T12:48:31Z","updated_at":"2015-02-10T11:25:20Z","pushed_at":"2015-02-10T11:25:20Z","git_url":"git://github.com/Donnerbart/hazelcast-stabilizer.git","ssh_url":"git@github.com:Donnerbart/hazelcast-stabilizer.git","clone_url":"https://github.com/Donnerbart/hazelcast-stabilizer.git","svn_url":"https://github.com/Donnerbart/hazelcast-stabilizer","homepage":null,"size":8031,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"9978aa4dd0b5472f77876db9eee311f69cf29401","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":11445479,"name":"hazelcast-stabilizer","full_name":"hazelcast/hazelcast-stabilizer","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast-stabilizer","description":"A tool for stress testing Hazelcast","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer","forks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/releases{/id}","created_at":"2013-07-16T09:18:54Z","updated_at":"2015-02-10T11:24:32Z","pushed_at":"2015-02-10T11:24:31Z","git_url":"git://github.com/hazelcast/hazelcast-stabilizer.git","ssh_url":"git@github.com:hazelcast/hazelcast-stabilizer.git","clone_url":"https://github.com/hazelcast/hazelcast-stabilizer.git","svn_url":"https://github.com/hazelcast/hazelcast-stabilizer","homepage":null,"size":12619,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":104,"forks":12,"open_issues":104,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497"},"html":{"href":"https://github.com/hazelcast/hazelcast-stabilizer/pull/497"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/497"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast-stabilizer/statuses/5a8a0970843f933def2ecdcc37df45c515cae712"}}}}