{"action":"created","issue":{"url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/43","labels_url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/43/comments","events_url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/43/events","html_url":"https://github.com/nickdesaulniers/node-nanomsg/pull/43","id":58075927,"number":43,"title":"Retrieve symbols on module load with nn_symbol","user":{"login":"comick","id":915939,"avatar_url":"https://avatars.githubusercontent.com/u/915939?v=3","gravatar_id":"","url":"https://api.github.com/users/comick","html_url":"https://github.com/comick","followers_url":"https://api.github.com/users/comick/followers","following_url":"https://api.github.com/users/comick/following{/other_user}","gists_url":"https://api.github.com/users/comick/gists{/gist_id}","starred_url":"https://api.github.com/users/comick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comick/subscriptions","organizations_url":"https://api.github.com/users/comick/orgs","repos_url":"https://api.github.com/users/comick/repos","events_url":"https://api.github.com/users/comick/events{/privacy}","received_events_url":"https://api.github.com/users/comick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-18T14:42:11Z","updated_at":"2015-02-18T21:09:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/pulls/43","html_url":"https://github.com/nickdesaulniers/node-nanomsg/pull/43","diff_url":"https://github.com/nickdesaulniers/node-nanomsg/pull/43.diff","patch_url":"https://github.com/nickdesaulniers/node-nanomsg/pull/43.patch"},"body":"See http://nanomsg.org/development-bindings.html, this is the reccomanded way to retrieve symbols.\r\n\r\nNot sure about:\r\nEXPORT_CONSTANT(exports, EISCONN); // not in symbol.c, but is in nn.h\r\n// Polling - these aren't in symbol.c but they are in nn.h\r\nEXPORT_CONSTANT(exports, NN_POLLIN);\r\nEXPORT_CONSTANT(exports, NN_POLLOUT);\r\n\r\nwhy they were defined as symbol in node module?\r\nThey are not returned by nn_symbol and it seems they are not needed at all.\r\nAll tests pass."},"comment":{"url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/comments/74948358","html_url":"https://github.com/nickdesaulniers/node-nanomsg/pull/43#issuecomment-74948358","issue_url":"https://api.github.com/repos/nickdesaulniers/node-nanomsg/issues/43","id":74948358,"user":{"login":"nickdesaulniers","id":1823839,"avatar_url":"https://avatars.githubusercontent.com/u/1823839?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdesaulniers","html_url":"https://github.com/nickdesaulniers","followers_url":"https://api.github.com/users/nickdesaulniers/followers","following_url":"https://api.github.com/users/nickdesaulniers/following{/other_user}","gists_url":"https://api.github.com/users/nickdesaulniers/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdesaulniers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdesaulniers/subscriptions","organizations_url":"https://api.github.com/users/nickdesaulniers/orgs","repos_url":"https://api.github.com/users/nickdesaulniers/repos","events_url":"https://api.github.com/users/nickdesaulniers/events{/privacy}","received_events_url":"https://api.github.com/users/nickdesaulniers/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T21:09:32Z","updated_at":"2015-02-18T21:09:32Z","body":"Looks good, thanks Michele.  Make sure you comment in the issue when you fix up code review nits; otherwise the maintainer doesn't get an email that the fixes were made. (or the maintainers GH settings are messed up)"}}