{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/3078","labels_url":"https://api.github.com/repos/openshift/origin/issues/3078/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3078/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/3078/events","html_url":"https://github.com/openshift/origin/pull/3078","id":87118579,"number":3078,"title":"Added stop channel to watched pods to prevent thread leak","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-10T21:48:52Z","updated_at":"2015-06-11T14:50:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3078","html_url":"https://github.com/openshift/origin/pull/3078","diff_url":"https://github.com/openshift/origin/pull/3078.diff","patch_url":"https://github.com/openshift/origin/pull/3078.patch"},"body":"Resolves #2869.\r\n\r\n@ironcladlou @abhgupta \r\n\r\nEdit:   Fixed the thread leak by returning a stop channel created at the same time/place where the reflector is created and started.  The caller of the watch is responsible for a deferred close on the channel.\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/111160408","html_url":"https://github.com/openshift/origin/pull/3078#issuecomment-111160408","issue_url":"https://api.github.com/repos/openshift/origin/issues/3078","id":111160408,"user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T14:50:43Z","updated_at":"2015-06-11T14:50:43Z","body":"@smarterclayton the change you wanted is implemented.  It is effectively the same as it was before.\r\n\r\nWhat would a \"global stopper\" look like?  The chan can't be reused because it's closed.  A global factory to create channels that keep an internal reference with TTL to close channels would work as well with the original implementation as it would with this one."}}