{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5806","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5806/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5806/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5806/events","html_url":"https://github.com/ManageIQ/manageiq/pull/5806","id":121762204,"number":5806,"title":"Container Topology - remove hardcoded image paths from JS","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/28","html_url":"https://github.com/ManageIQ/manageiq/milestones/Sprint%2034%20Ending%20Jan%204,%202016","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/28/labels","id":1450173,"number":28,"title":"Sprint 34 Ending Jan 4, 2016","description":"","creator":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":151,"state":"open","created_at":"2015-12-08T15:56:35Z","updated_at":"2015-12-18T23:20:19Z","due_on":"2016-01-04T05:00:00Z","closed_at":null},"comments":6,"created_at":"2015-12-11T18:09:58Z","updated_at":"2015-12-20T14:56:32Z","closed_at":"2015-12-18T15:48:00Z","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5806","html_url":"https://github.com/ManageIQ/manageiq/pull/5806","diff_url":"https://github.com/ManageIQ/manageiq/pull/5806.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5806.patch"},"body":"The icons for topology graph items would get generated in JS,\r\nthat will break with @skateman's asset pipeline changes\r\n    \r\nThis moves the image path logic to ContainerTopologyService, which can use the image_path helper\r\n    \r\n(note that as of now, the URL generated is exactly the same)\r\n\r\n(If you're reviewing, go commit by commit, because the last one changes all whitespace in there.)\r\n\r\nRelated PRs: https://github.com/ManageIQ/manageiq/pull/5709, https://github.com/ManageIQ/manageiq-appliance/pull/47\r\n(but not depending on either)"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/166125471","html_url":"https://github.com/ManageIQ/manageiq/pull/5806#issuecomment-166125471","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5806","id":166125471,"user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"created_at":"2015-12-20T14:56:32Z","updated_at":"2015-12-20T14:56:32Z","body":"@himdel : can we, please, formalize the style requirements for the javascripts and include that in our guidelines?\r\n\r\nCan we have something like `cindent` run for the javascripts in our PR automatically?\r\n\r\nThx!"}}