{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/1091","labels_url":"https://api.github.com/repos/openshift/origin/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1091/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/1091/events","html_url":"https://github.com/openshift/origin/pull/1091","id":58403753,"number":1091,"title":"Add controller retry support scaffolding","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-02-20T20:07:50Z","updated_at":"2015-02-26T16:09:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1091","html_url":"https://github.com/openshift/origin/pull/1091","diff_url":"https://github.com/openshift/origin/pull/1091.diff","patch_url":"https://github.com/openshift/origin/pull/1091.patch"},"body":"Introduce a reusable controller package which facilitates safe retries\r\nfor controllers which make use of cache.FIFO.\r\n\r\nPort the DeploymentConfigController to use the new support as a reference\r\nimplementation of the pattern."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/76205840","html_url":"https://github.com/openshift/origin/pull/1091#issuecomment-76205840","issue_url":"https://api.github.com/repos/openshift/origin/issues/1091","id":76205840,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2015-02-26T16:09:43Z","updated_at":"2015-02-26T16:09:43Z","body":"I'm about to take off - that was my last substantive issue (no one outside of controller and its tests should know about the errors, and caking util.HandleError before you eat one).\r\n\r\n\r\n> On Feb 26, 2015, at 7:39 AM, Dan Mace <notifications@github.com> wrote:\r\n> \r\n> @smarterclayton @bparees\r\n> The latest revision moves DeploymentConfigController/Factory into its own package. DeploymentConfigController has a private fatal error type which the factory recognizes to drive retries in a simple manner.\r\n> \r\n> Still haven't touched tests yet. When the structure of this one controller looks good to all, I'll fix the tests, get this PR merged, and then start porting all the other deploy controllers in followup PRs.\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> \r\n"}}