{"push_id":915539034,"size":20,"distinct_size":0,"ref":"refs/heads/coverity_scan","head":"ac79517efec69eb64d8470987ecf81c253ae1b93","before":"f2ca48a6f79f41b9d1e29016e2cd6b9c5df39089","commits":[{"sha":"e91ef973e98e8b2bb1f60f057a87d20994aac2a0","author":{"email":"4a2b94f8a97ab5760cddd2707413b9edfddcae58@dxzone.com.ar","name":"dequis"},"message":"fb_mqtt_write: fix unreachable input_add (priv->wev was always 0)\n\nThis was the only line that assigned anything to priv->wev, and it was\nbehind an (incorrect) condition that checked if it's nonzero.\n\nThat would have replaced priv->wev if the condition was ever true, but\nsince it wasn't, the only result is potentially delayed writes\n(for example, filling the write buffer and only writing the rest a\nminute later when pinging the server)\n\nThe new condition also checks the return value of fb_mqtt_cb_write(),\nwhich is true if it should continue writing, or false otherwise.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/e91ef973e98e8b2bb1f60f057a87d20994aac2a0"},{"sha":"72d107e543aeb8766140f258f48bda8bca88343d","author":{"email":"4a2b94f8a97ab5760cddd2707413b9edfddcae58@dxzone.com.ar","name":"dequis"},"message":"mqtt: fix segfaults after disconnecting on write\n\nAny call to fb_mqtt_write() can result in an error writing to the\nsocket, which means fb_mqtt_close() can be called and the mqtt object is\ninvalidated.\n\nTrying to write priv->tev = 0 at that point is a small invalid write,\nbut not enough to make it crash. The real problem is fb_mqtt_timeout(),\nwhich adds a 90 second delay after which it *does* crash, often when a\ndifferent account already finished logging.\n\nThe fix here takes advantage of the cleanup done by fb_mqtt_close() - by\nadding the timeout before that call, it will find a nonzero priv->tev\nand remove it.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/72d107e543aeb8766140f258f48bda8bca88343d"},{"sha":"cfb85ddbd5d20e5e193e29e1a247ac447a6cd422","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"travis: handle packaging for OBS","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/cfb85ddbd5d20e5e193e29e1a247ac447a6cd422"},{"sha":"687db5d141b1730899a3dd48e84f45c64a6f38af","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"travis: use bitlbee master instead of develop","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/687db5d141b1730899a3dd48e84f45c64a6f38af"},{"sha":"7cff245b84d410af087418b9eaf36803eaf29068","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"travis: use dynamic Ubuntu version","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/7cff245b84d410af087418b9eaf36803eaf29068"},{"sha":"b9f3d252fc662e3ff3a216f1ea42e0d85cd34d69","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"travis: refactored for better readability and handling\n\nChanges made:\n  - Build and install bitlbee from /tmp\n  - Disabled the building of the bitlbee documentation\n  - Moved all build commands to travis.yml (more informative)\n  - Moved all Travis related scripts to a hidden directory\n  - Moved the bitlbee build commands to a script\n  - Only deploy the master branch (excluding pull requests)\n  - Removed redundant parameters from the bitlbee configure command","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/b9f3d252fc662e3ff3a216f1ea42e0d85cd34d69"},{"sha":"2018aa1a288d5204d5d066bff672df8cb46065b9","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-util: use the GConverter interface instead of zlib","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/2018aa1a288d5204d5d066bff672df8cb46065b9"},{"sha":"1c47c7ab4d0b74f67dc11558360d24c746d63186","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"Fixed grammar errors in the GTK-Doc","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/1c47c7ab4d0b74f67dc11558360d24c746d63186"},{"sha":"6056cc2235b2e9515008da5a07b5617228006365","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-util: refactored naming and GTK-Doc","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/6056cc2235b2e9515008da5a07b5617228006365"},{"sha":"0121bae03b6d545ff799f4b02c9b05becac1b78b","author":{"email":"4a2b94f8a97ab5760cddd2707413b9edfddcae58@dxzone.com.ar","name":"dequis"},"message":"facebook-json: Ensure data is null terminated for json-glib < 1.0.2\n\nOlder json-glib versions had a bug[1] in which the length parameter was\nignored and this error happened if the input was not null-terminated:\n\n    JSON data must be UTF-8 encoded\n\nSince these versions are expected to still be around in some distros,\nthis commit makes a copy with g_strndup() to ensure that it's always\nnull terminated.\n\nThanks to advcomp2019 for reporting this bug and finding a test case\nwhere this issue is reproducible every time (receiving events of people\njoining or leaving in a groupchat)\n\n[1]: https://bugzilla.gnome.org/show_bug.cgi?id=727755","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/0121bae03b6d545ff799f4b02c9b05becac1b78b"},{"sha":"72e2a0eb4cf6a3bfd6464ebf2d03cc83647568bd","author":{"email":"4a2b94f8a97ab5760cddd2707413b9edfddcae58@dxzone.com.ar","name":"dequis"},"message":"facebook-json:`Special-case \"$\" to return root for json-glib < 0.99.2\n\nOlder glib versions didn't consider \"$\" to be a valid expression, and\nthrew this error:\n\n    Root node followed by invalid character '\n\n(That's supposed to be '%c' with a \\0)\n\nSince this is possibly the simplest expression to parse, a g_strcmp0()\ncan do the job.\n\nThanks to advcomp2019 for reporting this bug and finding a test case\nwhere this issue is reproducible every time (receiving events of people\njoining or leaving in a groupchat)\n\nAlso thanks to EionRobb who realized what the bug was three hours ago\n(and I didn't listen because I thought the previous bug was the same)","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/72e2a0eb4cf6a3bfd6464ebf2d03cc83647568bd"},{"sha":"00c0ae832b2f04969d205b951ae37b9bc884b84f","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-api: fixed non-friend contacts showing as buddies","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/00c0ae832b2f04969d205b951ae37b9bc884b84f"},{"sha":"28ec26e7ca9b1909c65939cea7f55fc72c55ed9c","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-json: fixed a size overflow with string duplication\n\nUnlike json_parser_load_from_data(), g_strndup() will not handle signed\nsizes that are negative. This causes the size to overflow to a really\nlarge value, and in turn lead to a segmentation fault.\n\nThe solution is simple: calculate the size of the data when the given\nsize is negative.\n\nThis bug was introduced by 0121bae.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/28ec26e7ca9b1909c65939cea7f55fc72c55ed9c"},{"sha":"ac00b3373f1e0a5ac4214322c49db89049022f5e","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-api: fixed faulty conditional with friend checking\n\nThis regression was introduced by 00c0ae8.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/ac00b3373f1e0a5ac4214322c49db89049022f5e"},{"sha":"4992f5216ec53b65e5773c8d98525c2421fc8cba","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook-util: document the FbDebugLevel enum","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/4992f5216ec53b65e5773c8d98525c2421fc8cba"},{"sha":"04cc3a0717da21a98eda3e33b3ae704e2ec9a698","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"Dropped required GLib version to 2.28.0\n\nThis is namely for the RedHat guys maintaining RHEL 6.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/04cc3a0717da21a98eda3e33b3ae704e2ec9a698"},{"sha":"3e09957c7523c9880aa810c8921bd2ed103f0858","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"README: removed misleading line","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/3e09957c7523c9880aa810c8921bd2ed103f0858"},{"sha":"d23df657328e4f565dfba973885be7c5d2b35eae","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"Coding style consistencies","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/d23df657328e4f565dfba973885be7c5d2b35eae"},{"sha":"c2a7c914d3d218124cb3cfd7ca422d2d7c37fa67","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"facebook: fixed broken contact counting with non-friends\n\nWhen fetching more than 500 contacts, multiple requests must be made in\norder avoid request limits. When friends are retrieved and processed,\nthe plugin must keep a count of the processed contacts to know whether\nor not it needs to retrieve more contacts.\n\nCurrently, this counter assumes every contact is a friend, which is not\nalways the case. This counter needs to advance even when a contact is\nnot a friend.\n\nThis fixes the incomplete fetching of the buddy list when a user has\nover 500 friends.\n\nThis is a regression introduced by 00c0ae8.","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/c2a7c914d3d218124cb3cfd7ca422d2d7c37fa67"},{"sha":"ac79517efec69eb64d8470987ecf81c253ae1b93","author":{"email":"c93b3069f495d0902eefae231005517ec5504a6d@gmail.com","name":"jgeboski"},"message":"Trivial GTK-Doc fixes","distinct":false,"url":"https://api.github.com/repos/jgeboski/bitlbee-facebook/commits/ac79517efec69eb64d8470987ecf81c253ae1b93"}]}