{"action":"created","comment":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/comments/34073430","id":34073430,"diff_hunk":"@@ -87,6 +93,14 @@ describe('Chartbeat', function() {\n     it('should load', function(done) {\n       analytics.load(chartbeat, done);\n     });\n+\n+    it('should load video lib when selected', function() {","path":"test/index.test.js","position":38,"original_position":38,"commit_id":"7ac2aef8001db82d58941f191ef58095575c7871","original_commit_id":"7ac2aef8001db82d58941f191ef58095575c7871","user":{"login":"ndhoule","id":1863990,"avatar_url":"https://avatars.githubusercontent.com/u/1863990?v=3","gravatar_id":"","url":"https://api.github.com/users/ndhoule","html_url":"https://github.com/ndhoule","followers_url":"https://api.github.com/users/ndhoule/followers","following_url":"https://api.github.com/users/ndhoule/following{/other_user}","gists_url":"https://api.github.com/users/ndhoule/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhoule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhoule/subscriptions","organizations_url":"https://api.github.com/users/ndhoule/orgs","repos_url":"https://api.github.com/users/ndhoule/repos","events_url":"https://api.github.com/users/ndhoule/events{/privacy}","received_events_url":"https://api.github.com/users/ndhoule/received_events","type":"User","site_admin":false},"body":"can you test the other case, where we load `chartbeat.js`?","created_at":"2015-07-07T18:29:44Z","updated_at":"2015-07-07T18:29:44Z","html_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1#discussion_r34073430","pull_request_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/comments/34073430"},"html":{"href":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1#discussion_r34073430"},"pull_request":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1","id":39033031,"html_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1","diff_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1.diff","patch_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1.patch","issue_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/1","number":1,"state":"open","locked":false,"title":"add optional support for loading video library","user":{"login":"sperand-io","id":3130232,"avatar_url":"https://avatars.githubusercontent.com/u/3130232?v=3","gravatar_id":"","url":"https://api.github.com/users/sperand-io","html_url":"https://github.com/sperand-io","followers_url":"https://api.github.com/users/sperand-io/followers","following_url":"https://api.github.com/users/sperand-io/following{/other_user}","gists_url":"https://api.github.com/users/sperand-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sperand-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sperand-io/subscriptions","organizations_url":"https://api.github.com/users/sperand-io/orgs","repos_url":"https://api.github.com/users/sperand-io/repos","events_url":"https://api.github.com/users/sperand-io/events{/privacy}","received_events_url":"https://api.github.com/users/sperand-io/received_events","type":"User","site_admin":false},"body":"Chartbeat has a video library that offers a superset of functionality from their regular snippet — it can automatically listen for events from `<video>` players, etc. This adds support for that, allowing the user to opt-in to using the bigger video script should they choose.\r\n\r\nhttp://support.chartbeat.com/docs/video.html#html5\r\n\r\n**corresponding integration metadata update already done**\r\n\r\n@ndhoule ","created_at":"2015-07-01T22:46:55Z","updated_at":"2015-07-07T18:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"694e7219d47b0e095acff1c3f4fc003fda1822f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1/commits","review_comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1/comments","review_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/1/comments","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/statuses/7ac2aef8001db82d58941f191ef58095575c7871","head":{"label":"segment-integrations:add/video","ref":"add/video","sha":"7ac2aef8001db82d58941f191ef58095575c7871","user":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":37163123,"name":"analytics.js-integration-chartbeat","full_name":"segment-integrations/analytics.js-integration-chartbeat","owner":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat","description":"The Chartbeat analytics.js integration.","fork":false,"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat","forks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/forks","keys_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/teams","hooks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/hooks","issue_events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/events{/number}","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/events","assignees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/assignees{/user}","branches_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/branches{/branch}","tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/tags","blobs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/languages","stargazers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/stargazers","contributors_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/contributors","subscribers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/subscribers","subscription_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/subscription","commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/contents/{+path}","compare_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/merges","archive_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/downloads","issues_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues{/number}","pulls_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/labels{/name}","releases_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/releases{/id}","created_at":"2015-06-09T22:58:46Z","updated_at":"2015-06-09T22:58:47Z","pushed_at":"2015-07-01T22:46:55Z","git_url":"git://github.com/segment-integrations/analytics.js-integration-chartbeat.git","ssh_url":"git@github.com:segment-integrations/analytics.js-integration-chartbeat.git","clone_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat.git","svn_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat","homepage":"https://segment.com/docs/integrations/chartbeat/","size":172,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"segment-integrations:master","ref":"master","sha":"dac454bbf8b81e49c8ab8878a18d9f3a49f7a1e3","user":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"repo":{"id":37163123,"name":"analytics.js-integration-chartbeat","full_name":"segment-integrations/analytics.js-integration-chartbeat","owner":{"login":"segment-integrations","id":11207740,"avatar_url":"https://avatars.githubusercontent.com/u/11207740?v=3","gravatar_id":"","url":"https://api.github.com/users/segment-integrations","html_url":"https://github.com/segment-integrations","followers_url":"https://api.github.com/users/segment-integrations/followers","following_url":"https://api.github.com/users/segment-integrations/following{/other_user}","gists_url":"https://api.github.com/users/segment-integrations/gists{/gist_id}","starred_url":"https://api.github.com/users/segment-integrations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/segment-integrations/subscriptions","organizations_url":"https://api.github.com/users/segment-integrations/orgs","repos_url":"https://api.github.com/users/segment-integrations/repos","events_url":"https://api.github.com/users/segment-integrations/events{/privacy}","received_events_url":"https://api.github.com/users/segment-integrations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat","description":"The Chartbeat analytics.js integration.","fork":false,"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat","forks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/forks","keys_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/teams","hooks_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/hooks","issue_events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/events{/number}","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/events","assignees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/assignees{/user}","branches_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/branches{/branch}","tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/tags","blobs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/languages","stargazers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/stargazers","contributors_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/contributors","subscribers_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/subscribers","subscription_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/subscription","commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/contents/{+path}","compare_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/merges","archive_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/downloads","issues_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues{/number}","pulls_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/labels{/name}","releases_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/releases{/id}","created_at":"2015-06-09T22:58:46Z","updated_at":"2015-06-09T22:58:47Z","pushed_at":"2015-07-01T22:46:55Z","git_url":"git://github.com/segment-integrations/analytics.js-integration-chartbeat.git","ssh_url":"git@github.com:segment-integrations/analytics.js-integration-chartbeat.git","clone_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat.git","svn_url":"https://github.com/segment-integrations/analytics.js-integration-chartbeat","homepage":"https://segment.com/docs/integrations/chartbeat/","size":172,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1"},"html":{"href":"https://github.com/segment-integrations/analytics.js-integration-chartbeat/pull/1"},"issue":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/1"},"comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/segment-integrations/analytics.js-integration-chartbeat/statuses/7ac2aef8001db82d58941f191ef58095575c7871"}}}}