{"action":"created","issue":{"url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/34","labels_url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/34/comments","events_url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/34/events","html_url":"https://github.com/alexgorbatchev/node-crc/pull/34","id":72407081,"number":34,"title":"Added crc16_xmodem bitwise calculation","user":{"login":"albertjleo","id":5587398,"avatar_url":"https://avatars.githubusercontent.com/u/5587398?v=3","gravatar_id":"","url":"https://api.github.com/users/albertjleo","html_url":"https://github.com/albertjleo","followers_url":"https://api.github.com/users/albertjleo/followers","following_url":"https://api.github.com/users/albertjleo/following{/other_user}","gists_url":"https://api.github.com/users/albertjleo/gists{/gist_id}","starred_url":"https://api.github.com/users/albertjleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertjleo/subscriptions","organizations_url":"https://api.github.com/users/albertjleo/orgs","repos_url":"https://api.github.com/users/albertjleo/repos","events_url":"https://api.github.com/users/albertjleo/events{/privacy}","received_events_url":"https://api.github.com/users/albertjleo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-01T11:01:15Z","updated_at":"2015-05-01T15:26:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexgorbatchev/node-crc/pulls/34","html_url":"https://github.com/alexgorbatchev/node-crc/pull/34","diff_url":"https://github.com/alexgorbatchev/node-crc/pull/34.diff","patch_url":"https://github.com/alexgorbatchev/node-crc/pull/34.patch"},"body":"Hi Alex,\r\n\r\nI came across your useful library, but I needed the xmodem implementation which was missing, although it was present in the pycrc library. \r\n\r\nTherefore I have added crc16_xmodem bitwise implementation, since I am not familiar with python or the pycrc lib, I wasn't quite sure how to generate the optimised table implementation.\r\n\r\nIt would be great if this could be merged, since we use both ccitt and xmodem.\r\n\r\nProposed Mods:\r\nIt would also be good to add the ability to pass along with the buffer the startIndex and endIndex to use rather than assume the entire buffer needs to be used when computing the CRC.\r\n\r\nAlso it would be good to have a Factory that can provide the ability to choose from the different models, this might already be present in the existing code, in which case could you please explain how to use it.\r\n\r\nRegards\r\nAlbert"},"comment":{"url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/comments/98156563","html_url":"https://github.com/alexgorbatchev/node-crc/pull/34#issuecomment-98156563","issue_url":"https://api.github.com/repos/alexgorbatchev/node-crc/issues/34","id":98156563,"user":{"login":"alexgorbatchev","id":65633,"avatar_url":"https://avatars.githubusercontent.com/u/65633?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgorbatchev","html_url":"https://github.com/alexgorbatchev","followers_url":"https://api.github.com/users/alexgorbatchev/followers","following_url":"https://api.github.com/users/alexgorbatchev/following{/other_user}","gists_url":"https://api.github.com/users/alexgorbatchev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgorbatchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgorbatchev/subscriptions","organizations_url":"https://api.github.com/users/alexgorbatchev/orgs","repos_url":"https://api.github.com/users/alexgorbatchev/repos","events_url":"https://api.github.com/users/alexgorbatchev/events{/privacy}","received_events_url":"https://api.github.com/users/alexgorbatchev/received_events","type":"User","site_admin":false},"created_at":"2015-05-01T15:26:17Z","updated_at":"2015-05-01T15:26:17Z","body":"Thanks for taking time to submit a PR. Do you know why the [tests](https://travis-ci.org/alexgorbatchev/node-crc/builds/60820716) aren't passing?"}}