{"action":"created","comment":{"url":"https://api.github.com/repos/tumblr/colossus/pulls/comments/26341634","id":26341634,"diff_hunk":"@@ -89,11 +88,14 @@ extends Controller[I,O](codec, ControllerConfig(50)) {\n   private val requestBuffer = collection.mutable.Queue[SyncPromise]()\n   private var numRequests = 0\n \n-  def idleCheck(period: Duration) {\n+  override def idleCheck(period: Duration) {\n+    super.idleCheck(period)","path":"colossus/src/main/scala/colossus/service/ServiceServer.scala","position":32,"original_position":32,"commit_id":"77f328206261b34efbd2dd41af764a5639f8813f","original_commit_id":"77f328206261b34efbd2dd41af764a5639f8813f","user":{"login":"nsauro","id":2262111,"avatar_url":"https://avatars.githubusercontent.com/u/2262111?v=3","gravatar_id":"","url":"https://api.github.com/users/nsauro","html_url":"https://github.com/nsauro","followers_url":"https://api.github.com/users/nsauro/followers","following_url":"https://api.github.com/users/nsauro/following{/other_user}","gists_url":"https://api.github.com/users/nsauro/gists{/gist_id}","starred_url":"https://api.github.com/users/nsauro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsauro/subscriptions","organizations_url":"https://api.github.com/users/nsauro/orgs","repos_url":"https://api.github.com/users/nsauro/repos","events_url":"https://api.github.com/users/nsauro/events{/privacy}","received_events_url":"https://api.github.com/users/nsauro/received_events","type":"User","site_admin":false},"body":"Let's see if I can say this intelligently, or if this is even an intelligent comment:\r\n\r\n  I've never been a fan of having code that get's structured in a way that if a function is overridden and the super isn't invoked..Bad Things Happen.  If the super's function absolutely needs to run(as in this case), I'm more a fan of making it so that you cannot override that function, but provide a hook which gets called at the end of the function.  That way children classes can override that function, add their own functionality and not accidentally fubar stuff.\r\n\r\nNot saying we should change this..but def something I think we should strive to avoid if at all possible.","created_at":"2015-03-12T20:34:25Z","updated_at":"2015-03-12T20:34:25Z","html_url":"https://github.com/tumblr/colossus/pull/149#discussion_r26341634","pull_request_url":"https://api.github.com/repos/tumblr/colossus/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/comments/26341634"},"html":{"href":"https://github.com/tumblr/colossus/pull/149#discussion_r26341634"},"pull_request":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/tumblr/colossus/pulls/149","id":31065686,"html_url":"https://github.com/tumblr/colossus/pull/149","diff_url":"https://github.com/tumblr/colossus/pull/149.diff","patch_url":"https://github.com/tumblr/colossus/pull/149.patch","issue_url":"https://api.github.com/repos/tumblr/colossus/issues/149","number":149,"state":"open","locked":false,"title":"Implement timeout checking for queued messages in controller","user":{"login":"reeve","id":6885611,"avatar_url":"https://avatars.githubusercontent.com/u/6885611?v=3","gravatar_id":"","url":"https://api.github.com/users/reeve","html_url":"https://github.com/reeve","followers_url":"https://api.github.com/users/reeve/followers","following_url":"https://api.github.com/users/reeve/following{/other_user}","gists_url":"https://api.github.com/users/reeve/gists{/gist_id}","starred_url":"https://api.github.com/users/reeve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reeve/subscriptions","organizations_url":"https://api.github.com/users/reeve/orgs","repos_url":"https://api.github.com/users/reeve/repos","events_url":"https://api.github.com/users/reeve/events{/privacy}","received_events_url":"https://api.github.com/users/reeve/received_events","type":"User","site_admin":false},"body":"Couple of significant API changes:\r\n1) Add timeout field to ControllerConfig\r\n2) Add optional createdMillis field to OutputController.push\r\n\r\nI'm going to do the in-flight timeout checks in another PR.\r\n\r\n@DanSimon @nsauro ","created_at":"2015-03-12T18:44:39Z","updated_at":"2015-03-12T20:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9baf985d113ff42789b3696fefac22dc5dae4e32","assignee":null,"milestone":{"url":"https://api.github.com/repos/tumblr/colossus/milestones/11","html_url":"https://github.com/tumblr/colossus/milestones/0.6.1-M1","labels_url":"https://api.github.com/repos/tumblr/colossus/milestones/11/labels","id":1002192,"number":11,"title":"0.6.1-M1","description":"","creator":{"login":"DanSimon","id":287961,"avatar_url":"https://avatars.githubusercontent.com/u/287961?v=3","gravatar_id":"","url":"https://api.github.com/users/DanSimon","html_url":"https://github.com/DanSimon","followers_url":"https://api.github.com/users/DanSimon/followers","following_url":"https://api.github.com/users/DanSimon/following{/other_user}","gists_url":"https://api.github.com/users/DanSimon/gists{/gist_id}","starred_url":"https://api.github.com/users/DanSimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanSimon/subscriptions","organizations_url":"https://api.github.com/users/DanSimon/orgs","repos_url":"https://api.github.com/users/DanSimon/repos","events_url":"https://api.github.com/users/DanSimon/events{/privacy}","received_events_url":"https://api.github.com/users/DanSimon/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-03-02T16:16:52Z","updated_at":"2015-03-12T19:11:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/tumblr/colossus/pulls/149/commits","review_comments_url":"https://api.github.com/repos/tumblr/colossus/pulls/149/comments","review_comment_url":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tumblr/colossus/issues/149/comments","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/77f328206261b34efbd2dd41af764a5639f8813f","head":{"label":"tumblr:reeve-request-timeouts","ref":"reeve-request-timeouts","sha":"77f328206261b34efbd2dd41af764a5639f8813f","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","created_at":"2014-11-11T16:06:06Z","updated_at":"2015-03-11T21:12:20Z","pushed_at":"2015-03-12T18:30:02Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":5198,"stargazers_count":525,"watchers_count":525,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":18,"forks":29,"open_issues":18,"watchers":525,"default_branch":"master"}},"base":{"label":"tumblr:master","ref":"master","sha":"5a017ffa3c4ece1b5c09965b6a2b00aa086c9daf","user":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"repo":{"id":26492586,"name":"colossus","full_name":"tumblr/colossus","owner":{"login":"tumblr","id":366151,"avatar_url":"https://avatars.githubusercontent.com/u/366151?v=3","gravatar_id":"","url":"https://api.github.com/users/tumblr","html_url":"https://github.com/tumblr","followers_url":"https://api.github.com/users/tumblr/followers","following_url":"https://api.github.com/users/tumblr/following{/other_user}","gists_url":"https://api.github.com/users/tumblr/gists{/gist_id}","starred_url":"https://api.github.com/users/tumblr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tumblr/subscriptions","organizations_url":"https://api.github.com/users/tumblr/orgs","repos_url":"https://api.github.com/users/tumblr/repos","events_url":"https://api.github.com/users/tumblr/events{/privacy}","received_events_url":"https://api.github.com/users/tumblr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tumblr/colossus","description":"I/O and Microservice library for Scala","fork":false,"url":"https://api.github.com/repos/tumblr/colossus","forks_url":"https://api.github.com/repos/tumblr/colossus/forks","keys_url":"https://api.github.com/repos/tumblr/colossus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tumblr/colossus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tumblr/colossus/teams","hooks_url":"https://api.github.com/repos/tumblr/colossus/hooks","issue_events_url":"https://api.github.com/repos/tumblr/colossus/issues/events{/number}","events_url":"https://api.github.com/repos/tumblr/colossus/events","assignees_url":"https://api.github.com/repos/tumblr/colossus/assignees{/user}","branches_url":"https://api.github.com/repos/tumblr/colossus/branches{/branch}","tags_url":"https://api.github.com/repos/tumblr/colossus/tags","blobs_url":"https://api.github.com/repos/tumblr/colossus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tumblr/colossus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tumblr/colossus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tumblr/colossus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tumblr/colossus/statuses/{sha}","languages_url":"https://api.github.com/repos/tumblr/colossus/languages","stargazers_url":"https://api.github.com/repos/tumblr/colossus/stargazers","contributors_url":"https://api.github.com/repos/tumblr/colossus/contributors","subscribers_url":"https://api.github.com/repos/tumblr/colossus/subscribers","subscription_url":"https://api.github.com/repos/tumblr/colossus/subscription","commits_url":"https://api.github.com/repos/tumblr/colossus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tumblr/colossus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tumblr/colossus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tumblr/colossus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tumblr/colossus/contents/{+path}","compare_url":"https://api.github.com/repos/tumblr/colossus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tumblr/colossus/merges","archive_url":"https://api.github.com/repos/tumblr/colossus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tumblr/colossus/downloads","issues_url":"https://api.github.com/repos/tumblr/colossus/issues{/number}","pulls_url":"https://api.github.com/repos/tumblr/colossus/pulls{/number}","milestones_url":"https://api.github.com/repos/tumblr/colossus/milestones{/number}","notifications_url":"https://api.github.com/repos/tumblr/colossus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tumblr/colossus/labels{/name}","releases_url":"https://api.github.com/repos/tumblr/colossus/releases{/id}","created_at":"2014-11-11T16:06:06Z","updated_at":"2015-03-11T21:12:20Z","pushed_at":"2015-03-12T18:30:02Z","git_url":"git://github.com/tumblr/colossus.git","ssh_url":"git@github.com:tumblr/colossus.git","clone_url":"https://github.com/tumblr/colossus.git","svn_url":"https://github.com/tumblr/colossus","homepage":"","size":5198,"stargazers_count":525,"watchers_count":525,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":29,"mirror_url":null,"open_issues_count":18,"forks":29,"open_issues":18,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/149"},"html":{"href":"https://github.com/tumblr/colossus/pull/149"},"issue":{"href":"https://api.github.com/repos/tumblr/colossus/issues/149"},"comments":{"href":"https://api.github.com/repos/tumblr/colossus/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tumblr/colossus/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/tumblr/colossus/statuses/77f328206261b34efbd2dd41af764a5639f8813f"}}}}