{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/28807614","id":28807614,"diff_hunk":"@@ -147,5 +147,358 @@ public void GetBindingDetails_FindsBindingSource_IfNullFallsBack()\n             // Assert\n             Assert.Equal(BindingSource.Body, context.BindingMetadata.BindingSource);\n         }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindingBehaviorNever_OnProperty()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindingBehaviorAttribute(BindingBehavior.Never),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.False(context.BindingMetadata.IsBindingAllowed);\n+            Assert.False(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindNever_OnProperty()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindNeverAttribute(),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.False(context.BindingMetadata.IsBindingAllowed);\n+            Assert.False(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindingBehaviorOptional_OnProperty()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindingBehaviorAttribute(BindingBehavior.Optional),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.True(context.BindingMetadata.IsBindingAllowed);\n+            Assert.False(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindingBehaviorRequired_OnProperty()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindingBehaviorAttribute(BindingBehavior.Required),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.True(context.BindingMetadata.IsBindingAllowed);\n+            Assert.True(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindRequired_OnProperty()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindingBehaviorAttribute(BindingBehavior.Required),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.True(context.BindingMetadata.IsBindingAllowed);\n+            Assert.True(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        // These attributes have conflicting behavior - the 'required' behavior should be used because\n+        // of ordering.\n+        [Fact]\n+        public void GetBindingDetails_UsesFirstAttribute()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+                new BindingBehaviorAttribute(BindingBehavior.Required),\n+                new BindNeverAttribute(),\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(int), \"Length\", typeof(string)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));\n+\n+            var provider = new DefaultBindingMetadataProvider();\n+\n+            // Act\n+            provider.GetBindingMetadata(context);\n+\n+            // Assert\n+            Assert.True(context.BindingMetadata.IsBindingAllowed);\n+            Assert.True(context.BindingMetadata.IsBindingRequired);\n+        }\n+\n+        [Fact]\n+        public void GetBindingDetails_FindsBindRequired_OnContainerClass()\n+        {\n+            // Arrange\n+            var propertyAttributes = new object[]\n+            {\n+            };\n+\n+            var context = new BindingMetadataProviderContext(\n+                ModelMetadataIdentity.ForProperty(typeof(string), \"Property\", typeof(BindRequiredOnClass)),\n+                new ModelAttributes(propertyAttributes, typeAttributes: new object[0]));","path":"test/Microsoft.AspNet.Mvc.ModelBinding.Test/Metadata/DefaultBindingMetadataProviderTest.cs","position":156,"original_position":156,"commit_id":"0b5f97ce15531850a69280c3e7f3d2ba018e26b9","original_commit_id":"0b5f97ce15531850a69280c3e7f3d2ba018e26b9","user":{"login":"harshgMSFT","id":6729943,"avatar_url":"https://avatars.githubusercontent.com/u/6729943?v=3","gravatar_id":"","url":"https://api.github.com/users/harshgMSFT","html_url":"https://github.com/harshgMSFT","followers_url":"https://api.github.com/users/harshgMSFT/followers","following_url":"https://api.github.com/users/harshgMSFT/following{/other_user}","gists_url":"https://api.github.com/users/harshgMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/harshgMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshgMSFT/subscriptions","organizations_url":"https://api.github.com/users/harshgMSFT/orgs","repos_url":"https://api.github.com/users/harshgMSFT/repos","events_url":"https://api.github.com/users/harshgMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/harshgMSFT/received_events","type":"User","site_admin":false},"body":"does this pass? you are passing in an empty typeAttribute array?","created_at":"2015-04-21T18:27:34Z","updated_at":"2015-04-21T18:27:34Z","html_url":"https://github.com/aspnet/Mvc/pull/2413#discussion_r28807614","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2413","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/28807614"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2413#discussion_r28807614"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2413"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/2413","id":33693399,"html_url":"https://github.com/aspnet/Mvc/pull/2413","diff_url":"https://github.com/aspnet/Mvc/pull/2413.diff","patch_url":"https://github.com/aspnet/Mvc/pull/2413.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/2413","number":2413,"state":"open","locked":false,"title":"Fix #1712 - remove reflection from validation code in MutableObjectModel...","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars.githubusercontent.com/u/1430011?v=3","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"body":"...Binder\r\n\r\nThis change moves [BindingBehavior(...)] and friends into the model\r\nmetadata layer, and removes the reflection code from\r\nMutableObjectModelBinder that was looking for them previously.","created_at":"2015-04-20T18:39:23Z","updated_at":"2015-04-21T18:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4ed6b8f8b055d80a229c8cfc6bd86dc27fa8650","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2413/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/2413/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/2413/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/0b5f97ce15531850a69280c3e7f3d2ba018e26b9","head":{"label":"aspnet:BindingBehavior","ref":"BindingBehavior","sha":"0b5f97ce15531850a69280c3e7f3d2ba018e26b9","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-04-21T15:27:10Z","pushed_at":"2015-04-21T17:27:03Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":112387,"stargazers_count":1626,"watchers_count":1626,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"open_issues_count":225,"forks":537,"open_issues":225,"watchers":1626,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"dedf923f09eeac8454892c0d619316b4e53e6804","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"Model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","created_at":"2013-12-12T03:54:00Z","updated_at":"2015-04-21T15:27:10Z","pushed_at":"2015-04-21T17:27:03Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":112387,"stargazers_count":1626,"watchers_count":1626,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":537,"mirror_url":null,"open_issues_count":225,"forks":537,"open_issues":225,"watchers":1626,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2413"},"html":{"href":"https://github.com/aspnet/Mvc/pull/2413"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2413"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/2413/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2413/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/2413/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/0b5f97ce15531850a69280c3e7f3d2ba018e26b9"}}}}