{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/w_transport/pulls/comments/36897756","id":36897756,"diff_hunk":"@@ -106,5 +106,27 @@ void main() {\n       Map data = JSON.decode(await response.asText());\n       expect(data['headers']['x-configured'], equals('true'));\n     });\n+\n+    group('should set the withCredentials flag', () {","path":"test/w_http_client_integration_test.dart","position":5,"original_position":5,"commit_id":"d647e223f53d7ed775fb4bd411d944ec2339b8e7","original_commit_id":"d647e223f53d7ed775fb4bd411d944ec2339b8e7","user":{"login":"dustinlessard-wf","id":2326518,"avatar_url":"https://avatars.githubusercontent.com/u/2326518?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinlessard-wf","html_url":"https://github.com/dustinlessard-wf","followers_url":"https://api.github.com/users/dustinlessard-wf/followers","following_url":"https://api.github.com/users/dustinlessard-wf/following{/other_user}","gists_url":"https://api.github.com/users/dustinlessard-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinlessard-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinlessard-wf/subscriptions","organizations_url":"https://api.github.com/users/dustinlessard-wf/orgs","repos_url":"https://api.github.com/users/dustinlessard-wf/repos","events_url":"https://api.github.com/users/dustinlessard-wf/events{/privacy}","received_events_url":"https://api.github.com/users/dustinlessard-wf/received_events","type":"User","site_admin":false},"body":"Ok,I see now - thanks","created_at":"2015-08-12T18:42:41Z","updated_at":"2015-08-12T18:42:41Z","html_url":"https://github.com/Workiva/w_transport/pull/51#discussion_r36897756","pull_request_url":"https://api.github.com/repos/Workiva/w_transport/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/comments/36897756"},"html":{"href":"https://github.com/Workiva/w_transport/pull/51#discussion_r36897756"},"pull_request":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/w_transport/pulls/51","id":42185889,"html_url":"https://github.com/Workiva/w_transport/pull/51","diff_url":"https://github.com/Workiva/w_transport/pull/51.diff","patch_url":"https://github.com/Workiva/w_transport/pull/51.patch","issue_url":"https://api.github.com/repos/Workiva/w_transport/issues/51","number":51,"state":"open","locked":false,"title":"CP-819 Refactor internal source code organization","user":{"login":"evanweible-wf","id":1738457,"avatar_url":"https://avatars.githubusercontent.com/u/1738457?v=3","gravatar_id":"","url":"https://api.github.com/users/evanweible-wf","html_url":"https://github.com/evanweible-wf","followers_url":"https://api.github.com/users/evanweible-wf/followers","following_url":"https://api.github.com/users/evanweible-wf/following{/other_user}","gists_url":"https://api.github.com/users/evanweible-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/evanweible-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanweible-wf/subscriptions","organizations_url":"https://api.github.com/users/evanweible-wf/orgs","repos_url":"https://api.github.com/users/evanweible-wf/repos","events_url":"https://api.github.com/users/evanweible-wf/events{/privacy}","received_events_url":"https://api.github.com/users/evanweible-wf/received_events","type":"User","site_admin":false},"body":"## Issue\r\nIn working on mocks for our the classes exposed in this library, the need for a reorganization of the source code became apparent. We are already sharing a good amount of code between the client and server implementations, but there wasn't an easy way to extend that reuse to the mocks that we were attempting to create (#32 / #41). Additionally, the configuration for client or server usage - despite being easy for consumers - is messy internally. It currently consists of a bunch of variables that are null by default that then get populated with a platform-specific function.\r\n\r\n## Changes\r\n**Source:**\r\nNow, the source code will be broken up into 5 different segments (seems like a lot, but it's much cleaner):\r\n\r\n- **Public abstract classes.** Defines the API cleanly without any implementation code. Includes a factory constructor if the class allows construction.\r\n  - `lib/src/http/w_http.dart`\r\n  - `lib/src/http/w_http_exception.dart` __*__\r\n  - `lib/src/http/w_progress.dart` __*__\r\n  - `lib/src/http/w_request.dart`\r\n  - `lib/src/http/w_response.dart`\r\n  - * These two classes are small enough and don't depend on the platform that they only need one implementation, so that implementation lives in this file.\r\n- **Common code.** Shared code that can remain the same on the client, server, or in a mock setting.\r\n  - `lib/src/http/common/w_http.dart`\r\n  - `lib/src/http/common/w_request.dart`\r\n  - `lib/src/http/common/w_response.dart`\r\n- **Platform-specific implementations.** Client/Server/Mock.\r\n  - `lib/src/[client|server|mock]/w_http.dart`\r\n  - `lib/src/[client|server|mock]/w_request.dart`\r\n  - `lib/src/[client|server|mock]/w_response.dart`\r\n\r\nWith this organization in place, all that's necessary is to define a platform adapter that can construct the correct instances of `WHttp` and `WRequest` based on the configured platform.\r\n> The public API for configuring w_transport remains the same to maintain backwards compatibility, but it now uses these new platform adapters internally.\r\n\r\n**Tests:**\r\n- Tests have been updated. A few tests were removed, but I verified that the content was also covered by integration tests.\r\n\r\n## Areas of Regression\r\n- Sort of everything..\r\n\r\n## Testing\r\n- CI build passes, examples work as expected.\r\n\r\n## Code Review\r\n@trentgrover-wf\r\n@maxwellpeterson-wf \r\n@dustinlessard-wf\r\nfyi: @jayudey-wf ","created_at":"2015-08-11T22:28:43Z","updated_at":"2015-08-12T18:42:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f9f4ccb50c7800feccab5abc942ba994d4b21d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/w_transport/pulls/51/commits","review_comments_url":"https://api.github.com/repos/Workiva/w_transport/pulls/51/comments","review_comment_url":"https://api.github.com/repos/Workiva/w_transport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/w_transport/issues/51/comments","statuses_url":"https://api.github.com/repos/Workiva/w_transport/statuses/d647e223f53d7ed775fb4bd411d944ec2339b8e7","head":{"label":"Workiva:source-org-refactor","ref":"source-org-refactor","sha":"d647e223f53d7ed775fb4bd411d944ec2339b8e7","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":32808289,"name":"w_transport","full_name":"Workiva/w_transport","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/w_transport","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/w_transport","forks_url":"https://api.github.com/repos/Workiva/w_transport/forks","keys_url":"https://api.github.com/repos/Workiva/w_transport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_transport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_transport/teams","hooks_url":"https://api.github.com/repos/Workiva/w_transport/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_transport/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_transport/events","assignees_url":"https://api.github.com/repos/Workiva/w_transport/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_transport/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_transport/tags","blobs_url":"https://api.github.com/repos/Workiva/w_transport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_transport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_transport/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_transport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_transport/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_transport/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_transport/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_transport/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_transport/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_transport/subscription","commits_url":"https://api.github.com/repos/Workiva/w_transport/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_transport/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_transport/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_transport/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_transport/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_transport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_transport/merges","archive_url":"https://api.github.com/repos/Workiva/w_transport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_transport/downloads","issues_url":"https://api.github.com/repos/Workiva/w_transport/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_transport/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_transport/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_transport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_transport/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_transport/releases{/id}","created_at":"2015-03-24T15:43:40Z","updated_at":"2015-06-29T18:38:00Z","pushed_at":"2015-08-11T23:40:36Z","git_url":"git://github.com/Workiva/w_transport.git","ssh_url":"git@github.com:Workiva/w_transport.git","clone_url":"https://github.com/Workiva/w_transport.git","svn_url":"https://github.com/Workiva/w_transport","homepage":null,"size":650,"stargazers_count":2,"watchers_count":2,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"8c63e0dae457e82a7b891c97d7befaad845afb79","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":32808289,"name":"w_transport","full_name":"Workiva/w_transport","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/w_transport","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/w_transport","forks_url":"https://api.github.com/repos/Workiva/w_transport/forks","keys_url":"https://api.github.com/repos/Workiva/w_transport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_transport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_transport/teams","hooks_url":"https://api.github.com/repos/Workiva/w_transport/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_transport/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_transport/events","assignees_url":"https://api.github.com/repos/Workiva/w_transport/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_transport/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_transport/tags","blobs_url":"https://api.github.com/repos/Workiva/w_transport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_transport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_transport/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_transport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_transport/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_transport/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_transport/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_transport/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_transport/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_transport/subscription","commits_url":"https://api.github.com/repos/Workiva/w_transport/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_transport/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_transport/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_transport/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_transport/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_transport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_transport/merges","archive_url":"https://api.github.com/repos/Workiva/w_transport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_transport/downloads","issues_url":"https://api.github.com/repos/Workiva/w_transport/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_transport/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_transport/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_transport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_transport/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_transport/releases{/id}","created_at":"2015-03-24T15:43:40Z","updated_at":"2015-06-29T18:38:00Z","pushed_at":"2015-08-11T23:40:36Z","git_url":"git://github.com/Workiva/w_transport.git","ssh_url":"git@github.com:Workiva/w_transport.git","clone_url":"https://github.com/Workiva/w_transport.git","svn_url":"https://github.com/Workiva/w_transport","homepage":null,"size":650,"stargazers_count":2,"watchers_count":2,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/51"},"html":{"href":"https://github.com/Workiva/w_transport/pull/51"},"issue":{"href":"https://api.github.com/repos/Workiva/w_transport/issues/51"},"comments":{"href":"https://api.github.com/repos/Workiva/w_transport/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/w_transport/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/w_transport/statuses/d647e223f53d7ed775fb4bd411d944ec2339b8e7"}}}}