{"action":"created","issue":{"url":"https://api.github.com/repos/rabernat/pyqg/issues/2","labels_url":"https://api.github.com/repos/rabernat/pyqg/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/rabernat/pyqg/issues/2/comments","events_url":"https://api.github.com/repos/rabernat/pyqg/issues/2/events","html_url":"https://github.com/rabernat/pyqg/issues/2","id":71955972,"number":2,"title":"test_twolayer_qq test fails","user":{"login":"rabernat","id":1197350,"avatar_url":"https://avatars.githubusercontent.com/u/1197350?v=3","gravatar_id":"","url":"https://api.github.com/users/rabernat","html_url":"https://github.com/rabernat","followers_url":"https://api.github.com/users/rabernat/followers","following_url":"https://api.github.com/users/rabernat/following{/other_user}","gists_url":"https://api.github.com/users/rabernat/gists{/gist_id}","starred_url":"https://api.github.com/users/rabernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabernat/subscriptions","organizations_url":"https://api.github.com/users/rabernat/orgs","repos_url":"https://api.github.com/users/rabernat/repos","events_url":"https://api.github.com/users/rabernat/events{/privacy}","received_events_url":"https://api.github.com/users/rabernat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rabernat/pyqg/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-29T18:48:34Z","updated_at":"2015-04-30T00:43:25Z","closed_at":null,"body":"Despite our best attempt at making a useful test, the default test still fails. Here is the output I get from it.\r\n\r\n```\r\nFAIL: test_twolayer_qg.test_the_model\r\nMake sure the results are correct within relative tolerance rtol.\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"/usr/local/anaconda/lib/python2.7/site-packages/nose/case.py\", line 197, in runTest\r\n    self.test(*self.arg)\r\n  File \"/home/rpa/pyqg/pyqg/tests/test_twolayer_qg.py\", line 42, in test_the_model\r\n    np.testing.assert_allclose(q1norm, 9.561430503712755e-08, rtol)\r\n  File \"/usr/local/anaconda/lib/python2.7/site-packages/numpy/testing/utils.py\", line 1297, in assert_allclose\r\n    verbose=verbose, header=header)\r\n  File \"/usr/local/anaconda/lib/python2.7/site-packages/numpy/testing/utils.py\", line 665, in assert_array_compare\r\n    raise AssertionError(msg)\r\nAssertionError: \r\nNot equal to tolerance rtol=1e-15, atol=0\r\n\r\n(mismatch 100.0%)\r\n x: array(9.723198783759038e-08)\r\n y: array(9.561430503712755e-08)\r\n-------------------- >> begin captured stdout << ---------------------\r\nt=               0, tc=         0: cfl=0.021228, ke=0.000019292, T_e=527.025961099\r\nt=        12800000, tc=      1000: cfl=0.021195, ke=0.000019292, T_e=527.025961099\r\nt=        25600000, tc=      2000: cfl=0.021309, ke=0.000035737, T_e=387.206968354\r\nt=        38400000, tc=      3000: cfl=0.026747, ke=0.000089140, T_e=245.170789728\r\nt=        51200000, tc=      4000: cfl=0.042333, ke=0.000222572, T_e=155.154023419\r\nt=        64000000, tc=      5000: cfl=0.066459, ke=0.000555989, T_e=98.164418796\r\nt=        76800000, tc=      6000: cfl=0.105021, ke=0.001390120, T_e=62.085201635\r\nt=        89600000, tc=      7000: cfl=0.102573, ke=0.003476802, T_e=39.257825464\r\ntime:       9.3312e+07\r\nq1norm:     9.723198783759038e-08\r\n\r\n--------------------- >> end captured stdout << ----------------------\r\n\r\n----------------------------------------------------------------------\r\nRan 4 tests in 14.851s\r\n\r\nFAILED (failures=1, errors=1)\r\n```"},"comment":{"url":"https://api.github.com/repos/rabernat/pyqg/issues/comments/97621988","html_url":"https://github.com/rabernat/pyqg/issues/2#issuecomment-97621988","issue_url":"https://api.github.com/repos/rabernat/pyqg/issues/2","id":97621988,"user":{"login":"MFJansen","id":7927916,"avatar_url":"https://avatars.githubusercontent.com/u/7927916?v=3","gravatar_id":"","url":"https://api.github.com/users/MFJansen","html_url":"https://github.com/MFJansen","followers_url":"https://api.github.com/users/MFJansen/followers","following_url":"https://api.github.com/users/MFJansen/following{/other_user}","gists_url":"https://api.github.com/users/MFJansen/gists{/gist_id}","starred_url":"https://api.github.com/users/MFJansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFJansen/subscriptions","organizations_url":"https://api.github.com/users/MFJansen/orgs","repos_url":"https://api.github.com/users/MFJansen/repos","events_url":"https://api.github.com/users/MFJansen/events{/privacy}","received_events_url":"https://api.github.com/users/MFJansen/received_events","type":"User","site_admin":false},"created_at":"2015-04-30T00:43:25Z","updated_at":"2015-04-30T00:43:25Z","body":"I just pulled the latest version on my old laptop. The version on the \"test_twolayer_succeeds\"  branch passes the test on my laptop. As I said earlier, on my desktop it failed, but less badly - so it might be a machine dependent numerics issue. However, that still seems a bit odd to me, given that it does work on my laptop and your desktop, which are just as different machines. Moreover I seem to recall that we were able to reproduce results to this precision even between the Matlab and python codes. Can somebody else checkout the \"test_twolayer_succeeds\" branch and check if it passes on their machine?\r\n\r\nThe master branch version now seems totally off, and also the test script itself seems to keep changing. Can we please restore the original test, so that we can make sure our answers haven't changed (and if they did, figure out why)?"}}