{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/25516891","id":25516891,"diff_hunk":"@@ -702,8 +707,16 @@ OC.Share={\n \t\t\thtml += '</div>';\n \t\t\thtml += '</li>';\n \t\t\thtml = $(html).appendTo('#shareWithList');\n-\t\t\tif (oc_config.enable_avatars === true && shareType === OC.Share.SHARE_TYPE_USER) {\n-\t\t\t\t$('#avatar-' + escapeHTML(shareWith)).avatar(escapeHTML(shareWith), 32);\n+\t\t\tif (oc_config.enable_avatars === true) {\n+\t\t\t\tif (shareType === OC.Share.SHARE_TYPE_USER) {\n+\t\t\t\t\t$('#avatar-user-' + escapeHTML(shareWith)).avatar(escapeHTML(shareWith), 32);\n+\t\t\t\t} else if (shareType === OC.Share.SHARE_TYPE_GROUP) {\n+\t\t\t\t\t//Add group to seed to have different background color than user with the same name\n+\t\t\t\t\t$('#avatar-group-' + escapeHTML(shareWith)).imageplaceholder(shareWith + ' group', shareWith);\n+\t\t\t\t} else if (shareType === OC.Share.SHARE_TYPE_REMOTE) {\n+\t\t\t\t\tvar tmpShareWith = escapeHTML(shareWith).replace(/[@\\.\\/]/g,\"_\");\n+\t\t\t\t\t$('#avatar-remote-' + tmpShareWith).imageplaceholder(shareWith);","path":"core/js/share.js","position":52,"original_position":52,"commit_id":"845ac365e4660cc030acc594e9c6996f6817fe98","original_commit_id":"845ac365e4660cc030acc594e9c6996f6817fe98","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"body":"Yeah better then to keep it a bit duplicated for now. And make it all nice and fancy once the popup dialog is available.","created_at":"2015-02-27T16:13:34Z","updated_at":"2015-02-27T16:13:34Z","html_url":"https://github.com/owncloud/core/pull/14582#discussion_r25516891","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/14582","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/25516891"},"html":{"href":"https://github.com/owncloud/core/pull/14582#discussion_r25516891"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/14582"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/14582","id":30176911,"html_url":"https://github.com/owncloud/core/pull/14582","diff_url":"https://github.com/owncloud/core/pull/14582.diff","patch_url":"https://github.com/owncloud/core/pull/14582.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/14582","number":14582,"state":"open","locked":false,"title":"Avatars in share dialog fixes","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"body":"* Avatar for \"xxxx share with you...\" to the left\r\n* Avatars for groups and remote shares (use default placeholder)\r\n* Modified and added unit tests\r\n\r\nPR for #14457. Should add more consistency to the sharedialog","created_at":"2015-02-27T15:58:35Z","updated_at":"2015-02-27T16:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"568eb735878e72a3843b0b2c530e272f0044c5ca","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","html_url":"https://github.com/owncloud/core/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":377,"closed_issues":213,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-02-27T16:11:37Z","due_on":"2015-04-02T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/14582/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/14582/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/14582/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/845ac365e4660cc030acc594e9c6996f6817fe98","head":{"label":"rullzer:avatar_fixes","ref":"avatar_fixes","sha":"845ac365e4660cc030acc594e9c6996f6817fe98","user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"repo":{"id":29611886,"name":"core","full_name":"rullzer/core","owner":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rullzer/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/rullzer/core","forks_url":"https://api.github.com/repos/rullzer/core/forks","keys_url":"https://api.github.com/repos/rullzer/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rullzer/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rullzer/core/teams","hooks_url":"https://api.github.com/repos/rullzer/core/hooks","issue_events_url":"https://api.github.com/repos/rullzer/core/issues/events{/number}","events_url":"https://api.github.com/repos/rullzer/core/events","assignees_url":"https://api.github.com/repos/rullzer/core/assignees{/user}","branches_url":"https://api.github.com/repos/rullzer/core/branches{/branch}","tags_url":"https://api.github.com/repos/rullzer/core/tags","blobs_url":"https://api.github.com/repos/rullzer/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rullzer/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rullzer/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rullzer/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rullzer/core/statuses/{sha}","languages_url":"https://api.github.com/repos/rullzer/core/languages","stargazers_url":"https://api.github.com/repos/rullzer/core/stargazers","contributors_url":"https://api.github.com/repos/rullzer/core/contributors","subscribers_url":"https://api.github.com/repos/rullzer/core/subscribers","subscription_url":"https://api.github.com/repos/rullzer/core/subscription","commits_url":"https://api.github.com/repos/rullzer/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rullzer/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rullzer/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rullzer/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rullzer/core/contents/{+path}","compare_url":"https://api.github.com/repos/rullzer/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rullzer/core/merges","archive_url":"https://api.github.com/repos/rullzer/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rullzer/core/downloads","issues_url":"https://api.github.com/repos/rullzer/core/issues{/number}","pulls_url":"https://api.github.com/repos/rullzer/core/pulls{/number}","milestones_url":"https://api.github.com/repos/rullzer/core/milestones{/number}","notifications_url":"https://api.github.com/repos/rullzer/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rullzer/core/labels{/name}","releases_url":"https://api.github.com/repos/rullzer/core/releases{/id}","created_at":"2015-01-21T20:40:40Z","updated_at":"2015-02-27T16:01:11Z","pushed_at":"2015-02-27T16:01:11Z","git_url":"git://github.com/rullzer/core.git","ssh_url":"git@github.com:rullzer/core.git","clone_url":"https://github.com/rullzer/core.git","svn_url":"https://github.com/rullzer/core","homepage":null,"size":153663,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"970b14d2979cb03d1e9ba96cbce3e43a52835333","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","created_at":"2012-08-25T10:32:48Z","updated_at":"2015-02-27T16:11:37Z","pushed_at":"2015-02-27T16:11:38Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":null,"size":918575,"stargazers_count":3068,"watchers_count":3068,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":997,"mirror_url":null,"open_issues_count":1863,"forks":997,"open_issues":1863,"watchers":3068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/14582"},"html":{"href":"https://github.com/owncloud/core/pull/14582"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/14582"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/14582/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/14582/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/14582/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/845ac365e4660cc030acc594e9c6996f6817fe98"}}}}