{"action":"created","issue":{"url":"https://api.github.com/repos/dbcli/pgcli/issues/262","labels_url":"https://api.github.com/repos/dbcli/pgcli/issues/262/labels{/name}","comments_url":"https://api.github.com/repos/dbcli/pgcli/issues/262/comments","events_url":"https://api.github.com/repos/dbcli/pgcli/issues/262/events","html_url":"https://github.com/dbcli/pgcli/pull/262","id":89875495,"number":262,"title":"Make the horizontal separator in expanded mode a constant length.","user":{"login":"amjith","id":49260,"avatar_url":"https://avatars.githubusercontent.com/u/49260?v=3","gravatar_id":"","url":"https://api.github.com/users/amjith","html_url":"https://github.com/amjith","followers_url":"https://api.github.com/users/amjith/followers","following_url":"https://api.github.com/users/amjith/following{/other_user}","gists_url":"https://api.github.com/users/amjith/gists{/gist_id}","starred_url":"https://api.github.com/users/amjith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amjith/subscriptions","organizations_url":"https://api.github.com/users/amjith/orgs","repos_url":"https://api.github.com/users/amjith/repos","events_url":"https://api.github.com/users/amjith/events{/privacy}","received_events_url":"https://api.github.com/users/amjith/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dbcli/pgcli/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-21T07:02:30Z","updated_at":"2015-06-26T18:24:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dbcli/pgcli/pulls/262","html_url":"https://github.com/dbcli/pgcli/pull/262","diff_url":"https://github.com/dbcli/pgcli/pull/262.diff","patch_url":"https://github.com/dbcli/pgcli/pull/262.patch"},"body":"In expanded mode the record separator looks like this `-[ RECORD 26 ]-------------------------`. \r\n\r\nThe number of dashes used to be calculated based on the longest value of a column. Now this is made a constant for two reasons. \r\n\r\n1. If a column has a really long value (say a multi-line paragraph). The separator will look ridiculous which  would make the expanded output useless. \r\n2. It is more performant to use a constant value instead of trying to iterate over the whole set of values just to determine the max length to use. \r\n\r\nReviewer: @macobo "},"comment":{"url":"https://api.github.com/repos/dbcli/pgcli/issues/comments/115824217","html_url":"https://github.com/dbcli/pgcli/pull/262#issuecomment-115824217","issue_url":"https://api.github.com/repos/dbcli/pgcli/issues/262","id":115824217,"user":{"login":"amjith","id":49260,"avatar_url":"https://avatars.githubusercontent.com/u/49260?v=3","gravatar_id":"","url":"https://api.github.com/users/amjith","html_url":"https://github.com/amjith","followers_url":"https://api.github.com/users/amjith/followers","following_url":"https://api.github.com/users/amjith/following{/other_user}","gists_url":"https://api.github.com/users/amjith/gists{/gist_id}","starred_url":"https://api.github.com/users/amjith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amjith/subscriptions","organizations_url":"https://api.github.com/users/amjith/orgs","repos_url":"https://api.github.com/users/amjith/repos","events_url":"https://api.github.com/users/amjith/events{/privacy}","received_events_url":"https://api.github.com/users/amjith/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T18:24:55Z","updated_at":"2015-06-26T18:24:55Z","body":"@macobo Can you review and merge? "}}