{"comment":{"url":"https://api.github.com/repos/e-lang/moodle-mod_elang/comments/11793070","html_url":"https://github.com/e-lang/moodle-mod_elang/commit/db6c2520de237b612044b3a31e9c7bc335f14fb3#commitcomment-11793070","id":11793070,"user":{"login":"ralferlebach","id":12737344,"avatar_url":"https://avatars.githubusercontent.com/u/12737344?v=3","gravatar_id":"","url":"https://api.github.com/users/ralferlebach","html_url":"https://github.com/ralferlebach","followers_url":"https://api.github.com/users/ralferlebach/followers","following_url":"https://api.github.com/users/ralferlebach/following{/other_user}","gists_url":"https://api.github.com/users/ralferlebach/gists{/gist_id}","starred_url":"https://api.github.com/users/ralferlebach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralferlebach/subscriptions","organizations_url":"https://api.github.com/users/ralferlebach/orgs","repos_url":"https://api.github.com/users/ralferlebach/repos","events_url":"https://api.github.com/users/ralferlebach/events{/privacy}","received_events_url":"https://api.github.com/users/ralferlebach/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"db6c2520de237b612044b3a31e9c7bc335f14fb3","created_at":"2015-06-22T12:41:28Z","updated_at":"2015-06-22T12:41:28Z","body":"Hi Christophe,\r\n\r\nI realized, that you made some progress in order to implement Levensthein distance into the checking routine by using iconv with TRANSLIT paradigm. This seems to me a great idea, however this will only work for lamguages basing on latin letters and will fail completely for any other language (Chinese, Japanese, Korean, Arab - for sure also for Russian and Greek as well...)\r\n\r\nTherefore I suggest to couple this feature onto the language used (EN, FR, ES, IT, DE will work, others should be bypassed).\r\n\r\nAlso, there will be differneces with the TRANSLIT paradigm for each loclization. For example Göthe (written wrongfully intentionally) will be translated by iconv to \"Goethe\" in German environments, but to \"Gothe\" in English ones. This will make a difference by using the (shortest) Levensthein distance procedure: Gtoehe => Goethe will be 2, Gtohe => Gothe only 1 Levensthein step to be counted. Also, for using a relative count (let's say \"Levensthein distance per total count of letters\") will be different as the total count of letters also differs accordingly to the language environment.\r\n\r\nThis is slightly combined with ticket \"Strict and Tolerant answer checking\" https://github.com/e-lang/moodle-mod_elang/issues/59\r\n\r\n(Hope, I do not swamp and spam you with those requests... it's not necessarily a feature for the very next versions and I will do my best in order to support you with that as ususal, but I post it all here in order not to forget it and also to discuss this. =)\r\n"}}