{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1483","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1483/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1483/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1483/events","html_url":"https://github.com/Automattic/wp-calypso/pull/1483","id":121594653,"number":1483,"title":"SiteSelectorModal: Use SitesDropdown","user":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Components","name":"Components","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Themes","name":"Themes","color":"006b75"},{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Author%20Reply","name":"[Status] Needs Author Reply","color":"eb6420"}],"state":"open","locked":false,"assignee":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/19","html_url":"https://github.com/Automattic/wp-calypso/milestones/Themes:%20Showcase%20M3-LoggedOut","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/19/labels","id":1420000,"number":19,"title":"Themes: Showcase M3-LoggedOut","description":"","creator":{"login":"hoverduck","id":7233112,"avatar_url":"https://avatars.githubusercontent.com/u/7233112?v=3","gravatar_id":"","url":"https://api.github.com/users/hoverduck","html_url":"https://github.com/hoverduck","followers_url":"https://api.github.com/users/hoverduck/followers","following_url":"https://api.github.com/users/hoverduck/following{/other_user}","gists_url":"https://api.github.com/users/hoverduck/gists{/gist_id}","starred_url":"https://api.github.com/users/hoverduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoverduck/subscriptions","organizations_url":"https://api.github.com/users/hoverduck/orgs","repos_url":"https://api.github.com/users/hoverduck/repos","events_url":"https://api.github.com/users/hoverduck/events{/privacy}","received_events_url":"https://api.github.com/users/hoverduck/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":6,"state":"open","created_at":"2015-11-19T15:18:52Z","updated_at":"2015-12-16T20:32:01Z","due_on":"2015-12-09T03:00:00Z","closed_at":null},"comments":4,"created_at":"2015-12-10T22:42:47Z","updated_at":"2015-12-16T23:26:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/1483","html_url":"https://github.com/Automattic/wp-calypso/pull/1483","diff_url":"https://github.com/Automattic/wp-calypso/pull/1483.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/1483.patch"},"body":"Use @mtias' `SitesDropdown` component inside `SiteSelectorModal` (instead of `me/select-site`).\r\n\r\nChanges include:\r\n* Added filter props to some components in the hierarchy, in order to remove Jetpack sites from the dropdown.\r\n* Generalization of the logic that sets the pre-selected site (bb739e1d16bacb00fd2627d1833984e98bd10c88) @seear \r\n* Some cleanup (ESLint, obsolete SASS, obsolete attribute in `SiteDropdown`'s `initialState`)\r\n\r\nTo test:\r\n* Go to calypso.localhost:3000/design\r\n* Click on any theme's '...' menu and select 'Activate'\r\n* Verify that your primary site is pre-selected in the dropdown.\r\n* Verify that no Jetpack sites are shown in that dropdown.\r\n* Select a test site of yours and activate the theme on it.\r\n* Check that you're shown the 'Thanks' modal, and that the theme really has been activated on the selected site.\r\n* Edge case -- primary site is a Jetpack site:\r\n * Try setting your primary site to a Jetpack site. Verify that instead of that JP site, the (alphabetically) first of your wpcom-hosted sites is pre-selected in the dropdown.\r\n\r\nBefore:\r\n\r\n![before](https://cloud.githubusercontent.com/assets/96308/11821812/ad558a90-a36b-11e5-8d6d-30fabeb32f6b.png)\r\n\r\nAfter:\r\n\r\n![after](https://cloud.githubusercontent.com/assets/96308/11821837/c8419aa6-a36b-11e5-834d-05857f888d58.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/165285277","html_url":"https://github.com/Automattic/wp-calypso/pull/1483#issuecomment-165285277","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/1483","id":165285277,"user":{"login":"ockham","id":96308,"avatar_url":"https://avatars.githubusercontent.com/u/96308?v=3","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"created_at":"2015-12-16T23:26:36Z","updated_at":"2015-12-16T23:26:36Z","body":"@folletto Should be fixed now."}}