{"action":"created","comment":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments/31253253","id":31253253,"diff_hunk":"@@ -617,7 +622,7 @@ class NINLayer_c01b(Layer):\n         Any additional keyword arguments are passed to the `Layer` superclass.\n     \"\"\"\n     def __init__(self, incoming, num_units, untie_biases=False,\n-                 W=init.GlorotUniform(c01b=True), b=init.Constant(0.),\n+                 W=init.GlorotUniform(), b=init.Constant(0.),","path":"lasagne/layers/cuda_convnet.py","position":68,"original_position":68,"commit_id":"9af291437f1bc06f6adcea1fd16a5310c6592da2","original_commit_id":"9af291437f1bc06f6adcea1fd16a5310c6592da2","user":{"login":"f0k","id":629706,"avatar_url":"https://avatars.githubusercontent.com/u/629706?v=3","gravatar_id":"","url":"https://api.github.com/users/f0k","html_url":"https://github.com/f0k","followers_url":"https://api.github.com/users/f0k/followers","following_url":"https://api.github.com/users/f0k/following{/other_user}","gists_url":"https://api.github.com/users/f0k/gists{/gist_id}","starred_url":"https://api.github.com/users/f0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0k/subscriptions","organizations_url":"https://api.github.com/users/f0k/orgs","repos_url":"https://api.github.com/users/f0k/repos","events_url":"https://api.github.com/users/f0k/events{/privacy}","received_events_url":"https://api.github.com/users/f0k/received_events","type":"User","site_admin":false},"body":"You removed that here, but not in the docstring.","created_at":"2015-05-28T16:44:57Z","updated_at":"2015-05-28T16:44:57Z","html_url":"https://github.com/Lasagne/Lasagne/pull/267#discussion_r31253253","pull_request_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267","_links":{"self":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments/31253253"},"html":{"href":"https://github.com/Lasagne/Lasagne/pull/267#discussion_r31253253"},"pull_request":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267"}}},"pull_request":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267","id":36141863,"html_url":"https://github.com/Lasagne/Lasagne/pull/267","diff_url":"https://github.com/Lasagne/Lasagne/pull/267.diff","patch_url":"https://github.com/Lasagne/Lasagne/pull/267.patch","issue_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267","number":267,"state":"open","locked":false,"title":"increase coverage for convolution layers","user":{"login":"benanne","id":43829,"avatar_url":"https://avatars.githubusercontent.com/u/43829?v=3","gravatar_id":"","url":"https://api.github.com/users/benanne","html_url":"https://github.com/benanne","followers_url":"https://api.github.com/users/benanne/followers","following_url":"https://api.github.com/users/benanne/following{/other_user}","gists_url":"https://api.github.com/users/benanne/gists{/gist_id}","starred_url":"https://api.github.com/users/benanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benanne/subscriptions","organizations_url":"https://api.github.com/users/benanne/orgs","repos_url":"https://api.github.com/users/benanne/repos","events_url":"https://api.github.com/users/benanne/events{/privacy}","received_events_url":"https://api.github.com/users/benanne/received_events","type":"User","site_admin":false},"body":"This PR does a few things:\r\n* fixes a bug in all convolution implementations which made bias-less layers unusable (the same one that @ebenolson fixed in `NINLayer`, see https://github.com/ebenolson/Lasagne/commit/ffce108e87d4f14a7e2c2499bb4ccb1c9c86f02e)\r\n* moves the `border_mode` validity check into the constructor for all layers, so constructing a layer with an invalid border mode string fails as early as possible (previously this check was in `get_output_for()` and `get_output_shape_for()` for a few implementations)\r\n* adds tests for bias-less layers (`b=None`), linear layers (`nonlinearity=None`) and invalid border mode checks\r\n\r\nIt brings coverage for `lasagne/layers/conv.py` up to almost 100%. It falls just two lines short of that: the `b=None` case in `get_output_for()` is not covered for `Conv1DLayer` and `Conv2DLayer`. I'm not sure how to go about covering these two lines effectively. Adding the `b=None` case to all test configurations in `conv2d_test_sets()` seems wasteful, it will increase the test duration by a lot and the benefit is negligible. It seems like a single \"output test\" should be sufficient. Any ideas?\r\n\r\nI'll try to get the coverage for `corrmm`, `dnn` and `cuda-convnet` up to 100% as well in this PR (at least the convolution parts, might leave the pooling parts for later).","created_at":"2015-05-25T14:10:25Z","updated_at":"2015-05-28T16:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f8a44a3344f8c87fd2bd1edaf250153126a674","assignee":null,"milestone":{"url":"https://api.github.com/repos/Lasagne/Lasagne/milestones/1","html_url":"https://github.com/Lasagne/Lasagne/milestones/First%20release","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/milestones/1/labels","id":908462,"number":1,"title":"First release","description":"Things to do for the first release.","creator":{"login":"benanne","id":43829,"avatar_url":"https://avatars.githubusercontent.com/u/43829?v=3","gravatar_id":"","url":"https://api.github.com/users/benanne","html_url":"https://github.com/benanne","followers_url":"https://api.github.com/users/benanne/followers","following_url":"https://api.github.com/users/benanne/following{/other_user}","gists_url":"https://api.github.com/users/benanne/gists{/gist_id}","starred_url":"https://api.github.com/users/benanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benanne/subscriptions","organizations_url":"https://api.github.com/users/benanne/orgs","repos_url":"https://api.github.com/users/benanne/repos","events_url":"https://api.github.com/users/benanne/events{/privacy}","received_events_url":"https://api.github.com/users/benanne/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":45,"state":"open","created_at":"2014-12-18T15:32:21Z","updated_at":"2015-05-25T14:12:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267/commits","review_comments_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267/comments","review_comment_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267/comments","statuses_url":"https://api.github.com/repos/Lasagne/Lasagne/statuses/9af291437f1bc06f6adcea1fd16a5310c6592da2","head":{"label":"Lasagne:conv-coverage","ref":"conv-coverage","sha":"9af291437f1bc06f6adcea1fd16a5310c6592da2","user":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"repo":{"id":23924195,"name":"Lasagne","full_name":"Lasagne/Lasagne","owner":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lasagne/Lasagne","description":"neural network tools for Theano","fork":false,"url":"https://api.github.com/repos/Lasagne/Lasagne","forks_url":"https://api.github.com/repos/Lasagne/Lasagne/forks","keys_url":"https://api.github.com/repos/Lasagne/Lasagne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lasagne/Lasagne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lasagne/Lasagne/teams","hooks_url":"https://api.github.com/repos/Lasagne/Lasagne/hooks","issue_events_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/events{/number}","events_url":"https://api.github.com/repos/Lasagne/Lasagne/events","assignees_url":"https://api.github.com/repos/Lasagne/Lasagne/assignees{/user}","branches_url":"https://api.github.com/repos/Lasagne/Lasagne/branches{/branch}","tags_url":"https://api.github.com/repos/Lasagne/Lasagne/tags","blobs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lasagne/Lasagne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lasagne/Lasagne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lasagne/Lasagne/statuses/{sha}","languages_url":"https://api.github.com/repos/Lasagne/Lasagne/languages","stargazers_url":"https://api.github.com/repos/Lasagne/Lasagne/stargazers","contributors_url":"https://api.github.com/repos/Lasagne/Lasagne/contributors","subscribers_url":"https://api.github.com/repos/Lasagne/Lasagne/subscribers","subscription_url":"https://api.github.com/repos/Lasagne/Lasagne/subscription","commits_url":"https://api.github.com/repos/Lasagne/Lasagne/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lasagne/Lasagne/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lasagne/Lasagne/contents/{+path}","compare_url":"https://api.github.com/repos/Lasagne/Lasagne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lasagne/Lasagne/merges","archive_url":"https://api.github.com/repos/Lasagne/Lasagne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lasagne/Lasagne/downloads","issues_url":"https://api.github.com/repos/Lasagne/Lasagne/issues{/number}","pulls_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls{/number}","milestones_url":"https://api.github.com/repos/Lasagne/Lasagne/milestones{/number}","notifications_url":"https://api.github.com/repos/Lasagne/Lasagne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/labels{/name}","releases_url":"https://api.github.com/repos/Lasagne/Lasagne/releases{/id}","created_at":"2014-09-11T15:31:41Z","updated_at":"2015-05-28T09:51:18Z","pushed_at":"2015-05-28T16:24:22Z","git_url":"git://github.com/Lasagne/Lasagne.git","ssh_url":"git@github.com:Lasagne/Lasagne.git","clone_url":"https://github.com/Lasagne/Lasagne.git","svn_url":"https://github.com/Lasagne/Lasagne","homepage":"http://lasagne.readthedocs.org/","size":4486,"stargazers_count":581,"watchers_count":581,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":36,"forks":139,"open_issues":36,"watchers":581,"default_branch":"master"}},"base":{"label":"Lasagne:master","ref":"master","sha":"c4b5e4d066a3b9a7d7fd196169032eb3a880650c","user":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"repo":{"id":23924195,"name":"Lasagne","full_name":"Lasagne/Lasagne","owner":{"login":"Lasagne","id":11752110,"avatar_url":"https://avatars.githubusercontent.com/u/11752110?v=3","gravatar_id":"","url":"https://api.github.com/users/Lasagne","html_url":"https://github.com/Lasagne","followers_url":"https://api.github.com/users/Lasagne/followers","following_url":"https://api.github.com/users/Lasagne/following{/other_user}","gists_url":"https://api.github.com/users/Lasagne/gists{/gist_id}","starred_url":"https://api.github.com/users/Lasagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lasagne/subscriptions","organizations_url":"https://api.github.com/users/Lasagne/orgs","repos_url":"https://api.github.com/users/Lasagne/repos","events_url":"https://api.github.com/users/Lasagne/events{/privacy}","received_events_url":"https://api.github.com/users/Lasagne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lasagne/Lasagne","description":"neural network tools for Theano","fork":false,"url":"https://api.github.com/repos/Lasagne/Lasagne","forks_url":"https://api.github.com/repos/Lasagne/Lasagne/forks","keys_url":"https://api.github.com/repos/Lasagne/Lasagne/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lasagne/Lasagne/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lasagne/Lasagne/teams","hooks_url":"https://api.github.com/repos/Lasagne/Lasagne/hooks","issue_events_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/events{/number}","events_url":"https://api.github.com/repos/Lasagne/Lasagne/events","assignees_url":"https://api.github.com/repos/Lasagne/Lasagne/assignees{/user}","branches_url":"https://api.github.com/repos/Lasagne/Lasagne/branches{/branch}","tags_url":"https://api.github.com/repos/Lasagne/Lasagne/tags","blobs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lasagne/Lasagne/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lasagne/Lasagne/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lasagne/Lasagne/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lasagne/Lasagne/statuses/{sha}","languages_url":"https://api.github.com/repos/Lasagne/Lasagne/languages","stargazers_url":"https://api.github.com/repos/Lasagne/Lasagne/stargazers","contributors_url":"https://api.github.com/repos/Lasagne/Lasagne/contributors","subscribers_url":"https://api.github.com/repos/Lasagne/Lasagne/subscribers","subscription_url":"https://api.github.com/repos/Lasagne/Lasagne/subscription","commits_url":"https://api.github.com/repos/Lasagne/Lasagne/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lasagne/Lasagne/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lasagne/Lasagne/contents/{+path}","compare_url":"https://api.github.com/repos/Lasagne/Lasagne/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lasagne/Lasagne/merges","archive_url":"https://api.github.com/repos/Lasagne/Lasagne/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lasagne/Lasagne/downloads","issues_url":"https://api.github.com/repos/Lasagne/Lasagne/issues{/number}","pulls_url":"https://api.github.com/repos/Lasagne/Lasagne/pulls{/number}","milestones_url":"https://api.github.com/repos/Lasagne/Lasagne/milestones{/number}","notifications_url":"https://api.github.com/repos/Lasagne/Lasagne/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/labels{/name}","releases_url":"https://api.github.com/repos/Lasagne/Lasagne/releases{/id}","created_at":"2014-09-11T15:31:41Z","updated_at":"2015-05-28T09:51:18Z","pushed_at":"2015-05-28T16:24:22Z","git_url":"git://github.com/Lasagne/Lasagne.git","ssh_url":"git@github.com:Lasagne/Lasagne.git","clone_url":"https://github.com/Lasagne/Lasagne.git","svn_url":"https://github.com/Lasagne/Lasagne","homepage":"http://lasagne.readthedocs.org/","size":4486,"stargazers_count":581,"watchers_count":581,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":36,"forks":139,"open_issues":36,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267"},"html":{"href":"https://github.com/Lasagne/Lasagne/pull/267"},"issue":{"href":"https://api.github.com/repos/Lasagne/Lasagne/issues/267"},"comments":{"href":"https://api.github.com/repos/Lasagne/Lasagne/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/Lasagne/Lasagne/statuses/9af291437f1bc06f6adcea1fd16a5310c6592da2"}}}}