{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/sockets/pulls/comments/47892385","id":47892385,"diff_hunk":"@@ -29,11 +29,12 @@ class SocketAddr {\n     const struct socket_addr * getAddr() const {return &_addr;}\n     void setAddr(const struct socket_addr *addr);\n     void setAddr(const SocketAddr *addr);\n+    int setAddr(socket_address_family_t af, const char *addr);\n     size_t getAddrSize() const {return sizeof(_addr.ipv6be);}\n-    bool is_v4();\n+    bool is_v4() const;\n \n-    int fmtIPv4(char *buf, size_t size);\n-    int fmtIPv6(char *buf, size_t size);\n+    int fmtIPv4(char *buf, size_t size) const;","path":"sockets/v0/SocketAddr.h","position":11,"original_position":11,"commit_id":"7240b783b10464c36805e594cca96e48094c63dc","original_commit_id":"7240b783b10464c36805e594cca96e48094c63dc","user":{"login":"niklas-arm","id":15176141,"avatar_url":"https://avatars.githubusercontent.com/u/15176141?v=3","gravatar_id":"","url":"https://api.github.com/users/niklas-arm","html_url":"https://github.com/niklas-arm","followers_url":"https://api.github.com/users/niklas-arm/followers","following_url":"https://api.github.com/users/niklas-arm/following{/other_user}","gists_url":"https://api.github.com/users/niklas-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/niklas-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklas-arm/subscriptions","organizations_url":"https://api.github.com/users/niklas-arm/orgs","repos_url":"https://api.github.com/users/niklas-arm/repos","events_url":"https://api.github.com/users/niklas-arm/events{/privacy}","received_events_url":"https://api.github.com/users/niklas-arm/received_events","type":"User","site_admin":false},"body":"Wasn't there some more documentation ","created_at":"2015-12-17T10:51:33Z","updated_at":"2015-12-17T10:51:33Z","html_url":"https://github.com/ARMmbed/sockets/pull/43#discussion_r47892385","pull_request_url":"https://api.github.com/repos/ARMmbed/sockets/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/comments/47892385"},"html":{"href":"https://github.com/ARMmbed/sockets/pull/43#discussion_r47892385"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/sockets/pulls/43","id":53878847,"html_url":"https://github.com/ARMmbed/sockets/pull/43","diff_url":"https://github.com/ARMmbed/sockets/pull/43.diff","patch_url":"https://github.com/ARMmbed/sockets/pull/43.patch","issue_url":"https://api.github.com/repos/ARMmbed/sockets/issues/43","number":43,"state":"open","locked":false,"title":"Use the SAL’s new inet_ntop and inet_pton functions","user":{"login":"bremoran","id":2636227,"avatar_url":"https://avatars.githubusercontent.com/u/2636227?v=3","gravatar_id":"","url":"https://api.github.com/users/bremoran","html_url":"https://github.com/bremoran","followers_url":"https://api.github.com/users/bremoran/followers","following_url":"https://api.github.com/users/bremoran/following{/other_user}","gists_url":"https://api.github.com/users/bremoran/gists{/gist_id}","starred_url":"https://api.github.com/users/bremoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremoran/subscriptions","organizations_url":"https://api.github.com/users/bremoran/orgs","repos_url":"https://api.github.com/users/bremoran/repos","events_url":"https://api.github.com/users/bremoran/events{/privacy}","received_events_url":"https://api.github.com/users/bremoran/received_events","type":"User","site_admin":false},"body":"* fmtIPv6 now uses ```inet_ntop(AF_INET6)```\r\n* fmtIPv4 now uses ```inet_ntop(AF_INET)```\r\n* Added a new function: ```setAddr(socket_address_family_t af, char *)```","created_at":"2015-12-16T18:23:13Z","updated_at":"2015-12-17T10:51:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4b0c2c074c95efff299aff5387a1550423c515e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/sockets/pulls/43/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/sockets/pulls/43/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/sockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/sockets/issues/43/comments","statuses_url":"https://api.github.com/repos/ARMmbed/sockets/statuses/7240b783b10464c36805e594cca96e48094c63dc","head":{"label":"bremoran:ipfmt","ref":"ipfmt","sha":"7240b783b10464c36805e594cca96e48094c63dc","user":{"login":"bremoran","id":2636227,"avatar_url":"https://avatars.githubusercontent.com/u/2636227?v=3","gravatar_id":"","url":"https://api.github.com/users/bremoran","html_url":"https://github.com/bremoran","followers_url":"https://api.github.com/users/bremoran/followers","following_url":"https://api.github.com/users/bremoran/following{/other_user}","gists_url":"https://api.github.com/users/bremoran/gists{/gist_id}","starred_url":"https://api.github.com/users/bremoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremoran/subscriptions","organizations_url":"https://api.github.com/users/bremoran/orgs","repos_url":"https://api.github.com/users/bremoran/repos","events_url":"https://api.github.com/users/bremoran/events{/privacy}","received_events_url":"https://api.github.com/users/bremoran/received_events","type":"User","site_admin":false},"repo":{"id":44545101,"name":"sockets","full_name":"bremoran/sockets","owner":{"login":"bremoran","id":2636227,"avatar_url":"https://avatars.githubusercontent.com/u/2636227?v=3","gravatar_id":"","url":"https://api.github.com/users/bremoran","html_url":"https://github.com/bremoran","followers_url":"https://api.github.com/users/bremoran/followers","following_url":"https://api.github.com/users/bremoran/following{/other_user}","gists_url":"https://api.github.com/users/bremoran/gists{/gist_id}","starred_url":"https://api.github.com/users/bremoran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bremoran/subscriptions","organizations_url":"https://api.github.com/users/bremoran/orgs","repos_url":"https://api.github.com/users/bremoran/repos","events_url":"https://api.github.com/users/bremoran/events{/privacy}","received_events_url":"https://api.github.com/users/bremoran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bremoran/sockets","description":"mbed sockets library abstraction layer","fork":true,"url":"https://api.github.com/repos/bremoran/sockets","forks_url":"https://api.github.com/repos/bremoran/sockets/forks","keys_url":"https://api.github.com/repos/bremoran/sockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bremoran/sockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bremoran/sockets/teams","hooks_url":"https://api.github.com/repos/bremoran/sockets/hooks","issue_events_url":"https://api.github.com/repos/bremoran/sockets/issues/events{/number}","events_url":"https://api.github.com/repos/bremoran/sockets/events","assignees_url":"https://api.github.com/repos/bremoran/sockets/assignees{/user}","branches_url":"https://api.github.com/repos/bremoran/sockets/branches{/branch}","tags_url":"https://api.github.com/repos/bremoran/sockets/tags","blobs_url":"https://api.github.com/repos/bremoran/sockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bremoran/sockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bremoran/sockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/bremoran/sockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bremoran/sockets/statuses/{sha}","languages_url":"https://api.github.com/repos/bremoran/sockets/languages","stargazers_url":"https://api.github.com/repos/bremoran/sockets/stargazers","contributors_url":"https://api.github.com/repos/bremoran/sockets/contributors","subscribers_url":"https://api.github.com/repos/bremoran/sockets/subscribers","subscription_url":"https://api.github.com/repos/bremoran/sockets/subscription","commits_url":"https://api.github.com/repos/bremoran/sockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/bremoran/sockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/bremoran/sockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/bremoran/sockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/bremoran/sockets/contents/{+path}","compare_url":"https://api.github.com/repos/bremoran/sockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bremoran/sockets/merges","archive_url":"https://api.github.com/repos/bremoran/sockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bremoran/sockets/downloads","issues_url":"https://api.github.com/repos/bremoran/sockets/issues{/number}","pulls_url":"https://api.github.com/repos/bremoran/sockets/pulls{/number}","milestones_url":"https://api.github.com/repos/bremoran/sockets/milestones{/number}","notifications_url":"https://api.github.com/repos/bremoran/sockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bremoran/sockets/labels{/name}","releases_url":"https://api.github.com/repos/bremoran/sockets/releases{/id}","created_at":"2015-10-19T15:39:15Z","updated_at":"2015-10-19T15:39:16Z","pushed_at":"2015-12-16T19:19:30Z","git_url":"git://github.com/bremoran/sockets.git","ssh_url":"git@github.com:bremoran/sockets.git","clone_url":"https://github.com/bremoran/sockets.git","svn_url":"https://github.com/bremoran/sockets","homepage":null,"size":263,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"812b3ae79cf7339f721a6126c6d919825ae1fc82","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":28924121,"name":"sockets","full_name":"ARMmbed/sockets","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/sockets","description":"mbed sockets library abstraction layer","fork":false,"url":"https://api.github.com/repos/ARMmbed/sockets","forks_url":"https://api.github.com/repos/ARMmbed/sockets/forks","keys_url":"https://api.github.com/repos/ARMmbed/sockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/sockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/sockets/teams","hooks_url":"https://api.github.com/repos/ARMmbed/sockets/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/sockets/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/sockets/events","assignees_url":"https://api.github.com/repos/ARMmbed/sockets/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/sockets/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/sockets/tags","blobs_url":"https://api.github.com/repos/ARMmbed/sockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/sockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/sockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/sockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/sockets/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/sockets/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/sockets/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/sockets/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/sockets/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/sockets/subscription","commits_url":"https://api.github.com/repos/ARMmbed/sockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/sockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/sockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/sockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/sockets/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/sockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/sockets/merges","archive_url":"https://api.github.com/repos/ARMmbed/sockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/sockets/downloads","issues_url":"https://api.github.com/repos/ARMmbed/sockets/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/sockets/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/sockets/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/sockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/sockets/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/sockets/releases{/id}","created_at":"2015-01-07T16:57:58Z","updated_at":"2015-09-04T13:35:20Z","pushed_at":"2015-12-16T21:11:47Z","git_url":"git://github.com/ARMmbed/sockets.git","ssh_url":"git@github.com:ARMmbed/sockets.git","clone_url":"https://github.com/ARMmbed/sockets.git","svn_url":"https://github.com/ARMmbed/sockets","homepage":null,"size":363,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/43"},"html":{"href":"https://github.com/ARMmbed/sockets/pull/43"},"issue":{"href":"https://api.github.com/repos/ARMmbed/sockets/issues/43"},"comments":{"href":"https://api.github.com/repos/ARMmbed/sockets/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/sockets/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/sockets/statuses/7240b783b10464c36805e594cca96e48094c63dc"}}}}