{"action":"created","comment":{"url":"https://api.github.com/repos/rear/rear/pulls/comments/42353906","id":42353906,"diff_hunk":"@@ -0,0 +1,54 @@\n+# locate NovaBACKUP DC client configuration, referenced by\n+#\n+# prep/NBKDC/default/40_prep_nbkdc.sh\n+# skel/NBKDC/etc/scripts/system-setup.d/59-start-nbkdc-client.sh\n+\n+\n+# Set the NovaBACKUP DC default directory\n+NBKDC_DIR=/opt/NovaStor/DataCenter","path":"usr/share/rear/lib/nbkdc-functions.sh","position":8,"original_position":8,"commit_id":"9f9b7c3a16d4eaedd3a5ff21c145ca5d6a1f6bbf","original_commit_id":"9f9b7c3a16d4eaedd3a5ff21c145ca5d6a1f6bbf","user":{"login":"schlomo","id":101384,"avatar_url":"https://avatars.githubusercontent.com/u/101384?v=3","gravatar_id":"","url":"https://api.github.com/users/schlomo","html_url":"https://github.com/schlomo","followers_url":"https://api.github.com/users/schlomo/followers","following_url":"https://api.github.com/users/schlomo/following{/other_user}","gists_url":"https://api.github.com/users/schlomo/gists{/gist_id}","starred_url":"https://api.github.com/users/schlomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schlomo/subscriptions","organizations_url":"https://api.github.com/users/schlomo/orgs","repos_url":"https://api.github.com/users/schlomo/repos","events_url":"https://api.github.com/users/schlomo/events{/privacy}","received_events_url":"https://api.github.com/users/schlomo/received_events","type":"User","site_admin":false},"body":"In that case I suggest to restructure your code so that during mkrescue it will do all the discovery and that in the rescue system everything is already set. Simply generate the required scripts in the rescue system. It can also be a good idea to generate some kind of a `nbkdc_settings.sh` somewhere that contains all the paths and other stuff that you found out during mkrescue. Then all other scripts can simply source that and you are done. The result is a single point of configuration that is much easier to debug than having autodiscovery everwhere.","created_at":"2015-10-19T09:59:31Z","updated_at":"2015-10-19T09:59:31Z","html_url":"https://github.com/rear/rear/pull/669#discussion_r42353906","pull_request_url":"https://api.github.com/repos/rear/rear/pulls/669","_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/comments/42353906"},"html":{"href":"https://github.com/rear/rear/pull/669#discussion_r42353906"},"pull_request":{"href":"https://api.github.com/repos/rear/rear/pulls/669"}}},"pull_request":{"url":"https://api.github.com/repos/rear/rear/pulls/669","id":47899652,"html_url":"https://github.com/rear/rear/pull/669","diff_url":"https://github.com/rear/rear/pull/669.diff","patch_url":"https://github.com/rear/rear/pull/669.patch","issue_url":"https://api.github.com/repos/rear/rear/issues/669","number":669,"state":"open","locked":false,"title":"Add new NBKDC backup method","user":{"login":"andyvb070","id":15103138,"avatar_url":"https://avatars.githubusercontent.com/u/15103138?v=3","gravatar_id":"","url":"https://api.github.com/users/andyvb070","html_url":"https://github.com/andyvb070","followers_url":"https://api.github.com/users/andyvb070/followers","following_url":"https://api.github.com/users/andyvb070/following{/other_user}","gists_url":"https://api.github.com/users/andyvb070/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvb070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvb070/subscriptions","organizations_url":"https://api.github.com/users/andyvb070/orgs","repos_url":"https://api.github.com/users/andyvb070/repos","events_url":"https://api.github.com/users/andyvb070/events{/privacy}","received_events_url":"https://api.github.com/users/andyvb070/received_events","type":"User","site_admin":false},"body":"A new support for a 3rd party backup tool\r\nReaR will not trigger the actual backup, it gets triggered and done by the backup program\r\n\r\nIntegrated the support for the backup program into the recovery image","created_at":"2015-10-16T11:35:23Z","updated_at":"2015-10-19T09:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbf69ba86be0b72569217a0e1cfbf34eb1d6b068","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rear/rear/pulls/669/commits","review_comments_url":"https://api.github.com/repos/rear/rear/pulls/669/comments","review_comment_url":"https://api.github.com/repos/rear/rear/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rear/rear/issues/669/comments","statuses_url":"https://api.github.com/repos/rear/rear/statuses/9f9b7c3a16d4eaedd3a5ff21c145ca5d6a1f6bbf","head":{"label":"andyvb070:add-new-backup-method","ref":"add-new-backup-method","sha":"9f9b7c3a16d4eaedd3a5ff21c145ca5d6a1f6bbf","user":{"login":"andyvb070","id":15103138,"avatar_url":"https://avatars.githubusercontent.com/u/15103138?v=3","gravatar_id":"","url":"https://api.github.com/users/andyvb070","html_url":"https://github.com/andyvb070","followers_url":"https://api.github.com/users/andyvb070/followers","following_url":"https://api.github.com/users/andyvb070/following{/other_user}","gists_url":"https://api.github.com/users/andyvb070/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvb070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvb070/subscriptions","organizations_url":"https://api.github.com/users/andyvb070/orgs","repos_url":"https://api.github.com/users/andyvb070/repos","events_url":"https://api.github.com/users/andyvb070/events{/privacy}","received_events_url":"https://api.github.com/users/andyvb070/received_events","type":"User","site_admin":false},"repo":{"id":44166226,"name":"rear","full_name":"andyvb070/rear","owner":{"login":"andyvb070","id":15103138,"avatar_url":"https://avatars.githubusercontent.com/u/15103138?v=3","gravatar_id":"","url":"https://api.github.com/users/andyvb070","html_url":"https://github.com/andyvb070","followers_url":"https://api.github.com/users/andyvb070/followers","following_url":"https://api.github.com/users/andyvb070/following{/other_user}","gists_url":"https://api.github.com/users/andyvb070/gists{/gist_id}","starred_url":"https://api.github.com/users/andyvb070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyvb070/subscriptions","organizations_url":"https://api.github.com/users/andyvb070/orgs","repos_url":"https://api.github.com/users/andyvb070/repos","events_url":"https://api.github.com/users/andyvb070/events{/privacy}","received_events_url":"https://api.github.com/users/andyvb070/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyvb070/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":true,"url":"https://api.github.com/repos/andyvb070/rear","forks_url":"https://api.github.com/repos/andyvb070/rear/forks","keys_url":"https://api.github.com/repos/andyvb070/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyvb070/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyvb070/rear/teams","hooks_url":"https://api.github.com/repos/andyvb070/rear/hooks","issue_events_url":"https://api.github.com/repos/andyvb070/rear/issues/events{/number}","events_url":"https://api.github.com/repos/andyvb070/rear/events","assignees_url":"https://api.github.com/repos/andyvb070/rear/assignees{/user}","branches_url":"https://api.github.com/repos/andyvb070/rear/branches{/branch}","tags_url":"https://api.github.com/repos/andyvb070/rear/tags","blobs_url":"https://api.github.com/repos/andyvb070/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyvb070/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyvb070/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyvb070/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyvb070/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/andyvb070/rear/languages","stargazers_url":"https://api.github.com/repos/andyvb070/rear/stargazers","contributors_url":"https://api.github.com/repos/andyvb070/rear/contributors","subscribers_url":"https://api.github.com/repos/andyvb070/rear/subscribers","subscription_url":"https://api.github.com/repos/andyvb070/rear/subscription","commits_url":"https://api.github.com/repos/andyvb070/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyvb070/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyvb070/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyvb070/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyvb070/rear/contents/{+path}","compare_url":"https://api.github.com/repos/andyvb070/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyvb070/rear/merges","archive_url":"https://api.github.com/repos/andyvb070/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyvb070/rear/downloads","issues_url":"https://api.github.com/repos/andyvb070/rear/issues{/number}","pulls_url":"https://api.github.com/repos/andyvb070/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/andyvb070/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/andyvb070/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyvb070/rear/labels{/name}","releases_url":"https://api.github.com/repos/andyvb070/rear/releases{/id}","created_at":"2015-10-13T09:34:22Z","updated_at":"2015-10-13T09:34:24Z","pushed_at":"2015-10-16T10:15:22Z","git_url":"git://github.com/andyvb070/rear.git","ssh_url":"git@github.com:andyvb070/rear.git","clone_url":"https://github.com/andyvb070/rear.git","svn_url":"https://github.com/andyvb070/rear","homepage":"http://relax-and-recover.org/","size":3623,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rear:master","ref":"master","sha":"e2c96392fd3c87e96301cf660b02147ff54c1281","user":{"login":"rear","id":1389578,"avatar_url":"https://avatars.githubusercontent.com/u/1389578?v=3","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"repo":{"id":3449791,"name":"rear","full_name":"rear/rear","owner":{"login":"rear","id":1389578,"avatar_url":"https://avatars.githubusercontent.com/u/1389578?v=3","gravatar_id":"","url":"https://api.github.com/users/rear","html_url":"https://github.com/rear","followers_url":"https://api.github.com/users/rear/followers","following_url":"https://api.github.com/users/rear/following{/other_user}","gists_url":"https://api.github.com/users/rear/gists{/gist_id}","starred_url":"https://api.github.com/users/rear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rear/subscriptions","organizations_url":"https://api.github.com/users/rear/orgs","repos_url":"https://api.github.com/users/rear/repos","events_url":"https://api.github.com/users/rear/events{/privacy}","received_events_url":"https://api.github.com/users/rear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rear/rear","description":"Relax-and-Recover - Linux bare metal disaster recovery and system migration solution (cfr. mksysb, ignite)","fork":false,"url":"https://api.github.com/repos/rear/rear","forks_url":"https://api.github.com/repos/rear/rear/forks","keys_url":"https://api.github.com/repos/rear/rear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rear/rear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rear/rear/teams","hooks_url":"https://api.github.com/repos/rear/rear/hooks","issue_events_url":"https://api.github.com/repos/rear/rear/issues/events{/number}","events_url":"https://api.github.com/repos/rear/rear/events","assignees_url":"https://api.github.com/repos/rear/rear/assignees{/user}","branches_url":"https://api.github.com/repos/rear/rear/branches{/branch}","tags_url":"https://api.github.com/repos/rear/rear/tags","blobs_url":"https://api.github.com/repos/rear/rear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rear/rear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rear/rear/git/refs{/sha}","trees_url":"https://api.github.com/repos/rear/rear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rear/rear/statuses/{sha}","languages_url":"https://api.github.com/repos/rear/rear/languages","stargazers_url":"https://api.github.com/repos/rear/rear/stargazers","contributors_url":"https://api.github.com/repos/rear/rear/contributors","subscribers_url":"https://api.github.com/repos/rear/rear/subscribers","subscription_url":"https://api.github.com/repos/rear/rear/subscription","commits_url":"https://api.github.com/repos/rear/rear/commits{/sha}","git_commits_url":"https://api.github.com/repos/rear/rear/git/commits{/sha}","comments_url":"https://api.github.com/repos/rear/rear/comments{/number}","issue_comment_url":"https://api.github.com/repos/rear/rear/issues/comments{/number}","contents_url":"https://api.github.com/repos/rear/rear/contents/{+path}","compare_url":"https://api.github.com/repos/rear/rear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rear/rear/merges","archive_url":"https://api.github.com/repos/rear/rear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rear/rear/downloads","issues_url":"https://api.github.com/repos/rear/rear/issues{/number}","pulls_url":"https://api.github.com/repos/rear/rear/pulls{/number}","milestones_url":"https://api.github.com/repos/rear/rear/milestones{/number}","notifications_url":"https://api.github.com/repos/rear/rear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rear/rear/labels{/name}","releases_url":"https://api.github.com/repos/rear/rear/releases{/id}","created_at":"2012-02-15T13:44:45Z","updated_at":"2015-10-16T22:28:39Z","pushed_at":"2015-10-16T11:35:23Z","git_url":"git://github.com/rear/rear.git","ssh_url":"git@github.com:rear/rear.git","clone_url":"https://github.com/rear/rear.git","svn_url":"https://github.com/rear/rear","homepage":"http://relax-and-recover.org/","size":5534,"stargazers_count":103,"watchers_count":103,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":82,"forks":73,"open_issues":82,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rear/rear/pulls/669"},"html":{"href":"https://github.com/rear/rear/pull/669"},"issue":{"href":"https://api.github.com/repos/rear/rear/issues/669"},"comments":{"href":"https://api.github.com/repos/rear/rear/issues/669/comments"},"review_comments":{"href":"https://api.github.com/repos/rear/rear/pulls/669/comments"},"review_comment":{"href":"https://api.github.com/repos/rear/rear/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rear/rear/pulls/669/commits"},"statuses":{"href":"https://api.github.com/repos/rear/rear/statuses/9f9b7c3a16d4eaedd3a5ff21c145ca5d6a1f6bbf"}}}}