{"action":"opened","number":798,"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798","id":49337545,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/798","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/798.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/798.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/798","number":798,"state":"open","locked":false,"title":"ensure all nodes are exited on dealloc","user":{"login":"eanagel","id":842898,"avatar_url":"https://avatars.githubusercontent.com/u/842898?v=3","gravatar_id":"","url":"https://api.github.com/users/eanagel","html_url":"https://github.com/eanagel","followers_url":"https://api.github.com/users/eanagel/followers","following_url":"https://api.github.com/users/eanagel/following{/other_user}","gists_url":"https://api.github.com/users/eanagel/gists{/gist_id}","starred_url":"https://api.github.com/users/eanagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eanagel/subscriptions","organizations_url":"https://api.github.com/users/eanagel/orgs","repos_url":"https://api.github.com/users/eanagel/repos","events_url":"https://api.github.com/users/eanagel/events{/privacy}","received_events_url":"https://api.github.com/users/eanagel/received_events","type":"User","site_admin":false},"body":"This is a short-term fix for #797 and #791 suggested by @appleguy. I'm using a tweaked build of 1.2.3 and this seems to be working well for me. It clears any ASCellNodes that were in the Render state when the ASRangeController is dealloced (ultimately.) It is still possible for ASCellNodes to \"leak\" temporarily while the ASRangeController is alive. The good news is that this code will make sure it is cleaned up when the parent ASTable/CollectionView is dealloced.\r\n\r\nI haven't tested this on master though (I'm not really set up for that at the moment), can someone give it a spin and make sure it plays well with all the amazing code in 1.9+?","created_at":"2015-10-31T00:58:16Z","updated_at":"2015-10-31T00:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/798/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/f5d0baf7ef4d7f63b3c47b27d255142a943ab685","head":{"label":"eanagel:asrange-render-retains","ref":"asrange-render-retains","sha":"f5d0baf7ef4d7f63b3c47b27d255142a943ab685","user":{"login":"eanagel","id":842898,"avatar_url":"https://avatars.githubusercontent.com/u/842898?v=3","gravatar_id":"","url":"https://api.github.com/users/eanagel","html_url":"https://github.com/eanagel","followers_url":"https://api.github.com/users/eanagel/followers","following_url":"https://api.github.com/users/eanagel/following{/other_user}","gists_url":"https://api.github.com/users/eanagel/gists{/gist_id}","starred_url":"https://api.github.com/users/eanagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eanagel/subscriptions","organizations_url":"https://api.github.com/users/eanagel/orgs","repos_url":"https://api.github.com/users/eanagel/repos","events_url":"https://api.github.com/users/eanagel/events{/privacy}","received_events_url":"https://api.github.com/users/eanagel/received_events","type":"User","site_admin":false},"repo":{"id":32956703,"name":"AsyncDisplayKit","full_name":"eanagel/AsyncDisplayKit","owner":{"login":"eanagel","id":842898,"avatar_url":"https://avatars.githubusercontent.com/u/842898?v=3","gravatar_id":"","url":"https://api.github.com/users/eanagel","html_url":"https://github.com/eanagel","followers_url":"https://api.github.com/users/eanagel/followers","following_url":"https://api.github.com/users/eanagel/following{/other_user}","gists_url":"https://api.github.com/users/eanagel/gists{/gist_id}","starred_url":"https://api.github.com/users/eanagel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eanagel/subscriptions","organizations_url":"https://api.github.com/users/eanagel/orgs","repos_url":"https://api.github.com/users/eanagel/repos","events_url":"https://api.github.com/users/eanagel/events{/privacy}","received_events_url":"https://api.github.com/users/eanagel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eanagel/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/eanagel/AsyncDisplayKit","forks_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/eanagel/AsyncDisplayKit/releases{/id}","created_at":"2015-03-26T23:09:30Z","updated_at":"2015-05-05T16:31:21Z","pushed_at":"2015-10-31T00:53:13Z","git_url":"git://github.com/eanagel/AsyncDisplayKit.git","ssh_url":"git@github.com:eanagel/AsyncDisplayKit.git","clone_url":"https://github.com/eanagel/AsyncDisplayKit.git","svn_url":"https://github.com/eanagel/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":3285,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"ed6357737065d45a262efa28c739e4811feaf9f5","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","created_at":"2014-06-27T05:29:02Z","updated_at":"2015-10-30T23:23:53Z","pushed_at":"2015-10-30T03:39:46Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":9426,"stargazers_count":5970,"watchers_count":5970,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":820,"mirror_url":null,"open_issues_count":111,"forks":820,"open_issues":111,"watchers":5970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/798"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/798"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/f5d0baf7ef4d7f63b3c47b27d255142a943ab685"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":33,"deletions":14,"changed_files":1}}