{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/43632329","id":43632329,"diff_hunk":"@@ -547,6 +563,11 @@ func (c *controller) Sandboxes() []Sandbox {\n \n \tlist := make([]Sandbox, 0, len(c.sandboxes))\n \tfor _, s := range c.sandboxes {\n+\t\t// Hide stub sandboxes from libnetwork users\n+\t\tif s.isStub {\n+\t\t\tcontinue\n+\t\t}","path":"controller.go","position":67,"original_position":57,"commit_id":"be9df17fcef2a2c21ddded8e38f944c0356ddacc","original_commit_id":"1356c2707a2b1610a1631647809028f7e3df04bb","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"okay. thanks. I understand the issue better now.","created_at":"2015-11-02T14:24:00Z","updated_at":"2015-11-02T14:24:00Z","html_url":"https://github.com/docker/libnetwork/pull/729#discussion_r43632329","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/729","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/43632329"},"html":{"href":"https://github.com/docker/libnetwork/pull/729#discussion_r43632329"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/729"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/729","id":49400885,"html_url":"https://github.com/docker/libnetwork/pull/729","diff_url":"https://github.com/docker/libnetwork/pull/729.diff","patch_url":"https://github.com/docker/libnetwork/pull/729.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/729","number":729,"state":"open","locked":false,"title":"Fix stale sandbox from store problem","user":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"body":"At times, when checkpointed sandbox from store cannot be\r\ncleaned up properly we still retain the sandbox in both\r\nthe store and in memory. But this sandbox may not\r\ncontain important configuration information from docker.\r\nSo when docker requests a new sandbox, instead of using\r\nit as is, reconcile the sandbox state from store with the\r\nthe configuration information provided by docker. To do this\r\nmark the sandbox from store as stub and never reveal it to\r\nexternal searches. When docker requests a new sandbox, update\r\nthe stub sandbox and clear the stub flag.\r\n\r\nSigned-off-by: Jana Radhakrishnan <mrjana@docker.com>","created_at":"2015-11-02T07:11:17Z","updated_at":"2015-11-02T14:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"611c34b352f43711cf4d09b4f683c452bc8673ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/729/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/729/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/729/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/be9df17fcef2a2c21ddded8e38f944c0356ddacc","head":{"label":"mrjana:bugs","ref":"bugs","sha":"be9df17fcef2a2c21ddded8e38f944c0356ddacc","user":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"repo":{"id":33910102,"name":"libnetwork","full_name":"mrjana/libnetwork","owner":{"login":"mrjana","id":1693482,"avatar_url":"https://avatars.githubusercontent.com/u/1693482?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjana","html_url":"https://github.com/mrjana","followers_url":"https://api.github.com/users/mrjana/followers","following_url":"https://api.github.com/users/mrjana/following{/other_user}","gists_url":"https://api.github.com/users/mrjana/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjana/subscriptions","organizations_url":"https://api.github.com/users/mrjana/orgs","repos_url":"https://api.github.com/users/mrjana/repos","events_url":"https://api.github.com/users/mrjana/events{/privacy}","received_events_url":"https://api.github.com/users/mrjana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrjana/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/mrjana/libnetwork","forks_url":"https://api.github.com/repos/mrjana/libnetwork/forks","keys_url":"https://api.github.com/repos/mrjana/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrjana/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrjana/libnetwork/teams","hooks_url":"https://api.github.com/repos/mrjana/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/mrjana/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/mrjana/libnetwork/events","assignees_url":"https://api.github.com/repos/mrjana/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/mrjana/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/mrjana/libnetwork/tags","blobs_url":"https://api.github.com/repos/mrjana/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrjana/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrjana/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrjana/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrjana/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/mrjana/libnetwork/languages","stargazers_url":"https://api.github.com/repos/mrjana/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/mrjana/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/mrjana/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/mrjana/libnetwork/subscription","commits_url":"https://api.github.com/repos/mrjana/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrjana/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrjana/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrjana/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrjana/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/mrjana/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrjana/libnetwork/merges","archive_url":"https://api.github.com/repos/mrjana/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrjana/libnetwork/downloads","issues_url":"https://api.github.com/repos/mrjana/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/mrjana/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/mrjana/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/mrjana/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrjana/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/mrjana/libnetwork/releases{/id}","created_at":"2015-04-14T04:08:13Z","updated_at":"2015-04-17T04:44:34Z","pushed_at":"2015-11-02T08:39:06Z","git_url":"git://github.com/mrjana/libnetwork.git","ssh_url":"git@github.com:mrjana/libnetwork.git","clone_url":"https://github.com/mrjana/libnetwork.git","svn_url":"https://github.com/mrjana/libnetwork","homepage":"","size":6851,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"05a5a1510f85977f374a9b9804a116391bab5089","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2015-11-02T02:49:23Z","pushed_at":"2015-11-02T08:39:07Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":10767,"stargazers_count":483,"watchers_count":483,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":108,"forks":187,"open_issues":108,"watchers":483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/729"},"html":{"href":"https://github.com/docker/libnetwork/pull/729"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/729"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/729/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/729/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/729/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/be9df17fcef2a2c21ddded8e38f944c0356ddacc"}}}}