{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/46754124","id":46754124,"diff_hunk":"@@ -2036,7 +2036,10 @@ const ToolChain *Driver::getToolChain(const ArgList &Args) const {\n       TC = new toolchains::Darwin(*this, Target);\n       break;\n     case llvm::Triple::Linux:\n-      TC = new toolchains::Linux(*this, Target);\n+      TC = new toolchains::GenericUnix(*this, Target);\n+      break;\n+    case llvm::Triple::FreeBSD:","path":"lib/Driver/Driver.cpp","position":7,"original_position":7,"commit_id":"c4daece7cedf57eb2a2a60937c3cc93d19fe7912","original_commit_id":"c4daece7cedf57eb2a2a60937c3cc93d19fe7912","user":{"login":"archshift","id":5377832,"avatar_url":"https://avatars.githubusercontent.com/u/5377832?v=3","gravatar_id":"","url":"https://api.github.com/users/archshift","html_url":"https://github.com/archshift","followers_url":"https://api.github.com/users/archshift/followers","following_url":"https://api.github.com/users/archshift/following{/other_user}","gists_url":"https://api.github.com/users/archshift/gists{/gist_id}","starred_url":"https://api.github.com/users/archshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archshift/subscriptions","organizations_url":"https://api.github.com/users/archshift/orgs","repos_url":"https://api.github.com/users/archshift/repos","events_url":"https://api.github.com/users/archshift/events{/privacy}","received_events_url":"https://api.github.com/users/archshift/received_events","type":"User","site_admin":false},"body":"Why not just let this fall through instead of duplicating code?","created_at":"2015-12-05T05:02:23Z","updated_at":"2015-12-05T05:02:23Z","html_url":"https://github.com/apple/swift/pull/203#discussion_r46754124","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/203","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/46754124"},"html":{"href":"https://github.com/apple/swift/pull/203#discussion_r46754124"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/203","id":52711066,"html_url":"https://github.com/apple/swift/pull/203","diff_url":"https://github.com/apple/swift/pull/203.diff","patch_url":"https://github.com/apple/swift/pull/203.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/203","number":203,"state":"open","locked":false,"title":"Partial FreeBSD Support","user":{"login":"landonf","id":18884,"avatar_url":"https://avatars.githubusercontent.com/u/18884?v=3","gravatar_id":"","url":"https://api.github.com/users/landonf","html_url":"https://github.com/landonf","followers_url":"https://api.github.com/users/landonf/followers","following_url":"https://api.github.com/users/landonf/following{/other_user}","gists_url":"https://api.github.com/users/landonf/gists{/gist_id}","starred_url":"https://api.github.com/users/landonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonf/subscriptions","organizations_url":"https://api.github.com/users/landonf/orgs","repos_url":"https://api.github.com/users/landonf/repos","events_url":"https://api.github.com/users/landonf/events{/privacy}","received_events_url":"https://api.github.com/users/landonf/received_events","type":"User","site_admin":false},"body":"This provides a non-controversial baseline for FreeBSD support.\r\n\r\nAdditional work will be required for the full port, but with this initial work -- plus local work-arounds for linker script behavior and use of pkg-installed libc++ -- I'm able to successfully compete a full Swift build on FreeBSD 10.x.","created_at":"2015-12-04T19:33:27Z","updated_at":"2015-12-05T05:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21371c7ab272ac7b7cd0028830fc86030358db5c","assignee":{"login":"gribozavr","id":1120569,"avatar_url":"https://avatars.githubusercontent.com/u/1120569?v=3","gravatar_id":"","url":"https://api.github.com/users/gribozavr","html_url":"https://github.com/gribozavr","followers_url":"https://api.github.com/users/gribozavr/followers","following_url":"https://api.github.com/users/gribozavr/following{/other_user}","gists_url":"https://api.github.com/users/gribozavr/gists{/gist_id}","starred_url":"https://api.github.com/users/gribozavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gribozavr/subscriptions","organizations_url":"https://api.github.com/users/gribozavr/orgs","repos_url":"https://api.github.com/users/gribozavr/repos","events_url":"https://api.github.com/users/gribozavr/events{/privacy}","received_events_url":"https://api.github.com/users/gribozavr/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/203/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/203/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/203/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/c4daece7cedf57eb2a2a60937c3cc93d19fe7912","head":{"label":"landonf:landonf/freebsd-patchset-1","ref":"landonf/freebsd-patchset-1","sha":"c4daece7cedf57eb2a2a60937c3cc93d19fe7912","user":{"login":"landonf","id":18884,"avatar_url":"https://avatars.githubusercontent.com/u/18884?v=3","gravatar_id":"","url":"https://api.github.com/users/landonf","html_url":"https://github.com/landonf","followers_url":"https://api.github.com/users/landonf/followers","following_url":"https://api.github.com/users/landonf/following{/other_user}","gists_url":"https://api.github.com/users/landonf/gists{/gist_id}","starred_url":"https://api.github.com/users/landonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonf/subscriptions","organizations_url":"https://api.github.com/users/landonf/orgs","repos_url":"https://api.github.com/users/landonf/repos","events_url":"https://api.github.com/users/landonf/events{/privacy}","received_events_url":"https://api.github.com/users/landonf/received_events","type":"User","site_admin":false},"repo":{"id":47379408,"name":"swift-freebsd","full_name":"landonf/swift-freebsd","owner":{"login":"landonf","id":18884,"avatar_url":"https://avatars.githubusercontent.com/u/18884?v=3","gravatar_id":"","url":"https://api.github.com/users/landonf","html_url":"https://github.com/landonf","followers_url":"https://api.github.com/users/landonf/followers","following_url":"https://api.github.com/users/landonf/following{/other_user}","gists_url":"https://api.github.com/users/landonf/gists{/gist_id}","starred_url":"https://api.github.com/users/landonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonf/subscriptions","organizations_url":"https://api.github.com/users/landonf/orgs","repos_url":"https://api.github.com/users/landonf/repos","events_url":"https://api.github.com/users/landonf/events{/privacy}","received_events_url":"https://api.github.com/users/landonf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/landonf/swift-freebsd","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/landonf/swift-freebsd","forks_url":"https://api.github.com/repos/landonf/swift-freebsd/forks","keys_url":"https://api.github.com/repos/landonf/swift-freebsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/landonf/swift-freebsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/landonf/swift-freebsd/teams","hooks_url":"https://api.github.com/repos/landonf/swift-freebsd/hooks","issue_events_url":"https://api.github.com/repos/landonf/swift-freebsd/issues/events{/number}","events_url":"https://api.github.com/repos/landonf/swift-freebsd/events","assignees_url":"https://api.github.com/repos/landonf/swift-freebsd/assignees{/user}","branches_url":"https://api.github.com/repos/landonf/swift-freebsd/branches{/branch}","tags_url":"https://api.github.com/repos/landonf/swift-freebsd/tags","blobs_url":"https://api.github.com/repos/landonf/swift-freebsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/landonf/swift-freebsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/landonf/swift-freebsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/landonf/swift-freebsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/landonf/swift-freebsd/statuses/{sha}","languages_url":"https://api.github.com/repos/landonf/swift-freebsd/languages","stargazers_url":"https://api.github.com/repos/landonf/swift-freebsd/stargazers","contributors_url":"https://api.github.com/repos/landonf/swift-freebsd/contributors","subscribers_url":"https://api.github.com/repos/landonf/swift-freebsd/subscribers","subscription_url":"https://api.github.com/repos/landonf/swift-freebsd/subscription","commits_url":"https://api.github.com/repos/landonf/swift-freebsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/landonf/swift-freebsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/landonf/swift-freebsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/landonf/swift-freebsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/landonf/swift-freebsd/contents/{+path}","compare_url":"https://api.github.com/repos/landonf/swift-freebsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/landonf/swift-freebsd/merges","archive_url":"https://api.github.com/repos/landonf/swift-freebsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/landonf/swift-freebsd/downloads","issues_url":"https://api.github.com/repos/landonf/swift-freebsd/issues{/number}","pulls_url":"https://api.github.com/repos/landonf/swift-freebsd/pulls{/number}","milestones_url":"https://api.github.com/repos/landonf/swift-freebsd/milestones{/number}","notifications_url":"https://api.github.com/repos/landonf/swift-freebsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/landonf/swift-freebsd/labels{/name}","releases_url":"https://api.github.com/repos/landonf/swift-freebsd/releases{/id}","created_at":"2015-12-04T03:45:04Z","updated_at":"2015-12-05T01:11:09Z","pushed_at":"2015-12-05T03:24:51Z","git_url":"git://github.com/landonf/swift-freebsd.git","ssh_url":"git@github.com:landonf/swift-freebsd.git","clone_url":"https://github.com/landonf/swift-freebsd.git","svn_url":"https://github.com/landonf/swift-freebsd","homepage":"","size":57600,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":15,"default_branch":"landonf/freebsd"}},"base":{"label":"apple:master","ref":"master","sha":"09fdd4cfaadf87dd969570b374d5d1f7dae0bee6","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","created_at":"2015-10-23T21:15:07Z","updated_at":"2015-12-05T05:02:17Z","pushed_at":"2015-12-05T04:43:42Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"","size":70458,"stargazers_count":17404,"watchers_count":17404,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1890,"mirror_url":null,"open_issues_count":45,"forks":1890,"open_issues":45,"watchers":17404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/203"},"html":{"href":"https://github.com/apple/swift/pull/203"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/203"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/c4daece7cedf57eb2a2a60937c3cc93d19fe7912"}}}}