{"action":"created","comment":{"url":"https://api.github.com/repos/twall/jna/pulls/comments/29325841","id":29325841,"diff_hunk":"@@ -1758,13 +1758,14 @@ public EnumKey(HKEY hKey, int dwIndex) {\n \t * @return A environment block\n \t */\n \tpublic static String getEnvironmentBlock(Map<String, String> environment) {\n-\t\tStringBuilder out = new StringBuilder();\n+\t\tStringBuilder out = new StringBuilder(environment.size() * 32 /* some guess about average name=value length*/);\n \t\tfor (Entry<String, String> entry : environment.entrySet()) {\n-\t\t\tif (entry.getValue() != null) {\n-\t\t\t\tout.append(entry.getKey() + \"=\" + entry.getValue() + \"\\0\");\n+\t\t    String    key=entry.getKey(), value=entry.getValue();","path":"contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java","position":9,"original_position":9,"commit_id":"054394a39dfd6695644638227d0f19d6a2d82c92","original_commit_id":"054394a39dfd6695644638227d0f19d6a2d82c92","user":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"body":"This has been the style of changes I submitted in the past and no one remarked about it. I have taken notice and will make an effort to have future submissions adhere to this style. As far as **this** submission goes, I would ask that you accept this change as-is, since back-formatting all the code I wrote with the spaces around the assignment operator would be tedious (I know Eclipse has a formatting option but I am afraid that other formatting issues will appear that may not be the way you like it - unless you can send me the **exact** configuration file for the Eclipse style).","created_at":"2015-04-29T10:55:10Z","updated_at":"2015-04-29T10:55:10Z","html_url":"https://github.com/twall/jna/pull/434#discussion_r29325841","pull_request_url":"https://api.github.com/repos/twall/jna/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/twall/jna/pulls/comments/29325841"},"html":{"href":"https://github.com/twall/jna/pull/434#discussion_r29325841"},"pull_request":{"href":"https://api.github.com/repos/twall/jna/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/twall/jna/pulls/434","id":34258909,"html_url":"https://github.com/twall/jna/pull/434","diff_url":"https://github.com/twall/jna/pull/434.diff","patch_url":"https://github.com/twall/jna/pull/434.patch","issue_url":"https://api.github.com/repos/twall/jna/issues/434","number":434,"state":"open","locked":false,"title":"Added GetEnvironmentStrings to 'com.sun.jna.platform.win32.Kernel32'","user":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"body":"Including code to parse the resulting _Pointer_ in _Kernel32Utils_ (wait a moment for the _CHANGES.md_ - the chicken and egg issue...)","created_at":"2015-04-28T11:55:26Z","updated_at":"2015-04-29T10:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e1f46853ef43187d6ea8f6601c3c92ff22ebe3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twall/jna/pulls/434/commits","review_comments_url":"https://api.github.com/repos/twall/jna/pulls/434/comments","review_comment_url":"https://api.github.com/repos/twall/jna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twall/jna/issues/434/comments","statuses_url":"https://api.github.com/repos/twall/jna/statuses/054394a39dfd6695644638227d0f19d6a2d82c92","head":{"label":"lgoldstein:env-vars-pull-request","ref":"env-vars-pull-request","sha":"054394a39dfd6695644638227d0f19d6a2d82c92","user":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"repo":{"id":34726840,"name":"jna","full_name":"lgoldstein/jna","owner":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgoldstein/jna","description":"Java Native Access","fork":true,"url":"https://api.github.com/repos/lgoldstein/jna","forks_url":"https://api.github.com/repos/lgoldstein/jna/forks","keys_url":"https://api.github.com/repos/lgoldstein/jna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgoldstein/jna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgoldstein/jna/teams","hooks_url":"https://api.github.com/repos/lgoldstein/jna/hooks","issue_events_url":"https://api.github.com/repos/lgoldstein/jna/issues/events{/number}","events_url":"https://api.github.com/repos/lgoldstein/jna/events","assignees_url":"https://api.github.com/repos/lgoldstein/jna/assignees{/user}","branches_url":"https://api.github.com/repos/lgoldstein/jna/branches{/branch}","tags_url":"https://api.github.com/repos/lgoldstein/jna/tags","blobs_url":"https://api.github.com/repos/lgoldstein/jna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgoldstein/jna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgoldstein/jna/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgoldstein/jna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgoldstein/jna/statuses/{sha}","languages_url":"https://api.github.com/repos/lgoldstein/jna/languages","stargazers_url":"https://api.github.com/repos/lgoldstein/jna/stargazers","contributors_url":"https://api.github.com/repos/lgoldstein/jna/contributors","subscribers_url":"https://api.github.com/repos/lgoldstein/jna/subscribers","subscription_url":"https://api.github.com/repos/lgoldstein/jna/subscription","commits_url":"https://api.github.com/repos/lgoldstein/jna/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgoldstein/jna/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgoldstein/jna/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgoldstein/jna/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgoldstein/jna/contents/{+path}","compare_url":"https://api.github.com/repos/lgoldstein/jna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgoldstein/jna/merges","archive_url":"https://api.github.com/repos/lgoldstein/jna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgoldstein/jna/downloads","issues_url":"https://api.github.com/repos/lgoldstein/jna/issues{/number}","pulls_url":"https://api.github.com/repos/lgoldstein/jna/pulls{/number}","milestones_url":"https://api.github.com/repos/lgoldstein/jna/milestones{/number}","notifications_url":"https://api.github.com/repos/lgoldstein/jna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgoldstein/jna/labels{/name}","releases_url":"https://api.github.com/repos/lgoldstein/jna/releases{/id}","created_at":"2015-04-28T11:34:11Z","updated_at":"2015-04-28T11:34:14Z","pushed_at":"2015-04-28T12:15:58Z","git_url":"git://github.com/lgoldstein/jna.git","ssh_url":"git@github.com:lgoldstein/jna.git","clone_url":"https://github.com/lgoldstein/jna.git","svn_url":"https://github.com/lgoldstein/jna","homepage":"","size":224058,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twall:master","ref":"master","sha":"68db993ca1d20e2ba5997b1d9bd7aae4bff181e9","user":{"login":"twall","id":756909,"avatar_url":"https://avatars.githubusercontent.com/u/756909?v=3","gravatar_id":"","url":"https://api.github.com/users/twall","html_url":"https://github.com/twall","followers_url":"https://api.github.com/users/twall/followers","following_url":"https://api.github.com/users/twall/following{/other_user}","gists_url":"https://api.github.com/users/twall/gists{/gist_id}","starred_url":"https://api.github.com/users/twall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twall/subscriptions","organizations_url":"https://api.github.com/users/twall/orgs","repos_url":"https://api.github.com/users/twall/repos","events_url":"https://api.github.com/users/twall/events{/privacy}","received_events_url":"https://api.github.com/users/twall/received_events","type":"User","site_admin":false},"repo":{"id":1680733,"name":"jna","full_name":"twall/jna","owner":{"login":"twall","id":756909,"avatar_url":"https://avatars.githubusercontent.com/u/756909?v=3","gravatar_id":"","url":"https://api.github.com/users/twall","html_url":"https://github.com/twall","followers_url":"https://api.github.com/users/twall/followers","following_url":"https://api.github.com/users/twall/following{/other_user}","gists_url":"https://api.github.com/users/twall/gists{/gist_id}","starred_url":"https://api.github.com/users/twall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twall/subscriptions","organizations_url":"https://api.github.com/users/twall/orgs","repos_url":"https://api.github.com/users/twall/repos","events_url":"https://api.github.com/users/twall/events{/privacy}","received_events_url":"https://api.github.com/users/twall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twall/jna","description":"Java Native Access","fork":false,"url":"https://api.github.com/repos/twall/jna","forks_url":"https://api.github.com/repos/twall/jna/forks","keys_url":"https://api.github.com/repos/twall/jna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twall/jna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twall/jna/teams","hooks_url":"https://api.github.com/repos/twall/jna/hooks","issue_events_url":"https://api.github.com/repos/twall/jna/issues/events{/number}","events_url":"https://api.github.com/repos/twall/jna/events","assignees_url":"https://api.github.com/repos/twall/jna/assignees{/user}","branches_url":"https://api.github.com/repos/twall/jna/branches{/branch}","tags_url":"https://api.github.com/repos/twall/jna/tags","blobs_url":"https://api.github.com/repos/twall/jna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twall/jna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twall/jna/git/refs{/sha}","trees_url":"https://api.github.com/repos/twall/jna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twall/jna/statuses/{sha}","languages_url":"https://api.github.com/repos/twall/jna/languages","stargazers_url":"https://api.github.com/repos/twall/jna/stargazers","contributors_url":"https://api.github.com/repos/twall/jna/contributors","subscribers_url":"https://api.github.com/repos/twall/jna/subscribers","subscription_url":"https://api.github.com/repos/twall/jna/subscription","commits_url":"https://api.github.com/repos/twall/jna/commits{/sha}","git_commits_url":"https://api.github.com/repos/twall/jna/git/commits{/sha}","comments_url":"https://api.github.com/repos/twall/jna/comments{/number}","issue_comment_url":"https://api.github.com/repos/twall/jna/issues/comments{/number}","contents_url":"https://api.github.com/repos/twall/jna/contents/{+path}","compare_url":"https://api.github.com/repos/twall/jna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twall/jna/merges","archive_url":"https://api.github.com/repos/twall/jna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twall/jna/downloads","issues_url":"https://api.github.com/repos/twall/jna/issues{/number}","pulls_url":"https://api.github.com/repos/twall/jna/pulls{/number}","milestones_url":"https://api.github.com/repos/twall/jna/milestones{/number}","notifications_url":"https://api.github.com/repos/twall/jna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twall/jna/labels{/name}","releases_url":"https://api.github.com/repos/twall/jna/releases{/id}","created_at":"2011-04-29T13:30:29Z","updated_at":"2015-04-29T09:07:48Z","pushed_at":"2015-04-29T09:05:54Z","git_url":"git://github.com/twall/jna.git","ssh_url":"git@github.com:twall/jna.git","clone_url":"https://github.com/twall/jna.git","svn_url":"https://github.com/twall/jna","homepage":"","size":224058,"stargazers_count":1646,"watchers_count":1646,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":472,"mirror_url":null,"open_issues_count":77,"forks":472,"open_issues":77,"watchers":1646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twall/jna/pulls/434"},"html":{"href":"https://github.com/twall/jna/pull/434"},"issue":{"href":"https://api.github.com/repos/twall/jna/issues/434"},"comments":{"href":"https://api.github.com/repos/twall/jna/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/twall/jna/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/twall/jna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twall/jna/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/twall/jna/statuses/054394a39dfd6695644638227d0f19d6a2d82c92"}}}}