{"action":"created","comment":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/45250998","id":45250998,"diff_hunk":"@@ -77,6 +77,7 @@ type SigningProfile struct {\n \tNameWhitelistString string     `json:\"name_whitelist\"`\n \tAuthRemote          AuthRemote `json:\"auth_remote\"`\n \tCTLogServers        []string   `json:\"ct_log_servers\"`\n+\tAllowedExtensions   []OID      `json:\"allowed_extensions\"`","path":"config/config.go","position":4,"original_position":4,"commit_id":"605be0286e416028bb6b842a10c9d0ed4e33b40b","original_commit_id":"605be0286e416028bb6b842a10c9d0ed4e33b40b","user":{"login":"kisom","id":175578,"avatar_url":"https://avatars.githubusercontent.com/u/175578?v=3","gravatar_id":"","url":"https://api.github.com/users/kisom","html_url":"https://github.com/kisom","followers_url":"https://api.github.com/users/kisom/followers","following_url":"https://api.github.com/users/kisom/following{/other_user}","gists_url":"https://api.github.com/users/kisom/gists{/gist_id}","starred_url":"https://api.github.com/users/kisom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kisom/subscriptions","organizations_url":"https://api.github.com/users/kisom/orgs","repos_url":"https://api.github.com/users/kisom/repos","events_url":"https://api.github.com/users/kisom/events{/privacy}","received_events_url":"https://api.github.com/users/kisom/received_events","type":"User","site_admin":false},"body":"AllowedExtensions should probably go into the CSRWhitelist.","created_at":"2015-11-18T19:52:28Z","updated_at":"2015-11-18T19:52:28Z","html_url":"https://github.com/cloudflare/cfssl/pull/428#discussion_r45250998","pull_request_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/428","_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments/45250998"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/428#discussion_r45250998"},"pull_request":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/428","id":51028935,"html_url":"https://github.com/cloudflare/cfssl/pull/428","diff_url":"https://github.com/cloudflare/cfssl/pull/428.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/428.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/428","number":428,"state":"open","locked":false,"title":"Add support for client-provided extensions","user":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"body":"This PR makes a couple of changes to allow a client to have certain extensions copied from the CSR to the certificate.\r\n\r\n* Adds a list of extension OIDs to the `CSRWhitelist` struct to indicate what is safe to copy\r\n* In `signer.ParseCertificateRequest`, move requested extensions to `ExtraExtensions` in the cert\r\n* In `local.Sign`, only allow through the extensions that are whitelisted\r\n\r\nThe only special consideration is for `subjectAltName`, which is already handled by `x509.ParseCertificate`. A couple of things to check:\r\n\r\n* If there is no whitelist, this allows the client to specify any extension in the certificate (besides SAN).  That seems consistent with the existing semantic of a whitelist being absent, though.\r\n* Disallowed extensions are currently silently ignored, rather than raising an error.","created_at":"2015-11-18T01:03:45Z","updated_at":"2015-11-18T19:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a43203cd478ac208fca7684eebb258ac052ac3a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/428/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/428/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/428/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/605be0286e416028bb6b842a10c9d0ed4e33b40b","head":{"label":"bifurcation:extra","ref":"extra","sha":"605be0286e416028bb6b842a10c9d0ed4e33b40b","user":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"repo":{"id":29909343,"name":"cfssl","full_name":"bifurcation/cfssl","owner":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bifurcation/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":true,"url":"https://api.github.com/repos/bifurcation/cfssl","forks_url":"https://api.github.com/repos/bifurcation/cfssl/forks","keys_url":"https://api.github.com/repos/bifurcation/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bifurcation/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bifurcation/cfssl/teams","hooks_url":"https://api.github.com/repos/bifurcation/cfssl/hooks","issue_events_url":"https://api.github.com/repos/bifurcation/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/bifurcation/cfssl/events","assignees_url":"https://api.github.com/repos/bifurcation/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/bifurcation/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/bifurcation/cfssl/tags","blobs_url":"https://api.github.com/repos/bifurcation/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bifurcation/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bifurcation/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bifurcation/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bifurcation/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/bifurcation/cfssl/languages","stargazers_url":"https://api.github.com/repos/bifurcation/cfssl/stargazers","contributors_url":"https://api.github.com/repos/bifurcation/cfssl/contributors","subscribers_url":"https://api.github.com/repos/bifurcation/cfssl/subscribers","subscription_url":"https://api.github.com/repos/bifurcation/cfssl/subscription","commits_url":"https://api.github.com/repos/bifurcation/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bifurcation/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bifurcation/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bifurcation/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bifurcation/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/bifurcation/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bifurcation/cfssl/merges","archive_url":"https://api.github.com/repos/bifurcation/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bifurcation/cfssl/downloads","issues_url":"https://api.github.com/repos/bifurcation/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/bifurcation/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/bifurcation/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/bifurcation/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bifurcation/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/bifurcation/cfssl/releases{/id}","created_at":"2015-01-27T10:33:53Z","updated_at":"2015-02-25T16:43:34Z","pushed_at":"2015-11-18T02:14:56Z","git_url":"git://github.com/bifurcation/cfssl.git","ssh_url":"git@github.com:bifurcation/cfssl.git","clone_url":"https://github.com/bifurcation/cfssl.git","svn_url":"https://github.com/bifurcation/cfssl","homepage":"https://blog.cloudflare.com/introducing-cfssl","size":2263,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"0c0cbb53b294e878378d887b019bfb8ebac286be","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","created_at":"2014-07-07T23:49:12Z","updated_at":"2015-11-18T14:06:10Z","pushed_at":"2015-11-18T19:20:13Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://cfssl.org/","size":2631,"stargazers_count":904,"watchers_count":904,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":57,"forks":106,"open_issues":57,"watchers":904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/428"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/428"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/428"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/605be0286e416028bb6b842a10c9d0ed4e33b40b"}}}}