{"action":"created","comment":{"url":"https://api.github.com/repos/sympy/sympy/pulls/comments/36551004","id":36551004,"diff_hunk":"@@ -497,7 +497,7 @@ def _solve_real_trig(f, symbol):\n     g, h = g.expand(), h.expand()\n     g, h = g.subs(exp(I*symbol), y), h.subs(exp(I*symbol), y)\n     if g.has(symbol) or h.has(symbol):\n-        raise NotImplementedError\n+        return ConditionSet(Lambda(symbol, f), S.Reals)","path":"sympy/solvers/solveset.py","position":23,"original_position":23,"commit_id":"38ebecbd5460de354abcfde495bd7fa4382f70db","original_commit_id":"38ebecbd5460de354abcfde495bd7fa4382f70db","user":{"login":"aktech","id":5647941,"avatar_url":"https://avatars.githubusercontent.com/u/5647941?v=3","gravatar_id":"","url":"https://api.github.com/users/aktech","html_url":"https://github.com/aktech","followers_url":"https://api.github.com/users/aktech/followers","following_url":"https://api.github.com/users/aktech/following{/other_user}","gists_url":"https://api.github.com/users/aktech/gists{/gist_id}","starred_url":"https://api.github.com/users/aktech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aktech/subscriptions","organizations_url":"https://api.github.com/users/aktech/orgs","repos_url":"https://api.github.com/users/aktech/repos","events_url":"https://api.github.com/users/aktech/events{/privacy}","received_events_url":"https://api.github.com/users/aktech/received_events","type":"User","site_admin":false},"body":" `f`  --> `Eq(f, 0)`","created_at":"2015-08-07T19:07:21Z","updated_at":"2015-08-07T19:07:21Z","html_url":"https://github.com/sympy/sympy/pull/9790#discussion_r36551004","pull_request_url":"https://api.github.com/repos/sympy/sympy/pulls/9790","_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments/36551004"},"html":{"href":"https://github.com/sympy/sympy/pull/9790#discussion_r36551004"},"pull_request":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9790"}}},"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/9790","id":41921716,"html_url":"https://github.com/sympy/sympy/pull/9790","diff_url":"https://github.com/sympy/sympy/pull/9790.diff","patch_url":"https://github.com/sympy/sympy/pull/9790.patch","issue_url":"https://api.github.com/repos/sympy/sympy/issues/9790","number":9790,"state":"open","locked":false,"title":"[WIP] Using ConditionSet as unsolvable objects instead of NotImplementedError.","user":{"login":"kumarkrishna","id":5628798,"avatar_url":"https://avatars.githubusercontent.com/u/5628798?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarkrishna","html_url":"https://github.com/kumarkrishna","followers_url":"https://api.github.com/users/kumarkrishna/followers","following_url":"https://api.github.com/users/kumarkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kumarkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarkrishna/subscriptions","organizations_url":"https://api.github.com/users/kumarkrishna/orgs","repos_url":"https://api.github.com/users/kumarkrishna/repos","events_url":"https://api.github.com/users/kumarkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kumarkrishna/received_events","type":"User","site_admin":false},"body":"Fixes #9773.\r\nTODO:\r\n- [ ] Edit Docstring.\r\n- [ ] Update tests.","created_at":"2015-08-07T18:49:25Z","updated_at":"2015-08-07T19:07:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa56646b75fe7ff89fbeacfe7f4e6482700439b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sympy/sympy/pulls/9790/commits","review_comments_url":"https://api.github.com/repos/sympy/sympy/pulls/9790/comments","review_comment_url":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/9790/comments","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/38ebecbd5460de354abcfde495bd7fa4382f70db","head":{"label":"kumarkrishna:notimplemented_to_conditionset","ref":"notimplemented_to_conditionset","sha":"38ebecbd5460de354abcfde495bd7fa4382f70db","user":{"login":"kumarkrishna","id":5628798,"avatar_url":"https://avatars.githubusercontent.com/u/5628798?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarkrishna","html_url":"https://github.com/kumarkrishna","followers_url":"https://api.github.com/users/kumarkrishna/followers","following_url":"https://api.github.com/users/kumarkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kumarkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarkrishna/subscriptions","organizations_url":"https://api.github.com/users/kumarkrishna/orgs","repos_url":"https://api.github.com/users/kumarkrishna/repos","events_url":"https://api.github.com/users/kumarkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kumarkrishna/received_events","type":"User","site_admin":false},"repo":{"id":14453858,"name":"sympy","full_name":"kumarkrishna/sympy","owner":{"login":"kumarkrishna","id":5628798,"avatar_url":"https://avatars.githubusercontent.com/u/5628798?v=3","gravatar_id":"","url":"https://api.github.com/users/kumarkrishna","html_url":"https://github.com/kumarkrishna","followers_url":"https://api.github.com/users/kumarkrishna/followers","following_url":"https://api.github.com/users/kumarkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kumarkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kumarkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumarkrishna/subscriptions","organizations_url":"https://api.github.com/users/kumarkrishna/orgs","repos_url":"https://api.github.com/users/kumarkrishna/repos","events_url":"https://api.github.com/users/kumarkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kumarkrishna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kumarkrishna/sympy","description":"A computer algebra system written in pure Python","fork":true,"url":"https://api.github.com/repos/kumarkrishna/sympy","forks_url":"https://api.github.com/repos/kumarkrishna/sympy/forks","keys_url":"https://api.github.com/repos/kumarkrishna/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kumarkrishna/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kumarkrishna/sympy/teams","hooks_url":"https://api.github.com/repos/kumarkrishna/sympy/hooks","issue_events_url":"https://api.github.com/repos/kumarkrishna/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/kumarkrishna/sympy/events","assignees_url":"https://api.github.com/repos/kumarkrishna/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/kumarkrishna/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/kumarkrishna/sympy/tags","blobs_url":"https://api.github.com/repos/kumarkrishna/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kumarkrishna/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kumarkrishna/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kumarkrishna/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kumarkrishna/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/kumarkrishna/sympy/languages","stargazers_url":"https://api.github.com/repos/kumarkrishna/sympy/stargazers","contributors_url":"https://api.github.com/repos/kumarkrishna/sympy/contributors","subscribers_url":"https://api.github.com/repos/kumarkrishna/sympy/subscribers","subscription_url":"https://api.github.com/repos/kumarkrishna/sympy/subscription","commits_url":"https://api.github.com/repos/kumarkrishna/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kumarkrishna/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kumarkrishna/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kumarkrishna/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kumarkrishna/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/kumarkrishna/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kumarkrishna/sympy/merges","archive_url":"https://api.github.com/repos/kumarkrishna/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kumarkrishna/sympy/downloads","issues_url":"https://api.github.com/repos/kumarkrishna/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/kumarkrishna/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/kumarkrishna/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/kumarkrishna/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kumarkrishna/sympy/labels{/name}","releases_url":"https://api.github.com/repos/kumarkrishna/sympy/releases{/id}","created_at":"2013-11-16T20:06:12Z","updated_at":"2015-08-05T12:43:25Z","pushed_at":"2015-08-07T18:44:25Z","git_url":"git://github.com/kumarkrishna/sympy.git","ssh_url":"git@github.com:kumarkrishna/sympy.git","clone_url":"https://github.com/kumarkrishna/sympy.git","svn_url":"https://github.com/kumarkrishna/sympy","homepage":"http://sympy.org/","size":72063,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sympy:master","ref":"master","sha":"a91ba26c6d639980a4b3351a443548c629447cf9","user":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"repo":{"id":640534,"name":"sympy","full_name":"sympy/sympy","owner":{"login":"sympy","id":260832,"avatar_url":"https://avatars.githubusercontent.com/u/260832?v=3","gravatar_id":"","url":"https://api.github.com/users/sympy","html_url":"https://github.com/sympy","followers_url":"https://api.github.com/users/sympy/followers","following_url":"https://api.github.com/users/sympy/following{/other_user}","gists_url":"https://api.github.com/users/sympy/gists{/gist_id}","starred_url":"https://api.github.com/users/sympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sympy/subscriptions","organizations_url":"https://api.github.com/users/sympy/orgs","repos_url":"https://api.github.com/users/sympy/repos","events_url":"https://api.github.com/users/sympy/events{/privacy}","received_events_url":"https://api.github.com/users/sympy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sympy/sympy","description":"A computer algebra system written in pure Python","fork":false,"url":"https://api.github.com/repos/sympy/sympy","forks_url":"https://api.github.com/repos/sympy/sympy/forks","keys_url":"https://api.github.com/repos/sympy/sympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sympy/sympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sympy/sympy/teams","hooks_url":"https://api.github.com/repos/sympy/sympy/hooks","issue_events_url":"https://api.github.com/repos/sympy/sympy/issues/events{/number}","events_url":"https://api.github.com/repos/sympy/sympy/events","assignees_url":"https://api.github.com/repos/sympy/sympy/assignees{/user}","branches_url":"https://api.github.com/repos/sympy/sympy/branches{/branch}","tags_url":"https://api.github.com/repos/sympy/sympy/tags","blobs_url":"https://api.github.com/repos/sympy/sympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sympy/sympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sympy/sympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/sympy/sympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sympy/sympy/statuses/{sha}","languages_url":"https://api.github.com/repos/sympy/sympy/languages","stargazers_url":"https://api.github.com/repos/sympy/sympy/stargazers","contributors_url":"https://api.github.com/repos/sympy/sympy/contributors","subscribers_url":"https://api.github.com/repos/sympy/sympy/subscribers","subscription_url":"https://api.github.com/repos/sympy/sympy/subscription","commits_url":"https://api.github.com/repos/sympy/sympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/sympy/sympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/sympy/sympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/sympy/sympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/sympy/sympy/contents/{+path}","compare_url":"https://api.github.com/repos/sympy/sympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sympy/sympy/merges","archive_url":"https://api.github.com/repos/sympy/sympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sympy/sympy/downloads","issues_url":"https://api.github.com/repos/sympy/sympy/issues{/number}","pulls_url":"https://api.github.com/repos/sympy/sympy/pulls{/number}","milestones_url":"https://api.github.com/repos/sympy/sympy/milestones{/number}","notifications_url":"https://api.github.com/repos/sympy/sympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sympy/sympy/labels{/name}","releases_url":"https://api.github.com/repos/sympy/sympy/releases{/id}","created_at":"2010-04-30T20:37:14Z","updated_at":"2015-08-07T16:02:58Z","pushed_at":"2015-08-07T18:49:25Z","git_url":"git://github.com/sympy/sympy.git","ssh_url":"git@github.com:sympy/sympy.git","clone_url":"https://github.com/sympy/sympy.git","svn_url":"https://github.com/sympy/sympy","homepage":"http://sympy.org/","size":152531,"stargazers_count":2267,"watchers_count":2267,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1111,"mirror_url":null,"open_issues_count":1955,"forks":1111,"open_issues":1955,"watchers":2267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9790"},"html":{"href":"https://github.com/sympy/sympy/pull/9790"},"issue":{"href":"https://api.github.com/repos/sympy/sympy/issues/9790"},"comments":{"href":"https://api.github.com/repos/sympy/sympy/issues/9790/comments"},"review_comments":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9790/comments"},"review_comment":{"href":"https://api.github.com/repos/sympy/sympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sympy/sympy/pulls/9790/commits"},"statuses":{"href":"https://api.github.com/repos/sympy/sympy/statuses/38ebecbd5460de354abcfde495bd7fa4382f70db"}}}}