{"action":"created","comment":{"url":"https://api.github.com/repos/basho/riak_pb/pulls/comments/43450373","id":43450373,"diff_hunk":"@@ -389,14 +389,11 @@ enum TsColumnType {\n   FLOAT = 2;","path":"src/riak_kv.proto","position":1,"original_position":1,"commit_id":"4583c01f3267bb30e67babce9153b7583e45a0c6","original_commit_id":"4583c01f3267bb30e67babce9153b7583e45a0c6","user":{"login":"lukebakken","id":514926,"avatar_url":"https://avatars.githubusercontent.com/u/514926?v=3","gravatar_id":"","url":"https://api.github.com/users/lukebakken","html_url":"https://github.com/lukebakken","followers_url":"https://api.github.com/users/lukebakken/followers","following_url":"https://api.github.com/users/lukebakken/following{/other_user}","gists_url":"https://api.github.com/users/lukebakken/gists{/gist_id}","starred_url":"https://api.github.com/users/lukebakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukebakken/subscriptions","organizations_url":"https://api.github.com/users/lukebakken/orgs","repos_url":"https://api.github.com/users/lukebakken/repos","events_url":"https://api.github.com/users/lukebakken/events{/privacy}","received_events_url":"https://api.github.com/users/lukebakken/received_events","type":"User","site_admin":false},"body":"Should this now be `FLOAT64`?","created_at":"2015-10-29T22:01:02Z","updated_at":"2015-10-29T22:01:02Z","html_url":"https://github.com/basho/riak_pb/pull/145#discussion_r43450373","pull_request_url":"https://api.github.com/repos/basho/riak_pb/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/comments/43450373"},"html":{"href":"https://github.com/basho/riak_pb/pull/145#discussion_r43450373"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/basho/riak_pb/pulls/145","id":48896253,"html_url":"https://github.com/basho/riak_pb/pull/145","diff_url":"https://github.com/basho/riak_pb/pull/145.diff","patch_url":"https://github.com/basho/riak_pb/pull/145.patch","issue_url":"https://api.github.com/repos/basho/riak_pb/issues/145","number":145,"state":"open","locked":false,"title":" avoid float to binary in deencoding tscell #145  [JIRA: RTS-481]","user":{"login":"hmmr","id":1107079,"avatar_url":"https://avatars.githubusercontent.com/u/1107079?v=3","gravatar_id":"","url":"https://api.github.com/users/hmmr","html_url":"https://github.com/hmmr","followers_url":"https://api.github.com/users/hmmr/followers","following_url":"https://api.github.com/users/hmmr/following{/other_user}","gists_url":"https://api.github.com/users/hmmr/gists{/gist_id}","starred_url":"https://api.github.com/users/hmmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmmr/subscriptions","organizations_url":"https://api.github.com/users/hmmr/orgs","repos_url":"https://api.github.com/users/hmmr/repos","events_url":"https://api.github.com/users/hmmr/events{/privacy}","received_events_url":"https://api.github.com/users/hmmr/received_events","type":"User","site_admin":false},"body":"There were unnecessary binary-to-float/integer conversions happening in the `riak_pb_ts_codec`, which apparently, indirectly, triggered regressions in ts_* modules after the work to keep floats natively.\r\n\r\nPrecisely what was broken is hard to say with certainty, in part because for some time into the coding session I was using protobuf-2.6.1 instead of the required 2.5.0. However, the item clearly needing to be fixed was the appearance of values like <<\"1.2223334e+22\">> in `#tscell.numeric_value`, which was wrong and which is getting fixed by this commit.\r\n\r\nts_basic, which now puts values on both sides of the sint64_max boundary, now passes. ","created_at":"2015-10-27T16:31:40Z","updated_at":"2015-10-29T22:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e67f882f463bbf44a9ce5533f21d99bdb957790d","assignee":{"login":"alexmoore","id":1438,"avatar_url":"https://avatars.githubusercontent.com/u/1438?v=3","gravatar_id":"","url":"https://api.github.com/users/alexmoore","html_url":"https://github.com/alexmoore","followers_url":"https://api.github.com/users/alexmoore/followers","following_url":"https://api.github.com/users/alexmoore/following{/other_user}","gists_url":"https://api.github.com/users/alexmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmoore/subscriptions","organizations_url":"https://api.github.com/users/alexmoore/orgs","repos_url":"https://api.github.com/users/alexmoore/repos","events_url":"https://api.github.com/users/alexmoore/events{/privacy}","received_events_url":"https://api.github.com/users/alexmoore/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/basho/riak_pb/pulls/145/commits","review_comments_url":"https://api.github.com/repos/basho/riak_pb/pulls/145/comments","review_comment_url":"https://api.github.com/repos/basho/riak_pb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho/riak_pb/issues/145/comments","statuses_url":"https://api.github.com/repos/basho/riak_pb/statuses/4583c01f3267bb30e67babce9153b7583e45a0c6","head":{"label":"basho:fix/az/avoid-float_to_binary-in-deencoding-tscell","ref":"fix/az/avoid-float_to_binary-in-deencoding-tscell","sha":"4583c01f3267bb30e67babce9153b7583e45a0c6","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":4339479,"name":"riak_pb","full_name":"basho/riak_pb","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_pb","description":"Riak Protocol Buffers Messages","fork":false,"url":"https://api.github.com/repos/basho/riak_pb","forks_url":"https://api.github.com/repos/basho/riak_pb/forks","keys_url":"https://api.github.com/repos/basho/riak_pb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_pb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_pb/teams","hooks_url":"https://api.github.com/repos/basho/riak_pb/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_pb/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_pb/events","assignees_url":"https://api.github.com/repos/basho/riak_pb/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_pb/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_pb/tags","blobs_url":"https://api.github.com/repos/basho/riak_pb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_pb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_pb/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_pb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_pb/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_pb/languages","stargazers_url":"https://api.github.com/repos/basho/riak_pb/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_pb/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_pb/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_pb/subscription","commits_url":"https://api.github.com/repos/basho/riak_pb/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_pb/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_pb/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_pb/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_pb/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_pb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_pb/merges","archive_url":"https://api.github.com/repos/basho/riak_pb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_pb/downloads","issues_url":"https://api.github.com/repos/basho/riak_pb/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_pb/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_pb/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_pb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_pb/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_pb/releases{/id}","created_at":"2012-05-15T19:06:35Z","updated_at":"2015-09-16T02:26:02Z","pushed_at":"2015-10-29T21:40:07Z","git_url":"git://github.com/basho/riak_pb.git","ssh_url":"git@github.com:basho/riak_pb.git","clone_url":"https://github.com/basho/riak_pb.git","svn_url":"https://github.com/basho/riak_pb","homepage":null,"size":3627,"stargazers_count":42,"watchers_count":42,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":21,"forks":63,"open_issues":21,"watchers":42,"default_branch":"develop"}},"base":{"label":"basho:end-to-end/timeseries","ref":"end-to-end/timeseries","sha":"6bd443d2eafabc03c2d15dd6243908868dfa63f5","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":4339479,"name":"riak_pb","full_name":"basho/riak_pb","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_pb","description":"Riak Protocol Buffers Messages","fork":false,"url":"https://api.github.com/repos/basho/riak_pb","forks_url":"https://api.github.com/repos/basho/riak_pb/forks","keys_url":"https://api.github.com/repos/basho/riak_pb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_pb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_pb/teams","hooks_url":"https://api.github.com/repos/basho/riak_pb/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_pb/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_pb/events","assignees_url":"https://api.github.com/repos/basho/riak_pb/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_pb/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_pb/tags","blobs_url":"https://api.github.com/repos/basho/riak_pb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_pb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_pb/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_pb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_pb/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_pb/languages","stargazers_url":"https://api.github.com/repos/basho/riak_pb/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_pb/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_pb/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_pb/subscription","commits_url":"https://api.github.com/repos/basho/riak_pb/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_pb/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_pb/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_pb/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/riak_pb/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_pb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_pb/merges","archive_url":"https://api.github.com/repos/basho/riak_pb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_pb/downloads","issues_url":"https://api.github.com/repos/basho/riak_pb/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_pb/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_pb/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_pb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_pb/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_pb/releases{/id}","created_at":"2012-05-15T19:06:35Z","updated_at":"2015-09-16T02:26:02Z","pushed_at":"2015-10-29T21:40:07Z","git_url":"git://github.com/basho/riak_pb.git","ssh_url":"git@github.com:basho/riak_pb.git","clone_url":"https://github.com/basho/riak_pb.git","svn_url":"https://github.com/basho/riak_pb","homepage":null,"size":3627,"stargazers_count":42,"watchers_count":42,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":21,"forks":63,"open_issues":21,"watchers":42,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/145"},"html":{"href":"https://github.com/basho/riak_pb/pull/145"},"issue":{"href":"https://api.github.com/repos/basho/riak_pb/issues/145"},"comments":{"href":"https://api.github.com/repos/basho/riak_pb/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho/riak_pb/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/basho/riak_pb/statuses/4583c01f3267bb30e67babce9153b7583e45a0c6"}}}}