{"action":"created","comment":{"url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/comments/43410720","id":43410720,"diff_hunk":"@@ -2,97 +2,116 @@\n \n static const int threadManagerSleep = 100;\n \n-thread_manager::ThreadSubject::ThreadSubject() { \n-  this->commands_ = std::make_shared<std::queue<command_manager::Command>>();\n-  this->_willStop = false;\n-  this->_paused = false;\n-}\n-\n-void thread_manager::ThreadSubject::processCommands ( ) {\n-  while (this->commands_->size () > 0) {\n-    auto& c = this->commands_->front();\n-    processCommand (c);\n-    this->commands_->pop();\n+using std::shared_ptr;\n+using std::make_shared;\n+using std::queue;\n+using std::thread;\n+using std::this_thread::sleep_for;\n+using std::chrono::milliseconds;\n+\n+using command_manager::CommandManager;\n+using command_manager::Command;\n+using command_manager::CommandType;\n+using command_manager::ID;\n+\n+namespace thread_manager {\n+\n+  ThreadSubject::ThreadSubject() {\n+    this->commands_ = make_shared<queue<Command>>();","path":"thread_manager/ThreadManager.cpp","position":30,"original_position":30,"commit_id":"4115b3ba5af90ed08459b40ccbeb9e13fc020bb8","original_commit_id":"4115b3ba5af90ed08459b40ccbeb9e13fc020bb8","user":{"login":"Swipes13","id":10452825,"avatar_url":"https://avatars.githubusercontent.com/u/10452825?v=3","gravatar_id":"","url":"https://api.github.com/users/Swipes13","html_url":"https://github.com/Swipes13","followers_url":"https://api.github.com/users/Swipes13/followers","following_url":"https://api.github.com/users/Swipes13/following{/other_user}","gists_url":"https://api.github.com/users/Swipes13/gists{/gist_id}","starred_url":"https://api.github.com/users/Swipes13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swipes13/subscriptions","organizations_url":"https://api.github.com/users/Swipes13/orgs","repos_url":"https://api.github.com/users/Swipes13/repos","events_url":"https://api.github.com/users/Swipes13/events{/privacy}","received_events_url":"https://api.github.com/users/Swipes13/received_events","type":"User","site_admin":false},"body":"Предлагаю переименовать commands_ -> _commands","created_at":"2015-10-29T16:41:49Z","updated_at":"2015-10-29T16:41:49Z","html_url":"https://github.com/BicycleStudio/Ewe/pull/37#discussion_r43410720","pull_request_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/comments/43410720"},"html":{"href":"https://github.com/BicycleStudio/Ewe/pull/37#discussion_r43410720"},"pull_request":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37","id":49165224,"html_url":"https://github.com/BicycleStudio/Ewe/pull/37","diff_url":"https://github.com/BicycleStudio/Ewe/pull/37.diff","patch_url":"https://github.com/BicycleStudio/Ewe/pull/37.patch","issue_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/37","number":37,"state":"open","locked":false,"title":"Bug/25. Connects #25","user":{"login":"Telhar","id":2892839,"avatar_url":"https://avatars.githubusercontent.com/u/2892839?v=3","gravatar_id":"","url":"https://api.github.com/users/Telhar","html_url":"https://github.com/Telhar","followers_url":"https://api.github.com/users/Telhar/followers","following_url":"https://api.github.com/users/Telhar/following{/other_user}","gists_url":"https://api.github.com/users/Telhar/gists{/gist_id}","starred_url":"https://api.github.com/users/Telhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Telhar/subscriptions","organizations_url":"https://api.github.com/users/Telhar/orgs","repos_url":"https://api.github.com/users/Telhar/repos","events_url":"https://api.github.com/users/Telhar/events{/privacy}","received_events_url":"https://api.github.com/users/Telhar/received_events","type":"User","site_admin":false},"body":"в первом коммите просто всё обернул в namespace и вынес обращения к другим namespace в using","created_at":"2015-10-29T16:34:47Z","updated_at":"2015-10-29T16:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0c2e094e43f175f97ab911c1030b2231fb147c7","assignee":{"login":"Swipes13","id":10452825,"avatar_url":"https://avatars.githubusercontent.com/u/10452825?v=3","gravatar_id":"","url":"https://api.github.com/users/Swipes13","html_url":"https://github.com/Swipes13","followers_url":"https://api.github.com/users/Swipes13/followers","following_url":"https://api.github.com/users/Swipes13/following{/other_user}","gists_url":"https://api.github.com/users/Swipes13/gists{/gist_id}","starred_url":"https://api.github.com/users/Swipes13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swipes13/subscriptions","organizations_url":"https://api.github.com/users/Swipes13/orgs","repos_url":"https://api.github.com/users/Swipes13/repos","events_url":"https://api.github.com/users/Swipes13/events{/privacy}","received_events_url":"https://api.github.com/users/Swipes13/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/BicycleStudio/Ewe/milestones/1","html_url":"https://github.com/BicycleStudio/Ewe/milestones/MVP","labels_url":"https://api.github.com/repos/BicycleStudio/Ewe/milestones/1/labels","id":1373639,"number":1,"title":"MVP","description":"Minimum viable product\r\n\r\nОбязательно:\r\n-  Работают все подсистемы.\r\n-  Фоновая музыка.\r\n-  Треугольник рисуется.\r\n-  От пользователя принимаются команды.\r\n-  Налажена сборка\r\n\r\nНеобязательно:\r\n-  Юнит-тесты\r\n-  Камера\r\n-  Система конфигов\r\n-  Документация\r\n-  Наведенный порядок в репозитории","creator":{"login":"Telhar","id":2892839,"avatar_url":"https://avatars.githubusercontent.com/u/2892839?v=3","gravatar_id":"","url":"https://api.github.com/users/Telhar","html_url":"https://github.com/Telhar","followers_url":"https://api.github.com/users/Telhar/followers","following_url":"https://api.github.com/users/Telhar/following{/other_user}","gists_url":"https://api.github.com/users/Telhar/gists{/gist_id}","starred_url":"https://api.github.com/users/Telhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Telhar/subscriptions","organizations_url":"https://api.github.com/users/Telhar/orgs","repos_url":"https://api.github.com/users/Telhar/repos","events_url":"https://api.github.com/users/Telhar/events{/privacy}","received_events_url":"https://api.github.com/users/Telhar/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":13,"state":"open","created_at":"2015-10-24T04:39:16Z","updated_at":"2015-10-29T16:34:47Z","due_on":"2015-11-29T18:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37/commits","review_comments_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37/comments","review_comment_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/37/comments","statuses_url":"https://api.github.com/repos/BicycleStudio/Ewe/statuses/4115b3ba5af90ed08459b40ccbeb9e13fc020bb8","head":{"label":"BicycleStudio:bug/25","ref":"bug/25","sha":"4115b3ba5af90ed08459b40ccbeb9e13fc020bb8","user":{"login":"BicycleStudio","id":10780522,"avatar_url":"https://avatars.githubusercontent.com/u/10780522?v=3","gravatar_id":"","url":"https://api.github.com/users/BicycleStudio","html_url":"https://github.com/BicycleStudio","followers_url":"https://api.github.com/users/BicycleStudio/followers","following_url":"https://api.github.com/users/BicycleStudio/following{/other_user}","gists_url":"https://api.github.com/users/BicycleStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/BicycleStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BicycleStudio/subscriptions","organizations_url":"https://api.github.com/users/BicycleStudio/orgs","repos_url":"https://api.github.com/users/BicycleStudio/repos","events_url":"https://api.github.com/users/BicycleStudio/events{/privacy}","received_events_url":"https://api.github.com/users/BicycleStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":43245366,"name":"Ewe","full_name":"BicycleStudio/Ewe","owner":{"login":"BicycleStudio","id":10780522,"avatar_url":"https://avatars.githubusercontent.com/u/10780522?v=3","gravatar_id":"","url":"https://api.github.com/users/BicycleStudio","html_url":"https://github.com/BicycleStudio","followers_url":"https://api.github.com/users/BicycleStudio/followers","following_url":"https://api.github.com/users/BicycleStudio/following{/other_user}","gists_url":"https://api.github.com/users/BicycleStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/BicycleStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BicycleStudio/subscriptions","organizations_url":"https://api.github.com/users/BicycleStudio/orgs","repos_url":"https://api.github.com/users/BicycleStudio/repos","events_url":"https://api.github.com/users/BicycleStudio/events{/privacy}","received_events_url":"https://api.github.com/users/BicycleStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BicycleStudio/Ewe","description":"Ships","fork":false,"url":"https://api.github.com/repos/BicycleStudio/Ewe","forks_url":"https://api.github.com/repos/BicycleStudio/Ewe/forks","keys_url":"https://api.github.com/repos/BicycleStudio/Ewe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BicycleStudio/Ewe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BicycleStudio/Ewe/teams","hooks_url":"https://api.github.com/repos/BicycleStudio/Ewe/hooks","issue_events_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/events{/number}","events_url":"https://api.github.com/repos/BicycleStudio/Ewe/events","assignees_url":"https://api.github.com/repos/BicycleStudio/Ewe/assignees{/user}","branches_url":"https://api.github.com/repos/BicycleStudio/Ewe/branches{/branch}","tags_url":"https://api.github.com/repos/BicycleStudio/Ewe/tags","blobs_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/refs{/sha}","trees_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BicycleStudio/Ewe/statuses/{sha}","languages_url":"https://api.github.com/repos/BicycleStudio/Ewe/languages","stargazers_url":"https://api.github.com/repos/BicycleStudio/Ewe/stargazers","contributors_url":"https://api.github.com/repos/BicycleStudio/Ewe/contributors","subscribers_url":"https://api.github.com/repos/BicycleStudio/Ewe/subscribers","subscription_url":"https://api.github.com/repos/BicycleStudio/Ewe/subscription","commits_url":"https://api.github.com/repos/BicycleStudio/Ewe/commits{/sha}","git_commits_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/commits{/sha}","comments_url":"https://api.github.com/repos/BicycleStudio/Ewe/comments{/number}","issue_comment_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/comments{/number}","contents_url":"https://api.github.com/repos/BicycleStudio/Ewe/contents/{+path}","compare_url":"https://api.github.com/repos/BicycleStudio/Ewe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BicycleStudio/Ewe/merges","archive_url":"https://api.github.com/repos/BicycleStudio/Ewe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BicycleStudio/Ewe/downloads","issues_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues{/number}","pulls_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls{/number}","milestones_url":"https://api.github.com/repos/BicycleStudio/Ewe/milestones{/number}","notifications_url":"https://api.github.com/repos/BicycleStudio/Ewe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BicycleStudio/Ewe/labels{/name}","releases_url":"https://api.github.com/repos/BicycleStudio/Ewe/releases{/id}","created_at":"2015-09-27T12:16:31Z","updated_at":"2015-09-27T12:20:05Z","pushed_at":"2015-10-29T16:34:48Z","git_url":"git://github.com/BicycleStudio/Ewe.git","ssh_url":"git@github.com:BicycleStudio/Ewe.git","clone_url":"https://github.com/BicycleStudio/Ewe.git","svn_url":"https://github.com/BicycleStudio/Ewe","homepage":null,"size":942,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":0,"default_branch":"master"}},"base":{"label":"BicycleStudio:master","ref":"master","sha":"9b69b7991e2c954b11e3d3387579616d89ab9e9c","user":{"login":"BicycleStudio","id":10780522,"avatar_url":"https://avatars.githubusercontent.com/u/10780522?v=3","gravatar_id":"","url":"https://api.github.com/users/BicycleStudio","html_url":"https://github.com/BicycleStudio","followers_url":"https://api.github.com/users/BicycleStudio/followers","following_url":"https://api.github.com/users/BicycleStudio/following{/other_user}","gists_url":"https://api.github.com/users/BicycleStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/BicycleStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BicycleStudio/subscriptions","organizations_url":"https://api.github.com/users/BicycleStudio/orgs","repos_url":"https://api.github.com/users/BicycleStudio/repos","events_url":"https://api.github.com/users/BicycleStudio/events{/privacy}","received_events_url":"https://api.github.com/users/BicycleStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":43245366,"name":"Ewe","full_name":"BicycleStudio/Ewe","owner":{"login":"BicycleStudio","id":10780522,"avatar_url":"https://avatars.githubusercontent.com/u/10780522?v=3","gravatar_id":"","url":"https://api.github.com/users/BicycleStudio","html_url":"https://github.com/BicycleStudio","followers_url":"https://api.github.com/users/BicycleStudio/followers","following_url":"https://api.github.com/users/BicycleStudio/following{/other_user}","gists_url":"https://api.github.com/users/BicycleStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/BicycleStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BicycleStudio/subscriptions","organizations_url":"https://api.github.com/users/BicycleStudio/orgs","repos_url":"https://api.github.com/users/BicycleStudio/repos","events_url":"https://api.github.com/users/BicycleStudio/events{/privacy}","received_events_url":"https://api.github.com/users/BicycleStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BicycleStudio/Ewe","description":"Ships","fork":false,"url":"https://api.github.com/repos/BicycleStudio/Ewe","forks_url":"https://api.github.com/repos/BicycleStudio/Ewe/forks","keys_url":"https://api.github.com/repos/BicycleStudio/Ewe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BicycleStudio/Ewe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BicycleStudio/Ewe/teams","hooks_url":"https://api.github.com/repos/BicycleStudio/Ewe/hooks","issue_events_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/events{/number}","events_url":"https://api.github.com/repos/BicycleStudio/Ewe/events","assignees_url":"https://api.github.com/repos/BicycleStudio/Ewe/assignees{/user}","branches_url":"https://api.github.com/repos/BicycleStudio/Ewe/branches{/branch}","tags_url":"https://api.github.com/repos/BicycleStudio/Ewe/tags","blobs_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/refs{/sha}","trees_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BicycleStudio/Ewe/statuses/{sha}","languages_url":"https://api.github.com/repos/BicycleStudio/Ewe/languages","stargazers_url":"https://api.github.com/repos/BicycleStudio/Ewe/stargazers","contributors_url":"https://api.github.com/repos/BicycleStudio/Ewe/contributors","subscribers_url":"https://api.github.com/repos/BicycleStudio/Ewe/subscribers","subscription_url":"https://api.github.com/repos/BicycleStudio/Ewe/subscription","commits_url":"https://api.github.com/repos/BicycleStudio/Ewe/commits{/sha}","git_commits_url":"https://api.github.com/repos/BicycleStudio/Ewe/git/commits{/sha}","comments_url":"https://api.github.com/repos/BicycleStudio/Ewe/comments{/number}","issue_comment_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues/comments{/number}","contents_url":"https://api.github.com/repos/BicycleStudio/Ewe/contents/{+path}","compare_url":"https://api.github.com/repos/BicycleStudio/Ewe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BicycleStudio/Ewe/merges","archive_url":"https://api.github.com/repos/BicycleStudio/Ewe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BicycleStudio/Ewe/downloads","issues_url":"https://api.github.com/repos/BicycleStudio/Ewe/issues{/number}","pulls_url":"https://api.github.com/repos/BicycleStudio/Ewe/pulls{/number}","milestones_url":"https://api.github.com/repos/BicycleStudio/Ewe/milestones{/number}","notifications_url":"https://api.github.com/repos/BicycleStudio/Ewe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BicycleStudio/Ewe/labels{/name}","releases_url":"https://api.github.com/repos/BicycleStudio/Ewe/releases{/id}","created_at":"2015-09-27T12:16:31Z","updated_at":"2015-09-27T12:20:05Z","pushed_at":"2015-10-29T16:34:48Z","git_url":"git://github.com/BicycleStudio/Ewe.git","ssh_url":"git@github.com:BicycleStudio/Ewe.git","clone_url":"https://github.com/BicycleStudio/Ewe.git","svn_url":"https://github.com/BicycleStudio/Ewe","homepage":null,"size":942,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37"},"html":{"href":"https://github.com/BicycleStudio/Ewe/pull/37"},"issue":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/issues/37"},"comments":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/BicycleStudio/Ewe/statuses/4115b3ba5af90ed08459b40ccbeb9e13fc020bb8"}}}}