{"action":"created","comment":{"url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/comments/23463075","id":23463075,"diff_hunk":"@@ -43,10 +44,33 @@ define([ \"shoestring\" ], function(){\n \t\t\treturn;\n \t\t}\n \n+\t\t// create parameter string from data object\n+\t\tif( settings.data !== null ){","path":"src/ajax/ajax.js","position":13,"original_position":13,"commit_id":"3382a678d777604509ef0ca375f784f4515c2a90","original_commit_id":"3382a678d777604509ef0ca375f784f4515c2a90","user":{"login":"johnbender","id":23505,"avatar_url":"https://avatars.githubusercontent.com/u/23505?v=3","gravatar_id":"","url":"https://api.github.com/users/johnbender","html_url":"https://github.com/johnbender","followers_url":"https://api.github.com/users/johnbender/followers","following_url":"https://api.github.com/users/johnbender/following{/other_user}","gists_url":"https://api.github.com/users/johnbender/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbender/subscriptions","organizations_url":"https://api.github.com/users/johnbender/orgs","repos_url":"https://api.github.com/users/johnbender/repos","events_url":"https://api.github.com/users/johnbender/events{/privacy}","received_events_url":"https://api.github.com/users/johnbender/received_events","type":"User","site_admin":false},"body":"What happens when `settings.data` is undefined? I noticed both new tests assume data.","created_at":"2015-01-23T16:55:16Z","updated_at":"2015-01-23T16:55:16Z","html_url":"https://github.com/filamentgroup/shoestring/pull/77#discussion_r23463075","pull_request_url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/comments/23463075"},"html":{"href":"https://github.com/filamentgroup/shoestring/pull/77#discussion_r23463075"},"pull_request":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77","id":24834311,"html_url":"https://github.com/filamentgroup/shoestring/pull/77","diff_url":"https://github.com/filamentgroup/shoestring/pull/77.diff","patch_url":"https://github.com/filamentgroup/shoestring/pull/77.patch","issue_url":"https://api.github.com/repos/filamentgroup/shoestring/issues/77","number":77,"state":"open","locked":false,"title":"update ajax method to send data, fixes #66","user":{"login":"JonathanPrince","id":2764625,"avatar_url":"https://avatars.githubusercontent.com/u/2764625?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanPrince","html_url":"https://github.com/JonathanPrince","followers_url":"https://api.github.com/users/JonathanPrince/followers","following_url":"https://api.github.com/users/JonathanPrince/following{/other_user}","gists_url":"https://api.github.com/users/JonathanPrince/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanPrince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanPrince/subscriptions","organizations_url":"https://api.github.com/users/JonathanPrince/orgs","repos_url":"https://api.github.com/users/JonathanPrince/repos","events_url":"https://api.github.com/users/JonathanPrince/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanPrince/received_events","type":"User","site_admin":false},"body":"# update ajax method to send data, fixes #66\r\n\r\n**submitting pull request early for feedback.**\r\n\r\n## Summary\r\n\r\n- Serialize data into parameter string. \r\n- Append to url for \"GET\" requests.\r\n- Or, format as \"www-form-urlencoded\" for \"POST\" request.\r\n\r\n## Notes:\r\ncomplies with jQuery JavaScript Style Guide.\r\n\r\n## TODO:\r\n- [x] add unit tests\r\n","created_at":"2014-11-21T11:37:43Z","updated_at":"2015-01-23T16:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52ace55da471369eb34cc961498f4dff53aa0c94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77/commits","review_comments_url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77/comments","review_comment_url":"https://api.github.com/repos/filamentgroup/shoestring/pulls/comments/{number}","comments_url":"https://api.github.com/repos/filamentgroup/shoestring/issues/77/comments","statuses_url":"https://api.github.com/repos/filamentgroup/shoestring/statuses/3382a678d777604509ef0ca375f784f4515c2a90","head":{"label":"JonathanPrince:ajax-data","ref":"ajax-data","sha":"3382a678d777604509ef0ca375f784f4515c2a90","user":{"login":"JonathanPrince","id":2764625,"avatar_url":"https://avatars.githubusercontent.com/u/2764625?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanPrince","html_url":"https://github.com/JonathanPrince","followers_url":"https://api.github.com/users/JonathanPrince/followers","following_url":"https://api.github.com/users/JonathanPrince/following{/other_user}","gists_url":"https://api.github.com/users/JonathanPrince/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanPrince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanPrince/subscriptions","organizations_url":"https://api.github.com/users/JonathanPrince/orgs","repos_url":"https://api.github.com/users/JonathanPrince/repos","events_url":"https://api.github.com/users/JonathanPrince/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanPrince/received_events","type":"User","site_admin":false},"repo":{"id":26852464,"name":"shoestring","full_name":"JonathanPrince/shoestring","owner":{"login":"JonathanPrince","id":2764625,"avatar_url":"https://avatars.githubusercontent.com/u/2764625?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanPrince","html_url":"https://github.com/JonathanPrince","followers_url":"https://api.github.com/users/JonathanPrince/followers","following_url":"https://api.github.com/users/JonathanPrince/following{/other_user}","gists_url":"https://api.github.com/users/JonathanPrince/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanPrince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanPrince/subscriptions","organizations_url":"https://api.github.com/users/JonathanPrince/orgs","repos_url":"https://api.github.com/users/JonathanPrince/repos","events_url":"https://api.github.com/users/JonathanPrince/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanPrince/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonathanPrince/shoestring","description":" A lightweight, simple DOM utility made to run on a tight budget.","fork":true,"url":"https://api.github.com/repos/JonathanPrince/shoestring","forks_url":"https://api.github.com/repos/JonathanPrince/shoestring/forks","keys_url":"https://api.github.com/repos/JonathanPrince/shoestring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonathanPrince/shoestring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonathanPrince/shoestring/teams","hooks_url":"https://api.github.com/repos/JonathanPrince/shoestring/hooks","issue_events_url":"https://api.github.com/repos/JonathanPrince/shoestring/issues/events{/number}","events_url":"https://api.github.com/repos/JonathanPrince/shoestring/events","assignees_url":"https://api.github.com/repos/JonathanPrince/shoestring/assignees{/user}","branches_url":"https://api.github.com/repos/JonathanPrince/shoestring/branches{/branch}","tags_url":"https://api.github.com/repos/JonathanPrince/shoestring/tags","blobs_url":"https://api.github.com/repos/JonathanPrince/shoestring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonathanPrince/shoestring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonathanPrince/shoestring/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonathanPrince/shoestring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonathanPrince/shoestring/statuses/{sha}","languages_url":"https://api.github.com/repos/JonathanPrince/shoestring/languages","stargazers_url":"https://api.github.com/repos/JonathanPrince/shoestring/stargazers","contributors_url":"https://api.github.com/repos/JonathanPrince/shoestring/contributors","subscribers_url":"https://api.github.com/repos/JonathanPrince/shoestring/subscribers","subscription_url":"https://api.github.com/repos/JonathanPrince/shoestring/subscription","commits_url":"https://api.github.com/repos/JonathanPrince/shoestring/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonathanPrince/shoestring/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonathanPrince/shoestring/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonathanPrince/shoestring/issues/comments/{number}","contents_url":"https://api.github.com/repos/JonathanPrince/shoestring/contents/{+path}","compare_url":"https://api.github.com/repos/JonathanPrince/shoestring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonathanPrince/shoestring/merges","archive_url":"https://api.github.com/repos/JonathanPrince/shoestring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonathanPrince/shoestring/downloads","issues_url":"https://api.github.com/repos/JonathanPrince/shoestring/issues{/number}","pulls_url":"https://api.github.com/repos/JonathanPrince/shoestring/pulls{/number}","milestones_url":"https://api.github.com/repos/JonathanPrince/shoestring/milestones{/number}","notifications_url":"https://api.github.com/repos/JonathanPrince/shoestring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonathanPrince/shoestring/labels{/name}","releases_url":"https://api.github.com/repos/JonathanPrince/shoestring/releases{/id}","created_at":"2014-11-19T08:45:02Z","updated_at":"2014-11-21T11:40:13Z","pushed_at":"2014-11-23T16:37:14Z","git_url":"git://github.com/JonathanPrince/shoestring.git","ssh_url":"git@github.com:JonathanPrince/shoestring.git","clone_url":"https://github.com/JonathanPrince/shoestring.git","svn_url":"https://github.com/JonathanPrince/shoestring","homepage":"","size":978,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"filamentgroup:master","ref":"master","sha":"9a8cae139ad751325943b71a18008fe79a51ffa4","user":{"login":"filamentgroup","id":30614,"avatar_url":"https://avatars.githubusercontent.com/u/30614?v=3","gravatar_id":"","url":"https://api.github.com/users/filamentgroup","html_url":"https://github.com/filamentgroup","followers_url":"https://api.github.com/users/filamentgroup/followers","following_url":"https://api.github.com/users/filamentgroup/following{/other_user}","gists_url":"https://api.github.com/users/filamentgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/filamentgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filamentgroup/subscriptions","organizations_url":"https://api.github.com/users/filamentgroup/orgs","repos_url":"https://api.github.com/users/filamentgroup/repos","events_url":"https://api.github.com/users/filamentgroup/events{/privacy}","received_events_url":"https://api.github.com/users/filamentgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":3942658,"name":"shoestring","full_name":"filamentgroup/shoestring","owner":{"login":"filamentgroup","id":30614,"avatar_url":"https://avatars.githubusercontent.com/u/30614?v=3","gravatar_id":"","url":"https://api.github.com/users/filamentgroup","html_url":"https://github.com/filamentgroup","followers_url":"https://api.github.com/users/filamentgroup/followers","following_url":"https://api.github.com/users/filamentgroup/following{/other_user}","gists_url":"https://api.github.com/users/filamentgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/filamentgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filamentgroup/subscriptions","organizations_url":"https://api.github.com/users/filamentgroup/orgs","repos_url":"https://api.github.com/users/filamentgroup/repos","events_url":"https://api.github.com/users/filamentgroup/events{/privacy}","received_events_url":"https://api.github.com/users/filamentgroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/filamentgroup/shoestring","description":" A lightweight, simple DOM utility made to run on a tight budget.","fork":false,"url":"https://api.github.com/repos/filamentgroup/shoestring","forks_url":"https://api.github.com/repos/filamentgroup/shoestring/forks","keys_url":"https://api.github.com/repos/filamentgroup/shoestring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filamentgroup/shoestring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filamentgroup/shoestring/teams","hooks_url":"https://api.github.com/repos/filamentgroup/shoestring/hooks","issue_events_url":"https://api.github.com/repos/filamentgroup/shoestring/issues/events{/number}","events_url":"https://api.github.com/repos/filamentgroup/shoestring/events","assignees_url":"https://api.github.com/repos/filamentgroup/shoestring/assignees{/user}","branches_url":"https://api.github.com/repos/filamentgroup/shoestring/branches{/branch}","tags_url":"https://api.github.com/repos/filamentgroup/shoestring/tags","blobs_url":"https://api.github.com/repos/filamentgroup/shoestring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filamentgroup/shoestring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filamentgroup/shoestring/git/refs{/sha}","trees_url":"https://api.github.com/repos/filamentgroup/shoestring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filamentgroup/shoestring/statuses/{sha}","languages_url":"https://api.github.com/repos/filamentgroup/shoestring/languages","stargazers_url":"https://api.github.com/repos/filamentgroup/shoestring/stargazers","contributors_url":"https://api.github.com/repos/filamentgroup/shoestring/contributors","subscribers_url":"https://api.github.com/repos/filamentgroup/shoestring/subscribers","subscription_url":"https://api.github.com/repos/filamentgroup/shoestring/subscription","commits_url":"https://api.github.com/repos/filamentgroup/shoestring/commits{/sha}","git_commits_url":"https://api.github.com/repos/filamentgroup/shoestring/git/commits{/sha}","comments_url":"https://api.github.com/repos/filamentgroup/shoestring/comments{/number}","issue_comment_url":"https://api.github.com/repos/filamentgroup/shoestring/issues/comments/{number}","contents_url":"https://api.github.com/repos/filamentgroup/shoestring/contents/{+path}","compare_url":"https://api.github.com/repos/filamentgroup/shoestring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filamentgroup/shoestring/merges","archive_url":"https://api.github.com/repos/filamentgroup/shoestring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filamentgroup/shoestring/downloads","issues_url":"https://api.github.com/repos/filamentgroup/shoestring/issues{/number}","pulls_url":"https://api.github.com/repos/filamentgroup/shoestring/pulls{/number}","milestones_url":"https://api.github.com/repos/filamentgroup/shoestring/milestones{/number}","notifications_url":"https://api.github.com/repos/filamentgroup/shoestring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filamentgroup/shoestring/labels{/name}","releases_url":"https://api.github.com/repos/filamentgroup/shoestring/releases{/id}","created_at":"2012-04-05T18:18:42Z","updated_at":"2015-01-23T09:07:48Z","pushed_at":"2015-01-21T21:29:52Z","git_url":"git://github.com/filamentgroup/shoestring.git","ssh_url":"git@github.com:filamentgroup/shoestring.git","clone_url":"https://github.com/filamentgroup/shoestring.git","svn_url":"https://github.com/filamentgroup/shoestring","homepage":"","size":2491,"stargazers_count":317,"watchers_count":317,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":23,"forks":8,"open_issues":23,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77"},"html":{"href":"https://github.com/filamentgroup/shoestring/pull/77"},"issue":{"href":"https://api.github.com/repos/filamentgroup/shoestring/issues/77"},"comments":{"href":"https://api.github.com/repos/filamentgroup/shoestring/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/filamentgroup/shoestring/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/filamentgroup/shoestring/statuses/3382a678d777604509ef0ca375f784f4515c2a90"}}}}