{"action":"created","issue":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5364","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5364/labels{/name}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5364/comments","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5364/events","html_url":"https://github.com/HabitRPG/habitrpg/pull/5364","id":86022508,"number":5364,"title":"Option to hide spells in Party Chat","user":{"login":"kusold","id":509966,"avatar_url":"https://avatars.githubusercontent.com/u/509966?v=3","gravatar_id":"","url":"https://api.github.com/users/kusold","html_url":"https://github.com/kusold","followers_url":"https://api.github.com/users/kusold/followers","following_url":"https://api.github.com/users/kusold/following{/other_user}","gists_url":"https://api.github.com/users/kusold/gists{/gist_id}","starred_url":"https://api.github.com/users/kusold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kusold/subscriptions","organizations_url":"https://api.github.com/users/kusold/orgs","repos_url":"https://api.github.com/users/kusold/repos","events_url":"https://api.github.com/users/kusold/events{/privacy}","received_events_url":"https://api.github.com/users/kusold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-06-08T04:39:47Z","updated_at":"2015-06-09T03:51:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/5364","html_url":"https://github.com/HabitRPG/habitrpg/pull/5364","diff_url":"https://github.com/HabitRPG/habitrpg/pull/5364.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/5364.patch"},"body":"Often during quests, it is difficult to review a party's chat history due to the number of spells. I'd like to be able to temporarily toggle off spells for a quicker recap of the day.\r\n\r\nI coded up a quick prototype and wanted to get some feedback on this idea.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/509966/8028203/76f450cc-0d65-11e5-92a1-caeaedab1308.png)\r\n![image](https://cloud.githubusercontent.com/assets/509966/8028206/9278ad48-0d65-11e5-95d7-739a740988c0.png)\r\n\r\nIf you like it, there are some problems with this PR that I should fix:\r\n\r\nI added a checkbox in what seemed like the easiest place, it probably is not the best place so I'd like feedback on where you would like it.\r\n\r\nAlso, I had trouble with the data-bindings. I wasn't able to figure out how to combine one-time and two-way data bindings in the `ng-class`. This is my first time working with angular, so I might be missing an easy solution.\r\n\r\nAlso, would tests be required for this sort of feature? If so, could you please direct me to the right file?"},"comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments/110216092","html_url":"https://github.com/HabitRPG/habitrpg/pull/5364#issuecomment-110216092","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/5364","id":110216092,"user":{"login":"crookedneighbor","id":2916945,"avatar_url":"https://avatars.githubusercontent.com/u/2916945?v=3","gravatar_id":"","url":"https://api.github.com/users/crookedneighbor","html_url":"https://github.com/crookedneighbor","followers_url":"https://api.github.com/users/crookedneighbor/followers","following_url":"https://api.github.com/users/crookedneighbor/following{/other_user}","gists_url":"https://api.github.com/users/crookedneighbor/gists{/gist_id}","starred_url":"https://api.github.com/users/crookedneighbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crookedneighbor/subscriptions","organizations_url":"https://api.github.com/users/crookedneighbor/orgs","repos_url":"https://api.github.com/users/crookedneighbor/repos","events_url":"https://api.github.com/users/crookedneighbor/events{/privacy}","received_events_url":"https://api.github.com/users/crookedneighbor/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T03:51:05Z","updated_at":"2015-06-09T03:51:05Z","body":"I'm not concerned about the tabbing. We can use `ui-keypress` to bind the tab key and cause it to focus on the right place. \r\n\r\nThe send chat button should also have the `.btn-primary` class applied to it. "}}