{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/comments/31767071","id":31767071,"diff_hunk":"@@ -2069,9 +2069,10 @@ IRNode *GenIR::convertFromStackType(IRNode *Node, CorInfoType CorType,\n       Result = (IRNode *)LLVMBuilder->CreateIntCast(Node, ResultTy, IsSigned);\n     } else if (NeedsExtension) {\n       assert(!NeedsReinterpret && \"cannot reinterpret and extend\");\n-      assert((CorType == CorInfoType::CORINFO_TYPE_NATIVEINT) &&\n-             \"only expect to extend to native int\");\n-      const bool IsSigned = true;\n+      assert((CorType == CorInfoType::CORINFO_TYPE_NATIVEINT ||\n+              CorType == CorInfoType::CORINFO_TYPE_NATIVEUINT) &&\n+             \"only expect to extend to native int or uint\");\n+      const bool IsSigned = CorType == CorInfoType::CORINFO_TYPE_NATIVEINT;","path":"lib/Reader/readerir.cpp","position":10,"original_position":10,"commit_id":"4cae2bfb32b9f032bd135bbd2048ea343709c3c4","original_commit_id":"4cae2bfb32b9f032bd135bbd2048ea343709c3c4","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"RyuJIT sign-extends in both cases, but this appears to be a bug: ECMA-335 Table III.9 prescribes sign-extension in the case of native int and zero-extension in the case of native unsigned int.","created_at":"2015-06-04T21:22:00Z","updated_at":"2015-06-04T21:22:00Z","html_url":"https://github.com/dotnet/llilc/pull/618#discussion_r31767071","pull_request_url":"https://api.github.com/repos/dotnet/llilc/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments/31767071"},"html":{"href":"https://github.com/dotnet/llilc/pull/618#discussion_r31767071"},"pull_request":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/llilc/pulls/618","id":36887288,"html_url":"https://github.com/dotnet/llilc/pull/618","diff_url":"https://github.com/dotnet/llilc/pull/618.diff","patch_url":"https://github.com/dotnet/llilc/pull/618.patch","issue_url":"https://api.github.com/repos/dotnet/llilc/issues/618","number":618,"state":"open","locked":false,"title":"Multiple small bug fixes.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"- Change the ASSERTM macro in the reader to use `assert` rather than\r\n  `debugError` in order to avoid losing the message argument\r\n- In GenIR::convertFromStackType, allow zero extension to native uint\r\n- In GenIR::binaryOpType, handle subtraction of one managed pointer\r\n  from another managed pointer as per ECMA-335 Table III.2\r\n- In GenIR::mdArrayRefAddr, convert array indicies from stack types to\r\n  actual types for consitency with ECMA-335 III.1.6\r\n- In GenIR::arrayGetDimLength, handle cases where the array argument is\r\n  an opaque System.Array reference\r\n- In GenIR::cmp, allow comparison between floats and doubles by extending\r\n  the former to the size of the latter","created_at":"2015-06-03T22:59:24Z","updated_at":"2015-06-04T21:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c3cc45c909b83c50d22ad91999f35a1752eb64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/llilc/pulls/618/commits","review_comments_url":"https://api.github.com/repos/dotnet/llilc/pulls/618/comments","review_comment_url":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/llilc/issues/618/comments","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/4cae2bfb32b9f032bd135bbd2048ea343709c3c4","head":{"label":"pgavlin:SmallFixes","ref":"SmallFixes","sha":"4cae2bfb32b9f032bd135bbd2048ea343709c3c4","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":33909806,"name":"llilc","full_name":"pgavlin/llilc","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":true,"url":"https://api.github.com/repos/pgavlin/llilc","forks_url":"https://api.github.com/repos/pgavlin/llilc/forks","keys_url":"https://api.github.com/repos/pgavlin/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/llilc/teams","hooks_url":"https://api.github.com/repos/pgavlin/llilc/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/llilc/events","assignees_url":"https://api.github.com/repos/pgavlin/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/llilc/tags","blobs_url":"https://api.github.com/repos/pgavlin/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/llilc/languages","stargazers_url":"https://api.github.com/repos/pgavlin/llilc/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/llilc/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/llilc/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/llilc/subscription","commits_url":"https://api.github.com/repos/pgavlin/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/llilc/merges","archive_url":"https://api.github.com/repos/pgavlin/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/llilc/downloads","issues_url":"https://api.github.com/repos/pgavlin/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/llilc/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/llilc/releases{/id}","created_at":"2015-04-14T03:59:06Z","updated_at":"2015-04-29T16:09:25Z","pushed_at":"2015-06-03T22:59:04Z","git_url":"git://github.com/pgavlin/llilc.git","ssh_url":"git@github.com:pgavlin/llilc.git","clone_url":"https://github.com/pgavlin/llilc.git","svn_url":"https://github.com/pgavlin/llilc","homepage":"","size":5832,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2db21157f8916208f9f5b97deee8610fdc00b725","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30043131,"name":"llilc","full_name":"dotnet/llilc","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/llilc","description":"This repo contains LLILC, an LLVM based compiler for .NET Core. It includes a set of cross-platform .NET code generation tools that enables compilation of MSIL byte code to LLVM supported platforms.","fork":false,"url":"https://api.github.com/repos/dotnet/llilc","forks_url":"https://api.github.com/repos/dotnet/llilc/forks","keys_url":"https://api.github.com/repos/dotnet/llilc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/llilc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/llilc/teams","hooks_url":"https://api.github.com/repos/dotnet/llilc/hooks","issue_events_url":"https://api.github.com/repos/dotnet/llilc/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/llilc/events","assignees_url":"https://api.github.com/repos/dotnet/llilc/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/llilc/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/llilc/tags","blobs_url":"https://api.github.com/repos/dotnet/llilc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/llilc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/llilc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/llilc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/llilc/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/llilc/languages","stargazers_url":"https://api.github.com/repos/dotnet/llilc/stargazers","contributors_url":"https://api.github.com/repos/dotnet/llilc/contributors","subscribers_url":"https://api.github.com/repos/dotnet/llilc/subscribers","subscription_url":"https://api.github.com/repos/dotnet/llilc/subscription","commits_url":"https://api.github.com/repos/dotnet/llilc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/llilc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/llilc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/llilc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/llilc/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/llilc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/llilc/merges","archive_url":"https://api.github.com/repos/dotnet/llilc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/llilc/downloads","issues_url":"https://api.github.com/repos/dotnet/llilc/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/llilc/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/llilc/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/llilc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/llilc/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/llilc/releases{/id}","created_at":"2015-01-29T21:52:01Z","updated_at":"2015-06-04T10:38:46Z","pushed_at":"2015-06-04T18:57:31Z","git_url":"git://github.com/dotnet/llilc.git","ssh_url":"git@github.com:dotnet/llilc.git","clone_url":"https://github.com/dotnet/llilc.git","svn_url":"https://github.com/dotnet/llilc","homepage":"","size":13547,"stargazers_count":737,"watchers_count":737,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":130,"forks":59,"open_issues":130,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/618"},"html":{"href":"https://github.com/dotnet/llilc/pull/618"},"issue":{"href":"https://api.github.com/repos/dotnet/llilc/issues/618"},"comments":{"href":"https://api.github.com/repos/dotnet/llilc/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/llilc/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/llilc/statuses/4cae2bfb32b9f032bd135bbd2048ea343709c3c4"}}}}