{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/39314680","id":39314680,"diff_hunk":"@@ -65,15 +70,15 @@\n \tuse_power(100)\r\n \r\n \taffecting = loc.contents - src\t\t// moved items will be all in loc\r\n-\tspawn(1)\t// slight delay to prevent infinite propagation due to map order\t//TODO: please no spawn() in process(). It's a very bad idea\r\n-\t\tvar/items_moved = 0\r\n-\t\tfor(var/atom/movable/A in affecting)\r\n-\t\t\tif(!A.anchored)\r\n-\t\t\t\tif(A.loc == src.loc) // prevents the object from being affected if it's not currently here.\r\n-\t\t\t\t\tstep(A,movedir)\r\n-\t\t\t\t\titems_moved++\r\n-\t\t\tif(items_moved >= 10)\r\n-\t\t\t\tbreak\r\n+\tvar/items_moved = 0\r\n+\tfor(var/atom/movable/A in affecting)\r\n+\t\tif(!A.anchored)\r\n+\t\t\tif(A.loc == src.loc && !conveyor_moved.Find(A)) // prevents the object from being affected if it's not currently here or alredy move.\r","path":"code/modules/recycling/conveyor2.dm","position":38,"original_position":38,"commit_id":"0efc305628f0d48300526c2931dba8960ea3e043","original_commit_id":"0efc305628f0d48300526c2931dba8960ea3e043","user":{"login":"mwerezak","id":242428,"avatar_url":"https://avatars.githubusercontent.com/u/242428?v=3","gravatar_id":"","url":"https://api.github.com/users/mwerezak","html_url":"https://github.com/mwerezak","followers_url":"https://api.github.com/users/mwerezak/followers","following_url":"https://api.github.com/users/mwerezak/following{/other_user}","gists_url":"https://api.github.com/users/mwerezak/gists{/gist_id}","starred_url":"https://api.github.com/users/mwerezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwerezak/subscriptions","organizations_url":"https://api.github.com/users/mwerezak/orgs","repos_url":"https://api.github.com/users/mwerezak/repos","events_url":"https://api.github.com/users/mwerezak/events{/privacy}","received_events_url":"https://api.github.com/users/mwerezak/received_events","type":"User","site_admin":false},"body":"Instead of a whole new list search each time we find a movable atom on a conveyor, it may be faster to just add everything to be moved to the list (assoc'd with the move direction perhaps), and then have the machines process move the atoms all at once as a post-process step.","created_at":"2015-09-11T20:38:47Z","updated_at":"2015-09-11T20:38:47Z","html_url":"https://github.com/Baystation12/Baystation12/pull/11070#discussion_r39314680","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/39314680"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/11070#discussion_r39314680"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070","id":44778487,"html_url":"https://github.com/Baystation12/Baystation12/pull/11070","diff_url":"https://github.com/Baystation12/Baystation12/pull/11070.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/11070.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/11070","number":11070,"state":"open","locked":false,"title":"conveyor update.","user":{"login":"Dennok","id":7734424,"avatar_url":"https://avatars.githubusercontent.com/u/7734424?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennok","html_url":"https://github.com/Dennok","followers_url":"https://api.github.com/users/Dennok/followers","following_url":"https://api.github.com/users/Dennok/following{/other_user}","gists_url":"https://api.github.com/users/Dennok/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennok/subscriptions","organizations_url":"https://api.github.com/users/Dennok/orgs","repos_url":"https://api.github.com/users/Dennok/repos","events_url":"https://api.github.com/users/Dennok/events{/privacy}","received_events_url":"https://api.github.com/users/Dennok/received_events","type":"User","site_admin":false},"body":"Remove spawn(1) from process.\r\nRemove obj move in backwards dir when off.","created_at":"2015-09-11T12:51:28Z","updated_at":"2015-09-11T20:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"addd131b2bead04484de939bf3463364782b8b2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/11070/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/0efc305628f0d48300526c2931dba8960ea3e043","head":{"label":"Dennok:patch-2","ref":"patch-2","sha":"0efc305628f0d48300526c2931dba8960ea3e043","user":{"login":"Dennok","id":7734424,"avatar_url":"https://avatars.githubusercontent.com/u/7734424?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennok","html_url":"https://github.com/Dennok","followers_url":"https://api.github.com/users/Dennok/followers","following_url":"https://api.github.com/users/Dennok/following{/other_user}","gists_url":"https://api.github.com/users/Dennok/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennok/subscriptions","organizations_url":"https://api.github.com/users/Dennok/orgs","repos_url":"https://api.github.com/users/Dennok/repos","events_url":"https://api.github.com/users/Dennok/events{/privacy}","received_events_url":"https://api.github.com/users/Dennok/received_events","type":"User","site_admin":false},"repo":{"id":35838512,"name":"Baystation12","full_name":"Dennok/Baystation12","owner":{"login":"Dennok","id":7734424,"avatar_url":"https://avatars.githubusercontent.com/u/7734424?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennok","html_url":"https://github.com/Dennok","followers_url":"https://api.github.com/users/Dennok/followers","following_url":"https://api.github.com/users/Dennok/following{/other_user}","gists_url":"https://api.github.com/users/Dennok/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennok/subscriptions","organizations_url":"https://api.github.com/users/Dennok/orgs","repos_url":"https://api.github.com/users/Dennok/repos","events_url":"https://api.github.com/users/Dennok/events{/privacy}","received_events_url":"https://api.github.com/users/Dennok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dennok/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/Dennok/Baystation12","forks_url":"https://api.github.com/repos/Dennok/Baystation12/forks","keys_url":"https://api.github.com/repos/Dennok/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dennok/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dennok/Baystation12/teams","hooks_url":"https://api.github.com/repos/Dennok/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Dennok/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Dennok/Baystation12/events","assignees_url":"https://api.github.com/repos/Dennok/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Dennok/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Dennok/Baystation12/tags","blobs_url":"https://api.github.com/repos/Dennok/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dennok/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dennok/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dennok/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dennok/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Dennok/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Dennok/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Dennok/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Dennok/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Dennok/Baystation12/subscription","commits_url":"https://api.github.com/repos/Dennok/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dennok/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dennok/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dennok/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dennok/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Dennok/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dennok/Baystation12/merges","archive_url":"https://api.github.com/repos/Dennok/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dennok/Baystation12/downloads","issues_url":"https://api.github.com/repos/Dennok/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Dennok/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Dennok/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Dennok/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dennok/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Dennok/Baystation12/releases{/id}","created_at":"2015-05-18T19:38:55Z","updated_at":"2015-05-18T21:49:12Z","pushed_at":"2015-09-11T14:38:56Z","git_url":"git://github.com/Dennok/Baystation12.git","ssh_url":"git@github.com:Dennok/Baystation12.git","clone_url":"https://github.com/Dennok/Baystation12.git","svn_url":"https://github.com/Dennok/Baystation12","homepage":"http://baystation12.net/","size":623040,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"8f4204df1907afbd915027509efd93ea457d9556","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","created_at":"2011-11-05T16:12:41Z","updated_at":"2015-09-04T15:55:21Z","pushed_at":"2015-09-11T20:10:18Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1596268,"stargazers_count":206,"watchers_count":206,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":848,"mirror_url":null,"open_issues_count":279,"forks":848,"open_issues":279,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/11070"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/11070"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/11070/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/11070/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/0efc305628f0d48300526c2931dba8960ea3e043"}}}}