{"action":"created","issue":{"url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/14","labels_url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/14/comments","events_url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/14/events","html_url":"https://github.com/SciRuby/rb-gsl/issues/14","id":70716550,"number":14,"title":"Merge with rb-gsl","user":{"login":"agarie","id":615227,"avatar_url":"https://avatars.githubusercontent.com/u/615227?v=3","gravatar_id":"","url":"https://api.github.com/users/agarie","html_url":"https://github.com/agarie","followers_url":"https://api.github.com/users/agarie/followers","following_url":"https://api.github.com/users/agarie/following{/other_user}","gists_url":"https://api.github.com/users/agarie/gists{/gist_id}","starred_url":"https://api.github.com/users/agarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarie/subscriptions","organizations_url":"https://api.github.com/users/agarie/orgs","repos_url":"https://api.github.com/users/agarie/repos","events_url":"https://api.github.com/users/agarie/events{/privacy}","received_events_url":"https://api.github.com/users/agarie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-24T15:18:12Z","updated_at":"2015-05-07T11:38:47Z","closed_at":null,"body":"Hi folks,\r\n\r\nI'm using a Ruby gem that depends on `rb-gsl` ([glove](https://github.com/vesselinv/glove)) and decided to see if it would work with `gsl-nmatrix` as well. Turns out I couldn't even install it correctly:\r\n\r\n```sh\r\nλ gem install gsl-nmatrix                                                                                                                                                                                                                                                 Fetching: gsl-nmatrix-1.15.3.2.gem (100%)\r\nBuilding native extensions.  This could take a while...\r\nERROR:  Error installing gsl-nmatrix:\r\n\tERROR: Failed to build gem native extension.\r\n\r\n    /Users/agarie/.rubies/ruby-2.2.0/bin/ruby -r ./siteconf20150424-7363-1opqasp.rb extconf.rb\r\nchecking gsl version... 1.16\r\nchecking gsl cflags... -I/usr/local/Cellar/gsl/1.16/include\r\n\r\n[...]\r\n\r\nIn file included from gsl_nmatrix.c:10:\r\n../include/rb_gsl_with_nmatrix.h:3:10: fatal error: 'nmatrix.h' file not found\r\n#include \"nmatrix.h\"\r\n         ^\r\n1 error generated.\r\nmake: *** [gsl_nmatrix.o] Error 1\r\n\r\nmake failed, exit code 2\r\n```\r\n\r\nI don't have time to find why it isn't working right now (IIRC @v0dro had the same problem with travis-ci), but that made me think: was there a very strong reason to not merge this fork with the current `rb-gsl` gem?\r\n\r\nApparently, the current maintainer is @blackwinter: the [rubygems page](https://rubygems.org/gems/rb-gsl) points to [blackwater/rb-gsl](https://github.com/blackwinter/rb-gsl)."},"comment":{"url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/comments/99829016","html_url":"https://github.com/SciRuby/rb-gsl/issues/14#issuecomment-99829016","issue_url":"https://api.github.com/repos/SciRuby/rb-gsl/issues/14","id":99829016,"user":{"login":"blackwinter","id":20381,"avatar_url":"https://avatars.githubusercontent.com/u/20381?v=3","gravatar_id":"","url":"https://api.github.com/users/blackwinter","html_url":"https://github.com/blackwinter","followers_url":"https://api.github.com/users/blackwinter/followers","following_url":"https://api.github.com/users/blackwinter/following{/other_user}","gists_url":"https://api.github.com/users/blackwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/blackwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackwinter/subscriptions","organizations_url":"https://api.github.com/users/blackwinter/orgs","repos_url":"https://api.github.com/users/blackwinter/repos","events_url":"https://api.github.com/users/blackwinter/events{/privacy}","received_events_url":"https://api.github.com/users/blackwinter/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T11:38:47Z","updated_at":"2015-05-07T11:38:47Z","body":"Hi Sameer,\r\n\r\nfirst of all, I'm really glad that you've taken on the task to make the current `rb-gsl` gem work with `NMatrix` instead of `NArray`. I put quite a bit of work into my fork, but ultimately feel that it should be in the hands of more active users. So I'd be more than happy to see it under the @SciRuby umbrella.\r\n\r\nRegarding your [recent work](https://groups.google.com/forum/#!topic/sciruby-dev/tLbRABJacH4) on [gsl-nmatrix](/v0dro/gsl-nmatrix) I have a few comments. I'll keep them in this issue for now, but we can move the discussion elsewhere if you prefer.\r\n\r\n0. It's a bit unfortunate that you didn't keep the commit metadata or at least the commit structure of @mohawkjohn's changes (or my most recent ones, for that matter). I know it's hard to merge two actively developed projects like this, especially considering that it's not even the main objective of your [GSoC project](https://groups.google.com/forum/#!topic/sciruby-dev/OS11GusLpoo).\r\n0. Your code in [extconf.rb](/v0dro/gsl-nmatrix/blob/0950a98/ext/gsl/extconf.rb#L122) fails with a `NoMethodError` when the `nmatrix` gem could not be found. Besides, the work [`gsl_gem_config`](/v0dro/gsl-nmatrix/blob/0950a98/ext/gsl/extconf.rb#L28) does happen for a [reason](/blackwinter/rb-gsl/issues/4) (actually [two](/blackwinter/rb-gsl/issues/5)). If that doesn't work for `nmatrix`, it should be amended instead of abandoned.\r\n0. In applying the [switch](/v0dro/gsl-nmatrix/commit/80e876f), you commented out a few passages. That should probably be cleaned up or even fixed in cases the sole reason was that it broke something. Also, in renaming `ext/gsl/include/rb_gsl_with_narray.{c -> old}` and `ext/gsl/include/rb_gsl_with_narray.{h -> old}` that process was not recorded with Git (and why keep the old files in the first place?).\r\n0. There are some references to `NArray` left in the code (about 40 files).\r\n0. When `narray` is installed, [`require 'nmatrix'`](/v0dro/gsl-nmatrix/blob/0950a98/lib/gsl.rb#L2) picks up the `nmatrix.rb` from `narray`. This is definitely a mistake by `narray`, but should possibly be dealt with.\r\n0. Last but not least, there were non-switch related and debug changes mixed in with everything else. Maybe a clearer structure would simplify the discussion and improve future maintenance.\r\n\r\nI don't want to come across as too nitpicky, but seeing as this should also be an opportunity to learn, I hope you take my comments in good faith.\r\n\r\nAs for the path forward, I'm excited that your fork might become the new [SciRuby/rb-gsl](/SciRuby/rb-gsl), as John already indicated, and hence the canonical implementation. As soon as `nmatrix`'s installation requirements have been softened (see @wlevine's [GSoC project](/wlevine/nmatrix/wiki/Summer-of-Code-2015-proposal)), I'd be willing to give up the `rb-gsl` gem name and point my repository here. Peripheral changes (upgrade path for current users, maybe GSL-independent versioning) notwithstanding.\r\n\r\nWould that be aggreable to everyone?\r\n\r\nCheers,\r\nJens"}}