{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/22480559","id":22480559,"diff_hunk":"@@ -53,18 +57,19 @@ func newBuildHandler(req *Request) (*buildHandler, error) {\n \t\tcallbackInvoker: util.NewCallbackInvoker(),\n \t}\n \trh.postExecutor = bh\n+\trh.errorChecker = bh\n \treturn bh, nil\n }\n \n-// Build processes a Request and returns a *Result and an error.\n+// Build processes a Request and returns a *api.Result and an error.\n // An error represents a failure performing the build rather than a failure\n // of the build itself.  Callers should check the Success field of the result\n // to determine whether a build succeeded or not.\n-func (b *Builder) Build() (*Result, error) {\n+func (b *Builder) Build() (*api.Result, error) {\n \tbh := b.handler\n \tdefer bh.cleanup()\n \n-\terr := bh.setup([]string{\"assemble\", \"run\"}, []string{\"save-artifacts\"})\n+\terr := bh.setup([]api.Script{api.Assemble, api.Run}, []api.Script{api.SaveArtifacts})","path":"pkg/sti/build.go","position":69,"original_position":69,"commit_id":"f2b6a743d60712934a00d25e10fcbb8311c96b6e","original_commit_id":"f2b6a743d60712934a00d25e10fcbb8311c96b6e","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"to me it is more readable `api.AssembleScript` and `api.RunScript`","created_at":"2015-01-05T18:52:34Z","updated_at":"2015-01-05T18:52:34Z","html_url":"https://github.com/openshift/source-to-image/pull/98#discussion_r22480559","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/22480559"},"html":{"href":"https://github.com/openshift/source-to-image/pull/98#discussion_r22480559"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/98","id":26068935,"html_url":"https://github.com/openshift/source-to-image/pull/98","diff_url":"https://github.com/openshift/source-to-image/pull/98.diff","patch_url":"https://github.com/openshift/source-to-image/pull/98.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/98","number":98,"state":"open","locked":false,"title":"Card devexp_416 - Support arbitrary images for STI builders","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"This PR contains:\r\n- [x] Added type for sti script names.\r\n- [x] Removed the need for sti-helper. The untarring is done on the fly when calling assemble script. \r\n- [x] Added additional parameter that can steer the location of untarred contents.\r\n\r\nStill to be done:\r\n- [x] Testing\r\n\r\nNonetheless comments to the build process are welcome since this part is ready.\r\n//cc @bparees @csrwng @smarterclayton ","created_at":"2014-12-15T13:31:11Z","updated_at":"2015-01-05T18:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f01bbda090df1d480a9cd61f53f5716f784f81c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/98/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/98/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/98/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/f2b6a743d60712934a00d25e10fcbb8311c96b6e","head":{"label":"soltysh:card416","ref":"card416","sha":"f2b6a743d60712934a00d25e10fcbb8311c96b6e","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"repo":{"id":25208363,"name":"source-to-image","full_name":"soltysh/source-to-image","owner":{"login":"soltysh","id":576341,"avatar_url":"https://avatars.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltysh/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/soltysh/source-to-image","forks_url":"https://api.github.com/repos/soltysh/source-to-image/forks","keys_url":"https://api.github.com/repos/soltysh/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltysh/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltysh/source-to-image/teams","hooks_url":"https://api.github.com/repos/soltysh/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/soltysh/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/soltysh/source-to-image/events","assignees_url":"https://api.github.com/repos/soltysh/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/soltysh/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/soltysh/source-to-image/tags","blobs_url":"https://api.github.com/repos/soltysh/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltysh/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltysh/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltysh/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltysh/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/soltysh/source-to-image/languages","stargazers_url":"https://api.github.com/repos/soltysh/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/soltysh/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/soltysh/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/soltysh/source-to-image/subscription","commits_url":"https://api.github.com/repos/soltysh/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltysh/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltysh/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltysh/source-to-image/issues/comments/{number}","contents_url":"https://api.github.com/repos/soltysh/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/soltysh/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltysh/source-to-image/merges","archive_url":"https://api.github.com/repos/soltysh/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltysh/source-to-image/downloads","issues_url":"https://api.github.com/repos/soltysh/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/soltysh/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/soltysh/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/soltysh/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltysh/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/soltysh/source-to-image/releases{/id}","created_at":"2014-10-14T13:32:11Z","updated_at":"2014-12-22T17:38:24Z","pushed_at":"2014-12-22T19:27:53Z","git_url":"git://github.com/soltysh/source-to-image.git","ssh_url":"git@github.com:soltysh/source-to-image.git","clone_url":"https://github.com/soltysh/source-to-image.git","svn_url":"https://github.com/soltysh/source-to-image","homepage":"","size":873,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"48cf2e985b571ddc67cfb84a59a339be38b98a81","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments/{number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","created_at":"2014-01-28T19:32:40Z","updated_at":"2014-12-22T17:33:25Z","pushed_at":"2014-12-22T17:33:25Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":1212,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/98"},"html":{"href":"https://github.com/openshift/source-to-image/pull/98"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/98"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/f2b6a743d60712934a00d25e10fcbb8311c96b6e"}}}}