{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/4776","labels_url":"https://api.github.com/repos/playframework/playframework/issues/4776/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/4776/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/4776/events","html_url":"https://github.com/playframework/playframework/pull/4776","id":91260543,"number":4776,"title":"Bumped akka-stream and akka-http to 1.0-RC4. Fix #4774","user":{"login":"dotta","id":703748,"avatar_url":"https://avatars.githubusercontent.com/u/703748?v=3","gravatar_id":"","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-26T14:06:46Z","updated_at":"2015-06-27T02:56:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/4776","html_url":"https://github.com/playframework/playframework/pull/4776","diff_url":"https://github.com/playframework/playframework/pull/4776.diff","patch_url":"https://github.com/playframework/playframework/pull/4776.patch"},"body":"*This PR was built on top of https://github.com/playframework/playframework/pull/4768 (hence, the linked PR must be merged before this).*\r\n\r\n[The only commit relevant for this PR is https://github.com/playframework/playframework/commit/3ee7691ce409d14c61fa893c544b2d25e147e081] \r\n\r\n* Moving from RC3 to RC4 had quite an impact because of the many class'\r\n  renamings.\r\n\r\n* Had to make `play.it.http.JavaResultsHandlingSpec` and\r\n  `play.it.http.ScalaResultsHandlingSpec` running sequentially because they\r\n  would fail otherwise (not sure what has changed in akka-http to cause it, but\r\n  I assumed it may have been caused by additional asynchronism in the impl).\r\n\r\nOne thing that worries me is that some akka-strems type leak into the Play user\r\nAPI (for instance, see `FlowMaterializer` in `play.api.mvc.Filters`), ~~and the\r\nname changes that occurred between RC3 and RC4 are such that I don't think this\r\ncommit can be backported to the 2.4.x branch (because of binary compatibility).~~ \r\nand akka-streams is an experimental module that hence doesn't ensure backward \r\nbinary compatibility across releases. I'm not sure if this is actually going to be an \r\nissue, but I think we should keep it in mind.\r\n\r\n~~Because of the above, I'm wondering if we should have a 2.5 release that only\r\nupgrades Play 2.4 to use akka-streams 1.0 final (once 1.0 is actually out, which\r\nshould happen soon enough).~~ (EDIT: We don't use akka-stream in Play 2.4, so \r\nforget about what I said)."},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/115943987","html_url":"https://github.com/playframework/playframework/pull/4776#issuecomment-115943987","issue_url":"https://api.github.com/repos/playframework/playframework/issues/4776","id":115943987,"user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars.githubusercontent.com/u/322311?v=3","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"created_at":"2015-06-27T02:56:43Z","updated_at":"2015-06-27T02:56:43Z","body":"FYI, there's a merge conflict"}}