{"action":"created","issue":{"url":"https://api.github.com/repos/rancherio/cattle/issues/455","labels_url":"https://api.github.com/repos/rancherio/cattle/issues/455/labels{/name}","comments_url":"https://api.github.com/repos/rancherio/cattle/issues/455/comments","events_url":"https://api.github.com/repos/rancherio/cattle/issues/455/events","html_url":"https://github.com/rancherio/cattle/pull/455","id":77788485,"number":455,"title":"Service Discovery bug fixes","user":{"login":"alena1108","id":1562176,"avatar_url":"https://avatars.githubusercontent.com/u/1562176?v=3","gravatar_id":"","url":"https://api.github.com/users/alena1108","html_url":"https://github.com/alena1108","followers_url":"https://api.github.com/users/alena1108/followers","following_url":"https://api.github.com/users/alena1108/following{/other_user}","gists_url":"https://api.github.com/users/alena1108/gists{/gist_id}","starred_url":"https://api.github.com/users/alena1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alena1108/subscriptions","organizations_url":"https://api.github.com/users/alena1108/orgs","repos_url":"https://api.github.com/users/alena1108/repos","events_url":"https://api.github.com/users/alena1108/events{/privacy}","received_events_url":"https://api.github.com/users/alena1108/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-18T20:12:29Z","updated_at":"2015-05-20T17:25:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/455","html_url":"https://github.com/rancherio/cattle/pull/455","diff_url":"https://github.com/rancherio/cattle/pull/455.diff","patch_url":"https://github.com/rancherio/cattle/pull/455.patch"},"body":"1) LBService: restart instance if stopped on activate\r\nhttps://github.com/rancherio/rancher/issues/844\r\n\r\n2) Check if service referenced via volumesFrom, still exists before resolving the instanceIds\r\n\r\nhttps://github.com/rancherio/rancher/issues/849\r\n\r\n3) Always wait for instance referenced via volumesFrom, to be fully started before creating a referencing instance. Otherwise the parameter might be ignored on the docker side.\r\n\r\nhttps://github.com/rancherio/rancher/issues/846\r\n\r\nAnd one more fix not corresponding to any bug - store used service generated instance names in map with key=serviceId instead of key=service. If we do the latter, the same DB object can be stored multiple times in the map, and it will grow fast.\r\n"},"comment":{"url":"https://api.github.com/repos/rancherio/cattle/issues/comments/103967656","html_url":"https://github.com/rancherio/cattle/pull/455#issuecomment-103967656","issue_url":"https://api.github.com/repos/rancherio/cattle/issues/455","id":103967656,"user":{"login":"sonchang","id":8651231,"avatar_url":"https://avatars.githubusercontent.com/u/8651231?v=3","gravatar_id":"","url":"https://api.github.com/users/sonchang","html_url":"https://github.com/sonchang","followers_url":"https://api.github.com/users/sonchang/followers","following_url":"https://api.github.com/users/sonchang/following{/other_user}","gists_url":"https://api.github.com/users/sonchang/gists{/gist_id}","starred_url":"https://api.github.com/users/sonchang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonchang/subscriptions","organizations_url":"https://api.github.com/users/sonchang/orgs","repos_url":"https://api.github.com/users/sonchang/repos","events_url":"https://api.github.com/users/sonchang/events{/privacy}","received_events_url":"https://api.github.com/users/sonchang/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T17:25:43Z","updated_at":"2015-05-20T17:25:43Z","body":"LGTM"}}