{"action":"created","issue":{"url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/608","labels_url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/608/comments","events_url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/608/events","html_url":"https://github.com/marcellustavares/liferay-portal/pull/608","id":93772847,"number":608,"title":"LPS-56789 Review and move tests to module","user":{"login":"epgarcia","id":1579803,"avatar_url":"https://avatars.githubusercontent.com/u/1579803?v=3","gravatar_id":"","url":"https://api.github.com/users/epgarcia","html_url":"https://github.com/epgarcia","followers_url":"https://api.github.com/users/epgarcia/followers","following_url":"https://api.github.com/users/epgarcia/following{/other_user}","gists_url":"https://api.github.com/users/epgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/epgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epgarcia/subscriptions","organizations_url":"https://api.github.com/users/epgarcia/orgs","repos_url":"https://api.github.com/users/epgarcia/repos","events_url":"https://api.github.com/users/epgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/epgarcia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-08T12:08:58Z","updated_at":"2015-07-08T15:25:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/marcellustavares/liferay-portal/pulls/608","html_url":"https://github.com/marcellustavares/liferay-portal/pull/608","diff_url":"https://github.com/marcellustavares/liferay-portal/pull/608.diff","patch_url":"https://github.com/marcellustavares/liferay-portal/pull/608.patch"},"body":"Hi @marcellustavares,\r\n\r\nI've reviewed your changes and I think they're fine. I've also moved ADT specific tests to a portlet-display-template-test module. I'd like to add more tests there in the future. I was also tempted to move the ADT inferfaces to an -api module, but they're few so I think it's fine to leave them in -service by now.\r\n\r\nMy only concern is that now we have the PortletDisplayTemplatePortlet class in dynamic-data-mapping-web instead of in portlet-display-template-web. This is weird, though I understand ADT is fully based on generic dynamic-data-mapping views. Is there any way we could have the PortletDisplayTemplatePortlet in portlet-display-template-web?\r\n\r\nIf there's no way to change this and you're fine with my own changes, feel free to send the pull to Brian (just CC me).\r\n\r\nThanks for taking care of this.\r\n\r\n@juliocamarero"},"comment":{"url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/comments/119624386","html_url":"https://github.com/marcellustavares/liferay-portal/pull/608#issuecomment-119624386","issue_url":"https://api.github.com/repos/marcellustavares/liferay-portal/issues/608","id":119624386,"user":{"login":"marcellustavares","id":286892,"avatar_url":"https://avatars.githubusercontent.com/u/286892?v=3","gravatar_id":"","url":"https://api.github.com/users/marcellustavares","html_url":"https://github.com/marcellustavares","followers_url":"https://api.github.com/users/marcellustavares/followers","following_url":"https://api.github.com/users/marcellustavares/following{/other_user}","gists_url":"https://api.github.com/users/marcellustavares/gists{/gist_id}","starred_url":"https://api.github.com/users/marcellustavares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcellustavares/subscriptions","organizations_url":"https://api.github.com/users/marcellustavares/orgs","repos_url":"https://api.github.com/users/marcellustavares/repos","events_url":"https://api.github.com/users/marcellustavares/events{/privacy}","received_events_url":"https://api.github.com/users/marcellustavares/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T15:25:14Z","updated_at":"2015-07-08T15:25:14Z","body":"Pull request submitted to https://github.com/brianchandotcom/liferay-portal/pull/28070. <br><br>:octocat: *Sent from [GH](http://nodegh.io).*"}}