{"action":"created","comment":{"url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments/37889492","id":37889492,"diff_hunk":"@@ -0,0 +1,5 @@\n+defprotocol ExAws.CloudSearch.Document do\n+  @fallback_to_any true","path":"lib/ex_aws/cloud_search/document.ex","position":2,"original_position":2,"commit_id":"edb477351189fbcc2cf23df63b7c18ff263b6428","original_commit_id":"edb477351189fbcc2cf23df63b7c18ff263b6428","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars.githubusercontent.com/u/247817?v=3","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"Well if there are cases where I may have some `%User{}` and want to provide some customization with respect to the way in which it's encoded, I think a protocol is fine. I'm not really all that familiar with cloudsearch yet so it isn't entirely clear if such a situation is what we want.\r\n\r\nThe particular comment here was less about the use of a protocol in and of itself, and more about whether or not we want to fall back to any vs enforce particular implementations to exist.","created_at":"2015-08-25T16:52:33Z","updated_at":"2015-08-25T16:52:33Z","html_url":"https://github.com/CargoSense/ex_aws/pull/60#discussion_r37889492","pull_request_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments/37889492"},"html":{"href":"https://github.com/CargoSense/ex_aws/pull/60#discussion_r37889492"},"pull_request":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60","id":43284118,"html_url":"https://github.com/CargoSense/ex_aws/pull/60","diff_url":"https://github.com/CargoSense/ex_aws/pull/60.diff","patch_url":"https://github.com/CargoSense/ex_aws/pull/60.patch","issue_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/60","number":60,"state":"open","locked":false,"title":"Add Cloud Search","user":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"body":"This adds cloud search.\r\n\r\nThere are currently still a few things to do:\r\n\r\n- [ ] Add documentation\r\n- [ ] Add tests\r\n- [ ] Implement `stream_search` that will be an enumerable that implements pagination\r\n\r\nAlso we should consider a few improvements:\r\n\r\n- Enable users to use custom data structure (e.g. indexing and retuning a `%User{}`)\r\n- Support more complex search queries\r\n- Add more search options","created_at":"2015-08-25T13:17:02Z","updated_at":"2015-08-25T16:52:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7aa11145ba167b8b6feee646157657f3b8c056c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60/commits","review_comments_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60/comments","review_comment_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/60/comments","statuses_url":"https://api.github.com/repos/CargoSense/ex_aws/statuses/edb477351189fbcc2cf23df63b7c18ff263b6428","head":{"label":"mschae:add-cloudsearch","ref":"add-cloudsearch","sha":"edb477351189fbcc2cf23df63b7c18ff263b6428","user":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"repo":{"id":38307200,"name":"ex_aws","full_name":"mschae/ex_aws","owner":{"login":"mschae","id":473241,"avatar_url":"https://avatars.githubusercontent.com/u/473241?v=3","gravatar_id":"","url":"https://api.github.com/users/mschae","html_url":"https://github.com/mschae","followers_url":"https://api.github.com/users/mschae/followers","following_url":"https://api.github.com/users/mschae/following{/other_user}","gists_url":"https://api.github.com/users/mschae/gists{/gist_id}","starred_url":"https://api.github.com/users/mschae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschae/subscriptions","organizations_url":"https://api.github.com/users/mschae/orgs","repos_url":"https://api.github.com/users/mschae/repos","events_url":"https://api.github.com/users/mschae/events{/privacy}","received_events_url":"https://api.github.com/users/mschae/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mschae/ex_aws","description":"","fork":true,"url":"https://api.github.com/repos/mschae/ex_aws","forks_url":"https://api.github.com/repos/mschae/ex_aws/forks","keys_url":"https://api.github.com/repos/mschae/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mschae/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mschae/ex_aws/teams","hooks_url":"https://api.github.com/repos/mschae/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/mschae/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/mschae/ex_aws/events","assignees_url":"https://api.github.com/repos/mschae/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/mschae/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/mschae/ex_aws/tags","blobs_url":"https://api.github.com/repos/mschae/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mschae/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mschae/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/mschae/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mschae/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/mschae/ex_aws/languages","stargazers_url":"https://api.github.com/repos/mschae/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/mschae/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/mschae/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/mschae/ex_aws/subscription","commits_url":"https://api.github.com/repos/mschae/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/mschae/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/mschae/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/mschae/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/mschae/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/mschae/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mschae/ex_aws/merges","archive_url":"https://api.github.com/repos/mschae/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mschae/ex_aws/downloads","issues_url":"https://api.github.com/repos/mschae/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/mschae/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/mschae/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/mschae/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mschae/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/mschae/ex_aws/releases{/id}","created_at":"2015-06-30T12:10:46Z","updated_at":"2015-06-30T12:10:47Z","pushed_at":"2015-08-25T13:14:04Z","git_url":"git://github.com/mschae/ex_aws.git","ssh_url":"git@github.com:mschae/ex_aws.git","clone_url":"https://github.com/mschae/ex_aws.git","svn_url":"https://github.com/mschae/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":408,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CargoSense:master","ref":"master","sha":"82648fa44d3bcddeefd21e72a2b7226cffbefdbb","user":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"repo":{"id":24062989,"name":"ex_aws","full_name":"CargoSense/ex_aws","owner":{"login":"CargoSense","id":3963271,"avatar_url":"https://avatars.githubusercontent.com/u/3963271?v=3","gravatar_id":"","url":"https://api.github.com/users/CargoSense","html_url":"https://github.com/CargoSense","followers_url":"https://api.github.com/users/CargoSense/followers","following_url":"https://api.github.com/users/CargoSense/following{/other_user}","gists_url":"https://api.github.com/users/CargoSense/gists{/gist_id}","starred_url":"https://api.github.com/users/CargoSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CargoSense/subscriptions","organizations_url":"https://api.github.com/users/CargoSense/orgs","repos_url":"https://api.github.com/users/CargoSense/repos","events_url":"https://api.github.com/users/CargoSense/events{/privacy}","received_events_url":"https://api.github.com/users/CargoSense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CargoSense/ex_aws","description":"","fork":false,"url":"https://api.github.com/repos/CargoSense/ex_aws","forks_url":"https://api.github.com/repos/CargoSense/ex_aws/forks","keys_url":"https://api.github.com/repos/CargoSense/ex_aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CargoSense/ex_aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CargoSense/ex_aws/teams","hooks_url":"https://api.github.com/repos/CargoSense/ex_aws/hooks","issue_events_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/events{/number}","events_url":"https://api.github.com/repos/CargoSense/ex_aws/events","assignees_url":"https://api.github.com/repos/CargoSense/ex_aws/assignees{/user}","branches_url":"https://api.github.com/repos/CargoSense/ex_aws/branches{/branch}","tags_url":"https://api.github.com/repos/CargoSense/ex_aws/tags","blobs_url":"https://api.github.com/repos/CargoSense/ex_aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CargoSense/ex_aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CargoSense/ex_aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/CargoSense/ex_aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CargoSense/ex_aws/statuses/{sha}","languages_url":"https://api.github.com/repos/CargoSense/ex_aws/languages","stargazers_url":"https://api.github.com/repos/CargoSense/ex_aws/stargazers","contributors_url":"https://api.github.com/repos/CargoSense/ex_aws/contributors","subscribers_url":"https://api.github.com/repos/CargoSense/ex_aws/subscribers","subscription_url":"https://api.github.com/repos/CargoSense/ex_aws/subscription","commits_url":"https://api.github.com/repos/CargoSense/ex_aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/CargoSense/ex_aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/CargoSense/ex_aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/CargoSense/ex_aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/CargoSense/ex_aws/contents/{+path}","compare_url":"https://api.github.com/repos/CargoSense/ex_aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CargoSense/ex_aws/merges","archive_url":"https://api.github.com/repos/CargoSense/ex_aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CargoSense/ex_aws/downloads","issues_url":"https://api.github.com/repos/CargoSense/ex_aws/issues{/number}","pulls_url":"https://api.github.com/repos/CargoSense/ex_aws/pulls{/number}","milestones_url":"https://api.github.com/repos/CargoSense/ex_aws/milestones{/number}","notifications_url":"https://api.github.com/repos/CargoSense/ex_aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CargoSense/ex_aws/labels{/name}","releases_url":"https://api.github.com/repos/CargoSense/ex_aws/releases{/id}","created_at":"2014-09-15T16:02:48Z","updated_at":"2015-08-17T00:46:56Z","pushed_at":"2015-08-25T13:17:03Z","git_url":"git://github.com/CargoSense/ex_aws.git","ssh_url":"git@github.com:CargoSense/ex_aws.git","clone_url":"https://github.com/CargoSense/ex_aws.git","svn_url":"https://github.com/CargoSense/ex_aws","homepage":"https://hex.pm/packages/ex_aws","size":1488,"stargazers_count":38,"watchers_count":38,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":10,"forks":9,"open_issues":10,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60"},"html":{"href":"https://github.com/CargoSense/ex_aws/pull/60"},"issue":{"href":"https://api.github.com/repos/CargoSense/ex_aws/issues/60"},"comments":{"href":"https://api.github.com/repos/CargoSense/ex_aws/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CargoSense/ex_aws/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/CargoSense/ex_aws/statuses/edb477351189fbcc2cf23df63b7c18ff263b6428"}}}}