{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/northstar/issues/125","labels_url":"https://api.github.com/repos/DoSomething/northstar/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/northstar/issues/125/comments","events_url":"https://api.github.com/repos/DoSomething/northstar/issues/125/events","html_url":"https://github.com/DoSomething/northstar/pull/125","id":76490187,"number":125,"title":"Structuring login, logout, and user delete responses","user":{"login":"jonuy","id":696595,"avatar_url":"https://avatars.githubusercontent.com/u/696595?v=3","gravatar_id":"","url":"https://api.github.com/users/jonuy","html_url":"https://github.com/jonuy","followers_url":"https://api.github.com/users/jonuy/followers","following_url":"https://api.github.com/users/jonuy/following{/other_user}","gists_url":"https://api.github.com/users/jonuy/gists{/gist_id}","starred_url":"https://api.github.com/users/jonuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonuy/subscriptions","organizations_url":"https://api.github.com/users/jonuy/orgs","repos_url":"https://api.github.com/users/jonuy/repos","events_url":"https://api.github.com/users/jonuy/events{/privacy}","received_events_url":"https://api.github.com/users/jonuy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-05-14T21:04:22Z","updated_at":"2015-05-18T18:36:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DoSomething/northstar/pulls/125","html_url":"https://github.com/DoSomething/northstar/pull/125","diff_url":"https://github.com/DoSomething/northstar/pull/125.diff","patch_url":"https://github.com/DoSomething/northstar/pull/125.patch"},"body":"#### What's this PR do?\r\nThe intent here was to start standardizing the responses from Northstar. In particular, the focus was on a handful of responses that just replied back with a string as opposed to an object or array like some other responses did.\r\n\r\nResponses affected:\r\n- login\r\n- logout\r\n- user delete\r\n\r\nWhere a response would previously just reply back with a string, now it'll be structured like:\r\n```\r\n{\r\n  status: {\r\n    \"message\": \"This is the error/success message\"\r\n  }\r\n}\r\n```\r\n\r\nWhere a response would've replied back with an object, now it'll assign it to a \"data\" field in an object. The only response affected by this PR right now is on a successful login.\r\n```\r\n{\r\n  \"data\": <User object>\r\n}\r\n```\r\n\r\n#### What are the relevant tickets?\r\n#84\r\n\r\n#### Questions\r\nThis is a breaking change for any client code that uses these endpoints right now. So for example, login on the mobile apps will be broken until they get updated to support the new structure. This is sorta why I held off on updating _all_ the responses.\r\n\r\nThat being said, should we just go ahead and update all of them right now? This might be more of a question for the iOS and Android devs.\r\n\r\ncc: @DFurnes @aaronschachter "},"comment":{"url":"https://api.github.com/repos/DoSomething/northstar/issues/comments/103164783","html_url":"https://github.com/DoSomething/northstar/pull/125#issuecomment-103164783","issue_url":"https://api.github.com/repos/DoSomething/northstar/issues/125","id":103164783,"user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T18:36:09Z","updated_at":"2015-05-18T18:36:09Z","body":"Would it be helpful to make a `$this->respondPaginated($eloquent)` method that takes an Eloquent query object, so that we can set common pagination settings in one place?"}}