{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2355","labels_url":"https://api.github.com/repos/nodejs/node/issues/2355/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2355/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2355/events","html_url":"https://github.com/nodejs/node/pull/2355","id":100455193,"number":2355,"title":"FAST HTTP YEAH","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/http","name":"http","color":"c7def8"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-08-12T03:08:16Z","updated_at":"2015-08-12T22:42:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/2355","html_url":"https://github.com/nodejs/node/pull/2355","diff_url":"https://github.com/nodejs/node/pull/2355.diff","patch_url":"https://github.com/nodejs/node/pull/2355.patch"},"body":"# PLEASE DO NOT LAND THIS YET\r\n\r\n_Depends on: https://github.com/nodejs/node/pull/2351_\r\n\r\nI just want to kick off the discussion of where this path may lead us. With this change http Server will consume all data from the net.Socket, skipping its `data` events, and the server will parse this data directly without going to JS-land and without allocating Buffer instances.\r\n\r\nFrom my local benchmarks (simple server, GET requests):\r\n\r\n* Performance is 20% better with empty body on GET requests\r\n* 10% better with 16kb body, still on GET requests\r\n\r\nI'm yet to run our benchmarks on some server (or my laptop) to see what general effects this patch has on everything, but I think it should be mostly an improvement, not degradation.\r\n\r\nThe downside of this thing is absence of `data` events on the `net.Socket`. We will also need to handle the cases where the socket is not a `net.Socket` instance after all, which might appear in user-land modules.\r\n\r\nPlease leave your feedback here.\r\n\r\ncc @bnoordhuis @trevnorris @nodejs/collaborators "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/130469707","html_url":"https://github.com/nodejs/node/pull/2355#issuecomment-130469707","issue_url":"https://api.github.com/repos/nodejs/node/issues/2355","id":130469707,"user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T22:42:56Z","updated_at":"2015-08-12T22:42:56Z","body":"I think this PR is finished at the moment, PTAL"}}