{"action":"created","comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/37481671","id":37481671,"diff_hunk":"@@ -51,6 +52,7 @@ struct NodeBasedEdge\n     NodeID target;\n     NodeID name_id;\n     EdgeWeight weight;\n+    EdgeWeight duration;","path":"data_structures/import_edge.hpp","position":12,"original_position":12,"commit_id":"42b86b86ddc547c0ffbbeb714aab336e129bc867","original_commit_id":"42b86b86ddc547c0ffbbeb714aab336e129bc867","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"body":"Why the manual padding below, but not doing proper padding here?","created_at":"2015-08-19T23:35:25Z","updated_at":"2015-08-19T23:35:25Z","html_url":"https://github.com/Project-OSRM/osrm-backend/pull/1614#discussion_r37481671","pull_request_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614","_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/37481671"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/1614#discussion_r37481671"},"pull_request":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614"}}},"pull_request":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614","id":42842633,"html_url":"https://github.com/Project-OSRM/osrm-backend/pull/1614","diff_url":"https://github.com/Project-OSRM/osrm-backend/pull/1614.diff","patch_url":"https://github.com/Project-OSRM/osrm-backend/pull/1614.patch","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1614","number":1614,"state":"open","locked":false,"title":"[Not ready] Weight edges","user":{"login":"Tristramg","id":12235,"avatar_url":"https://avatars.githubusercontent.com/u/12235?v=3","gravatar_id":"","url":"https://api.github.com/users/Tristramg","html_url":"https://github.com/Tristramg","followers_url":"https://api.github.com/users/Tristramg/followers","following_url":"https://api.github.com/users/Tristramg/following{/other_user}","gists_url":"https://api.github.com/users/Tristramg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tristramg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tristramg/subscriptions","organizations_url":"https://api.github.com/users/Tristramg/orgs","repos_url":"https://api.github.com/users/Tristramg/repos","events_url":"https://api.github.com/users/Tristramg/events{/privacy}","received_events_url":"https://api.github.com/users/Tristramg/received_events","type":"User","site_admin":false},"body":"We want to be able to compute the optimal route according to an arbitrary objective and not only the duration (e.g. avoid a road with heavy traffic on a bike).\r\n\r\nThe usual trick is to modify the speed to penalize unwanted ways. The problem is that is produces bad duration estimations.\r\n\r\nThis PR fixes that by keeping the duration to output it correctly.\r\n\r\nIn the lua profile, it is possible to define a `forward_weight` (or `backward_weight`) on the way. That value will be used for the route computation, but the duration will be returned. If that weight is not given, it fallbacks on the speed. Existing profiles continue to work.\r\n\r\nIt is not ready:\r\n\r\n- [ ] phantom nodes are not evaluated\r\n- [ ] memory consumption should be measured and minimized\r\n- [x] tests are broken :sweat_smile: \r\n- [ ] it is not tested\r\n- [ ] maybe it could be more generic","created_at":"2015-08-19T17:41:06Z","updated_at":"2015-08-19T23:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1249f38b0591cc898986b6def523ee4163d8e8b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614/commits","review_comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614/comments","review_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1614/comments","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/42b86b86ddc547c0ffbbeb714aab336e129bc867","head":{"label":"Tristramg:weight_edges","ref":"weight_edges","sha":"42b86b86ddc547c0ffbbeb714aab336e129bc867","user":{"login":"Tristramg","id":12235,"avatar_url":"https://avatars.githubusercontent.com/u/12235?v=3","gravatar_id":"","url":"https://api.github.com/users/Tristramg","html_url":"https://github.com/Tristramg","followers_url":"https://api.github.com/users/Tristramg/followers","following_url":"https://api.github.com/users/Tristramg/following{/other_user}","gists_url":"https://api.github.com/users/Tristramg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tristramg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tristramg/subscriptions","organizations_url":"https://api.github.com/users/Tristramg/orgs","repos_url":"https://api.github.com/users/Tristramg/repos","events_url":"https://api.github.com/users/Tristramg/events{/privacy}","received_events_url":"https://api.github.com/users/Tristramg/received_events","type":"User","site_admin":false},"repo":{"id":40753705,"name":"osrm-backend","full_name":"Tristramg/osrm-backend","owner":{"login":"Tristramg","id":12235,"avatar_url":"https://avatars.githubusercontent.com/u/12235?v=3","gravatar_id":"","url":"https://api.github.com/users/Tristramg","html_url":"https://github.com/Tristramg","followers_url":"https://api.github.com/users/Tristramg/followers","following_url":"https://api.github.com/users/Tristramg/following{/other_user}","gists_url":"https://api.github.com/users/Tristramg/gists{/gist_id}","starred_url":"https://api.github.com/users/Tristramg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tristramg/subscriptions","organizations_url":"https://api.github.com/users/Tristramg/orgs","repos_url":"https://api.github.com/users/Tristramg/repos","events_url":"https://api.github.com/users/Tristramg/events{/privacy}","received_events_url":"https://api.github.com/users/Tristramg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tristramg/osrm-backend","description":"Project OSRM: C++ backend","fork":true,"url":"https://api.github.com/repos/Tristramg/osrm-backend","forks_url":"https://api.github.com/repos/Tristramg/osrm-backend/forks","keys_url":"https://api.github.com/repos/Tristramg/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tristramg/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tristramg/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Tristramg/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Tristramg/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Tristramg/osrm-backend/events","assignees_url":"https://api.github.com/repos/Tristramg/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Tristramg/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Tristramg/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Tristramg/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tristramg/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tristramg/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tristramg/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tristramg/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Tristramg/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Tristramg/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Tristramg/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Tristramg/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Tristramg/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Tristramg/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tristramg/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tristramg/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tristramg/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tristramg/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Tristramg/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tristramg/osrm-backend/merges","archive_url":"https://api.github.com/repos/Tristramg/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tristramg/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Tristramg/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Tristramg/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Tristramg/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Tristramg/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tristramg/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Tristramg/osrm-backend/releases{/id}","created_at":"2015-08-15T09:39:24Z","updated_at":"2015-08-15T09:39:25Z","pushed_at":"2015-08-19T18:23:48Z","git_url":"git://github.com/Tristramg/osrm-backend.git","ssh_url":"git@github.com:Tristramg/osrm-backend.git","clone_url":"https://github.com/Tristramg/osrm-backend.git","svn_url":"https://github.com/Tristramg/osrm-backend","homepage":"http://map.project-osrm.org","size":23023,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Project-OSRM:develop","ref":"develop","sha":"92956f2b455febba157758e707e4a0bb1aa9e9c9","user":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"repo":{"id":2436255,"name":"osrm-backend","full_name":"Project-OSRM/osrm-backend","owner":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-OSRM/osrm-backend","description":"Project OSRM: C++ backend","fork":false,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend","forks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/forks","keys_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/events","assignees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/merges","archive_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/releases{/id}","created_at":"2011-09-22T10:05:08Z","updated_at":"2015-08-18T20:47:41Z","pushed_at":"2015-08-19T22:59:10Z","git_url":"git://github.com/Project-OSRM/osrm-backend.git","ssh_url":"git@github.com:Project-OSRM/osrm-backend.git","clone_url":"https://github.com/Project-OSRM/osrm-backend.git","svn_url":"https://github.com/Project-OSRM/osrm-backend","homepage":"http://map.project-osrm.org","size":23023,"stargazers_count":864,"watchers_count":864,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":210,"forks":323,"open_issues":210,"watchers":864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/1614"},"issue":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1614"},"comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/1614/comments"},"review_comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614/comments"},"review_comment":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/1614/commits"},"statuses":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/42b86b86ddc547c0ffbbeb714aab336e129bc867"}}}}