{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/26341555","id":26341555,"diff_hunk":"@@ -278,7 +313,31 @@ exports.getServers = function() {\n };\n \n \n-exports.setServers = function(servers) {\n+exports.setServers = function setServers(servers) {","path":"lib/dns.js","position":106,"original_position":106,"commit_id":"ee5056f7cf8ddb6c5d642cd1239a127b8648bad6","original_commit_id":"ee5056f7cf8ddb6c5d642cd1239a127b8648bad6","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"body":"this is no longer guaranteed to `throw` synchronously if there is a problem setting the servers list; perhaps this is a breaking change that makes this PR unworkable?","created_at":"2015-03-12T20:33:34Z","updated_at":"2015-03-12T20:33:34Z","html_url":"https://github.com/iojs/io.js/pull/1132#discussion_r26341555","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/26341555"},"html":{"href":"https://github.com/iojs/io.js/pull/1132#discussion_r26341555"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1132","id":31072776,"html_url":"https://github.com/iojs/io.js/pull/1132","diff_url":"https://github.com/iojs/io.js/pull/1132.diff","patch_url":"https://github.com/iojs/io.js/pull/1132.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1132","number":1132,"state":"open","locked":false,"title":"dns: gate setServers to avoid async cares conflicts","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"body":"Use an EE with some state data to gate async resolution operations in c-ares so that setServers() can run independently.\r\n\r\nLikely a temporary fix for https://github.com/iojs/io.js/issues/894 with a better solution being to fix c-ares to do this without barfing.\r\n\r\nI have no perf data on this, would appreciate insight from others.\r\n\r\nFrankly I'm just sick of seeing this item in \"Known issues\" with each release, crashing is not really acceptable.\r\n\r\nThoughts anyone?","created_at":"2015-03-12T20:10:16Z","updated_at":"2015-03-12T20:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b88a2c381654055a85c188f9e4086f60262f60e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1132/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/ee5056f7cf8ddb6c5d642cd1239a127b8648bad6","head":{"label":"rvagg:dns-setserver-async-gate","ref":"dns-setserver-async-gate","sha":"ee5056f7cf8ddb6c5d642cd1239a127b8648bad6","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"repo":{"id":27289064,"name":"io.js","full_name":"rvagg/io.js","owner":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvagg/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/rvagg/io.js","forks_url":"https://api.github.com/repos/rvagg/io.js/forks","keys_url":"https://api.github.com/repos/rvagg/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvagg/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvagg/io.js/teams","hooks_url":"https://api.github.com/repos/rvagg/io.js/hooks","issue_events_url":"https://api.github.com/repos/rvagg/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/rvagg/io.js/events","assignees_url":"https://api.github.com/repos/rvagg/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/rvagg/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/rvagg/io.js/tags","blobs_url":"https://api.github.com/repos/rvagg/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvagg/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvagg/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvagg/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvagg/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/rvagg/io.js/languages","stargazers_url":"https://api.github.com/repos/rvagg/io.js/stargazers","contributors_url":"https://api.github.com/repos/rvagg/io.js/contributors","subscribers_url":"https://api.github.com/repos/rvagg/io.js/subscribers","subscription_url":"https://api.github.com/repos/rvagg/io.js/subscription","commits_url":"https://api.github.com/repos/rvagg/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvagg/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvagg/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvagg/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvagg/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/rvagg/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvagg/io.js/merges","archive_url":"https://api.github.com/repos/rvagg/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvagg/io.js/downloads","issues_url":"https://api.github.com/repos/rvagg/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/rvagg/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/rvagg/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/rvagg/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvagg/io.js/labels{/name}","releases_url":"https://api.github.com/repos/rvagg/io.js/releases{/id}","created_at":"2014-11-29T02:36:43Z","updated_at":"2015-01-11T18:25:26Z","pushed_at":"2015-03-12T20:11:26Z","git_url":"git://github.com/rvagg/io.js.git","ssh_url":"git@github.com:rvagg/io.js.git","clone_url":"https://github.com/rvagg/io.js.git","svn_url":"https://github.com/rvagg/io.js","homepage":null,"size":121400,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"v0.12"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"41c9daa143d1675a7b960e9fd4c1671672d5d7e0","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-03-12T19:36:51Z","pushed_at":"2015-03-11T19:02:06Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":156272,"stargazers_count":11016,"watchers_count":11016,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":713,"mirror_url":null,"open_issues_count":187,"forks":713,"open_issues":187,"watchers":11016,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1132"},"html":{"href":"https://github.com/iojs/io.js/pull/1132"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/1132"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/ee5056f7cf8ddb6c5d642cd1239a127b8648bad6"}}}}