{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/3695","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/3695/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3695/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/3695/events","html_url":"https://github.com/kripken/emscripten/issues/3695","id":101622112,"number":3695,"title":"Stripping down js_optimize.py","user":{"login":"waywardmonkeys","id":178582,"avatar_url":"https://avatars.githubusercontent.com/u/178582?v=3","gravatar_id":"","url":"https://api.github.com/users/waywardmonkeys","html_url":"https://github.com/waywardmonkeys","followers_url":"https://api.github.com/users/waywardmonkeys/followers","following_url":"https://api.github.com/users/waywardmonkeys/following{/other_user}","gists_url":"https://api.github.com/users/waywardmonkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/waywardmonkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waywardmonkeys/subscriptions","organizations_url":"https://api.github.com/users/waywardmonkeys/orgs","repos_url":"https://api.github.com/users/waywardmonkeys/repos","events_url":"https://api.github.com/users/waywardmonkeys/events{/privacy}","received_events_url":"https://api.github.com/users/waywardmonkeys/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-18T10:18:38Z","updated_at":"2015-08-18T20:06:22Z","closed_at":null,"body":"I'd like to remove some code paths from ``js_optimize.py`` so that we can report errors better / more correctly. This is in reaction to my having to spend some time debugging something where if ``js_optimize.py`` had failed more clearly, it would've been a lot easier.\r\n\r\n* Do we need ``just_split``? I suspect that we do.\r\n* Do we need ``know_generated``? I suspect that we don't. Removing this would let me handle an error situation a lot better (and would've saved me a good bit of time).\r\n"},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/132334554","html_url":"https://github.com/kripken/emscripten/issues/3695#issuecomment-132334554","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3695","id":132334554,"user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T20:06:22Z","updated_at":"2015-08-18T20:06:22Z","body":" * Yes, I believe we use `just_split` that when receiving JSON instead of JS, or vice versa. It was added when we added JSON support.\r\n * Yes, I believe we always know generated. The only exception might be when we run `cleanup` which runs on the entire code, just parsing and unparsing it to clean it up. But I don't think that should stop you from removing `know_generated`, as we do the `cleanup` thing in a special way anyhow in that file.\r\n"}}