{"action":"created","issue":{"url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/36","labels_url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/36/comments","events_url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/36/events","html_url":"https://github.com/kevin-hirsch/KVNProgress/issues/36","id":68918534,"number":36,"title":"Adding Animated Flag To Presentation (show) And Dismissing (hide)","user":{"login":"joeblau","id":1218847,"avatar_url":"https://avatars.githubusercontent.com/u/1218847?v=3","gravatar_id":"","url":"https://api.github.com/users/joeblau","html_url":"https://github.com/joeblau","followers_url":"https://api.github.com/users/joeblau/followers","following_url":"https://api.github.com/users/joeblau/following{/other_user}","gists_url":"https://api.github.com/users/joeblau/gists{/gist_id}","starred_url":"https://api.github.com/users/joeblau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeblau/subscriptions","organizations_url":"https://api.github.com/users/joeblau/orgs","repos_url":"https://api.github.com/users/joeblau/repos","events_url":"https://api.github.com/users/joeblau/events{/privacy}","received_events_url":"https://api.github.com/users/joeblau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-16T12:59:30Z","updated_at":"2015-04-29T19:23:20Z","closed_at":null,"body":"I was thinking about modifying this library to allow toggling of animations like iOS's native UI View Controllers.  Right now the KVNLayoutAnimationDuration property is not exposed and what I'm proposing would be a major version point release breaking change.\r\n\r\nEssentially, I want to propose adding an animated flag to all shows/dismisses in KVN just like apple exposes on its [View Controller](https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/#//apple_ref/occ/instm/UIViewController/presentViewController:animated:completion:) presentation\r\n```objective-c\r\n// Present\r\n- (void)presentViewController:(UIViewController *)viewControllerToPresent\r\n                     animated:(BOOL)flag\r\n                   completion:(void (^)(void))completion\r\n// Dismiss\r\n- (void)dismissViewControllerAnimated:(BOOL)flag\r\n                           completion:(void (^)(void))completion\r\n```\r\n\r\nWith an `animated` property, I'm proposing changing all of the show/hide calls of KVN to have an animated property.  Like I mentioned above, this would break anyone using a 2.x version of the application so it would also require a version bump.\r\n\r\nWhat do you think about this?"},"comment":{"url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/comments/97550358","html_url":"https://github.com/kevin-hirsch/KVNProgress/issues/36#issuecomment-97550358","issue_url":"https://api.github.com/repos/kevin-hirsch/KVNProgress/issues/36","id":97550358,"user":{"login":"kevin-hirsch","id":2794684,"avatar_url":"https://avatars.githubusercontent.com/u/2794684?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-hirsch","html_url":"https://github.com/kevin-hirsch","followers_url":"https://api.github.com/users/kevin-hirsch/followers","following_url":"https://api.github.com/users/kevin-hirsch/following{/other_user}","gists_url":"https://api.github.com/users/kevin-hirsch/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-hirsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-hirsch/subscriptions","organizations_url":"https://api.github.com/users/kevin-hirsch/orgs","repos_url":"https://api.github.com/users/kevin-hirsch/repos","events_url":"https://api.github.com/users/kevin-hirsch/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-hirsch/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T19:23:20Z","updated_at":"2015-04-29T19:23:20Z","body":"Hello @joeblau,\r\n\r\nThank you for your proposal. I am just wondering what could be the benefit of that. Why would we want to show the HUD in a non animated way? Do you need this feature for something special?\r\nAlso, when possible, I would like to keep `KVNProgress` calls shorts (`[KVNProgress show]`, `[KVNProgress dismiss]`, `[KVNProgress showWithStatus:@\"\"]`)."}}