{"action":"created","comment":{"url":"https://api.github.com/repos/GPII/universal/pulls/comments/27906298","id":27906298,"diff_hunk":"@@ -164,5 +164,131 @@\n                 }\n             }\n         ]\n+    },\n+    \"eu.gpii.olb\": {\n+        \"name\": \"Online Banking Demonstrator\",\n+        \"contexts\": {\n+            \"OS\": [\n+                {\n+                    \"id\": \"web\"\n+                }\n+            ]\n+        },\n+        \"settingsHandlers\": [\n+            {\n+                \"type\": \"gpii.settingsHandlers.noSettings\",\n+                \"capabilities\": [\n+                    \"applications.eu\\\\.gpii\\\\.olb.id\",\n+                    \"display.applications.eu\\\\.gpii\\\\.olb.name\",\n+                    \"language\",\n+                    \"textSize\",\n+                    \"toc\",\n+                    \"links\",\n+                    \"contrastTheme\",\n+                    \"signLanguageEnabled\",\n+                    \"signLanguage\",\n+                    \"interpreterType\",\n+                    \"pictogramEnabled\",\n+                    \"pictogramMode\",\n+                    \"pictogramSymbolSet\"\n+                ],\n+                \"capabilitiesTransformations\": {\n+                    \"language\": \"http://registry\\\\.gpii\\\\.net/common/language\",\n+                    \"textSize\": {\n+                        \"transform\": {\n+                            \"type\": \"fluid.transforms.binaryOp\",\n+                            \"leftPath\": \"http://registry\\\\.gpii\\\\.net/common/fontSize\",\n+                            \"operator\": \"/\",\n+                            \"right\": 12\n+                        }\n+                    },\n+                    \"toc\": {\n+                        \"transform\": {\n+                            \"type\": \"fluid.transforms.valueMapper\",\n+                            \"inputPath\": \"http://registry\\\\.gpii\\\\.net/common/navigationAdaptation\",\n+                            \"options\": {\n+                                \"showToC\": {\n+                                    \"outputValue\": true\n+                                },\n+                                \"default\": {\n+                                    \"outputValue\": false\n+                                }\n+                            }\n+                        }\n+                    },\n+                    \"links\": {\n+                        \"transform\": {\n+                            \"type\": \"fluid.transforms.valueMapper\",\n+                            \"inputPath\": \"http://registry\\\\.gpii\\\\.net/common/linkAdaptation\",\n+                            \"options\": {\n+                                \"emphasizeLinks\": {\n+                                    \"outputValue\": true\n+                                }\n+                            }\n+                        }\n+                    },\n+                    \"contrastTheme\": {\n+                        \"transform\": {\n+                            \"type\": \"fluid.transforms.condition\",\n+                            \"conditionPath\": \"http://registry\\\\.gpii\\\\.net/common/highContrastEnabled\",\n+                            \"true\": {\n+                                \"transform\": {\n+                                    \"type\": \"fluid.transforms.valueMapper\",\n+                                    \"inputPath\": \"http://registry\\\\.gpii\\\\.net/common/highContrastTheme\",\n+                                    \"defaultInputValue\": \"default\",\n+                                    \"options\": {\n+                                        \"black-white\": {\n+                                            \"outputValue\": \"bw\"\n+                                        },\n+                                        \"white-black\": {\n+                                            \"outputValue\": \"wb\"\n+                                        },\n+                                        \"black-yellow\": {\n+                                            \"outputValue\": \"by\"\n+                                        },\n+                                        \"yellow-black\": {\n+                                            \"outputValue\": \"yb\"\n+                                        }\n+                                    }\n+                                }\n+                            }\n+                        }\n+                    },\n+                    \"signLanguageEnabled\": \"http://registry\\\\.gpii\\\\.net/common/signLanguageEnabled\",\n+                    \"signLanguage\": {\n+                        \"transform\": {\n+                            \"type\": \"fluid.transforms.valueMapper\",\n+                            \"inputPath\": \"http://registry\\\\.gpii\\\\.net/common/signLanguage\",\n+                            \"options\": {\n+                                \"ase\": {\n+                                    \"outputValue\": \"ase\"\n+                                },\n+                                \"gsg\": {\n+                                    \"outputValue\": \"gsg\"\n+                                },\n+                                \"ils\": {\n+                                    \"outputValue\": \"ils\"\n+                                }\n+                            }\n+                        }\n+                    },","path":"testData/solutions/web.json","position":112,"original_position":111,"commit_id":"f62fd3e362be21773bbd5989b90a049ddc6192b6","original_commit_id":"b0eed40a04a5a43d2145ad3a421511dd12112c10","user":{"login":"cstrobbe","id":1943277,"avatar_url":"https://avatars.githubusercontent.com/u/1943277?v=3","gravatar_id":"","url":"https://api.github.com/users/cstrobbe","html_url":"https://github.com/cstrobbe","followers_url":"https://api.github.com/users/cstrobbe/followers","following_url":"https://api.github.com/users/cstrobbe/following{/other_user}","gists_url":"https://api.github.com/users/cstrobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrobbe/subscriptions","organizations_url":"https://api.github.com/users/cstrobbe/orgs","repos_url":"https://api.github.com/users/cstrobbe/repos","events_url":"https://api.github.com/users/cstrobbe/events{/privacy}","received_events_url":"https://api.github.com/users/cstrobbe/received_events","type":"User","site_admin":false},"body":"I have now added \r\n  \"defaultInputValue\": \"ils\",\r\nto the valueMapper.\r\n\r\n(I found this feature in several transformations for Linux, e.g. https://github.com/GPII/universal/blob/master/testData/solutions/linux.json#L40.)\r\n\r\nHowever, this has an unintended side effect: the transformer now outputs \"ils\" when the preference signLanguage (as a common term) is not present in a preference set. Is this the intended behaviour of this valueMapper feature? I would expect no output when the preference is not expressed in the NP set. \r\nI could not find this documented at http://wiki.gpii.net/w/Architecture_-_Available_transformation_functions#Using_the_valueMapper_to_convert_to.2Ffrom_enumerated_sets_of_values. ","created_at":"2015-04-07T18:29:33Z","updated_at":"2015-04-07T18:29:33Z","html_url":"https://github.com/GPII/universal/pull/286#discussion_r27906298","pull_request_url":"https://api.github.com/repos/GPII/universal/pulls/286","_links":{"self":{"href":"https://api.github.com/repos/GPII/universal/pulls/comments/27906298"},"html":{"href":"https://github.com/GPII/universal/pull/286#discussion_r27906298"},"pull_request":{"href":"https://api.github.com/repos/GPII/universal/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/GPII/universal/pulls/286","id":25453394,"html_url":"https://github.com/GPII/universal/pull/286","diff_url":"https://github.com/GPII/universal/pull/286.diff","patch_url":"https://github.com/GPII/universal/pull/286.patch","issue_url":"https://api.github.com/repos/GPII/universal/issues/286","number":286,"state":"open","locked":false,"title":"GPII-875: Online Banking initial integration","user":{"login":"cstrobbe","id":1943277,"avatar_url":"https://avatars.githubusercontent.com/u/1943277?v=3","gravatar_id":"","url":"https://api.github.com/users/cstrobbe","html_url":"https://github.com/cstrobbe","followers_url":"https://api.github.com/users/cstrobbe/followers","following_url":"https://api.github.com/users/cstrobbe/following{/other_user}","gists_url":"https://api.github.com/users/cstrobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrobbe/subscriptions","organizations_url":"https://api.github.com/users/cstrobbe/orgs","repos_url":"https://api.github.com/users/cstrobbe/repos","events_url":"https://api.github.com/users/cstrobbe/events{/privacy}","received_events_url":"https://api.github.com/users/cstrobbe/received_events","type":"User","site_admin":false},"body":"Web and Win32 entries for the Online Banking Demonstrator. There is currently only one transformer, i.e. for language. Once the infrastructure for the four-layer adaptation is available, the integration will need to be modified, but this pull request should bring us closer to a web app that can be demonstrated. \r\n\r\nThis pull request replaces the older one at https://github.com/GPII/universal/pull/265 , which dated from before the \"fireball\". ","created_at":"2014-12-03T21:31:32Z","updated_at":"2015-04-07T18:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b83e3dcf8a166abe910b91c6211aff3b395629","assignee":{"login":"colinbdclark","id":558076,"avatar_url":"https://avatars.githubusercontent.com/u/558076?v=3","gravatar_id":"","url":"https://api.github.com/users/colinbdclark","html_url":"https://github.com/colinbdclark","followers_url":"https://api.github.com/users/colinbdclark/followers","following_url":"https://api.github.com/users/colinbdclark/following{/other_user}","gists_url":"https://api.github.com/users/colinbdclark/gists{/gist_id}","starred_url":"https://api.github.com/users/colinbdclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinbdclark/subscriptions","organizations_url":"https://api.github.com/users/colinbdclark/orgs","repos_url":"https://api.github.com/users/colinbdclark/repos","events_url":"https://api.github.com/users/colinbdclark/events{/privacy}","received_events_url":"https://api.github.com/users/colinbdclark/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GPII/universal/pulls/286/commits","review_comments_url":"https://api.github.com/repos/GPII/universal/pulls/286/comments","review_comment_url":"https://api.github.com/repos/GPII/universal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPII/universal/issues/286/comments","statuses_url":"https://api.github.com/repos/GPII/universal/statuses/f62fd3e362be21773bbd5989b90a049ddc6192b6","head":{"label":"cstrobbe:patch-16","ref":"patch-16","sha":"f62fd3e362be21773bbd5989b90a049ddc6192b6","user":{"login":"cstrobbe","id":1943277,"avatar_url":"https://avatars.githubusercontent.com/u/1943277?v=3","gravatar_id":"","url":"https://api.github.com/users/cstrobbe","html_url":"https://github.com/cstrobbe","followers_url":"https://api.github.com/users/cstrobbe/followers","following_url":"https://api.github.com/users/cstrobbe/following{/other_user}","gists_url":"https://api.github.com/users/cstrobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrobbe/subscriptions","organizations_url":"https://api.github.com/users/cstrobbe/orgs","repos_url":"https://api.github.com/users/cstrobbe/repos","events_url":"https://api.github.com/users/cstrobbe/events{/privacy}","received_events_url":"https://api.github.com/users/cstrobbe/received_events","type":"User","site_admin":false},"repo":{"id":17978764,"name":"universal","full_name":"cstrobbe/universal","owner":{"login":"cstrobbe","id":1943277,"avatar_url":"https://avatars.githubusercontent.com/u/1943277?v=3","gravatar_id":"","url":"https://api.github.com/users/cstrobbe","html_url":"https://github.com/cstrobbe","followers_url":"https://api.github.com/users/cstrobbe/followers","following_url":"https://api.github.com/users/cstrobbe/following{/other_user}","gists_url":"https://api.github.com/users/cstrobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrobbe/subscriptions","organizations_url":"https://api.github.com/users/cstrobbe/orgs","repos_url":"https://api.github.com/users/cstrobbe/repos","events_url":"https://api.github.com/users/cstrobbe/events{/privacy}","received_events_url":"https://api.github.com/users/cstrobbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cstrobbe/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":true,"url":"https://api.github.com/repos/cstrobbe/universal","forks_url":"https://api.github.com/repos/cstrobbe/universal/forks","keys_url":"https://api.github.com/repos/cstrobbe/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cstrobbe/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cstrobbe/universal/teams","hooks_url":"https://api.github.com/repos/cstrobbe/universal/hooks","issue_events_url":"https://api.github.com/repos/cstrobbe/universal/issues/events{/number}","events_url":"https://api.github.com/repos/cstrobbe/universal/events","assignees_url":"https://api.github.com/repos/cstrobbe/universal/assignees{/user}","branches_url":"https://api.github.com/repos/cstrobbe/universal/branches{/branch}","tags_url":"https://api.github.com/repos/cstrobbe/universal/tags","blobs_url":"https://api.github.com/repos/cstrobbe/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cstrobbe/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cstrobbe/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/cstrobbe/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cstrobbe/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/cstrobbe/universal/languages","stargazers_url":"https://api.github.com/repos/cstrobbe/universal/stargazers","contributors_url":"https://api.github.com/repos/cstrobbe/universal/contributors","subscribers_url":"https://api.github.com/repos/cstrobbe/universal/subscribers","subscription_url":"https://api.github.com/repos/cstrobbe/universal/subscription","commits_url":"https://api.github.com/repos/cstrobbe/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/cstrobbe/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/cstrobbe/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/cstrobbe/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/cstrobbe/universal/contents/{+path}","compare_url":"https://api.github.com/repos/cstrobbe/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cstrobbe/universal/merges","archive_url":"https://api.github.com/repos/cstrobbe/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cstrobbe/universal/downloads","issues_url":"https://api.github.com/repos/cstrobbe/universal/issues{/number}","pulls_url":"https://api.github.com/repos/cstrobbe/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/cstrobbe/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/cstrobbe/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cstrobbe/universal/labels{/name}","releases_url":"https://api.github.com/repos/cstrobbe/universal/releases{/id}","created_at":"2014-03-21T12:08:23Z","updated_at":"2014-08-20T23:40:29Z","pushed_at":"2015-04-07T18:24:09Z","git_url":"git://github.com/cstrobbe/universal.git","ssh_url":"git@github.com:cstrobbe/universal.git","clone_url":"https://github.com/cstrobbe/universal.git","svn_url":"https://github.com/cstrobbe/universal","homepage":"gpii.net","size":90604,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"GPII:master","ref":"master","sha":"b278659b9a7ff9530a05690ca4e48b9778db6c71","user":{"login":"GPII","id":1343050,"avatar_url":"https://avatars.githubusercontent.com/u/1343050?v=3","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"repo":{"id":3623720,"name":"universal","full_name":"GPII/universal","owner":{"login":"GPII","id":1343050,"avatar_url":"https://avatars.githubusercontent.com/u/1343050?v=3","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GPII/universal","description":"Cross platform, core components of the GPII personalization infrastructure","fork":false,"url":"https://api.github.com/repos/GPII/universal","forks_url":"https://api.github.com/repos/GPII/universal/forks","keys_url":"https://api.github.com/repos/GPII/universal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPII/universal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPII/universal/teams","hooks_url":"https://api.github.com/repos/GPII/universal/hooks","issue_events_url":"https://api.github.com/repos/GPII/universal/issues/events{/number}","events_url":"https://api.github.com/repos/GPII/universal/events","assignees_url":"https://api.github.com/repos/GPII/universal/assignees{/user}","branches_url":"https://api.github.com/repos/GPII/universal/branches{/branch}","tags_url":"https://api.github.com/repos/GPII/universal/tags","blobs_url":"https://api.github.com/repos/GPII/universal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPII/universal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPII/universal/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPII/universal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPII/universal/statuses/{sha}","languages_url":"https://api.github.com/repos/GPII/universal/languages","stargazers_url":"https://api.github.com/repos/GPII/universal/stargazers","contributors_url":"https://api.github.com/repos/GPII/universal/contributors","subscribers_url":"https://api.github.com/repos/GPII/universal/subscribers","subscription_url":"https://api.github.com/repos/GPII/universal/subscription","commits_url":"https://api.github.com/repos/GPII/universal/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPII/universal/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPII/universal/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPII/universal/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPII/universal/contents/{+path}","compare_url":"https://api.github.com/repos/GPII/universal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPII/universal/merges","archive_url":"https://api.github.com/repos/GPII/universal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPII/universal/downloads","issues_url":"https://api.github.com/repos/GPII/universal/issues{/number}","pulls_url":"https://api.github.com/repos/GPII/universal/pulls{/number}","milestones_url":"https://api.github.com/repos/GPII/universal/milestones{/number}","notifications_url":"https://api.github.com/repos/GPII/universal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPII/universal/labels{/name}","releases_url":"https://api.github.com/repos/GPII/universal/releases{/id}","created_at":"2012-03-05T04:01:44Z","updated_at":"2015-04-04T09:23:17Z","pushed_at":"2015-04-07T18:24:10Z","git_url":"git://github.com/GPII/universal.git","ssh_url":"git@github.com:GPII/universal.git","clone_url":"https://github.com/GPII/universal.git","svn_url":"https://github.com/GPII/universal","homepage":"gpii.net","size":93888,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":39,"forks":46,"open_issues":39,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GPII/universal/pulls/286"},"html":{"href":"https://github.com/GPII/universal/pull/286"},"issue":{"href":"https://api.github.com/repos/GPII/universal/issues/286"},"comments":{"href":"https://api.github.com/repos/GPII/universal/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/GPII/universal/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/GPII/universal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPII/universal/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/GPII/universal/statuses/f62fd3e362be21773bbd5989b90a049ddc6192b6"}}}}