{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/45099550","id":45099550,"diff_hunk":"@@ -87,6 +94,17 @@ class SimpleAclAuthorizer extends Authorizer with Logging {\n       case str: String if str.nonEmpty => str.split(\",\").map(s => KafkaPrincipal.fromString(s.trim)).toSet\n     }.getOrElse(Set.empty[KafkaPrincipal])\n \n+    def getInstanceForConfig(configName: String): Option[Nothing] = {\n+      configs.get(configName).collect {\n+        case str: String if str.nonEmpty => CoreUtils.createObject(str)\n+      }\n+    }\n+    principalToLocalPlugin = getInstanceForConfig(SimpleAclAuthorizer.PrincipalToLocalProp)","path":"core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala","position":43,"original_position":43,"commit_id":"46cd2505ec9d7cb39ea906f8a84ad5384c45a85a","original_commit_id":"46cd2505ec9d7cb39ea906f8a84ad5384c45a85a","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"Thanks, I will file a jira and raise a PR.","created_at":"2015-11-17T18:35:36Z","updated_at":"2015-11-17T18:35:36Z","html_url":"https://github.com/apache/kafka/pull/483#discussion_r45099550","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/483","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/45099550"},"html":{"href":"https://github.com/apache/kafka/pull/483#discussion_r45099550"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/483","id":50218490,"html_url":"https://github.com/apache/kafka/pull/483","diff_url":"https://github.com/apache/kafka/pull/483.diff","patch_url":"https://github.com/apache/kafka/pull/483.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/483","number":483,"state":"open","locked":false,"title":"Kafka-2794: Added group support to authorizer.","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-10T06:20:38Z","updated_at":"2015-11-17T18:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de02b30a1c44b70c64bd64da116763084e3ab96e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/483/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/483/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/483/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/46cd2505ec9d7cb39ea906f8a84ad5384c45a85a","head":{"label":"Parth-Brahmbhatt:KAFKA-2794","ref":"KAFKA-2794","sha":"46cd2505ec9d7cb39ea906f8a84ad5384c45a85a","user":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"repo":{"id":34346413,"name":"kafka","full_name":"Parth-Brahmbhatt/kafka","owner":{"login":"Parth-Brahmbhatt","id":6914358,"avatar_url":"https://avatars.githubusercontent.com/u/6914358?v=3","gravatar_id":"","url":"https://api.github.com/users/Parth-Brahmbhatt","html_url":"https://github.com/Parth-Brahmbhatt","followers_url":"https://api.github.com/users/Parth-Brahmbhatt/followers","following_url":"https://api.github.com/users/Parth-Brahmbhatt/following{/other_user}","gists_url":"https://api.github.com/users/Parth-Brahmbhatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Parth-Brahmbhatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parth-Brahmbhatt/subscriptions","organizations_url":"https://api.github.com/users/Parth-Brahmbhatt/orgs","repos_url":"https://api.github.com/users/Parth-Brahmbhatt/repos","events_url":"https://api.github.com/users/Parth-Brahmbhatt/events{/privacy}","received_events_url":"https://api.github.com/users/Parth-Brahmbhatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Parth-Brahmbhatt/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka","forks_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/forks","keys_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/teams","hooks_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/hooks","issue_events_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/events","assignees_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/tags","blobs_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/languages","stargazers_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/stargazers","contributors_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/contributors","subscribers_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/subscribers","subscription_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/subscription","commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/merges","archive_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/downloads","issues_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/labels{/name}","releases_url":"https://api.github.com/repos/Parth-Brahmbhatt/kafka/releases{/id}","created_at":"2015-04-21T19:00:48Z","updated_at":"2015-09-10T10:18:32Z","pushed_at":"2015-11-14T02:15:18Z","git_url":"git://github.com/Parth-Brahmbhatt/kafka.git","ssh_url":"git@github.com:Parth-Brahmbhatt/kafka.git","clone_url":"https://github.com/Parth-Brahmbhatt/kafka.git","svn_url":"https://github.com/Parth-Brahmbhatt/kafka","homepage":null,"size":25519,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"0.8.2"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"590a4616a1030b3175ba5a548b5f1e1b49c323c2","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-11-17T16:33:18Z","pushed_at":"2015-11-17T17:47:40Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":29635,"stargazers_count":2213,"watchers_count":2213,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1308,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":103,"forks":1308,"open_issues":103,"watchers":2213,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/483"},"html":{"href":"https://github.com/apache/kafka/pull/483"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/483"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/46cd2505ec9d7cb39ea906f8a84ad5384c45a85a"}}}}