{"action":"created","comment":{"url":"https://api.github.com/repos/then/promise/pulls/comments/28506253","id":28506253,"diff_hunk":"@@ -85,25 +87,30 @@ Promise.prototype._handle = function(deferred) {\n   var state = this._state;\n   var value = this._value;\n   asap(function() {\n-    var cb = state === 1 ? deferred.onFulfilled : deferred.onRejected\n+    var cb = state === 1 ? deferred.onFulfilled : deferred.onRejected;\n     if (cb === null) {\n-      (state === 1 ? deferred.promise._resolve(value) : deferred.promise._reject(value))\n-      return\n+      (state === 1\n+        ? deferred.promise._resolve(value)\n+        : deferred.promise._reject(value));\n+      return;\n     }\n     var ret = tryCallOne(cb, value);\n     if (ret === IS_ERROR) {\n-      deferred.promise._reject(LAST_ERROR)\n+      deferred.promise._reject(LAST_ERROR);\n     } else {\n-      deferred.promise._resolve(ret)\n+      deferred.promise._resolve(ret);\n     }\n   });\n };\n Promise.prototype._resolve = function(newValue) {\n-  //Promise Resolution Procedure: https://github.com/promises-aplus/promises-spec#the-promise-resolution-procedure\n+  // Promise Resolution Procedure: http://bit.ly/1IJmVHN","path":"src/core.js","position":59,"original_position":59,"commit_id":"03590f3f72988477515114a6da6d0c443e972d5b","original_commit_id":"03590f3f72988477515114a6da6d0c443e972d5b","user":{"login":"ForbesLindesay","id":1260646,"avatar_url":"https://avatars.githubusercontent.com/u/1260646?v=3","gravatar_id":"","url":"https://api.github.com/users/ForbesLindesay","html_url":"https://github.com/ForbesLindesay","followers_url":"https://api.github.com/users/ForbesLindesay/followers","following_url":"https://api.github.com/users/ForbesLindesay/following{/other_user}","gists_url":"https://api.github.com/users/ForbesLindesay/gists{/gist_id}","starred_url":"https://api.github.com/users/ForbesLindesay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForbesLindesay/subscriptions","organizations_url":"https://api.github.com/users/ForbesLindesay/orgs","repos_url":"https://api.github.com/users/ForbesLindesay/repos","events_url":"https://api.github.com/users/ForbesLindesay/events{/privacy}","received_events_url":"https://api.github.com/users/ForbesLindesay/received_events","type":"User","site_admin":false},"body":"I'd prefer to keep the full original url, even if it results in a longer line.","created_at":"2015-04-16T12:53:26Z","updated_at":"2015-04-16T12:53:26Z","html_url":"https://github.com/then/promise/pull/89#discussion_r28506253","pull_request_url":"https://api.github.com/repos/then/promise/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/then/promise/pulls/comments/28506253"},"html":{"href":"https://github.com/then/promise/pull/89#discussion_r28506253"},"pull_request":{"href":"https://api.github.com/repos/then/promise/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/then/promise/pulls/89","id":33301780,"html_url":"https://github.com/then/promise/pull/89","diff_url":"https://github.com/then/promise/pull/89.diff","patch_url":"https://github.com/then/promise/pull/89.patch","issue_url":"https://api.github.com/repos/then/promise/issues/89","number":89,"state":"open","locked":false,"title":"Code style improvements.","user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"body":"Planning to use this at FB. Fixing up some of the code style: 80 char limit, semicolons.\r\n\r\nI noticed that this git repo is a little inconsistent with semicolons, so I hope it is not controversial to add them everywhere.","created_at":"2015-04-14T21:27:48Z","updated_at":"2015-04-16T12:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79cb89e0ac755370622c00cecc2f542b2d34069a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/then/promise/pulls/89/commits","review_comments_url":"https://api.github.com/repos/then/promise/pulls/89/comments","review_comment_url":"https://api.github.com/repos/then/promise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/then/promise/issues/89/comments","statuses_url":"https://api.github.com/repos/then/promise/statuses/03590f3f72988477515114a6da6d0c443e972d5b","head":{"label":"cpojer:code-style","ref":"code-style","sha":"03590f3f72988477515114a6da6d0c443e972d5b","user":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"repo":{"id":33957445,"name":"promise","full_name":"cpojer/promise","owner":{"login":"cpojer","id":13352,"avatar_url":"https://avatars.githubusercontent.com/u/13352?v=3","gravatar_id":"","url":"https://api.github.com/users/cpojer","html_url":"https://github.com/cpojer","followers_url":"https://api.github.com/users/cpojer/followers","following_url":"https://api.github.com/users/cpojer/following{/other_user}","gists_url":"https://api.github.com/users/cpojer/gists{/gist_id}","starred_url":"https://api.github.com/users/cpojer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpojer/subscriptions","organizations_url":"https://api.github.com/users/cpojer/orgs","repos_url":"https://api.github.com/users/cpojer/repos","events_url":"https://api.github.com/users/cpojer/events{/privacy}","received_events_url":"https://api.github.com/users/cpojer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpojer/promise","description":"Bare bones Promises/A+ implementation","fork":true,"url":"https://api.github.com/repos/cpojer/promise","forks_url":"https://api.github.com/repos/cpojer/promise/forks","keys_url":"https://api.github.com/repos/cpojer/promise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpojer/promise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpojer/promise/teams","hooks_url":"https://api.github.com/repos/cpojer/promise/hooks","issue_events_url":"https://api.github.com/repos/cpojer/promise/issues/events{/number}","events_url":"https://api.github.com/repos/cpojer/promise/events","assignees_url":"https://api.github.com/repos/cpojer/promise/assignees{/user}","branches_url":"https://api.github.com/repos/cpojer/promise/branches{/branch}","tags_url":"https://api.github.com/repos/cpojer/promise/tags","blobs_url":"https://api.github.com/repos/cpojer/promise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpojer/promise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpojer/promise/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpojer/promise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpojer/promise/statuses/{sha}","languages_url":"https://api.github.com/repos/cpojer/promise/languages","stargazers_url":"https://api.github.com/repos/cpojer/promise/stargazers","contributors_url":"https://api.github.com/repos/cpojer/promise/contributors","subscribers_url":"https://api.github.com/repos/cpojer/promise/subscribers","subscription_url":"https://api.github.com/repos/cpojer/promise/subscription","commits_url":"https://api.github.com/repos/cpojer/promise/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpojer/promise/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpojer/promise/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpojer/promise/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpojer/promise/contents/{+path}","compare_url":"https://api.github.com/repos/cpojer/promise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpojer/promise/merges","archive_url":"https://api.github.com/repos/cpojer/promise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpojer/promise/downloads","issues_url":"https://api.github.com/repos/cpojer/promise/issues{/number}","pulls_url":"https://api.github.com/repos/cpojer/promise/pulls{/number}","milestones_url":"https://api.github.com/repos/cpojer/promise/milestones{/number}","notifications_url":"https://api.github.com/repos/cpojer/promise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpojer/promise/labels{/name}","releases_url":"https://api.github.com/repos/cpojer/promise/releases{/id}","created_at":"2015-04-14T21:15:27Z","updated_at":"2015-04-14T21:15:27Z","pushed_at":"2015-04-15T17:20:21Z","git_url":"git://github.com/cpojer/promise.git","ssh_url":"git@github.com:cpojer/promise.git","clone_url":"https://github.com/cpojer/promise.git","svn_url":"https://github.com/cpojer/promise","homepage":"https://www.promisejs.org","size":899,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"then:master","ref":"master","sha":"cac6f9da045c7b136559a2634f7a22802ef3acfb","user":{"login":"then","id":3106720,"avatar_url":"https://avatars.githubusercontent.com/u/3106720?v=3","gravatar_id":"","url":"https://api.github.com/users/then","html_url":"https://github.com/then","followers_url":"https://api.github.com/users/then/followers","following_url":"https://api.github.com/users/then/following{/other_user}","gists_url":"https://api.github.com/users/then/gists{/gist_id}","starred_url":"https://api.github.com/users/then/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/then/subscriptions","organizations_url":"https://api.github.com/users/then/orgs","repos_url":"https://api.github.com/users/then/repos","events_url":"https://api.github.com/users/then/events{/privacy}","received_events_url":"https://api.github.com/users/then/received_events","type":"Organization","site_admin":false},"repo":{"id":7297261,"name":"promise","full_name":"then/promise","owner":{"login":"then","id":3106720,"avatar_url":"https://avatars.githubusercontent.com/u/3106720?v=3","gravatar_id":"","url":"https://api.github.com/users/then","html_url":"https://github.com/then","followers_url":"https://api.github.com/users/then/followers","following_url":"https://api.github.com/users/then/following{/other_user}","gists_url":"https://api.github.com/users/then/gists{/gist_id}","starred_url":"https://api.github.com/users/then/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/then/subscriptions","organizations_url":"https://api.github.com/users/then/orgs","repos_url":"https://api.github.com/users/then/repos","events_url":"https://api.github.com/users/then/events{/privacy}","received_events_url":"https://api.github.com/users/then/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/then/promise","description":"Bare bones Promises/A+ implementation","fork":false,"url":"https://api.github.com/repos/then/promise","forks_url":"https://api.github.com/repos/then/promise/forks","keys_url":"https://api.github.com/repos/then/promise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/then/promise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/then/promise/teams","hooks_url":"https://api.github.com/repos/then/promise/hooks","issue_events_url":"https://api.github.com/repos/then/promise/issues/events{/number}","events_url":"https://api.github.com/repos/then/promise/events","assignees_url":"https://api.github.com/repos/then/promise/assignees{/user}","branches_url":"https://api.github.com/repos/then/promise/branches{/branch}","tags_url":"https://api.github.com/repos/then/promise/tags","blobs_url":"https://api.github.com/repos/then/promise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/then/promise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/then/promise/git/refs{/sha}","trees_url":"https://api.github.com/repos/then/promise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/then/promise/statuses/{sha}","languages_url":"https://api.github.com/repos/then/promise/languages","stargazers_url":"https://api.github.com/repos/then/promise/stargazers","contributors_url":"https://api.github.com/repos/then/promise/contributors","subscribers_url":"https://api.github.com/repos/then/promise/subscribers","subscription_url":"https://api.github.com/repos/then/promise/subscription","commits_url":"https://api.github.com/repos/then/promise/commits{/sha}","git_commits_url":"https://api.github.com/repos/then/promise/git/commits{/sha}","comments_url":"https://api.github.com/repos/then/promise/comments{/number}","issue_comment_url":"https://api.github.com/repos/then/promise/issues/comments{/number}","contents_url":"https://api.github.com/repos/then/promise/contents/{+path}","compare_url":"https://api.github.com/repos/then/promise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/then/promise/merges","archive_url":"https://api.github.com/repos/then/promise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/then/promise/downloads","issues_url":"https://api.github.com/repos/then/promise/issues{/number}","pulls_url":"https://api.github.com/repos/then/promise/pulls{/number}","milestones_url":"https://api.github.com/repos/then/promise/milestones{/number}","notifications_url":"https://api.github.com/repos/then/promise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/then/promise/labels{/name}","releases_url":"https://api.github.com/repos/then/promise/releases{/id}","created_at":"2012-12-23T17:38:36Z","updated_at":"2015-04-16T11:03:48Z","pushed_at":"2015-04-15T17:20:22Z","git_url":"git://github.com/then/promise.git","ssh_url":"git@github.com:then/promise.git","clone_url":"https://github.com/then/promise.git","svn_url":"https://github.com/then/promise","homepage":"https://www.promisejs.org","size":899,"stargazers_count":669,"watchers_count":669,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":13,"forks":76,"open_issues":13,"watchers":669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/then/promise/pulls/89"},"html":{"href":"https://github.com/then/promise/pull/89"},"issue":{"href":"https://api.github.com/repos/then/promise/issues/89"},"comments":{"href":"https://api.github.com/repos/then/promise/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/then/promise/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/then/promise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/then/promise/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/then/promise/statuses/03590f3f72988477515114a6da6d0c443e972d5b"}}}}