{"action":"created","comment":{"url":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/29083106","id":29083106,"diff_hunk":"@@ -117,6 +127,16 @@ public void testMultipleIntegerValues() {\n   }\n \n   @Test\n+  public void testMultipleIntegerValuesNormalized() {\n+    // normalized predicate normalizes the string values,\n+    // so they won't be sorted numerically.\n+    // ensures that cases where the type may not be comparable directly\n+    // that they will be consistently sorted\n+    Assert.assertEquals(\"In#toString(INT)\",\n+        \"123,45\", Predicates.in(45,123).toNormalizedString(INT));","path":"kite-data/kite-data-core/src/test/java/org/kitesdk/data/spi/predicates/TestInToFromString.java","position":27,"original_position":27,"commit_id":"b917e3ce0d456cb33e0af5ae70ffda0897a68561","original_commit_id":"52c36e2bd396663f361b5a536368b2992fda27a9","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"body":"That works. Just keep in mind that we can't change it. :)","created_at":"2015-04-24T20:31:25Z","updated_at":"2015-04-24T20:31:25Z","html_url":"https://github.com/kite-sdk/kite/pull/348#discussion_r29083106","pull_request_url":"https://api.github.com/repos/kite-sdk/kite/pulls/348","_links":{"self":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/29083106"},"html":{"href":"https://github.com/kite-sdk/kite/pull/348#discussion_r29083106"},"pull_request":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/kite-sdk/kite/pulls/348","id":33185622,"html_url":"https://github.com/kite-sdk/kite/pull/348","diff_url":"https://github.com/kite-sdk/kite/pull/348.diff","patch_url":"https://github.com/kite-sdk/kite/pull/348.patch","issue_url":"https://api.github.com/repos/kite-sdk/kite/issues/348","number":348,"state":"open","locked":false,"title":"CDK-451 signal ready views","user":{"login":"bbrownz","id":1099854,"avatar_url":"https://avatars.githubusercontent.com/u/1099854?v=3","gravatar_id":"","url":"https://api.github.com/users/bbrownz","html_url":"https://github.com/bbrownz","followers_url":"https://api.github.com/users/bbrownz/followers","following_url":"https://api.github.com/users/bbrownz/following{/other_user}","gists_url":"https://api.github.com/users/bbrownz/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrownz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrownz/subscriptions","organizations_url":"https://api.github.com/users/bbrownz/orgs","repos_url":"https://api.github.com/users/bbrownz/repos","events_url":"https://api.github.com/users/bbrownz/events{/privacy}","received_events_url":"https://api.github.com/users/bbrownz/received_events","type":"User","site_admin":false},"body":"Implementation for hdfs and hive based views, hbase is currently unimplemented.\r\n\r\nIncludes updates to interfaces for views for the basic signalReady/isReady concept\r\n\r\nUpdates were also made to the dataset repository interface to create these signals for datasets based on constraints, and to determine the last time those constraints were signaled.\r\n\r\nMapReduce was updated to create these signals (if possible) when a write to a dataset is successful. Crunch was updated to support using these signals for WriteMode.CHECKPOINT (with a 'ready' view essentially indicating a previous success)","created_at":"2015-04-13T17:39:52Z","updated_at":"2015-04-24T20:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"282e8807868eda3d20bd375a0d7e3f1433f77b07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kite-sdk/kite/pulls/348/commits","review_comments_url":"https://api.github.com/repos/kite-sdk/kite/pulls/348/comments","review_comment_url":"https://api.github.com/repos/kite-sdk/kite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kite-sdk/kite/issues/348/comments","statuses_url":"https://api.github.com/repos/kite-sdk/kite/statuses/b917e3ce0d456cb33e0af5ae70ffda0897a68561","head":{"label":"bbrownz:CDK-451","ref":"CDK-451","sha":"b917e3ce0d456cb33e0af5ae70ffda0897a68561","user":{"login":"bbrownz","id":1099854,"avatar_url":"https://avatars.githubusercontent.com/u/1099854?v=3","gravatar_id":"","url":"https://api.github.com/users/bbrownz","html_url":"https://github.com/bbrownz","followers_url":"https://api.github.com/users/bbrownz/followers","following_url":"https://api.github.com/users/bbrownz/following{/other_user}","gists_url":"https://api.github.com/users/bbrownz/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrownz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrownz/subscriptions","organizations_url":"https://api.github.com/users/bbrownz/orgs","repos_url":"https://api.github.com/users/bbrownz/repos","events_url":"https://api.github.com/users/bbrownz/events{/privacy}","received_events_url":"https://api.github.com/users/bbrownz/received_events","type":"User","site_admin":false},"repo":{"id":33877632,"name":"kite","full_name":"bbrownz/kite","owner":{"login":"bbrownz","id":1099854,"avatar_url":"https://avatars.githubusercontent.com/u/1099854?v=3","gravatar_id":"","url":"https://api.github.com/users/bbrownz","html_url":"https://github.com/bbrownz","followers_url":"https://api.github.com/users/bbrownz/followers","following_url":"https://api.github.com/users/bbrownz/following{/other_user}","gists_url":"https://api.github.com/users/bbrownz/gists{/gist_id}","starred_url":"https://api.github.com/users/bbrownz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbrownz/subscriptions","organizations_url":"https://api.github.com/users/bbrownz/orgs","repos_url":"https://api.github.com/users/bbrownz/repos","events_url":"https://api.github.com/users/bbrownz/events{/privacy}","received_events_url":"https://api.github.com/users/bbrownz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbrownz/kite","description":"Kite SDK","fork":true,"url":"https://api.github.com/repos/bbrownz/kite","forks_url":"https://api.github.com/repos/bbrownz/kite/forks","keys_url":"https://api.github.com/repos/bbrownz/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbrownz/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbrownz/kite/teams","hooks_url":"https://api.github.com/repos/bbrownz/kite/hooks","issue_events_url":"https://api.github.com/repos/bbrownz/kite/issues/events{/number}","events_url":"https://api.github.com/repos/bbrownz/kite/events","assignees_url":"https://api.github.com/repos/bbrownz/kite/assignees{/user}","branches_url":"https://api.github.com/repos/bbrownz/kite/branches{/branch}","tags_url":"https://api.github.com/repos/bbrownz/kite/tags","blobs_url":"https://api.github.com/repos/bbrownz/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbrownz/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbrownz/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbrownz/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbrownz/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/bbrownz/kite/languages","stargazers_url":"https://api.github.com/repos/bbrownz/kite/stargazers","contributors_url":"https://api.github.com/repos/bbrownz/kite/contributors","subscribers_url":"https://api.github.com/repos/bbrownz/kite/subscribers","subscription_url":"https://api.github.com/repos/bbrownz/kite/subscription","commits_url":"https://api.github.com/repos/bbrownz/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbrownz/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbrownz/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbrownz/kite/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbrownz/kite/contents/{+path}","compare_url":"https://api.github.com/repos/bbrownz/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbrownz/kite/merges","archive_url":"https://api.github.com/repos/bbrownz/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbrownz/kite/downloads","issues_url":"https://api.github.com/repos/bbrownz/kite/issues{/number}","pulls_url":"https://api.github.com/repos/bbrownz/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/bbrownz/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/bbrownz/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbrownz/kite/labels{/name}","releases_url":"https://api.github.com/repos/bbrownz/kite/releases{/id}","created_at":"2015-04-13T15:45:33Z","updated_at":"2015-04-13T15:45:38Z","pushed_at":"2015-04-24T20:00:57Z","git_url":"git://github.com/bbrownz/kite.git","ssh_url":"git@github.com:bbrownz/kite.git","clone_url":"https://github.com/bbrownz/kite.git","svn_url":"https://github.com/bbrownz/kite","homepage":"http://kitesdk.org/docs/current/","size":47194,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kite-sdk:master","ref":"master","sha":"172a1968626a93930d6467b675e4110f82619a40","user":{"login":"kite-sdk","id":5732728,"avatar_url":"https://avatars.githubusercontent.com/u/5732728?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-sdk","html_url":"https://github.com/kite-sdk","followers_url":"https://api.github.com/users/kite-sdk/followers","following_url":"https://api.github.com/users/kite-sdk/following{/other_user}","gists_url":"https://api.github.com/users/kite-sdk/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-sdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-sdk/subscriptions","organizations_url":"https://api.github.com/users/kite-sdk/orgs","repos_url":"https://api.github.com/users/kite-sdk/repos","events_url":"https://api.github.com/users/kite-sdk/events{/privacy}","received_events_url":"https://api.github.com/users/kite-sdk/received_events","type":"Organization","site_admin":false},"repo":{"id":14829187,"name":"kite","full_name":"kite-sdk/kite","owner":{"login":"kite-sdk","id":5732728,"avatar_url":"https://avatars.githubusercontent.com/u/5732728?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-sdk","html_url":"https://github.com/kite-sdk","followers_url":"https://api.github.com/users/kite-sdk/followers","following_url":"https://api.github.com/users/kite-sdk/following{/other_user}","gists_url":"https://api.github.com/users/kite-sdk/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-sdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-sdk/subscriptions","organizations_url":"https://api.github.com/users/kite-sdk/orgs","repos_url":"https://api.github.com/users/kite-sdk/repos","events_url":"https://api.github.com/users/kite-sdk/events{/privacy}","received_events_url":"https://api.github.com/users/kite-sdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kite-sdk/kite","description":"Kite SDK","fork":false,"url":"https://api.github.com/repos/kite-sdk/kite","forks_url":"https://api.github.com/repos/kite-sdk/kite/forks","keys_url":"https://api.github.com/repos/kite-sdk/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kite-sdk/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kite-sdk/kite/teams","hooks_url":"https://api.github.com/repos/kite-sdk/kite/hooks","issue_events_url":"https://api.github.com/repos/kite-sdk/kite/issues/events{/number}","events_url":"https://api.github.com/repos/kite-sdk/kite/events","assignees_url":"https://api.github.com/repos/kite-sdk/kite/assignees{/user}","branches_url":"https://api.github.com/repos/kite-sdk/kite/branches{/branch}","tags_url":"https://api.github.com/repos/kite-sdk/kite/tags","blobs_url":"https://api.github.com/repos/kite-sdk/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kite-sdk/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kite-sdk/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/kite-sdk/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kite-sdk/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/kite-sdk/kite/languages","stargazers_url":"https://api.github.com/repos/kite-sdk/kite/stargazers","contributors_url":"https://api.github.com/repos/kite-sdk/kite/contributors","subscribers_url":"https://api.github.com/repos/kite-sdk/kite/subscribers","subscription_url":"https://api.github.com/repos/kite-sdk/kite/subscription","commits_url":"https://api.github.com/repos/kite-sdk/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/kite-sdk/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/kite-sdk/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/kite-sdk/kite/issues/comments{/number}","contents_url":"https://api.github.com/repos/kite-sdk/kite/contents/{+path}","compare_url":"https://api.github.com/repos/kite-sdk/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kite-sdk/kite/merges","archive_url":"https://api.github.com/repos/kite-sdk/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kite-sdk/kite/downloads","issues_url":"https://api.github.com/repos/kite-sdk/kite/issues{/number}","pulls_url":"https://api.github.com/repos/kite-sdk/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/kite-sdk/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/kite-sdk/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kite-sdk/kite/labels{/name}","releases_url":"https://api.github.com/repos/kite-sdk/kite/releases{/id}","created_at":"2013-11-30T22:06:02Z","updated_at":"2015-04-24T18:06:42Z","pushed_at":"2015-04-24T20:00:57Z","git_url":"git://github.com/kite-sdk/kite.git","ssh_url":"git@github.com:kite-sdk/kite.git","clone_url":"https://github.com/kite-sdk/kite.git","svn_url":"https://github.com/kite-sdk/kite","homepage":"http://kitesdk.org/docs/current/","size":77107,"stargazers_count":125,"watchers_count":125,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":13,"forks":90,"open_issues":13,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/348"},"html":{"href":"https://github.com/kite-sdk/kite/pull/348"},"issue":{"href":"https://api.github.com/repos/kite-sdk/kite/issues/348"},"comments":{"href":"https://api.github.com/repos/kite-sdk/kite/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/kite-sdk/kite/statuses/b917e3ce0d456cb33e0af5ae70ffda0897a68561"}}}}