{"action":"created","comment":{"url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/comments/33955452","id":33955452,"diff_hunk":"@@ -23,14 +23,13 @@\n       if (!jQuery) throw new Error('jQuery dependency not found');\n     }\n \n-    factory(root, exports, momentjs, jQuery);\n-\n+    module.exports = factory(root, momentjs, jQuery);\n   // Finally, as a browser global.\n   } else {\n-    root.daterangepicker = factory(root, {}, root.moment || moment, (root.jQuery || root.Zepto || root.ender || root.$));\n+    root.daterangepicker = factory(root, root.moment, (root.jQuery || root.Zepto || root.ender || root.$));","path":"daterangepicker.js","position":23,"original_position":23,"commit_id":"de27596601c9830e80a43f744207b58333b72c87","original_commit_id":"de27596601c9830e80a43f744207b58333b72c87","user":{"login":"dangrossman","id":407706,"avatar_url":"https://avatars.githubusercontent.com/u/407706?v=3","gravatar_id":"","url":"https://api.github.com/users/dangrossman","html_url":"https://github.com/dangrossman","followers_url":"https://api.github.com/users/dangrossman/followers","following_url":"https://api.github.com/users/dangrossman/following{/other_user}","gists_url":"https://api.github.com/users/dangrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/dangrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangrossman/subscriptions","organizations_url":"https://api.github.com/users/dangrossman/orgs","repos_url":"https://api.github.com/users/dangrossman/repos","events_url":"https://api.github.com/users/dangrossman/events{/privacy}","received_events_url":"https://api.github.com/users/dangrossman/received_events","type":"User","site_admin":false},"body":"Here you change the function signature and remove `moment`, which is needed by Meteor.js users as the `moment` object is not attached to the window (root) for them. This change would mean they have to go back to maintaining a fork instead of using this package. ","created_at":"2015-07-06T16:50:59Z","updated_at":"2015-07-06T16:50:59Z","html_url":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696#discussion_r33955452","pull_request_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696","_links":{"self":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/comments/33955452"},"html":{"href":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696#discussion_r33955452"},"pull_request":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696"}}},"pull_request":{"url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696","id":39226910,"html_url":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696","diff_url":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696.diff","patch_url":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696.patch","issue_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/696","number":696,"state":"open","locked":false,"title":"Fix browserify/commonjs bug : plugin object isn’t exported","user":{"login":"harobed","id":230143,"avatar_url":"https://avatars.githubusercontent.com/u/230143?v=3","gravatar_id":"","url":"https://api.github.com/users/harobed","html_url":"https://github.com/harobed","followers_url":"https://api.github.com/users/harobed/followers","following_url":"https://api.github.com/users/harobed/following{/other_user}","gists_url":"https://api.github.com/users/harobed/gists{/gist_id}","starred_url":"https://api.github.com/users/harobed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harobed/subscriptions","organizations_url":"https://api.github.com/users/harobed/orgs","repos_url":"https://api.github.com/users/harobed/repos","events_url":"https://api.github.com/users/harobed/events{/privacy}","received_events_url":"https://api.github.com/users/harobed/received_events","type":"User","site_admin":false},"body":"Fix browserify/commonjs bug : plugin object isn’t exported","created_at":"2015-07-05T21:04:21Z","updated_at":"2015-07-06T16:50:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a246d4dc420397560e58050c94077e32c8ce0a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696/commits","review_comments_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696/comments","review_comment_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/696/comments","statuses_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/statuses/de27596601c9830e80a43f744207b58333b72c87","head":{"label":"harobed:fix_browserify_bug_plugin_not_exported","ref":"fix_browserify_bug_plugin_not_exported","sha":"de27596601c9830e80a43f744207b58333b72c87","user":{"login":"harobed","id":230143,"avatar_url":"https://avatars.githubusercontent.com/u/230143?v=3","gravatar_id":"","url":"https://api.github.com/users/harobed","html_url":"https://github.com/harobed","followers_url":"https://api.github.com/users/harobed/followers","following_url":"https://api.github.com/users/harobed/following{/other_user}","gists_url":"https://api.github.com/users/harobed/gists{/gist_id}","starred_url":"https://api.github.com/users/harobed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harobed/subscriptions","organizations_url":"https://api.github.com/users/harobed/orgs","repos_url":"https://api.github.com/users/harobed/repos","events_url":"https://api.github.com/users/harobed/events{/privacy}","received_events_url":"https://api.github.com/users/harobed/received_events","type":"User","site_admin":false},"repo":{"id":38583750,"name":"bootstrap-daterangepicker","full_name":"harobed/bootstrap-daterangepicker","owner":{"login":"harobed","id":230143,"avatar_url":"https://avatars.githubusercontent.com/u/230143?v=3","gravatar_id":"","url":"https://api.github.com/users/harobed","html_url":"https://github.com/harobed","followers_url":"https://api.github.com/users/harobed/followers","following_url":"https://api.github.com/users/harobed/following{/other_user}","gists_url":"https://api.github.com/users/harobed/gists{/gist_id}","starred_url":"https://api.github.com/users/harobed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harobed/subscriptions","organizations_url":"https://api.github.com/users/harobed/orgs","repos_url":"https://api.github.com/users/harobed/repos","events_url":"https://api.github.com/users/harobed/events{/privacy}","received_events_url":"https://api.github.com/users/harobed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harobed/bootstrap-daterangepicker","description":"Date range picker component for Bootstrap","fork":true,"url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker","forks_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/forks","keys_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/teams","hooks_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/hooks","issue_events_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/issues/events{/number}","events_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/events","assignees_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/assignees{/user}","branches_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/branches{/branch}","tags_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/tags","blobs_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/languages","stargazers_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/stargazers","contributors_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/contributors","subscribers_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/subscribers","subscription_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/subscription","commits_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/contents/{+path}","compare_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/merges","archive_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/downloads","issues_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/issues{/number}","pulls_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/labels{/name}","releases_url":"https://api.github.com/repos/harobed/bootstrap-daterangepicker/releases{/id}","created_at":"2015-07-05T20:55:47Z","updated_at":"2015-07-05T20:55:47Z","pushed_at":"2015-07-05T21:04:06Z","git_url":"git://github.com/harobed/bootstrap-daterangepicker.git","ssh_url":"git@github.com:harobed/bootstrap-daterangepicker.git","clone_url":"https://github.com/harobed/bootstrap-daterangepicker.git","svn_url":"https://github.com/harobed/bootstrap-daterangepicker","homepage":"https://www.improvely.com","size":3406,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dangrossman:master","ref":"master","sha":"889f730279051b371c85669ea38bfb9b1ddb062c","user":{"login":"dangrossman","id":407706,"avatar_url":"https://avatars.githubusercontent.com/u/407706?v=3","gravatar_id":"","url":"https://api.github.com/users/dangrossman","html_url":"https://github.com/dangrossman","followers_url":"https://api.github.com/users/dangrossman/followers","following_url":"https://api.github.com/users/dangrossman/following{/other_user}","gists_url":"https://api.github.com/users/dangrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/dangrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangrossman/subscriptions","organizations_url":"https://api.github.com/users/dangrossman/orgs","repos_url":"https://api.github.com/users/dangrossman/repos","events_url":"https://api.github.com/users/dangrossman/events{/privacy}","received_events_url":"https://api.github.com/users/dangrossman/received_events","type":"User","site_admin":false},"repo":{"id":5476048,"name":"bootstrap-daterangepicker","full_name":"dangrossman/bootstrap-daterangepicker","owner":{"login":"dangrossman","id":407706,"avatar_url":"https://avatars.githubusercontent.com/u/407706?v=3","gravatar_id":"","url":"https://api.github.com/users/dangrossman","html_url":"https://github.com/dangrossman","followers_url":"https://api.github.com/users/dangrossman/followers","following_url":"https://api.github.com/users/dangrossman/following{/other_user}","gists_url":"https://api.github.com/users/dangrossman/gists{/gist_id}","starred_url":"https://api.github.com/users/dangrossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangrossman/subscriptions","organizations_url":"https://api.github.com/users/dangrossman/orgs","repos_url":"https://api.github.com/users/dangrossman/repos","events_url":"https://api.github.com/users/dangrossman/events{/privacy}","received_events_url":"https://api.github.com/users/dangrossman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dangrossman/bootstrap-daterangepicker","description":"Date range picker component for Bootstrap","fork":false,"url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker","forks_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/forks","keys_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/teams","hooks_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/hooks","issue_events_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/events{/number}","events_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/events","assignees_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/assignees{/user}","branches_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/branches{/branch}","tags_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/tags","blobs_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/languages","stargazers_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/stargazers","contributors_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/contributors","subscribers_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/subscribers","subscription_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/subscription","commits_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/contents/{+path}","compare_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/merges","archive_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/downloads","issues_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues{/number}","pulls_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/labels{/name}","releases_url":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/releases{/id}","created_at":"2012-08-20T01:53:06Z","updated_at":"2015-07-06T08:00:18Z","pushed_at":"2015-07-05T21:04:21Z","git_url":"git://github.com/dangrossman/bootstrap-daterangepicker.git","ssh_url":"git@github.com:dangrossman/bootstrap-daterangepicker.git","clone_url":"https://github.com/dangrossman/bootstrap-daterangepicker.git","svn_url":"https://github.com/dangrossman/bootstrap-daterangepicker","homepage":"https://www.improvely.com","size":3406,"stargazers_count":4045,"watchers_count":4045,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1271,"mirror_url":null,"open_issues_count":55,"forks":1271,"open_issues":55,"watchers":4045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696"},"html":{"href":"https://github.com/dangrossman/bootstrap-daterangepicker/pull/696"},"issue":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/696"},"comments":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/issues/696/comments"},"review_comments":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696/comments"},"review_comment":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/pulls/696/commits"},"statuses":{"href":"https://api.github.com/repos/dangrossman/bootstrap-daterangepicker/statuses/de27596601c9830e80a43f744207b58333b72c87"}}}}