{"action":"closed","issue":{"url":"https://api.github.com/repos/nrlulz/ACF/issues/34","labels_url":"https://api.github.com/repos/nrlulz/ACF/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/nrlulz/ACF/issues/34/comments","events_url":"https://api.github.com/repos/nrlulz/ACF/issues/34/events","html_url":"https://github.com/nrlulz/ACF/issues/34","id":16177331,"number":34,"title":"Version check","user":{"login":"nrlulz","id":2789013,"avatar_url":"https://avatars.githubusercontent.com/u/2789013?v=3","gravatar_id":"","url":"https://api.github.com/users/nrlulz","html_url":"https://github.com/nrlulz","followers_url":"https://api.github.com/users/nrlulz/followers","following_url":"https://api.github.com/users/nrlulz/following{/other_user}","gists_url":"https://api.github.com/users/nrlulz/gists{/gist_id}","starred_url":"https://api.github.com/users/nrlulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrlulz/subscriptions","organizations_url":"https://api.github.com/users/nrlulz/orgs","repos_url":"https://api.github.com/users/nrlulz/repos","events_url":"https://api.github.com/users/nrlulz/events{/privacy}","received_events_url":"https://api.github.com/users/nrlulz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nrlulz/ACF/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2013-06-29T17:09:42Z","updated_at":"2015-05-28T19:24:49Z","closed_at":"2015-05-28T19:24:49Z","body":"So it looks like github's new design has broken the version check which to be honest was kind of a hack anyway... so instead of just updating the string match we might as well do a proper version check.\r\n\r\nI like the idea of the pre-commit hook updating it automatically, but as we discussed in #26 it's not the most effective since it's clientside. @Bubbus mentioned something about a serverside post-upload hook that would bounce back a modified commit though, I wanna know more about that. We can run whatever it is we need to run on my server. If we could pull that off we'd have automatic version updating for anyone who commits from anywhere, even from auto-merging pull requests so I think that'd be best."}}