{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker-py/issues/591","labels_url":"https://api.github.com/repos/docker/docker-py/issues/591/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker-py/issues/591/comments","events_url":"https://api.github.com/repos/docker/docker-py/issues/591/events","html_url":"https://github.com/docker/docker-py/pull/591","id":74169175,"number":591,"title":"Added proper support for .dockerignore 'folder/' syntax","user":{"login":"shin-","id":1086876,"avatar_url":"https://avatars.githubusercontent.com/u/1086876?v=3","gravatar_id":"","url":"https://api.github.com/users/shin-","html_url":"https://github.com/shin-","followers_url":"https://api.github.com/users/shin-/followers","following_url":"https://api.github.com/users/shin-/following{/other_user}","gists_url":"https://api.github.com/users/shin-/gists{/gist_id}","starred_url":"https://api.github.com/users/shin-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shin-/subscriptions","organizations_url":"https://api.github.com/users/shin-/orgs","repos_url":"https://api.github.com/users/shin-/repos","events_url":"https://api.github.com/users/shin-/events{/privacy}","received_events_url":"https://api.github.com/users/shin-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-08T00:00:05Z","updated_at":"2015-05-15T16:26:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker-py/pulls/591","html_url":"https://github.com/docker/docker-py/pull/591","diff_url":"https://github.com/docker/docker-py/pull/591.diff","patch_url":"https://github.com/docker/docker-py/pull/591.patch"},"body":"Fixes #581 "},"comment":{"url":"https://api.github.com/repos/docker/docker-py/issues/comments/102452979","html_url":"https://github.com/docker/docker-py/pull/591#issuecomment-102452979","issue_url":"https://api.github.com/repos/docker/docker-py/issues/591","id":102452979,"user":{"login":"mikexstudios","id":26704,"avatar_url":"https://avatars.githubusercontent.com/u/26704?v=3","gravatar_id":"","url":"https://api.github.com/users/mikexstudios","html_url":"https://github.com/mikexstudios","followers_url":"https://api.github.com/users/mikexstudios/followers","following_url":"https://api.github.com/users/mikexstudios/following{/other_user}","gists_url":"https://api.github.com/users/mikexstudios/gists{/gist_id}","starred_url":"https://api.github.com/users/mikexstudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikexstudios/subscriptions","organizations_url":"https://api.github.com/users/mikexstudios/orgs","repos_url":"https://api.github.com/users/mikexstudios/repos","events_url":"https://api.github.com/users/mikexstudios/events{/privacy}","received_events_url":"https://api.github.com/users/mikexstudios/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T16:26:52Z","updated_at":"2015-05-15T16:26:52Z","body":"Hey @shin-. I updated your PR with a unit test for this case. Your PR works for detecting trailing slashes on folders.\r\n\r\nHowever, I am concerned that we need a more general and robust way of handling .dockerignore files. The currently implementation fails on a lot of syntax defined here: https://github.com/docker/docker/blob/master/docs/sources/reference/builder.md#dockerignore-file\r\n\r\nI'll see if I can contribute to improving this in docker-py."}}