{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/vtt.js/pulls/comments/24286160","id":24286160,"diff_hunk":"@@ -818,14 +846,19 @@\n       // result in the desired behaviour.\n       lh = rects ? Math.max((rects[0] && rects[0].height) || 0, obj.height / rects.length)\n                  : 0;\n+\n     }\n     this.left = obj.left;\n     this.right = obj.right;\n-    this.top = obj.top;\n-    this.height = obj.height;\n-    this.bottom = obj.bottom;\n-    this.width = obj.width;\n+    this.top = obj.top || top;\n+    this.height = obj.height || height;\n+    this.bottom = obj.bottom || (top + (obj.height || height));\n+    this.width = obj.width || width;\n     this.lineHeight = lh !== undefined ? lh : obj.lineHeight;\n+\n+    if (isIE8 && !this.lineHeight) {\n+      this.lineHeight = 13;","path":"lib/vtt.js","position":111,"original_position":111,"commit_id":"32ecb0056b76ebfdad35c3e577d4304175b64dfb","original_commit_id":"32ecb0056b76ebfdad35c3e577d4304175b64dfb","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"I did some googling around line height values and this value came up a lot. In IE8, it seems to make the font-size look correct, though, I haven't really experimented with many other values. ","created_at":"2015-02-07T02:59:31Z","updated_at":"2015-02-07T02:59:31Z","html_url":"https://github.com/mozilla/vtt.js/pull/337#discussion_r24286160","pull_request_url":"https://api.github.com/repos/mozilla/vtt.js/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/comments/24286160"},"html":{"href":"https://github.com/mozilla/vtt.js/pull/337#discussion_r24286160"},"pull_request":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/vtt.js/pulls/337","id":27638692,"html_url":"https://github.com/mozilla/vtt.js/pull/337","diff_url":"https://github.com/mozilla/vtt.js/pull/337.diff","patch_url":"https://github.com/mozilla/vtt.js/pull/337.patch","issue_url":"https://api.github.com/repos/mozilla/vtt.js/issues/337","number":337,"state":"open","locked":false,"title":"New ie8","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"This is a new rebased version of #334. It has some re-ordered commits and *right* now doesn't position things correctly in IE8. Working on bringing that back from the other PR. However, I believe that these current additions pass all the tests and I'll make sure as I apply the other changes, the tests continue to pass.\r\nFix #333.","created_at":"2015-01-19T21:59:08Z","updated_at":"2015-02-07T02:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e9ad0672f7e114bd539e7daa8a6d0521da659e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/vtt.js/pulls/337/commits","review_comments_url":"https://api.github.com/repos/mozilla/vtt.js/pulls/337/comments","review_comment_url":"https://api.github.com/repos/mozilla/vtt.js/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/vtt.js/issues/337/comments","statuses_url":"https://api.github.com/repos/mozilla/vtt.js/statuses/32ecb0056b76ebfdad35c3e577d4304175b64dfb","head":{"label":"gkatsev:new-ie8","ref":"new-ie8","sha":"32ecb0056b76ebfdad35c3e577d4304175b64dfb","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"repo":{"id":26975348,"name":"vtt.js","full_name":"gkatsev/vtt.js","owner":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkatsev/vtt.js","description":"A JavaScript implementation of the WebVTT specification","fork":true,"url":"https://api.github.com/repos/gkatsev/vtt.js","forks_url":"https://api.github.com/repos/gkatsev/vtt.js/forks","keys_url":"https://api.github.com/repos/gkatsev/vtt.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkatsev/vtt.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkatsev/vtt.js/teams","hooks_url":"https://api.github.com/repos/gkatsev/vtt.js/hooks","issue_events_url":"https://api.github.com/repos/gkatsev/vtt.js/issues/events{/number}","events_url":"https://api.github.com/repos/gkatsev/vtt.js/events","assignees_url":"https://api.github.com/repos/gkatsev/vtt.js/assignees{/user}","branches_url":"https://api.github.com/repos/gkatsev/vtt.js/branches{/branch}","tags_url":"https://api.github.com/repos/gkatsev/vtt.js/tags","blobs_url":"https://api.github.com/repos/gkatsev/vtt.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkatsev/vtt.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkatsev/vtt.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkatsev/vtt.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkatsev/vtt.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gkatsev/vtt.js/languages","stargazers_url":"https://api.github.com/repos/gkatsev/vtt.js/stargazers","contributors_url":"https://api.github.com/repos/gkatsev/vtt.js/contributors","subscribers_url":"https://api.github.com/repos/gkatsev/vtt.js/subscribers","subscription_url":"https://api.github.com/repos/gkatsev/vtt.js/subscription","commits_url":"https://api.github.com/repos/gkatsev/vtt.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkatsev/vtt.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkatsev/vtt.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkatsev/vtt.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/gkatsev/vtt.js/contents/{+path}","compare_url":"https://api.github.com/repos/gkatsev/vtt.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkatsev/vtt.js/merges","archive_url":"https://api.github.com/repos/gkatsev/vtt.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkatsev/vtt.js/downloads","issues_url":"https://api.github.com/repos/gkatsev/vtt.js/issues{/number}","pulls_url":"https://api.github.com/repos/gkatsev/vtt.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gkatsev/vtt.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gkatsev/vtt.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkatsev/vtt.js/labels{/name}","releases_url":"https://api.github.com/repos/gkatsev/vtt.js/releases{/id}","created_at":"2014-11-21T19:49:09Z","updated_at":"2014-11-21T19:49:10Z","pushed_at":"2015-01-22T20:50:36Z","git_url":"git://github.com/gkatsev/vtt.js.git","ssh_url":"git@github.com:gkatsev/vtt.js.git","clone_url":"https://github.com/gkatsev/vtt.js.git","svn_url":"https://github.com/gkatsev/vtt.js","homepage":"http://dev.w3.org/html5/webvtt/","size":1644,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e8fbcb8650cf9260b6d8e2449d7490f346c61cf2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11298679,"name":"vtt.js","full_name":"mozilla/vtt.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/vtt.js","description":"A JavaScript implementation of the WebVTT specification","fork":false,"url":"https://api.github.com/repos/mozilla/vtt.js","forks_url":"https://api.github.com/repos/mozilla/vtt.js/forks","keys_url":"https://api.github.com/repos/mozilla/vtt.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/vtt.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/vtt.js/teams","hooks_url":"https://api.github.com/repos/mozilla/vtt.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/vtt.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/vtt.js/events","assignees_url":"https://api.github.com/repos/mozilla/vtt.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/vtt.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/vtt.js/tags","blobs_url":"https://api.github.com/repos/mozilla/vtt.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/vtt.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/vtt.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/vtt.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/vtt.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/vtt.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/vtt.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/vtt.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/vtt.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/vtt.js/subscription","commits_url":"https://api.github.com/repos/mozilla/vtt.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/vtt.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/vtt.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/vtt.js/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/vtt.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/vtt.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/vtt.js/merges","archive_url":"https://api.github.com/repos/mozilla/vtt.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/vtt.js/downloads","issues_url":"https://api.github.com/repos/mozilla/vtt.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/vtt.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/vtt.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/vtt.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/vtt.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/vtt.js/releases{/id}","created_at":"2013-07-10T01:22:14Z","updated_at":"2015-02-06T12:37:01Z","pushed_at":"2014-06-21T18:20:57Z","git_url":"git://github.com/mozilla/vtt.js.git","ssh_url":"git@github.com:mozilla/vtt.js.git","clone_url":"https://github.com/mozilla/vtt.js.git","svn_url":"https://github.com/mozilla/vtt.js","homepage":"http://dev.w3.org/html5/webvtt/","size":4703,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":28,"forks":22,"open_issues":28,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/337"},"html":{"href":"https://github.com/mozilla/vtt.js/pull/337"},"issue":{"href":"https://api.github.com/repos/mozilla/vtt.js/issues/337"},"comments":{"href":"https://api.github.com/repos/mozilla/vtt.js/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/vtt.js/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/vtt.js/statuses/32ecb0056b76ebfdad35c3e577d4304175b64dfb"}}}}