{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1","id":30079834,"html_url":"https://github.com/andreisumar/mrcabdriver/pull/1","diff_url":"https://github.com/andreisumar/mrcabdriver/pull/1.diff","patch_url":"https://github.com/andreisumar/mrcabdriver/pull/1.patch","issue_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/1","number":1,"state":"open","locked":false,"title":"Refactoring/sergey/ng taxi cars service","user":{"login":"sbedulin","id":900840,"avatar_url":"https://avatars.githubusercontent.com/u/900840?v=3","gravatar_id":"","url":"https://api.github.com/users/sbedulin","html_url":"https://github.com/sbedulin","followers_url":"https://api.github.com/users/sbedulin/followers","following_url":"https://api.github.com/users/sbedulin/following{/other_user}","gists_url":"https://api.github.com/users/sbedulin/gists{/gist_id}","starred_url":"https://api.github.com/users/sbedulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbedulin/subscriptions","organizations_url":"https://api.github.com/users/sbedulin/orgs","repos_url":"https://api.github.com/users/sbedulin/repos","events_url":"https://api.github.com/users/sbedulin/events{/privacy}","received_events_url":"https://api.github.com/users/sbedulin/received_events","type":"User","site_admin":false},"body":"1) Removed global variable creation\r\n2) Move `use strict` inside factory functions, because it might raise problems when scripts are bundled.\r\n3) Keep annotations and function params on separate lines, this way it's easier to spot errors in DI chain\r\n4) Angular convention is to specify built-in services before custom - `$http, $q, geoLocation`","created_at":"2015-02-26T14:05:52Z","updated_at":"2015-02-26T14:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1/commits","review_comments_url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1/comments","review_comment_url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/1/comments","statuses_url":"https://api.github.com/repos/andreisumar/mrcabdriver/statuses/5d2591e502428b6433a763fd87844b427bd83127","head":{"label":"andreisumar:Refactoring/Sergey/ng-taxi-cars-service","ref":"Refactoring/Sergey/ng-taxi-cars-service","sha":"5d2591e502428b6433a763fd87844b427bd83127","user":{"login":"andreisumar","id":7620700,"avatar_url":"https://avatars.githubusercontent.com/u/7620700?v=3","gravatar_id":"","url":"https://api.github.com/users/andreisumar","html_url":"https://github.com/andreisumar","followers_url":"https://api.github.com/users/andreisumar/followers","following_url":"https://api.github.com/users/andreisumar/following{/other_user}","gists_url":"https://api.github.com/users/andreisumar/gists{/gist_id}","starred_url":"https://api.github.com/users/andreisumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreisumar/subscriptions","organizations_url":"https://api.github.com/users/andreisumar/orgs","repos_url":"https://api.github.com/users/andreisumar/repos","events_url":"https://api.github.com/users/andreisumar/events{/privacy}","received_events_url":"https://api.github.com/users/andreisumar/received_events","type":"User","site_admin":false},"repo":{"id":26528655,"name":"mrcabdriver","full_name":"andreisumar/mrcabdriver","owner":{"login":"andreisumar","id":7620700,"avatar_url":"https://avatars.githubusercontent.com/u/7620700?v=3","gravatar_id":"","url":"https://api.github.com/users/andreisumar","html_url":"https://github.com/andreisumar","followers_url":"https://api.github.com/users/andreisumar/followers","following_url":"https://api.github.com/users/andreisumar/following{/other_user}","gists_url":"https://api.github.com/users/andreisumar/gists{/gist_id}","starred_url":"https://api.github.com/users/andreisumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreisumar/subscriptions","organizations_url":"https://api.github.com/users/andreisumar/orgs","repos_url":"https://api.github.com/users/andreisumar/repos","events_url":"https://api.github.com/users/andreisumar/events{/privacy}","received_events_url":"https://api.github.com/users/andreisumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreisumar/mrcabdriver","description":"Taxi Calling App","fork":false,"url":"https://api.github.com/repos/andreisumar/mrcabdriver","forks_url":"https://api.github.com/repos/andreisumar/mrcabdriver/forks","keys_url":"https://api.github.com/repos/andreisumar/mrcabdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreisumar/mrcabdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreisumar/mrcabdriver/teams","hooks_url":"https://api.github.com/repos/andreisumar/mrcabdriver/hooks","issue_events_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/events{/number}","events_url":"https://api.github.com/repos/andreisumar/mrcabdriver/events","assignees_url":"https://api.github.com/repos/andreisumar/mrcabdriver/assignees{/user}","branches_url":"https://api.github.com/repos/andreisumar/mrcabdriver/branches{/branch}","tags_url":"https://api.github.com/repos/andreisumar/mrcabdriver/tags","blobs_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreisumar/mrcabdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/andreisumar/mrcabdriver/languages","stargazers_url":"https://api.github.com/repos/andreisumar/mrcabdriver/stargazers","contributors_url":"https://api.github.com/repos/andreisumar/mrcabdriver/contributors","subscribers_url":"https://api.github.com/repos/andreisumar/mrcabdriver/subscribers","subscription_url":"https://api.github.com/repos/andreisumar/mrcabdriver/subscription","commits_url":"https://api.github.com/repos/andreisumar/mrcabdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreisumar/mrcabdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreisumar/mrcabdriver/contents/{+path}","compare_url":"https://api.github.com/repos/andreisumar/mrcabdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreisumar/mrcabdriver/merges","archive_url":"https://api.github.com/repos/andreisumar/mrcabdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreisumar/mrcabdriver/downloads","issues_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues{/number}","pulls_url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/andreisumar/mrcabdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/andreisumar/mrcabdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreisumar/mrcabdriver/labels{/name}","releases_url":"https://api.github.com/repos/andreisumar/mrcabdriver/releases{/id}","created_at":"2014-11-12T09:31:44Z","updated_at":"2015-02-16T02:56:34Z","pushed_at":"2015-02-26T14:03:45Z","git_url":"git://github.com/andreisumar/mrcabdriver.git","ssh_url":"git@github.com:andreisumar/mrcabdriver.git","clone_url":"https://github.com/andreisumar/mrcabdriver.git","svn_url":"https://github.com/andreisumar/mrcabdriver","homepage":null,"size":362,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"andreisumar:master","ref":"master","sha":"0833acf3003434fae9b4f2be1d673621be463c88","user":{"login":"andreisumar","id":7620700,"avatar_url":"https://avatars.githubusercontent.com/u/7620700?v=3","gravatar_id":"","url":"https://api.github.com/users/andreisumar","html_url":"https://github.com/andreisumar","followers_url":"https://api.github.com/users/andreisumar/followers","following_url":"https://api.github.com/users/andreisumar/following{/other_user}","gists_url":"https://api.github.com/users/andreisumar/gists{/gist_id}","starred_url":"https://api.github.com/users/andreisumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreisumar/subscriptions","organizations_url":"https://api.github.com/users/andreisumar/orgs","repos_url":"https://api.github.com/users/andreisumar/repos","events_url":"https://api.github.com/users/andreisumar/events{/privacy}","received_events_url":"https://api.github.com/users/andreisumar/received_events","type":"User","site_admin":false},"repo":{"id":26528655,"name":"mrcabdriver","full_name":"andreisumar/mrcabdriver","owner":{"login":"andreisumar","id":7620700,"avatar_url":"https://avatars.githubusercontent.com/u/7620700?v=3","gravatar_id":"","url":"https://api.github.com/users/andreisumar","html_url":"https://github.com/andreisumar","followers_url":"https://api.github.com/users/andreisumar/followers","following_url":"https://api.github.com/users/andreisumar/following{/other_user}","gists_url":"https://api.github.com/users/andreisumar/gists{/gist_id}","starred_url":"https://api.github.com/users/andreisumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreisumar/subscriptions","organizations_url":"https://api.github.com/users/andreisumar/orgs","repos_url":"https://api.github.com/users/andreisumar/repos","events_url":"https://api.github.com/users/andreisumar/events{/privacy}","received_events_url":"https://api.github.com/users/andreisumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreisumar/mrcabdriver","description":"Taxi Calling App","fork":false,"url":"https://api.github.com/repos/andreisumar/mrcabdriver","forks_url":"https://api.github.com/repos/andreisumar/mrcabdriver/forks","keys_url":"https://api.github.com/repos/andreisumar/mrcabdriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreisumar/mrcabdriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreisumar/mrcabdriver/teams","hooks_url":"https://api.github.com/repos/andreisumar/mrcabdriver/hooks","issue_events_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/events{/number}","events_url":"https://api.github.com/repos/andreisumar/mrcabdriver/events","assignees_url":"https://api.github.com/repos/andreisumar/mrcabdriver/assignees{/user}","branches_url":"https://api.github.com/repos/andreisumar/mrcabdriver/branches{/branch}","tags_url":"https://api.github.com/repos/andreisumar/mrcabdriver/tags","blobs_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreisumar/mrcabdriver/statuses/{sha}","languages_url":"https://api.github.com/repos/andreisumar/mrcabdriver/languages","stargazers_url":"https://api.github.com/repos/andreisumar/mrcabdriver/stargazers","contributors_url":"https://api.github.com/repos/andreisumar/mrcabdriver/contributors","subscribers_url":"https://api.github.com/repos/andreisumar/mrcabdriver/subscribers","subscription_url":"https://api.github.com/repos/andreisumar/mrcabdriver/subscription","commits_url":"https://api.github.com/repos/andreisumar/mrcabdriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreisumar/mrcabdriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreisumar/mrcabdriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreisumar/mrcabdriver/contents/{+path}","compare_url":"https://api.github.com/repos/andreisumar/mrcabdriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreisumar/mrcabdriver/merges","archive_url":"https://api.github.com/repos/andreisumar/mrcabdriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreisumar/mrcabdriver/downloads","issues_url":"https://api.github.com/repos/andreisumar/mrcabdriver/issues{/number}","pulls_url":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls{/number}","milestones_url":"https://api.github.com/repos/andreisumar/mrcabdriver/milestones{/number}","notifications_url":"https://api.github.com/repos/andreisumar/mrcabdriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreisumar/mrcabdriver/labels{/name}","releases_url":"https://api.github.com/repos/andreisumar/mrcabdriver/releases{/id}","created_at":"2014-11-12T09:31:44Z","updated_at":"2015-02-16T02:56:34Z","pushed_at":"2015-02-26T14:03:45Z","git_url":"git://github.com/andreisumar/mrcabdriver.git","ssh_url":"git@github.com:andreisumar/mrcabdriver.git","clone_url":"https://github.com/andreisumar/mrcabdriver.git","svn_url":"https://github.com/andreisumar/mrcabdriver","homepage":null,"size":362,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1"},"html":{"href":"https://github.com/andreisumar/mrcabdriver/pull/1"},"issue":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/1"},"comments":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/andreisumar/mrcabdriver/statuses/5d2591e502428b6433a763fd87844b427bd83127"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":36,"deletions":35,"changed_files":1}}