{"action":"opened","number":10661,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661","id":42061112,"html_url":"https://github.com/cms-sw/cmssw/pull/10661","diff_url":"https://github.com/cms-sw/cmssw/pull/10661.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/10661.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10661","number":10661,"state":"open","locked":false,"title":"Make missing consumes calls an exception","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"body":"This makes it an exception when a module has\r\nnot declared the products it gets with a consumes\r\nfunction call. Previous to this it just resulted\r\nin an error being printed out.\r\n\r\nFixed HcalDigisValidation which had recently added\r\na getByLabel without a consumes call. Also fixed\r\ntwo Framework unit tests that also had problems with\r\nconsumes calls.\r\n\r\nThis has been tested to not cause problems in the\r\nIB by scanning all the log files of a recent\r\nIB for the error message. Framework unit tests\r\nalso pass.\r\n\r\nWhile this should cause no IB test failures, there\r\nprobably will be failures of other code not tested\r\nin the IBs which has not been migrated to declare\r\nthe products it consumes.","created_at":"2015-08-10T20:16:28Z","updated_at":"2015-08-10T20:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/10661/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/62f10aee04431c67276b9303b6550e094911dec5","head":{"label":"wddgit:enableConsumesException","ref":"enableConsumesException","sha":"62f10aee04431c67276b9303b6550e094911dec5","user":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"repo":{"id":11036606,"name":"cmssw","full_name":"wddgit/cmssw","owner":{"login":"wddgit","id":4295891,"avatar_url":"https://avatars.githubusercontent.com/u/4295891?v=3","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wddgit/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wddgit/cmssw","forks_url":"https://api.github.com/repos/wddgit/cmssw/forks","keys_url":"https://api.github.com/repos/wddgit/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wddgit/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wddgit/cmssw/teams","hooks_url":"https://api.github.com/repos/wddgit/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wddgit/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wddgit/cmssw/events","assignees_url":"https://api.github.com/repos/wddgit/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wddgit/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wddgit/cmssw/tags","blobs_url":"https://api.github.com/repos/wddgit/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wddgit/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wddgit/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wddgit/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wddgit/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wddgit/cmssw/languages","stargazers_url":"https://api.github.com/repos/wddgit/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wddgit/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wddgit/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wddgit/cmssw/subscription","commits_url":"https://api.github.com/repos/wddgit/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wddgit/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wddgit/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wddgit/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/wddgit/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wddgit/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wddgit/cmssw/merges","archive_url":"https://api.github.com/repos/wddgit/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wddgit/cmssw/downloads","issues_url":"https://api.github.com/repos/wddgit/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wddgit/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wddgit/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wddgit/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wddgit/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wddgit/cmssw/releases{/id}","created_at":"2013-06-28T20:02:04Z","updated_at":"2015-05-08T19:48:35Z","pushed_at":"2015-08-10T20:12:22Z","git_url":"git://github.com/wddgit/cmssw.git","ssh_url":"git@github.com:wddgit/cmssw.git","clone_url":"https://github.com/wddgit/cmssw.git","svn_url":"https://github.com/wddgit/cmssw","homepage":null,"size":673098,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_6_X"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"11b2f0d5c47969d18c6b0d71c46e9589db874501","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-08-07T23:46:12Z","pushed_at":"2015-08-10T20:14:06Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1270048,"stargazers_count":256,"watchers_count":256,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1518,"mirror_url":null,"open_issues_count":223,"forks":1518,"open_issues":223,"watchers":256,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/10661"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10661"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/10661/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/10661/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/62f10aee04431c67276b9303b6550e094911dec5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":28,"deletions":12,"changed_files":6}}