{"action":"opened","number":852,"pull_request":{"url":"https://api.github.com/repos/ros-visualization/rviz/pulls/852","id":29899380,"html_url":"https://github.com/ros-visualization/rviz/pull/852","diff_url":"https://github.com/ros-visualization/rviz/pull/852.diff","patch_url":"https://github.com/ros-visualization/rviz/pull/852.patch","issue_url":"https://api.github.com/repos/ros-visualization/rviz/issues/852","number":852,"state":"open","locked":false,"title":"init tool's shortcut_key_ and fixed toKeys()","user":{"login":"hdeeken","id":4179358,"avatar_url":"https://avatars.githubusercontent.com/u/4179358?v=3","gravatar_id":"","url":"https://api.github.com/users/hdeeken","html_url":"https://github.com/hdeeken","followers_url":"https://api.github.com/users/hdeeken/followers","following_url":"https://api.github.com/users/hdeeken/following{/other_user}","gists_url":"https://api.github.com/users/hdeeken/gists{/gist_id}","starred_url":"https://api.github.com/users/hdeeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdeeken/subscriptions","organizations_url":"https://api.github.com/users/hdeeken/orgs","repos_url":"https://api.github.com/users/hdeeken/repos","events_url":"https://api.github.com/users/hdeeken/events{/privacy}","received_events_url":"https://api.github.com/users/hdeeken/received_events","type":"User","site_admin":false},"body":"* initialized the shortcut_key_ param with '/0' to be able to check whether a tool has a shortkey assigned or not\r\n* made the tool manager check if a tool has a shortkey before converting the char to a key code\r\n* (hopefully) fixed the toKeys method by removing the assertions, making at a boolean returning function and allowing a single key only,\r\n  as this is what is to be expected from the shortcut_key_ param\r\n\r\nthis should fix #851","created_at":"2015-02-24T14:04:40Z","updated_at":"2015-02-24T14:04:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/852/commits","review_comments_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/852/comments","review_comment_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/issues/852/comments","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/5d5d5bb6091f9b1230af4557877e568c1b0bfc89","head":{"label":"hdeeken:indigo-devel","ref":"indigo-devel","sha":"5d5d5bb6091f9b1230af4557877e568c1b0bfc89","user":{"login":"hdeeken","id":4179358,"avatar_url":"https://avatars.githubusercontent.com/u/4179358?v=3","gravatar_id":"","url":"https://api.github.com/users/hdeeken","html_url":"https://github.com/hdeeken","followers_url":"https://api.github.com/users/hdeeken/followers","following_url":"https://api.github.com/users/hdeeken/following{/other_user}","gists_url":"https://api.github.com/users/hdeeken/gists{/gist_id}","starred_url":"https://api.github.com/users/hdeeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdeeken/subscriptions","organizations_url":"https://api.github.com/users/hdeeken/orgs","repos_url":"https://api.github.com/users/hdeeken/repos","events_url":"https://api.github.com/users/hdeeken/events{/privacy}","received_events_url":"https://api.github.com/users/hdeeken/received_events","type":"User","site_admin":false},"repo":{"id":29549554,"name":"rviz","full_name":"hdeeken/rviz","owner":{"login":"hdeeken","id":4179358,"avatar_url":"https://avatars.githubusercontent.com/u/4179358?v=3","gravatar_id":"","url":"https://api.github.com/users/hdeeken","html_url":"https://github.com/hdeeken","followers_url":"https://api.github.com/users/hdeeken/followers","following_url":"https://api.github.com/users/hdeeken/following{/other_user}","gists_url":"https://api.github.com/users/hdeeken/gists{/gist_id}","starred_url":"https://api.github.com/users/hdeeken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hdeeken/subscriptions","organizations_url":"https://api.github.com/users/hdeeken/orgs","repos_url":"https://api.github.com/users/hdeeken/repos","events_url":"https://api.github.com/users/hdeeken/events{/privacy}","received_events_url":"https://api.github.com/users/hdeeken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hdeeken/rviz","description":"ROS 3D Robot Visualizer","fork":true,"url":"https://api.github.com/repos/hdeeken/rviz","forks_url":"https://api.github.com/repos/hdeeken/rviz/forks","keys_url":"https://api.github.com/repos/hdeeken/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hdeeken/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hdeeken/rviz/teams","hooks_url":"https://api.github.com/repos/hdeeken/rviz/hooks","issue_events_url":"https://api.github.com/repos/hdeeken/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/hdeeken/rviz/events","assignees_url":"https://api.github.com/repos/hdeeken/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/hdeeken/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/hdeeken/rviz/tags","blobs_url":"https://api.github.com/repos/hdeeken/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hdeeken/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hdeeken/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/hdeeken/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hdeeken/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/hdeeken/rviz/languages","stargazers_url":"https://api.github.com/repos/hdeeken/rviz/stargazers","contributors_url":"https://api.github.com/repos/hdeeken/rviz/contributors","subscribers_url":"https://api.github.com/repos/hdeeken/rviz/subscribers","subscription_url":"https://api.github.com/repos/hdeeken/rviz/subscription","commits_url":"https://api.github.com/repos/hdeeken/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/hdeeken/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/hdeeken/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/hdeeken/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/hdeeken/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/hdeeken/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hdeeken/rviz/merges","archive_url":"https://api.github.com/repos/hdeeken/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hdeeken/rviz/downloads","issues_url":"https://api.github.com/repos/hdeeken/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/hdeeken/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/hdeeken/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/hdeeken/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hdeeken/rviz/labels{/name}","releases_url":"https://api.github.com/repos/hdeeken/rviz/releases{/id}","created_at":"2015-01-20T20:07:25Z","updated_at":"2015-02-24T14:03:14Z","pushed_at":"2015-02-24T14:03:13Z","git_url":"git://github.com/hdeeken/rviz.git","ssh_url":"git@github.com:hdeeken/rviz.git","clone_url":"https://github.com/hdeeken/rviz.git","svn_url":"https://github.com/hdeeken/rviz","homepage":null,"size":12836,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"ros-visualization:indigo-devel","ref":"indigo-devel","sha":"26f68fae6cc59c6b1f15954fa2e1dc219564f720","user":{"login":"ros-visualization","id":2328629,"avatar_url":"https://avatars.githubusercontent.com/u/2328629?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":5860736,"name":"rviz","full_name":"ros-visualization/rviz","owner":{"login":"ros-visualization","id":2328629,"avatar_url":"https://avatars.githubusercontent.com/u/2328629?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-visualization/rviz","description":"ROS 3D Robot Visualizer","fork":false,"url":"https://api.github.com/repos/ros-visualization/rviz","forks_url":"https://api.github.com/repos/ros-visualization/rviz/forks","keys_url":"https://api.github.com/repos/ros-visualization/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-visualization/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-visualization/rviz/teams","hooks_url":"https://api.github.com/repos/ros-visualization/rviz/hooks","issue_events_url":"https://api.github.com/repos/ros-visualization/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/ros-visualization/rviz/events","assignees_url":"https://api.github.com/repos/ros-visualization/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/ros-visualization/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/ros-visualization/rviz/tags","blobs_url":"https://api.github.com/repos/ros-visualization/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-visualization/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-visualization/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-visualization/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-visualization/rviz/languages","stargazers_url":"https://api.github.com/repos/ros-visualization/rviz/stargazers","contributors_url":"https://api.github.com/repos/ros-visualization/rviz/contributors","subscribers_url":"https://api.github.com/repos/ros-visualization/rviz/subscribers","subscription_url":"https://api.github.com/repos/ros-visualization/rviz/subscription","commits_url":"https://api.github.com/repos/ros-visualization/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-visualization/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-visualization/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-visualization/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/ros-visualization/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-visualization/rviz/merges","archive_url":"https://api.github.com/repos/ros-visualization/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-visualization/rviz/downloads","issues_url":"https://api.github.com/repos/ros-visualization/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/ros-visualization/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-visualization/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-visualization/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-visualization/rviz/labels{/name}","releases_url":"https://api.github.com/repos/ros-visualization/rviz/releases{/id}","created_at":"2012-09-18T18:15:03Z","updated_at":"2015-02-14T00:20:58Z","pushed_at":"2015-02-14T00:26:33Z","git_url":"git://github.com/ros-visualization/rviz.git","ssh_url":"git@github.com:ros-visualization/rviz.git","clone_url":"https://github.com/ros-visualization/rviz.git","svn_url":"https://github.com/ros-visualization/rviz","homepage":null,"size":17611,"stargazers_count":29,"watchers_count":29,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":68,"forks":72,"open_issues":68,"watchers":29,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/852"},"html":{"href":"https://github.com/ros-visualization/rviz/pull/852"},"issue":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/852"},"comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/852/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/852/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/852/commits"},"statuses":{"href":"https://api.github.com/repos/ros-visualization/rviz/statuses/5d5d5bb6091f9b1230af4557877e568c1b0bfc89"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":25,"deletions":26,"changed_files":3}}