{"action":"opened","number":1046,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046","id":53439368,"html_url":"https://github.com/ReactiveX/RxJS/pull/1046","diff_url":"https://github.com/ReactiveX/RxJS/pull/1046.diff","patch_url":"https://github.com/ReactiveX/RxJS/pull/1046.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1046","number":1046,"state":"open","locked":false,"title":"fix(distinctUntilChanged): implement optional keySelector","user":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"body":"Currently, `distinctUntilChanged` holds on to the [previous distinct `value`](https://github.com/ReactiveX/RxJS/blob/master/src/operator/distinctUntilChanged.ts#L48), which is incorrect. `distinctUntilChanged` should use an optional `keySelector` to [pick a key from each event](https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/distinctuntilchanged.js#L20), and only retain the `key` itself.","created_at":"2015-12-11T20:20:20Z","updated_at":"2015-12-11T20:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/1046/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJS/statuses/28803ce4f99b16ffbda2ea0ca1d0f87bbd88e29b","head":{"label":"trxcllnt:fix-distinctUntilChanged","ref":"fix-distinctUntilChanged","sha":"28803ce4f99b16ffbda2ea0ca1d0f87bbd88e29b","user":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"repo":{"id":42749612,"name":"RxJS","full_name":"trxcllnt/RxJS","owner":{"login":"trxcllnt","id":178183,"avatar_url":"https://avatars.githubusercontent.com/u/178183?v=3","gravatar_id":"","url":"https://api.github.com/users/trxcllnt","html_url":"https://github.com/trxcllnt","followers_url":"https://api.github.com/users/trxcllnt/followers","following_url":"https://api.github.com/users/trxcllnt/following{/other_user}","gists_url":"https://api.github.com/users/trxcllnt/gists{/gist_id}","starred_url":"https://api.github.com/users/trxcllnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trxcllnt/subscriptions","organizations_url":"https://api.github.com/users/trxcllnt/orgs","repos_url":"https://api.github.com/users/trxcllnt/repos","events_url":"https://api.github.com/users/trxcllnt/events{/privacy}","received_events_url":"https://api.github.com/users/trxcllnt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trxcllnt/RxJS","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/trxcllnt/RxJS","forks_url":"https://api.github.com/repos/trxcllnt/RxJS/forks","keys_url":"https://api.github.com/repos/trxcllnt/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trxcllnt/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trxcllnt/RxJS/teams","hooks_url":"https://api.github.com/repos/trxcllnt/RxJS/hooks","issue_events_url":"https://api.github.com/repos/trxcllnt/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/trxcllnt/RxJS/events","assignees_url":"https://api.github.com/repos/trxcllnt/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/trxcllnt/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/trxcllnt/RxJS/tags","blobs_url":"https://api.github.com/repos/trxcllnt/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trxcllnt/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trxcllnt/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/trxcllnt/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trxcllnt/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/trxcllnt/RxJS/languages","stargazers_url":"https://api.github.com/repos/trxcllnt/RxJS/stargazers","contributors_url":"https://api.github.com/repos/trxcllnt/RxJS/contributors","subscribers_url":"https://api.github.com/repos/trxcllnt/RxJS/subscribers","subscription_url":"https://api.github.com/repos/trxcllnt/RxJS/subscription","commits_url":"https://api.github.com/repos/trxcllnt/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/trxcllnt/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/trxcllnt/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/trxcllnt/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/trxcllnt/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/trxcllnt/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trxcllnt/RxJS/merges","archive_url":"https://api.github.com/repos/trxcllnt/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trxcllnt/RxJS/downloads","issues_url":"https://api.github.com/repos/trxcllnt/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/trxcllnt/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/trxcllnt/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/trxcllnt/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trxcllnt/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/trxcllnt/RxJS/releases{/id}","created_at":"2015-09-18T22:19:34Z","updated_at":"2015-09-18T22:19:35Z","pushed_at":"2015-12-11T20:18:28Z","git_url":"git://github.com/trxcllnt/RxJS.git","ssh_url":"git@github.com:trxcllnt/RxJS.git","clone_url":"https://github.com/trxcllnt/RxJS.git","svn_url":"https://github.com/trxcllnt/RxJS","homepage":null,"size":4593,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"fc3dcf7530b2bde115094e16859f8d8937c9d9b9","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"name":"RxJS","full_name":"ReactiveX/RxJS","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJS","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJS","forks_url":"https://api.github.com/repos/ReactiveX/RxJS/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJS/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJS/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJS/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJS/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJS/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJS/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJS/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJS/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJS/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJS/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJS/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJS/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJS/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJS/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJS/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJS/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJS/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJS/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJS/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJS/releases{/id}","created_at":"2015-03-15T06:17:10Z","updated_at":"2015-12-11T17:44:11Z","pushed_at":"2015-12-11T19:18:41Z","git_url":"git://github.com/ReactiveX/RxJS.git","ssh_url":"git@github.com:ReactiveX/RxJS.git","clone_url":"https://github.com/ReactiveX/RxJS.git","svn_url":"https://github.com/ReactiveX/RxJS","homepage":null,"size":8556,"stargazers_count":764,"watchers_count":764,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":72,"mirror_url":null,"open_issues_count":59,"forks":72,"open_issues":59,"watchers":764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046"},"html":{"href":"https://github.com/ReactiveX/RxJS/pull/1046"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJS/issues/1046"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJS/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJS/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJS/statuses/28803ce4f99b16ffbda2ea0ca1d0f87bbd88e29b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":66,"deletions":23,"changed_files":2}}