{"action":"created","comment":{"url":"https://api.github.com/repos/oyiptong/splice/pulls/comments/45762676","id":45762676,"diff_hunk":"@@ -1,11 +1,7 @@\n import fetch from 'isomorphic-fetch';\n+import * as config from 'helpers/config';\n \n-let apiUrl;\n-if (typeof __DEVELOPMENT__ !== 'undefined' && __DEVELOPMENT__ === true) {\n-  apiUrl = __DEVAPI__;\n-} else {\n-  apiUrl = __LIVEAPI__;\n-}\n+const apiUrl = config.get('DEVELOPMENT') ? config.get('DEV_API') : config.get('LIVE_API');","path":"front_end/src/actions/AdGroups/AdGroupActions.js","position":10,"original_position":10,"commit_id":"d278026c374d8e755fde655848bd9799fb7ed7f0","original_commit_id":"d278026c374d8e755fde655848bd9799fb7ed7f0","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"Yeah i agree","created_at":"2015-11-24T16:56:38Z","updated_at":"2015-11-24T16:56:38Z","html_url":"https://github.com/oyiptong/splice/pull/254#discussion_r45762676","pull_request_url":"https://api.github.com/repos/oyiptong/splice/pulls/254","_links":{"self":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/comments/45762676"},"html":{"href":"https://github.com/oyiptong/splice/pull/254#discussion_r45762676"},"pull_request":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/oyiptong/splice/pulls/254","id":51587806,"html_url":"https://github.com/oyiptong/splice/pull/254","diff_url":"https://github.com/oyiptong/splice/pull/254.diff","patch_url":"https://github.com/oyiptong/splice/pull/254.patch","issue_url":"https://api.github.com/repos/oyiptong/splice/issues/254","number":254,"state":"open","locked":false,"title":"Better configuration for front end","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"OK, so this does a few things:\r\n\r\n* allows for a local settings.conf.js file that's gitignored\r\n* groups all configuration under one global (`__CONFIG__`)\r\n* uses a common file to generate webpack settings for karma/webpack\r\n\r\nI wrote the node stuff in node 4 so I need to update travis to use that","created_at":"2015-11-23T22:09:08Z","updated_at":"2015-11-24T16:56:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af5503dc15019a1d77abfb3bad80f66432114d58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oyiptong/splice/pulls/254/commits","review_comments_url":"https://api.github.com/repos/oyiptong/splice/pulls/254/comments","review_comment_url":"https://api.github.com/repos/oyiptong/splice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oyiptong/splice/issues/254/comments","statuses_url":"https://api.github.com/repos/oyiptong/splice/statuses/d278026c374d8e755fde655848bd9799fb7ed7f0","head":{"label":"k88hudson:configuration","ref":"configuration","sha":"d278026c374d8e755fde655848bd9799fb7ed7f0","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"repo":{"id":43558288,"name":"splice","full_name":"k88hudson/splice","owner":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k88hudson/splice","description":"Firefox Tiles Ingestion, Validation and Reporting tool","fork":true,"url":"https://api.github.com/repos/k88hudson/splice","forks_url":"https://api.github.com/repos/k88hudson/splice/forks","keys_url":"https://api.github.com/repos/k88hudson/splice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k88hudson/splice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k88hudson/splice/teams","hooks_url":"https://api.github.com/repos/k88hudson/splice/hooks","issue_events_url":"https://api.github.com/repos/k88hudson/splice/issues/events{/number}","events_url":"https://api.github.com/repos/k88hudson/splice/events","assignees_url":"https://api.github.com/repos/k88hudson/splice/assignees{/user}","branches_url":"https://api.github.com/repos/k88hudson/splice/branches{/branch}","tags_url":"https://api.github.com/repos/k88hudson/splice/tags","blobs_url":"https://api.github.com/repos/k88hudson/splice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k88hudson/splice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k88hudson/splice/git/refs{/sha}","trees_url":"https://api.github.com/repos/k88hudson/splice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k88hudson/splice/statuses/{sha}","languages_url":"https://api.github.com/repos/k88hudson/splice/languages","stargazers_url":"https://api.github.com/repos/k88hudson/splice/stargazers","contributors_url":"https://api.github.com/repos/k88hudson/splice/contributors","subscribers_url":"https://api.github.com/repos/k88hudson/splice/subscribers","subscription_url":"https://api.github.com/repos/k88hudson/splice/subscription","commits_url":"https://api.github.com/repos/k88hudson/splice/commits{/sha}","git_commits_url":"https://api.github.com/repos/k88hudson/splice/git/commits{/sha}","comments_url":"https://api.github.com/repos/k88hudson/splice/comments{/number}","issue_comment_url":"https://api.github.com/repos/k88hudson/splice/issues/comments{/number}","contents_url":"https://api.github.com/repos/k88hudson/splice/contents/{+path}","compare_url":"https://api.github.com/repos/k88hudson/splice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k88hudson/splice/merges","archive_url":"https://api.github.com/repos/k88hudson/splice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k88hudson/splice/downloads","issues_url":"https://api.github.com/repos/k88hudson/splice/issues{/number}","pulls_url":"https://api.github.com/repos/k88hudson/splice/pulls{/number}","milestones_url":"https://api.github.com/repos/k88hudson/splice/milestones{/number}","notifications_url":"https://api.github.com/repos/k88hudson/splice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k88hudson/splice/labels{/name}","releases_url":"https://api.github.com/repos/k88hudson/splice/releases{/id}","created_at":"2015-10-02T14:45:07Z","updated_at":"2015-10-02T14:45:09Z","pushed_at":"2015-11-24T16:38:47Z","git_url":"git://github.com/k88hudson/splice.git","ssh_url":"git@github.com:k88hudson/splice.git","clone_url":"https://github.com/k88hudson/splice.git","svn_url":"https://github.com/k88hudson/splice","homepage":"","size":31397,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oyiptong:sp2","ref":"sp2","sha":"a8154f91666f2516ae4a7138caf76efa1ac68006","user":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"repo":{"id":22929675,"name":"splice","full_name":"oyiptong/splice","owner":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oyiptong/splice","description":"Firefox Tiles Ingestion, Validation and Reporting tool","fork":false,"url":"https://api.github.com/repos/oyiptong/splice","forks_url":"https://api.github.com/repos/oyiptong/splice/forks","keys_url":"https://api.github.com/repos/oyiptong/splice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oyiptong/splice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oyiptong/splice/teams","hooks_url":"https://api.github.com/repos/oyiptong/splice/hooks","issue_events_url":"https://api.github.com/repos/oyiptong/splice/issues/events{/number}","events_url":"https://api.github.com/repos/oyiptong/splice/events","assignees_url":"https://api.github.com/repos/oyiptong/splice/assignees{/user}","branches_url":"https://api.github.com/repos/oyiptong/splice/branches{/branch}","tags_url":"https://api.github.com/repos/oyiptong/splice/tags","blobs_url":"https://api.github.com/repos/oyiptong/splice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oyiptong/splice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oyiptong/splice/git/refs{/sha}","trees_url":"https://api.github.com/repos/oyiptong/splice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oyiptong/splice/statuses/{sha}","languages_url":"https://api.github.com/repos/oyiptong/splice/languages","stargazers_url":"https://api.github.com/repos/oyiptong/splice/stargazers","contributors_url":"https://api.github.com/repos/oyiptong/splice/contributors","subscribers_url":"https://api.github.com/repos/oyiptong/splice/subscribers","subscription_url":"https://api.github.com/repos/oyiptong/splice/subscription","commits_url":"https://api.github.com/repos/oyiptong/splice/commits{/sha}","git_commits_url":"https://api.github.com/repos/oyiptong/splice/git/commits{/sha}","comments_url":"https://api.github.com/repos/oyiptong/splice/comments{/number}","issue_comment_url":"https://api.github.com/repos/oyiptong/splice/issues/comments{/number}","contents_url":"https://api.github.com/repos/oyiptong/splice/contents/{+path}","compare_url":"https://api.github.com/repos/oyiptong/splice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oyiptong/splice/merges","archive_url":"https://api.github.com/repos/oyiptong/splice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oyiptong/splice/downloads","issues_url":"https://api.github.com/repos/oyiptong/splice/issues{/number}","pulls_url":"https://api.github.com/repos/oyiptong/splice/pulls{/number}","milestones_url":"https://api.github.com/repos/oyiptong/splice/milestones{/number}","notifications_url":"https://api.github.com/repos/oyiptong/splice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oyiptong/splice/labels{/name}","releases_url":"https://api.github.com/repos/oyiptong/splice/releases{/id}","created_at":"2014-08-13T20:10:36Z","updated_at":"2015-11-11T15:32:25Z","pushed_at":"2015-11-24T16:36:36Z","git_url":"git://github.com/oyiptong/splice.git","ssh_url":"git@github.com:oyiptong/splice.git","clone_url":"https://github.com/oyiptong/splice.git","svn_url":"https://github.com/oyiptong/splice","homepage":"","size":31703,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":39,"forks":10,"open_issues":39,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/254"},"html":{"href":"https://github.com/oyiptong/splice/pull/254"},"issue":{"href":"https://api.github.com/repos/oyiptong/splice/issues/254"},"comments":{"href":"https://api.github.com/repos/oyiptong/splice/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oyiptong/splice/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/oyiptong/splice/statuses/d278026c374d8e755fde655848bd9799fb7ed7f0"}}}}