{"action":"created","comment":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27188691","id":27188691,"diff_hunk":"@@ -90,67 +79,50 @@\n       }\n \n       &.has_nested:hover > a {\n-        @include rounded-top(10px);\n         border-bottom: 5px solid $hover-menu-item-background;\n         background: $hover-menu-item-background image-url('active_admin/nested_menu_arrow_dark.gif') no-repeat calc(100% - 7px) 50%;\n         z-index: 1020;\n       }\n \n-\n       /* Hover on li, display the ul */\n-      &:hover ul { display: block;}\n+      &:hover ul {\n+        display: block;\n+      }\n+\n       /* Drop down menus */\n       ul {\n         background: $hover-menu-item-background;\n-        @include rounded-all(0,10px,10px,10px);\n-        @include shadow(0, 1px, 3px, #444);\n-        position: absolute;\n-        width: 120%;\n-        min-width: 175px;\n-        max-width: calc(100% + 20px);\n-        margin-top: 5px;\n-        float: left;\n+        border-radius: 0 4px 4px 4px;\n+        box-shadow: 0 1px 3px rgba(0, 0, 0, 0.2);\n         display: none;\n-        padding: 3px 0px 5px 0;\n         list-style: none;\n+        margin-top: 5px;\n+        min-width: 175px;\n+        padding: 5px 0;\n+        position: absolute;\n         z-index: 1010;\n \n         li {\n-          margin: 0px;\n           a {\n-            background: none;\n             display: block;\n-            &:hover { color: #fff; background: none; }\n           }\n \n-          &.current {\n-            a { @include rounded(0) }\n+          &.current a,\n+          a:hover {\n+            color: #fff;\n           }\n         }\n       }\n     }\n-\n-  }\n-\n-  #tabs {\n-    width: 100%;\n-  }\n-\n-  #utility_nav {\n-    color: #aaa;\n-    display: table-cell;\n-    white-space: nowrap;\n-    margin: 0;\n-    padding: 0;\n-    padding-right: 26px;\n-    text-align: right;\n-\n-    a { text-decoration: none; }\n-    a:hover { color: #fff; }\n-\n-    li {\n-      display:inline;\n-    }\n   }\n+}\n \n+#utility_nav {\n+  color: #aaa;\n+  display: table-cell;\n+  white-space: nowrap;","path":"app/assets/stylesheets/active_admin/_header.scss","position":171,"original_position":171,"commit_id":"9f3f645b15f4404abc716b773646458809497842","original_commit_id":"9f3f645b15f4404abc716b773646458809497842","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Properties should be ordered color, display, margin, padding, padding-right, text-align, white-space","created_at":"2015-03-26T05:05:31Z","updated_at":"2015-03-26T05:05:31Z","html_url":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27188691","pull_request_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments/27188691"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862#discussion_r27188691"},"pull_request":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"}}},"pull_request":{"url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862","id":31797608,"html_url":"https://github.com/activeadmin/activeadmin/pull/3862","diff_url":"https://github.com/activeadmin/activeadmin/pull/3862.diff","patch_url":"https://github.com/activeadmin/activeadmin/pull/3862.patch","issue_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862","number":3862,"state":"open","locked":false,"title":"WIP: Overhaul CSS for maintainability and customization","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"body":"I've seen mention about CSS overhauls but nothing seems active, if anything years old. I'm attempting to streamline the CSS to make it easier to maintain, improve and finally customize. I see this happening in several steps. So far this is what I have in mind and how it will help:\r\n\r\n- [x] Replace reset with normalize.css (resets make debugging horrendously difficult)\r\n- [ ] Remove excessive styles e.g. gradients, shadows (keep default theme basic, only what’s necessary and we can build from there)\r\n- [ ] Remove unnecessary styles (many have no effect or are repetitive, apply smarter defaults)\r\n  - [ ] Clean up typography\r\n  - [ ] Replace strip table even/odd classes with nth-child selectors \r\n  - [ ] Fix calc in forms due to box-sizing:border-box global change\r\n- [ ] Reduce selector specificity (3 ids and 1 class in one selector says it all 😩)\r\n- [ ] Replace id based selectors with class based ones but keeping ids in HTML in place\r\n- [ ] Configure component styles using variables (e.g. Foundation or Bootstrap) starting off with something simple like status tag and go from there\r\n- [ ] Hound be houndin me! (most Hound complaints should be solved by earlier tasks)\r\n- [ ] Consider whether we use variables for customizing theme or a different approach? Perhaps going the route of variables first might be good enough for a 1.0 release.\r\n\r\n## How can I help?\r\n\r\n* use my branch to test out how the changes are affecting your admin\r\n* there is an icons mixin file, where and how is that used? sample code?\r\n* sample code for other ActiveAdmin features to include in the generated test project, features I don’t know anything about (tabs in header, icons, popovers, modals, etc.","created_at":"2015-03-24T05:04:13Z","updated_at":"2015-03-26T05:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f47ca3b3ae0285e69576067b610c6b891dcb329c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits","review_comments_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments","review_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/9f3f645b15f4404abc716b773646458809497842","head":{"label":"javierjulio:update-css-with-overhaul","ref":"update-css-with-overhaul","sha":"9f3f645b15f4404abc716b773646458809497842","user":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"repo":{"id":32771575,"name":"activeadmin","full_name":"javierjulio/activeadmin","owner":{"login":"javierjulio","id":198547,"avatar_url":"https://avatars.githubusercontent.com/u/198547?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjulio","html_url":"https://github.com/javierjulio","followers_url":"https://api.github.com/users/javierjulio/followers","following_url":"https://api.github.com/users/javierjulio/following{/other_user}","gists_url":"https://api.github.com/users/javierjulio/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjulio/subscriptions","organizations_url":"https://api.github.com/users/javierjulio/orgs","repos_url":"https://api.github.com/users/javierjulio/repos","events_url":"https://api.github.com/users/javierjulio/events{/privacy}","received_events_url":"https://api.github.com/users/javierjulio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierjulio/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":true,"url":"https://api.github.com/repos/javierjulio/activeadmin","forks_url":"https://api.github.com/repos/javierjulio/activeadmin/forks","keys_url":"https://api.github.com/repos/javierjulio/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierjulio/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierjulio/activeadmin/teams","hooks_url":"https://api.github.com/repos/javierjulio/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/javierjulio/activeadmin/events","assignees_url":"https://api.github.com/repos/javierjulio/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/javierjulio/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/javierjulio/activeadmin/tags","blobs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierjulio/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierjulio/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierjulio/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierjulio/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/javierjulio/activeadmin/languages","stargazers_url":"https://api.github.com/repos/javierjulio/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/javierjulio/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/javierjulio/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/javierjulio/activeadmin/subscription","commits_url":"https://api.github.com/repos/javierjulio/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierjulio/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierjulio/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierjulio/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierjulio/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/javierjulio/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierjulio/activeadmin/merges","archive_url":"https://api.github.com/repos/javierjulio/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierjulio/activeadmin/downloads","issues_url":"https://api.github.com/repos/javierjulio/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/javierjulio/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/javierjulio/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/javierjulio/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierjulio/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/javierjulio/activeadmin/releases{/id}","created_at":"2015-03-24T02:32:35Z","updated_at":"2015-03-24T02:32:38Z","pushed_at":"2015-03-26T05:05:06Z","git_url":"git://github.com/javierjulio/activeadmin.git","ssh_url":"git@github.com:javierjulio/activeadmin.git","clone_url":"https://github.com/javierjulio/activeadmin.git","svn_url":"https://github.com/javierjulio/activeadmin","homepage":"activeadmin.info","size":19207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activeadmin:master","ref":"master","sha":"078f234288a15982217ab2594631ef259985b16f","user":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"repo":{"id":611921,"name":"activeadmin","full_name":"activeadmin/activeadmin","owner":{"login":"activeadmin","id":814570,"avatar_url":"https://avatars.githubusercontent.com/u/814570?v=3","gravatar_id":"","url":"https://api.github.com/users/activeadmin","html_url":"https://github.com/activeadmin","followers_url":"https://api.github.com/users/activeadmin/followers","following_url":"https://api.github.com/users/activeadmin/following{/other_user}","gists_url":"https://api.github.com/users/activeadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/activeadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeadmin/subscriptions","organizations_url":"https://api.github.com/users/activeadmin/orgs","repos_url":"https://api.github.com/users/activeadmin/repos","events_url":"https://api.github.com/users/activeadmin/events{/privacy}","received_events_url":"https://api.github.com/users/activeadmin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activeadmin/activeadmin","description":"The administration framework for Ruby on Rails applications.","fork":false,"url":"https://api.github.com/repos/activeadmin/activeadmin","forks_url":"https://api.github.com/repos/activeadmin/activeadmin/forks","keys_url":"https://api.github.com/repos/activeadmin/activeadmin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activeadmin/activeadmin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activeadmin/activeadmin/teams","hooks_url":"https://api.github.com/repos/activeadmin/activeadmin/hooks","issue_events_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/events{/number}","events_url":"https://api.github.com/repos/activeadmin/activeadmin/events","assignees_url":"https://api.github.com/repos/activeadmin/activeadmin/assignees{/user}","branches_url":"https://api.github.com/repos/activeadmin/activeadmin/branches{/branch}","tags_url":"https://api.github.com/repos/activeadmin/activeadmin/tags","blobs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activeadmin/activeadmin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activeadmin/activeadmin/git/refs{/sha}","trees_url":"https://api.github.com/repos/activeadmin/activeadmin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activeadmin/activeadmin/statuses/{sha}","languages_url":"https://api.github.com/repos/activeadmin/activeadmin/languages","stargazers_url":"https://api.github.com/repos/activeadmin/activeadmin/stargazers","contributors_url":"https://api.github.com/repos/activeadmin/activeadmin/contributors","subscribers_url":"https://api.github.com/repos/activeadmin/activeadmin/subscribers","subscription_url":"https://api.github.com/repos/activeadmin/activeadmin/subscription","commits_url":"https://api.github.com/repos/activeadmin/activeadmin/commits{/sha}","git_commits_url":"https://api.github.com/repos/activeadmin/activeadmin/git/commits{/sha}","comments_url":"https://api.github.com/repos/activeadmin/activeadmin/comments{/number}","issue_comment_url":"https://api.github.com/repos/activeadmin/activeadmin/issues/comments{/number}","contents_url":"https://api.github.com/repos/activeadmin/activeadmin/contents/{+path}","compare_url":"https://api.github.com/repos/activeadmin/activeadmin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activeadmin/activeadmin/merges","archive_url":"https://api.github.com/repos/activeadmin/activeadmin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activeadmin/activeadmin/downloads","issues_url":"https://api.github.com/repos/activeadmin/activeadmin/issues{/number}","pulls_url":"https://api.github.com/repos/activeadmin/activeadmin/pulls{/number}","milestones_url":"https://api.github.com/repos/activeadmin/activeadmin/milestones{/number}","notifications_url":"https://api.github.com/repos/activeadmin/activeadmin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activeadmin/activeadmin/labels{/name}","releases_url":"https://api.github.com/repos/activeadmin/activeadmin/releases{/id}","created_at":"2010-04-15T14:26:03Z","updated_at":"2015-03-26T03:16:32Z","pushed_at":"2015-03-26T05:05:09Z","git_url":"git://github.com/activeadmin/activeadmin.git","ssh_url":"git@github.com:activeadmin/activeadmin.git","clone_url":"https://github.com/activeadmin/activeadmin.git","svn_url":"https://github.com/activeadmin/activeadmin","homepage":"activeadmin.info","size":19207,"stargazers_count":5799,"watchers_count":5799,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2076,"mirror_url":null,"open_issues_count":190,"forks":2076,"open_issues":190,"watchers":5799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862"},"html":{"href":"https://github.com/activeadmin/activeadmin/pull/3862"},"issue":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862"},"comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/issues/3862/comments"},"review_comments":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/comments"},"review_comment":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activeadmin/activeadmin/pulls/3862/commits"},"statuses":{"href":"https://api.github.com/repos/activeadmin/activeadmin/statuses/9f3f645b15f4404abc716b773646458809497842"}}}}