{"action":"created","issue":{"url":"https://api.github.com/repos/apocas/dockerode/issues/126","labels_url":"https://api.github.com/repos/apocas/dockerode/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/apocas/dockerode/issues/126/comments","events_url":"https://api.github.com/repos/apocas/dockerode/issues/126/events","html_url":"https://github.com/apocas/dockerode/pull/126","id":60232178,"number":126,"title":"drop underscore, slight tidy-up","user":{"login":"jokeyrhyme","id":479816,"avatar_url":"https://avatars.githubusercontent.com/u/479816?v=3","gravatar_id":"","url":"https://api.github.com/users/jokeyrhyme","html_url":"https://github.com/jokeyrhyme","followers_url":"https://api.github.com/users/jokeyrhyme/followers","following_url":"https://api.github.com/users/jokeyrhyme/following{/other_user}","gists_url":"https://api.github.com/users/jokeyrhyme/gists{/gist_id}","starred_url":"https://api.github.com/users/jokeyrhyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokeyrhyme/subscriptions","organizations_url":"https://api.github.com/users/jokeyrhyme/orgs","repos_url":"https://api.github.com/users/jokeyrhyme/repos","events_url":"https://api.github.com/users/jokeyrhyme/events{/privacy}","received_events_url":"https://api.github.com/users/jokeyrhyme/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-03-08T00:00:12Z","updated_at":"2015-03-15T01:45:28Z","closed_at":"2015-03-14T21:10:27Z","pull_request":{"url":"https://api.github.com/repos/apocas/dockerode/pulls/126","html_url":"https://github.com/apocas/dockerode/pull/126","diff_url":"https://github.com/apocas/dockerode/pull/126.diff","patch_url":"https://github.com/apocas/dockerode/pull/126.patch"},"body":"Firstly, thanks for providing this module, as it's exactly what I've been looking for.\r\n\r\nI noticed that it depends on [Underscore.js](http://underscorejs.org/), but only uses it for either `_.extend` or tasks that aren't terrible in vanilla JavaScript. This PR replaces Underscore.js with the [extend-object](https://www.npmjs.com/package/extend-object) module.\r\n\r\nI've also:\r\n- started some ESLint options for tooling convenience\r\n- swapped `typeof(value)` usage for `typeof value` for correctness\r\n- updated the README.md test instructions to mention that manually pulling the Ubuntu image is required\r\n\r\nI can break this up into separate PRs, or squash it into a single commit, or remove things you don't agree with. `npm test` passes. Let me know what you think. :)"},"comment":{"url":"https://api.github.com/repos/apocas/dockerode/issues/comments/80792939","html_url":"https://github.com/apocas/dockerode/pull/126#issuecomment-80792939","issue_url":"https://api.github.com/repos/apocas/dockerode/issues/126","id":80792939,"user":{"login":"jokeyrhyme","id":479816,"avatar_url":"https://avatars.githubusercontent.com/u/479816?v=3","gravatar_id":"","url":"https://api.github.com/users/jokeyrhyme","html_url":"https://github.com/jokeyrhyme","followers_url":"https://api.github.com/users/jokeyrhyme/followers","following_url":"https://api.github.com/users/jokeyrhyme/following{/other_user}","gists_url":"https://api.github.com/users/jokeyrhyme/gists{/gist_id}","starred_url":"https://api.github.com/users/jokeyrhyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokeyrhyme/subscriptions","organizations_url":"https://api.github.com/users/jokeyrhyme/orgs","repos_url":"https://api.github.com/users/jokeyrhyme/repos","events_url":"https://api.github.com/users/jokeyrhyme/events{/privacy}","received_events_url":"https://api.github.com/users/jokeyrhyme/received_events","type":"User","site_admin":false},"created_at":"2015-03-15T01:45:28Z","updated_at":"2015-03-15T01:45:28Z","body":"Now we just need to get rid of Underscore in docker-modem. :)"}}