{"action":"closed","number":2812,"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812","id":48158898,"html_url":"https://github.com/PowerDNS/pdns/pull/2812","diff_url":"https://github.com/PowerDNS/pdns/pull/2812.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/2812.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/2812","number":2812,"state":"closed","locked":false,"title":"Use token label in PKCS#11 instead of slot ID","user":{"login":"cmouse","id":1204643,"avatar_url":"https://avatars.githubusercontent.com/u/1204643?v=3","gravatar_id":"","url":"https://api.github.com/users/cmouse","html_url":"https://github.com/cmouse","followers_url":"https://api.github.com/users/cmouse/followers","following_url":"https://api.github.com/users/cmouse/following{/other_user}","gists_url":"https://api.github.com/users/cmouse/gists{/gist_id}","starred_url":"https://api.github.com/users/cmouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmouse/subscriptions","organizations_url":"https://api.github.com/users/cmouse/orgs","repos_url":"https://api.github.com/users/cmouse/repos","events_url":"https://api.github.com/users/cmouse/events{/privacy}","received_events_url":"https://api.github.com/users/cmouse/received_events","type":"User","site_admin":false},"body":"SoftHSM2 at least does not retain slot ID order if you add more slots, so we need to use token label instead to make sure we open the same token each time. Contains backwards compability with token slots IDs to prevent breakage.","created_at":"2015-10-20T05:40:27Z","updated_at":"2015-10-26T08:03:50Z","closed_at":"2015-10-26T08:03:50Z","merged_at":"2015-10-26T08:03:50Z","merge_commit_sha":"a14c81456de6dccaea46fc4d8a6164fe09c62b45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/2812/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/092c013d894bacbb9971b00b6731ee048d51a18b","head":{"label":"cmouse:pkcs11-token-label","ref":"pkcs11-token-label","sha":"092c013d894bacbb9971b00b6731ee048d51a18b","user":{"login":"cmouse","id":1204643,"avatar_url":"https://avatars.githubusercontent.com/u/1204643?v=3","gravatar_id":"","url":"https://api.github.com/users/cmouse","html_url":"https://github.com/cmouse","followers_url":"https://api.github.com/users/cmouse/followers","following_url":"https://api.github.com/users/cmouse/following{/other_user}","gists_url":"https://api.github.com/users/cmouse/gists{/gist_id}","starred_url":"https://api.github.com/users/cmouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmouse/subscriptions","organizations_url":"https://api.github.com/users/cmouse/orgs","repos_url":"https://api.github.com/users/cmouse/repos","events_url":"https://api.github.com/users/cmouse/events{/privacy}","received_events_url":"https://api.github.com/users/cmouse/received_events","type":"User","site_admin":false},"repo":{"id":9715032,"name":"pdns","full_name":"cmouse/pdns","owner":{"login":"cmouse","id":1204643,"avatar_url":"https://avatars.githubusercontent.com/u/1204643?v=3","gravatar_id":"","url":"https://api.github.com/users/cmouse","html_url":"https://github.com/cmouse","followers_url":"https://api.github.com/users/cmouse/followers","following_url":"https://api.github.com/users/cmouse/following{/other_user}","gists_url":"https://api.github.com/users/cmouse/gists{/gist_id}","starred_url":"https://api.github.com/users/cmouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmouse/subscriptions","organizations_url":"https://api.github.com/users/cmouse/orgs","repos_url":"https://api.github.com/users/cmouse/repos","events_url":"https://api.github.com/users/cmouse/events{/privacy}","received_events_url":"https://api.github.com/users/cmouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmouse/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/cmouse/pdns","forks_url":"https://api.github.com/repos/cmouse/pdns/forks","keys_url":"https://api.github.com/repos/cmouse/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmouse/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmouse/pdns/teams","hooks_url":"https://api.github.com/repos/cmouse/pdns/hooks","issue_events_url":"https://api.github.com/repos/cmouse/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/cmouse/pdns/events","assignees_url":"https://api.github.com/repos/cmouse/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/cmouse/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/cmouse/pdns/tags","blobs_url":"https://api.github.com/repos/cmouse/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmouse/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmouse/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmouse/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmouse/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/cmouse/pdns/languages","stargazers_url":"https://api.github.com/repos/cmouse/pdns/stargazers","contributors_url":"https://api.github.com/repos/cmouse/pdns/contributors","subscribers_url":"https://api.github.com/repos/cmouse/pdns/subscribers","subscription_url":"https://api.github.com/repos/cmouse/pdns/subscription","commits_url":"https://api.github.com/repos/cmouse/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmouse/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmouse/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmouse/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmouse/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/cmouse/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmouse/pdns/merges","archive_url":"https://api.github.com/repos/cmouse/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmouse/pdns/downloads","issues_url":"https://api.github.com/repos/cmouse/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/cmouse/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/cmouse/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/cmouse/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmouse/pdns/labels{/name}","releases_url":"https://api.github.com/repos/cmouse/pdns/releases{/id}","created_at":"2013-04-27T13:28:27Z","updated_at":"2015-05-01T18:25:57Z","pushed_at":"2015-10-23T11:20:52Z","git_url":"git://github.com/cmouse/pdns.git","ssh_url":"git@github.com:cmouse/pdns.git","clone_url":"https://github.com/cmouse/pdns.git","svn_url":"https://github.com/cmouse/pdns","homepage":null,"size":28283,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"a497ce4ac95d57ea800ff596f3bd5b6a878b5ce3","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","created_at":"2013-04-26T11:16:49Z","updated_at":"2015-10-25T15:50:59Z","pushed_at":"2015-10-26T08:03:50Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":47638,"stargazers_count":464,"watchers_count":464,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":376,"forks":168,"open_issues":376,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/2812"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/2812"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/2812/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2812/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/092c013d894bacbb9971b00b6731ee048d51a18b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ahupowerdns","id":1223657,"avatar_url":"https://avatars.githubusercontent.com/u/1223657?v=3","gravatar_id":"","url":"https://api.github.com/users/ahupowerdns","html_url":"https://github.com/ahupowerdns","followers_url":"https://api.github.com/users/ahupowerdns/followers","following_url":"https://api.github.com/users/ahupowerdns/following{/other_user}","gists_url":"https://api.github.com/users/ahupowerdns/gists{/gist_id}","starred_url":"https://api.github.com/users/ahupowerdns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahupowerdns/subscriptions","organizations_url":"https://api.github.com/users/ahupowerdns/orgs","repos_url":"https://api.github.com/users/ahupowerdns/repos","events_url":"https://api.github.com/users/ahupowerdns/events{/privacy}","received_events_url":"https://api.github.com/users/ahupowerdns/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":78,"deletions":31,"changed_files":7}}