{"action":"created","issue":{"url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/21","labels_url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/21/comments","events_url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/21/events","html_url":"https://github.com/dreamlayers/em-dosbox/pull/21","id":89211571,"number":21,"title":"ISO file support in CDROM module","user":{"login":"jbanes","id":381314,"avatar_url":"https://avatars.githubusercontent.com/u/381314?v=3","gravatar_id":"","url":"https://api.github.com/users/jbanes","html_url":"https://github.com/jbanes","followers_url":"https://api.github.com/users/jbanes/followers","following_url":"https://api.github.com/users/jbanes/following{/other_user}","gists_url":"https://api.github.com/users/jbanes/gists{/gist_id}","starred_url":"https://api.github.com/users/jbanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbanes/subscriptions","organizations_url":"https://api.github.com/users/jbanes/orgs","repos_url":"https://api.github.com/users/jbanes/repos","events_url":"https://api.github.com/users/jbanes/events{/privacy}","received_events_url":"https://api.github.com/users/jbanes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-18T06:26:40Z","updated_at":"2015-07-12T04:25:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dreamlayers/em-dosbox/pulls/21","html_url":"https://github.com/dreamlayers/em-dosbox/pull/21","diff_url":"https://github.com/dreamlayers/em-dosbox/pull/21.diff","patch_url":"https://github.com/dreamlayers/em-dosbox/pull/21.patch"},"body":"I believe you can safely re-enable ISO support in em-dosbox. The mutex functionality isn't supported in the SDL2 port, but that's partly because Javascript is inherently single threaded. The necessary functionality is in the language itself. \r\n\r\nGive this a try and see if it meets with your approval."},"comment":{"url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/comments/120685668","html_url":"https://github.com/dreamlayers/em-dosbox/pull/21#issuecomment-120685668","issue_url":"https://api.github.com/repos/dreamlayers/em-dosbox/issues/21","id":120685668,"user":{"login":"jbanes","id":381314,"avatar_url":"https://avatars.githubusercontent.com/u/381314?v=3","gravatar_id":"","url":"https://api.github.com/users/jbanes","html_url":"https://github.com/jbanes","followers_url":"https://api.github.com/users/jbanes/followers","following_url":"https://api.github.com/users/jbanes/following{/other_user}","gists_url":"https://api.github.com/users/jbanes/gists{/gist_id}","starred_url":"https://api.github.com/users/jbanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbanes/subscriptions","organizations_url":"https://api.github.com/users/jbanes/orgs","repos_url":"https://api.github.com/users/jbanes/repos","events_url":"https://api.github.com/users/jbanes/events{/privacy}","received_events_url":"https://api.github.com/users/jbanes/received_events","type":"User","site_admin":false},"created_at":"2015-07-12T04:25:59Z","updated_at":"2015-07-12T04:25:59Z","body":"In case there are any questions about if the patch has been tested, here are some screenshots of various CD games from GOG.com in action:\r\n\r\n### Wing Commander: Privateer\r\n![image](https://cloud.githubusercontent.com/assets/381314/8636229/6704d2ba-281b-11e5-95aa-88910f157c16.png)\r\n\r\n### SimCity 2000: Special Edition\r\n![image](https://cloud.githubusercontent.com/assets/381314/8636257/4512e140-281d-11e5-877c-6b765cc43054.png)\r\n\r\n### Bloodnet (Enhanced CDROM Version)\r\n![image](https://cloud.githubusercontent.com/assets/381314/8636299/5b4279f0-2820-11e5-95ec-ccfa0f7aec14.png)\r\n\r\n### Crusader: No Remorse\r\n![image](https://cloud.githubusercontent.com/assets/381314/8636326/b0a9ab56-2821-11e5-9e2d-6f76959042aa.png)\r\n\r\n### Under a Killing Moon\r\n![image](https://cloud.githubusercontent.com/assets/381314/8636353/91886342-2822-11e5-8921-94a048d0cf89.png)\r\n\r\nThese are all functional games. I only needed to add a dosbox.conf that was customized for the peculiarities of the web system. For example, this is the normal Crusader autoexec section:\r\n\r\n    [autoexec]\r\n    # Lines in this section will be run at startup.\r\n    mount C \"..\"\r\n    imgmount d \"..\\game.gog\" -t iso -fs iso\r\n    c:\r\n    cls\r\n    crusader.EXE\r\n    exit\r\n\r\nHere's the section modified for web use:\r\n\r\n    [autoexec]\r\n    # Lines in this section will be run at startup.\r\n    mount C /\r\n    c:\r\n    imgmount d \"game.gog\" -t cdrom -fs iso\r\n    cls\r\n    crusader.exe\r\n    exit\r\n\r\nSome key points to note:\r\n\r\n1. Shouldn't be a big surprise, but C: is mounted as / since there are no other files in the filesystem.\r\n2. Notice how I switch to C: before attempting to mount the CD-ROM drive. If the order is reversed (as in the original), em-dosbox will not be able to find the ISO file.\r\n3. GOG has the mount command stated incorrectly. It works anyway (defaults? auto-detecion?), but I fixed the command anyway to set type to \"cdrom\".\r\n\r\nI'd be happy to answer any and all questions!"}}