{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/lhm/issues/8","labels_url":"https://api.github.com/repos/Shopify/lhm/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/lhm/issues/8/comments","events_url":"https://api.github.com/repos/Shopify/lhm/issues/8/events","html_url":"https://github.com/Shopify/lhm/pull/8","id":96422026,"number":8,"title":"Throttle based on lag of all slaves in replication chain","user":{"login":"jordanwheeler","id":2702398,"avatar_url":"https://avatars.githubusercontent.com/u/2702398?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanwheeler","html_url":"https://github.com/jordanwheeler","followers_url":"https://api.github.com/users/jordanwheeler/followers","following_url":"https://api.github.com/users/jordanwheeler/following{/other_user}","gists_url":"https://api.github.com/users/jordanwheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanwheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanwheeler/subscriptions","organizations_url":"https://api.github.com/users/jordanwheeler/orgs","repos_url":"https://api.github.com/users/jordanwheeler/repos","events_url":"https://api.github.com/users/jordanwheeler/events{/privacy}","received_events_url":"https://api.github.com/users/jordanwheeler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-21T21:38:24Z","updated_at":"2015-07-26T12:01:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/lhm/pulls/8","html_url":"https://github.com/Shopify/lhm/pull/8","diff_url":"https://github.com/Shopify/lhm/pull/8.diff","patch_url":"https://github.com/Shopify/lhm/pull/8.patch"},"body":"This is my slave lag throttler code as compared to soundcloud/lhm master (the `lhm-upstream` branch in this repo).  I've tested it quite a bit with Shopify.  There's some small changes we need to make there to use this (https://github.com/Shopify/shopify/pull/49019), but other than the `logger_params` change I needed to make in that PR, upstream lhm works just fine for us.\r\n\r\nAs I've mentioned, I'm not PRing this upstream because it explicitly uses the `Mysql2::Client`, whereas upstream \"is compatible and continuously tested with MRI 2.0.x, 2.1.x, ActiveRecord 3.2.x and 4.x (mysql and mysql2 adapters).\"  But we're more concerned with throttling slave lag than we are with getting this code upstream right now.\r\n\r\nSo I think the plan right now (pending review) is to merge the `lhm-upstream` branch, merge this, merge my Shopify PR (along with an updated gem ref) then start throttling some slave lag.\r\n\r\n@camilo @arthurnn @jasonhl @shuhaowu "},"comment":{"url":"https://api.github.com/repos/Shopify/lhm/issues/comments/124975800","html_url":"https://github.com/Shopify/lhm/pull/8#issuecomment-124975800","issue_url":"https://api.github.com/repos/Shopify/lhm/issues/8","id":124975800,"user":{"login":"arthurnn","id":833383,"avatar_url":"https://avatars.githubusercontent.com/u/833383?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":false},"created_at":"2015-07-26T12:01:21Z","updated_at":"2015-07-26T12:01:21Z","body":"Before I dig in, what was the main reason the first code was not working? what was the issues with it? and why we had to change it so much?"}}