{"action":"created","issue":{"url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/194","labels_url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/194/comments","events_url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/194/events","html_url":"https://github.com/qcode-software/qcode-tcl/pull/194","id":57624722,"number":194,"title":"JSON Response Extend","user":{"login":"nicky-johnstone","id":8330836,"avatar_url":"https://avatars.githubusercontent.com/u/8330836?v=3","gravatar_id":"","url":"https://api.github.com/users/nicky-johnstone","html_url":"https://github.com/nicky-johnstone","followers_url":"https://api.github.com/users/nicky-johnstone/followers","following_url":"https://api.github.com/users/nicky-johnstone/following{/other_user}","gists_url":"https://api.github.com/users/nicky-johnstone/gists{/gist_id}","starred_url":"https://api.github.com/users/nicky-johnstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicky-johnstone/subscriptions","organizations_url":"https://api.github.com/users/nicky-johnstone/orgs","repos_url":"https://api.github.com/users/nicky-johnstone/repos","events_url":"https://api.github.com/users/nicky-johnstone/events{/privacy}","received_events_url":"https://api.github.com/users/nicky-johnstone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bvw","id":486212,"avatar_url":"https://avatars.githubusercontent.com/u/486212?v=3","gravatar_id":"","url":"https://api.github.com/users/bvw","html_url":"https://github.com/bvw","followers_url":"https://api.github.com/users/bvw/followers","following_url":"https://api.github.com/users/bvw/following{/other_user}","gists_url":"https://api.github.com/users/bvw/gists{/gist_id}","starred_url":"https://api.github.com/users/bvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvw/subscriptions","organizations_url":"https://api.github.com/users/bvw/orgs","repos_url":"https://api.github.com/users/bvw/repos","events_url":"https://api.github.com/users/bvw/events{/privacy}","received_events_url":"https://api.github.com/users/bvw/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-02-13T17:02:22Z","updated_at":"2015-02-16T14:49:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qcode-software/qcode-tcl/pulls/194","html_url":"https://github.com/qcode-software/qcode-tcl/pull/194","diff_url":"https://github.com/qcode-software/qcode-tcl/pull/194.diff","patch_url":"https://github.com/qcode-software/qcode-tcl/pull/194.patch"},"body":"Extends the JSON Response to include a `status` element that indicates `valid` or `invalid`.\r\n\r\nChecklist\r\n----\r\n- [x] Does each proc have a #| comment to describe what it does ?\r\n- [x] Are there comments throughout the code ?\r\n- [x] Is each proc unit testable ?\r\n- [x] Are the proc names well chosen ?\r\n- [x] Are variable names well chosen ?\r\n- [x] List what testing has been done.\r\n  - Unit testing `qc::status valid` and `qc::status invalid`.\r\n  - Testing `qc::data2json` after setting the status and also without setting the status to test the default."},"comment":{"url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/comments/74518892","html_url":"https://github.com/qcode-software/qcode-tcl/pull/194#issuecomment-74518892","issue_url":"https://api.github.com/repos/qcode-software/qcode-tcl/issues/194","id":74518892,"user":{"login":"bvw","id":486212,"avatar_url":"https://avatars.githubusercontent.com/u/486212?v=3","gravatar_id":"","url":"https://api.github.com/users/bvw","html_url":"https://github.com/bvw","followers_url":"https://api.github.com/users/bvw/followers","following_url":"https://api.github.com/users/bvw/following{/other_user}","gists_url":"https://api.github.com/users/bvw/gists{/gist_id}","starred_url":"https://api.github.com/users/bvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvw/subscriptions","organizations_url":"https://api.github.com/users/bvw/orgs","repos_url":"https://api.github.com/users/bvw/repos","events_url":"https://api.github.com/users/bvw/events{/privacy}","received_events_url":"https://api.github.com/users/bvw/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T14:49:48Z","updated_at":"2015-02-16T14:49:48Z","body":"`qc::status` seems like quite a special name but just floating ideas.\r\nShould we consider names qualified by a namespace etc.\r\n\r\n`qc::status invalid`\r\n`qc::response::status invalid`\r\n`qc::response_status invalid`\r\n\r\n`qc::record invalid username $username \"That username is already taken\"`\r\n`qc::response::record invalid username $username \"That username is already taken\"`\r\n`qc::response_record invalid username $username \"That username is already taken\"`"}}