{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24278727","id":24278727,"diff_hunk":"@@ -48,5 +48,15 @@\n install_packages_on(master, MASTER_PACKAGES)\n install_packages_on(agents, AGENT_PACKAGES)\n \n+agents.each do |agent|\n+  if agent['platform'] =~ /windows/\n+    arch = agent[:ruby_arch] || 'x86'\n+    base_url = \"http://builds.puppetlabs.lan/puppet/#{ENV['SHA']}/artifacts/windows\"\n+    filename = \"puppet-agent-#{ENV['VERSION']}-#{arch}.msi\"","path":"acceptance/setup/packages/pre-suite/010_Install.rb","position":8,"original_position":8,"commit_id":"b372a847cbab7206b81c068c6d6b58a69deed3de","original_commit_id":"b372a847cbab7206b81c068c6d6b58a69deed3de","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"I thought about that, but this change would be in puppet/master for 4.0 where we know the MSI will have `-x86` (as opposed to being able to acceptance test earlier versions of puppet)","created_at":"2015-02-06T22:51:54Z","updated_at":"2015-02-06T22:51:54Z","html_url":"https://github.com/puppetlabs/puppet/pull/3584#discussion_r24278727","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/24278727"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3584#discussion_r24278727"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584","id":28848057,"html_url":"https://github.com/puppetlabs/puppet/pull/3584","diff_url":"https://github.com/puppetlabs/puppet/pull/3584.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3584.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3584","number":3584,"state":"open","locked":false,"title":"(QENG-1800) Install MSI during package acceptance","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"Previously it was not possible to run windows acceptance against FOSS\r\nMSI packages. This commit adds a step to install the puppet-agent MSI. It\r\ndepends on https://github.com/puppetlabs/beaker/pull/674\r\n\r\nWith this commit you can do:\r\n\r\n    $ bundle exec rake ci:test:packages \\\r\n        CONFIG=config/nodes/win2008r2-rubyx64.yaml \\\r\n        SHA=<SHA> VERSION=3.7.4-1303\r\n\r\nNote the VERSION string must match the filename of the MSI which\r\nincludes the output from `git describe`. The host definition file needs\r\nto specify which `ruby_arch` it wants to install, either x86 or x64.","created_at":"2015-02-06T22:35:08Z","updated_at":"2015-02-06T22:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e991adc4d6325b651540384a22ab0364393cab6a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3584/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/b372a847cbab7206b81c068c6d6b58a69deed3de","head":{"label":"joshcooper:ticket/master/QENG-1800-install-msi","ref":"ticket/master/QENG-1800-install-msi","sha":"b372a847cbab7206b81c068c6d6b58a69deed3de","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"repo":{"id":1632836,"name":"puppet","full_name":"joshcooper/puppet","owner":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshcooper/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/joshcooper/puppet","forks_url":"https://api.github.com/repos/joshcooper/puppet/forks","keys_url":"https://api.github.com/repos/joshcooper/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshcooper/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshcooper/puppet/teams","hooks_url":"https://api.github.com/repos/joshcooper/puppet/hooks","issue_events_url":"https://api.github.com/repos/joshcooper/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/joshcooper/puppet/events","assignees_url":"https://api.github.com/repos/joshcooper/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/joshcooper/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/joshcooper/puppet/tags","blobs_url":"https://api.github.com/repos/joshcooper/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshcooper/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshcooper/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshcooper/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshcooper/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/joshcooper/puppet/languages","stargazers_url":"https://api.github.com/repos/joshcooper/puppet/stargazers","contributors_url":"https://api.github.com/repos/joshcooper/puppet/contributors","subscribers_url":"https://api.github.com/repos/joshcooper/puppet/subscribers","subscription_url":"https://api.github.com/repos/joshcooper/puppet/subscription","commits_url":"https://api.github.com/repos/joshcooper/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshcooper/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshcooper/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshcooper/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/joshcooper/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/joshcooper/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshcooper/puppet/merges","archive_url":"https://api.github.com/repos/joshcooper/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshcooper/puppet/downloads","issues_url":"https://api.github.com/repos/joshcooper/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/joshcooper/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/joshcooper/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/joshcooper/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshcooper/puppet/labels{/name}","releases_url":"https://api.github.com/repos/joshcooper/puppet/releases{/id}","created_at":"2011-04-18T21:50:21Z","updated_at":"2015-02-05T17:46:22Z","pushed_at":"2015-02-06T22:34:10Z","git_url":"git://github.com/joshcooper/puppet.git","ssh_url":"git@github.com:joshcooper/puppet.git","clone_url":"https://github.com/joshcooper/puppet.git","svn_url":"https://github.com/joshcooper/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":50730,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"4f40695f94a41b7384509236be01ce24364b57b3","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-02-06T21:59:38Z","pushed_at":"2015-02-06T21:59:38Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":106324,"stargazers_count":2945,"watchers_count":2945,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1261,"mirror_url":null,"open_issues_count":26,"forks":1261,"open_issues":26,"watchers":2945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/3584"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3584"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/3584/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/3584/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/b372a847cbab7206b81c068c6d6b58a69deed3de"}}}}