{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/37951279","id":37951279,"diff_hunk":"@@ -173,6 +173,16 @@ public void deleteNonExistentIndexWarmerTest() {\n         }\n     }\n \n+    @Test // issue 8991\n+    public void deleteAllIndexWarmerDoesNotThrowWhenNoWarmers() {\n+        createIndex(\"test\");\n+        try {\n+            client().admin().indices().prepareDeleteWarmer().setIndices(\"test\").setNames(\"_all\").execute().actionGet();","path":"core/src/test/java/org/elasticsearch/indices/warmer/SimpleIndicesWarmerIT.java","position":8,"original_position":8,"commit_id":"8c3b7752cf07f0180ab0f283224fae0ae9d23d20","original_commit_id":"8c3b7752cf07f0180ab0f283224fae0ae9d23d20","user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"body":"you can remove the try and catch here, if the test throws exception it fails anyway. maybe just do some sanity check on the response. Also maybe randomly add some other index name so `_all` is not always the only one.","created_at":"2015-08-26T06:58:40Z","updated_at":"2015-08-26T06:58:40Z","html_url":"https://github.com/elastic/elasticsearch/pull/13058#discussion_r37951279","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/37951279"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/13058#discussion_r37951279"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058","id":43109187,"html_url":"https://github.com/elastic/elasticsearch/pull/13058","diff_url":"https://github.com/elastic/elasticsearch/pull/13058.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/13058.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13058","number":13058,"state":"open","locked":false,"title":"Warmers delete _all should not throw exception when no warmers","user":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"body":"I think this fixes #8991. It will not throw exceptions when the request is to delete \"_all\" warmers but log it.\r\n\r\n","created_at":"2015-08-22T19:54:34Z","updated_at":"2015-08-26T06:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d1fac9c082269b2ce528d9bb26243102920ae27","assignee":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/13058/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/8c3b7752cf07f0180ab0f283224fae0ae9d23d20","head":{"label":"andrestc:feature/delete-warmer-logging","ref":"feature/delete-warmer-logging","sha":"8c3b7752cf07f0180ab0f283224fae0ae9d23d20","user":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"repo":{"id":41218198,"name":"elasticsearch","full_name":"andrestc/elasticsearch","owner":{"login":"andrestc","id":2944739,"avatar_url":"https://avatars.githubusercontent.com/u/2944739?v=3","gravatar_id":"","url":"https://api.github.com/users/andrestc","html_url":"https://github.com/andrestc","followers_url":"https://api.github.com/users/andrestc/followers","following_url":"https://api.github.com/users/andrestc/following{/other_user}","gists_url":"https://api.github.com/users/andrestc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrestc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrestc/subscriptions","organizations_url":"https://api.github.com/users/andrestc/orgs","repos_url":"https://api.github.com/users/andrestc/repos","events_url":"https://api.github.com/users/andrestc/events{/privacy}","received_events_url":"https://api.github.com/users/andrestc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrestc/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/andrestc/elasticsearch","forks_url":"https://api.github.com/repos/andrestc/elasticsearch/forks","keys_url":"https://api.github.com/repos/andrestc/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrestc/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrestc/elasticsearch/teams","hooks_url":"https://api.github.com/repos/andrestc/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/andrestc/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/andrestc/elasticsearch/events","assignees_url":"https://api.github.com/repos/andrestc/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/andrestc/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/andrestc/elasticsearch/tags","blobs_url":"https://api.github.com/repos/andrestc/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrestc/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrestc/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrestc/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrestc/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/andrestc/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/andrestc/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/andrestc/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/andrestc/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/andrestc/elasticsearch/subscription","commits_url":"https://api.github.com/repos/andrestc/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrestc/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrestc/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrestc/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrestc/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/andrestc/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrestc/elasticsearch/merges","archive_url":"https://api.github.com/repos/andrestc/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrestc/elasticsearch/downloads","issues_url":"https://api.github.com/repos/andrestc/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/andrestc/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/andrestc/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/andrestc/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrestc/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/andrestc/elasticsearch/releases{/id}","created_at":"2015-08-22T17:44:58Z","updated_at":"2015-08-22T17:45:18Z","pushed_at":"2015-08-26T01:42:31Z","git_url":"git://github.com/andrestc/elasticsearch.git","ssh_url":"git@github.com:andrestc/elasticsearch.git","clone_url":"https://github.com/andrestc/elasticsearch.git","svn_url":"https://github.com/andrestc/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":154219,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"febc7f5d4c2158574d9a22c2e73e8092c5516690","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-08-26T06:21:17Z","pushed_at":"2015-08-26T06:58:04Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":409676,"stargazers_count":12481,"watchers_count":12481,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4030,"mirror_url":null,"open_issues_count":1205,"forks":4030,"open_issues":1205,"watchers":12481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/13058"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/13058"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/13058/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/13058/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/8c3b7752cf07f0180ab0f283224fae0ae9d23d20"}}}}