{"action":"created","issue":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/3154","labels_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/3154/labels{/name}","comments_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/3154/comments","events_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/3154/events","html_url":"https://github.com/WhisperSystems/TextSecure/pull/3154","id":75561420,"number":3154,"title":"Remove ACTION_OPEN_DOCUMENT from AttachmentManager","user":{"login":"unrulygnu","id":11031903,"avatar_url":"https://avatars.githubusercontent.com/u/11031903?v=3","gravatar_id":"","url":"https://api.github.com/users/unrulygnu","html_url":"https://github.com/unrulygnu","followers_url":"https://api.github.com/users/unrulygnu/followers","following_url":"https://api.github.com/users/unrulygnu/following{/other_user}","gists_url":"https://api.github.com/users/unrulygnu/gists{/gist_id}","starred_url":"https://api.github.com/users/unrulygnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unrulygnu/subscriptions","organizations_url":"https://api.github.com/users/unrulygnu/orgs","repos_url":"https://api.github.com/users/unrulygnu/repos","events_url":"https://api.github.com/users/unrulygnu/events{/privacy}","received_events_url":"https://api.github.com/users/unrulygnu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-05-12T10:56:58Z","updated_at":"2015-05-20T21:25:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/3154","html_url":"https://github.com/WhisperSystems/TextSecure/pull/3154","diff_url":"https://github.com/WhisperSystems/TextSecure/pull/3154.diff","patch_url":"https://github.com/WhisperSystems/TextSecure/pull/3154.patch"},"body":"// FREEBIE\r\n\r\nFixes #1744"},"comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/comments/104043644","html_url":"https://github.com/WhisperSystems/TextSecure/pull/3154#issuecomment-104043644","issue_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/3154","id":104043644,"user":{"login":"rhodey","id":3441581,"avatar_url":"https://avatars.githubusercontent.com/u/3441581?v=3","gravatar_id":"","url":"https://api.github.com/users/rhodey","html_url":"https://github.com/rhodey","followers_url":"https://api.github.com/users/rhodey/followers","following_url":"https://api.github.com/users/rhodey/following{/other_user}","gists_url":"https://api.github.com/users/rhodey/gists{/gist_id}","starred_url":"https://api.github.com/users/rhodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhodey/subscriptions","organizations_url":"https://api.github.com/users/rhodey/orgs","repos_url":"https://api.github.com/users/rhodey/repos","events_url":"https://api.github.com/users/rhodey/events{/privacy}","received_events_url":"https://api.github.com/users/rhodey/received_events","type":"User","site_admin":false},"created_at":"2015-05-20T21:25:08Z","updated_at":"2015-05-20T21:25:08Z","body":"so I'm seeing all these old crash reports that are seemingly related to KitKat and use of `ACTION_GET_CONTENT`, for example #926, #1628, #1556, and #1544 but none of the steps to reproduce in any of those issues result in a crash or unexpected behavior when tested on this PR.\r\n\r\nlooking back it appears that the use of `ACTION_OPEN_DOCUMENT` did stop the crashes from happening but it is also clear that for our use case `ACTION_GET_CONTENT` is actually what we want (RE: all the issues reported in #1744).\r\n\r\nSo, I think that `ACTION_GET_CONTENT` is definitely the correct action to use across all API levels *but maybe* we should add some permission magic to this URI conditionally for API levels above KitKat? I don't know and we can't understand any of this until we can crash a device using `ACTION_GET_CONTENT` again :'(\r\n\r\nmaybe `AttachmentManager` has changed a lot since then? maybe glide fixed this? @unrulygnu sorry for all the hold ups but it is difficult to merge this until we understand why `ACTION_GET_CONTENT` used to cause so many crashes on Kitkat and now does not."}}