{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/mysql/pulls/comments/37994681","id":37994681,"diff_hunk":"@@ -6,6 +6,7 @@ source ${HOME}/common.sh\n set -eu\n \n export MYSQL_RUNNING_AS_SLAVE=1\n+export MYSQL_MASTER_ADDR=${MYSQL_MASTER_ADDR:-mysql-master}","path":"5.5/run-mysqld-slave.sh","position":4,"original_position":4,"commit_id":"6ca74416cbfebd61155652d442364569ce832aa2","original_commit_id":"6ca74416cbfebd61155652d442364569ce832aa2","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"@bparees I think it is searching the current namespace for the \"mysql-master\" service. The variable is not provided, it is there so you can override it when you do bash testing with docker (where you don't have the headless service available)","created_at":"2015-08-26T15:18:26Z","updated_at":"2015-08-26T15:18:26Z","html_url":"https://github.com/openshift/mysql/pull/86#discussion_r37994681","pull_request_url":"https://api.github.com/repos/openshift/mysql/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments/37994681"},"html":{"href":"https://github.com/openshift/mysql/pull/86#discussion_r37994681"},"pull_request":{"href":"https://api.github.com/repos/openshift/mysql/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/mysql/pulls/86","id":43376956,"html_url":"https://github.com/openshift/mysql/pull/86","diff_url":"https://github.com/openshift/mysql/pull/86.diff","patch_url":"https://github.com/openshift/mysql/pull/86.patch","issue_url":"https://api.github.com/repos/openshift/mysql/issues/86","number":86,"state":"open","locked":false,"title":"Don't look up master address in DNS, use hostname directly","user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"body":"@bparees","created_at":"2015-08-26T08:37:50Z","updated_at":"2015-08-26T15:18:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f42b534bd452975f150ce597a9433d65e3d7aa7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/mysql/pulls/86/commits","review_comments_url":"https://api.github.com/repos/openshift/mysql/pulls/86/comments","review_comment_url":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/mysql/issues/86/comments","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/6ca74416cbfebd61155652d442364569ce832aa2","head":{"label":"mnagy:dont_lookup_master_address","ref":"dont_lookup_master_address","sha":"6ca74416cbfebd61155652d442364569ce832aa2","user":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"repo":{"id":31023512,"name":"mysql","full_name":"mnagy/mysql","owner":{"login":"mnagy","id":72469,"avatar_url":"https://avatars.githubusercontent.com/u/72469?v=3","gravatar_id":"","url":"https://api.github.com/users/mnagy","html_url":"https://github.com/mnagy","followers_url":"https://api.github.com/users/mnagy/followers","following_url":"https://api.github.com/users/mnagy/following{/other_user}","gists_url":"https://api.github.com/users/mnagy/gists{/gist_id}","starred_url":"https://api.github.com/users/mnagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnagy/subscriptions","organizations_url":"https://api.github.com/users/mnagy/orgs","repos_url":"https://api.github.com/users/mnagy/repos","events_url":"https://api.github.com/users/mnagy/events{/privacy}","received_events_url":"https://api.github.com/users/mnagy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnagy/mysql","description":"","fork":true,"url":"https://api.github.com/repos/mnagy/mysql","forks_url":"https://api.github.com/repos/mnagy/mysql/forks","keys_url":"https://api.github.com/repos/mnagy/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnagy/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnagy/mysql/teams","hooks_url":"https://api.github.com/repos/mnagy/mysql/hooks","issue_events_url":"https://api.github.com/repos/mnagy/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/mnagy/mysql/events","assignees_url":"https://api.github.com/repos/mnagy/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/mnagy/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/mnagy/mysql/tags","blobs_url":"https://api.github.com/repos/mnagy/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnagy/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnagy/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnagy/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnagy/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/mnagy/mysql/languages","stargazers_url":"https://api.github.com/repos/mnagy/mysql/stargazers","contributors_url":"https://api.github.com/repos/mnagy/mysql/contributors","subscribers_url":"https://api.github.com/repos/mnagy/mysql/subscribers","subscription_url":"https://api.github.com/repos/mnagy/mysql/subscription","commits_url":"https://api.github.com/repos/mnagy/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnagy/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnagy/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnagy/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnagy/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/mnagy/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnagy/mysql/merges","archive_url":"https://api.github.com/repos/mnagy/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnagy/mysql/downloads","issues_url":"https://api.github.com/repos/mnagy/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/mnagy/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/mnagy/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/mnagy/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnagy/mysql/labels{/name}","releases_url":"https://api.github.com/repos/mnagy/mysql/releases{/id}","created_at":"2015-02-19T16:07:22Z","updated_at":"2015-03-09T14:13:35Z","pushed_at":"2015-08-26T08:37:40Z","git_url":"git://github.com/mnagy/mysql.git","ssh_url":"git@github.com:mnagy/mysql.git","clone_url":"https://github.com/mnagy/mysql.git","svn_url":"https://github.com/mnagy/mysql","homepage":null,"size":416,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"081fa5456df235e04aca91716c91c243ca61dba9","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":31020442,"name":"mysql","full_name":"openshift/mysql","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/mysql","description":"","fork":false,"url":"https://api.github.com/repos/openshift/mysql","forks_url":"https://api.github.com/repos/openshift/mysql/forks","keys_url":"https://api.github.com/repos/openshift/mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/mysql/teams","hooks_url":"https://api.github.com/repos/openshift/mysql/hooks","issue_events_url":"https://api.github.com/repos/openshift/mysql/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/mysql/events","assignees_url":"https://api.github.com/repos/openshift/mysql/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/mysql/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/mysql/tags","blobs_url":"https://api.github.com/repos/openshift/mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/mysql/languages","stargazers_url":"https://api.github.com/repos/openshift/mysql/stargazers","contributors_url":"https://api.github.com/repos/openshift/mysql/contributors","subscribers_url":"https://api.github.com/repos/openshift/mysql/subscribers","subscription_url":"https://api.github.com/repos/openshift/mysql/subscription","commits_url":"https://api.github.com/repos/openshift/mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/mysql/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/mysql/merges","archive_url":"https://api.github.com/repos/openshift/mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/mysql/downloads","issues_url":"https://api.github.com/repos/openshift/mysql/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/mysql/labels{/name}","releases_url":"https://api.github.com/repos/openshift/mysql/releases{/id}","created_at":"2015-02-19T15:03:58Z","updated_at":"2015-08-18T13:55:49Z","pushed_at":"2015-08-26T14:33:14Z","git_url":"git://github.com/openshift/mysql.git","ssh_url":"git@github.com:openshift/mysql.git","clone_url":"https://github.com/openshift/mysql.git","svn_url":"https://github.com/openshift/mysql","homepage":null,"size":682,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":9,"forks":19,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/mysql/pulls/86"},"html":{"href":"https://github.com/openshift/mysql/pull/86"},"issue":{"href":"https://api.github.com/repos/openshift/mysql/issues/86"},"comments":{"href":"https://api.github.com/repos/openshift/mysql/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/mysql/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/mysql/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/mysql/statuses/6ca74416cbfebd61155652d442364569ce832aa2"}}}}