{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/22569848","id":22569848,"diff_hunk":"@@ -1,230 +1,129 @@\n+/*\n+    Account settings page.\n+    Contains a lot of rules on what to show or hide if logged in or out.\n+*/\n @import 'lib';\n \n-// Don't show logout links to native FxA users (bug 1073177).\n-.native-fxa {\n-    .logout,\n-    .logout.button.only-logged-in {\n+.native-fxa .account-settings .logout {\n+    // Don't show logout links to native FxA users (bug 1073177).\n+    display: none;\n+}\n+\n+.account-settings section.full > div {\n+    padding-top: 30px;\n+}\n+\n+.account-settings {\n+    .hide-logged-out {\n         display: none;\n     }\n-\n-    .account-settings .reviewer-tools {\n-        margin-top: 0;\n+}\n+.logged-in .account-settings {\n+    .hide-logged-out {\n+        display: block;\n+    }\n+    .hide-logged-in {\n+        display: none;\n     }\n }\n \n .account-settings {\n-    background: #fff;\n+    color: $greyscale-black;\n+    background: $tile-border;\n     width: 100%;\n \n-    .button {\n-        width: 100%;\n-    }\n-    footer {\n-        font-size: 0;\n-    }\n-    p {\n-        width: 50%;\n+    .account-field {\n+        padding: 15px;\n+\n+        > label {\n+            color: $greyscale-dark-grey;\n+            font-weight: 400;\n+            margin-bottom: 15px;\n+        }\n     }\n     h3 {\n-        background: $salt-flat-white;\n         clear: both;\n-        margin: 10px 0 0;\n-        padding: 10px;\n+        padding: 0 10px 10px;\n         text-transform: uppercase;\n     }\n-    input[type=email],\n-    input[type=text] {\n-        height: 48px;\n-        width: 100%;\n-    }\n     input[type=checkbox] {\n         margin-right: 5px;\n     }\n-    .pretty-select,\n-    .pretty-select select {\n-        cursor: pointer;\n-    }\n-    .pretty-select {\n-        gradient-two-color(#fff, $seavan-salt-white);\n-        padding: 0;\n-        overflow: hidden;\n-        position: relative;\n-\n-        &:before {\n-            dropdown();\n-            z-index: 2;\n-        }\n-        &:after {\n-            // Hide the native `<select>` arrow so we can overlay our\n-            // dropdown arrow in `:before`.\n-            border-left: 1px solid $cement-gray;\n-            box-shadow: 0 1px 0 #fff, 0 1px 1px $seavan-salt-white inset;\n-            content: \"\";\n-            display: block;\n-            gradient-two-color(#fff, $seavan-salt-white);\n-            height: 100%;\n-            pointer-events: none;\n-            position: absolute;\n-            right: 0;\n-            top: 0;\n-            width: 45px;\n-            z-index: 1;\n-        }\n-        &:hover, &:active {\n-            &:before {\n-                background-image: url(../img/pretty/dropdown_active.svg);\n-            }\n-        }\n-        select {\n-            -moz-padding-start: 10px;\n-            appearance-none();\n-            background: none;\n-            border: 0;\n-            padding: 10px 12px;\n-        }\n+    .display-name {\n+        width: 100%;\n     }\n-    .simple-field {\n-        padding: 10px 10px 0;\n+    [name=\"display_name\"] {\n+        height: 36px;\n+        width: 100%;\n     }\n-    .form-label,\n-    .form-label label {\n-        font-weight: 500;\n+    .recommendations label:last-child {\n+        color: $greyscale-black;\n+        display: inline;\n+        line-height: 18px;\n     }\n-    .form-col {\n-        color: $london-fog-gray;\n-        margin-top: 10px;\n-    }\n-    // Overrides region class to make things match and line up properly.\n     .region {\n-        color: $london-fog-gray;\n+        display: block;\n         margin-top: -2px;\n+\n+        span {\n+            color: $greyscale-black;\n+        }\n     }\n-    footer {\n-        border-top: 1px solid $cloud-gray;\n-        clear: both;\n-        margin-top: 10px;\n-    }\n-    p {\n-        padding: 10px;\n+    .newsletter-info p {\n+        line-height: 18px;\n+        padding: 0 0 10px;\n+        width: 100%;\n     }\n     .only-logged-in.extras {\n         display: none;\n     }\n-    .extras {\n-        display: inline-block;\n-        vertical-align: top;\n-\n-        &:last-child {\n-            padding-bottom: 10px;\n-        }\n-\n-        .button {\n-            font-weight: 300;\n-        }\n-    }\n-}\n-\n-.newsletter-info p {\n-    padding: 0 0 10px;\n-    width: 100%;\n }\n \n-.logged-in .account-settings .only-logged-out.extras {\n-    display: none;\n-}\n-.logged-in .account-settings .only-logged-in.extras {\n-    display: inline-block;\n-}\n+.account-settings-save,\n+.account-settings-links div {\n+    align-items: center;\n+    display: flex;\n+    flex-wrap: wrap;\n+    justify-content: center;\n \n-article.extras {\n-    .notice {\n-        background: #fff;\n-        border-bottom: 1px solid $cloud-gray;\n-        padding: 15px 10px;\n-    }\n     .button {\n-        display: block;\n-        margin: 10px;\n-    }\n-}\n-\n-.account-settings {\n-    footer {\n-        background: $seavan-salt-white;\n-    }\n-    p {\n+        margin-top: 10px;\n         width: 100%;\n     }\n-    .save-changes {\n-        background: #fff;\n-        border-bottom: 1px solid $cloud-gray;\n-    }\n-    .extras {\n-        padding-bottom: 0;\n-    }\n }\n \n-.toggles {\n-    display: table;\n-    table-layout: fixed;\n-    width: 100%;\n+.account-settings-save {","path":"src/media/css/account.styl","position":229,"original_position":229,"commit_id":"a2e72723d787e711595020f2083fc293fe6f642f","original_commit_id":"a2e72723d787e711595020f2083fc293fe6f642f","user":{"login":"spasovski","id":391260,"avatar_url":"https://avatars.githubusercontent.com/u/391260?v=3","gravatar_id":"","url":"https://api.github.com/users/spasovski","html_url":"https://github.com/spasovski","followers_url":"https://api.github.com/users/spasovski/followers","following_url":"https://api.github.com/users/spasovski/following{/other_user}","gists_url":"https://api.github.com/users/spasovski/gists{/gist_id}","starred_url":"https://api.github.com/users/spasovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spasovski/subscriptions","organizations_url":"https://api.github.com/users/spasovski/orgs","repos_url":"https://api.github.com/users/spasovski/repos","events_url":"https://api.github.com/users/spasovski/events{/privacy}","received_events_url":"https://api.github.com/users/spasovski/received_events","type":"User","site_admin":false},"body":"Verbose name but it should help with on-boarding contributors.","created_at":"2015-01-07T03:48:44Z","updated_at":"2015-01-07T03:48:44Z","html_url":"https://github.com/mozilla/fireplace/pull/874#discussion_r22569848","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/874","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/22569848"},"html":{"href":"https://github.com/mozilla/fireplace/pull/874#discussion_r22569848"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/874"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/874","id":26610104,"html_url":"https://github.com/mozilla/fireplace/pull/874","diff_url":"https://github.com/mozilla/fireplace/pull/874.diff","patch_url":"https://github.com/mozilla/fireplace/pull/874.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/874","number":874,"state":"open","locked":false,"title":"refresh account settings page (bug 1103228)","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"- moves settings/main.html to settings.html to match route, with all other PRs the settings template folder will be removed\r\n- gets rid of a ton of old settings page CSS, cruft markup, and unneeded classes\r\n\r\n# Desktop Logged In\r\n\r\n![screen shot 2014-12-29 at 1 43 49 pm](https://cloud.githubusercontent.com/assets/674727/5573445/4e7d2312-8f61-11e4-8074-24c4fdcf2133.png)\r\n\r\n# Tablet Logged In \r\n\r\n![screen shot 2014-12-29 at 1 43 59 pm](https://cloud.githubusercontent.com/assets/674727/5573435/35681f62-8f61-11e4-8ea8-f6fae4c6c941.png)\r\n\r\n\r\n# Mobile Logged In\r\n\r\n![screen shot 2014-12-29 at 1 44 19 pm](https://cloud.githubusercontent.com/assets/674727/5573420/03e05d38-8f61-11e4-9b94-fb23f58b1f6f.png)\r\n\r\n# Desktop Logged Out\r\n\r\n![screen shot 2014-12-29 at 1 44 28 pm](https://cloud.githubusercontent.com/assets/674727/5573446/55011fe0-8f61-11e4-84f9-a5807fe756b1.png)\r\n\r\n\r\n# Tablet Logged Out\r\n\r\n![screen shot 2014-12-29 at 1 44 36 pm](https://cloud.githubusercontent.com/assets/674727/5573429/2a592508-8f61-11e4-9a5a-6ce89fc83aac.png)\r\n\r\n# Mobile Logged Out\r\n\r\n![screen shot 2014-12-29 at 1 44 49 pm](https://cloud.githubusercontent.com/assets/674727/5573441/3e90474a-8f61-11e4-8866-ca41e29efb75.png)\r\n\r\n","created_at":"2014-12-27T02:00:50Z","updated_at":"2015-01-07T03:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"591aebab6c3d51d2a1b70c75375de3fcbff90f58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/874/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/874/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/874/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/a2e72723d787e711595020f2083fc293fe6f642f","head":{"label":"ngokevin:feed-account","ref":"feed-account","sha":"a2e72723d787e711595020f2083fc293fe6f642f","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"repo":{"id":11646521,"name":"fireplace","full_name":"ngokevin/fireplace","owner":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngokevin/fireplace","description":"Frontend for the Firefox Marketplace","fork":true,"url":"https://api.github.com/repos/ngokevin/fireplace","forks_url":"https://api.github.com/repos/ngokevin/fireplace/forks","keys_url":"https://api.github.com/repos/ngokevin/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngokevin/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngokevin/fireplace/teams","hooks_url":"https://api.github.com/repos/ngokevin/fireplace/hooks","issue_events_url":"https://api.github.com/repos/ngokevin/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/ngokevin/fireplace/events","assignees_url":"https://api.github.com/repos/ngokevin/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/ngokevin/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/ngokevin/fireplace/tags","blobs_url":"https://api.github.com/repos/ngokevin/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngokevin/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngokevin/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngokevin/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngokevin/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/ngokevin/fireplace/languages","stargazers_url":"https://api.github.com/repos/ngokevin/fireplace/stargazers","contributors_url":"https://api.github.com/repos/ngokevin/fireplace/contributors","subscribers_url":"https://api.github.com/repos/ngokevin/fireplace/subscribers","subscription_url":"https://api.github.com/repos/ngokevin/fireplace/subscription","commits_url":"https://api.github.com/repos/ngokevin/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngokevin/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngokevin/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngokevin/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/ngokevin/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/ngokevin/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngokevin/fireplace/merges","archive_url":"https://api.github.com/repos/ngokevin/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngokevin/fireplace/downloads","issues_url":"https://api.github.com/repos/ngokevin/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/ngokevin/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/ngokevin/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/ngokevin/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngokevin/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/ngokevin/fireplace/releases{/id}","created_at":"2013-07-24T22:13:26Z","updated_at":"2014-12-12T20:33:32Z","pushed_at":"2015-01-06T19:45:09Z","git_url":"git://github.com/ngokevin/fireplace.git","ssh_url":"git@github.com:ngokevin/fireplace.git","clone_url":"https://github.com/ngokevin/fireplace.git","svn_url":"https://github.com/ngokevin/fireplace","homepage":"https://marketplace.firefox.com/","size":22458,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:feed","ref":"feed","sha":"ac16cd6835805419c1f5baf352aedab324c96ad7","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2015-01-06T19:33:31Z","pushed_at":"2015-01-06T19:46:46Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":80105,"stargazers_count":47,"watchers_count":47,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":10,"forks":92,"open_issues":10,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/874"},"html":{"href":"https://github.com/mozilla/fireplace/pull/874"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/874"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/a2e72723d787e711595020f2083fc293fe6f642f"}}}}