{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/30093552","id":30093552,"diff_hunk":"@@ -3,13 +3,21 @@ module PasswordStrategies\n     module SHA1\n       require 'digest/sha1'\n \n+      DEPRECATION_MESSAGE = \"[DEPRECATION] The SHA1 password strategy \" \\\n+        \"has been deprecated and will be removed from Clearance 2.0. BCrypt \" \\\n+        \"is the only officially supported strategy, though you are free to \" \\\n+        \"provide your own. To continue using this strategy add \" \\\n+        \"clearance-deprecated_password_strategies to your Gemfile.\"","path":"lib/clearance/password_strategies/sha1.rb","position":8,"original_position":8,"commit_id":"469e11db475ba8bec1f5fee3de1ffa811f59914f","original_commit_id":"469e11db475ba8bec1f5fee3de1ffa811f59914f","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?v=3","gravatar_id":"","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"body":"Would you recommend bucking the convention here?\n\nOn Mon, May 11, 2015 at 5:12 PM, Joe Ferris <notifications@github.com>\nwrote:\n\n> In lib/clearance/password_strategies/sha1.rb\n> <https://github.com/thoughtbot/clearance/pull/558#discussion_r30082672>:\n>\n> > @@ -3,13 +3,21 @@ module PasswordStrategies\n> >      module SHA1\n> >        require 'digest/sha1'\n> >\n> > +      DEPRECATION_MESSAGE = \"[DEPRECATION] The SHA1 password strategy \" \\\n> > +        \"has been deprecated and will be removed from Clearance 2.0. BCrypt \" \\\n> > +        \"is the only officially supported strategy, though you are free to \" \\\n> > +        \"provide your own. To continue using this strategy add \" \\\n> > +        \"clearance-deprecated_password_strategies to your Gemfile.\"\n>\n> FYI, it was originally factory_girl-rails but enough people complained\n> that I renamed it.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/thoughtbot/clearance/pull/558/files#r30082672>.\n>\n","created_at":"2015-05-11T23:45:48Z","updated_at":"2015-05-11T23:45:48Z","html_url":"https://github.com/thoughtbot/clearance/pull/558#discussion_r30093552","pull_request_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/558","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/30093552"},"html":{"href":"https://github.com/thoughtbot/clearance/pull/558#discussion_r30093552"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/558","id":35046847,"html_url":"https://github.com/thoughtbot/clearance/pull/558","diff_url":"https://github.com/thoughtbot/clearance/pull/558.diff","patch_url":"https://github.com/thoughtbot/clearance/pull/558.patch","issue_url":"https://api.github.com/repos/thoughtbot/clearance/issues/558","number":558,"state":"open","locked":false,"title":"Deprecate unused password strategies","user":{"login":"derekprior","id":152152,"avatar_url":"https://avatars.githubusercontent.com/u/152152?v=3","gravatar_id":"","url":"https://api.github.com/users/derekprior","html_url":"https://github.com/derekprior","followers_url":"https://api.github.com/users/derekprior/followers","following_url":"https://api.github.com/users/derekprior/following{/other_user}","gists_url":"https://api.github.com/users/derekprior/gists{/gist_id}","starred_url":"https://api.github.com/users/derekprior/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekprior/subscriptions","organizations_url":"https://api.github.com/users/derekprior/orgs","repos_url":"https://api.github.com/users/derekprior/repos","events_url":"https://api.github.com/users/derekprior/events{/privacy}","received_events_url":"https://api.github.com/users/derekprior/received_events","type":"User","site_admin":false},"body":"We don't use `SHA1` or `Blowfish` password strategies. I have no plans\nto maintain them moving forward and as an opinionated library Clearance\nshould be pushing users to `BCrypt`. With `SHA1` being deprecated we\nalso need to deprecated the `BCryptMigrationFromSHA1` strategy.\n\nThese strategies can still be used, deprecation free, by adding the\n`clearance-deprecated_password_strategies` gem. We do not intend to\nmaintain these, but also have no plans to break the interface. Should\nmaintainers want to keep a particular strategy alive and maintained,\nthey should extract it.","created_at":"2015-05-08T21:06:44Z","updated_at":"2015-05-11T23:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e9f45dce06986211ff446c6aed5147a19321463","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/558/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/558/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/issues/558/comments","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/469e11db475ba8bec1f5fee3de1ffa811f59914f","head":{"label":"thoughtbot:dp-deprecate-blowfish","ref":"dp-deprecate-blowfish","sha":"469e11db475ba8bec1f5fee3de1ffa811f59914f","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":56125,"name":"clearance","full_name":"thoughtbot/clearance","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/clearance","description":"Rails authentication with email & password.","fork":false,"url":"https://api.github.com/repos/thoughtbot/clearance","forks_url":"https://api.github.com/repos/thoughtbot/clearance/forks","keys_url":"https://api.github.com/repos/thoughtbot/clearance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/clearance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/clearance/teams","hooks_url":"https://api.github.com/repos/thoughtbot/clearance/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/clearance/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/clearance/events","assignees_url":"https://api.github.com/repos/thoughtbot/clearance/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/clearance/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/clearance/tags","blobs_url":"https://api.github.com/repos/thoughtbot/clearance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/clearance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/clearance/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/clearance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/clearance/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/clearance/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/clearance/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/clearance/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/clearance/subscription","commits_url":"https://api.github.com/repos/thoughtbot/clearance/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/clearance/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/clearance/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/clearance/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/clearance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/clearance/merges","archive_url":"https://api.github.com/repos/thoughtbot/clearance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/clearance/downloads","issues_url":"https://api.github.com/repos/thoughtbot/clearance/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/clearance/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/clearance/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/clearance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/clearance/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/clearance/releases{/id}","created_at":"2008-09-24T19:57:58Z","updated_at":"2015-05-08T14:54:25Z","pushed_at":"2015-05-08T21:09:44Z","git_url":"git://github.com/thoughtbot/clearance.git","ssh_url":"git@github.com:thoughtbot/clearance.git","clone_url":"https://github.com/thoughtbot/clearance.git","svn_url":"https://github.com/thoughtbot/clearance","homepage":"https://robots.thoughtbot.com","size":10517,"stargazers_count":1850,"watchers_count":1850,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":9,"forks":242,"open_issues":9,"watchers":1850,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"64777707c3522ba3ca50a5514d023374f71f76df","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":56125,"name":"clearance","full_name":"thoughtbot/clearance","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/clearance","description":"Rails authentication with email & password.","fork":false,"url":"https://api.github.com/repos/thoughtbot/clearance","forks_url":"https://api.github.com/repos/thoughtbot/clearance/forks","keys_url":"https://api.github.com/repos/thoughtbot/clearance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/clearance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/clearance/teams","hooks_url":"https://api.github.com/repos/thoughtbot/clearance/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/clearance/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/clearance/events","assignees_url":"https://api.github.com/repos/thoughtbot/clearance/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/clearance/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/clearance/tags","blobs_url":"https://api.github.com/repos/thoughtbot/clearance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/clearance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/clearance/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/clearance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/clearance/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/clearance/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/clearance/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/clearance/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/clearance/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/clearance/subscription","commits_url":"https://api.github.com/repos/thoughtbot/clearance/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/clearance/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/clearance/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/clearance/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/clearance/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/clearance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/clearance/merges","archive_url":"https://api.github.com/repos/thoughtbot/clearance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/clearance/downloads","issues_url":"https://api.github.com/repos/thoughtbot/clearance/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/clearance/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/clearance/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/clearance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/clearance/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/clearance/releases{/id}","created_at":"2008-09-24T19:57:58Z","updated_at":"2015-05-08T14:54:25Z","pushed_at":"2015-05-08T21:09:44Z","git_url":"git://github.com/thoughtbot/clearance.git","ssh_url":"git@github.com:thoughtbot/clearance.git","clone_url":"https://github.com/thoughtbot/clearance.git","svn_url":"https://github.com/thoughtbot/clearance","homepage":"https://robots.thoughtbot.com","size":10517,"stargazers_count":1850,"watchers_count":1850,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":242,"mirror_url":null,"open_issues_count":9,"forks":242,"open_issues":9,"watchers":1850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/558"},"html":{"href":"https://github.com/thoughtbot/clearance/pull/558"},"issue":{"href":"https://api.github.com/repos/thoughtbot/clearance/issues/558"},"comments":{"href":"https://api.github.com/repos/thoughtbot/clearance/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/clearance/statuses/469e11db475ba8bec1f5fee3de1ffa811f59914f"}}}}