{"action":"created","issue":{"url":"https://api.github.com/repos/DOAJ/doaj/issues/855","labels_url":"https://api.github.com/repos/DOAJ/doaj/issues/855/labels{/name}","comments_url":"https://api.github.com/repos/DOAJ/doaj/issues/855/comments","events_url":"https://api.github.com/repos/DOAJ/doaj/issues/855/events","html_url":"https://github.com/DOAJ/doaj/pull/855","id":105591789,"number":855,"title":"[hotfix] Fix invisible close button on filters","user":{"login":"emanuil-tolev","id":1190172,"avatar_url":"https://avatars.githubusercontent.com/u/1190172?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuil-tolev","html_url":"https://github.com/emanuil-tolev","followers_url":"https://api.github.com/users/emanuil-tolev/followers","following_url":"https://api.github.com/users/emanuil-tolev/following{/other_user}","gists_url":"https://api.github.com/users/emanuil-tolev/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuil-tolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuil-tolev/subscriptions","organizations_url":"https://api.github.com/users/emanuil-tolev/orgs","repos_url":"https://api.github.com/users/emanuil-tolev/repos","events_url":"https://api.github.com/users/emanuil-tolev/events{/privacy}","received_events_url":"https://api.github.com/users/emanuil-tolev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DOAJ/doaj/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-09T13:01:12Z","updated_at":"2015-09-09T15:31:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DOAJ/doaj/pulls/855","html_url":"https://github.com/DOAJ/doaj/pull/855","diff_url":"https://github.com/DOAJ/doaj/pull/855.diff","patch_url":"https://github.com/DOAJ/doaj/pull/855.patch"},"body":"# HOTFIX, DO NOT MERGE HERE\r\n\r\nFor #854 \r\n\r\nThere are many ways I could've done this including just removing .icon-white and .icon-remove with Javascript on page load, and then replacing with .fa .fa-remove . But that feels hackier, I think the HTML should contain the intent (otherwise as a dev I will one day wonder why the hell are my bootstrap icons coloured when that's impossible and I don't seem to be using FontAwesome ones - the override is too easy to miss).\r\n\r\nI wanted to do it the right way which to me seems to be to use the callback functionality and just render custom filters, identical in every way except the remove icon."},"comment":{"url":"https://api.github.com/repos/DOAJ/doaj/issues/comments/138948113","html_url":"https://github.com/DOAJ/doaj/pull/855#issuecomment-138948113","issue_url":"https://api.github.com/repos/DOAJ/doaj/issues/855","id":138948113,"user":{"login":"Steven-Eardley","id":1446355,"avatar_url":"https://avatars.githubusercontent.com/u/1446355?v=3","gravatar_id":"","url":"https://api.github.com/users/Steven-Eardley","html_url":"https://github.com/Steven-Eardley","followers_url":"https://api.github.com/users/Steven-Eardley/followers","following_url":"https://api.github.com/users/Steven-Eardley/following{/other_user}","gists_url":"https://api.github.com/users/Steven-Eardley/gists{/gist_id}","starred_url":"https://api.github.com/users/Steven-Eardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steven-Eardley/subscriptions","organizations_url":"https://api.github.com/users/Steven-Eardley/orgs","repos_url":"https://api.github.com/users/Steven-Eardley/repos","events_url":"https://api.github.com/users/Steven-Eardley/events{/privacy}","received_events_url":"https://api.github.com/users/Steven-Eardley/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T15:31:17Z","updated_at":"2015-09-09T15:31:17Z","body":":+1: I like this solution - you've fixed the problem with CSS without bodging the CSS."}}