{"action":"created","comment":{"url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/comments/31762987","id":31762987,"diff_hunk":"@@ -468,7 +594,66 @@ public void handleShutdownSignal(String consumerTag, ShutdownSignalException sig\n                     logDebug(consumerTag + \" :SHUTDOWN: \" + sig.getMessage());\r\n                 }\r\n             };\r\n-    }\r\n+        }\r\n+\r\n+        if  (data.isConsumer) {\r\n+\r\n+            if ( ! Const.isEmpty(data.ackStepName) || ! Const.isEmpty(data.rejectStepName) )            {\r\n+                // we start active confirmation , need not to Ack messages in batches\r\n+                data.activeConfirmation = true;\r\n+            }\r\n+\r\n+            //bind to step with acknowledge rows on input stream\r\n+            if ( ! Const.isEmpty(data.ackStepName) ) {\r","path":"src/main/java/com/instaclick/pentaho/plugin/amqp/AMQPPlugin.java","position":287,"original_position":287,"commit_id":"934db658d5270190057b911de105d59385ae6fe0","original_commit_id":"934db658d5270190057b911de105d59385ae6fe0","user":{"login":"FabioBatSilva","id":588172,"avatar_url":"https://avatars.githubusercontent.com/u/588172?v=3","gravatar_id":"","url":"https://api.github.com/users/FabioBatSilva","html_url":"https://github.com/FabioBatSilva","followers_url":"https://api.github.com/users/FabioBatSilva/followers","following_url":"https://api.github.com/users/FabioBatSilva/following{/other_user}","gists_url":"https://api.github.com/users/FabioBatSilva/gists{/gist_id}","starred_url":"https://api.github.com/users/FabioBatSilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabioBatSilva/subscriptions","organizations_url":"https://api.github.com/users/FabioBatSilva/orgs","repos_url":"https://api.github.com/users/FabioBatSilva/repos","events_url":"https://api.github.com/users/FabioBatSilva/events{/privacy}","received_events_url":"https://api.github.com/users/FabioBatSilva/received_events","type":"User","site_admin":false},"body":"Formatting is still messed up here","created_at":"2015-06-04T20:41:05Z","updated_at":"2015-06-04T20:41:05Z","html_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17#discussion_r31762987","pull_request_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/comments/31762987"},"html":{"href":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17#discussion_r31762987"},"pull_request":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17","id":36729121,"html_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17","diff_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17.diff","patch_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17.patch","issue_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/17","number":17,"state":"open","locked":false,"title":"2.2.1, implement issue 16","user":{"login":"dshvedchenko","id":1282496,"avatar_url":"https://avatars.githubusercontent.com/u/1282496?v=3","gravatar_id":"","url":"https://api.github.com/users/dshvedchenko","html_url":"https://github.com/dshvedchenko","followers_url":"https://api.github.com/users/dshvedchenko/followers","following_url":"https://api.github.com/users/dshvedchenko/following{/other_user}","gists_url":"https://api.github.com/users/dshvedchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dshvedchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshvedchenko/subscriptions","organizations_url":"https://api.github.com/users/dshvedchenko/orgs","repos_url":"https://api.github.com/users/dshvedchenko/repos","events_url":"https://api.github.com/users/dshvedchenko/events{/privacy}","received_events_url":"https://api.github.com/users/dshvedchenko/received_events","type":"User","site_admin":false},"body":"Please, review proposed changes. uses cases covered\r\n1. confirmed messages ACK and REJECTED immidiatley if no transaction enabled\r\n2. if transaction enabled ACK and REJECTED messages form two list of tags. tags ack and Nack at the end\r\n3. if consumer finished before  confirming steps received all data, it will wait for all of them before finish its' work","created_at":"2015-06-02T13:39:56Z","updated_at":"2015-06-04T20:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cec12564f2ddd5a7c6554380ecc17c40d1a409f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17/commits","review_comments_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17/comments","review_comment_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/17/comments","statuses_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/statuses/934db658d5270190057b911de105d59385ae6fe0","head":{"label":"dshvedchenko:2.2.1","ref":"2.2.1","sha":"934db658d5270190057b911de105d59385ae6fe0","user":{"login":"dshvedchenko","id":1282496,"avatar_url":"https://avatars.githubusercontent.com/u/1282496?v=3","gravatar_id":"","url":"https://api.github.com/users/dshvedchenko","html_url":"https://github.com/dshvedchenko","followers_url":"https://api.github.com/users/dshvedchenko/followers","following_url":"https://api.github.com/users/dshvedchenko/following{/other_user}","gists_url":"https://api.github.com/users/dshvedchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dshvedchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshvedchenko/subscriptions","organizations_url":"https://api.github.com/users/dshvedchenko/orgs","repos_url":"https://api.github.com/users/dshvedchenko/repos","events_url":"https://api.github.com/users/dshvedchenko/events{/privacy}","received_events_url":"https://api.github.com/users/dshvedchenko/received_events","type":"User","site_admin":false},"repo":{"id":31759608,"name":"PDI-Plugin-Step-AMQP","full_name":"dshvedchenko/PDI-Plugin-Step-AMQP","owner":{"login":"dshvedchenko","id":1282496,"avatar_url":"https://avatars.githubusercontent.com/u/1282496?v=3","gravatar_id":"","url":"https://api.github.com/users/dshvedchenko","html_url":"https://github.com/dshvedchenko","followers_url":"https://api.github.com/users/dshvedchenko/followers","following_url":"https://api.github.com/users/dshvedchenko/following{/other_user}","gists_url":"https://api.github.com/users/dshvedchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dshvedchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshvedchenko/subscriptions","organizations_url":"https://api.github.com/users/dshvedchenko/orgs","repos_url":"https://api.github.com/users/dshvedchenko/repos","events_url":"https://api.github.com/users/dshvedchenko/events{/privacy}","received_events_url":"https://api.github.com/users/dshvedchenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dshvedchenko/PDI-Plugin-Step-AMQP","description":"AMQP Plugin for PDI","fork":true,"url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP","forks_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/forks","keys_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/teams","hooks_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/hooks","issue_events_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/issues/events{/number}","events_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/events","assignees_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/assignees{/user}","branches_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/branches{/branch}","tags_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/tags","blobs_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/git/refs{/sha}","trees_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/statuses/{sha}","languages_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/languages","stargazers_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/stargazers","contributors_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/contributors","subscribers_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/subscribers","subscription_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/subscription","commits_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/commits{/sha}","git_commits_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/git/commits{/sha}","comments_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/comments{/number}","issue_comment_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/issues/comments{/number}","contents_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/contents/{+path}","compare_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/merges","archive_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/downloads","issues_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/issues{/number}","pulls_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/pulls{/number}","milestones_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/milestones{/number}","notifications_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/labels{/name}","releases_url":"https://api.github.com/repos/dshvedchenko/PDI-Plugin-Step-AMQP/releases{/id}","created_at":"2015-03-06T08:23:47Z","updated_at":"2015-03-06T14:50:43Z","pushed_at":"2015-06-04T16:16:38Z","git_url":"git://github.com/dshvedchenko/PDI-Plugin-Step-AMQP.git","ssh_url":"git@github.com:dshvedchenko/PDI-Plugin-Step-AMQP.git","clone_url":"https://github.com/dshvedchenko/PDI-Plugin-Step-AMQP.git","svn_url":"https://github.com/dshvedchenko/PDI-Plugin-Step-AMQP","homepage":null,"size":342,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"instaclick:2.0.x","ref":"2.0.x","sha":"210e4fd2fc88b6c2d7265cd24acb3a2f738a10ed","user":{"login":"instaclick","id":1379065,"avatar_url":"https://avatars.githubusercontent.com/u/1379065?v=3","gravatar_id":"","url":"https://api.github.com/users/instaclick","html_url":"https://github.com/instaclick","followers_url":"https://api.github.com/users/instaclick/followers","following_url":"https://api.github.com/users/instaclick/following{/other_user}","gists_url":"https://api.github.com/users/instaclick/gists{/gist_id}","starred_url":"https://api.github.com/users/instaclick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instaclick/subscriptions","organizations_url":"https://api.github.com/users/instaclick/orgs","repos_url":"https://api.github.com/users/instaclick/repos","events_url":"https://api.github.com/users/instaclick/events{/privacy}","received_events_url":"https://api.github.com/users/instaclick/received_events","type":"Organization","site_admin":false},"repo":{"id":15884235,"name":"PDI-Plugin-Step-AMQP","full_name":"instaclick/PDI-Plugin-Step-AMQP","owner":{"login":"instaclick","id":1379065,"avatar_url":"https://avatars.githubusercontent.com/u/1379065?v=3","gravatar_id":"","url":"https://api.github.com/users/instaclick","html_url":"https://github.com/instaclick","followers_url":"https://api.github.com/users/instaclick/followers","following_url":"https://api.github.com/users/instaclick/following{/other_user}","gists_url":"https://api.github.com/users/instaclick/gists{/gist_id}","starred_url":"https://api.github.com/users/instaclick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instaclick/subscriptions","organizations_url":"https://api.github.com/users/instaclick/orgs","repos_url":"https://api.github.com/users/instaclick/repos","events_url":"https://api.github.com/users/instaclick/events{/privacy}","received_events_url":"https://api.github.com/users/instaclick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP","description":"AMQP Plugin for PDI","fork":false,"url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP","forks_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/forks","keys_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/teams","hooks_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/hooks","issue_events_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/events{/number}","events_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/events","assignees_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/assignees{/user}","branches_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/branches{/branch}","tags_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/tags","blobs_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/git/refs{/sha}","trees_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/statuses/{sha}","languages_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/languages","stargazers_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/stargazers","contributors_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/contributors","subscribers_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/subscribers","subscription_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/subscription","commits_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/commits{/sha}","git_commits_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/git/commits{/sha}","comments_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/comments{/number}","issue_comment_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/comments{/number}","contents_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/contents/{+path}","compare_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/merges","archive_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/downloads","issues_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues{/number}","pulls_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls{/number}","milestones_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/milestones{/number}","notifications_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/labels{/name}","releases_url":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/releases{/id}","created_at":"2014-01-13T22:33:26Z","updated_at":"2015-04-16T17:36:38Z","pushed_at":"2015-06-04T16:16:38Z","git_url":"git://github.com/instaclick/PDI-Plugin-Step-AMQP.git","ssh_url":"git@github.com:instaclick/PDI-Plugin-Step-AMQP.git","clone_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP.git","svn_url":"https://github.com/instaclick/PDI-Plugin-Step-AMQP","homepage":null,"size":425,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":5,"default_branch":"2.0.x"}},"_links":{"self":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17"},"html":{"href":"https://github.com/instaclick/PDI-Plugin-Step-AMQP/pull/17"},"issue":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/17"},"comments":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/instaclick/PDI-Plugin-Step-AMQP/statuses/934db658d5270190057b911de105d59385ae6fe0"}}}}