{"action":"opened","number":19,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19","id":51935618,"html_url":"https://github.com/angular-ui/ui-validate/pull/19","diff_url":"https://github.com/angular-ui/ui-validate/pull/19.diff","patch_url":"https://github.com/angular-ui/ui-validate/pull/19.patch","issue_url":"https://api.github.com/repos/angular-ui/ui-validate/issues/19","number":19,"state":"open","locked":false,"title":"Avoid corrupting the NgModelController and the FormController when ui-validator returns undefined","user":{"login":"bluebilt","id":1673911,"avatar_url":"https://avatars.githubusercontent.com/u/1673911?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebilt","html_url":"https://github.com/bluebilt","followers_url":"https://api.github.com/users/bluebilt/followers","following_url":"https://api.github.com/users/bluebilt/following{/other_user}","gists_url":"https://api.github.com/users/bluebilt/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebilt/subscriptions","organizations_url":"https://api.github.com/users/bluebilt/orgs","repos_url":"https://api.github.com/users/bluebilt/repos","events_url":"https://api.github.com/users/bluebilt/events{/privacy}","received_events_url":"https://api.github.com/users/bluebilt/received_events","type":"User","site_admin":false},"body":"It seems angular can't handle validation functions that return 'undefined'. This leads to corruption of the NgModelController and the surrounding FormController. (both end up losing the $valid and $invalid properties)\r\n\r\nReturning undefined is a mistake that is easily made in a validator and it doesn't give an obvious error. This pull request makes the validator return false which is more obvious to the user.\r\n","created_at":"2015-11-26T17:30:11Z","updated_at":"2015-11-26T17:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19/commits","review_comments_url":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19/comments","review_comment_url":"https://api.github.com/repos/angular-ui/ui-validate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/ui-validate/issues/19/comments","statuses_url":"https://api.github.com/repos/angular-ui/ui-validate/statuses/87d819799b91446437663d203d10eb6c23d34c39","head":{"label":"bluebilt:master","ref":"master","sha":"87d819799b91446437663d203d10eb6c23d34c39","user":{"login":"bluebilt","id":1673911,"avatar_url":"https://avatars.githubusercontent.com/u/1673911?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebilt","html_url":"https://github.com/bluebilt","followers_url":"https://api.github.com/users/bluebilt/followers","following_url":"https://api.github.com/users/bluebilt/following{/other_user}","gists_url":"https://api.github.com/users/bluebilt/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebilt/subscriptions","organizations_url":"https://api.github.com/users/bluebilt/orgs","repos_url":"https://api.github.com/users/bluebilt/repos","events_url":"https://api.github.com/users/bluebilt/events{/privacy}","received_events_url":"https://api.github.com/users/bluebilt/received_events","type":"User","site_admin":false},"repo":{"id":46937976,"name":"ui-validate","full_name":"bluebilt/ui-validate","owner":{"login":"bluebilt","id":1673911,"avatar_url":"https://avatars.githubusercontent.com/u/1673911?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebilt","html_url":"https://github.com/bluebilt","followers_url":"https://api.github.com/users/bluebilt/followers","following_url":"https://api.github.com/users/bluebilt/following{/other_user}","gists_url":"https://api.github.com/users/bluebilt/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebilt/subscriptions","organizations_url":"https://api.github.com/users/bluebilt/orgs","repos_url":"https://api.github.com/users/bluebilt/repos","events_url":"https://api.github.com/users/bluebilt/events{/privacy}","received_events_url":"https://api.github.com/users/bluebilt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluebilt/ui-validate","description":"General-purpose validator for ngModel","fork":true,"url":"https://api.github.com/repos/bluebilt/ui-validate","forks_url":"https://api.github.com/repos/bluebilt/ui-validate/forks","keys_url":"https://api.github.com/repos/bluebilt/ui-validate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluebilt/ui-validate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluebilt/ui-validate/teams","hooks_url":"https://api.github.com/repos/bluebilt/ui-validate/hooks","issue_events_url":"https://api.github.com/repos/bluebilt/ui-validate/issues/events{/number}","events_url":"https://api.github.com/repos/bluebilt/ui-validate/events","assignees_url":"https://api.github.com/repos/bluebilt/ui-validate/assignees{/user}","branches_url":"https://api.github.com/repos/bluebilt/ui-validate/branches{/branch}","tags_url":"https://api.github.com/repos/bluebilt/ui-validate/tags","blobs_url":"https://api.github.com/repos/bluebilt/ui-validate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluebilt/ui-validate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluebilt/ui-validate/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluebilt/ui-validate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluebilt/ui-validate/statuses/{sha}","languages_url":"https://api.github.com/repos/bluebilt/ui-validate/languages","stargazers_url":"https://api.github.com/repos/bluebilt/ui-validate/stargazers","contributors_url":"https://api.github.com/repos/bluebilt/ui-validate/contributors","subscribers_url":"https://api.github.com/repos/bluebilt/ui-validate/subscribers","subscription_url":"https://api.github.com/repos/bluebilt/ui-validate/subscription","commits_url":"https://api.github.com/repos/bluebilt/ui-validate/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluebilt/ui-validate/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluebilt/ui-validate/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluebilt/ui-validate/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluebilt/ui-validate/contents/{+path}","compare_url":"https://api.github.com/repos/bluebilt/ui-validate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluebilt/ui-validate/merges","archive_url":"https://api.github.com/repos/bluebilt/ui-validate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluebilt/ui-validate/downloads","issues_url":"https://api.github.com/repos/bluebilt/ui-validate/issues{/number}","pulls_url":"https://api.github.com/repos/bluebilt/ui-validate/pulls{/number}","milestones_url":"https://api.github.com/repos/bluebilt/ui-validate/milestones{/number}","notifications_url":"https://api.github.com/repos/bluebilt/ui-validate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluebilt/ui-validate/labels{/name}","releases_url":"https://api.github.com/repos/bluebilt/ui-validate/releases{/id}","created_at":"2015-11-26T16:49:21Z","updated_at":"2015-11-26T16:49:22Z","pushed_at":"2015-11-26T16:59:50Z","git_url":"git://github.com/bluebilt/ui-validate.git","ssh_url":"git@github.com:bluebilt/ui-validate.git","clone_url":"https://github.com/bluebilt/ui-validate.git","svn_url":"https://github.com/bluebilt/ui-validate","homepage":"https://htmlpreview.github.io/?https://github.com/angular-ui/ui-validate/master/demo/index.html","size":6026,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"6ef6a179b220087c596a5341051a5a9eb7a1fbf7","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":36473648,"name":"ui-validate","full_name":"angular-ui/ui-validate","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/ui-validate","description":"General-purpose validator for ngModel","fork":false,"url":"https://api.github.com/repos/angular-ui/ui-validate","forks_url":"https://api.github.com/repos/angular-ui/ui-validate/forks","keys_url":"https://api.github.com/repos/angular-ui/ui-validate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/ui-validate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/ui-validate/teams","hooks_url":"https://api.github.com/repos/angular-ui/ui-validate/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/ui-validate/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/ui-validate/events","assignees_url":"https://api.github.com/repos/angular-ui/ui-validate/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/ui-validate/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/ui-validate/tags","blobs_url":"https://api.github.com/repos/angular-ui/ui-validate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/ui-validate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/ui-validate/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/ui-validate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/ui-validate/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/ui-validate/languages","stargazers_url":"https://api.github.com/repos/angular-ui/ui-validate/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/ui-validate/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/ui-validate/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/ui-validate/subscription","commits_url":"https://api.github.com/repos/angular-ui/ui-validate/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/ui-validate/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/ui-validate/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/ui-validate/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/ui-validate/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/ui-validate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/ui-validate/merges","archive_url":"https://api.github.com/repos/angular-ui/ui-validate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/ui-validate/downloads","issues_url":"https://api.github.com/repos/angular-ui/ui-validate/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/ui-validate/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/ui-validate/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/ui-validate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/ui-validate/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/ui-validate/releases{/id}","created_at":"2015-05-29T00:21:06Z","updated_at":"2015-11-26T12:49:08Z","pushed_at":"2015-10-23T01:54:42Z","git_url":"git://github.com/angular-ui/ui-validate.git","ssh_url":"git@github.com:angular-ui/ui-validate.git","clone_url":"https://github.com/angular-ui/ui-validate.git","svn_url":"https://github.com/angular-ui/ui-validate","homepage":"https://htmlpreview.github.io/?https://github.com/angular-ui/ui-validate/master/demo/index.html","size":6315,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":3,"forks":30,"open_issues":3,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19"},"html":{"href":"https://github.com/angular-ui/ui-validate/pull/19"},"issue":{"href":"https://api.github.com/repos/angular-ui/ui-validate/issues/19"},"comments":{"href":"https://api.github.com/repos/angular-ui/ui-validate/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/ui-validate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/ui-validate/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/ui-validate/statuses/87d819799b91446437663d203d10eb6c23d34c39"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":10,"changed_files":2}}