{"action":"created","comment":{"url":"https://api.github.com/repos/jnunemaker/flipper/pulls/comments/44965698","id":44965698,"diff_hunk":"@@ -16,8 +17,19 @@\n \n   before do\n     begin\n-      collection.drop\n-    rescue Mongo::Error::OperationFailure\n+      Timeout::timeout(1) do","path":"spec/flipper/adapters/mongo_spec.rb","position":null,"original_position":19,"commit_id":"9e027b0843f96990807b6becefe11aa257ff84e5","original_commit_id":"e6c91bd180922e572121d9351792ab4bf1973ecf","user":{"login":"listrophy","id":26813,"avatar_url":"https://avatars.githubusercontent.com/u/26813?v=3","gravatar_id":"","url":"https://api.github.com/users/listrophy","html_url":"https://github.com/listrophy","followers_url":"https://api.github.com/users/listrophy/followers","following_url":"https://api.github.com/users/listrophy/following{/other_user}","gists_url":"https://api.github.com/users/listrophy/gists{/gist_id}","starred_url":"https://api.github.com/users/listrophy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/listrophy/subscriptions","organizations_url":"https://api.github.com/users/listrophy/orgs","repos_url":"https://api.github.com/users/listrophy/repos","events_url":"https://api.github.com/users/listrophy/events{/privacy}","received_events_url":"https://api.github.com/users/listrophy/received_events","type":"User","site_admin":false},"body":"Since it truly is a separate concern, I just reverted the commit related to this. Setting the timeout in the mongo client initialization can be a separate PR.","created_at":"2015-11-16T18:58:22Z","updated_at":"2015-11-16T18:58:22Z","html_url":"https://github.com/jnunemaker/flipper/pull/87#discussion_r44965698","pull_request_url":"https://api.github.com/repos/jnunemaker/flipper/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/comments/44965698"},"html":{"href":"https://github.com/jnunemaker/flipper/pull/87#discussion_r44965698"},"pull_request":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/jnunemaker/flipper/pulls/87","id":50841937,"html_url":"https://github.com/jnunemaker/flipper/pull/87","diff_url":"https://github.com/jnunemaker/flipper/pull/87.diff","patch_url":"https://github.com/jnunemaker/flipper/pull/87.patch","issue_url":"https://api.github.com/repos/jnunemaker/flipper/issues/87","number":87,"state":"open","locked":false,"title":"Rspec3 syntax","user":{"login":"listrophy","id":26813,"avatar_url":"https://avatars.githubusercontent.com/u/26813?v=3","gravatar_id":"","url":"https://api.github.com/users/listrophy","html_url":"https://github.com/listrophy","followers_url":"https://api.github.com/users/listrophy/followers","following_url":"https://api.github.com/users/listrophy/following{/other_user}","gists_url":"https://api.github.com/users/listrophy/gists{/gist_id}","starred_url":"https://api.github.com/users/listrophy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/listrophy/subscriptions","organizations_url":"https://api.github.com/users/listrophy/orgs","repos_url":"https://api.github.com/users/listrophy/repos","events_url":"https://api.github.com/users/listrophy/events{/privacy}","received_events_url":"https://api.github.com/users/listrophy/received_events","type":"User","site_admin":false},"body":"Anyone who's writing their own adapter and using flipper's `shared_examples` to test it are likely to get deprecation warnings.\r\n\r\nThis PR includes 2 unrelated things... sorry!\r\n\r\n**First** (and most importantly), it switches the `should` syntax to `expect`. Nearly all the conversion was done with http://xinminlabs.github.io/synvert/, so there should be less chance for user error. The only manually converted file is the shared_spec file in lib.\r\n\r\n**Second**, I got a bit frustrated running specs on a clean repo the first time. Turns out, the mongo adapter waits 60 (or so) seconds (per spec!) before failing if it can't connect to the mongo server. This PR shortens that to 1 second and outputs a helpful message about maybe mongo not running.","created_at":"2015-11-16T17:44:38Z","updated_at":"2015-11-16T18:58:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a6ad85008fdb97f5ef670c009582082699c479d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jnunemaker/flipper/pulls/87/commits","review_comments_url":"https://api.github.com/repos/jnunemaker/flipper/pulls/87/comments","review_comment_url":"https://api.github.com/repos/jnunemaker/flipper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jnunemaker/flipper/issues/87/comments","statuses_url":"https://api.github.com/repos/jnunemaker/flipper/statuses/9e027b0843f96990807b6becefe11aa257ff84e5","head":{"label":"listrophy:rspec3_syntax","ref":"rspec3_syntax","sha":"9e027b0843f96990807b6becefe11aa257ff84e5","user":{"login":"listrophy","id":26813,"avatar_url":"https://avatars.githubusercontent.com/u/26813?v=3","gravatar_id":"","url":"https://api.github.com/users/listrophy","html_url":"https://github.com/listrophy","followers_url":"https://api.github.com/users/listrophy/followers","following_url":"https://api.github.com/users/listrophy/following{/other_user}","gists_url":"https://api.github.com/users/listrophy/gists{/gist_id}","starred_url":"https://api.github.com/users/listrophy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/listrophy/subscriptions","organizations_url":"https://api.github.com/users/listrophy/orgs","repos_url":"https://api.github.com/users/listrophy/repos","events_url":"https://api.github.com/users/listrophy/events{/privacy}","received_events_url":"https://api.github.com/users/listrophy/received_events","type":"User","site_admin":false},"repo":{"id":46291220,"name":"flipper","full_name":"listrophy/flipper","owner":{"login":"listrophy","id":26813,"avatar_url":"https://avatars.githubusercontent.com/u/26813?v=3","gravatar_id":"","url":"https://api.github.com/users/listrophy","html_url":"https://github.com/listrophy","followers_url":"https://api.github.com/users/listrophy/followers","following_url":"https://api.github.com/users/listrophy/following{/other_user}","gists_url":"https://api.github.com/users/listrophy/gists{/gist_id}","starred_url":"https://api.github.com/users/listrophy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/listrophy/subscriptions","organizations_url":"https://api.github.com/users/listrophy/orgs","repos_url":"https://api.github.com/users/listrophy/repos","events_url":"https://api.github.com/users/listrophy/events{/privacy}","received_events_url":"https://api.github.com/users/listrophy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/listrophy/flipper","description":"feature flipping for ANYTHING","fork":true,"url":"https://api.github.com/repos/listrophy/flipper","forks_url":"https://api.github.com/repos/listrophy/flipper/forks","keys_url":"https://api.github.com/repos/listrophy/flipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/listrophy/flipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/listrophy/flipper/teams","hooks_url":"https://api.github.com/repos/listrophy/flipper/hooks","issue_events_url":"https://api.github.com/repos/listrophy/flipper/issues/events{/number}","events_url":"https://api.github.com/repos/listrophy/flipper/events","assignees_url":"https://api.github.com/repos/listrophy/flipper/assignees{/user}","branches_url":"https://api.github.com/repos/listrophy/flipper/branches{/branch}","tags_url":"https://api.github.com/repos/listrophy/flipper/tags","blobs_url":"https://api.github.com/repos/listrophy/flipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/listrophy/flipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/listrophy/flipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/listrophy/flipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/listrophy/flipper/statuses/{sha}","languages_url":"https://api.github.com/repos/listrophy/flipper/languages","stargazers_url":"https://api.github.com/repos/listrophy/flipper/stargazers","contributors_url":"https://api.github.com/repos/listrophy/flipper/contributors","subscribers_url":"https://api.github.com/repos/listrophy/flipper/subscribers","subscription_url":"https://api.github.com/repos/listrophy/flipper/subscription","commits_url":"https://api.github.com/repos/listrophy/flipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/listrophy/flipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/listrophy/flipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/listrophy/flipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/listrophy/flipper/contents/{+path}","compare_url":"https://api.github.com/repos/listrophy/flipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/listrophy/flipper/merges","archive_url":"https://api.github.com/repos/listrophy/flipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/listrophy/flipper/downloads","issues_url":"https://api.github.com/repos/listrophy/flipper/issues{/number}","pulls_url":"https://api.github.com/repos/listrophy/flipper/pulls{/number}","milestones_url":"https://api.github.com/repos/listrophy/flipper/milestones{/number}","notifications_url":"https://api.github.com/repos/listrophy/flipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/listrophy/flipper/labels{/name}","releases_url":"https://api.github.com/repos/listrophy/flipper/releases{/id}","created_at":"2015-11-16T17:39:04Z","updated_at":"2015-11-16T17:39:05Z","pushed_at":"2015-11-16T18:57:13Z","git_url":"git://github.com/listrophy/flipper.git","ssh_url":"git@github.com:listrophy/flipper.git","clone_url":"https://github.com/listrophy/flipper.git","svn_url":"https://github.com/listrophy/flipper","homepage":"","size":1190,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jnunemaker:master","ref":"master","sha":"a5d92ac63332582bc4cbafd8c1a9458e2611024a","user":{"login":"jnunemaker","id":235,"avatar_url":"https://avatars.githubusercontent.com/u/235?v=3","gravatar_id":"","url":"https://api.github.com/users/jnunemaker","html_url":"https://github.com/jnunemaker","followers_url":"https://api.github.com/users/jnunemaker/followers","following_url":"https://api.github.com/users/jnunemaker/following{/other_user}","gists_url":"https://api.github.com/users/jnunemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/jnunemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnunemaker/subscriptions","organizations_url":"https://api.github.com/users/jnunemaker/orgs","repos_url":"https://api.github.com/users/jnunemaker/repos","events_url":"https://api.github.com/users/jnunemaker/events{/privacy}","received_events_url":"https://api.github.com/users/jnunemaker/received_events","type":"User","site_admin":true},"repo":{"id":5144181,"name":"flipper","full_name":"jnunemaker/flipper","owner":{"login":"jnunemaker","id":235,"avatar_url":"https://avatars.githubusercontent.com/u/235?v=3","gravatar_id":"","url":"https://api.github.com/users/jnunemaker","html_url":"https://github.com/jnunemaker","followers_url":"https://api.github.com/users/jnunemaker/followers","following_url":"https://api.github.com/users/jnunemaker/following{/other_user}","gists_url":"https://api.github.com/users/jnunemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/jnunemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnunemaker/subscriptions","organizations_url":"https://api.github.com/users/jnunemaker/orgs","repos_url":"https://api.github.com/users/jnunemaker/repos","events_url":"https://api.github.com/users/jnunemaker/events{/privacy}","received_events_url":"https://api.github.com/users/jnunemaker/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/jnunemaker/flipper","description":"feature flipping for ANYTHING","fork":false,"url":"https://api.github.com/repos/jnunemaker/flipper","forks_url":"https://api.github.com/repos/jnunemaker/flipper/forks","keys_url":"https://api.github.com/repos/jnunemaker/flipper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jnunemaker/flipper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jnunemaker/flipper/teams","hooks_url":"https://api.github.com/repos/jnunemaker/flipper/hooks","issue_events_url":"https://api.github.com/repos/jnunemaker/flipper/issues/events{/number}","events_url":"https://api.github.com/repos/jnunemaker/flipper/events","assignees_url":"https://api.github.com/repos/jnunemaker/flipper/assignees{/user}","branches_url":"https://api.github.com/repos/jnunemaker/flipper/branches{/branch}","tags_url":"https://api.github.com/repos/jnunemaker/flipper/tags","blobs_url":"https://api.github.com/repos/jnunemaker/flipper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jnunemaker/flipper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jnunemaker/flipper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jnunemaker/flipper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jnunemaker/flipper/statuses/{sha}","languages_url":"https://api.github.com/repos/jnunemaker/flipper/languages","stargazers_url":"https://api.github.com/repos/jnunemaker/flipper/stargazers","contributors_url":"https://api.github.com/repos/jnunemaker/flipper/contributors","subscribers_url":"https://api.github.com/repos/jnunemaker/flipper/subscribers","subscription_url":"https://api.github.com/repos/jnunemaker/flipper/subscription","commits_url":"https://api.github.com/repos/jnunemaker/flipper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jnunemaker/flipper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jnunemaker/flipper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jnunemaker/flipper/issues/comments{/number}","contents_url":"https://api.github.com/repos/jnunemaker/flipper/contents/{+path}","compare_url":"https://api.github.com/repos/jnunemaker/flipper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jnunemaker/flipper/merges","archive_url":"https://api.github.com/repos/jnunemaker/flipper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jnunemaker/flipper/downloads","issues_url":"https://api.github.com/repos/jnunemaker/flipper/issues{/number}","pulls_url":"https://api.github.com/repos/jnunemaker/flipper/pulls{/number}","milestones_url":"https://api.github.com/repos/jnunemaker/flipper/milestones{/number}","notifications_url":"https://api.github.com/repos/jnunemaker/flipper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jnunemaker/flipper/labels{/name}","releases_url":"https://api.github.com/repos/jnunemaker/flipper/releases{/id}","created_at":"2012-07-22T19:39:38Z","updated_at":"2015-11-15T00:30:11Z","pushed_at":"2015-11-16T18:57:13Z","git_url":"git://github.com/jnunemaker/flipper.git","ssh_url":"git@github.com:jnunemaker/flipper.git","clone_url":"https://github.com/jnunemaker/flipper.git","svn_url":"https://github.com/jnunemaker/flipper","homepage":"","size":1961,"stargazers_count":630,"watchers_count":630,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":6,"forks":39,"open_issues":6,"watchers":630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/87"},"html":{"href":"https://github.com/jnunemaker/flipper/pull/87"},"issue":{"href":"https://api.github.com/repos/jnunemaker/flipper/issues/87"},"comments":{"href":"https://api.github.com/repos/jnunemaker/flipper/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jnunemaker/flipper/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/jnunemaker/flipper/statuses/9e027b0843f96990807b6becefe11aa257ff84e5"}}}}