{"action":"created","issue":{"url":"https://api.github.com/repos/liveeditor/draftsman/issues/29","labels_url":"https://api.github.com/repos/liveeditor/draftsman/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/liveeditor/draftsman/issues/29/comments","events_url":"https://api.github.com/repos/liveeditor/draftsman/issues/29/events","html_url":"https://github.com/liveeditor/draftsman/pull/29","id":92706226,"number":29,"title":"Fixes #28: Skipped attributes aren't updated if a model has a draft","user":{"login":"npafundi","id":4703477,"avatar_url":"https://avatars.githubusercontent.com/u/4703477?v=3","gravatar_id":"","url":"https://api.github.com/users/npafundi","html_url":"https://github.com/npafundi","followers_url":"https://api.github.com/users/npafundi/followers","following_url":"https://api.github.com/users/npafundi/following{/other_user}","gists_url":"https://api.github.com/users/npafundi/gists{/gist_id}","starred_url":"https://api.github.com/users/npafundi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npafundi/subscriptions","organizations_url":"https://api.github.com/users/npafundi/orgs","repos_url":"https://api.github.com/users/npafundi/repos","events_url":"https://api.github.com/users/npafundi/events{/privacy}","received_events_url":"https://api.github.com/users/npafundi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-02T18:47:16Z","updated_at":"2015-07-08T19:53:15Z","closed_at":"2015-07-08T15:51:34Z","pull_request":{"url":"https://api.github.com/repos/liveeditor/draftsman/pulls/29","html_url":"https://github.com/liveeditor/draftsman/pull/29","diff_url":"https://github.com/liveeditor/draftsman/pull/29.diff","patch_url":"https://github.com/liveeditor/draftsman/pull/29.patch"},"body":"There was a saving inconsistency when a model has a draft vs. no draft.\r\n\r\n* When a model did not have a draft and both skipped and non-skipped attributes were updated, the skipped attributes were updated on the model, while the non-skipped attributes were updated in a new \"update\" draft.\r\n* When a model had a draft and both skipped and non-skipped attributes were updated, the skipped attributes were **not** updated on the model, and the non-skipped attributes were updated in the draft.\r\n\r\nThis commit resolves that inconsistency.  The skipped attributes are now always updated in this case, whether there is a draft or not.\r\n\r\nA test case has been provided that shows the issue."},"comment":{"url":"https://api.github.com/repos/liveeditor/draftsman/issues/comments/119713505","html_url":"https://github.com/liveeditor/draftsman/pull/29#issuecomment-119713505","issue_url":"https://api.github.com/repos/liveeditor/draftsman/issues/29","id":119713505,"user":{"login":"chrisdpeters","id":159187,"avatar_url":"https://avatars.githubusercontent.com/u/159187?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdpeters","html_url":"https://github.com/chrisdpeters","followers_url":"https://api.github.com/users/chrisdpeters/followers","following_url":"https://api.github.com/users/chrisdpeters/following{/other_user}","gists_url":"https://api.github.com/users/chrisdpeters/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdpeters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdpeters/subscriptions","organizations_url":"https://api.github.com/users/chrisdpeters/orgs","repos_url":"https://api.github.com/users/chrisdpeters/repos","events_url":"https://api.github.com/users/chrisdpeters/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdpeters/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T19:53:15Z","updated_at":"2015-07-08T19:53:15Z","body":"Hope you don't mind my changing your code, but I felt that what you were testing was worthy of a new `context` within the spec. See 135c70036dac1cb609e1128c47fca7f822ea8b13.\r\n\r\nThanks for catching this and fixing it! Looks like we'll need a v0.3.5!"}}