{"action":"opened","number":15,"pull_request":{"url":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15","id":53003606,"html_url":"https://github.com/simplereach/chef-nsq/pull/15","diff_url":"https://github.com/simplereach/chef-nsq/pull/15.diff","patch_url":"https://github.com/simplereach/chef-nsq/pull/15.patch","issue_url":"https://api.github.com/repos/simplereach/chef-nsq/issues/15","number":15,"state":"open","locked":false,"title":"Remove unused nsq common directory. Fix nsqd data_path","user":{"login":"blakesmith","id":44368,"avatar_url":"https://avatars.githubusercontent.com/u/44368?v=3","gravatar_id":"","url":"https://api.github.com/users/blakesmith","html_url":"https://github.com/blakesmith","followers_url":"https://api.github.com/users/blakesmith/followers","following_url":"https://api.github.com/users/blakesmith/following{/other_user}","gists_url":"https://api.github.com/users/blakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/blakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakesmith/subscriptions","organizations_url":"https://api.github.com/users/blakesmith/orgs","repos_url":"https://api.github.com/users/blakesmith/repos","events_url":"https://api.github.com/users/blakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/blakesmith/received_events","type":"User","site_admin":false},"body":"Hey there,\r\n\r\nIn our production environment, we had been setting `['nsq']['nsqd']['data_path']` in our node attributes, and not seeing the data directory being created when provisioning a server with nsqd. This PR fixes that.\r\n\r\nI removed the nsq 'common' directory attribute `['nsq']['data_path']`, since it's not used anywhere except in the nsqd recipe - it's confusing and not helpful to have one more layer of indirection between the two different directories. The nsqd recipe was updated to create the nsqd data_path instead.\r\n\r\nThis will be a breaking change for anyone who has overridden `['nsq']['data_path']` instead of `['nsq']['nsqd']['data_path']` - but it seems simpler and more correct to me.\r\n\r\nLet me know what you think!\r\n\r\nBlake","created_at":"2015-12-08T16:31:01Z","updated_at":"2015-12-08T16:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15/commits","review_comments_url":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15/comments","review_comment_url":"https://api.github.com/repos/simplereach/chef-nsq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplereach/chef-nsq/issues/15/comments","statuses_url":"https://api.github.com/repos/simplereach/chef-nsq/statuses/5bdf54c14179cef4a029d7245271525e2ee09e62","head":{"label":"blakesmith:nsqd_data_path","ref":"nsqd_data_path","sha":"5bdf54c14179cef4a029d7245271525e2ee09e62","user":{"login":"blakesmith","id":44368,"avatar_url":"https://avatars.githubusercontent.com/u/44368?v=3","gravatar_id":"","url":"https://api.github.com/users/blakesmith","html_url":"https://github.com/blakesmith","followers_url":"https://api.github.com/users/blakesmith/followers","following_url":"https://api.github.com/users/blakesmith/following{/other_user}","gists_url":"https://api.github.com/users/blakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/blakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakesmith/subscriptions","organizations_url":"https://api.github.com/users/blakesmith/orgs","repos_url":"https://api.github.com/users/blakesmith/repos","events_url":"https://api.github.com/users/blakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/blakesmith/received_events","type":"User","site_admin":false},"repo":{"id":45256045,"name":"chef-nsq","full_name":"blakesmith/chef-nsq","owner":{"login":"blakesmith","id":44368,"avatar_url":"https://avatars.githubusercontent.com/u/44368?v=3","gravatar_id":"","url":"https://api.github.com/users/blakesmith","html_url":"https://github.com/blakesmith","followers_url":"https://api.github.com/users/blakesmith/followers","following_url":"https://api.github.com/users/blakesmith/following{/other_user}","gists_url":"https://api.github.com/users/blakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/blakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakesmith/subscriptions","organizations_url":"https://api.github.com/users/blakesmith/orgs","repos_url":"https://api.github.com/users/blakesmith/repos","events_url":"https://api.github.com/users/blakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/blakesmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blakesmith/chef-nsq","description":"Chef Cookbook for NSQ","fork":true,"url":"https://api.github.com/repos/blakesmith/chef-nsq","forks_url":"https://api.github.com/repos/blakesmith/chef-nsq/forks","keys_url":"https://api.github.com/repos/blakesmith/chef-nsq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blakesmith/chef-nsq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blakesmith/chef-nsq/teams","hooks_url":"https://api.github.com/repos/blakesmith/chef-nsq/hooks","issue_events_url":"https://api.github.com/repos/blakesmith/chef-nsq/issues/events{/number}","events_url":"https://api.github.com/repos/blakesmith/chef-nsq/events","assignees_url":"https://api.github.com/repos/blakesmith/chef-nsq/assignees{/user}","branches_url":"https://api.github.com/repos/blakesmith/chef-nsq/branches{/branch}","tags_url":"https://api.github.com/repos/blakesmith/chef-nsq/tags","blobs_url":"https://api.github.com/repos/blakesmith/chef-nsq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blakesmith/chef-nsq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blakesmith/chef-nsq/git/refs{/sha}","trees_url":"https://api.github.com/repos/blakesmith/chef-nsq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blakesmith/chef-nsq/statuses/{sha}","languages_url":"https://api.github.com/repos/blakesmith/chef-nsq/languages","stargazers_url":"https://api.github.com/repos/blakesmith/chef-nsq/stargazers","contributors_url":"https://api.github.com/repos/blakesmith/chef-nsq/contributors","subscribers_url":"https://api.github.com/repos/blakesmith/chef-nsq/subscribers","subscription_url":"https://api.github.com/repos/blakesmith/chef-nsq/subscription","commits_url":"https://api.github.com/repos/blakesmith/chef-nsq/commits{/sha}","git_commits_url":"https://api.github.com/repos/blakesmith/chef-nsq/git/commits{/sha}","comments_url":"https://api.github.com/repos/blakesmith/chef-nsq/comments{/number}","issue_comment_url":"https://api.github.com/repos/blakesmith/chef-nsq/issues/comments{/number}","contents_url":"https://api.github.com/repos/blakesmith/chef-nsq/contents/{+path}","compare_url":"https://api.github.com/repos/blakesmith/chef-nsq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blakesmith/chef-nsq/merges","archive_url":"https://api.github.com/repos/blakesmith/chef-nsq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blakesmith/chef-nsq/downloads","issues_url":"https://api.github.com/repos/blakesmith/chef-nsq/issues{/number}","pulls_url":"https://api.github.com/repos/blakesmith/chef-nsq/pulls{/number}","milestones_url":"https://api.github.com/repos/blakesmith/chef-nsq/milestones{/number}","notifications_url":"https://api.github.com/repos/blakesmith/chef-nsq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blakesmith/chef-nsq/labels{/name}","releases_url":"https://api.github.com/repos/blakesmith/chef-nsq/releases{/id}","created_at":"2015-10-30T14:32:14Z","updated_at":"2015-10-30T14:32:15Z","pushed_at":"2015-12-08T16:25:37Z","git_url":"git://github.com/blakesmith/chef-nsq.git","ssh_url":"git@github.com:blakesmith/chef-nsq.git","clone_url":"https://github.com/blakesmith/chef-nsq.git","svn_url":"https://github.com/blakesmith/chef-nsq","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simplereach:master","ref":"master","sha":"1855ff4e9385559d5edd80e336e9d8df217c2619","user":{"login":"simplereach","id":421911,"avatar_url":"https://avatars.githubusercontent.com/u/421911?v=3","gravatar_id":"","url":"https://api.github.com/users/simplereach","html_url":"https://github.com/simplereach","followers_url":"https://api.github.com/users/simplereach/followers","following_url":"https://api.github.com/users/simplereach/following{/other_user}","gists_url":"https://api.github.com/users/simplereach/gists{/gist_id}","starred_url":"https://api.github.com/users/simplereach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplereach/subscriptions","organizations_url":"https://api.github.com/users/simplereach/orgs","repos_url":"https://api.github.com/users/simplereach/repos","events_url":"https://api.github.com/users/simplereach/events{/privacy}","received_events_url":"https://api.github.com/users/simplereach/received_events","type":"Organization","site_admin":false},"repo":{"id":15746562,"name":"chef-nsq","full_name":"simplereach/chef-nsq","owner":{"login":"simplereach","id":421911,"avatar_url":"https://avatars.githubusercontent.com/u/421911?v=3","gravatar_id":"","url":"https://api.github.com/users/simplereach","html_url":"https://github.com/simplereach","followers_url":"https://api.github.com/users/simplereach/followers","following_url":"https://api.github.com/users/simplereach/following{/other_user}","gists_url":"https://api.github.com/users/simplereach/gists{/gist_id}","starred_url":"https://api.github.com/users/simplereach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplereach/subscriptions","organizations_url":"https://api.github.com/users/simplereach/orgs","repos_url":"https://api.github.com/users/simplereach/repos","events_url":"https://api.github.com/users/simplereach/events{/privacy}","received_events_url":"https://api.github.com/users/simplereach/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplereach/chef-nsq","description":"Chef Cookbook for NSQ","fork":false,"url":"https://api.github.com/repos/simplereach/chef-nsq","forks_url":"https://api.github.com/repos/simplereach/chef-nsq/forks","keys_url":"https://api.github.com/repos/simplereach/chef-nsq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplereach/chef-nsq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplereach/chef-nsq/teams","hooks_url":"https://api.github.com/repos/simplereach/chef-nsq/hooks","issue_events_url":"https://api.github.com/repos/simplereach/chef-nsq/issues/events{/number}","events_url":"https://api.github.com/repos/simplereach/chef-nsq/events","assignees_url":"https://api.github.com/repos/simplereach/chef-nsq/assignees{/user}","branches_url":"https://api.github.com/repos/simplereach/chef-nsq/branches{/branch}","tags_url":"https://api.github.com/repos/simplereach/chef-nsq/tags","blobs_url":"https://api.github.com/repos/simplereach/chef-nsq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplereach/chef-nsq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplereach/chef-nsq/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplereach/chef-nsq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplereach/chef-nsq/statuses/{sha}","languages_url":"https://api.github.com/repos/simplereach/chef-nsq/languages","stargazers_url":"https://api.github.com/repos/simplereach/chef-nsq/stargazers","contributors_url":"https://api.github.com/repos/simplereach/chef-nsq/contributors","subscribers_url":"https://api.github.com/repos/simplereach/chef-nsq/subscribers","subscription_url":"https://api.github.com/repos/simplereach/chef-nsq/subscription","commits_url":"https://api.github.com/repos/simplereach/chef-nsq/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplereach/chef-nsq/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplereach/chef-nsq/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplereach/chef-nsq/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplereach/chef-nsq/contents/{+path}","compare_url":"https://api.github.com/repos/simplereach/chef-nsq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplereach/chef-nsq/merges","archive_url":"https://api.github.com/repos/simplereach/chef-nsq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplereach/chef-nsq/downloads","issues_url":"https://api.github.com/repos/simplereach/chef-nsq/issues{/number}","pulls_url":"https://api.github.com/repos/simplereach/chef-nsq/pulls{/number}","milestones_url":"https://api.github.com/repos/simplereach/chef-nsq/milestones{/number}","notifications_url":"https://api.github.com/repos/simplereach/chef-nsq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplereach/chef-nsq/labels{/name}","releases_url":"https://api.github.com/repos/simplereach/chef-nsq/releases{/id}","created_at":"2014-01-08T20:04:01Z","updated_at":"2015-11-14T18:47:01Z","pushed_at":"2015-08-11T06:08:27Z","git_url":"git://github.com/simplereach/chef-nsq.git","ssh_url":"git@github.com:simplereach/chef-nsq.git","clone_url":"https://github.com/simplereach/chef-nsq.git","svn_url":"https://github.com/simplereach/chef-nsq","homepage":null,"size":318,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15"},"html":{"href":"https://github.com/simplereach/chef-nsq/pull/15"},"issue":{"href":"https://api.github.com/repos/simplereach/chef-nsq/issues/15"},"comments":{"href":"https://api.github.com/repos/simplereach/chef-nsq/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/simplereach/chef-nsq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplereach/chef-nsq/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/simplereach/chef-nsq/statuses/5bdf54c14179cef4a029d7245271525e2ee09e62"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":5,"changed_files":3}}