{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/46770119","id":46770119,"diff_hunk":"@@ -0,0 +1,179 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.IO;\n+using System.Linq;\n+using System.Text;\n+using System.Diagnostics.Tracing;\n+using Xunit;\n+using System.Reflection;\n+\n+//using Mdt = MdtEventSources;\n+using Sdt = SdtEventSources;\n+using System.Diagnostics;\n+using System.Threading;\n+using System.Text.RegularExpressions;\n+\n+namespace BasicEventSourceTests\n+{\n+    \n+    public class TestsManifestGeneration\n+    {\n+        /// <summary>\n+        /// Visual Studio Online bug #125529, EventSource would fail when an EventSource was named \"EventSource\".\n+        /// </summary>\n+        [Fact]\n+        public void Test_EventSource_NamedEventSource()\n+        {\n+            lock (TestUtilities.EventSourceTestLock)\n+            {\n+                using (var es = new SdtEventSources.DontPollute.EventSource())\n+                {\n+                    using (var el = new LoudListener())\n+                    {\n+                        int i = 12;\n+                        es.EventWrite(i);\n+\n+                        Assert.Equal(1, LoudListener.LastEvent.EventId);\n+                        Assert.Equal(1, LoudListener.LastEvent.Payload.Count);\n+                        Assert.Equal(i, LoudListener.LastEvent.Payload[0]);\n+                    }\n+                }\n+            }\n+        }\n+\n+        /// <summary>\n+        /// Validate generating manifests for the inproc as well as reflection-loaded event sources\n+        /// </summary>\n+        [Fact]\n+        public void Test_GenerateManifest()\n+        {\n+#if true\n+            Console.WriteLine(\"Disabled because it fails in checkin but not locally on 10/6/2015\");","path":"src/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.cs","position":51,"original_position":51,"commit_id":"f5268e0acf9cb4742b38931898136a63ff25062a","original_commit_id":"f5268e0acf9cb4742b38931898136a63ff25062a","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Tests should be disabled with an attribute rather than compilation constants, e.g.\r\n```C#\r\n[ActiveIssue(12345)] // where 12345 is the GitHub issue number\r\n```","created_at":"2015-12-06T13:11:26Z","updated_at":"2015-12-06T13:11:26Z","html_url":"https://github.com/dotnet/corefx/pull/4843#discussion_r46770119","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/4843","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/46770119"},"html":{"href":"https://github.com/dotnet/corefx/pull/4843#discussion_r46770119"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4843"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4843","id":52733574,"html_url":"https://github.com/dotnet/corefx/pull/4843","diff_url":"https://github.com/dotnet/corefx/pull/4843.diff","patch_url":"https://github.com/dotnet/corefx/pull/4843.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4843","number":4843,"state":"open","locked":false,"title":"Porting EventSource tests to CoreFX","user":{"login":"davmason","id":12141819,"avatar_url":"https://avatars.githubusercontent.com/u/12141819?v=3","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"body":"Porting our EventSource tests to the CoreFX branch. Currently we don't have any tests for EventSource.\r\n\r\nThis set of tests does not have ETW testing enabled, we need TraceEvent to be enabled on CoreCLR for that to happen.","created_at":"2015-12-04T23:09:06Z","updated_at":"2015-12-06T13:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"341eb41278fa1c0a7e243f8bc7c245afcc0e2cbd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4843/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4843/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4843/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/f5268e0acf9cb4742b38931898136a63ff25062a","head":{"label":"davmason:master","ref":"master","sha":"f5268e0acf9cb4742b38931898136a63ff25062a","user":{"login":"davmason","id":12141819,"avatar_url":"https://avatars.githubusercontent.com/u/12141819?v=3","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"repo":{"id":46451122,"name":"corefx","full_name":"davmason/corefx","owner":{"login":"davmason","id":12141819,"avatar_url":"https://avatars.githubusercontent.com/u/12141819?v=3","gravatar_id":"","url":"https://api.github.com/users/davmason","html_url":"https://github.com/davmason","followers_url":"https://api.github.com/users/davmason/followers","following_url":"https://api.github.com/users/davmason/following{/other_user}","gists_url":"https://api.github.com/users/davmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davmason/subscriptions","organizations_url":"https://api.github.com/users/davmason/orgs","repos_url":"https://api.github.com/users/davmason/repos","events_url":"https://api.github.com/users/davmason/events{/privacy}","received_events_url":"https://api.github.com/users/davmason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davmason/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/davmason/corefx","forks_url":"https://api.github.com/repos/davmason/corefx/forks","keys_url":"https://api.github.com/repos/davmason/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davmason/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davmason/corefx/teams","hooks_url":"https://api.github.com/repos/davmason/corefx/hooks","issue_events_url":"https://api.github.com/repos/davmason/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/davmason/corefx/events","assignees_url":"https://api.github.com/repos/davmason/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/davmason/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/davmason/corefx/tags","blobs_url":"https://api.github.com/repos/davmason/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davmason/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davmason/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/davmason/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davmason/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/davmason/corefx/languages","stargazers_url":"https://api.github.com/repos/davmason/corefx/stargazers","contributors_url":"https://api.github.com/repos/davmason/corefx/contributors","subscribers_url":"https://api.github.com/repos/davmason/corefx/subscribers","subscription_url":"https://api.github.com/repos/davmason/corefx/subscription","commits_url":"https://api.github.com/repos/davmason/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/davmason/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/davmason/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/davmason/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/davmason/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/davmason/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davmason/corefx/merges","archive_url":"https://api.github.com/repos/davmason/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davmason/corefx/downloads","issues_url":"https://api.github.com/repos/davmason/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/davmason/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/davmason/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/davmason/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davmason/corefx/labels{/name}","releases_url":"https://api.github.com/repos/davmason/corefx/releases{/id}","created_at":"2015-11-18T22:17:41Z","updated_at":"2015-11-18T22:18:08Z","pushed_at":"2015-12-05T05:11:40Z","git_url":"git://github.com/davmason/corefx.git","ssh_url":"git@github.com:davmason/corefx.git","clone_url":"https://github.com/davmason/corefx.git","svn_url":"https://github.com/davmason/corefx","homepage":"http://dotnet.github.io/","size":42326,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"989e561cdf6cf1879b48f6f21a969a4c3f6e366a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-12-06T11:51:08Z","pushed_at":"2015-12-06T09:58:09Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":51568,"stargazers_count":8731,"watchers_count":8731,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1972,"mirror_url":null,"open_issues_count":753,"forks":1972,"open_issues":753,"watchers":8731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4843"},"html":{"href":"https://github.com/dotnet/corefx/pull/4843"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4843"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4843/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4843/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4843/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/f5268e0acf9cb4742b38931898136a63ff25062a"}}}}