{"action":"opened","number":3402,"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402","id":39613265,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/3402","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/3402.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/3402.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/3402","number":3402,"state":"open","locked":false,"title":"[*] FO Add if condition to displayBanner hook","user":{"login":"panploenes","id":8298538,"avatar_url":"https://avatars.githubusercontent.com/u/8298538?v=3","gravatar_id":"","url":"https://api.github.com/users/panploenes","html_url":"https://github.com/panploenes","followers_url":"https://api.github.com/users/panploenes/followers","following_url":"https://api.github.com/users/panploenes/following{/other_user}","gists_url":"https://api.github.com/users/panploenes/gists{/gist_id}","starred_url":"https://api.github.com/users/panploenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panploenes/subscriptions","organizations_url":"https://api.github.com/users/panploenes/orgs","repos_url":"https://api.github.com/users/panploenes/repos","events_url":"https://api.github.com/users/panploenes/events{/privacy}","received_events_url":"https://api.github.com/users/panploenes/received_events","type":"User","site_admin":false},"body":"Hey guys\r\n\r\nThis is more of a questions then an actual commit.\r\nWhile developing a new theme i noticed that we always have some empty \"divs\" hanging around when there is no module hooked into the hook that is placed inside these \"divs\". (What a sentence)\r\n\r\nNow i wonder if there is any performance advantage the way i propose it in this commit.\r\nIt obviously would save some DOM elements.\r\nJust want to get some input on this.","created_at":"2015-07-09T18:27:22Z","updated_at":"2015-07-09T18:27:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/3402/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/54555218d1a7d902df0c96011dae1bf63aea7a64","head":{"label":"panploenes:patch-1","ref":"patch-1","sha":"54555218d1a7d902df0c96011dae1bf63aea7a64","user":{"login":"panploenes","id":8298538,"avatar_url":"https://avatars.githubusercontent.com/u/8298538?v=3","gravatar_id":"","url":"https://api.github.com/users/panploenes","html_url":"https://github.com/panploenes","followers_url":"https://api.github.com/users/panploenes/followers","following_url":"https://api.github.com/users/panploenes/following{/other_user}","gists_url":"https://api.github.com/users/panploenes/gists{/gist_id}","starred_url":"https://api.github.com/users/panploenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panploenes/subscriptions","organizations_url":"https://api.github.com/users/panploenes/orgs","repos_url":"https://api.github.com/users/panploenes/repos","events_url":"https://api.github.com/users/panploenes/events{/privacy}","received_events_url":"https://api.github.com/users/panploenes/received_events","type":"User","site_admin":false},"repo":{"id":38812106,"name":"PrestaShop","full_name":"panploenes/PrestaShop","owner":{"login":"panploenes","id":8298538,"avatar_url":"https://avatars.githubusercontent.com/u/8298538?v=3","gravatar_id":"","url":"https://api.github.com/users/panploenes","html_url":"https://github.com/panploenes","followers_url":"https://api.github.com/users/panploenes/followers","following_url":"https://api.github.com/users/panploenes/following{/other_user}","gists_url":"https://api.github.com/users/panploenes/gists{/gist_id}","starred_url":"https://api.github.com/users/panploenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panploenes/subscriptions","organizations_url":"https://api.github.com/users/panploenes/orgs","repos_url":"https://api.github.com/users/panploenes/repos","events_url":"https://api.github.com/users/panploenes/events{/privacy}","received_events_url":"https://api.github.com/users/panploenes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panploenes/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/panploenes/PrestaShop","forks_url":"https://api.github.com/repos/panploenes/PrestaShop/forks","keys_url":"https://api.github.com/repos/panploenes/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panploenes/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panploenes/PrestaShop/teams","hooks_url":"https://api.github.com/repos/panploenes/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/panploenes/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/panploenes/PrestaShop/events","assignees_url":"https://api.github.com/repos/panploenes/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/panploenes/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/panploenes/PrestaShop/tags","blobs_url":"https://api.github.com/repos/panploenes/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panploenes/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panploenes/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/panploenes/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panploenes/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/panploenes/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/panploenes/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/panploenes/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/panploenes/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/panploenes/PrestaShop/subscription","commits_url":"https://api.github.com/repos/panploenes/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/panploenes/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/panploenes/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/panploenes/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/panploenes/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/panploenes/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panploenes/PrestaShop/merges","archive_url":"https://api.github.com/repos/panploenes/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panploenes/PrestaShop/downloads","issues_url":"https://api.github.com/repos/panploenes/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/panploenes/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/panploenes/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/panploenes/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panploenes/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/panploenes/PrestaShop/releases{/id}","created_at":"2015-07-09T09:43:49Z","updated_at":"2015-07-09T09:43:59Z","pushed_at":"2015-07-09T18:21:52Z","git_url":"git://github.com/panploenes/PrestaShop.git","ssh_url":"git@github.com:panploenes/PrestaShop.git","clone_url":"https://github.com/panploenes/PrestaShop.git","svn_url":"https://github.com/panploenes/PrestaShop","homepage":"http://www.prestashop.com/","size":203848,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:1.6.1.x","ref":"1.6.1.x","sha":"615ed328affb58fbcc5f452b383391e3ce58d7b6","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","created_at":"2012-11-19T16:41:31Z","updated_at":"2015-07-08T20:47:03Z","pushed_at":"2015-07-09T16:18:53Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":289059,"stargazers_count":1236,"watchers_count":1236,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1458,"mirror_url":null,"open_issues_count":339,"forks":1458,"open_issues":339,"watchers":1236,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/3402"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/3402"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/3402/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/3402/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/54555218d1a7d902df0c96011dae1bf63aea7a64"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}