{"action":"opened","number":1565,"pull_request":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565","id":31982815,"html_url":"https://github.com/Modernizr/Modernizr/pull/1565","diff_url":"https://github.com/Modernizr/Modernizr/pull/1565.diff","patch_url":"https://github.com/Modernizr/Modernizr/pull/1565.patch","issue_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1565","number":1565,"state":"open","locked":false,"title":"Add jscs to check style","user":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"body":"@ryanseddon \r\nfrom https://github.com/Modernizr/Modernizr/pull/1551#discussion_r26722041.\r\n\r\nI just copied the format from jshint so it will run it in on the same files (and same ignores).\r\n\r\nI didn't know what the rules should be (so we can start to discuss that based on the code) so I just picked the google preset as a start (using the jscs autoconfigure option (`jscs --autoconfigure src/ lib/ feature-detects/`). One option is to use it as a base or just copy the rules from the preset and add/remove as needed. If there isn't a written style guide or another one to follow we can just look at what's the majority.\r\n\r\nAnother thing would be how to go about fixing the styles after determining rules. We can use the autofix setting `jscs --auto-fix` (only in master branch) to fix most of the whitespace changes and everything else would be manual. I went ahead and did the autofix changes in a seperate commit so the potential changes of using the google preset can be seen. I can remove the 2nd commit or make a new PR to actually fix the changes later.\r\n\r\nAnd then adding it to the `grunt test` task after all that's fixed? Maybe that should be a separate issue?","created_at":"2015-03-26T01:43:57Z","updated_at":"2015-03-26T01:43:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cb104319b74a851b1e29611768be0e9d41bdffc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565/commits","review_comments_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565/comments","review_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/1565/comments","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/c15fd40b56cb2f19cc73bcda5b64ca6ef97f9d0d","head":{"label":"hzoo:add-jscs","ref":"add-jscs","sha":"c15fd40b56cb2f19cc73bcda5b64ca6ef97f9d0d","user":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"repo":{"id":32552710,"name":"Modernizr","full_name":"hzoo/Modernizr","owner":{"login":"hzoo","id":588473,"avatar_url":"https://avatars.githubusercontent.com/u/588473?v=3","gravatar_id":"","url":"https://api.github.com/users/hzoo","html_url":"https://github.com/hzoo","followers_url":"https://api.github.com/users/hzoo/followers","following_url":"https://api.github.com/users/hzoo/following{/other_user}","gists_url":"https://api.github.com/users/hzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/hzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzoo/subscriptions","organizations_url":"https://api.github.com/users/hzoo/orgs","repos_url":"https://api.github.com/users/hzoo/repos","events_url":"https://api.github.com/users/hzoo/events{/privacy}","received_events_url":"https://api.github.com/users/hzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzoo/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":true,"url":"https://api.github.com/repos/hzoo/Modernizr","forks_url":"https://api.github.com/repos/hzoo/Modernizr/forks","keys_url":"https://api.github.com/repos/hzoo/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzoo/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzoo/Modernizr/teams","hooks_url":"https://api.github.com/repos/hzoo/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/hzoo/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/hzoo/Modernizr/events","assignees_url":"https://api.github.com/repos/hzoo/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/hzoo/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/hzoo/Modernizr/tags","blobs_url":"https://api.github.com/repos/hzoo/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzoo/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzoo/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzoo/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzoo/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/hzoo/Modernizr/languages","stargazers_url":"https://api.github.com/repos/hzoo/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/hzoo/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/hzoo/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/hzoo/Modernizr/subscription","commits_url":"https://api.github.com/repos/hzoo/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzoo/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzoo/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzoo/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzoo/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/hzoo/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzoo/Modernizr/merges","archive_url":"https://api.github.com/repos/hzoo/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzoo/Modernizr/downloads","issues_url":"https://api.github.com/repos/hzoo/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/hzoo/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/hzoo/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/hzoo/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzoo/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/hzoo/Modernizr/releases{/id}","created_at":"2015-03-19T23:59:51Z","updated_at":"2015-03-26T01:23:50Z","pushed_at":"2015-03-26T01:41:35Z","git_url":"git://github.com/hzoo/Modernizr.git","ssh_url":"git@github.com:hzoo/Modernizr.git","clone_url":"https://github.com/hzoo/Modernizr.git","svn_url":"https://github.com/hzoo/Modernizr","homepage":"http://modernizr.com","size":14741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Modernizr:master","ref":"master","sha":"0f3035a63979e50dca228157b6037f2b6c85f422","user":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"repo":{"id":317757,"name":"Modernizr","full_name":"Modernizr/Modernizr","owner":{"login":"Modernizr","id":131060,"avatar_url":"https://avatars.githubusercontent.com/u/131060?v=3","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Modernizr/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":false,"url":"https://api.github.com/repos/Modernizr/Modernizr","forks_url":"https://api.github.com/repos/Modernizr/Modernizr/forks","keys_url":"https://api.github.com/repos/Modernizr/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Modernizr/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Modernizr/Modernizr/teams","hooks_url":"https://api.github.com/repos/Modernizr/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/Modernizr/Modernizr/events","assignees_url":"https://api.github.com/repos/Modernizr/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/Modernizr/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/Modernizr/Modernizr/tags","blobs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Modernizr/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Modernizr/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/Modernizr/Modernizr/languages","stargazers_url":"https://api.github.com/repos/Modernizr/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/Modernizr/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/Modernizr/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/Modernizr/Modernizr/subscription","commits_url":"https://api.github.com/repos/Modernizr/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Modernizr/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Modernizr/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/Modernizr/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Modernizr/Modernizr/merges","archive_url":"https://api.github.com/repos/Modernizr/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Modernizr/Modernizr/downloads","issues_url":"https://api.github.com/repos/Modernizr/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/Modernizr/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/Modernizr/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Modernizr/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/Modernizr/Modernizr/releases{/id}","created_at":"2009-09-25T20:13:23Z","updated_at":"2015-03-26T00:39:40Z","pushed_at":"2015-03-26T01:43:58Z","git_url":"git://github.com/Modernizr/Modernizr.git","ssh_url":"git@github.com:Modernizr/Modernizr.git","clone_url":"https://github.com/Modernizr/Modernizr.git","svn_url":"https://github.com/Modernizr/Modernizr","homepage":"http://modernizr.com","size":26747,"stargazers_count":14754,"watchers_count":14754,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1948,"mirror_url":null,"open_issues_count":112,"forks":1948,"open_issues":112,"watchers":14754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/1565"},"issue":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1565"},"comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/1565/comments"},"review_comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565/comments"},"review_comment":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/1565/commits"},"statuses":{"href":"https://api.github.com/repos/Modernizr/Modernizr/statuses/c15fd40b56cb2f19cc73bcda5b64ca6ef97f9d0d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":230,"deletions":208,"changed_files":107}}