{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/42786757","id":42786757,"diff_hunk":"@@ -111,14 +111,16 @@ module ApplianceConsole\n \n   loop do\n     begin\n+      dns = LinuxAdmin::Dns.new\n+\n       host     = LinuxAdmin::Hosts.new.hostname\n       ip       = Env[\"IP\"]\n       mac      = Env[\"MAC\"]\n       mask     = Env[\"MASK\"]\n       gw       = Env[\"GW\"]\n-      dns1     = Env[\"DNS1\"]\n-      dns2     = Env[\"DNS2\"]\n-      order    = Env[\"SEARCHORDER\"]\n+      dns1     = dns.nameservers.fetch(0, \"\")","path":"gems/pending/appliance_console.rb","position":14,"original_position":14,"commit_id":"3fff039e75e89c3e7cbdc05f2775df3a87c63e2d","original_commit_id":"3fff039e75e89c3e7cbdc05f2775df3a87c63e2d","user":{"login":"bdunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"body":"Is there a reason this can't be nil?","created_at":"2015-10-22T18:28:44Z","updated_at":"2015-10-22T18:28:44Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4707#discussion_r42786757","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/42786757"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4707#discussion_r42786757"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707","id":46942030,"html_url":"https://github.com/ManageIQ/manageiq/pull/4707","diff_url":"https://github.com/ManageIQ/manageiq/pull/4707.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4707.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4707","number":4707,"state":"open","locked":false,"title":"Use LinuxAdmin dns class","user":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"body":"Using `LinuxAdmin::Dns` for getting the nameserver and search order info rather than `miqnet.sh`\r\n\r\nRequires https://github.com/ManageIQ/linux_admin/pull/127\r\n\r\nhttps://trello.com/c/rWKh4KQs","created_at":"2015-10-06T18:49:06Z","updated_at":"2015-10-22T18:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af4f1b6ad0b72a7e7ac657e8b19a33f92858a03","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4707/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3fff039e75e89c3e7cbdc05f2775df3a87c63e2d","head":{"label":"carbonin:use_linux_admin_dns_class","ref":"use_linux_admin_dns_class","sha":"3fff039e75e89c3e7cbdc05f2775df3a87c63e2d","user":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"repo":{"id":36686944,"name":"manageiq","full_name":"carbonin/manageiq","owner":{"login":"carbonin","id":12697904,"avatar_url":"https://avatars.githubusercontent.com/u/12697904?v=3","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carbonin/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/carbonin/manageiq","forks_url":"https://api.github.com/repos/carbonin/manageiq/forks","keys_url":"https://api.github.com/repos/carbonin/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carbonin/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carbonin/manageiq/teams","hooks_url":"https://api.github.com/repos/carbonin/manageiq/hooks","issue_events_url":"https://api.github.com/repos/carbonin/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/carbonin/manageiq/events","assignees_url":"https://api.github.com/repos/carbonin/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/carbonin/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/carbonin/manageiq/tags","blobs_url":"https://api.github.com/repos/carbonin/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carbonin/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carbonin/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/carbonin/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carbonin/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/carbonin/manageiq/languages","stargazers_url":"https://api.github.com/repos/carbonin/manageiq/stargazers","contributors_url":"https://api.github.com/repos/carbonin/manageiq/contributors","subscribers_url":"https://api.github.com/repos/carbonin/manageiq/subscribers","subscription_url":"https://api.github.com/repos/carbonin/manageiq/subscription","commits_url":"https://api.github.com/repos/carbonin/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/carbonin/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/carbonin/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/carbonin/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/carbonin/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/carbonin/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carbonin/manageiq/merges","archive_url":"https://api.github.com/repos/carbonin/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carbonin/manageiq/downloads","issues_url":"https://api.github.com/repos/carbonin/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/carbonin/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/carbonin/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/carbonin/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carbonin/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/carbonin/manageiq/releases{/id}","created_at":"2015-06-01T20:29:47Z","updated_at":"2015-06-01T20:30:04Z","pushed_at":"2015-10-22T15:41:32Z","git_url":"git://github.com/carbonin/manageiq.git","ssh_url":"git@github.com:carbonin/manageiq.git","clone_url":"https://github.com/carbonin/manageiq.git","svn_url":"https://github.com/carbonin/manageiq","homepage":"manageiq.org","size":90636,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"38454a1fc4d2ae9b55885ea5566f3ac533b9baa7","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-10-21T05:07:57Z","pushed_at":"2015-10-22T18:25:22Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":178166,"stargazers_count":161,"watchers_count":161,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":446,"forks":172,"open_issues":446,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4707"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4707"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4707/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4707/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/3fff039e75e89c3e7cbdc05f2775df3a87c63e2d"}}}}