{"action":"created","issue":{"url":"https://api.github.com/repos/perfwatcher/collectm/issues/13","labels_url":"https://api.github.com/repos/perfwatcher/collectm/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/perfwatcher/collectm/issues/13/comments","events_url":"https://api.github.com/repos/perfwatcher/collectm/issues/13/events","html_url":"https://github.com/perfwatcher/collectm/pull/13","id":71260892,"number":13,"title":"Modularization","user":{"login":"ptzianos","id":1652175,"avatar_url":"https://avatars.githubusercontent.com/u/1652175?v=3","gravatar_id":"","url":"https://api.github.com/users/ptzianos","html_url":"https://github.com/ptzianos","followers_url":"https://api.github.com/users/ptzianos/followers","following_url":"https://api.github.com/users/ptzianos/following{/other_user}","gists_url":"https://api.github.com/users/ptzianos/gists{/gist_id}","starred_url":"https://api.github.com/users/ptzianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptzianos/subscriptions","organizations_url":"https://api.github.com/users/ptzianos/orgs","repos_url":"https://api.github.com/users/ptzianos/repos","events_url":"https://api.github.com/users/ptzianos/events{/privacy}","received_events_url":"https://api.github.com/users/ptzianos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/perfwatcher/collectm/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-27T11:51:43Z","updated_at":"2015-05-07T09:58:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/perfwatcher/collectm/pulls/13","html_url":"https://github.com/perfwatcher/collectm/pull/13","diff_url":"https://github.com/perfwatcher/collectm/pull/13.diff","patch_url":"https://github.com/perfwatcher/collectm/pull/13.patch"},"body":"This change in the collectdCompat plugin allows the user to select which of the metrics of plugin will be enabled. It was needed initially to make sure that the new load and disk plugins will not have any conflict with the existing functionality but it might come handy for other users in the future."},"comment":{"url":"https://api.github.com/repos/perfwatcher/collectm/issues/comments/99799614","html_url":"https://github.com/perfwatcher/collectm/pull/13#issuecomment-99799614","issue_url":"https://api.github.com/repos/perfwatcher/collectm/issues/13","id":99799614,"user":{"login":"ymettier","id":2285664,"avatar_url":"https://avatars.githubusercontent.com/u/2285664?v=3","gravatar_id":"","url":"https://api.github.com/users/ymettier","html_url":"https://github.com/ymettier","followers_url":"https://api.github.com/users/ymettier/followers","following_url":"https://api.github.com/users/ymettier/following{/other_user}","gists_url":"https://api.github.com/users/ymettier/gists{/gist_id}","starred_url":"https://api.github.com/users/ymettier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymettier/subscriptions","organizations_url":"https://api.github.com/users/ymettier/orgs","repos_url":"https://api.github.com/users/ymettier/repos","events_url":"https://api.github.com/users/ymettier/events{/privacy}","received_events_url":"https://api.github.com/users/ymettier/received_events","type":"User","site_admin":false},"created_at":"2015-05-07T09:58:14Z","updated_at":"2015-05-07T09:58:14Z","body":"Hello,\r\n\r\nI created a new branch named modularization.\r\nHere are the first lines of new ChangeLog : \r\n```\r\n- PR #10 : added Load plugin (Thanks to Paul Tzianos)\r\n- PR #11 : added Ping plugin (Thanks to Paul Tzianos)\r\n- PR #12 : added Disk plugin (Thanks to Paul Tzianos)\r\n- PR #15 : added Df plugin (Thanks to Paul Tzianos)\r\n- PR #13 (1) : removed duplicate modules from collectdCompat plugin (Thanks to Paul Tzianos)\r\n- PR #13 (2) : some modules of CollectdCompat plugin are now optional (Thanks to Paul Tzianos)\r\n```\r\n\r\nI will now close PR #10, PR #11, PR #12 and PR #15.\r\nI keep this PR open until I merge the \"modularization\" branch into master.\r\n\r\nNotes about the merge :\r\n* I kept your code in collectdCompat as you requested.\r\n* You should run `grunt test` in order to test the syntax (thanks to jshint) before sending any PR\r\n* jshint noticed 2 syntax errors (missing semicolon at the end of lines)\r\n* jshint complains about double quotes. You should use single quotes instead.\r\n* jshint complains about some vars['xyz'] that should be better written vars.xyz\r\n* jshint complains about some `== 0` or `== true` comparizons that should better be written as `=== 0` or `=== true`.\r\n\r\nI fixed all those jshint complains.\r\n\r\nI also included ping-output npm module into Collectm.\r\n\r\nBecause the merging of all your PR confliced on default.json configuration file, I'd prefer that we now work on the modularization branch in order to fix what is not working yet (load : see below). That's why I close the other PR.\r\n\r\nLast problem : load plugin crashed as soon as I started Collectm. More info about that will follow.\r\n\r\nRegards,\r\nYves"}}