{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/46098508","id":46098508,"diff_hunk":"@@ -14,7 +14,7 @@\n \n open Cmx_format\n \n-val reset: ?packname:string -> string -> unit\n+val reset: ?packname:string -> sourcefile:Timings.build_kind -> string -> unit","path":"asmcomp/compilenv.mli","position":5,"original_position":5,"commit_id":"52c00a9c08e2f11aba13af7f74b24cc09a30c01a","original_commit_id":"52c00a9c08e2f11aba13af7f74b24cc09a30c01a","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"To someone with no knowledge of the `Timings` module, having a `sourcefile` parameter with type `Timings.build_kind` is not very intuitive.","created_at":"2015-11-29T21:48:37Z","updated_at":"2015-11-29T21:48:37Z","html_url":"https://github.com/ocaml/ocaml/pull/306#discussion_r46098508","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/46098508"},"html":{"href":"https://github.com/ocaml/ocaml/pull/306#discussion_r46098508"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/306","id":51555559,"html_url":"https://github.com/ocaml/ocaml/pull/306","diff_url":"https://github.com/ocaml/ocaml/pull/306.diff","patch_url":"https://github.com/ocaml/ocaml/pull/306.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/306","number":306,"state":"open","locked":false,"title":"Instrument the compiler to record time of different phases","user":{"login":"chambart","id":2196625,"avatar_url":"https://avatars.githubusercontent.com/u/2196625?v=3","gravatar_id":"","url":"https://api.github.com/users/chambart","html_url":"https://github.com/chambart","followers_url":"https://api.github.com/users/chambart/followers","following_url":"https://api.github.com/users/chambart/following{/other_user}","gists_url":"https://api.github.com/users/chambart/gists{/gist_id}","starred_url":"https://api.github.com/users/chambart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambart/subscriptions","organizations_url":"https://api.github.com/users/chambart/orgs","repos_url":"https://api.github.com/users/chambart/repos","events_url":"https://api.github.com/users/chambart/events{/privacy}","received_events_url":"https://api.github.com/users/chambart/received_events","type":"User","site_admin":false},"body":"This was developed as part of the flambda branch to track compiler performance regressions. I think this can be useful for other developments.\r\n\r\nThe timings are produced on stderr in an easy to parse format. This allows to run bulk builds with `OCAMLPARAM=timings=1,_ opam install --verbose ...` and directly extract the relevant informations from the output.\r\n```\r\nall: 2.600s\r\nparsing(camlinternalFormat.ml): 0.088s\r\ntyping(camlinternalFormat.ml): 1.784s\r\ntransl(camlinternalFormat.ml): 0.104s\r\ngenerate(camlinternalFormat.ml): 0.620s\r\nclambda(camlinternalFormat.ml): 0.032s\r\ncmm(camlinternalFormat.ml): 0.020s\r\ncompile_phrases(camlinternalFormat.ml): 0.476s\r\nregalloc: 0.236s\r\nassemble(camlinternalFormat.ml): 0.000s\r\n```\r\n\r\nThe times are associated to their respective files to be able to handle correctly multi-files compilation commands. regalloc isn't to avoid propagating too many changes in this patch.","created_at":"2015-11-23T17:42:54Z","updated_at":"2015-11-29T21:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d8a3f1a7ff1efe2f4d7c02ac06e94dd657c6a87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/306/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/306/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/306/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/52c00a9c08e2f11aba13af7f74b24cc09a30c01a","head":{"label":"chambart:compiler_instrumentation","ref":"compiler_instrumentation","sha":"52c00a9c08e2f11aba13af7f74b24cc09a30c01a","user":{"login":"chambart","id":2196625,"avatar_url":"https://avatars.githubusercontent.com/u/2196625?v=3","gravatar_id":"","url":"https://api.github.com/users/chambart","html_url":"https://github.com/chambart","followers_url":"https://api.github.com/users/chambart/followers","following_url":"https://api.github.com/users/chambart/following{/other_user}","gists_url":"https://api.github.com/users/chambart/gists{/gist_id}","starred_url":"https://api.github.com/users/chambart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambart/subscriptions","organizations_url":"https://api.github.com/users/chambart/orgs","repos_url":"https://api.github.com/users/chambart/repos","events_url":"https://api.github.com/users/chambart/events{/privacy}","received_events_url":"https://api.github.com/users/chambart/received_events","type":"User","site_admin":false},"repo":{"id":18686752,"name":"ocaml-1","full_name":"chambart/ocaml-1","owner":{"login":"chambart","id":2196625,"avatar_url":"https://avatars.githubusercontent.com/u/2196625?v=3","gravatar_id":"","url":"https://api.github.com/users/chambart","html_url":"https://github.com/chambart","followers_url":"https://api.github.com/users/chambart/followers","following_url":"https://api.github.com/users/chambart/following{/other_user}","gists_url":"https://api.github.com/users/chambart/gists{/gist_id}","starred_url":"https://api.github.com/users/chambart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambart/subscriptions","organizations_url":"https://api.github.com/users/chambart/orgs","repos_url":"https://api.github.com/users/chambart/repos","events_url":"https://api.github.com/users/chambart/events{/privacy}","received_events_url":"https://api.github.com/users/chambart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chambart/ocaml-1","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/chambart/ocaml-1","forks_url":"https://api.github.com/repos/chambart/ocaml-1/forks","keys_url":"https://api.github.com/repos/chambart/ocaml-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chambart/ocaml-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chambart/ocaml-1/teams","hooks_url":"https://api.github.com/repos/chambart/ocaml-1/hooks","issue_events_url":"https://api.github.com/repos/chambart/ocaml-1/issues/events{/number}","events_url":"https://api.github.com/repos/chambart/ocaml-1/events","assignees_url":"https://api.github.com/repos/chambart/ocaml-1/assignees{/user}","branches_url":"https://api.github.com/repos/chambart/ocaml-1/branches{/branch}","tags_url":"https://api.github.com/repos/chambart/ocaml-1/tags","blobs_url":"https://api.github.com/repos/chambart/ocaml-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chambart/ocaml-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chambart/ocaml-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/chambart/ocaml-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chambart/ocaml-1/statuses/{sha}","languages_url":"https://api.github.com/repos/chambart/ocaml-1/languages","stargazers_url":"https://api.github.com/repos/chambart/ocaml-1/stargazers","contributors_url":"https://api.github.com/repos/chambart/ocaml-1/contributors","subscribers_url":"https://api.github.com/repos/chambart/ocaml-1/subscribers","subscription_url":"https://api.github.com/repos/chambart/ocaml-1/subscription","commits_url":"https://api.github.com/repos/chambart/ocaml-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/chambart/ocaml-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/chambart/ocaml-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/chambart/ocaml-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/chambart/ocaml-1/contents/{+path}","compare_url":"https://api.github.com/repos/chambart/ocaml-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chambart/ocaml-1/merges","archive_url":"https://api.github.com/repos/chambart/ocaml-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chambart/ocaml-1/downloads","issues_url":"https://api.github.com/repos/chambart/ocaml-1/issues{/number}","pulls_url":"https://api.github.com/repos/chambart/ocaml-1/pulls{/number}","milestones_url":"https://api.github.com/repos/chambart/ocaml-1/milestones{/number}","notifications_url":"https://api.github.com/repos/chambart/ocaml-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chambart/ocaml-1/labels{/name}","releases_url":"https://api.github.com/repos/chambart/ocaml-1/releases{/id}","created_at":"2014-04-11T19:50:53Z","updated_at":"2015-07-04T13:12:41Z","pushed_at":"2015-11-28T20:57:49Z","git_url":"git://github.com/chambart/ocaml-1.git","ssh_url":"git@github.com:chambart/ocaml-1.git","clone_url":"https://github.com/chambart/ocaml-1.git","svn_url":"https://github.com/chambart/ocaml-1","homepage":null,"size":149645,"stargazers_count":2,"watchers_count":2,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"flambda_trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"657e6be3dd15e20b7bbb51e72d584746e1b48904","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","created_at":"2012-11-20T22:18:22Z","updated_at":"2015-11-29T07:22:48Z","pushed_at":"2015-11-29T21:37:33Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":161955,"stargazers_count":559,"watchers_count":559,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":72,"forks":196,"open_issues":72,"watchers":559,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/306"},"html":{"href":"https://github.com/ocaml/ocaml/pull/306"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/306"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/52c00a9c08e2f11aba13af7f74b24cc09a30c01a"}}}}