{"action":"created","issue":{"url":"https://api.github.com/repos/simoncozens/sile/issues/114","labels_url":"https://api.github.com/repos/simoncozens/sile/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/simoncozens/sile/issues/114/comments","events_url":"https://api.github.com/repos/simoncozens/sile/issues/114/events","html_url":"https://github.com/simoncozens/sile/pull/114","id":90027939,"number":114,"title":"Added font fullname to face fields (to include font style).","user":{"login":"pkulchenko","id":77071,"avatar_url":"https://avatars.githubusercontent.com/u/77071?v=3","gravatar_id":"","url":"https://api.github.com/users/pkulchenko","html_url":"https://github.com/pkulchenko","followers_url":"https://api.github.com/users/pkulchenko/followers","following_url":"https://api.github.com/users/pkulchenko/following{/other_user}","gists_url":"https://api.github.com/users/pkulchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/pkulchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkulchenko/subscriptions","organizations_url":"https://api.github.com/users/pkulchenko/orgs","repos_url":"https://api.github.com/users/pkulchenko/repos","events_url":"https://api.github.com/users/pkulchenko/events{/privacy}","received_events_url":"https://api.github.com/users/pkulchenko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-22T06:54:04Z","updated_at":"2015-06-27T04:36:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/simoncozens/sile/pulls/114","html_url":"https://github.com/simoncozens/sile/pull/114","diff_url":"https://github.com/simoncozens/sile/pull/114.diff","patch_url":"https://github.com/simoncozens/sile/pull/114.patch"},"body":"Simon, per the discussion in #95, this adds `fullname` fields to the `face` result for the font substitution, which allows to properly load the font (to use with alternative viewers) as `family` only returns the name, but doesn't return the style.\r\n\r\nFrom the documentation:\r\n\r\n```\r\n fullname       FC_FULLNAME            String  Font face full name where\r\n                                               different from family and\r\n                                               family + style\r\n```"},"comment":{"url":"https://api.github.com/repos/simoncozens/sile/issues/comments/115957318","html_url":"https://github.com/simoncozens/sile/pull/114#issuecomment-115957318","issue_url":"https://api.github.com/repos/simoncozens/sile/issues/114","id":115957318,"user":{"login":"alerque","id":173595,"avatar_url":"https://avatars.githubusercontent.com/u/173595?v=3","gravatar_id":"","url":"https://api.github.com/users/alerque","html_url":"https://github.com/alerque","followers_url":"https://api.github.com/users/alerque/followers","following_url":"https://api.github.com/users/alerque/following{/other_user}","gists_url":"https://api.github.com/users/alerque/gists{/gist_id}","starred_url":"https://api.github.com/users/alerque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alerque/subscriptions","organizations_url":"https://api.github.com/users/alerque/orgs","repos_url":"https://api.github.com/users/alerque/repos","events_url":"https://api.github.com/users/alerque/events{/privacy}","received_events_url":"https://api.github.com/users/alerque/received_events","type":"User","site_admin":false},"created_at":"2015-06-27T04:36:44Z","updated_at":"2015-06-27T04:36:44Z","body":"@pkulchenko Out of curiosity were you able to replicate the error Travis CI ran into locally?\r\n\r\n\t### Compiling examples/showoff.sil\r\n\tThis is SILE 0.9.3-unreleased\r\n\t<examples/showoff.sil>\r\n\tError detected:\r\n\tcore/harfbuzz-shaper.lua:28: attempt to index local 'face' (a nil value)\r\n\tThe command \"perl tests/attack.pl\" exited with 1.\r\n\r\nJust wondering if this is a problem with the tests or with something showing up in edge cases that your changes broke."}}