{"action":"created","issue":{"url":"https://api.github.com/repos/markfasheh/duperemove/issues/78","labels_url":"https://api.github.com/repos/markfasheh/duperemove/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/markfasheh/duperemove/issues/78/comments","events_url":"https://api.github.com/repos/markfasheh/duperemove/issues/78/events","html_url":"https://github.com/markfasheh/duperemove/issues/78","id":91190642,"number":78,"title":"Identical files not deduped","user":{"login":"petechap","id":511966,"avatar_url":"https://avatars.githubusercontent.com/u/511966?v=3","gravatar_id":"","url":"https://api.github.com/users/petechap","html_url":"https://github.com/petechap","followers_url":"https://api.github.com/users/petechap/followers","following_url":"https://api.github.com/users/petechap/following{/other_user}","gists_url":"https://api.github.com/users/petechap/gists{/gist_id}","starred_url":"https://api.github.com/users/petechap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petechap/subscriptions","organizations_url":"https://api.github.com/users/petechap/orgs","repos_url":"https://api.github.com/users/petechap/repos","events_url":"https://api.github.com/users/petechap/events{/privacy}","received_events_url":"https://api.github.com/users/petechap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-26T08:37:39Z","updated_at":"2015-06-28T22:21:35Z","closed_at":null,"body":"Tested 'master' branch at bc5aae3b19:\r\n\r\nduperemove finds the common extent in identical files, but doesn't dedupe them when the '-d' option is given. Sample session here:\r\n\r\nhttps://gist.github.com/petechap/355014a0c752f3d63ccf\r\n\r\nRunning 'btrfs-extent-same' on the same files manually will dedupe them OK.\r\n\r\nFor some reason I don't understand, the kernel is marking every file extent I write as 'shared' shortly after being written to disk. However looking at the physical extents in the above gist will clearly show that duperemove is not doing anything"},"comment":{"url":"https://api.github.com/repos/markfasheh/duperemove/issues/comments/116355661","html_url":"https://github.com/markfasheh/duperemove/issues/78#issuecomment-116355661","issue_url":"https://api.github.com/repos/markfasheh/duperemove/issues/78","id":116355661,"user":{"login":"petechap","id":511966,"avatar_url":"https://avatars.githubusercontent.com/u/511966?v=3","gravatar_id":"","url":"https://api.github.com/users/petechap","html_url":"https://github.com/petechap","followers_url":"https://api.github.com/users/petechap/followers","following_url":"https://api.github.com/users/petechap/following{/other_user}","gists_url":"https://api.github.com/users/petechap/gists{/gist_id}","starred_url":"https://api.github.com/users/petechap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petechap/subscriptions","organizations_url":"https://api.github.com/users/petechap/orgs","repos_url":"https://api.github.com/users/petechap/repos","events_url":"https://api.github.com/users/petechap/events{/privacy}","received_events_url":"https://api.github.com/users/petechap/received_events","type":"User","site_admin":false},"created_at":"2015-06-28T22:21:35Z","updated_at":"2015-06-28T22:21:35Z","body":"Sorry Mark, I only just saw your comment on the gist.\r\n\r\nI'm using your 'master branch at bc5aae3, and \"uname -a\" gives me:\r\nLinux pan 3.19.0-21-generic #21-Ubuntu SMP Sun Jun 14 18:31:11 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux\r\n\r\nI've bisected the problem and it was actually introduced in revision bc5aae3. Prior to this, the dedupe iotcl is getting issued correctly in my above example. After that revision, no ioctl is issued at all."}}