{"push_id":886820543,"size":30,"distinct_size":13,"ref":"refs/heads/adding-system-addressbook-of-users","head":"0391cc045109cc0dcc5f60753144593ab019626c","before":"bf767293c2d7c88d3e08fcc26bbd4c961c900caa","commits":[{"sha":"497101554404cc40e5fee4335a567bfcec780de8","author":{"email":"65adda4326914576405c9e3a62f4904d96573863@owncloud.com","name":"Lukas Reschke"},"message":"Add code integrity check\n\nThis PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.\n\nFurthermore, there is a basic implementation to display problems with the code integrity on the update screen.\n\nCode signing basically happens the following way:\n\n- There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.\n- Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`,  apps need to be signed with a certificate that either has a CN of `core` (shipped apps!)  or the AppID.\n- The command generates a signature.json file of the following format:\n```json\n{\n    \"hashes\": {\n        \"/filename.php\": \"2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d\",\n        \"/lib/base.php\": \"55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9\"\n    },\n    \"certificate\": \"-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\\niG+UxI/MNcWV0uJg9S63LF8=\\n-----END CERTIFICATE-----\",\n    \"signature\": \"U29tZVNpZ25lZERhdGFFeGFtcGxl\"\n}\n```\n`hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the  certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.\n\nSteps to do in other PRs, this is already a quite huge one:\n- Add nag screen in case the code check fails to ensure that administrators are aware of this.\n- Add code verification also to OCC upgrade and unify display code more.\n- Add enforced code verification to apps shipped from the appstore with a level of \"official\"\n- Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release\n- Add some developer documentation on how devs can request their own certificate\n- Check when installing ownCloud\n- Add support for CRLs to allow revoking certificates\n\n**Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:\n\n```\n➜  master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt\nSuccessfully signed \"core\"\n```\n\nThen increase the version and you should see something like the following:\n\n![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)\n\nAs you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.\n\nFor packaging stable releases this requires the following additional steps as a last action before zipping:\n1. Run `./occ integrity:sign-core` once\n2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/497101554404cc40e5fee4335a567bfcec780de8"},{"sha":"b4302a49be9e0ea67f53fe566c9335fa23ed9a9f","author":{"email":"16f2d52edcaec44656b79b18c493fd900b9ac5db@owncloud.com","name":"Roeland Jago Douma"},"message":"Make autotest.sh able to output proper coverage again\n\nThe usage of single quotes make sure that a string is used verbatim in\nbash. And no variables are subsituted.","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/b4302a49be9e0ea67f53fe566c9335fa23ed9a9f"},{"sha":"1761fdd9eea8fa8a367a45df3912943a4d67bf37","author":{"email":"f44f7abf4c5d551f4e22b9283a65f9a39d9bd450@owncloud.com","name":"Joas Schilling"},"message":"Fix the docs of the exceptions and remove hardcoded language from the message","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/1761fdd9eea8fa8a367a45df3912943a4d67bf37"},{"sha":"cce053f7e935cdb8a94eccc3d23775efa5f0699f","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Merge pull request #20859 from owncloud/autotest-coverage\n\nMake autotest.sh able to output proper coverage again","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/cce053f7e935cdb8a94eccc3d23775efa5f0699f"},{"sha":"0655f3d102a5ad6059c51a0af38d4dbb9f1f6fa4","author":{"email":"7f550a9f4c44173a37664d938f1355f0f92a47a7@morrisjobke.de","name":"Morris Jobke"},"message":"Revert \"Fix column width of mtime column\"","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/0655f3d102a5ad6059c51a0af38d4dbb9f1f6fa4"},{"sha":"d5ffbc94012d4a21bf9e5bc95988c220e981afd1","author":{"email":"b9f9a77534c684a24e62227084543c5efc7e604e@owncloud.com","name":"Robin Appelman"},"message":"Add command to get and set config for external mounts","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/d5ffbc94012d4a21bf9e5bc95988c220e981afd1"},{"sha":"2dd0066b0e1a9dba311f964617f8d7f13a6123bf","author":{"email":"b9f9a77534c684a24e62227084543c5efc7e604e@owncloud.com","name":"Robin Appelman"},"message":"Add command to set mount options for external storages","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/2dd0066b0e1a9dba311f964617f8d7f13a6123bf"},{"sha":"1347e3332bafd3ae44327843b06979b75d169034","author":{"email":"b9f9a77534c684a24e62227084543c5efc7e604e@owncloud.com","name":"Robin Appelman"},"message":"return non 0 status code in case of missing mount","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/1347e3332bafd3ae44327843b06979b75d169034"},{"sha":"490e01e3836b4a7d21ec660350d0401136985a49","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Merge pull request #20861 from owncloud/systemtags-better-exceptions-docs\n\nFix the docs of the exceptions and remove hardcoded language from the…","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/490e01e3836b4a7d21ec660350d0401136985a49"},{"sha":"d5fe052838064909232565265787ba2d9bbf39cf","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Merge pull request #20868 from owncloud/revert-20842-fix-date-time-column\n\nRevert \"Fix column width of mtime column\"","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/d5fe052838064909232565265787ba2d9bbf39cf"},{"sha":"27da63886f14a94aab1fb7e4927cca7a5b940f68","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Merge pull request #20710 from owncloud/files_external_config_command\n\nAdd command to get and set config for external mounts","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/27da63886f14a94aab1fb7e4927cca7a5b940f68"},{"sha":"74e8c25a5b48eb4b675de262ced1702dec4307f4","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Merge pull request #20285 from owncloud/add-integrity-checker\n\nAdd code integrity checker foundation","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/74e8c25a5b48eb4b675de262ced1702dec4307f4"},{"sha":"2515cb17be18da4aee32167259ee75fdc7a5a56b","author":{"email":"65adda4326914576405c9e3a62f4904d96573863@owncloud.com","name":"Lukas Reschke"},"message":"Support pretty URLs\n\nThis changeset allows ownCloud to run with pretty URLs, they will be used if mod_rewrite and mod_env are available. This means basically that the `index.php` in the URL is not shown to the user anymore.\n\nAlso the not deprecated functions to generate URLs have been modified to support this behaviour, old functions such as `filePath` will still behave as before for compatibility reasons.\n\nExamples:\nhttp://localhost/owncloud/index.php/s/AIDyKbxiRZWAAjP => http://localhost/owncloud/s/AIDyKbxiRZWAAjP\nhttp://localhost/owncloud/index.php/apps/files/ => http://localhost/owncloud/apps/files/\n\nDue to the way our CSS and JS is structured the .htaccess uses some hacks for the final result but could be worse... And I was just annoyed by all that users crying for the removal of `index.php` ;-)","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/2515cb17be18da4aee32167259ee75fdc7a5a56b"},{"sha":"8931ba4a0d574a05cf4415f2556bdd3ee0388ba9","author":{"email":"65adda4326914576405c9e3a62f4904d96573863@owncloud.com","name":"Lukas Reschke"},"message":"Merge pull request #14081 from owncloud/use-pretty-urls\n\nSupport pretty URLs","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/8931ba4a0d574a05cf4415f2556bdd3ee0388ba9"},{"sha":"b00db2c9334874c6062a143de2a6b76b44dca35d","author":{"email":"16f2d52edcaec44656b79b18c493fd900b9ac5db@owncloud.com","name":"Roeland Jago Douma"},"message":"DI in avatar code\n\n* DI in avatar code\n* Use the node API\n* More unit tests\n* Unit tests no longer require DB","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/b00db2c9334874c6062a143de2a6b76b44dca35d"},{"sha":"9baa96a5aebbef629db90ea9cd71f84c5ff6e6c7","author":{"email":"16f2d52edcaec44656b79b18c493fd900b9ac5db@users.noreply.github.com","name":"Roeland Douma"},"message":"Merge pull request #20883 from owncloud/avatar_di\n\nDI in avatar code","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/9baa96a5aebbef629db90ea9cd71f84c5ff6e6c7"},{"sha":"4f4b91a9ecc265d7501934bb40c1632a30afc7f5","author":{"email":"4751712426bbecfda99947034b6176c396757e74@tmit.eu","name":"Jenkins for ownCloud"},"message":"[tx-robot] updated from transifex","distinct":false,"url":"https://api.github.com/repos/owncloud/core/commits/4f4b91a9ecc265d7501934bb40c1632a30afc7f5"},{"sha":"c91192fb7324c246d3af95ae83ad9ac1ae0a8ec1","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Adding system addressbook for users of this instance - a occ command is supplied for synchronizing","distinct":true,"url":"https://api.github.com/repos/owncloud/core/commits/c91192fb7324c246d3af95ae83ad9ac1ae0a8ec1"},{"sha":"dad6470baa817a796de7e1b6d27daf6d24519096","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Add IUser::getAvatarImage() for easy access","distinct":true,"url":"https://api.github.com/repos/owncloud/core/commits/dad6470baa817a796de7e1b6d27daf6d24519096"},{"sha":"dcfd089a6caed18f040284802cb3fe7e5475c4c5","author":{"email":"cfd42f3b0bf19c6e35e778ede1fa394bf5d63c15@tmit.eu","name":"Thomas Müller"},"message":"Adding a second principal backend which holds system principals - as of now only one principals/system/system","distinct":true,"url":"https://api.github.com/repos/owncloud/core/commits/dcfd089a6caed18f040284802cb3fe7e5475c4c5"}]}