{"action":"created","comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/41797915","id":41797915,"diff_hunk":"@@ -1585,7 +1607,7 @@ def sanity_check_step(self, custom_paths=None, custom_commands=None, extension=F\n                 found = False\n                 for name in xs:\n                     path = os.path.join(self.installdir, name)\n-                    if os.path.exists(path):\n+                    if check_fn(path):","path":"easybuild/framework/easyblock.py","position":41,"original_position":41,"commit_id":"a17eb36ae418f5a4d6a8eb92b6b398f3266df740","original_commit_id":"a17eb36ae418f5a4d6a8eb92b6b398f3266df740","user":{"login":"boegel","id":620876,"avatar_url":"https://avatars.githubusercontent.com/u/620876?v=3","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"body":"this is indeed a bug, this fix is also included in #1388 (which doesn't mean it shouldn't be included here)\r\n\r\nmaybe we should make this a separate PR though, to make the bug fix stand out; it may have some fallout, i.e. causing sanity checks to fail on empty directories where they didn't before (they should have though)","created_at":"2015-10-12T20:30:39Z","updated_at":"2015-10-12T20:30:39Z","html_url":"https://github.com/hpcugent/easybuild-framework/pull/1424#discussion_r41797915","pull_request_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/41797915"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1424#discussion_r41797915"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424"}}},"pull_request":{"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424","id":47458780,"html_url":"https://github.com/hpcugent/easybuild-framework/pull/1424","diff_url":"https://github.com/hpcugent/easybuild-framework/pull/1424.diff","patch_url":"https://github.com/hpcugent/easybuild-framework/pull/1424.patch","issue_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1424","number":1424,"state":"open","locked":false,"title":"generic sanity-checking of libraries","user":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?v=3","gravatar_id":"","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"body":"A new key (`'libs'`) is introduced potentially holding a list of maps specifying libraries to be checked in a generic way. Each library map must have a `'name'` and a `'kind'` while the latter must either be `'shared'` or `'static'`. The name is only the library name without path and suffix.\r\n\r\nExample:\r\nTo test for a library `libmy.so`, which might either be in `lib/` or in `lib64/`:\r\n\r\n    sanity_check_paths = {\r\n      'libs': [{'name': 'libmy', 'kind': 'shared'}]\r\n    }\r\n\r\nThis will look for the following files:\r\n\r\n    lib/libmy.so\r\n    lib/libmy.dyn\r\n    lib64/libmy.so\r\n    lib64/libmy.dyn\r\n\r\nThis is done by generating a tuple of these, which is appended to the `sanity_check_paths['files']` list.\r\n\r\nTodo:\r\n- [ ] make the library directory and library suffixes configurable\r\n- [ ] think of better way to specify the libraries in the easyconfig file\r\n\r\nBTW: The first commit is a potential bug fix. The lambdas specified in `path_keys_and_check` where never used.","created_at":"2015-10-12T20:04:52Z","updated_at":"2015-10-12T20:30:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d08a0958f837fa5fefb8727bf764c219c877a6ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424/commits","review_comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424/comments","review_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1424/comments","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/a17eb36ae418f5a4d6a8eb92b6b398f3266df740","head":{"label":"torbjoernk:feature/sanity-check-libs","ref":"feature/sanity-check-libs","sha":"a17eb36ae418f5a4d6a8eb92b6b398f3266df740","user":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?v=3","gravatar_id":"","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"repo":{"id":43093190,"name":"easybuild-framework","full_name":"torbjoernk/easybuild-framework","owner":{"login":"torbjoernk","id":1336965,"avatar_url":"https://avatars.githubusercontent.com/u/1336965?v=3","gravatar_id":"","url":"https://api.github.com/users/torbjoernk","html_url":"https://github.com/torbjoernk","followers_url":"https://api.github.com/users/torbjoernk/followers","following_url":"https://api.github.com/users/torbjoernk/following{/other_user}","gists_url":"https://api.github.com/users/torbjoernk/gists{/gist_id}","starred_url":"https://api.github.com/users/torbjoernk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torbjoernk/subscriptions","organizations_url":"https://api.github.com/users/torbjoernk/orgs","repos_url":"https://api.github.com/users/torbjoernk/repos","events_url":"https://api.github.com/users/torbjoernk/events{/privacy}","received_events_url":"https://api.github.com/users/torbjoernk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/torbjoernk/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":true,"url":"https://api.github.com/repos/torbjoernk/easybuild-framework","forks_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/forks","keys_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/events","assignees_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/merges","archive_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/torbjoernk/easybuild-framework/releases{/id}","created_at":"2015-09-24T21:09:04Z","updated_at":"2015-09-24T21:09:07Z","pushed_at":"2015-10-12T20:04:16Z","git_url":"git://github.com/torbjoernk/easybuild-framework.git","ssh_url":"git@github.com:torbjoernk/easybuild-framework.git","clone_url":"https://github.com/torbjoernk/easybuild-framework.git","svn_url":"https://github.com/torbjoernk/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":10655,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"hpcugent:develop","ref":"develop","sha":"b2767c074869ea4eda59e327073a2672e3e52a5f","user":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"repo":{"id":3662176,"name":"easybuild-framework","full_name":"hpcugent/easybuild-framework","owner":{"login":"hpcugent","id":1515263,"avatar_url":"https://avatars.githubusercontent.com/u/1515263?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcugent","html_url":"https://github.com/hpcugent","followers_url":"https://api.github.com/users/hpcugent/followers","following_url":"https://api.github.com/users/hpcugent/following{/other_user}","gists_url":"https://api.github.com/users/hpcugent/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcugent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcugent/subscriptions","organizations_url":"https://api.github.com/users/hpcugent/orgs","repos_url":"https://api.github.com/users/hpcugent/repos","events_url":"https://api.github.com/users/hpcugent/events{/privacy}","received_events_url":"https://api.github.com/users/hpcugent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcugent/easybuild-framework","description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","fork":false,"url":"https://api.github.com/repos/hpcugent/easybuild-framework","forks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/forks","keys_url":"https://api.github.com/repos/hpcugent/easybuild-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcugent/easybuild-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcugent/easybuild-framework/teams","hooks_url":"https://api.github.com/repos/hpcugent/easybuild-framework/hooks","issue_events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/events{/number}","events_url":"https://api.github.com/repos/hpcugent/easybuild-framework/events","assignees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/assignees{/user}","branches_url":"https://api.github.com/repos/hpcugent/easybuild-framework/branches{/branch}","tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/tags","blobs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcugent/easybuild-framework/languages","stargazers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/stargazers","contributors_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contributors","subscribers_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscribers","subscription_url":"https://api.github.com/repos/hpcugent/easybuild-framework/subscription","commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcugent/easybuild-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcugent/easybuild-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcugent/easybuild-framework/contents/{+path}","compare_url":"https://api.github.com/repos/hpcugent/easybuild-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcugent/easybuild-framework/merges","archive_url":"https://api.github.com/repos/hpcugent/easybuild-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcugent/easybuild-framework/downloads","issues_url":"https://api.github.com/repos/hpcugent/easybuild-framework/issues{/number}","pulls_url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcugent/easybuild-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcugent/easybuild-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcugent/easybuild-framework/labels{/name}","releases_url":"https://api.github.com/repos/hpcugent/easybuild-framework/releases{/id}","created_at":"2012-03-08T17:07:43Z","updated_at":"2015-09-22T09:21:13Z","pushed_at":"2015-10-12T20:16:40Z","git_url":"git://github.com/hpcugent/easybuild-framework.git","ssh_url":"git@github.com:hpcugent/easybuild-framework.git","clone_url":"https://github.com/hpcugent/easybuild-framework.git","svn_url":"https://github.com/hpcugent/easybuild-framework","homepage":"http://hpcugent.github.com/easybuild/","size":17369,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":275,"forks":68,"open_issues":275,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/1424"},"issue":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1424"},"comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/issues/1424/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/1424/commits"},"statuses":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/statuses/a17eb36ae418f5a4d6a8eb92b6b398f3266df740"}}}}