{"action":"created","comment":{"url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/comments/29803267","id":29803267,"diff_hunk":"@@ -233,7 +232,7 @@ def num_columns(self):\n \n     def headers(self):\n         \"\"\"original ordered list of spreadsheet headers\"\"\"\n-        return self.csvreader.fieldnames\n+        return self.csvreader.unicode_fieldnames","path":"mcm/reader.py","position":13,"original_position":13,"commit_id":"9fbbcc77c2fc087b84bf9ecbcfc5b23984c86e34","original_commit_id":"9fbbcc77c2fc087b84bf9ecbcfc5b23984c86e34","user":{"login":"alecklandgraf","id":2336595,"avatar_url":"https://avatars.githubusercontent.com/u/2336595?v=3","gravatar_id":"","url":"https://api.github.com/users/alecklandgraf","html_url":"https://github.com/alecklandgraf","followers_url":"https://api.github.com/users/alecklandgraf/followers","following_url":"https://api.github.com/users/alecklandgraf/following{/other_user}","gists_url":"https://api.github.com/users/alecklandgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/alecklandgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecklandgraf/subscriptions","organizations_url":"https://api.github.com/users/alecklandgraf/orgs","repos_url":"https://api.github.com/users/alecklandgraf/repos","events_url":"https://api.github.com/users/alecklandgraf/events{/privacy}","received_events_url":"https://api.github.com/users/alecklandgraf/received_events","type":"User","site_admin":false},"body":"Also need to consider if the bad headers come from a xls file and the `headers` method from ExcelReader","created_at":"2015-05-06T21:18:45Z","updated_at":"2015-05-06T21:18:45Z","html_url":"https://github.com/buildingenergy/mcm-core/pull/37#discussion_r29803267","pull_request_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/comments/29803267"},"html":{"href":"https://github.com/buildingenergy/mcm-core/pull/37#discussion_r29803267"},"pull_request":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37","id":34860770,"html_url":"https://github.com/buildingenergy/mcm-core/pull/37","diff_url":"https://github.com/buildingenergy/mcm-core/pull/37.diff","patch_url":"https://github.com/buildingenergy/mcm-core/pull/37.patch","issue_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/37","number":37,"state":"open","locked":false,"title":"use unicode_fieldnames like everywhere else","user":{"login":"maackle","id":896230,"avatar_url":"https://avatars.githubusercontent.com/u/896230?v=3","gravatar_id":"","url":"https://api.github.com/users/maackle","html_url":"https://github.com/maackle","followers_url":"https://api.github.com/users/maackle/followers","following_url":"https://api.github.com/users/maackle/following{/other_user}","gists_url":"https://api.github.com/users/maackle/gists{/gist_id}","starred_url":"https://api.github.com/users/maackle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maackle/subscriptions","organizations_url":"https://api.github.com/users/maackle/orgs","repos_url":"https://api.github.com/users/maackle/repos","events_url":"https://api.github.com/users/maackle/events{/privacy}","received_events_url":"https://api.github.com/users/maackle/received_events","type":"User","site_admin":false},"body":"`clean_super_scripts` modifies `unicode_fieldnames`, not `fieldnames`. Either we should use `unicode_fieldnames` exclusively, or also expose a `unicode_headers` method to expose this.","created_at":"2015-05-06T21:12:29Z","updated_at":"2015-05-06T21:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e22da765c7d071c62d9d3b68e2a5230ab5836492","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37/commits","review_comments_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37/comments","review_comment_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/37/comments","statuses_url":"https://api.github.com/repos/buildingenergy/mcm-core/statuses/9fbbcc77c2fc087b84bf9ecbcfc5b23984c86e34","head":{"label":"buildingenergy:fix/unicode-headers","ref":"fix/unicode-headers","sha":"9fbbcc77c2fc087b84bf9ecbcfc5b23984c86e34","user":{"login":"buildingenergy","id":1799875,"avatar_url":"https://avatars.githubusercontent.com/u/1799875?v=3","gravatar_id":"","url":"https://api.github.com/users/buildingenergy","html_url":"https://github.com/buildingenergy","followers_url":"https://api.github.com/users/buildingenergy/followers","following_url":"https://api.github.com/users/buildingenergy/following{/other_user}","gists_url":"https://api.github.com/users/buildingenergy/gists{/gist_id}","starred_url":"https://api.github.com/users/buildingenergy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildingenergy/subscriptions","organizations_url":"https://api.github.com/users/buildingenergy/orgs","repos_url":"https://api.github.com/users/buildingenergy/repos","events_url":"https://api.github.com/users/buildingenergy/events{/privacy}","received_events_url":"https://api.github.com/users/buildingenergy/received_events","type":"Organization","site_admin":false},"repo":{"id":15062616,"name":"mcm-core","full_name":"buildingenergy/mcm-core","owner":{"login":"buildingenergy","id":1799875,"avatar_url":"https://avatars.githubusercontent.com/u/1799875?v=3","gravatar_id":"","url":"https://api.github.com/users/buildingenergy","html_url":"https://github.com/buildingenergy","followers_url":"https://api.github.com/users/buildingenergy/followers","following_url":"https://api.github.com/users/buildingenergy/following{/other_user}","gists_url":"https://api.github.com/users/buildingenergy/gists{/gist_id}","starred_url":"https://api.github.com/users/buildingenergy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildingenergy/subscriptions","organizations_url":"https://api.github.com/users/buildingenergy/orgs","repos_url":"https://api.github.com/users/buildingenergy/repos","events_url":"https://api.github.com/users/buildingenergy/events{/privacy}","received_events_url":"https://api.github.com/users/buildingenergy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildingenergy/mcm-core","description":"Core MCM - Map Clean Merge","fork":false,"url":"https://api.github.com/repos/buildingenergy/mcm-core","forks_url":"https://api.github.com/repos/buildingenergy/mcm-core/forks","keys_url":"https://api.github.com/repos/buildingenergy/mcm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildingenergy/mcm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildingenergy/mcm-core/teams","hooks_url":"https://api.github.com/repos/buildingenergy/mcm-core/hooks","issue_events_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/events{/number}","events_url":"https://api.github.com/repos/buildingenergy/mcm-core/events","assignees_url":"https://api.github.com/repos/buildingenergy/mcm-core/assignees{/user}","branches_url":"https://api.github.com/repos/buildingenergy/mcm-core/branches{/branch}","tags_url":"https://api.github.com/repos/buildingenergy/mcm-core/tags","blobs_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildingenergy/mcm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/buildingenergy/mcm-core/languages","stargazers_url":"https://api.github.com/repos/buildingenergy/mcm-core/stargazers","contributors_url":"https://api.github.com/repos/buildingenergy/mcm-core/contributors","subscribers_url":"https://api.github.com/repos/buildingenergy/mcm-core/subscribers","subscription_url":"https://api.github.com/repos/buildingenergy/mcm-core/subscription","commits_url":"https://api.github.com/repos/buildingenergy/mcm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildingenergy/mcm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildingenergy/mcm-core/contents/{+path}","compare_url":"https://api.github.com/repos/buildingenergy/mcm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildingenergy/mcm-core/merges","archive_url":"https://api.github.com/repos/buildingenergy/mcm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildingenergy/mcm-core/downloads","issues_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues{/number}","pulls_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/buildingenergy/mcm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/buildingenergy/mcm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildingenergy/mcm-core/labels{/name}","releases_url":"https://api.github.com/repos/buildingenergy/mcm-core/releases{/id}","created_at":"2013-12-10T00:03:15Z","updated_at":"2015-04-29T16:10:05Z","pushed_at":"2015-05-06T21:12:29Z","git_url":"git://github.com/buildingenergy/mcm-core.git","ssh_url":"git@github.com:buildingenergy/mcm-core.git","clone_url":"https://github.com/buildingenergy/mcm-core.git","svn_url":"https://github.com/buildingenergy/mcm-core","homepage":null,"size":1243,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"buildingenergy:master","ref":"master","sha":"edeaed8879331ff1425688ecdfdf01c6859146f7","user":{"login":"buildingenergy","id":1799875,"avatar_url":"https://avatars.githubusercontent.com/u/1799875?v=3","gravatar_id":"","url":"https://api.github.com/users/buildingenergy","html_url":"https://github.com/buildingenergy","followers_url":"https://api.github.com/users/buildingenergy/followers","following_url":"https://api.github.com/users/buildingenergy/following{/other_user}","gists_url":"https://api.github.com/users/buildingenergy/gists{/gist_id}","starred_url":"https://api.github.com/users/buildingenergy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildingenergy/subscriptions","organizations_url":"https://api.github.com/users/buildingenergy/orgs","repos_url":"https://api.github.com/users/buildingenergy/repos","events_url":"https://api.github.com/users/buildingenergy/events{/privacy}","received_events_url":"https://api.github.com/users/buildingenergy/received_events","type":"Organization","site_admin":false},"repo":{"id":15062616,"name":"mcm-core","full_name":"buildingenergy/mcm-core","owner":{"login":"buildingenergy","id":1799875,"avatar_url":"https://avatars.githubusercontent.com/u/1799875?v=3","gravatar_id":"","url":"https://api.github.com/users/buildingenergy","html_url":"https://github.com/buildingenergy","followers_url":"https://api.github.com/users/buildingenergy/followers","following_url":"https://api.github.com/users/buildingenergy/following{/other_user}","gists_url":"https://api.github.com/users/buildingenergy/gists{/gist_id}","starred_url":"https://api.github.com/users/buildingenergy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildingenergy/subscriptions","organizations_url":"https://api.github.com/users/buildingenergy/orgs","repos_url":"https://api.github.com/users/buildingenergy/repos","events_url":"https://api.github.com/users/buildingenergy/events{/privacy}","received_events_url":"https://api.github.com/users/buildingenergy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildingenergy/mcm-core","description":"Core MCM - Map Clean Merge","fork":false,"url":"https://api.github.com/repos/buildingenergy/mcm-core","forks_url":"https://api.github.com/repos/buildingenergy/mcm-core/forks","keys_url":"https://api.github.com/repos/buildingenergy/mcm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildingenergy/mcm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildingenergy/mcm-core/teams","hooks_url":"https://api.github.com/repos/buildingenergy/mcm-core/hooks","issue_events_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/events{/number}","events_url":"https://api.github.com/repos/buildingenergy/mcm-core/events","assignees_url":"https://api.github.com/repos/buildingenergy/mcm-core/assignees{/user}","branches_url":"https://api.github.com/repos/buildingenergy/mcm-core/branches{/branch}","tags_url":"https://api.github.com/repos/buildingenergy/mcm-core/tags","blobs_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildingenergy/mcm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/buildingenergy/mcm-core/languages","stargazers_url":"https://api.github.com/repos/buildingenergy/mcm-core/stargazers","contributors_url":"https://api.github.com/repos/buildingenergy/mcm-core/contributors","subscribers_url":"https://api.github.com/repos/buildingenergy/mcm-core/subscribers","subscription_url":"https://api.github.com/repos/buildingenergy/mcm-core/subscription","commits_url":"https://api.github.com/repos/buildingenergy/mcm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildingenergy/mcm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildingenergy/mcm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildingenergy/mcm-core/contents/{+path}","compare_url":"https://api.github.com/repos/buildingenergy/mcm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildingenergy/mcm-core/merges","archive_url":"https://api.github.com/repos/buildingenergy/mcm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildingenergy/mcm-core/downloads","issues_url":"https://api.github.com/repos/buildingenergy/mcm-core/issues{/number}","pulls_url":"https://api.github.com/repos/buildingenergy/mcm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/buildingenergy/mcm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/buildingenergy/mcm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildingenergy/mcm-core/labels{/name}","releases_url":"https://api.github.com/repos/buildingenergy/mcm-core/releases{/id}","created_at":"2013-12-10T00:03:15Z","updated_at":"2015-04-29T16:10:05Z","pushed_at":"2015-05-06T21:12:29Z","git_url":"git://github.com/buildingenergy/mcm-core.git","ssh_url":"git@github.com:buildingenergy/mcm-core.git","clone_url":"https://github.com/buildingenergy/mcm-core.git","svn_url":"https://github.com/buildingenergy/mcm-core","homepage":null,"size":1243,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37"},"html":{"href":"https://github.com/buildingenergy/mcm-core/pull/37"},"issue":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/issues/37"},"comments":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/buildingenergy/mcm-core/statuses/9fbbcc77c2fc087b84bf9ecbcfc5b23984c86e34"}}}}