{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/30407142","id":30407142,"diff_hunk":"@@ -559,26 +559,24 @@ stop_component() {\n \n     eval $stopcmd\n \n+    unlock ${LOCKPATH}\n+    removePid ${PIDPATH}\n+\n     RESULT=0\n-    local counter=0\n-    while [[ $RESULT -eq 0 && $counter -le 20 ]]; do\n+    local waittime=30","path":"initfiles/bash/etc/init.d/hpcc_common.in","position":10,"original_position":10,"commit_id":"dd25812623f7f9efefd30b1f5dfee0ff54bc1e9b","original_commit_id":"dd25812623f7f9efefd30b1f5dfee0ff54bc1e9b","user":{"login":"jakesmith","id":902700,"avatar_url":"https://avatars.githubusercontent.com/u/902700?v=3","gravatar_id":"","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User","site_admin":false},"body":"Could this limit be passed as a parameter?\r\nDali on large systems can take longer than 30secs to shutdown.","created_at":"2015-05-15T13:22:23Z","updated_at":"2015-05-15T13:22:23Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319#discussion_r30407142","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/30407142"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319#discussion_r30407142"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319","id":35447356,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7319","number":7319,"state":"open","locked":false,"title":"HPCC-13497 Moved unlock, removePid.  Modified RESULT test, in hpcc_common -> stop_component ","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"body":"Mark made a necessary change recently that fixed a looping issue in 5.2.0 -> 5.2.2.  In this change we now use check_status as the primary way of seeing the health of a component within the loop.  It made everything much simpler, but it was causing issues where a RETURN value of 4, could mean that a process was still alive, but it would give a success message.\r\n\r\nI modified the RESULT test to only show success if the value was '1' (Stopped in healthy state.) and I moved the unlock and removePid to before the loop so it won't immediately fail.  This is what was causing issues I was seeing in 5.4 where dali and dfuserver were having issues on restart (because they were still trying to shut down) and I initially thought it was a problem with the stopdali and dfuserver action=STOP calls.  The bug that Srinivas Sivasubramanian had the other day with 5.2.0 helped me isolate and find the issue when I was testing 5.2.2.\r\n\r\nSigned-off-by: Michael Gardner <Michael.Gardner@lexisnexis.com>","created_at":"2015-05-14T18:24:18Z","updated_at":"2015-05-15T13:22:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544827b373e01090915cff40eb590a28e9c207d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7319/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/dd25812623f7f9efefd30b1f5dfee0ff54bc1e9b","head":{"label":"Michael-Gardner:hpcc-13497-5.2.4","ref":"hpcc-13497-5.2.4","sha":"dd25812623f7f9efefd30b1f5dfee0ff54bc1e9b","user":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"repo":{"id":24113512,"name":"HPCC-Platform","full_name":"Michael-Gardner/HPCC-Platform","owner":{"login":"Michael-Gardner","id":7481082,"avatar_url":"https://avatars.githubusercontent.com/u/7481082?v=3","gravatar_id":"","url":"https://api.github.com/users/Michael-Gardner","html_url":"https://github.com/Michael-Gardner","followers_url":"https://api.github.com/users/Michael-Gardner/followers","following_url":"https://api.github.com/users/Michael-Gardner/following{/other_user}","gists_url":"https://api.github.com/users/Michael-Gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/Michael-Gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Michael-Gardner/subscriptions","organizations_url":"https://api.github.com/users/Michael-Gardner/orgs","repos_url":"https://api.github.com/users/Michael-Gardner/repos","events_url":"https://api.github.com/users/Michael-Gardner/events{/privacy}","received_events_url":"https://api.github.com/users/Michael-Gardner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Michael-Gardner/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform","forks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/Michael-Gardner/HPCC-Platform/releases{/id}","created_at":"2014-09-16T19:06:46Z","updated_at":"2015-03-30T15:05:42Z","pushed_at":"2015-05-14T17:36:26Z","git_url":"git://github.com/Michael-Gardner/HPCC-Platform.git","ssh_url":"git@github.com:Michael-Gardner/HPCC-Platform.git","clone_url":"https://github.com/Michael-Gardner/HPCC-Platform.git","svn_url":"https://github.com/Michael-Gardner/HPCC-Platform","homepage":"track.hpccsystems.com","size":146280,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"candidate-5.2.0"}},"base":{"label":"hpcc-systems:candidate-5.2.4","ref":"candidate-5.2.4","sha":"fcb415458fa35d8af2cdb7df1731f1076ba16262","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-05-12T23:24:59Z","pushed_at":"2015-05-15T12:35:01Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":335948,"stargazers_count":250,"watchers_count":250,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":426,"forks":108,"open_issues":426,"watchers":250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7319"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7319"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7319/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7319/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/dd25812623f7f9efefd30b1f5dfee0ff54bc1e9b"}}}}