{"action":"closed","number":4515,"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/4515","id":46108759,"html_url":"https://github.com/divio/django-cms/pull/4515","diff_url":"https://github.com/divio/django-cms/pull/4515.diff","patch_url":"https://github.com/divio/django-cms/pull/4515.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/4515","number":4515,"state":"closed","locked":false,"title":"Proposal: sharper icon font using fixed 16px font-size","user":{"login":"SachaMPS","id":305877,"avatar_url":"https://avatars.githubusercontent.com/u/305877?v=3","gravatar_id":"","url":"https://api.github.com/users/SachaMPS","html_url":"https://github.com/SachaMPS","followers_url":"https://api.github.com/users/SachaMPS/followers","following_url":"https://api.github.com/users/SachaMPS/following{/other_user}","gists_url":"https://api.github.com/users/SachaMPS/gists{/gist_id}","starred_url":"https://api.github.com/users/SachaMPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SachaMPS/subscriptions","organizations_url":"https://api.github.com/users/SachaMPS/orgs","repos_url":"https://api.github.com/users/SachaMPS/repos","events_url":"https://api.github.com/users/SachaMPS/events{/privacy}","received_events_url":"https://api.github.com/users/SachaMPS/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\nthis is just a proposal top optimize the icons on non retina displays. How this approach works is crucial to consider if you want to merge that changes in.\r\n\r\n- All icons are 16px tall in css\r\n- Different icon sizes are made via the svg file NOT via font-size.\r\n- The svg files are normalized by hand to contain only icons which use a 512px grid (Exception: logo.svg)\r\n- This way the text rendering does not produce blurry lines as long as you aligned the svg paths properly\r\n- The $...icon-size definitions in the scss are obsolete. Instead 16px is hardcoded in _iconfont.scss\r\n\r\nThe benefit are sharper icons in some cases. Just an example:\r\n![image](https://cloud.githubusercontent.com/assets/305877/10125195/9974b570-656b-11e5-88e8-3f9df15106ba.png)\r\n\r\n\r\nThe obvious downside of this approach is that you must align the icons properly and adjust the to your needs. The second downside is that I recommend to use different icon files for different font sizes if an icon is required in different sizes. \r\n\r\nI can explain how to do that if you want. Actually it's quite simple... Use a 512px Artboard in Illustrator. Subdivide the artboard by 32px with 16px subdivisions. If you now want an 12px tall icon you just have to calculate: 32px * 12px = 384px and apply that dimensions to the icon. Adjust some points while \"snap to grid\" is activated and voila :)\r\n\r\n\r\n\r\n","created_at":"2015-09-27T21:00:57Z","updated_at":"2015-09-30T07:52:18Z","closed_at":"2015-09-30T07:52:18Z","merged_at":null,"merge_commit_sha":"55871b37adee6f275daea3b3147ffcaa876f6fce","assignee":null,"milestone":{"url":"https://api.github.com/repos/divio/django-cms/milestones/33","html_url":"https://github.com/divio/django-cms/milestones/3.2","labels_url":"https://api.github.com/repos/divio/django-cms/milestones/33/labels","id":1007077,"number":33,"title":"3.2","description":"Next feature release","creator":{"login":"yakky","id":714711,"avatar_url":"https://avatars.githubusercontent.com/u/714711?v=3","gravatar_id":"","url":"https://api.github.com/users/yakky","html_url":"https://github.com/yakky","followers_url":"https://api.github.com/users/yakky/followers","following_url":"https://api.github.com/users/yakky/following{/other_user}","gists_url":"https://api.github.com/users/yakky/gists{/gist_id}","starred_url":"https://api.github.com/users/yakky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakky/subscriptions","organizations_url":"https://api.github.com/users/yakky/orgs","repos_url":"https://api.github.com/users/yakky/repos","events_url":"https://api.github.com/users/yakky/events{/privacy}","received_events_url":"https://api.github.com/users/yakky/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":70,"state":"open","created_at":"2015-03-05T07:27:27Z","updated_at":"2015-09-30T07:52:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/4515/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/4515/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/4515/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/346727de17b671a19f36d19d5d38100044810324","head":{"label":"SachaMPS:preview","ref":"preview","sha":"346727de17b671a19f36d19d5d38100044810324","user":{"login":"SachaMPS","id":305877,"avatar_url":"https://avatars.githubusercontent.com/u/305877?v=3","gravatar_id":"","url":"https://api.github.com/users/SachaMPS","html_url":"https://github.com/SachaMPS","followers_url":"https://api.github.com/users/SachaMPS/followers","following_url":"https://api.github.com/users/SachaMPS/following{/other_user}","gists_url":"https://api.github.com/users/SachaMPS/gists{/gist_id}","starred_url":"https://api.github.com/users/SachaMPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SachaMPS/subscriptions","organizations_url":"https://api.github.com/users/SachaMPS/orgs","repos_url":"https://api.github.com/users/SachaMPS/repos","events_url":"https://api.github.com/users/SachaMPS/events{/privacy}","received_events_url":"https://api.github.com/users/SachaMPS/received_events","type":"User","site_admin":false},"repo":{"id":42269591,"name":"django-cms","full_name":"SachaMPS/django-cms","owner":{"login":"SachaMPS","id":305877,"avatar_url":"https://avatars.githubusercontent.com/u/305877?v=3","gravatar_id":"","url":"https://api.github.com/users/SachaMPS","html_url":"https://github.com/SachaMPS","followers_url":"https://api.github.com/users/SachaMPS/followers","following_url":"https://api.github.com/users/SachaMPS/following{/other_user}","gists_url":"https://api.github.com/users/SachaMPS/gists{/gist_id}","starred_url":"https://api.github.com/users/SachaMPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SachaMPS/subscriptions","organizations_url":"https://api.github.com/users/SachaMPS/orgs","repos_url":"https://api.github.com/users/SachaMPS/repos","events_url":"https://api.github.com/users/SachaMPS/events{/privacy}","received_events_url":"https://api.github.com/users/SachaMPS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SachaMPS/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":true,"url":"https://api.github.com/repos/SachaMPS/django-cms","forks_url":"https://api.github.com/repos/SachaMPS/django-cms/forks","keys_url":"https://api.github.com/repos/SachaMPS/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SachaMPS/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SachaMPS/django-cms/teams","hooks_url":"https://api.github.com/repos/SachaMPS/django-cms/hooks","issue_events_url":"https://api.github.com/repos/SachaMPS/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/SachaMPS/django-cms/events","assignees_url":"https://api.github.com/repos/SachaMPS/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/SachaMPS/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/SachaMPS/django-cms/tags","blobs_url":"https://api.github.com/repos/SachaMPS/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SachaMPS/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SachaMPS/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/SachaMPS/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SachaMPS/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/SachaMPS/django-cms/languages","stargazers_url":"https://api.github.com/repos/SachaMPS/django-cms/stargazers","contributors_url":"https://api.github.com/repos/SachaMPS/django-cms/contributors","subscribers_url":"https://api.github.com/repos/SachaMPS/django-cms/subscribers","subscription_url":"https://api.github.com/repos/SachaMPS/django-cms/subscription","commits_url":"https://api.github.com/repos/SachaMPS/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/SachaMPS/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/SachaMPS/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/SachaMPS/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/SachaMPS/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/SachaMPS/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SachaMPS/django-cms/merges","archive_url":"https://api.github.com/repos/SachaMPS/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SachaMPS/django-cms/downloads","issues_url":"https://api.github.com/repos/SachaMPS/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/SachaMPS/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/SachaMPS/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/SachaMPS/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SachaMPS/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/SachaMPS/django-cms/releases{/id}","created_at":"2015-09-10T20:40:44Z","updated_at":"2015-09-10T20:40:47Z","pushed_at":"2015-09-28T20:02:28Z","git_url":"git://github.com/SachaMPS/django-cms.git","ssh_url":"git@github.com:SachaMPS/django-cms.git","clone_url":"https://github.com/SachaMPS/django-cms.git","svn_url":"https://github.com/SachaMPS/django-cms","homepage":"http://www.django-cms.org","size":48660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"divio:preview","ref":"preview","sha":"836d18471ca7b2aa5c1c29b4d03594afeebaf171","user":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"avatar_url":"https://avatars.githubusercontent.com/u/117904?v=3","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","created_at":"2009-03-05T10:14:18Z","updated_at":"2015-09-30T07:24:55Z","pushed_at":"2015-09-30T07:38:48Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":69004,"stargazers_count":3669,"watchers_count":3669,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1416,"mirror_url":null,"open_issues_count":289,"forks":1416,"open_issues":289,"watchers":3669,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4515"},"html":{"href":"https://github.com/divio/django-cms/pull/4515"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/4515"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/4515/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4515/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/4515/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/346727de17b671a19f36d19d5d38100044810324"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":11,"review_comments":0,"commits":1,"additions":210,"deletions":109,"changed_files":29}}