{"action":"created","issue":{"url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/1","labels_url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/1/comments","events_url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/1/events","html_url":"https://github.com/alexk111/ngImgCrop/pull/1","id":38950097,"number":1,"title":"non-square selections","user":{"login":"chirgwin","id":165955,"avatar_url":"https://avatars.githubusercontent.com/u/165955?v=3","gravatar_id":"","url":"https://api.github.com/users/chirgwin","html_url":"https://github.com/chirgwin","followers_url":"https://api.github.com/users/chirgwin/followers","following_url":"https://api.github.com/users/chirgwin/following{/other_user}","gists_url":"https://api.github.com/users/chirgwin/gists{/gist_id}","starred_url":"https://api.github.com/users/chirgwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chirgwin/subscriptions","organizations_url":"https://api.github.com/users/chirgwin/orgs","repos_url":"https://api.github.com/users/chirgwin/repos","events_url":"https://api.github.com/users/chirgwin/events{/privacy}","received_events_url":"https://api.github.com/users/chirgwin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":68,"created_at":"2014-07-29T01:14:51Z","updated_at":"2015-10-26T15:26:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexk111/ngImgCrop/pulls/1","html_url":"https://github.com/alexk111/ngImgCrop/pull/1","diff_url":"https://github.com/alexk111/ngImgCrop/pull/1.diff","patch_url":"https://github.com/alexk111/ngImgCrop/pull/1.patch"},"body":"@alexk111 For your consideration, I've made some changes to allow for (non-square) rectangular selections (which I plan on implementing soon, along with some tests).  This mostly involved moving geometry getters/setters away from being center-point centric.  Behavior of current circle and square selections should be identical.\r\n\r\nI've also added a property for binding the image data (RGBa pixel array), since we have a need to further process pixels from the crop selection.  The alternative would be to externally convert the existing imageURI back into an RGBa pixel array, which we could live with."},"comment":{"url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/comments/151174161","html_url":"https://github.com/alexk111/ngImgCrop/pull/1#issuecomment-151174161","issue_url":"https://api.github.com/repos/alexk111/ngImgCrop/issues/1","id":151174161,"user":{"login":"CrackerakiUA","id":6815721,"avatar_url":"https://avatars.githubusercontent.com/u/6815721?v=3","gravatar_id":"","url":"https://api.github.com/users/CrackerakiUA","html_url":"https://github.com/CrackerakiUA","followers_url":"https://api.github.com/users/CrackerakiUA/followers","following_url":"https://api.github.com/users/CrackerakiUA/following{/other_user}","gists_url":"https://api.github.com/users/CrackerakiUA/gists{/gist_id}","starred_url":"https://api.github.com/users/CrackerakiUA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrackerakiUA/subscriptions","organizations_url":"https://api.github.com/users/CrackerakiUA/orgs","repos_url":"https://api.github.com/users/CrackerakiUA/repos","events_url":"https://api.github.com/users/CrackerakiUA/events{/privacy}","received_events_url":"https://api.github.com/users/CrackerakiUA/received_events","type":"User","site_admin":false},"created_at":"2015-10-26T15:26:30Z","updated_at":"2015-10-26T15:26:30Z","body":"@hugomn ok, i see your point. I have added it as future fix, if you want subscribe on mine fork, i will fix it as soon as possible. "}}