{"action":"closed","number":667,"pull_request":{"url":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667","id":35243282,"html_url":"https://github.com/CoolProp/CoolProp/pull/667","diff_url":"https://github.com/CoolProp/CoolProp/pull/667.diff","patch_url":"https://github.com/CoolProp/CoolProp/pull/667.patch","issue_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/667","number":667,"state":"closed","locked":false,"title":"If -DCMAKE_BUILD_TYPE is set on the cmake command line, do not overwr…","user":{"login":"postmath","id":8881134,"avatar_url":"https://avatars.githubusercontent.com/u/8881134?v=3","gravatar_id":"","url":"https://api.github.com/users/postmath","html_url":"https://github.com/postmath","followers_url":"https://api.github.com/users/postmath/followers","following_url":"https://api.github.com/users/postmath/following{/other_user}","gists_url":"https://api.github.com/users/postmath/gists{/gist_id}","starred_url":"https://api.github.com/users/postmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmath/subscriptions","organizations_url":"https://api.github.com/users/postmath/orgs","repos_url":"https://api.github.com/users/postmath/repos","events_url":"https://api.github.com/users/postmath/events{/privacy}","received_events_url":"https://api.github.com/users/postmath/received_events","type":"User","site_admin":false},"body":"…ite it.\r\n\r\nCurrently, there is some logic that says if COOLPROP_VERSION_REVISION is \"dev\",\r\nthen the build type is set to Debug by default, otherwise to Release. With\r\nthis change, that logic will only trigger if CMAKE_BUILD_TYPE was not set\r\nalready (e.g. on the command line with a -D option). The behaviour is\r\noverridden by the COOLPROP_RELEASE and COOLPROP_DEBUG variables.\r\n\r\nThis makes it easier to integrate the CoolProp build into build systems that build\r\nmultiple projects and expect to be able to set CMAKE_BUILD_TYPE. (Maplesoft's\r\nis an example of such build systems.)","created_at":"2015-05-12T16:12:05Z","updated_at":"2015-05-12T17:06:20Z","closed_at":"2015-05-12T17:06:20Z","merged_at":"2015-05-12T17:06:20Z","merge_commit_sha":"0a7725b85dad43f46dec7b3fc67b141d7f939b5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667/commits","review_comments_url":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667/comments","review_comment_url":"https://api.github.com/repos/CoolProp/CoolProp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/667/comments","statuses_url":"https://api.github.com/repos/CoolProp/CoolProp/statuses/5c3561a8d8a75c4d3bafbee519f28b0553a16380","head":{"label":"postmath:do-not-overwrite-cmake-build-type","ref":"do-not-overwrite-cmake-build-type","sha":"5c3561a8d8a75c4d3bafbee519f28b0553a16380","user":{"login":"postmath","id":8881134,"avatar_url":"https://avatars.githubusercontent.com/u/8881134?v=3","gravatar_id":"","url":"https://api.github.com/users/postmath","html_url":"https://github.com/postmath","followers_url":"https://api.github.com/users/postmath/followers","following_url":"https://api.github.com/users/postmath/following{/other_user}","gists_url":"https://api.github.com/users/postmath/gists{/gist_id}","starred_url":"https://api.github.com/users/postmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmath/subscriptions","organizations_url":"https://api.github.com/users/postmath/orgs","repos_url":"https://api.github.com/users/postmath/repos","events_url":"https://api.github.com/users/postmath/events{/privacy}","received_events_url":"https://api.github.com/users/postmath/received_events","type":"User","site_admin":false},"repo":{"id":34334674,"name":"CoolProp","full_name":"postmath/CoolProp","owner":{"login":"postmath","id":8881134,"avatar_url":"https://avatars.githubusercontent.com/u/8881134?v=3","gravatar_id":"","url":"https://api.github.com/users/postmath","html_url":"https://github.com/postmath","followers_url":"https://api.github.com/users/postmath/followers","following_url":"https://api.github.com/users/postmath/following{/other_user}","gists_url":"https://api.github.com/users/postmath/gists{/gist_id}","starred_url":"https://api.github.com/users/postmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmath/subscriptions","organizations_url":"https://api.github.com/users/postmath/orgs","repos_url":"https://api.github.com/users/postmath/repos","events_url":"https://api.github.com/users/postmath/events{/privacy}","received_events_url":"https://api.github.com/users/postmath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/postmath/CoolProp","description":"Thermophysical properties for the masses","fork":true,"url":"https://api.github.com/repos/postmath/CoolProp","forks_url":"https://api.github.com/repos/postmath/CoolProp/forks","keys_url":"https://api.github.com/repos/postmath/CoolProp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmath/CoolProp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmath/CoolProp/teams","hooks_url":"https://api.github.com/repos/postmath/CoolProp/hooks","issue_events_url":"https://api.github.com/repos/postmath/CoolProp/issues/events{/number}","events_url":"https://api.github.com/repos/postmath/CoolProp/events","assignees_url":"https://api.github.com/repos/postmath/CoolProp/assignees{/user}","branches_url":"https://api.github.com/repos/postmath/CoolProp/branches{/branch}","tags_url":"https://api.github.com/repos/postmath/CoolProp/tags","blobs_url":"https://api.github.com/repos/postmath/CoolProp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmath/CoolProp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmath/CoolProp/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmath/CoolProp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmath/CoolProp/statuses/{sha}","languages_url":"https://api.github.com/repos/postmath/CoolProp/languages","stargazers_url":"https://api.github.com/repos/postmath/CoolProp/stargazers","contributors_url":"https://api.github.com/repos/postmath/CoolProp/contributors","subscribers_url":"https://api.github.com/repos/postmath/CoolProp/subscribers","subscription_url":"https://api.github.com/repos/postmath/CoolProp/subscription","commits_url":"https://api.github.com/repos/postmath/CoolProp/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmath/CoolProp/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmath/CoolProp/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmath/CoolProp/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmath/CoolProp/contents/{+path}","compare_url":"https://api.github.com/repos/postmath/CoolProp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmath/CoolProp/merges","archive_url":"https://api.github.com/repos/postmath/CoolProp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmath/CoolProp/downloads","issues_url":"https://api.github.com/repos/postmath/CoolProp/issues{/number}","pulls_url":"https://api.github.com/repos/postmath/CoolProp/pulls{/number}","milestones_url":"https://api.github.com/repos/postmath/CoolProp/milestones{/number}","notifications_url":"https://api.github.com/repos/postmath/CoolProp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmath/CoolProp/labels{/name}","releases_url":"https://api.github.com/repos/postmath/CoolProp/releases{/id}","created_at":"2015-04-21T15:11:44Z","updated_at":"2015-04-22T17:53:36Z","pushed_at":"2015-05-12T16:10:09Z","git_url":"git://github.com/postmath/CoolProp.git","ssh_url":"git@github.com:postmath/CoolProp.git","clone_url":"https://github.com/postmath/CoolProp.git","svn_url":"https://github.com/postmath/CoolProp","homepage":"www.coolprop.org","size":15540,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CoolProp:master","ref":"master","sha":"594f995b42b3aa44bb72045f1bcce62ed4f1578c","user":{"login":"CoolProp","id":6862239,"avatar_url":"https://avatars.githubusercontent.com/u/6862239?v=3","gravatar_id":"","url":"https://api.github.com/users/CoolProp","html_url":"https://github.com/CoolProp","followers_url":"https://api.github.com/users/CoolProp/followers","following_url":"https://api.github.com/users/CoolProp/following{/other_user}","gists_url":"https://api.github.com/users/CoolProp/gists{/gist_id}","starred_url":"https://api.github.com/users/CoolProp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoolProp/subscriptions","organizations_url":"https://api.github.com/users/CoolProp/orgs","repos_url":"https://api.github.com/users/CoolProp/repos","events_url":"https://api.github.com/users/CoolProp/events{/privacy}","received_events_url":"https://api.github.com/users/CoolProp/received_events","type":"Organization","site_admin":false},"repo":{"id":19775824,"name":"CoolProp","full_name":"CoolProp/CoolProp","owner":{"login":"CoolProp","id":6862239,"avatar_url":"https://avatars.githubusercontent.com/u/6862239?v=3","gravatar_id":"","url":"https://api.github.com/users/CoolProp","html_url":"https://github.com/CoolProp","followers_url":"https://api.github.com/users/CoolProp/followers","following_url":"https://api.github.com/users/CoolProp/following{/other_user}","gists_url":"https://api.github.com/users/CoolProp/gists{/gist_id}","starred_url":"https://api.github.com/users/CoolProp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoolProp/subscriptions","organizations_url":"https://api.github.com/users/CoolProp/orgs","repos_url":"https://api.github.com/users/CoolProp/repos","events_url":"https://api.github.com/users/CoolProp/events{/privacy}","received_events_url":"https://api.github.com/users/CoolProp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CoolProp/CoolProp","description":"Thermophysical properties for the masses","fork":false,"url":"https://api.github.com/repos/CoolProp/CoolProp","forks_url":"https://api.github.com/repos/CoolProp/CoolProp/forks","keys_url":"https://api.github.com/repos/CoolProp/CoolProp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoolProp/CoolProp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoolProp/CoolProp/teams","hooks_url":"https://api.github.com/repos/CoolProp/CoolProp/hooks","issue_events_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/events{/number}","events_url":"https://api.github.com/repos/CoolProp/CoolProp/events","assignees_url":"https://api.github.com/repos/CoolProp/CoolProp/assignees{/user}","branches_url":"https://api.github.com/repos/CoolProp/CoolProp/branches{/branch}","tags_url":"https://api.github.com/repos/CoolProp/CoolProp/tags","blobs_url":"https://api.github.com/repos/CoolProp/CoolProp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoolProp/CoolProp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoolProp/CoolProp/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoolProp/CoolProp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoolProp/CoolProp/statuses/{sha}","languages_url":"https://api.github.com/repos/CoolProp/CoolProp/languages","stargazers_url":"https://api.github.com/repos/CoolProp/CoolProp/stargazers","contributors_url":"https://api.github.com/repos/CoolProp/CoolProp/contributors","subscribers_url":"https://api.github.com/repos/CoolProp/CoolProp/subscribers","subscription_url":"https://api.github.com/repos/CoolProp/CoolProp/subscription","commits_url":"https://api.github.com/repos/CoolProp/CoolProp/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoolProp/CoolProp/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoolProp/CoolProp/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoolProp/CoolProp/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoolProp/CoolProp/contents/{+path}","compare_url":"https://api.github.com/repos/CoolProp/CoolProp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoolProp/CoolProp/merges","archive_url":"https://api.github.com/repos/CoolProp/CoolProp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoolProp/CoolProp/downloads","issues_url":"https://api.github.com/repos/CoolProp/CoolProp/issues{/number}","pulls_url":"https://api.github.com/repos/CoolProp/CoolProp/pulls{/number}","milestones_url":"https://api.github.com/repos/CoolProp/CoolProp/milestones{/number}","notifications_url":"https://api.github.com/repos/CoolProp/CoolProp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoolProp/CoolProp/labels{/name}","releases_url":"https://api.github.com/repos/CoolProp/CoolProp/releases{/id}","created_at":"2014-05-14T10:43:50Z","updated_at":"2015-05-08T04:31:28Z","pushed_at":"2015-05-12T17:06:20Z","git_url":"git://github.com/CoolProp/CoolProp.git","ssh_url":"git@github.com:CoolProp/CoolProp.git","clone_url":"https://github.com/CoolProp/CoolProp.git","svn_url":"https://github.com/CoolProp/CoolProp","homepage":"www.coolprop.org","size":24766,"stargazers_count":35,"watchers_count":35,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":43,"forks":17,"open_issues":43,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667"},"html":{"href":"https://github.com/CoolProp/CoolProp/pull/667"},"issue":{"href":"https://api.github.com/repos/CoolProp/CoolProp/issues/667"},"comments":{"href":"https://api.github.com/repos/CoolProp/CoolProp/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/CoolProp/CoolProp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CoolProp/CoolProp/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/CoolProp/CoolProp/statuses/5c3561a8d8a75c4d3bafbee519f28b0553a16380"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jowr","id":769593,"avatar_url":"https://avatars.githubusercontent.com/u/769593?v=3","gravatar_id":"","url":"https://api.github.com/users/jowr","html_url":"https://github.com/jowr","followers_url":"https://api.github.com/users/jowr/followers","following_url":"https://api.github.com/users/jowr/following{/other_user}","gists_url":"https://api.github.com/users/jowr/gists{/gist_id}","starred_url":"https://api.github.com/users/jowr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jowr/subscriptions","organizations_url":"https://api.github.com/users/jowr/orgs","repos_url":"https://api.github.com/users/jowr/repos","events_url":"https://api.github.com/users/jowr/events{/privacy}","received_events_url":"https://api.github.com/users/jowr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":4,"changed_files":1}}