{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/41651796","id":41651796,"diff_hunk":"@@ -0,0 +1,52 @@\n+'use strict';\n+\n+require('../common');\n+const assert = require('assert');\n+\n+// v8 fails silently if string length > v8::String::kMaxLength\n+// v8::String::kMaxLength defined in v8.h\n+const kStringMaxLength = process.binding('buffer').kStringMaxLength;\n+\n+try {\n+  new Buffer(kStringMaxLength * 3);\n+} catch(e) {\n+  assert.equal(e.message, 'Invalid array buffer length');\n+  console.log(\n+      '1..0 # Skipped: intensive toString tests due to memory confinements');\n+  return;\n+}\n+\n+const buf1 = new Buffer(kStringMaxLength + 1);\n+\n+assert.throws(function() {\n+  buf1.toString();\n+}, /toString failed|Invalid array buffer length/);\n+\n+assert.throws(function() {\n+  buf1.toString('ascii');\n+}, /toString failed/);\n+\n+assert.throws(function() {\n+  buf1.toString('utf8');\n+}, /toString failed/);","path":"test/parallel/test-stringbytes-external-exceed-max-by-1.js","position":31,"original_position":31,"commit_id":"6a8a8b5351d54c9ede7bf62c0b231446fbda34cd","original_commit_id":"6a8a8b5351d54c9ede7bf62c0b231446fbda34cd","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars.githubusercontent.com/u/289174?v=3","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"Interestingly, this will still throw as expected even if there are multibyte characters in the string. It must have something to do with v8 internals.\r\n\r\nOn the side, I don't think that `utf8`, `hex` and `base64` are necessary. `utf8` for reasons similar to the above. `hex` and `base64` will never be shorter than `binary`. It may be useful to add `ucs2`, but not sure if doing the larger allocation will break the test on pi.","created_at":"2015-10-09T16:49:16Z","updated_at":"2015-10-09T16:49:16Z","html_url":"https://github.com/nodejs/node/pull/3287#discussion_r41651796","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3287","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/41651796"},"html":{"href":"https://github.com/nodejs/node/pull/3287#discussion_r41651796"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3287"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3287","id":47213980,"html_url":"https://github.com/nodejs/node/pull/3287","diff_url":"https://github.com/nodejs/node/pull/3287.diff","patch_url":"https://github.com/nodejs/node/pull/3287.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3287","number":3287,"state":"open","locked":false,"title":"test: parallelize long-running test","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"I got terribly sad seeing `test-stringbytes-external` fail on Raspberry Pi in CI again and again and again, so I did the easiest laziest thing I could think of to fix it, which was to split the long-running test into multiple files so it wouldn't time out.\r\n\r\nFixes (hopefull) #2370","created_at":"2015-10-08T22:20:11Z","updated_at":"2015-10-09T16:49:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51628fe8051f3a937aab00f3bed9fc072679bb9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3287/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3287/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3287/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/6a8a8b5351d54c9ede7bf62c0b231446fbda34cd","head":{"label":"Trott:borked-test","ref":"borked-test","sha":"6a8a8b5351d54c9ede7bf62c0b231446fbda34cd","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"repo":{"id":35707182,"name":"io.js","full_name":"Trott/io.js","owner":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Trott/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/Trott/io.js","forks_url":"https://api.github.com/repos/Trott/io.js/forks","keys_url":"https://api.github.com/repos/Trott/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Trott/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Trott/io.js/teams","hooks_url":"https://api.github.com/repos/Trott/io.js/hooks","issue_events_url":"https://api.github.com/repos/Trott/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/Trott/io.js/events","assignees_url":"https://api.github.com/repos/Trott/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/Trott/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/Trott/io.js/tags","blobs_url":"https://api.github.com/repos/Trott/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Trott/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Trott/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Trott/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Trott/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Trott/io.js/languages","stargazers_url":"https://api.github.com/repos/Trott/io.js/stargazers","contributors_url":"https://api.github.com/repos/Trott/io.js/contributors","subscribers_url":"https://api.github.com/repos/Trott/io.js/subscribers","subscription_url":"https://api.github.com/repos/Trott/io.js/subscription","commits_url":"https://api.github.com/repos/Trott/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Trott/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Trott/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Trott/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Trott/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/Trott/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Trott/io.js/merges","archive_url":"https://api.github.com/repos/Trott/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Trott/io.js/downloads","issues_url":"https://api.github.com/repos/Trott/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/Trott/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Trott/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Trott/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Trott/io.js/labels{/name}","releases_url":"https://api.github.com/repos/Trott/io.js/releases{/id}","created_at":"2015-05-16T02:50:59Z","updated_at":"2015-05-16T02:51:03Z","pushed_at":"2015-10-09T05:36:23Z","git_url":"git://github.com/Trott/io.js.git","ssh_url":"git@github.com:Trott/io.js.git","clone_url":"https://github.com/Trott/io.js.git","svn_url":"https://github.com/Trott/io.js","homepage":"https://iojs.org","size":145664,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"01908d0a9a0db65b91270327850ae03ba8e0da16","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-10-09T16:01:09Z","pushed_at":"2015-10-09T16:44:03Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":367198,"stargazers_count":15957,"watchers_count":15957,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1500,"mirror_url":null,"open_issues_count":505,"forks":1500,"open_issues":505,"watchers":15957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3287"},"html":{"href":"https://github.com/nodejs/node/pull/3287"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3287"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3287/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3287/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3287/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/6a8a8b5351d54c9ede7bf62c0b231446fbda34cd"}}}}