{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/22717547","id":22717547,"diff_hunk":"@@ -1079,21 +1177,28 @@ sub clearAllConfigs {\n     $class->cache->remove_multi(\\@stored_config_files);\n }\n \n-sub updateCacheControl {\n-    my ($dontCreate) = @_;\n-    if ( !-e $cache_control_file && !$dontCreate) {\n-        my $fh;\n-        open($fh,\">$cache_control_file\") or die \"Can't create $cache_control_file\\nPlease run 'pfcmd fixpermissions'\";\n-        close($fh);\n-    }\n-    if(-e $cache_control_file) {\n-        sysopen(my $fh,$cache_control_file,O_RDWR | O_CREAT);\n-        POSIX::2008::futimens(fileno $fh);\n-        close($fh);\n-    }\n+sub _ExpireFile {","path":"lib/pf/config/cached.pm","position":640,"original_position":640,"commit_id":"53adedc7734884ecf1b267c157755fa030f9c94c","original_commit_id":"53adedc7734884ecf1b267c157755fa030f9c94c","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"pod doc for the sub ?","created_at":"2015-01-09T14:20:08Z","updated_at":"2015-01-09T14:20:08Z","html_url":"https://github.com/inverse-inc/packetfence/pull/292#discussion_r22717547","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/22717547"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/292#discussion_r22717547"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292","id":25443268,"html_url":"https://github.com/inverse-inc/packetfence/pull/292","diff_url":"https://github.com/inverse-inc/packetfence/pull/292.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/292.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/292","number":292,"state":"open","locked":false,"title":"Ensure that the reloading of a config file only happenes once","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Description\n-----------\nEnsure that configuration files are only reloaded once to avoid reparsing\n\nImpacts\n-------\nThis impact all services\nbin/pfcmd configreload\nbin/pfcmd configreload hard\n\n\nDelete branch after merge\n-------------------------\nNO","created_at":"2014-12-03T19:09:17Z","updated_at":"2015-01-09T14:20:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80783f347d692c4f17021053e5fbd564cace3b36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/{number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/292/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/53adedc7734884ecf1b267c157755fa030f9c94c","head":{"label":"jrouzierinverse:feature/control-file-per-config-cached","ref":"feature/control-file-per-config-cached","sha":"53adedc7734884ecf1b267c157755fa030f9c94c","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"repo":{"id":6552051,"name":"packetfence","full_name":"jrouzierinverse/packetfence","owner":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrouzierinverse/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/jrouzierinverse/packetfence","forks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/forks","keys_url":"https://api.github.com/repos/jrouzierinverse/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrouzierinverse/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrouzierinverse/packetfence/teams","hooks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/hooks","issue_events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/events","assignees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/jrouzierinverse/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/tags","blobs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrouzierinverse/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/jrouzierinverse/packetfence/languages","stargazers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/stargazers","contributors_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contributors","subscribers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscribers","subscription_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscription","commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrouzierinverse/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/comments/{number}","contents_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/jrouzierinverse/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrouzierinverse/packetfence/merges","archive_url":"https://api.github.com/repos/jrouzierinverse/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrouzierinverse/packetfence/downloads","issues_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/jrouzierinverse/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/jrouzierinverse/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/jrouzierinverse/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrouzierinverse/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/jrouzierinverse/packetfence/releases{/id}","created_at":"2012-11-05T21:28:44Z","updated_at":"2014-09-04T14:49:59Z","pushed_at":"2015-01-08T16:44:50Z","git_url":"git://github.com/jrouzierinverse/packetfence.git","ssh_url":"git@github.com:jrouzierinverse/packetfence.git","clone_url":"https://github.com/jrouzierinverse/packetfence.git","svn_url":"https://github.com/jrouzierinverse/packetfence","homepage":"http://www.packetfence.org","size":85676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"4c28a229d8d7a6e4b2f00ce42f2c7803f4b2e399","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments/{number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","created_at":"2012-03-01T20:21:13Z","updated_at":"2015-01-08T20:29:19Z","pushed_at":"2015-01-09T12:57:20Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":102871,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":24,"forks":54,"open_issues":24,"watchers":99,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/292"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/292"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/53adedc7734884ecf1b267c157755fa030f9c94c"}}}}