{"push_id":734400049,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"4b869e24cb5c850e43cdf9f025d145abf1fe8c5d","before":"a0eee6a88b418a75f89fe28edfc5b3eb1d8a6924","commits":[{"sha":"4b869e24cb5c850e43cdf9f025d145abf1fe8c5d","author":{"email":"86afcc11905a16fc7f55f47e39f4f6f84944afea@joyent.com","name":"Julien Gilli"},"message":"DOCKER-460: docker build should error out earlier if possible\n\nMove use(bodyParser) and use(queryParser) calls from being common\nhandlers defined in a centralized place (docker.js) to being\nspecific per route handlers.\n\nThis has the benefit of requiring anyone who needs to use these\npotentially costly handlers (especially bodyParser) to specify them\nexplicitly, and thus know what they're doing.\n\nFor instance, unimplemented endpoints such as /build do not use these\nhandlers anymore.\n\nIt has the nice side effect of fixing issues like DOCKER-460, where\ndocker clients would send big payloads to unimplemented endpoints\nand get a \"NonImplemented\" error back after a long time spent by the\nserver processing the body of the request.\n\nThis commit also adds a test to make sure that the /build endpoint\ndoesn't execute the bodyParser handler. It looks in the logs for a\nspecific request ID and checks if the req.timers object contains a\nvalue for the parseBody property.\n\nPR: #45\nPR-URL: https://github.com/joyent/sdc-docker/pull/45\nReviewed-By: Trent Mick <trentm@gmail.com>\nReviewed-By: Orlando Vazquez <ovazquez@gmail.com>","distinct":true,"url":"https://api.github.com/repos/joyent/sdc-docker/commits/4b869e24cb5c850e43cdf9f025d145abf1fe8c5d"}]}