{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/11","labels_url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/11/comments","events_url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/11/events","html_url":"https://github.com/PowerShell/xHyper-V/pull/11","id":87964896,"number":11,"title":"Fixes #4","user":{"login":"iainbrighton","id":7023258,"avatar_url":"https://avatars.githubusercontent.com/u/7023258?v=3","gravatar_id":"","url":"https://api.github.com/users/iainbrighton","html_url":"https://github.com/iainbrighton","followers_url":"https://api.github.com/users/iainbrighton/followers","following_url":"https://api.github.com/users/iainbrighton/following{/other_user}","gists_url":"https://api.github.com/users/iainbrighton/gists{/gist_id}","starred_url":"https://api.github.com/users/iainbrighton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainbrighton/subscriptions","organizations_url":"https://api.github.com/users/iainbrighton/orgs","repos_url":"https://api.github.com/users/iainbrighton/repos","events_url":"https://api.github.com/users/iainbrighton/events{/privacy}","received_events_url":"https://api.github.com/users/iainbrighton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PowerShell/xHyper-V/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-13T08:48:50Z","updated_at":"2015-06-17T21:55:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/xHyper-V/pulls/11","html_url":"https://github.com/PowerShell/xHyper-V/pull/11","diff_url":"https://github.com/PowerShell/xHyper-V/pull/11.diff","patch_url":"https://github.com/PowerShell/xHyper-V/pull/11.patch"},"body":"* Fixes VM generation implementation.\r\n* Changed Generation property to Uint32 and updated .schema.mof accordingly.\r\n* Throws during Test-TargetResource if Generation = 2 and VhdPath = *.vhd\r\n* Updated README.md to reflect the property type change.\r\n* Added test coverage"},"comment":{"url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/comments/112962243","html_url":"https://github.com/PowerShell/xHyper-V/pull/11#issuecomment-112962243","issue_url":"https://api.github.com/repos/PowerShell/xHyper-V/issues/11","id":112962243,"user":{"login":"KrishnaV-MSFT","id":10604558,"avatar_url":"https://avatars.githubusercontent.com/u/10604558?v=3","gravatar_id":"","url":"https://api.github.com/users/KrishnaV-MSFT","html_url":"https://github.com/KrishnaV-MSFT","followers_url":"https://api.github.com/users/KrishnaV-MSFT/followers","following_url":"https://api.github.com/users/KrishnaV-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/KrishnaV-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/KrishnaV-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrishnaV-MSFT/subscriptions","organizations_url":"https://api.github.com/users/KrishnaV-MSFT/orgs","repos_url":"https://api.github.com/users/KrishnaV-MSFT/repos","events_url":"https://api.github.com/users/KrishnaV-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/KrishnaV-MSFT/received_events","type":"User","site_admin":false},"created_at":"2015-06-17T21:55:58Z","updated_at":"2015-06-17T21:55:58Z","body":"Thanks @iainbrighton for the change. Looks like you have changed the generation property to UInt32 from string (with validateset \"vhd\" or \"vhdx\"). Wont this make the configuration scripts little harder to read. Also, existing configuration scripts that use this DSC resource might break with this change. Have you thought about that.\r\n\r\nThanks\r\nKrishna"}}