{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/39457108","id":39457108,"diff_hunk":"@@ -695,6 +702,75 @@ void deleteApp(Id.Application appId, ApplicationSpecification spec) throws Excep\n     }\n   }\n \n+  /**\n+   * Delete the business metadata for the application and the programs.\n+   */\n+  private void deleteAppBusinessMetadata(Id.Application appId) {\n+    // Remove metadata for the Application itself.\n+    businessMds.removeMetadata(appId);\n+\n+    // Remove business metadata for the programs of the Application\n+    // TODO: Need to remove this we support prefix search of metadata type.\n+    ApplicationSpecification appSpec = store.getApplication(appId);\n+    for (ProgramType programType : ProgramType.values()) {\n+      deleteProgramBusinessMetadataForApp(programType, appId, appSpec);\n+    }\n+  }\n+\n+  /**\n+   *  Delete the business metadata for a program type in an application.\n+   *  TODO: Need to remove this we support prefix search of metadata type.\n+   */\n+  private void deleteProgramBusinessMetadataForApp(ProgramType programType, Id.Application appId,\n+                                                   ApplicationSpecification appSpec) {\n+    Set<String> programNames = null;\n+    switch (programType) {","path":"cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/services/ApplicationLifecycleService.java","position":77,"original_position":77,"commit_id":"7b0af52f066c1c007eb15d746a5560804570db89","original_commit_id":"7b0af52f066c1c007eb15d746a5560804570db89","user":{"login":"henry-cask","id":11763016,"avatar_url":"https://avatars.githubusercontent.com/u/11763016?v=3","gravatar_id":"","url":"https://api.github.com/users/henry-cask","html_url":"https://github.com/henry-cask","followers_url":"https://api.github.com/users/henry-cask/followers","following_url":"https://api.github.com/users/henry-cask/following{/other_user}","gists_url":"https://api.github.com/users/henry-cask/gists{/gist_id}","starred_url":"https://api.github.com/users/henry-cask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henry-cask/subscriptions","organizations_url":"https://api.github.com/users/henry-cask/orgs","repos_url":"https://api.github.com/users/henry-cask/repos","events_url":"https://api.github.com/users/henry-cask/events{/privacy}","received_events_url":"https://api.github.com/users/henry-cask/received_events","type":"User","site_admin":false},"body":"Sounds good to me. Will make the change","created_at":"2015-09-14T22:50:35Z","updated_at":"2015-09-14T22:50:35Z","html_url":"https://github.com/caskdata/cdap/pull/3933#discussion_r39457108","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/3933","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/39457108"},"html":{"href":"https://github.com/caskdata/cdap/pull/3933#discussion_r39457108"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3933"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/3933","id":44977064,"html_url":"https://github.com/caskdata/cdap/pull/3933","diff_url":"https://github.com/caskdata/cdap/pull/3933.diff","patch_url":"https://github.com/caskdata/cdap/pull/3933.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/3933","number":3933,"state":"open","locked":false,"title":"CDAP-3605 Intercept entitiy deletion to also remove metadata","user":{"login":"henry-cask","id":11763016,"avatar_url":"https://avatars.githubusercontent.com/u/11763016?v=3","gravatar_id":"","url":"https://api.github.com/users/henry-cask","html_url":"https://github.com/henry-cask","followers_url":"https://api.github.com/users/henry-cask/followers","following_url":"https://api.github.com/users/henry-cask/following{/other_user}","gists_url":"https://api.github.com/users/henry-cask/gists{/gist_id}","starred_url":"https://api.github.com/users/henry-cask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henry-cask/subscriptions","organizations_url":"https://api.github.com/users/henry-cask/orgs","repos_url":"https://api.github.com/users/henry-cask/repos","events_url":"https://api.github.com/users/henry-cask/events{/privacy}","received_events_url":"https://api.github.com/users/henry-cask/received_events","type":"User","site_admin":false},"body":"Intercept the entity deletion of App, Program, Dataset, and Stream so it also remove the corresponding business metadata (property and tags).\r\n\r\nAdd Dataset service and transaction manager to some tests.","created_at":"2015-09-14T20:32:11Z","updated_at":"2015-09-14T22:50:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76b8af6bc16655559b2e3e6c54b02f008246e4ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/3933/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/3933/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/3933/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/7b0af52f066c1c007eb15d746a5560804570db89","head":{"label":"caskdata:feature/CDAP-3605_delete_also_remove_metadata","ref":"feature/CDAP-3605_delete_also_remove_metadata","sha":"7b0af52f066c1c007eb15d746a5560804570db89","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-09-13T05:41:31Z","pushed_at":"2015-09-14T22:07:00Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":860881,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":67,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"7633852cc8906f82a8b10f6bdc3edddc2e16f289","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-09-13T05:41:31Z","pushed_at":"2015-09-14T22:07:00Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":860881,"stargazers_count":67,"watchers_count":67,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":67,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3933"},"html":{"href":"https://github.com/caskdata/cdap/pull/3933"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/3933"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/3933/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3933/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/3933/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/7b0af52f066c1c007eb15d746a5560804570db89"}}}}