{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/2","labels_url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/2/comments","events_url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/2/events","html_url":"https://github.com/JuliaGeometry/Orthotopes.jl/issues/2","id":62112511,"number":2,"title":"Code duplication between my code and this package","user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-16T15:19:32Z","updated_at":"2015-03-23T14:35:32Z","closed_at":null,"body":"I noticed that there seem to be some code duplication between stuff I wrote for usage in my kd tree package and this repo, see here:\r\n\r\nhttps://github.com/KristofferC/KDTrees.jl/blob/master/src/hyper_rec.jl\r\n\r\nWhat I have there is basically the same type definition as you have for the HyperRectangle and some functions for calculating the min/max distance between a point and a hyper rectangle and two hyper rectangle. They are currently only implemented for Euclidian distance. I also have a function for splitting a hyper rectangle in a given dimension at a given value.\r\n\r\nIf this were to be added to this package I could scrap my own code and just use this package instead.\r\n\r\nWould a PR with some of these distance functions be of any interest? "},"comment":{"url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/comments/85027571","html_url":"https://github.com/JuliaGeometry/Orthotopes.jl/issues/2#issuecomment-85027571","issue_url":"https://api.github.com/repos/JuliaGeometry/Orthotopes.jl/issues/2","id":85027571,"user":{"login":"KristofferC","id":1282691,"avatar_url":"https://avatars.githubusercontent.com/u/1282691?v=3","gravatar_id":"","url":"https://api.github.com/users/KristofferC","html_url":"https://github.com/KristofferC","followers_url":"https://api.github.com/users/KristofferC/followers","following_url":"https://api.github.com/users/KristofferC/following{/other_user}","gists_url":"https://api.github.com/users/KristofferC/gists{/gist_id}","starred_url":"https://api.github.com/users/KristofferC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristofferC/subscriptions","organizations_url":"https://api.github.com/users/KristofferC/orgs","repos_url":"https://api.github.com/users/KristofferC/repos","events_url":"https://api.github.com/users/KristofferC/events{/privacy}","received_events_url":"https://api.github.com/users/KristofferC/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T14:35:32Z","updated_at":"2015-03-23T14:35:32Z","body":"Yes, I meant hyper rectangles of course :) Orthotopes is a cool name but I think maybe it is a bit too cool for its own good. I had no idea what \"orthotope\" meant and it was just luck that I found out that this package was about rectangles in many dimensions.\r\n\r\nI will draft a PR that adds the distances and then we can discuss the specifics there.\r\n\r\nCheers."}}