{"push_id":869924958,"size":271,"distinct_size":271,"ref":"refs/heads/master","head":"ee3a825a1763a1fa397f538b9e1ef11c4dbba7a0","before":"5a8f2fe76950d10b4ccf71426468bf9df58e5b46","commits":[{"sha":"e14f59e9e6e66277b030ac0ffd728aa57e7a058c","author":{"email":"39eaa2729e56794ce3b9a1b5e543e44ad7c43d9c@gmail.com","name":"Chris Kühl"},"message":"Avoid allocating space for empty slice initialization\n\nIn order to avoid unnecessarily allocating memory in the case where the\nempty slice is never appended to, it's better to use the \"var name\n[]type\" form than the \"name := []type{}\" form.\n\nSee:\nhttps://github.com/coreos/docs/tree/master/golang","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/e14f59e9e6e66277b030ac0ffd728aa57e7a058c"},{"sha":"b0007ad0e4d3abe09a63d289f97934a79ab020d4","author":{"email":"27a2b4d30ab1e8df0ee4a9665ca6121633bce949@gmail.com","name":"Krzesimir Nowak"},"message":"build: Fix make clean for kvm flavor\n\nWe have to remove both /var and /var/run directories and the enter\nsymlink.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/b0007ad0e4d3abe09a63d289f97934a79ab020d4"},{"sha":"a8a23722be84c6401192774d9575adcfe45b46f3","author":{"email":"cf48a9f1523ee9907dfdfe7340b4d0a5425749a7@gmail.com","name":"Alban Crequy"},"message":"rkt: removePod: fix switch order\n\np.isExitedGarbage and p.isExited can both be true at the same time. Fix\nthe tests order in the switch, so we don't move a pod to garbage if it\nis already in garbage.\n\nFixes https://github.com/coreos/rkt/issues/1620","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/a8a23722be84c6401192774d9575adcfe45b46f3"},{"sha":"09209fc0971a9bc15f4930c7b25a70ef49a875b3","author":{"email":"cf48a9f1523ee9907dfdfe7340b4d0a5425749a7@gmail.com","name":"Alban Crequy"},"message":"ci: skip build if requested in the last commit message\n\nJust add \"[skip ci]\" somewhere in the commit message to skip the build\nin CI.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/09209fc0971a9bc15f4930c7b25a70ef49a875b3"},{"sha":"43f37abf4cc6805d3bf214239f62597a8a7fffb3","author":{"email":"388c977fd989d677f52fb2c10990be07ea0a3243@users.noreply.github.com","name":"Iago López Galeiras"},"message":"Merge pull request #1611 from krnowak/fix-make-clean-in-kvm\n\nbuild: Fix make clean for kvm flavor","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/43f37abf4cc6805d3bf214239f62597a8a7fffb3"},{"sha":"28675b2576fafb44941b0894f1d84dd591b2a5a5","author":{"email":"cf48a9f1523ee9907dfdfe7340b4d0a5425749a7@gmail.com","name":"Alban Crequy"},"message":"Merge pull request #1603 from alban/alban/doc-skip\n\nci: allow skipping ci runs via keyword in commit msg","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/28675b2576fafb44941b0894f1d84dd591b2a5a5"},{"sha":"4c3af486838497ac0d90c4b086dd189f68dcb229","author":{"email":"cf48a9f1523ee9907dfdfe7340b4d0a5425749a7@gmail.com","name":"Alban Crequy"},"message":"ci: don't skip all ci runs\n\nThe regexp for checking the keyword in the commit msg was bogus.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/4c3af486838497ac0d90c4b086dd189f68dcb229"},{"sha":"9841bbc35ec05586eaa75e90aa6fb102937cd576","author":{"email":"388c977fd989d677f52fb2c10990be07ea0a3243@users.noreply.github.com","name":"Iago López Galeiras"},"message":"Merge pull request #1623 from alban/alban/tests-no-skip\n\nci: don't skip all ci runs","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/9841bbc35ec05586eaa75e90aa6fb102937cd576"},{"sha":"0ff43311d47c8fdef158c3c509a488fa9db7a5f9","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: fix race in GoroutineAssistant\n\nUse a single channel for shutting down GoroutineAssistant, of type error\ninstead of string; in this way, Done() and Fatalf() are serialized and\ncan't race.\n\nFixes #1590","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/0ff43311d47c8fdef158c3c509a488fa9db7a5f9"},{"sha":"7255852f2e82626d162bbd8bef1da10af79173f4","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"testutils: properly return error from HttpGet\n\nCalling log.Fatal would circumvent proper test shutdown/error\npropagation. All callers are already checking for the error\nappropriately.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/7255852f2e82626d162bbd8bef1da10af79173f4"},{"sha":"586b3213077cece438a7ab251327d3da1aefa26a","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: fix waitgroup initialization in net tests","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/586b3213077cece438a7ab251327d3da1aefa26a"},{"sha":"93df7f42e0575bbcc6cad56bbf310aec6f73a6c5","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: use GoroutineAssistant for all operations\n\nAfter a GoroutineAssistant is initialised during tests, all operations\nthat might end in a testing.Fatal should be serialized through it.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/93df7f42e0575bbcc6cad56bbf310aec6f73a6c5"},{"sha":"6a22db07df544d127b3e955ec776e1e71cd45cd3","author":{"email":"27a2b4d30ab1e8df0ee4a9665ca6121633bce949@gmail.com","name":"Krzesimir Nowak"},"message":"functional tests: Return from a goroutine when the ACI server closes\n\nThe test ACI server closes both Msg and Stop channels on Close(). The\nStop channel never receives any messages - it is only used to listen\nfor service shutdown. The channel listening is done in serverHandler,\nwhich is run in its own goroutine. The Stop channel was used shortly\nbefore, but I wrongly removed it during review process. Because of\nthat, the function never returned and the goroutine was unnecessarily\nkept alive.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/6a22db07df544d127b3e955ec776e1e71cd45cd3"},{"sha":"f56e4a4d09fad87a74c26a993e34b5d18fa0f651","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: do not error on IsNotExist during cleanup","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/f56e4a4d09fad87a74c26a993e34b5d18fa0f651"},{"sha":"d385f9b6d78b7c2cab84423e4845871e5470ac0a","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: wait for other goroutines on teardown\n\nOtherwise there are issues when cleaning up the rkt context.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/d385f9b6d78b7c2cab84423e4845871e5470ac0a"},{"sha":"2efce153c356a724dda4d5808080a5a9f79b9b52","author":{"email":"0d47477beef1d882e8812885f3dcf66c4a47c346@gmail.com","name":"Jonathan Boulle"},"message":"tests: fix print logic after HTTP get","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/2efce153c356a724dda4d5808080a5a9f79b9b52"},{"sha":"727fef8279c19d8a7b187ab15e7570bd690853ff","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@stefanjunker.de","name":"Stefan Junker"},"message":"testutils/httputils: don't print the serve message before listening\n\nSince the tests that use the inspect binary rely on stdout parsing,\nprinting this too early will cause a race condition between the serve\nand test code. Simply moving the print to a point after the Listen()\ncall prevents that.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/727fef8279c19d8a7b187ab15e7570bd690853ff"},{"sha":"01634f70b151384fbe43da76fdb248838031498f","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@stefanjunker.de","name":"Stefan Junker"},"message":"testutils/goroutineassistant: fail on first error","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/01634f70b151384fbe43da76fdb248838031498f"},{"sha":"183288ae2bff669bb0165aeea5242f779dfa24fa","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@stefanjunker.de","name":"Stefan Junker"},"message":"goroutineassistant: fix Fatalf logic\n* don't branch since Fatalf will not return\n* exit the calling goroutine in Fatalf","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/183288ae2bff669bb0165aeea5242f779dfa24fa"},{"sha":"d234323e3a3db26319730f574ae9b59c2f70592f","author":{"email":"1d6e1cf70ec6f9ab28d3ea4b27a49a77654d370e@stefanjunker.de","name":"Stefan Junker"},"message":"tests: ctx cleanup/reset will shutdown registered children\n\nWhen tests spawn children and then cause a failure, they don't have the\nchance to wait for the children to complete. These tests are supposed to\nuse the ctx.RegisterChild function for every child so that ctx.cleanup()\nwill be able to handle child shutdown.","distinct":true,"url":"https://api.github.com/repos/Issacpeng/rkt/commits/d234323e3a3db26319730f574ae9b59c2f70592f"}]}