{"action":"created","issue":{"url":"https://api.github.com/repos/luvit/luv/issues/134","labels_url":"https://api.github.com/repos/luvit/luv/issues/134/labels{/name}","comments_url":"https://api.github.com/repos/luvit/luv/issues/134/comments","events_url":"https://api.github.com/repos/luvit/luv/issues/134/events","html_url":"https://github.com/luvit/luv/issues/134","id":66228782,"number":134,"title":"Building luv","user":{"login":"joerg-krause","id":6870896,"avatar_url":"https://avatars.githubusercontent.com/u/6870896?v=3","gravatar_id":"","url":"https://api.github.com/users/joerg-krause","html_url":"https://github.com/joerg-krause","followers_url":"https://api.github.com/users/joerg-krause/followers","following_url":"https://api.github.com/users/joerg-krause/following{/other_user}","gists_url":"https://api.github.com/users/joerg-krause/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg-krause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg-krause/subscriptions","organizations_url":"https://api.github.com/users/joerg-krause/orgs","repos_url":"https://api.github.com/users/joerg-krause/repos","events_url":"https://api.github.com/users/joerg-krause/events{/privacy}","received_events_url":"https://api.github.com/users/joerg-krause/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-03T21:12:13Z","updated_at":"2015-04-07T19:32:21Z","closed_at":"2015-04-07T19:32:21Z","body":"I'm trying to ease the library dependency for building luv with Buildroot. For this, I want to build luv with libuv and lujit as external libraries (not the one in deps/) as package dependency is handled by Buildroot. I added simple FindLibuv.cmake and FindLuaJIT.cmake files to locate the libraries with find_package.\r\n\r\nI would suggest to remove the `git submodule` part in both Makefiles and CMakelists.txt. For a build system it's not applicable and if a user follows the README it's not necessary.\r\n\r\nWhat I would do instead is: if find_package does not find a library in the build environment it will call the cmake files for the deps.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/luvit/luv/issues/comments/90707633","html_url":"https://github.com/luvit/luv/issues/134#issuecomment-90707633","issue_url":"https://api.github.com/repos/luvit/luv/issues/134","id":90707633,"user":{"login":"joerg-krause","id":6870896,"avatar_url":"https://avatars.githubusercontent.com/u/6870896?v=3","gravatar_id":"","url":"https://api.github.com/users/joerg-krause","html_url":"https://github.com/joerg-krause","followers_url":"https://api.github.com/users/joerg-krause/followers","following_url":"https://api.github.com/users/joerg-krause/following{/other_user}","gists_url":"https://api.github.com/users/joerg-krause/gists{/gist_id}","starred_url":"https://api.github.com/users/joerg-krause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joerg-krause/subscriptions","organizations_url":"https://api.github.com/users/joerg-krause/orgs","repos_url":"https://api.github.com/users/joerg-krause/repos","events_url":"https://api.github.com/users/joerg-krause/events{/privacy}","received_events_url":"https://api.github.com/users/joerg-krause/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T19:32:21Z","updated_at":"2015-04-07T19:32:21Z","body":"Another question. What is the reason for why luv is not install as libluv?"}}