{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/22939224","id":22939224,"diff_hunk":"@@ -18,14 +18,19 @@ export sin, cos, tan, sinh, cosh, tanh, asin, acos, atan,\n        hankelh1, hankelh2, hankelh1x, hankelh2x,\n        besseli, besselix, besselk, besselkx, besselh,\n        beta, lbeta, eta, zeta, polygamma, invdigamma, digamma, trigamma,\n-       erfinv, erfcinv, @evalpoly\n+       erfinv, erfcinv, @evalpoly,\n+       acos_fast, acosh_fast, asin_fast, asinh_fast, atan2_fast,","path":"base/math.jl","position":6,"original_position":6,"commit_id":"3008ae37bf80bcd1422867f8f99762c613786612","original_commit_id":"3008ae37bf80bcd1422867f8f99762c613786612","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars.githubusercontent.com/u/1120448?v=3","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"Right. Maybe a better solution would be to put these into a Base.Fastmath module?","created_at":"2015-01-14T14:31:59Z","updated_at":"2015-01-14T14:31:59Z","html_url":"https://github.com/JuliaLang/julia/pull/9759#discussion_r22939224","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9759","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/22939224"},"html":{"href":"https://github.com/JuliaLang/julia/pull/9759#discussion_r22939224"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9759"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/9759","id":27307396,"html_url":"https://github.com/JuliaLang/julia/pull/9759","diff_url":"https://github.com/JuliaLang/julia/pull/9759.diff","patch_url":"https://github.com/JuliaLang/julia/pull/9759.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/9759","number":9759,"state":"open","locked":false,"title":"Optimize some math functions with `@fastmath`","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"body":"Optimize math functions with `@fastmath`, update documentation, add test cases.","created_at":"2015-01-13T21:42:38Z","updated_at":"2015-01-14T14:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2099b5e7f24102b5955b7dfd163eaf250807a03f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9759/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/9759/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/9759/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/3008ae37bf80bcd1422867f8f99762c613786612","head":{"label":"eschnett:fast-math-2","ref":"fast-math-2","sha":"3008ae37bf80bcd1422867f8f99762c613786612","user":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"repo":{"id":23268889,"name":"julia","full_name":"eschnett/julia","owner":{"login":"eschnett","id":213514,"avatar_url":"https://avatars.githubusercontent.com/u/213514?v=3","gravatar_id":"","url":"https://api.github.com/users/eschnett","html_url":"https://github.com/eschnett","followers_url":"https://api.github.com/users/eschnett/followers","following_url":"https://api.github.com/users/eschnett/following{/other_user}","gists_url":"https://api.github.com/users/eschnett/gists{/gist_id}","starred_url":"https://api.github.com/users/eschnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eschnett/subscriptions","organizations_url":"https://api.github.com/users/eschnett/orgs","repos_url":"https://api.github.com/users/eschnett/repos","events_url":"https://api.github.com/users/eschnett/events{/privacy}","received_events_url":"https://api.github.com/users/eschnett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eschnett/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/eschnett/julia","forks_url":"https://api.github.com/repos/eschnett/julia/forks","keys_url":"https://api.github.com/repos/eschnett/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eschnett/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eschnett/julia/teams","hooks_url":"https://api.github.com/repos/eschnett/julia/hooks","issue_events_url":"https://api.github.com/repos/eschnett/julia/issues/events{/number}","events_url":"https://api.github.com/repos/eschnett/julia/events","assignees_url":"https://api.github.com/repos/eschnett/julia/assignees{/user}","branches_url":"https://api.github.com/repos/eschnett/julia/branches{/branch}","tags_url":"https://api.github.com/repos/eschnett/julia/tags","blobs_url":"https://api.github.com/repos/eschnett/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eschnett/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eschnett/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/eschnett/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eschnett/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/eschnett/julia/languages","stargazers_url":"https://api.github.com/repos/eschnett/julia/stargazers","contributors_url":"https://api.github.com/repos/eschnett/julia/contributors","subscribers_url":"https://api.github.com/repos/eschnett/julia/subscribers","subscription_url":"https://api.github.com/repos/eschnett/julia/subscription","commits_url":"https://api.github.com/repos/eschnett/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/eschnett/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/eschnett/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/eschnett/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/eschnett/julia/contents/{+path}","compare_url":"https://api.github.com/repos/eschnett/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eschnett/julia/merges","archive_url":"https://api.github.com/repos/eschnett/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eschnett/julia/downloads","issues_url":"https://api.github.com/repos/eschnett/julia/issues{/number}","pulls_url":"https://api.github.com/repos/eschnett/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/eschnett/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/eschnett/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eschnett/julia/labels{/name}","releases_url":"https://api.github.com/repos/eschnett/julia/releases{/id}","created_at":"2014-08-23T23:50:07Z","updated_at":"2015-01-14T05:48:09Z","pushed_at":"2015-01-14T05:48:09Z","git_url":"git://github.com/eschnett/julia.git","ssh_url":"git@github.com:eschnett/julia.git","clone_url":"https://github.com/eschnett/julia.git","svn_url":"https://github.com/eschnett/julia","homepage":"http://julialang.org/","size":61278,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"8938e3a32c68910ccfa84d5bb5f6c7850920a38a","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/{number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-01-14T13:29:34Z","pushed_at":"2015-01-14T13:26:25Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":152261,"stargazers_count":4931,"watchers_count":4931,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1021,"mirror_url":null,"open_issues_count":1111,"forks":1021,"open_issues":1111,"watchers":4931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9759"},"html":{"href":"https://github.com/JuliaLang/julia/pull/9759"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/9759"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/9759/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9759/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/9759/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/3008ae37bf80bcd1422867f8f99762c613786612"}}}}