{"action":"created","issue":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/350","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/350/labels{/name}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/350/comments","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/350/events","html_url":"https://github.com/alliedmodders/sourcemod/pull/350","id":89458258,"number":350,"title":"FindMap plugins","user":{"login":"powerlord","id":2437606,"avatar_url":"https://avatars.githubusercontent.com/u/2437606?v=3","gravatar_id":"","url":"https://api.github.com/users/powerlord","html_url":"https://github.com/powerlord","followers_url":"https://api.github.com/users/powerlord/followers","following_url":"https://api.github.com/users/powerlord/following{/other_user}","gists_url":"https://api.github.com/users/powerlord/gists{/gist_id}","starred_url":"https://api.github.com/users/powerlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerlord/subscriptions","organizations_url":"https://api.github.com/users/powerlord/orgs","repos_url":"https://api.github.com/users/powerlord/repos","events_url":"https://api.github.com/users/powerlord/events{/privacy}","received_events_url":"https://api.github.com/users/powerlord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=3","gravatar_id":"","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-06-19T03:52:46Z","updated_at":"2015-07-02T01:43:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/350","html_url":"https://github.com/alliedmodders/sourcemod/pull/350","diff_url":"https://github.com/alliedmodders/sourcemod/pull/350.diff","patch_url":"https://github.com/alliedmodders/sourcemod/pull/350.patch"},"body":"NOTE:  Since this was started, it switched from being based on pull request #348 to being based on the now-merged pull request #351.\r\n\r\nThis adds a new stock to sourcemod.inc: \r\n\r\n* GetFriendlyMapName changes a CSGO or TF2 workshop path to just the base mapname.  This is intended for display purposes in various plugins and/or plugins that need compatibility with existing names.\r\n\r\nNote that in TF2, at this time you can't get the proper map path for a workshop map unless you `tf_workshop_map_sync` the map after the server start so that the server is actively tracking it.\r\n\r\nThe following plugins have all been updated to make calls to FindMap and GetFriendlyMapName as appropriate:\r\n\r\n* MapChooser\r\n* Nominations\r\n* NextMap\r\n* BaseVotes\r\n* BaseTriggers\r\n* RandomCycle\r\n"},"comment":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments/117870641","html_url":"https://github.com/alliedmodders/sourcemod/pull/350#issuecomment-117870641","issue_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/350","id":117870641,"user":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=3","gravatar_id":"","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"created_at":"2015-07-02T01:43:12Z","updated_at":"2015-07-02T01:43:12Z","body":"D:\n\n-- \nNicholas Hastings\n\n\n\n> Ross Bemrose <mailto:notifications@github.com>\n> Wednesday, July 1, 2015 9:42 PM\n>\n> Not sure when it happened, but I'm seeing bugs in nominations... need\n> to check other plugins as well.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/alliedmodders/sourcemod/pull/350#issuecomment-117870569>.\n>\n> Ross Bemrose <mailto:notifications@github.com>\n> Thursday, June 18, 2015 11:52 PM\n>\n> NOTE: Since this branch was based on the Fuzzymapnative branch, it\n> includes all the changes made in pull request #348\n> <https://github.com/alliedmodders/sourcemod/pull/348> as well.\n>\n> This adds two new stocks to sourcemod.inc :\n>\n>  *\n>\n>     GetFriendlyMapName changes a CSGO or TF2 workshop path to just the\n>     base mapname. This is intended for display purposes in various\n>     plugins and/or plugins that need compatibility with existing names.\n>\n>     Note that in TF2, at this time you can't get the proper map path\n>     for a workshop map unless you |tf_workshop_map_sync| the map after\n>     the server start so that the server is actively tracking it.\n>\n>  *\n>\n>     ProduceResolvedMapList runs ResolveFuzzyMapName on every entry in\n>     an ArrayList and places the resolved name in the second ArrayList.\n>     Also has the side effect of clearing the target ArrayList first.\n>\n> The following plugins have all been updated to make calls to\n> ResolveFuzzyMapName and GetFriendlyMapName as appropriate:\n>\n>   * MapChooser\n>   * Nominations\n>   * NextMap\n>   * BaseVotes\n>   * BaseTriggers\n>\n> ------------------------------------------------------------------------\n>\n>\n>         You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/alliedmodders/sourcemod/pull/350\n>\n>\n>         Commit Summary\n>\n>   * Add new ResolveFuzzyMapName native, modifying internal\n>     ResolveFuzzyMapName command to be a member function.\n>   * Fix a typo and a bad description for the native\n>   * Make it return true if the maps are the same.\n>   * TF2 doesn't support engine->IsMapValid any more... it's failing\n>     for cp_dustbowl, for example. Therefore, don't waste time calling it.\n>   * Add a way to use resolved maps to MapChooser. More plugins to go,\n>     as well as calling the new GetFriendlyMapName for displaying.\n>   * Changes to a bunch of plugins. Still working on it and need to do\n>     a branch change.\n>   * ResolveFuzzyMapName is now exposed as part of IGameHelpers and\n>     Bumped IGameHelpers to version 11.\n>   * Merge branch 'fuzzymapnative' into fuzzymap-plugins\n>   * Move the stocks from mapchooser.inc to sourcemod.inc (where\n>     ReadMapList is). This is because non-MapChooser plugins may also\n>     need them.\n>   * Nominations now does the map resolving up front instead of one by one.\n>   * GetFriendlyMapName now works for CS:GO.\n>   * Fixed Mapchooser's \"Nextmap Voting Finished\" to use the map's\n>     info, which is the friendly name stored earlier.\n>   * Update basetriggers to support friendly map names. Maps are\n>     assumed to be in friendly format in GetNextMap.\n>   * The next map may not be in resolved format, so lets resolve it\n>     when asking for the friendly name.\n>   * Change basetriggers back to not forcing resolve before\n>     GetFriendlyMapName.\n>   * Fix issues with basetriggers chat commands using a different method.\n>   * basevotes now displays the friendlyname\n>   * Last change to basevotes won't work for single-item votes,\n>     implemented a different fix.\n>\n>\n>         File Changes\n>\n>   * *M* core/HalfLife2.cpp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-0>\n>     (26)\n>   * *M* core/HalfLife2.h\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-1>\n>     (1)\n>   * *M* core/smn_halflife.cpp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-2>\n>     (17)\n>   * *M* plugins/basecommands/map.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-3>\n>     (16)\n>   * *M* plugins/basetriggers.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-4>\n>     (12)\n>   * *M* plugins/basevotes.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-5>\n>     (7)\n>   * *M* plugins/basevotes/votemap.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-6>\n>     (12)\n>   * *M* plugins/include/halflife.inc\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-7>\n>     (17)\n>   * *M* plugins/include/sourcemod.inc\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-8>\n>     (99)\n>   * *M* plugins/mapchooser.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-9>\n>     (29)\n>   * *M* plugins/nextmap.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-10> (13)\n>\n>   * *M* plugins/nominations.sp\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-11> (86)\n>\n>   * *M* public/IGameHelpers.h\n>     <https://github.com/alliedmodders/sourcemod/pull/350/files#diff-12> (15)\n>\n>\n>\n>         Patch Links:\n>\n>   * https://github.com/alliedmodders/sourcemod/pull/350.patch\n>   * https://github.com/alliedmodders/sourcemod/pull/350.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/alliedmodders/sourcemod/pull/350>.\n>\n\n"}}