{"action":"created","comment":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/29166786","id":29166786,"diff_hunk":"@@ -31,6 +34,11 @@ def event_dispatcher(nameko_config, **kwargs):\n     def dispatch(service_name, event_type, event_data):\n         conn = Connection(nameko_config[AMQP_URI_CONFIG_KEY])\n \n+        if KOMBU_SERIALIZER_CONFIG_KEY in nameko_config.keys():\n+            serializer = nameko_config[KOMBU_SERIALIZER_CONFIG_KEY]\n+        else:\n+            serializer = DEFAULT_KOMBU_SERIALIZER","path":"nameko/standalone/events.py","position":19,"original_position":19,"commit_id":"a4fbcb80d9cbe45dbcf224a99b0fa6a21c43dfe8","original_commit_id":"a4fbcb80d9cbe45dbcf224a99b0fa6a21c43dfe8","user":{"login":"mattbennett","id":107611,"avatar_url":"https://avatars.githubusercontent.com/u/107611?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbennett","html_url":"https://github.com/mattbennett","followers_url":"https://api.github.com/users/mattbennett/followers","following_url":"https://api.github.com/users/mattbennett/following{/other_user}","gists_url":"https://api.github.com/users/mattbennett/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbennett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbennett/subscriptions","organizations_url":"https://api.github.com/users/mattbennett/orgs","repos_url":"https://api.github.com/users/mattbennett/repos","events_url":"https://api.github.com/users/mattbennett/events{/privacy}","received_events_url":"https://api.github.com/users/mattbennett/received_events","type":"User","site_admin":false},"body":"Nicer to use the ``get`` method with a default:\r\n\r\n``` python\r\nserializer = nameko_config.get(SERIALIZER_CONFIG_KEY, DEFAULT_SERIALIZER)\r\n```\r\n\r\nNot sure why we do ``config.get(MAX_WORKERS_CONFIG_KEY) or DEFAULT_MAX_WORKERS)`` further up. Maybe you can fix that too...","created_at":"2015-04-27T17:05:29Z","updated_at":"2015-04-27T17:05:29Z","html_url":"https://github.com/onefinestay/nameko/pull/244#discussion_r29166786","pull_request_url":"https://api.github.com/repos/onefinestay/nameko/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments/29166786"},"html":{"href":"https://github.com/onefinestay/nameko/pull/244#discussion_r29166786"},"pull_request":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/onefinestay/nameko/pulls/244","id":33649060,"html_url":"https://github.com/onefinestay/nameko/pull/244","diff_url":"https://github.com/onefinestay/nameko/pull/244.diff","patch_url":"https://github.com/onefinestay/nameko/pull/244.patch","issue_url":"https://api.github.com/repos/onefinestay/nameko/issues/244","number":244,"state":"open","locked":false,"title":"Kombu serialization support","user":{"login":"ayoshi","id":498112,"avatar_url":"https://avatars.githubusercontent.com/u/498112?v=3","gravatar_id":"","url":"https://api.github.com/users/ayoshi","html_url":"https://github.com/ayoshi","followers_url":"https://api.github.com/users/ayoshi/followers","following_url":"https://api.github.com/users/ayoshi/following{/other_user}","gists_url":"https://api.github.com/users/ayoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/ayoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayoshi/subscriptions","organizations_url":"https://api.github.com/users/ayoshi/orgs","repos_url":"https://api.github.com/users/ayoshi/repos","events_url":"https://api.github.com/users/ayoshi/events{/privacy}","received_events_url":"https://api.github.com/users/ayoshi/received_events","type":"User","site_admin":false},"body":"Hi.\r\n\r\nI had a spare time on hand, and decided to take a stab at it. It proved a bit harder than I expected.\r\nLet me know if there are any glaring omissions.\r\n\r\nAll tests pass correctly with default being JSON. I didn't add any tests for alternative serializers.\r\nIf the code looks right , I'l try to add tests for other serialization format, pickle for example.","created_at":"2015-04-20T09:37:01Z","updated_at":"2015-04-27T17:05:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"862d655d429a3b0ec493971670e066af97a7b416","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onefinestay/nameko/pulls/244/commits","review_comments_url":"https://api.github.com/repos/onefinestay/nameko/pulls/244/comments","review_comment_url":"https://api.github.com/repos/onefinestay/nameko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onefinestay/nameko/issues/244/comments","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/a4fbcb80d9cbe45dbcf224a99b0fa6a21c43dfe8","head":{"label":"ayoshi:kombu_serialization","ref":"kombu_serialization","sha":"a4fbcb80d9cbe45dbcf224a99b0fa6a21c43dfe8","user":{"login":"ayoshi","id":498112,"avatar_url":"https://avatars.githubusercontent.com/u/498112?v=3","gravatar_id":"","url":"https://api.github.com/users/ayoshi","html_url":"https://github.com/ayoshi","followers_url":"https://api.github.com/users/ayoshi/followers","following_url":"https://api.github.com/users/ayoshi/following{/other_user}","gists_url":"https://api.github.com/users/ayoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/ayoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayoshi/subscriptions","organizations_url":"https://api.github.com/users/ayoshi/orgs","repos_url":"https://api.github.com/users/ayoshi/repos","events_url":"https://api.github.com/users/ayoshi/events{/privacy}","received_events_url":"https://api.github.com/users/ayoshi/received_events","type":"User","site_admin":false},"repo":{"id":33887202,"name":"nameko","full_name":"ayoshi/nameko","owner":{"login":"ayoshi","id":498112,"avatar_url":"https://avatars.githubusercontent.com/u/498112?v=3","gravatar_id":"","url":"https://api.github.com/users/ayoshi","html_url":"https://github.com/ayoshi","followers_url":"https://api.github.com/users/ayoshi/followers","following_url":"https://api.github.com/users/ayoshi/following{/other_user}","gists_url":"https://api.github.com/users/ayoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/ayoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayoshi/subscriptions","organizations_url":"https://api.github.com/users/ayoshi/orgs","repos_url":"https://api.github.com/users/ayoshi/repos","events_url":"https://api.github.com/users/ayoshi/events{/privacy}","received_events_url":"https://api.github.com/users/ayoshi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ayoshi/nameko","description":"Python framework for building microservices","fork":true,"url":"https://api.github.com/repos/ayoshi/nameko","forks_url":"https://api.github.com/repos/ayoshi/nameko/forks","keys_url":"https://api.github.com/repos/ayoshi/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ayoshi/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ayoshi/nameko/teams","hooks_url":"https://api.github.com/repos/ayoshi/nameko/hooks","issue_events_url":"https://api.github.com/repos/ayoshi/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/ayoshi/nameko/events","assignees_url":"https://api.github.com/repos/ayoshi/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/ayoshi/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/ayoshi/nameko/tags","blobs_url":"https://api.github.com/repos/ayoshi/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ayoshi/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ayoshi/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/ayoshi/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ayoshi/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/ayoshi/nameko/languages","stargazers_url":"https://api.github.com/repos/ayoshi/nameko/stargazers","contributors_url":"https://api.github.com/repos/ayoshi/nameko/contributors","subscribers_url":"https://api.github.com/repos/ayoshi/nameko/subscribers","subscription_url":"https://api.github.com/repos/ayoshi/nameko/subscription","commits_url":"https://api.github.com/repos/ayoshi/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/ayoshi/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/ayoshi/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/ayoshi/nameko/issues/comments{/number}","contents_url":"https://api.github.com/repos/ayoshi/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/ayoshi/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ayoshi/nameko/merges","archive_url":"https://api.github.com/repos/ayoshi/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ayoshi/nameko/downloads","issues_url":"https://api.github.com/repos/ayoshi/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/ayoshi/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/ayoshi/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/ayoshi/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ayoshi/nameko/labels{/name}","releases_url":"https://api.github.com/repos/ayoshi/nameko/releases{/id}","created_at":"2015-04-13T18:50:22Z","updated_at":"2015-04-13T18:50:23Z","pushed_at":"2015-04-21T22:42:56Z","git_url":"git://github.com/ayoshi/nameko.git","ssh_url":"git@github.com:ayoshi/nameko.git","clone_url":"https://github.com/ayoshi/nameko.git","svn_url":"https://github.com/ayoshi/nameko","homepage":"https://nameko.readthedocs.org","size":2098,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onefinestay:master","ref":"master","sha":"9a3ba6bc0cbb608f156e6f39a659be421e534293","user":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"repo":{"id":8431589,"name":"nameko","full_name":"onefinestay/nameko","owner":{"login":"onefinestay","id":634153,"avatar_url":"https://avatars.githubusercontent.com/u/634153?v=3","gravatar_id":"","url":"https://api.github.com/users/onefinestay","html_url":"https://github.com/onefinestay","followers_url":"https://api.github.com/users/onefinestay/followers","following_url":"https://api.github.com/users/onefinestay/following{/other_user}","gists_url":"https://api.github.com/users/onefinestay/gists{/gist_id}","starred_url":"https://api.github.com/users/onefinestay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onefinestay/subscriptions","organizations_url":"https://api.github.com/users/onefinestay/orgs","repos_url":"https://api.github.com/users/onefinestay/repos","events_url":"https://api.github.com/users/onefinestay/events{/privacy}","received_events_url":"https://api.github.com/users/onefinestay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onefinestay/nameko","description":"Python framework for building microservices","fork":false,"url":"https://api.github.com/repos/onefinestay/nameko","forks_url":"https://api.github.com/repos/onefinestay/nameko/forks","keys_url":"https://api.github.com/repos/onefinestay/nameko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onefinestay/nameko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onefinestay/nameko/teams","hooks_url":"https://api.github.com/repos/onefinestay/nameko/hooks","issue_events_url":"https://api.github.com/repos/onefinestay/nameko/issues/events{/number}","events_url":"https://api.github.com/repos/onefinestay/nameko/events","assignees_url":"https://api.github.com/repos/onefinestay/nameko/assignees{/user}","branches_url":"https://api.github.com/repos/onefinestay/nameko/branches{/branch}","tags_url":"https://api.github.com/repos/onefinestay/nameko/tags","blobs_url":"https://api.github.com/repos/onefinestay/nameko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onefinestay/nameko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onefinestay/nameko/git/refs{/sha}","trees_url":"https://api.github.com/repos/onefinestay/nameko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onefinestay/nameko/statuses/{sha}","languages_url":"https://api.github.com/repos/onefinestay/nameko/languages","stargazers_url":"https://api.github.com/repos/onefinestay/nameko/stargazers","contributors_url":"https://api.github.com/repos/onefinestay/nameko/contributors","subscribers_url":"https://api.github.com/repos/onefinestay/nameko/subscribers","subscription_url":"https://api.github.com/repos/onefinestay/nameko/subscription","commits_url":"https://api.github.com/repos/onefinestay/nameko/commits{/sha}","git_commits_url":"https://api.github.com/repos/onefinestay/nameko/git/commits{/sha}","comments_url":"https://api.github.com/repos/onefinestay/nameko/comments{/number}","issue_comment_url":"https://api.github.com/repos/onefinestay/nameko/issues/comments{/number}","contents_url":"https://api.github.com/repos/onefinestay/nameko/contents/{+path}","compare_url":"https://api.github.com/repos/onefinestay/nameko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onefinestay/nameko/merges","archive_url":"https://api.github.com/repos/onefinestay/nameko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onefinestay/nameko/downloads","issues_url":"https://api.github.com/repos/onefinestay/nameko/issues{/number}","pulls_url":"https://api.github.com/repos/onefinestay/nameko/pulls{/number}","milestones_url":"https://api.github.com/repos/onefinestay/nameko/milestones{/number}","notifications_url":"https://api.github.com/repos/onefinestay/nameko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onefinestay/nameko/labels{/name}","releases_url":"https://api.github.com/repos/onefinestay/nameko/releases{/id}","created_at":"2013-02-26T11:59:08Z","updated_at":"2015-04-27T15:34:01Z","pushed_at":"2015-04-23T16:11:54Z","git_url":"git://github.com/onefinestay/nameko.git","ssh_url":"git@github.com:onefinestay/nameko.git","clone_url":"https://github.com/onefinestay/nameko.git","svn_url":"https://github.com/onefinestay/nameko","homepage":"https://nameko.readthedocs.org","size":6043,"stargazers_count":425,"watchers_count":425,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/244"},"html":{"href":"https://github.com/onefinestay/nameko/pull/244"},"issue":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/244"},"comments":{"href":"https://api.github.com/repos/onefinestay/nameko/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onefinestay/nameko/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/onefinestay/nameko/statuses/a4fbcb80d9cbe45dbcf224a99b0fa6a21c43dfe8"}}}}