{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/24285481","id":24285481,"diff_hunk":"@@ -120,13 +190,73 @@ impl Float for f32 {\n     #[allow(deprecated)]\n     #[inline]\n     fn max_value() -> f32 { num::Float::max_value() }\n-\n+    /// Returns `true` if the number is `NaN`.\n+    ///\n+    /// ```\n+    /// use std::f32;\n+    ///\n+    /// let nan: f32 = f32::NAN;\n+    ///\n+    /// assert!(nan.is_nan());\n+    /// assert!(!7.0f32.is_nan());\n+    /// ```\n     #[inline]\n     fn is_nan(self) -> bool { num::Float::is_nan(self) }\n+    /// Returns `true` if the number is infinite.\n+    ///\n+    /// ```\n+    /// use std::Float;\n+    /// use std::f32;\n+    ///\n+    /// let inf: f32 = Float::infinity();\n+    /// let neg_inf: f32 = Float::neg_infinity();\n+    /// let nan: f32 = f32::NAN;\n+    ///\n+    /// assert!(!7.0f32.is_infinite());\n+    /// assert!(!nan.is_infinite());\n+    ///\n+    /// assert!(inf.is_infinite());\n+    /// assert!(neg_inf.is_infinite());\n+    /// ```\n     #[inline]\n     fn is_infinite(self) -> bool { num::Float::is_infinite(self) }\n+    /// Returns `true` is the number is finite.\n+    ///\n+    /// ```\n+    /// use std::Float;\n+    /// use std::f32;\n+    ///\n+    /// let inf: f32 = Float::infinity();\n+    /// let neg_inf: f32 = Float::neg_infinity();\n+    /// let nan: f32 = f32::NAN;\n+    ///\n+    /// assert!(7.0f32.is_finite());\n+    ///\n+    /// assert!(!nan.is_finite());\n+    /// assert!(!inf.is_finite());\n+    /// assert!(!neg_inf.is_finite());\n+    /// ```\n     #[inline]\n     fn is_finite(self) -> bool { num::Float::is_finite(self) }\n+    /// Returns `true` if the number is neither zero, infinite, subnormal, or NaN.\n+    ///\n+    /// ```\n+    /// use std::num::Float;\n+    /// use std::f32;\n+    ///\n+    /// let min: f32 = f32::MIN_POS_VALUE; // 1.17549435e-38f32\n+    /// let max: f32 = f32::MAX_VALUE;\n+    /// let lower_than_min: f32 = 1.0e-40;","path":"src/libstd/num/f32.rs","position":148,"original_position":148,"commit_id":"33499300211e51ad3a5a5f672a61800d5dd12da5","original_commit_id":"33499300211e51ad3a5a5f672a61800d5dd12da5","user":{"login":"mdinger","id":4156987,"avatar_url":"https://avatars.githubusercontent.com/u/4156987?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinger","html_url":"https://github.com/mdinger","followers_url":"https://api.github.com/users/mdinger/followers","following_url":"https://api.github.com/users/mdinger/following{/other_user}","gists_url":"https://api.github.com/users/mdinger/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinger/subscriptions","organizations_url":"https://api.github.com/users/mdinger/orgs","repos_url":"https://api.github.com/users/mdinger/repos","events_url":"https://api.github.com/users/mdinger/events{/privacy}","received_events_url":"https://api.github.com/users/mdinger/received_events","type":"User","site_admin":false},"body":"Should provide a link...less than min is weird. This could be puzzling if you've never seen this before. I hadn't.","created_at":"2015-02-07T02:04:50Z","updated_at":"2015-02-07T02:04:50Z","html_url":"https://github.com/rust-lang/rust/pull/22030#discussion_r24285481","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/22030","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/24285481"},"html":{"href":"https://github.com/rust-lang/rust/pull/22030#discussion_r24285481"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22030"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/22030","id":28854075,"html_url":"https://github.com/rust-lang/rust/pull/22030","diff_url":"https://github.com/rust-lang/rust/pull/22030.diff","patch_url":"https://github.com/rust-lang/rust/pull/22030.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/22030","number":22030,"state":"open","locked":false,"title":"WIP: Give f32 some examples","user":{"login":"mdinger","id":4156987,"avatar_url":"https://avatars.githubusercontent.com/u/4156987?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinger","html_url":"https://github.com/mdinger","followers_url":"https://api.github.com/users/mdinger/followers","following_url":"https://api.github.com/users/mdinger/following{/other_user}","gists_url":"https://api.github.com/users/mdinger/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinger/subscriptions","organizations_url":"https://api.github.com/users/mdinger/orgs","repos_url":"https://api.github.com/users/mdinger/repos","events_url":"https://api.github.com/users/mdinger/events{/privacy}","received_events_url":"https://api.github.com/users/mdinger/received_events","type":"User","site_admin":false},"body":"This is WIP for making examples for `f32`. This probably won't pass `make tidy` and I'm not sure which `f32` needs documentation. https://github.com/rust-lang/rust/issues/22025 shows 2 sets of `f32` which seems split between `core` and `std`. I'm not sure which should be documented but I started doing a couple from `std`. Easy to move if that's where they go...\r\n\r\nGotta build it eventually to actually see if the docs actually appear where I think they will or if I'm just disillusioned.\r\n\r\ncc @steveklabnik ","created_at":"2015-02-07T00:34:55Z","updated_at":"2015-02-07T02:04:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93e97ee851dd0bd7527bdcf3c591a57868a5fca8","assignee":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/22030/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/22030/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/22030/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/33499300211e51ad3a5a5f672a61800d5dd12da5","head":{"label":"mdinger:f32_examples","ref":"f32_examples","sha":"33499300211e51ad3a5a5f672a61800d5dd12da5","user":{"login":"mdinger","id":4156987,"avatar_url":"https://avatars.githubusercontent.com/u/4156987?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinger","html_url":"https://github.com/mdinger","followers_url":"https://api.github.com/users/mdinger/followers","following_url":"https://api.github.com/users/mdinger/following{/other_user}","gists_url":"https://api.github.com/users/mdinger/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinger/subscriptions","organizations_url":"https://api.github.com/users/mdinger/orgs","repos_url":"https://api.github.com/users/mdinger/repos","events_url":"https://api.github.com/users/mdinger/events{/privacy}","received_events_url":"https://api.github.com/users/mdinger/received_events","type":"User","site_admin":false},"repo":{"id":18922377,"name":"rust","full_name":"mdinger/rust","owner":{"login":"mdinger","id":4156987,"avatar_url":"https://avatars.githubusercontent.com/u/4156987?v=3","gravatar_id":"","url":"https://api.github.com/users/mdinger","html_url":"https://github.com/mdinger","followers_url":"https://api.github.com/users/mdinger/followers","following_url":"https://api.github.com/users/mdinger/following{/other_user}","gists_url":"https://api.github.com/users/mdinger/gists{/gist_id}","starred_url":"https://api.github.com/users/mdinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdinger/subscriptions","organizations_url":"https://api.github.com/users/mdinger/orgs","repos_url":"https://api.github.com/users/mdinger/repos","events_url":"https://api.github.com/users/mdinger/events{/privacy}","received_events_url":"https://api.github.com/users/mdinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdinger/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/mdinger/rust","forks_url":"https://api.github.com/repos/mdinger/rust/forks","keys_url":"https://api.github.com/repos/mdinger/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdinger/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdinger/rust/teams","hooks_url":"https://api.github.com/repos/mdinger/rust/hooks","issue_events_url":"https://api.github.com/repos/mdinger/rust/issues/events{/number}","events_url":"https://api.github.com/repos/mdinger/rust/events","assignees_url":"https://api.github.com/repos/mdinger/rust/assignees{/user}","branches_url":"https://api.github.com/repos/mdinger/rust/branches{/branch}","tags_url":"https://api.github.com/repos/mdinger/rust/tags","blobs_url":"https://api.github.com/repos/mdinger/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdinger/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdinger/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdinger/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdinger/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/mdinger/rust/languages","stargazers_url":"https://api.github.com/repos/mdinger/rust/stargazers","contributors_url":"https://api.github.com/repos/mdinger/rust/contributors","subscribers_url":"https://api.github.com/repos/mdinger/rust/subscribers","subscription_url":"https://api.github.com/repos/mdinger/rust/subscription","commits_url":"https://api.github.com/repos/mdinger/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdinger/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdinger/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdinger/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/mdinger/rust/contents/{+path}","compare_url":"https://api.github.com/repos/mdinger/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdinger/rust/merges","archive_url":"https://api.github.com/repos/mdinger/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdinger/rust/downloads","issues_url":"https://api.github.com/repos/mdinger/rust/issues{/number}","pulls_url":"https://api.github.com/repos/mdinger/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/mdinger/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/mdinger/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdinger/rust/labels{/name}","releases_url":"https://api.github.com/repos/mdinger/rust/releases{/id}","created_at":"2014-04-18T18:55:17Z","updated_at":"2015-02-02T05:38:06Z","pushed_at":"2015-02-07T00:29:21Z","git_url":"git://github.com/mdinger/rust.git","ssh_url":"git@github.com:mdinger/rust.git","clone_url":"https://github.com/mdinger/rust.git","svn_url":"https://github.com/mdinger/rust","homepage":"http://www.rust-lang.org","size":226999,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b75b21cb9b187a6f836da61769a8110354fd6dad","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-02-07T02:04:46Z","pushed_at":"2015-02-07T02:04:47Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":466525,"stargazers_count":9249,"watchers_count":9249,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1772,"mirror_url":null,"open_issues_count":2029,"forks":1772,"open_issues":2029,"watchers":9249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22030"},"html":{"href":"https://github.com/rust-lang/rust/pull/22030"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22030"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22030/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22030/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22030/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/33499300211e51ad3a5a5f672a61800d5dd12da5"}}}}