{"action":"created","comment":{"url":"https://api.github.com/repos/divmain/GitSavvy/pulls/comments/26148412","id":26148412,"diff_hunk":"@@ -95,10 +96,21 @@ def run_async(self):\n         if self.view.settings().get(\"git_savvy.commit_view.include_unstaged\"):\n             self.add_all_tracked_files()\n \n+        commit_args = [\"commit\", \"-q\"]\n+\n         if self.view.settings().get(\"git_savvy.commit_view.amend\"):\n-            self.git(\"commit\", \"-q\", \"--amend\", \"-F\", \"-\", stdin=commit_message)\n-        else:\n-            self.git(\"commit\", \"-q\", \"-F\", \"-\", stdin=commit_message)\n+            commit_args.append(\"--amend\")\n+\n+        if self.view.settings().get(\"git_savvy.signed\"):\n+            commit_args.append(\"--gpg-sign\")\n+\n+        commit_args.extend([\"-F\", \"-\"])\n+\n+        commit_kwargs = {\n+            \"stdin\": commit_message\n+        }\n+\n+        self.git(*commit_args, **commit_kwargs)","path":"core/commands/commit.py","position":37,"original_position":37,"commit_id":"3256083516c625a19940fa6311d547512b0380d9","original_commit_id":"3256083516c625a19940fa6311d547512b0380d9","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"body":"Since you're not generating the keyword args dynamically, please change this line to:\r\n```python\r\nself.git(*commit_args, stdin=commit_message)\r\n```","created_at":"2015-03-10T18:06:14Z","updated_at":"2015-03-10T18:06:14Z","html_url":"https://github.com/divmain/GitSavvy/pull/68#discussion_r26148412","pull_request_url":"https://api.github.com/repos/divmain/GitSavvy/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/comments/26148412"},"html":{"href":"https://github.com/divmain/GitSavvy/pull/68#discussion_r26148412"},"pull_request":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/divmain/GitSavvy/pulls/68","id":30866431,"html_url":"https://github.com/divmain/GitSavvy/pull/68","diff_url":"https://github.com/divmain/GitSavvy/pull/68.diff","patch_url":"https://github.com/divmain/GitSavvy/pull/68.patch","issue_url":"https://api.github.com/repos/divmain/GitSavvy/issues/68","number":68,"state":"open","locked":false,"title":"Signed commits","user":{"login":"TheHippo","id":199056,"avatar_url":"https://avatars.githubusercontent.com/u/199056?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHippo","html_url":"https://github.com/TheHippo","followers_url":"https://api.github.com/users/TheHippo/followers","following_url":"https://api.github.com/users/TheHippo/following{/other_user}","gists_url":"https://api.github.com/users/TheHippo/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHippo/subscriptions","organizations_url":"https://api.github.com/users/TheHippo/orgs","repos_url":"https://api.github.com/users/TheHippo/repos","events_url":"https://api.github.com/users/TheHippo/events{/privacy}","received_events_url":"https://api.github.com/users/TheHippo/received_events","type":"User","site_admin":false},"body":"Started to implement GPG signed commits. This is work in progress.\r\n\r\n- [x] command for signed commits\r\n- [x] command for signed amends\r\n- [ ] test what happends if GPG key isn't unlocked\r\n- [ ] test what happends if no GPG key is configured\r\n- [ ] allow signed commit from status view.\r\n\r\nIf there is anything you don't like about my code, please let me know. This is the first time I'm working / hacking on a Sublime Text plugin.","created_at":"2015-03-10T16:20:22Z","updated_at":"2015-03-10T18:06:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e648d2709bd75d173653c5ee850c0e3c67377b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/divmain/GitSavvy/pulls/68/commits","review_comments_url":"https://api.github.com/repos/divmain/GitSavvy/pulls/68/comments","review_comment_url":"https://api.github.com/repos/divmain/GitSavvy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divmain/GitSavvy/issues/68/comments","statuses_url":"https://api.github.com/repos/divmain/GitSavvy/statuses/3256083516c625a19940fa6311d547512b0380d9","head":{"label":"TheHippo:signed-commits","ref":"signed-commits","sha":"3256083516c625a19940fa6311d547512b0380d9","user":{"login":"TheHippo","id":199056,"avatar_url":"https://avatars.githubusercontent.com/u/199056?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHippo","html_url":"https://github.com/TheHippo","followers_url":"https://api.github.com/users/TheHippo/followers","following_url":"https://api.github.com/users/TheHippo/following{/other_user}","gists_url":"https://api.github.com/users/TheHippo/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHippo/subscriptions","organizations_url":"https://api.github.com/users/TheHippo/orgs","repos_url":"https://api.github.com/users/TheHippo/repos","events_url":"https://api.github.com/users/TheHippo/events{/privacy}","received_events_url":"https://api.github.com/users/TheHippo/received_events","type":"User","site_admin":false},"repo":{"id":31772757,"name":"GitSavvy","full_name":"TheHippo/GitSavvy","owner":{"login":"TheHippo","id":199056,"avatar_url":"https://avatars.githubusercontent.com/u/199056?v=3","gravatar_id":"","url":"https://api.github.com/users/TheHippo","html_url":"https://github.com/TheHippo","followers_url":"https://api.github.com/users/TheHippo/followers","following_url":"https://api.github.com/users/TheHippo/following{/other_user}","gists_url":"https://api.github.com/users/TheHippo/gists{/gist_id}","starred_url":"https://api.github.com/users/TheHippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheHippo/subscriptions","organizations_url":"https://api.github.com/users/TheHippo/orgs","repos_url":"https://api.github.com/users/TheHippo/repos","events_url":"https://api.github.com/users/TheHippo/events{/privacy}","received_events_url":"https://api.github.com/users/TheHippo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheHippo/GitSavvy","description":"Full git and GitHub integration with Sublime Text 3.","fork":true,"url":"https://api.github.com/repos/TheHippo/GitSavvy","forks_url":"https://api.github.com/repos/TheHippo/GitSavvy/forks","keys_url":"https://api.github.com/repos/TheHippo/GitSavvy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheHippo/GitSavvy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheHippo/GitSavvy/teams","hooks_url":"https://api.github.com/repos/TheHippo/GitSavvy/hooks","issue_events_url":"https://api.github.com/repos/TheHippo/GitSavvy/issues/events{/number}","events_url":"https://api.github.com/repos/TheHippo/GitSavvy/events","assignees_url":"https://api.github.com/repos/TheHippo/GitSavvy/assignees{/user}","branches_url":"https://api.github.com/repos/TheHippo/GitSavvy/branches{/branch}","tags_url":"https://api.github.com/repos/TheHippo/GitSavvy/tags","blobs_url":"https://api.github.com/repos/TheHippo/GitSavvy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheHippo/GitSavvy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheHippo/GitSavvy/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheHippo/GitSavvy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheHippo/GitSavvy/statuses/{sha}","languages_url":"https://api.github.com/repos/TheHippo/GitSavvy/languages","stargazers_url":"https://api.github.com/repos/TheHippo/GitSavvy/stargazers","contributors_url":"https://api.github.com/repos/TheHippo/GitSavvy/contributors","subscribers_url":"https://api.github.com/repos/TheHippo/GitSavvy/subscribers","subscription_url":"https://api.github.com/repos/TheHippo/GitSavvy/subscription","commits_url":"https://api.github.com/repos/TheHippo/GitSavvy/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheHippo/GitSavvy/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheHippo/GitSavvy/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheHippo/GitSavvy/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheHippo/GitSavvy/contents/{+path}","compare_url":"https://api.github.com/repos/TheHippo/GitSavvy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheHippo/GitSavvy/merges","archive_url":"https://api.github.com/repos/TheHippo/GitSavvy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheHippo/GitSavvy/downloads","issues_url":"https://api.github.com/repos/TheHippo/GitSavvy/issues{/number}","pulls_url":"https://api.github.com/repos/TheHippo/GitSavvy/pulls{/number}","milestones_url":"https://api.github.com/repos/TheHippo/GitSavvy/milestones{/number}","notifications_url":"https://api.github.com/repos/TheHippo/GitSavvy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheHippo/GitSavvy/labels{/name}","releases_url":"https://api.github.com/repos/TheHippo/GitSavvy/releases{/id}","created_at":"2015-03-06T14:26:05Z","updated_at":"2015-03-10T15:31:45Z","pushed_at":"2015-03-10T16:31:20Z","git_url":"git://github.com/TheHippo/GitSavvy.git","ssh_url":"git@github.com:TheHippo/GitSavvy.git","clone_url":"https://github.com/TheHippo/GitSavvy.git","svn_url":"https://github.com/TheHippo/GitSavvy","homepage":"","size":356,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"divmain:master","ref":"master","sha":"b951a6dfb6e2904b1c4baa65d902b3e948d7d2ae","user":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"repo":{"id":29417074,"name":"GitSavvy","full_name":"divmain/GitSavvy","owner":{"login":"divmain","id":5016978,"avatar_url":"https://avatars.githubusercontent.com/u/5016978?v=3","gravatar_id":"","url":"https://api.github.com/users/divmain","html_url":"https://github.com/divmain","followers_url":"https://api.github.com/users/divmain/followers","following_url":"https://api.github.com/users/divmain/following{/other_user}","gists_url":"https://api.github.com/users/divmain/gists{/gist_id}","starred_url":"https://api.github.com/users/divmain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divmain/subscriptions","organizations_url":"https://api.github.com/users/divmain/orgs","repos_url":"https://api.github.com/users/divmain/repos","events_url":"https://api.github.com/users/divmain/events{/privacy}","received_events_url":"https://api.github.com/users/divmain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/divmain/GitSavvy","description":"Full git and GitHub integration with Sublime Text 3.","fork":false,"url":"https://api.github.com/repos/divmain/GitSavvy","forks_url":"https://api.github.com/repos/divmain/GitSavvy/forks","keys_url":"https://api.github.com/repos/divmain/GitSavvy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divmain/GitSavvy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divmain/GitSavvy/teams","hooks_url":"https://api.github.com/repos/divmain/GitSavvy/hooks","issue_events_url":"https://api.github.com/repos/divmain/GitSavvy/issues/events{/number}","events_url":"https://api.github.com/repos/divmain/GitSavvy/events","assignees_url":"https://api.github.com/repos/divmain/GitSavvy/assignees{/user}","branches_url":"https://api.github.com/repos/divmain/GitSavvy/branches{/branch}","tags_url":"https://api.github.com/repos/divmain/GitSavvy/tags","blobs_url":"https://api.github.com/repos/divmain/GitSavvy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divmain/GitSavvy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divmain/GitSavvy/git/refs{/sha}","trees_url":"https://api.github.com/repos/divmain/GitSavvy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divmain/GitSavvy/statuses/{sha}","languages_url":"https://api.github.com/repos/divmain/GitSavvy/languages","stargazers_url":"https://api.github.com/repos/divmain/GitSavvy/stargazers","contributors_url":"https://api.github.com/repos/divmain/GitSavvy/contributors","subscribers_url":"https://api.github.com/repos/divmain/GitSavvy/subscribers","subscription_url":"https://api.github.com/repos/divmain/GitSavvy/subscription","commits_url":"https://api.github.com/repos/divmain/GitSavvy/commits{/sha}","git_commits_url":"https://api.github.com/repos/divmain/GitSavvy/git/commits{/sha}","comments_url":"https://api.github.com/repos/divmain/GitSavvy/comments{/number}","issue_comment_url":"https://api.github.com/repos/divmain/GitSavvy/issues/comments{/number}","contents_url":"https://api.github.com/repos/divmain/GitSavvy/contents/{+path}","compare_url":"https://api.github.com/repos/divmain/GitSavvy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divmain/GitSavvy/merges","archive_url":"https://api.github.com/repos/divmain/GitSavvy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divmain/GitSavvy/downloads","issues_url":"https://api.github.com/repos/divmain/GitSavvy/issues{/number}","pulls_url":"https://api.github.com/repos/divmain/GitSavvy/pulls{/number}","milestones_url":"https://api.github.com/repos/divmain/GitSavvy/milestones{/number}","notifications_url":"https://api.github.com/repos/divmain/GitSavvy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divmain/GitSavvy/labels{/name}","releases_url":"https://api.github.com/repos/divmain/GitSavvy/releases{/id}","created_at":"2015-01-18T05:40:08Z","updated_at":"2015-03-10T17:59:24Z","pushed_at":"2015-03-10T17:59:23Z","git_url":"git://github.com/divmain/GitSavvy.git","ssh_url":"git@github.com:divmain/GitSavvy.git","clone_url":"https://github.com/divmain/GitSavvy.git","svn_url":"https://github.com/divmain/GitSavvy","homepage":"","size":1114,"stargazers_count":689,"watchers_count":689,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":28,"forks":18,"open_issues":28,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/68"},"html":{"href":"https://github.com/divmain/GitSavvy/pull/68"},"issue":{"href":"https://api.github.com/repos/divmain/GitSavvy/issues/68"},"comments":{"href":"https://api.github.com/repos/divmain/GitSavvy/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divmain/GitSavvy/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/divmain/GitSavvy/statuses/3256083516c625a19940fa6311d547512b0380d9"}}}}