{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/27641","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/27641/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27641/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/27641/events","html_url":"https://github.com/rust-lang/rust/pull/27641","id":100146923,"number":27641,"title":"Implement (most of) RFC 1214","user":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nrc","id":762626,"avatar_url":"https://avatars.githubusercontent.com/u/762626?v=3","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"milestone":null,"comments":16,"created_at":"2015-08-10T19:21:46Z","updated_at":"2015-08-14T15:13:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27641","html_url":"https://github.com/rust-lang/rust/pull/27641","diff_url":"https://github.com/rust-lang/rust/pull/27641.diff","patch_url":"https://github.com/rust-lang/rust/pull/27641.patch"},"body":"This PR implements the majority of RFC 1214. In particular, it implements:\r\n\r\n- the new outlives relation\r\n- comprehensive WF checking\r\n\r\nFor the most part, new code receives warnings, not errors, though 3 regressions were found via a crater run. \r\n\r\nThere are some deviations from RFC 1214. Most notably:\r\n\r\n- we still consider implied bounds from fn ret; this intersects other soundness issues that I intend to address in detail in a follow-up RFC. Fixing this without breaking a lot of code probably requires rewriting compare-method somewhat (which is probably a good thing).\r\n- object types do not check trait bounds for fear of encountering `Self`; this was left as an unresolved question in RFC 1214, but ultimately feels inconsistent.\r\n\r\nBoth of those two issues are highlighted in the tracking issue, https://github.com/rust-lang/rust/issues/27579. #27579 also includes a testing matrix with new tests that I wrote -- these probably duplicate some existing tests, I tried to check but wasn't quite sure what to look for. I tried to be thorough in testing the WF relation, at least, but would welcome suggestions for missing tests.\r\n\r\nr? @nrc (or perhaps someone else?)"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/131142879","html_url":"https://github.com/rust-lang/rust/pull/27641#issuecomment-131142879","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27641","id":131142879,"user":{"login":"Marwes","id":957312,"avatar_url":"https://avatars.githubusercontent.com/u/957312?v=3","gravatar_id":"","url":"https://api.github.com/users/Marwes","html_url":"https://github.com/Marwes","followers_url":"https://api.github.com/users/Marwes/followers","following_url":"https://api.github.com/users/Marwes/following{/other_user}","gists_url":"https://api.github.com/users/Marwes/gists{/gist_id}","starred_url":"https://api.github.com/users/Marwes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marwes/subscriptions","organizations_url":"https://api.github.com/users/Marwes/orgs","repos_url":"https://api.github.com/users/Marwes/repos","events_url":"https://api.github.com/users/Marwes/events{/privacy}","received_events_url":"https://api.github.com/users/Marwes/received_events","type":"User","site_admin":false},"created_at":"2015-08-14T15:13:02Z","updated_at":"2015-08-14T15:13:02Z","body":"Author of combine here. Got a heads up from @nikomatsakis about this and it should be possible to fix easily. I will upload a fix once I can test it on nightly."}}