{"action":"closed","number":1182,"pull_request":{"url":"https://api.github.com/repos/github/hubot-scripts/pulls/1182","id":8999672,"html_url":"https://github.com/github/hubot-scripts/pull/1182","diff_url":"https://github.com/github/hubot-scripts/pull/1182.diff","patch_url":"https://github.com/github/hubot-scripts/pull/1182.patch","issue_url":"https://api.github.com/repos/github/hubot-scripts/issues/1182","number":1182,"state":"closed","locked":false,"title":"Handle error for stock info request","user":{"login":"EnotionZ","id":100429,"avatar_url":"https://avatars.githubusercontent.com/u/100429?v=3","gravatar_id":"","url":"https://api.github.com/users/EnotionZ","html_url":"https://github.com/EnotionZ","followers_url":"https://api.github.com/users/EnotionZ/followers","following_url":"https://api.github.com/users/EnotionZ/following{/other_user}","gists_url":"https://api.github.com/users/EnotionZ/gists{/gist_id}","starred_url":"https://api.github.com/users/EnotionZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnotionZ/subscriptions","organizations_url":"https://api.github.com/users/EnotionZ/orgs","repos_url":"https://api.github.com/users/EnotionZ/repos","events_url":"https://api.github.com/users/EnotionZ/events{/privacy}","received_events_url":"https://api.github.com/users/EnotionZ/received_events","type":"User","site_admin":false},"body":"We should handle the error for this callback, specifically in the case where the ticker doesn't match any existing company. Oddly enough when the ticker doesn't exist, the `err` object is still `null` but `body` is an empty string. This commit ensures `JSON.parse` isn't called on an empty string, preventing hubot from dying.","created_at":"2013-10-10T18:19:52Z","updated_at":"2015-06-05T16:06:48Z","closed_at":"2015-06-05T16:06:48Z","merged_at":null,"merge_commit_sha":"39691809109806b171145651c01b6b9e8df2e452","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/github/hubot-scripts/pulls/1182/commits","review_comments_url":"https://api.github.com/repos/github/hubot-scripts/pulls/1182/comments","review_comment_url":"https://api.github.com/repos/github/hubot-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/hubot-scripts/issues/1182/comments","statuses_url":"https://api.github.com/repos/github/hubot-scripts/statuses/0d6e850af4672dd70b2aed6fa445d96d789ba542","head":{"label":"EnotionZ:patch-1","ref":"patch-1","sha":"0d6e850af4672dd70b2aed6fa445d96d789ba542","user":{"login":"EnotionZ","id":100429,"avatar_url":"https://avatars.githubusercontent.com/u/100429?v=3","gravatar_id":"","url":"https://api.github.com/users/EnotionZ","html_url":"https://github.com/EnotionZ","followers_url":"https://api.github.com/users/EnotionZ/followers","following_url":"https://api.github.com/users/EnotionZ/following{/other_user}","gists_url":"https://api.github.com/users/EnotionZ/gists{/gist_id}","starred_url":"https://api.github.com/users/EnotionZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnotionZ/subscriptions","organizations_url":"https://api.github.com/users/EnotionZ/orgs","repos_url":"https://api.github.com/users/EnotionZ/repos","events_url":"https://api.github.com/users/EnotionZ/events{/privacy}","received_events_url":"https://api.github.com/users/EnotionZ/received_events","type":"User","site_admin":false},"repo":{"id":13478871,"name":"hubot-scripts","full_name":"EnotionZ/hubot-scripts","owner":{"login":"EnotionZ","id":100429,"avatar_url":"https://avatars.githubusercontent.com/u/100429?v=3","gravatar_id":"","url":"https://api.github.com/users/EnotionZ","html_url":"https://github.com/EnotionZ","followers_url":"https://api.github.com/users/EnotionZ/followers","following_url":"https://api.github.com/users/EnotionZ/following{/other_user}","gists_url":"https://api.github.com/users/EnotionZ/gists{/gist_id}","starred_url":"https://api.github.com/users/EnotionZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnotionZ/subscriptions","organizations_url":"https://api.github.com/users/EnotionZ/orgs","repos_url":"https://api.github.com/users/EnotionZ/repos","events_url":"https://api.github.com/users/EnotionZ/events{/privacy}","received_events_url":"https://api.github.com/users/EnotionZ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EnotionZ/hubot-scripts","description":"optional scripts for hubot, opt in via hubot-scripts.json","fork":true,"url":"https://api.github.com/repos/EnotionZ/hubot-scripts","forks_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/forks","keys_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/teams","hooks_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/hooks","issue_events_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/events","assignees_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/tags","blobs_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/languages","stargazers_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/stargazers","contributors_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/contributors","subscribers_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/subscribers","subscription_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/subscription","commits_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/merges","archive_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/downloads","issues_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/labels{/name}","releases_url":"https://api.github.com/repos/EnotionZ/hubot-scripts/releases{/id}","created_at":"2013-10-10T18:04:47Z","updated_at":"2013-10-10T20:25:34Z","pushed_at":"2013-10-10T18:18:54Z","git_url":"git://github.com/EnotionZ/hubot-scripts.git","ssh_url":"git@github.com:EnotionZ/hubot-scripts.git","clone_url":"https://github.com/EnotionZ/hubot-scripts.git","svn_url":"https://github.com/EnotionZ/hubot-scripts","homepage":"","size":2356,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"935699b9b7ecc60fafcff048e99b40c7e6e3be3a","user":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":2346623,"name":"hubot-scripts","full_name":"github/hubot-scripts","owner":{"login":"github","id":9919,"avatar_url":"https://avatars.githubusercontent.com/u/9919?v=3","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/hubot-scripts","description":"DEPRECATED, see https://github.com/github/hubot-scripts/issues/1113 for details - optional scripts for hubot, opt in via hubot-scripts.json","fork":false,"url":"https://api.github.com/repos/github/hubot-scripts","forks_url":"https://api.github.com/repos/github/hubot-scripts/forks","keys_url":"https://api.github.com/repos/github/hubot-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/hubot-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/hubot-scripts/teams","hooks_url":"https://api.github.com/repos/github/hubot-scripts/hooks","issue_events_url":"https://api.github.com/repos/github/hubot-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/github/hubot-scripts/events","assignees_url":"https://api.github.com/repos/github/hubot-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/github/hubot-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/github/hubot-scripts/tags","blobs_url":"https://api.github.com/repos/github/hubot-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/hubot-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/hubot-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/hubot-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/hubot-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/github/hubot-scripts/languages","stargazers_url":"https://api.github.com/repos/github/hubot-scripts/stargazers","contributors_url":"https://api.github.com/repos/github/hubot-scripts/contributors","subscribers_url":"https://api.github.com/repos/github/hubot-scripts/subscribers","subscription_url":"https://api.github.com/repos/github/hubot-scripts/subscription","commits_url":"https://api.github.com/repos/github/hubot-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/hubot-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/hubot-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/hubot-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/hubot-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/github/hubot-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/hubot-scripts/merges","archive_url":"https://api.github.com/repos/github/hubot-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/hubot-scripts/downloads","issues_url":"https://api.github.com/repos/github/hubot-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/github/hubot-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/github/hubot-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/github/hubot-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/hubot-scripts/labels{/name}","releases_url":"https://api.github.com/repos/github/hubot-scripts/releases{/id}","created_at":"2011-09-08T05:39:54Z","updated_at":"2015-06-04T21:09:10Z","pushed_at":"2015-06-05T16:02:47Z","git_url":"git://github.com/github/hubot-scripts.git","ssh_url":"git@github.com:github/hubot-scripts.git","clone_url":"https://github.com/github/hubot-scripts.git","svn_url":"https://github.com/github/hubot-scripts","homepage":"","size":10318,"stargazers_count":2744,"watchers_count":2744,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1739,"mirror_url":null,"open_issues_count":62,"forks":1739,"open_issues":62,"watchers":2744,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/hubot-scripts/pulls/1182"},"html":{"href":"https://github.com/github/hubot-scripts/pull/1182"},"issue":{"href":"https://api.github.com/repos/github/hubot-scripts/issues/1182"},"comments":{"href":"https://api.github.com/repos/github/hubot-scripts/issues/1182/comments"},"review_comments":{"href":"https://api.github.com/repos/github/hubot-scripts/pulls/1182/comments"},"review_comment":{"href":"https://api.github.com/repos/github/hubot-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/hubot-scripts/pulls/1182/commits"},"statuses":{"href":"https://api.github.com/repos/github/hubot-scripts/statuses/0d6e850af4672dd70b2aed6fa445d96d789ba542"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":3,"commits":1,"additions":5,"deletions":2,"changed_files":1}}