{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/2001","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/2001/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2001/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/2001/events","html_url":"https://github.com/theforeman/foreman/pull/2001","id":51213614,"number":2001,"title":"fixes #8597 - friendly ID should escape slashes for URL parameters","user":{"login":"unorthodoxgeek","id":706359,"avatar_url":"https://avatars.githubusercontent.com/u/706359?v=3","gravatar_id":"","url":"https://api.github.com/users/unorthodoxgeek","html_url":"https://github.com/unorthodoxgeek","followers_url":"https://api.github.com/users/unorthodoxgeek/followers","following_url":"https://api.github.com/users/unorthodoxgeek/following{/other_user}","gists_url":"https://api.github.com/users/unorthodoxgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/unorthodoxgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unorthodoxgeek/subscriptions","organizations_url":"https://api.github.com/users/unorthodoxgeek/orgs","repos_url":"https://api.github.com/users/unorthodoxgeek/repos","events_url":"https://api.github.com/users/unorthodoxgeek/events{/privacy}","received_events_url":"https://api.github.com/users/unorthodoxgeek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04"},{"url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-07T10:13:31Z","updated_at":"2015-01-25T09:42:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2001","html_url":"https://github.com/theforeman/foreman/pull/2001","diff_url":"https://github.com/theforeman/foreman/pull/2001.diff","patch_url":"https://github.com/theforeman/foreman/pull/2001.patch"},"body":"just a short explanation - there was a similar PR on friendly id, to which they answered - hey, why not use sluggable? (which means another table in the DB, just for fetching the ID)\r\nthere's also an option to sanitise names, which means we don't let slashes in the name (feels intrusive to me, and doesn't solve current broken items)\r\n\r\nI think that this monkey patch fixes it in the best possible way - we are able to both keep current (broken) data and have it working, we don't need to add a database table which might break current friendly ids, and this seems like the most performant option of the ones I see."},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/71362978","html_url":"https://github.com/theforeman/foreman/pull/2001#issuecomment-71362978","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2001","id":71362978,"user":{"login":"unorthodoxgeek","id":706359,"avatar_url":"https://avatars.githubusercontent.com/u/706359?v=3","gravatar_id":"","url":"https://api.github.com/users/unorthodoxgeek","html_url":"https://github.com/unorthodoxgeek","followers_url":"https://api.github.com/users/unorthodoxgeek/followers","following_url":"https://api.github.com/users/unorthodoxgeek/following{/other_user}","gists_url":"https://api.github.com/users/unorthodoxgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/unorthodoxgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unorthodoxgeek/subscriptions","organizations_url":"https://api.github.com/users/unorthodoxgeek/orgs","repos_url":"https://api.github.com/users/unorthodoxgeek/repos","events_url":"https://api.github.com/users/unorthodoxgeek/events{/privacy}","received_events_url":"https://api.github.com/users/unorthodoxgeek/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T09:42:12Z","updated_at":"2015-01-25T09:42:12Z","body":"fixed. LDAP tests might fail because of lack of Gemfile.lock"}}