{"action":"closed","number":490,"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/490","id":48003579,"html_url":"https://github.com/Ultimaker/Cura/pull/490","diff_url":"https://github.com/Ultimaker/Cura/pull/490.diff","patch_url":"https://github.com/Ultimaker/Cura/pull/490.patch","issue_url":"https://api.github.com/repos/Ultimaker/Cura/issues/490","number":490,"state":"closed","locked":false,"title":"Add back placeholder expansion for start/end gcode","user":{"login":"markwal","id":10781013,"avatar_url":"https://avatars.githubusercontent.com/u/10781013?v=3","gravatar_id":"","url":"https://api.github.com/users/markwal","html_url":"https://github.com/markwal","followers_url":"https://api.github.com/users/markwal/followers","following_url":"https://api.github.com/users/markwal/following{/other_user}","gists_url":"https://api.github.com/users/markwal/gists{/gist_id}","starred_url":"https://api.github.com/users/markwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwal/subscriptions","organizations_url":"https://api.github.com/users/markwal/orgs","repos_url":"https://api.github.com/users/markwal/repos","events_url":"https://api.github.com/users/markwal/events{/privacy}","received_events_url":"https://api.github.com/users/markwal/received_events","type":"User","site_admin":false},"body":"See issue Ultimaker/CuraEngine#240\r\n\r\nThe intent of this change it to allow token replacement in start/end\r\ngcode similar to the old Cura. Tokens are of the form\r\n{material_bed_temperature} where the name is any setting name that is\r\npassed to the engine.\r\n\r\nIn addition, four new tokens are added that expand to full gcode lines\r\nfor setting temperatures: {set_bed_temperature},\r\n{set_bed_temperature_and_wait}, {set_extruder_temperatures}, and\r\n{set_extruder_temperatures_and_wait}. These make it convenient to\r\ncontrol placement in the machine profile start/end gcode, but maintain the same\r\nsame generated temperature gcode as previously provided by\r\nFffGcodeWriter.cpp\r\n\r\nThis change will generate the same temperature gcode as FffGcodeWriter\r\nat the head, if none of the temperature tokens are present in the\r\nmachine profile. Otherwise, they're suppressed.\r\n\r\nThis change also depends on a corresponding change in CuraEngine that\r\nremoves the temperature gcode generation from FffGcodeWriter.cpp and\r\nWireframe2gcode.cpp as per suggestion from @BagelOrb in\r\nUltimaker/CuraEngine#240\r\n\r\nI'm not sure I got the per object stuff correct because I'm not sure I tracked it properly to the backend.  The intention was to retain the logic that picks up the material temperatures from the per object setting that this replaces in FffGcodeWriter.cpp, but in my testing it always picked up the temperature from the global settings.","created_at":"2015-10-18T07:37:37Z","updated_at":"2015-11-16T14:09:58Z","closed_at":"2015-11-16T14:09:58Z","merged_at":"2015-11-16T14:09:58Z","merge_commit_sha":"023b62eb51856252aaf81be499c9d567e2f6b45b","assignee":{"login":"awhiemstra","id":9590386,"avatar_url":"https://avatars.githubusercontent.com/u/9590386?v=3","gravatar_id":"","url":"https://api.github.com/users/awhiemstra","html_url":"https://github.com/awhiemstra","followers_url":"https://api.github.com/users/awhiemstra/followers","following_url":"https://api.github.com/users/awhiemstra/following{/other_user}","gists_url":"https://api.github.com/users/awhiemstra/gists{/gist_id}","starred_url":"https://api.github.com/users/awhiemstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awhiemstra/subscriptions","organizations_url":"https://api.github.com/users/awhiemstra/orgs","repos_url":"https://api.github.com/users/awhiemstra/repos","events_url":"https://api.github.com/users/awhiemstra/events{/privacy}","received_events_url":"https://api.github.com/users/awhiemstra/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/490/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/490/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/issues/490/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/4a3db419ec4545aa587985a1096bf80b3f0765f7","head":{"label":"markwal:master","ref":"master","sha":"4a3db419ec4545aa587985a1096bf80b3f0765f7","user":{"login":"markwal","id":10781013,"avatar_url":"https://avatars.githubusercontent.com/u/10781013?v=3","gravatar_id":"","url":"https://api.github.com/users/markwal","html_url":"https://github.com/markwal","followers_url":"https://api.github.com/users/markwal/followers","following_url":"https://api.github.com/users/markwal/following{/other_user}","gists_url":"https://api.github.com/users/markwal/gists{/gist_id}","starred_url":"https://api.github.com/users/markwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwal/subscriptions","organizations_url":"https://api.github.com/users/markwal/orgs","repos_url":"https://api.github.com/users/markwal/repos","events_url":"https://api.github.com/users/markwal/events{/privacy}","received_events_url":"https://api.github.com/users/markwal/received_events","type":"User","site_admin":false},"repo":{"id":42331124,"name":"Cura","full_name":"markwal/Cura","owner":{"login":"markwal","id":10781013,"avatar_url":"https://avatars.githubusercontent.com/u/10781013?v=3","gravatar_id":"","url":"https://api.github.com/users/markwal","html_url":"https://github.com/markwal","followers_url":"https://api.github.com/users/markwal/followers","following_url":"https://api.github.com/users/markwal/following{/other_user}","gists_url":"https://api.github.com/users/markwal/gists{/gist_id}","starred_url":"https://api.github.com/users/markwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwal/subscriptions","organizations_url":"https://api.github.com/users/markwal/orgs","repos_url":"https://api.github.com/users/markwal/repos","events_url":"https://api.github.com/users/markwal/events{/privacy}","received_events_url":"https://api.github.com/users/markwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markwal/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":true,"url":"https://api.github.com/repos/markwal/Cura","forks_url":"https://api.github.com/repos/markwal/Cura/forks","keys_url":"https://api.github.com/repos/markwal/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markwal/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markwal/Cura/teams","hooks_url":"https://api.github.com/repos/markwal/Cura/hooks","issue_events_url":"https://api.github.com/repos/markwal/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/markwal/Cura/events","assignees_url":"https://api.github.com/repos/markwal/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/markwal/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/markwal/Cura/tags","blobs_url":"https://api.github.com/repos/markwal/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markwal/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markwal/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/markwal/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markwal/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/markwal/Cura/languages","stargazers_url":"https://api.github.com/repos/markwal/Cura/stargazers","contributors_url":"https://api.github.com/repos/markwal/Cura/contributors","subscribers_url":"https://api.github.com/repos/markwal/Cura/subscribers","subscription_url":"https://api.github.com/repos/markwal/Cura/subscription","commits_url":"https://api.github.com/repos/markwal/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/markwal/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/markwal/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/markwal/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/markwal/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/markwal/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markwal/Cura/merges","archive_url":"https://api.github.com/repos/markwal/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markwal/Cura/downloads","issues_url":"https://api.github.com/repos/markwal/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/markwal/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/markwal/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/markwal/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markwal/Cura/labels{/name}","releases_url":"https://api.github.com/repos/markwal/Cura/releases{/id}","created_at":"2015-09-11T20:40:13Z","updated_at":"2015-09-11T20:40:14Z","pushed_at":"2015-11-16T10:28:09Z","git_url":"git://github.com/markwal/Cura.git","ssh_url":"git@github.com:markwal/Cura.git","clone_url":"https://github.com/markwal/Cura.git","svn_url":"https://github.com/markwal/Cura","homepage":"","size":31362,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"107beb9798936f18661a81ee8bf0bbff35c4e6ca","user":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"name":"Cura","full_name":"Ultimaker/Cura","owner":{"login":"Ultimaker","id":499557,"avatar_url":"https://avatars.githubusercontent.com/u/499557?v=3","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","created_at":"2014-06-16T12:55:31Z","updated_at":"2015-11-15T05:30:13Z","pushed_at":"2015-11-16T14:09:58Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":32864,"stargazers_count":87,"watchers_count":87,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":114,"forks":59,"open_issues":114,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/490"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/490"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/490"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Cura/statuses/4a3db419ec4545aa587985a1096bf80b3f0765f7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"awhiemstra","id":9590386,"avatar_url":"https://avatars.githubusercontent.com/u/9590386?v=3","gravatar_id":"","url":"https://api.github.com/users/awhiemstra","html_url":"https://github.com/awhiemstra","followers_url":"https://api.github.com/users/awhiemstra/followers","following_url":"https://api.github.com/users/awhiemstra/following{/other_user}","gists_url":"https://api.github.com/users/awhiemstra/gists{/gist_id}","starred_url":"https://api.github.com/users/awhiemstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awhiemstra/subscriptions","organizations_url":"https://api.github.com/users/awhiemstra/orgs","repos_url":"https://api.github.com/users/awhiemstra/repos","events_url":"https://api.github.com/users/awhiemstra/events{/privacy}","received_events_url":"https://api.github.com/users/awhiemstra/received_events","type":"User","site_admin":false},"comments":20,"review_comments":1,"commits":1,"additions":40,"deletions":3,"changed_files":3}}