{"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/41436815","id":41436815,"diff_hunk":"@@ -76,6 +79,10 @@\n   //\n   // `Function#apply` can be slow so we use the method's arg count, if we know it.\n   var addMethod = function(length, method, attribute) {\n+    // In case we don't catch it, deopt Underscore functions that contain\n+    // the arguments keyword.\n+    if (length > 0 && containsArguments.test(_[method])) length = 0;","path":"backbone.js","position":16,"original_position":16,"commit_id":"4c39192c97fa4b2765f2c384e8673450f8df8ddb","original_commit_id":"4c39192c97fa4b2765f2c384e8673450f8df8ddb","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Yup. It'll soon be configurable by one of the well-known symbols.","created_at":"2015-10-07T19:47:06Z","updated_at":"2015-10-07T19:47:06Z","html_url":"https://github.com/jashkenas/backbone/pull/3820#discussion_r41436815","pull_request_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3820","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments/41436815"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3820#discussion_r41436815"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3820"}}},"pull_request":{"url":"https://api.github.com/repos/jashkenas/backbone/pulls/3820","id":47041720,"html_url":"https://github.com/jashkenas/backbone/pull/3820","diff_url":"https://github.com/jashkenas/backbone/pull/3820.diff","patch_url":"https://github.com/jashkenas/backbone/pull/3820.patch","issue_url":"https://api.github.com/repos/jashkenas/backbone/issues/3820","number":3820,"state":"open","locked":false,"title":"Deopt Underscore methods that change on arguments","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"All of our currently deoptimized Underscore methods (`pick`, `omit`, `invoke`, `without`, and `difference`) change behavior based on the number of arguments pass to the call. This both adds `reduce` (and friends), and explicitly deopts any method that depends on `arguments` from falling through the cracks.\n\nSupersedes (and incorporates) #3810.","created_at":"2015-10-07T15:22:17Z","updated_at":"2015-10-07T19:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30cb79bdab2770f51f60e664d03ed03f66e1ef7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3820/commits","review_comments_url":"https://api.github.com/repos/jashkenas/backbone/pulls/3820/comments","review_comment_url":"https://api.github.com/repos/jashkenas/backbone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jashkenas/backbone/issues/3820/comments","statuses_url":"https://api.github.com/repos/jashkenas/backbone/statuses/4c39192c97fa4b2765f2c384e8673450f8df8ddb","head":{"label":"jridgewell:reduce-deopt","ref":"reduce-deopt","sha":"4c39192c97fa4b2765f2c384e8673450f8df8ddb","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":25927845,"name":"backbone","full_name":"jridgewell/backbone","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/backbone","description":"Give your JS App some Backbone with Models, Views, Collections, and Events","fork":true,"url":"https://api.github.com/repos/jridgewell/backbone","forks_url":"https://api.github.com/repos/jridgewell/backbone/forks","keys_url":"https://api.github.com/repos/jridgewell/backbone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/backbone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/backbone/teams","hooks_url":"https://api.github.com/repos/jridgewell/backbone/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/backbone/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/backbone/events","assignees_url":"https://api.github.com/repos/jridgewell/backbone/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/backbone/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/backbone/tags","blobs_url":"https://api.github.com/repos/jridgewell/backbone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/backbone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/backbone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/backbone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/backbone/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/backbone/languages","stargazers_url":"https://api.github.com/repos/jridgewell/backbone/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/backbone/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/backbone/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/backbone/subscription","commits_url":"https://api.github.com/repos/jridgewell/backbone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/backbone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/backbone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/backbone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/backbone/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/backbone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/backbone/merges","archive_url":"https://api.github.com/repos/jridgewell/backbone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/backbone/downloads","issues_url":"https://api.github.com/repos/jridgewell/backbone/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/backbone/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/backbone/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/backbone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/backbone/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/backbone/releases{/id}","created_at":"2014-10-29T15:38:55Z","updated_at":"2015-05-01T23:24:06Z","pushed_at":"2015-10-07T15:21:48Z","git_url":"git://github.com/jridgewell/backbone.git","ssh_url":"git@github.com:jridgewell/backbone.git","clone_url":"https://github.com/jridgewell/backbone.git","svn_url":"https://github.com/jridgewell/backbone","homepage":"http://backbonejs.org","size":27111,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jashkenas:master","ref":"master","sha":"4104cada6675bf41deba2540e607255ad6e50088","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":952189,"name":"backbone","full_name":"jashkenas/backbone","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/backbone","description":"Give your JS App some Backbone with Models, Views, Collections, and Events","fork":false,"url":"https://api.github.com/repos/jashkenas/backbone","forks_url":"https://api.github.com/repos/jashkenas/backbone/forks","keys_url":"https://api.github.com/repos/jashkenas/backbone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/backbone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/backbone/teams","hooks_url":"https://api.github.com/repos/jashkenas/backbone/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/backbone/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/backbone/events","assignees_url":"https://api.github.com/repos/jashkenas/backbone/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/backbone/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/backbone/tags","blobs_url":"https://api.github.com/repos/jashkenas/backbone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/backbone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/backbone/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/backbone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/backbone/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/backbone/languages","stargazers_url":"https://api.github.com/repos/jashkenas/backbone/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/backbone/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/backbone/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/backbone/subscription","commits_url":"https://api.github.com/repos/jashkenas/backbone/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/backbone/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/backbone/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/backbone/issues/comments{/number}","contents_url":"https://api.github.com/repos/jashkenas/backbone/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/backbone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/backbone/merges","archive_url":"https://api.github.com/repos/jashkenas/backbone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/backbone/downloads","issues_url":"https://api.github.com/repos/jashkenas/backbone/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/backbone/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/backbone/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/backbone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/backbone/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/backbone/releases{/id}","created_at":"2010-09-30T19:41:28Z","updated_at":"2015-10-07T19:39:01Z","pushed_at":"2015-10-07T16:40:07Z","git_url":"git://github.com/jashkenas/backbone.git","ssh_url":"git@github.com:jashkenas/backbone.git","clone_url":"https://github.com/jashkenas/backbone.git","svn_url":"https://github.com/jashkenas/backbone","homepage":"http://backbonejs.org","size":47889,"stargazers_count":23108,"watchers_count":23108,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5147,"mirror_url":null,"open_issues_count":38,"forks":5147,"open_issues":38,"watchers":23108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3820"},"html":{"href":"https://github.com/jashkenas/backbone/pull/3820"},"issue":{"href":"https://api.github.com/repos/jashkenas/backbone/issues/3820"},"comments":{"href":"https://api.github.com/repos/jashkenas/backbone/issues/3820/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3820/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/backbone/pulls/3820/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/backbone/statuses/4c39192c97fa4b2765f2c384e8673450f8df8ddb"}}}}