{"action":"closed","number":371,"pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371","id":54194983,"html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/371","diff_url":"https://github.com/JoinMarket-Org/joinmarket/pull/371.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket/pull/371.patch","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/371","number":371,"state":"closed","locked":false,"title":"fixes issues #106 and #358","user":{"login":"raedah","id":15878246,"avatar_url":"https://avatars.githubusercontent.com/u/15878246?v=3","gravatar_id":"","url":"https://api.github.com/users/raedah","html_url":"https://github.com/raedah","followers_url":"https://api.github.com/users/raedah/followers","following_url":"https://api.github.com/users/raedah/following{/other_user}","gists_url":"https://api.github.com/users/raedah/gists{/gist_id}","starred_url":"https://api.github.com/users/raedah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raedah/subscriptions","organizations_url":"https://api.github.com/users/raedah/orgs","repos_url":"https://api.github.com/users/raedah/repos","events_url":"https://api.github.com/users/raedah/events{/privacy}","received_events_url":"https://api.github.com/users/raedah/received_events","type":"User","site_admin":false},"body":"This resolves issues #106 and #358.\r\n\r\nAlso fixed an issue where the txfee contribution was not being taken account of when filling orders, which could have rarely been causing crashes if the total amount surpassed the utxo selection.\r\n\r\nAdded dust exact sized absolute offers. \r\n\r\nygbasic and ygmixdepth both pass regtest\r\nygdeluxe only passes when its configuration options are greatly simplified so that it only creates a single order. I guess an issue with how the test selects orders. The error being thrown is  https://bpaste.net/show/e82a247f1608","created_at":"2015-12-20T08:03:52Z","updated_at":"2015-12-23T12:26:38Z","closed_at":"2015-12-23T12:26:38Z","merged_at":"2015-12-23T12:26:38Z","merge_commit_sha":"653140a92e031bcc2431ef1e30fb96138201add0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371/commits","review_comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371/comments","review_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/371/comments","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/d130d7138b26e784377b101d707746a5bf600665","head":{"label":"raedah:develop","ref":"develop","sha":"d130d7138b26e784377b101d707746a5bf600665","user":{"login":"raedah","id":15878246,"avatar_url":"https://avatars.githubusercontent.com/u/15878246?v=3","gravatar_id":"","url":"https://api.github.com/users/raedah","html_url":"https://github.com/raedah","followers_url":"https://api.github.com/users/raedah/followers","following_url":"https://api.github.com/users/raedah/following{/other_user}","gists_url":"https://api.github.com/users/raedah/gists{/gist_id}","starred_url":"https://api.github.com/users/raedah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raedah/subscriptions","organizations_url":"https://api.github.com/users/raedah/orgs","repos_url":"https://api.github.com/users/raedah/repos","events_url":"https://api.github.com/users/raedah/events{/privacy}","received_events_url":"https://api.github.com/users/raedah/received_events","type":"User","site_admin":false},"repo":{"id":46302045,"name":"joinmarket","full_name":"raedah/joinmarket","owner":{"login":"raedah","id":15878246,"avatar_url":"https://avatars.githubusercontent.com/u/15878246?v=3","gravatar_id":"","url":"https://api.github.com/users/raedah","html_url":"https://github.com/raedah","followers_url":"https://api.github.com/users/raedah/followers","following_url":"https://api.github.com/users/raedah/following{/other_user}","gists_url":"https://api.github.com/users/raedah/gists{/gist_id}","starred_url":"https://api.github.com/users/raedah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raedah/subscriptions","organizations_url":"https://api.github.com/users/raedah/orgs","repos_url":"https://api.github.com/users/raedah/repos","events_url":"https://api.github.com/users/raedah/events{/privacy}","received_events_url":"https://api.github.com/users/raedah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raedah/joinmarket","description":"CoinJoin implementation with incentive structure to convince people to take part","fork":true,"url":"https://api.github.com/repos/raedah/joinmarket","forks_url":"https://api.github.com/repos/raedah/joinmarket/forks","keys_url":"https://api.github.com/repos/raedah/joinmarket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raedah/joinmarket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raedah/joinmarket/teams","hooks_url":"https://api.github.com/repos/raedah/joinmarket/hooks","issue_events_url":"https://api.github.com/repos/raedah/joinmarket/issues/events{/number}","events_url":"https://api.github.com/repos/raedah/joinmarket/events","assignees_url":"https://api.github.com/repos/raedah/joinmarket/assignees{/user}","branches_url":"https://api.github.com/repos/raedah/joinmarket/branches{/branch}","tags_url":"https://api.github.com/repos/raedah/joinmarket/tags","blobs_url":"https://api.github.com/repos/raedah/joinmarket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raedah/joinmarket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raedah/joinmarket/git/refs{/sha}","trees_url":"https://api.github.com/repos/raedah/joinmarket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raedah/joinmarket/statuses/{sha}","languages_url":"https://api.github.com/repos/raedah/joinmarket/languages","stargazers_url":"https://api.github.com/repos/raedah/joinmarket/stargazers","contributors_url":"https://api.github.com/repos/raedah/joinmarket/contributors","subscribers_url":"https://api.github.com/repos/raedah/joinmarket/subscribers","subscription_url":"https://api.github.com/repos/raedah/joinmarket/subscription","commits_url":"https://api.github.com/repos/raedah/joinmarket/commits{/sha}","git_commits_url":"https://api.github.com/repos/raedah/joinmarket/git/commits{/sha}","comments_url":"https://api.github.com/repos/raedah/joinmarket/comments{/number}","issue_comment_url":"https://api.github.com/repos/raedah/joinmarket/issues/comments{/number}","contents_url":"https://api.github.com/repos/raedah/joinmarket/contents/{+path}","compare_url":"https://api.github.com/repos/raedah/joinmarket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raedah/joinmarket/merges","archive_url":"https://api.github.com/repos/raedah/joinmarket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raedah/joinmarket/downloads","issues_url":"https://api.github.com/repos/raedah/joinmarket/issues{/number}","pulls_url":"https://api.github.com/repos/raedah/joinmarket/pulls{/number}","milestones_url":"https://api.github.com/repos/raedah/joinmarket/milestones{/number}","notifications_url":"https://api.github.com/repos/raedah/joinmarket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raedah/joinmarket/labels{/name}","releases_url":"https://api.github.com/repos/raedah/joinmarket/releases{/id}","created_at":"2015-11-16T20:54:06Z","updated_at":"2015-11-16T20:54:07Z","pushed_at":"2015-12-21T08:16:40Z","git_url":"git://github.com/raedah/joinmarket.git","ssh_url":"git@github.com:raedah/joinmarket.git","clone_url":"https://github.com/raedah/joinmarket.git","svn_url":"https://github.com/raedah/joinmarket","homepage":"","size":1342,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoinMarket-Org:develop","ref":"develop","sha":"0f7322a7605cd36ec9a58471987d88449cf0ecb1","user":{"login":"JoinMarket-Org","id":16105296,"avatar_url":"https://avatars.githubusercontent.com/u/16105296?v=3","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":27746301,"name":"joinmarket","full_name":"JoinMarket-Org/joinmarket","owner":{"login":"JoinMarket-Org","id":16105296,"avatar_url":"https://avatars.githubusercontent.com/u/16105296?v=3","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JoinMarket-Org/joinmarket","description":"CoinJoin implementation with incentive structure to convince people to take part","fork":false,"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket","forks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/forks","keys_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/teams","hooks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/hooks","issue_events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/events{/number}","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/events","assignees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/assignees{/user}","branches_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/branches{/branch}","tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/tags","blobs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/languages","stargazers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/stargazers","contributors_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/contributors","subscribers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/subscribers","subscription_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/subscription","commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/contents/{+path}","compare_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/merges","archive_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/downloads","issues_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues{/number}","pulls_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels{/name}","releases_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/releases{/id}","created_at":"2014-12-09T02:44:35Z","updated_at":"2015-12-22T18:19:05Z","pushed_at":"2015-12-23T12:26:38Z","git_url":"git://github.com/JoinMarket-Org/joinmarket.git","ssh_url":"git@github.com:JoinMarket-Org/joinmarket.git","clone_url":"https://github.com/JoinMarket-Org/joinmarket.git","svn_url":"https://github.com/JoinMarket-Org/joinmarket","homepage":"","size":1584,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":129,"forks":43,"open_issues":129,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371"},"html":{"href":"https://github.com/JoinMarket-Org/joinmarket/pull/371"},"issue":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/371"},"comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/d130d7138b26e784377b101d707746a5bf600665"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"AdamISZ","id":4278257,"avatar_url":"https://avatars.githubusercontent.com/u/4278257?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":1,"additions":236,"deletions":102,"changed_files":3}}