{"action":"created","issue":{"url":"https://api.github.com/repos/Andersbakken/rtags/issues/461","labels_url":"https://api.github.com/repos/Andersbakken/rtags/issues/461/labels{/name}","comments_url":"https://api.github.com/repos/Andersbakken/rtags/issues/461/comments","events_url":"https://api.github.com/repos/Andersbakken/rtags/issues/461/events","html_url":"https://github.com/Andersbakken/rtags/pull/461","id":110877069,"number":461,"title":"Yet another pull-request","user":{"login":"cslux","id":1712313,"avatar_url":"https://avatars.githubusercontent.com/u/1712313?v=3","gravatar_id":"","url":"https://api.github.com/users/cslux","html_url":"https://github.com/cslux","followers_url":"https://api.github.com/users/cslux/followers","following_url":"https://api.github.com/users/cslux/following{/other_user}","gists_url":"https://api.github.com/users/cslux/gists{/gist_id}","starred_url":"https://api.github.com/users/cslux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cslux/subscriptions","organizations_url":"https://api.github.com/users/cslux/orgs","repos_url":"https://api.github.com/users/cslux/repos","events_url":"https://api.github.com/users/cslux/events{/privacy}","received_events_url":"https://api.github.com/users/cslux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-11T19:07:05Z","updated_at":"2015-10-12T01:21:34Z","closed_at":"2015-10-12T01:15:32Z","pull_request":{"url":"https://api.github.com/repos/Andersbakken/rtags/pulls/461","html_url":"https://github.com/Andersbakken/rtags/pull/461","diff_url":"https://github.com/Andersbakken/rtags/pull/461.diff","patch_url":"https://github.com/Andersbakken/rtags/pull/461.patch"},"body":"- Follow the cmake module convention for `FindXXX.cmake` https://cmake.org/cgi-bin/viewcvs.cgi/CMake/Modules/readme.txt?view=markup\r\n- `REQUIRE` argument to find_package never worked\r\n- Remove the `CLANG_HACK...` something from the cache, instead but `LIBCLANG_CXXFLAGS`, `LIBCLANG_LLVM_CONFIG_EXECUTABLE` and `LIBCLANG_LIBRARY` into to cache but mark them as advanced.\r\n- Print feature summary, using the module `FeatureSummary.cmake` available since 2.8 \r\n\r\nPS: Not sure if this is valid putting my copyright notice into the file...? You could create a CONTRIBUTORS file, in the root directory, or/and an AUTHORS file.\r\n\r\nFurther, some labels in the issue tracker would help to have a better overview what the individual reports content is about. \r\n\r\nMy suggestion:\r\n\r\n- whish\r\n- bug\r\n- question\r\n- duplicate\r\n\r\nWhat do you think?\r\n\r\nregards,\r\nChristian"},"comment":{"url":"https://api.github.com/repos/Andersbakken/rtags/issues/comments/147269356","html_url":"https://github.com/Andersbakken/rtags/pull/461#issuecomment-147269356","issue_url":"https://api.github.com/repos/Andersbakken/rtags/issues/461","id":147269356,"user":{"login":"Andersbakken","id":73034,"avatar_url":"https://avatars.githubusercontent.com/u/73034?v=3","gravatar_id":"","url":"https://api.github.com/users/Andersbakken","html_url":"https://github.com/Andersbakken","followers_url":"https://api.github.com/users/Andersbakken/followers","following_url":"https://api.github.com/users/Andersbakken/following{/other_user}","gists_url":"https://api.github.com/users/Andersbakken/gists{/gist_id}","starred_url":"https://api.github.com/users/Andersbakken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andersbakken/subscriptions","organizations_url":"https://api.github.com/users/Andersbakken/orgs","repos_url":"https://api.github.com/users/Andersbakken/repos","events_url":"https://api.github.com/users/Andersbakken/events{/privacy}","received_events_url":"https://api.github.com/users/Andersbakken/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T01:21:34Z","updated_at":"2015-10-12T01:21:34Z","body":"In other words. A pull request changing it in all appropriate locations would be accepted. "}}