{"action":"created","comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/31825167","id":31825167,"diff_hunk":"@@ -0,0 +1,132 @@\n+/*\n+ * This file is part of Applied Energistics 2.\n+ * Copyright (c) 2013 - 2014, AlgorithmX2, All rights reserved.\n+ *\n+ * Applied Energistics 2 is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Lesser General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * Applied Energistics 2 is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Lesser General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with Applied Energistics 2.  If not, see <http://www.gnu.org/licenses/lgpl>.\n+ */\n+\n+package appeng.parts.reporting;\n+\n+\n+import net.minecraft.client.renderer.RenderBlocks;\n+import net.minecraft.client.renderer.Tessellator;\n+import net.minecraft.item.ItemStack;\n+import net.minecraftforge.common.util.ForgeDirection;\n+\n+import cpw.mods.fml.relauncher.Side;\n+import cpw.mods.fml.relauncher.SideOnly;\n+\n+import appeng.api.parts.IPartRenderHelper;\n+import appeng.client.texture.CableBusTextures;\n+\n+\n+public abstract class AbstractPartDisplay extends AbstractPartReporting\n+{\n+\n+\tpublic AbstractPartDisplay( ItemStack is )\n+\t{\n+\t\tsuper( is, true );\n+\t}\n+\n+\t@Override\n+\t@SideOnly( Side.CLIENT )\n+\tpublic void renderInventory( IPartRenderHelper rh, RenderBlocks renderer )\n+\t{\n+\t\trh.setBounds( 2, 2, 14, 14, 14, 16 );\n+\n+\t\trh.setTexture( CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorBack.getIcon(), this.is.getIconIndex(), CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorSides.getIcon() );\n+\t\trh.renderInventoryBox( renderer );\n+\n+\t\trh.setInvColor( this.getColor().whiteVariant );\n+\t\trh.renderInventoryFace( this.getFrontBright().getIcon(), ForgeDirection.SOUTH, renderer );\n+\n+\t\trh.setInvColor( this.getColor().mediumVariant );\n+\t\trh.renderInventoryFace( this.getFrontDark().getIcon(), ForgeDirection.SOUTH, renderer );\n+\n+\t\trh.setInvColor( this.getColor().blackVariant );\n+\t\trh.renderInventoryFace( this.getFrontColored().getIcon(), ForgeDirection.SOUTH, renderer );\n+\n+\t\trh.setBounds( 4, 4, 13, 12, 12, 14 );\n+\t\trh.renderInventoryBox( renderer );\n+\t}\n+\n+\t@Override\n+\t@SideOnly( Side.CLIENT )\n+\tpublic void renderStatic( int x, int y, int z, IPartRenderHelper rh, RenderBlocks renderer )\n+\t{\n+\t\tthis.renderCache = rh.useSimplifiedRendering( x, y, z, this, this.renderCache );\n+\n+\t\trh.setTexture( CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorBack.getIcon(), this.is.getIconIndex(), CableBusTextures.PartMonitorSides.getIcon(), CableBusTextures.PartMonitorSides.getIcon() );","path":"src/main/java/appeng/parts/reporting/AbstractPartDisplay.java","position":70,"original_position":70,"commit_id":"745aa0229cdf37a6b345749730d46dbdb2456dcd","original_commit_id":"745aa0229cdf37a6b345749730d46dbdb2456dcd","user":{"login":"thatsIch","id":2210496,"avatar_url":"https://avatars.githubusercontent.com/u/2210496?v=3","gravatar_id":"","url":"https://api.github.com/users/thatsIch","html_url":"https://github.com/thatsIch","followers_url":"https://api.github.com/users/thatsIch/followers","following_url":"https://api.github.com/users/thatsIch/following{/other_user}","gists_url":"https://api.github.com/users/thatsIch/gists{/gist_id}","starred_url":"https://api.github.com/users/thatsIch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatsIch/subscriptions","organizations_url":"https://api.github.com/users/thatsIch/orgs","repos_url":"https://api.github.com/users/thatsIch/repos","events_url":"https://api.github.com/users/thatsIch/events{/privacy}","received_events_url":"https://api.github.com/users/thatsIch/received_events","type":"User","site_admin":false},"body":"or here","created_at":"2015-06-05T15:55:58Z","updated_at":"2015-06-05T15:55:58Z","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522#discussion_r31825167","pull_request_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522","_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/31825167"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522#discussion_r31825167"},"pull_request":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522"}}},"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522","id":36314217,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522.patch","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1522","number":1522,"state":"open","locked":false,"title":"Closes #12 Added visual lock state to monitors","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"body":"Added a (simple) way of indicating a locked monitor, texture is mostly tentative for now.\r\n\r\nAlso some general refactoring of every monitor including panels and terminals.\r\nMoved the texture to constants instead of a field in `PartMonitor` and added getters for them.\r\nSo they can for example return a different texture based on the state.\r\n\r\nThis makes it necessary to override the getters in each subclass and which cannot be enforced.\r\nExcept if we introduce an abstract class for every type (panel, monitor and terminals), which then handle important parts and just leave the getter for texture abstract.\r\nBut that might be a bit overengineered.\r\n\r\nDisabled glPushAttrib and glPopAttrib for StorageMonitor as this can be a performance issue and seems to be unecessary/not causing issues for me.\r\nProbably needs further testing.\r\n\r\nRemoved the double assignment of `this.spin` from the netcode.\r\n\r\nCloses #12","created_at":"2015-05-27T15:11:05Z","updated_at":"2015-06-05T15:55:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032c0ca9eb66898e00c57b21249f765ab2fd0a7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522/commits","review_comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522/comments","review_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1522/comments","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/745aa0229cdf37a6b345749730d46dbdb2456dcd","head":{"label":"yueh:feature-12","ref":"feature-12","sha":"745aa0229cdf37a6b345749730d46dbdb2456dcd","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"repo":{"id":24421290,"name":"Applied-Energistics-2","full_name":"yueh/Applied-Energistics-2","owner":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yueh/Applied-Energistics-2","description":"A Mod about Matter, Energy and using them to conquer the world..","fork":true,"url":"https://api.github.com/repos/yueh/Applied-Energistics-2","forks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T15:45:12Z","updated_at":"2015-04-28T16:29:30Z","pushed_at":"2015-06-01T18:02:54Z","git_url":"git://github.com/yueh/Applied-Energistics-2.git","ssh_url":"git@github.com:yueh/Applied-Energistics-2.git","clone_url":"https://github.com/yueh/Applied-Energistics-2.git","svn_url":"https://github.com/yueh/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":11604,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AppliedEnergistics:master","ref":"master","sha":"2722057c81a100a8212d5a18a463276441ecdc51","user":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"repo":{"id":24395109,"name":"Applied-Energistics-2","full_name":"AppliedEnergistics/Applied-Energistics-2","owner":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":false,"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","forks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T00:48:40Z","updated_at":"2015-06-03T00:53:33Z","pushed_at":"2015-06-03T21:18:36Z","git_url":"git://github.com/AppliedEnergistics/Applied-Energistics-2.git","ssh_url":"git@github.com:AppliedEnergistics/Applied-Energistics-2.git","clone_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2.git","svn_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":20757,"stargazers_count":220,"watchers_count":220,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":107,"mirror_url":null,"open_issues_count":218,"forks":107,"open_issues":218,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1522"},"issue":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1522"},"comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1522/comments"},"review_comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522/comments"},"review_comment":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1522/commits"},"statuses":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/745aa0229cdf37a6b345749730d46dbdb2456dcd"}}}}