{"push_id":585086921,"size":23,"distinct_size":23,"ref":"refs/heads/master","head":"d5eebc4dced2c5d1326ed39d967a5db2df9edd9c","before":"6a0dd704d894d21815ba05bc85453c81292147e5","commits":[{"sha":"0ef90d1227d6b25ed17345e2547c26eac0956827","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Massage and comment iterators, part 1.\n\n+++ b/compiler/AST/iterator.cpp\nIn isSingleLoopIterator(FnSymbol* fn, Vec<BaseAST*>& asts) {\nnoted that the multi-case conditional isForLoop() || isCForLoop || isWhileDoLoop appearing\nin two places could be replaced by a dynamic_cast<>() call.  I used dynamic_cast instead\nof the isLoopStmt macro for two reasons: 1) I am confident that it does what I want; and\n2) it is almost certainly faster.\nI think the resulting code is clearer, because it first select the general case of\ninterest and then weeds out the exceptions.\n\nAdded header comments to buildZip1.  Noted that dumping all of the local variables into\nZip1-4 is sloppy and suggested a way this could be done more surgically, factoring out the\ncommon code.\nFor the loop test condition in a WhileLoop, we used to generate\n  tmp <- _cond_test(condExpr)\n  if (tmp)\n    _this.more <- 1\n  else\n    _this.more <- 0\nI leveraged the bool -> int coercion in the backend to write the simpler expression\n  _this.more <- tmp\nThis needs to be tested with the LLVM backend.\nPerformed the same simplification in buildZip3.\n\nIn rebuildIterator(IteratorInfo* ii, enabled the noOtherCalls assertion with fVerify is true.\n\n+++ b/compiler/resolution/functionResolution.cpp\nIn protoIteratorMethod(IteratorInfo* ii, const char* name, Type* retType) {\nadded comments to clarify how the defaultInitializer field is used for illicit purposes by\nthe iterator record and class definitions.\nNoted that the addition of the FLAG_RESOLVED flag could be factored into\nprotoIteratorMethod().\n\n+++ b/compiler/resolution/lowerIterators.cpp\nAdded a header comment to expandForLoop explaining what expanded single-yield iterators\nlook like.\nAdded more descriptions of how expandForLoop works.\nIn inlineIterators(), inverted the logic for identifying live blocks to instead weeding\nthem out.  The existing test did not have an associated comment.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/0ef90d1227d6b25ed17345e2547c26eac0956827"},{"sha":"fe0d0d25de24cfe4c2b2c63c2d19926ac557a429","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Massage and comment iterators, part 2.\n\nAdded header comments to buildAdvance().\nRemoved the seemingly unnecessary copy of cforLoop->testBlockGet() in buildHasMore(),\nbuildInit() and buildIncr() as noted by mnoakes.\nIn insertLocalsForRefs(Vec<Symbol*>& syms, FnSymbol* fn, reworked the logic slightly, to\nexpose that whether the RHS of a move is a primitive or a function call is a subcase of\nits being a call.  This permitted the insertion of a new INT_FATAL with more-useful error\nmessages in each (what is wrong with the expected structure of the AST at that point in\nthe execution).\nComputation of se and call within their respective \"if\" clauses places them as close as\npossible to their uses, and minimizes their respective scopes -- both elements of good\ncoding practice.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/fe0d0d25de24cfe4c2b2c63c2d19926ac557a429"},{"sha":"869710773e2137507052988a036a40980533cb59","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Merge branch 'master' into massageAndCommentIterators","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/869710773e2137507052988a036a40980533cb59"},{"sha":"aef3ab43625e141a0225c4773c8ee224f33bc58c","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Revert \"Update from 2015-02-18 00:00 to present.\"\n\nThis reverts commit 632b6c2fba4cd4b236e8299bd155ba52385896e4.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/aef3ab43625e141a0225c4773c8ee224f33bc58c"},{"sha":"dbee01d027f459a442d249314030e7d71591c989","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Revert \"Triage update for the day.\"\n\nThis reverts commit 301a284ffd606eb9d2ae7c8728361a8e141015be.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/dbee01d027f459a442d249314030e7d71591c989"},{"sha":"a50741338091017e606090e43a865af4d741b72d","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"Remove `:chpl` prefix from cross-reference in Random.chpl.\n\nSince chpldoc ensures the default-domain for Sphinx is chpl, the\ncross-reference do not need to specify chpl. There is no harm in specifying the\nchpl, but it is easier to write the docs without it.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/a50741338091017e606090e43a865af4d741b72d"},{"sha":"11fa7c34759ada27f189d022b88a6a47d9e156e9","author":{"email":"76b11d3d92bad7a642f7c1b15d8a810ff35b7019@users.noreply.github.com","name":"Brad Chamberlain"},"message":"Fixing a default sparse domain idxType bug and filing a test against it\n\nKyle mentioned yesterday that the default sparse domain map\ndoesn't do well when the idxType is something other than  'int'\n(or perhaps, something that doesn't coerce to 'int', like,\nspecifically 'uint').  The fix turned out to be trivial,\nand I filed a test against the issue so that it doesn't crop\nup again in the future.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/11fa7c34759ada27f189d022b88a6a47d9e156e9"},{"sha":"3e9a529a97acdaca9192b540f56b15d76d5ee428","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"Merge pull request #1379 from thomasvandoren/no-prefixes-for-random\n\nRemove `:chpl` prefix from cross-reference in Random.chpl.\r\n\r\nSince chpldoc ensures the default-domain for Sphinx is chpl, the\r\ncross-reference do not need to specify chpl. There is no harm in specifying the\r\nchpl, but it is easier to write the docs without it.\r\n\r\nr: @bradcray","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/3e9a529a97acdaca9192b540f56b15d76d5ee428"},{"sha":"0ed2a969a0deba0650e168f334c171fcd715f6ee","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Tweaks in response to reviewer comments.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/0ed2a969a0deba0650e168f334c171fcd715f6ee"},{"sha":"3e1e9b6faf0e376bcb6da6da889a88de3485b442","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"Update nightly testing scripts to send to internal email lists.\n\nThe external ones are dropping lots of messages...","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/3e1e9b6faf0e376bcb6da6da889a88de3485b442"},{"sha":"4ec335bd546379044e098bfb03e9a09da1596da9","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"Send darwin emails using relay smtp server.\n\nThe last few times chapelmac has rebooted, the postfix mail service has not\nstarted. Just use the relay server directly instead of fiddling with the\npostfix service.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/4ec335bd546379044e098bfb03e9a09da1596da9"},{"sha":"f1bdb8fa9e0d067e1f1080bbfacb2a3e09a52219","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"fix typo","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/f1bdb8fa9e0d067e1f1080bbfacb2a3e09a52219"},{"sha":"ca6dafe48acfb9958cdd2f6f9f329db24c9387da","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Merge branch 'master' of github.com:hildeth/chapel","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/ca6dafe48acfb9958cdd2f6f9f329db24c9387da"},{"sha":"d18ff0043016f76c19420c2cecce1a4d0e171a45","author":{"email":"76b11d3d92bad7a642f7c1b15d8a810ff35b7019@users.noreply.github.com","name":"Brad Chamberlain"},"message":"Merge pull request #1380 from bradcray/fixDefaultSpsIdxType\n\nFixing a default sparse domain idxType bug and filing a test against it\r\n\r\n[reviewed by Kyle]\r\n\r\nKyle mentioned yesterday that the default sparse domain map\r\ndoesn't do well when the idxType is something other than  'int'\r\n(or perhaps, something that doesn't coerce to 'int', like,\r\nspecifically 'uint').  The fix turned out to be trivial,\r\nand I filed a test against the issue so that it doesn't crop\r\nup again in the future -- specifically, I changed an index(rank)\r\nexpression into index(rank, idxType).","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/d18ff0043016f76c19420c2cecce1a4d0e171a45"},{"sha":"02419a3eb3bd9730a6c7e876f417eb60f2a10872","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Merge branch 'master' of https://github.com/chapel-lang/chapel","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/02419a3eb3bd9730a6c7e876f417eb60f2a10872"},{"sha":"669bab38c52681b936182b68c68c19a1f5d52772","author":{"email":"e01f471a0a039ccd6e0007037df8ddb2a870c29b@gmail.com","name":"Thomas Van Doren"},"message":"Merge pull request #1382 from thomasvandoren/internal-emails\n\nUpdate nightly testing scripts to send to internal email lists.\r\n\r\nThe external ones are dropping lots of messages...\r\n\r\nAlso, send darwin emails using relay smtp server. The last few\r\ntimes chapelmac has rebooted, the postfix mail service has not\r\nstarted. Just use the relay server directly instead of fiddling with\r\nthe postfix service.\r\n\r\nr: @bradcray","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/669bab38c52681b936182b68c68c19a1f5d52772"},{"sha":"cae57a43e9a5516983dcee922555a2cffd4b5e65","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Added an explicit cast when setting 'more' in zip1 and zip3.\n\nThis makes the cast from the bool type of the conditional expression to the int type of\nthe 'more' field.  I also added a comment about the meaning of 'more' in this context.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/cae57a43e9a5516983dcee922555a2cffd4b5e65"},{"sha":"1eb0e2a112b5e6f508fc94ea1f215a7106d8cab6","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Merge branch 'master' into massageAndCommentIterators\n\nConflicts:\n\ttest/REGRESSIONS\n\ttest/REGRESSIONS-hw","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/1eb0e2a112b5e6f508fc94ea1f215a7106d8cab6"},{"sha":"0f44fde771595e11e667ce83bb6fbeeb46ca60e9","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Clean up REGRESSIONS file differences.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/0f44fde771595e11e667ce83bb6fbeeb46ca60e9"},{"sha":"a1f048adcfbb57135177008c623d71f3c125b095","author":{"email":"2b94302d36b86f447dddbe1183d3dd7ada803772@cray.com","name":"Thomas H Hildebrandt"},"message":"Additional format tweaks.","distinct":true,"url":"https://api.github.com/repos/lydia-duncan/chapel/commits/a1f048adcfbb57135177008c623d71f3c125b095"}]}