{"action":"created","comment":{"url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments/25159319","id":25159319,"diff_hunk":"@@ -0,0 +1,41 @@\n+require 'sinatra/base'\n+require 'active_support/all'\n+require 'sinatra'\n+require_relative './game'\n+require_relative './player'\n+\n+class Rps < Sinatra::Base\n+","path":"lib/rps.rb","position":8,"original_position":8,"commit_id":"e6dc2f3614997648fc32dc30dc121d1a39cb6214","original_commit_id":"e6dc2f3614997648fc32dc30dc121d1a39cb6214","user":{"login":"tansaku","id":30216,"avatar_url":"https://avatars.githubusercontent.com/u/30216?v=3","gravatar_id":"","url":"https://api.github.com/users/tansaku","html_url":"https://github.com/tansaku","followers_url":"https://api.github.com/users/tansaku/followers","following_url":"https://api.github.com/users/tansaku/following{/other_user}","gists_url":"https://api.github.com/users/tansaku/gists{/gist_id}","starred_url":"https://api.github.com/users/tansaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tansaku/subscriptions","organizations_url":"https://api.github.com/users/tansaku/orgs","repos_url":"https://api.github.com/users/tansaku/repos","events_url":"https://api.github.com/users/tansaku/events{/privacy}","received_events_url":"https://api.github.com/users/tansaku/received_events","type":"User","site_admin":false},"body":"please ensure to remove excess empty lines from places like this","created_at":"2015-02-23T12:12:44Z","updated_at":"2015-02-23T12:12:44Z","html_url":"https://github.com/makersacademy/rps-challenge/pull/9#discussion_r25159319","pull_request_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments/25159319"},"html":{"href":"https://github.com/makersacademy/rps-challenge/pull/9#discussion_r25159319"},"pull_request":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9","id":29792501,"html_url":"https://github.com/makersacademy/rps-challenge/pull/9","diff_url":"https://github.com/makersacademy/rps-challenge/pull/9.diff","patch_url":"https://github.com/makersacademy/rps-challenge/pull/9.patch","issue_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/9","number":9,"state":"open","locked":false,"title":"Rock Paper Scissors","user":{"login":"braunsnow","id":10322095,"avatar_url":"https://avatars.githubusercontent.com/u/10322095?v=3","gravatar_id":"","url":"https://api.github.com/users/braunsnow","html_url":"https://github.com/braunsnow","followers_url":"https://api.github.com/users/braunsnow/followers","following_url":"https://api.github.com/users/braunsnow/following{/other_user}","gists_url":"https://api.github.com/users/braunsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/braunsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braunsnow/subscriptions","organizations_url":"https://api.github.com/users/braunsnow/orgs","repos_url":"https://api.github.com/users/braunsnow/repos","events_url":"https://api.github.com/users/braunsnow/events{/privacy}","received_events_url":"https://api.github.com/users/braunsnow/received_events","type":"User","site_admin":false},"body":"Negatives: I started off using cucumber and then felt like I was being hindered a bit so prioritise completing the game and getting a good understanding of sessions. I tried working on a generic style sheet but wasn't happy with the result and a bit confused overall. My website code needs to be neater and should make better use of GET POST conventions.\r\n\r\nPros: I fully understand sessions, and feel comfortable with the display process in erb. ","created_at":"2015-02-23T08:38:20Z","updated_at":"2015-02-23T12:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93f57c9963195a7b810a527044ff97e21589bc8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9/commits","review_comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9/comments","review_comment_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/9/comments","statuses_url":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/e6dc2f3614997648fc32dc30dc121d1a39cb6214","head":{"label":"braunsnow:master","ref":"master","sha":"e6dc2f3614997648fc32dc30dc121d1a39cb6214","user":{"login":"braunsnow","id":10322095,"avatar_url":"https://avatars.githubusercontent.com/u/10322095?v=3","gravatar_id":"","url":"https://api.github.com/users/braunsnow","html_url":"https://github.com/braunsnow","followers_url":"https://api.github.com/users/braunsnow/followers","following_url":"https://api.github.com/users/braunsnow/following{/other_user}","gists_url":"https://api.github.com/users/braunsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/braunsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braunsnow/subscriptions","organizations_url":"https://api.github.com/users/braunsnow/orgs","repos_url":"https://api.github.com/users/braunsnow/repos","events_url":"https://api.github.com/users/braunsnow/events{/privacy}","received_events_url":"https://api.github.com/users/braunsnow/received_events","type":"User","site_admin":false},"repo":{"id":31061963,"name":"rps-challenge","full_name":"braunsnow/rps-challenge","owner":{"login":"braunsnow","id":10322095,"avatar_url":"https://avatars.githubusercontent.com/u/10322095?v=3","gravatar_id":"","url":"https://api.github.com/users/braunsnow","html_url":"https://github.com/braunsnow","followers_url":"https://api.github.com/users/braunsnow/followers","following_url":"https://api.github.com/users/braunsnow/following{/other_user}","gists_url":"https://api.github.com/users/braunsnow/gists{/gist_id}","starred_url":"https://api.github.com/users/braunsnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braunsnow/subscriptions","organizations_url":"https://api.github.com/users/braunsnow/orgs","repos_url":"https://api.github.com/users/braunsnow/repos","events_url":"https://api.github.com/users/braunsnow/events{/privacy}","received_events_url":"https://api.github.com/users/braunsnow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/braunsnow/rps-challenge","description":"Create the Rock Paper Scissors Game","fork":true,"url":"https://api.github.com/repos/braunsnow/rps-challenge","forks_url":"https://api.github.com/repos/braunsnow/rps-challenge/forks","keys_url":"https://api.github.com/repos/braunsnow/rps-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/braunsnow/rps-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/braunsnow/rps-challenge/teams","hooks_url":"https://api.github.com/repos/braunsnow/rps-challenge/hooks","issue_events_url":"https://api.github.com/repos/braunsnow/rps-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/braunsnow/rps-challenge/events","assignees_url":"https://api.github.com/repos/braunsnow/rps-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/braunsnow/rps-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/braunsnow/rps-challenge/tags","blobs_url":"https://api.github.com/repos/braunsnow/rps-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/braunsnow/rps-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/braunsnow/rps-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/braunsnow/rps-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/braunsnow/rps-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/braunsnow/rps-challenge/languages","stargazers_url":"https://api.github.com/repos/braunsnow/rps-challenge/stargazers","contributors_url":"https://api.github.com/repos/braunsnow/rps-challenge/contributors","subscribers_url":"https://api.github.com/repos/braunsnow/rps-challenge/subscribers","subscription_url":"https://api.github.com/repos/braunsnow/rps-challenge/subscription","commits_url":"https://api.github.com/repos/braunsnow/rps-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/braunsnow/rps-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/braunsnow/rps-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/braunsnow/rps-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/braunsnow/rps-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/braunsnow/rps-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/braunsnow/rps-challenge/merges","archive_url":"https://api.github.com/repos/braunsnow/rps-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/braunsnow/rps-challenge/downloads","issues_url":"https://api.github.com/repos/braunsnow/rps-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/braunsnow/rps-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/braunsnow/rps-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/braunsnow/rps-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/braunsnow/rps-challenge/labels{/name}","releases_url":"https://api.github.com/repos/braunsnow/rps-challenge/releases{/id}","created_at":"2015-02-20T11:24:46Z","updated_at":"2015-02-23T09:45:33Z","pushed_at":"2015-02-23T09:45:33Z","git_url":"git://github.com/braunsnow/rps-challenge.git","ssh_url":"git@github.com:braunsnow/rps-challenge.git","clone_url":"https://github.com/braunsnow/rps-challenge.git","svn_url":"https://github.com/braunsnow/rps-challenge","homepage":null,"size":163,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"makersacademy:master","ref":"master","sha":"9799328ada5a799f838ce98991d8dc9eb88737c1","user":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars.githubusercontent.com/u/3636186?v=3","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":27006066,"name":"rps-challenge","full_name":"makersacademy/rps-challenge","owner":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars.githubusercontent.com/u/3636186?v=3","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makersacademy/rps-challenge","description":"Create the Rock Paper Scissors Game","fork":false,"url":"https://api.github.com/repos/makersacademy/rps-challenge","forks_url":"https://api.github.com/repos/makersacademy/rps-challenge/forks","keys_url":"https://api.github.com/repos/makersacademy/rps-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makersacademy/rps-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makersacademy/rps-challenge/teams","hooks_url":"https://api.github.com/repos/makersacademy/rps-challenge/hooks","issue_events_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/makersacademy/rps-challenge/events","assignees_url":"https://api.github.com/repos/makersacademy/rps-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/makersacademy/rps-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/makersacademy/rps-challenge/tags","blobs_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/makersacademy/rps-challenge/languages","stargazers_url":"https://api.github.com/repos/makersacademy/rps-challenge/stargazers","contributors_url":"https://api.github.com/repos/makersacademy/rps-challenge/contributors","subscribers_url":"https://api.github.com/repos/makersacademy/rps-challenge/subscribers","subscription_url":"https://api.github.com/repos/makersacademy/rps-challenge/subscription","commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/makersacademy/rps-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/makersacademy/rps-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makersacademy/rps-challenge/merges","archive_url":"https://api.github.com/repos/makersacademy/rps-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makersacademy/rps-challenge/downloads","issues_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/makersacademy/rps-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/makersacademy/rps-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makersacademy/rps-challenge/labels{/name}","releases_url":"https://api.github.com/repos/makersacademy/rps-challenge/releases{/id}","created_at":"2014-11-22T17:15:17Z","updated_at":"2015-02-20T10:05:38Z","pushed_at":"2015-02-21T08:04:34Z","git_url":"git://github.com/makersacademy/rps-challenge.git","ssh_url":"git@github.com:makersacademy/rps-challenge.git","clone_url":"https://github.com/makersacademy/rps-challenge.git","svn_url":"https://github.com/makersacademy/rps-challenge","homepage":null,"size":129,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":20,"forks":23,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9"},"html":{"href":"https://github.com/makersacademy/rps-challenge/pull/9"},"issue":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/issues/9"},"comments":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/e6dc2f3614997648fc32dc30dc121d1a39cb6214"}}}}