{"action":"created","comment":{"url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/comments/28766942","id":28766942,"diff_hunk":"@@ -51,102 +51,101 @@ angular.module('Pie').factory('pieFactory', function (utils, jsonValue, termServ\n \n   var instance = {\n     renderView: function ($terms) {\n-      $$.generateChartData($terms);\n-      $('.pie-Chart-Container').highcharts({\n-        colors: data4PieChart.colors,\n-        chart: {\n-          backgroundColor: '#f1f3f7',\n-          plotBorderColor: '#1f1f1f'\n-        },\n-        title: {\n-          text: ''\n-        },\n-        legend: {\n-          itemStyle: {\n-            color: '#1f1f1f'\n-          },\n-          itemHoverStyle: {\n-            color: '#1f1f1f'\n+      $translate([\"salaryRangeJob\", \"jobNumber\", \"salaryRangeInJob\", \"jobNumberLabel\"]).then(function (translate) {\n+        $$.generateChartData($terms);\n+        $('.pie-Chart-Container').highcharts({\n+          colors: data4PieChart.colors,\n+          chart: {\n+            backgroundColor: '#f1f3f7',\n+            plotBorderColor: '#1f1f1f'\n           },\n-          itemHiddenStyle: {\n-            color: '#1f1f1f'\n-          }\n-        },\n-        labels: {\n-          style: {\n-            color: '#1f1f1f'\n-          }\n-        },\n-        tooltip: {\n-          formatter: function () {\n-            if (localStorage.getItem(\"PIE_CHART_ITEM_TYPE\") === jsonValue.pieChartType.job) {\n-              return sprintf(\"<b>%(salRange)s</b> <br/>a month in average for jobs in <b>%(label)s</b>\", terms[this.point.index]);\n-            }\n-            return sprintf(\"<b>%(count)s</b> jobs in <b>%(label)s</b>\", terms[this.point.index]);\n-          }\n-        },\n-        plotOptions: {\n-          pie: {\n-            allowPointSelect: true,\n-            cursor: 'pointer',\n-            dataLabels: {\n-              enabled: true,\n-              //format: '<b>{point.y}</b> jobs in <b>{point.name}</b>',\n-              formatter: function () {\n-                var termLabel = this.key;\n-                var index = data4PieChart.labels.indexOf(termLabel);\n-                if (index !== -1) {\n-                  if (localStorage.getItem(\"PIE_CHART_ITEM_TYPE\") === jsonValue.pieChartType.job) {\n-                    if (data4PieChart.data[index] instanceof Array) {\n-                      return \"<span>\" + data4PieChart.data[index][1] + ' jobs in ' + termLabel + \"</span>\";\n-                    } else {\n-                      return \"<span>\" + data4PieChart.data[index].y + ' jobs in ' + termLabel + \"</span>\";\n-                    }\n-                  } else {\n-                    return \"<span>\" + data4PieChart.data[index][2] + ' in ' + termLabel + \"</span>\";\n-                  }\n-                }\n-              },\n-              style: {\n-                color: (Highcharts.theme && Highcharts.theme.contrastTextColor) || 'black'\n-              }\n-            }\n+          title: {\n+            text: ''\n           },\n-          series: {\n-            dataLabels: {\n+          legend: {\n+            itemStyle: {\n               color: '#1f1f1f'\n             },\n-            marker: {\n-              lineColor: '#333'\n+            itemHoverStyle: {\n+              color: '#1f1f1f'\n             },\n-            animation: false\n+            itemHiddenStyle: {\n+              color: '#1f1f1f'\n+            }\n           },\n-          boxplot: {\n-            fillColor: '#505053'\n+          labels: {\n+            style: {\n+              color: '#1f1f1f'\n+            }\n           },\n-          candlestick: {\n-            lineColor: 'white'\n+          tooltip: {\n+            formatter: function () {\n+              var term = terms[this.point.index];\n+              if (localStorage.getItem(\"PIE_CHART_ITEM_TYPE\") === jsonValue.pieChartType.job) {\n+                return sprintf(translate.salaryRangeJob, term.salRange, term.label);\n+              }\n+              return sprintf(translate.jobNumber, term.count, term.label);\n+            }\n           },\n-          errorbar: {\n-            color: 'white'\n-          }\n-        },\n-        series: [{\n-          type: 'pie',\n-          name: 'Jobs',\n-          innerSize: innerDonut,\n-          point: {\n-            events: {\n-              click: function (e) {\n-                utils.go2SkillAnalyticPage(scope, terms[this.index].term);\n+          plotOptions: {\n+            pie: {\n+              allowPointSelect: true,\n+              cursor: 'pointer',\n+              dataLabels: {\n+                enabled: true,\n+                //format: '<b>{point.y}</b> jobs in <b>{point.name}</b>',\n+                formatter: function () {\n+                  var term = terms[this.point.index];\n+                  if (localStorage.getItem(\"PIE_CHART_ITEM_TYPE\") === jsonValue.pieChartType.job) {\n+                    return sprintf(translate.jobNumberLabel, term.count, term.label);\n+                  }\n+                  else {\n+                    return sprintf(translate.salaryRangeInJob, term.salRange, term.label);\n+                  }\n+                },\n+                style: {\n+                  color: (Highcharts.theme && Highcharts.theme.contrastTextColor) || 'black'","path":"src/main/webapp/assets/modules/pie-chart/pie-chart.fac.js","position":164,"original_position":164,"commit_id":"bcdda8181b179d5855dccf8f4bb444f588e5ead1","original_commit_id":"bcdda8181b179d5855dccf8f4bb444f588e5ead1","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long.<br>'Highcharts' is not defined.","created_at":"2015-04-21T10:41:54Z","updated_at":"2015-04-21T10:41:54Z","html_url":"https://github.com/chrisshayan/TechLooper/pull/232#discussion_r28766942","pull_request_url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232","_links":{"self":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/comments/28766942"},"html":{"href":"https://github.com/chrisshayan/TechLooper/pull/232#discussion_r28766942"},"pull_request":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232"}}},"pull_request":{"url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232","id":33748809,"html_url":"https://github.com/chrisshayan/TechLooper/pull/232","diff_url":"https://github.com/chrisshayan/TechLooper/pull/232.diff","patch_url":"https://github.com/chrisshayan/TechLooper/pull/232.patch","issue_url":"https://api.github.com/repos/chrisshayan/TechLooper/issues/232","number":232,"state":"open","locked":false,"title":"Please pull the latest code","user":{"login":"khoa-nd","id":1620282,"avatar_url":"https://avatars.githubusercontent.com/u/1620282?v=3","gravatar_id":"","url":"https://api.github.com/users/khoa-nd","html_url":"https://github.com/khoa-nd","followers_url":"https://api.github.com/users/khoa-nd/followers","following_url":"https://api.github.com/users/khoa-nd/following{/other_user}","gists_url":"https://api.github.com/users/khoa-nd/gists{/gist_id}","starred_url":"https://api.github.com/users/khoa-nd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoa-nd/subscriptions","organizations_url":"https://api.github.com/users/khoa-nd/orgs","repos_url":"https://api.github.com/users/khoa-nd/repos","events_url":"https://api.github.com/users/khoa-nd/events{/privacy}","received_events_url":"https://api.github.com/users/khoa-nd/received_events","type":"User","site_admin":false},"body":"- Support vietnamese language for charts\r\n- Change \"Detail\" to 'Details\"\r\n- Change white color for mobile version","created_at":"2015-04-21T10:41:47Z","updated_at":"2015-04-21T10:41:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3bec029bae011bae374cfa5fdbd36654aa29cce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232/commits","review_comments_url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232/comments","review_comment_url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chrisshayan/TechLooper/issues/232/comments","statuses_url":"https://api.github.com/repos/chrisshayan/TechLooper/statuses/bcdda8181b179d5855dccf8f4bb444f588e5ead1","head":{"label":"khoa-nd:master","ref":"master","sha":"bcdda8181b179d5855dccf8f4bb444f588e5ead1","user":{"login":"khoa-nd","id":1620282,"avatar_url":"https://avatars.githubusercontent.com/u/1620282?v=3","gravatar_id":"","url":"https://api.github.com/users/khoa-nd","html_url":"https://github.com/khoa-nd","followers_url":"https://api.github.com/users/khoa-nd/followers","following_url":"https://api.github.com/users/khoa-nd/following{/other_user}","gists_url":"https://api.github.com/users/khoa-nd/gists{/gist_id}","starred_url":"https://api.github.com/users/khoa-nd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoa-nd/subscriptions","organizations_url":"https://api.github.com/users/khoa-nd/orgs","repos_url":"https://api.github.com/users/khoa-nd/repos","events_url":"https://api.github.com/users/khoa-nd/events{/privacy}","received_events_url":"https://api.github.com/users/khoa-nd/received_events","type":"User","site_admin":false},"repo":{"id":25450824,"name":"TechLooper","full_name":"khoa-nd/TechLooper","owner":{"login":"khoa-nd","id":1620282,"avatar_url":"https://avatars.githubusercontent.com/u/1620282?v=3","gravatar_id":"","url":"https://api.github.com/users/khoa-nd","html_url":"https://github.com/khoa-nd","followers_url":"https://api.github.com/users/khoa-nd/followers","following_url":"https://api.github.com/users/khoa-nd/following{/other_user}","gists_url":"https://api.github.com/users/khoa-nd/gists{/gist_id}","starred_url":"https://api.github.com/users/khoa-nd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khoa-nd/subscriptions","organizations_url":"https://api.github.com/users/khoa-nd/orgs","repos_url":"https://api.github.com/users/khoa-nd/repos","events_url":"https://api.github.com/users/khoa-nd/events{/privacy}","received_events_url":"https://api.github.com/users/khoa-nd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khoa-nd/TechLooper","description":"This is VietnamWorks Open Source project. TechLooper is an aggregator which will detects the market demands and trends for IT jobs.","fork":true,"url":"https://api.github.com/repos/khoa-nd/TechLooper","forks_url":"https://api.github.com/repos/khoa-nd/TechLooper/forks","keys_url":"https://api.github.com/repos/khoa-nd/TechLooper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khoa-nd/TechLooper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khoa-nd/TechLooper/teams","hooks_url":"https://api.github.com/repos/khoa-nd/TechLooper/hooks","issue_events_url":"https://api.github.com/repos/khoa-nd/TechLooper/issues/events{/number}","events_url":"https://api.github.com/repos/khoa-nd/TechLooper/events","assignees_url":"https://api.github.com/repos/khoa-nd/TechLooper/assignees{/user}","branches_url":"https://api.github.com/repos/khoa-nd/TechLooper/branches{/branch}","tags_url":"https://api.github.com/repos/khoa-nd/TechLooper/tags","blobs_url":"https://api.github.com/repos/khoa-nd/TechLooper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khoa-nd/TechLooper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khoa-nd/TechLooper/git/refs{/sha}","trees_url":"https://api.github.com/repos/khoa-nd/TechLooper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khoa-nd/TechLooper/statuses/{sha}","languages_url":"https://api.github.com/repos/khoa-nd/TechLooper/languages","stargazers_url":"https://api.github.com/repos/khoa-nd/TechLooper/stargazers","contributors_url":"https://api.github.com/repos/khoa-nd/TechLooper/contributors","subscribers_url":"https://api.github.com/repos/khoa-nd/TechLooper/subscribers","subscription_url":"https://api.github.com/repos/khoa-nd/TechLooper/subscription","commits_url":"https://api.github.com/repos/khoa-nd/TechLooper/commits{/sha}","git_commits_url":"https://api.github.com/repos/khoa-nd/TechLooper/git/commits{/sha}","comments_url":"https://api.github.com/repos/khoa-nd/TechLooper/comments{/number}","issue_comment_url":"https://api.github.com/repos/khoa-nd/TechLooper/issues/comments{/number}","contents_url":"https://api.github.com/repos/khoa-nd/TechLooper/contents/{+path}","compare_url":"https://api.github.com/repos/khoa-nd/TechLooper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khoa-nd/TechLooper/merges","archive_url":"https://api.github.com/repos/khoa-nd/TechLooper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khoa-nd/TechLooper/downloads","issues_url":"https://api.github.com/repos/khoa-nd/TechLooper/issues{/number}","pulls_url":"https://api.github.com/repos/khoa-nd/TechLooper/pulls{/number}","milestones_url":"https://api.github.com/repos/khoa-nd/TechLooper/milestones{/number}","notifications_url":"https://api.github.com/repos/khoa-nd/TechLooper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khoa-nd/TechLooper/labels{/name}","releases_url":"https://api.github.com/repos/khoa-nd/TechLooper/releases{/id}","created_at":"2014-10-20T04:32:02Z","updated_at":"2015-04-21T10:36:57Z","pushed_at":"2015-04-21T10:36:57Z","git_url":"git://github.com/khoa-nd/TechLooper.git","ssh_url":"git@github.com:khoa-nd/TechLooper.git","clone_url":"https://github.com/khoa-nd/TechLooper.git","svn_url":"https://github.com/khoa-nd/TechLooper","homepage":null,"size":29400,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chrisshayan:Release25","ref":"Release25","sha":"5c0cafefc3a015ee4080242d28b2ab8ccc4a6151","user":{"login":"chrisshayan","id":4226119,"avatar_url":"https://avatars.githubusercontent.com/u/4226119?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisshayan","html_url":"https://github.com/chrisshayan","followers_url":"https://api.github.com/users/chrisshayan/followers","following_url":"https://api.github.com/users/chrisshayan/following{/other_user}","gists_url":"https://api.github.com/users/chrisshayan/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisshayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisshayan/subscriptions","organizations_url":"https://api.github.com/users/chrisshayan/orgs","repos_url":"https://api.github.com/users/chrisshayan/repos","events_url":"https://api.github.com/users/chrisshayan/events{/privacy}","received_events_url":"https://api.github.com/users/chrisshayan/received_events","type":"User","site_admin":false},"repo":{"id":21732596,"name":"TechLooper","full_name":"chrisshayan/TechLooper","owner":{"login":"chrisshayan","id":4226119,"avatar_url":"https://avatars.githubusercontent.com/u/4226119?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisshayan","html_url":"https://github.com/chrisshayan","followers_url":"https://api.github.com/users/chrisshayan/followers","following_url":"https://api.github.com/users/chrisshayan/following{/other_user}","gists_url":"https://api.github.com/users/chrisshayan/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisshayan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisshayan/subscriptions","organizations_url":"https://api.github.com/users/chrisshayan/orgs","repos_url":"https://api.github.com/users/chrisshayan/repos","events_url":"https://api.github.com/users/chrisshayan/events{/privacy}","received_events_url":"https://api.github.com/users/chrisshayan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisshayan/TechLooper","description":"This is VietnamWorks Open Source project. TechLooper is an aggregator which will detects the market demands and trends for IT jobs.","fork":false,"url":"https://api.github.com/repos/chrisshayan/TechLooper","forks_url":"https://api.github.com/repos/chrisshayan/TechLooper/forks","keys_url":"https://api.github.com/repos/chrisshayan/TechLooper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisshayan/TechLooper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisshayan/TechLooper/teams","hooks_url":"https://api.github.com/repos/chrisshayan/TechLooper/hooks","issue_events_url":"https://api.github.com/repos/chrisshayan/TechLooper/issues/events{/number}","events_url":"https://api.github.com/repos/chrisshayan/TechLooper/events","assignees_url":"https://api.github.com/repos/chrisshayan/TechLooper/assignees{/user}","branches_url":"https://api.github.com/repos/chrisshayan/TechLooper/branches{/branch}","tags_url":"https://api.github.com/repos/chrisshayan/TechLooper/tags","blobs_url":"https://api.github.com/repos/chrisshayan/TechLooper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisshayan/TechLooper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisshayan/TechLooper/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisshayan/TechLooper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisshayan/TechLooper/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisshayan/TechLooper/languages","stargazers_url":"https://api.github.com/repos/chrisshayan/TechLooper/stargazers","contributors_url":"https://api.github.com/repos/chrisshayan/TechLooper/contributors","subscribers_url":"https://api.github.com/repos/chrisshayan/TechLooper/subscribers","subscription_url":"https://api.github.com/repos/chrisshayan/TechLooper/subscription","commits_url":"https://api.github.com/repos/chrisshayan/TechLooper/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisshayan/TechLooper/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisshayan/TechLooper/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisshayan/TechLooper/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisshayan/TechLooper/contents/{+path}","compare_url":"https://api.github.com/repos/chrisshayan/TechLooper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisshayan/TechLooper/merges","archive_url":"https://api.github.com/repos/chrisshayan/TechLooper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisshayan/TechLooper/downloads","issues_url":"https://api.github.com/repos/chrisshayan/TechLooper/issues{/number}","pulls_url":"https://api.github.com/repos/chrisshayan/TechLooper/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisshayan/TechLooper/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisshayan/TechLooper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisshayan/TechLooper/labels{/name}","releases_url":"https://api.github.com/repos/chrisshayan/TechLooper/releases{/id}","created_at":"2014-07-11T10:34:18Z","updated_at":"2015-04-21T09:41:01Z","pushed_at":"2015-04-21T10:41:48Z","git_url":"git://github.com/chrisshayan/TechLooper.git","ssh_url":"git@github.com:chrisshayan/TechLooper.git","clone_url":"https://github.com/chrisshayan/TechLooper.git","svn_url":"https://github.com/chrisshayan/TechLooper","homepage":null,"size":28536,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232"},"html":{"href":"https://github.com/chrisshayan/TechLooper/pull/232"},"issue":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/issues/232"},"comments":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/chrisshayan/TechLooper/statuses/bcdda8181b179d5855dccf8f4bb444f588e5ead1"}}}}