{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/comments/44273081","id":44273081,"diff_hunk":"@@ -148,11 +174,24 @@\n           // Resolve promise if user already picked one device.\n           return Promise.resolve(this._device);\n         }\n-        if (!this.servicesFilter || this.servicesFilter.length == 0) {\n-          return Promise.reject(new Error('Please set Bluetooth services filter.'));\n+        options = options||{};\n+        if ((!this.servicesFilter || this.servicesFilter.length == 0)\n+                &&!this.nameFilter&&!this.namePrefixFilter) {\n+          if (!(options.filters&&options.filters.length)) {","path":"platinum-bluetooth-device.html","position":65,"original_position":65,"commit_id":"d5ce3d68d29f1a47b35a4b428710243bea22ffb2","original_commit_id":"d5ce3d68d29f1a47b35a4b428710243bea22ffb2","user":{"login":"beaufortfrancois","id":634478,"avatar_url":"https://avatars.githubusercontent.com/u/634478?v=3","gravatar_id":"","url":"https://api.github.com/users/beaufortfrancois","html_url":"https://github.com/beaufortfrancois","followers_url":"https://api.github.com/users/beaufortfrancois/followers","following_url":"https://api.github.com/users/beaufortfrancois/following{/other_user}","gists_url":"https://api.github.com/users/beaufortfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/beaufortfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beaufortfrancois/subscriptions","organizations_url":"https://api.github.com/users/beaufortfrancois/orgs","repos_url":"https://api.github.com/users/beaufortfrancois/repos","events_url":"https://api.github.com/users/beaufortfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/beaufortfrancois/received_events","type":"User","site_admin":false},"body":"whitespace issue there as well.","created_at":"2015-11-09T13:17:51Z","updated_at":"2015-11-09T13:17:51Z","html_url":"https://github.com/PolymerElements/platinum-bluetooth/pull/10#discussion_r44273081","pull_request_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/comments/44273081"},"html":{"href":"https://github.com/PolymerElements/platinum-bluetooth/pull/10#discussion_r44273081"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10","id":49801439,"html_url":"https://github.com/PolymerElements/platinum-bluetooth/pull/10","diff_url":"https://github.com/PolymerElements/platinum-bluetooth/pull/10.diff","patch_url":"https://github.com/PolymerElements/platinum-bluetooth/pull/10.patch","issue_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/10","number":10,"state":"open","locked":false,"title":"add more filter options","user":{"login":"rbellens","id":11777399,"avatar_url":"https://avatars.githubusercontent.com/u/11777399?v=3","gravatar_id":"","url":"https://api.github.com/users/rbellens","html_url":"https://github.com/rbellens","followers_url":"https://api.github.com/users/rbellens/followers","following_url":"https://api.github.com/users/rbellens/following{/other_user}","gists_url":"https://api.github.com/users/rbellens/gists{/gist_id}","starred_url":"https://api.github.com/users/rbellens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbellens/subscriptions","organizations_url":"https://api.github.com/users/rbellens/orgs","repos_url":"https://api.github.com/users/rbellens/repos","events_url":"https://api.github.com/users/rbellens/events{/privacy}","received_events_url":"https://api.github.com/users/rbellens/received_events","type":"User","site_admin":false},"body":"* filter devices on name and name prefix\n* add optional services property\n* allow to define filters and options in request method argument","created_at":"2015-11-05T09:46:08Z","updated_at":"2015-11-09T13:17:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0967def53257c951429b31973dee4a5e3e6d67a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/10/comments","statuses_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/statuses/d5ce3d68d29f1a47b35a4b428710243bea22ffb2","head":{"label":"appsup-polymer:name-filter","ref":"name-filter","sha":"d5ce3d68d29f1a47b35a4b428710243bea22ffb2","user":{"login":"appsup-polymer","id":14886864,"avatar_url":"https://avatars.githubusercontent.com/u/14886864?v=3","gravatar_id":"","url":"https://api.github.com/users/appsup-polymer","html_url":"https://github.com/appsup-polymer","followers_url":"https://api.github.com/users/appsup-polymer/followers","following_url":"https://api.github.com/users/appsup-polymer/following{/other_user}","gists_url":"https://api.github.com/users/appsup-polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/appsup-polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsup-polymer/subscriptions","organizations_url":"https://api.github.com/users/appsup-polymer/orgs","repos_url":"https://api.github.com/users/appsup-polymer/repos","events_url":"https://api.github.com/users/appsup-polymer/events{/privacy}","received_events_url":"https://api.github.com/users/appsup-polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":45570941,"name":"platinum-bluetooth","full_name":"appsup-polymer/platinum-bluetooth","owner":{"login":"appsup-polymer","id":14886864,"avatar_url":"https://avatars.githubusercontent.com/u/14886864?v=3","gravatar_id":"","url":"https://api.github.com/users/appsup-polymer","html_url":"https://github.com/appsup-polymer","followers_url":"https://api.github.com/users/appsup-polymer/followers","following_url":"https://api.github.com/users/appsup-polymer/following{/other_user}","gists_url":"https://api.github.com/users/appsup-polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/appsup-polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appsup-polymer/subscriptions","organizations_url":"https://api.github.com/users/appsup-polymer/orgs","repos_url":"https://api.github.com/users/appsup-polymer/repos","events_url":"https://api.github.com/users/appsup-polymer/events{/privacy}","received_events_url":"https://api.github.com/users/appsup-polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appsup-polymer/platinum-bluetooth","description":"A set of Polymer elements to discover and communicate with nearby Bluetooth devices","fork":true,"url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth","forks_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/forks","keys_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/teams","hooks_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/hooks","issue_events_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/issues/events{/number}","events_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/events","assignees_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/assignees{/user}","branches_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/branches{/branch}","tags_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/tags","blobs_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/git/refs{/sha}","trees_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/statuses/{sha}","languages_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/languages","stargazers_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/stargazers","contributors_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/contributors","subscribers_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/subscribers","subscription_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/subscription","commits_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/commits{/sha}","git_commits_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/git/commits{/sha}","comments_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/comments{/number}","issue_comment_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/issues/comments{/number}","contents_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/contents/{+path}","compare_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/merges","archive_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/downloads","issues_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/issues{/number}","pulls_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/pulls{/number}","milestones_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/milestones{/number}","notifications_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/labels{/name}","releases_url":"https://api.github.com/repos/appsup-polymer/platinum-bluetooth/releases{/id}","created_at":"2015-11-04T22:14:42Z","updated_at":"2015-11-04T22:14:43Z","pushed_at":"2015-11-05T09:45:39Z","git_url":"git://github.com/appsup-polymer/platinum-bluetooth.git","ssh_url":"git@github.com:appsup-polymer/platinum-bluetooth.git","clone_url":"https://github.com/appsup-polymer/platinum-bluetooth.git","svn_url":"https://github.com/appsup-polymer/platinum-bluetooth","homepage":"https://elements.polymer-project.org/elements/platinum-bluetooth","size":102,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"2ffa2512a1c4609bf6e1871674278d16c2b3c2d9","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":39959229,"name":"platinum-bluetooth","full_name":"PolymerElements/platinum-bluetooth","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/platinum-bluetooth","description":"A set of Polymer elements to discover and communicate with nearby Bluetooth devices","fork":false,"url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth","forks_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/forks","keys_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/teams","hooks_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/events","assignees_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/tags","blobs_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/subscription","commits_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/merges","archive_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/downloads","issues_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/releases{/id}","created_at":"2015-07-30T15:57:38Z","updated_at":"2015-09-18T06:39:52Z","pushed_at":"2015-11-05T09:46:08Z","git_url":"git://github.com/PolymerElements/platinum-bluetooth.git","ssh_url":"git@github.com:PolymerElements/platinum-bluetooth.git","clone_url":"https://github.com/PolymerElements/platinum-bluetooth.git","svn_url":"https://github.com/PolymerElements/platinum-bluetooth","homepage":"https://elements.polymer-project.org/elements/platinum-bluetooth","size":255,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10"},"html":{"href":"https://github.com/PolymerElements/platinum-bluetooth/pull/10"},"issue":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/10"},"comments":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/platinum-bluetooth/statuses/d5ce3d68d29f1a47b35a4b428710243bea22ffb2"}}}}