{"action":"created","comment":{"url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/comments/41334639","id":41334639,"diff_hunk":"@@ -725,6 +743,49 @@ public static FloatInput makeEncoder(int aChannel, int bChannel, boolean reverse\n     }\n \n     /**\n+     * Creates a reference to a Counter on the specified ports* with the\n+     * specified number of average bits. Will count up when up channel is\n+     * pulsed, and down when down channel is pulsed.\n+     * \n+     * @param channel The channel for the counter.\n+     * @param resetWhen If provided, the Counter's value will be reset when this\n+     * event is produced.\n+     * @param updateOn Updates the FloatInput when this event is produced.\n+     * @return the Counter, reporting Counter ticks.\n+     */\n+    public static FloatInput makeCounter(int upChannel, int downChannel, int mode, EventInput resetWhen, EventInput updateOn) {\n+        return impl.makeCounter(upChannel, downChannel, resetWhen, updateOn, mode);\n+    }\n+\n+    /**\n+     * Creates a reference to a Counter on the specified ports* with the\n+     * specified number of average bits. Will count up when up channel is\n+     * pulsed, and down when down channel is pulsed.\n+     * \n+     * @param channel The channel for the counter.\n+     * @param resetWhen If provided, the Counter's value will be reset when this\n+     * event is produced.\n+     * @param updateOn Updates the FloatInput when this event is produced.\n+     * @return the Counter, reporting Counter ticks.\n+     */\n+    public static FloatInput makeCounter(int upChannel, int downChannel, EventInput resetWhen, EventInput updateOn) {\n+        return impl.makeCounter(upChannel, downChannel, resetWhen, updateOn, K_TWO_PULSE);\n+    }\n+","path":"CommonChickenRuntimeEngine/src/ccre/frc/FRC.java","position":57,"original_position":57,"commit_id":"b8b1160294d624c1b364b1f1c31d4c2bc9f12103","original_commit_id":"b8b1160294d624c1b364b1f1c31d4c2bc9f12103","user":{"login":"col6y","id":5056099,"avatar_url":"https://avatars.githubusercontent.com/u/5056099?v=3","gravatar_id":"","url":"https://api.github.com/users/col6y","html_url":"https://github.com/col6y","followers_url":"https://api.github.com/users/col6y/followers","following_url":"https://api.github.com/users/col6y/following{/other_user}","gists_url":"https://api.github.com/users/col6y/gists{/gist_id}","starred_url":"https://api.github.com/users/col6y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/col6y/subscriptions","organizations_url":"https://api.github.com/users/col6y/orgs","repos_url":"https://api.github.com/users/col6y/repos","events_url":"https://api.github.com/users/col6y/events{/privacy}","received_events_url":"https://api.github.com/users/col6y/received_events","type":"User","site_admin":false},"body":"Where's the version with a mode but no updateOn? You'll want all combinations of the arguments that you have chosen to be optional.","created_at":"2015-10-06T23:10:29Z","updated_at":"2015-10-06T23:10:29Z","html_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73#discussion_r41334639","pull_request_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/comments/41334639"},"html":{"href":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73#discussion_r41334639"},"pull_request":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73","id":46690228,"html_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73","diff_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73.diff","patch_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73.patch","issue_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/73","number":73,"state":"open","locked":false,"title":"Counter Implementation","user":{"login":"Ja-ake","id":3107437,"avatar_url":"https://avatars.githubusercontent.com/u/3107437?v=3","gravatar_id":"","url":"https://api.github.com/users/Ja-ake","html_url":"https://github.com/Ja-ake","followers_url":"https://api.github.com/users/Ja-ake/followers","following_url":"https://api.github.com/users/Ja-ake/following{/other_user}","gists_url":"https://api.github.com/users/Ja-ake/gists{/gist_id}","starred_url":"https://api.github.com/users/Ja-ake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ja-ake/subscriptions","organizations_url":"https://api.github.com/users/Ja-ake/orgs","repos_url":"https://api.github.com/users/Ja-ake/repos","events_url":"https://api.github.com/users/Ja-ake/events{/privacy}","received_events_url":"https://api.github.com/users/Ja-ake/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-02T22:45:27Z","updated_at":"2015-10-06T23:10:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24ca5630a23f8c19387e03e4dca742461bb84964","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73/commits","review_comments_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73/comments","review_comment_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/73/comments","statuses_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/statuses/b8b1160294d624c1b364b1f1c31d4c2bc9f12103","head":{"label":"Ja-ake:devel-3.x.x-geartooth","ref":"devel-3.x.x-geartooth","sha":"b8b1160294d624c1b364b1f1c31d4c2bc9f12103","user":{"login":"Ja-ake","id":3107437,"avatar_url":"https://avatars.githubusercontent.com/u/3107437?v=3","gravatar_id":"","url":"https://api.github.com/users/Ja-ake","html_url":"https://github.com/Ja-ake","followers_url":"https://api.github.com/users/Ja-ake/followers","following_url":"https://api.github.com/users/Ja-ake/following{/other_user}","gists_url":"https://api.github.com/users/Ja-ake/gists{/gist_id}","starred_url":"https://api.github.com/users/Ja-ake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ja-ake/subscriptions","organizations_url":"https://api.github.com/users/Ja-ake/orgs","repos_url":"https://api.github.com/users/Ja-ake/repos","events_url":"https://api.github.com/users/Ja-ake/events{/privacy}","received_events_url":"https://api.github.com/users/Ja-ake/received_events","type":"User","site_admin":false},"repo":{"id":42143068,"name":"Common-Chicken-Runtime-Engine","full_name":"Ja-ake/Common-Chicken-Runtime-Engine","owner":{"login":"Ja-ake","id":3107437,"avatar_url":"https://avatars.githubusercontent.com/u/3107437?v=3","gravatar_id":"","url":"https://api.github.com/users/Ja-ake","html_url":"https://github.com/Ja-ake","followers_url":"https://api.github.com/users/Ja-ake/followers","following_url":"https://api.github.com/users/Ja-ake/following{/other_user}","gists_url":"https://api.github.com/users/Ja-ake/gists{/gist_id}","starred_url":"https://api.github.com/users/Ja-ake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ja-ake/subscriptions","organizations_url":"https://api.github.com/users/Ja-ake/orgs","repos_url":"https://api.github.com/users/Ja-ake/repos","events_url":"https://api.github.com/users/Ja-ake/events{/privacy}","received_events_url":"https://api.github.com/users/Ja-ake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ja-ake/Common-Chicken-Runtime-Engine","description":"The CCRE is Team 1540's powerful open-source robot code framework, primarily for FIRST Robotics Competition robots. Click on the Wiki link to the right for more info!","fork":true,"url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine","forks_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/forks","keys_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/teams","hooks_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/hooks","issue_events_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/events","assignees_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/tags","blobs_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/languages","stargazers_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/stargazers","contributors_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/contributors","subscribers_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/subscribers","subscription_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/subscription","commits_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/merges","archive_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/downloads","issues_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/labels{/name}","releases_url":"https://api.github.com/repos/Ja-ake/Common-Chicken-Runtime-Engine/releases{/id}","created_at":"2015-09-08T22:47:14Z","updated_at":"2015-09-08T22:47:16Z","pushed_at":"2015-10-02T23:59:46Z","git_url":"git://github.com/Ja-ake/Common-Chicken-Runtime-Engine.git","ssh_url":"git@github.com:Ja-ake/Common-Chicken-Runtime-Engine.git","clone_url":"https://github.com/Ja-ake/Common-Chicken-Runtime-Engine.git","svn_url":"https://github.com/Ja-ake/Common-Chicken-Runtime-Engine","homepage":"","size":22751,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flamingchickens1540:devel-3.x.x","ref":"devel-3.x.x","sha":"fd5dd5f6cbfc1c16fdf97477d9b347652cecb564","user":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"repo":{"id":25059625,"name":"Common-Chicken-Runtime-Engine","full_name":"flamingchickens1540/Common-Chicken-Runtime-Engine","owner":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine","description":"The CCRE is Team 1540's powerful open-source robot code framework, primarily for FIRST Robotics Competition robots. Click on the Wiki link to the right for more info!","fork":false,"url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine","forks_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/forks","keys_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/teams","hooks_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/hooks","issue_events_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/events{/number}","events_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/events","assignees_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/assignees{/user}","branches_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/branches{/branch}","tags_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/tags","blobs_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/languages","stargazers_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/stargazers","contributors_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/contributors","subscribers_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/subscribers","subscription_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/subscription","commits_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/contents/{+path}","compare_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/merges","archive_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/downloads","issues_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues{/number}","pulls_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/labels{/name}","releases_url":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/releases{/id}","created_at":"2014-10-11T01:51:36Z","updated_at":"2015-06-29T18:40:44Z","pushed_at":"2015-10-06T23:07:52Z","git_url":"git://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine.git","ssh_url":"git@github.com:flamingchickens1540/Common-Chicken-Runtime-Engine.git","clone_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine.git","svn_url":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine","homepage":"","size":27005,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":27,"forks":3,"open_issues":27,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73"},"html":{"href":"https://github.com/flamingchickens1540/Common-Chicken-Runtime-Engine/pull/73"},"issue":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/73"},"comments":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/flamingchickens1540/Common-Chicken-Runtime-Engine/statuses/b8b1160294d624c1b364b1f1c31d4c2bc9f12103"}}}}