{"action":"created","comment":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/44914994","id":44914994,"diff_hunk":"@@ -31,7 +31,6 @@\n \n public class LightningFX extends EntityFX","path":"src/main/java/appeng/client/render/effects/LightningFX.java","position":2,"original_position":2,"commit_id":"8b4a39085e53e6974c3ae0f04f60dae0a8791aaa","original_commit_id":"8b4a39085e53e6974c3ae0f04f60dae0a8791aaa","user":{"login":"orod-org","id":14347709,"avatar_url":"https://avatars.githubusercontent.com/u/14347709?v=3","gravatar_id":"","url":"https://api.github.com/users/orod-org","html_url":"https://github.com/orod-org","followers_url":"https://api.github.com/users/orod-org/followers","following_url":"https://api.github.com/users/orod-org/following{/other_user}","gists_url":"https://api.github.com/users/orod-org/gists{/gist_id}","starred_url":"https://api.github.com/users/orod-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orod-org/subscriptions","organizations_url":"https://api.github.com/users/orod-org/orgs","repos_url":"https://api.github.com/users/orod-org/repos","events_url":"https://api.github.com/users/orod-org/events{/privacy}","received_events_url":"https://api.github.com/users/orod-org/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Override this superclass' \"equals\" method. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://nemo.sonarqube.org/coding_rules#rule_key=squid%3AS2160)\n","created_at":"2015-11-16T11:55:24Z","updated_at":"2015-11-16T11:55:24Z","html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880#discussion_r44914994","pull_request_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880","_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments/44914994"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880#discussion_r44914994"},"pull_request":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880"}}},"pull_request":{"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880","id":45207910,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880","diff_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880.diff","patch_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880.patch","issue_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1880","number":1880,"state":"open","locked":false,"title":"Rendering cleanup","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"body":"**Unfinished**\r\n\r\nReplaces the reflexive instantiation of the Renderes with a factory method.\r\nSome optimizations to the renderers to no longer push the whole OpenGL state to the stack.\r\nGeneral cleanup of duplicate code, etc\r\n\r\nFor now I did not notice any rendering issues, but I would not exclude that it can happen in some corner cases as it is way less defensive now. Potentially it can now even make bugs in the rendering obvious. Like enabling/disabling already enabled/disabled OpenGL capabilities.","created_at":"2015-09-16T18:36:07Z","updated_at":"2015-11-16T11:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"360e75fa681fb9a5753b7cf7cb6ccedd4b75b00c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880/commits","review_comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880/comments","review_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1880/comments","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/8b4a39085e53e6974c3ae0f04f60dae0a8791aaa","head":{"label":"yueh:feature-rendering-cleanup","ref":"feature-rendering-cleanup","sha":"8b4a39085e53e6974c3ae0f04f60dae0a8791aaa","user":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"repo":{"id":24421290,"name":"Applied-Energistics-2","full_name":"yueh/Applied-Energistics-2","owner":{"login":"yueh","id":151949,"avatar_url":"https://avatars.githubusercontent.com/u/151949?v=3","gravatar_id":"","url":"https://api.github.com/users/yueh","html_url":"https://github.com/yueh","followers_url":"https://api.github.com/users/yueh/followers","following_url":"https://api.github.com/users/yueh/following{/other_user}","gists_url":"https://api.github.com/users/yueh/gists{/gist_id}","starred_url":"https://api.github.com/users/yueh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yueh/subscriptions","organizations_url":"https://api.github.com/users/yueh/orgs","repos_url":"https://api.github.com/users/yueh/repos","events_url":"https://api.github.com/users/yueh/events{/privacy}","received_events_url":"https://api.github.com/users/yueh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yueh/Applied-Energistics-2","description":"A Mod about Matter, Energy and using them to conquer the world..","fork":true,"url":"https://api.github.com/repos/yueh/Applied-Energistics-2","forks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/yueh/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T15:45:12Z","updated_at":"2015-04-28T16:29:30Z","pushed_at":"2015-11-16T10:39:58Z","git_url":"git://github.com/yueh/Applied-Energistics-2.git","ssh_url":"git@github.com:yueh/Applied-Energistics-2.git","clone_url":"https://github.com/yueh/Applied-Energistics-2.git","svn_url":"https://github.com/yueh/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":13084,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AppliedEnergistics:master","ref":"master","sha":"824ec1eccbf0e1976e703b90a86a940ab774a6ea","user":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"repo":{"id":24395109,"name":"Applied-Energistics-2","full_name":"AppliedEnergistics/Applied-Energistics-2","owner":{"login":"AppliedEnergistics","id":8868712,"avatar_url":"https://avatars.githubusercontent.com/u/8868712?v=3","gravatar_id":"","url":"https://api.github.com/users/AppliedEnergistics","html_url":"https://github.com/AppliedEnergistics","followers_url":"https://api.github.com/users/AppliedEnergistics/followers","following_url":"https://api.github.com/users/AppliedEnergistics/following{/other_user}","gists_url":"https://api.github.com/users/AppliedEnergistics/gists{/gist_id}","starred_url":"https://api.github.com/users/AppliedEnergistics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppliedEnergistics/subscriptions","organizations_url":"https://api.github.com/users/AppliedEnergistics/orgs","repos_url":"https://api.github.com/users/AppliedEnergistics/repos","events_url":"https://api.github.com/users/AppliedEnergistics/events{/privacy}","received_events_url":"https://api.github.com/users/AppliedEnergistics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","description":"A Minecraft Mod about Matter, Energy and using them to conquer the world..","fork":false,"url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2","forks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/forks","keys_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/teams","hooks_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/hooks","issue_events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/events{/number}","events_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/events","assignees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/assignees{/user}","branches_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/branches{/branch}","tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/tags","blobs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/{sha}","languages_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/languages","stargazers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/stargazers","contributors_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contributors","subscribers_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscribers","subscription_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/subscription","commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/contents/{+path}","compare_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/merges","archive_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/downloads","issues_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues{/number}","pulls_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls{/number}","milestones_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/milestones{/number}","notifications_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/labels{/name}","releases_url":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/releases{/id}","created_at":"2014-09-24T00:48:40Z","updated_at":"2015-11-15T06:16:40Z","pushed_at":"2015-11-16T10:55:40Z","git_url":"git://github.com/AppliedEnergistics/Applied-Energistics-2.git","ssh_url":"git@github.com:AppliedEnergistics/Applied-Energistics-2.git","clone_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2.git","svn_url":"https://github.com/AppliedEnergistics/Applied-Energistics-2","homepage":"http://ae-mod.info/","size":24696,"stargazers_count":295,"watchers_count":295,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"open_issues_count":229,"forks":121,"open_issues":229,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880"},"html":{"href":"https://github.com/AppliedEnergistics/Applied-Energistics-2/pull/1880"},"issue":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1880"},"comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/issues/1880/comments"},"review_comments":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880/comments"},"review_comment":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/pulls/1880/commits"},"statuses":{"href":"https://api.github.com/repos/AppliedEnergistics/Applied-Energistics-2/statuses/8b4a39085e53e6974c3ae0f04f60dae0a8791aaa"}}}}