{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/47647377","id":47647377,"diff_hunk":"@@ -251,17 +251,36 @@ public static Configuration getConfiguration(JobContext context) {\n     }\n   }\n \n-  public static Counter getCounter(TaskInputOutputContext context,\n-                                   String groupName, String counterName) {\n-    return (Counter) invoke(GET_COUNTER_METHOD, context, groupName, counterName);","path":"parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ContextUtil.java","position":65,"original_position":15,"commit_id":"f118990bc6872bb81f4ed319cc3523526054c586","original_commit_id":"f45565e423b4ff53ecb29044f949317fdbdda082","user":{"login":"sircodesalotOfTheRound","id":4482959,"avatar_url":"https://avatars.githubusercontent.com/u/4482959?v=3","gravatar_id":"","url":"https://api.github.com/users/sircodesalotOfTheRound","html_url":"https://github.com/sircodesalotOfTheRound","followers_url":"https://api.github.com/users/sircodesalotOfTheRound/followers","following_url":"https://api.github.com/users/sircodesalotOfTheRound/following{/other_user}","gists_url":"https://api.github.com/users/sircodesalotOfTheRound/gists{/gist_id}","starred_url":"https://api.github.com/users/sircodesalotOfTheRound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sircodesalotOfTheRound/subscriptions","organizations_url":"https://api.github.com/users/sircodesalotOfTheRound/orgs","repos_url":"https://api.github.com/users/sircodesalotOfTheRound/repos","events_url":"https://api.github.com/users/sircodesalotOfTheRound/events{/privacy}","received_events_url":"https://api.github.com/users/sircodesalotOfTheRound/received_events","type":"User","site_admin":false},"body":"I replaced `GET_COUNTER_METHOD` with a cache (`COUNTER_METHODS_BY_CLASS`).","created_at":"2015-12-15T15:08:36Z","updated_at":"2015-12-15T15:08:36Z","html_url":"https://github.com/apache/parquet-mr/pull/280#discussion_r47647377","pull_request_url":"https://api.github.com/repos/apache/parquet-mr/pulls/280","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/47647377"},"html":{"href":"https://github.com/apache/parquet-mr/pull/280#discussion_r47647377"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/280","id":47191200,"html_url":"https://github.com/apache/parquet-mr/pull/280","diff_url":"https://github.com/apache/parquet-mr/pull/280.diff","patch_url":"https://github.com/apache/parquet-mr/pull/280.patch","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/280","number":280,"state":"open","locked":false,"title":"PARQUET-220: Unnecessary warning in ParquetRecordReader.initialize","user":{"login":"sircodesalotOfTheRound","id":4482959,"avatar_url":"https://avatars.githubusercontent.com/u/4482959?v=3","gravatar_id":"","url":"https://api.github.com/users/sircodesalotOfTheRound","html_url":"https://github.com/sircodesalotOfTheRound","followers_url":"https://api.github.com/users/sircodesalotOfTheRound/followers","following_url":"https://api.github.com/users/sircodesalotOfTheRound/following{/other_user}","gists_url":"https://api.github.com/users/sircodesalotOfTheRound/gists{/gist_id}","starred_url":"https://api.github.com/users/sircodesalotOfTheRound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sircodesalotOfTheRound/subscriptions","organizations_url":"https://api.github.com/users/sircodesalotOfTheRound/orgs","repos_url":"https://api.github.com/users/sircodesalotOfTheRound/repos","events_url":"https://api.github.com/users/sircodesalotOfTheRound/events{/privacy}","received_events_url":"https://api.github.com/users/sircodesalotOfTheRound/received_events","type":"User","site_admin":false},"body":"Rather than querying the COUNTER_METHOD up front, the counter method is resolved per object. This allows us to use the\r\n'getCounter' method on any TaskAttemptContext with the correct signature (ignoring versions where TaskAttemptContext does\r\nnot have an appropriate method/signature - preserving current behavior).","created_at":"2015-10-08T18:50:03Z","updated_at":"2015-12-15T15:08:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"101fbaad968edf79ed754be71070005cb74c8719","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-mr/pulls/280/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-mr/pulls/280/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/280/comments","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/f118990bc6872bb81f4ed319cc3523526054c586","head":{"label":"sircodesalotOfTheRound:context-utils-parquet-220","ref":"context-utils-parquet-220","sha":"f118990bc6872bb81f4ed319cc3523526054c586","user":{"login":"sircodesalotOfTheRound","id":4482959,"avatar_url":"https://avatars.githubusercontent.com/u/4482959?v=3","gravatar_id":"","url":"https://api.github.com/users/sircodesalotOfTheRound","html_url":"https://github.com/sircodesalotOfTheRound","followers_url":"https://api.github.com/users/sircodesalotOfTheRound/followers","following_url":"https://api.github.com/users/sircodesalotOfTheRound/following{/other_user}","gists_url":"https://api.github.com/users/sircodesalotOfTheRound/gists{/gist_id}","starred_url":"https://api.github.com/users/sircodesalotOfTheRound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sircodesalotOfTheRound/subscriptions","organizations_url":"https://api.github.com/users/sircodesalotOfTheRound/orgs","repos_url":"https://api.github.com/users/sircodesalotOfTheRound/repos","events_url":"https://api.github.com/users/sircodesalotOfTheRound/events{/privacy}","received_events_url":"https://api.github.com/users/sircodesalotOfTheRound/received_events","type":"User","site_admin":false},"repo":{"id":38845444,"name":"parquet-mr","full_name":"sircodesalotOfTheRound/parquet-mr","owner":{"login":"sircodesalotOfTheRound","id":4482959,"avatar_url":"https://avatars.githubusercontent.com/u/4482959?v=3","gravatar_id":"","url":"https://api.github.com/users/sircodesalotOfTheRound","html_url":"https://github.com/sircodesalotOfTheRound","followers_url":"https://api.github.com/users/sircodesalotOfTheRound/followers","following_url":"https://api.github.com/users/sircodesalotOfTheRound/following{/other_user}","gists_url":"https://api.github.com/users/sircodesalotOfTheRound/gists{/gist_id}","starred_url":"https://api.github.com/users/sircodesalotOfTheRound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sircodesalotOfTheRound/subscriptions","organizations_url":"https://api.github.com/users/sircodesalotOfTheRound/orgs","repos_url":"https://api.github.com/users/sircodesalotOfTheRound/repos","events_url":"https://api.github.com/users/sircodesalotOfTheRound/events{/privacy}","received_events_url":"https://api.github.com/users/sircodesalotOfTheRound/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sircodesalotOfTheRound/parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr","forks_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/forks","keys_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/teams","hooks_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/events","assignees_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/tags","blobs_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/subscription","commits_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/merges","archive_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/downloads","issues_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/sircodesalotOfTheRound/parquet-mr/releases{/id}","created_at":"2015-07-09T21:10:04Z","updated_at":"2015-07-09T21:10:06Z","pushed_at":"2015-12-15T15:07:17Z","git_url":"git://github.com/sircodesalotOfTheRound/parquet-mr.git","ssh_url":"git@github.com:sircodesalotOfTheRound/parquet-mr.git","clone_url":"https://github.com/sircodesalotOfTheRound/parquet-mr.git","svn_url":"https://github.com/sircodesalotOfTheRound/parquet-mr","homepage":null,"size":13955,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"fa7588c4c0f8d403e4815fa72e3b8a3bc98d73ec","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"parquet-mr","full_name":"apache/parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-mr","forks_url":"https://api.github.com/repos/apache/parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-mr/releases{/id}","created_at":"2014-06-10T07:00:07Z","updated_at":"2015-12-04T08:26:48Z","pushed_at":"2015-12-15T15:07:18Z","git_url":"git://github.com/apache/parquet-mr.git","ssh_url":"git@github.com:apache/parquet-mr.git","clone_url":"https://github.com/apache/parquet-mr.git","svn_url":"https://github.com/apache/parquet-mr","homepage":null,"size":17181,"stargazers_count":170,"watchers_count":170,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":175,"mirror_url":"git://git.apache.org/parquet-mr.git","open_issues_count":52,"forks":175,"open_issues":52,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/280"},"html":{"href":"https://github.com/apache/parquet-mr/pull/280"},"issue":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/280"},"comments":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-mr/statuses/f118990bc6872bb81f4ed319cc3523526054c586"}}}}