{"action":"created","issue":{"url":"https://api.github.com/repos/meejah/txtorcon/issues/89","labels_url":"https://api.github.com/repos/meejah/txtorcon/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/meejah/txtorcon/issues/89/comments","events_url":"https://api.github.com/repos/meejah/txtorcon/issues/89/events","html_url":"https://github.com/meejah/txtorcon/issues/89","id":53154089,"number":89,"title":"De-duplicate hidden-services by HiddenServiceDir","user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/meejah/txtorcon/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/meejah/txtorcon/milestones/2","labels_url":"https://api.github.com/repos/meejah/txtorcon/milestones/2/labels","id":969303,"number":2,"title":"v0.13.0","description":null,"creator":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2015-02-06T20:12:59Z","updated_at":"2015-02-13T07:55:06Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2014-12-30T22:52:01Z","updated_at":"2015-02-16T04:05:01Z","closed_at":null,"body":"It turns out that Tor currently only \"warns\" if you have two hidden services that have the very same HiddenServiceDir.\r\n\r\nSo TorConfig should verify that we don't have two HiddenService instances pointing at the same directory, or tor will accept it with a warn, but one of them won't work at all."},"comment":{"url":"https://api.github.com/repos/meejah/txtorcon/issues/comments/74457594","html_url":"https://github.com/meejah/txtorcon/issues/89#issuecomment-74457594","issue_url":"https://api.github.com/repos/meejah/txtorcon/issues/89","id":74457594,"user":{"login":"meejah","id":145599,"avatar_url":"https://avatars.githubusercontent.com/u/145599?v=3","gravatar_id":"","url":"https://api.github.com/users/meejah","html_url":"https://github.com/meejah","followers_url":"https://api.github.com/users/meejah/followers","following_url":"https://api.github.com/users/meejah/following{/other_user}","gists_url":"https://api.github.com/users/meejah/gists{/gist_id}","starred_url":"https://api.github.com/users/meejah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meejah/subscriptions","organizations_url":"https://api.github.com/users/meejah/orgs","repos_url":"https://api.github.com/users/meejah/repos","events_url":"https://api.github.com/users/meejah/events{/privacy}","received_events_url":"https://api.github.com/users/meejah/received_events","type":"User","site_admin":false},"created_at":"2015-02-16T04:05:01Z","updated_at":"2015-02-16T04:05:01Z","body":"Actually, the reason it's checking is that the first time we see HiddenServiceDir, it'll be None.\r\n\r\nSo, if there's precisely 1 HiddenServiceDir line, only the 1140 case gets hit; if there's 2, then 1113 gets called once, and 1140 once.\r\n\r\nThis bug is about what happens if a user of TorConfig adds two HiddenService instances with the same dir -- we shouldn't allow the second one to be added."}}