{"action":"reopened","issue":{"url":"https://api.github.com/repos/nickup9/n-pong/issues/4","labels_url":"https://api.github.com/repos/nickup9/n-pong/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/nickup9/n-pong/issues/4/comments","events_url":"https://api.github.com/repos/nickup9/n-pong/issues/4/events","html_url":"https://github.com/nickup9/n-pong/issues/4","id":123567884,"number":4,"title":"Unclear variable names","user":{"login":"sdleffler","id":5241142,"avatar_url":"https://avatars.githubusercontent.com/u/5241142?v=3","gravatar_id":"","url":"https://api.github.com/users/sdleffler","html_url":"https://github.com/sdleffler","followers_url":"https://api.github.com/users/sdleffler/followers","following_url":"https://api.github.com/users/sdleffler/following{/other_user}","gists_url":"https://api.github.com/users/sdleffler/gists{/gist_id}","starred_url":"https://api.github.com/users/sdleffler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdleffler/subscriptions","organizations_url":"https://api.github.com/users/sdleffler/orgs","repos_url":"https://api.github.com/users/sdleffler/repos","events_url":"https://api.github.com/users/sdleffler/events{/privacy}","received_events_url":"https://api.github.com/users/sdleffler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-22T22:23:39Z","updated_at":"2015-12-23T22:27:15Z","closed_at":null,"body":"```playerOne``` - actually a score variable. Recommend renaming to ```playerOneScore```.\r\n```playerTwo``` - ditto.\r\n```paddleOneX```/```paddleOneY```/```paddleTwoX```/```paddleTwoY```/```puckX```/```puckY``` - just looking at these variable names suggests that they are real numbers, not lists of coordinates. Usual convention in Lua for storing lists of coordinates is to store lists of coordinate pairs, not individual lists of components. For example, a square stored like this would look like ```{{0, 0}, {0, 1}, {1, 1}, {1, 0}}``` - note how each individual point is represented as one element of the list. Of course, this isn't how Love2D accepts points in its draw functions - if you're dead set on storing these things as lists of vertices which can be passed into Love's draw functions, then you'll want to store them as Love expects them. Anything else is just inconvenient.\r\n```winCheck``` - name suggests a boolean value (checking for winner.) Not actually a boolean value, but instead an enum value (0, 1, or 2.) Suggest renaming to ```winner``` and assigning string values instead of integer values - maybe ```\"none\"```, ```\"player1\"```, and ```\"player2\"```, or creating integer constants to represent the winners and make code using this variable more clear."}}