{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39914419","id":39914419,"diff_hunk":"@@ -148,3 +198,142 @@ func (d *DeploymentController) getDesiredRC(deployment *experimental.Deployment)\n \t}\n \treturn createdRC, nil\n }\n+\n+func getDesiredRCTemplate(deployment experimental.Deployment) *api.PodTemplateSpec {\n+\t// desiredRC will have the same template as in deployment spec, plus a unique label in some cases.\n+\tdesiredRCTemplate := &api.PodTemplateSpec{\n+\t\tObjectMeta: deployment.Spec.Template.ObjectMeta,\n+\t\tSpec:       deployment.Spec.Template.Spec,\n+\t}\n+\tpodTemplateSpecHash := getPodTemplateSpecHash(desiredRCTemplate)\n+\tif deployment.Spec.UniqueLabelKey != \"\" {\n+\t\tnewLabels := map[string]string{}\n+\t\tfor key, value := range deployment.Spec.Template.ObjectMeta.Labels {\n+\t\t\tnewLabels[key] = value\n+\t\t}\n+\t\tnewLabels[deployment.Spec.UniqueLabelKey] = fmt.Sprintf(\"%d\", podTemplateSpecHash)\n+\t\tdesiredRCTemplate.ObjectMeta.Labels = newLabels\n+\t}\n+\treturn desiredRCTemplate\n+}\n+\n+func getPodTemplateSpecHash(template *api.PodTemplateSpec) uint32 {\n+\tpodTemplateSpecHasher := adler32.New()\n+\tutil.DeepHashObject(podTemplateSpecHasher, template)\n+\treturn podTemplateSpecHasher.Sum32()\n+}\n+\n+func (d *DeploymentController) getPodsForRCs(replicationControllers []*api.ReplicationController) ([]api.Pod, error) {\n+\tallPods := []api.Pod{}\n+\tfor _, rc := range replicationControllers {\n+\t\tpodList, err := d.client.Pods(rc.ObjectMeta.Namespace).List(labels.SelectorFromSet(rc.Spec.Selector), fields.Everything())\n+\t\tif err != nil {\n+\t\t\treturn allPods, fmt.Errorf(\"error listing pods: %v\", err)\n+\t\t}\n+\t\tallPods = append(allPods, podList.Items...)\n+\t}\n+\treturn allPods, nil\n+}\n+\n+func (d *DeploymentController) getReplicaCountForRCs(replicationControllers []*api.ReplicationController) int {\n+\ttotalReplicaCount := 0\n+\tfor _, rc := range replicationControllers {\n+\t\ttotalReplicaCount += rc.Spec.Replicas\n+\t}\n+\treturn totalReplicaCount\n+}\n+\n+func (d *DeploymentController) scaleUp(allRCs []*api.ReplicationController, desiredRC *api.ReplicationController, deployment experimental.Deployment) (bool, error) {\n+\tmaxSurge, isPercent, err := util.GetIntOrPercentValue(&deployment.Spec.Strategy.RollingUpdate.MaxSurge)\n+\tif err != nil {\n+\t\treturn false, fmt.Errorf(\"Invalid value for MaxSurge: %v\", err)\n+\t}\n+\tif isPercent {\n+\t\tmaxSurge = util.GetValueFromPercent(maxSurge, deployment.Spec.Replicas)\n+\t}\n+\t// Find the total number of pods\n+\tallPods, err := d.getPodsForRCs(allRCs)\n+\tif err != nil {\n+\t\treturn false, err\n+\t}\n+\tcurrentPodCount := len(allPods)\n+\t// Check if we can scale up.\n+\tmaxTotalPods := deployment.Spec.Replicas + maxSurge\n+\tif currentPodCount >= maxTotalPods {\n+\t\t// Cannot scale up.\n+\t\treturn false, nil\n+\t}\n+\t// Scale up.\n+\tscaleUpCount := maxTotalPods - currentPodCount\n+\tscaleUpCount = int(math.Min(float64(scaleUpCount), float64(deployment.Spec.Replicas-desiredRC.Spec.Replicas)))\n+\t_, err = d.scaleRC(desiredRC, scaleUpCount)\n+\treturn true, err\n+}\n+\n+func (d *DeploymentController) scaleDown(allRCs []*api.ReplicationController, targetedRCs []*api.ReplicationController, desiredRC *api.ReplicationController, deployment experimental.Deployment) (bool, error) {\n+\tmaxUnavailable, isPercent, err := util.GetIntOrPercentValue(&deployment.Spec.Strategy.RollingUpdate.MaxUnavailable)\n+\tif err != nil {\n+\t\treturn false, fmt.Errorf(\"Invalid value for MaxUnavailable: %v\", err)\n+\t}\n+\tif isPercent {\n+\t\tmaxUnavailable = util.GetValueFromPercent(maxUnavailable, deployment.Spec.Replicas)\n+\t}\n+\t// Check if we can scale down.\n+\tminAvailable := deployment.Spec.Replicas - maxUnavailable\n+\t// Find the number of ready pods.\n+\t// TODO: Use MinReadySeconds once https://github.com/kubernetes/kubernetes/pull/12894 is merged.\n+\treadyPodCount := 0\n+\tallPods, err := d.getPodsForRCs(allRCs)\n+\tfor _, pod := range allPods {\n+\t\tif api.IsPodReady(&pod) {\n+\t\t\treadyPodCount++\n+\t\t}\n+\t}\n+\n+\tif readyPodCount <= minAvailable {\n+\t\t// Cannot scale down.\n+\t\treturn false, nil\n+\t}\n+\ttotalScaleDownCount := readyPodCount - minAvailable\n+\tfor _, targetRC := range targetedRCs {\n+\t\tif totalScaleDownCount == 0 {\n+\t\t\t// No further scaling required.\n+\t\t\tbreak\n+\t\t}\n+\t\tif targetRC.Spec.Replicas == 0 {\n+\t\t\t// cannot scale down this RC.\n+\t\t\tcontinue\n+\t\t}\n+\t\t// Scale down.\n+\t\tscaleDownCount := int(math.Min(float64(targetRC.Spec.Replicas), float64(totalScaleDownCount)))\n+\t\t_, err = d.scaleRC(targetRC, -scaleDownCount)\n+\t\tif err != nil {\n+\t\t\treturn false, err\n+\t\t}\n+\t\ttotalScaleDownCount -= scaleDownCount\n+\t}\n+\treturn true, err\n+}\n+\n+func (d *DeploymentController) updateDeploymentStatus(allRCs []*api.ReplicationController, desiredRC *api.ReplicationController, deployment experimental.Deployment) error {","path":"pkg/controller/deployment/deployment_controller.go","position":null,"original_position":279,"commit_id":"d800fef81b8db9a77890e717ed1cbb31d2ae7592","original_commit_id":"13813a7640484db8a06f440e006d5c1a8a2435d9","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"What do you think?\r\nDeployment's job is to tell the ReplicationController that it needs X pods. Its RCs job to make sure that there are X pods running at all times. So deployment can just report that I have told RC to keep X pods ready. Or do you think deployment should report how many of those pods are ready?\r\nI guess we can discuss this with other folks as well.\r\nAdded a comment for now.","created_at":"2015-09-19T01:26:26Z","updated_at":"2015-09-19T01:26:26Z","html_url":"https://github.com/kubernetes/kubernetes/pull/14209#discussion_r39914419","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39914419"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14209#discussion_r39914419"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209","id":45461884,"html_url":"https://github.com/kubernetes/kubernetes/pull/14209","diff_url":"https://github.com/kubernetes/kubernetes/pull/14209.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/14209.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14209","number":14209,"state":"open","locked":false,"title":"Adding scale up down code for DeploymentController","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"body":"Ref #1743 \r\n\r\nAdding code for scaling up down RCs using RollingUpdateStrategy.\r\nVerified manually that it works.\r\n\r\nNext steps:\r\n* Add e2e tests\r\n* Start using store when https://github.com/kubernetes/kubernetes/pull/14130 is submitted (which should speed up the sync loop)\r\n* Add logic for RecreateDeployment\r\n\r\nWill send subsequent PRs for the above tasks.","created_at":"2015-09-18T23:08:28Z","updated_at":"2015-09-19T01:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e23ca4e8b169e2cf3d9d86bcc9260deeecb24770","assignee":{"login":"ghodss","id":5209643,"avatar_url":"https://avatars.githubusercontent.com/u/5209643?v=3","gravatar_id":"","url":"https://api.github.com/users/ghodss","html_url":"https://github.com/ghodss","followers_url":"https://api.github.com/users/ghodss/followers","following_url":"https://api.github.com/users/ghodss/following{/other_user}","gists_url":"https://api.github.com/users/ghodss/gists{/gist_id}","starred_url":"https://api.github.com/users/ghodss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghodss/subscriptions","organizations_url":"https://api.github.com/users/ghodss/orgs","repos_url":"https://api.github.com/users/ghodss/repos","events_url":"https://api.github.com/users/ghodss/events{/privacy}","received_events_url":"https://api.github.com/users/ghodss/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14209/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d800fef81b8db9a77890e717ed1cbb31d2ae7592","head":{"label":"nikhiljindal:deploymentController","ref":"deploymentController","sha":"d800fef81b8db9a77890e717ed1cbb31d2ae7592","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"repo":{"id":29988055,"name":"kubernetes","full_name":"nikhiljindal/kubernetes","owner":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhiljindal/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/nikhiljindal/kubernetes","forks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/forks","keys_url":"https://api.github.com/repos/nikhiljindal/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhiljindal/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhiljindal/kubernetes/teams","hooks_url":"https://api.github.com/repos/nikhiljindal/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nikhiljindal/kubernetes/events","assignees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nikhiljindal/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/tags","blobs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhiljindal/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhiljindal/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nikhiljindal/kubernetes/subscription","commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhiljindal/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhiljindal/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhiljindal/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nikhiljindal/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhiljindal/kubernetes/merges","archive_url":"https://api.github.com/repos/nikhiljindal/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhiljindal/kubernetes/downloads","issues_url":"https://api.github.com/repos/nikhiljindal/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nikhiljindal/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhiljindal/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhiljindal/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhiljindal/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nikhiljindal/kubernetes/releases{/id}","created_at":"2015-01-28T21:01:50Z","updated_at":"2015-01-28T21:01:53Z","pushed_at":"2015-09-19T01:21:54Z","git_url":"git://github.com/nikhiljindal/kubernetes.git","ssh_url":"git@github.com:nikhiljindal/kubernetes.git","clone_url":"https://github.com/nikhiljindal/kubernetes.git","svn_url":"https://github.com/nikhiljindal/kubernetes","homepage":"http://kubernetes.io","size":108767,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7ddbdc478d7e71687e583e1d89e2943d3d347548","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-19T01:08:49Z","pushed_at":"2015-09-19T01:21:55Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":419442,"stargazers_count":10315,"watchers_count":10315,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2554,"mirror_url":null,"open_issues_count":1794,"forks":2554,"open_issues":1794,"watchers":10315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/14209"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14209"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/14209/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/14209/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d800fef81b8db9a77890e717ed1cbb31d2ae7592"}}}}