{"action":"closed","number":3802,"pull_request":{"url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802","id":50696239,"html_url":"https://github.com/juliocamarero/liferay-portal/pull/3802","diff_url":"https://github.com/juliocamarero/liferay-portal/pull/3802.diff","patch_url":"https://github.com/juliocamarero/liferay-portal/pull/3802.patch","issue_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/3802","number":3802,"state":"closed","locked":false,"title":"LPS-60407","user":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars.githubusercontent.com/u/116871?v=3","gravatar_id":"","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"body":"/cc @ealonso\n\nHey guys,\nSorry for the delay on this one, there were some icons that I had missed the first time around.\nI wasn't able to get things 100% of the way there, but I think I covered most of them.\n\nThe two things I wasn't able to do, and if you're able to help or have ideas, that'd be awesome, but it's:\n1. Since we're now using the `aui:icon` taglib, there is no `useDialog` attribute, and I'm not sure if we're using it in here anymore.\n2. Inside of the Add Content area, the `aui:nav-item` taglib is taking an `iconCssClass` attribute, but I don't know of any way to cascase it down. Maybe in this case we remove it, and manually add the icon?\n\nIf you guys have any questions, or there are any issues you guys see, please let me know. I'll try to send the Product Menu one along as well, but I'll need to double check and make sure I didn't miss too much.\n\nThanks guys,","created_at":"2015-11-13T21:47:51Z","updated_at":"2015-11-18T09:07:32Z","closed_at":"2015-11-18T09:07:32Z","merged_at":null,"merge_commit_sha":"e5236c6c3bf594ed1909daaceeee20e0624f2584","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802/commits","review_comments_url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802/comments","review_comment_url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/3802/comments","statuses_url":"https://api.github.com/repos/juliocamarero/liferay-portal/statuses/d3fb833be3718439099b38f8d1c0bc36d17bc6e6","head":{"label":"natecavanaugh:LPS-60407","ref":"LPS-60407","sha":"d3fb833be3718439099b38f8d1c0bc36d17bc6e6","user":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars.githubusercontent.com/u/116871?v=3","gravatar_id":"","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"repo":{"id":1325549,"name":"liferay-portal","full_name":"natecavanaugh/liferay-portal","owner":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars.githubusercontent.com/u/116871?v=3","gravatar_id":"","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natecavanaugh/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/natecavanaugh/liferay-portal","forks_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/forks","keys_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/teams","hooks_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/events","assignees_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/tags","blobs_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/subscription","commits_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/merges","archive_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/downloads","issues_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/natecavanaugh/liferay-portal/releases{/id}","created_at":"2011-02-03T20:17:10Z","updated_at":"2015-05-08T18:29:12Z","pushed_at":"2015-11-17T20:43:57Z","git_url":"git://github.com/natecavanaugh/liferay-portal.git","ssh_url":"git@github.com:natecavanaugh/liferay-portal.git","clone_url":"https://github.com/natecavanaugh/liferay-portal.git","svn_url":"https://github.com/natecavanaugh/liferay-portal","homepage":"http://liferay.com","size":5415707,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"juliocamarero:master","ref":"master","sha":"69735aafb491eed291b11bc3253cbcc3e7280b25","user":{"login":"juliocamarero","id":203395,"avatar_url":"https://avatars.githubusercontent.com/u/203395?v=3","gravatar_id":"","url":"https://api.github.com/users/juliocamarero","html_url":"https://github.com/juliocamarero","followers_url":"https://api.github.com/users/juliocamarero/followers","following_url":"https://api.github.com/users/juliocamarero/following{/other_user}","gists_url":"https://api.github.com/users/juliocamarero/gists{/gist_id}","starred_url":"https://api.github.com/users/juliocamarero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliocamarero/subscriptions","organizations_url":"https://api.github.com/users/juliocamarero/orgs","repos_url":"https://api.github.com/users/juliocamarero/repos","events_url":"https://api.github.com/users/juliocamarero/events{/privacy}","received_events_url":"https://api.github.com/users/juliocamarero/received_events","type":"User","site_admin":false},"repo":{"id":1922200,"name":"liferay-portal","full_name":"juliocamarero/liferay-portal","owner":{"login":"juliocamarero","id":203395,"avatar_url":"https://avatars.githubusercontent.com/u/203395?v=3","gravatar_id":"","url":"https://api.github.com/users/juliocamarero","html_url":"https://github.com/juliocamarero","followers_url":"https://api.github.com/users/juliocamarero/followers","following_url":"https://api.github.com/users/juliocamarero/following{/other_user}","gists_url":"https://api.github.com/users/juliocamarero/gists{/gist_id}","starred_url":"https://api.github.com/users/juliocamarero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliocamarero/subscriptions","organizations_url":"https://api.github.com/users/juliocamarero/orgs","repos_url":"https://api.github.com/users/juliocamarero/repos","events_url":"https://api.github.com/users/juliocamarero/events{/privacy}","received_events_url":"https://api.github.com/users/juliocamarero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliocamarero/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/juliocamarero/liferay-portal","forks_url":"https://api.github.com/repos/juliocamarero/liferay-portal/forks","keys_url":"https://api.github.com/repos/juliocamarero/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliocamarero/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliocamarero/liferay-portal/teams","hooks_url":"https://api.github.com/repos/juliocamarero/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/juliocamarero/liferay-portal/events","assignees_url":"https://api.github.com/repos/juliocamarero/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/juliocamarero/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/juliocamarero/liferay-portal/tags","blobs_url":"https://api.github.com/repos/juliocamarero/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliocamarero/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliocamarero/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliocamarero/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliocamarero/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/juliocamarero/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/juliocamarero/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/juliocamarero/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/juliocamarero/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/juliocamarero/liferay-portal/subscription","commits_url":"https://api.github.com/repos/juliocamarero/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliocamarero/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliocamarero/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliocamarero/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/juliocamarero/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliocamarero/liferay-portal/merges","archive_url":"https://api.github.com/repos/juliocamarero/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliocamarero/liferay-portal/downloads","issues_url":"https://api.github.com/repos/juliocamarero/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/juliocamarero/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/juliocamarero/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliocamarero/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/juliocamarero/liferay-portal/releases{/id}","created_at":"2011-06-20T06:30:10Z","updated_at":"2015-05-08T06:38:22Z","pushed_at":"2015-11-18T08:59:23Z","git_url":"git://github.com/juliocamarero/liferay-portal.git","ssh_url":"git@github.com:juliocamarero/liferay-portal.git","clone_url":"https://github.com/juliocamarero/liferay-portal.git","svn_url":"https://github.com/juliocamarero/liferay-portal","homepage":"http://www.liferay.com","size":5338578,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802"},"html":{"href":"https://github.com/juliocamarero/liferay-portal/pull/3802"},"issue":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/3802"},"comments":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/issues/3802/comments"},"review_comments":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802/comments"},"review_comment":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/pulls/3802/commits"},"statuses":{"href":"https://api.github.com/repos/juliocamarero/liferay-portal/statuses/d3fb833be3718439099b38f8d1c0bc36d17bc6e6"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"commits":64,"additions":1733,"deletions":405,"changed_files":101}}