{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/27644283","id":27644283,"diff_hunk":"@@ -77,39 +77,39 @@ void Paxos::init()\n void Paxos::init_logger()\n {\n   PerfCountersBuilder pcb(g_ceph_context, \"paxos\", l_paxos_first, l_paxos_last);\n-  pcb.add_u64_counter(l_paxos_start_leader, \"start_leader\");\n-  pcb.add_u64_counter(l_paxos_start_peon, \"start_peon\");\n-  pcb.add_u64_counter(l_paxos_restart, \"restart\");\n-  pcb.add_u64_counter(l_paxos_refresh, \"refresh\");\n-  pcb.add_time_avg(l_paxos_refresh_latency, \"refresh_latency\");\n-  pcb.add_u64_counter(l_paxos_begin, \"begin\");\n-  pcb.add_u64_avg(l_paxos_begin_keys, \"begin_keys\");\n-  pcb.add_u64_avg(l_paxos_begin_bytes, \"begin_bytes\");\n-  pcb.add_time_avg(l_paxos_begin_latency, \"begin_latency\");\n+  pcb.add_u64_counter(l_paxos_start_leader, \"start_leader\", \"Starts in leader role\");\n+  pcb.add_u64_counter(l_paxos_start_peon, \"start_peon\", \"Starts in peon role\");\n+  pcb.add_u64_counter(l_paxos_restart, \"restart\", \"Restarts\");\n+  pcb.add_u64_counter(l_paxos_refresh, \"refresh\", \"Refreshs\");\n+  pcb.add_time_avg(l_paxos_refresh_latency, \"refresh_latency\", \"Refresh latency\");\n+  pcb.add_u64_counter(l_paxos_begin, \"begin\", \"Started and handled begins\");\n+  pcb.add_u64_avg(l_paxos_begin_keys, \"begin_keys\", \"Keys in transaction on begin\");\n+  pcb.add_u64_avg(l_paxos_begin_bytes, \"begin_bytes\", \"Data in transaction on begin\");\n+  pcb.add_time_avg(l_paxos_begin_latency, \"begin_latency\", \"Latency of begin operation\");\n   pcb.add_u64_counter(l_paxos_commit, \"commit\",\n       \"Commits\", \"cmt\");\n-  pcb.add_u64_avg(l_paxos_commit_keys, \"commit_keys\");\n-  pcb.add_u64_avg(l_paxos_commit_bytes, \"commit_bytes\");\n+  pcb.add_u64_avg(l_paxos_commit_keys, \"commit_keys\", \"Keys in tansaction on commit\");\n+  pcb.add_u64_avg(l_paxos_commit_bytes, \"commit_bytes\", \"Data in tansaction on commit\");\n   pcb.add_time_avg(l_paxos_commit_latency, \"commit_latency\",\n       \"Commit latency\", \"clat\");\n-  pcb.add_u64_counter(l_paxos_collect, \"collect\");\n-  pcb.add_u64_avg(l_paxos_collect_keys, \"collect_keys\");\n-  pcb.add_u64_avg(l_paxos_collect_bytes, \"collect_bytes\");\n-  pcb.add_time_avg(l_paxos_collect_latency, \"collect_latency\");\n-  pcb.add_u64_counter(l_paxos_collect_uncommitted, \"collect_uncommitted\");\n-  pcb.add_u64_counter(l_paxos_collect_timeout, \"collect_timeout\");\n-  pcb.add_u64_counter(l_paxos_accept_timeout, \"accept_timeout\");\n-  pcb.add_u64_counter(l_paxos_lease_ack_timeout, \"lease_ack_timeout\");\n-  pcb.add_u64_counter(l_paxos_lease_timeout, \"lease_timeout\");\n-  pcb.add_u64_counter(l_paxos_store_state, \"store_state\");\n-  pcb.add_u64_avg(l_paxos_store_state_keys, \"store_state_keys\");\n-  pcb.add_u64_avg(l_paxos_store_state_bytes, \"store_state_bytes\");\n-  pcb.add_time_avg(l_paxos_store_state_latency, \"store_state_latency\");\n-  pcb.add_u64_counter(l_paxos_share_state, \"share_state\");\n-  pcb.add_u64_avg(l_paxos_share_state_keys, \"share_state_keys\");\n-  pcb.add_u64_avg(l_paxos_share_state_bytes, \"share_state_bytes\");\n-  pcb.add_u64_counter(l_paxos_new_pn, \"new_pn\");\n-  pcb.add_time_avg(l_paxos_new_pn_latency, \"new_pn_latency\");\n+  pcb.add_u64_counter(l_paxos_collect, \"collect\", \"Peon collects\");\n+  pcb.add_u64_avg(l_paxos_collect_keys, \"collect_keys\", \"Keys in tansaction on peon collect\");","path":"src/mon/Paxos.cc","position":49,"original_position":49,"commit_id":"943879b0f63e8a58da423ead65116cf0fbeb4d77","original_commit_id":"943879b0f63e8a58da423ead65116cf0fbeb4d77","user":{"login":"jcsp","id":944640,"avatar_url":"https://avatars.githubusercontent.com/u/944640?v=3","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"body":"s/tansaction/transaction/ (several of these)","created_at":"2015-04-02T09:52:15Z","updated_at":"2015-04-02T09:52:15Z","html_url":"https://github.com/ceph/ceph/pull/4255#discussion_r27644283","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/4255","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/27644283"},"html":{"href":"https://github.com/ceph/ceph/pull/4255#discussion_r27644283"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4255"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/4255","id":32495531,"html_url":"https://github.com/ceph/ceph/pull/4255","diff_url":"https://github.com/ceph/ceph/pull/4255.diff","patch_url":"https://github.com/ceph/ceph/pull/4255.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/4255","number":4255,"state":"open","locked":false,"title":"Perf counters descriptions, new part","user":{"login":"Ved-vampir","id":10771767,"avatar_url":"https://avatars.githubusercontent.com/u/10771767?v=3","gravatar_id":"","url":"https://api.github.com/users/Ved-vampir","html_url":"https://github.com/Ved-vampir","followers_url":"https://api.github.com/users/Ved-vampir/followers","following_url":"https://api.github.com/users/Ved-vampir/following{/other_user}","gists_url":"https://api.github.com/users/Ved-vampir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ved-vampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ved-vampir/subscriptions","organizations_url":"https://api.github.com/users/Ved-vampir/orgs","repos_url":"https://api.github.com/users/Ved-vampir/repos","events_url":"https://api.github.com/users/Ved-vampir/events{/privacy}","received_events_url":"https://api.github.com/users/Ved-vampir/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-04-02T09:27:41Z","updated_at":"2015-04-02T09:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa78ec75f3f35302aa8237fcf735d0cf23060313","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/4255/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/4255/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/4255/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/943879b0f63e8a58da423ead65116cf0fbeb4d77","head":{"label":"Ved-vampir:osdccnt","ref":"osdccnt","sha":"943879b0f63e8a58da423ead65116cf0fbeb4d77","user":{"login":"Ved-vampir","id":10771767,"avatar_url":"https://avatars.githubusercontent.com/u/10771767?v=3","gravatar_id":"","url":"https://api.github.com/users/Ved-vampir","html_url":"https://github.com/Ved-vampir","followers_url":"https://api.github.com/users/Ved-vampir/followers","following_url":"https://api.github.com/users/Ved-vampir/following{/other_user}","gists_url":"https://api.github.com/users/Ved-vampir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ved-vampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ved-vampir/subscriptions","organizations_url":"https://api.github.com/users/Ved-vampir/orgs","repos_url":"https://api.github.com/users/Ved-vampir/repos","events_url":"https://api.github.com/users/Ved-vampir/events{/privacy}","received_events_url":"https://api.github.com/users/Ved-vampir/received_events","type":"User","site_admin":false},"repo":{"id":30068399,"name":"ceph","full_name":"Ved-vampir/ceph","owner":{"login":"Ved-vampir","id":10771767,"avatar_url":"https://avatars.githubusercontent.com/u/10771767?v=3","gravatar_id":"","url":"https://api.github.com/users/Ved-vampir","html_url":"https://github.com/Ved-vampir","followers_url":"https://api.github.com/users/Ved-vampir/followers","following_url":"https://api.github.com/users/Ved-vampir/following{/other_user}","gists_url":"https://api.github.com/users/Ved-vampir/gists{/gist_id}","starred_url":"https://api.github.com/users/Ved-vampir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ved-vampir/subscriptions","organizations_url":"https://api.github.com/users/Ved-vampir/orgs","repos_url":"https://api.github.com/users/Ved-vampir/repos","events_url":"https://api.github.com/users/Ved-vampir/events{/privacy}","received_events_url":"https://api.github.com/users/Ved-vampir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ved-vampir/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/Ved-vampir/ceph","forks_url":"https://api.github.com/repos/Ved-vampir/ceph/forks","keys_url":"https://api.github.com/repos/Ved-vampir/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ved-vampir/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ved-vampir/ceph/teams","hooks_url":"https://api.github.com/repos/Ved-vampir/ceph/hooks","issue_events_url":"https://api.github.com/repos/Ved-vampir/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/Ved-vampir/ceph/events","assignees_url":"https://api.github.com/repos/Ved-vampir/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/Ved-vampir/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/Ved-vampir/ceph/tags","blobs_url":"https://api.github.com/repos/Ved-vampir/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ved-vampir/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ved-vampir/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ved-vampir/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ved-vampir/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/Ved-vampir/ceph/languages","stargazers_url":"https://api.github.com/repos/Ved-vampir/ceph/stargazers","contributors_url":"https://api.github.com/repos/Ved-vampir/ceph/contributors","subscribers_url":"https://api.github.com/repos/Ved-vampir/ceph/subscribers","subscription_url":"https://api.github.com/repos/Ved-vampir/ceph/subscription","commits_url":"https://api.github.com/repos/Ved-vampir/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ved-vampir/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ved-vampir/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ved-vampir/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ved-vampir/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/Ved-vampir/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ved-vampir/ceph/merges","archive_url":"https://api.github.com/repos/Ved-vampir/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ved-vampir/ceph/downloads","issues_url":"https://api.github.com/repos/Ved-vampir/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/Ved-vampir/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/Ved-vampir/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/Ved-vampir/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ved-vampir/ceph/labels{/name}","releases_url":"https://api.github.com/repos/Ved-vampir/ceph/releases{/id}","created_at":"2015-01-30T11:01:12Z","updated_at":"2015-03-23T10:57:00Z","pushed_at":"2015-03-24T11:21:37Z","git_url":"git://github.com/Ved-vampir/ceph.git","ssh_url":"git@github.com:Ved-vampir/ceph.git","clone_url":"https://github.com/Ved-vampir/ceph.git","svn_url":"https://github.com/Ved-vampir/ceph","homepage":"http://ceph.com","size":113116,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"03d2d80131575e6401f4c39f059c3e1fb024fb6a","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-04-02T09:32:10Z","pushed_at":"2015-04-02T09:32:09Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":387364,"stargazers_count":1208,"watchers_count":1208,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":656,"mirror_url":null,"open_issues_count":126,"forks":656,"open_issues":126,"watchers":1208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4255"},"html":{"href":"https://github.com/ceph/ceph/pull/4255"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/4255"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/4255/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4255/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/4255/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/943879b0f63e8a58da423ead65116cf0fbeb4d77"}}}}