{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/1664","labels_url":"https://api.github.com/repos/rust-lang/cargo/issues/1664/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/1664/comments","events_url":"https://api.github.com/repos/rust-lang/cargo/issues/1664/events","html_url":"https://github.com/rust-lang/cargo/pull/1664","id":82807868,"number":1664,"title":"Fix the detection of directories when listing files using libgit2","user":{"login":"IvanUkhov","id":57440,"avatar_url":"https://avatars.githubusercontent.com/u/57440?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanUkhov","html_url":"https://github.com/IvanUkhov","followers_url":"https://api.github.com/users/IvanUkhov/followers","following_url":"https://api.github.com/users/IvanUkhov/following{/other_user}","gists_url":"https://api.github.com/users/IvanUkhov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanUkhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanUkhov/subscriptions","organizations_url":"https://api.github.com/users/IvanUkhov/orgs","repos_url":"https://api.github.com/users/IvanUkhov/repos","events_url":"https://api.github.com/users/IvanUkhov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanUkhov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-05-30T12:59:06Z","updated_at":"2015-06-01T19:06:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/1664","html_url":"https://github.com/rust-lang/cargo/pull/1664","diff_url":"https://github.com/rust-lang/cargo/pull/1664.diff","patch_url":"https://github.com/rust-lang/cargo/pull/1664.patch"},"body":"The pull request addresses issue #1663. The problem is that `libgit2` [combines][1] `S_IFDIR ` with `S_IFLNK`, and, therefore, the [strict comparison][2] based on `S_ISDIR` rejects directories.\r\n\r\n\r\nRegards,\r\nIvan\r\n\r\n[1]: https://github.com/libgit2/libgit2/blob/47f37400253210f483d84fb9c2ecf44fb5986849/src/index.c#L308\r\n[2]: https://github.com/rust-lang/cargo/blob/06dbe6555a4a15f5912bbfc841d446dad4d417cc/src/cargo/sources/path.rs#L150"},"comment":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/comments/107673143","html_url":"https://github.com/rust-lang/cargo/pull/1664#issuecomment-107673143","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/1664","id":107673143,"user":{"login":"IvanUkhov","id":57440,"avatar_url":"https://avatars.githubusercontent.com/u/57440?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanUkhov","html_url":"https://github.com/IvanUkhov","followers_url":"https://api.github.com/users/IvanUkhov/followers","following_url":"https://api.github.com/users/IvanUkhov/following{/other_user}","gists_url":"https://api.github.com/users/IvanUkhov/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanUkhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanUkhov/subscriptions","organizations_url":"https://api.github.com/users/IvanUkhov/orgs","repos_url":"https://api.github.com/users/IvanUkhov/repos","events_url":"https://api.github.com/users/IvanUkhov/events{/privacy}","received_events_url":"https://api.github.com/users/IvanUkhov/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T19:06:29Z","updated_at":"2015-06-01T19:06:29Z","body":"I’ve updated the pull request; I’m not sure, though, if I’m able to pull off writing a test for that."}}