{"action":"created","issue":{"url":"https://api.github.com/repos/mekentosj/PARViewController/issues/1","labels_url":"https://api.github.com/repos/mekentosj/PARViewController/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mekentosj/PARViewController/issues/1/comments","events_url":"https://api.github.com/repos/mekentosj/PARViewController/issues/1/events","html_url":"https://github.com/mekentosj/PARViewController/pull/1","id":55135617,"number":1,"title":"Improvements to responder chain management","user":{"login":"danielrbrowne","id":1047175,"avatar_url":"https://avatars.githubusercontent.com/u/1047175?v=3","gravatar_id":"","url":"https://api.github.com/users/danielrbrowne","html_url":"https://github.com/danielrbrowne","followers_url":"https://api.github.com/users/danielrbrowne/followers","following_url":"https://api.github.com/users/danielrbrowne/following{/other_user}","gists_url":"https://api.github.com/users/danielrbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrbrowne/subscriptions","organizations_url":"https://api.github.com/users/danielrbrowne/orgs","repos_url":"https://api.github.com/users/danielrbrowne/repos","events_url":"https://api.github.com/users/danielrbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/danielrbrowne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cparnot","id":4797,"avatar_url":"https://avatars.githubusercontent.com/u/4797?v=3","gravatar_id":"","url":"https://api.github.com/users/cparnot","html_url":"https://github.com/cparnot","followers_url":"https://api.github.com/users/cparnot/followers","following_url":"https://api.github.com/users/cparnot/following{/other_user}","gists_url":"https://api.github.com/users/cparnot/gists{/gist_id}","starred_url":"https://api.github.com/users/cparnot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cparnot/subscriptions","organizations_url":"https://api.github.com/users/cparnot/orgs","repos_url":"https://api.github.com/users/cparnot/repos","events_url":"https://api.github.com/users/cparnot/events{/privacy}","received_events_url":"https://api.github.com/users/cparnot/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-01-22T10:13:55Z","updated_at":"2015-01-29T11:23:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mekentosj/PARViewController/pulls/1","html_url":"https://github.com/mekentosj/PARViewController/pull/1","diff_url":"https://github.com/mekentosj/PARViewController/pull/1.diff","patch_url":"https://github.com/mekentosj/PARViewController/pull/1.patch"},"body":"This PR aims to improve the responder chain management of PARViewController so that we (hopefully) avoid hitting the remaining hard-to-diagnose class of crashes due to the garbage data being present in the responder chain during deallocation of views, as described here: https://github.com/mekentosj/papers-mac/issues/3994\r\n\r\nMyself and @defragged worked on this, and are confident that it is working as intended and the responder chain appears intact during adding and removing objects from it, but of course this should have a decent level of scrutiny pointed at it before merging."},"comment":{"url":"https://api.github.com/repos/mekentosj/PARViewController/issues/comments/72009187","html_url":"https://github.com/mekentosj/PARViewController/pull/1#issuecomment-72009187","issue_url":"https://api.github.com/repos/mekentosj/PARViewController/issues/1","id":72009187,"user":{"login":"defragged","id":727283,"avatar_url":"https://avatars.githubusercontent.com/u/727283?v=3","gravatar_id":"","url":"https://api.github.com/users/defragged","html_url":"https://github.com/defragged","followers_url":"https://api.github.com/users/defragged/followers","following_url":"https://api.github.com/users/defragged/following{/other_user}","gists_url":"https://api.github.com/users/defragged/gists{/gist_id}","starred_url":"https://api.github.com/users/defragged/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/defragged/subscriptions","organizations_url":"https://api.github.com/users/defragged/orgs","repos_url":"https://api.github.com/users/defragged/repos","events_url":"https://api.github.com/users/defragged/events{/privacy}","received_events_url":"https://api.github.com/users/defragged/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T11:23:09Z","updated_at":"2015-01-29T11:23:09Z","body":"I don't believe the issues we're seeing are down to observers hanging around. Rather view controllers that are being patched into the responder chain getting deallocated, not removed from the chain, then are later messaged.\r\n\r\nThat's the hypothesis anyway."}}