{"action":"created","comment":{"url":"https://api.github.com/repos/ev3dev/brickman/pulls/comments/35781323","id":35781323,"diff_hunk":"@@ -70,34 +70,34 @@ namespace BrickManager {\n                             throw new IOError.PERMISSION_DENIED (\"Cannot run files owned by system users.\");\n                         try {\n                             var owner = file_info.get_attribute_string (FileAttribute.OWNER_USER);\n+                            // openvt will unfortunately set the ownership of the new /dev/tty<num> to root:root\n+                            // instead of root:tty. Even with root:tty the new application would fails to configure\n+                            // the tty. We deal with that by changing the ownership of the new tty to belong to\n+                            // the owner of the programm we launch.\n+                            var ttyname_dir_template = \"/tmp/brickman.XXXXXX\".dup();\n+                            var ttyname_dir = DirUtils.mkdtemp (ttyname_dir_template);","path":"src/controller/FileBrowserController.vala","position":9,"original_position":9,"commit_id":"feb1647154b88c737c4f1c21cd87c6ffb2edc2d1","original_commit_id":"feb1647154b88c737c4f1c21cd87c6ffb2edc2d1","user":{"login":"dlech","id":963645,"avatar_url":"https://avatars.githubusercontent.com/u/963645?v=3","gravatar_id":"","url":"https://api.github.com/users/dlech","html_url":"https://github.com/dlech","followers_url":"https://api.github.com/users/dlech/followers","following_url":"https://api.github.com/users/dlech/following{/other_user}","gists_url":"https://api.github.com/users/dlech/gists{/gist_id}","starred_url":"https://api.github.com/users/dlech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlech/subscriptions","organizations_url":"https://api.github.com/users/dlech/orgs","repos_url":"https://api.github.com/users/dlech/repos","events_url":"https://api.github.com/users/dlech/events{/privacy}","received_events_url":"https://api.github.com/users/dlech/received_events","type":"User","site_admin":false},"body":"I was hoping that this just created the name and didn't actually create a directory to make things easier. Guess I was wrong. But since you already did the work, this is OK. If we ever need any other temp files in brickman, we can refactor this directory out and use it elsewhere.","created_at":"2015-07-29T16:40:13Z","updated_at":"2015-07-29T16:40:13Z","html_url":"https://github.com/ev3dev/brickman/pull/2#discussion_r35781323","pull_request_url":"https://api.github.com/repos/ev3dev/brickman/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/comments/35781323"},"html":{"href":"https://github.com/ev3dev/brickman/pull/2#discussion_r35781323"},"pull_request":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ev3dev/brickman/pulls/2","id":41098521,"html_url":"https://github.com/ev3dev/brickman/pull/2","diff_url":"https://github.com/ev3dev/brickman/pull/2.diff","patch_url":"https://github.com/ev3dev/brickman/pull/2.patch","issue_url":"https://api.github.com/repos/ev3dev/brickman/issues/2","number":2,"state":"open","locked":false,"title":"Fix the tty permissions and improve the dev-workflow","user":{"login":"ensonic","id":1279486,"avatar_url":"https://avatars.githubusercontent.com/u/1279486?v=3","gravatar_id":"","url":"https://api.github.com/users/ensonic","html_url":"https://github.com/ensonic","followers_url":"https://api.github.com/users/ensonic/followers","following_url":"https://api.github.com/users/ensonic/following{/other_user}","gists_url":"https://api.github.com/users/ensonic/gists{/gist_id}","starred_url":"https://api.github.com/users/ensonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensonic/subscriptions","organizations_url":"https://api.github.com/users/ensonic/orgs","repos_url":"https://api.github.com/users/ensonic/repos","events_url":"https://api.github.com/users/ensonic/events{/privacy}","received_events_url":"https://api.github.com/users/ensonic/received_events","type":"User","site_admin":false},"body":"See issue #365 and #366.","created_at":"2015-07-29T08:32:12Z","updated_at":"2015-07-29T16:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93a5e620a033ffefc3c87edf8c311c7ee3471a2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ev3dev/brickman/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ev3dev/brickman/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ev3dev/brickman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ev3dev/brickman/issues/2/comments","statuses_url":"https://api.github.com/repos/ev3dev/brickman/statuses/feb1647154b88c737c4f1c21cd87c6ffb2edc2d1","head":{"label":"ensonic:ev3dev-jessie","ref":"ev3dev-jessie","sha":"feb1647154b88c737c4f1c21cd87c6ffb2edc2d1","user":{"login":"ensonic","id":1279486,"avatar_url":"https://avatars.githubusercontent.com/u/1279486?v=3","gravatar_id":"","url":"https://api.github.com/users/ensonic","html_url":"https://github.com/ensonic","followers_url":"https://api.github.com/users/ensonic/followers","following_url":"https://api.github.com/users/ensonic/following{/other_user}","gists_url":"https://api.github.com/users/ensonic/gists{/gist_id}","starred_url":"https://api.github.com/users/ensonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensonic/subscriptions","organizations_url":"https://api.github.com/users/ensonic/orgs","repos_url":"https://api.github.com/users/ensonic/repos","events_url":"https://api.github.com/users/ensonic/events{/privacy}","received_events_url":"https://api.github.com/users/ensonic/received_events","type":"User","site_admin":false},"repo":{"id":39829163,"name":"brickman","full_name":"ensonic/brickman","owner":{"login":"ensonic","id":1279486,"avatar_url":"https://avatars.githubusercontent.com/u/1279486?v=3","gravatar_id":"","url":"https://api.github.com/users/ensonic","html_url":"https://github.com/ensonic","followers_url":"https://api.github.com/users/ensonic/followers","following_url":"https://api.github.com/users/ensonic/following{/other_user}","gists_url":"https://api.github.com/users/ensonic/gists{/gist_id}","starred_url":"https://api.github.com/users/ensonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ensonic/subscriptions","organizations_url":"https://api.github.com/users/ensonic/orgs","repos_url":"https://api.github.com/users/ensonic/repos","events_url":"https://api.github.com/users/ensonic/events{/privacy}","received_events_url":"https://api.github.com/users/ensonic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ensonic/brickman","description":"Brick Manager for ev3dev","fork":true,"url":"https://api.github.com/repos/ensonic/brickman","forks_url":"https://api.github.com/repos/ensonic/brickman/forks","keys_url":"https://api.github.com/repos/ensonic/brickman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ensonic/brickman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ensonic/brickman/teams","hooks_url":"https://api.github.com/repos/ensonic/brickman/hooks","issue_events_url":"https://api.github.com/repos/ensonic/brickman/issues/events{/number}","events_url":"https://api.github.com/repos/ensonic/brickman/events","assignees_url":"https://api.github.com/repos/ensonic/brickman/assignees{/user}","branches_url":"https://api.github.com/repos/ensonic/brickman/branches{/branch}","tags_url":"https://api.github.com/repos/ensonic/brickman/tags","blobs_url":"https://api.github.com/repos/ensonic/brickman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ensonic/brickman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ensonic/brickman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ensonic/brickman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ensonic/brickman/statuses/{sha}","languages_url":"https://api.github.com/repos/ensonic/brickman/languages","stargazers_url":"https://api.github.com/repos/ensonic/brickman/stargazers","contributors_url":"https://api.github.com/repos/ensonic/brickman/contributors","subscribers_url":"https://api.github.com/repos/ensonic/brickman/subscribers","subscription_url":"https://api.github.com/repos/ensonic/brickman/subscription","commits_url":"https://api.github.com/repos/ensonic/brickman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ensonic/brickman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ensonic/brickman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ensonic/brickman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ensonic/brickman/contents/{+path}","compare_url":"https://api.github.com/repos/ensonic/brickman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ensonic/brickman/merges","archive_url":"https://api.github.com/repos/ensonic/brickman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ensonic/brickman/downloads","issues_url":"https://api.github.com/repos/ensonic/brickman/issues{/number}","pulls_url":"https://api.github.com/repos/ensonic/brickman/pulls{/number}","milestones_url":"https://api.github.com/repos/ensonic/brickman/milestones{/number}","notifications_url":"https://api.github.com/repos/ensonic/brickman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ensonic/brickman/labels{/name}","releases_url":"https://api.github.com/repos/ensonic/brickman/releases{/id}","created_at":"2015-07-28T11:02:27Z","updated_at":"2015-07-28T11:02:28Z","pushed_at":"2015-07-29T16:26:59Z","git_url":"git://github.com/ensonic/brickman.git","ssh_url":"git@github.com:ensonic/brickman.git","clone_url":"https://github.com/ensonic/brickman.git","svn_url":"https://github.com/ensonic/brickman","homepage":"http://www.ev3dev.org","size":880,"stargazers_count":0,"watchers_count":0,"language":"Vala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ev3dev-jessie"}},"base":{"label":"ev3dev:ev3dev-jessie","ref":"ev3dev-jessie","sha":"f7662b34bc6989f87cdd4c4c73a7235f14d0f257","user":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"repo":{"id":20454766,"name":"brickman","full_name":"ev3dev/brickman","owner":{"login":"ev3dev","id":6878323,"avatar_url":"https://avatars.githubusercontent.com/u/6878323?v=3","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ev3dev/brickman","description":"Brick Manager for ev3dev","fork":false,"url":"https://api.github.com/repos/ev3dev/brickman","forks_url":"https://api.github.com/repos/ev3dev/brickman/forks","keys_url":"https://api.github.com/repos/ev3dev/brickman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev3dev/brickman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev3dev/brickman/teams","hooks_url":"https://api.github.com/repos/ev3dev/brickman/hooks","issue_events_url":"https://api.github.com/repos/ev3dev/brickman/issues/events{/number}","events_url":"https://api.github.com/repos/ev3dev/brickman/events","assignees_url":"https://api.github.com/repos/ev3dev/brickman/assignees{/user}","branches_url":"https://api.github.com/repos/ev3dev/brickman/branches{/branch}","tags_url":"https://api.github.com/repos/ev3dev/brickman/tags","blobs_url":"https://api.github.com/repos/ev3dev/brickman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev3dev/brickman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev3dev/brickman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev3dev/brickman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev3dev/brickman/statuses/{sha}","languages_url":"https://api.github.com/repos/ev3dev/brickman/languages","stargazers_url":"https://api.github.com/repos/ev3dev/brickman/stargazers","contributors_url":"https://api.github.com/repos/ev3dev/brickman/contributors","subscribers_url":"https://api.github.com/repos/ev3dev/brickman/subscribers","subscription_url":"https://api.github.com/repos/ev3dev/brickman/subscription","commits_url":"https://api.github.com/repos/ev3dev/brickman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev3dev/brickman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev3dev/brickman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev3dev/brickman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev3dev/brickman/contents/{+path}","compare_url":"https://api.github.com/repos/ev3dev/brickman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev3dev/brickman/merges","archive_url":"https://api.github.com/repos/ev3dev/brickman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev3dev/brickman/downloads","issues_url":"https://api.github.com/repos/ev3dev/brickman/issues{/number}","pulls_url":"https://api.github.com/repos/ev3dev/brickman/pulls{/number}","milestones_url":"https://api.github.com/repos/ev3dev/brickman/milestones{/number}","notifications_url":"https://api.github.com/repos/ev3dev/brickman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev3dev/brickman/labels{/name}","releases_url":"https://api.github.com/repos/ev3dev/brickman/releases{/id}","created_at":"2014-06-03T18:39:12Z","updated_at":"2015-05-01T23:11:51Z","pushed_at":"2015-07-29T16:27:00Z","git_url":"git://github.com/ev3dev/brickman.git","ssh_url":"git@github.com:ev3dev/brickman.git","clone_url":"https://github.com/ev3dev/brickman.git","svn_url":"https://github.com/ev3dev/brickman","homepage":"http://www.ev3dev.org","size":1119,"stargazers_count":6,"watchers_count":6,"language":"Vala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":6,"default_branch":"ev3dev-jessie"}},"_links":{"self":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/2"},"html":{"href":"https://github.com/ev3dev/brickman/pull/2"},"issue":{"href":"https://api.github.com/repos/ev3dev/brickman/issues/2"},"comments":{"href":"https://api.github.com/repos/ev3dev/brickman/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ev3dev/brickman/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ev3dev/brickman/statuses/feb1647154b88c737c4f1c21cd87c6ffb2edc2d1"}}}}