{"action":"created","comment":{"url":"https://api.github.com/repos/dpla/KriKri/pulls/comments/26163749","id":26163749,"diff_hunk":"@@ -83,5 +83,23 @@ def rdf_subject\n       RDF::URI(Krikri::Settings['marmotta']['ldp']) /\n         Krikri::Settings['prov']['activity'] / id.to_s\n     end\n+\n+    ##\n+    # Return an Enumerator of URI strings of entities (e.g. aggregations or\n+    # original records) that pertain to this activity\n+    #\n+    # @return [Enumerator] URI strings","path":"app/models/krikri/activity.rb","position":9,"original_position":9,"commit_id":"732f16c67a38e16d072e6d06aa6a1671572bbac5","original_commit_id":"732f16c67a38e16d072e6d06aa6a1671572bbac5","user":{"login":"anarchivist","id":73732,"avatar_url":"https://avatars.githubusercontent.com/u/73732?v=3","gravatar_id":"","url":"https://api.github.com/users/anarchivist","html_url":"https://github.com/anarchivist","followers_url":"https://api.github.com/users/anarchivist/followers","following_url":"https://api.github.com/users/anarchivist/following{/other_user}","gists_url":"https://api.github.com/users/anarchivist/gists{/gist_id}","starred_url":"https://api.github.com/users/anarchivist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anarchivist/subscriptions","organizations_url":"https://api.github.com/users/anarchivist/orgs","repos_url":"https://api.github.com/users/anarchivist/repos","events_url":"https://api.github.com/users/anarchivist/events{/privacy}","received_events_url":"https://api.github.com/users/anarchivist/received_events","type":"User","site_admin":false},"body":"Minor: This should state it returns an `Enumerator::Lazy`.","created_at":"2015-03-10T20:42:23Z","updated_at":"2015-03-10T20:42:23Z","html_url":"https://github.com/dpla/KriKri/pull/116#discussion_r26163749","pull_request_url":"https://api.github.com/repos/dpla/KriKri/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/comments/26163749"},"html":{"href":"https://github.com/dpla/KriKri/pull/116#discussion_r26163749"},"pull_request":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/dpla/KriKri/pulls/116","id":30794448,"html_url":"https://github.com/dpla/KriKri/pull/116","diff_url":"https://github.com/dpla/KriKri/pull/116.diff","patch_url":"https://github.com/dpla/KriKri/pull/116.patch","issue_url":"https://api.github.com/repos/dpla/KriKri/issues/116","number":116,"state":"open","locked":false,"title":"Feature/index an activity","user":{"login":"markbreedlove","id":5550828,"avatar_url":"https://avatars.githubusercontent.com/u/5550828?v=3","gravatar_id":"","url":"https://api.github.com/users/markbreedlove","html_url":"https://github.com/markbreedlove","followers_url":"https://api.github.com/users/markbreedlove/followers","following_url":"https://api.github.com/users/markbreedlove/following{/other_user}","gists_url":"https://api.github.com/users/markbreedlove/gists{/gist_id}","starred_url":"https://api.github.com/users/markbreedlove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markbreedlove/subscriptions","organizations_url":"https://api.github.com/users/markbreedlove/orgs","repos_url":"https://api.github.com/users/markbreedlove/repos","events_url":"https://api.github.com/users/markbreedlove/events{/privacy}","received_events_url":"https://api.github.com/users/markbreedlove/received_events","type":"User","site_admin":false},"body":"** DO NOT MERGE **\r\n\r\nThis is just for comment.  I am not done with this branch yet.\r\n\r\nI've added \"behavior\" classes for activities, in preparation for the addition of indexing activities, and having activities report on the entities they generated.\r\n\r\nThere are some FIXME and TODO items that need attention:\r\n\r\n1. My [factory method for representing an enrichment](https://github.com/dpla/KriKri/blob/4f3012063bc0b17626f1f90b3ad8331c57a17bca/spec/factories/krikri_activities.rb#L25-L62) is not working\r\n2. There's an [issue with representing an options hash](https://github.com/dpla/KriKri/blob/4f3012063bc0b17626f1f90b3ad8331c57a17bca/spec/lib/krikri/mapper_agent_spec.rb#L9-L33) in the Mapper::Agent tests.\r\n3. I want to remove [`Mapper::Agent#target_records`](https://github.com/dpla/KriKri/blob/feature/index-an-activity/lib/krikri/mapper.rb#L135-L164) (formerly named `records`) but I'm having trouble refactoring the spec tests to get that to happen.\r\n\r\nNext up, also for comment:\r\n- I think the behavior classes should be moved into a subdirectory\r\n- I need to add a test for SoftwareAgent#set_generator_activity\r\n- I need to actually add Elasticsearch indexing!\r\n","created_at":"2015-03-09T20:02:08Z","updated_at":"2015-03-10T20:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae143b5c2d6a9851d229970bd02ad085002caceb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dpla/KriKri/pulls/116/commits","review_comments_url":"https://api.github.com/repos/dpla/KriKri/pulls/116/comments","review_comment_url":"https://api.github.com/repos/dpla/KriKri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpla/KriKri/issues/116/comments","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/732f16c67a38e16d072e6d06aa6a1671572bbac5","head":{"label":"dpla:feature/index-an-activity","ref":"feature/index-an-activity","sha":"732f16c67a38e16d072e6d06aa6a1671572bbac5","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":25104780,"name":"KriKri","full_name":"dpla/KriKri","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/KriKri","description":"A Rails engine for metadata aggregation, enhancement, and quality control.","fork":false,"url":"https://api.github.com/repos/dpla/KriKri","forks_url":"https://api.github.com/repos/dpla/KriKri/forks","keys_url":"https://api.github.com/repos/dpla/KriKri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/KriKri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/KriKri/teams","hooks_url":"https://api.github.com/repos/dpla/KriKri/hooks","issue_events_url":"https://api.github.com/repos/dpla/KriKri/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/KriKri/events","assignees_url":"https://api.github.com/repos/dpla/KriKri/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/KriKri/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/KriKri/tags","blobs_url":"https://api.github.com/repos/dpla/KriKri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/KriKri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/KriKri/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/KriKri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/KriKri/languages","stargazers_url":"https://api.github.com/repos/dpla/KriKri/stargazers","contributors_url":"https://api.github.com/repos/dpla/KriKri/contributors","subscribers_url":"https://api.github.com/repos/dpla/KriKri/subscribers","subscription_url":"https://api.github.com/repos/dpla/KriKri/subscription","commits_url":"https://api.github.com/repos/dpla/KriKri/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/KriKri/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/KriKri/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/KriKri/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpla/KriKri/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/KriKri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/KriKri/merges","archive_url":"https://api.github.com/repos/dpla/KriKri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/KriKri/downloads","issues_url":"https://api.github.com/repos/dpla/KriKri/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/KriKri/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/KriKri/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/KriKri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/KriKri/labels{/name}","releases_url":"https://api.github.com/repos/dpla/KriKri/releases{/id}","created_at":"2014-10-12T02:41:01Z","updated_at":"2015-03-10T20:39:06Z","pushed_at":"2015-03-10T20:39:05Z","git_url":"git://github.com/dpla/KriKri.git","ssh_url":"git@github.com:dpla/KriKri.git","clone_url":"https://github.com/dpla/KriKri.git","svn_url":"https://github.com/dpla/KriKri","homepage":null,"size":3861,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":17,"default_branch":"develop"}},"base":{"label":"dpla:develop","ref":"develop","sha":"106343cc8c89c939486a23954bf7aea2051e957b","user":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"repo":{"id":25104780,"name":"KriKri","full_name":"dpla/KriKri","owner":{"login":"dpla","id":1252916,"avatar_url":"https://avatars.githubusercontent.com/u/1252916?v=3","gravatar_id":"","url":"https://api.github.com/users/dpla","html_url":"https://github.com/dpla","followers_url":"https://api.github.com/users/dpla/followers","following_url":"https://api.github.com/users/dpla/following{/other_user}","gists_url":"https://api.github.com/users/dpla/gists{/gist_id}","starred_url":"https://api.github.com/users/dpla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpla/subscriptions","organizations_url":"https://api.github.com/users/dpla/orgs","repos_url":"https://api.github.com/users/dpla/repos","events_url":"https://api.github.com/users/dpla/events{/privacy}","received_events_url":"https://api.github.com/users/dpla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dpla/KriKri","description":"A Rails engine for metadata aggregation, enhancement, and quality control.","fork":false,"url":"https://api.github.com/repos/dpla/KriKri","forks_url":"https://api.github.com/repos/dpla/KriKri/forks","keys_url":"https://api.github.com/repos/dpla/KriKri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpla/KriKri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpla/KriKri/teams","hooks_url":"https://api.github.com/repos/dpla/KriKri/hooks","issue_events_url":"https://api.github.com/repos/dpla/KriKri/issues/events{/number}","events_url":"https://api.github.com/repos/dpla/KriKri/events","assignees_url":"https://api.github.com/repos/dpla/KriKri/assignees{/user}","branches_url":"https://api.github.com/repos/dpla/KriKri/branches{/branch}","tags_url":"https://api.github.com/repos/dpla/KriKri/tags","blobs_url":"https://api.github.com/repos/dpla/KriKri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpla/KriKri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpla/KriKri/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpla/KriKri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpla/KriKri/statuses/{sha}","languages_url":"https://api.github.com/repos/dpla/KriKri/languages","stargazers_url":"https://api.github.com/repos/dpla/KriKri/stargazers","contributors_url":"https://api.github.com/repos/dpla/KriKri/contributors","subscribers_url":"https://api.github.com/repos/dpla/KriKri/subscribers","subscription_url":"https://api.github.com/repos/dpla/KriKri/subscription","commits_url":"https://api.github.com/repos/dpla/KriKri/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpla/KriKri/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpla/KriKri/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpla/KriKri/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpla/KriKri/contents/{+path}","compare_url":"https://api.github.com/repos/dpla/KriKri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpla/KriKri/merges","archive_url":"https://api.github.com/repos/dpla/KriKri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpla/KriKri/downloads","issues_url":"https://api.github.com/repos/dpla/KriKri/issues{/number}","pulls_url":"https://api.github.com/repos/dpla/KriKri/pulls{/number}","milestones_url":"https://api.github.com/repos/dpla/KriKri/milestones{/number}","notifications_url":"https://api.github.com/repos/dpla/KriKri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpla/KriKri/labels{/name}","releases_url":"https://api.github.com/repos/dpla/KriKri/releases{/id}","created_at":"2014-10-12T02:41:01Z","updated_at":"2015-03-10T20:39:06Z","pushed_at":"2015-03-10T20:39:05Z","git_url":"git://github.com/dpla/KriKri.git","ssh_url":"git@github.com:dpla/KriKri.git","clone_url":"https://github.com/dpla/KriKri.git","svn_url":"https://github.com/dpla/KriKri","homepage":null,"size":3861,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/116"},"html":{"href":"https://github.com/dpla/KriKri/pull/116"},"issue":{"href":"https://api.github.com/repos/dpla/KriKri/issues/116"},"comments":{"href":"https://api.github.com/repos/dpla/KriKri/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpla/KriKri/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/dpla/KriKri/statuses/732f16c67a38e16d072e6d06aa6a1671572bbac5"}}}}