{"action":"closed","number":4383,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383","id":46560701,"html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4383","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/4383.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/4383.patch","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4383","number":4383,"state":"closed","locked":false,"title":"[blocked] Update developer app reg UI to work with JSONAPI formatting changes","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"body":"Refs [#OSF-4720].\r\n\r\n\r\n## Purpose\r\nFix an issue where recent JSONAPI format changes caused data to be rejected by the server. Ensure that data is correctly serialized so that developer apps can be registered and updated.\r\n\r\n## Summary of changes\r\n- Change serialization method in data model\r\n- Update unit tests to check additional fields\r\n\r\nThis issue was not caught because there are not presently any integration tests between the frontend and APIv2. If this issue continues to crop up in the future, we may need to revisit that strategy.\r\n\r\n## Blockers\r\nWill require further testing once id field issue is resolved ([#OSF-4725]); difficult to fully test as that issue is blocking data submission to server. Candidate fix for review in #4392 .","created_at":"2015-10-01T18:42:10Z","updated_at":"2015-10-07T17:56:29Z","closed_at":"2015-10-07T17:56:29Z","merged_at":"2015-10-07T17:56:29Z","merge_commit_sha":"009a91915b29b9f90fba0e57e334722ca166fd4c","assignee":null,"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/51","html_url":"https://github.com/CenterForOpenScience/osf.io/milestones/0.52.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/51/labels","id":1313635,"number":51,"title":"0.52.0","description":"JIRA Sprint 3","creator":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":43,"state":"open","created_at":"2015-09-18T15:50:28Z","updated_at":"2015-10-07T17:56:29Z","due_on":"2015-10-07T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383/commits","review_comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383/comments","review_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4383/comments","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/06038911f781b117241e022ef694b7a6ece0afae","head":{"label":"abought:fix/osf4270-appreg","ref":"fix/osf4270-appreg","sha":"06038911f781b117241e022ef694b7a6ece0afae","user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"repo":{"id":31237649,"name":"osf.io","full_name":"abought/osf.io","owner":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abought/osf.io","description":"Facilitating Open Science","fork":true,"url":"https://api.github.com/repos/abought/osf.io","forks_url":"https://api.github.com/repos/abought/osf.io/forks","keys_url":"https://api.github.com/repos/abought/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abought/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abought/osf.io/teams","hooks_url":"https://api.github.com/repos/abought/osf.io/hooks","issue_events_url":"https://api.github.com/repos/abought/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/abought/osf.io/events","assignees_url":"https://api.github.com/repos/abought/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/abought/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/abought/osf.io/tags","blobs_url":"https://api.github.com/repos/abought/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abought/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abought/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/abought/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abought/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/abought/osf.io/languages","stargazers_url":"https://api.github.com/repos/abought/osf.io/stargazers","contributors_url":"https://api.github.com/repos/abought/osf.io/contributors","subscribers_url":"https://api.github.com/repos/abought/osf.io/subscribers","subscription_url":"https://api.github.com/repos/abought/osf.io/subscription","commits_url":"https://api.github.com/repos/abought/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/abought/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/abought/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/abought/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/abought/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/abought/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abought/osf.io/merges","archive_url":"https://api.github.com/repos/abought/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abought/osf.io/downloads","issues_url":"https://api.github.com/repos/abought/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/abought/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/abought/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/abought/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abought/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/abought/osf.io/releases{/id}","created_at":"2015-02-24T00:27:13Z","updated_at":"2015-05-06T13:18:01Z","pushed_at":"2015-10-05T13:29:00Z","git_url":"git://github.com/abought/osf.io.git","ssh_url":"git@github.com:abought/osf.io.git","clone_url":"https://github.com/abought/osf.io.git","svn_url":"https://github.com/abought/osf.io","homepage":"http://osf.io","size":101999,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"CenterForOpenScience:develop","ref":"develop","sha":"c2d811a3b83876bab494f5b36660ad96233a4f64","user":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"repo":{"id":10199599,"name":"osf.io","full_name":"CenterForOpenScience/osf.io","owner":{"login":"CenterForOpenScience","id":3344584,"avatar_url":"https://avatars.githubusercontent.com/u/3344584?v=3","gravatar_id":"","url":"https://api.github.com/users/CenterForOpenScience","html_url":"https://github.com/CenterForOpenScience","followers_url":"https://api.github.com/users/CenterForOpenScience/followers","following_url":"https://api.github.com/users/CenterForOpenScience/following{/other_user}","gists_url":"https://api.github.com/users/CenterForOpenScience/gists{/gist_id}","starred_url":"https://api.github.com/users/CenterForOpenScience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CenterForOpenScience/subscriptions","organizations_url":"https://api.github.com/users/CenterForOpenScience/orgs","repos_url":"https://api.github.com/users/CenterForOpenScience/repos","events_url":"https://api.github.com/users/CenterForOpenScience/events{/privacy}","received_events_url":"https://api.github.com/users/CenterForOpenScience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CenterForOpenScience/osf.io","description":"Facilitating Open Science","fork":false,"url":"https://api.github.com/repos/CenterForOpenScience/osf.io","forks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/forks","keys_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/teams","hooks_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/hooks","issue_events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/events{/number}","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/events","assignees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/assignees{/user}","branches_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/branches{/branch}","tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/tags","blobs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/{sha}","languages_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/languages","stargazers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/stargazers","contributors_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contributors","subscribers_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscribers","subscription_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/subscription","commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/contents/{+path}","compare_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/merges","archive_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/downloads","issues_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues{/number}","pulls_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls{/number}","milestones_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones{/number}","notifications_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/labels{/name}","releases_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/releases{/id}","created_at":"2013-05-21T15:53:37Z","updated_at":"2015-09-28T06:19:31Z","pushed_at":"2015-10-07T17:56:29Z","git_url":"git://github.com/CenterForOpenScience/osf.io.git","ssh_url":"git@github.com:CenterForOpenScience/osf.io.git","clone_url":"https://github.com/CenterForOpenScience/osf.io.git","svn_url":"https://github.com/CenterForOpenScience/osf.io","homepage":"http://osf.io","size":233372,"stargazers_count":140,"watchers_count":140,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":420,"forks":121,"open_issues":420,"watchers":140,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383"},"html":{"href":"https://github.com/CenterForOpenScience/osf.io/pull/4383"},"issue":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4383"},"comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4383/comments"},"review_comments":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383/comments"},"review_comment":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4383/commits"},"statuses":{"href":"https://api.github.com/repos/CenterForOpenScience/osf.io/statuses/06038911f781b117241e022ef694b7a6ece0afae"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":23,"deletions":16,"changed_files":2}}