{"action":"opened","number":102,"pull_request":{"url":"https://api.github.com/repos/laravel/lumen-framework/pulls/102","id":35448184,"html_url":"https://github.com/laravel/lumen-framework/pull/102","diff_url":"https://github.com/laravel/lumen-framework/pull/102.diff","patch_url":"https://github.com/laravel/lumen-framework/pull/102.patch","issue_url":"https://api.github.com/repos/laravel/lumen-framework/issues/102","number":102,"state":"open","locked":false,"title":"Resolved a problem where response()->download() was returning 0 bytes.","user":{"login":"Raistlfiren","id":234712,"avatar_url":"https://avatars.githubusercontent.com/u/234712?v=3","gravatar_id":"","url":"https://api.github.com/users/Raistlfiren","html_url":"https://github.com/Raistlfiren","followers_url":"https://api.github.com/users/Raistlfiren/followers","following_url":"https://api.github.com/users/Raistlfiren/following{/other_user}","gists_url":"https://api.github.com/users/Raistlfiren/gists{/gist_id}","starred_url":"https://api.github.com/users/Raistlfiren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raistlfiren/subscriptions","organizations_url":"https://api.github.com/users/Raistlfiren/orgs","repos_url":"https://api.github.com/users/Raistlfiren/repos","events_url":"https://api.github.com/users/Raistlfiren/events{/privacy}","received_events_url":"https://api.github.com/users/Raistlfiren/received_events","type":"User","site_admin":false},"body":"I ran into the same issue as https://github.com/laravel/lumen-framework/issues/74 where the content body was returning nothing. After further debugging I found out that in the Symfony HttpFoundation was returning a maxlen of 0 everytime. The maxlen variable was never being set since the prepare() method was never called. After evoking the prepare() method in BinaryFileResponse it set the maxlen properly and returned the correct size of the file. I don't know if this is the proper way of doing this, but it works.\r\n\r\nThanks!","created_at":"2015-05-14T18:33:12Z","updated_at":"2015-05-14T18:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/lumen-framework/pulls/102/commits","review_comments_url":"https://api.github.com/repos/laravel/lumen-framework/pulls/102/comments","review_comment_url":"https://api.github.com/repos/laravel/lumen-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/lumen-framework/issues/102/comments","statuses_url":"https://api.github.com/repos/laravel/lumen-framework/statuses/30257c4c3c3510666591c01173714ed3662145c5","head":{"label":"Raistlfiren:5.0","ref":"5.0","sha":"30257c4c3c3510666591c01173714ed3662145c5","user":{"login":"Raistlfiren","id":234712,"avatar_url":"https://avatars.githubusercontent.com/u/234712?v=3","gravatar_id":"","url":"https://api.github.com/users/Raistlfiren","html_url":"https://github.com/Raistlfiren","followers_url":"https://api.github.com/users/Raistlfiren/followers","following_url":"https://api.github.com/users/Raistlfiren/following{/other_user}","gists_url":"https://api.github.com/users/Raistlfiren/gists{/gist_id}","starred_url":"https://api.github.com/users/Raistlfiren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raistlfiren/subscriptions","organizations_url":"https://api.github.com/users/Raistlfiren/orgs","repos_url":"https://api.github.com/users/Raistlfiren/repos","events_url":"https://api.github.com/users/Raistlfiren/events{/privacy}","received_events_url":"https://api.github.com/users/Raistlfiren/received_events","type":"User","site_admin":false},"repo":{"id":35623350,"name":"lumen-framework","full_name":"Raistlfiren/lumen-framework","owner":{"login":"Raistlfiren","id":234712,"avatar_url":"https://avatars.githubusercontent.com/u/234712?v=3","gravatar_id":"","url":"https://api.github.com/users/Raistlfiren","html_url":"https://github.com/Raistlfiren","followers_url":"https://api.github.com/users/Raistlfiren/followers","following_url":"https://api.github.com/users/Raistlfiren/following{/other_user}","gists_url":"https://api.github.com/users/Raistlfiren/gists{/gist_id}","starred_url":"https://api.github.com/users/Raistlfiren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raistlfiren/subscriptions","organizations_url":"https://api.github.com/users/Raistlfiren/orgs","repos_url":"https://api.github.com/users/Raistlfiren/repos","events_url":"https://api.github.com/users/Raistlfiren/events{/privacy}","received_events_url":"https://api.github.com/users/Raistlfiren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Raistlfiren/lumen-framework","description":"","fork":true,"url":"https://api.github.com/repos/Raistlfiren/lumen-framework","forks_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/forks","keys_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/teams","hooks_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/hooks","issue_events_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/issues/events{/number}","events_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/events","assignees_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/assignees{/user}","branches_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/branches{/branch}","tags_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/tags","blobs_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/languages","stargazers_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/stargazers","contributors_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/contributors","subscribers_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/subscribers","subscription_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/subscription","commits_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/contents/{+path}","compare_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/merges","archive_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/downloads","issues_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/issues{/number}","pulls_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/labels{/name}","releases_url":"https://api.github.com/repos/Raistlfiren/lumen-framework/releases{/id}","created_at":"2015-05-14T16:46:01Z","updated_at":"2015-05-14T16:46:12Z","pushed_at":"2015-05-14T18:26:11Z","git_url":"git://github.com/Raistlfiren/lumen-framework.git","ssh_url":"git@github.com:Raistlfiren/lumen-framework.git","clone_url":"https://github.com/Raistlfiren/lumen-framework.git","svn_url":"https://github.com/Raistlfiren/lumen-framework","homepage":"","size":922,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.0","ref":"5.0","sha":"16ae1d590d0f73b61212b1375bdf41e69cb594c1","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":33903775,"name":"lumen-framework","full_name":"laravel/lumen-framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/lumen-framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/lumen-framework","forks_url":"https://api.github.com/repos/laravel/lumen-framework/forks","keys_url":"https://api.github.com/repos/laravel/lumen-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/lumen-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/lumen-framework/teams","hooks_url":"https://api.github.com/repos/laravel/lumen-framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/lumen-framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/lumen-framework/events","assignees_url":"https://api.github.com/repos/laravel/lumen-framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/lumen-framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/lumen-framework/tags","blobs_url":"https://api.github.com/repos/laravel/lumen-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/lumen-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/lumen-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/lumen-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/lumen-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/lumen-framework/languages","stargazers_url":"https://api.github.com/repos/laravel/lumen-framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/lumen-framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/lumen-framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/lumen-framework/subscription","commits_url":"https://api.github.com/repos/laravel/lumen-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/lumen-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/lumen-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/lumen-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/lumen-framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/lumen-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/lumen-framework/merges","archive_url":"https://api.github.com/repos/laravel/lumen-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/lumen-framework/downloads","issues_url":"https://api.github.com/repos/laravel/lumen-framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/lumen-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/lumen-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/lumen-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/lumen-framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/lumen-framework/releases{/id}","created_at":"2015-04-14T01:30:27Z","updated_at":"2015-05-13T18:04:18Z","pushed_at":"2015-05-13T21:03:56Z","git_url":"git://github.com/laravel/lumen-framework.git","ssh_url":"git@github.com:laravel/lumen-framework.git","clone_url":"https://github.com/laravel/lumen-framework.git","svn_url":"https://github.com/laravel/lumen-framework","homepage":null,"size":922,"stargazers_count":247,"watchers_count":247,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":6,"forks":64,"open_issues":6,"watchers":247,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/lumen-framework/pulls/102"},"html":{"href":"https://github.com/laravel/lumen-framework/pull/102"},"issue":{"href":"https://api.github.com/repos/laravel/lumen-framework/issues/102"},"comments":{"href":"https://api.github.com/repos/laravel/lumen-framework/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/lumen-framework/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/lumen-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/lumen-framework/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/lumen-framework/statuses/30257c4c3c3510666591c01173714ed3662145c5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":0,"changed_files":1}}