{"action":"created","issue":{"url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/281","labels_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/281/comments","events_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/281/events","html_url":"https://github.com/davidjbradshaw/iframe-resizer/issues/281","id":113782135,"number":281,"title":"Not correctly calculating taggedElement margin. ","user":{"login":"danballance","id":13839912,"avatar_url":"https://avatars.githubusercontent.com/u/13839912?v=3","gravatar_id":"","url":"https://api.github.com/users/danballance","html_url":"https://github.com/danballance","followers_url":"https://api.github.com/users/danballance/followers","following_url":"https://api.github.com/users/danballance/following{/other_user}","gists_url":"https://api.github.com/users/danballance/gists{/gist_id}","starred_url":"https://api.github.com/users/danballance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danballance/subscriptions","organizations_url":"https://api.github.com/users/danballance/orgs","repos_url":"https://api.github.com/users/danballance/repos","events_url":"https://api.github.com/users/danballance/events{/privacy}","received_events_url":"https://api.github.com/users/danballance/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-10-28T09:59:26Z","updated_at":"2015-10-30T16:46:35Z","closed_at":null,"body":"Hi,\r\n\r\nWe are loving this project and using it to load a shopping cart on our marketing site. So thanks in advance for all of the great work.\r\n\r\nOne issue we are hitting is where a modal dialogue opens and the height calculation returns the correct bottom position of the modal, but \"crops\" our drop shadow breaking the illusion that the cart is actually in the page.\r\n\r\nWould you be open to me submitting a pull request for a couple of extra options, say: heightModifier and widthModifier ?\r\n\r\nSo my idea is that after the height or width calculation has been done, this modifier would be applied. We would like to use this to add 20 or 30 pixels to the height calculation so that we don't lose our drop shadow.\r\n\r\nWould you be interested in this as a new feature? Do you think I am approaching the problem in the correct way?\r\n\r\nmany thanks in advance,\r\n\r\nDan "},"comment":{"url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/comments/152583557","html_url":"https://github.com/davidjbradshaw/iframe-resizer/issues/281#issuecomment-152583557","issue_url":"https://api.github.com/repos/davidjbradshaw/iframe-resizer/issues/281","id":152583557,"user":{"login":"danballance","id":13839912,"avatar_url":"https://avatars.githubusercontent.com/u/13839912?v=3","gravatar_id":"","url":"https://api.github.com/users/danballance","html_url":"https://github.com/danballance","followers_url":"https://api.github.com/users/danballance/followers","following_url":"https://api.github.com/users/danballance/following{/other_user}","gists_url":"https://api.github.com/users/danballance/gists{/gist_id}","starred_url":"https://api.github.com/users/danballance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danballance/subscriptions","organizations_url":"https://api.github.com/users/danballance/orgs","repos_url":"https://api.github.com/users/danballance/repos","events_url":"https://api.github.com/users/danballance/events{/privacy}","received_events_url":"https://api.github.com/users/danballance/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T16:46:35Z","updated_at":"2015-10-30T16:46:35Z","body":"Just to confirm, I have a provisional version of this working now on my local machine that checks the margins on the element being processed and also accepts the additional settings of widthModification and heightModification. It's not unit tested or linted yet though. If you think it's worth a pull request I'll get it into a proper state to send across to you."}}