{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/comments/45044880","id":45044880,"diff_hunk":"@@ -0,0 +1,45 @@\n+Veewee::Session.declare({\n+  :cpu_count => '1',\n+  :memory_size => '512',\n+  :disk_size => '12040',\n+  :disk_format => 'VDI',\n+  :hostiocache => 'off',\n+  :os_type_id => 'Ubuntu_64',\n+  :iso_file => \"ubuntu-14.04.3-server-amd64.iso\",\n+  :iso_src => \"http://releases.ubuntu.com/14.04/ubuntu-14.04.3-server-amd64.iso\",\n+  :iso_md5 => \"9e5fecc94b3925bededed0fdca1bd417\",\n+  :iso_download_timeout => \"1000\",\n+  :boot_wait => \"4\",\n+  :boot_cmd_sequence => [\n+    '<Esc><Esc><Enter>',\n+    '/install/vmlinuz noapic preseed/url=http://%IP%:%PORT%/preseed.cfg ',\n+    'debian-installer=en_US auto locale=en_US kbd-chooser/method=us ',\n+    'hostname=base-ubuntu-14.04 ',\n+    'fb=false debconf/frontend=noninteractive ',\n+    'keyboard-configuration/modelcode=SKIP keyboard-configuration/layout=us keyboard-configuration/variant=us console-setup/ask_detect=false ',\n+    'initrd=/install/initrd.gz -- <Enter>'\n+],\n+  :kickstart_port => \"7122\",\n+  :kickstart_timeout => \"300\",\n+  :kickstart_file => \"preseed.cfg\",\n+  :ssh_login_timeout => \"10000\",\n+  :ssh_user => \"vagrant\",\n+  :ssh_password => \"vagrant\",\n+  :ssh_key => \"\",\n+  :ssh_host_port => \"7222\",\n+  :ssh_guest_port => \"22\",\n+  :sudo_cmd => \"echo '%p'|sudo -S sh '%f'\",\n+  :shutdown_cmd => \"shutdown -P now\",\n+  :postinstall_files => [\n+   \"build_time.sh\",\n+   \"apt.sh\",\n+   \"sudo.sh\",\n+   \"vagrant.sh\",\n+   \"ruby.sh\",\n+   \"chef.sh\",\n+   \"puppet.sh\",\n+   \"root.sh\",\n+   \"cleanup.sh\"\n+  ],\n+  :postinstall_timeout => \"10000\"\n+})","path":"spec/definitions/boxes/definitions/base_ubuntu14.04_kvm/definition.rb","position":45,"original_position":45,"commit_id":"baf7f6202d88cb1f00251d3f53f4c838e84c0dd9","original_commit_id":"baf7f6202d88cb1f00251d3f53f4c838e84c0dd9","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Indent the right brace the same as the first position after the preceding left parenthesis.","created_at":"2015-11-17T10:45:44Z","updated_at":"2015-11-17T10:45:44Z","html_url":"https://github.com/SUSE/machinery/pull/1660#discussion_r45044880","pull_request_url":"https://api.github.com/repos/SUSE/machinery/pulls/1660","_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments/45044880"},"html":{"href":"https://github.com/SUSE/machinery/pull/1660#discussion_r45044880"},"pull_request":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1660"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/machinery/pulls/1660","id":50930486,"html_url":"https://github.com/SUSE/machinery/pull/1660","diff_url":"https://github.com/SUSE/machinery/pull/1660.diff","patch_url":"https://github.com/SUSE/machinery/pull/1660.patch","issue_url":"https://api.github.com/repos/SUSE/machinery/issues/1660","number":1660,"state":"open","locked":false,"title":"[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_151117_add_basic_ubuntu_integration_test'","user":{"login":"aduffeck","id":203813,"avatar_url":"https://avatars.githubusercontent.com/u/203813?v=3","gravatar_id":"","url":"https://api.github.com/users/aduffeck","html_url":"https://github.com/aduffeck","followers_url":"https://api.github.com/users/aduffeck/followers","following_url":"https://api.github.com/users/aduffeck/following{/other_user}","gists_url":"https://api.github.com/users/aduffeck/gists{/gist_id}","starred_url":"https://api.github.com/users/aduffeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduffeck/subscriptions","organizations_url":"https://api.github.com/users/aduffeck/orgs","repos_url":"https://api.github.com/users/aduffeck/repos","events_url":"https://api.github.com/users/aduffeck/events{/privacy}","received_events_url":"https://api.github.com/users/aduffeck/received_events","type":"User","site_admin":false},"body":"Please review the following changes:\n  * baf7f62 Add a basic integration test for ubuntu 14.04\n  * 32fdd40 Add veewee and vagrant definition for an ubuntu 14.04 image\n  * 654e82c Merge pull request #1651 from SUSE/fix_tumbleweed_leap_inheritance\n  * f73e2d7 Add Autoyast and Kiwi export fixes to NEWS file\n  * 855f38f Update build_support matrix for Tumbleweed and Leap\n  * 9deff07 Add Kiwi profiles for Leap and Tumbleweed\n  * b9fafa3 Add Gemfile fixes building veewee images\n  * ad7dabc Let Tumbleweed and Leap inherit from OsSuse instead of just Os\n  * 52bd34a Merge pull request #1646 from SUSE/fix_broken_upgrade_output\n  * 4593182 Prevent additional newline after diff output\n  * 1c36fee The test description didn't have any extracted files\n  * c017e40 Merge pull request #1642 from SUSE/fix_remote_dir_line_break2\n  * d519a5a Don't add indentation for empty lines\n  * 2891638 Adapt integration tests to new remote_dir rendering\n  * 57f93b5 Adapt unmanaged-file renderer output to extraction status\n  * e94d57b Don't filter empty newlines in renderer\n  * b2f972f Merge pull request #1641 from SUSE/handle_empty_scopes2\n  * 14e1ad6 Merge pull request #1640 from SUSE/fix_1638\n  * 1a7c79f Update NEWS file\n  * d1cdd17 Handle empty scopes output in HTML\n  * fe84b1f Handle empty scopes output on CLI\n  * 4e93bc8 Fix typo in warning message","created_at":"2015-11-17T10:45:37Z","updated_at":"2015-11-17T10:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c3541cc0911360692272224c36974e0da1a3076","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/machinery/pulls/1660/commits","review_comments_url":"https://api.github.com/repos/SUSE/machinery/pulls/1660/comments","review_comment_url":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/machinery/issues/1660/comments","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/baf7f6202d88cb1f00251d3f53f4c838e84c0dd9","head":{"label":"SUSE:review_151117_add_basic_ubuntu_integration_test","ref":"review_151117_add_basic_ubuntu_integration_test","sha":"baf7f6202d88cb1f00251d3f53f4c838e84c0dd9","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-11-08T13:59:06Z","pushed_at":"2015-11-17T10:45:37Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":60282,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":57,"forks":14,"open_issues":57,"watchers":74,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"654e82cbd998350d917df94cf2dc7d9fd75a3eb0","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":21424418,"name":"machinery","full_name":"SUSE/machinery","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/machinery","description":"A systems management toolkit for Linux","fork":false,"url":"https://api.github.com/repos/SUSE/machinery","forks_url":"https://api.github.com/repos/SUSE/machinery/forks","keys_url":"https://api.github.com/repos/SUSE/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/machinery/teams","hooks_url":"https://api.github.com/repos/SUSE/machinery/hooks","issue_events_url":"https://api.github.com/repos/SUSE/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/machinery/events","assignees_url":"https://api.github.com/repos/SUSE/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/machinery/tags","blobs_url":"https://api.github.com/repos/SUSE/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/machinery/languages","stargazers_url":"https://api.github.com/repos/SUSE/machinery/stargazers","contributors_url":"https://api.github.com/repos/SUSE/machinery/contributors","subscribers_url":"https://api.github.com/repos/SUSE/machinery/subscribers","subscription_url":"https://api.github.com/repos/SUSE/machinery/subscription","commits_url":"https://api.github.com/repos/SUSE/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/machinery/merges","archive_url":"https://api.github.com/repos/SUSE/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/machinery/downloads","issues_url":"https://api.github.com/repos/SUSE/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/machinery/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/machinery/releases{/id}","created_at":"2014-07-02T13:07:04Z","updated_at":"2015-11-08T13:59:06Z","pushed_at":"2015-11-17T10:45:37Z","git_url":"git://github.com/SUSE/machinery.git","ssh_url":"git@github.com:SUSE/machinery.git","clone_url":"https://github.com/SUSE/machinery.git","svn_url":"https://github.com/SUSE/machinery","homepage":"machinery-project.org","size":60282,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":57,"forks":14,"open_issues":57,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1660"},"html":{"href":"https://github.com/SUSE/machinery/pull/1660"},"issue":{"href":"https://api.github.com/repos/SUSE/machinery/issues/1660"},"comments":{"href":"https://api.github.com/repos/SUSE/machinery/issues/1660/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1660/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/machinery/pulls/1660/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/machinery/statuses/baf7f6202d88cb1f00251d3f53f4c838e84c0dd9"}}}}