{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/28456847","id":28456847,"diff_hunk":"@@ -122,8 +122,18 @@ func getArgsEnv(p *Pod, debug bool) ([]string, []string, error) {\n \n \tcase \"src\":\n \t\targs = append(args, filepath.Join(common.Stage1RootfsPath(p.Root), nspawnBin))\n-\t\targs = append(args, \"--boot\") // Launch systemd in the pod\n-\n+\t\targs = append(args, \"--boot\")              // Launch systemd in the pod\n+\t\targs = append(args, \"--register\", \"false\") // We cannot assume the host system is running systemd\n+\t\tout, err := os.Getwd()\n+\t\tif err != nil {\n+\t\t\treturn nil, nil, err\n+\t\t}\n+\t\tlfd, err := common.GetRktLockFD()\n+\t\tif err != nil {\n+\t\t\treturn nil, nil, err\n+\t\t}\n+\t\targs = append(args, fmt.Sprintf(\"--pid-file=%v\", filepath.Join(out, \"pid\")))\n+\t\targs = append(args, fmt.Sprintf(\"--keep-fd=%v\", lfd))","path":"stage1/init/init.go","position":14,"original_position":17,"commit_id":"8fcfce911f84c5979f2c08231373bbd78004ca50","original_commit_id":"44965df8ca66ca09681f584bf5da4378b0aa4cbf","user":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"body":"Right. Sorry, I overlooked that in my comment.","created_at":"2015-04-15T20:02:05Z","updated_at":"2015-04-15T20:02:05Z","html_url":"https://github.com/coreos/rkt/pull/754#discussion_r28456847","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/754","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/28456847"},"html":{"href":"https://github.com/coreos/rkt/pull/754#discussion_r28456847"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/754","id":33134519,"html_url":"https://github.com/coreos/rkt/pull/754","diff_url":"https://github.com/coreos/rkt/pull/754.diff","patch_url":"https://github.com/coreos/rkt/pull/754.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/754","number":754,"state":"open","locked":false,"title":"Pass arguments for keeping lock and writing PID to systemd built in \"src...","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"body":"This PR passes arguments for keeping lock and writing PID to systemd built in \"src.\" mode. refs coreos/rkt#753\r\n\r\nPlease treat this PR as a bug report, rather as a final fix. I'm happy to adjust code style/overall approach based on your suggestions.","created_at":"2015-04-13T03:59:48Z","updated_at":"2015-04-15T20:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1f9cb4e349c2de81afd5ef089ac50a06ee7afd8","assignee":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/754/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/754/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/754/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/8fcfce911f84c5979f2c08231373bbd78004ca50","head":{"label":"klizhentas:master","ref":"master","sha":"8fcfce911f84c5979f2c08231373bbd78004ca50","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"repo":{"id":33846292,"name":"rkt","full_name":"klizhentas/rkt","owner":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars.githubusercontent.com/u/13717?v=3","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klizhentas/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/klizhentas/rkt","forks_url":"https://api.github.com/repos/klizhentas/rkt/forks","keys_url":"https://api.github.com/repos/klizhentas/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klizhentas/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klizhentas/rkt/teams","hooks_url":"https://api.github.com/repos/klizhentas/rkt/hooks","issue_events_url":"https://api.github.com/repos/klizhentas/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/klizhentas/rkt/events","assignees_url":"https://api.github.com/repos/klizhentas/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/klizhentas/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/klizhentas/rkt/tags","blobs_url":"https://api.github.com/repos/klizhentas/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klizhentas/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klizhentas/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/klizhentas/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klizhentas/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/klizhentas/rkt/languages","stargazers_url":"https://api.github.com/repos/klizhentas/rkt/stargazers","contributors_url":"https://api.github.com/repos/klizhentas/rkt/contributors","subscribers_url":"https://api.github.com/repos/klizhentas/rkt/subscribers","subscription_url":"https://api.github.com/repos/klizhentas/rkt/subscription","commits_url":"https://api.github.com/repos/klizhentas/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/klizhentas/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/klizhentas/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/klizhentas/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/klizhentas/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/klizhentas/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klizhentas/rkt/merges","archive_url":"https://api.github.com/repos/klizhentas/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klizhentas/rkt/downloads","issues_url":"https://api.github.com/repos/klizhentas/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/klizhentas/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/klizhentas/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/klizhentas/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klizhentas/rkt/labels{/name}","releases_url":"https://api.github.com/repos/klizhentas/rkt/releases{/id}","created_at":"2015-04-13T03:41:49Z","updated_at":"2015-04-15T19:15:44Z","pushed_at":"2015-04-15T19:15:44Z","git_url":"git://github.com/klizhentas/rkt.git","ssh_url":"git@github.com:klizhentas/rkt.git","clone_url":"https://github.com/klizhentas/rkt.git","svn_url":"https://github.com/klizhentas/rkt","homepage":"","size":5130,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"7bcbe3f0887a66078f22dd4b1f9f31ee626feab0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"App Container runtime","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-04-15T17:09:03Z","pushed_at":"2015-04-15T19:15:45Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":12369,"stargazers_count":3787,"watchers_count":3787,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":90,"forks":282,"open_issues":90,"watchers":3787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/754"},"html":{"href":"https://github.com/coreos/rkt/pull/754"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/754"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/8fcfce911f84c5979f2c08231373bbd78004ca50"}}}}