{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/47155302","id":47155302,"diff_hunk":"@@ -305,6 +323,11 @@ public Command OnErrorLine(Action<string> handler)\n             return this;\n         }\n \n+        public bool IsUnsafe","path":"src/Microsoft.DotNet.Cli.Utils/Command.cs","position":76,"original_position":76,"commit_id":"7e3487eab281fb93cfb2133f7e0bee76454d9ed0","original_commit_id":"7e3487eab281fb93cfb2133f7e0bee76454d9ed0","user":{"login":"krwq","id":660048,"avatar_url":"https://avatars.githubusercontent.com/u/660048?v=3","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"could you write some comment on what Unsafe means in this context?","created_at":"2015-12-09T21:34:03Z","updated_at":"2015-12-09T21:34:03Z","html_url":"https://github.com/dotnet/cli/pull/457#discussion_r47155302","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/457","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/47155302"},"html":{"href":"https://github.com/dotnet/cli/pull/457#discussion_r47155302"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/457","id":53162072,"html_url":"https://github.com/dotnet/cli/pull/457","diff_url":"https://github.com/dotnet/cli/pull/457.diff","patch_url":"https://github.com/dotnet/cli/pull/457.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/457","number":457,"state":"open","locked":false,"title":"Record safety checks for incremental compilation","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"body":"This is the first PR for issue #382:\r\n\r\n- local for each project, collect the safety checks in #382 \r\n- print the improvement message when compilation completes, per the user experience specified in #232:\r\n\r\n![2](https://cloud.githubusercontent.com/assets/2255729/11674737/8731e284-9dd8-11e5-801f-5958d78e6aeb.png)\r\n\r\nFuture PRs will:\r\n- add the --BuildProfile flag to show the safety checks to the user\r\n- perform the analysis before any compilation begins and not per project as it happens now (we need to do it before so we're able to switch between incremental and non-incremental implementations)","created_at":"2015-12-09T18:56:24Z","updated_at":"2015-12-09T21:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b44426f06a3d53f0cf6d44d6070e65fef0b8d9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/457/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/457/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/457/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/7e3487eab281fb93cfb2133f7e0bee76454d9ed0","head":{"label":"cdmihai:incrementalWarnings","ref":"incrementalWarnings","sha":"7e3487eab281fb93cfb2133f7e0bee76454d9ed0","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"repo":{"id":47228803,"name":"cli","full_name":"cdmihai/cli","owner":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdmihai/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/cdmihai/cli","forks_url":"https://api.github.com/repos/cdmihai/cli/forks","keys_url":"https://api.github.com/repos/cdmihai/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdmihai/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdmihai/cli/teams","hooks_url":"https://api.github.com/repos/cdmihai/cli/hooks","issue_events_url":"https://api.github.com/repos/cdmihai/cli/issues/events{/number}","events_url":"https://api.github.com/repos/cdmihai/cli/events","assignees_url":"https://api.github.com/repos/cdmihai/cli/assignees{/user}","branches_url":"https://api.github.com/repos/cdmihai/cli/branches{/branch}","tags_url":"https://api.github.com/repos/cdmihai/cli/tags","blobs_url":"https://api.github.com/repos/cdmihai/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdmihai/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdmihai/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdmihai/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdmihai/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/cdmihai/cli/languages","stargazers_url":"https://api.github.com/repos/cdmihai/cli/stargazers","contributors_url":"https://api.github.com/repos/cdmihai/cli/contributors","subscribers_url":"https://api.github.com/repos/cdmihai/cli/subscribers","subscription_url":"https://api.github.com/repos/cdmihai/cli/subscription","commits_url":"https://api.github.com/repos/cdmihai/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdmihai/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdmihai/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdmihai/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdmihai/cli/contents/{+path}","compare_url":"https://api.github.com/repos/cdmihai/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdmihai/cli/merges","archive_url":"https://api.github.com/repos/cdmihai/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdmihai/cli/downloads","issues_url":"https://api.github.com/repos/cdmihai/cli/issues{/number}","pulls_url":"https://api.github.com/repos/cdmihai/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/cdmihai/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/cdmihai/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdmihai/cli/labels{/name}","releases_url":"https://api.github.com/repos/cdmihai/cli/releases{/id}","created_at":"2015-12-02T01:30:50Z","updated_at":"2015-12-02T01:30:56Z","pushed_at":"2015-12-09T19:26:48Z","git_url":"git://github.com/cdmihai/cli.git","ssh_url":"git@github.com:cdmihai/cli.git","clone_url":"https://github.com/cdmihai/cli.git","svn_url":"https://github.com/cdmihai/cli","homepage":"http://dotnet.github.io/","size":13978,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d09137f8d5d18ce4c017c2a915a693b0654ffb70","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","created_at":"2015-10-02T18:03:15Z","updated_at":"2015-12-09T13:52:04Z","pushed_at":"2015-12-09T20:34:12Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"http://dotnet.github.io/","size":14362,"stargazers_count":137,"watchers_count":137,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":187,"forks":34,"open_issues":187,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/457"},"html":{"href":"https://github.com/dotnet/cli/pull/457"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/457"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/7e3487eab281fb93cfb2133f7e0bee76454d9ed0"}}}}