{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/24779600","id":24779600,"diff_hunk":"@@ -29,19 +29,13 @@ class FolderController extends Controller\n      * @throws NotFoundHttpException $location is flagged as invisible\n      * @return \\Symfony\\Component\\HttpFoundation\\Response\n      */\n-    public function showFolderListAsideViewAction( Location $location )\n+    public function showFolderListAsideViewAction( Location $location, $viewType, $layout = false, array $params = array() )\n     {\n-        $response = new Response();\n-\n         if ( $location->invisible )\n         {\n             throw new NotFoundHttpException( \"Location #$location->id cannot be displayed as it is flagged as invisible.\" );\n         }\n \n-        $response->setSharedMaxAge( $this->getConfigResolver()->getParameter( 'content.default_ttl' ) );","path":"Controller/FolderController.php","position":null,"original_position":14,"commit_id":"8b197c2015828335a791339ef7952558323ef094","original_commit_id":"eee6f3170491fafbc85098b9c0a1d4a6d9040195","user":{"login":"wizhippo","id":1456102,"avatar_url":"https://avatars.githubusercontent.com/u/1456102?v=3","gravatar_id":"","url":"https://api.github.com/users/wizhippo","html_url":"https://github.com/wizhippo","followers_url":"https://api.github.com/users/wizhippo/followers","following_url":"https://api.github.com/users/wizhippo/following{/other_user}","gists_url":"https://api.github.com/users/wizhippo/gists{/gist_id}","starred_url":"https://api.github.com/users/wizhippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizhippo/subscriptions","organizations_url":"https://api.github.com/users/wizhippo/orgs","repos_url":"https://api.github.com/users/wizhippo/repos","events_url":"https://api.github.com/users/wizhippo/events{/privacy}","received_events_url":"https://api.github.com/users/wizhippo/received_events","type":"User","site_admin":false},"body":"@crevillo Your are right.  I have removed this too.","created_at":"2015-02-16T22:17:24Z","updated_at":"2015-02-16T22:17:24Z","html_url":"https://github.com/ezsystems/DemoBundle/pull/140#discussion_r24779600","pull_request_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/24779600"},"html":{"href":"https://github.com/ezsystems/DemoBundle/pull/140#discussion_r24779600"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140","id":29288264,"html_url":"https://github.com/ezsystems/DemoBundle/pull/140","diff_url":"https://github.com/ezsystems/DemoBundle/pull/140.diff","patch_url":"https://github.com/ezsystems/DemoBundle/pull/140.patch","issue_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/140","number":140,"state":"open","locked":false,"title":"Fix unused response in FolderController","user":{"login":"wizhippo","id":1456102,"avatar_url":"https://avatars.githubusercontent.com/u/1456102?v=3","gravatar_id":"","url":"https://api.github.com/users/wizhippo","html_url":"https://github.com/wizhippo","followers_url":"https://api.github.com/users/wizhippo/followers","following_url":"https://api.github.com/users/wizhippo/following{/other_user}","gists_url":"https://api.github.com/users/wizhippo/gists{/gist_id}","starred_url":"https://api.github.com/users/wizhippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizhippo/subscriptions","organizations_url":"https://api.github.com/users/wizhippo/orgs","repos_url":"https://api.github.com/users/wizhippo/repos","events_url":"https://api.github.com/users/wizhippo/events{/privacy}","received_events_url":"https://api.github.com/users/wizhippo/received_events","type":"User","site_admin":false},"body":"The response from viewLocation should be used as the the response created is not used.  This also adds support for different view types.","created_at":"2015-02-13T18:42:15Z","updated_at":"2015-02-16T22:17:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c0c611d07eca5b384710b627ae9c667583242c5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140/commits","review_comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140/comments","review_comment_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/140/comments","statuses_url":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/8b197c2015828335a791339ef7952558323ef094","head":{"label":"wizhippo:fix-folder-response","ref":"fix-folder-response","sha":"8b197c2015828335a791339ef7952558323ef094","user":{"login":"wizhippo","id":1456102,"avatar_url":"https://avatars.githubusercontent.com/u/1456102?v=3","gravatar_id":"","url":"https://api.github.com/users/wizhippo","html_url":"https://github.com/wizhippo","followers_url":"https://api.github.com/users/wizhippo/followers","following_url":"https://api.github.com/users/wizhippo/following{/other_user}","gists_url":"https://api.github.com/users/wizhippo/gists{/gist_id}","starred_url":"https://api.github.com/users/wizhippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizhippo/subscriptions","organizations_url":"https://api.github.com/users/wizhippo/orgs","repos_url":"https://api.github.com/users/wizhippo/repos","events_url":"https://api.github.com/users/wizhippo/events{/privacy}","received_events_url":"https://api.github.com/users/wizhippo/received_events","type":"User","site_admin":false},"repo":{"id":23329337,"name":"DemoBundle","full_name":"wizhippo/DemoBundle","owner":{"login":"wizhippo","id":1456102,"avatar_url":"https://avatars.githubusercontent.com/u/1456102?v=3","gravatar_id":"","url":"https://api.github.com/users/wizhippo","html_url":"https://github.com/wizhippo","followers_url":"https://api.github.com/users/wizhippo/followers","following_url":"https://api.github.com/users/wizhippo/following{/other_user}","gists_url":"https://api.github.com/users/wizhippo/gists{/gist_id}","starred_url":"https://api.github.com/users/wizhippo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wizhippo/subscriptions","organizations_url":"https://api.github.com/users/wizhippo/orgs","repos_url":"https://api.github.com/users/wizhippo/repos","events_url":"https://api.github.com/users/wizhippo/events{/privacy}","received_events_url":"https://api.github.com/users/wizhippo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wizhippo/DemoBundle","description":"DemoBundle represent a front end web site on eZ Publish 5, work in progress","fork":true,"url":"https://api.github.com/repos/wizhippo/DemoBundle","forks_url":"https://api.github.com/repos/wizhippo/DemoBundle/forks","keys_url":"https://api.github.com/repos/wizhippo/DemoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wizhippo/DemoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wizhippo/DemoBundle/teams","hooks_url":"https://api.github.com/repos/wizhippo/DemoBundle/hooks","issue_events_url":"https://api.github.com/repos/wizhippo/DemoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/wizhippo/DemoBundle/events","assignees_url":"https://api.github.com/repos/wizhippo/DemoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/wizhippo/DemoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/wizhippo/DemoBundle/tags","blobs_url":"https://api.github.com/repos/wizhippo/DemoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wizhippo/DemoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wizhippo/DemoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/wizhippo/DemoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wizhippo/DemoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/wizhippo/DemoBundle/languages","stargazers_url":"https://api.github.com/repos/wizhippo/DemoBundle/stargazers","contributors_url":"https://api.github.com/repos/wizhippo/DemoBundle/contributors","subscribers_url":"https://api.github.com/repos/wizhippo/DemoBundle/subscribers","subscription_url":"https://api.github.com/repos/wizhippo/DemoBundle/subscription","commits_url":"https://api.github.com/repos/wizhippo/DemoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/wizhippo/DemoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/wizhippo/DemoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/wizhippo/DemoBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/wizhippo/DemoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/wizhippo/DemoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wizhippo/DemoBundle/merges","archive_url":"https://api.github.com/repos/wizhippo/DemoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wizhippo/DemoBundle/downloads","issues_url":"https://api.github.com/repos/wizhippo/DemoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/wizhippo/DemoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/wizhippo/DemoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/wizhippo/DemoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wizhippo/DemoBundle/labels{/name}","releases_url":"https://api.github.com/repos/wizhippo/DemoBundle/releases{/id}","created_at":"2014-08-25T21:28:06Z","updated_at":"2015-02-12T19:59:13Z","pushed_at":"2015-02-16T22:16:56Z","git_url":"git://github.com/wizhippo/DemoBundle.git","ssh_url":"git@github.com:wizhippo/DemoBundle.git","clone_url":"https://github.com/wizhippo/DemoBundle.git","svn_url":"https://github.com/wizhippo/DemoBundle","homepage":null,"size":6122,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"f8ab0afd7bbe55b52f6075c780d6f82e926e2f93","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":8177076,"name":"DemoBundle","full_name":"ezsystems/DemoBundle","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/DemoBundle","description":"DemoBundle represent a front end web site on eZ Publish 5, work in progress","fork":false,"url":"https://api.github.com/repos/ezsystems/DemoBundle","forks_url":"https://api.github.com/repos/ezsystems/DemoBundle/forks","keys_url":"https://api.github.com/repos/ezsystems/DemoBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/DemoBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/DemoBundle/teams","hooks_url":"https://api.github.com/repos/ezsystems/DemoBundle/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/DemoBundle/events","assignees_url":"https://api.github.com/repos/ezsystems/DemoBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/DemoBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/DemoBundle/tags","blobs_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/DemoBundle/languages","stargazers_url":"https://api.github.com/repos/ezsystems/DemoBundle/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/DemoBundle/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/DemoBundle/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/DemoBundle/subscription","commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/DemoBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/DemoBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/DemoBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/DemoBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/DemoBundle/merges","archive_url":"https://api.github.com/repos/ezsystems/DemoBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/DemoBundle/downloads","issues_url":"https://api.github.com/repos/ezsystems/DemoBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/DemoBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/DemoBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/DemoBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/DemoBundle/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/DemoBundle/releases{/id}","created_at":"2013-02-13T10:19:36Z","updated_at":"2015-02-16T15:19:40Z","pushed_at":"2015-02-13T16:42:29Z","git_url":"git://github.com/ezsystems/DemoBundle.git","ssh_url":"git@github.com:ezsystems/DemoBundle.git","clone_url":"https://github.com/ezsystems/DemoBundle.git","svn_url":"https://github.com/ezsystems/DemoBundle","homepage":null,"size":8330,"stargazers_count":5,"watchers_count":5,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140"},"html":{"href":"https://github.com/ezsystems/DemoBundle/pull/140"},"issue":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/issues/140"},"comments":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/DemoBundle/statuses/8b197c2015828335a791339ef7952558323ef094"}}}}