{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/15001","labels_url":"https://api.github.com/repos/docker/docker/issues/15001/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/15001/comments","events_url":"https://api.github.com/repos/docker/docker/issues/15001/events","html_url":"https://github.com/docker/docker/pull/15001","id":97279668,"number":15001,"title":"Adding support for elementary OS distro in install script.","user":{"login":"fmoliveira","id":3985462,"avatar_url":"https://avatars.githubusercontent.com/u/3985462?v=3","gravatar_id":"","url":"https://api.github.com/users/fmoliveira","html_url":"https://github.com/fmoliveira","followers_url":"https://api.github.com/users/fmoliveira/followers","following_url":"https://api.github.com/users/fmoliveira/following{/other_user}","gists_url":"https://api.github.com/users/fmoliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/fmoliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmoliveira/subscriptions","organizations_url":"https://api.github.com/users/fmoliveira/orgs","repos_url":"https://api.github.com/users/fmoliveira/repos","events_url":"https://api.github.com/users/fmoliveira/events{/privacy}","received_events_url":"https://api.github.com/users/fmoliveira/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/39","html_url":"https://github.com/docker/docker/milestones/1.8.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/39/labels","id":1151952,"number":39,"title":"1.8.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":132,"state":"open","created_at":"2015-06-05T19:27:06Z","updated_at":"2015-08-06T17:16:54Z","due_on":"2015-08-09T22:00:00Z","closed_at":null},"comments":56,"created_at":"2015-07-26T03:10:31Z","updated_at":"2015-08-06T18:17:13Z","closed_at":"2015-08-05T23:14:47Z","pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/15001","html_url":"https://github.com/docker/docker/pull/15001","diff_url":"https://github.com/docker/docker/pull/15001.diff","patch_url":"https://github.com/docker/docker/pull/15001.patch"},"body":"Adding support for elementary OS in the installer script.\r\n\r\nThe script will query the upstream release from the command `$ lsb_release -a -u`, so, it's now very easy to add support for more forked distros.\r\n\r\n~~I don't know what are the side effects of checking the upstream release for all distros. For that reason, I've restricted this check to elementary OS, which I've been able to test.~~\r\n\r\nI've tested this in elementary OS 0.3 (freya) and it's working just fine.\r\n\r\nCredits to Daniel Foré and Cody Garver from elementary OS for [helping me out to achieve this](http://elementaryos.stackexchange.com/a/769).\r\n\r\n**TL;DR:**\r\nWe've tested the command in some distros (based and non-based in Debian/Ubuntu) and have achieved a solution that should work across all distros. It'll check for the existince and success of the command `lsb_release -a -u` to then retrieve the upstream release info."},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/128464008","html_url":"https://github.com/docker/docker/pull/15001#issuecomment-128464008","issue_url":"https://api.github.com/repos/docker/docker/issues/15001","id":128464008,"user":{"login":"fmoliveira","id":3985462,"avatar_url":"https://avatars.githubusercontent.com/u/3985462?v=3","gravatar_id":"","url":"https://api.github.com/users/fmoliveira","html_url":"https://github.com/fmoliveira","followers_url":"https://api.github.com/users/fmoliveira/followers","following_url":"https://api.github.com/users/fmoliveira/following{/other_user}","gists_url":"https://api.github.com/users/fmoliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/fmoliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmoliveira/subscriptions","organizations_url":"https://api.github.com/users/fmoliveira/orgs","repos_url":"https://api.github.com/users/fmoliveira/repos","events_url":"https://api.github.com/users/fmoliveira/events{/privacy}","received_events_url":"https://api.github.com/users/fmoliveira/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T18:17:13Z","updated_at":"2015-08-06T18:17:13Z","body":"@gospo I see. It's a pity the LSB check won't work for Cumulus. I suggest you to open a new issue to discuss with more people about ideas to solve this. There are some stuff I'd ask to try to help but this isn't the ideal place."}}