{"action":"opened","number":12250,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250","id":37208935,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/12250","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/12250.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/12250.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12250","number":12250,"state":"open","locked":false,"title":"Fails if file does not exist","user":{"login":"hawkwood","id":672455,"avatar_url":"https://avatars.githubusercontent.com/u/672455?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkwood","html_url":"https://github.com/hawkwood","followers_url":"https://api.github.com/users/hawkwood/followers","following_url":"https://api.github.com/users/hawkwood/following{/other_user}","gists_url":"https://api.github.com/users/hawkwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkwood/subscriptions","organizations_url":"https://api.github.com/users/hawkwood/orgs","repos_url":"https://api.github.com/users/hawkwood/repos","events_url":"https://api.github.com/users/hawkwood/events{/privacy}","received_events_url":"https://api.github.com/users/hawkwood/received_events","type":"User","site_admin":false},"body":"This adds a callback with nullptr if the file does not exists.  Checking this before checking cache means that if a file is cached then deleted, the async call will fail.  To allow a cached but deleted file to return the texture, move the isFileExist check to ALTERNATIVE.\r\n\r\nIf leaving check where it is, on failure should it also check if the file was cached and remove it?","created_at":"2015-06-09T00:14:24Z","updated_at":"2015-06-09T00:14:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12250/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/eca488b85a9b90393e582d0192eafb013a2cc8ae","head":{"label":"hawkwood:patch-10","ref":"patch-10","sha":"eca488b85a9b90393e582d0192eafb013a2cc8ae","user":{"login":"hawkwood","id":672455,"avatar_url":"https://avatars.githubusercontent.com/u/672455?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkwood","html_url":"https://github.com/hawkwood","followers_url":"https://api.github.com/users/hawkwood/followers","following_url":"https://api.github.com/users/hawkwood/following{/other_user}","gists_url":"https://api.github.com/users/hawkwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkwood/subscriptions","organizations_url":"https://api.github.com/users/hawkwood/orgs","repos_url":"https://api.github.com/users/hawkwood/repos","events_url":"https://api.github.com/users/hawkwood/events{/privacy}","received_events_url":"https://api.github.com/users/hawkwood/received_events","type":"User","site_admin":false},"repo":{"id":13234366,"name":"cocos2d-x","full_name":"hawkwood/cocos2d-x","owner":{"login":"hawkwood","id":672455,"avatar_url":"https://avatars.githubusercontent.com/u/672455?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkwood","html_url":"https://github.com/hawkwood","followers_url":"https://api.github.com/users/hawkwood/followers","following_url":"https://api.github.com/users/hawkwood/following{/other_user}","gists_url":"https://api.github.com/users/hawkwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkwood/subscriptions","organizations_url":"https://api.github.com/users/hawkwood/orgs","repos_url":"https://api.github.com/users/hawkwood/repos","events_url":"https://api.github.com/users/hawkwood/events{/privacy}","received_events_url":"https://api.github.com/users/hawkwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hawkwood/cocos2d-x","description":"cocos2d for iOS, Android, Win32 and OS X. Built using C++","fork":true,"url":"https://api.github.com/repos/hawkwood/cocos2d-x","forks_url":"https://api.github.com/repos/hawkwood/cocos2d-x/forks","keys_url":"https://api.github.com/repos/hawkwood/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkwood/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkwood/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/hawkwood/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/hawkwood/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/hawkwood/cocos2d-x/events","assignees_url":"https://api.github.com/repos/hawkwood/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/hawkwood/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/hawkwood/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/hawkwood/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkwood/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkwood/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkwood/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkwood/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkwood/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/hawkwood/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/hawkwood/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/hawkwood/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/hawkwood/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/hawkwood/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkwood/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkwood/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkwood/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkwood/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/hawkwood/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkwood/cocos2d-x/merges","archive_url":"https://api.github.com/repos/hawkwood/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkwood/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/hawkwood/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/hawkwood/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkwood/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkwood/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkwood/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/hawkwood/cocos2d-x/releases{/id}","created_at":"2013-10-01T04:04:07Z","updated_at":"2014-08-20T19:21:36Z","pushed_at":"2015-06-09T00:14:15Z","git_url":"git://github.com/hawkwood/cocos2d-x.git","ssh_url":"git@github.com:hawkwood/cocos2d-x.git","clone_url":"https://github.com/hawkwood/cocos2d-x.git","svn_url":"https://github.com/hawkwood/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":774383,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"a364d6ecfcefec29076546968d7da3d9ff4a4052","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","created_at":"2010-11-18T23:17:00Z","updated_at":"2015-06-08T15:50:20Z","pushed_at":"2015-06-08T16:26:07Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1488240,"stargazers_count":6011,"watchers_count":6011,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4345,"mirror_url":null,"open_issues_count":720,"forks":4345,"open_issues":720,"watchers":6011,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/12250"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12250"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/12250/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/12250/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/eca488b85a9b90393e582d0192eafb013a2cc8ae"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":0,"changed_files":1}}