{"action":"created","comment":{"url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/comments/25577574","id":25577574,"diff_hunk":"@@ -32,10 +30,12 @@\n import org.hbase.async.HBaseException;\n import org.hbase.async.KeyValue;\n import org.hbase.async.PutRequest;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n \n-import net.opentsdb.uid.UniqueId;\n-import net.opentsdb.stats.Histogram;\n-import net.opentsdb.stats.StatsCollector;\n+import com.stumbleupon.async.Callback;","path":"src/core/TSDB.java","position":28,"original_position":28,"commit_id":"a5f78e245174b7f09f311525b4e5740e9db21981","original_commit_id":"a5f78e245174b7f09f311525b4e5740e9db21981","user":{"login":"manolama","id":1377700,"avatar_url":"https://avatars.githubusercontent.com/u/1377700?v=3","gravatar_id":"","url":"https://api.github.com/users/manolama","html_url":"https://github.com/manolama","followers_url":"https://api.github.com/users/manolama/followers","following_url":"https://api.github.com/users/manolama/following{/other_user}","gists_url":"https://api.github.com/users/manolama/gists{/gist_id}","starred_url":"https://api.github.com/users/manolama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolama/subscriptions","organizations_url":"https://api.github.com/users/manolama/orgs","repos_url":"https://api.github.com/users/manolama/repos","events_url":"https://api.github.com/users/manolama/events{/privacy}","received_events_url":"https://api.github.com/users/manolama/received_events","type":"User","site_admin":false},"body":"Avoid re-arranging imports if possible. Just clutters PRs.","created_at":"2015-03-02T04:06:41Z","updated_at":"2015-03-02T04:06:41Z","html_url":"https://github.com/OpenTSDB/opentsdb/pull/265#discussion_r25577574","pull_request_url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/comments/25577574"},"html":{"href":"https://github.com/OpenTSDB/opentsdb/pull/265#discussion_r25577574"},"pull_request":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265","id":11060607,"html_url":"https://github.com/OpenTSDB/opentsdb/pull/265","diff_url":"https://github.com/OpenTSDB/opentsdb/pull/265.diff","patch_url":"https://github.com/OpenTSDB/opentsdb/pull/265.patch","issue_url":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/265","number":265,"state":"open","locked":false,"title":"Atomic increment/add","user":{"login":"jakeri","id":76497,"avatar_url":"https://avatars.githubusercontent.com/u/76497?v=3","gravatar_id":"","url":"https://api.github.com/users/jakeri","html_url":"https://github.com/jakeri","followers_url":"https://api.github.com/users/jakeri/followers","following_url":"https://api.github.com/users/jakeri/following{/other_user}","gists_url":"https://api.github.com/users/jakeri/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeri/subscriptions","organizations_url":"https://api.github.com/users/jakeri/orgs","repos_url":"https://api.github.com/users/jakeri/repos","events_url":"https://api.github.com/users/jakeri/events{/privacy}","received_events_url":"https://api.github.com/users/jakeri/received_events","type":"User","site_admin":false},"body":"This is a new pull request for @KevinOrtman atomic increment feature (https://github.com/tsuna/opentsdb/pull/2) that was made against 1.X code base and never added master.\r\n\r\nBasically the same code, except minor changes for 2.0 code base and using add-keyword instead of inc. There was some discussion about this in above mentioned pull request.\r\n\r\nAnother thing done is that I have disabled scheduleForCompaction(...) within the increment. Does this mean that a row created by add will never be compacted?\r\nI would guess that compaction and atomic increment for already compacted values is not good fit.\r\n\r\nWould like to see a discussion if this could be incorporated into the project.","created_at":"2013-12-23T20:15:51Z","updated_at":"2015-03-02T04:06:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"923df580fa2bce57f5c2fd76845b406425b1a05e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265/commits","review_comments_url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265/comments","review_comment_url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/265/comments","statuses_url":"https://api.github.com/repos/OpenTSDB/opentsdb/statuses/a5f78e245174b7f09f311525b4e5740e9db21981","head":{"label":"jakeri:master","ref":"master","sha":"a5f78e245174b7f09f311525b4e5740e9db21981","user":{"login":"jakeri","id":76497,"avatar_url":"https://avatars.githubusercontent.com/u/76497?v=3","gravatar_id":"","url":"https://api.github.com/users/jakeri","html_url":"https://github.com/jakeri","followers_url":"https://api.github.com/users/jakeri/followers","following_url":"https://api.github.com/users/jakeri/following{/other_user}","gists_url":"https://api.github.com/users/jakeri/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeri/subscriptions","organizations_url":"https://api.github.com/users/jakeri/orgs","repos_url":"https://api.github.com/users/jakeri/repos","events_url":"https://api.github.com/users/jakeri/events{/privacy}","received_events_url":"https://api.github.com/users/jakeri/received_events","type":"User","site_admin":false},"repo":{"id":15398348,"name":"opentsdb","full_name":"jakeri/opentsdb","owner":{"login":"jakeri","id":76497,"avatar_url":"https://avatars.githubusercontent.com/u/76497?v=3","gravatar_id":"","url":"https://api.github.com/users/jakeri","html_url":"https://github.com/jakeri","followers_url":"https://api.github.com/users/jakeri/followers","following_url":"https://api.github.com/users/jakeri/following{/other_user}","gists_url":"https://api.github.com/users/jakeri/gists{/gist_id}","starred_url":"https://api.github.com/users/jakeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakeri/subscriptions","organizations_url":"https://api.github.com/users/jakeri/orgs","repos_url":"https://api.github.com/users/jakeri/repos","events_url":"https://api.github.com/users/jakeri/events{/privacy}","received_events_url":"https://api.github.com/users/jakeri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakeri/opentsdb","description":"A scalable, distributed Time Series Database.","fork":true,"url":"https://api.github.com/repos/jakeri/opentsdb","forks_url":"https://api.github.com/repos/jakeri/opentsdb/forks","keys_url":"https://api.github.com/repos/jakeri/opentsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakeri/opentsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakeri/opentsdb/teams","hooks_url":"https://api.github.com/repos/jakeri/opentsdb/hooks","issue_events_url":"https://api.github.com/repos/jakeri/opentsdb/issues/events{/number}","events_url":"https://api.github.com/repos/jakeri/opentsdb/events","assignees_url":"https://api.github.com/repos/jakeri/opentsdb/assignees{/user}","branches_url":"https://api.github.com/repos/jakeri/opentsdb/branches{/branch}","tags_url":"https://api.github.com/repos/jakeri/opentsdb/tags","blobs_url":"https://api.github.com/repos/jakeri/opentsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakeri/opentsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakeri/opentsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakeri/opentsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakeri/opentsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/jakeri/opentsdb/languages","stargazers_url":"https://api.github.com/repos/jakeri/opentsdb/stargazers","contributors_url":"https://api.github.com/repos/jakeri/opentsdb/contributors","subscribers_url":"https://api.github.com/repos/jakeri/opentsdb/subscribers","subscription_url":"https://api.github.com/repos/jakeri/opentsdb/subscription","commits_url":"https://api.github.com/repos/jakeri/opentsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakeri/opentsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakeri/opentsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakeri/opentsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakeri/opentsdb/contents/{+path}","compare_url":"https://api.github.com/repos/jakeri/opentsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakeri/opentsdb/merges","archive_url":"https://api.github.com/repos/jakeri/opentsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakeri/opentsdb/downloads","issues_url":"https://api.github.com/repos/jakeri/opentsdb/issues{/number}","pulls_url":"https://api.github.com/repos/jakeri/opentsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/jakeri/opentsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/jakeri/opentsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakeri/opentsdb/labels{/name}","releases_url":"https://api.github.com/repos/jakeri/opentsdb/releases{/id}","created_at":"2013-12-23T15:29:20Z","updated_at":"2013-12-23T20:15:52Z","pushed_at":"2013-12-23T19:44:07Z","git_url":"git://github.com/jakeri/opentsdb.git","ssh_url":"git@github.com:jakeri/opentsdb.git","clone_url":"https://github.com/jakeri/opentsdb.git","svn_url":"https://github.com/jakeri/opentsdb","homepage":"http://opentsdb.net","size":26654,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenTSDB:master","ref":"master","sha":"6f1d105a3f322da28552e45fa5f84d0698c68649","user":{"login":"OpenTSDB","id":2086220,"avatar_url":"https://avatars.githubusercontent.com/u/2086220?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenTSDB","html_url":"https://github.com/OpenTSDB","followers_url":"https://api.github.com/users/OpenTSDB/followers","following_url":"https://api.github.com/users/OpenTSDB/following{/other_user}","gists_url":"https://api.github.com/users/OpenTSDB/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTSDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTSDB/subscriptions","organizations_url":"https://api.github.com/users/OpenTSDB/orgs","repos_url":"https://api.github.com/users/OpenTSDB/repos","events_url":"https://api.github.com/users/OpenTSDB/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTSDB/received_events","type":"Organization","site_admin":false},"repo":{"id":865412,"name":"opentsdb","full_name":"OpenTSDB/opentsdb","owner":{"login":"OpenTSDB","id":2086220,"avatar_url":"https://avatars.githubusercontent.com/u/2086220?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenTSDB","html_url":"https://github.com/OpenTSDB","followers_url":"https://api.github.com/users/OpenTSDB/followers","following_url":"https://api.github.com/users/OpenTSDB/following{/other_user}","gists_url":"https://api.github.com/users/OpenTSDB/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenTSDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenTSDB/subscriptions","organizations_url":"https://api.github.com/users/OpenTSDB/orgs","repos_url":"https://api.github.com/users/OpenTSDB/repos","events_url":"https://api.github.com/users/OpenTSDB/events{/privacy}","received_events_url":"https://api.github.com/users/OpenTSDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenTSDB/opentsdb","description":"A scalable, distributed Time Series Database.","fork":false,"url":"https://api.github.com/repos/OpenTSDB/opentsdb","forks_url":"https://api.github.com/repos/OpenTSDB/opentsdb/forks","keys_url":"https://api.github.com/repos/OpenTSDB/opentsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenTSDB/opentsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenTSDB/opentsdb/teams","hooks_url":"https://api.github.com/repos/OpenTSDB/opentsdb/hooks","issue_events_url":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/events{/number}","events_url":"https://api.github.com/repos/OpenTSDB/opentsdb/events","assignees_url":"https://api.github.com/repos/OpenTSDB/opentsdb/assignees{/user}","branches_url":"https://api.github.com/repos/OpenTSDB/opentsdb/branches{/branch}","tags_url":"https://api.github.com/repos/OpenTSDB/opentsdb/tags","blobs_url":"https://api.github.com/repos/OpenTSDB/opentsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenTSDB/opentsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenTSDB/opentsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenTSDB/opentsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenTSDB/opentsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenTSDB/opentsdb/languages","stargazers_url":"https://api.github.com/repos/OpenTSDB/opentsdb/stargazers","contributors_url":"https://api.github.com/repos/OpenTSDB/opentsdb/contributors","subscribers_url":"https://api.github.com/repos/OpenTSDB/opentsdb/subscribers","subscription_url":"https://api.github.com/repos/OpenTSDB/opentsdb/subscription","commits_url":"https://api.github.com/repos/OpenTSDB/opentsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenTSDB/opentsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenTSDB/opentsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenTSDB/opentsdb/contents/{+path}","compare_url":"https://api.github.com/repos/OpenTSDB/opentsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenTSDB/opentsdb/merges","archive_url":"https://api.github.com/repos/OpenTSDB/opentsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenTSDB/opentsdb/downloads","issues_url":"https://api.github.com/repos/OpenTSDB/opentsdb/issues{/number}","pulls_url":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenTSDB/opentsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenTSDB/opentsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenTSDB/opentsdb/labels{/name}","releases_url":"https://api.github.com/repos/OpenTSDB/opentsdb/releases{/id}","created_at":"2010-08-27T02:05:20Z","updated_at":"2015-03-01T00:18:34Z","pushed_at":"2015-03-02T03:56:48Z","git_url":"git://github.com/OpenTSDB/opentsdb.git","ssh_url":"git@github.com:OpenTSDB/opentsdb.git","clone_url":"https://github.com/OpenTSDB/opentsdb.git","svn_url":"https://github.com/OpenTSDB/opentsdb","homepage":"http://opentsdb.net","size":33393,"stargazers_count":1153,"watchers_count":1153,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":429,"mirror_url":null,"open_issues_count":146,"forks":429,"open_issues":146,"watchers":1153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265"},"html":{"href":"https://github.com/OpenTSDB/opentsdb/pull/265"},"issue":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/265"},"comments":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/OpenTSDB/opentsdb/statuses/a5f78e245174b7f09f311525b4e5740e9db21981"}}}}