{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/34958042","id":34958042,"diff_hunk":"@@ -93,6 +93,23 @@ mod bar {\n ```\n \"##,\n \n+E0253: r##\"\n+Attempt was made to import an unimportable value. This can happen when\n+trying to import a method from a trait. An example of this error:\n+\n+```\n+mod foo {\n+    pub trait MyTrait {\n+        fn do_something();\n+    }\n+}\n+use foo::MyTrait::do_something;\n+```\n+\n+In general, it's not legal to directly import methods belonging to a","path":"src/librustc_resolve/diagnostics.rs","position":17,"original_position":17,"commit_id":"4ea02b72b77a7d077e6a249564314c39a597ded0","original_commit_id":"4ea02b72b77a7d077e6a249564314c39a597ded0","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"why \"in general\"? is there an exception? this feels like the diagnostic is not sure why it's firing. Let's not ship slightly ambiguous language like this","created_at":"2015-07-19T13:05:50Z","updated_at":"2015-07-19T13:05:50Z","html_url":"https://github.com/rust-lang/rust/pull/27111#discussion_r34958042","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/27111","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/34958042"},"html":{"href":"https://github.com/rust-lang/rust/pull/27111#discussion_r34958042"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27111"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27111","id":40294462,"html_url":"https://github.com/rust-lang/rust/pull/27111","diff_url":"https://github.com/rust-lang/rust/pull/27111.diff","patch_url":"https://github.com/rust-lang/rust/pull/27111.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27111","number":27111,"state":"open","locked":false,"title":"Add diagnostics for E0253","user":{"login":"AlisdairO","id":6296622,"avatar_url":"https://avatars.githubusercontent.com/u/6296622?v=3","gravatar_id":"","url":"https://api.github.com/users/AlisdairO","html_url":"https://github.com/AlisdairO","followers_url":"https://api.github.com/users/AlisdairO/followers","following_url":"https://api.github.com/users/AlisdairO/following{/other_user}","gists_url":"https://api.github.com/users/AlisdairO/gists{/gist_id}","starred_url":"https://api.github.com/users/AlisdairO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlisdairO/subscriptions","organizations_url":"https://api.github.com/users/AlisdairO/orgs","repos_url":"https://api.github.com/users/AlisdairO/repos","events_url":"https://api.github.com/users/AlisdairO/events{/privacy}","received_events_url":"https://api.github.com/users/AlisdairO/received_events","type":"User","site_admin":false},"body":"As per topic :-).\r\n\r\nPart of #24407.\r\nr? @Manishearth ","created_at":"2015-07-18T16:26:43Z","updated_at":"2015-07-19T13:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f5f18e3233ff472514dc1a444c62fd1e0bd0ca7","assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27111/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27111/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27111/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/4ea02b72b77a7d077e6a249564314c39a597ded0","head":{"label":"AlisdairO:diagnostics253","ref":"diagnostics253","sha":"4ea02b72b77a7d077e6a249564314c39a597ded0","user":{"login":"AlisdairO","id":6296622,"avatar_url":"https://avatars.githubusercontent.com/u/6296622?v=3","gravatar_id":"","url":"https://api.github.com/users/AlisdairO","html_url":"https://github.com/AlisdairO","followers_url":"https://api.github.com/users/AlisdairO/followers","following_url":"https://api.github.com/users/AlisdairO/following{/other_user}","gists_url":"https://api.github.com/users/AlisdairO/gists{/gist_id}","starred_url":"https://api.github.com/users/AlisdairO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlisdairO/subscriptions","organizations_url":"https://api.github.com/users/AlisdairO/orgs","repos_url":"https://api.github.com/users/AlisdairO/repos","events_url":"https://api.github.com/users/AlisdairO/events{/privacy}","received_events_url":"https://api.github.com/users/AlisdairO/received_events","type":"User","site_admin":false},"repo":{"id":23756103,"name":"rust","full_name":"AlisdairO/rust","owner":{"login":"AlisdairO","id":6296622,"avatar_url":"https://avatars.githubusercontent.com/u/6296622?v=3","gravatar_id":"","url":"https://api.github.com/users/AlisdairO","html_url":"https://github.com/AlisdairO","followers_url":"https://api.github.com/users/AlisdairO/followers","following_url":"https://api.github.com/users/AlisdairO/following{/other_user}","gists_url":"https://api.github.com/users/AlisdairO/gists{/gist_id}","starred_url":"https://api.github.com/users/AlisdairO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlisdairO/subscriptions","organizations_url":"https://api.github.com/users/AlisdairO/orgs","repos_url":"https://api.github.com/users/AlisdairO/repos","events_url":"https://api.github.com/users/AlisdairO/events{/privacy}","received_events_url":"https://api.github.com/users/AlisdairO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlisdairO/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/AlisdairO/rust","forks_url":"https://api.github.com/repos/AlisdairO/rust/forks","keys_url":"https://api.github.com/repos/AlisdairO/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlisdairO/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlisdairO/rust/teams","hooks_url":"https://api.github.com/repos/AlisdairO/rust/hooks","issue_events_url":"https://api.github.com/repos/AlisdairO/rust/issues/events{/number}","events_url":"https://api.github.com/repos/AlisdairO/rust/events","assignees_url":"https://api.github.com/repos/AlisdairO/rust/assignees{/user}","branches_url":"https://api.github.com/repos/AlisdairO/rust/branches{/branch}","tags_url":"https://api.github.com/repos/AlisdairO/rust/tags","blobs_url":"https://api.github.com/repos/AlisdairO/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlisdairO/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlisdairO/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlisdairO/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlisdairO/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/AlisdairO/rust/languages","stargazers_url":"https://api.github.com/repos/AlisdairO/rust/stargazers","contributors_url":"https://api.github.com/repos/AlisdairO/rust/contributors","subscribers_url":"https://api.github.com/repos/AlisdairO/rust/subscribers","subscription_url":"https://api.github.com/repos/AlisdairO/rust/subscription","commits_url":"https://api.github.com/repos/AlisdairO/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlisdairO/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlisdairO/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlisdairO/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlisdairO/rust/contents/{+path}","compare_url":"https://api.github.com/repos/AlisdairO/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlisdairO/rust/merges","archive_url":"https://api.github.com/repos/AlisdairO/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlisdairO/rust/downloads","issues_url":"https://api.github.com/repos/AlisdairO/rust/issues{/number}","pulls_url":"https://api.github.com/repos/AlisdairO/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/AlisdairO/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/AlisdairO/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlisdairO/rust/labels{/name}","releases_url":"https://api.github.com/repos/AlisdairO/rust/releases{/id}","created_at":"2014-09-07T08:58:38Z","updated_at":"2014-12-19T20:04:48Z","pushed_at":"2015-07-19T08:59:46Z","git_url":"git://github.com/AlisdairO/rust.git","ssh_url":"git@github.com:AlisdairO/rust.git","clone_url":"https://github.com/AlisdairO/rust.git","svn_url":"https://github.com/AlisdairO/rust","homepage":"http://www.rust-lang.org","size":304140,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"a27fed7cbd9d5e2a2f025c226dd48bb0c4bbbb20","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-07-19T11:53:28Z","pushed_at":"2015-07-19T12:55:02Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":647408,"stargazers_count":12663,"watchers_count":12663,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2433,"mirror_url":null,"open_issues_count":2149,"forks":2433,"open_issues":2149,"watchers":12663,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27111"},"html":{"href":"https://github.com/rust-lang/rust/pull/27111"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27111"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27111/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27111/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27111/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/4ea02b72b77a7d077e6a249564314c39a597ded0"}}}}