{"action":"created","comment":{"url":"https://api.github.com/repos/ros/urdfdom/pulls/comments/40880147","id":40880147,"diff_hunk":"@@ -26,6 +26,15 @@ if (HAS_VISIBILITY)\n   set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -fvisibility=hidden\")\n endif()\n \n+# Using dynamic linking by default\n+option(BUILD_SHARED_LIBS \"Build shared libraries\" ON)\n+\n+# If building static libraries, set URDFDOM_STATIC definition for symbol\n+# visibility settings.\n+if (NOT BUILD_SHARED_LIBS)\n+  add_definitions(-DURDFDOM_STATIC)","path":"CMakeLists.txt","position":null,"original_position":10,"commit_id":"25d4010f995e8487fc4722e0fcc5baa075696728","original_commit_id":"72e61e508a74058fe74279b062e7abf637ba52b8","user":{"login":"jslee02","id":4038467,"avatar_url":"https://avatars.githubusercontent.com/u/4038467?v=3","gravatar_id":"","url":"https://api.github.com/users/jslee02","html_url":"https://github.com/jslee02","followers_url":"https://api.github.com/users/jslee02/followers","following_url":"https://api.github.com/users/jslee02/following{/other_user}","gists_url":"https://api.github.com/users/jslee02/gists{/gist_id}","starred_url":"https://api.github.com/users/jslee02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslee02/subscriptions","organizations_url":"https://api.github.com/users/jslee02/orgs","repos_url":"https://api.github.com/users/jslee02/repos","events_url":"https://api.github.com/users/jslee02/events{/privacy}","received_events_url":"https://api.github.com/users/jslee02/received_events","type":"User","site_admin":false},"body":"Thanks for the guide. \r\n\r\nI added distinct `config.h` file instead of configuring `exportdecl.h` because I prefer to use `config.h` file to includes all the definitions configured at cmake time. But I'm fine with using `exportdecl.h` for if this is not a preferable way to `urdfdom`.","created_at":"2015-10-01T05:27:01Z","updated_at":"2015-10-01T05:27:01Z","html_url":"https://github.com/ros/urdfdom/pull/64#discussion_r40880147","pull_request_url":"https://api.github.com/repos/ros/urdfdom/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/comments/40880147"},"html":{"href":"https://github.com/ros/urdfdom/pull/64#discussion_r40880147"},"pull_request":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/ros/urdfdom/pulls/64","id":46449345,"html_url":"https://github.com/ros/urdfdom/pull/64","diff_url":"https://github.com/ros/urdfdom/pull/64.diff","patch_url":"https://github.com/ros/urdfdom/pull/64.patch","issue_url":"https://api.github.com/repos/ros/urdfdom/issues/64","number":64,"state":"open","locked":false,"title":"Enable to build static libraries","user":{"login":"jslee02","id":4038467,"avatar_url":"https://avatars.githubusercontent.com/u/4038467?v=3","gravatar_id":"","url":"https://api.github.com/users/jslee02","html_url":"https://github.com/jslee02","followers_url":"https://api.github.com/users/jslee02/followers","following_url":"https://api.github.com/users/jslee02/following{/other_user}","gists_url":"https://api.github.com/users/jslee02/gists{/gist_id}","starred_url":"https://api.github.com/users/jslee02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslee02/subscriptions","organizations_url":"https://api.github.com/users/jslee02/orgs","repos_url":"https://api.github.com/users/jslee02/repos","events_url":"https://api.github.com/users/jslee02/events{/privacy}","received_events_url":"https://api.github.com/users/jslee02/received_events","type":"User","site_admin":false},"body":"This PR enables urdfdom to build static libraries by:\r\n  * adding shared/static build option\r\n  * adding URDFDOM_STATIC definition for static build\r\n  * removing explicit build type specification from `add_library(~)`\r\n\r\nThis does not change the default build behavior (i.e., shared build) when the build type is not specified.\r\n","created_at":"2015-09-30T20:04:15Z","updated_at":"2015-10-01T05:27:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd5c7ef97eede41ad45d7a520130113ac8d4131a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/urdfdom/pulls/64/commits","review_comments_url":"https://api.github.com/repos/ros/urdfdom/pulls/64/comments","review_comment_url":"https://api.github.com/repos/ros/urdfdom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/urdfdom/issues/64/comments","statuses_url":"https://api.github.com/repos/ros/urdfdom/statuses/25d4010f995e8487fc4722e0fcc5baa075696728","head":{"label":"dartsim:static_build","ref":"static_build","sha":"25d4010f995e8487fc4722e0fcc5baa075696728","user":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"repo":{"id":43455043,"name":"urdfdom-1","full_name":"dartsim/urdfdom-1","owner":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dartsim/urdfdom-1","description":"URDF parser","fork":true,"url":"https://api.github.com/repos/dartsim/urdfdom-1","forks_url":"https://api.github.com/repos/dartsim/urdfdom-1/forks","keys_url":"https://api.github.com/repos/dartsim/urdfdom-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dartsim/urdfdom-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dartsim/urdfdom-1/teams","hooks_url":"https://api.github.com/repos/dartsim/urdfdom-1/hooks","issue_events_url":"https://api.github.com/repos/dartsim/urdfdom-1/issues/events{/number}","events_url":"https://api.github.com/repos/dartsim/urdfdom-1/events","assignees_url":"https://api.github.com/repos/dartsim/urdfdom-1/assignees{/user}","branches_url":"https://api.github.com/repos/dartsim/urdfdom-1/branches{/branch}","tags_url":"https://api.github.com/repos/dartsim/urdfdom-1/tags","blobs_url":"https://api.github.com/repos/dartsim/urdfdom-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dartsim/urdfdom-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dartsim/urdfdom-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dartsim/urdfdom-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dartsim/urdfdom-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dartsim/urdfdom-1/languages","stargazers_url":"https://api.github.com/repos/dartsim/urdfdom-1/stargazers","contributors_url":"https://api.github.com/repos/dartsim/urdfdom-1/contributors","subscribers_url":"https://api.github.com/repos/dartsim/urdfdom-1/subscribers","subscription_url":"https://api.github.com/repos/dartsim/urdfdom-1/subscription","commits_url":"https://api.github.com/repos/dartsim/urdfdom-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dartsim/urdfdom-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dartsim/urdfdom-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dartsim/urdfdom-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dartsim/urdfdom-1/contents/{+path}","compare_url":"https://api.github.com/repos/dartsim/urdfdom-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dartsim/urdfdom-1/merges","archive_url":"https://api.github.com/repos/dartsim/urdfdom-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dartsim/urdfdom-1/downloads","issues_url":"https://api.github.com/repos/dartsim/urdfdom-1/issues{/number}","pulls_url":"https://api.github.com/repos/dartsim/urdfdom-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dartsim/urdfdom-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dartsim/urdfdom-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dartsim/urdfdom-1/labels{/name}","releases_url":"https://api.github.com/repos/dartsim/urdfdom-1/releases{/id}","created_at":"2015-09-30T19:45:17Z","updated_at":"2015-09-30T19:45:18Z","pushed_at":"2015-10-01T05:11:25Z","git_url":"git://github.com/dartsim/urdfdom-1.git","ssh_url":"git@github.com:dartsim/urdfdom-1.git","clone_url":"https://github.com/dartsim/urdfdom-1.git","svn_url":"https://github.com/dartsim/urdfdom-1","homepage":"http://ros.org/wiki/urdf","size":4221,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros:master","ref":"master","sha":"59433bb2f5226d9728fffa75cdc6ebd4344ba08c","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":12067406,"name":"urdfdom","full_name":"ros/urdfdom","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/urdfdom","description":"URDF parser","fork":false,"url":"https://api.github.com/repos/ros/urdfdom","forks_url":"https://api.github.com/repos/ros/urdfdom/forks","keys_url":"https://api.github.com/repos/ros/urdfdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/urdfdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/urdfdom/teams","hooks_url":"https://api.github.com/repos/ros/urdfdom/hooks","issue_events_url":"https://api.github.com/repos/ros/urdfdom/issues/events{/number}","events_url":"https://api.github.com/repos/ros/urdfdom/events","assignees_url":"https://api.github.com/repos/ros/urdfdom/assignees{/user}","branches_url":"https://api.github.com/repos/ros/urdfdom/branches{/branch}","tags_url":"https://api.github.com/repos/ros/urdfdom/tags","blobs_url":"https://api.github.com/repos/ros/urdfdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/urdfdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/urdfdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/urdfdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/urdfdom/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/urdfdom/languages","stargazers_url":"https://api.github.com/repos/ros/urdfdom/stargazers","contributors_url":"https://api.github.com/repos/ros/urdfdom/contributors","subscribers_url":"https://api.github.com/repos/ros/urdfdom/subscribers","subscription_url":"https://api.github.com/repos/ros/urdfdom/subscription","commits_url":"https://api.github.com/repos/ros/urdfdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/urdfdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/urdfdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/urdfdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/urdfdom/contents/{+path}","compare_url":"https://api.github.com/repos/ros/urdfdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/urdfdom/merges","archive_url":"https://api.github.com/repos/ros/urdfdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/urdfdom/downloads","issues_url":"https://api.github.com/repos/ros/urdfdom/issues{/number}","pulls_url":"https://api.github.com/repos/ros/urdfdom/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/urdfdom/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/urdfdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/urdfdom/labels{/name}","releases_url":"https://api.github.com/repos/ros/urdfdom/releases{/id}","created_at":"2013-08-12T22:06:33Z","updated_at":"2015-03-31T04:43:41Z","pushed_at":"2015-10-01T05:11:26Z","git_url":"git://github.com/ros/urdfdom.git","ssh_url":"git@github.com:ros/urdfdom.git","clone_url":"https://github.com/ros/urdfdom.git","svn_url":"https://github.com/ros/urdfdom","homepage":"http://ros.org/wiki/urdf","size":4221,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":23,"forks":34,"open_issues":23,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/64"},"html":{"href":"https://github.com/ros/urdfdom/pull/64"},"issue":{"href":"https://api.github.com/repos/ros/urdfdom/issues/64"},"comments":{"href":"https://api.github.com/repos/ros/urdfdom/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/urdfdom/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/ros/urdfdom/statuses/25d4010f995e8487fc4722e0fcc5baa075696728"}}}}