{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/37529800","id":37529800,"diff_hunk":"@@ -211,6 +213,14 @@ public IndexManager getIndexManager(String targetIndexName) {\n \t\treturn indexManagersRegistry.get( targetIndexName );\n \t}\n \n+\tpublic BackendQueueProcessor getBackendQueueProcessor(String indexName) {","path":"engine/src/main/java/org/hibernate/search/indexes/impl/IndexManagerHolder.java","position":67,"original_position":67,"commit_id":"47d07d211ab4df7ffa36df84af624c20d4d367ec","original_commit_id":"47d07d211ab4df7ffa36df84af624c20d4d367ec","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"But potentially a new idea","created_at":"2015-08-20T13:43:14Z","updated_at":"2015-08-20T13:43:14Z","html_url":"https://github.com/hibernate/hibernate-search/pull/896#discussion_r37529800","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/37529800"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/896#discussion_r37529800"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896","id":42927084,"html_url":"https://github.com/hibernate/hibernate-search/pull/896","diff_url":"https://github.com/hibernate/hibernate-search/pull/896.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/896.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/896","number":896,"state":"open","locked":false,"title":"HSEARCH-1970 Untangling IndexManager and BackendQueueProcessor contracts","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"@Sanne, @hferentschik This PR does the untangling of `(DirectoryBased)IndexManager` and `BackendQueueProcessor` we discussed. Responsibilities are much nicer defined that way and it will e.g. allow to use the ES index manager via JMS without further changes in the new ES index manager being required.\r\n\r\nOn a tangent this change also allowed to remove some methods from `BQP` which did not really make sense there (lock handling).\r\n\r\nOf course it's a braking change to existing `IndexManager` and `BackendQueueProcessor` implementations. Not sure how much that is in reality as I'd expect those contracts only to be implemented by rather advanced integrators?\r\n\r\nAnyways, let me know what you think. Maybe it's not as overwhelming as the ES PR :)","created_at":"2015-08-20T13:09:10Z","updated_at":"2015-08-20T13:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d662ac3a2b313015d80c382ece54d68bc404325","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/896/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/47d07d211ab4df7ffa36df84af624c20d4d367ec","head":{"label":"gunnarmorling:HSEARCH-1970","ref":"HSEARCH-1970","sha":"47d07d211ab4df7ffa36df84af624c20d4d367ec","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"repo":{"id":10077974,"name":"hibernate-search","full_name":"gunnarmorling/hibernate-search","owner":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunnarmorling/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/gunnarmorling/hibernate-search","forks_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/forks","keys_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/teams","hooks_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/events","assignees_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/tags","blobs_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/subscription","commits_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/merges","archive_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/downloads","issues_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/gunnarmorling/hibernate-search/releases{/id}","created_at":"2013-05-15T12:21:58Z","updated_at":"2014-08-07T13:43:45Z","pushed_at":"2015-08-20T13:02:12Z","git_url":"git://github.com/gunnarmorling/hibernate-search.git","ssh_url":"git@github.com:gunnarmorling/hibernate-search.git","clone_url":"https://github.com/gunnarmorling/hibernate-search.git","svn_url":"https://github.com/gunnarmorling/hibernate-search","homepage":"http://search.hibernate.org","size":43349,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"fc57445f153658929871d4953ca21a423f47868c","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","created_at":"2010-10-15T15:55:09Z","updated_at":"2015-08-20T01:33:17Z","pushed_at":"2015-08-20T13:09:11Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":68003,"stargazers_count":150,"watchers_count":150,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":5,"forks":108,"open_issues":5,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/896"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/896"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/47d07d211ab4df7ffa36df84af624c20d4d367ec"}}}}