{"action":"created","issue":{"url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/9","labels_url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/9/comments","events_url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/9/events","html_url":"https://github.com/perl5-utils/List-MoreUtils/pull/9","id":65789556,"number":9,"title":"Simplify testing and configuration setup","user":{"login":"haarg","id":50029,"avatar_url":"https://avatars.githubusercontent.com/u/50029?v=3","gravatar_id":"","url":"https://api.github.com/users/haarg","html_url":"https://github.com/haarg","followers_url":"https://api.github.com/users/haarg/followers","following_url":"https://api.github.com/users/haarg/following{/other_user}","gists_url":"https://api.github.com/users/haarg/gists{/gist_id}","starred_url":"https://api.github.com/users/haarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haarg/subscriptions","organizations_url":"https://api.github.com/users/haarg/orgs","repos_url":"https://api.github.com/users/haarg/repos","events_url":"https://api.github.com/users/haarg/events{/privacy}","received_events_url":"https://api.github.com/users/haarg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":41,"created_at":"2015-04-01T22:08:33Z","updated_at":"2015-05-05T20:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/pulls/9","html_url":"https://github.com/perl5-utils/List-MoreUtils/pull/9","diff_url":"https://github.com/perl5-utils/List-MoreUtils/pull/9.diff","patch_url":"https://github.com/perl5-utils/List-MoreUtils/pull/9.patch"},"body":"Rather than generating test files at configure time and packaging a ton of unneeded code in inc/, just have the tests hard coded and pick which to run based on if XS is being used."},"comment":{"url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/comments/99203524","html_url":"https://github.com/perl5-utils/List-MoreUtils/pull/9#issuecomment-99203524","issue_url":"https://api.github.com/repos/perl5-utils/List-MoreUtils/issues/9","id":99203524,"user":{"login":"rehsack","id":230029,"avatar_url":"https://avatars.githubusercontent.com/u/230029?v=3","gravatar_id":"","url":"https://api.github.com/users/rehsack","html_url":"https://github.com/rehsack","followers_url":"https://api.github.com/users/rehsack/followers","following_url":"https://api.github.com/users/rehsack/following{/other_user}","gists_url":"https://api.github.com/users/rehsack/gists{/gist_id}","starred_url":"https://api.github.com/users/rehsack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehsack/subscriptions","organizations_url":"https://api.github.com/users/rehsack/orgs","repos_url":"https://api.github.com/users/rehsack/repos","events_url":"https://api.github.com/users/rehsack/events{/privacy}","received_events_url":"https://api.github.com/users/rehsack/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T20:00:23Z","updated_at":"2015-05-05T20:00:23Z","body":"Ich habe mir das angesehen und brauche keine halbe Stunde (siehe https://github.com/perl5-utils/List-MoreUtils/pull/9#issuecomment-98985992) um mehere Problempunkte aufzuzeigen. Ich habe in kleiner Runde diese Codeschnippsel bereits kritisiert. Da Du diese Punkte weder aufgreifst noch @ribasushi 's ExtUtils::HaveCompiler Review-Anfrage kommentierst, sehe ich nicht, was Dich außer der nicht-Verwendung der deiner Meinung nach korrekten Lösung, stört.\r\n\r\nIn viele dieser Probleme mit dem Code bin ich schon reingelaufen - und es wird nicht am Code gearbeitet, sondern Vorschläge unterbreitet, wie das reinlaufen in die Probleme verhindert werden kann. (Don't use compiler wrappers who fix broken arguments, add missing rpath etc.).\r\n\r\nEs tut mir leid, \"well tested\" sagt nichts aus, wenn die Tests bestimmte use-cases (möglicherweise naturgemäß) nicht abbilden."}}