{"action":"closed","number":375,"pull_request":{"url":"https://api.github.com/repos/cloudflare/cfssl/pulls/375","id":47322035,"html_url":"https://github.com/cloudflare/cfssl/pull/375","diff_url":"https://github.com/cloudflare/cfssl/pull/375.diff","patch_url":"https://github.com/cloudflare/cfssl/pull/375.patch","issue_url":"https://api.github.com/repos/cloudflare/cfssl/issues/375","number":375,"state":"closed","locked":false,"title":"Adapt ParseCertificatesDER to use the new golang pkcs12 library","user":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"body":"We no longer need to maintain crypto/pkcs12 since pkcs12 has been merged with golang. Addresses comment on #279 . The interface is very similar except the new pkcs12.Decode returns only a single certificate pointer rather than a list of them.","created_at":"2015-10-09T21:28:36Z","updated_at":"2015-10-10T16:38:27Z","closed_at":"2015-10-10T16:38:27Z","merged_at":"2015-10-10T16:38:27Z","merge_commit_sha":"c923d3de7c9c6667b7b1ca820f6a9f19d62718c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/375/commits","review_comments_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/375/comments","review_comment_url":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/issues/375/comments","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/b84b2cc703c4da11934289bee153f2ab878ed5d6","head":{"label":"andrewbuss:andrewbuss/use_golang_pkcs12","ref":"andrewbuss/use_golang_pkcs12","sha":"b84b2cc703c4da11934289bee153f2ab878ed5d6","user":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"repo":{"id":43838375,"name":"cfssl","full_name":"andrewbuss/cfssl","owner":{"login":"andrewbuss","id":5904167,"avatar_url":"https://avatars.githubusercontent.com/u/5904167?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbuss","html_url":"https://github.com/andrewbuss","followers_url":"https://api.github.com/users/andrewbuss/followers","following_url":"https://api.github.com/users/andrewbuss/following{/other_user}","gists_url":"https://api.github.com/users/andrewbuss/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbuss/subscriptions","organizations_url":"https://api.github.com/users/andrewbuss/orgs","repos_url":"https://api.github.com/users/andrewbuss/repos","events_url":"https://api.github.com/users/andrewbuss/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbuss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewbuss/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":true,"url":"https://api.github.com/repos/andrewbuss/cfssl","forks_url":"https://api.github.com/repos/andrewbuss/cfssl/forks","keys_url":"https://api.github.com/repos/andrewbuss/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewbuss/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewbuss/cfssl/teams","hooks_url":"https://api.github.com/repos/andrewbuss/cfssl/hooks","issue_events_url":"https://api.github.com/repos/andrewbuss/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/andrewbuss/cfssl/events","assignees_url":"https://api.github.com/repos/andrewbuss/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/andrewbuss/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/andrewbuss/cfssl/tags","blobs_url":"https://api.github.com/repos/andrewbuss/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewbuss/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewbuss/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewbuss/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewbuss/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewbuss/cfssl/languages","stargazers_url":"https://api.github.com/repos/andrewbuss/cfssl/stargazers","contributors_url":"https://api.github.com/repos/andrewbuss/cfssl/contributors","subscribers_url":"https://api.github.com/repos/andrewbuss/cfssl/subscribers","subscription_url":"https://api.github.com/repos/andrewbuss/cfssl/subscription","commits_url":"https://api.github.com/repos/andrewbuss/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewbuss/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewbuss/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewbuss/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewbuss/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/andrewbuss/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewbuss/cfssl/merges","archive_url":"https://api.github.com/repos/andrewbuss/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewbuss/cfssl/downloads","issues_url":"https://api.github.com/repos/andrewbuss/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/andrewbuss/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewbuss/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewbuss/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewbuss/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/andrewbuss/cfssl/releases{/id}","created_at":"2015-10-07T19:02:02Z","updated_at":"2015-10-07T19:02:03Z","pushed_at":"2015-10-09T21:24:45Z","git_url":"git://github.com/andrewbuss/cfssl.git","ssh_url":"git@github.com:andrewbuss/cfssl.git","clone_url":"https://github.com/andrewbuss/cfssl.git","svn_url":"https://github.com/andrewbuss/cfssl","homepage":"https://cfssl.org/","size":2332,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudflare:master","ref":"master","sha":"fa1559794e85b3c060fa50d42c05def3cb48e217","user":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"repo":{"id":21591001,"name":"cfssl","full_name":"cloudflare/cfssl","owner":{"login":"cloudflare","id":314135,"avatar_url":"https://avatars.githubusercontent.com/u/314135?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudflare","html_url":"https://github.com/cloudflare","followers_url":"https://api.github.com/users/cloudflare/followers","following_url":"https://api.github.com/users/cloudflare/following{/other_user}","gists_url":"https://api.github.com/users/cloudflare/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudflare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudflare/subscriptions","organizations_url":"https://api.github.com/users/cloudflare/orgs","repos_url":"https://api.github.com/users/cloudflare/repos","events_url":"https://api.github.com/users/cloudflare/events{/privacy}","received_events_url":"https://api.github.com/users/cloudflare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudflare/cfssl","description":"CFSSL: CloudFlare's PKI toolkit","fork":false,"url":"https://api.github.com/repos/cloudflare/cfssl","forks_url":"https://api.github.com/repos/cloudflare/cfssl/forks","keys_url":"https://api.github.com/repos/cloudflare/cfssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudflare/cfssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudflare/cfssl/teams","hooks_url":"https://api.github.com/repos/cloudflare/cfssl/hooks","issue_events_url":"https://api.github.com/repos/cloudflare/cfssl/issues/events{/number}","events_url":"https://api.github.com/repos/cloudflare/cfssl/events","assignees_url":"https://api.github.com/repos/cloudflare/cfssl/assignees{/user}","branches_url":"https://api.github.com/repos/cloudflare/cfssl/branches{/branch}","tags_url":"https://api.github.com/repos/cloudflare/cfssl/tags","blobs_url":"https://api.github.com/repos/cloudflare/cfssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudflare/cfssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudflare/cfssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudflare/cfssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudflare/cfssl/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudflare/cfssl/languages","stargazers_url":"https://api.github.com/repos/cloudflare/cfssl/stargazers","contributors_url":"https://api.github.com/repos/cloudflare/cfssl/contributors","subscribers_url":"https://api.github.com/repos/cloudflare/cfssl/subscribers","subscription_url":"https://api.github.com/repos/cloudflare/cfssl/subscription","commits_url":"https://api.github.com/repos/cloudflare/cfssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudflare/cfssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudflare/cfssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudflare/cfssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudflare/cfssl/contents/{+path}","compare_url":"https://api.github.com/repos/cloudflare/cfssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudflare/cfssl/merges","archive_url":"https://api.github.com/repos/cloudflare/cfssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudflare/cfssl/downloads","issues_url":"https://api.github.com/repos/cloudflare/cfssl/issues{/number}","pulls_url":"https://api.github.com/repos/cloudflare/cfssl/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudflare/cfssl/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudflare/cfssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudflare/cfssl/labels{/name}","releases_url":"https://api.github.com/repos/cloudflare/cfssl/releases{/id}","created_at":"2014-07-07T23:49:12Z","updated_at":"2015-10-09T12:56:19Z","pushed_at":"2015-10-10T16:38:27Z","git_url":"git://github.com/cloudflare/cfssl.git","ssh_url":"git@github.com:cloudflare/cfssl.git","clone_url":"https://github.com/cloudflare/cfssl.git","svn_url":"https://github.com/cloudflare/cfssl","homepage":"https://cfssl.org/","size":5372,"stargazers_count":856,"watchers_count":856,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":51,"forks":88,"open_issues":51,"watchers":856,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/375"},"html":{"href":"https://github.com/cloudflare/cfssl/pull/375"},"issue":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/375"},"comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudflare/cfssl/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/cloudflare/cfssl/statuses/b84b2cc703c4da11934289bee153f2ab878ed5d6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grittygrease","id":5125095,"avatar_url":"https://avatars.githubusercontent.com/u/5125095?v=3","gravatar_id":"","url":"https://api.github.com/users/grittygrease","html_url":"https://github.com/grittygrease","followers_url":"https://api.github.com/users/grittygrease/followers","following_url":"https://api.github.com/users/grittygrease/following{/other_user}","gists_url":"https://api.github.com/users/grittygrease/gists{/gist_id}","starred_url":"https://api.github.com/users/grittygrease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grittygrease/subscriptions","organizations_url":"https://api.github.com/users/grittygrease/orgs","repos_url":"https://api.github.com/users/grittygrease/repos","events_url":"https://api.github.com/users/grittygrease/events{/privacy}","received_events_url":"https://api.github.com/users/grittygrease/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":545,"changed_files":4}}