{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/fariza/matplotlib/pulls/5","id":28371321,"html_url":"https://github.com/fariza/matplotlib/pull/5","diff_url":"https://github.com/fariza/matplotlib/pull/5.diff","patch_url":"https://github.com/fariza/matplotlib/pull/5.patch","issue_url":"https://api.github.com/repos/fariza/matplotlib/issues/5","number":5,"state":"closed","locked":false,"title":"Toolbars keep history if axes change","user":{"login":"KevKeating","id":7716291,"avatar_url":"https://avatars.githubusercontent.com/u/7716291?v=3","gravatar_id":"","url":"https://api.github.com/users/KevKeating","html_url":"https://github.com/KevKeating","followers_url":"https://api.github.com/users/KevKeating/followers","following_url":"https://api.github.com/users/KevKeating/following{/other_user}","gists_url":"https://api.github.com/users/KevKeating/gists{/gist_id}","starred_url":"https://api.github.com/users/KevKeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevKeating/subscriptions","organizations_url":"https://api.github.com/users/KevKeating/orgs","repos_url":"https://api.github.com/users/KevKeating/repos","events_url":"https://api.github.com/users/KevKeating/events{/privacy}","received_events_url":"https://api.github.com/users/KevKeating/received_events","type":"User","site_admin":false},"body":"This is a fix for matplotlib/matplotlib#2511 based on matplotlib/matplotlib#3652.  With this PR, the back, forward, and home buttons in the toolbar will continue to work even if the number of axes changes. I've added a home_views dictionary that stores the initial views of all axes. If an axes object didn't exist when a view was created, the initial view will be used for that axes. Positions will only be restored if there is a position for all axes objects. This avoids having newer axes overlap with older ones when clicking on back or home.\r\n\r\nAssuming that the NavigationToolbar2-based classes aren't going to be completely deleted in matplotlib 1.5, I'd be inclined to merge both this PR as well as matplotlib/matplotlib#3347, which is the same fix applied to the NavigationToolbar2 toolbars.  Since that PR is essentially complete, there's no effort involved in the back-port.  (I still need to disconnect toolbar.update() as an axobserver, but it's fully functional other than that.)  If the intent is to have no new code added to the NavigationToolbar2 classes, though, that's fine as well.","created_at":"2015-01-30T16:00:01Z","updated_at":"2015-04-13T17:21:49Z","closed_at":"2015-04-13T17:21:49Z","merged_at":null,"merge_commit_sha":"32722ccd6b1e79ad6c8253fab0f303d0e1701c95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fariza/matplotlib/pulls/5/commits","review_comments_url":"https://api.github.com/repos/fariza/matplotlib/pulls/5/comments","review_comment_url":"https://api.github.com/repos/fariza/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fariza/matplotlib/issues/5/comments","statuses_url":"https://api.github.com/repos/fariza/matplotlib/statuses/e4e53ddca758042c82dfe501518f1943f1147498","head":{"label":"KevKeating:iss2511-nbe","ref":"iss2511-nbe","sha":"e4e53ddca758042c82dfe501518f1943f1147498","user":{"login":"KevKeating","id":7716291,"avatar_url":"https://avatars.githubusercontent.com/u/7716291?v=3","gravatar_id":"","url":"https://api.github.com/users/KevKeating","html_url":"https://github.com/KevKeating","followers_url":"https://api.github.com/users/KevKeating/followers","following_url":"https://api.github.com/users/KevKeating/following{/other_user}","gists_url":"https://api.github.com/users/KevKeating/gists{/gist_id}","starred_url":"https://api.github.com/users/KevKeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevKeating/subscriptions","organizations_url":"https://api.github.com/users/KevKeating/orgs","repos_url":"https://api.github.com/users/KevKeating/repos","events_url":"https://api.github.com/users/KevKeating/events{/privacy}","received_events_url":"https://api.github.com/users/KevKeating/received_events","type":"User","site_admin":false},"repo":{"id":20456113,"name":"matplotlib","full_name":"KevKeating/matplotlib","owner":{"login":"KevKeating","id":7716291,"avatar_url":"https://avatars.githubusercontent.com/u/7716291?v=3","gravatar_id":"","url":"https://api.github.com/users/KevKeating","html_url":"https://github.com/KevKeating","followers_url":"https://api.github.com/users/KevKeating/followers","following_url":"https://api.github.com/users/KevKeating/following{/other_user}","gists_url":"https://api.github.com/users/KevKeating/gists{/gist_id}","starred_url":"https://api.github.com/users/KevKeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevKeating/subscriptions","organizations_url":"https://api.github.com/users/KevKeating/orgs","repos_url":"https://api.github.com/users/KevKeating/repos","events_url":"https://api.github.com/users/KevKeating/events{/privacy}","received_events_url":"https://api.github.com/users/KevKeating/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevKeating/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/KevKeating/matplotlib","forks_url":"https://api.github.com/repos/KevKeating/matplotlib/forks","keys_url":"https://api.github.com/repos/KevKeating/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevKeating/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevKeating/matplotlib/teams","hooks_url":"https://api.github.com/repos/KevKeating/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/KevKeating/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/KevKeating/matplotlib/events","assignees_url":"https://api.github.com/repos/KevKeating/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/KevKeating/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/KevKeating/matplotlib/tags","blobs_url":"https://api.github.com/repos/KevKeating/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevKeating/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevKeating/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevKeating/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevKeating/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/KevKeating/matplotlib/languages","stargazers_url":"https://api.github.com/repos/KevKeating/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/KevKeating/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/KevKeating/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/KevKeating/matplotlib/subscription","commits_url":"https://api.github.com/repos/KevKeating/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevKeating/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevKeating/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevKeating/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevKeating/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/KevKeating/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevKeating/matplotlib/merges","archive_url":"https://api.github.com/repos/KevKeating/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevKeating/matplotlib/downloads","issues_url":"https://api.github.com/repos/KevKeating/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/KevKeating/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/KevKeating/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/KevKeating/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevKeating/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/KevKeating/matplotlib/releases{/id}","created_at":"2014-06-03T19:20:40Z","updated_at":"2014-06-11T16:58:27Z","pushed_at":"2015-01-30T15:39:37Z","git_url":"git://github.com/KevKeating/matplotlib.git","ssh_url":"git@github.com:KevKeating/matplotlib.git","clone_url":"https://github.com/KevKeating/matplotlib.git","svn_url":"https://github.com/KevKeating/matplotlib","homepage":"http://matplotlib.org/","size":197546,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fariza:navigation-by-events","ref":"navigation-by-events","sha":"5eae4e12c657616e007c1ef4336a01f695cf3a43","user":{"login":"fariza","id":1490153,"avatar_url":"https://avatars.githubusercontent.com/u/1490153?v=3","gravatar_id":"","url":"https://api.github.com/users/fariza","html_url":"https://github.com/fariza","followers_url":"https://api.github.com/users/fariza/followers","following_url":"https://api.github.com/users/fariza/following{/other_user}","gists_url":"https://api.github.com/users/fariza/gists{/gist_id}","starred_url":"https://api.github.com/users/fariza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fariza/subscriptions","organizations_url":"https://api.github.com/users/fariza/orgs","repos_url":"https://api.github.com/users/fariza/repos","events_url":"https://api.github.com/users/fariza/events{/privacy}","received_events_url":"https://api.github.com/users/fariza/received_events","type":"User","site_admin":false},"repo":{"id":12761338,"name":"matplotlib","full_name":"fariza/matplotlib","owner":{"login":"fariza","id":1490153,"avatar_url":"https://avatars.githubusercontent.com/u/1490153?v=3","gravatar_id":"","url":"https://api.github.com/users/fariza","html_url":"https://github.com/fariza","followers_url":"https://api.github.com/users/fariza/followers","following_url":"https://api.github.com/users/fariza/following{/other_user}","gists_url":"https://api.github.com/users/fariza/gists{/gist_id}","starred_url":"https://api.github.com/users/fariza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fariza/subscriptions","organizations_url":"https://api.github.com/users/fariza/orgs","repos_url":"https://api.github.com/users/fariza/repos","events_url":"https://api.github.com/users/fariza/events{/privacy}","received_events_url":"https://api.github.com/users/fariza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fariza/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/fariza/matplotlib","forks_url":"https://api.github.com/repos/fariza/matplotlib/forks","keys_url":"https://api.github.com/repos/fariza/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fariza/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fariza/matplotlib/teams","hooks_url":"https://api.github.com/repos/fariza/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/fariza/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/fariza/matplotlib/events","assignees_url":"https://api.github.com/repos/fariza/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/fariza/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/fariza/matplotlib/tags","blobs_url":"https://api.github.com/repos/fariza/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fariza/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fariza/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/fariza/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fariza/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/fariza/matplotlib/languages","stargazers_url":"https://api.github.com/repos/fariza/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/fariza/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/fariza/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/fariza/matplotlib/subscription","commits_url":"https://api.github.com/repos/fariza/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/fariza/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/fariza/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/fariza/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/fariza/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/fariza/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fariza/matplotlib/merges","archive_url":"https://api.github.com/repos/fariza/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fariza/matplotlib/downloads","issues_url":"https://api.github.com/repos/fariza/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/fariza/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/fariza/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/fariza/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fariza/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/fariza/matplotlib/releases{/id}","created_at":"2013-09-11T16:28:02Z","updated_at":"2015-02-13T19:38:54Z","pushed_at":"2015-04-13T17:21:48Z","git_url":"git://github.com/fariza/matplotlib.git","ssh_url":"git@github.com:fariza/matplotlib.git","clone_url":"https://github.com/fariza/matplotlib.git","svn_url":"https://github.com/fariza/matplotlib","homepage":"http://matplotlib.org/","size":213690,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fariza/matplotlib/pulls/5"},"html":{"href":"https://github.com/fariza/matplotlib/pull/5"},"issue":{"href":"https://api.github.com/repos/fariza/matplotlib/issues/5"},"comments":{"href":"https://api.github.com/repos/fariza/matplotlib/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/fariza/matplotlib/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/fariza/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fariza/matplotlib/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/fariza/matplotlib/statuses/e4e53ddca758042c82dfe501518f1943f1147498"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":61,"additions":2027,"deletions":21,"changed_files":8}}