{"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/39011869","id":39011869,"diff_hunk":"@@ -161,8 +166,11 @@ public IRelevanceCheck createRelevanceCheck(IJavaElement element) {\n \t * @see org.jboss.tools.common.el.core.resolver.ELResolver#resolve(org.jboss.tools.common.el.core.resolver.ELContext, org.jboss.tools.common.el.core.model.ELExpression)\r\n \t */\r\n \tpublic ELResolution resolve(ELContext context, ELExpression operand, int offset) {\r\n-\t\tList<Var> vars = new ArrayList<Var>();\r\n+\t\tList<Var> vars = EMPTY_VARS;\r\n \t\tVar[] array = context.getVars(offset);\r\n+\t\tif(array.length > 0) {\r","path":"common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ca/AbstractELCompletionEngine.java","position":29,"original_position":29,"commit_id":"cd0fd6264f7d796234de9b8fe79b799fa32f4e2d","original_commit_id":"cd0fd6264f7d796234de9b8fe79b799fa32f4e2d","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"body":"I agree, this code needs further improvement.","created_at":"2015-09-09T06:52:55Z","updated_at":"2015-09-09T06:52:55Z","html_url":"https://github.com/jbosstools/jbosstools-base/pull/448#discussion_r39011869","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/39011869"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/448#discussion_r39011869"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448","id":44275935,"html_url":"https://github.com/jbosstools/jbosstools-base/pull/448","diff_url":"https://github.com/jbosstools/jbosstools-base/pull/448.diff","patch_url":"https://github.com/jbosstools/jbosstools-base/pull/448.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/448","number":448,"state":"closed","locked":false,"title":"JBIDE-20580 Performance: EL resolvers unnecessarily create a lot of empty ArrayList instances","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-05T03:42:01Z","updated_at":"2015-09-09T06:52:55Z","closed_at":"2015-09-06T16:37:18Z","merged_at":"2015-09-06T16:37:18Z","merge_commit_sha":"88476491eaafc7c36a0ceea5e5d439517c7bf922","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/448/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/cd0fd6264f7d796234de9b8fe79b799fa32f4e2d","head":{"label":"scabanovich:jbide-20580","ref":"jbide-20580","sha":"cd0fd6264f7d796234de9b8fe79b799fa32f4e2d","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"repo":{"id":6444098,"name":"jbosstools-base","full_name":"scabanovich/jbosstools-base","owner":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scabanovich/jbosstools-base","description":"JBoss Tools :: Base { common, runtime, tests, usage }","fork":true,"url":"https://api.github.com/repos/scabanovich/jbosstools-base","forks_url":"https://api.github.com/repos/scabanovich/jbosstools-base/forks","keys_url":"https://api.github.com/repos/scabanovich/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scabanovich/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scabanovich/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/scabanovich/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/scabanovich/jbosstools-base/events","assignees_url":"https://api.github.com/repos/scabanovich/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/scabanovich/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/scabanovich/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scabanovich/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/scabanovich/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/scabanovich/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/scabanovich/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/scabanovich/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/scabanovich/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/scabanovich/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/scabanovich/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/scabanovich/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/scabanovich/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scabanovich/jbosstools-base/merges","archive_url":"https://api.github.com/repos/scabanovich/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scabanovich/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/scabanovich/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/scabanovich/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/scabanovich/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scabanovich/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/scabanovich/jbosstools-base/releases{/id}","created_at":"2012-10-29T16:56:05Z","updated_at":"2015-05-01T19:56:33Z","pushed_at":"2015-09-08T17:15:50Z","git_url":"git://github.com/scabanovich/jbosstools-base.git","ssh_url":"git@github.com:scabanovich/jbosstools-base.git","clone_url":"https://github.com/scabanovich/jbosstools-base.git","svn_url":"https://github.com/scabanovich/jbosstools-base","homepage":"","size":70967,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"1eb4d392210ac620a06f869caaaa184c7f66b7e3","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308266,"name":"jbosstools-base","full_name":"jbosstools/jbosstools-base","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-base","description":"JBoss Tools :: Base { common, foundation, runtime, stacks, tests, usage }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-base","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-base/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-base/releases{/id}","created_at":"2012-10-20T11:22:45Z","updated_at":"2015-08-10T04:55:09Z","pushed_at":"2015-09-08T20:30:07Z","git_url":"git://github.com/jbosstools/jbosstools-base.git","ssh_url":"git@github.com:jbosstools/jbosstools-base.git","clone_url":"https://github.com/jbosstools/jbosstools-base.git","svn_url":"https://github.com/jbosstools/jbosstools-base","homepage":"","size":77555,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":4,"forks":45,"open_issues":4,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/448"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/448"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/cd0fd6264f7d796234de9b8fe79b799fa32f4e2d"}}}}