{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/43438320","id":43438320,"diff_hunk":"@@ -272,9 +272,9 @@ void ViveControllerManager::update(float deltaTime, bool jointsCaptured) {\n     auto userInputMapper = DependencyManager::get<controller::UserInputMapper>();\n         \n     if (numTrackedControllers == 0) {\n-        if (_deviceID != 0) {\n+        if (_deviceID != controller::Input::INVALID_DEVICE) {\n             userInputMapper->removeDevice(_deviceID);\n-            _deviceID = 0;\n+            _deviceID = controller::Input::INVALID_DEVICE;","path":"libraries/input-plugins/src/input-plugins/ViveControllerManager.cpp","position":8,"original_position":8,"commit_id":"9165b21895863ac7947d0b8dc655f3337693271c","original_commit_id":"9165b21895863ac7947d0b8dc655f3337693271c","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"since I don't have access to Vive controller hardware I can't really test it... I guess I'd start by debugging to see if ViveControllerManager::handleButtonEvent() is being called, and to trace through what's happening in there. The code looks very similar to the Sixense plugin... so I'd expect it to work.","created_at":"2015-10-29T20:16:08Z","updated_at":"2015-10-29T20:16:08Z","html_url":"https://github.com/highfidelity/hifi/pull/6223#discussion_r43438320","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6223","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/43438320"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6223#discussion_r43438320"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6223"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/6223","id":49187124,"html_url":"https://github.com/highfidelity/hifi/pull/6223","diff_url":"https://github.com/highfidelity/hifi/pull/6223.diff","patch_url":"https://github.com/highfidelity/hifi/pull/6223.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/6223","number":6223,"state":"open","locked":false,"title":"Vive Controller","user":{"login":"AlessandroSigna","id":13383505,"avatar_url":"https://avatars.githubusercontent.com/u/13383505?v=3","gravatar_id":"","url":"https://api.github.com/users/AlessandroSigna","html_url":"https://github.com/AlessandroSigna","followers_url":"https://api.github.com/users/AlessandroSigna/followers","following_url":"https://api.github.com/users/AlessandroSigna/following{/other_user}","gists_url":"https://api.github.com/users/AlessandroSigna/gists{/gist_id}","starred_url":"https://api.github.com/users/AlessandroSigna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlessandroSigna/subscriptions","organizations_url":"https://api.github.com/users/AlessandroSigna/orgs","repos_url":"https://api.github.com/users/AlessandroSigna/repos","events_url":"https://api.github.com/users/AlessandroSigna/events{/privacy}","received_events_url":"https://api.github.com/users/AlessandroSigna/received_events","type":"User","site_admin":false},"body":"The pose works fine, but the buttons and trackpads don't ","created_at":"2015-10-29T19:20:39Z","updated_at":"2015-10-29T20:16:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3367869f6524e4b51735b0fb7516f5c2300c4f07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6223/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/6223/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/6223/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/9165b21895863ac7947d0b8dc655f3337693271c","head":{"label":"AlessandroSigna:controllers","ref":"controllers","sha":"9165b21895863ac7947d0b8dc655f3337693271c","user":{"login":"AlessandroSigna","id":13383505,"avatar_url":"https://avatars.githubusercontent.com/u/13383505?v=3","gravatar_id":"","url":"https://api.github.com/users/AlessandroSigna","html_url":"https://github.com/AlessandroSigna","followers_url":"https://api.github.com/users/AlessandroSigna/followers","following_url":"https://api.github.com/users/AlessandroSigna/following{/other_user}","gists_url":"https://api.github.com/users/AlessandroSigna/gists{/gist_id}","starred_url":"https://api.github.com/users/AlessandroSigna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlessandroSigna/subscriptions","organizations_url":"https://api.github.com/users/AlessandroSigna/orgs","repos_url":"https://api.github.com/users/AlessandroSigna/repos","events_url":"https://api.github.com/users/AlessandroSigna/events{/privacy}","received_events_url":"https://api.github.com/users/AlessandroSigna/received_events","type":"User","site_admin":false},"repo":{"id":39265207,"name":"hifi","full_name":"AlessandroSigna/hifi","owner":{"login":"AlessandroSigna","id":13383505,"avatar_url":"https://avatars.githubusercontent.com/u/13383505?v=3","gravatar_id":"","url":"https://api.github.com/users/AlessandroSigna","html_url":"https://github.com/AlessandroSigna","followers_url":"https://api.github.com/users/AlessandroSigna/followers","following_url":"https://api.github.com/users/AlessandroSigna/following{/other_user}","gists_url":"https://api.github.com/users/AlessandroSigna/gists{/gist_id}","starred_url":"https://api.github.com/users/AlessandroSigna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlessandroSigna/subscriptions","organizations_url":"https://api.github.com/users/AlessandroSigna/orgs","repos_url":"https://api.github.com/users/AlessandroSigna/repos","events_url":"https://api.github.com/users/AlessandroSigna/events{/privacy}","received_events_url":"https://api.github.com/users/AlessandroSigna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlessandroSigna/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/AlessandroSigna/hifi","forks_url":"https://api.github.com/repos/AlessandroSigna/hifi/forks","keys_url":"https://api.github.com/repos/AlessandroSigna/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlessandroSigna/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlessandroSigna/hifi/teams","hooks_url":"https://api.github.com/repos/AlessandroSigna/hifi/hooks","issue_events_url":"https://api.github.com/repos/AlessandroSigna/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/AlessandroSigna/hifi/events","assignees_url":"https://api.github.com/repos/AlessandroSigna/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/AlessandroSigna/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/AlessandroSigna/hifi/tags","blobs_url":"https://api.github.com/repos/AlessandroSigna/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlessandroSigna/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlessandroSigna/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlessandroSigna/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlessandroSigna/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/AlessandroSigna/hifi/languages","stargazers_url":"https://api.github.com/repos/AlessandroSigna/hifi/stargazers","contributors_url":"https://api.github.com/repos/AlessandroSigna/hifi/contributors","subscribers_url":"https://api.github.com/repos/AlessandroSigna/hifi/subscribers","subscription_url":"https://api.github.com/repos/AlessandroSigna/hifi/subscription","commits_url":"https://api.github.com/repos/AlessandroSigna/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlessandroSigna/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlessandroSigna/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlessandroSigna/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlessandroSigna/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/AlessandroSigna/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlessandroSigna/hifi/merges","archive_url":"https://api.github.com/repos/AlessandroSigna/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlessandroSigna/hifi/downloads","issues_url":"https://api.github.com/repos/AlessandroSigna/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/AlessandroSigna/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/AlessandroSigna/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/AlessandroSigna/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlessandroSigna/hifi/labels{/name}","releases_url":"https://api.github.com/repos/AlessandroSigna/hifi/releases{/id}","created_at":"2015-07-17T16:57:36Z","updated_at":"2015-07-17T16:57:41Z","pushed_at":"2015-10-29T19:16:33Z","git_url":"git://github.com/AlessandroSigna/hifi.git","ssh_url":"git@github.com:AlessandroSigna/hifi.git","clone_url":"https://github.com/AlessandroSigna/hifi.git","svn_url":"https://github.com/AlessandroSigna/hifi","homepage":"","size":181479,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:controllers","ref":"controllers","sha":"ccbae81dad1c409afee191cead0975e687443431","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-10-29T19:23:43Z","pushed_at":"2015-10-29T20:12:21Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":251991,"stargazers_count":318,"watchers_count":318,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":67,"forks":186,"open_issues":67,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6223"},"html":{"href":"https://github.com/highfidelity/hifi/pull/6223"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6223"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/6223/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6223/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/6223/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/9165b21895863ac7947d0b8dc655f3337693271c"}}}}