{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/comments/45272033","id":45272033,"diff_hunk":"@@ -72,6 +83,86 @@\n     });\n   });\n \n+\n+\n+  // Backfill support for %-based dimensions in players. Includes copy/\n+  // pasted code from the `updateStyleEl_` method in video.js 5 because\n+  // that hard-codes px. :-/\n+  Player.prototype.dimension = function(dimension, value) {\n+\n+    // When the value is set as a %, bypass the usual handling.\n+    if (isPct(value)) {\n+      this[dimension + '_'] = value;\n+      this.updateStyleEl_();","path":"src/plugin.js","position":67,"original_position":67,"commit_id":"f9cc7fe8bb01bc5b3df93292a471163d49129345","original_commit_id":"f9cc7fe8bb01bc5b3df93292a471163d49129345","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"Yep, I meant make a local `updateStyleEl` and call it when needed but otherwise, there's no need to specifically override it.","created_at":"2015-11-18T22:39:34Z","updated_at":"2015-11-18T22:39:34Z","html_url":"https://github.com/videojs/videojs-4to5/pull/9#discussion_r45272033","pull_request_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/comments/45272033"},"html":{"href":"https://github.com/videojs/videojs-4to5/pull/9#discussion_r45272033"},"pull_request":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9","id":51149781,"html_url":"https://github.com/videojs/videojs-4to5/pull/9","diff_url":"https://github.com/videojs/videojs-4to5/pull/9.diff","patch_url":"https://github.com/videojs/videojs-4to5/pull/9.patch","issue_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/9","number":9,"state":"open","locked":false,"title":"Percent Dimensions","user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"body":"Beauty and horror are often two sides of the same coin.\r\n\r\nThis brings back support for non-standard percentage-based dimension attribute support for `<video>` elements.","created_at":"2015-11-18T22:08:16Z","updated_at":"2015-11-18T22:39:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1a88d7234080eeab84dac271bf938dea7af3a40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9/commits","review_comments_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9/comments","review_comment_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/9/comments","statuses_url":"https://api.github.com/repos/videojs/videojs-4to5/statuses/f9cc7fe8bb01bc5b3df93292a471163d49129345","head":{"label":"videojs:percent-dimensions","ref":"percent-dimensions","sha":"f9cc7fe8bb01bc5b3df93292a471163d49129345","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":43704726,"name":"videojs-4to5","full_name":"videojs/videojs-4to5","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-4to5","description":"Tools to ease the transition from video.js 4.x to 5.x.","fork":false,"url":"https://api.github.com/repos/videojs/videojs-4to5","forks_url":"https://api.github.com/repos/videojs/videojs-4to5/forks","keys_url":"https://api.github.com/repos/videojs/videojs-4to5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-4to5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-4to5/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-4to5/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-4to5/events","assignees_url":"https://api.github.com/repos/videojs/videojs-4to5/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-4to5/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-4to5/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-4to5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-4to5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-4to5/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-4to5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-4to5/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-4to5/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-4to5/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-4to5/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-4to5/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-4to5/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-4to5/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-4to5/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-4to5/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-4to5/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-4to5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-4to5/merges","archive_url":"https://api.github.com/repos/videojs/videojs-4to5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-4to5/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-4to5/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-4to5/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-4to5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-4to5/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-4to5/releases{/id}","created_at":"2015-10-05T18:23:08Z","updated_at":"2015-11-17T20:45:57Z","pushed_at":"2015-11-18T22:11:17Z","git_url":"git://github.com/videojs/videojs-4to5.git","ssh_url":"git@github.com:videojs/videojs-4to5.git","clone_url":"https://github.com/videojs/videojs-4to5.git","svn_url":"https://github.com/videojs/videojs-4to5","homepage":"","size":57,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"6442b2d36768fcd546892e563f2462f8acaa727d","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":43704726,"name":"videojs-4to5","full_name":"videojs/videojs-4to5","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/videojs-4to5","description":"Tools to ease the transition from video.js 4.x to 5.x.","fork":false,"url":"https://api.github.com/repos/videojs/videojs-4to5","forks_url":"https://api.github.com/repos/videojs/videojs-4to5/forks","keys_url":"https://api.github.com/repos/videojs/videojs-4to5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/videojs-4to5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/videojs-4to5/teams","hooks_url":"https://api.github.com/repos/videojs/videojs-4to5/hooks","issue_events_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/videojs-4to5/events","assignees_url":"https://api.github.com/repos/videojs/videojs-4to5/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/videojs-4to5/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/videojs-4to5/tags","blobs_url":"https://api.github.com/repos/videojs/videojs-4to5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/videojs-4to5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/videojs-4to5/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/videojs-4to5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/videojs-4to5/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/videojs-4to5/languages","stargazers_url":"https://api.github.com/repos/videojs/videojs-4to5/stargazers","contributors_url":"https://api.github.com/repos/videojs/videojs-4to5/contributors","subscribers_url":"https://api.github.com/repos/videojs/videojs-4to5/subscribers","subscription_url":"https://api.github.com/repos/videojs/videojs-4to5/subscription","commits_url":"https://api.github.com/repos/videojs/videojs-4to5/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/videojs-4to5/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/videojs-4to5/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/videojs-4to5/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/videojs-4to5/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/videojs-4to5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/videojs-4to5/merges","archive_url":"https://api.github.com/repos/videojs/videojs-4to5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/videojs-4to5/downloads","issues_url":"https://api.github.com/repos/videojs/videojs-4to5/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/videojs-4to5/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/videojs-4to5/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/videojs-4to5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/videojs-4to5/labels{/name}","releases_url":"https://api.github.com/repos/videojs/videojs-4to5/releases{/id}","created_at":"2015-10-05T18:23:08Z","updated_at":"2015-11-17T20:45:57Z","pushed_at":"2015-11-18T22:11:17Z","git_url":"git://github.com/videojs/videojs-4to5.git","ssh_url":"git@github.com:videojs/videojs-4to5.git","clone_url":"https://github.com/videojs/videojs-4to5.git","svn_url":"https://github.com/videojs/videojs-4to5","homepage":"","size":57,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9"},"html":{"href":"https://github.com/videojs/videojs-4to5/pull/9"},"issue":{"href":"https://api.github.com/repos/videojs/videojs-4to5/issues/9"},"comments":{"href":"https://api.github.com/repos/videojs/videojs-4to5/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/videojs-4to5/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/videojs-4to5/statuses/f9cc7fe8bb01bc5b3df93292a471163d49129345"}}}}