{"action":"created","comment":{"url":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments/47894603","id":47894603,"diff_hunk":"@@ -0,0 +1,31 @@\n+package com.kryptnostic.v2.crypto;\n+\n+import java.util.Map;\n+import java.util.Set;\n+import java.util.UUID;\n+import java.util.concurrent.ExecutionException;\n+\n+import javax.annotation.Nonnull;\n+\n+import com.google.common.base.Optional;\n+import com.kryptnostic.kodex.v1.crypto.ciphers.CryptoService;\n+import com.kryptnostic.kodex.v1.crypto.ciphers.Cypher;\n+import com.kryptnostic.v2.storage.models.VersionedObjectKey;\n+\n+public interface CryptoServiceLoader {\n+\n+    @Nonnull\n+    Optional<CryptoService> get( VersionedObjectKey id ) throws ExecutionException;","path":"src/main/java/com/kryptnostic/v2/crypto/CryptoServiceLoader.java","position":18,"original_position":18,"commit_id":"97b8784f68bfafff55e59653fdb0b1e3d894ad65","original_commit_id":"97b8784f68bfafff55e59653fdb0b1e3d894ad65","user":{"login":"geekbeast","id":3698721,"avatar_url":"https://avatars.githubusercontent.com/u/3698721?v=3","gravatar_id":"","url":"https://api.github.com/users/geekbeast","html_url":"https://github.com/geekbeast","followers_url":"https://api.github.com/users/geekbeast/followers","following_url":"https://api.github.com/users/geekbeast/following{/other_user}","gists_url":"https://api.github.com/users/geekbeast/gists{/gist_id}","starred_url":"https://api.github.com/users/geekbeast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekbeast/subscriptions","organizations_url":"https://api.github.com/users/geekbeast/orgs","repos_url":"https://api.github.com/users/geekbeast/repos","events_url":"https://api.github.com/users/geekbeast/events{/privacy}","received_events_url":"https://api.github.com/users/geekbeast/received_events","type":"User","site_admin":false},"body":"No throws in retrofit interfaces. CryptoServiceLoader is fine since it's a client only class.","created_at":"2015-12-17T11:17:52Z","updated_at":"2015-12-17T11:17:52Z","html_url":"https://github.com/kryptnostic/kodex/pull/123#discussion_r47894603","pull_request_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments/47894603"},"html":{"href":"https://github.com/kryptnostic/kodex/pull/123#discussion_r47894603"},"pull_request":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/kryptnostic/kodex/pulls/123","id":53041100,"html_url":"https://github.com/kryptnostic/kodex/pull/123","diff_url":"https://github.com/kryptnostic/kodex/pull/123.diff","patch_url":"https://github.com/kryptnostic/kodex/pull/123.patch","issue_url":"https://api.github.com/repos/kryptnostic/kodex/issues/123","number":123,"state":"closed","locked":false,"title":"Feature/forth eorlingas","user":{"login":"makosblade","id":336506,"avatar_url":"https://avatars.githubusercontent.com/u/336506?v=3","gravatar_id":"","url":"https://api.github.com/users/makosblade","html_url":"https://github.com/makosblade","followers_url":"https://api.github.com/users/makosblade/followers","following_url":"https://api.github.com/users/makosblade/following{/other_user}","gists_url":"https://api.github.com/users/makosblade/gists{/gist_id}","starred_url":"https://api.github.com/users/makosblade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makosblade/subscriptions","organizations_url":"https://api.github.com/users/makosblade/orgs","repos_url":"https://api.github.com/users/makosblade/repos","events_url":"https://api.github.com/users/makosblade/events{/privacy}","received_events_url":"https://api.github.com/users/makosblade/received_events","type":"User","site_admin":false},"body":"The end is nigh","created_at":"2015-12-08T21:28:01Z","updated_at":"2015-12-17T11:17:52Z","closed_at":"2015-12-16T11:24:12Z","merged_at":"2015-12-16T11:24:12Z","merge_commit_sha":"d20115c6c690ba36ed9112eb3169689486844951","assignee":{"login":"geekbeast","id":3698721,"avatar_url":"https://avatars.githubusercontent.com/u/3698721?v=3","gravatar_id":"","url":"https://api.github.com/users/geekbeast","html_url":"https://github.com/geekbeast","followers_url":"https://api.github.com/users/geekbeast/followers","following_url":"https://api.github.com/users/geekbeast/following{/other_user}","gists_url":"https://api.github.com/users/geekbeast/gists{/gist_id}","starred_url":"https://api.github.com/users/geekbeast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekbeast/subscriptions","organizations_url":"https://api.github.com/users/geekbeast/orgs","repos_url":"https://api.github.com/users/geekbeast/repos","events_url":"https://api.github.com/users/geekbeast/events{/privacy}","received_events_url":"https://api.github.com/users/geekbeast/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/123/commits","review_comments_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/123/comments","review_comment_url":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/issues/123/comments","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/97b8784f68bfafff55e59653fdb0b1e3d894ad65","head":{"label":"kryptnostic:feature/forth-eorlingas","ref":"feature/forth-eorlingas","sha":"97b8784f68bfafff55e59653fdb0b1e3d894ad65","user":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"repo":{"id":23140778,"name":"kodex","full_name":"kryptnostic/kodex","owner":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kryptnostic/kodex","description":"API and Models for talking with Kryptnostic backend services","fork":false,"url":"https://api.github.com/repos/kryptnostic/kodex","forks_url":"https://api.github.com/repos/kryptnostic/kodex/forks","keys_url":"https://api.github.com/repos/kryptnostic/kodex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kryptnostic/kodex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kryptnostic/kodex/teams","hooks_url":"https://api.github.com/repos/kryptnostic/kodex/hooks","issue_events_url":"https://api.github.com/repos/kryptnostic/kodex/issues/events{/number}","events_url":"https://api.github.com/repos/kryptnostic/kodex/events","assignees_url":"https://api.github.com/repos/kryptnostic/kodex/assignees{/user}","branches_url":"https://api.github.com/repos/kryptnostic/kodex/branches{/branch}","tags_url":"https://api.github.com/repos/kryptnostic/kodex/tags","blobs_url":"https://api.github.com/repos/kryptnostic/kodex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kryptnostic/kodex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kryptnostic/kodex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kryptnostic/kodex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/{sha}","languages_url":"https://api.github.com/repos/kryptnostic/kodex/languages","stargazers_url":"https://api.github.com/repos/kryptnostic/kodex/stargazers","contributors_url":"https://api.github.com/repos/kryptnostic/kodex/contributors","subscribers_url":"https://api.github.com/repos/kryptnostic/kodex/subscribers","subscription_url":"https://api.github.com/repos/kryptnostic/kodex/subscription","commits_url":"https://api.github.com/repos/kryptnostic/kodex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kryptnostic/kodex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kryptnostic/kodex/issues/comments{/number}","contents_url":"https://api.github.com/repos/kryptnostic/kodex/contents/{+path}","compare_url":"https://api.github.com/repos/kryptnostic/kodex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kryptnostic/kodex/merges","archive_url":"https://api.github.com/repos/kryptnostic/kodex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kryptnostic/kodex/downloads","issues_url":"https://api.github.com/repos/kryptnostic/kodex/issues{/number}","pulls_url":"https://api.github.com/repos/kryptnostic/kodex/pulls{/number}","milestones_url":"https://api.github.com/repos/kryptnostic/kodex/milestones{/number}","notifications_url":"https://api.github.com/repos/kryptnostic/kodex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kryptnostic/kodex/labels{/name}","releases_url":"https://api.github.com/repos/kryptnostic/kodex/releases{/id}","created_at":"2014-08-20T08:01:31Z","updated_at":"2015-10-20T06:56:21Z","pushed_at":"2015-12-17T07:33:14Z","git_url":"git://github.com/kryptnostic/kodex.git","ssh_url":"git@github.com:kryptnostic/kodex.git","clone_url":"https://github.com/kryptnostic/kodex.git","svn_url":"https://github.com/kryptnostic/kodex","homepage":null,"size":1119,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"kryptnostic:develop","ref":"develop","sha":"f99744f817d633c5634700d8c1a290afa660dca7","user":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"repo":{"id":23140778,"name":"kodex","full_name":"kryptnostic/kodex","owner":{"login":"kryptnostic","id":5438547,"avatar_url":"https://avatars.githubusercontent.com/u/5438547?v=3","gravatar_id":"","url":"https://api.github.com/users/kryptnostic","html_url":"https://github.com/kryptnostic","followers_url":"https://api.github.com/users/kryptnostic/followers","following_url":"https://api.github.com/users/kryptnostic/following{/other_user}","gists_url":"https://api.github.com/users/kryptnostic/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptnostic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptnostic/subscriptions","organizations_url":"https://api.github.com/users/kryptnostic/orgs","repos_url":"https://api.github.com/users/kryptnostic/repos","events_url":"https://api.github.com/users/kryptnostic/events{/privacy}","received_events_url":"https://api.github.com/users/kryptnostic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kryptnostic/kodex","description":"API and Models for talking with Kryptnostic backend services","fork":false,"url":"https://api.github.com/repos/kryptnostic/kodex","forks_url":"https://api.github.com/repos/kryptnostic/kodex/forks","keys_url":"https://api.github.com/repos/kryptnostic/kodex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kryptnostic/kodex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kryptnostic/kodex/teams","hooks_url":"https://api.github.com/repos/kryptnostic/kodex/hooks","issue_events_url":"https://api.github.com/repos/kryptnostic/kodex/issues/events{/number}","events_url":"https://api.github.com/repos/kryptnostic/kodex/events","assignees_url":"https://api.github.com/repos/kryptnostic/kodex/assignees{/user}","branches_url":"https://api.github.com/repos/kryptnostic/kodex/branches{/branch}","tags_url":"https://api.github.com/repos/kryptnostic/kodex/tags","blobs_url":"https://api.github.com/repos/kryptnostic/kodex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kryptnostic/kodex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kryptnostic/kodex/git/refs{/sha}","trees_url":"https://api.github.com/repos/kryptnostic/kodex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kryptnostic/kodex/statuses/{sha}","languages_url":"https://api.github.com/repos/kryptnostic/kodex/languages","stargazers_url":"https://api.github.com/repos/kryptnostic/kodex/stargazers","contributors_url":"https://api.github.com/repos/kryptnostic/kodex/contributors","subscribers_url":"https://api.github.com/repos/kryptnostic/kodex/subscribers","subscription_url":"https://api.github.com/repos/kryptnostic/kodex/subscription","commits_url":"https://api.github.com/repos/kryptnostic/kodex/commits{/sha}","git_commits_url":"https://api.github.com/repos/kryptnostic/kodex/git/commits{/sha}","comments_url":"https://api.github.com/repos/kryptnostic/kodex/comments{/number}","issue_comment_url":"https://api.github.com/repos/kryptnostic/kodex/issues/comments{/number}","contents_url":"https://api.github.com/repos/kryptnostic/kodex/contents/{+path}","compare_url":"https://api.github.com/repos/kryptnostic/kodex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kryptnostic/kodex/merges","archive_url":"https://api.github.com/repos/kryptnostic/kodex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kryptnostic/kodex/downloads","issues_url":"https://api.github.com/repos/kryptnostic/kodex/issues{/number}","pulls_url":"https://api.github.com/repos/kryptnostic/kodex/pulls{/number}","milestones_url":"https://api.github.com/repos/kryptnostic/kodex/milestones{/number}","notifications_url":"https://api.github.com/repos/kryptnostic/kodex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kryptnostic/kodex/labels{/name}","releases_url":"https://api.github.com/repos/kryptnostic/kodex/releases{/id}","created_at":"2014-08-20T08:01:31Z","updated_at":"2015-10-20T06:56:21Z","pushed_at":"2015-12-17T07:33:14Z","git_url":"git://github.com/kryptnostic/kodex.git","ssh_url":"git@github.com:kryptnostic/kodex.git","clone_url":"https://github.com/kryptnostic/kodex.git","svn_url":"https://github.com/kryptnostic/kodex","homepage":null,"size":1119,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/123"},"html":{"href":"https://github.com/kryptnostic/kodex/pull/123"},"issue":{"href":"https://api.github.com/repos/kryptnostic/kodex/issues/123"},"comments":{"href":"https://api.github.com/repos/kryptnostic/kodex/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kryptnostic/kodex/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/kryptnostic/kodex/statuses/97b8784f68bfafff55e59653fdb0b1e3d894ad65"}}}}