{"action":"closed","number":928,"pull_request":{"url":"https://api.github.com/repos/selendroid/selendroid/pulls/928","id":38820418,"html_url":"https://github.com/selendroid/selendroid/pull/928","diff_url":"https://github.com/selendroid/selendroid/pull/928.diff","patch_url":"https://github.com/selendroid/selendroid/pull/928.patch","issue_url":"https://api.github.com/repos/selendroid/selendroid/issues/928","number":928,"state":"closed","locked":false,"title":"[standalone] Fix HTTP response for unknown commands","user":{"login":"asm89","id":657357,"avatar_url":"https://avatars.githubusercontent.com/u/657357?v=3","gravatar_id":"","url":"https://api.github.com/users/asm89","html_url":"https://github.com/asm89","followers_url":"https://api.github.com/users/asm89/followers","following_url":"https://api.github.com/users/asm89/following{/other_user}","gists_url":"https://api.github.com/users/asm89/gists{/gist_id}","starred_url":"https://api.github.com/users/asm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asm89/subscriptions","organizations_url":"https://api.github.com/users/asm89/orgs","repos_url":"https://api.github.com/users/asm89/repos","events_url":"https://api.github.com/users/asm89/events{/privacy}","received_events_url":"https://api.github.com/users/asm89/received_events","type":"User","site_admin":false},"body":"Summary: Before this fix the selendroid standalone server would proxy\r\nany command to the server on the device. The server on the device would\r\nreturn `404 Not Found`. The standalone server then failed to deserialize\r\nthat string as JSON and actually ended up retrying proxying the command\r\nto the device three times.\r\n\r\nTest Plan: Create a new session and try to query existing and\r\nnon-existing endpoints:\r\n\r\n```\r\n$ curl localhost:4444/wd/hub/session/8fbdf5e5-bc39-7012-09f8-0417acdf6916/foo\r\n{\"status\":0,\"sessionId\":\"8fbdf5e5-bc39-7012-09f8-0417acdf6916\",\"value\":\"UNKNOWN_COMMAND\"}\r\n$ curl localhost:4444/wd/hub/session/8fbdf5e5-bc39-7012-09f8-0417acdf6916/\r\n{\"status\":0,\"sessionId\":\"8fbdf5e5-bc39-7012-09f8-0417acdf6916\",...}\r\n$ curl -XPOST localhost:4444/wd/hub/session/8fbdf5e5-bc39-7012-09f8-0417acdf6916/log\r\n{\"status\":0,\"sessionId\":\"8fbdf5e5-bc39-7012-09f8-0417acdf6916\",\"value\":[\"[2015-0...}\r\n```","created_at":"2015-06-29T21:36:25Z","updated_at":"2015-06-30T19:59:42Z","closed_at":"2015-06-30T19:59:42Z","merged_at":"2015-06-30T19:59:42Z","merge_commit_sha":"08dcf30216c6181d5b210e2fdd981288bed42a46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/selendroid/selendroid/pulls/928/commits","review_comments_url":"https://api.github.com/repos/selendroid/selendroid/pulls/928/comments","review_comment_url":"https://api.github.com/repos/selendroid/selendroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/selendroid/selendroid/issues/928/comments","statuses_url":"https://api.github.com/repos/selendroid/selendroid/statuses/d9fabce1ab734222d9befa7e325665f004167bca","head":{"label":"asm89:fix-http-response-for-unknown-commands","ref":"fix-http-response-for-unknown-commands","sha":"d9fabce1ab734222d9befa7e325665f004167bca","user":{"login":"asm89","id":657357,"avatar_url":"https://avatars.githubusercontent.com/u/657357?v=3","gravatar_id":"","url":"https://api.github.com/users/asm89","html_url":"https://github.com/asm89","followers_url":"https://api.github.com/users/asm89/followers","following_url":"https://api.github.com/users/asm89/following{/other_user}","gists_url":"https://api.github.com/users/asm89/gists{/gist_id}","starred_url":"https://api.github.com/users/asm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asm89/subscriptions","organizations_url":"https://api.github.com/users/asm89/orgs","repos_url":"https://api.github.com/users/asm89/repos","events_url":"https://api.github.com/users/asm89/events{/privacy}","received_events_url":"https://api.github.com/users/asm89/received_events","type":"User","site_admin":false},"repo":{"id":35555344,"name":"selendroid","full_name":"asm89/selendroid","owner":{"login":"asm89","id":657357,"avatar_url":"https://avatars.githubusercontent.com/u/657357?v=3","gravatar_id":"","url":"https://api.github.com/users/asm89","html_url":"https://github.com/asm89","followers_url":"https://api.github.com/users/asm89/followers","following_url":"https://api.github.com/users/asm89/following{/other_user}","gists_url":"https://api.github.com/users/asm89/gists{/gist_id}","starred_url":"https://api.github.com/users/asm89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asm89/subscriptions","organizations_url":"https://api.github.com/users/asm89/orgs","repos_url":"https://api.github.com/users/asm89/repos","events_url":"https://api.github.com/users/asm89/events{/privacy}","received_events_url":"https://api.github.com/users/asm89/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asm89/selendroid","description":"\"Selenium for Android\" (Test automate native or hybrid Android apps and the mobile web with Selendroid.) Join us on IRC #selendroid on freenode. Also confirm you have signed the CLA http://goo.gl/pAvxEI when making a Pull Request.","fork":true,"url":"https://api.github.com/repos/asm89/selendroid","forks_url":"https://api.github.com/repos/asm89/selendroid/forks","keys_url":"https://api.github.com/repos/asm89/selendroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asm89/selendroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asm89/selendroid/teams","hooks_url":"https://api.github.com/repos/asm89/selendroid/hooks","issue_events_url":"https://api.github.com/repos/asm89/selendroid/issues/events{/number}","events_url":"https://api.github.com/repos/asm89/selendroid/events","assignees_url":"https://api.github.com/repos/asm89/selendroid/assignees{/user}","branches_url":"https://api.github.com/repos/asm89/selendroid/branches{/branch}","tags_url":"https://api.github.com/repos/asm89/selendroid/tags","blobs_url":"https://api.github.com/repos/asm89/selendroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asm89/selendroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asm89/selendroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/asm89/selendroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asm89/selendroid/statuses/{sha}","languages_url":"https://api.github.com/repos/asm89/selendroid/languages","stargazers_url":"https://api.github.com/repos/asm89/selendroid/stargazers","contributors_url":"https://api.github.com/repos/asm89/selendroid/contributors","subscribers_url":"https://api.github.com/repos/asm89/selendroid/subscribers","subscription_url":"https://api.github.com/repos/asm89/selendroid/subscription","commits_url":"https://api.github.com/repos/asm89/selendroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/asm89/selendroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/asm89/selendroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/asm89/selendroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/asm89/selendroid/contents/{+path}","compare_url":"https://api.github.com/repos/asm89/selendroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asm89/selendroid/merges","archive_url":"https://api.github.com/repos/asm89/selendroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asm89/selendroid/downloads","issues_url":"https://api.github.com/repos/asm89/selendroid/issues{/number}","pulls_url":"https://api.github.com/repos/asm89/selendroid/pulls{/number}","milestones_url":"https://api.github.com/repos/asm89/selendroid/milestones{/number}","notifications_url":"https://api.github.com/repos/asm89/selendroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asm89/selendroid/labels{/name}","releases_url":"https://api.github.com/repos/asm89/selendroid/releases{/id}","created_at":"2015-05-13T14:54:45Z","updated_at":"2015-05-13T14:54:47Z","pushed_at":"2015-06-30T19:44:47Z","git_url":"git://github.com/asm89/selendroid.git","ssh_url":"git@github.com:asm89/selendroid.git","clone_url":"https://github.com/asm89/selendroid.git","svn_url":"https://github.com/asm89/selendroid","homepage":"http://selendroid.io","size":15273,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"selendroid:master","ref":"master","sha":"965a0b879ba184b8269411f96afb4e8b340d4ccf","user":{"login":"selendroid","id":3197580,"avatar_url":"https://avatars.githubusercontent.com/u/3197580?v=3","gravatar_id":"","url":"https://api.github.com/users/selendroid","html_url":"https://github.com/selendroid","followers_url":"https://api.github.com/users/selendroid/followers","following_url":"https://api.github.com/users/selendroid/following{/other_user}","gists_url":"https://api.github.com/users/selendroid/gists{/gist_id}","starred_url":"https://api.github.com/users/selendroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selendroid/subscriptions","organizations_url":"https://api.github.com/users/selendroid/orgs","repos_url":"https://api.github.com/users/selendroid/repos","events_url":"https://api.github.com/users/selendroid/events{/privacy}","received_events_url":"https://api.github.com/users/selendroid/received_events","type":"Organization","site_admin":false},"repo":{"id":7465720,"name":"selendroid","full_name":"selendroid/selendroid","owner":{"login":"selendroid","id":3197580,"avatar_url":"https://avatars.githubusercontent.com/u/3197580?v=3","gravatar_id":"","url":"https://api.github.com/users/selendroid","html_url":"https://github.com/selendroid","followers_url":"https://api.github.com/users/selendroid/followers","following_url":"https://api.github.com/users/selendroid/following{/other_user}","gists_url":"https://api.github.com/users/selendroid/gists{/gist_id}","starred_url":"https://api.github.com/users/selendroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selendroid/subscriptions","organizations_url":"https://api.github.com/users/selendroid/orgs","repos_url":"https://api.github.com/users/selendroid/repos","events_url":"https://api.github.com/users/selendroid/events{/privacy}","received_events_url":"https://api.github.com/users/selendroid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/selendroid/selendroid","description":"\"Selenium for Android\" (Test automate native or hybrid Android apps and the mobile web with Selendroid.) Join us on IRC #selendroid on freenode. Also confirm you have signed the CLA http://goo.gl/pAvxEI when making a Pull Request.","fork":false,"url":"https://api.github.com/repos/selendroid/selendroid","forks_url":"https://api.github.com/repos/selendroid/selendroid/forks","keys_url":"https://api.github.com/repos/selendroid/selendroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selendroid/selendroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selendroid/selendroid/teams","hooks_url":"https://api.github.com/repos/selendroid/selendroid/hooks","issue_events_url":"https://api.github.com/repos/selendroid/selendroid/issues/events{/number}","events_url":"https://api.github.com/repos/selendroid/selendroid/events","assignees_url":"https://api.github.com/repos/selendroid/selendroid/assignees{/user}","branches_url":"https://api.github.com/repos/selendroid/selendroid/branches{/branch}","tags_url":"https://api.github.com/repos/selendroid/selendroid/tags","blobs_url":"https://api.github.com/repos/selendroid/selendroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selendroid/selendroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selendroid/selendroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/selendroid/selendroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selendroid/selendroid/statuses/{sha}","languages_url":"https://api.github.com/repos/selendroid/selendroid/languages","stargazers_url":"https://api.github.com/repos/selendroid/selendroid/stargazers","contributors_url":"https://api.github.com/repos/selendroid/selendroid/contributors","subscribers_url":"https://api.github.com/repos/selendroid/selendroid/subscribers","subscription_url":"https://api.github.com/repos/selendroid/selendroid/subscription","commits_url":"https://api.github.com/repos/selendroid/selendroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/selendroid/selendroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/selendroid/selendroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/selendroid/selendroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/selendroid/selendroid/contents/{+path}","compare_url":"https://api.github.com/repos/selendroid/selendroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selendroid/selendroid/merges","archive_url":"https://api.github.com/repos/selendroid/selendroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selendroid/selendroid/downloads","issues_url":"https://api.github.com/repos/selendroid/selendroid/issues{/number}","pulls_url":"https://api.github.com/repos/selendroid/selendroid/pulls{/number}","milestones_url":"https://api.github.com/repos/selendroid/selendroid/milestones{/number}","notifications_url":"https://api.github.com/repos/selendroid/selendroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selendroid/selendroid/labels{/name}","releases_url":"https://api.github.com/repos/selendroid/selendroid/releases{/id}","created_at":"2013-01-06T08:29:32Z","updated_at":"2015-06-29T18:05:43Z","pushed_at":"2015-06-30T19:59:42Z","git_url":"git://github.com/selendroid/selendroid.git","ssh_url":"git@github.com:selendroid/selendroid.git","clone_url":"https://github.com/selendroid/selendroid.git","svn_url":"https://github.com/selendroid/selendroid","homepage":"http://selendroid.io","size":20288,"stargazers_count":363,"watchers_count":363,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":13,"forks":239,"open_issues":13,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/selendroid/selendroid/pulls/928"},"html":{"href":"https://github.com/selendroid/selendroid/pull/928"},"issue":{"href":"https://api.github.com/repos/selendroid/selendroid/issues/928"},"comments":{"href":"https://api.github.com/repos/selendroid/selendroid/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/selendroid/selendroid/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/selendroid/selendroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/selendroid/selendroid/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/selendroid/selendroid/statuses/d9fabce1ab734222d9befa7e325665f004167bca"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lukeis","id":926454,"avatar_url":"https://avatars.githubusercontent.com/u/926454?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeis","html_url":"https://github.com/lukeis","followers_url":"https://api.github.com/users/lukeis/followers","following_url":"https://api.github.com/users/lukeis/following{/other_user}","gists_url":"https://api.github.com/users/lukeis/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeis/subscriptions","organizations_url":"https://api.github.com/users/lukeis/orgs","repos_url":"https://api.github.com/users/lukeis/repos","events_url":"https://api.github.com/users/lukeis/events{/privacy}","received_events_url":"https://api.github.com/users/lukeis/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":1,"additions":6,"deletions":0,"changed_files":1}}