{"action":"created","comment":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/33122873","id":33122873,"diff_hunk":"@@ -45,13 +45,10 @@ public static function outputCSV($filename, array $array, array $columns = null,\n \n         // set headers for download\n         $charset = BackendModel::getContainer()->getParameter('kernel.charset');\n-        $headers[] = 'Content-type: application/csv; charset=' . $charset;\n-        $headers[] = 'Content-Disposition: attachment; filename=\"' . $filename;\n-        $headers[] = 'Content-Length: ' . strlen($csv);\n-        $headers[] = 'Pragma: no-cache';\n-\n-        // overwrite the headers\n-        \\SpoonHTTP::setHeaders($headers);\n+        header('Content-type: application/csv; charset=' . $charset);\n+        header('Content-Disposition: attachment; filename=\"' . $filename);","path":"src/Backend/Core/Engine/Csv.php","position":12,"original_position":12,"commit_id":"90e5652724d74569745a58b59f7bae6c0d8145a4","original_commit_id":"90e5652724d74569745a58b59f7bae6c0d8145a4","user":{"login":"WouterSioen","id":1398405,"avatar_url":"https://avatars.githubusercontent.com/u/1398405?v=3","gravatar_id":"","url":"https://api.github.com/users/WouterSioen","html_url":"https://github.com/WouterSioen","followers_url":"https://api.github.com/users/WouterSioen/followers","following_url":"https://api.github.com/users/WouterSioen/following{/other_user}","gists_url":"https://api.github.com/users/WouterSioen/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterSioen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterSioen/subscriptions","organizations_url":"https://api.github.com/users/WouterSioen/orgs","repos_url":"https://api.github.com/users/WouterSioen/repos","events_url":"https://api.github.com/users/WouterSioen/events{/privacy}","received_events_url":"https://api.github.com/users/WouterSioen/received_events","type":"User","site_admin":false},"body":"you miss a quote `\"` after your filename","created_at":"2015-06-24T07:21:26Z","updated_at":"2015-06-24T07:21:26Z","html_url":"https://github.com/forkcms/forkcms/pull/1230#discussion_r33122873","pull_request_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1230","_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments/33122873"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1230#discussion_r33122873"},"pull_request":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1230"}}},"pull_request":{"url":"https://api.github.com/repos/forkcms/forkcms/pulls/1230","id":37143858,"html_url":"https://github.com/forkcms/forkcms/pull/1230","diff_url":"https://github.com/forkcms/forkcms/pull/1230.diff","patch_url":"https://github.com/forkcms/forkcms/pull/1230.patch","issue_url":"https://api.github.com/repos/forkcms/forkcms/issues/1230","number":1230,"state":"open","locked":false,"title":"Remove SpoonHTTP","user":{"login":"tijsverkoyen","id":250042,"avatar_url":"https://avatars.githubusercontent.com/u/250042?v=3","gravatar_id":"","url":"https://api.github.com/users/tijsverkoyen","html_url":"https://github.com/tijsverkoyen","followers_url":"https://api.github.com/users/tijsverkoyen/followers","following_url":"https://api.github.com/users/tijsverkoyen/following{/other_user}","gists_url":"https://api.github.com/users/tijsverkoyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tijsverkoyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijsverkoyen/subscriptions","organizations_url":"https://api.github.com/users/tijsverkoyen/orgs","repos_url":"https://api.github.com/users/tijsverkoyen/repos","events_url":"https://api.github.com/users/tijsverkoyen/events{/privacy}","received_events_url":"https://api.github.com/users/tijsverkoyen/received_events","type":"User","site_admin":false},"body":"As you all know Spoon isn't supported anymore, therefore we are trying to \r\nreplace all functionality that was provided by Spoon with SYmfony-functionality\r\nor native code. \r\n\r\nWith this upgrade we have replaced all functionality provided with SpoonHTTP. \r\nThere are several methods, each one is discussed below.\r\n\r\n* [x] SpoonHTTP::getContent()\r\n* [x] SpoonHTTP::getHeadersList()\r\n* [x] SpoonHTTP::getIp()\r\n* [x] SpoonHTTP::redirect()\r\n* [x] SpoonHTTP::setHeaders()\r\n* [x] SpoonHTTP::setHeadersByCode()\r\n\r\nThis will fix https://github.com/forkcms/forkcms/issues/1224","created_at":"2015-06-08T11:27:01Z","updated_at":"2015-06-24T07:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"786da919c0c1e4a3c1bc0f68edead9b2667328a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1230/commits","review_comments_url":"https://api.github.com/repos/forkcms/forkcms/pulls/1230/comments","review_comment_url":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forkcms/forkcms/issues/1230/comments","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/90e5652724d74569745a58b59f7bae6c0d8145a4","head":{"label":"forkcms:removed-spoonhttp","ref":"removed-spoonhttp","sha":"90e5652724d74569745a58b59f7bae6c0d8145a4","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an open source CMS.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","created_at":"2010-12-04T18:06:15Z","updated_at":"2015-06-22T05:52:42Z","pushed_at":"2015-06-23T14:28:55Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":65490,"stargazers_count":871,"watchers_count":871,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":null,"open_issues_count":66,"forks":237,"open_issues":66,"watchers":871,"default_branch":"master"}},"base":{"label":"forkcms:master","ref":"master","sha":"03f4559755c0fbce44557e911fe72196cf02e645","user":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"repo":{"id":1138583,"name":"forkcms","full_name":"forkcms/forkcms","owner":{"login":"forkcms","id":312505,"avatar_url":"https://avatars.githubusercontent.com/u/312505?v=3","gravatar_id":"","url":"https://api.github.com/users/forkcms","html_url":"https://github.com/forkcms","followers_url":"https://api.github.com/users/forkcms/followers","following_url":"https://api.github.com/users/forkcms/following{/other_user}","gists_url":"https://api.github.com/users/forkcms/gists{/gist_id}","starred_url":"https://api.github.com/users/forkcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forkcms/subscriptions","organizations_url":"https://api.github.com/users/forkcms/orgs","repos_url":"https://api.github.com/users/forkcms/repos","events_url":"https://api.github.com/users/forkcms/events{/privacy}","received_events_url":"https://api.github.com/users/forkcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forkcms/forkcms","description":"Fork is an open source CMS.","fork":false,"url":"https://api.github.com/repos/forkcms/forkcms","forks_url":"https://api.github.com/repos/forkcms/forkcms/forks","keys_url":"https://api.github.com/repos/forkcms/forkcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forkcms/forkcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forkcms/forkcms/teams","hooks_url":"https://api.github.com/repos/forkcms/forkcms/hooks","issue_events_url":"https://api.github.com/repos/forkcms/forkcms/issues/events{/number}","events_url":"https://api.github.com/repos/forkcms/forkcms/events","assignees_url":"https://api.github.com/repos/forkcms/forkcms/assignees{/user}","branches_url":"https://api.github.com/repos/forkcms/forkcms/branches{/branch}","tags_url":"https://api.github.com/repos/forkcms/forkcms/tags","blobs_url":"https://api.github.com/repos/forkcms/forkcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forkcms/forkcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forkcms/forkcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/forkcms/forkcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forkcms/forkcms/statuses/{sha}","languages_url":"https://api.github.com/repos/forkcms/forkcms/languages","stargazers_url":"https://api.github.com/repos/forkcms/forkcms/stargazers","contributors_url":"https://api.github.com/repos/forkcms/forkcms/contributors","subscribers_url":"https://api.github.com/repos/forkcms/forkcms/subscribers","subscription_url":"https://api.github.com/repos/forkcms/forkcms/subscription","commits_url":"https://api.github.com/repos/forkcms/forkcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/forkcms/forkcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/forkcms/forkcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/forkcms/forkcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/forkcms/forkcms/contents/{+path}","compare_url":"https://api.github.com/repos/forkcms/forkcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forkcms/forkcms/merges","archive_url":"https://api.github.com/repos/forkcms/forkcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forkcms/forkcms/downloads","issues_url":"https://api.github.com/repos/forkcms/forkcms/issues{/number}","pulls_url":"https://api.github.com/repos/forkcms/forkcms/pulls{/number}","milestones_url":"https://api.github.com/repos/forkcms/forkcms/milestones{/number}","notifications_url":"https://api.github.com/repos/forkcms/forkcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forkcms/forkcms/labels{/name}","releases_url":"https://api.github.com/repos/forkcms/forkcms/releases{/id}","created_at":"2010-12-04T18:06:15Z","updated_at":"2015-06-22T05:52:42Z","pushed_at":"2015-06-23T14:28:55Z","git_url":"git://github.com/forkcms/forkcms.git","ssh_url":"git@github.com:forkcms/forkcms.git","clone_url":"https://github.com/forkcms/forkcms.git","svn_url":"https://github.com/forkcms/forkcms","homepage":"http://www.fork-cms.com","size":65490,"stargazers_count":871,"watchers_count":871,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":null,"open_issues_count":66,"forks":237,"open_issues":66,"watchers":871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1230"},"html":{"href":"https://github.com/forkcms/forkcms/pull/1230"},"issue":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1230"},"comments":{"href":"https://api.github.com/repos/forkcms/forkcms/issues/1230/comments"},"review_comments":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1230/comments"},"review_comment":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forkcms/forkcms/pulls/1230/commits"},"statuses":{"href":"https://api.github.com/repos/forkcms/forkcms/statuses/90e5652724d74569745a58b59f7bae6c0d8145a4"}}}}