{"action":"created","issue":{"url":"https://api.github.com/repos/restic/restic/issues/365","labels_url":"https://api.github.com/repos/restic/restic/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/restic/restic/issues/365/comments","events_url":"https://api.github.com/repos/restic/restic/issues/365/events","html_url":"https://github.com/restic/restic/pull/365","id":120649494,"number":365,"title":"Add a test reproducing #358 by concurrently saving duplicated chunks","user":{"login":"episource","id":3219567,"avatar_url":"https://avatars.githubusercontent.com/u/3219567?v=3","gravatar_id":"","url":"https://api.github.com/users/episource","html_url":"https://github.com/episource","followers_url":"https://api.github.com/users/episource/followers","following_url":"https://api.github.com/users/episource/following{/other_user}","gists_url":"https://api.github.com/users/episource/gists{/gist_id}","starred_url":"https://api.github.com/users/episource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episource/subscriptions","organizations_url":"https://api.github.com/users/episource/orgs","repos_url":"https://api.github.com/users/episource/repos","events_url":"https://api.github.com/users/episource/events{/privacy}","received_events_url":"https://api.github.com/users/episource/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-06T18:14:15Z","updated_at":"2015-12-06T19:54:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/restic/restic/pulls/365","html_url":"https://github.com/restic/restic/pull/365","diff_url":"https://github.com/restic/restic/pull/365.diff","patch_url":"https://github.com/restic/restic/pull/365.patch"},"body":"This commit adds an integration test, that calls Archiver.Save from many goroutines processing several duplicated chunks concurrently. The test asserts, that after all chunks have been saved, there are no\r\nunreferenced packs in the repository.\r\n\r\nThe test has been checked to give the expected results:\r\n 1. Running the test with maxParallel=1 (all chunks are processed sequentially) has been verified not to produce any unreferenced packs. Consequently the test passes.\r\n 2. Running the test with unbounded parallelism (maxParallel=math.MaxInt32) has been verified to produce unreferenced packs all the time (at least 25 test runs). Consequently the test fails due to #358.\r\n\r\nNote: The test is **expected to fail**, as the underlying issue #358 has not yet been solved. Hopefully it does not fail due to running **out of memory**. In it's current form, the test allocates several gb of ram. So it might require some reworking."},"comment":{"url":"https://api.github.com/repos/restic/restic/issues/comments/162341653","html_url":"https://github.com/restic/restic/pull/365#issuecomment-162341653","issue_url":"https://api.github.com/repos/restic/restic/issues/365","id":162341653,"user":{"login":"episource","id":3219567,"avatar_url":"https://avatars.githubusercontent.com/u/3219567?v=3","gravatar_id":"","url":"https://api.github.com/users/episource","html_url":"https://github.com/episource","followers_url":"https://api.github.com/users/episource/followers","following_url":"https://api.github.com/users/episource/following{/other_user}","gists_url":"https://api.github.com/users/episource/gists{/gist_id}","starred_url":"https://api.github.com/users/episource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/episource/subscriptions","organizations_url":"https://api.github.com/users/episource/orgs","repos_url":"https://api.github.com/users/episource/repos","events_url":"https://api.github.com/users/episource/events{/privacy}","received_events_url":"https://api.github.com/users/episource/received_events","type":"User","site_admin":false},"created_at":"2015-12-06T19:54:20Z","updated_at":"2015-12-06T19:54:20Z","body":"Interesting. All but one test runs failed as expected. One passed however: [Job #892.1](https://travis-ci.org/restic/restic/jobs/95211692). Probably I should further increase the number of duplicates!? Any idea on how to increase the chance of #358 to happen?"}}