{"action":"created","comment":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/36871393","id":36871393,"diff_hunk":"@@ -139,6 +139,9 @@ def create(req, sock, client, server, cfg):\n             host = hdr_value\n         elif hdr_name == \"SCRIPT_NAME\":\n             script_name = hdr_value\n+        elif hdr_name in (\"SCRIPT_URL\", \"REDIRECT_URL\"):","path":"gunicorn/http/wsgi.py","position":4,"original_position":4,"commit_id":"2bca62f9e81db0539958368154e3bd587f276dfb","original_commit_id":"2bca62f9e81db0539958368154e3bd587f276dfb","user":{"login":"benoitc","id":14498,"avatar_url":"https://avatars.githubusercontent.com/u/14498?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"body":"looking at the django path , maybe we should handle these values differently though. Thoughts?","created_at":"2015-08-12T15:11:43Z","updated_at":"2015-08-12T15:11:43Z","html_url":"https://github.com/benoitc/gunicorn/pull/1096#discussion_r36871393","pull_request_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096","_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/36871393"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1096#discussion_r36871393"},"pull_request":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096"}}},"pull_request":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096","id":42163958,"html_url":"https://github.com/benoitc/gunicorn/pull/1096","diff_url":"https://github.com/benoitc/gunicorn/pull/1096.diff","patch_url":"https://github.com/benoitc/gunicorn/pull/1096.patch","issue_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1096","number":1096,"state":"open","locked":false,"title":"Forward SCRIPT_URL and REDIRECT_URL into wsgi env","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"Main change: prevent prefixing these headers with 'HTTP_'.\r\n\r\nThese headers are very useful when you host your web-app under sub-path on the server and don't know 'SCRIPT_NAME' beforehand.\r\nExample usage in Django core: https://github.com/django/django/blob/master/django/core/handlers/wsgi.py#L200","created_at":"2015-08-11T18:53:58Z","updated_at":"2015-08-12T15:11:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8632e651392e0c0f12fce9e5ec2e792993d64268","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096/commits","review_comments_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096/comments","review_comment_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1096/comments","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/2bca62f9e81db0539958368154e3bd587f276dfb","head":{"label":"Ashald:patch-1","ref":"patch-1","sha":"2bca62f9e81db0539958368154e3bd587f276dfb","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"repo":{"id":40559150,"name":"gunicorn","full_name":"Ashald/gunicorn","owner":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ashald/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":true,"url":"https://api.github.com/repos/Ashald/gunicorn","forks_url":"https://api.github.com/repos/Ashald/gunicorn/forks","keys_url":"https://api.github.com/repos/Ashald/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ashald/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ashald/gunicorn/teams","hooks_url":"https://api.github.com/repos/Ashald/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/Ashald/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/Ashald/gunicorn/events","assignees_url":"https://api.github.com/repos/Ashald/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/Ashald/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/Ashald/gunicorn/tags","blobs_url":"https://api.github.com/repos/Ashald/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ashald/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ashald/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ashald/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ashald/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/Ashald/gunicorn/languages","stargazers_url":"https://api.github.com/repos/Ashald/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/Ashald/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/Ashald/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/Ashald/gunicorn/subscription","commits_url":"https://api.github.com/repos/Ashald/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ashald/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ashald/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ashald/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ashald/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/Ashald/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ashald/gunicorn/merges","archive_url":"https://api.github.com/repos/Ashald/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ashald/gunicorn/downloads","issues_url":"https://api.github.com/repos/Ashald/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/Ashald/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/Ashald/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/Ashald/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ashald/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/Ashald/gunicorn/releases{/id}","created_at":"2015-08-11T18:46:38Z","updated_at":"2015-08-11T18:46:39Z","pushed_at":"2015-08-11T19:00:26Z","git_url":"git://github.com/Ashald/gunicorn.git","ssh_url":"git@github.com:Ashald/gunicorn.git","clone_url":"https://github.com/Ashald/gunicorn.git","svn_url":"https://github.com/Ashald/gunicorn","homepage":"http://www.gunicorn.org","size":10225,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benoitc:master","ref":"master","sha":"89562c776e99b6e74a5fc6192372986a7fa2d131","user":{"login":"benoitc","id":14498,"avatar_url":"https://avatars.githubusercontent.com/u/14498?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"repo":{"id":390510,"name":"gunicorn","full_name":"benoitc/gunicorn","owner":{"login":"benoitc","id":14498,"avatar_url":"https://avatars.githubusercontent.com/u/14498?v=3","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benoitc/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":false,"url":"https://api.github.com/repos/benoitc/gunicorn","forks_url":"https://api.github.com/repos/benoitc/gunicorn/forks","keys_url":"https://api.github.com/repos/benoitc/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benoitc/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benoitc/gunicorn/teams","hooks_url":"https://api.github.com/repos/benoitc/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/benoitc/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/benoitc/gunicorn/events","assignees_url":"https://api.github.com/repos/benoitc/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/benoitc/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/benoitc/gunicorn/tags","blobs_url":"https://api.github.com/repos/benoitc/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benoitc/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benoitc/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/benoitc/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/benoitc/gunicorn/languages","stargazers_url":"https://api.github.com/repos/benoitc/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/benoitc/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/benoitc/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/benoitc/gunicorn/subscription","commits_url":"https://api.github.com/repos/benoitc/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/benoitc/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/benoitc/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/benoitc/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/benoitc/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benoitc/gunicorn/merges","archive_url":"https://api.github.com/repos/benoitc/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benoitc/gunicorn/downloads","issues_url":"https://api.github.com/repos/benoitc/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/benoitc/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/benoitc/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/benoitc/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benoitc/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/benoitc/gunicorn/releases{/id}","created_at":"2009-11-30T18:18:08Z","updated_at":"2015-08-11T17:46:07Z","pushed_at":"2015-08-11T19:00:36Z","git_url":"git://github.com/benoitc/gunicorn.git","ssh_url":"git@github.com:benoitc/gunicorn.git","clone_url":"https://github.com/benoitc/gunicorn.git","svn_url":"https://github.com/benoitc/gunicorn","homepage":"http://www.gunicorn.org","size":10225,"stargazers_count":2495,"watchers_count":2495,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":515,"mirror_url":null,"open_issues_count":90,"forks":515,"open_issues":90,"watchers":2495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1096"},"issue":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1096"},"comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1096/comments"},"review_comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096/comments"},"review_comment":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1096/commits"},"statuses":{"href":"https://api.github.com/repos/benoitc/gunicorn/statuses/2bca62f9e81db0539958368154e3bd587f276dfb"}}}}