{"action":"created","issue":{"url":"https://api.github.com/repos/manastech/crystal/issues/1478","labels_url":"https://api.github.com/repos/manastech/crystal/issues/1478/labels{/name}","comments_url":"https://api.github.com/repos/manastech/crystal/issues/1478/comments","events_url":"https://api.github.com/repos/manastech/crystal/issues/1478/events","html_url":"https://github.com/manastech/crystal/pull/1478","id":106551252,"number":1478,"title":"Rename time related types","user":{"login":"jhass","id":141294,"avatar_url":"https://avatars.githubusercontent.com/u/141294?v=3","gravatar_id":"","url":"https://api.github.com/users/jhass","html_url":"https://github.com/jhass","followers_url":"https://api.github.com/users/jhass/followers","following_url":"https://api.github.com/users/jhass/following{/other_user}","gists_url":"https://api.github.com/users/jhass/gists{/gist_id}","starred_url":"https://api.github.com/users/jhass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhass/subscriptions","organizations_url":"https://api.github.com/users/jhass/orgs","repos_url":"https://api.github.com/users/jhass/repos","events_url":"https://api.github.com/users/jhass/events{/privacy}","received_events_url":"https://api.github.com/users/jhass/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-15T13:06:54Z","updated_at":"2015-09-15T13:13:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/manastech/crystal/pulls/1478","html_url":"https://github.com/manastech/crystal/pull/1478","diff_url":"https://github.com/manastech/crystal/pull/1478.diff","patch_url":"https://github.com/manastech/crystal/pull/1478.patch"},"body":"* DayOfWeek -> Time::DayOfWeek\r\n* MonthSpan -> Time::MonthSpan\r\n* TimeSpan -> Time::Span\r\n* TimeFormat -> Time::Format\r\n\r\nRationale:\r\n\r\n* Group related types together so they're easier discovered in the docs.\r\n* Don't fill up the global namespace if there's no real reason to do so, that is if there's a namespaced place that's equally fine.\r\n* TimeSpan and TimeFormat can sort of be considered internals whose public API is on Time and the number primitives."},"comment":{"url":"https://api.github.com/repos/manastech/crystal/issues/comments/140383386","html_url":"https://github.com/manastech/crystal/pull/1478#issuecomment-140383386","issue_url":"https://api.github.com/repos/manastech/crystal/issues/1478","id":140383386,"user":{"login":"asterite","id":209371,"avatar_url":"https://avatars.githubusercontent.com/u/209371?v=3","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T13:13:06Z","updated_at":"2015-09-15T13:13:06Z","body":"I think I like this too. `TimeFormat` and `TimeSpan` are public APIs.\r\n\r\nIf some day we have a way to group related classes in docs I see these renames as less important. But yes, grouping with a namespace is also important.\r\n\r\n@waj what do you think?\r\n\r\n"}}