{"action":"created","issue":{"url":"https://api.github.com/repos/keystonejs/keystone/issues/1263","labels_url":"https://api.github.com/repos/keystonejs/keystone/issues/1263/labels{/name}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/1263/comments","events_url":"https://api.github.com/repos/keystonejs/keystone/issues/1263/events","html_url":"https://github.com/keystonejs/keystone/pull/1263","id":64847656,"number":1263,"title":"Added missing updateItem on S3FileType and CloudinaryImagesType type to allow DB updates","user":{"login":"danielzurawski","id":1625711,"avatar_url":"https://avatars.githubusercontent.com/u/1625711?v=3","gravatar_id":"","url":"https://api.github.com/users/danielzurawski","html_url":"https://github.com/danielzurawski","followers_url":"https://api.github.com/users/danielzurawski/followers","following_url":"https://api.github.com/users/danielzurawski/following{/other_user}","gists_url":"https://api.github.com/users/danielzurawski/gists{/gist_id}","starred_url":"https://api.github.com/users/danielzurawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielzurawski/subscriptions","organizations_url":"https://api.github.com/users/danielzurawski/orgs","repos_url":"https://api.github.com/users/danielzurawski/repos","events_url":"https://api.github.com/users/danielzurawski/events{/privacy}","received_events_url":"https://api.github.com/users/danielzurawski/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/keystonejs/keystone/labels/(status)%20on%20hold","name":"(status) on hold","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-27T20:44:04Z","updated_at":"2015-03-31T07:43:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/1263","html_url":"https://github.com/keystonejs/keystone/pull/1263","diff_url":"https://github.com/keystonejs/keystone/pull/1263.diff","patch_url":"https://github.com/keystonejs/keystone/pull/1263.patch"},"body":"Hi,\r\n\r\nI've 'implemented' the missing updateItem method on the S3FileType and CloudinaryImagesType (plural).\r\nIn case of S3File that's mostly copy & paste of what's already in CloudinaryImage field type (all credits to @webteckie ), but with different properties.\r\nThe properties I've listed are the default ones that get populated for a simple S3 field.\r\n\r\nFor CloudinaryImagesType I check for deep equality and if it has changed or it was not present before, I update.\r\nComments/suggestions appreciated! \r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/keystonejs/keystone/issues/comments/87980473","html_url":"https://github.com/keystonejs/keystone/pull/1263#issuecomment-87980473","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/1263","id":87980473,"user":{"login":"creynders","id":436347,"avatar_url":"https://avatars.githubusercontent.com/u/436347?v=3","gravatar_id":"","url":"https://api.github.com/users/creynders","html_url":"https://github.com/creynders","followers_url":"https://api.github.com/users/creynders/followers","following_url":"https://api.github.com/users/creynders/following{/other_user}","gists_url":"https://api.github.com/users/creynders/gists{/gist_id}","starred_url":"https://api.github.com/users/creynders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creynders/subscriptions","organizations_url":"https://api.github.com/users/creynders/orgs","repos_url":"https://api.github.com/users/creynders/repos","events_url":"https://api.github.com/users/creynders/events{/privacy}","received_events_url":"https://api.github.com/users/creynders/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T07:43:27Z","updated_at":"2015-03-31T07:43:27Z","body":"Hi @danielzurawski thanks for the PR. Unfortunately I'm going to have to put this on hold, since we're currently in the process of rewriting the file fields (trying to consolidate them) and S3's one of them.\r\nHowever, I hope to either merge/migrate this, once I'm finished with it."}}