{"action":"created","issue":{"url":"https://api.github.com/repos/fpl/scihub/issues/6","labels_url":"https://api.github.com/repos/fpl/scihub/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/fpl/scihub/issues/6/comments","events_url":"https://api.github.com/repos/fpl/scihub/issues/6/events","html_url":"https://github.com/fpl/scihub/issues/6","id":119745255,"number":6,"title":"Corrupted zip files","user":{"login":"krasny2k5","id":3613226,"avatar_url":"https://avatars.githubusercontent.com/u/3613226?v=3","gravatar_id":"","url":"https://api.github.com/users/krasny2k5","html_url":"https://github.com/krasny2k5","followers_url":"https://api.github.com/users/krasny2k5/followers","following_url":"https://api.github.com/users/krasny2k5/following{/other_user}","gists_url":"https://api.github.com/users/krasny2k5/gists{/gist_id}","starred_url":"https://api.github.com/users/krasny2k5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasny2k5/subscriptions","organizations_url":"https://api.github.com/users/krasny2k5/orgs","repos_url":"https://api.github.com/users/krasny2k5/repos","events_url":"https://api.github.com/users/krasny2k5/events{/privacy}","received_events_url":"https://api.github.com/users/krasny2k5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-01T15:50:39Z","updated_at":"2015-12-02T11:27:11Z","closed_at":null,"body":"Hello\r\nI just found that, with the new version, some zips are corrupted. Only files that were resumed are affected, so it must be a problem with the resume parte. Also, the files passes the test because magic dectects it as a zip file, but some files inside has CRC errors.\r\n\r\nI think a possible workaround can be do a zipfile.testzip() after the file is downloaded, by this if anything is wrong the file should be discarted and start the process again. It will be slow to check a +- 4Gb Image, but i think that the integrity of the data is more important here. I can implement this if you think that it´s a good approach.\r\n\r\nI recommend you to check your downloaded files if you downloaded images with the latest version of the program (unzip -t zipfile.zip)"},"comment":{"url":"https://api.github.com/repos/fpl/scihub/issues/comments/161266311","html_url":"https://github.com/fpl/scihub/issues/6#issuecomment-161266311","issue_url":"https://api.github.com/repos/fpl/scihub/issues/6","id":161266311,"user":{"login":"fpl","id":53651,"avatar_url":"https://avatars.githubusercontent.com/u/53651?v=3","gravatar_id":"","url":"https://api.github.com/users/fpl","html_url":"https://github.com/fpl","followers_url":"https://api.github.com/users/fpl/followers","following_url":"https://api.github.com/users/fpl/following{/other_user}","gists_url":"https://api.github.com/users/fpl/gists{/gist_id}","starred_url":"https://api.github.com/users/fpl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpl/subscriptions","organizations_url":"https://api.github.com/users/fpl/orgs","repos_url":"https://api.github.com/users/fpl/repos","events_url":"https://api.github.com/users/fpl/events{/privacy}","received_events_url":"https://api.github.com/users/fpl/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T11:27:11Z","updated_at":"2015-12-02T11:27:11Z","body":"Right, indeed it is probably the issue: it does fail again (with an error message) at resume time and corrupts the output file. "}}