{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/comments/36463542","id":36463542,"diff_hunk":"@@ -367,59 +376,62 @@ def update_landsat_product_status(contact_id):\n \n             set_products_unavailable(invalid, 'Not found in landsat archive')\n \n+    logger.info('Handling submitted landsat products...')\n+\n     #Here's the real logic for this handling submitted landsat products\n     mark_nlaps_unavailable()\n \n     for contact_id in get_contactids_for_submitted_landsat_products():\n         try:\n-            print(\"Updating landsat_product_status for %s\" % contact_id)\n+            logger.info(\"Updating landsat_product_status for {0}\"","path":"web/ordering/core.py","position":146,"original_position":146,"commit_id":"5eb35187d23e1bcb1e9922dda1c7f7fc89050150","original_commit_id":"7fd1972d11c110b113f778889efd0b9bbba53086","user":{"login":"rdilley-usgs","id":12140146,"avatar_url":"https://avatars.githubusercontent.com/u/12140146?v=3","gravatar_id":"","url":"https://api.github.com/users/rdilley-usgs","html_url":"https://github.com/rdilley-usgs","followers_url":"https://api.github.com/users/rdilley-usgs/followers","following_url":"https://api.github.com/users/rdilley-usgs/following{/other_user}","gists_url":"https://api.github.com/users/rdilley-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/rdilley-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdilley-usgs/subscriptions","organizations_url":"https://api.github.com/users/rdilley-usgs/orgs","repos_url":"https://api.github.com/users/rdilley-usgs/repos","events_url":"https://api.github.com/users/rdilley-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/rdilley-usgs/received_events","type":"User","site_admin":false},"body":"Did you mean for this to be logger.info and not logger.debug like the others?","created_at":"2015-08-06T20:47:48Z","updated_at":"2015-08-06T20:47:48Z","html_url":"https://github.com/USGS-EROS/espa-web/pull/5#discussion_r36463542","pull_request_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/comments/36463542"},"html":{"href":"https://github.com/USGS-EROS/espa-web/pull/5#discussion_r36463542"},"pull_request":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5","id":41826917,"html_url":"https://github.com/USGS-EROS/espa-web/pull/5","diff_url":"https://github.com/USGS-EROS/espa-web/pull/5.diff","patch_url":"https://github.com/USGS-EROS/espa-web/pull/5.patch","issue_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/5","number":5,"state":"open","locked":false,"title":"Create global orderdisposition lock","user":{"login":"dhill-usgs","id":12154564,"avatar_url":"https://avatars.githubusercontent.com/u/12154564?v=3","gravatar_id":"","url":"https://api.github.com/users/dhill-usgs","html_url":"https://github.com/dhill-usgs","followers_url":"https://api.github.com/users/dhill-usgs/followers","following_url":"https://api.github.com/users/dhill-usgs/following{/other_user}","gists_url":"https://api.github.com/users/dhill-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/dhill-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhill-usgs/subscriptions","organizations_url":"https://api.github.com/users/dhill-usgs/orgs","repos_url":"https://api.github.com/users/dhill-usgs/repos","events_url":"https://api.github.com/users/dhill-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/dhill-usgs/received_events","type":"User","site_admin":false},"body":"Looking for a sanity check/peer review on the changes.  This is currently deployed to dev + tst and has been tested.  Global lock key is defined in settings.py along with the timeout.  This will help keep all cache keys centralized, and later can build console pages to display all cache key/values and their timeouts, allow expiring the values, etc.\r\n\r\nGlobal lock effectively keeps more than one instance of order_disposition (handle_orders in core) from running.  If the process dies or spins out of control the lock auto expires after 21 minutes (three times longer than cron schedule is set for on order_disposition_cron.\r\n\r\nAlso put standard django/python logging in place in accordance with the espa standard configuration that existed in espa_common/settings.\r\n\r\nMoved all imports to relative wherever possible.  Was not possible in espa_web/auth_backends.py because you can't relative import out of the top level.","created_at":"2015-08-06T19:46:20Z","updated_at":"2015-08-06T20:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03ce6addf8cb62f940d3ce496f9d920d7b84de92","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5/commits","review_comments_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5/comments","review_comment_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/5/comments","statuses_url":"https://api.github.com/repos/USGS-EROS/espa-web/statuses/5eb35187d23e1bcb1e9922dda1c7f7fc89050150","head":{"label":"USGS-EROS:create_global_orderdisposition_lock","ref":"create_global_orderdisposition_lock","sha":"5eb35187d23e1bcb1e9922dda1c7f7fc89050150","user":{"login":"USGS-EROS","id":12549192,"avatar_url":"https://avatars.githubusercontent.com/u/12549192?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-EROS","html_url":"https://github.com/USGS-EROS","followers_url":"https://api.github.com/users/USGS-EROS/followers","following_url":"https://api.github.com/users/USGS-EROS/following{/other_user}","gists_url":"https://api.github.com/users/USGS-EROS/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-EROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-EROS/subscriptions","organizations_url":"https://api.github.com/users/USGS-EROS/orgs","repos_url":"https://api.github.com/users/USGS-EROS/repos","events_url":"https://api.github.com/users/USGS-EROS/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-EROS/received_events","type":"Organization","site_admin":false},"repo":{"id":39915720,"name":"espa-web","full_name":"USGS-EROS/espa-web","owner":{"login":"USGS-EROS","id":12549192,"avatar_url":"https://avatars.githubusercontent.com/u/12549192?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-EROS","html_url":"https://github.com/USGS-EROS","followers_url":"https://api.github.com/users/USGS-EROS/followers","following_url":"https://api.github.com/users/USGS-EROS/following{/other_user}","gists_url":"https://api.github.com/users/USGS-EROS/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-EROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-EROS/subscriptions","organizations_url":"https://api.github.com/users/USGS-EROS/orgs","repos_url":"https://api.github.com/users/USGS-EROS/repos","events_url":"https://api.github.com/users/USGS-EROS/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-EROS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-EROS/espa-web","description":"","fork":false,"url":"https://api.github.com/repos/USGS-EROS/espa-web","forks_url":"https://api.github.com/repos/USGS-EROS/espa-web/forks","keys_url":"https://api.github.com/repos/USGS-EROS/espa-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-EROS/espa-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-EROS/espa-web/teams","hooks_url":"https://api.github.com/repos/USGS-EROS/espa-web/hooks","issue_events_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-EROS/espa-web/events","assignees_url":"https://api.github.com/repos/USGS-EROS/espa-web/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-EROS/espa-web/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-EROS/espa-web/tags","blobs_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-EROS/espa-web/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-EROS/espa-web/languages","stargazers_url":"https://api.github.com/repos/USGS-EROS/espa-web/stargazers","contributors_url":"https://api.github.com/repos/USGS-EROS/espa-web/contributors","subscribers_url":"https://api.github.com/repos/USGS-EROS/espa-web/subscribers","subscription_url":"https://api.github.com/repos/USGS-EROS/espa-web/subscription","commits_url":"https://api.github.com/repos/USGS-EROS/espa-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-EROS/espa-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-EROS/espa-web/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-EROS/espa-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-EROS/espa-web/merges","archive_url":"https://api.github.com/repos/USGS-EROS/espa-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-EROS/espa-web/downloads","issues_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-EROS/espa-web/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-EROS/espa-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-EROS/espa-web/labels{/name}","releases_url":"https://api.github.com/repos/USGS-EROS/espa-web/releases{/id}","created_at":"2015-07-29T20:51:15Z","updated_at":"2015-07-29T20:54:43Z","pushed_at":"2015-08-06T20:39:39Z","git_url":"git://github.com/USGS-EROS/espa-web.git","ssh_url":"git@github.com:USGS-EROS/espa-web.git","clone_url":"https://github.com/USGS-EROS/espa-web.git","svn_url":"https://github.com/USGS-EROS/espa-web","homepage":null,"size":14376,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-EROS:master","ref":"master","sha":"9647ef21f879728d8f72fe638d3223fc0b2e9a2f","user":{"login":"USGS-EROS","id":12549192,"avatar_url":"https://avatars.githubusercontent.com/u/12549192?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-EROS","html_url":"https://github.com/USGS-EROS","followers_url":"https://api.github.com/users/USGS-EROS/followers","following_url":"https://api.github.com/users/USGS-EROS/following{/other_user}","gists_url":"https://api.github.com/users/USGS-EROS/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-EROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-EROS/subscriptions","organizations_url":"https://api.github.com/users/USGS-EROS/orgs","repos_url":"https://api.github.com/users/USGS-EROS/repos","events_url":"https://api.github.com/users/USGS-EROS/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-EROS/received_events","type":"Organization","site_admin":false},"repo":{"id":39915720,"name":"espa-web","full_name":"USGS-EROS/espa-web","owner":{"login":"USGS-EROS","id":12549192,"avatar_url":"https://avatars.githubusercontent.com/u/12549192?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-EROS","html_url":"https://github.com/USGS-EROS","followers_url":"https://api.github.com/users/USGS-EROS/followers","following_url":"https://api.github.com/users/USGS-EROS/following{/other_user}","gists_url":"https://api.github.com/users/USGS-EROS/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-EROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-EROS/subscriptions","organizations_url":"https://api.github.com/users/USGS-EROS/orgs","repos_url":"https://api.github.com/users/USGS-EROS/repos","events_url":"https://api.github.com/users/USGS-EROS/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-EROS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-EROS/espa-web","description":"","fork":false,"url":"https://api.github.com/repos/USGS-EROS/espa-web","forks_url":"https://api.github.com/repos/USGS-EROS/espa-web/forks","keys_url":"https://api.github.com/repos/USGS-EROS/espa-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-EROS/espa-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-EROS/espa-web/teams","hooks_url":"https://api.github.com/repos/USGS-EROS/espa-web/hooks","issue_events_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-EROS/espa-web/events","assignees_url":"https://api.github.com/repos/USGS-EROS/espa-web/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-EROS/espa-web/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-EROS/espa-web/tags","blobs_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-EROS/espa-web/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-EROS/espa-web/languages","stargazers_url":"https://api.github.com/repos/USGS-EROS/espa-web/stargazers","contributors_url":"https://api.github.com/repos/USGS-EROS/espa-web/contributors","subscribers_url":"https://api.github.com/repos/USGS-EROS/espa-web/subscribers","subscription_url":"https://api.github.com/repos/USGS-EROS/espa-web/subscription","commits_url":"https://api.github.com/repos/USGS-EROS/espa-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-EROS/espa-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-EROS/espa-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-EROS/espa-web/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-EROS/espa-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-EROS/espa-web/merges","archive_url":"https://api.github.com/repos/USGS-EROS/espa-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-EROS/espa-web/downloads","issues_url":"https://api.github.com/repos/USGS-EROS/espa-web/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-EROS/espa-web/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-EROS/espa-web/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-EROS/espa-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-EROS/espa-web/labels{/name}","releases_url":"https://api.github.com/repos/USGS-EROS/espa-web/releases{/id}","created_at":"2015-07-29T20:51:15Z","updated_at":"2015-07-29T20:54:43Z","pushed_at":"2015-08-06T20:39:39Z","git_url":"git://github.com/USGS-EROS/espa-web.git","ssh_url":"git@github.com:USGS-EROS/espa-web.git","clone_url":"https://github.com/USGS-EROS/espa-web.git","svn_url":"https://github.com/USGS-EROS/espa-web","homepage":null,"size":14376,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5"},"html":{"href":"https://github.com/USGS-EROS/espa-web/pull/5"},"issue":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/issues/5"},"comments":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-EROS/espa-web/statuses/5eb35187d23e1bcb1e9922dda1c7f7fc89050150"}}}}