{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/6995","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6995/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6995/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6995/events","html_url":"https://github.com/joomla/joomla-cms/pull/6995","id":78516458,"number":6995,"title":"Use the Joomla way for bootstrap modals","user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/8","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.4.2","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/8/labels","id":1009981,"number":8,"title":"Joomla! 3.4.2","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":150,"state":"open","created_at":"2015-03-06T21:41:22Z","updated_at":"2015-05-25T12:58:06Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-05-20T13:03:15Z","updated_at":"2015-05-25T13:19:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/6995","html_url":"https://github.com/joomla/joomla-cms/pull/6995","diff_url":"https://github.com/joomla/joomla-cms/pull/6995.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/6995.patch"},"body":"#### Exchange some class names\r\n\r\nMost of the PRs that convert the mootools modals to bootstrap use `JHtmlBootstrap::renderModal(etc)`\r\nbut they should actually use `JHtml::_('bootstrap.renderModal', etc)`.\r\nAnd here is how I found out:\r\nMe: JHtmlBootstrap::renderModal( vs JHtml::_('bootstrap.renderModal'\r\nThe first one on my IDE with cmd + click on JHtmlBootstrap takes me to the correct file/class but the other takes me to JHtml and cmd + click on 'bootstrap.renderModal' isn’t really helpful as well. So I am a little bit confused here…\r\n@mbabker: JHtml has some code that can let you override the various methods if called via JHtml::_. Direct calling of JHtml (and its subclasses) methods break that functionality. The downside is just as you pointed out, IDE autocompletion is out the window.\r\n\r\nSo in order to prevent any future conflicts with this code is better to change it ASAP!\r\n\r\nBecause this is only a rename and some CS work I would like to ask the maintainers to just review and commit. @wilsonge @roland-d ? \r\nTo save other people and not to spent their time here, I provide a proof that all the relative modals still work as before. So:\r\nadministrator/components/com_contact/models/fields/modal/contact.php\r\n![screen shot 2015-05-20 at 3 46 56](https://cloud.githubusercontent.com/assets/3889375/7725928/8277e45c-ff07-11e4-94ba-350b120b1f7c.png)\r\n\r\nadministrator/components/com_content/models/fields/modal/article.php\r\n![screen shot 2015-05-20 at 3 48 26](https://cloud.githubusercontent.com/assets/3889375/7725961/b3cc78a6-ff07-11e4-8909-52d54e6e5fcd.png)\r\n\r\nadministrator/components/com_menus/models/fields/menutype.php\r\n![screen shot 2015-05-20 at 3 49 12](https://cloud.githubusercontent.com/assets/3889375/7725985/d788e1da-ff07-11e4-8713-c33814f9484f.png)\r\n\r\nadministrator/components/com_menus/views/item/tmpl/edit_modules.php\r\n![screen shot 2015-05-20 at 3 50 24](https://cloud.githubusercontent.com/assets/3889375/7726024/09eba82e-ff08-11e4-8a79-0360be55a8eb.png)\r\n\r\nadministrator/templates/hathor/html/com_menus/menus/default.php\r\n![screen shot 2015-05-20 at 3 52 04](https://cloud.githubusercontent.com/assets/3889375/7726069/4501cd4e-ff08-11e4-9cfe-7b3cc20cac50.png)\r\n\r\nadministrator/components/com_newsfeeds/models/fields/modal/newsfeed.php\r\n![screen shot 2015-05-20 at 3 53 37](https://cloud.githubusercontent.com/assets/3889375/7726094/6ebcf762-ff08-11e4-947f-da1e9106676e.png)\r\n\r\nadministrator/components/com_templates/helpers/html/templates.php\r\n![screen shot 2015-05-20 at 3 55 10](https://cloud.githubusercontent.com/assets/3889375/7726134/ac60c0ee-ff08-11e4-8ffe-b80a34473369.png)\r\n\r\nadministrator/components/com_users/helpers/html/users.php\r\n![screen shot 2015-05-20 at 3 57 04](https://cloud.githubusercontent.com/assets/3889375/7726183/ef61193e-ff08-11e4-9d88-c54f4a6b8abc.png)\r\n\r\nadministrator/templates/hathor/html/com_menus/menus/default.php\r\n![screen shot 2015-05-20 at 3 59 04](https://cloud.githubusercontent.com/assets/3889375/7726230/396f07a2-ff09-11e4-8d85-cf0c78a88df5.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/105230486","html_url":"https://github.com/joomla/joomla-cms/pull/6995#issuecomment-105230486","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6995","id":105230486,"user":{"login":"n9iels","id":2659866,"avatar_url":"https://avatars.githubusercontent.com/u/2659866?v=3","gravatar_id":"","url":"https://api.github.com/users/n9iels","html_url":"https://github.com/n9iels","followers_url":"https://api.github.com/users/n9iels/followers","following_url":"https://api.github.com/users/n9iels/following{/other_user}","gists_url":"https://api.github.com/users/n9iels/gists{/gist_id}","starred_url":"https://api.github.com/users/n9iels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n9iels/subscriptions","organizations_url":"https://api.github.com/users/n9iels/orgs","repos_url":"https://api.github.com/users/n9iels/repos","events_url":"https://api.github.com/users/n9iels/events{/privacy}","received_events_url":"https://api.github.com/users/n9iels/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T13:19:39Z","updated_at":"2015-05-25T13:19:39Z","body":"Not sure if this is the right place.\r\nWhen I add a new menu item, and click on the \"Select menu type\" button I got the following error:\r\nNotice: Undefined variable: tispanle in C:\\MAMP\\htdocs\\joomla-cms\\administrator\\components\\com_menus\\views\\menutypes\\view.html.php on line 108\r\n\r\nLittle bug? Or a problem in my local installation?"}}