{"push_id":743185258,"size":2,"distinct_size":2,"ref":"refs/heads/removetool20150730","head":"086a60ba2bc738e350f850ff9ed1c581bf783775","before":"d7a533e515806df7798a5f2776bf3ebc1967bc42","commits":[{"sha":"0ff80e47272ac1b6ddc676aa9ad51957966804a2","author":{"email":"783b0497773840316eedb54250966d6fa49938c8@tower-research.com","name":"Andy Zhu"},"message":"PreviewSaveTool init doesn't create dom element\n\n(Minor) Right now every time a figure is initialized with the\nPreviewSaveTool, a corresponding dialog div element gets created.\nPretty minor since the div elements aren't visible, but it is rather\nconfusing since it makes it look like updating figures in python is\na wrong thing to do. For example, try starting stock_app after\nadding the \"save\" tool to each of the plots, changing the plot sources,\nand looking at a html console.\n\nThis still doesn't entirely fix the problem in that after a figure\nis removed, the corresponding PreviewSaveTool dom element nor view\ndon't seem to get removed. My guess is that its because a reference\nto the PreviewSaveTool model isn't kept by the app (if we are creating\nthe tool via the \"save\" string). If that's the case maybe Plot's\nremove() method can be overloaded to call all of its tools' remove()\nmethods.\n\nUpdate some docs to change SaveTool to PreviewSaveTool, and dimension\nto dimensions.","distinct":true,"url":"https://api.github.com/repos/azjps/bokeh/commits/0ff80e47272ac1b6ddc676aa9ad51957966804a2"},{"sha":"086a60ba2bc738e350f850ff9ed1c581bf783775","author":{"email":"783b0497773840316eedb54250966d6fa49938c8@tower-research.com","name":"Andy Zhu"},"message":"Plot view removal also remove the tool views\n\nWhen a Plot backbone view is remove()'d, it will also call remove()\non its tools. Otherwise right now the tools do not seem to be included\nwith other models and so won't be remove()'d when their plot is removed.\nI think this should be ok as long as its ok to call remove() twice on a\nview.","distinct":true,"url":"https://api.github.com/repos/azjps/bokeh/commits/086a60ba2bc738e350f850ff9ed1c581bf783775"}]}