{"action":"created","issue":{"url":"https://api.github.com/repos/jekyll/jekyll-import/issues/235","labels_url":"https://api.github.com/repos/jekyll/jekyll-import/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/jekyll/jekyll-import/issues/235/comments","events_url":"https://api.github.com/repos/jekyll/jekyll-import/issues/235/events","html_url":"https://github.com/jekyll/jekyll-import/pull/235","id":123740028,"number":235,"title":"Clean up the Drupal importers","user":{"login":"borfast","id":4837,"avatar_url":"https://avatars.githubusercontent.com/u/4837?v=3","gravatar_id":"","url":"https://api.github.com/users/borfast","html_url":"https://github.com/borfast","followers_url":"https://api.github.com/users/borfast/followers","following_url":"https://api.github.com/users/borfast/following{/other_user}","gists_url":"https://api.github.com/users/borfast/gists{/gist_id}","starred_url":"https://api.github.com/users/borfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borfast/subscriptions","organizations_url":"https://api.github.com/users/borfast/orgs","repos_url":"https://api.github.com/users/borfast/repos","events_url":"https://api.github.com/users/borfast/events{/privacy}","received_events_url":"https://api.github.com/users/borfast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-24T00:29:58Z","updated_at":"2015-12-26T00:28:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll-import/pulls/235","html_url":"https://github.com/jekyll/jekyll-import/pull/235","diff_url":"https://github.com/jekyll/jekyll-import/pull/235.diff","patch_url":"https://github.com/jekyll/jekyll-import/pull/235.patch"},"body":"Big refactoring of the Drupal importers.\r\n\r\nAll the code that was repeated on both Drupal6 and Drupal7 importers was pulled up into a generic `DrupalAbstract` class which implements the \"core\" logic of the Drupal importers and delegates the version-specific code to sub-classes.\r\n\r\nI would appreciate it if someone could test importing non-Drupal content, though, because I don't have another blog to test the non-Drupal importers with."},"comment":{"url":"https://api.github.com/repos/jekyll/jekyll-import/issues/comments/167268401","html_url":"https://github.com/jekyll/jekyll-import/pull/235#issuecomment-167268401","issue_url":"https://api.github.com/repos/jekyll/jekyll-import/issues/235","id":167268401,"user":{"login":"parkr","id":237985,"avatar_url":"https://avatars.githubusercontent.com/u/237985?v=3","gravatar_id":"","url":"https://api.github.com/users/parkr","html_url":"https://github.com/parkr","followers_url":"https://api.github.com/users/parkr/followers","following_url":"https://api.github.com/users/parkr/following{/other_user}","gists_url":"https://api.github.com/users/parkr/gists{/gist_id}","starred_url":"https://api.github.com/users/parkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkr/subscriptions","organizations_url":"https://api.github.com/users/parkr/orgs","repos_url":"https://api.github.com/users/parkr/repos","events_url":"https://api.github.com/users/parkr/events{/privacy}","received_events_url":"https://api.github.com/users/parkr/received_events","type":"User","site_admin":false},"created_at":"2015-12-26T00:28:57Z","updated_at":"2015-12-26T00:28:57Z","body":"Great start, @borfast! I would love to see this as a module instead of a superclass, or have the one class handle both options and allowing folks to specify the version in the options, maybe. What do you think about that? That gets around the sub-subclassing issue and keeps the inheritance tree very clean."}}