{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8","id":48014421,"html_url":"https://github.com/PythonNut/helm-flx/pull/8","diff_url":"https://github.com/PythonNut/helm-flx/pull/8.diff","patch_url":"https://github.com/PythonNut/helm-flx/pull/8.patch","issue_url":"https://api.github.com/repos/PythonNut/helm-flx/issues/8","number":8,"state":"closed","locked":false,"title":"Coerce candidates to string before highlighting","user":{"login":"julienfantin","id":127283,"avatar_url":"https://avatars.githubusercontent.com/u/127283?v=3","gravatar_id":"","url":"https://api.github.com/users/julienfantin","html_url":"https://github.com/julienfantin","followers_url":"https://api.github.com/users/julienfantin/followers","following_url":"https://api.github.com/users/julienfantin/following{/other_user}","gists_url":"https://api.github.com/users/julienfantin/gists{/gist_id}","starred_url":"https://api.github.com/users/julienfantin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienfantin/subscriptions","organizations_url":"https://api.github.com/users/julienfantin/orgs","repos_url":"https://api.github.com/users/julienfantin/repos","events_url":"https://api.github.com/users/julienfantin/events{/privacy}","received_events_url":"https://api.github.com/users/julienfantin/received_events","type":"User","site_admin":false},"body":"Some helm sources, such as the `helm-themes` package, use symbols in\r\ntheir candidates list, which would break the assumption that they are\r\nchars or stings somehwere in `helm-flx-fuzzy-highlight-match`.\r\n\r\nThis adds a coercion function `helm-flx-candidate-string` that converts\r\na symbol to a string -- with a cond statement, so this can be extended\r\nto other types, though I'm not sure this would come up in practice? --\r\nand ensures that candidates are strings in the scope of the highlighting\r\nfunction.\r\n\r\nThis PR fixes #5 ","created_at":"2015-10-18T18:37:05Z","updated_at":"2015-10-18T21:02:32Z","closed_at":"2015-10-18T21:02:32Z","merged_at":null,"merge_commit_sha":"220338e32c72b537d7efd35e62735ca12376bf2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8/commits","review_comments_url":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8/comments","review_comment_url":"https://api.github.com/repos/PythonNut/helm-flx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PythonNut/helm-flx/issues/8/comments","statuses_url":"https://api.github.com/repos/PythonNut/helm-flx/statuses/267b1a8c6fff650d0c4a83059514570693f0eda4","head":{"label":"julienfantin:fix-symbol-candidates","ref":"fix-symbol-candidates","sha":"267b1a8c6fff650d0c4a83059514570693f0eda4","user":{"login":"julienfantin","id":127283,"avatar_url":"https://avatars.githubusercontent.com/u/127283?v=3","gravatar_id":"","url":"https://api.github.com/users/julienfantin","html_url":"https://github.com/julienfantin","followers_url":"https://api.github.com/users/julienfantin/followers","following_url":"https://api.github.com/users/julienfantin/following{/other_user}","gists_url":"https://api.github.com/users/julienfantin/gists{/gist_id}","starred_url":"https://api.github.com/users/julienfantin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienfantin/subscriptions","organizations_url":"https://api.github.com/users/julienfantin/orgs","repos_url":"https://api.github.com/users/julienfantin/repos","events_url":"https://api.github.com/users/julienfantin/events{/privacy}","received_events_url":"https://api.github.com/users/julienfantin/received_events","type":"User","site_admin":false},"repo":{"id":44490179,"name":"helm-flx","full_name":"julienfantin/helm-flx","owner":{"login":"julienfantin","id":127283,"avatar_url":"https://avatars.githubusercontent.com/u/127283?v=3","gravatar_id":"","url":"https://api.github.com/users/julienfantin","html_url":"https://github.com/julienfantin","followers_url":"https://api.github.com/users/julienfantin/followers","following_url":"https://api.github.com/users/julienfantin/following{/other_user}","gists_url":"https://api.github.com/users/julienfantin/gists{/gist_id}","starred_url":"https://api.github.com/users/julienfantin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienfantin/subscriptions","organizations_url":"https://api.github.com/users/julienfantin/orgs","repos_url":"https://api.github.com/users/julienfantin/repos","events_url":"https://api.github.com/users/julienfantin/events{/privacy}","received_events_url":"https://api.github.com/users/julienfantin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienfantin/helm-flx","description":"Flx-based fuzzy matching for helm","fork":true,"url":"https://api.github.com/repos/julienfantin/helm-flx","forks_url":"https://api.github.com/repos/julienfantin/helm-flx/forks","keys_url":"https://api.github.com/repos/julienfantin/helm-flx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienfantin/helm-flx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienfantin/helm-flx/teams","hooks_url":"https://api.github.com/repos/julienfantin/helm-flx/hooks","issue_events_url":"https://api.github.com/repos/julienfantin/helm-flx/issues/events{/number}","events_url":"https://api.github.com/repos/julienfantin/helm-flx/events","assignees_url":"https://api.github.com/repos/julienfantin/helm-flx/assignees{/user}","branches_url":"https://api.github.com/repos/julienfantin/helm-flx/branches{/branch}","tags_url":"https://api.github.com/repos/julienfantin/helm-flx/tags","blobs_url":"https://api.github.com/repos/julienfantin/helm-flx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienfantin/helm-flx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienfantin/helm-flx/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienfantin/helm-flx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienfantin/helm-flx/statuses/{sha}","languages_url":"https://api.github.com/repos/julienfantin/helm-flx/languages","stargazers_url":"https://api.github.com/repos/julienfantin/helm-flx/stargazers","contributors_url":"https://api.github.com/repos/julienfantin/helm-flx/contributors","subscribers_url":"https://api.github.com/repos/julienfantin/helm-flx/subscribers","subscription_url":"https://api.github.com/repos/julienfantin/helm-flx/subscription","commits_url":"https://api.github.com/repos/julienfantin/helm-flx/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienfantin/helm-flx/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienfantin/helm-flx/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienfantin/helm-flx/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienfantin/helm-flx/contents/{+path}","compare_url":"https://api.github.com/repos/julienfantin/helm-flx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienfantin/helm-flx/merges","archive_url":"https://api.github.com/repos/julienfantin/helm-flx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienfantin/helm-flx/downloads","issues_url":"https://api.github.com/repos/julienfantin/helm-flx/issues{/number}","pulls_url":"https://api.github.com/repos/julienfantin/helm-flx/pulls{/number}","milestones_url":"https://api.github.com/repos/julienfantin/helm-flx/milestones{/number}","notifications_url":"https://api.github.com/repos/julienfantin/helm-flx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienfantin/helm-flx/labels{/name}","releases_url":"https://api.github.com/repos/julienfantin/helm-flx/releases{/id}","created_at":"2015-10-18T18:16:37Z","updated_at":"2015-10-18T18:16:38Z","pushed_at":"2015-10-18T18:34:20Z","git_url":"git://github.com/julienfantin/helm-flx.git","ssh_url":"git@github.com:julienfantin/helm-flx.git","clone_url":"https://github.com/julienfantin/helm-flx.git","svn_url":"https://github.com/julienfantin/helm-flx","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PythonNut:master","ref":"master","sha":"ae0806a6e61bd2a581d120fc0f26ca6ad22a2d73","user":{"login":"PythonNut","id":5009546,"avatar_url":"https://avatars.githubusercontent.com/u/5009546?v=3","gravatar_id":"","url":"https://api.github.com/users/PythonNut","html_url":"https://github.com/PythonNut","followers_url":"https://api.github.com/users/PythonNut/followers","following_url":"https://api.github.com/users/PythonNut/following{/other_user}","gists_url":"https://api.github.com/users/PythonNut/gists{/gist_id}","starred_url":"https://api.github.com/users/PythonNut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PythonNut/subscriptions","organizations_url":"https://api.github.com/users/PythonNut/orgs","repos_url":"https://api.github.com/users/PythonNut/repos","events_url":"https://api.github.com/users/PythonNut/events{/privacy}","received_events_url":"https://api.github.com/users/PythonNut/received_events","type":"User","site_admin":false},"repo":{"id":44204744,"name":"helm-flx","full_name":"PythonNut/helm-flx","owner":{"login":"PythonNut","id":5009546,"avatar_url":"https://avatars.githubusercontent.com/u/5009546?v=3","gravatar_id":"","url":"https://api.github.com/users/PythonNut","html_url":"https://github.com/PythonNut","followers_url":"https://api.github.com/users/PythonNut/followers","following_url":"https://api.github.com/users/PythonNut/following{/other_user}","gists_url":"https://api.github.com/users/PythonNut/gists{/gist_id}","starred_url":"https://api.github.com/users/PythonNut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PythonNut/subscriptions","organizations_url":"https://api.github.com/users/PythonNut/orgs","repos_url":"https://api.github.com/users/PythonNut/repos","events_url":"https://api.github.com/users/PythonNut/events{/privacy}","received_events_url":"https://api.github.com/users/PythonNut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PythonNut/helm-flx","description":"Flx-based fuzzy matching for helm","fork":false,"url":"https://api.github.com/repos/PythonNut/helm-flx","forks_url":"https://api.github.com/repos/PythonNut/helm-flx/forks","keys_url":"https://api.github.com/repos/PythonNut/helm-flx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PythonNut/helm-flx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PythonNut/helm-flx/teams","hooks_url":"https://api.github.com/repos/PythonNut/helm-flx/hooks","issue_events_url":"https://api.github.com/repos/PythonNut/helm-flx/issues/events{/number}","events_url":"https://api.github.com/repos/PythonNut/helm-flx/events","assignees_url":"https://api.github.com/repos/PythonNut/helm-flx/assignees{/user}","branches_url":"https://api.github.com/repos/PythonNut/helm-flx/branches{/branch}","tags_url":"https://api.github.com/repos/PythonNut/helm-flx/tags","blobs_url":"https://api.github.com/repos/PythonNut/helm-flx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PythonNut/helm-flx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PythonNut/helm-flx/git/refs{/sha}","trees_url":"https://api.github.com/repos/PythonNut/helm-flx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PythonNut/helm-flx/statuses/{sha}","languages_url":"https://api.github.com/repos/PythonNut/helm-flx/languages","stargazers_url":"https://api.github.com/repos/PythonNut/helm-flx/stargazers","contributors_url":"https://api.github.com/repos/PythonNut/helm-flx/contributors","subscribers_url":"https://api.github.com/repos/PythonNut/helm-flx/subscribers","subscription_url":"https://api.github.com/repos/PythonNut/helm-flx/subscription","commits_url":"https://api.github.com/repos/PythonNut/helm-flx/commits{/sha}","git_commits_url":"https://api.github.com/repos/PythonNut/helm-flx/git/commits{/sha}","comments_url":"https://api.github.com/repos/PythonNut/helm-flx/comments{/number}","issue_comment_url":"https://api.github.com/repos/PythonNut/helm-flx/issues/comments{/number}","contents_url":"https://api.github.com/repos/PythonNut/helm-flx/contents/{+path}","compare_url":"https://api.github.com/repos/PythonNut/helm-flx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PythonNut/helm-flx/merges","archive_url":"https://api.github.com/repos/PythonNut/helm-flx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PythonNut/helm-flx/downloads","issues_url":"https://api.github.com/repos/PythonNut/helm-flx/issues{/number}","pulls_url":"https://api.github.com/repos/PythonNut/helm-flx/pulls{/number}","milestones_url":"https://api.github.com/repos/PythonNut/helm-flx/milestones{/number}","notifications_url":"https://api.github.com/repos/PythonNut/helm-flx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PythonNut/helm-flx/labels{/name}","releases_url":"https://api.github.com/repos/PythonNut/helm-flx/releases{/id}","created_at":"2015-10-13T21:03:55Z","updated_at":"2015-10-18T13:24:00Z","pushed_at":"2015-10-18T18:37:07Z","git_url":"git://github.com/PythonNut/helm-flx.git","ssh_url":"git@github.com:PythonNut/helm-flx.git","clone_url":"https://github.com/PythonNut/helm-flx.git","svn_url":"https://github.com/PythonNut/helm-flx","homepage":"","size":0,"stargazers_count":10,"watchers_count":10,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8"},"html":{"href":"https://github.com/PythonNut/helm-flx/pull/8"},"issue":{"href":"https://api.github.com/repos/PythonNut/helm-flx/issues/8"},"comments":{"href":"https://api.github.com/repos/PythonNut/helm-flx/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/PythonNut/helm-flx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PythonNut/helm-flx/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/PythonNut/helm-flx/statuses/267b1a8c6fff650d0c4a83059514570693f0eda4"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}