{"action":"created","comment":{"url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/comments/36840887","id":36840887,"diff_hunk":"@@ -78,15 +80,16 @@ public class AdtTask extends DefaultTask {\n         adtArguments.addAll(args)\n     }\n \n-    def handleIfFailed(String antResultProperty, String antOutputProperty) {\n+    def handleIfFailed(String antResultProperty, String antOutputProperty, String antErrorProperty) {","path":"src/main/groovy/org/gradlefx/tasks/adt/AdtTask.groovy","position":34,"original_position":34,"commit_id":"c04e282cee7dd323b9fb5a50170f9d980e7b83de","original_commit_id":"c04e282cee7dd323b9fb5a50170f9d980e7b83de","user":{"login":"matyasatfp","id":9418242,"avatar_url":"https://avatars.githubusercontent.com/u/9418242?v=3","gravatar_id":"","url":"https://api.github.com/users/matyasatfp","html_url":"https://github.com/matyasatfp","followers_url":"https://api.github.com/users/matyasatfp/followers","following_url":"https://api.github.com/users/matyasatfp/following{/other_user}","gists_url":"https://api.github.com/users/matyasatfp/gists{/gist_id}","starred_url":"https://api.github.com/users/matyasatfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyasatfp/subscriptions","organizations_url":"https://api.github.com/users/matyasatfp/orgs","repos_url":"https://api.github.com/users/matyasatfp/repos","events_url":"https://api.github.com/users/matyasatfp/events{/privacy}","received_events_url":"https://api.github.com/users/matyasatfp/received_events","type":"User","site_admin":false},"body":"In the cases I tested `antOutputProperty` seems to be an empty string and `antErrorProperty` holds the error text. But there could be cases when `antOutputProperty` holds something useful, and the extra empy string added to the log wont hurt anyone.","created_at":"2015-08-12T09:26:48Z","updated_at":"2015-08-12T09:26:48Z","html_url":"https://github.com/GradleFx/GradleFx/pull/194#discussion_r36840887","pull_request_url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/comments/36840887"},"html":{"href":"https://github.com/GradleFx/GradleFx/pull/194#discussion_r36840887"},"pull_request":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194","id":42186472,"html_url":"https://github.com/GradleFx/GradleFx/pull/194","diff_url":"https://github.com/GradleFx/GradleFx/pull/194.diff","patch_url":"https://github.com/GradleFx/GradleFx/pull/194.patch","issue_url":"https://api.github.com/repos/GradleFx/GradleFx/issues/194","number":194,"state":"open","locked":false,"title":"Better logging for ADT errors","user":{"login":"matyasf","id":2875286,"avatar_url":"https://avatars.githubusercontent.com/u/2875286?v=3","gravatar_id":"","url":"https://api.github.com/users/matyasf","html_url":"https://github.com/matyasf","followers_url":"https://api.github.com/users/matyasf/followers","following_url":"https://api.github.com/users/matyasf/following{/other_user}","gists_url":"https://api.github.com/users/matyasf/gists{/gist_id}","starred_url":"https://api.github.com/users/matyasf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyasf/subscriptions","organizations_url":"https://api.github.com/users/matyasf/orgs","repos_url":"https://api.github.com/users/matyasf/repos","events_url":"https://api.github.com/users/matyasf/events{/privacy}","received_events_url":"https://api.github.com/users/matyasf/received_events","type":"User","site_admin":false},"body":"With this PR it displays the error text not just an error code. For example:     \r\nUntil now it it displayed\r\n[ant:java] Java Result: 13   \r\n\r\nNow it will display:\r\n[ant:java] Java Result: 13\r\n Unable to enumerate devices","created_at":"2015-08-11T22:36:06Z","updated_at":"2015-08-12T09:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e63d1b0f8d5f2b54a1f71aa0fb42b9d58f836099","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194/commits","review_comments_url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194/comments","review_comment_url":"https://api.github.com/repos/GradleFx/GradleFx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GradleFx/GradleFx/issues/194/comments","statuses_url":"https://api.github.com/repos/GradleFx/GradleFx/statuses/c04e282cee7dd323b9fb5a50170f9d980e7b83de","head":{"label":"matyasatfp:develop","ref":"develop","sha":"c04e282cee7dd323b9fb5a50170f9d980e7b83de","user":{"login":"matyasatfp","id":9418242,"avatar_url":"https://avatars.githubusercontent.com/u/9418242?v=3","gravatar_id":"","url":"https://api.github.com/users/matyasatfp","html_url":"https://github.com/matyasatfp","followers_url":"https://api.github.com/users/matyasatfp/followers","following_url":"https://api.github.com/users/matyasatfp/following{/other_user}","gists_url":"https://api.github.com/users/matyasatfp/gists{/gist_id}","starred_url":"https://api.github.com/users/matyasatfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyasatfp/subscriptions","organizations_url":"https://api.github.com/users/matyasatfp/orgs","repos_url":"https://api.github.com/users/matyasatfp/repos","events_url":"https://api.github.com/users/matyasatfp/events{/privacy}","received_events_url":"https://api.github.com/users/matyasatfp/received_events","type":"User","site_admin":false},"repo":{"id":25985567,"name":"GradleFx","full_name":"matyasatfp/GradleFx","owner":{"login":"matyasatfp","id":9418242,"avatar_url":"https://avatars.githubusercontent.com/u/9418242?v=3","gravatar_id":"","url":"https://api.github.com/users/matyasatfp","html_url":"https://github.com/matyasatfp","followers_url":"https://api.github.com/users/matyasatfp/followers","following_url":"https://api.github.com/users/matyasatfp/following{/other_user}","gists_url":"https://api.github.com/users/matyasatfp/gists{/gist_id}","starred_url":"https://api.github.com/users/matyasatfp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyasatfp/subscriptions","organizations_url":"https://api.github.com/users/matyasatfp/orgs","repos_url":"https://api.github.com/users/matyasatfp/repos","events_url":"https://api.github.com/users/matyasatfp/events{/privacy}","received_events_url":"https://api.github.com/users/matyasatfp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matyasatfp/GradleFx","description":"Gradle plugin for building Flex projects. LATEST VERSION: 0.8.3","fork":true,"url":"https://api.github.com/repos/matyasatfp/GradleFx","forks_url":"https://api.github.com/repos/matyasatfp/GradleFx/forks","keys_url":"https://api.github.com/repos/matyasatfp/GradleFx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matyasatfp/GradleFx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matyasatfp/GradleFx/teams","hooks_url":"https://api.github.com/repos/matyasatfp/GradleFx/hooks","issue_events_url":"https://api.github.com/repos/matyasatfp/GradleFx/issues/events{/number}","events_url":"https://api.github.com/repos/matyasatfp/GradleFx/events","assignees_url":"https://api.github.com/repos/matyasatfp/GradleFx/assignees{/user}","branches_url":"https://api.github.com/repos/matyasatfp/GradleFx/branches{/branch}","tags_url":"https://api.github.com/repos/matyasatfp/GradleFx/tags","blobs_url":"https://api.github.com/repos/matyasatfp/GradleFx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matyasatfp/GradleFx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matyasatfp/GradleFx/git/refs{/sha}","trees_url":"https://api.github.com/repos/matyasatfp/GradleFx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matyasatfp/GradleFx/statuses/{sha}","languages_url":"https://api.github.com/repos/matyasatfp/GradleFx/languages","stargazers_url":"https://api.github.com/repos/matyasatfp/GradleFx/stargazers","contributors_url":"https://api.github.com/repos/matyasatfp/GradleFx/contributors","subscribers_url":"https://api.github.com/repos/matyasatfp/GradleFx/subscribers","subscription_url":"https://api.github.com/repos/matyasatfp/GradleFx/subscription","commits_url":"https://api.github.com/repos/matyasatfp/GradleFx/commits{/sha}","git_commits_url":"https://api.github.com/repos/matyasatfp/GradleFx/git/commits{/sha}","comments_url":"https://api.github.com/repos/matyasatfp/GradleFx/comments{/number}","issue_comment_url":"https://api.github.com/repos/matyasatfp/GradleFx/issues/comments{/number}","contents_url":"https://api.github.com/repos/matyasatfp/GradleFx/contents/{+path}","compare_url":"https://api.github.com/repos/matyasatfp/GradleFx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matyasatfp/GradleFx/merges","archive_url":"https://api.github.com/repos/matyasatfp/GradleFx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matyasatfp/GradleFx/downloads","issues_url":"https://api.github.com/repos/matyasatfp/GradleFx/issues{/number}","pulls_url":"https://api.github.com/repos/matyasatfp/GradleFx/pulls{/number}","milestones_url":"https://api.github.com/repos/matyasatfp/GradleFx/milestones{/number}","notifications_url":"https://api.github.com/repos/matyasatfp/GradleFx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matyasatfp/GradleFx/labels{/name}","releases_url":"https://api.github.com/repos/matyasatfp/GradleFx/releases{/id}","created_at":"2014-10-30T19:04:04Z","updated_at":"2014-10-30T19:07:58Z","pushed_at":"2015-08-11T22:32:41Z","git_url":"git://github.com/matyasatfp/GradleFx.git","ssh_url":"git@github.com:matyasatfp/GradleFx.git","clone_url":"https://github.com/matyasatfp/GradleFx.git","svn_url":"https://github.com/matyasatfp/GradleFx","homepage":"http://doc.gradlefx.org","size":1837,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GradleFx:develop","ref":"develop","sha":"1d29fffbe03c43414a3d79657a8867a6978f975b","user":{"login":"GradleFx","id":823995,"avatar_url":"https://avatars.githubusercontent.com/u/823995?v=3","gravatar_id":"","url":"https://api.github.com/users/GradleFx","html_url":"https://github.com/GradleFx","followers_url":"https://api.github.com/users/GradleFx/followers","following_url":"https://api.github.com/users/GradleFx/following{/other_user}","gists_url":"https://api.github.com/users/GradleFx/gists{/gist_id}","starred_url":"https://api.github.com/users/GradleFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GradleFx/subscriptions","organizations_url":"https://api.github.com/users/GradleFx/orgs","repos_url":"https://api.github.com/users/GradleFx/repos","events_url":"https://api.github.com/users/GradleFx/events{/privacy}","received_events_url":"https://api.github.com/users/GradleFx/received_events","type":"Organization","site_admin":false},"repo":{"id":1834068,"name":"GradleFx","full_name":"GradleFx/GradleFx","owner":{"login":"GradleFx","id":823995,"avatar_url":"https://avatars.githubusercontent.com/u/823995?v=3","gravatar_id":"","url":"https://api.github.com/users/GradleFx","html_url":"https://github.com/GradleFx","followers_url":"https://api.github.com/users/GradleFx/followers","following_url":"https://api.github.com/users/GradleFx/following{/other_user}","gists_url":"https://api.github.com/users/GradleFx/gists{/gist_id}","starred_url":"https://api.github.com/users/GradleFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GradleFx/subscriptions","organizations_url":"https://api.github.com/users/GradleFx/orgs","repos_url":"https://api.github.com/users/GradleFx/repos","events_url":"https://api.github.com/users/GradleFx/events{/privacy}","received_events_url":"https://api.github.com/users/GradleFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GradleFx/GradleFx","description":"Gradle plugin for building Flex projects.","fork":false,"url":"https://api.github.com/repos/GradleFx/GradleFx","forks_url":"https://api.github.com/repos/GradleFx/GradleFx/forks","keys_url":"https://api.github.com/repos/GradleFx/GradleFx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GradleFx/GradleFx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GradleFx/GradleFx/teams","hooks_url":"https://api.github.com/repos/GradleFx/GradleFx/hooks","issue_events_url":"https://api.github.com/repos/GradleFx/GradleFx/issues/events{/number}","events_url":"https://api.github.com/repos/GradleFx/GradleFx/events","assignees_url":"https://api.github.com/repos/GradleFx/GradleFx/assignees{/user}","branches_url":"https://api.github.com/repos/GradleFx/GradleFx/branches{/branch}","tags_url":"https://api.github.com/repos/GradleFx/GradleFx/tags","blobs_url":"https://api.github.com/repos/GradleFx/GradleFx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GradleFx/GradleFx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GradleFx/GradleFx/git/refs{/sha}","trees_url":"https://api.github.com/repos/GradleFx/GradleFx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GradleFx/GradleFx/statuses/{sha}","languages_url":"https://api.github.com/repos/GradleFx/GradleFx/languages","stargazers_url":"https://api.github.com/repos/GradleFx/GradleFx/stargazers","contributors_url":"https://api.github.com/repos/GradleFx/GradleFx/contributors","subscribers_url":"https://api.github.com/repos/GradleFx/GradleFx/subscribers","subscription_url":"https://api.github.com/repos/GradleFx/GradleFx/subscription","commits_url":"https://api.github.com/repos/GradleFx/GradleFx/commits{/sha}","git_commits_url":"https://api.github.com/repos/GradleFx/GradleFx/git/commits{/sha}","comments_url":"https://api.github.com/repos/GradleFx/GradleFx/comments{/number}","issue_comment_url":"https://api.github.com/repos/GradleFx/GradleFx/issues/comments{/number}","contents_url":"https://api.github.com/repos/GradleFx/GradleFx/contents/{+path}","compare_url":"https://api.github.com/repos/GradleFx/GradleFx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GradleFx/GradleFx/merges","archive_url":"https://api.github.com/repos/GradleFx/GradleFx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GradleFx/GradleFx/downloads","issues_url":"https://api.github.com/repos/GradleFx/GradleFx/issues{/number}","pulls_url":"https://api.github.com/repos/GradleFx/GradleFx/pulls{/number}","milestones_url":"https://api.github.com/repos/GradleFx/GradleFx/milestones{/number}","notifications_url":"https://api.github.com/repos/GradleFx/GradleFx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GradleFx/GradleFx/labels{/name}","releases_url":"https://api.github.com/repos/GradleFx/GradleFx/releases{/id}","created_at":"2011-06-01T20:50:52Z","updated_at":"2015-08-11T21:06:11Z","pushed_at":"2015-08-11T22:36:06Z","git_url":"git://github.com/GradleFx/GradleFx.git","ssh_url":"git@github.com:GradleFx/GradleFx.git","clone_url":"https://github.com/GradleFx/GradleFx.git","svn_url":"https://github.com/GradleFx/GradleFx","homepage":"http://doc.gradlefx.org","size":2468,"stargazers_count":112,"watchers_count":112,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":39,"forks":61,"open_issues":39,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194"},"html":{"href":"https://github.com/GradleFx/GradleFx/pull/194"},"issue":{"href":"https://api.github.com/repos/GradleFx/GradleFx/issues/194"},"comments":{"href":"https://api.github.com/repos/GradleFx/GradleFx/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GradleFx/GradleFx/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/GradleFx/GradleFx/statuses/c04e282cee7dd323b9fb5a50170f9d980e7b83de"}}}}