{"action":"created","comment":{"url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/comments/33224219","id":33224219,"diff_hunk":"@@ -1656,18 +1682,52 @@ destructor TOmniTaskExecutor.Destroy;\n   FreeAndNil(oteTerminateHandles);\r\n   FreeAndNil(oteMethodHash);\r\n   FreeAndNil(oteException);\r\n-  DSiCloseHandleAndNull(oteCommRebuildHandles);\r","path":"OtlTaskControl.pas","position":413,"original_position":413,"commit_id":"0ac7db57644302c5896418da64c78755e3a1f1fd","original_commit_id":"0ac7db57644302c5896418da64c78755e3a1f1fd","user":{"login":"SeanBDurkin","id":6110042,"avatar_url":"https://avatars.githubusercontent.com/u/6110042?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanBDurkin","html_url":"https://github.com/SeanBDurkin","followers_url":"https://api.github.com/users/SeanBDurkin/followers","following_url":"https://api.github.com/users/SeanBDurkin/following{/other_user}","gists_url":"https://api.github.com/users/SeanBDurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanBDurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanBDurkin/subscriptions","organizations_url":"https://api.github.com/users/SeanBDurkin/orgs","repos_url":"https://api.github.com/users/SeanBDurkin/repos","events_url":"https://api.github.com/users/SeanBDurkin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanBDurkin/received_events","type":"User","site_admin":false},"body":"It is still there. It is just hidden by compiler magic. oteCommRebuildHandles is now an interface pointer of type IOmniEvent. When the TOmniTaskExecutor object is destroyed, the interface data members are de-referenced, and when the reference count reaches zero, the event resource is then de-allocated.","created_at":"2015-06-25T05:51:22Z","updated_at":"2015-06-25T05:51:22Z","html_url":"https://github.com/gabr42/OmniThreadLibrary/pull/36#discussion_r33224219","pull_request_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/comments/33224219"},"html":{"href":"https://github.com/gabr42/OmniThreadLibrary/pull/36#discussion_r33224219"},"pull_request":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36","id":36359595,"html_url":"https://github.com/gabr42/OmniThreadLibrary/pull/36","diff_url":"https://github.com/gabr42/OmniThreadLibrary/pull/36.diff","patch_url":"https://github.com/gabr42/OmniThreadLibrary/pull/36.patch","issue_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/36","number":36,"state":"open","locked":false,"title":"My double-down attempt to upgrade OtlContainers.pas","user":{"login":"SeanBDurkin","id":6110042,"avatar_url":"https://avatars.githubusercontent.com/u/6110042?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanBDurkin","html_url":"https://github.com/SeanBDurkin","followers_url":"https://api.github.com/users/SeanBDurkin/followers","following_url":"https://api.github.com/users/SeanBDurkin/following{/other_user}","gists_url":"https://api.github.com/users/SeanBDurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanBDurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanBDurkin/subscriptions","organizations_url":"https://api.github.com/users/SeanBDurkin/orgs","repos_url":"https://api.github.com/users/SeanBDurkin/repos","events_url":"https://api.github.com/users/SeanBDurkin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanBDurkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-27T23:35:41Z","updated_at":"2015-06-25T05:51:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ebeaded623a42a7a1ff3947c82ca5cc2650ea5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36/commits","review_comments_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36/comments","review_comment_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/36/comments","statuses_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/statuses/0ac7db57644302c5896418da64c78755e3a1f1fd","head":{"label":"SeanBDurkin:mobile","ref":"mobile","sha":"0ac7db57644302c5896418da64c78755e3a1f1fd","user":{"login":"SeanBDurkin","id":6110042,"avatar_url":"https://avatars.githubusercontent.com/u/6110042?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanBDurkin","html_url":"https://github.com/SeanBDurkin","followers_url":"https://api.github.com/users/SeanBDurkin/followers","following_url":"https://api.github.com/users/SeanBDurkin/following{/other_user}","gists_url":"https://api.github.com/users/SeanBDurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanBDurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanBDurkin/subscriptions","organizations_url":"https://api.github.com/users/SeanBDurkin/orgs","repos_url":"https://api.github.com/users/SeanBDurkin/repos","events_url":"https://api.github.com/users/SeanBDurkin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanBDurkin/received_events","type":"User","site_admin":false},"repo":{"id":35395324,"name":"OmniThreadLibrary","full_name":"SeanBDurkin/OmniThreadLibrary","owner":{"login":"SeanBDurkin","id":6110042,"avatar_url":"https://avatars.githubusercontent.com/u/6110042?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanBDurkin","html_url":"https://github.com/SeanBDurkin","followers_url":"https://api.github.com/users/SeanBDurkin/followers","following_url":"https://api.github.com/users/SeanBDurkin/following{/other_user}","gists_url":"https://api.github.com/users/SeanBDurkin/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanBDurkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanBDurkin/subscriptions","organizations_url":"https://api.github.com/users/SeanBDurkin/orgs","repos_url":"https://api.github.com/users/SeanBDurkin/repos","events_url":"https://api.github.com/users/SeanBDurkin/events{/privacy}","received_events_url":"https://api.github.com/users/SeanBDurkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeanBDurkin/OmniThreadLibrary","description":"A simple and powerful multithreading library for Delphi","fork":true,"url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary","forks_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/forks","keys_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/teams","hooks_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/hooks","issue_events_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/issues/events{/number}","events_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/events","assignees_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/assignees{/user}","branches_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/branches{/branch}","tags_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/tags","blobs_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/languages","stargazers_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/stargazers","contributors_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/contributors","subscribers_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/subscribers","subscription_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/subscription","commits_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/contents/{+path}","compare_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/merges","archive_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/downloads","issues_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/issues{/number}","pulls_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/labels{/name}","releases_url":"https://api.github.com/repos/SeanBDurkin/OmniThreadLibrary/releases{/id}","created_at":"2015-05-11T01:25:14Z","updated_at":"2015-05-11T01:25:19Z","pushed_at":"2015-05-27T23:34:06Z","git_url":"git://github.com/SeanBDurkin/OmniThreadLibrary.git","ssh_url":"git@github.com:SeanBDurkin/OmniThreadLibrary.git","clone_url":"https://github.com/SeanBDurkin/OmniThreadLibrary.git","svn_url":"https://github.com/SeanBDurkin/OmniThreadLibrary","homepage":"","size":5622,"stargazers_count":0,"watchers_count":0,"language":"Pascal","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mobile"}},"base":{"label":"gabr42:mobile","ref":"mobile","sha":"9f3fae30295e39c8cbf27c5abd615b1e99f63443","user":{"login":"gabr42","id":2873801,"avatar_url":"https://avatars.githubusercontent.com/u/2873801?v=3","gravatar_id":"","url":"https://api.github.com/users/gabr42","html_url":"https://github.com/gabr42","followers_url":"https://api.github.com/users/gabr42/followers","following_url":"https://api.github.com/users/gabr42/following{/other_user}","gists_url":"https://api.github.com/users/gabr42/gists{/gist_id}","starred_url":"https://api.github.com/users/gabr42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabr42/subscriptions","organizations_url":"https://api.github.com/users/gabr42/orgs","repos_url":"https://api.github.com/users/gabr42/repos","events_url":"https://api.github.com/users/gabr42/events{/privacy}","received_events_url":"https://api.github.com/users/gabr42/received_events","type":"User","site_admin":false},"repo":{"id":34079338,"name":"OmniThreadLibrary","full_name":"gabr42/OmniThreadLibrary","owner":{"login":"gabr42","id":2873801,"avatar_url":"https://avatars.githubusercontent.com/u/2873801?v=3","gravatar_id":"","url":"https://api.github.com/users/gabr42","html_url":"https://github.com/gabr42","followers_url":"https://api.github.com/users/gabr42/followers","following_url":"https://api.github.com/users/gabr42/following{/other_user}","gists_url":"https://api.github.com/users/gabr42/gists{/gist_id}","starred_url":"https://api.github.com/users/gabr42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabr42/subscriptions","organizations_url":"https://api.github.com/users/gabr42/orgs","repos_url":"https://api.github.com/users/gabr42/repos","events_url":"https://api.github.com/users/gabr42/events{/privacy}","received_events_url":"https://api.github.com/users/gabr42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabr42/OmniThreadLibrary","description":"A simple and powerful multithreading library for Delphi","fork":false,"url":"https://api.github.com/repos/gabr42/OmniThreadLibrary","forks_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/forks","keys_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/teams","hooks_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/hooks","issue_events_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/events{/number}","events_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/events","assignees_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/assignees{/user}","branches_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/branches{/branch}","tags_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/tags","blobs_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/languages","stargazers_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/stargazers","contributors_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/contributors","subscribers_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/subscribers","subscription_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/subscription","commits_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/contents/{+path}","compare_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/merges","archive_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/downloads","issues_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues{/number}","pulls_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/labels{/name}","releases_url":"https://api.github.com/repos/gabr42/OmniThreadLibrary/releases{/id}","created_at":"2015-04-16T20:38:28Z","updated_at":"2015-06-15T20:02:03Z","pushed_at":"2015-05-27T23:35:41Z","git_url":"git://github.com/gabr42/OmniThreadLibrary.git","ssh_url":"git@github.com:gabr42/OmniThreadLibrary.git","clone_url":"https://github.com/gabr42/OmniThreadLibrary.git","svn_url":"https://github.com/gabr42/OmniThreadLibrary","homepage":"","size":9466,"stargazers_count":29,"watchers_count":29,"language":"Pascal","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36"},"html":{"href":"https://github.com/gabr42/OmniThreadLibrary/pull/36"},"issue":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/36"},"comments":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/gabr42/OmniThreadLibrary/statuses/0ac7db57644302c5896418da64c78755e3a1f1fd"}}}}