{"action":"created","comment":{"url":"https://api.github.com/repos/Elao/curvytron/pulls/comments/27806045","id":27806045,"diff_hunk":"@@ -1,20 +1,22 @@\n /**\n  * RoomsRepository\n  *\n- * @param {SocketCLient} client\n+ * @param {SocketClient} client\n  */\n function RoomsRepository(client)\n {\n     EventEmitter.call(this);\n \n-    this.client = client;\n-    this.rooms  = new Collection([], 'name');\n+    this.client       = client;\n+    this.rooms        = new Collection([], 'name');\n+    this.nbPlayers    = 0;","path":"src/client/repository/RoomsRepository.js","position":15,"original_position":15,"commit_id":"10d44cd4dbafc973b19f7befffe532042ce70f21","original_commit_id":"10d44cd4dbafc973b19f7befffe532042ce70f21","user":{"login":"Tom32i","id":1846873,"avatar_url":"https://avatars.githubusercontent.com/u/1846873?v=3","gravatar_id":"","url":"https://api.github.com/users/Tom32i","html_url":"https://github.com/Tom32i","followers_url":"https://api.github.com/users/Tom32i/followers","following_url":"https://api.github.com/users/Tom32i/following{/other_user}","gists_url":"https://api.github.com/users/Tom32i/gists{/gist_id}","starred_url":"https://api.github.com/users/Tom32i/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tom32i/subscriptions","organizations_url":"https://api.github.com/users/Tom32i/orgs","repos_url":"https://api.github.com/users/Tom32i/repos","events_url":"https://api.github.com/users/Tom32i/events{/privacy}","received_events_url":"https://api.github.com/users/Tom32i/received_events","type":"User","site_admin":false},"body":"Not a big fan of abbreviations in variable names: maybe rename to `totalPlayers` or `totalClients`?","created_at":"2015-04-06T15:56:26Z","updated_at":"2015-04-06T15:56:26Z","html_url":"https://github.com/Elao/curvytron/pull/169#discussion_r27806045","pull_request_url":"https://api.github.com/repos/Elao/curvytron/pulls/169","_links":{"self":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/comments/27806045"},"html":{"href":"https://github.com/Elao/curvytron/pull/169#discussion_r27806045"},"pull_request":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/Elao/curvytron/pulls/169","id":32680531,"html_url":"https://github.com/Elao/curvytron/pull/169","diff_url":"https://github.com/Elao/curvytron/pull/169.diff","patch_url":"https://github.com/Elao/curvytron/pull/169.patch","issue_url":"https://api.github.com/repos/Elao/curvytron/issues/169","number":169,"state":"open","locked":false,"title":"[RFR] Display nb connected opponents on rooms page","user":{"login":"DaphDaOne","id":3803406,"avatar_url":"https://avatars.githubusercontent.com/u/3803406?v=3","gravatar_id":"","url":"https://api.github.com/users/DaphDaOne","html_url":"https://github.com/DaphDaOne","followers_url":"https://api.github.com/users/DaphDaOne/followers","following_url":"https://api.github.com/users/DaphDaOne/following{/other_user}","gists_url":"https://api.github.com/users/DaphDaOne/gists{/gist_id}","starred_url":"https://api.github.com/users/DaphDaOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaphDaOne/subscriptions","organizations_url":"https://api.github.com/users/DaphDaOne/orgs","repos_url":"https://api.github.com/users/DaphDaOne/repos","events_url":"https://api.github.com/users/DaphDaOne/events{/privacy}","received_events_url":"https://api.github.com/users/DaphDaOne/received_events","type":"User","site_admin":false},"body":"On rooms page, display a message with the nb of connected opponents.\r\n* If no other players & no room : \"You can start by creating a room:\"\r\n* If other players & no room : \"1 opponent connected, no room created.\"\r\n* If other players & at least one room: \"2  opponents connected, with 1 room.\"","created_at":"2015-04-06T14:08:08Z","updated_at":"2015-04-06T15:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de5f70eae57729aa1ab01c350cc4f32c3fcd7430","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Elao/curvytron/pulls/169/commits","review_comments_url":"https://api.github.com/repos/Elao/curvytron/pulls/169/comments","review_comment_url":"https://api.github.com/repos/Elao/curvytron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Elao/curvytron/issues/169/comments","statuses_url":"https://api.github.com/repos/Elao/curvytron/statuses/10d44cd4dbafc973b19f7befffe532042ce70f21","head":{"label":"DaphDaOne:nb_players","ref":"nb_players","sha":"10d44cd4dbafc973b19f7befffe532042ce70f21","user":{"login":"DaphDaOne","id":3803406,"avatar_url":"https://avatars.githubusercontent.com/u/3803406?v=3","gravatar_id":"","url":"https://api.github.com/users/DaphDaOne","html_url":"https://github.com/DaphDaOne","followers_url":"https://api.github.com/users/DaphDaOne/followers","following_url":"https://api.github.com/users/DaphDaOne/following{/other_user}","gists_url":"https://api.github.com/users/DaphDaOne/gists{/gist_id}","starred_url":"https://api.github.com/users/DaphDaOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaphDaOne/subscriptions","organizations_url":"https://api.github.com/users/DaphDaOne/orgs","repos_url":"https://api.github.com/users/DaphDaOne/repos","events_url":"https://api.github.com/users/DaphDaOne/events{/privacy}","received_events_url":"https://api.github.com/users/DaphDaOne/received_events","type":"User","site_admin":false},"repo":{"id":32582939,"name":"curvytron","full_name":"DaphDaOne/curvytron","owner":{"login":"DaphDaOne","id":3803406,"avatar_url":"https://avatars.githubusercontent.com/u/3803406?v=3","gravatar_id":"","url":"https://api.github.com/users/DaphDaOne","html_url":"https://github.com/DaphDaOne","followers_url":"https://api.github.com/users/DaphDaOne/followers","following_url":"https://api.github.com/users/DaphDaOne/following{/other_user}","gists_url":"https://api.github.com/users/DaphDaOne/gists{/gist_id}","starred_url":"https://api.github.com/users/DaphDaOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaphDaOne/subscriptions","organizations_url":"https://api.github.com/users/DaphDaOne/orgs","repos_url":"https://api.github.com/users/DaphDaOne/repos","events_url":"https://api.github.com/users/DaphDaOne/events{/privacy}","received_events_url":"https://api.github.com/users/DaphDaOne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaphDaOne/curvytron","description":"A web multiplayer Tron game like with curves","fork":true,"url":"https://api.github.com/repos/DaphDaOne/curvytron","forks_url":"https://api.github.com/repos/DaphDaOne/curvytron/forks","keys_url":"https://api.github.com/repos/DaphDaOne/curvytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaphDaOne/curvytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaphDaOne/curvytron/teams","hooks_url":"https://api.github.com/repos/DaphDaOne/curvytron/hooks","issue_events_url":"https://api.github.com/repos/DaphDaOne/curvytron/issues/events{/number}","events_url":"https://api.github.com/repos/DaphDaOne/curvytron/events","assignees_url":"https://api.github.com/repos/DaphDaOne/curvytron/assignees{/user}","branches_url":"https://api.github.com/repos/DaphDaOne/curvytron/branches{/branch}","tags_url":"https://api.github.com/repos/DaphDaOne/curvytron/tags","blobs_url":"https://api.github.com/repos/DaphDaOne/curvytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaphDaOne/curvytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaphDaOne/curvytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaphDaOne/curvytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaphDaOne/curvytron/statuses/{sha}","languages_url":"https://api.github.com/repos/DaphDaOne/curvytron/languages","stargazers_url":"https://api.github.com/repos/DaphDaOne/curvytron/stargazers","contributors_url":"https://api.github.com/repos/DaphDaOne/curvytron/contributors","subscribers_url":"https://api.github.com/repos/DaphDaOne/curvytron/subscribers","subscription_url":"https://api.github.com/repos/DaphDaOne/curvytron/subscription","commits_url":"https://api.github.com/repos/DaphDaOne/curvytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaphDaOne/curvytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaphDaOne/curvytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaphDaOne/curvytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaphDaOne/curvytron/contents/{+path}","compare_url":"https://api.github.com/repos/DaphDaOne/curvytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaphDaOne/curvytron/merges","archive_url":"https://api.github.com/repos/DaphDaOne/curvytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaphDaOne/curvytron/downloads","issues_url":"https://api.github.com/repos/DaphDaOne/curvytron/issues{/number}","pulls_url":"https://api.github.com/repos/DaphDaOne/curvytron/pulls{/number}","milestones_url":"https://api.github.com/repos/DaphDaOne/curvytron/milestones{/number}","notifications_url":"https://api.github.com/repos/DaphDaOne/curvytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaphDaOne/curvytron/labels{/name}","releases_url":"https://api.github.com/repos/DaphDaOne/curvytron/releases{/id}","created_at":"2015-03-20T12:39:21Z","updated_at":"2015-03-20T12:39:22Z","pushed_at":"2015-04-06T14:13:07Z","git_url":"git://github.com/DaphDaOne/curvytron.git","ssh_url":"git@github.com:DaphDaOne/curvytron.git","clone_url":"https://github.com/DaphDaOne/curvytron.git","svn_url":"https://github.com/DaphDaOne/curvytron","homepage":"http://www.curvytron.com","size":3121,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Elao:develop","ref":"develop","sha":"434f95e0e0424b2eb9d2aeaa5ceb619ada831292","user":{"login":"Elao","id":623877,"avatar_url":"https://avatars.githubusercontent.com/u/623877?v=3","gravatar_id":"","url":"https://api.github.com/users/Elao","html_url":"https://github.com/Elao","followers_url":"https://api.github.com/users/Elao/followers","following_url":"https://api.github.com/users/Elao/following{/other_user}","gists_url":"https://api.github.com/users/Elao/gists{/gist_id}","starred_url":"https://api.github.com/users/Elao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elao/subscriptions","organizations_url":"https://api.github.com/users/Elao/orgs","repos_url":"https://api.github.com/users/Elao/repos","events_url":"https://api.github.com/users/Elao/events{/privacy}","received_events_url":"https://api.github.com/users/Elao/received_events","type":"Organization","site_admin":false},"repo":{"id":20557977,"name":"curvytron","full_name":"Elao/curvytron","owner":{"login":"Elao","id":623877,"avatar_url":"https://avatars.githubusercontent.com/u/623877?v=3","gravatar_id":"","url":"https://api.github.com/users/Elao","html_url":"https://github.com/Elao","followers_url":"https://api.github.com/users/Elao/followers","following_url":"https://api.github.com/users/Elao/following{/other_user}","gists_url":"https://api.github.com/users/Elao/gists{/gist_id}","starred_url":"https://api.github.com/users/Elao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elao/subscriptions","organizations_url":"https://api.github.com/users/Elao/orgs","repos_url":"https://api.github.com/users/Elao/repos","events_url":"https://api.github.com/users/Elao/events{/privacy}","received_events_url":"https://api.github.com/users/Elao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Elao/curvytron","description":"A web multiplayer Tron game like with curves","fork":false,"url":"https://api.github.com/repos/Elao/curvytron","forks_url":"https://api.github.com/repos/Elao/curvytron/forks","keys_url":"https://api.github.com/repos/Elao/curvytron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Elao/curvytron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Elao/curvytron/teams","hooks_url":"https://api.github.com/repos/Elao/curvytron/hooks","issue_events_url":"https://api.github.com/repos/Elao/curvytron/issues/events{/number}","events_url":"https://api.github.com/repos/Elao/curvytron/events","assignees_url":"https://api.github.com/repos/Elao/curvytron/assignees{/user}","branches_url":"https://api.github.com/repos/Elao/curvytron/branches{/branch}","tags_url":"https://api.github.com/repos/Elao/curvytron/tags","blobs_url":"https://api.github.com/repos/Elao/curvytron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Elao/curvytron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Elao/curvytron/git/refs{/sha}","trees_url":"https://api.github.com/repos/Elao/curvytron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Elao/curvytron/statuses/{sha}","languages_url":"https://api.github.com/repos/Elao/curvytron/languages","stargazers_url":"https://api.github.com/repos/Elao/curvytron/stargazers","contributors_url":"https://api.github.com/repos/Elao/curvytron/contributors","subscribers_url":"https://api.github.com/repos/Elao/curvytron/subscribers","subscription_url":"https://api.github.com/repos/Elao/curvytron/subscription","commits_url":"https://api.github.com/repos/Elao/curvytron/commits{/sha}","git_commits_url":"https://api.github.com/repos/Elao/curvytron/git/commits{/sha}","comments_url":"https://api.github.com/repos/Elao/curvytron/comments{/number}","issue_comment_url":"https://api.github.com/repos/Elao/curvytron/issues/comments{/number}","contents_url":"https://api.github.com/repos/Elao/curvytron/contents/{+path}","compare_url":"https://api.github.com/repos/Elao/curvytron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Elao/curvytron/merges","archive_url":"https://api.github.com/repos/Elao/curvytron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Elao/curvytron/downloads","issues_url":"https://api.github.com/repos/Elao/curvytron/issues{/number}","pulls_url":"https://api.github.com/repos/Elao/curvytron/pulls{/number}","milestones_url":"https://api.github.com/repos/Elao/curvytron/milestones{/number}","notifications_url":"https://api.github.com/repos/Elao/curvytron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Elao/curvytron/labels{/name}","releases_url":"https://api.github.com/repos/Elao/curvytron/releases{/id}","created_at":"2014-06-06T09:16:25Z","updated_at":"2015-04-03T07:57:37Z","pushed_at":"2015-04-06T15:44:55Z","git_url":"git://github.com/Elao/curvytron.git","ssh_url":"git@github.com:Elao/curvytron.git","clone_url":"https://github.com/Elao/curvytron.git","svn_url":"https://github.com/Elao/curvytron","homepage":"http://www.curvytron.com","size":5668,"stargazers_count":29,"watchers_count":29,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":28,"forks":10,"open_issues":28,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/169"},"html":{"href":"https://github.com/Elao/curvytron/pull/169"},"issue":{"href":"https://api.github.com/repos/Elao/curvytron/issues/169"},"comments":{"href":"https://api.github.com/repos/Elao/curvytron/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Elao/curvytron/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/Elao/curvytron/statuses/10d44cd4dbafc973b19f7befffe532042ce70f21"}}}}