{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/44033075","id":44033075,"diff_hunk":"@@ -360,8 +364,18 @@ - (BOOL)application:(UIApplication *)p_application didFinishLaunchingWithOptions\n     NSDictionary *t_push_notification = [p_launchOptions objectForKey: UIApplicationLaunchOptionsRemoteNotificationKey];\n     // MM-2012-09-25: [[ Bug 10391 ]] Retain notification.\n     if (t_push_notification)\n-        m_pending_push_notification = [[t_push_notification objectForKey:@\"payload\"] retain];\n-\n+\t{\n+\t\t// Prevent crash when launching the app from the notifications screen:\n+\t\t// If the payload is empty, JSON null will be deserialized to NSNull. Unlike nil,\n+\t\t// we cannot send (most) messages to NSNull\n+\t\tid t_pending_push_notification_value = [[t_push_notification objectForKey:@\"payload\"] retain];","path":"engine/src/mbliphoneapp.mm","position":23,"original_position":23,"commit_id":"e1cf21011834f924feeaa4ce324e6a876393a330","original_commit_id":"e1cf21011834f924feeaa4ce324e6a876393a330","user":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"body":"I guess yes, because of bug 10391:\r\nhttp://quality.runrev.com/show_bug.cgi?id=10391","created_at":"2015-11-05T16:31:24Z","updated_at":"2015-11-05T16:31:24Z","html_url":"https://github.com/livecode/livecode/pull/3129#discussion_r44033075","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/3129","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/44033075"},"html":{"href":"https://github.com/livecode/livecode/pull/3129#discussion_r44033075"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3129"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/3129","id":48891956,"html_url":"https://github.com/livecode/livecode/pull/3129","diff_url":"https://github.com/livecode/livecode/pull/3129.diff","patch_url":"https://github.com/livecode/livecode/pull/3129.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/3129","number":3129,"state":"open","locked":false,"title":"[Bug 16279] Prevent crash when creating notifications with empty payload ","user":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-27T16:03:13Z","updated_at":"2015-11-05T16:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a48530b494e105645c4c2bffb2fade405819007","assignee":null,"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/74","html_url":"https://github.com/livecode/livecode/milestones/7.1.2-rc-1","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/74/labels","id":1334574,"number":74,"title":"7.1.2-rc-1","description":null,"creator":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2015-10-02T09:21:34Z","updated_at":"2015-11-04T23:12:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/3129/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/3129/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/3129/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/e1cf21011834f924feeaa4ce324e6a876393a330","head":{"label":"livecodepanos:bugfix-16279","ref":"bugfix-16279","sha":"e1cf21011834f924feeaa4ce324e6a876393a330","user":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"repo":{"id":11736489,"name":"livecode","full_name":"livecodepanos/livecode","owner":{"login":"livecodepanos","id":5111835,"avatar_url":"https://avatars.githubusercontent.com/u/5111835?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodepanos","html_url":"https://github.com/livecodepanos","followers_url":"https://api.github.com/users/livecodepanos/followers","following_url":"https://api.github.com/users/livecodepanos/following{/other_user}","gists_url":"https://api.github.com/users/livecodepanos/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodepanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodepanos/subscriptions","organizations_url":"https://api.github.com/users/livecodepanos/orgs","repos_url":"https://api.github.com/users/livecodepanos/repos","events_url":"https://api.github.com/users/livecodepanos/events{/privacy}","received_events_url":"https://api.github.com/users/livecodepanos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/livecodepanos/livecode","description":"","fork":true,"url":"https://api.github.com/repos/livecodepanos/livecode","forks_url":"https://api.github.com/repos/livecodepanos/livecode/forks","keys_url":"https://api.github.com/repos/livecodepanos/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecodepanos/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecodepanos/livecode/teams","hooks_url":"https://api.github.com/repos/livecodepanos/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecodepanos/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecodepanos/livecode/events","assignees_url":"https://api.github.com/repos/livecodepanos/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecodepanos/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecodepanos/livecode/tags","blobs_url":"https://api.github.com/repos/livecodepanos/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecodepanos/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecodepanos/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecodepanos/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecodepanos/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecodepanos/livecode/languages","stargazers_url":"https://api.github.com/repos/livecodepanos/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecodepanos/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecodepanos/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecodepanos/livecode/subscription","commits_url":"https://api.github.com/repos/livecodepanos/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecodepanos/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecodepanos/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecodepanos/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecodepanos/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecodepanos/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecodepanos/livecode/merges","archive_url":"https://api.github.com/repos/livecodepanos/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecodepanos/livecode/downloads","issues_url":"https://api.github.com/repos/livecodepanos/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecodepanos/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecodepanos/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecodepanos/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecodepanos/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecodepanos/livecode/releases{/id}","created_at":"2013-07-29T09:59:26Z","updated_at":"2015-05-23T15:45:43Z","pushed_at":"2015-11-05T16:02:39Z","git_url":"git://github.com/livecodepanos/livecode.git","ssh_url":"git@github.com:livecodepanos/livecode.git","clone_url":"https://github.com/livecodepanos/livecode.git","svn_url":"https://github.com/livecodepanos/livecode","homepage":null,"size":99500,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"livecode:develop-7.0","ref":"develop-7.0","sha":"38a0b07334268efb1e5979ac4e27d943a43d8972","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","created_at":"2013-04-10T00:15:57Z","updated_at":"2015-10-21T14:55:28Z","pushed_at":"2015-11-05T16:02:40Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":null,"size":300979,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":67,"forks":82,"open_issues":67,"watchers":103,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3129"},"html":{"href":"https://github.com/livecode/livecode/pull/3129"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/3129"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/3129/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3129/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/3129/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/e1cf21011834f924feeaa4ce324e6a876393a330"}}}}