{"action":"opened","number":187,"pull_request":{"url":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187","id":40474863,"html_url":"https://github.com/GraylinKim/sc2reader/pull/187","diff_url":"https://github.com/GraylinKim/sc2reader/pull/187.diff","patch_url":"https://github.com/GraylinKim/sc2reader/pull/187.patch","issue_url":"https://api.github.com/repos/GraylinKim/sc2reader/issues/187","number":187,"state":"open","locked":false,"title":"Adding support for the 36442 base build","user":{"login":"StoicLoofah","id":1123311,"avatar_url":"https://avatars.githubusercontent.com/u/1123311?v=3","gravatar_id":"","url":"https://api.github.com/users/StoicLoofah","html_url":"https://github.com/StoicLoofah","followers_url":"https://api.github.com/users/StoicLoofah/followers","following_url":"https://api.github.com/users/StoicLoofah/following{/other_user}","gists_url":"https://api.github.com/users/StoicLoofah/gists{/gist_id}","starred_url":"https://api.github.com/users/StoicLoofah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StoicLoofah/subscriptions","organizations_url":"https://api.github.com/users/StoicLoofah/orgs","repos_url":"https://api.github.com/users/StoicLoofah/repos","events_url":"https://api.github.com/users/StoicLoofah/events{/privacy}","received_events_url":"https://api.github.com/users/StoicLoofah/received_events","type":"User","site_admin":false},"body":"@GraylinKim I feel like an idiot: I had no idea how the different numbers in the s2protocol file corresponded to the types, and then I realized it was just a dictionary into the types. After that, it was easy to figure out.\r\n\r\nFor posterity (and anyone else who might want to contribute), I:\r\n\r\n1. took a diff between the last 2 s2protocol builds\r\n2. for new/different field, I went into sc2reader/readers.py and found where it fit in (probably just below the previous field)\r\n3. for that field, I took the number type from s2protocol, found another field with the same type, searched that field in readers.py, and copied that type for the new line and added the base_build check as well\r\n4. None of the fields were marked as optional, but if they were, I would have handled that\r\n5. for the event changes, I copied the last GameEventsReader and updated its parent. I tweaked it appropriately\r\n6. I registered the new GameEventsReader in sc2reader/resources.py\r\n\r\nand it seemed like that worked.\r\n\r\nLet me know if there's anything that I might have missed. I'm popping this into production for lotv.spawningtool.com right now, so I will let you know if I see any other errors.","created_at":"2015-07-21T16:08:04Z","updated_at":"2015-07-21T16:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187/commits","review_comments_url":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187/comments","review_comment_url":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GraylinKim/sc2reader/issues/187/comments","statuses_url":"https://api.github.com/repos/GraylinKim/sc2reader/statuses/32811c210da853ea65f83d97f47b5468443c634b","head":{"label":"StoicLoofah:lotv","ref":"lotv","sha":"32811c210da853ea65f83d97f47b5468443c634b","user":{"login":"StoicLoofah","id":1123311,"avatar_url":"https://avatars.githubusercontent.com/u/1123311?v=3","gravatar_id":"","url":"https://api.github.com/users/StoicLoofah","html_url":"https://github.com/StoicLoofah","followers_url":"https://api.github.com/users/StoicLoofah/followers","following_url":"https://api.github.com/users/StoicLoofah/following{/other_user}","gists_url":"https://api.github.com/users/StoicLoofah/gists{/gist_id}","starred_url":"https://api.github.com/users/StoicLoofah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StoicLoofah/subscriptions","organizations_url":"https://api.github.com/users/StoicLoofah/orgs","repos_url":"https://api.github.com/users/StoicLoofah/repos","events_url":"https://api.github.com/users/StoicLoofah/events{/privacy}","received_events_url":"https://api.github.com/users/StoicLoofah/received_events","type":"User","site_admin":false},"repo":{"id":9996150,"name":"sc2reader","full_name":"StoicLoofah/sc2reader","owner":{"login":"StoicLoofah","id":1123311,"avatar_url":"https://avatars.githubusercontent.com/u/1123311?v=3","gravatar_id":"","url":"https://api.github.com/users/StoicLoofah","html_url":"https://github.com/StoicLoofah","followers_url":"https://api.github.com/users/StoicLoofah/followers","following_url":"https://api.github.com/users/StoicLoofah/following{/other_user}","gists_url":"https://api.github.com/users/StoicLoofah/gists{/gist_id}","starred_url":"https://api.github.com/users/StoicLoofah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StoicLoofah/subscriptions","organizations_url":"https://api.github.com/users/StoicLoofah/orgs","repos_url":"https://api.github.com/users/StoicLoofah/repos","events_url":"https://api.github.com/users/StoicLoofah/events{/privacy}","received_events_url":"https://api.github.com/users/StoicLoofah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StoicLoofah/sc2reader","description":"A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community.  Who doesn't want to hack on the games they play?","fork":true,"url":"https://api.github.com/repos/StoicLoofah/sc2reader","forks_url":"https://api.github.com/repos/StoicLoofah/sc2reader/forks","keys_url":"https://api.github.com/repos/StoicLoofah/sc2reader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StoicLoofah/sc2reader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StoicLoofah/sc2reader/teams","hooks_url":"https://api.github.com/repos/StoicLoofah/sc2reader/hooks","issue_events_url":"https://api.github.com/repos/StoicLoofah/sc2reader/issues/events{/number}","events_url":"https://api.github.com/repos/StoicLoofah/sc2reader/events","assignees_url":"https://api.github.com/repos/StoicLoofah/sc2reader/assignees{/user}","branches_url":"https://api.github.com/repos/StoicLoofah/sc2reader/branches{/branch}","tags_url":"https://api.github.com/repos/StoicLoofah/sc2reader/tags","blobs_url":"https://api.github.com/repos/StoicLoofah/sc2reader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StoicLoofah/sc2reader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StoicLoofah/sc2reader/git/refs{/sha}","trees_url":"https://api.github.com/repos/StoicLoofah/sc2reader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StoicLoofah/sc2reader/statuses/{sha}","languages_url":"https://api.github.com/repos/StoicLoofah/sc2reader/languages","stargazers_url":"https://api.github.com/repos/StoicLoofah/sc2reader/stargazers","contributors_url":"https://api.github.com/repos/StoicLoofah/sc2reader/contributors","subscribers_url":"https://api.github.com/repos/StoicLoofah/sc2reader/subscribers","subscription_url":"https://api.github.com/repos/StoicLoofah/sc2reader/subscription","commits_url":"https://api.github.com/repos/StoicLoofah/sc2reader/commits{/sha}","git_commits_url":"https://api.github.com/repos/StoicLoofah/sc2reader/git/commits{/sha}","comments_url":"https://api.github.com/repos/StoicLoofah/sc2reader/comments{/number}","issue_comment_url":"https://api.github.com/repos/StoicLoofah/sc2reader/issues/comments{/number}","contents_url":"https://api.github.com/repos/StoicLoofah/sc2reader/contents/{+path}","compare_url":"https://api.github.com/repos/StoicLoofah/sc2reader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StoicLoofah/sc2reader/merges","archive_url":"https://api.github.com/repos/StoicLoofah/sc2reader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StoicLoofah/sc2reader/downloads","issues_url":"https://api.github.com/repos/StoicLoofah/sc2reader/issues{/number}","pulls_url":"https://api.github.com/repos/StoicLoofah/sc2reader/pulls{/number}","milestones_url":"https://api.github.com/repos/StoicLoofah/sc2reader/milestones{/number}","notifications_url":"https://api.github.com/repos/StoicLoofah/sc2reader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StoicLoofah/sc2reader/labels{/name}","releases_url":"https://api.github.com/repos/StoicLoofah/sc2reader/releases{/id}","created_at":"2013-05-11T06:59:00Z","updated_at":"2015-03-04T07:09:13Z","pushed_at":"2015-07-21T16:03:27Z","git_url":"git://github.com/StoicLoofah/sc2reader.git","ssh_url":"git@github.com:StoicLoofah/sc2reader.git","clone_url":"https://github.com/StoicLoofah/sc2reader.git","svn_url":"https://github.com/StoicLoofah/sc2reader","homepage":"http://sc2reader.readthedocs.org","size":20607,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GraylinKim:lotv","ref":"lotv","sha":"a4fd4e9da0a031598218ee34d201f376c872be6a","user":{"login":"GraylinKim","id":196774,"avatar_url":"https://avatars.githubusercontent.com/u/196774?v=3","gravatar_id":"","url":"https://api.github.com/users/GraylinKim","html_url":"https://github.com/GraylinKim","followers_url":"https://api.github.com/users/GraylinKim/followers","following_url":"https://api.github.com/users/GraylinKim/following{/other_user}","gists_url":"https://api.github.com/users/GraylinKim/gists{/gist_id}","starred_url":"https://api.github.com/users/GraylinKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GraylinKim/subscriptions","organizations_url":"https://api.github.com/users/GraylinKim/orgs","repos_url":"https://api.github.com/users/GraylinKim/repos","events_url":"https://api.github.com/users/GraylinKim/events{/privacy}","received_events_url":"https://api.github.com/users/GraylinKim/received_events","type":"User","site_admin":false},"repo":{"id":1235539,"name":"sc2reader","full_name":"GraylinKim/sc2reader","owner":{"login":"GraylinKim","id":196774,"avatar_url":"https://avatars.githubusercontent.com/u/196774?v=3","gravatar_id":"","url":"https://api.github.com/users/GraylinKim","html_url":"https://github.com/GraylinKim","followers_url":"https://api.github.com/users/GraylinKim/followers","following_url":"https://api.github.com/users/GraylinKim/following{/other_user}","gists_url":"https://api.github.com/users/GraylinKim/gists{/gist_id}","starred_url":"https://api.github.com/users/GraylinKim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GraylinKim/subscriptions","organizations_url":"https://api.github.com/users/GraylinKim/orgs","repos_url":"https://api.github.com/users/GraylinKim/repos","events_url":"https://api.github.com/users/GraylinKim/events{/privacy}","received_events_url":"https://api.github.com/users/GraylinKim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GraylinKim/sc2reader","description":"A python library that extracts data from various Starcraft II resources to power tools and services for the SC2 community.  Who doesn't want to hack on the games they play?","fork":false,"url":"https://api.github.com/repos/GraylinKim/sc2reader","forks_url":"https://api.github.com/repos/GraylinKim/sc2reader/forks","keys_url":"https://api.github.com/repos/GraylinKim/sc2reader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GraylinKim/sc2reader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GraylinKim/sc2reader/teams","hooks_url":"https://api.github.com/repos/GraylinKim/sc2reader/hooks","issue_events_url":"https://api.github.com/repos/GraylinKim/sc2reader/issues/events{/number}","events_url":"https://api.github.com/repos/GraylinKim/sc2reader/events","assignees_url":"https://api.github.com/repos/GraylinKim/sc2reader/assignees{/user}","branches_url":"https://api.github.com/repos/GraylinKim/sc2reader/branches{/branch}","tags_url":"https://api.github.com/repos/GraylinKim/sc2reader/tags","blobs_url":"https://api.github.com/repos/GraylinKim/sc2reader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GraylinKim/sc2reader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GraylinKim/sc2reader/git/refs{/sha}","trees_url":"https://api.github.com/repos/GraylinKim/sc2reader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GraylinKim/sc2reader/statuses/{sha}","languages_url":"https://api.github.com/repos/GraylinKim/sc2reader/languages","stargazers_url":"https://api.github.com/repos/GraylinKim/sc2reader/stargazers","contributors_url":"https://api.github.com/repos/GraylinKim/sc2reader/contributors","subscribers_url":"https://api.github.com/repos/GraylinKim/sc2reader/subscribers","subscription_url":"https://api.github.com/repos/GraylinKim/sc2reader/subscription","commits_url":"https://api.github.com/repos/GraylinKim/sc2reader/commits{/sha}","git_commits_url":"https://api.github.com/repos/GraylinKim/sc2reader/git/commits{/sha}","comments_url":"https://api.github.com/repos/GraylinKim/sc2reader/comments{/number}","issue_comment_url":"https://api.github.com/repos/GraylinKim/sc2reader/issues/comments{/number}","contents_url":"https://api.github.com/repos/GraylinKim/sc2reader/contents/{+path}","compare_url":"https://api.github.com/repos/GraylinKim/sc2reader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GraylinKim/sc2reader/merges","archive_url":"https://api.github.com/repos/GraylinKim/sc2reader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GraylinKim/sc2reader/downloads","issues_url":"https://api.github.com/repos/GraylinKim/sc2reader/issues{/number}","pulls_url":"https://api.github.com/repos/GraylinKim/sc2reader/pulls{/number}","milestones_url":"https://api.github.com/repos/GraylinKim/sc2reader/milestones{/number}","notifications_url":"https://api.github.com/repos/GraylinKim/sc2reader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GraylinKim/sc2reader/labels{/name}","releases_url":"https://api.github.com/repos/GraylinKim/sc2reader/releases{/id}","created_at":"2011-01-09T17:23:36Z","updated_at":"2015-07-02T11:23:49Z","pushed_at":"2015-05-28T12:34:15Z","git_url":"git://github.com/GraylinKim/sc2reader.git","ssh_url":"git@github.com:GraylinKim/sc2reader.git","clone_url":"https://github.com/GraylinKim/sc2reader.git","svn_url":"https://github.com/GraylinKim/sc2reader","homepage":"http://sc2reader.readthedocs.org","size":21935,"stargazers_count":275,"watchers_count":275,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":20,"forks":73,"open_issues":20,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187"},"html":{"href":"https://github.com/GraylinKim/sc2reader/pull/187"},"issue":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/issues/187"},"comments":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/GraylinKim/sc2reader/statuses/32811c210da853ea65f83d97f47b5468443c634b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":19,"deletions":1,"changed_files":3}}