{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/35043764","id":35043764,"diff_hunk":"@@ -250,9 +260,22 @@ def fit(self, X, y=None):\n         if feature_range[0] >= feature_range[1]:\n             raise ValueError(\"Minimum of desired feature range must be smaller\"\n                              \" than maximum. Got %s.\" % str(feature_range))\n-        data_min = np.min(X, axis=0)\n-        data_range = np.max(X, axis=0) - data_min\n+\n+        if len(X.shape) == 2:","path":"sklearn/preprocessing/data.py","position":null,"original_position":37,"commit_id":"63bcb21c93f28989e6c05882f00434b31255e21c","original_commit_id":"3105712a24f07e116ca307aeffa4e6a5c6d97213","user":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"body":"Yes I should. (I was considering adding a warning, at least.) I'll put that in a future commit, thank you.","created_at":"2015-07-20T21:02:50Z","updated_at":"2015-07-20T21:02:50Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/5002#discussion_r35043764","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/35043764"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5002#discussion_r35043764"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002","id":40304938,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/5002","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/5002.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/5002.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002","number":5002,"state":"open","locked":false,"title":"Allow MinMaxScaler to scale specified columns","user":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"body":"Addresses #5000. This should allow users to specify which columns to scale. This allows categorical data to exist in the dataset.","created_at":"2015-07-19T08:11:58Z","updated_at":"2015-07-20T21:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16b6532b8a4e6317d0c656f1c670e6df2d7c152b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/63bcb21c93f28989e6c05882f00434b31255e21c","head":{"label":"hlin117:minmaxscaler","ref":"minmaxscaler","sha":"63bcb21c93f28989e6c05882f00434b31255e21c","user":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"repo":{"id":36590365,"name":"scikit-learn","full_name":"hlin117/scikit-learn","owner":{"login":"hlin117","id":1865885,"avatar_url":"https://avatars.githubusercontent.com/u/1865885?v=3","gravatar_id":"","url":"https://api.github.com/users/hlin117","html_url":"https://github.com/hlin117","followers_url":"https://api.github.com/users/hlin117/followers","following_url":"https://api.github.com/users/hlin117/following{/other_user}","gists_url":"https://api.github.com/users/hlin117/gists{/gist_id}","starred_url":"https://api.github.com/users/hlin117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlin117/subscriptions","organizations_url":"https://api.github.com/users/hlin117/orgs","repos_url":"https://api.github.com/users/hlin117/repos","events_url":"https://api.github.com/users/hlin117/events{/privacy}","received_events_url":"https://api.github.com/users/hlin117/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlin117/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/hlin117/scikit-learn","forks_url":"https://api.github.com/repos/hlin117/scikit-learn/forks","keys_url":"https://api.github.com/repos/hlin117/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlin117/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlin117/scikit-learn/teams","hooks_url":"https://api.github.com/repos/hlin117/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/hlin117/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/hlin117/scikit-learn/events","assignees_url":"https://api.github.com/repos/hlin117/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/hlin117/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/hlin117/scikit-learn/tags","blobs_url":"https://api.github.com/repos/hlin117/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlin117/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlin117/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlin117/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlin117/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/hlin117/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/hlin117/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/hlin117/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/hlin117/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/hlin117/scikit-learn/subscription","commits_url":"https://api.github.com/repos/hlin117/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlin117/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlin117/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlin117/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlin117/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/hlin117/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlin117/scikit-learn/merges","archive_url":"https://api.github.com/repos/hlin117/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlin117/scikit-learn/downloads","issues_url":"https://api.github.com/repos/hlin117/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/hlin117/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/hlin117/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/hlin117/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlin117/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/hlin117/scikit-learn/releases{/id}","created_at":"2015-05-31T06:06:00Z","updated_at":"2015-06-01T01:02:20Z","pushed_at":"2015-07-20T17:47:25Z","git_url":"git://github.com/hlin117/scikit-learn.git","ssh_url":"git@github.com:hlin117/scikit-learn.git","clone_url":"https://github.com/hlin117/scikit-learn.git","svn_url":"https://github.com/hlin117/scikit-learn","homepage":"http://scikit-learn.org","size":63479,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"03b09a482f5fe3eb689330180044f3c9604e1542","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-07-20T20:29:57Z","pushed_at":"2015-07-20T19:45:49Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":126724,"stargazers_count":6798,"watchers_count":6798,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4071,"mirror_url":null,"open_issues_count":734,"forks":4071,"open_issues":734,"watchers":6798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/5002"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/5002/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/5002/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/63bcb21c93f28989e6c05882f00434b31255e21c"}}}}