{"action":"created","issue":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847","labels_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847/labels{/name}","comments_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847/comments","events_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847/events","html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847","id":89627714,"number":847,"title":"Externalize localhost:8080 urls and context path","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-06-19T18:21:39Z","updated_at":"2015-06-20T21:26:59Z","closed_at":"2015-06-20T01:13:47Z","body":"urls are hardcoded to localhost:8080/openid-connect-server-webapp. It would be best if these could be referenced via some sort of property in a single spot s mods are easier to handle. "},"comment":{"url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/comments/113822398","html_url":"https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847#issuecomment-113822398","issue_url":"https://api.github.com/repos/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/847","id":113822398,"user":{"login":"jricher","id":122511,"avatar_url":"https://avatars.githubusercontent.com/u/122511?v=3","gravatar_id":"","url":"https://api.github.com/users/jricher","html_url":"https://github.com/jricher","followers_url":"https://api.github.com/users/jricher/followers","following_url":"https://api.github.com/users/jricher/following{/other_user}","gists_url":"https://api.github.com/users/jricher/gists{/gist_id}","starred_url":"https://api.github.com/users/jricher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jricher/subscriptions","organizations_url":"https://api.github.com/users/jricher/orgs","repos_url":"https://api.github.com/users/jricher/repos","events_url":"https://api.github.com/users/jricher/events{/privacy}","received_events_url":"https://api.github.com/users/jricher/received_events","type":"User","site_admin":false},"created_at":"2015-06-20T21:26:59Z","updated_at":"2015-06-20T21:26:59Z","body":"I still don't understand what you're saying about the values in the .jsp files -- they are **already** configured using the existing bean. If you don't believe me, go change the value in that bean and watch it change in all of the .jsp files too. There's an interceptor that injects the bean into the context and makes it available for all .jsp processed pages, as the `config` variable. That's why you'll see `config.issuer` in a bunch of places throughout those. Other parts of the code inject the bean with `@Autowired` and use it that way.\r\n\r\nAs to the rest, I've used properties files on a number of projects in the past, and we don't plan on changing the configuration here to use them, for a number of reasons. You can **already** deploy the same .war file to multiple different tiers and locations without rebuilding it if you externalize your configuration in a localized overlay. This is our recommended practice for building and deploying this server because more often than not it takes much more than just changing a small set of properties. For instance, most production instances of this code are tied to an enterprise SSO system of some type (MIT uses Kerberos, for example), which requires changes to the authorization providers and a few other things that you can't express with a properties file. \r\n\r\nYou are, of course, free to implement properties files to handle configurations in your own overlays, and I recommend that you do just that."}}