{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/1186","labels_url":"https://api.github.com/repos/php/php-src/issues/1186/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/1186/comments","events_url":"https://api.github.com/repos/php/php-src/issues/1186/events","html_url":"https://github.com/php/php-src/pull/1186","id":63277870,"number":1186,"title":"Move check for __builtin_expect to configure","user":{"login":"morrisonlevi","id":253316,"avatar_url":"https://avatars.githubusercontent.com/u/253316?v=3","gravatar_id":"","url":"https://api.github.com/users/morrisonlevi","html_url":"https://github.com/morrisonlevi","followers_url":"https://api.github.com/users/morrisonlevi/followers","following_url":"https://api.github.com/users/morrisonlevi/following{/other_user}","gists_url":"https://api.github.com/users/morrisonlevi/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonlevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonlevi/subscriptions","organizations_url":"https://api.github.com/users/morrisonlevi/orgs","repos_url":"https://api.github.com/users/morrisonlevi/repos","events_url":"https://api.github.com/users/morrisonlevi/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonlevi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/php/php-src/labels/quickfix","name":"quickfix","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-20T18:20:59Z","updated_at":"2015-03-20T22:46:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1186","html_url":"https://github.com/php/php-src/pull/1186","diff_url":"https://github.com/php/php-src/pull/1186.diff","patch_url":"https://github.com/php/php-src/pull/1186.patch"},"body":"This allows `__builtin_expect` to be used more accurately.\r\n\r\nI've checked on a Mac and a Linux machine that it works correctly. Later I am going to test the Intel C Compiler on Linux.\r\n\r\nWe probably need to test this on a few other setups which I don't have access to:\r\n  - Whatever Visual Studio versions we support\r\n  - AIX\r\n  - HPUX\r\n\r\n… and maybe more."},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/84172972","html_url":"https://github.com/php/php-src/pull/1186#issuecomment-84172972","issue_url":"https://api.github.com/repos/php/php-src/issues/1186","id":84172972,"user":{"login":"morrisonlevi","id":253316,"avatar_url":"https://avatars.githubusercontent.com/u/253316?v=3","gravatar_id":"","url":"https://api.github.com/users/morrisonlevi","html_url":"https://github.com/morrisonlevi","followers_url":"https://api.github.com/users/morrisonlevi/followers","following_url":"https://api.github.com/users/morrisonlevi/following{/other_user}","gists_url":"https://api.github.com/users/morrisonlevi/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonlevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonlevi/subscriptions","organizations_url":"https://api.github.com/users/morrisonlevi/orgs","repos_url":"https://api.github.com/users/morrisonlevi/repos","events_url":"https://api.github.com/users/morrisonlevi/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonlevi/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T22:46:32Z","updated_at":"2015-03-20T22:46:32Z","body":"Reporting back with the Intel C Compiler on RHEL results. It is able to use `__builtin_expect` with a `bench.php` time of ~1.507; without the patch it's ~1.541. Intel is one of the compilers I suspected weren't using the builtin but supported it. I'm glad I got the expected result.\r\n\r\nWe still need to check the other systems to ensure everything compiles okay and are using or not using the builtin accordingly."}}