{"action":"created","comment":{"url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/comments/39356093","id":39356093,"diff_hunk":"@@ -258,7 +258,26 @@ def set_infrastructure\n \n   # Never trust parameters from the scary internet, only allow the white list through.\n   def infrastructure_params(no_keypair: nil)\n+    require 'open3'","path":"app/controllers/infrastructures_controller.rb","position":13,"original_position":13,"commit_id":"86c20bdb9e5d824003402ad50e564602497cf4c9","original_commit_id":"86c20bdb9e5d824003402ad50e564602497cf4c9","user":{"login":"pocke","id":4361134,"avatar_url":"https://avatars.githubusercontent.com/u/4361134?v=3","gravatar_id":"","url":"https://api.github.com/users/pocke","html_url":"https://github.com/pocke","followers_url":"https://api.github.com/users/pocke/followers","following_url":"https://api.github.com/users/pocke/following{/other_user}","gists_url":"https://api.github.com/users/pocke/gists{/gist_id}","starred_url":"https://api.github.com/users/pocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocke/subscriptions","organizations_url":"https://api.github.com/users/pocke/orgs","repos_url":"https://api.github.com/users/pocke/repos","events_url":"https://api.github.com/users/pocke/events{/privacy}","received_events_url":"https://api.github.com/users/pocke/received_events","type":"User","site_admin":false},"body":"This `require` is not necessary. because open3 is already required.\r\nhttps://github.com/skyarch-networks/skyhopper/blob/e87a667094b4a0d936ac8967ba474e98caba7eb0/config/initializers/requires.rb","created_at":"2015-09-14T01:37:31Z","updated_at":"2015-09-14T01:37:31Z","html_url":"https://github.com/skyarch-networks/skyhopper/pull/45#discussion_r39356093","pull_request_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/comments/39356093"},"html":{"href":"https://github.com/skyarch-networks/skyhopper/pull/45#discussion_r39356093"},"pull_request":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45","id":44740966,"html_url":"https://github.com/skyarch-networks/skyhopper/pull/45","diff_url":"https://github.com/skyarch-networks/skyhopper/pull/45.diff","patch_url":"https://github.com/skyarch-networks/skyhopper/pull/45.patch","issue_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/45","number":45,"state":"open","locked":false,"title":"[WIP] Validation for keypair submission","user":{"login":"Joeper214","id":2352389,"avatar_url":"https://avatars.githubusercontent.com/u/2352389?v=3","gravatar_id":"","url":"https://api.github.com/users/Joeper214","html_url":"https://github.com/Joeper214","followers_url":"https://api.github.com/users/Joeper214/followers","following_url":"https://api.github.com/users/Joeper214/following{/other_user}","gists_url":"https://api.github.com/users/Joeper214/gists{/gist_id}","starred_url":"https://api.github.com/users/Joeper214/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joeper214/subscriptions","organizations_url":"https://api.github.com/users/Joeper214/orgs","repos_url":"https://api.github.com/users/Joeper214/repos","events_url":"https://api.github.com/users/Joeper214/events{/privacy}","received_events_url":"https://api.github.com/users/Joeper214/received_events","type":"User","site_admin":false},"body":"### Goals of this PR\r\n- [x] Create temporary PEM files to write the values of the key-pair\r\n- [x] read the pem file using the `ec2-fingerprint-key` command line tool to get the right fingerprint.\r\n- [x] check the available key-pairs on the specified `AWS region`\r\n- [x] Raise error if key pair is invalid or non existing.\r\n\r\nPlease let me know if you have comments in this PR. and we'll merge it after doing so. Thanks!","created_at":"2015-09-11T02:32:53Z","updated_at":"2015-09-14T01:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22e2b6d8595c0cfd8f8497edbbadba3f2feb7ab8","assignee":{"login":"pocke","id":4361134,"avatar_url":"https://avatars.githubusercontent.com/u/4361134?v=3","gravatar_id":"","url":"https://api.github.com/users/pocke","html_url":"https://github.com/pocke","followers_url":"https://api.github.com/users/pocke/followers","following_url":"https://api.github.com/users/pocke/following{/other_user}","gists_url":"https://api.github.com/users/pocke/gists{/gist_id}","starred_url":"https://api.github.com/users/pocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pocke/subscriptions","organizations_url":"https://api.github.com/users/pocke/orgs","repos_url":"https://api.github.com/users/pocke/repos","events_url":"https://api.github.com/users/pocke/events{/privacy}","received_events_url":"https://api.github.com/users/pocke/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45/commits","review_comments_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45/comments","review_comment_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/45/comments","statuses_url":"https://api.github.com/repos/skyarch-networks/skyhopper/statuses/86c20bdb9e5d824003402ad50e564602497cf4c9","head":{"label":"skyarch-networks:keypair-validation","ref":"keypair-validation","sha":"86c20bdb9e5d824003402ad50e564602497cf4c9","user":{"login":"skyarch-networks","id":10970571,"avatar_url":"https://avatars.githubusercontent.com/u/10970571?v=3","gravatar_id":"","url":"https://api.github.com/users/skyarch-networks","html_url":"https://github.com/skyarch-networks","followers_url":"https://api.github.com/users/skyarch-networks/followers","following_url":"https://api.github.com/users/skyarch-networks/following{/other_user}","gists_url":"https://api.github.com/users/skyarch-networks/gists{/gist_id}","starred_url":"https://api.github.com/users/skyarch-networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyarch-networks/subscriptions","organizations_url":"https://api.github.com/users/skyarch-networks/orgs","repos_url":"https://api.github.com/users/skyarch-networks/repos","events_url":"https://api.github.com/users/skyarch-networks/events{/privacy}","received_events_url":"https://api.github.com/users/skyarch-networks/received_events","type":"User","site_admin":false},"repo":{"id":31754199,"name":"skyhopper","full_name":"skyarch-networks/skyhopper","owner":{"login":"skyarch-networks","id":10970571,"avatar_url":"https://avatars.githubusercontent.com/u/10970571?v=3","gravatar_id":"","url":"https://api.github.com/users/skyarch-networks","html_url":"https://github.com/skyarch-networks","followers_url":"https://api.github.com/users/skyarch-networks/followers","following_url":"https://api.github.com/users/skyarch-networks/following{/other_user}","gists_url":"https://api.github.com/users/skyarch-networks/gists{/gist_id}","starred_url":"https://api.github.com/users/skyarch-networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyarch-networks/subscriptions","organizations_url":"https://api.github.com/users/skyarch-networks/orgs","repos_url":"https://api.github.com/users/skyarch-networks/repos","events_url":"https://api.github.com/users/skyarch-networks/events{/privacy}","received_events_url":"https://api.github.com/users/skyarch-networks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skyarch-networks/skyhopper","description":"システム自動構築ツール","fork":false,"url":"https://api.github.com/repos/skyarch-networks/skyhopper","forks_url":"https://api.github.com/repos/skyarch-networks/skyhopper/forks","keys_url":"https://api.github.com/repos/skyarch-networks/skyhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyarch-networks/skyhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyarch-networks/skyhopper/teams","hooks_url":"https://api.github.com/repos/skyarch-networks/skyhopper/hooks","issue_events_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/events{/number}","events_url":"https://api.github.com/repos/skyarch-networks/skyhopper/events","assignees_url":"https://api.github.com/repos/skyarch-networks/skyhopper/assignees{/user}","branches_url":"https://api.github.com/repos/skyarch-networks/skyhopper/branches{/branch}","tags_url":"https://api.github.com/repos/skyarch-networks/skyhopper/tags","blobs_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyarch-networks/skyhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/skyarch-networks/skyhopper/languages","stargazers_url":"https://api.github.com/repos/skyarch-networks/skyhopper/stargazers","contributors_url":"https://api.github.com/repos/skyarch-networks/skyhopper/contributors","subscribers_url":"https://api.github.com/repos/skyarch-networks/skyhopper/subscribers","subscription_url":"https://api.github.com/repos/skyarch-networks/skyhopper/subscription","commits_url":"https://api.github.com/repos/skyarch-networks/skyhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyarch-networks/skyhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyarch-networks/skyhopper/contents/{+path}","compare_url":"https://api.github.com/repos/skyarch-networks/skyhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyarch-networks/skyhopper/merges","archive_url":"https://api.github.com/repos/skyarch-networks/skyhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyarch-networks/skyhopper/downloads","issues_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues{/number}","pulls_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/skyarch-networks/skyhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/skyarch-networks/skyhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyarch-networks/skyhopper/labels{/name}","releases_url":"https://api.github.com/repos/skyarch-networks/skyhopper/releases{/id}","created_at":"2015-03-06T05:30:44Z","updated_at":"2015-08-03T06:38:16Z","pushed_at":"2015-09-14T01:15:31Z","git_url":"git://github.com/skyarch-networks/skyhopper.git","ssh_url":"git@github.com:skyarch-networks/skyhopper.git","clone_url":"https://github.com/skyarch-networks/skyhopper.git","svn_url":"https://github.com/skyarch-networks/skyhopper","homepage":"","size":6825,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":14,"default_branch":"master"}},"base":{"label":"skyarch-networks:develop","ref":"develop","sha":"e87a667094b4a0d936ac8967ba474e98caba7eb0","user":{"login":"skyarch-networks","id":10970571,"avatar_url":"https://avatars.githubusercontent.com/u/10970571?v=3","gravatar_id":"","url":"https://api.github.com/users/skyarch-networks","html_url":"https://github.com/skyarch-networks","followers_url":"https://api.github.com/users/skyarch-networks/followers","following_url":"https://api.github.com/users/skyarch-networks/following{/other_user}","gists_url":"https://api.github.com/users/skyarch-networks/gists{/gist_id}","starred_url":"https://api.github.com/users/skyarch-networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyarch-networks/subscriptions","organizations_url":"https://api.github.com/users/skyarch-networks/orgs","repos_url":"https://api.github.com/users/skyarch-networks/repos","events_url":"https://api.github.com/users/skyarch-networks/events{/privacy}","received_events_url":"https://api.github.com/users/skyarch-networks/received_events","type":"User","site_admin":false},"repo":{"id":31754199,"name":"skyhopper","full_name":"skyarch-networks/skyhopper","owner":{"login":"skyarch-networks","id":10970571,"avatar_url":"https://avatars.githubusercontent.com/u/10970571?v=3","gravatar_id":"","url":"https://api.github.com/users/skyarch-networks","html_url":"https://github.com/skyarch-networks","followers_url":"https://api.github.com/users/skyarch-networks/followers","following_url":"https://api.github.com/users/skyarch-networks/following{/other_user}","gists_url":"https://api.github.com/users/skyarch-networks/gists{/gist_id}","starred_url":"https://api.github.com/users/skyarch-networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyarch-networks/subscriptions","organizations_url":"https://api.github.com/users/skyarch-networks/orgs","repos_url":"https://api.github.com/users/skyarch-networks/repos","events_url":"https://api.github.com/users/skyarch-networks/events{/privacy}","received_events_url":"https://api.github.com/users/skyarch-networks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skyarch-networks/skyhopper","description":"システム自動構築ツール","fork":false,"url":"https://api.github.com/repos/skyarch-networks/skyhopper","forks_url":"https://api.github.com/repos/skyarch-networks/skyhopper/forks","keys_url":"https://api.github.com/repos/skyarch-networks/skyhopper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyarch-networks/skyhopper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyarch-networks/skyhopper/teams","hooks_url":"https://api.github.com/repos/skyarch-networks/skyhopper/hooks","issue_events_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/events{/number}","events_url":"https://api.github.com/repos/skyarch-networks/skyhopper/events","assignees_url":"https://api.github.com/repos/skyarch-networks/skyhopper/assignees{/user}","branches_url":"https://api.github.com/repos/skyarch-networks/skyhopper/branches{/branch}","tags_url":"https://api.github.com/repos/skyarch-networks/skyhopper/tags","blobs_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyarch-networks/skyhopper/statuses/{sha}","languages_url":"https://api.github.com/repos/skyarch-networks/skyhopper/languages","stargazers_url":"https://api.github.com/repos/skyarch-networks/skyhopper/stargazers","contributors_url":"https://api.github.com/repos/skyarch-networks/skyhopper/contributors","subscribers_url":"https://api.github.com/repos/skyarch-networks/skyhopper/subscribers","subscription_url":"https://api.github.com/repos/skyarch-networks/skyhopper/subscription","commits_url":"https://api.github.com/repos/skyarch-networks/skyhopper/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyarch-networks/skyhopper/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyarch-networks/skyhopper/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyarch-networks/skyhopper/contents/{+path}","compare_url":"https://api.github.com/repos/skyarch-networks/skyhopper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyarch-networks/skyhopper/merges","archive_url":"https://api.github.com/repos/skyarch-networks/skyhopper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyarch-networks/skyhopper/downloads","issues_url":"https://api.github.com/repos/skyarch-networks/skyhopper/issues{/number}","pulls_url":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls{/number}","milestones_url":"https://api.github.com/repos/skyarch-networks/skyhopper/milestones{/number}","notifications_url":"https://api.github.com/repos/skyarch-networks/skyhopper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyarch-networks/skyhopper/labels{/name}","releases_url":"https://api.github.com/repos/skyarch-networks/skyhopper/releases{/id}","created_at":"2015-03-06T05:30:44Z","updated_at":"2015-08-03T06:38:16Z","pushed_at":"2015-09-14T01:15:31Z","git_url":"git://github.com/skyarch-networks/skyhopper.git","ssh_url":"git@github.com:skyarch-networks/skyhopper.git","clone_url":"https://github.com/skyarch-networks/skyhopper.git","svn_url":"https://github.com/skyarch-networks/skyhopper","homepage":"","size":6825,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45"},"html":{"href":"https://github.com/skyarch-networks/skyhopper/pull/45"},"issue":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/45"},"comments":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/skyarch-networks/skyhopper/statuses/86c20bdb9e5d824003402ad50e564602497cf4c9"}}}}