{"action":"opened","number":7938,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/7938","id":43794160,"html_url":"https://github.com/xbmc/xbmc/pull/7938","diff_url":"https://github.com/xbmc/xbmc/pull/7938.diff","patch_url":"https://github.com/xbmc/xbmc/pull/7938.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938","number":7938,"state":"open","locked":false,"title":"[MusicLibrary] Include \"Various artists\" album artist in the artists list","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"(Resubmitted #7928 after messing up the Git and commiting additional WIP by mistake).\r\nBefore Gotham the \"Various artists\" entry would appear in the artists list (when \"include artists who appear only on compilations\" is disabled). On the forum users have requested this is reinstated. See http://forum.kodi.tv/showthread.php?tid=223454 and http://forum.kodi.tv/showthread.php?tid=200797\r\n\r\nIt also seems inconsistent to exclude it as an album artist in this one view, since it does appear when listing the artists for a specific genre.\r\n\r\nIn testing I discovered that this change reveals some previously hidden (lost?) artists. That possibly elevates it to being a bug fix!!  MusicBrainz/Picard sometimes sets the compliation flag but also provides album artists, unless these artists appear on some other album then they are currently excluded from the artists list. That is not good behaviour.\r\n\r\nWhen albumArtistsOnly is false then it is valid to exclude the fake (album) artist \"Various artists\" from the artists list because you are listing the song artists individually.\r\n\r\nLooked back in the Git I have not be able to find a good reason to exclude it - in fact it simplifies the query. Anyone see a problem? A nice simple change, a good place to start my first PR.\r\n\r\n@evilhamster, @Razzeee nothing new here. @Montellese any comments?\r\n","created_at":"2015-08-31T18:31:00Z","updated_at":"2015-08-31T18:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7938/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/7938/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/7938/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/8c2f5fdf570b4879d836123c3f32e7ae466508ea","head":{"label":"DaveTBlake:Various_Artists","ref":"Various_Artists","sha":"8c2f5fdf570b4879d836123c3f32e7ae466508ea","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"repo":{"id":41623007,"name":"xbmc","full_name":"DaveTBlake/xbmc","owner":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveTBlake/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/DaveTBlake/xbmc","forks_url":"https://api.github.com/repos/DaveTBlake/xbmc/forks","keys_url":"https://api.github.com/repos/DaveTBlake/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveTBlake/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveTBlake/xbmc/teams","hooks_url":"https://api.github.com/repos/DaveTBlake/xbmc/hooks","issue_events_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/DaveTBlake/xbmc/events","assignees_url":"https://api.github.com/repos/DaveTBlake/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/DaveTBlake/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/tags","blobs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveTBlake/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveTBlake/xbmc/languages","stargazers_url":"https://api.github.com/repos/DaveTBlake/xbmc/stargazers","contributors_url":"https://api.github.com/repos/DaveTBlake/xbmc/contributors","subscribers_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscribers","subscription_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscription","commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveTBlake/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveTBlake/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/DaveTBlake/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveTBlake/xbmc/merges","archive_url":"https://api.github.com/repos/DaveTBlake/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveTBlake/xbmc/downloads","issues_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/DaveTBlake/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveTBlake/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveTBlake/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveTBlake/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/DaveTBlake/xbmc/releases{/id}","created_at":"2015-08-30T09:25:19Z","updated_at":"2015-08-30T09:25:50Z","pushed_at":"2015-08-31T18:03:59Z","git_url":"git://github.com/DaveTBlake/xbmc.git","ssh_url":"git@github.com:DaveTBlake/xbmc.git","clone_url":"https://github.com/DaveTBlake/xbmc.git","svn_url":"https://github.com/DaveTBlake/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":535695,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"23bc0c1a8fb8888a8057de10ff93008ddbd392f3","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-08-31T12:23:52Z","pushed_at":"2015-08-31T17:42:22Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1887946,"stargazers_count":4076,"watchers_count":4076,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2992,"mirror_url":null,"open_issues_count":232,"forks":2992,"open_issues":232,"watchers":4076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7938"},"html":{"href":"https://github.com/xbmc/xbmc/pull/7938"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7938"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/7938/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7938/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/7938/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/8c2f5fdf570b4879d836123c3f32e7ae466508ea"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":4,"changed_files":1}}