{"action":"created","comment":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/31875638","id":31875638,"diff_hunk":"@@ -20,29 +22,29 @@\n \t/**\n \t * Constructs a default sequence with all parameters specified.\n \t * @param id The ID of this sequence.\n-\t * @param source The sources of the sequence (from where it was sequenced).\n+\t * @param sources The sources of the sequence (from where it was sequenced).\n \t * @param start The start position of the sequence.\n \t * @param end The end position of the sequence.\n \t * @param sequence The sequence.\n \t */\n-\tpublic SequenceNodeImpl(String id, String source, int start, int end, String sequence) {\n-\t\tthis(id, source, start, end, sequence, 0, new ArrayList<>());\n+\tpublic SequenceNodeImpl(String id, List<String> sources, int start, int end, String sequence) {\n+\t\tthis(id, sources, start, end, sequence, 0, new ArrayList<>());\n \t}\n \n \t/**\n \t * Constructs a default sequence with all parameters specified.\n \t * @param id The ID of this sequence.\n-\t * @param source The sources of the sequence (from where it was sequenced).\n+\t * @param sources The sources of the sequence (from where it was sequenced).\n \t * @param start The start position of the sequence.\n \t * @param end The end position of the sequence.\n \t * @param sequence The sequence.\n \t * @param rank The rank.\n \t * @param outgoing The neighbours\n \t */\n-\tpublic SequenceNodeImpl(String id, String source,\n+\tpublic SequenceNodeImpl(String id, List<String> sources,","path":"src/main/java/nl/tudelft/dnainator/core/impl/SequenceNodeImpl.java","position":46,"original_position":46,"commit_id":"027142f5d72607fb7e681faee2cc6bd937cae488","original_commit_id":"027142f5d72607fb7e681faee2cc6bd937cae488","user":{"login":"Balletie","id":3884925,"avatar_url":"https://avatars.githubusercontent.com/u/3884925?v=3","gravatar_id":"","url":"https://api.github.com/users/Balletie","html_url":"https://github.com/Balletie","followers_url":"https://api.github.com/users/Balletie/followers","following_url":"https://api.github.com/users/Balletie/following{/other_user}","gists_url":"https://api.github.com/users/Balletie/gists{/gist_id}","starred_url":"https://api.github.com/users/Balletie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balletie/subscriptions","organizations_url":"https://api.github.com/users/Balletie/orgs","repos_url":"https://api.github.com/users/Balletie/repos","events_url":"https://api.github.com/users/Balletie/events{/privacy}","received_events_url":"https://api.github.com/users/Balletie/received_events","type":"User","site_admin":false},"body":"Might be more future proof to add a constructor which takes a Set.\r\n\r\nThe `SequenceNodeFactoryImpl` currently splits on commas, returning a List.","created_at":"2015-06-07T10:27:51Z","updated_at":"2015-06-07T10:27:51Z","html_url":"https://github.com/DNAinator/dnainator/pull/98#discussion_r31875638","pull_request_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/31875638"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/98#discussion_r31875638"},"pull_request":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/98","id":36581382,"html_url":"https://github.com/DNAinator/dnainator/pull/98","diff_url":"https://github.com/DNAinator/dnainator/pull/98.diff","patch_url":"https://github.com/DNAinator/dnainator/pull/98.patch","issue_url":"https://api.github.com/repos/DNAinator/dnainator/issues/98","number":98,"state":"open","locked":false,"title":"[RFC] Split sources when storing them in the graph.","user":{"login":"gfokkema","id":5970912,"avatar_url":"https://avatars.githubusercontent.com/u/5970912?v=3","gravatar_id":"","url":"https://api.github.com/users/gfokkema","html_url":"https://github.com/gfokkema","followers_url":"https://api.github.com/users/gfokkema/followers","following_url":"https://api.github.com/users/gfokkema/following{/other_user}","gists_url":"https://api.github.com/users/gfokkema/gists{/gist_id}","starred_url":"https://api.github.com/users/gfokkema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfokkema/subscriptions","organizations_url":"https://api.github.com/users/gfokkema/orgs","repos_url":"https://api.github.com/users/gfokkema/repos","events_url":"https://api.github.com/users/gfokkema/events{/privacy}","received_events_url":"https://api.github.com/users/gfokkema/received_events","type":"User","site_admin":false},"body":"Split sources in Neo4j by storing them as relationships to a unique SOURCE node.\r\n\r\nAlso create an accompanying index.\r\n~~For now the sources are split in Neo4jGraph.java and concatenated again in NodeQuery.java.\r\nNode factory and user interface should be updated to handle lists of sources.~~ **Edit**: done.\r\n**Edit**: Fixes #62","created_at":"2015-05-31T12:25:24Z","updated_at":"2015-06-07T10:27:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dbb98becc45262e74c58fb0a7ca399b82c79f45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/98/commits","review_comments_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/98/comments","review_comment_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/issues/98/comments","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/027142f5d72607fb7e681faee2cc6bd937cae488","head":{"label":"gfokkema:gerlof-split-sources","ref":"gerlof-split-sources","sha":"027142f5d72607fb7e681faee2cc6bd937cae488","user":{"login":"gfokkema","id":5970912,"avatar_url":"https://avatars.githubusercontent.com/u/5970912?v=3","gravatar_id":"","url":"https://api.github.com/users/gfokkema","html_url":"https://github.com/gfokkema","followers_url":"https://api.github.com/users/gfokkema/followers","following_url":"https://api.github.com/users/gfokkema/following{/other_user}","gists_url":"https://api.github.com/users/gfokkema/gists{/gist_id}","starred_url":"https://api.github.com/users/gfokkema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfokkema/subscriptions","organizations_url":"https://api.github.com/users/gfokkema/orgs","repos_url":"https://api.github.com/users/gfokkema/repos","events_url":"https://api.github.com/users/gfokkema/events{/privacy}","received_events_url":"https://api.github.com/users/gfokkema/received_events","type":"User","site_admin":false},"repo":{"id":34401882,"name":"dnainator","full_name":"gfokkema/dnainator","owner":{"login":"gfokkema","id":5970912,"avatar_url":"https://avatars.githubusercontent.com/u/5970912?v=3","gravatar_id":"","url":"https://api.github.com/users/gfokkema","html_url":"https://github.com/gfokkema","followers_url":"https://api.github.com/users/gfokkema/followers","following_url":"https://api.github.com/users/gfokkema/following{/other_user}","gists_url":"https://api.github.com/users/gfokkema/gists{/gist_id}","starred_url":"https://api.github.com/users/gfokkema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfokkema/subscriptions","organizations_url":"https://api.github.com/users/gfokkema/orgs","repos_url":"https://api.github.com/users/gfokkema/repos","events_url":"https://api.github.com/users/gfokkema/events{/privacy}","received_events_url":"https://api.github.com/users/gfokkema/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfokkema/dnainator","description":"TI2806 Contextproject","fork":true,"url":"https://api.github.com/repos/gfokkema/dnainator","forks_url":"https://api.github.com/repos/gfokkema/dnainator/forks","keys_url":"https://api.github.com/repos/gfokkema/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfokkema/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfokkema/dnainator/teams","hooks_url":"https://api.github.com/repos/gfokkema/dnainator/hooks","issue_events_url":"https://api.github.com/repos/gfokkema/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/gfokkema/dnainator/events","assignees_url":"https://api.github.com/repos/gfokkema/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/gfokkema/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/gfokkema/dnainator/tags","blobs_url":"https://api.github.com/repos/gfokkema/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfokkema/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfokkema/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfokkema/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfokkema/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/gfokkema/dnainator/languages","stargazers_url":"https://api.github.com/repos/gfokkema/dnainator/stargazers","contributors_url":"https://api.github.com/repos/gfokkema/dnainator/contributors","subscribers_url":"https://api.github.com/repos/gfokkema/dnainator/subscribers","subscription_url":"https://api.github.com/repos/gfokkema/dnainator/subscription","commits_url":"https://api.github.com/repos/gfokkema/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfokkema/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfokkema/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfokkema/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfokkema/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/gfokkema/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfokkema/dnainator/merges","archive_url":"https://api.github.com/repos/gfokkema/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfokkema/dnainator/downloads","issues_url":"https://api.github.com/repos/gfokkema/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/gfokkema/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/gfokkema/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/gfokkema/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfokkema/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/gfokkema/dnainator/releases{/id}","created_at":"2015-04-22T16:28:16Z","updated_at":"2015-05-07T23:54:46Z","pushed_at":"2015-06-06T20:57:17Z","git_url":"git://github.com/gfokkema/dnainator.git","ssh_url":"git@github.com:gfokkema/dnainator.git","clone_url":"https://github.com/gfokkema/dnainator.git","svn_url":"https://github.com/gfokkema/dnainator","homepage":null,"size":12714,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DNAinator:master","ref":"master","sha":"1f334548db72cf1a9f8533dec9983ef17162b352","user":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"repo":{"id":34383905,"name":"dnainator","full_name":"DNAinator/dnainator","owner":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DNAinator/dnainator","description":"TI2806 Contextproject","fork":false,"url":"https://api.github.com/repos/DNAinator/dnainator","forks_url":"https://api.github.com/repos/DNAinator/dnainator/forks","keys_url":"https://api.github.com/repos/DNAinator/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNAinator/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNAinator/dnainator/teams","hooks_url":"https://api.github.com/repos/DNAinator/dnainator/hooks","issue_events_url":"https://api.github.com/repos/DNAinator/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/DNAinator/dnainator/events","assignees_url":"https://api.github.com/repos/DNAinator/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/DNAinator/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/DNAinator/dnainator/tags","blobs_url":"https://api.github.com/repos/DNAinator/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNAinator/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNAinator/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNAinator/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/DNAinator/dnainator/languages","stargazers_url":"https://api.github.com/repos/DNAinator/dnainator/stargazers","contributors_url":"https://api.github.com/repos/DNAinator/dnainator/contributors","subscribers_url":"https://api.github.com/repos/DNAinator/dnainator/subscribers","subscription_url":"https://api.github.com/repos/DNAinator/dnainator/subscription","commits_url":"https://api.github.com/repos/DNAinator/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNAinator/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNAinator/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNAinator/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/DNAinator/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNAinator/dnainator/merges","archive_url":"https://api.github.com/repos/DNAinator/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNAinator/dnainator/downloads","issues_url":"https://api.github.com/repos/DNAinator/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/DNAinator/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/DNAinator/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/DNAinator/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNAinator/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/DNAinator/dnainator/releases{/id}","created_at":"2015-04-22T10:22:38Z","updated_at":"2015-06-02T19:49:41Z","pushed_at":"2015-06-07T09:15:25Z","git_url":"git://github.com/DNAinator/dnainator.git","ssh_url":"git@github.com:DNAinator/dnainator.git","clone_url":"https://github.com/DNAinator/dnainator.git","svn_url":"https://github.com/DNAinator/dnainator","homepage":null,"size":18988,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/98"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/98"},"issue":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/98"},"comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/DNAinator/dnainator/statuses/027142f5d72607fb7e681faee2cc6bd937cae488"}}}}