{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/26484476","id":26484476,"diff_hunk":"@@ -827,9 +827,19 @@\n \n     if (this.isSearch()) {\n       var dataset = this.app.config;\n-      data.options.push({ id: 'search', text: dataset.searchName });\n+      data.options.push({\n+        id: 'search',\n+        text: {\n+          raw: dataset.searchName\n+        }\n+      });\n     } else {\n-      data.options.push({ id: 'origin', text: this.title.textContent });\n+      data.options.push({\n+        id: 'origin',\n+        text: {\n+          raw: this.title.textContent\n+        }\n+      });\n     }\n \n     ModalDialog.selectOne(data, selected);","path":"apps/system/js/app_chrome.js","position":21,"original_position":21,"commit_id":"49010dc249f5d6a3b38ed5e8159241196bf421f9","original_commit_id":"49010dc249f5d6a3b38ed5e8159241196bf421f9","user":{"login":"jankeromnes","id":599268,"avatar_url":"https://avatars.githubusercontent.com/u/599268?v=3","gravatar_id":"","url":"https://api.github.com/users/jankeromnes","html_url":"https://github.com/jankeromnes","followers_url":"https://api.github.com/users/jankeromnes/followers","following_url":"https://api.github.com/users/jankeromnes/following{/other_user}","gists_url":"https://api.github.com/users/jankeromnes/gists{/gist_id}","starred_url":"https://api.github.com/users/jankeromnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jankeromnes/subscriptions","organizations_url":"https://api.github.com/users/jankeromnes/orgs","repos_url":"https://api.github.com/users/jankeromnes/repos","events_url":"https://api.github.com/users/jankeromnes/events{/privacy}","received_events_url":"https://api.github.com/users/jankeromnes/received_events","type":"User","site_admin":false},"body":"Didn't you refactor this method to take an additional non-optional `title` parameter?","created_at":"2015-03-16T13:43:45Z","updated_at":"2015-03-16T13:43:45Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/28777#discussion_r26484476","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/26484476"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/28777#discussion_r26484476"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777","id":30905067,"html_url":"https://github.com/mozilla-b2g/gaia/pull/28777","diff_url":"https://github.com/mozilla-b2g/gaia/pull/28777.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/28777.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28777","number":28777,"state":"open","locked":false,"title":"Bug 1032128 - Add \"always allow\" for cert-based authentication. r=janx","user":{"login":"jryans","id":279572,"avatar_url":"https://avatars.githubusercontent.com/u/279572?v=3","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"body":"In addition to the \"always allow\" option, this reworks the \"selectone\" modal style to allow more customization and localization.","created_at":"2015-03-11T00:05:08Z","updated_at":"2015-03-16T13:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"512e44fe4fe56dab26dc603523ac824c0b6ac6d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28777/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/49010dc249f5d6a3b38ed5e8159241196bf421f9","head":{"label":"jryans:always-allow","ref":"always-allow","sha":"49010dc249f5d6a3b38ed5e8159241196bf421f9","user":{"login":"jryans","id":279572,"avatar_url":"https://avatars.githubusercontent.com/u/279572?v=3","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"repo":{"id":17960472,"name":"gaia","full_name":"jryans/gaia","owner":{"login":"jryans","id":279572,"avatar_url":"https://avatars.githubusercontent.com/u/279572?v=3","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jryans/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/jryans/gaia","forks_url":"https://api.github.com/repos/jryans/gaia/forks","keys_url":"https://api.github.com/repos/jryans/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jryans/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jryans/gaia/teams","hooks_url":"https://api.github.com/repos/jryans/gaia/hooks","issue_events_url":"https://api.github.com/repos/jryans/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/jryans/gaia/events","assignees_url":"https://api.github.com/repos/jryans/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/jryans/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/jryans/gaia/tags","blobs_url":"https://api.github.com/repos/jryans/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jryans/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jryans/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/jryans/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jryans/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/jryans/gaia/languages","stargazers_url":"https://api.github.com/repos/jryans/gaia/stargazers","contributors_url":"https://api.github.com/repos/jryans/gaia/contributors","subscribers_url":"https://api.github.com/repos/jryans/gaia/subscribers","subscription_url":"https://api.github.com/repos/jryans/gaia/subscription","commits_url":"https://api.github.com/repos/jryans/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/jryans/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/jryans/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/jryans/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/jryans/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/jryans/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jryans/gaia/merges","archive_url":"https://api.github.com/repos/jryans/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jryans/gaia/downloads","issues_url":"https://api.github.com/repos/jryans/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/jryans/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/jryans/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/jryans/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jryans/gaia/labels{/name}","releases_url":"https://api.github.com/repos/jryans/gaia/releases{/id}","created_at":"2014-03-20T22:19:22Z","updated_at":"2014-05-06T23:51:55Z","pushed_at":"2015-03-12T22:09:36Z","git_url":"git://github.com/jryans/gaia.git","ssh_url":"git@github.com:jryans/gaia.git","clone_url":"https://github.com/jryans/gaia.git","svn_url":"https://github.com/jryans/gaia","homepage":"https://wiki.mozilla.org/B2G","size":888774,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"10dcd335d588997fc12845e9197de89228664f95","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-03-16T09:58:36Z","pushed_at":"2015-03-16T09:58:42Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1455903,"stargazers_count":1889,"watchers_count":1889,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2255,"mirror_url":null,"open_issues_count":910,"forks":2255,"open_issues":910,"watchers":1889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/28777"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28777"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/28777/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/28777/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/49010dc249f5d6a3b38ed5e8159241196bf421f9"}}}}