{"action":"closed","issue":{"url":"https://api.github.com/repos/MassiveCraft/Factions/issues/167","labels_url":"https://api.github.com/repos/MassiveCraft/Factions/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/MassiveCraft/Factions/issues/167/comments","events_url":"https://api.github.com/repos/MassiveCraft/Factions/issues/167/events","html_url":"https://github.com/MassiveCraft/Factions/issues/167","id":6640732,"number":167,"title":"no FactionDisbandEvent when last player /f leave  or on autoLeaveOnInactivityRoutine","user":{"login":"ghost","id":10137,"avatar_url":"https://avatars.githubusercontent.com/u/10137?v=3","gravatar_id":"","url":"https://api.github.com/users/ghost","html_url":"https://github.com/ghost","followers_url":"https://api.github.com/users/ghost/followers","following_url":"https://api.github.com/users/ghost/following{/other_user}","gists_url":"https://api.github.com/users/ghost/gists{/gist_id}","starred_url":"https://api.github.com/users/ghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghost/subscriptions","organizations_url":"https://api.github.com/users/ghost/orgs","repos_url":"https://api.github.com/users/ghost/repos","events_url":"https://api.github.com/users/ghost/events{/privacy}","received_events_url":"https://api.github.com/users/ghost/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2012-09-04T17:28:50Z","updated_at":"2015-09-08T02:08:23Z","closed_at":"2015-09-08T02:08:23Z","body":"the relevant code is in FPlayer.java  if you search for \"// Remove this faction\"  (both 1.6 and 1.7) it' s inside the com.massivecraft.factions.FPlayer.leave(boolean)  method\n\nThe method is called both on autoLeaveOnInactivityRoutine() and on /f leave.\n\nI realize that on both these times the cancelled should be ignored if FactionDisbandEvent (FDE) should be called.\n\nI'd even go as far as having FactionDisbandEvent.isCancellable() method which would return false in both these cases, but true in the case of /f disband (which is the only one that calls this event at this time of this writing - according to Alt+Ctrl+H in eclipse)\n\nCome to think of it, in my own needs I could probably use the FPlayerLeaveEvent and check if that's the only player left in the faction and thus deduce the faction's gonna be disbanded, and in effect not need to have FDE called in those 2 cases.\n\nI'd love to hear your thoughts on this, thanks!"}}