{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/286","labels_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/286/comments","events_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/286/events","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/286","id":96406779,"number":286,"title":"EZP-24129: Application Config Provider","user":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars.githubusercontent.com/u/235928?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-07-21T20:14:20Z","updated_at":"2015-07-25T09:14:12Z","closed_at":"2015-07-24T10:39:41Z","pull_request":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/pulls/286","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/286","diff_url":"https://github.com/ezsystems/PlatformUIBundle/pull/286.diff","patch_url":"https://github.com/ezsystems/PlatformUIBundle/pull/286.patch"},"body":"> Implements https://jira.ez.no/browse/EZP-24129\r\n> Status: approved by @dpobel and @lolautruche, merged\r\n\r\nAdds an Aggregator, passed on to the PlatformUIController, that aggregates a bunch of `ApplicationConfigProviders`.\r\n\r\nThe existing configs were converted to their own implementation of `ApplicationConfigProvider`: `AnonymousUserId`, `CountriesInfo`, `SessionInfo`.\r\n\r\nA compiler pass parses the `ezsystems.platformui.application_config_provider` tag, and registers them in the Aggregator. The `key` attribute of the tag is used as the namespace. \r\n\r\nThe controller assigns the whole thing to the template as the `parameters` array.\r\n\r\n### TODO\r\n- [x] Improve naming, it's terrible right now\r\n- [x] Write tests\r\n- [x] See if the JS code that passes on the config to the app should be updated somehow. With the current code, `shell.html.twig` must be changed to add new config namespaces.\r\n- [x] Add Root Parameter Provider (with assets root and rest root)\r\n- [x] Squash once review is finished"},"comment":{"url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/comments/124824916","html_url":"https://github.com/ezsystems/PlatformUIBundle/pull/286#issuecomment-124824916","issue_url":"https://api.github.com/repos/ezsystems/PlatformUIBundle/issues/286","id":124824916,"user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"created_at":"2015-07-25T09:14:12Z","updated_at":"2015-07-25T09:14:12Z","body":"looks good besides nitpick :)"}}