{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26","id":35092302,"html_url":"https://github.com/zeekay/flask-uwsgi-websocket/pull/26","diff_url":"https://github.com/zeekay/flask-uwsgi-websocket/pull/26.diff","patch_url":"https://github.com/zeekay/flask-uwsgi-websocket/pull/26.patch","issue_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/26","number":26,"state":"open","locked":false,"title":"Don't shadow variables","user":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"body":"You are shadowing the global ws by the function parameter ws which might confuse people (it confused me :P). Better give them different names.","created_at":"2015-05-11T01:13:03Z","updated_at":"2015-05-11T01:13:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26/commits","review_comments_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26/comments","review_comment_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/26/comments","statuses_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/statuses/631bc36800858d2037fa62b0c02be3890a8e735d","head":{"label":"svenstaro:patch-1","ref":"patch-1","sha":"631bc36800858d2037fa62b0c02be3890a8e735d","user":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"repo":{"id":35390821,"name":"flask-uwsgi-websocket","full_name":"svenstaro/flask-uwsgi-websocket","owner":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svenstaro/flask-uwsgi-websocket","description":"  High-performance WebSockets for your Flask apps powered by uWSGI.","fork":true,"url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket","forks_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/forks","keys_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/teams","hooks_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/hooks","issue_events_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/issues/events{/number}","events_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/events","assignees_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/assignees{/user}","branches_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/branches{/branch}","tags_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/tags","blobs_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/languages","stargazers_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/stargazers","contributors_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/contributors","subscribers_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/subscribers","subscription_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/subscription","commits_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/contents/{+path}","compare_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/merges","archive_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/downloads","issues_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/issues{/number}","pulls_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/labels{/name}","releases_url":"https://api.github.com/repos/svenstaro/flask-uwsgi-websocket/releases{/id}","created_at":"2015-05-10T22:40:16Z","updated_at":"2015-05-10T22:40:16Z","pushed_at":"2015-05-11T01:12:55Z","git_url":"git://github.com/svenstaro/flask-uwsgi-websocket.git","ssh_url":"git@github.com:svenstaro/flask-uwsgi-websocket.git","clone_url":"https://github.com/svenstaro/flask-uwsgi-websocket.git","svn_url":"https://github.com/svenstaro/flask-uwsgi-websocket","homepage":"","size":129,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeekay:master","ref":"master","sha":"a8ccae71df15396cf1a7a6051da2d1d602654705","user":{"login":"zeekay","id":285707,"avatar_url":"https://avatars.githubusercontent.com/u/285707?v=3","gravatar_id":"","url":"https://api.github.com/users/zeekay","html_url":"https://github.com/zeekay","followers_url":"https://api.github.com/users/zeekay/followers","following_url":"https://api.github.com/users/zeekay/following{/other_user}","gists_url":"https://api.github.com/users/zeekay/gists{/gist_id}","starred_url":"https://api.github.com/users/zeekay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeekay/subscriptions","organizations_url":"https://api.github.com/users/zeekay/orgs","repos_url":"https://api.github.com/users/zeekay/repos","events_url":"https://api.github.com/users/zeekay/events{/privacy}","received_events_url":"https://api.github.com/users/zeekay/received_events","type":"User","site_admin":false},"repo":{"id":16104568,"name":"flask-uwsgi-websocket","full_name":"zeekay/flask-uwsgi-websocket","owner":{"login":"zeekay","id":285707,"avatar_url":"https://avatars.githubusercontent.com/u/285707?v=3","gravatar_id":"","url":"https://api.github.com/users/zeekay","html_url":"https://github.com/zeekay","followers_url":"https://api.github.com/users/zeekay/followers","following_url":"https://api.github.com/users/zeekay/following{/other_user}","gists_url":"https://api.github.com/users/zeekay/gists{/gist_id}","starred_url":"https://api.github.com/users/zeekay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeekay/subscriptions","organizations_url":"https://api.github.com/users/zeekay/orgs","repos_url":"https://api.github.com/users/zeekay/repos","events_url":"https://api.github.com/users/zeekay/events{/privacy}","received_events_url":"https://api.github.com/users/zeekay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeekay/flask-uwsgi-websocket","description":"  High-performance WebSockets for your Flask apps powered by uWSGI.","fork":false,"url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket","forks_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/forks","keys_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/teams","hooks_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/hooks","issue_events_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/events{/number}","events_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/events","assignees_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/assignees{/user}","branches_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/branches{/branch}","tags_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/tags","blobs_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/languages","stargazers_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/stargazers","contributors_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/contributors","subscribers_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/subscribers","subscription_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/subscription","commits_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/contents/{+path}","compare_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/merges","archive_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/downloads","issues_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues{/number}","pulls_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/labels{/name}","releases_url":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/releases{/id}","created_at":"2014-01-21T14:21:24Z","updated_at":"2015-04-28T06:57:52Z","pushed_at":"2015-05-11T01:13:03Z","git_url":"git://github.com/zeekay/flask-uwsgi-websocket.git","ssh_url":"git@github.com:zeekay/flask-uwsgi-websocket.git","clone_url":"https://github.com/zeekay/flask-uwsgi-websocket.git","svn_url":"https://github.com/zeekay/flask-uwsgi-websocket","homepage":"","size":611,"stargazers_count":73,"watchers_count":73,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26"},"html":{"href":"https://github.com/zeekay/flask-uwsgi-websocket/pull/26"},"issue":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/26"},"comments":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/zeekay/flask-uwsgi-websocket/statuses/631bc36800858d2037fa62b0c02be3890a8e735d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}