{"action":"created","issue":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/2359","labels_url":"https://api.github.com/repos/pantsbuild/pants/issues/2359/labels{/name}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/2359/comments","events_url":"https://api.github.com/repos/pantsbuild/pants/issues/2359/events","html_url":"https://github.com/pantsbuild/pants/issues/2359","id":110850604,"number":2359,"title":"jvm_binary deploy_excludes changed behavior as of 0.0.52","user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pantsbuild/pants/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/pantsbuild/pants/labels/in-progress","name":"in-progress","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"jsirois","id":157586,"avatar_url":"https://avatars.githubusercontent.com/u/157586?v=3","gravatar_id":"","url":"https://api.github.com/users/jsirois","html_url":"https://github.com/jsirois","followers_url":"https://api.github.com/users/jsirois/followers","following_url":"https://api.github.com/users/jsirois/following{/other_user}","gists_url":"https://api.github.com/users/jsirois/gists{/gist_id}","starred_url":"https://api.github.com/users/jsirois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsirois/subscriptions","organizations_url":"https://api.github.com/users/jsirois/orgs","repos_url":"https://api.github.com/users/jsirois/repos","events_url":"https://api.github.com/users/jsirois/events{/privacy}","received_events_url":"https://api.github.com/users/jsirois/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-11T11:23:29Z","updated_at":"2015-10-11T22:06:17Z","closed_at":null,"body":"I am experimenting with using `deploy_excludes` in junit-runner to fix a problem I'm having with running a particular kind of test suite.  I noticed that building a jar file with 0.0.53 and deploy_excludes=[] appears to be broken, or I don't understand how it is supposed to work.\r\n\r\nHere's the patch I was working with:\r\n\r\n```\r\ndiff --git a/src/java/org/pantsbuild/tools/junit/BUILD b/src/java/org/pantsbuild/tools/junit/BUILD\r\nindex 3738214..f72d1cf 100644\r\n--- a/src/java/org/pantsbuild/tools/junit/BUILD\r\n+++ b/src/java/org/pantsbuild/tools/junit/BUILD\r\n@@ -31,6 +31,9 @@ jvm_binary(\r\n   dependencies=[\r\n     ':junit',\r\n   ],\r\n+  deploy_excludes=[\r\n+    exclude(name='junit', org='junit'),\r\n+  ],\r\n   description=\"\"\"\r\n A replacement for org.junit.runner.JUnitCore.main that adds:\r\n   + support for running individual test methods using [classname]#[methodname]\r\n```\r\n\r\nI created jars with 0.0.51 and 0.0.52 respectively and renamed the output\r\n\r\n```\r\n$ ls -l junit*\r\n-rw-r--r--  1 zundel  zundel  2701454 Oct 11 07:03 junit-runner-0.0.51.jar\r\n-rw-r--r--  1 zundel  zundel  3068891 Oct 11 07:17 junit-runner-0.0.52.jar\r\n```\r\n\r\nThe difference is that the version created with 0.0.51 doesn't contain the org.junit classes, but the one created with 0.0.52 still contains them (as if deploy_excludes was not specified.)\r\n\r\n```\r\n$ jar -tvf junit-runner-0.0.51.jar | grep \"org/junit\" | wc -l\r\n       0\r\n$ jar -tvf junit-runner-0.0.52.jar | grep \"org/junit\" | wc -l\r\n     284\r\n```"},"comment":{"url":"https://api.github.com/repos/pantsbuild/pants/issues/comments/147250418","html_url":"https://github.com/pantsbuild/pants/issues/2359#issuecomment-147250418","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/2359","id":147250418,"user":{"login":"ericzundel","id":119728,"avatar_url":"https://avatars.githubusercontent.com/u/119728?v=3","gravatar_id":"","url":"https://api.github.com/users/ericzundel","html_url":"https://github.com/ericzundel","followers_url":"https://api.github.com/users/ericzundel/followers","following_url":"https://api.github.com/users/ericzundel/following{/other_user}","gists_url":"https://api.github.com/users/ericzundel/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzundel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzundel/subscriptions","organizations_url":"https://api.github.com/users/ericzundel/orgs","repos_url":"https://api.github.com/users/ericzundel/repos","events_url":"https://api.github.com/users/ericzundel/events{/privacy}","received_events_url":"https://api.github.com/users/ericzundel/received_events","type":"User","site_admin":false},"created_at":"2015-10-11T22:06:17Z","updated_at":"2015-10-11T22:06:17Z","body":"I put up a fix for the 'adding an additional argument' fix: https://rbcommons.com/s/twitter/r/2962/"}}