{"push_id":813909509,"size":20,"distinct_size":20,"ref":"refs/heads/master","head":"71ce07f2c87c450cbc3ca233c520584b897c4761","before":"9bfca466c97ffff94f15923905d39782d0c85249","commits":[{"sha":"a705076172b274463563416adffe55f129740267","author":{"email":"305cc9d5027c0f4e08c2697d4cabde07a8221669@redhat.com","name":"Steve Dickson"},"message":"rpc.gssd: Only clear the retval if it has not been set\n\nIn gssd_search_krb5_keytab() an error code can be\ncleared by blindly setting retval to zero.\n\nReported-by: Jianhong Yin <jiyin@redhat.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/a705076172b274463563416adffe55f129740267"},{"sha":"8c7d7fe5577b059130d472d4145a09cf9d4a7ea2","author":{"email":"305cc9d5027c0f4e08c2697d4cabde07a8221669@redhat.com","name":"Steve Dickson"},"message":"mountstats.man: fixed typo in man page\n\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/8c7d7fe5577b059130d472d4145a09cf9d4a7ea2"},{"sha":"21f10369965bb183d1a72df1da0c2811cd2b1d5c","author":{"email":"354e29cfbea2f74d5ce81a3b79d7f0264830cb78@netapp.com","name":"Andy Adamson"},"message":"rpc.gssd: Replace exit(0) by return in process_krb5_upcall\n\nFrom: Andy Adamson <andros@netapp.com>\n\nexit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory\nrpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for\neach upcall, ignoring a valid TGT in the kerberos credential cache.\n\nSigned-off-by: Andy Adamson <andros@netapp.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/21f10369965bb183d1a72df1da0c2811cd2b1d5c"},{"sha":"34fd18332fd536e2f7a75274576bfa49f0af34e7","author":{"email":"305cc9d5027c0f4e08c2697d4cabde07a8221669@redhat.com","name":"Steve Dickson"},"message":"Revert \"rpc.gssd: Replace exit(0) by return in process_krb5_upcall\"\n\nThis reverts commit 21f10369965bb183d1a72df1da0c2811cd2b1d5c\ndue to child processes not exiting on upcalls.","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/34fd18332fd536e2f7a75274576bfa49f0af34e7"},{"sha":"67a435bbf5015d8d2f6008744cadab4c4ede7c07","author":{"email":"bceb368e7f2cb351af47298f32034f0587bbe4a6@chabot.fr","name":"Aurelien Chabot"},"message":"Install only needed systemd unit file\n\nSigned-off-by: Aurelien Chabot <aurelien@chabot.fr>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/67a435bbf5015d8d2f6008744cadab4c4ede7c07"},{"sha":"017164521b94018bd143b879b0e858d98cca83e8","author":{"email":"305cc9d5027c0f4e08c2697d4cabde07a8221669@redhat.com","name":"Steve Dickson"},"message":"configure.ac: with-systemd flag not using default directory\n\nThe with-systemd config flag was not using the\ndefault directory when a directory was not given\n\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/017164521b94018bd143b879b0e858d98cca83e8"},{"sha":"5135a70fd0917986a575f9f01d0a29b5c93c4041","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: Display the effective NFSv4 domain name\n\nSorry for the extensive man page changes. I added the description\nfor the new \"-d\" option, then realized there was no explanation\nabout what an \"NFSv4 domain name\" is.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/5135a70fd0917986a575f9f01d0a29b5c93c4041"},{"sha":"8903d75ed4abd4207873b315885b559abfaa2af8","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: Use find_key_by_type_and_desc() if available\n\nRecent versions of libkeyutils have find_key_by_type_and_desc()\nwhich replaces the open-coded keyring search in keyring_clear().\n\nI don't quite understand what's going on in key_invalidate(),\nso I didn't touch it.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/8903d75ed4abd4207873b315885b559abfaa2af8"},{"sha":"43bcaca81740cbe78f4f97cf8b0fc39350a17a68","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: List cached ID mapping results\n\nUser space can see the keys, but not their contents.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/43bcaca81740cbe78f4f97cf8b0fc39350a17a68"},{"sha":"49f6c29fcfd924b2b964cce75623463c0d1c0d59","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: Fix error handling in id_lookup()\n\nAs near as I can tell, the exit status of nfsidmap is supposed to be\nzero (success) or one (failure).\n\nThe return value of id_lookup() becomes the exit status, so it\nshould return only zero or one.\n\nThe libnfsidmap calls return a signed integer, either 0 or negative\nerrno values. These have to be translated to an exit status.\n\nlibkeyutils calls return a signed long, either 0 or -1. These also\nhave to be translated to an exit status.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/49f6c29fcfd924b2b964cce75623463c0d1c0d59"},{"sha":"0b463a7bc09d89e0e141546ea5c5c59d94c5fefe","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: Fix error handling in name_lookup()\n\nAs near as I can tell, the exit status of nfsidmap is supposed to be\nzero (success) or one (failure).\n\nThe return value of name_lookup() becomes the exit status, so it\nshould return only zero or one.\n\nThe libnfsidmap calls return a signed integer, either 0 or negative\nerrno values. These have to be translated to an exit status.\n\nlibkeyutils calls return a signed long, either 0 or -1. These also\nhave to be translated to an exit status.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/0b463a7bc09d89e0e141546ea5c5c59d94c5fefe"},{"sha":"a4def734f7b9601c9ce89f18841aadf7a1962063","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"nfsidmap: Clean up other exit status cases\n\nMake it unambiguous where 0 or 1 represent an exit status.\n\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/a4def734f7b9601c9ce89f18841aadf7a1962063"},{"sha":"78240c41be17bd20d5fb5b70b6f470d8e779adee","author":{"email":"2e22df475573e88bce729ca6f5857d12b75544e6@samsung.com","name":"Vivek Trivedi"},"message":"mountd: fix mount issue due to comparison with uninitialized uuid\n\nFix mount issue due to comparison of uninitialized variable\nu(uuid) with parsed->fhuuid when uuid_by_path return 0.\n\n/tmp/usb\n192.168.1.0/16(ro,no_root_squash,no_subtree_check,fsid=0)\n/tmp/usb/sda1       192.168.1.0/16(ro,no_root_squash,no_subtree_check)\n/tmp/usb/sdb1       192.168.1.0/16(ro,no_root_squash,no_subtree_check)\n\nmount -t nfs -o nolock,nfsvers=3 192.168.1.2:/tmp/usb/sda1 /tmp/sda1\nmount -t nfs -o nolock,nfsvers=3 192.168.1.2:/tmp/usb/sdb1 /tmp/sdb1\n\nresults in below mountd error:\nmountd: /tmp/usb and /tmp/usb/sdb1 have same filehandle for\n192.168.1.0/16, using first\n\nwhen uuid_by_path returned 0, by chance, garbage value of u was same as\nparsed->fhuuid(of sdb1), and comparison of these resulted in above\nerror.\n\nSigned-off-by: Vivek Trivedi <t.vivek@samsung.com>\nReviewed-by: Amit Sahrawat <a.sahrawat@samsung.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/78240c41be17bd20d5fb5b70b6f470d8e779adee"},{"sha":"3a5732152c60f8cefaa804db0b81e424e96ee657","author":{"email":"e7d8216bf9b1956703857d0050bd04192118f43d@oracle.com","name":"Chuck Lever"},"message":"statd: statd_get_socket() should return open fds\n\nTastky <tastky@gmail.com> reports:\n> There appears to be a bug in nfs-utils exposed by musl, which\n> makes rpc.statd loop with:\n>\n> my_svc_run() - select: Bad file descriptor\n\nOpenGroup says getservbyport(3) is supposed to return NULL when\nno entry exists for the specified port. But musl's getservbyport(3)\nnever returns NULL (likely a bug).\n\nThus statd_get_socket() tries bindresvport(3) 100 times, then gives\nup and returns the last socket it created. This should work fine,\nbut there's a bug in the retry loop:\n\nRich Felker <dalias@libc.org> says:\n> The logic bug is the count-down loop that closes all the temp\n> sockets. In the case where the loop terminates via break, it\n> leaves the last one open and only closes the extras. But in the\n> case where where the loop terminates via the end condition in the\n> for statement, the close loop closes all the sockets _including_\n> the one it intends to use.\n\n(emphasis mine). The closed socket fd is then passed to select(2).\n\nSee also: http://www.openwall.com/lists/musl/2015/08\n\nThe fix is to perform the loop termination test before adding sockfd\nto the set of fds to be closed. As additional clean ups, remove the\nuse of the variable-length stack array, and switch to variable names\nthat better document the purpose of this logic.\n\nReported-by: Tastky <tastky@gmail.com>\nFixes: eb8229338f06 (\"rpc.statd: Fix socket binding loop.\")\nSigned-off-by: Chuck Lever <chuck.lever@oracle.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/3a5732152c60f8cefaa804db0b81e424e96ee657"},{"sha":"f2efa15ef8c083926791195ed1037fd47a5e4e41","author":{"email":"129700617821125d23e4a9ae8bf609ed655da086@redhat.com","name":"Scott Mayhew"},"message":"mountstats.man:  Remove a few bogus .R macros\n\nThese have no effect on the rendering of the man page, but they do cause\nthe following error if you try to pipe or redirect the output:\n\n`R' is a string (producing the registered sign), not a macro.\n\nSigned-off-by: Scott Mayhew <smayhew@redhat.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/f2efa15ef8c083926791195ed1037fd47a5e4e41"},{"sha":"1201d5d8aeb0651a6fe195bc8232128ddf6e8b28","author":{"email":"354e29cfbea2f74d5ce81a3b79d7f0264830cb78@netapp.com","name":"Andy Adamson"},"message":"GSSD: move process_krb5_upcall machine cred case to helper function\n\nSigned-off-by: Andy Adamson <andros@netapp.com>\nSigned-off-by: Jeff Layton <jlayton@poochiereds.net>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/1201d5d8aeb0651a6fe195bc8232128ddf6e8b28"},{"sha":"cbe19a1d34d4d13f41337047da26ec1ef82ed44c","author":{"email":"354e29cfbea2f74d5ce81a3b79d7f0264830cb78@netapp.com","name":"Andy Adamson"},"message":"GSSD: move process_krb5_updcall non machine cred case to helper function\n\nSigned-off-by: Andy Adamson <andros@netapp.com>\nSigned-off-by: Jeff Layton <jlayton@poochiereds.net>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/cbe19a1d34d4d13f41337047da26ec1ef82ed44c"},{"sha":"30c37b2dd6decdd65a33b956a5ae4b548de63a6d","author":{"email":"354e29cfbea2f74d5ce81a3b79d7f0264830cb78@netapp.com","name":"Andy Adamson"},"message":"GSSD only fork when uid is not zero\n\ncommit f9cac65972da588d5218236de60a7be11247a8aa\nadded the fork to process_krb5_upcall so that the\nchild assumes the uid of the principal requesting\nservice.\n\nWhen machine credentials are used, a gssd_k5_kt_princ\nentry is added to a global list and used by future\nupcalls to note when valid machine credentials have\nbeen obtained. When a child process performs this task,\nthe entry to the global list is lost upon exit, and\nall upcalls for machine credentials re-fetch a TGT,\neven when a valid TGT is in the machine kerberos\ncredential cache.\n\nSince forking is not necessary when the principal has\nuid=0, solve the gssd_k5_kt_princ_list issue by only\nforking when the uid != 0.\n\nAcked-by: Jeff Layton <jlayton@poochiereds.net>\nSigned-off-by: Andy Adamson <andros@netapp.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/30c37b2dd6decdd65a33b956a5ae4b548de63a6d"},{"sha":"ad50822bf010c5a7917f160b4d4b39e71f15d086","author":{"email":"354e29cfbea2f74d5ce81a3b79d7f0264830cb78@netapp.com","name":"Andy Adamson"},"message":"GSSD: clean up machine credentials\n\nSince we no longer fork for uid 0, gssd_atexit()\nis only called when uid != 0, and fails as permissions\non the /tmp/krb5ccmachine_REALM file prohibit the\nclean up of machine credentials (as it should).\n\nMove the reaping of machine credentials back into a\nSIGINT sighandler so that <Ctrl-C> destroyes\nmachine credentials.\n\nSigned-off-by: Andy Adamson <andros@netapp.com>\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/ad50822bf010c5a7917f160b4d4b39e71f15d086"},{"sha":"71ce07f2c87c450cbc3ca233c520584b897c4761","author":{"email":"305cc9d5027c0f4e08c2697d4cabde07a8221669@redhat.com","name":"Steve Dickson"},"message":"Release 1.3.3\n\nSigned-off-by: Steve Dickson <steved@redhat.com>","distinct":true,"url":"https://api.github.com/repos/Distrotech/nfs-utils/commits/71ce07f2c87c450cbc3ca233c520584b897c4761"}]}