{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/1555","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/1555/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/1555/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/1555/events","html_url":"https://github.com/LMMS/lmms/pull/1555","id":53408764,"number":1555,"title":"Lock SF2 player mutex around pitch-related calls","user":{"login":"softrabbit","id":6411463,"avatar_url":"https://avatars.githubusercontent.com/u/6411463?v=3","gravatar_id":"","url":"https://api.github.com/users/softrabbit","html_url":"https://github.com/softrabbit","followers_url":"https://api.github.com/users/softrabbit/followers","following_url":"https://api.github.com/users/softrabbit/following{/other_user}","gists_url":"https://api.github.com/users/softrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/softrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softrabbit/subscriptions","organizations_url":"https://api.github.com/users/softrabbit/orgs","repos_url":"https://api.github.com/users/softrabbit/repos","events_url":"https://api.github.com/users/softrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/softrabbit/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-01-05T15:44:24Z","updated_at":"2015-01-12T14:26:01Z","closed_at":"2015-01-10T02:28:09Z","pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/1555","html_url":"https://github.com/LMMS/lmms/pull/1555","diff_url":"https://github.com/LMMS/lmms/pull/1555.diff","patch_url":"https://github.com/LMMS/lmms/pull/1555.patch"},"body":"Looks like locking the mutex in SF2 player is needed around a few more operations than before, at least while importing MIDI. Should fix #1544"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/69576586","html_url":"https://github.com/LMMS/lmms/pull/1555#issuecomment-69576586","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/1555","id":69576586,"user":{"login":"diizy","id":6368868,"avatar_url":"https://avatars.githubusercontent.com/u/6368868?v=3","gravatar_id":"","url":"https://api.github.com/users/diizy","html_url":"https://github.com/diizy","followers_url":"https://api.github.com/users/diizy/followers","following_url":"https://api.github.com/users/diizy/following{/other_user}","gists_url":"https://api.github.com/users/diizy/gists{/gist_id}","starred_url":"https://api.github.com/users/diizy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diizy/subscriptions","organizations_url":"https://api.github.com/users/diizy/orgs","repos_url":"https://api.github.com/users/diizy/repos","events_url":"https://api.github.com/users/diizy/events{/privacy}","received_events_url":"https://api.github.com/users/diizy/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T14:26:01Z","updated_at":"2015-01-12T14:26:01Z","body":"On 01/12/2015 01:09 PM, Raine M. Ekman wrote:\n>\n> I pulled those mutex operations out and here are the relevant threads\n> when it crashes on adding an SF2 player.\n>\n\nMaybe you could consult the fluidsynth developers, they might be able to\nadvise on the issue & let us know which parts of their API are\nthreadsafe and if it's possible to call these functions locklessly."}}