{"action":"created","comment":{"url":"https://api.github.com/repos/Araq/Nim/pulls/comments/30469390","id":30469390,"diff_hunk":"@@ -708,9 +708,12 @@ proc `$`*(node: NimNode): string {.compileTime.} =\n proc ident*(name: string): NimNode {.compileTime,inline.} = newIdentNode(name)\n   ## Create a new ident node from a string\n \n-iterator children*(n: NimNode): NimNode {.inline.}=\n-  for i in 0 .. high(n):\n-    yield n[i]\n+iterator items*(n: NimNode): NimNode {.inline.} =\n+  if n[0] != nil:","path":"lib/core/macros.nim","position":8,"original_position":8,"commit_id":"3d80fcb8c6ff1e03922f517681efad65d79563fb","original_commit_id":"3d80fcb8c6ff1e03922f517681efad65d79563fb","user":{"login":"dom96","id":246651,"avatar_url":"https://avatars.githubusercontent.com/u/246651?v=3","gravatar_id":"","url":"https://api.github.com/users/dom96","html_url":"https://github.com/dom96","followers_url":"https://api.github.com/users/dom96/followers","following_url":"https://api.github.com/users/dom96/following{/other_user}","gists_url":"https://api.github.com/users/dom96/gists{/gist_id}","starred_url":"https://api.github.com/users/dom96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dom96/subscriptions","organizations_url":"https://api.github.com/users/dom96/orgs","repos_url":"https://api.github.com/users/dom96/repos","events_url":"https://api.github.com/users/dom96/events{/privacy}","received_events_url":"https://api.github.com/users/dom96/received_events","type":"User","site_admin":false},"body":"Might be better to check the node kind.","created_at":"2015-05-17T10:44:29Z","updated_at":"2015-05-17T10:44:29Z","html_url":"https://github.com/Araq/Nim/pull/2740#discussion_r30469390","pull_request_url":"https://api.github.com/repos/Araq/Nim/pulls/2740","_links":{"self":{"href":"https://api.github.com/repos/Araq/Nim/pulls/comments/30469390"},"html":{"href":"https://github.com/Araq/Nim/pull/2740#discussion_r30469390"},"pull_request":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2740"}}},"pull_request":{"url":"https://api.github.com/repos/Araq/Nim/pulls/2740","id":35574813,"html_url":"https://github.com/Araq/Nim/pull/2740","diff_url":"https://github.com/Araq/Nim/pull/2740.diff","patch_url":"https://github.com/Araq/Nim/pull/2740.patch","issue_url":"https://api.github.com/repos/Araq/Nim/issues/2740","number":2740,"state":"open","locked":false,"title":"Unless there's some reason for not giving macros an items iterator.","user":{"login":"transfuturist","id":4128514,"avatar_url":"https://avatars.githubusercontent.com/u/4128514?v=3","gravatar_id":"","url":"https://api.github.com/users/transfuturist","html_url":"https://github.com/transfuturist","followers_url":"https://api.github.com/users/transfuturist/followers","following_url":"https://api.github.com/users/transfuturist/following{/other_user}","gists_url":"https://api.github.com/users/transfuturist/gists{/gist_id}","starred_url":"https://api.github.com/users/transfuturist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transfuturist/subscriptions","organizations_url":"https://api.github.com/users/transfuturist/orgs","repos_url":"https://api.github.com/users/transfuturist/repos","events_url":"https://api.github.com/users/transfuturist/events{/privacy}","received_events_url":"https://api.github.com/users/transfuturist/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-05-16T18:02:12Z","updated_at":"2015-05-17T10:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d96594ca1fc3971762e22ef8ac097a625e4930f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Araq/Nim/pulls/2740/commits","review_comments_url":"https://api.github.com/repos/Araq/Nim/pulls/2740/comments","review_comment_url":"https://api.github.com/repos/Araq/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Araq/Nim/issues/2740/comments","statuses_url":"https://api.github.com/repos/Araq/Nim/statuses/3d80fcb8c6ff1e03922f517681efad65d79563fb","head":{"label":"transfuturist:macro-items","ref":"macro-items","sha":"3d80fcb8c6ff1e03922f517681efad65d79563fb","user":{"login":"transfuturist","id":4128514,"avatar_url":"https://avatars.githubusercontent.com/u/4128514?v=3","gravatar_id":"","url":"https://api.github.com/users/transfuturist","html_url":"https://github.com/transfuturist","followers_url":"https://api.github.com/users/transfuturist/followers","following_url":"https://api.github.com/users/transfuturist/following{/other_user}","gists_url":"https://api.github.com/users/transfuturist/gists{/gist_id}","starred_url":"https://api.github.com/users/transfuturist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transfuturist/subscriptions","organizations_url":"https://api.github.com/users/transfuturist/orgs","repos_url":"https://api.github.com/users/transfuturist/repos","events_url":"https://api.github.com/users/transfuturist/events{/privacy}","received_events_url":"https://api.github.com/users/transfuturist/received_events","type":"User","site_admin":false},"repo":{"id":35439611,"name":"Nim","full_name":"transfuturist/Nim","owner":{"login":"transfuturist","id":4128514,"avatar_url":"https://avatars.githubusercontent.com/u/4128514?v=3","gravatar_id":"","url":"https://api.github.com/users/transfuturist","html_url":"https://github.com/transfuturist","followers_url":"https://api.github.com/users/transfuturist/followers","following_url":"https://api.github.com/users/transfuturist/following{/other_user}","gists_url":"https://api.github.com/users/transfuturist/gists{/gist_id}","starred_url":"https://api.github.com/users/transfuturist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transfuturist/subscriptions","organizations_url":"https://api.github.com/users/transfuturist/orgs","repos_url":"https://api.github.com/users/transfuturist/repos","events_url":"https://api.github.com/users/transfuturist/events{/privacy}","received_events_url":"https://api.github.com/users/transfuturist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/transfuturist/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":true,"url":"https://api.github.com/repos/transfuturist/Nim","forks_url":"https://api.github.com/repos/transfuturist/Nim/forks","keys_url":"https://api.github.com/repos/transfuturist/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transfuturist/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transfuturist/Nim/teams","hooks_url":"https://api.github.com/repos/transfuturist/Nim/hooks","issue_events_url":"https://api.github.com/repos/transfuturist/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/transfuturist/Nim/events","assignees_url":"https://api.github.com/repos/transfuturist/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/transfuturist/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/transfuturist/Nim/tags","blobs_url":"https://api.github.com/repos/transfuturist/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transfuturist/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transfuturist/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/transfuturist/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transfuturist/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/transfuturist/Nim/languages","stargazers_url":"https://api.github.com/repos/transfuturist/Nim/stargazers","contributors_url":"https://api.github.com/repos/transfuturist/Nim/contributors","subscribers_url":"https://api.github.com/repos/transfuturist/Nim/subscribers","subscription_url":"https://api.github.com/repos/transfuturist/Nim/subscription","commits_url":"https://api.github.com/repos/transfuturist/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/transfuturist/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/transfuturist/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/transfuturist/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/transfuturist/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/transfuturist/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transfuturist/Nim/merges","archive_url":"https://api.github.com/repos/transfuturist/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transfuturist/Nim/downloads","issues_url":"https://api.github.com/repos/transfuturist/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/transfuturist/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/transfuturist/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/transfuturist/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transfuturist/Nim/labels{/name}","releases_url":"https://api.github.com/repos/transfuturist/Nim/releases{/id}","created_at":"2015-05-11T17:42:15Z","updated_at":"2015-05-11T17:42:20Z","pushed_at":"2015-05-17T00:50:11Z","git_url":"git://github.com/transfuturist/Nim.git","ssh_url":"git@github.com:transfuturist/Nim.git","clone_url":"https://github.com/transfuturist/Nim.git","svn_url":"https://github.com/transfuturist/Nim","homepage":"http://nim-lang.org/","size":37767,"stargazers_count":0,"watchers_count":0,"language":"Nimrod","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"Araq:devel","ref":"devel","sha":"61c7cc2ff76fbc589d4827d9eba257b280e43c4a","user":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"Araq/Nim","owner":{"login":"Araq","id":287816,"avatar_url":"https://avatars.githubusercontent.com/u/287816?v=3","gravatar_id":"","url":"https://api.github.com/users/Araq","html_url":"https://github.com/Araq","followers_url":"https://api.github.com/users/Araq/followers","following_url":"https://api.github.com/users/Araq/following{/other_user}","gists_url":"https://api.github.com/users/Araq/gists{/gist_id}","starred_url":"https://api.github.com/users/Araq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Araq/subscriptions","organizations_url":"https://api.github.com/users/Araq/orgs","repos_url":"https://api.github.com/users/Araq/repos","events_url":"https://api.github.com/users/Araq/events{/privacy}","received_events_url":"https://api.github.com/users/Araq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Araq/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/Araq/Nim","forks_url":"https://api.github.com/repos/Araq/Nim/forks","keys_url":"https://api.github.com/repos/Araq/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Araq/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Araq/Nim/teams","hooks_url":"https://api.github.com/repos/Araq/Nim/hooks","issue_events_url":"https://api.github.com/repos/Araq/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/Araq/Nim/events","assignees_url":"https://api.github.com/repos/Araq/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/Araq/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/Araq/Nim/tags","blobs_url":"https://api.github.com/repos/Araq/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Araq/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Araq/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Araq/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Araq/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/Araq/Nim/languages","stargazers_url":"https://api.github.com/repos/Araq/Nim/stargazers","contributors_url":"https://api.github.com/repos/Araq/Nim/contributors","subscribers_url":"https://api.github.com/repos/Araq/Nim/subscribers","subscription_url":"https://api.github.com/repos/Araq/Nim/subscription","commits_url":"https://api.github.com/repos/Araq/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Araq/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Araq/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Araq/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Araq/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/Araq/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Araq/Nim/merges","archive_url":"https://api.github.com/repos/Araq/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Araq/Nim/downloads","issues_url":"https://api.github.com/repos/Araq/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/Araq/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/Araq/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/Araq/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Araq/Nim/labels{/name}","releases_url":"https://api.github.com/repos/Araq/Nim/releases{/id}","created_at":"2010-08-16T20:38:58Z","updated_at":"2015-05-17T10:31:25Z","pushed_at":"2015-05-17T10:04:03Z","git_url":"git://github.com/Araq/Nim.git","ssh_url":"git@github.com:Araq/Nim.git","clone_url":"https://github.com/Araq/Nim.git","svn_url":"https://github.com/Araq/Nim","homepage":"http://nim-lang.org/","size":351983,"stargazers_count":1841,"watchers_count":1841,"language":"Nimrod","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":520,"forks":256,"open_issues":520,"watchers":1841,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2740"},"html":{"href":"https://github.com/Araq/Nim/pull/2740"},"issue":{"href":"https://api.github.com/repos/Araq/Nim/issues/2740"},"comments":{"href":"https://api.github.com/repos/Araq/Nim/issues/2740/comments"},"review_comments":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2740/comments"},"review_comment":{"href":"https://api.github.com/repos/Araq/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Araq/Nim/pulls/2740/commits"},"statuses":{"href":"https://api.github.com/repos/Araq/Nim/statuses/3d80fcb8c6ff1e03922f517681efad65d79563fb"}}}}