{"action":"created","issue":{"url":"https://api.github.com/repos/mcallegari/qlcplus/issues/527","labels_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/527/comments","events_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/527/events","html_url":"https://github.com/mcallegari/qlcplus/pull/527","id":104289134,"number":527,"title":"EFX gradient size should be 256x256","user":{"login":"grebecchi","id":11348993,"avatar_url":"https://avatars.githubusercontent.com/u/11348993?v=3","gravatar_id":"","url":"https://api.github.com/users/grebecchi","html_url":"https://github.com/grebecchi","followers_url":"https://api.github.com/users/grebecchi/followers","following_url":"https://api.github.com/users/grebecchi/following{/other_user}","gists_url":"https://api.github.com/users/grebecchi/gists{/gist_id}","starred_url":"https://api.github.com/users/grebecchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grebecchi/subscriptions","organizations_url":"https://api.github.com/users/grebecchi/orgs","repos_url":"https://api.github.com/users/grebecchi/repos","events_url":"https://api.github.com/users/grebecchi/events{/privacy}","received_events_url":"https://api.github.com/users/grebecchi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-01T15:14:35Z","updated_at":"2015-09-02T10:37:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcallegari/qlcplus/pulls/527","html_url":"https://github.com/mcallegari/qlcplus/pull/527","diff_url":"https://github.com/mcallegari/qlcplus/pull/527.diff","patch_url":"https://github.com/mcallegari/qlcplus/pull/527.patch"},"body":"Gradient size should be 255x255 because it is accessed by EFX when RGB mode is used.\r\nAfter my initial commit, gradient x size was changed to 252 to reflect the ClickAndGoWidget size.\r\n\r\nNow I have correct the Gradient and the  ClickAndGoWidget x size to 255."},"comment":{"url":"https://api.github.com/repos/mcallegari/qlcplus/issues/comments/137021410","html_url":"https://github.com/mcallegari/qlcplus/pull/527#issuecomment-137021410","issue_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/527","id":137021410,"user":{"login":"mcallegari","id":2951337,"avatar_url":"https://avatars.githubusercontent.com/u/2951337?v=3","gravatar_id":"","url":"https://api.github.com/users/mcallegari","html_url":"https://github.com/mcallegari","followers_url":"https://api.github.com/users/mcallegari/followers","following_url":"https://api.github.com/users/mcallegari/following{/other_user}","gists_url":"https://api.github.com/users/mcallegari/gists{/gist_id}","starred_url":"https://api.github.com/users/mcallegari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcallegari/subscriptions","organizations_url":"https://api.github.com/users/mcallegari/orgs","repos_url":"https://api.github.com/users/mcallegari/repos","events_url":"https://api.github.com/users/mcallegari/events{/privacy}","received_events_url":"https://api.github.com/users/mcallegari/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T10:37:17Z","updated_at":"2015-09-02T10:37:17Z","body":"I'm afraid this is still not right.\r\nBasically a Gradient is a lookup table when used by the EFX class. If the QImage is 252 pixels wide, you will still have 4 pixels handled not properly.\r\nIf you test your change with a Square EFX in RGB mode, you will notice that the last 4 horizontal pixels will return the same color. Not a big deal, but I guess this is not what we want.\r\n\r\nI think the only way is to rescale the QImage to the needed size, as I suggested.\r\nYou just need to find a proper place in the EFX class to call the rescale method."}}