{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/42931838","id":42931838,"diff_hunk":"@@ -287,6 +287,10 @@ bool CGUIWindowMusicNav::GetDirectory(const std::string &strDirectory, CFileItem\n       OnRetrieveMusicInfo(items);\n   }\n \n+  //Navigating music files so default content to \"songs\" unless in sources folder.\n+  //This content allows view type to include media info so that file tag data can be displayed\n+  if (!URIUtils::IsSourcesPath(strDirectory))","path":"xbmc/music/windows/GUIWindowMusicNav.cpp","position":6,"original_position":6,"commit_id":"1e08c3973b4f316e269c380b13c26162d7cbc161","original_commit_id":"1e08c3973b4f316e269c380b13c26162d7cbc161","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":">Have you ever been to the video files views?\r\nYes, most evenings. But I don't have a video library of scraped info so I don't see what you mention. \r\n\r\nMusic is different in that there is intrinsic data to display, part of the file as much as date or size, not additional data scraped from external sources.\r\n\r\nBut clearly my implementation is faulty and is causing problems. Sorry about that, I will look to fixing it. Suggestions welcome.","created_at":"2015-10-24T08:16:41Z","updated_at":"2015-10-24T08:16:41Z","html_url":"https://github.com/xbmc/xbmc/pull/8205#discussion_r42931838","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8205","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/42931838"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8205#discussion_r42931838"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8205"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8205","id":47372685,"html_url":"https://github.com/xbmc/xbmc/pull/8205","diff_url":"https://github.com/xbmc/xbmc/pull/8205.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8205.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8205","number":8205,"state":"closed","locked":false,"title":"[Fix] Restore music file view display of extracted tag data and sort criteria","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"body":"With changes of #8011 (unifying the music windows) the music file view was broken. The facility to display and sort by the tag data that is intrinsic to music files was inadvertantly lost.\r\n\r\nSee http://forum.kodi.tv/showthread.php?tid=235259&pid=2129282#pid2129282 for screen shots and discussion of this issue.  This change restores this functionality with some minor alterations.\r\n\r\na) Sorting and display of \"Listeners\" has been removed as this data has been deprecated.\r\nb) Sort criteria include various music file tag data e.g. artist, title etc. as well as file name, size etc. that were not previously supported.\r\n\r\n@notspiff thanks for the hints. @jjd_uk hope you are glad to see this back, on behalf of many others. @Montellese, @evilhamster please check over as this is a new area of Kodi for me. @Razzeee I hope this eases your \"funny feeling\" about listeners even if you don't like display of tag data in file view.","created_at":"2015-10-11T18:34:18Z","updated_at":"2015-10-24T08:16:41Z","closed_at":"2015-10-19T10:29:51Z","merged_at":"2015-10-19T10:29:51Z","merge_commit_sha":"28bb25d86a12aa6f6a9da89c55b63f9e54014d8a","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/70","html_url":"https://github.com/xbmc/xbmc/milestones/Jarvis%2016.0-alpha4","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/70/labels","id":1315988,"number":70,"title":"Jarvis 16.0-alpha4","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":108,"state":"open","created_at":"2015-09-21T09:47:25Z","updated_at":"2015-10-23T13:41:33Z","due_on":"2015-10-30T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8205/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8205/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8205/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/1e08c3973b4f316e269c380b13c26162d7cbc161","head":{"label":"DaveTBlake:FileViewSongShowTags","ref":"FileViewSongShowTags","sha":"1e08c3973b4f316e269c380b13c26162d7cbc161","user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"repo":{"id":41623007,"name":"xbmc","full_name":"DaveTBlake/xbmc","owner":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveTBlake/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":true,"url":"https://api.github.com/repos/DaveTBlake/xbmc","forks_url":"https://api.github.com/repos/DaveTBlake/xbmc/forks","keys_url":"https://api.github.com/repos/DaveTBlake/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveTBlake/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveTBlake/xbmc/teams","hooks_url":"https://api.github.com/repos/DaveTBlake/xbmc/hooks","issue_events_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/DaveTBlake/xbmc/events","assignees_url":"https://api.github.com/repos/DaveTBlake/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/DaveTBlake/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/tags","blobs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveTBlake/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveTBlake/xbmc/languages","stargazers_url":"https://api.github.com/repos/DaveTBlake/xbmc/stargazers","contributors_url":"https://api.github.com/repos/DaveTBlake/xbmc/contributors","subscribers_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscribers","subscription_url":"https://api.github.com/repos/DaveTBlake/xbmc/subscription","commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveTBlake/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveTBlake/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveTBlake/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/DaveTBlake/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveTBlake/xbmc/merges","archive_url":"https://api.github.com/repos/DaveTBlake/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveTBlake/xbmc/downloads","issues_url":"https://api.github.com/repos/DaveTBlake/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/DaveTBlake/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveTBlake/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveTBlake/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveTBlake/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/DaveTBlake/xbmc/releases{/id}","created_at":"2015-08-30T09:25:19Z","updated_at":"2015-08-30T09:25:50Z","pushed_at":"2015-10-23T15:26:13Z","git_url":"git://github.com/DaveTBlake/xbmc.git","ssh_url":"git@github.com:DaveTBlake/xbmc.git","clone_url":"https://github.com/DaveTBlake/xbmc.git","svn_url":"https://github.com/DaveTBlake/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":549954,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"a07c856e40eb0fa5c23eabc630fc1a29af8bc06d","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-10-24T01:25:57Z","pushed_at":"2015-10-24T06:55:25Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1903679,"stargazers_count":4201,"watchers_count":4201,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3083,"mirror_url":null,"open_issues_count":187,"forks":3083,"open_issues":187,"watchers":4201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8205"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8205"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8205"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8205/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8205/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8205/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/1e08c3973b4f316e269c380b13c26162d7cbc161"}}}}