{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/30511862","id":30511862,"diff_hunk":"@@ -14,8 +15,8 @@ class Gtkx < Formula\n   depends_on \"jasper\" => :optional\n   depends_on \"atk\"\n   depends_on \"pango\"\n-  depends_on :x11 => [\"2.3.6\", :recommended]\n   depends_on \"gobject-introspection\"\n+  option \"with-quartz-relocation\"","path":"Library/Formula/gtk+.rb","position":14,"original_position":14,"commit_id":"8db3661b2245704fe1900d171e79e0d18dfba7ac","original_commit_id":"8db3661b2245704fe1900d171e79e0d18dfba7ac","user":{"login":"DomT4","id":6998367,"avatar_url":"https://avatars.githubusercontent.com/u/6998367?v=3","gravatar_id":"","url":"https://api.github.com/users/DomT4","html_url":"https://github.com/DomT4","followers_url":"https://api.github.com/users/DomT4/followers","following_url":"https://api.github.com/users/DomT4/following{/other_user}","gists_url":"https://api.github.com/users/DomT4/gists{/gist_id}","starred_url":"https://api.github.com/users/DomT4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DomT4/subscriptions","organizations_url":"https://api.github.com/users/DomT4/orgs","repos_url":"https://api.github.com/users/DomT4/repos","events_url":"https://api.github.com/users/DomT4/events{/privacy}","received_events_url":"https://api.github.com/users/DomT4/received_events","type":"User","site_admin":false},"body":"Let's move the option above the dependencies, with space between the two blocks.","created_at":"2015-05-18T14:28:04Z","updated_at":"2015-05-18T14:28:04Z","html_url":"https://github.com/Homebrew/homebrew/pull/39868#discussion_r30511862","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/30511862"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39868#discussion_r30511862"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868","id":35624573,"html_url":"https://github.com/Homebrew/homebrew/pull/39868","diff_url":"https://github.com/Homebrew/homebrew/pull/39868.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/39868.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39868","number":39868,"state":"open","locked":false,"title":"Gtk+ goes quartz-only","user":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars.githubusercontent.com/u/65736?v=3","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"body":"@mikemcquaid \r\n\r\nThis branch represents an effort to remove the X11 dependency completely from gtk+ and its dependencies cairo and pango.\r\n\r\nThe rationale behind this move is:\r\n\r\n1. It is a major pain for homebrew to support simultaneously the X11 and quartz backends of gtk+. Some formulas require the quartz backend explicitly (like gtk-mac-integration, which for this reason is still not included in homebrew). See also e.g. #38969 for a discussion about this (there are a lot more PRs and issues where this problem was brought up!)\r\n2. In gtk+3, the X11 backend is not even supported anymore\r\n3. X11 is very un-Mac OS X anyway and delivers an inferior user experience (IMHO)\r\n4. Are there any packages that really need the gtk+ X11 backend to work properly anyway?\r\n\r\nMy plan is basically to:\r\n\r\n1. Remove X11 from the dependency list of cairo, pango and gtk+. Modify the configure argument list to ensure that no X11 bindings will get built. Explicitly enable quartz support. Update the revision number of these formulas\r\n2. Update the revision number of all formulas in Homebrew/homebrew that depend on gtk+. This will be the most work since many of these formulas will not be audit --strict compliant (missing tests).\r\n3. Update the revision number of all formulas in all other Homebrew taps that depend on gtk+. Will create separate pull request for each tap which should be pulled in when this PR is merged in.\r\n\r\nIt is possible that some formulas that depend only on cairo and/or pango will also need a revision bump if they depend explicitly on the cairo/pango dylibs that are linked to X11. Not sure how to identify these though.\r\n\r\nTO DO list (will get longer...):\r\n\r\n- [x] cairo\r\n- [ ] pango\r\n- [ ] gtk+\r\n- [ ] cairomm\r\n- [ ] pangomm\r\n- [ ] gtkmm\r\n- [ ] bokken\r\n- [ ] diffuse\r\n- [ ] gabedit\r\n- [ ] gbdfed\r\n- [ ] gdmap\r\n- [ ] gnome-icon-theme\r\n- [ ] goffice\r\n- [ ] gqview\r\n- [ ] grsync\r\n- [ ] gst-python\r\n- [ ] gtk-engines\r\n- [ ] gtk-gnutella\r\n- [ ] gtk-murrine-engine\r\n- [ ] gtk-nodoka-engine\r\n- [ ] gtkdatabox\r\n- [ ] gtkextra\r\n- [ ] gtkglarea\r\n- [ ] gtkglext\r\n- [ ] gtksourceview\r\n- [ ] gwyddion\r\n- [ ] homebank\r\n- [ ] jigdo\r\n- [ ] lablgtk\r\n- [ ] libglade\r\n- [ ] libglademm\r\n- [ ] libgnomecanvas\r\n- [ ] libgnomecanvasmm\r\n- [ ] libinfinity\r\n- [ ] librsvg\r\n- [ ] mdk\r\n- [ ] minbif\r\n- [ ] open-scene-graph\r\n- [ ] pidgin\r\n- [ ] pygtk\r\n- [ ] pygtkglext\r\n- [ ] pygtksourceview\r\n- [ ] qiv\r\n- [ ] synfigstudio\r\n- [ ] vte\r\n- [ ] vte3\r\n- [ ] xplanetfx\r\n- [ ] xsane\r\n\r\n","created_at":"2015-05-18T11:31:19Z","updated_at":"2015-05-18T14:28:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9872975bfc74af8f72f36c8711a6a97ca673cf8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39868/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/8db3661b2245704fe1900d171e79e0d18dfba7ac","head":{"label":"tschoonj:gtk+-goes-quartz-only","ref":"gtk+-goes-quartz-only","sha":"8db3661b2245704fe1900d171e79e0d18dfba7ac","user":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars.githubusercontent.com/u/65736?v=3","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"repo":{"id":29061860,"name":"homebrew","full_name":"tschoonj/homebrew","owner":{"login":"tschoonj","id":65736,"avatar_url":"https://avatars.githubusercontent.com/u/65736?v=3","gravatar_id":"","url":"https://api.github.com/users/tschoonj","html_url":"https://github.com/tschoonj","followers_url":"https://api.github.com/users/tschoonj/followers","following_url":"https://api.github.com/users/tschoonj/following{/other_user}","gists_url":"https://api.github.com/users/tschoonj/gists{/gist_id}","starred_url":"https://api.github.com/users/tschoonj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschoonj/subscriptions","organizations_url":"https://api.github.com/users/tschoonj/orgs","repos_url":"https://api.github.com/users/tschoonj/repos","events_url":"https://api.github.com/users/tschoonj/events{/privacy}","received_events_url":"https://api.github.com/users/tschoonj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschoonj/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/tschoonj/homebrew","forks_url":"https://api.github.com/repos/tschoonj/homebrew/forks","keys_url":"https://api.github.com/repos/tschoonj/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschoonj/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschoonj/homebrew/teams","hooks_url":"https://api.github.com/repos/tschoonj/homebrew/hooks","issue_events_url":"https://api.github.com/repos/tschoonj/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/tschoonj/homebrew/events","assignees_url":"https://api.github.com/repos/tschoonj/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/tschoonj/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/tschoonj/homebrew/tags","blobs_url":"https://api.github.com/repos/tschoonj/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschoonj/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschoonj/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschoonj/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschoonj/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/tschoonj/homebrew/languages","stargazers_url":"https://api.github.com/repos/tschoonj/homebrew/stargazers","contributors_url":"https://api.github.com/repos/tschoonj/homebrew/contributors","subscribers_url":"https://api.github.com/repos/tschoonj/homebrew/subscribers","subscription_url":"https://api.github.com/repos/tschoonj/homebrew/subscription","commits_url":"https://api.github.com/repos/tschoonj/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschoonj/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschoonj/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschoonj/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschoonj/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/tschoonj/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschoonj/homebrew/merges","archive_url":"https://api.github.com/repos/tschoonj/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschoonj/homebrew/downloads","issues_url":"https://api.github.com/repos/tschoonj/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/tschoonj/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/tschoonj/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/tschoonj/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschoonj/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/tschoonj/homebrew/releases{/id}","created_at":"2015-01-10T15:48:19Z","updated_at":"2015-04-23T12:20:11Z","pushed_at":"2015-05-18T13:56:43Z","git_url":"git://github.com/tschoonj/homebrew.git","ssh_url":"git@github.com:tschoonj/homebrew.git","clone_url":"https://github.com/tschoonj/homebrew.git","svn_url":"https://github.com/tschoonj/homebrew","homepage":"http://brew.sh","size":43858,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"4249a206cbb3a40b316760a2207a6a0a1bfbea34","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-05-18T14:03:47Z","pushed_at":"2015-05-18T14:06:36Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1531664,"stargazers_count":22970,"watchers_count":22970,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":11570,"mirror_url":null,"open_issues_count":400,"forks":11570,"open_issues":400,"watchers":22970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39868"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39868"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39868/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39868/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/8db3661b2245704fe1900d171e79e0d18dfba7ac"}}}}