{"action":"closed","number":84,"pull_request":{"url":"https://api.github.com/repos/socrata/cetera/pulls/84","id":49089148,"html_url":"https://github.com/socrata/cetera/pull/84","diff_url":"https://github.com/socrata/cetera/pull/84.diff","patch_url":"https://github.com/socrata/cetera/pull/84.patch","issue_url":"https://api.github.com/repos/socrata/cetera/issues/84","number":84,"state":"closed","locked":false,"title":"consolidate facet service requests, add moar tests","user":{"login":"sokrahta","id":9438863,"avatar_url":"https://avatars.githubusercontent.com/u/9438863?v=3","gravatar_id":"","url":"https://api.github.com/users/sokrahta","html_url":"https://github.com/sokrahta","followers_url":"https://api.github.com/users/sokrahta/followers","following_url":"https://api.github.com/users/sokrahta/following{/other_user}","gists_url":"https://api.github.com/users/sokrahta/gists{/gist_id}","starred_url":"https://api.github.com/users/sokrahta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokrahta/subscriptions","organizations_url":"https://api.github.com/users/sokrahta/orgs","repos_url":"https://api.github.com/users/sokrahta/repos","events_url":"https://api.github.com/users/sokrahta/events{/privacy}","received_events_url":"https://api.github.com/users/sokrahta/received_events","type":"User","site_admin":false},"body":"now raised test coverage to 76%\r\n* exclude jetty and config code\r\n* reformat some test suites to `FunSuiteLike`\r\n* es error if null or empty\r\n* added todos with some future test suggestions\r\n\r\nevictions are now cleaned up\r\n* grouped dependencies\r\n* excluded rojoma from known libraries with transitive dependency\r\n\r\nconsistency\r\n* updated the codacy project settings to suppress some noisy errors\r\n* updated facet/value requests to use arm service trait\r\n* logging all elasticsearch requests in the same method\r\n\r\nfacet key/value requests\r\n* super powerful aggregation\r\n* now `/catalog/domains/<cname>/facets` returns all keys and values with counts\r\n* add datatype facet counts\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/socrata/cetera/84)\r\n<!-- Reviewable:end -->\r\n","created_at":"2015-10-29T01:33:35Z","updated_at":"2015-10-31T15:33:45Z","closed_at":"2015-10-31T15:33:45Z","merged_at":"2015-10-31T15:33:45Z","merge_commit_sha":"65764448c493ca81fd772b19032acc64b76210f8","assignee":{"login":"aynleslie","id":6155686,"avatar_url":"https://avatars.githubusercontent.com/u/6155686?v=3","gravatar_id":"","url":"https://api.github.com/users/aynleslie","html_url":"https://github.com/aynleslie","followers_url":"https://api.github.com/users/aynleslie/followers","following_url":"https://api.github.com/users/aynleslie/following{/other_user}","gists_url":"https://api.github.com/users/aynleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/aynleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aynleslie/subscriptions","organizations_url":"https://api.github.com/users/aynleslie/orgs","repos_url":"https://api.github.com/users/aynleslie/repos","events_url":"https://api.github.com/users/aynleslie/events{/privacy}","received_events_url":"https://api.github.com/users/aynleslie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/socrata/cetera/pulls/84/commits","review_comments_url":"https://api.github.com/repos/socrata/cetera/pulls/84/comments","review_comment_url":"https://api.github.com/repos/socrata/cetera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata/cetera/issues/84/comments","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/26e949db0547f365791dc1c67e4ba60c17b45ffa","head":{"label":"socrata:krah/tests2","ref":"krah/tests2","sha":"26e949db0547f365791dc1c67e4ba60c17b45ffa","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":29320951,"name":"cetera","full_name":"socrata/cetera","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/cetera","description":"Cetera -- the golden-throated search service. Basically a wrapper around elasticsearch to enable keyword search to return dataset metadata for use by the front end in displaying search results.","fork":false,"url":"https://api.github.com/repos/socrata/cetera","forks_url":"https://api.github.com/repos/socrata/cetera/forks","keys_url":"https://api.github.com/repos/socrata/cetera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/cetera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/cetera/teams","hooks_url":"https://api.github.com/repos/socrata/cetera/hooks","issue_events_url":"https://api.github.com/repos/socrata/cetera/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/cetera/events","assignees_url":"https://api.github.com/repos/socrata/cetera/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/cetera/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/cetera/tags","blobs_url":"https://api.github.com/repos/socrata/cetera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/cetera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/cetera/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/cetera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/cetera/languages","stargazers_url":"https://api.github.com/repos/socrata/cetera/stargazers","contributors_url":"https://api.github.com/repos/socrata/cetera/contributors","subscribers_url":"https://api.github.com/repos/socrata/cetera/subscribers","subscription_url":"https://api.github.com/repos/socrata/cetera/subscription","commits_url":"https://api.github.com/repos/socrata/cetera/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/cetera/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/cetera/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/cetera/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/cetera/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/cetera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/cetera/merges","archive_url":"https://api.github.com/repos/socrata/cetera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/cetera/downloads","issues_url":"https://api.github.com/repos/socrata/cetera/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/cetera/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/cetera/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/cetera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/cetera/labels{/name}","releases_url":"https://api.github.com/repos/socrata/cetera/releases{/id}","created_at":"2015-01-15T22:15:58Z","updated_at":"2015-10-21T12:47:47Z","pushed_at":"2015-10-31T15:33:45Z","git_url":"git://github.com/socrata/cetera.git","ssh_url":"git@github.com:socrata/cetera.git","clone_url":"https://github.com/socrata/cetera.git","svn_url":"https://github.com/socrata/cetera","homepage":"","size":1747,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":5,"default_branch":"master"}},"base":{"label":"socrata:master","ref":"master","sha":"9460c5a8856dbcd098a66953b1f39a8dfbe39c5d","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":29320951,"name":"cetera","full_name":"socrata/cetera","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/cetera","description":"Cetera -- the golden-throated search service. Basically a wrapper around elasticsearch to enable keyword search to return dataset metadata for use by the front end in displaying search results.","fork":false,"url":"https://api.github.com/repos/socrata/cetera","forks_url":"https://api.github.com/repos/socrata/cetera/forks","keys_url":"https://api.github.com/repos/socrata/cetera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/cetera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/cetera/teams","hooks_url":"https://api.github.com/repos/socrata/cetera/hooks","issue_events_url":"https://api.github.com/repos/socrata/cetera/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/cetera/events","assignees_url":"https://api.github.com/repos/socrata/cetera/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/cetera/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/cetera/tags","blobs_url":"https://api.github.com/repos/socrata/cetera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/cetera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/cetera/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/cetera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/cetera/languages","stargazers_url":"https://api.github.com/repos/socrata/cetera/stargazers","contributors_url":"https://api.github.com/repos/socrata/cetera/contributors","subscribers_url":"https://api.github.com/repos/socrata/cetera/subscribers","subscription_url":"https://api.github.com/repos/socrata/cetera/subscription","commits_url":"https://api.github.com/repos/socrata/cetera/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/cetera/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/cetera/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/cetera/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/cetera/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/cetera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/cetera/merges","archive_url":"https://api.github.com/repos/socrata/cetera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/cetera/downloads","issues_url":"https://api.github.com/repos/socrata/cetera/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/cetera/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/cetera/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/cetera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/cetera/labels{/name}","releases_url":"https://api.github.com/repos/socrata/cetera/releases{/id}","created_at":"2015-01-15T22:15:58Z","updated_at":"2015-10-21T12:47:47Z","pushed_at":"2015-10-31T15:33:45Z","git_url":"git://github.com/socrata/cetera.git","ssh_url":"git@github.com:socrata/cetera.git","clone_url":"https://github.com/socrata/cetera.git","svn_url":"https://github.com/socrata/cetera","homepage":"","size":1747,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata/cetera/pulls/84"},"html":{"href":"https://github.com/socrata/cetera/pull/84"},"issue":{"href":"https://api.github.com/repos/socrata/cetera/issues/84"},"comments":{"href":"https://api.github.com/repos/socrata/cetera/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata/cetera/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata/cetera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata/cetera/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/socrata/cetera/statuses/26e949db0547f365791dc1c67e4ba60c17b45ffa"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sokrahta","id":9438863,"avatar_url":"https://avatars.githubusercontent.com/u/9438863?v=3","gravatar_id":"","url":"https://api.github.com/users/sokrahta","html_url":"https://github.com/sokrahta","followers_url":"https://api.github.com/users/sokrahta/followers","following_url":"https://api.github.com/users/sokrahta/following{/other_user}","gists_url":"https://api.github.com/users/sokrahta/gists{/gist_id}","starred_url":"https://api.github.com/users/sokrahta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokrahta/subscriptions","organizations_url":"https://api.github.com/users/sokrahta/orgs","repos_url":"https://api.github.com/users/sokrahta/repos","events_url":"https://api.github.com/users/sokrahta/events{/privacy}","received_events_url":"https://api.github.com/users/sokrahta/received_events","type":"User","site_admin":false},"comments":4,"review_comments":12,"commits":8,"additions":384,"deletions":384,"changed_files":23}}