{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2353","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2353/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2353/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2353/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2353","id":53057444,"number":2353,"title":"PolygonGraphics.hierarchy","user":{"login":"mramato","id":1495196,"avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=3","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-12-29T17:47:49Z","updated_at":"2015-01-07T17:11:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/2353","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2353","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2353.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2353.patch"},"body":"This can wait until after 1.6 instead of rushing it into master; I'll probably pull it into the `implicit-properties` branch first; to aid with other efforts.\r\n\r\n* Added `PolygonHierarchy` to Core to make defining polygons with holes clearer.\r\n* `PolygonGraphics.positions` was deprecated and replaced with `PolygonGraphics.hierarchy`, which evaluates to a `PolygonHierarchy` instead of an array of positions.\r\n* `GeoJsonDataSource` now supports polygons with holes.\r\n* `ConstantProperty` can now hold any value; previously it was limited to values that implemented `equals` and `clones` functions, as well as a few special cases.\r\n* CZML does not yet have support for holes and is still creating an array of positions instead of a `PolygonHierarchy`, which is still supported during the deprecation period.  I'm still trying to determine the best way to do holes in CZML (which will most likely be a separate pull request unless anyone has any objections).\r\n* `PolygonGraphics.positions` created by `GeoJSONDataSource` now evaluate to a `PolygonHierarchy` object instead of an array of positions. __This one is technically a breaking change__ I could probably jump through some additional hoops to avoid this if we think it's important; but it's an easy fix for anyone it may affect.\r\n\r\nThe overall goal is to move exclusively to the `hierarchy` property for `PolygonGraphics` and have it always evaluate to a `PolygonHierarchy` object.  This simplifies the API for end users.\r\n\r\n@bagnell Some of the GeoJSON files we test with look worse when using holes.  I think it may be a big on our end; I'll see if I can pull together some examples for you to look at."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/69054885","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/2353#issuecomment-69054885","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/2353","id":69054885,"user":{"login":"mramato","id":1495196,"avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=3","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T17:11:31Z","updated_at":"2015-01-07T17:11:31Z","body":"@pjcozzi can I get a ruling here; I'd like to get this into master because several branches depend on it.  I'll go a long with whatever you want; we have bigger fish to fry.  Just let me know."}}