{"action":"created","issue":{"url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/232","labels_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/232/comments","events_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/232/events","html_url":"https://github.com/simple-mvc-framework/framework/issues/232","id":121786816,"number":232,"title":"Proposed router change","user":{"login":"jimgwhit","id":7936192,"avatar_url":"https://avatars.githubusercontent.com/u/7936192?v=3","gravatar_id":"","url":"https://api.github.com/users/jimgwhit","html_url":"https://github.com/jimgwhit","followers_url":"https://api.github.com/users/jimgwhit/followers","following_url":"https://api.github.com/users/jimgwhit/following{/other_user}","gists_url":"https://api.github.com/users/jimgwhit/gists{/gist_id}","starred_url":"https://api.github.com/users/jimgwhit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimgwhit/subscriptions","organizations_url":"https://api.github.com/users/jimgwhit/orgs","repos_url":"https://api.github.com/users/jimgwhit/repos","events_url":"https://api.github.com/users/jimgwhit/events{/privacy}","received_events_url":"https://api.github.com/users/jimgwhit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-12-11T20:35:20Z","updated_at":"2015-12-12T19:58:07Z","closed_at":null,"body":"@LuckyCyborg in your proposed router if I had this route\r\n```\r\nRouter::any('pet', 'Controllers\\Pet@index');\r\n```\r\nThis URL\r\n```\r\nsite/pet?p=2&search=b&color=black\r\n```\r\nAre you saying that the new way of getting  \r\nthat data in the controller is:\r\n```\r\npublic function index($str = '')\r\n$t1 = Request::get('search');\r\n$mycolor = Request::get('color');\r\n//other code here.\r\n```\r\nAnd the $str='' has to be there for it to work?  You never gave a controller\r\nexample.  I just find it odd that a str='' would need to be there.  It would make more since\r\nto have a way for user to choose friendly url or querystring in a config file.  \r\nThat way if a regular querystring is going to be used the controller method  \r\nwould still start like:\r\n```\r\npublic function index()\r\n```\r\nAnd if friendly url like\r\n```\r\npublic function index($p='', $search='', $color='')\r\n$currpage = $p;  //empty string if empty.\r\n$t1 = $search;\r\n$mycolor = $color;\r\n```\r\nBut I have never seen where you have to have anything in the parenthesis  \r\nif working with the querystring.  And POST data hasn't even been asked yet."},"comment":{"url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/comments/164185567","html_url":"https://github.com/simple-mvc-framework/framework/issues/232#issuecomment-164185567","issue_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/232","id":164185567,"user":{"login":"daveismyname","id":1018170,"avatar_url":"https://avatars.githubusercontent.com/u/1018170?v=3","gravatar_id":"","url":"https://api.github.com/users/daveismyname","html_url":"https://github.com/daveismyname","followers_url":"https://api.github.com/users/daveismyname/followers","following_url":"https://api.github.com/users/daveismyname/following{/other_user}","gists_url":"https://api.github.com/users/daveismyname/gists{/gist_id}","starred_url":"https://api.github.com/users/daveismyname/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveismyname/subscriptions","organizations_url":"https://api.github.com/users/daveismyname/orgs","repos_url":"https://api.github.com/users/daveismyname/repos","events_url":"https://api.github.com/users/daveismyname/events{/privacy}","received_events_url":"https://api.github.com/users/daveismyname/received_events","type":"User","site_admin":false},"created_at":"2015-12-12T19:58:07Z","updated_at":"2015-12-12T19:58:07Z","body":"Yeah can we wait as you've suggested. As we have quite a few different things going on.\nWarmest Regards.\nDAVID CARR\nWeb Developer\nEmail: dave@daveismyname.com (mailto:dave@daveismyname.com)\nwebsite: daveismyname.com (http://daveismyname.com)\nwebsite: phpcodesnippets.com (http://phpcodesnippets.com)\nwebsite: simplemvcframework.com (http://simplemvcframework.com)\nMobile: 07429 561 809\nOn Sat, Dec 12, 2015 at 07:37 PM, jimgwhit  wrote: \n\n\t@daveismyname (https://github.com/daveismyname) a while back I wrote another pager that works with pretty url's, The only problem I have is I can't figure out how to make just one that works with querystring or pretty url's.\n\n After this router thing is resolved, can I send you an attached zip file of what I have, and maybe we can make it work, Just look it over. It's a similar paginator, you just pass the parameters a little different. I am still trying to make it so querystring or pretty will work.\n\n Bear in mind I am new to pretty url's, I don't use them, but started this out of curiosity. \n\n\t—\nReply to this email directly or view it on GitHub (https://github.com/simple-mvc-framework/framework/issues/232#issuecomment-164178111).\n"}}