{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/2049","labels_url":"https://api.github.com/repos/openshift/origin/issues/2049/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2049/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/2049/events","html_url":"https://github.com/openshift/origin/pull/2049","id":73014924,"number":2049,"title":"openshift-diagnostics","user":{"login":"sosiouxme","id":29690,"avatar_url":"https://avatars.githubusercontent.com/u/29690?v=3","gravatar_id":"","url":"https://api.github.com/users/sosiouxme","html_url":"https://github.com/sosiouxme","followers_url":"https://api.github.com/users/sosiouxme/followers","following_url":"https://api.github.com/users/sosiouxme/following{/other_user}","gists_url":"https://api.github.com/users/sosiouxme/gists{/gist_id}","starred_url":"https://api.github.com/users/sosiouxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosiouxme/subscriptions","organizations_url":"https://api.github.com/users/sosiouxme/orgs","repos_url":"https://api.github.com/users/sosiouxme/repos","events_url":"https://api.github.com/users/sosiouxme/events{/privacy}","received_events_url":"https://api.github.com/users/sosiouxme/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-04T13:07:42Z","updated_at":"2015-05-04T17:39:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2049","html_url":"https://github.com/openshift/origin/pull/2049","diff_url":"https://github.com/openshift/origin/pull/2049.diff","patch_url":"https://github.com/openshift/origin/pull/2049.patch"},"body":"I would like some feedback on this, just not sure who to tap. @danmcp @jwhonce PTAL or redirect?\r\n\r\nThis is still mainly framework implementation:\r\nhttps://trello.com/c/LdUogKuN/379-introduce-openshift-v3-diagnostics\r\n\r\nBut will actually detect a few things. (See epic for where it's going - https://trello.com/c/On7sLHVw/342-epic-openshift-v3-diagnostics)\r\n\r\nI'd like to finally get this in front of people so they can use and improve it."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/98791715","html_url":"https://github.com/openshift/origin/pull/2049#issuecomment-98791715","issue_url":"https://api.github.com/repos/openshift/origin/issues/2049","id":98791715,"user":{"login":"sosiouxme","id":29690,"avatar_url":"https://avatars.githubusercontent.com/u/29690?v=3","gravatar_id":"","url":"https://api.github.com/users/sosiouxme","html_url":"https://github.com/sosiouxme","followers_url":"https://api.github.com/users/sosiouxme/followers","following_url":"https://api.github.com/users/sosiouxme/following{/other_user}","gists_url":"https://api.github.com/users/sosiouxme/gists{/gist_id}","starred_url":"https://api.github.com/users/sosiouxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosiouxme/subscriptions","organizations_url":"https://api.github.com/users/sosiouxme/orgs","repos_url":"https://api.github.com/users/sosiouxme/repos","events_url":"https://api.github.com/users/sosiouxme/events{/privacy}","received_events_url":"https://api.github.com/users/sosiouxme/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T17:39:20Z","updated_at":"2015-05-04T17:39:20Z","body":"@jwhonce PTAL or redirect? \r\n\r\nDan suggested that having the large explanation text in the middle of the code makes it a bit unreadable and these could be separated out. I did kind of have in mind doing that at some point, but on the other hand I like having things in context. Dan declined to comment on code quality, deferring to someone more Go-focused.\r\n\r\nComments on that, how idiomatic the code is(n't), or really anything - all welcome. "}}