{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/hhvm/issues/5571","labels_url":"https://api.github.com/repos/facebook/hhvm/issues/5571/labels{/name}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/5571/comments","events_url":"https://api.github.com/repos/facebook/hhvm/issues/5571/events","html_url":"https://github.com/facebook/hhvm/pull/5571","id":92561053,"number":5571,"title":"Made most of the extensions optional.","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/hhvm/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":24,"created_at":"2015-07-02T06:38:57Z","updated_at":"2015-07-23T17:20:14Z","closed_at":"2015-07-15T20:36:19Z","pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/5571","html_url":"https://github.com/facebook/hhvm/pull/5571","diff_url":"https://github.com/facebook/hhvm/pull/5571.diff","patch_url":"https://github.com/facebook/hhvm/pull/5571.patch"},"body":"This very likely breaks FB's internal build due to the relocation of the .idl.json files for most of the extensions. Additional defines for the enabled extensions also need to be added.\r\nThis adds configs for all but the gd and imap extensions, allowing most of them (the ones not explicitly marked as REQUIRED) to be disabled via the ENABLE_EXTENSION_* variables.\r\nThis also adds configs for the extensions that were originally in the root directory.\r\n\r\nThis supersedes PR #5413. \r\n\r\nIt is possible that I've missed some in this list, but the additional defines needed by a non-cmake build system in order to compile correctly are:\r\n```\r\nENABLE_EXTENSION_ASIO\r\nENABLE_EXTENSION_CLOSURE\r\nENABLE_EXTENSION_COLLECTIONS\r\nENABLE_EXTENSION_GENERATOR\r\nENABLE_EXTENSION_FB\r\nENABLE_EXTENSION_PDO_MYSQL\r\nENABLE_EXTENSION_PDO_SQLITE\r\nENABLE_EXTENSION_SIMPLEXML\r\nENABLE_EXTENSION_XDEBUG\r\n```\r\n\r\nAnd let's see if this is enough for Phabricator to play nice with the description now..."},"comment":{"url":"https://api.github.com/repos/facebook/hhvm/issues/comments/124171664","html_url":"https://github.com/facebook/hhvm/pull/5571#issuecomment-124171664","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/5571","id":124171664,"user":{"login":"jwatzman","id":575697,"avatar_url":"https://avatars.githubusercontent.com/u/575697?v=3","gravatar_id":"","url":"https://api.github.com/users/jwatzman","html_url":"https://github.com/jwatzman","followers_url":"https://api.github.com/users/jwatzman/followers","following_url":"https://api.github.com/users/jwatzman/following{/other_user}","gists_url":"https://api.github.com/users/jwatzman/gists{/gist_id}","starred_url":"https://api.github.com/users/jwatzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwatzman/subscriptions","organizations_url":"https://api.github.com/users/jwatzman/orgs","repos_url":"https://api.github.com/users/jwatzman/repos","events_url":"https://api.github.com/users/jwatzman/events{/privacy}","received_events_url":"https://api.github.com/users/jwatzman/received_events","type":"User","site_admin":false},"created_at":"2015-07-23T17:20:14Z","updated_at":"2015-07-23T17:20:14Z","body":"Can we just kill the `ENABLE_ASYNC_MYSQL`, `ENABLE_MCROUTER`, etc options, and use `ENABLE_EXTENSION_MCROUTER` etc instead?"}}