{"action":"created","issue":{"url":"https://api.github.com/repos/fisharebest/webtrees/issues/465","labels_url":"https://api.github.com/repos/fisharebest/webtrees/issues/465/labels{/name}","comments_url":"https://api.github.com/repos/fisharebest/webtrees/issues/465/comments","events_url":"https://api.github.com/repos/fisharebest/webtrees/issues/465/events","html_url":"https://github.com/fisharebest/webtrees/pull/465","id":60200557,"number":465,"title":"Further pedigree chart work","user":{"login":"ddrury","id":104515,"avatar_url":"https://avatars.githubusercontent.com/u/104515?v=3","gravatar_id":"","url":"https://api.github.com/users/ddrury","html_url":"https://github.com/ddrury","followers_url":"https://api.github.com/users/ddrury/followers","following_url":"https://api.github.com/users/ddrury/following{/other_user}","gists_url":"https://api.github.com/users/ddrury/gists{/gist_id}","starred_url":"https://api.github.com/users/ddrury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddrury/subscriptions","organizations_url":"https://api.github.com/users/ddrury/orgs","repos_url":"https://api.github.com/users/ddrury/repos","events_url":"https://api.github.com/users/ddrury/events{/privacy}","received_events_url":"https://api.github.com/users/ddrury/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-07T10:17:54Z","updated_at":"2015-03-08T09:59:20Z","closed_at":"2015-03-07T19:23:12Z","pull_request":{"url":"https://api.github.com/repos/fisharebest/webtrees/pulls/465","html_url":"https://github.com/fisharebest/webtrees/pull/465","diff_url":"https://github.com/fisharebest/webtrees/pull/465.diff","patch_url":"https://github.com/fisharebest/webtrees/pull/465.patch"},"body":"Moved all positioning logic into the controller. Now the only elements that are absolutely positioned are the node containers. Simplified the line drawing logic in javascript by using sosa triples (ie child + parents)  and using the node location as the base for calculating the point positions.\r\n\r\nThis has no impact on Meliza's requirements"},"comment":{"url":"https://api.github.com/repos/fisharebest/webtrees/issues/comments/77741598","html_url":"https://github.com/fisharebest/webtrees/pull/465#issuecomment-77741598","issue_url":"https://api.github.com/repos/fisharebest/webtrees/issues/465","id":77741598,"user":{"login":"ddrury","id":104515,"avatar_url":"https://avatars.githubusercontent.com/u/104515?v=3","gravatar_id":"","url":"https://api.github.com/users/ddrury","html_url":"https://github.com/ddrury","followers_url":"https://api.github.com/users/ddrury/followers","following_url":"https://api.github.com/users/ddrury/following{/other_user}","gists_url":"https://api.github.com/users/ddrury/gists{/gist_id}","starred_url":"https://api.github.com/users/ddrury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddrury/subscriptions","organizations_url":"https://api.github.com/users/ddrury/orgs","repos_url":"https://api.github.com/users/ddrury/repos","events_url":"https://api.github.com/users/ddrury/events{/privacy}","received_events_url":"https://api.github.com/users/ddrury/received_events","type":"User","site_admin":false},"created_at":"2015-03-08T09:59:20Z","updated_at":"2015-03-08T09:59:20Z","body":"Re you queries below\n\n1. I wanted too but thought as they generated output they shouldn't go \nin the controller (I'll get the hang of this MVC stuff one day).\n\n2. I think this was one of my changes but not recently - The original \nintention was to have it as an instantiated object with parameters \npassed into it, but it never worked out like that.\n\nI'll make the changes and push then up.\n\n\nRegards\nDavid\n\nPlease consider the environment before printing this e-mail\n\n\n\n------ Original Message ------\nFrom: \"Greg Roach\" <notifications@github.com>\nTo: \"fisharebest/webtrees\" <webtrees@noreply.github.com>\nCc: \"David Drury\" <david@drury.me.uk>\nSent: 07/03/2015 07:23:17\nSubject: Re: [webtrees] Further pedigree chart work (#465)\n\n>1) Instead of creating new global functions get_menu() and \n>gotoPreviousGen(), would these be better as functions within the \n>controller?\n>\n>2) Do we need to create the global JS variable WT_PEDIGREE_CHART. Can \n>we use just (function() {...})();\n>\n>—\n>Reply to this email directly or view it on GitHub.\n>"}}