{"action":"created","comment":{"url":"https://api.github.com/repos/ternjs/acorn/pulls/comments/43302335","id":43302335,"diff_hunk":"@@ -648,8 +648,9 @@ pp.parseIdent = function(liberal) {\n   let node = this.startNode()\n   if (liberal && this.options.allowReserved == \"never\") liberal = false\n   if (this.type === tt.name) {\n-    if (!liberal &&\n-        (this.strict ? this.reservedWordsStrict : this.reservedWords).test(this.value) &&\n+    let reservedWords = this.options.sourceType === \"module\" ? this.reservedWordsES6Module :","path":"src/expression.js","position":6,"original_position":6,"commit_id":"ecc9f21a487a6465d0a1fc57d8adb4ef261b5435","original_commit_id":"ecc9f21a487a6465d0a1fc57d8adb4ef261b5435","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"body":"Oh, there actually is already an `inModule` property. I'll just use that.","created_at":"2015-10-28T19:00:49Z","updated_at":"2015-10-28T19:00:49Z","html_url":"https://github.com/ternjs/acorn/pull/344#discussion_r43302335","pull_request_url":"https://api.github.com/repos/ternjs/acorn/pulls/344","_links":{"self":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/comments/43302335"},"html":{"href":"https://github.com/ternjs/acorn/pull/344#discussion_r43302335"},"pull_request":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/344"}}},"pull_request":{"url":"https://api.github.com/repos/ternjs/acorn/pulls/344","id":49045194,"html_url":"https://github.com/ternjs/acorn/pull/344","diff_url":"https://github.com/ternjs/acorn/pull/344.diff","patch_url":"https://github.com/ternjs/acorn/pull/344.patch","issue_url":"https://api.github.com/repos/ternjs/acorn/issues/344","number":344,"state":"open","locked":false,"title":"Add await as module reserved word","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"body":"This is a little bit hacky, so let me know if you'd prefer something else.\r\n\r\n`await` is only a reserved word in modules *right now*, but if async functions are implemented for ES7, `await` would be a keyword in that context. So really, this restriction applies to modules running in ES6 mode or any other ES version that hasn't yet implemented async functions. In the future, that will mean checking for ES versions in addition to whether or not it's a module.\r\n\r\nAs a result, I'm calling the properties `strictModeES6Module` and `es6Module` in anticipation of async functions being added to ES7.\r\n\r\nFixes #326 \r\n","created_at":"2015-10-28T18:10:10Z","updated_at":"2015-10-28T19:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f68f8f488df711fbe6dc7bfd1ef03e53b2e8c89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ternjs/acorn/pulls/344/commits","review_comments_url":"https://api.github.com/repos/ternjs/acorn/pulls/344/comments","review_comment_url":"https://api.github.com/repos/ternjs/acorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ternjs/acorn/issues/344/comments","statuses_url":"https://api.github.com/repos/ternjs/acorn/statuses/ecc9f21a487a6465d0a1fc57d8adb4ef261b5435","head":{"label":"nzakas:moduleawait","ref":"moduleawait","sha":"ecc9f21a487a6465d0a1fc57d8adb4ef261b5435","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"repo":{"id":43911627,"name":"acorn","full_name":"nzakas/acorn","owner":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nzakas/acorn","description":"A small, fast, JavaScript-based JavaScript parser","fork":true,"url":"https://api.github.com/repos/nzakas/acorn","forks_url":"https://api.github.com/repos/nzakas/acorn/forks","keys_url":"https://api.github.com/repos/nzakas/acorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nzakas/acorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nzakas/acorn/teams","hooks_url":"https://api.github.com/repos/nzakas/acorn/hooks","issue_events_url":"https://api.github.com/repos/nzakas/acorn/issues/events{/number}","events_url":"https://api.github.com/repos/nzakas/acorn/events","assignees_url":"https://api.github.com/repos/nzakas/acorn/assignees{/user}","branches_url":"https://api.github.com/repos/nzakas/acorn/branches{/branch}","tags_url":"https://api.github.com/repos/nzakas/acorn/tags","blobs_url":"https://api.github.com/repos/nzakas/acorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nzakas/acorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nzakas/acorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nzakas/acorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nzakas/acorn/statuses/{sha}","languages_url":"https://api.github.com/repos/nzakas/acorn/languages","stargazers_url":"https://api.github.com/repos/nzakas/acorn/stargazers","contributors_url":"https://api.github.com/repos/nzakas/acorn/contributors","subscribers_url":"https://api.github.com/repos/nzakas/acorn/subscribers","subscription_url":"https://api.github.com/repos/nzakas/acorn/subscription","commits_url":"https://api.github.com/repos/nzakas/acorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nzakas/acorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nzakas/acorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nzakas/acorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nzakas/acorn/contents/{+path}","compare_url":"https://api.github.com/repos/nzakas/acorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nzakas/acorn/merges","archive_url":"https://api.github.com/repos/nzakas/acorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nzakas/acorn/downloads","issues_url":"https://api.github.com/repos/nzakas/acorn/issues{/number}","pulls_url":"https://api.github.com/repos/nzakas/acorn/pulls{/number}","milestones_url":"https://api.github.com/repos/nzakas/acorn/milestones{/number}","notifications_url":"https://api.github.com/repos/nzakas/acorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nzakas/acorn/labels{/name}","releases_url":"https://api.github.com/repos/nzakas/acorn/releases{/id}","created_at":"2015-10-08T19:27:59Z","updated_at":"2015-10-09T02:21:40Z","pushed_at":"2015-10-28T18:06:56Z","git_url":"git://github.com/nzakas/acorn.git","ssh_url":"git@github.com:nzakas/acorn.git","clone_url":"https://github.com/nzakas/acorn.git","svn_url":"https://github.com/nzakas/acorn","homepage":"","size":3197,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ternjs:master","ref":"master","sha":"4ae39e1524f556f2563ea080057539f70f766e32","user":{"login":"ternjs","id":8876849,"avatar_url":"https://avatars.githubusercontent.com/u/8876849?v=3","gravatar_id":"","url":"https://api.github.com/users/ternjs","html_url":"https://github.com/ternjs","followers_url":"https://api.github.com/users/ternjs/followers","following_url":"https://api.github.com/users/ternjs/following{/other_user}","gists_url":"https://api.github.com/users/ternjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ternjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ternjs/subscriptions","organizations_url":"https://api.github.com/users/ternjs/orgs","repos_url":"https://api.github.com/users/ternjs/repos","events_url":"https://api.github.com/users/ternjs/events{/privacy}","received_events_url":"https://api.github.com/users/ternjs/received_events","type":"Organization","site_admin":false},"repo":{"id":5932749,"name":"acorn","full_name":"ternjs/acorn","owner":{"login":"ternjs","id":8876849,"avatar_url":"https://avatars.githubusercontent.com/u/8876849?v=3","gravatar_id":"","url":"https://api.github.com/users/ternjs","html_url":"https://github.com/ternjs","followers_url":"https://api.github.com/users/ternjs/followers","following_url":"https://api.github.com/users/ternjs/following{/other_user}","gists_url":"https://api.github.com/users/ternjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ternjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ternjs/subscriptions","organizations_url":"https://api.github.com/users/ternjs/orgs","repos_url":"https://api.github.com/users/ternjs/repos","events_url":"https://api.github.com/users/ternjs/events{/privacy}","received_events_url":"https://api.github.com/users/ternjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ternjs/acorn","description":"A small, fast, JavaScript-based JavaScript parser","fork":false,"url":"https://api.github.com/repos/ternjs/acorn","forks_url":"https://api.github.com/repos/ternjs/acorn/forks","keys_url":"https://api.github.com/repos/ternjs/acorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ternjs/acorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ternjs/acorn/teams","hooks_url":"https://api.github.com/repos/ternjs/acorn/hooks","issue_events_url":"https://api.github.com/repos/ternjs/acorn/issues/events{/number}","events_url":"https://api.github.com/repos/ternjs/acorn/events","assignees_url":"https://api.github.com/repos/ternjs/acorn/assignees{/user}","branches_url":"https://api.github.com/repos/ternjs/acorn/branches{/branch}","tags_url":"https://api.github.com/repos/ternjs/acorn/tags","blobs_url":"https://api.github.com/repos/ternjs/acorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ternjs/acorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ternjs/acorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ternjs/acorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ternjs/acorn/statuses/{sha}","languages_url":"https://api.github.com/repos/ternjs/acorn/languages","stargazers_url":"https://api.github.com/repos/ternjs/acorn/stargazers","contributors_url":"https://api.github.com/repos/ternjs/acorn/contributors","subscribers_url":"https://api.github.com/repos/ternjs/acorn/subscribers","subscription_url":"https://api.github.com/repos/ternjs/acorn/subscription","commits_url":"https://api.github.com/repos/ternjs/acorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ternjs/acorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ternjs/acorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ternjs/acorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ternjs/acorn/contents/{+path}","compare_url":"https://api.github.com/repos/ternjs/acorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ternjs/acorn/merges","archive_url":"https://api.github.com/repos/ternjs/acorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ternjs/acorn/downloads","issues_url":"https://api.github.com/repos/ternjs/acorn/issues{/number}","pulls_url":"https://api.github.com/repos/ternjs/acorn/pulls{/number}","milestones_url":"https://api.github.com/repos/ternjs/acorn/milestones{/number}","notifications_url":"https://api.github.com/repos/ternjs/acorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ternjs/acorn/labels{/name}","releases_url":"https://api.github.com/repos/ternjs/acorn/releases{/id}","created_at":"2012-09-24T10:05:00Z","updated_at":"2015-10-28T18:03:17Z","pushed_at":"2015-10-28T18:10:10Z","git_url":"git://github.com/ternjs/acorn.git","ssh_url":"git@github.com:ternjs/acorn.git","clone_url":"https://github.com/ternjs/acorn.git","svn_url":"https://github.com/ternjs/acorn","homepage":"","size":5536,"stargazers_count":1248,"watchers_count":1248,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":12,"forks":161,"open_issues":12,"watchers":1248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/344"},"html":{"href":"https://github.com/ternjs/acorn/pull/344"},"issue":{"href":"https://api.github.com/repos/ternjs/acorn/issues/344"},"comments":{"href":"https://api.github.com/repos/ternjs/acorn/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ternjs/acorn/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/ternjs/acorn/statuses/ecc9f21a487a6465d0a1fc57d8adb4ef261b5435"}}}}