{"action":"opened","number":672,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672","id":41977435,"html_url":"https://github.com/letsencrypt/letsencrypt/pull/672","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/672.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/672.patch","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/672","number":672,"state":"open","locked":false,"title":"Minor enhancements (fix typo in docs, remove unneeded code for better cov)","user":{"login":"frennkie","id":6499251,"avatar_url":"https://avatars.githubusercontent.com/u/6499251?v=3","gravatar_id":"","url":"https://api.github.com/users/frennkie","html_url":"https://github.com/frennkie","followers_url":"https://api.github.com/users/frennkie/followers","following_url":"https://api.github.com/users/frennkie/following{/other_user}","gists_url":"https://api.github.com/users/frennkie/gists{/gist_id}","starred_url":"https://api.github.com/users/frennkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frennkie/subscriptions","organizations_url":"https://api.github.com/users/frennkie/orgs","repos_url":"https://api.github.com/users/frennkie/repos","events_url":"https://api.github.com/users/frennkie/events{/privacy}","received_events_url":"https://api.github.com/users/frennkie/received_events","type":"User","site_admin":false},"body":"I think this project is really important and started looking into the code trying to find places where I can help in this effort. I found:\r\n- a typo in the docs (tox.cover.sh) and \r\n- an if clause that will never be true and because of that the following line is and can not be tested. Removing the two lines improves the coverage for the letsencrypt-nginx tests to 97%.","created_at":"2015-08-09T21:30:51Z","updated_at":"2015-08-09T21:30:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/672/comments","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/6a1cf1b754d7d55706d20f53baba87aca085ab6e","head":{"label":"frennkie:master","ref":"master","sha":"6a1cf1b754d7d55706d20f53baba87aca085ab6e","user":{"login":"frennkie","id":6499251,"avatar_url":"https://avatars.githubusercontent.com/u/6499251?v=3","gravatar_id":"","url":"https://api.github.com/users/frennkie","html_url":"https://github.com/frennkie","followers_url":"https://api.github.com/users/frennkie/followers","following_url":"https://api.github.com/users/frennkie/following{/other_user}","gists_url":"https://api.github.com/users/frennkie/gists{/gist_id}","starred_url":"https://api.github.com/users/frennkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frennkie/subscriptions","organizations_url":"https://api.github.com/users/frennkie/orgs","repos_url":"https://api.github.com/users/frennkie/repos","events_url":"https://api.github.com/users/frennkie/events{/privacy}","received_events_url":"https://api.github.com/users/frennkie/received_events","type":"User","site_admin":false},"repo":{"id":40076912,"name":"letsencrypt","full_name":"frennkie/letsencrypt","owner":{"login":"frennkie","id":6499251,"avatar_url":"https://avatars.githubusercontent.com/u/6499251?v=3","gravatar_id":"","url":"https://api.github.com/users/frennkie","html_url":"https://github.com/frennkie","followers_url":"https://api.github.com/users/frennkie/followers","following_url":"https://api.github.com/users/frennkie/following{/other_user}","gists_url":"https://api.github.com/users/frennkie/gists{/gist_id}","starred_url":"https://api.github.com/users/frennkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frennkie/subscriptions","organizations_url":"https://api.github.com/users/frennkie/orgs","repos_url":"https://api.github.com/users/frennkie/repos","events_url":"https://api.github.com/users/frennkie/events{/privacy}","received_events_url":"https://api.github.com/users/frennkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frennkie/letsencrypt","description":"An ACME client that can update Apache/Nginx configurations","fork":true,"url":"https://api.github.com/repos/frennkie/letsencrypt","forks_url":"https://api.github.com/repos/frennkie/letsencrypt/forks","keys_url":"https://api.github.com/repos/frennkie/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frennkie/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frennkie/letsencrypt/teams","hooks_url":"https://api.github.com/repos/frennkie/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/frennkie/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/frennkie/letsencrypt/events","assignees_url":"https://api.github.com/repos/frennkie/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/frennkie/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/frennkie/letsencrypt/tags","blobs_url":"https://api.github.com/repos/frennkie/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frennkie/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frennkie/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/frennkie/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frennkie/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/frennkie/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/frennkie/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/frennkie/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/frennkie/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/frennkie/letsencrypt/subscription","commits_url":"https://api.github.com/repos/frennkie/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/frennkie/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/frennkie/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/frennkie/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/frennkie/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/frennkie/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frennkie/letsencrypt/merges","archive_url":"https://api.github.com/repos/frennkie/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frennkie/letsencrypt/downloads","issues_url":"https://api.github.com/repos/frennkie/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/frennkie/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/frennkie/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/frennkie/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frennkie/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/frennkie/letsencrypt/releases{/id}","created_at":"2015-08-02T11:06:39Z","updated_at":"2015-08-02T11:06:40Z","pushed_at":"2015-08-09T09:11:30Z","git_url":"git://github.com/frennkie/letsencrypt.git","ssh_url":"git@github.com:frennkie/letsencrypt.git","clone_url":"https://github.com/frennkie/letsencrypt.git","svn_url":"https://github.com/frennkie/letsencrypt","homepage":"","size":4467,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"74b677248d082c35489ed96a806e50bd648627e1","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"An ACME client that can update Apache/Nginx configurations","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-08-09T21:08:41Z","pushed_at":"2015-08-08T20:20:49Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":8896,"stargazers_count":2923,"watchers_count":2923,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":135,"forks":213,"open_issues":135,"watchers":2923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/672"},"issue":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/672"},"comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/6a1cf1b754d7d55706d20f53baba87aca085ab6e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1,"deletions":4,"changed_files":2}}