{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/comments/24753272","id":24753272,"diff_hunk":"@@ -0,0 +1,14 @@\n+# Pulp Admin Configuration\n+class pulp::admin::config {\n+  file { '/etc/pulp/admin/admin.conf':\n+    ensure  => 'file',\n+    content => template('pulp/admin.conf.erb'),\n+  }\n+\n+  if $pulp::admin::puppet {","path":"manifests/admin/config.pp","position":8,"original_position":8,"commit_id":"20548b5c2b95466c8afb317240824d62fe613107","original_commit_id":"20548b5c2b95466c8afb317240824d62fe613107","user":{"login":"cristi1979","id":3647635,"avatar_url":"https://avatars.githubusercontent.com/u/3647635?v=3","gravatar_id":"","url":"https://api.github.com/users/cristi1979","html_url":"https://github.com/cristi1979","followers_url":"https://api.github.com/users/cristi1979/followers","following_url":"https://api.github.com/users/cristi1979/following{/other_user}","gists_url":"https://api.github.com/users/cristi1979/gists{/gist_id}","starred_url":"https://api.github.com/users/cristi1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristi1979/subscriptions","organizations_url":"https://api.github.com/users/cristi1979/orgs","repos_url":"https://api.github.com/users/cristi1979/repos","events_url":"https://api.github.com/users/cristi1979/events{/privacy}","received_events_url":"https://api.github.com/users/cristi1979/received_events","type":"User","site_admin":false},"body":"Should I check based on $version = absent/purged and remove the files in this case? From my point of view the file should remain on the system even if the package is uninstalled.","created_at":"2015-02-16T14:28:05Z","updated_at":"2015-02-16T14:28:05Z","html_url":"https://github.com/Katello/puppet-pulp/pull/33#discussion_r24753272","pull_request_url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/comments/24753272"},"html":{"href":"https://github.com/Katello/puppet-pulp/pull/33#discussion_r24753272"},"pull_request":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33","id":28504534,"html_url":"https://github.com/Katello/puppet-pulp/pull/33","diff_url":"https://github.com/Katello/puppet-pulp/pull/33.diff","patch_url":"https://github.com/Katello/puppet-pulp/pull/33.patch","issue_url":"https://api.github.com/repos/Katello/puppet-pulp/issues/33","number":33,"state":"open","locked":false,"title":"add initial admin support","user":{"login":"cristi1979","id":3647635,"avatar_url":"https://avatars.githubusercontent.com/u/3647635?v=3","gravatar_id":"","url":"https://api.github.com/users/cristi1979","html_url":"https://github.com/cristi1979","followers_url":"https://api.github.com/users/cristi1979/followers","following_url":"https://api.github.com/users/cristi1979/following{/other_user}","gists_url":"https://api.github.com/users/cristi1979/gists{/gist_id}","starred_url":"https://api.github.com/users/cristi1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristi1979/subscriptions","organizations_url":"https://api.github.com/users/cristi1979/orgs","repos_url":"https://api.github.com/users/cristi1979/repos","events_url":"https://api.github.com/users/cristi1979/events{/privacy}","received_events_url":"https://api.github.com/users/cristi1979/received_events","type":"User","site_admin":false},"body":"add initial admin support","created_at":"2015-02-02T21:32:07Z","updated_at":"2015-02-16T14:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea01c7ee93bf9ea33fc22754304cb817e154d527","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Katello/puppet-pulp/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Katello/puppet-pulp/issues/33/comments","statuses_url":"https://api.github.com/repos/Katello/puppet-pulp/statuses/20548b5c2b95466c8afb317240824d62fe613107","head":{"label":"cristi1979:master","ref":"master","sha":"20548b5c2b95466c8afb317240824d62fe613107","user":{"login":"cristi1979","id":3647635,"avatar_url":"https://avatars.githubusercontent.com/u/3647635?v=3","gravatar_id":"","url":"https://api.github.com/users/cristi1979","html_url":"https://github.com/cristi1979","followers_url":"https://api.github.com/users/cristi1979/followers","following_url":"https://api.github.com/users/cristi1979/following{/other_user}","gists_url":"https://api.github.com/users/cristi1979/gists{/gist_id}","starred_url":"https://api.github.com/users/cristi1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristi1979/subscriptions","organizations_url":"https://api.github.com/users/cristi1979/orgs","repos_url":"https://api.github.com/users/cristi1979/repos","events_url":"https://api.github.com/users/cristi1979/events{/privacy}","received_events_url":"https://api.github.com/users/cristi1979/received_events","type":"User","site_admin":false},"repo":{"id":30209616,"name":"puppet-pulp","full_name":"cristi1979/puppet-pulp","owner":{"login":"cristi1979","id":3647635,"avatar_url":"https://avatars.githubusercontent.com/u/3647635?v=3","gravatar_id":"","url":"https://api.github.com/users/cristi1979","html_url":"https://github.com/cristi1979","followers_url":"https://api.github.com/users/cristi1979/followers","following_url":"https://api.github.com/users/cristi1979/following{/other_user}","gists_url":"https://api.github.com/users/cristi1979/gists{/gist_id}","starred_url":"https://api.github.com/users/cristi1979/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristi1979/subscriptions","organizations_url":"https://api.github.com/users/cristi1979/orgs","repos_url":"https://api.github.com/users/cristi1979/repos","events_url":"https://api.github.com/users/cristi1979/events{/privacy}","received_events_url":"https://api.github.com/users/cristi1979/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristi1979/puppet-pulp","description":"Puppet module for setting Pulp as part of Katello installation","fork":true,"url":"https://api.github.com/repos/cristi1979/puppet-pulp","forks_url":"https://api.github.com/repos/cristi1979/puppet-pulp/forks","keys_url":"https://api.github.com/repos/cristi1979/puppet-pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristi1979/puppet-pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristi1979/puppet-pulp/teams","hooks_url":"https://api.github.com/repos/cristi1979/puppet-pulp/hooks","issue_events_url":"https://api.github.com/repos/cristi1979/puppet-pulp/issues/events{/number}","events_url":"https://api.github.com/repos/cristi1979/puppet-pulp/events","assignees_url":"https://api.github.com/repos/cristi1979/puppet-pulp/assignees{/user}","branches_url":"https://api.github.com/repos/cristi1979/puppet-pulp/branches{/branch}","tags_url":"https://api.github.com/repos/cristi1979/puppet-pulp/tags","blobs_url":"https://api.github.com/repos/cristi1979/puppet-pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristi1979/puppet-pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristi1979/puppet-pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristi1979/puppet-pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristi1979/puppet-pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/cristi1979/puppet-pulp/languages","stargazers_url":"https://api.github.com/repos/cristi1979/puppet-pulp/stargazers","contributors_url":"https://api.github.com/repos/cristi1979/puppet-pulp/contributors","subscribers_url":"https://api.github.com/repos/cristi1979/puppet-pulp/subscribers","subscription_url":"https://api.github.com/repos/cristi1979/puppet-pulp/subscription","commits_url":"https://api.github.com/repos/cristi1979/puppet-pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristi1979/puppet-pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristi1979/puppet-pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristi1979/puppet-pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/cristi1979/puppet-pulp/contents/{+path}","compare_url":"https://api.github.com/repos/cristi1979/puppet-pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristi1979/puppet-pulp/merges","archive_url":"https://api.github.com/repos/cristi1979/puppet-pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristi1979/puppet-pulp/downloads","issues_url":"https://api.github.com/repos/cristi1979/puppet-pulp/issues{/number}","pulls_url":"https://api.github.com/repos/cristi1979/puppet-pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/cristi1979/puppet-pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/cristi1979/puppet-pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristi1979/puppet-pulp/labels{/name}","releases_url":"https://api.github.com/repos/cristi1979/puppet-pulp/releases{/id}","created_at":"2015-02-02T21:29:12Z","updated_at":"2015-02-16T13:50:33Z","pushed_at":"2015-02-16T13:50:33Z","git_url":"git://github.com/cristi1979/puppet-pulp.git","ssh_url":"git@github.com:cristi1979/puppet-pulp.git","clone_url":"https://github.com/cristi1979/puppet-pulp.git","svn_url":"https://github.com/cristi1979/puppet-pulp","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"d9f53d1c7be53beb12a211505d2ae3b89f5a5d4f","user":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":13798704,"name":"puppet-pulp","full_name":"Katello/puppet-pulp","owner":{"login":"Katello","id":1316386,"avatar_url":"https://avatars.githubusercontent.com/u/1316386?v=3","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/puppet-pulp","description":"Puppet module for setting Pulp as part of Katello installation","fork":false,"url":"https://api.github.com/repos/Katello/puppet-pulp","forks_url":"https://api.github.com/repos/Katello/puppet-pulp/forks","keys_url":"https://api.github.com/repos/Katello/puppet-pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/puppet-pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/puppet-pulp/teams","hooks_url":"https://api.github.com/repos/Katello/puppet-pulp/hooks","issue_events_url":"https://api.github.com/repos/Katello/puppet-pulp/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/puppet-pulp/events","assignees_url":"https://api.github.com/repos/Katello/puppet-pulp/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/puppet-pulp/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/puppet-pulp/tags","blobs_url":"https://api.github.com/repos/Katello/puppet-pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/puppet-pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/puppet-pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/puppet-pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/puppet-pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/puppet-pulp/languages","stargazers_url":"https://api.github.com/repos/Katello/puppet-pulp/stargazers","contributors_url":"https://api.github.com/repos/Katello/puppet-pulp/contributors","subscribers_url":"https://api.github.com/repos/Katello/puppet-pulp/subscribers","subscription_url":"https://api.github.com/repos/Katello/puppet-pulp/subscription","commits_url":"https://api.github.com/repos/Katello/puppet-pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/puppet-pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/puppet-pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/puppet-pulp/issues/comments/{number}","contents_url":"https://api.github.com/repos/Katello/puppet-pulp/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/puppet-pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/puppet-pulp/merges","archive_url":"https://api.github.com/repos/Katello/puppet-pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/puppet-pulp/downloads","issues_url":"https://api.github.com/repos/Katello/puppet-pulp/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/puppet-pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/puppet-pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/puppet-pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/puppet-pulp/labels{/name}","releases_url":"https://api.github.com/repos/Katello/puppet-pulp/releases{/id}","created_at":"2013-10-23T09:27:56Z","updated_at":"2015-02-09T13:11:34Z","pushed_at":"2015-02-09T13:11:34Z","git_url":"git://github.com/Katello/puppet-pulp.git","ssh_url":"git@github.com:Katello/puppet-pulp.git","clone_url":"https://github.com/Katello/puppet-pulp.git","svn_url":"https://github.com/Katello/puppet-pulp","homepage":null,"size":508,"stargazers_count":2,"watchers_count":2,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33"},"html":{"href":"https://github.com/Katello/puppet-pulp/pull/33"},"issue":{"href":"https://api.github.com/repos/Katello/puppet-pulp/issues/33"},"comments":{"href":"https://api.github.com/repos/Katello/puppet-pulp/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Katello/puppet-pulp/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/puppet-pulp/statuses/20548b5c2b95466c8afb317240824d62fe613107"}}}}