{"action":"created","comment":{"url":"https://api.github.com/repos/progrium/dokku/pulls/comments/38678256","id":38678256,"diff_hunk":"@@ -0,0 +1,7 @@\n+#!/usr/bin/env bash\n+set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x\n+source \"$(dirname $0)/../common/functions\"\n+\n+tag_image() {","path":"plugins/tag/functions","position":5,"original_position":5,"commit_id":"2f16b06a7664a448ecf9c6832160f4b6808ffd4b","original_commit_id":"2f16b06a7664a448ecf9c6832160f4b6808ffd4b","user":{"login":"josegonzalez","id":65675,"avatar_url":"https://avatars.githubusercontent.com/u/65675?v=3","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"body":"No test for this?","created_at":"2015-09-03T18:16:39Z","updated_at":"2015-09-03T18:16:39Z","html_url":"https://github.com/progrium/dokku/pull/1225#discussion_r38678256","pull_request_url":"https://api.github.com/repos/progrium/dokku/pulls/1225","_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments/38678256"},"html":{"href":"https://github.com/progrium/dokku/pull/1225#discussion_r38678256"},"pull_request":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1225"}}},"pull_request":{"url":"https://api.github.com/repos/progrium/dokku/pulls/1225","id":37406107,"html_url":"https://github.com/progrium/dokku/pull/1225","diff_url":"https://github.com/progrium/dokku/pull/1225.diff","patch_url":"https://github.com/progrium/dokku/pull/1225.patch","issue_url":"https://api.github.com/repos/progrium/dokku/issues/1225","number":1225,"state":"open","locked":false,"title":"allow tagging and deployment of tagged app images","user":{"login":"michaelshobbs","id":4491438,"avatar_url":"https://avatars.githubusercontent.com/u/4491438?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelshobbs","html_url":"https://github.com/michaelshobbs","followers_url":"https://api.github.com/users/michaelshobbs/followers","following_url":"https://api.github.com/users/michaelshobbs/following{/other_user}","gists_url":"https://api.github.com/users/michaelshobbs/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelshobbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelshobbs/subscriptions","organizations_url":"https://api.github.com/users/michaelshobbs/orgs","repos_url":"https://api.github.com/users/michaelshobbs/repos","events_url":"https://api.github.com/users/michaelshobbs/events{/privacy}","received_events_url":"https://api.github.com/users/michaelshobbs/received_events","type":"User","site_admin":false},"body":"as with most \"simple\" things, this was not as straightforward as we've been fairly lax about how $IMAGE is set.\n\n- add tag plugin, documentation & tests\n    - tag:add\n    - tag:deploy\n    - tag:list\n    - tag:rm\n- consolidate setting `$IMAGE` to `verify_app_name()`\n- extend `verify_app_name()` to accept `$TAG` (image tag)\n- created `get_running_image_tag()`\n- consolidate `release`/`deploy` calls to `release_and_deploy()`\n- add `$TAG` to appropriate pluginhook calls\n    - `pre-deploy`\n    - `docker-args-deploy`\n    - `docker-args-run`\n    - `pre-release`\n    - `pre-release-buildstep`\n    - `pre-release-dockerfile`\n    - `post-release`\n    - `post-release-buildstep`\n    - `post-release-dockerfile`\n- make apps:destroy container/image cleanup more robust (read: actually destroy an app and *all* its artifcats)","created_at":"2015-06-10T21:22:26Z","updated_at":"2015-09-03T18:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d24baa4171d5c4dee3f0190508767def3e6464ae","assignee":{"login":"michaelshobbs","id":4491438,"avatar_url":"https://avatars.githubusercontent.com/u/4491438?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelshobbs","html_url":"https://github.com/michaelshobbs","followers_url":"https://api.github.com/users/michaelshobbs/followers","following_url":"https://api.github.com/users/michaelshobbs/following{/other_user}","gists_url":"https://api.github.com/users/michaelshobbs/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelshobbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelshobbs/subscriptions","organizations_url":"https://api.github.com/users/michaelshobbs/orgs","repos_url":"https://api.github.com/users/michaelshobbs/repos","events_url":"https://api.github.com/users/michaelshobbs/events{/privacy}","received_events_url":"https://api.github.com/users/michaelshobbs/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/progrium/dokku/pulls/1225/commits","review_comments_url":"https://api.github.com/repos/progrium/dokku/pulls/1225/comments","review_comment_url":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/progrium/dokku/issues/1225/comments","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/2f16b06a7664a448ecf9c6832160f4b6808ffd4b","head":{"label":"progrium:mh-image-tagging","ref":"mh-image-tagging","sha":"2f16b06a7664a448ecf9c6832160f4b6808ffd4b","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":10567197,"name":"dokku","full_name":"progrium/dokku","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":false,"url":"https://api.github.com/repos/progrium/dokku","forks_url":"https://api.github.com/repos/progrium/dokku/forks","keys_url":"https://api.github.com/repos/progrium/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/dokku/teams","hooks_url":"https://api.github.com/repos/progrium/dokku/hooks","issue_events_url":"https://api.github.com/repos/progrium/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/dokku/events","assignees_url":"https://api.github.com/repos/progrium/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/dokku/tags","blobs_url":"https://api.github.com/repos/progrium/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/dokku/languages","stargazers_url":"https://api.github.com/repos/progrium/dokku/stargazers","contributors_url":"https://api.github.com/repos/progrium/dokku/contributors","subscribers_url":"https://api.github.com/repos/progrium/dokku/subscribers","subscription_url":"https://api.github.com/repos/progrium/dokku/subscription","commits_url":"https://api.github.com/repos/progrium/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/progrium/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/dokku/merges","archive_url":"https://api.github.com/repos/progrium/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/dokku/downloads","issues_url":"https://api.github.com/repos/progrium/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/dokku/labels{/name}","releases_url":"https://api.github.com/repos/progrium/dokku/releases{/id}","created_at":"2013-06-08T10:26:57Z","updated_at":"2015-09-03T17:06:28Z","pushed_at":"2015-09-02T19:23:07Z","git_url":"git://github.com/progrium/dokku.git","ssh_url":"git@github.com:progrium/dokku.git","clone_url":"https://github.com/progrium/dokku.git","svn_url":"https://github.com/progrium/dokku","homepage":"http://progrium.viewdocs.io/dokku","size":7575,"stargazers_count":9925,"watchers_count":9925,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":824,"mirror_url":null,"open_issues_count":32,"forks":824,"open_issues":32,"watchers":9925,"default_branch":"master"}},"base":{"label":"progrium:master","ref":"master","sha":"03165ee3f88c0767985e7abd4174b5ca9a587dbd","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":10567197,"name":"dokku","full_name":"progrium/dokku","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":false,"url":"https://api.github.com/repos/progrium/dokku","forks_url":"https://api.github.com/repos/progrium/dokku/forks","keys_url":"https://api.github.com/repos/progrium/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/dokku/teams","hooks_url":"https://api.github.com/repos/progrium/dokku/hooks","issue_events_url":"https://api.github.com/repos/progrium/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/dokku/events","assignees_url":"https://api.github.com/repos/progrium/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/dokku/tags","blobs_url":"https://api.github.com/repos/progrium/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/dokku/languages","stargazers_url":"https://api.github.com/repos/progrium/dokku/stargazers","contributors_url":"https://api.github.com/repos/progrium/dokku/contributors","subscribers_url":"https://api.github.com/repos/progrium/dokku/subscribers","subscription_url":"https://api.github.com/repos/progrium/dokku/subscription","commits_url":"https://api.github.com/repos/progrium/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/progrium/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/dokku/merges","archive_url":"https://api.github.com/repos/progrium/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/dokku/downloads","issues_url":"https://api.github.com/repos/progrium/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/dokku/labels{/name}","releases_url":"https://api.github.com/repos/progrium/dokku/releases{/id}","created_at":"2013-06-08T10:26:57Z","updated_at":"2015-09-03T17:06:28Z","pushed_at":"2015-09-02T19:23:07Z","git_url":"git://github.com/progrium/dokku.git","ssh_url":"git@github.com:progrium/dokku.git","clone_url":"https://github.com/progrium/dokku.git","svn_url":"https://github.com/progrium/dokku","homepage":"http://progrium.viewdocs.io/dokku","size":7575,"stargazers_count":9925,"watchers_count":9925,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":824,"mirror_url":null,"open_issues_count":32,"forks":824,"open_issues":32,"watchers":9925,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1225"},"html":{"href":"https://github.com/progrium/dokku/pull/1225"},"issue":{"href":"https://api.github.com/repos/progrium/dokku/issues/1225"},"comments":{"href":"https://api.github.com/repos/progrium/dokku/issues/1225/comments"},"review_comments":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1225/comments"},"review_comment":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1225/commits"},"statuses":{"href":"https://api.github.com/repos/progrium/dokku/statuses/2f16b06a7664a448ecf9c6832160f4b6808ffd4b"}}}}