{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/oozie/pyhumod/pulls/9","id":33327710,"html_url":"https://github.com/oozie/pyhumod/pull/9","diff_url":"https://github.com/oozie/pyhumod/pull/9.diff","patch_url":"https://github.com/oozie/pyhumod/pull/9.patch","issue_url":"https://api.github.com/repos/oozie/pyhumod/issues/9","number":9,"state":"closed","locked":false,"title":"Fix for #7 improper handling of 'OK' content in an SMS","user":{"login":"oozie","id":1587140,"avatar_url":"https://avatars.githubusercontent.com/u/1587140?v=3","gravatar_id":"","url":"https://api.github.com/users/oozie","html_url":"https://github.com/oozie","followers_url":"https://api.github.com/users/oozie/followers","following_url":"https://api.github.com/users/oozie/following{/other_user}","gists_url":"https://api.github.com/users/oozie/gists{/gist_id}","starred_url":"https://api.github.com/users/oozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oozie/subscriptions","organizations_url":"https://api.github.com/users/oozie/orgs","repos_url":"https://api.github.com/users/oozie/repos","events_url":"https://api.github.com/users/oozie/events{/privacy}","received_events_url":"https://api.github.com/users/oozie/received_events","type":"User","site_admin":false},"body":"This probably fixes the issue, as confirmed by a unit test, but I'm unable to functionally test it since I don't have an enabled modem anymore. \r\n\r\n@fmalina I'd appreciate if you could review this change.\r\n\r\nRunning unit tests is a little awkward since I was too lazy to do the whole distutils/setuptools compatibility thing between py3 and py2, so here is how we do it for now:\r\n\r\nThis will use the version currently installed (the \"before\"):\r\n```\r\n~/pyhumod$ python tests/test_humodem.py\r\n```\r\nThis will use the version from the branch (the \"after\"):\r\n```\r\n~/pyhumod$ PYTHONPATH=\".\" python tests/test_humodem.py\r\n```","created_at":"2015-04-15T07:07:10Z","updated_at":"2015-04-21T15:50:59Z","closed_at":"2015-04-21T15:50:59Z","merged_at":"2015-04-21T15:50:59Z","merge_commit_sha":"13fae6f476ada9c23be61bfcb7960b481ce6b54a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/oozie/pyhumod/pulls/9/commits","review_comments_url":"https://api.github.com/repos/oozie/pyhumod/pulls/9/comments","review_comment_url":"https://api.github.com/repos/oozie/pyhumod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oozie/pyhumod/issues/9/comments","statuses_url":"https://api.github.com/repos/oozie/pyhumod/statuses/cc0da9fbfcad21a00f868d55b84d25656f20b040","head":{"label":"oozie:master_ok_bugfix","ref":"master_ok_bugfix","sha":"cc0da9fbfcad21a00f868d55b84d25656f20b040","user":{"login":"oozie","id":1587140,"avatar_url":"https://avatars.githubusercontent.com/u/1587140?v=3","gravatar_id":"","url":"https://api.github.com/users/oozie","html_url":"https://github.com/oozie","followers_url":"https://api.github.com/users/oozie/followers","following_url":"https://api.github.com/users/oozie/following{/other_user}","gists_url":"https://api.github.com/users/oozie/gists{/gist_id}","starred_url":"https://api.github.com/users/oozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oozie/subscriptions","organizations_url":"https://api.github.com/users/oozie/orgs","repos_url":"https://api.github.com/users/oozie/repos","events_url":"https://api.github.com/users/oozie/events{/privacy}","received_events_url":"https://api.github.com/users/oozie/received_events","type":"User","site_admin":false},"repo":{"id":32119923,"name":"pyhumod","full_name":"oozie/pyhumod","owner":{"login":"oozie","id":1587140,"avatar_url":"https://avatars.githubusercontent.com/u/1587140?v=3","gravatar_id":"","url":"https://api.github.com/users/oozie","html_url":"https://github.com/oozie","followers_url":"https://api.github.com/users/oozie/followers","following_url":"https://api.github.com/users/oozie/following{/other_user}","gists_url":"https://api.github.com/users/oozie/gists{/gist_id}","starred_url":"https://api.github.com/users/oozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oozie/subscriptions","organizations_url":"https://api.github.com/users/oozie/orgs","repos_url":"https://api.github.com/users/oozie/repos","events_url":"https://api.github.com/users/oozie/events{/privacy}","received_events_url":"https://api.github.com/users/oozie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oozie/pyhumod","description":"Using Huawei Modems in Python ","fork":false,"url":"https://api.github.com/repos/oozie/pyhumod","forks_url":"https://api.github.com/repos/oozie/pyhumod/forks","keys_url":"https://api.github.com/repos/oozie/pyhumod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oozie/pyhumod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oozie/pyhumod/teams","hooks_url":"https://api.github.com/repos/oozie/pyhumod/hooks","issue_events_url":"https://api.github.com/repos/oozie/pyhumod/issues/events{/number}","events_url":"https://api.github.com/repos/oozie/pyhumod/events","assignees_url":"https://api.github.com/repos/oozie/pyhumod/assignees{/user}","branches_url":"https://api.github.com/repos/oozie/pyhumod/branches{/branch}","tags_url":"https://api.github.com/repos/oozie/pyhumod/tags","blobs_url":"https://api.github.com/repos/oozie/pyhumod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oozie/pyhumod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oozie/pyhumod/git/refs{/sha}","trees_url":"https://api.github.com/repos/oozie/pyhumod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oozie/pyhumod/statuses/{sha}","languages_url":"https://api.github.com/repos/oozie/pyhumod/languages","stargazers_url":"https://api.github.com/repos/oozie/pyhumod/stargazers","contributors_url":"https://api.github.com/repos/oozie/pyhumod/contributors","subscribers_url":"https://api.github.com/repos/oozie/pyhumod/subscribers","subscription_url":"https://api.github.com/repos/oozie/pyhumod/subscription","commits_url":"https://api.github.com/repos/oozie/pyhumod/commits{/sha}","git_commits_url":"https://api.github.com/repos/oozie/pyhumod/git/commits{/sha}","comments_url":"https://api.github.com/repos/oozie/pyhumod/comments{/number}","issue_comment_url":"https://api.github.com/repos/oozie/pyhumod/issues/comments{/number}","contents_url":"https://api.github.com/repos/oozie/pyhumod/contents/{+path}","compare_url":"https://api.github.com/repos/oozie/pyhumod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oozie/pyhumod/merges","archive_url":"https://api.github.com/repos/oozie/pyhumod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oozie/pyhumod/downloads","issues_url":"https://api.github.com/repos/oozie/pyhumod/issues{/number}","pulls_url":"https://api.github.com/repos/oozie/pyhumod/pulls{/number}","milestones_url":"https://api.github.com/repos/oozie/pyhumod/milestones{/number}","notifications_url":"https://api.github.com/repos/oozie/pyhumod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oozie/pyhumod/labels{/name}","releases_url":"https://api.github.com/repos/oozie/pyhumod/releases{/id}","created_at":"2015-03-13T02:14:05Z","updated_at":"2015-03-30T04:38:35Z","pushed_at":"2015-04-21T15:50:59Z","git_url":"git://github.com/oozie/pyhumod.git","ssh_url":"git@github.com:oozie/pyhumod.git","clone_url":"https://github.com/oozie/pyhumod.git","svn_url":"https://github.com/oozie/pyhumod","homepage":"","size":385,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"oozie:master","ref":"master","sha":"dc97c600f8aa481d1d2171cd601e4ef1c7f3863e","user":{"login":"oozie","id":1587140,"avatar_url":"https://avatars.githubusercontent.com/u/1587140?v=3","gravatar_id":"","url":"https://api.github.com/users/oozie","html_url":"https://github.com/oozie","followers_url":"https://api.github.com/users/oozie/followers","following_url":"https://api.github.com/users/oozie/following{/other_user}","gists_url":"https://api.github.com/users/oozie/gists{/gist_id}","starred_url":"https://api.github.com/users/oozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oozie/subscriptions","organizations_url":"https://api.github.com/users/oozie/orgs","repos_url":"https://api.github.com/users/oozie/repos","events_url":"https://api.github.com/users/oozie/events{/privacy}","received_events_url":"https://api.github.com/users/oozie/received_events","type":"User","site_admin":false},"repo":{"id":32119923,"name":"pyhumod","full_name":"oozie/pyhumod","owner":{"login":"oozie","id":1587140,"avatar_url":"https://avatars.githubusercontent.com/u/1587140?v=3","gravatar_id":"","url":"https://api.github.com/users/oozie","html_url":"https://github.com/oozie","followers_url":"https://api.github.com/users/oozie/followers","following_url":"https://api.github.com/users/oozie/following{/other_user}","gists_url":"https://api.github.com/users/oozie/gists{/gist_id}","starred_url":"https://api.github.com/users/oozie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oozie/subscriptions","organizations_url":"https://api.github.com/users/oozie/orgs","repos_url":"https://api.github.com/users/oozie/repos","events_url":"https://api.github.com/users/oozie/events{/privacy}","received_events_url":"https://api.github.com/users/oozie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oozie/pyhumod","description":"Using Huawei Modems in Python ","fork":false,"url":"https://api.github.com/repos/oozie/pyhumod","forks_url":"https://api.github.com/repos/oozie/pyhumod/forks","keys_url":"https://api.github.com/repos/oozie/pyhumod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oozie/pyhumod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oozie/pyhumod/teams","hooks_url":"https://api.github.com/repos/oozie/pyhumod/hooks","issue_events_url":"https://api.github.com/repos/oozie/pyhumod/issues/events{/number}","events_url":"https://api.github.com/repos/oozie/pyhumod/events","assignees_url":"https://api.github.com/repos/oozie/pyhumod/assignees{/user}","branches_url":"https://api.github.com/repos/oozie/pyhumod/branches{/branch}","tags_url":"https://api.github.com/repos/oozie/pyhumod/tags","blobs_url":"https://api.github.com/repos/oozie/pyhumod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oozie/pyhumod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oozie/pyhumod/git/refs{/sha}","trees_url":"https://api.github.com/repos/oozie/pyhumod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oozie/pyhumod/statuses/{sha}","languages_url":"https://api.github.com/repos/oozie/pyhumod/languages","stargazers_url":"https://api.github.com/repos/oozie/pyhumod/stargazers","contributors_url":"https://api.github.com/repos/oozie/pyhumod/contributors","subscribers_url":"https://api.github.com/repos/oozie/pyhumod/subscribers","subscription_url":"https://api.github.com/repos/oozie/pyhumod/subscription","commits_url":"https://api.github.com/repos/oozie/pyhumod/commits{/sha}","git_commits_url":"https://api.github.com/repos/oozie/pyhumod/git/commits{/sha}","comments_url":"https://api.github.com/repos/oozie/pyhumod/comments{/number}","issue_comment_url":"https://api.github.com/repos/oozie/pyhumod/issues/comments{/number}","contents_url":"https://api.github.com/repos/oozie/pyhumod/contents/{+path}","compare_url":"https://api.github.com/repos/oozie/pyhumod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oozie/pyhumod/merges","archive_url":"https://api.github.com/repos/oozie/pyhumod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oozie/pyhumod/downloads","issues_url":"https://api.github.com/repos/oozie/pyhumod/issues{/number}","pulls_url":"https://api.github.com/repos/oozie/pyhumod/pulls{/number}","milestones_url":"https://api.github.com/repos/oozie/pyhumod/milestones{/number}","notifications_url":"https://api.github.com/repos/oozie/pyhumod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oozie/pyhumod/labels{/name}","releases_url":"https://api.github.com/repos/oozie/pyhumod/releases{/id}","created_at":"2015-03-13T02:14:05Z","updated_at":"2015-03-30T04:38:35Z","pushed_at":"2015-04-21T15:50:59Z","git_url":"git://github.com/oozie/pyhumod.git","ssh_url":"git@github.com:oozie/pyhumod.git","clone_url":"https://github.com/oozie/pyhumod.git","svn_url":"https://github.com/oozie/pyhumod","homepage":"","size":385,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oozie/pyhumod/pulls/9"},"html":{"href":"https://github.com/oozie/pyhumod/pull/9"},"issue":{"href":"https://api.github.com/repos/oozie/pyhumod/issues/9"},"comments":{"href":"https://api.github.com/repos/oozie/pyhumod/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/oozie/pyhumod/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/oozie/pyhumod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oozie/pyhumod/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/oozie/pyhumod/statuses/cc0da9fbfcad21a00f868d55b84d25656f20b040"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fmalina","id":10356928,"avatar_url":"https://avatars.githubusercontent.com/u/10356928?v=3","gravatar_id":"","url":"https://api.github.com/users/fmalina","html_url":"https://github.com/fmalina","followers_url":"https://api.github.com/users/fmalina/followers","following_url":"https://api.github.com/users/fmalina/following{/other_user}","gists_url":"https://api.github.com/users/fmalina/gists{/gist_id}","starred_url":"https://api.github.com/users/fmalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmalina/subscriptions","organizations_url":"https://api.github.com/users/fmalina/orgs","repos_url":"https://api.github.com/users/fmalina/repos","events_url":"https://api.github.com/users/fmalina/events{/privacy}","received_events_url":"https://api.github.com/users/fmalina/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":58,"deletions":2,"changed_files":3}}