{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/remeh/upd/pulls/7","id":38386823,"html_url":"https://github.com/remeh/upd/pull/7","diff_url":"https://github.com/remeh/upd/pull/7.diff","patch_url":"https://github.com/remeh/upd/pull/7.patch","issue_url":"https://api.github.com/repos/remeh/upd/issues/7","number":7,"state":"closed","locked":false,"title":"Fix a deadlock in CleanJob","user":{"login":"vrischmann","id":1916079,"avatar_url":"https://avatars.githubusercontent.com/u/1916079?v=3","gravatar_id":"","url":"https://api.github.com/users/vrischmann","html_url":"https://github.com/vrischmann","followers_url":"https://api.github.com/users/vrischmann/followers","following_url":"https://api.github.com/users/vrischmann/following{/other_user}","gists_url":"https://api.github.com/users/vrischmann/gists{/gist_id}","starred_url":"https://api.github.com/users/vrischmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrischmann/subscriptions","organizations_url":"https://api.github.com/users/vrischmann/orgs","repos_url":"https://api.github.com/users/vrischmann/repos","events_url":"https://api.github.com/users/vrischmann/events{/privacy}","received_events_url":"https://api.github.com/users/vrischmann/received_events","type":"User","site_admin":false},"body":"With the current code if you have entries to expire, it will deadlock: the `Run` method takes a View on the `Database`, and `Expire` will then try to get a lock via `deleteMetadata`. This will fail, forever blocking upd.","created_at":"2015-06-23T21:46:34Z","updated_at":"2015-06-24T07:17:47Z","closed_at":"2015-06-24T07:17:47Z","merged_at":null,"merge_commit_sha":"09548a807a69e1cab42d06fb222466a16851710e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/remeh/upd/pulls/7/commits","review_comments_url":"https://api.github.com/repos/remeh/upd/pulls/7/comments","review_comment_url":"https://api.github.com/repos/remeh/upd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remeh/upd/issues/7/comments","statuses_url":"https://api.github.com/repos/remeh/upd/statuses/76c0edc427342fc650659cf49e34b4e094c45e5b","head":{"label":"vrischmann:master","ref":"master","sha":"76c0edc427342fc650659cf49e34b4e094c45e5b","user":{"login":"vrischmann","id":1916079,"avatar_url":"https://avatars.githubusercontent.com/u/1916079?v=3","gravatar_id":"","url":"https://api.github.com/users/vrischmann","html_url":"https://github.com/vrischmann","followers_url":"https://api.github.com/users/vrischmann/followers","following_url":"https://api.github.com/users/vrischmann/following{/other_user}","gists_url":"https://api.github.com/users/vrischmann/gists{/gist_id}","starred_url":"https://api.github.com/users/vrischmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrischmann/subscriptions","organizations_url":"https://api.github.com/users/vrischmann/orgs","repos_url":"https://api.github.com/users/vrischmann/repos","events_url":"https://api.github.com/users/vrischmann/events{/privacy}","received_events_url":"https://api.github.com/users/vrischmann/received_events","type":"User","site_admin":false},"repo":{"id":37878586,"name":"upd","full_name":"vrischmann/upd","owner":{"login":"vrischmann","id":1916079,"avatar_url":"https://avatars.githubusercontent.com/u/1916079?v=3","gravatar_id":"","url":"https://api.github.com/users/vrischmann","html_url":"https://github.com/vrischmann","followers_url":"https://api.github.com/users/vrischmann/followers","following_url":"https://api.github.com/users/vrischmann/following{/other_user}","gists_url":"https://api.github.com/users/vrischmann/gists{/gist_id}","starred_url":"https://api.github.com/users/vrischmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrischmann/subscriptions","organizations_url":"https://api.github.com/users/vrischmann/orgs","repos_url":"https://api.github.com/users/vrischmann/repos","events_url":"https://api.github.com/users/vrischmann/events{/privacy}","received_events_url":"https://api.github.com/users/vrischmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrischmann/upd","description":"Upload from the command-line, share with your browsers.","fork":true,"url":"https://api.github.com/repos/vrischmann/upd","forks_url":"https://api.github.com/repos/vrischmann/upd/forks","keys_url":"https://api.github.com/repos/vrischmann/upd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrischmann/upd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrischmann/upd/teams","hooks_url":"https://api.github.com/repos/vrischmann/upd/hooks","issue_events_url":"https://api.github.com/repos/vrischmann/upd/issues/events{/number}","events_url":"https://api.github.com/repos/vrischmann/upd/events","assignees_url":"https://api.github.com/repos/vrischmann/upd/assignees{/user}","branches_url":"https://api.github.com/repos/vrischmann/upd/branches{/branch}","tags_url":"https://api.github.com/repos/vrischmann/upd/tags","blobs_url":"https://api.github.com/repos/vrischmann/upd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrischmann/upd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrischmann/upd/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrischmann/upd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrischmann/upd/statuses/{sha}","languages_url":"https://api.github.com/repos/vrischmann/upd/languages","stargazers_url":"https://api.github.com/repos/vrischmann/upd/stargazers","contributors_url":"https://api.github.com/repos/vrischmann/upd/contributors","subscribers_url":"https://api.github.com/repos/vrischmann/upd/subscribers","subscription_url":"https://api.github.com/repos/vrischmann/upd/subscription","commits_url":"https://api.github.com/repos/vrischmann/upd/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrischmann/upd/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrischmann/upd/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrischmann/upd/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrischmann/upd/contents/{+path}","compare_url":"https://api.github.com/repos/vrischmann/upd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrischmann/upd/merges","archive_url":"https://api.github.com/repos/vrischmann/upd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrischmann/upd/downloads","issues_url":"https://api.github.com/repos/vrischmann/upd/issues{/number}","pulls_url":"https://api.github.com/repos/vrischmann/upd/pulls{/number}","milestones_url":"https://api.github.com/repos/vrischmann/upd/milestones{/number}","notifications_url":"https://api.github.com/repos/vrischmann/upd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrischmann/upd/labels{/name}","releases_url":"https://api.github.com/repos/vrischmann/upd/releases{/id}","created_at":"2015-06-22T20:20:25Z","updated_at":"2015-06-22T20:20:26Z","pushed_at":"2015-06-23T21:42:36Z","git_url":"git://github.com/vrischmann/upd.git","ssh_url":"git@github.com:vrischmann/upd.git","clone_url":"https://github.com/vrischmann/upd.git","svn_url":"https://github.com/vrischmann/upd","homepage":"","size":351,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"remeh:master","ref":"master","sha":"3e756e613248b19887c28121098520db8a5d1ee4","user":{"login":"remeh","id":1798689,"avatar_url":"https://avatars.githubusercontent.com/u/1798689?v=3","gravatar_id":"","url":"https://api.github.com/users/remeh","html_url":"https://github.com/remeh","followers_url":"https://api.github.com/users/remeh/followers","following_url":"https://api.github.com/users/remeh/following{/other_user}","gists_url":"https://api.github.com/users/remeh/gists{/gist_id}","starred_url":"https://api.github.com/users/remeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remeh/subscriptions","organizations_url":"https://api.github.com/users/remeh/orgs","repos_url":"https://api.github.com/users/remeh/repos","events_url":"https://api.github.com/users/remeh/events{/privacy}","received_events_url":"https://api.github.com/users/remeh/received_events","type":"User","site_admin":false},"repo":{"id":29859076,"name":"upd","full_name":"remeh/upd","owner":{"login":"remeh","id":1798689,"avatar_url":"https://avatars.githubusercontent.com/u/1798689?v=3","gravatar_id":"","url":"https://api.github.com/users/remeh","html_url":"https://github.com/remeh","followers_url":"https://api.github.com/users/remeh/followers","following_url":"https://api.github.com/users/remeh/following{/other_user}","gists_url":"https://api.github.com/users/remeh/gists{/gist_id}","starred_url":"https://api.github.com/users/remeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remeh/subscriptions","organizations_url":"https://api.github.com/users/remeh/orgs","repos_url":"https://api.github.com/users/remeh/repos","events_url":"https://api.github.com/users/remeh/events{/privacy}","received_events_url":"https://api.github.com/users/remeh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remeh/upd","description":"Upload from the command-line, share with your browsers.","fork":false,"url":"https://api.github.com/repos/remeh/upd","forks_url":"https://api.github.com/repos/remeh/upd/forks","keys_url":"https://api.github.com/repos/remeh/upd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remeh/upd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remeh/upd/teams","hooks_url":"https://api.github.com/repos/remeh/upd/hooks","issue_events_url":"https://api.github.com/repos/remeh/upd/issues/events{/number}","events_url":"https://api.github.com/repos/remeh/upd/events","assignees_url":"https://api.github.com/repos/remeh/upd/assignees{/user}","branches_url":"https://api.github.com/repos/remeh/upd/branches{/branch}","tags_url":"https://api.github.com/repos/remeh/upd/tags","blobs_url":"https://api.github.com/repos/remeh/upd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remeh/upd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remeh/upd/git/refs{/sha}","trees_url":"https://api.github.com/repos/remeh/upd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remeh/upd/statuses/{sha}","languages_url":"https://api.github.com/repos/remeh/upd/languages","stargazers_url":"https://api.github.com/repos/remeh/upd/stargazers","contributors_url":"https://api.github.com/repos/remeh/upd/contributors","subscribers_url":"https://api.github.com/repos/remeh/upd/subscribers","subscription_url":"https://api.github.com/repos/remeh/upd/subscription","commits_url":"https://api.github.com/repos/remeh/upd/commits{/sha}","git_commits_url":"https://api.github.com/repos/remeh/upd/git/commits{/sha}","comments_url":"https://api.github.com/repos/remeh/upd/comments{/number}","issue_comment_url":"https://api.github.com/repos/remeh/upd/issues/comments{/number}","contents_url":"https://api.github.com/repos/remeh/upd/contents/{+path}","compare_url":"https://api.github.com/repos/remeh/upd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remeh/upd/merges","archive_url":"https://api.github.com/repos/remeh/upd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remeh/upd/downloads","issues_url":"https://api.github.com/repos/remeh/upd/issues{/number}","pulls_url":"https://api.github.com/repos/remeh/upd/pulls{/number}","milestones_url":"https://api.github.com/repos/remeh/upd/milestones{/number}","notifications_url":"https://api.github.com/repos/remeh/upd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remeh/upd/labels{/name}","releases_url":"https://api.github.com/repos/remeh/upd/releases{/id}","created_at":"2015-01-26T11:59:06Z","updated_at":"2015-05-07T15:49:58Z","pushed_at":"2015-06-23T21:46:35Z","git_url":"git://github.com/remeh/upd.git","ssh_url":"git@github.com:remeh/upd.git","clone_url":"https://github.com/remeh/upd.git","svn_url":"https://github.com/remeh/upd","homepage":"","size":351,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remeh/upd/pulls/7"},"html":{"href":"https://github.com/remeh/upd/pull/7"},"issue":{"href":"https://api.github.com/repos/remeh/upd/issues/7"},"comments":{"href":"https://api.github.com/repos/remeh/upd/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/remeh/upd/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/remeh/upd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remeh/upd/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/remeh/upd/statuses/76c0edc427342fc650659cf49e34b4e094c45e5b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":15,"deletions":10,"changed_files":1}}