{"action":"created","issue":{"url":"https://api.github.com/repos/rackt/redux-react-router/issues/57","labels_url":"https://api.github.com/repos/rackt/redux-react-router/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/rackt/redux-react-router/issues/57/comments","events_url":"https://api.github.com/repos/rackt/redux-react-router/issues/57/events","html_url":"https://github.com/rackt/redux-react-router/issues/57","id":106986030,"number":57,"title":"Necessary to put complete routes in store?","user":{"login":"Furizaa","id":365742,"avatar_url":"https://avatars.githubusercontent.com/u/365742?v=3","gravatar_id":"","url":"https://api.github.com/users/Furizaa","html_url":"https://github.com/Furizaa","followers_url":"https://api.github.com/users/Furizaa/followers","following_url":"https://api.github.com/users/Furizaa/following{/other_user}","gists_url":"https://api.github.com/users/Furizaa/gists{/gist_id}","starred_url":"https://api.github.com/users/Furizaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Furizaa/subscriptions","organizations_url":"https://api.github.com/users/Furizaa/orgs","repos_url":"https://api.github.com/users/Furizaa/repos","events_url":"https://api.github.com/users/Furizaa/events{/privacy}","received_events_url":"https://api.github.com/users/Furizaa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-17T13:34:42Z","updated_at":"2015-09-18T00:28:11Z","closed_at":null,"body":"This also puts all components in the store and its even possible to break things with a cyclic dependency.\r\n\r\nFor example:\r\n\r\n1. A `<App store={store} />` root component that receives the store using a prop (the store is created differently by client/server).\r\n2. `<ReduxRouter>{routes}</ReduxRouter>` is a child of `<App>`\r\n3. Routes get stored in state\r\n4. Therefore, using the `_owner` relation, also `<App>` is stored in the store (deeply nested somewhere in routes)\r\n5. store is stored in store because it's a prop of `App`. Cyclic dependency is complete.\r\n\r\nI hope this makes any sense. It's a constructed case because store is passed to `<App>`. But nevertheless it breaks redux-devtools with persistState."},"comment":{"url":"https://api.github.com/repos/rackt/redux-react-router/issues/comments/141295280","html_url":"https://github.com/rackt/redux-react-router/issues/57#issuecomment-141295280","issue_url":"https://api.github.com/repos/rackt/redux-react-router/issues/57","id":141295280,"user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars.githubusercontent.com/u/3624098?v=3","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T00:28:11Z","updated_at":"2015-09-18T00:28:11Z","body":"No problem, I didn't get that vibe at all :)"}}