{"action":"created","issue":{"url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/163","labels_url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/163/comments","events_url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/163/events","html_url":"https://github.com/Glucosio/glucosio-android/pull/163","id":116476042,"number":163,"title":"Created UI tests for Hello Activity","user":{"login":"amouly","id":4089870,"avatar_url":"https://avatars.githubusercontent.com/u/4089870?v=3","gravatar_id":"","url":"https://api.github.com/users/amouly","html_url":"https://github.com/amouly","followers_url":"https://api.github.com/users/amouly/followers","following_url":"https://api.github.com/users/amouly/following{/other_user}","gists_url":"https://api.github.com/users/amouly/gists{/gist_id}","starred_url":"https://api.github.com/users/amouly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amouly/subscriptions","organizations_url":"https://api.github.com/users/amouly/orgs","repos_url":"https://api.github.com/users/amouly/repos","events_url":"https://api.github.com/users/amouly/events{/privacy}","received_events_url":"https://api.github.com/users/amouly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-12T04:11:01Z","updated_at":"2015-11-12T22:47:41Z","closed_at":"2015-11-12T15:12:31Z","pull_request":{"url":"https://api.github.com/repos/Glucosio/glucosio-android/pulls/163","html_url":"https://github.com/Glucosio/glucosio-android/pull/163","diff_url":"https://github.com/Glucosio/glucosio-android/pull/163.diff","patch_url":"https://github.com/Glucosio/glucosio-android/pull/163.patch"},"body":"# Description of Changes\r\n\r\n- Refactor some IDs on HelloActivity layout, so now it's more descriptive and standard.\r\n- Replace some \"fill_parent\" with \"match_parent\". From Android 2 this both attributes are the same, but the second one is the most used. Anyway, there is no visual changes.\r\n- Added UI tests for HelloActivity\r\n - Check if every element is showing.\r\n - Check the submission flow.\r\n- Created a custom ClickAction class due to some issues on Espresso library.\r\n- I've found some issues when looking for the custom spinner on the UI hierarchy, so I've added an ID to it.\r\n\r\n# Testing\r\n\r\nThese tests were run on:\r\n> LG Nexus 5 - Android 5.1.1.\r\n\r\nFor testing it, you should connect a real device to your computer, and then run the Espresso tests with the following command:\r\n> ./gradlew connectedAndroidTest\r\n\r\nAfter that you can check the output from the console or the HTML file located in:\r\n> {PROJECT_PATH} /app/build/reports/androidTests/connected/org.glucosio.android.html"},"comment":{"url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/comments/156261509","html_url":"https://github.com/Glucosio/glucosio-android/pull/163#issuecomment-156261509","issue_url":"https://api.github.com/repos/Glucosio/glucosio-android/issues/163","id":156261509,"user":{"login":"amouly","id":4089870,"avatar_url":"https://avatars.githubusercontent.com/u/4089870?v=3","gravatar_id":"","url":"https://api.github.com/users/amouly","html_url":"https://github.com/amouly","followers_url":"https://api.github.com/users/amouly/followers","following_url":"https://api.github.com/users/amouly/following{/other_user}","gists_url":"https://api.github.com/users/amouly/gists{/gist_id}","starred_url":"https://api.github.com/users/amouly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amouly/subscriptions","organizations_url":"https://api.github.com/users/amouly/orgs","repos_url":"https://api.github.com/users/amouly/repos","events_url":"https://api.github.com/users/amouly/events{/privacy}","received_events_url":"https://api.github.com/users/amouly/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T22:47:41Z","updated_at":"2015-11-12T22:47:41Z","body":"@piotrek1543 what do you think about this tests I've made? Do you want to review or improve it? Thank you."}}