{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/musnix/musnix/pulls/21","id":39501531,"html_url":"https://github.com/musnix/musnix/pull/21","diff_url":"https://github.com/musnix/musnix/pull/21.diff","patch_url":"https://github.com/musnix/musnix/pull/21.patch","issue_url":"https://api.github.com/repos/musnix/musnix/issues/21","number":21,"state":"closed","locked":false,"title":"Refactor kernel.nix, add 3.18.17-rt14 and 4.0.5-rt4 kernels","user":{"login":"henrytill","id":6430643,"avatar_url":"https://avatars.githubusercontent.com/u/6430643?v=3","gravatar_id":"","url":"https://api.github.com/users/henrytill","html_url":"https://github.com/henrytill","followers_url":"https://api.github.com/users/henrytill/followers","following_url":"https://api.github.com/users/henrytill/following{/other_user}","gists_url":"https://api.github.com/users/henrytill/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytill/subscriptions","organizations_url":"https://api.github.com/users/henrytill/orgs","repos_url":"https://api.github.com/users/henrytill/repos","events_url":"https://api.github.com/users/henrytill/events{/privacy}","received_events_url":"https://api.github.com/users/henrytill/received_events","type":"User","site_admin":false},"body":"Opening this to track progress...\r\n\r\nImportant changes:\r\n* Users will be able to choose from several available real-time kernels.  This is done by setting `musnix.kernel.packages` to one of the following packages:  \r\n  * `pkgs.linuxPackages_3_14_rt`\r\n  * `pkgs.linuxPackages_3_18_rt` (default)\r\n  * `pkgs.linuxPackages_4_0_rt`\r\n* For real-time kernels, rather than applying the `CONFIG_PREEMPT_RT` patches using overrides, the patches are now directly applied to three new kernel derivations.   The patch expressions have also been moved to a separate file.  This approach is similar to what is used in [nixpkgs](https://github.com/NixOS/nixpkgs/tree/master/pkgs/os-specific/linux/kernel), and facilitates moving some of this work there when the time comes.  \r\n  * At that point, we'd probably add something like: \r\n\r\n    ```\r\n    features.realtime = true;\r\n    ```\r\n    to each real-time kernel expression, and the kernel config flags would be moved from `extraConfig`, where they are now, to an \r\n    ```\r\n    ${optionalString features.realtime ''\r\n    \r\n    ...\r\n\r\n    ''}\r\n    ``` \r\n    clause in [`common-config.nix`](https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/kernel/common-config.nix), etc.  \r\n  * As in this PR, we would need separate kernel expressions in nixpkgs,  because the patches need to stay pinned to their particular kernel versions.  \r\n\r\n* Similarly, the directory structure of `pkgs` now mirrors the relevant [slice](https://github.com/NixOS/nixpkgs/tree/master/pkgs/os-specific/linux) of nixpkgs.","created_at":"2015-07-08T17:22:19Z","updated_at":"2015-07-10T03:27:19Z","closed_at":"2015-07-10T03:27:19Z","merged_at":"2015-07-10T03:27:19Z","merge_commit_sha":"635fcf3337a4036aa9aef7d22a73adb74f53719b","assignee":{"login":"henrytill","id":6430643,"avatar_url":"https://avatars.githubusercontent.com/u/6430643?v=3","gravatar_id":"","url":"https://api.github.com/users/henrytill","html_url":"https://github.com/henrytill","followers_url":"https://api.github.com/users/henrytill/followers","following_url":"https://api.github.com/users/henrytill/following{/other_user}","gists_url":"https://api.github.com/users/henrytill/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytill/subscriptions","organizations_url":"https://api.github.com/users/henrytill/orgs","repos_url":"https://api.github.com/users/henrytill/repos","events_url":"https://api.github.com/users/henrytill/events{/privacy}","received_events_url":"https://api.github.com/users/henrytill/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/musnix/musnix/pulls/21/commits","review_comments_url":"https://api.github.com/repos/musnix/musnix/pulls/21/comments","review_comment_url":"https://api.github.com/repos/musnix/musnix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musnix/musnix/issues/21/comments","statuses_url":"https://api.github.com/repos/musnix/musnix/statuses/9a6e89ade603254870fa58b3643ed601aac473cf","head":{"label":"musnix:refactor-kernel","ref":"refactor-kernel","sha":"9a6e89ade603254870fa58b3643ed601aac473cf","user":{"login":"musnix","id":10273760,"avatar_url":"https://avatars.githubusercontent.com/u/10273760?v=3","gravatar_id":"","url":"https://api.github.com/users/musnix","html_url":"https://github.com/musnix","followers_url":"https://api.github.com/users/musnix/followers","following_url":"https://api.github.com/users/musnix/following{/other_user}","gists_url":"https://api.github.com/users/musnix/gists{/gist_id}","starred_url":"https://api.github.com/users/musnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musnix/subscriptions","organizations_url":"https://api.github.com/users/musnix/orgs","repos_url":"https://api.github.com/users/musnix/repos","events_url":"https://api.github.com/users/musnix/events{/privacy}","received_events_url":"https://api.github.com/users/musnix/received_events","type":"Organization","site_admin":false},"repo":{"id":28358928,"name":"musnix","full_name":"musnix/musnix","owner":{"login":"musnix","id":10273760,"avatar_url":"https://avatars.githubusercontent.com/u/10273760?v=3","gravatar_id":"","url":"https://api.github.com/users/musnix","html_url":"https://github.com/musnix","followers_url":"https://api.github.com/users/musnix/followers","following_url":"https://api.github.com/users/musnix/following{/other_user}","gists_url":"https://api.github.com/users/musnix/gists{/gist_id}","starred_url":"https://api.github.com/users/musnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musnix/subscriptions","organizations_url":"https://api.github.com/users/musnix/orgs","repos_url":"https://api.github.com/users/musnix/repos","events_url":"https://api.github.com/users/musnix/events{/privacy}","received_events_url":"https://api.github.com/users/musnix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musnix/musnix","description":"Real-time audio in NixOS","fork":false,"url":"https://api.github.com/repos/musnix/musnix","forks_url":"https://api.github.com/repos/musnix/musnix/forks","keys_url":"https://api.github.com/repos/musnix/musnix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musnix/musnix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musnix/musnix/teams","hooks_url":"https://api.github.com/repos/musnix/musnix/hooks","issue_events_url":"https://api.github.com/repos/musnix/musnix/issues/events{/number}","events_url":"https://api.github.com/repos/musnix/musnix/events","assignees_url":"https://api.github.com/repos/musnix/musnix/assignees{/user}","branches_url":"https://api.github.com/repos/musnix/musnix/branches{/branch}","tags_url":"https://api.github.com/repos/musnix/musnix/tags","blobs_url":"https://api.github.com/repos/musnix/musnix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musnix/musnix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musnix/musnix/git/refs{/sha}","trees_url":"https://api.github.com/repos/musnix/musnix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musnix/musnix/statuses/{sha}","languages_url":"https://api.github.com/repos/musnix/musnix/languages","stargazers_url":"https://api.github.com/repos/musnix/musnix/stargazers","contributors_url":"https://api.github.com/repos/musnix/musnix/contributors","subscribers_url":"https://api.github.com/repos/musnix/musnix/subscribers","subscription_url":"https://api.github.com/repos/musnix/musnix/subscription","commits_url":"https://api.github.com/repos/musnix/musnix/commits{/sha}","git_commits_url":"https://api.github.com/repos/musnix/musnix/git/commits{/sha}","comments_url":"https://api.github.com/repos/musnix/musnix/comments{/number}","issue_comment_url":"https://api.github.com/repos/musnix/musnix/issues/comments{/number}","contents_url":"https://api.github.com/repos/musnix/musnix/contents/{+path}","compare_url":"https://api.github.com/repos/musnix/musnix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musnix/musnix/merges","archive_url":"https://api.github.com/repos/musnix/musnix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musnix/musnix/downloads","issues_url":"https://api.github.com/repos/musnix/musnix/issues{/number}","pulls_url":"https://api.github.com/repos/musnix/musnix/pulls{/number}","milestones_url":"https://api.github.com/repos/musnix/musnix/milestones{/number}","notifications_url":"https://api.github.com/repos/musnix/musnix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musnix/musnix/labels{/name}","releases_url":"https://api.github.com/repos/musnix/musnix/releases{/id}","created_at":"2014-12-22T20:57:55Z","updated_at":"2015-06-15T19:07:12Z","pushed_at":"2015-07-10T03:27:19Z","git_url":"git://github.com/musnix/musnix.git","ssh_url":"git@github.com:musnix/musnix.git","clone_url":"https://github.com/musnix/musnix.git","svn_url":"https://github.com/musnix/musnix","homepage":"","size":548,"stargazers_count":10,"watchers_count":10,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":10,"default_branch":"master"}},"base":{"label":"musnix:master","ref":"master","sha":"4650e4cc1714694def1ce2d41d2e9e2f5330a54f","user":{"login":"musnix","id":10273760,"avatar_url":"https://avatars.githubusercontent.com/u/10273760?v=3","gravatar_id":"","url":"https://api.github.com/users/musnix","html_url":"https://github.com/musnix","followers_url":"https://api.github.com/users/musnix/followers","following_url":"https://api.github.com/users/musnix/following{/other_user}","gists_url":"https://api.github.com/users/musnix/gists{/gist_id}","starred_url":"https://api.github.com/users/musnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musnix/subscriptions","organizations_url":"https://api.github.com/users/musnix/orgs","repos_url":"https://api.github.com/users/musnix/repos","events_url":"https://api.github.com/users/musnix/events{/privacy}","received_events_url":"https://api.github.com/users/musnix/received_events","type":"Organization","site_admin":false},"repo":{"id":28358928,"name":"musnix","full_name":"musnix/musnix","owner":{"login":"musnix","id":10273760,"avatar_url":"https://avatars.githubusercontent.com/u/10273760?v=3","gravatar_id":"","url":"https://api.github.com/users/musnix","html_url":"https://github.com/musnix","followers_url":"https://api.github.com/users/musnix/followers","following_url":"https://api.github.com/users/musnix/following{/other_user}","gists_url":"https://api.github.com/users/musnix/gists{/gist_id}","starred_url":"https://api.github.com/users/musnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musnix/subscriptions","organizations_url":"https://api.github.com/users/musnix/orgs","repos_url":"https://api.github.com/users/musnix/repos","events_url":"https://api.github.com/users/musnix/events{/privacy}","received_events_url":"https://api.github.com/users/musnix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musnix/musnix","description":"Real-time audio in NixOS","fork":false,"url":"https://api.github.com/repos/musnix/musnix","forks_url":"https://api.github.com/repos/musnix/musnix/forks","keys_url":"https://api.github.com/repos/musnix/musnix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musnix/musnix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musnix/musnix/teams","hooks_url":"https://api.github.com/repos/musnix/musnix/hooks","issue_events_url":"https://api.github.com/repos/musnix/musnix/issues/events{/number}","events_url":"https://api.github.com/repos/musnix/musnix/events","assignees_url":"https://api.github.com/repos/musnix/musnix/assignees{/user}","branches_url":"https://api.github.com/repos/musnix/musnix/branches{/branch}","tags_url":"https://api.github.com/repos/musnix/musnix/tags","blobs_url":"https://api.github.com/repos/musnix/musnix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musnix/musnix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musnix/musnix/git/refs{/sha}","trees_url":"https://api.github.com/repos/musnix/musnix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musnix/musnix/statuses/{sha}","languages_url":"https://api.github.com/repos/musnix/musnix/languages","stargazers_url":"https://api.github.com/repos/musnix/musnix/stargazers","contributors_url":"https://api.github.com/repos/musnix/musnix/contributors","subscribers_url":"https://api.github.com/repos/musnix/musnix/subscribers","subscription_url":"https://api.github.com/repos/musnix/musnix/subscription","commits_url":"https://api.github.com/repos/musnix/musnix/commits{/sha}","git_commits_url":"https://api.github.com/repos/musnix/musnix/git/commits{/sha}","comments_url":"https://api.github.com/repos/musnix/musnix/comments{/number}","issue_comment_url":"https://api.github.com/repos/musnix/musnix/issues/comments{/number}","contents_url":"https://api.github.com/repos/musnix/musnix/contents/{+path}","compare_url":"https://api.github.com/repos/musnix/musnix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musnix/musnix/merges","archive_url":"https://api.github.com/repos/musnix/musnix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musnix/musnix/downloads","issues_url":"https://api.github.com/repos/musnix/musnix/issues{/number}","pulls_url":"https://api.github.com/repos/musnix/musnix/pulls{/number}","milestones_url":"https://api.github.com/repos/musnix/musnix/milestones{/number}","notifications_url":"https://api.github.com/repos/musnix/musnix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musnix/musnix/labels{/name}","releases_url":"https://api.github.com/repos/musnix/musnix/releases{/id}","created_at":"2014-12-22T20:57:55Z","updated_at":"2015-06-15T19:07:12Z","pushed_at":"2015-07-10T03:27:19Z","git_url":"git://github.com/musnix/musnix.git","ssh_url":"git@github.com:musnix/musnix.git","clone_url":"https://github.com/musnix/musnix.git","svn_url":"https://github.com/musnix/musnix","homepage":"","size":548,"stargazers_count":10,"watchers_count":10,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musnix/musnix/pulls/21"},"html":{"href":"https://github.com/musnix/musnix/pull/21"},"issue":{"href":"https://api.github.com/repos/musnix/musnix/issues/21"},"comments":{"href":"https://api.github.com/repos/musnix/musnix/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/musnix/musnix/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/musnix/musnix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musnix/musnix/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/musnix/musnix/statuses/9a6e89ade603254870fa58b3643ed601aac473cf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"henrytill","id":6430643,"avatar_url":"https://avatars.githubusercontent.com/u/6430643?v=3","gravatar_id":"","url":"https://api.github.com/users/henrytill","html_url":"https://github.com/henrytill","followers_url":"https://api.github.com/users/henrytill/followers","following_url":"https://api.github.com/users/henrytill/following{/other_user}","gists_url":"https://api.github.com/users/henrytill/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytill/subscriptions","organizations_url":"https://api.github.com/users/henrytill/orgs","repos_url":"https://api.github.com/users/henrytill/repos","events_url":"https://api.github.com/users/henrytill/events{/privacy}","received_events_url":"https://api.github.com/users/henrytill/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":166,"deletions":41,"changed_files":6}}