{"action":"created","comment":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments/35710103","id":35710103,"diff_hunk":"@@ -249,8 +261,7 @@ def make_E(self):\n             ('Label' , self.label)]\n         \n         # Plot\n-        n1 = len(E.base_field().embeddings(RR))\n-        if(n1):\n+        if(E.base_field().signature()[0]):","path":"lmfdb/ecnf/WebEllipticCurve.py","position":null,"original_position":51,"commit_id":"d0f78ee4b15963c951a3793f01c277278f01b94b","original_commit_id":"c394652a36b2a0cdcd1de04dc07cdd923b6ae241","user":{"login":"nmascot","id":7770236,"avatar_url":"https://avatars.githubusercontent.com/u/7770236?v=3","gravatar_id":"","url":"https://api.github.com/users/nmascot","html_url":"https://github.com/nmascot","followers_url":"https://api.github.com/users/nmascot/followers","following_url":"https://api.github.com/users/nmascot/following{/other_user}","gists_url":"https://api.github.com/users/nmascot/gists{/gist_id}","starred_url":"https://api.github.com/users/nmascot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmascot/subscriptions","organizations_url":"https://api.github.com/users/nmascot/orgs","repos_url":"https://api.github.com/users/nmascot/repos","events_url":"https://api.github.com/users/nmascot/events{/privacy}","received_events_url":"https://api.github.com/users/nmascot/received_events","type":"User","site_admin":false},"body":"FIxed :) Now guess which is the programming language I learnt when I was in high school...","created_at":"2015-07-28T22:37:57Z","updated_at":"2015-07-28T22:37:57Z","html_url":"https://github.com/LMFDB/lmfdb/pull/263#discussion_r35710103","pull_request_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263","_links":{"self":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments/35710103"},"html":{"href":"https://github.com/LMFDB/lmfdb/pull/263#discussion_r35710103"},"pull_request":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263","id":41067812,"html_url":"https://github.com/LMFDB/lmfdb/pull/263","diff_url":"https://github.com/LMFDB/lmfdb/pull/263.diff","patch_url":"https://github.com/LMFDB/lmfdb/pull/263.patch","issue_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/263","number":263,"state":"open","locked":false,"title":"Strudiness improvement","user":{"login":"nmascot","id":7770236,"avatar_url":"https://avatars.githubusercontent.com/u/7770236?v=3","gravatar_id":"","url":"https://api.github.com/users/nmascot","html_url":"https://github.com/nmascot","followers_url":"https://api.github.com/users/nmascot/followers","following_url":"https://api.github.com/users/nmascot/following{/other_user}","gists_url":"https://api.github.com/users/nmascot/gists{/gist_id}","starred_url":"https://api.github.com/users/nmascot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmascot/subscriptions","organizations_url":"https://api.github.com/users/nmascot/orgs","repos_url":"https://api.github.com/users/nmascot/repos","events_url":"https://api.github.com/users/nmascot/events{/privacy}","received_events_url":"https://api.github.com/users/nmascot/received_events","type":"User","site_admin":false},"body":"Made the plotting code resistant to the case where the curve is almost singular under some real embedding. This could lead to Sage believing that the curve is indeed singular, thus preventing the page from being displayed.","created_at":"2015-07-28T22:21:19Z","updated_at":"2015-07-28T22:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26df84236b19948e2dbe8c91b3c8a75c95c05d49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263/commits","review_comments_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263/comments","review_comment_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/263/comments","statuses_url":"https://api.github.com/repos/LMFDB/lmfdb/statuses/d0f78ee4b15963c951a3793f01c277278f01b94b","head":{"label":"nmascot:ecnfplot","ref":"ecnfplot","sha":"d0f78ee4b15963c951a3793f01c277278f01b94b","user":{"login":"nmascot","id":7770236,"avatar_url":"https://avatars.githubusercontent.com/u/7770236?v=3","gravatar_id":"","url":"https://api.github.com/users/nmascot","html_url":"https://github.com/nmascot","followers_url":"https://api.github.com/users/nmascot/followers","following_url":"https://api.github.com/users/nmascot/following{/other_user}","gists_url":"https://api.github.com/users/nmascot/gists{/gist_id}","starred_url":"https://api.github.com/users/nmascot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmascot/subscriptions","organizations_url":"https://api.github.com/users/nmascot/orgs","repos_url":"https://api.github.com/users/nmascot/repos","events_url":"https://api.github.com/users/nmascot/events{/privacy}","received_events_url":"https://api.github.com/users/nmascot/received_events","type":"User","site_admin":false},"repo":{"id":20410249,"name":"lmfdb","full_name":"nmascot/lmfdb","owner":{"login":"nmascot","id":7770236,"avatar_url":"https://avatars.githubusercontent.com/u/7770236?v=3","gravatar_id":"","url":"https://api.github.com/users/nmascot","html_url":"https://github.com/nmascot","followers_url":"https://api.github.com/users/nmascot/followers","following_url":"https://api.github.com/users/nmascot/following{/other_user}","gists_url":"https://api.github.com/users/nmascot/gists{/gist_id}","starred_url":"https://api.github.com/users/nmascot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmascot/subscriptions","organizations_url":"https://api.github.com/users/nmascot/orgs","repos_url":"https://api.github.com/users/nmascot/repos","events_url":"https://api.github.com/users/nmascot/events{/privacy}","received_events_url":"https://api.github.com/users/nmascot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmascot/lmfdb","description":"L-Functions and Modular Forms Database","fork":true,"url":"https://api.github.com/repos/nmascot/lmfdb","forks_url":"https://api.github.com/repos/nmascot/lmfdb/forks","keys_url":"https://api.github.com/repos/nmascot/lmfdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmascot/lmfdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmascot/lmfdb/teams","hooks_url":"https://api.github.com/repos/nmascot/lmfdb/hooks","issue_events_url":"https://api.github.com/repos/nmascot/lmfdb/issues/events{/number}","events_url":"https://api.github.com/repos/nmascot/lmfdb/events","assignees_url":"https://api.github.com/repos/nmascot/lmfdb/assignees{/user}","branches_url":"https://api.github.com/repos/nmascot/lmfdb/branches{/branch}","tags_url":"https://api.github.com/repos/nmascot/lmfdb/tags","blobs_url":"https://api.github.com/repos/nmascot/lmfdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmascot/lmfdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmascot/lmfdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmascot/lmfdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmascot/lmfdb/statuses/{sha}","languages_url":"https://api.github.com/repos/nmascot/lmfdb/languages","stargazers_url":"https://api.github.com/repos/nmascot/lmfdb/stargazers","contributors_url":"https://api.github.com/repos/nmascot/lmfdb/contributors","subscribers_url":"https://api.github.com/repos/nmascot/lmfdb/subscribers","subscription_url":"https://api.github.com/repos/nmascot/lmfdb/subscription","commits_url":"https://api.github.com/repos/nmascot/lmfdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmascot/lmfdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmascot/lmfdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmascot/lmfdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmascot/lmfdb/contents/{+path}","compare_url":"https://api.github.com/repos/nmascot/lmfdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmascot/lmfdb/merges","archive_url":"https://api.github.com/repos/nmascot/lmfdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmascot/lmfdb/downloads","issues_url":"https://api.github.com/repos/nmascot/lmfdb/issues{/number}","pulls_url":"https://api.github.com/repos/nmascot/lmfdb/pulls{/number}","milestones_url":"https://api.github.com/repos/nmascot/lmfdb/milestones{/number}","notifications_url":"https://api.github.com/repos/nmascot/lmfdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmascot/lmfdb/labels{/name}","releases_url":"https://api.github.com/repos/nmascot/lmfdb/releases{/id}","created_at":"2014-06-02T16:05:55Z","updated_at":"2015-06-15T20:02:28Z","pushed_at":"2015-07-28T22:36:37Z","git_url":"git://github.com/nmascot/lmfdb.git","ssh_url":"git@github.com:nmascot/lmfdb.git","clone_url":"https://github.com/nmascot/lmfdb.git","svn_url":"https://github.com/nmascot/lmfdb","homepage":null,"size":14064,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LMFDB:master","ref":"master","sha":"4ffbd18c3b6970a3bcdefb86d53c5bea27c19b1d","user":{"login":"LMFDB","id":3043016,"avatar_url":"https://avatars.githubusercontent.com/u/3043016?v=3","gravatar_id":"","url":"https://api.github.com/users/LMFDB","html_url":"https://github.com/LMFDB","followers_url":"https://api.github.com/users/LMFDB/followers","following_url":"https://api.github.com/users/LMFDB/following{/other_user}","gists_url":"https://api.github.com/users/LMFDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMFDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMFDB/subscriptions","organizations_url":"https://api.github.com/users/LMFDB/orgs","repos_url":"https://api.github.com/users/LMFDB/repos","events_url":"https://api.github.com/users/LMFDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMFDB/received_events","type":"Organization","site_admin":false},"repo":{"id":7166369,"name":"lmfdb","full_name":"LMFDB/lmfdb","owner":{"login":"LMFDB","id":3043016,"avatar_url":"https://avatars.githubusercontent.com/u/3043016?v=3","gravatar_id":"","url":"https://api.github.com/users/LMFDB","html_url":"https://github.com/LMFDB","followers_url":"https://api.github.com/users/LMFDB/followers","following_url":"https://api.github.com/users/LMFDB/following{/other_user}","gists_url":"https://api.github.com/users/LMFDB/gists{/gist_id}","starred_url":"https://api.github.com/users/LMFDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMFDB/subscriptions","organizations_url":"https://api.github.com/users/LMFDB/orgs","repos_url":"https://api.github.com/users/LMFDB/repos","events_url":"https://api.github.com/users/LMFDB/events{/privacy}","received_events_url":"https://api.github.com/users/LMFDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMFDB/lmfdb","description":"L-Functions and Modular Forms Database","fork":false,"url":"https://api.github.com/repos/LMFDB/lmfdb","forks_url":"https://api.github.com/repos/LMFDB/lmfdb/forks","keys_url":"https://api.github.com/repos/LMFDB/lmfdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMFDB/lmfdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMFDB/lmfdb/teams","hooks_url":"https://api.github.com/repos/LMFDB/lmfdb/hooks","issue_events_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/events{/number}","events_url":"https://api.github.com/repos/LMFDB/lmfdb/events","assignees_url":"https://api.github.com/repos/LMFDB/lmfdb/assignees{/user}","branches_url":"https://api.github.com/repos/LMFDB/lmfdb/branches{/branch}","tags_url":"https://api.github.com/repos/LMFDB/lmfdb/tags","blobs_url":"https://api.github.com/repos/LMFDB/lmfdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMFDB/lmfdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMFDB/lmfdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMFDB/lmfdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMFDB/lmfdb/statuses/{sha}","languages_url":"https://api.github.com/repos/LMFDB/lmfdb/languages","stargazers_url":"https://api.github.com/repos/LMFDB/lmfdb/stargazers","contributors_url":"https://api.github.com/repos/LMFDB/lmfdb/contributors","subscribers_url":"https://api.github.com/repos/LMFDB/lmfdb/subscribers","subscription_url":"https://api.github.com/repos/LMFDB/lmfdb/subscription","commits_url":"https://api.github.com/repos/LMFDB/lmfdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMFDB/lmfdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMFDB/lmfdb/contents/{+path}","compare_url":"https://api.github.com/repos/LMFDB/lmfdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMFDB/lmfdb/merges","archive_url":"https://api.github.com/repos/LMFDB/lmfdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMFDB/lmfdb/downloads","issues_url":"https://api.github.com/repos/LMFDB/lmfdb/issues{/number}","pulls_url":"https://api.github.com/repos/LMFDB/lmfdb/pulls{/number}","milestones_url":"https://api.github.com/repos/LMFDB/lmfdb/milestones{/number}","notifications_url":"https://api.github.com/repos/LMFDB/lmfdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMFDB/lmfdb/labels{/name}","releases_url":"https://api.github.com/repos/LMFDB/lmfdb/releases{/id}","created_at":"2012-12-14T14:09:00Z","updated_at":"2015-07-28T17:07:49Z","pushed_at":"2015-07-28T22:37:20Z","git_url":"git://github.com/LMFDB/lmfdb.git","ssh_url":"git@github.com:LMFDB/lmfdb.git","clone_url":"https://github.com/LMFDB/lmfdb.git","svn_url":"https://github.com/LMFDB/lmfdb","homepage":null,"size":16298,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":41,"forks":56,"open_issues":41,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263"},"html":{"href":"https://github.com/LMFDB/lmfdb/pull/263"},"issue":{"href":"https://api.github.com/repos/LMFDB/lmfdb/issues/263"},"comments":{"href":"https://api.github.com/repos/LMFDB/lmfdb/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMFDB/lmfdb/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/LMFDB/lmfdb/statuses/d0f78ee4b15963c951a3793f01c277278f01b94b"}}}}