{"action":"created","comment":{"url":"https://api.github.com/repos/addthis/stream-lib/pulls/comments/25290668","id":25290668,"diff_hunk":"@@ -64,6 +64,13 @@\n \n     public static final int[] EMPTY_SPARSE = new int[0];\n \n+    private static final int INITIAL_TEMP_SET_CAPACITY = 64;","path":"src/main/java/com/clearspring/analytics/stream/cardinality/HyperLogLogPlus.java","position":4,"original_position":4,"commit_id":"0e4ecd89b72b301fb855981268b1e7d81af7d349","original_commit_id":"0e4ecd89b72b301fb855981268b1e7d81af7d349","user":{"login":"tea-dragon","id":2219887,"avatar_url":"https://avatars.githubusercontent.com/u/2219887?v=3","gravatar_id":"","url":"https://api.github.com/users/tea-dragon","html_url":"https://github.com/tea-dragon","followers_url":"https://api.github.com/users/tea-dragon/followers","following_url":"https://api.github.com/users/tea-dragon/following{/other_user}","gists_url":"https://api.github.com/users/tea-dragon/gists{/gist_id}","starred_url":"https://api.github.com/users/tea-dragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tea-dragon/subscriptions","organizations_url":"https://api.github.com/users/tea-dragon/orgs","repos_url":"https://api.github.com/users/tea-dragon/repos","events_url":"https://api.github.com/users/tea-dragon/events{/privacy}","received_events_url":"https://api.github.com/users/tea-dragon/received_events","type":"User","site_admin":false},"body":"think this should probably be lower. maybe 8 or even 4.","created_at":"2015-02-24T20:45:42Z","updated_at":"2015-02-24T20:45:42Z","html_url":"https://github.com/addthis/stream-lib/pull/87#discussion_r25290668","pull_request_url":"https://api.github.com/repos/addthis/stream-lib/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/comments/25290668"},"html":{"href":"https://github.com/addthis/stream-lib/pull/87#discussion_r25290668"},"pull_request":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/addthis/stream-lib/pulls/87","id":29916558,"html_url":"https://github.com/addthis/stream-lib/pull/87","diff_url":"https://github.com/addthis/stream-lib/pull/87.diff","patch_url":"https://github.com/addthis/stream-lib/pull/87.patch","issue_url":"https://api.github.com/repos/addthis/stream-lib/issues/87","number":87,"state":"open","locked":false,"title":"Improve heap usage of low cardinality hllp counters.","user":{"login":"mspiegel","id":11677,"avatar_url":"https://avatars.githubusercontent.com/u/11677?v=3","gravatar_id":"","url":"https://api.github.com/users/mspiegel","html_url":"https://github.com/mspiegel","followers_url":"https://api.github.com/users/mspiegel/followers","following_url":"https://api.github.com/users/mspiegel/following{/other_user}","gists_url":"https://api.github.com/users/mspiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/mspiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspiegel/subscriptions","organizations_url":"https://api.github.com/users/mspiegel/orgs","repos_url":"https://api.github.com/users/mspiegel/repos","events_url":"https://api.github.com/users/mspiegel/events{/privacy}","received_events_url":"https://api.github.com/users/mspiegel/received_events","type":"User","site_admin":false},"body":"Low cardinality hllp counters should have a temp set\r\nsize that is proportional to the current sparse set\r\nsize. The previous implementation had a temp set size\r\nthat was proportional to the maximum sparse set size.\r\nRef T53112.","created_at":"2015-02-24T17:14:08Z","updated_at":"2015-02-24T20:45:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28d7bbc9cdc0bb5fcea462418f3f0e7ad6c81245","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/addthis/stream-lib/pulls/87/commits","review_comments_url":"https://api.github.com/repos/addthis/stream-lib/pulls/87/comments","review_comment_url":"https://api.github.com/repos/addthis/stream-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/addthis/stream-lib/issues/87/comments","statuses_url":"https://api.github.com/repos/addthis/stream-lib/statuses/0e4ecd89b72b301fb855981268b1e7d81af7d349","head":{"label":"addthis:spiegel/hllp-low-cardinality-mem-usage","ref":"spiegel/hllp-low-cardinality-mem-usage","sha":"0e4ecd89b72b301fb855981268b1e7d81af7d349","user":{"login":"addthis","id":2325903,"avatar_url":"https://avatars.githubusercontent.com/u/2325903?v=3","gravatar_id":"","url":"https://api.github.com/users/addthis","html_url":"https://github.com/addthis","followers_url":"https://api.github.com/users/addthis/followers","following_url":"https://api.github.com/users/addthis/following{/other_user}","gists_url":"https://api.github.com/users/addthis/gists{/gist_id}","starred_url":"https://api.github.com/users/addthis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addthis/subscriptions","organizations_url":"https://api.github.com/users/addthis/orgs","repos_url":"https://api.github.com/users/addthis/repos","events_url":"https://api.github.com/users/addthis/events{/privacy}","received_events_url":"https://api.github.com/users/addthis/received_events","type":"Organization","site_admin":false},"repo":{"id":1483979,"name":"stream-lib","full_name":"addthis/stream-lib","owner":{"login":"addthis","id":2325903,"avatar_url":"https://avatars.githubusercontent.com/u/2325903?v=3","gravatar_id":"","url":"https://api.github.com/users/addthis","html_url":"https://github.com/addthis","followers_url":"https://api.github.com/users/addthis/followers","following_url":"https://api.github.com/users/addthis/following{/other_user}","gists_url":"https://api.github.com/users/addthis/gists{/gist_id}","starred_url":"https://api.github.com/users/addthis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addthis/subscriptions","organizations_url":"https://api.github.com/users/addthis/orgs","repos_url":"https://api.github.com/users/addthis/repos","events_url":"https://api.github.com/users/addthis/events{/privacy}","received_events_url":"https://api.github.com/users/addthis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/addthis/stream-lib","description":"Stream summarizer and cardinality estimator.","fork":false,"url":"https://api.github.com/repos/addthis/stream-lib","forks_url":"https://api.github.com/repos/addthis/stream-lib/forks","keys_url":"https://api.github.com/repos/addthis/stream-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addthis/stream-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addthis/stream-lib/teams","hooks_url":"https://api.github.com/repos/addthis/stream-lib/hooks","issue_events_url":"https://api.github.com/repos/addthis/stream-lib/issues/events{/number}","events_url":"https://api.github.com/repos/addthis/stream-lib/events","assignees_url":"https://api.github.com/repos/addthis/stream-lib/assignees{/user}","branches_url":"https://api.github.com/repos/addthis/stream-lib/branches{/branch}","tags_url":"https://api.github.com/repos/addthis/stream-lib/tags","blobs_url":"https://api.github.com/repos/addthis/stream-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addthis/stream-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addthis/stream-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/addthis/stream-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addthis/stream-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/addthis/stream-lib/languages","stargazers_url":"https://api.github.com/repos/addthis/stream-lib/stargazers","contributors_url":"https://api.github.com/repos/addthis/stream-lib/contributors","subscribers_url":"https://api.github.com/repos/addthis/stream-lib/subscribers","subscription_url":"https://api.github.com/repos/addthis/stream-lib/subscription","commits_url":"https://api.github.com/repos/addthis/stream-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/addthis/stream-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/addthis/stream-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/addthis/stream-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/addthis/stream-lib/contents/{+path}","compare_url":"https://api.github.com/repos/addthis/stream-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addthis/stream-lib/merges","archive_url":"https://api.github.com/repos/addthis/stream-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addthis/stream-lib/downloads","issues_url":"https://api.github.com/repos/addthis/stream-lib/issues{/number}","pulls_url":"https://api.github.com/repos/addthis/stream-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/addthis/stream-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/addthis/stream-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addthis/stream-lib/labels{/name}","releases_url":"https://api.github.com/repos/addthis/stream-lib/releases{/id}","created_at":"2011-03-15T18:41:27Z","updated_at":"2015-02-24T06:01:04Z","pushed_at":"2015-02-24T17:13:30Z","git_url":"git://github.com/addthis/stream-lib.git","ssh_url":"git@github.com:addthis/stream-lib.git","clone_url":"https://github.com/addthis/stream-lib.git","svn_url":"https://github.com/addthis/stream-lib","homepage":"","size":2974,"stargazers_count":1047,"watchers_count":1047,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":8,"forks":259,"open_issues":8,"watchers":1047,"default_branch":"master"}},"base":{"label":"addthis:master","ref":"master","sha":"1cae6828e8e7d3e6be5428e42fa9e088fc8c6b1a","user":{"login":"addthis","id":2325903,"avatar_url":"https://avatars.githubusercontent.com/u/2325903?v=3","gravatar_id":"","url":"https://api.github.com/users/addthis","html_url":"https://github.com/addthis","followers_url":"https://api.github.com/users/addthis/followers","following_url":"https://api.github.com/users/addthis/following{/other_user}","gists_url":"https://api.github.com/users/addthis/gists{/gist_id}","starred_url":"https://api.github.com/users/addthis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addthis/subscriptions","organizations_url":"https://api.github.com/users/addthis/orgs","repos_url":"https://api.github.com/users/addthis/repos","events_url":"https://api.github.com/users/addthis/events{/privacy}","received_events_url":"https://api.github.com/users/addthis/received_events","type":"Organization","site_admin":false},"repo":{"id":1483979,"name":"stream-lib","full_name":"addthis/stream-lib","owner":{"login":"addthis","id":2325903,"avatar_url":"https://avatars.githubusercontent.com/u/2325903?v=3","gravatar_id":"","url":"https://api.github.com/users/addthis","html_url":"https://github.com/addthis","followers_url":"https://api.github.com/users/addthis/followers","following_url":"https://api.github.com/users/addthis/following{/other_user}","gists_url":"https://api.github.com/users/addthis/gists{/gist_id}","starred_url":"https://api.github.com/users/addthis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addthis/subscriptions","organizations_url":"https://api.github.com/users/addthis/orgs","repos_url":"https://api.github.com/users/addthis/repos","events_url":"https://api.github.com/users/addthis/events{/privacy}","received_events_url":"https://api.github.com/users/addthis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/addthis/stream-lib","description":"Stream summarizer and cardinality estimator.","fork":false,"url":"https://api.github.com/repos/addthis/stream-lib","forks_url":"https://api.github.com/repos/addthis/stream-lib/forks","keys_url":"https://api.github.com/repos/addthis/stream-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addthis/stream-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addthis/stream-lib/teams","hooks_url":"https://api.github.com/repos/addthis/stream-lib/hooks","issue_events_url":"https://api.github.com/repos/addthis/stream-lib/issues/events{/number}","events_url":"https://api.github.com/repos/addthis/stream-lib/events","assignees_url":"https://api.github.com/repos/addthis/stream-lib/assignees{/user}","branches_url":"https://api.github.com/repos/addthis/stream-lib/branches{/branch}","tags_url":"https://api.github.com/repos/addthis/stream-lib/tags","blobs_url":"https://api.github.com/repos/addthis/stream-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addthis/stream-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addthis/stream-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/addthis/stream-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addthis/stream-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/addthis/stream-lib/languages","stargazers_url":"https://api.github.com/repos/addthis/stream-lib/stargazers","contributors_url":"https://api.github.com/repos/addthis/stream-lib/contributors","subscribers_url":"https://api.github.com/repos/addthis/stream-lib/subscribers","subscription_url":"https://api.github.com/repos/addthis/stream-lib/subscription","commits_url":"https://api.github.com/repos/addthis/stream-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/addthis/stream-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/addthis/stream-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/addthis/stream-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/addthis/stream-lib/contents/{+path}","compare_url":"https://api.github.com/repos/addthis/stream-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addthis/stream-lib/merges","archive_url":"https://api.github.com/repos/addthis/stream-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addthis/stream-lib/downloads","issues_url":"https://api.github.com/repos/addthis/stream-lib/issues{/number}","pulls_url":"https://api.github.com/repos/addthis/stream-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/addthis/stream-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/addthis/stream-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addthis/stream-lib/labels{/name}","releases_url":"https://api.github.com/repos/addthis/stream-lib/releases{/id}","created_at":"2011-03-15T18:41:27Z","updated_at":"2015-02-24T06:01:04Z","pushed_at":"2015-02-24T17:13:30Z","git_url":"git://github.com/addthis/stream-lib.git","ssh_url":"git@github.com:addthis/stream-lib.git","clone_url":"https://github.com/addthis/stream-lib.git","svn_url":"https://github.com/addthis/stream-lib","homepage":"","size":2974,"stargazers_count":1047,"watchers_count":1047,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":8,"forks":259,"open_issues":8,"watchers":1047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/87"},"html":{"href":"https://github.com/addthis/stream-lib/pull/87"},"issue":{"href":"https://api.github.com/repos/addthis/stream-lib/issues/87"},"comments":{"href":"https://api.github.com/repos/addthis/stream-lib/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/addthis/stream-lib/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/addthis/stream-lib/statuses/0e4ecd89b72b301fb855981268b1e7d81af7d349"}}}}