{"action":"created","issue":{"url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/60","labels_url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/60/comments","events_url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/60/events","html_url":"https://github.com/rsnapshot/rsnapshot/issues/60","id":63571339,"number":60,"title":"More ideas for tests","user":{"login":"kevinlyles","id":424797,"avatar_url":"https://avatars.githubusercontent.com/u/424797?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinlyles","html_url":"https://github.com/kevinlyles","followers_url":"https://api.github.com/users/kevinlyles/followers","following_url":"https://api.github.com/users/kevinlyles/following{/other_user}","gists_url":"https://api.github.com/users/kevinlyles/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinlyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinlyles/subscriptions","organizations_url":"https://api.github.com/users/kevinlyles/orgs","repos_url":"https://api.github.com/users/kevinlyles/repos","events_url":"https://api.github.com/users/kevinlyles/events{/privacy}","received_events_url":"https://api.github.com/users/kevinlyles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rsnapshot/rsnapshot/labels/task","name":"task","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/rsnapshot/rsnapshot/milestones/2","html_url":"https://github.com/rsnapshot/rsnapshot/milestones/rsnapshot%201.4","labels_url":"https://api.github.com/repos/rsnapshot/rsnapshot/milestones/2/labels","id":1028925,"number":2,"title":"rsnapshot 1.4","description":"create new release 1.4","creator":{"login":"bebehei","id":2073458,"avatar_url":"https://avatars.githubusercontent.com/u/2073458?v=3","gravatar_id":"","url":"https://api.github.com/users/bebehei","html_url":"https://github.com/bebehei","followers_url":"https://api.github.com/users/bebehei/followers","following_url":"https://api.github.com/users/bebehei/following{/other_user}","gists_url":"https://api.github.com/users/bebehei/gists{/gist_id}","starred_url":"https://api.github.com/users/bebehei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bebehei/subscriptions","organizations_url":"https://api.github.com/users/bebehei/orgs","repos_url":"https://api.github.com/users/bebehei/repos","events_url":"https://api.github.com/users/bebehei/events{/privacy}","received_events_url":"https://api.github.com/users/bebehei/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":9,"state":"open","created_at":"2015-03-19T10:50:10Z","updated_at":"2015-03-25T13:48:19Z","due_on":"2015-06-14T22:00:00Z","closed_at":null},"comments":10,"created_at":"2015-03-22T20:24:28Z","updated_at":"2015-03-26T01:43:52Z","closed_at":null,"body":"* file local vs absolute/link/directory traversal checks for:\r\n\t* -c?\r\n\t* include_conf (with args?)\r\n\t* cmd_rsync (no args)\r\n\t* cmd_ssh (no args)\r\n\t* cmd_cp (no args)\r\n\t* cmd_rm (no args)\r\n\t* cmd_logger (with args?)\r\n\t* cmd_du (no args)\r\n\t* cmd_rsnapshot_diff (no args)\r\n\t* cmd_preexec (with args?)\r\n\t* cmd_postexec (with args?)\r\n\t* linux_lvm_cmd_lvcreate (no args, backup level too)\r\n\t* linux_lvm_cmd_lvremove (no args, backup level too)\r\n\t* linux_lvm_cmd_mount (no args, backup level too)\r\n\t* linux_lvm_cmd_umount (no args, backup level too)\r\n\t* logfile\r\n\t* include_file (backup level too?)\r\n\t* exclude_file (backup level too?)\r\n\t* backup\r\n\t* backup_script\r\n* Mixing retain and interval\r\n* Mixing log methods\r\n* Check command line options:\r\n\t* -t: verify that no changes are made for a series of commands\r\n\t* -c: probably covered by all of the other tests\r\n\t* -x: specify a custom \"rsync\" and check for -x with it\r\n\t* -v, -q, -V, -D: unsure\r\n\t* Check multiple retains\r\n* Test lockfiles hanging around (on every test?)\r\n"},"comment":{"url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/comments/86289295","html_url":"https://github.com/rsnapshot/rsnapshot/issues/60#issuecomment-86289295","issue_url":"https://api.github.com/repos/rsnapshot/rsnapshot/issues/60","id":86289295,"user":{"login":"sam-at-github","id":3386865,"avatar_url":"https://avatars.githubusercontent.com/u/3386865?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-at-github","html_url":"https://github.com/sam-at-github","followers_url":"https://api.github.com/users/sam-at-github/followers","following_url":"https://api.github.com/users/sam-at-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-at-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-at-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-at-github/subscriptions","organizations_url":"https://api.github.com/users/sam-at-github/orgs","repos_url":"https://api.github.com/users/sam-at-github/repos","events_url":"https://api.github.com/users/sam-at-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-at-github/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T01:43:51Z","updated_at":"2015-03-26T01:43:51Z","body":"> That report will go away the next time I make a change to my website - is there somewhere better to put things like this? Note that while Coveralls.io is awesome ..\r\n\r\nIn the README.md like these?: https://github.com/markdalgleish/gulp-coveralls, https://github.com/kt3k/coveralls-gradle-plugin\r\n\r\n> Additionally, to write a test has to be done with small effort.\r\n\r\n:+1: yep.\r\n\r\nNot in favor of modulularizing, too much effort for no gain. I'm OK with the current setup. Just need some minor restructuring, an maybe some guidelines to follow for new tests."}}