{"action":"created","issue":{"url":"https://api.github.com/repos/kingd/looper/issues/6","labels_url":"https://api.github.com/repos/kingd/looper/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/kingd/looper/issues/6/comments","events_url":"https://api.github.com/repos/kingd/looper/issues/6/events","html_url":"https://github.com/kingd/looper/issues/6","id":36030912,"number":6,"title":"error on launching plugin in RB2.99+ & 3.0","user":{"login":"fossfreedom","id":996240,"avatar_url":"https://avatars.githubusercontent.com/u/996240?v=3","gravatar_id":"","url":"https://api.github.com/users/fossfreedom","html_url":"https://github.com/fossfreedom","followers_url":"https://api.github.com/users/fossfreedom/followers","following_url":"https://api.github.com/users/fossfreedom/following{/other_user}","gists_url":"https://api.github.com/users/fossfreedom/gists{/gist_id}","starred_url":"https://api.github.com/users/fossfreedom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossfreedom/subscriptions","organizations_url":"https://api.github.com/users/fossfreedom/orgs","repos_url":"https://api.github.com/users/fossfreedom/repos","events_url":"https://api.github.com/users/fossfreedom/events{/privacy}","received_events_url":"https://api.github.com/users/fossfreedom/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-06-18T21:47:36Z","updated_at":"2015-01-07T09:42:25Z","closed_at":"2015-01-07T09:42:25Z","body":"The new checkbox is causing an issue\r\n\r\n<pre>\r\nTraceback (most recent call last):\r\n  File \"/home/dad/.local/share/rhythmbox/plugins/looper/looper.py\", line 92, in do_activate\r\n    self.create_widgets()\r\n  File \"/home/dad/.local/share/rhythmbox/plugins/looper/looper.py\", line 130, in create_widgets\r\n    self.button.set_related_action(self.action.action)\r\nTypeError: argument action: Expected Gtk.Action, but got gi.repository.Gio.SimpleAction\r\n</pre>\r\n\r\nthe attempt to assign the action to the button does not work because it is a Gio.SimpleAction not a Gtk.Action - in RB2.99 and later, menus use the latter object type.  In RB2.98 and earlier, Gtk.Action is used - hence why you could do a button.set_related_action(action) before but you cannot now.\r\n\r\nI would recommend that you use a button instead\r\n\r\n        self.button = Gtk.Button.new_with_label('Close')\r\n        #self.button.set_related_action(self.action.action)\r\n        self.button.connect('clicked', self.on_button_clicked)\r\n\r\n        def on_button_clicked(self, *args):\r\n            self.action.activate()\r\n\r\nMove this to the end of the hbox\r\n\r\nI was going to do a pull request but I came across the following issue as well.\r\n\r\nIf you click the \"Always show Looper GUI\" in the preferences you have the following issue...\r\n\r\n1. the Toggle menu option just toggles on-off but the GUI stays - a bit confusing.\r\n\r\n2. the proposed close button is visible but clicking it nothing happens because the GUI remains always visible.\r\n\r\nMaybe the better option would be to change \"Always show Looper GUI\" to actually be \"Show Looper on start of rhythmbox\" - thus start with looper on by default - but you can turn it off via the close button.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kingd/looper/issues/comments/68998945","html_url":"https://github.com/kingd/looper/issues/6#issuecomment-68998945","issue_url":"https://api.github.com/repos/kingd/looper/issues/6","id":68998945,"user":{"login":"kingd","id":6278599,"avatar_url":"https://avatars.githubusercontent.com/u/6278599?v=3","gravatar_id":"","url":"https://api.github.com/users/kingd","html_url":"https://github.com/kingd","followers_url":"https://api.github.com/users/kingd/followers","following_url":"https://api.github.com/users/kingd/following{/other_user}","gists_url":"https://api.github.com/users/kingd/gists{/gist_id}","starred_url":"https://api.github.com/users/kingd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingd/subscriptions","organizations_url":"https://api.github.com/users/kingd/orgs","repos_url":"https://api.github.com/users/kingd/repos","events_url":"https://api.github.com/users/kingd/events{/privacy}","received_events_url":"https://api.github.com/users/kingd/received_events","type":"User","site_admin":false},"created_at":"2015-01-07T09:42:25Z","updated_at":"2015-01-07T09:42:25Z","body":"Activation button should now be available in RB3"}}