{"action":"created","issue":{"url":"https://api.github.com/repos/spree/spree/issues/6520","labels_url":"https://api.github.com/repos/spree/spree/issues/6520/labels{/name}","comments_url":"https://api.github.com/repos/spree/spree/issues/6520/comments","events_url":"https://api.github.com/repos/spree/spree/issues/6520/events","html_url":"https://github.com/spree/spree/pull/6520","id":90430015,"number":6520,"title":"Only run PromotionHandler::Coupon eligible line items","user":{"login":"SebAshton","id":881759,"avatar_url":"https://avatars.githubusercontent.com/u/881759?v=3","gravatar_id":"","url":"https://api.github.com/users/SebAshton","html_url":"https://github.com/SebAshton","followers_url":"https://api.github.com/users/SebAshton/followers","following_url":"https://api.github.com/users/SebAshton/following{/other_user}","gists_url":"https://api.github.com/users/SebAshton/gists{/gist_id}","starred_url":"https://api.github.com/users/SebAshton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebAshton/subscriptions","organizations_url":"https://api.github.com/users/SebAshton/orgs","repos_url":"https://api.github.com/users/SebAshton/repos","events_url":"https://api.github.com/users/SebAshton/events{/privacy}","received_events_url":"https://api.github.com/users/SebAshton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-23T16:17:08Z","updated_at":"2015-06-23T21:29:52Z","closed_at":"2015-06-23T21:29:52Z","pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/6520","html_url":"https://github.com/spree/spree/pull/6520","diff_url":"https://github.com/spree/spree/pull/6520.diff","patch_url":"https://github.com/spree/spree/pull/6520.patch"},"body":"This line in the Coupon PromotionHandler\r\n`order.line_item_adjustments.promotion.detect` ([link](https://github.com/spree/spree/blob/2-4-stable/core/app/models/spree/promotion_handler/coupon.rb#L89))\r\n\r\nWill only get run against the first line item. If that line item is not marked promotionable, then the `#determine_promotion_application_result` incorrectly returns an error message, even though the coupon has in fact been successfully applied to the other eligible line items.\r\n\r\nThis is fixed in 3-0-stable through use of the new all_adjustment scope, but persists in 2-2-stable, 2-3-stable, and 2-4-stable"},"comment":{"url":"https://api.github.com/repos/spree/spree/issues/comments/114647405","html_url":"https://github.com/spree/spree/pull/6520#issuecomment-114647405","issue_url":"https://api.github.com/repos/spree/spree/issues/6520","id":114647405,"user":{"login":"JDutil","id":25104,"avatar_url":"https://avatars.githubusercontent.com/u/25104?v=3","gravatar_id":"","url":"https://api.github.com/users/JDutil","html_url":"https://github.com/JDutil","followers_url":"https://api.github.com/users/JDutil/followers","following_url":"https://api.github.com/users/JDutil/following{/other_user}","gists_url":"https://api.github.com/users/JDutil/gists{/gist_id}","starred_url":"https://api.github.com/users/JDutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDutil/subscriptions","organizations_url":"https://api.github.com/users/JDutil/orgs","repos_url":"https://api.github.com/users/JDutil/repos","events_url":"https://api.github.com/users/JDutil/events{/privacy}","received_events_url":"https://api.github.com/users/JDutil/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T21:29:52Z","updated_at":"2015-06-23T21:29:52Z","body":"Merged w/ https://github.com/spree/spree/commit/793f88a4da030b6f50f42dc1838476110b75511c"}}