{"action":"created","comment":{"url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments/27066910","id":27066910,"diff_hunk":"@@ -140,7 +141,7 @@ def _baseline_callback_ecef(self, data):\n     return\n \n   def iar_state_callback(self, data):\n-    self.num_hyps = struct.unpack('<I', data)[0]\n+    self.num_hyps = struct.unpack('<I', data.payload)[0]","path":"scripts/baseline_view.py","position":32,"original_position":32,"commit_id":"08f1a6ac2b53c44e7bf6b837512b7715d49aa794","original_commit_id":"08f1a6ac2b53c44e7bf6b837512b7715d49aa794","user":{"login":"mookerji","id":353255,"avatar_url":"https://avatars.githubusercontent.com/u/353255?v=3","gravatar_id":"","url":"https://api.github.com/users/mookerji","html_url":"https://github.com/mookerji","followers_url":"https://api.github.com/users/mookerji/followers","following_url":"https://api.github.com/users/mookerji/following{/other_user}","gists_url":"https://api.github.com/users/mookerji/gists{/gist_id}","starred_url":"https://api.github.com/users/mookerji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mookerji/subscriptions","organizations_url":"https://api.github.com/users/mookerji/orgs","repos_url":"https://api.github.com/users/mookerji/repos","events_url":"https://api.github.com/users/mookerji/events{/privacy}","received_events_url":"https://api.github.com/users/mookerji/received_events","type":"User","site_admin":false},"body":"... with updating the contract, this could be something like: \r\n\r\n```python\r\ndef iar_state_callback(self, sbp_msg):\r\n  self.num_hyps = MsgIarState(sbp_msg).num_hyps\r\n```","created_at":"2015-03-24T20:00:19Z","updated_at":"2015-03-24T20:00:19Z","html_url":"https://github.com/swift-nav/piksi_firmware/pull/273#discussion_r27066910","pull_request_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments/27066910"},"html":{"href":"https://github.com/swift-nav/piksi_firmware/pull/273#discussion_r27066910"},"pull_request":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273","id":31390009,"html_url":"https://github.com/swift-nav/piksi_firmware/pull/273","diff_url":"https://github.com/swift-nav/piksi_firmware/pull/273.diff","patch_url":"https://github.com/swift-nav/piksi_firmware/pull/273.patch","issue_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/273","number":273,"state":"open","locked":false,"title":"Move on to libsbp","user":{"login":"mfine","id":60851,"avatar_url":"https://avatars.githubusercontent.com/u/60851?v=3","gravatar_id":"","url":"https://api.github.com/users/mfine","html_url":"https://github.com/mfine","followers_url":"https://api.github.com/users/mfine/followers","following_url":"https://api.github.com/users/mfine/following{/other_user}","gists_url":"https://api.github.com/users/mfine/gists{/gist_id}","starred_url":"https://api.github.com/users/mfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfine/subscriptions","organizations_url":"https://api.github.com/users/mfine/orgs","repos_url":"https://api.github.com/users/mfine/repos","events_url":"https://api.github.com/users/mfine/events{/privacy}","received_events_url":"https://api.github.com/users/mfine/received_events","type":"User","site_admin":false},"body":"First pass at moving on to libsbp. Moved messages and structs over. There are a couple of missing messages (todo: `OLD_OBS`, `PACKED_OBS`). Comments and feedback about how this is integrated (is there a better way to import messages and their structs?).\r\n\r\n/cc @mookerji @fnoble ","created_at":"2015-03-18T00:02:24Z","updated_at":"2015-03-24T20:00:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab26fa696415b5e5ffb78fb412ccb656c15c1142","assignee":{"login":"mfine","id":60851,"avatar_url":"https://avatars.githubusercontent.com/u/60851?v=3","gravatar_id":"","url":"https://api.github.com/users/mfine","html_url":"https://github.com/mfine","followers_url":"https://api.github.com/users/mfine/followers","following_url":"https://api.github.com/users/mfine/following{/other_user}","gists_url":"https://api.github.com/users/mfine/gists{/gist_id}","starred_url":"https://api.github.com/users/mfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfine/subscriptions","organizations_url":"https://api.github.com/users/mfine/orgs","repos_url":"https://api.github.com/users/mfine/repos","events_url":"https://api.github.com/users/mfine/events{/privacy}","received_events_url":"https://api.github.com/users/mfine/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273/commits","review_comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273/comments","review_comment_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/273/comments","statuses_url":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/08f1a6ac2b53c44e7bf6b837512b7715d49aa794","head":{"label":"mfine:mfine-move-piksi-firmware-to-sbp","ref":"mfine-move-piksi-firmware-to-sbp","sha":"08f1a6ac2b53c44e7bf6b837512b7715d49aa794","user":{"login":"mfine","id":60851,"avatar_url":"https://avatars.githubusercontent.com/u/60851?v=3","gravatar_id":"","url":"https://api.github.com/users/mfine","html_url":"https://github.com/mfine","followers_url":"https://api.github.com/users/mfine/followers","following_url":"https://api.github.com/users/mfine/following{/other_user}","gists_url":"https://api.github.com/users/mfine/gists{/gist_id}","starred_url":"https://api.github.com/users/mfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfine/subscriptions","organizations_url":"https://api.github.com/users/mfine/orgs","repos_url":"https://api.github.com/users/mfine/repos","events_url":"https://api.github.com/users/mfine/events{/privacy}","received_events_url":"https://api.github.com/users/mfine/received_events","type":"User","site_admin":false},"repo":{"id":31729440,"name":"piksi_firmware","full_name":"mfine/piksi_firmware","owner":{"login":"mfine","id":60851,"avatar_url":"https://avatars.githubusercontent.com/u/60851?v=3","gravatar_id":"","url":"https://api.github.com/users/mfine","html_url":"https://github.com/mfine","followers_url":"https://api.github.com/users/mfine/followers","following_url":"https://api.github.com/users/mfine/following{/other_user}","gists_url":"https://api.github.com/users/mfine/gists{/gist_id}","starred_url":"https://api.github.com/users/mfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfine/subscriptions","organizations_url":"https://api.github.com/users/mfine/orgs","repos_url":"https://api.github.com/users/mfine/repos","events_url":"https://api.github.com/users/mfine/events{/privacy}","received_events_url":"https://api.github.com/users/mfine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfine/piksi_firmware","description":"Firmware for the Piksi GNSS receiver.","fork":true,"url":"https://api.github.com/repos/mfine/piksi_firmware","forks_url":"https://api.github.com/repos/mfine/piksi_firmware/forks","keys_url":"https://api.github.com/repos/mfine/piksi_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfine/piksi_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfine/piksi_firmware/teams","hooks_url":"https://api.github.com/repos/mfine/piksi_firmware/hooks","issue_events_url":"https://api.github.com/repos/mfine/piksi_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/mfine/piksi_firmware/events","assignees_url":"https://api.github.com/repos/mfine/piksi_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/mfine/piksi_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/mfine/piksi_firmware/tags","blobs_url":"https://api.github.com/repos/mfine/piksi_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfine/piksi_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfine/piksi_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfine/piksi_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfine/piksi_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/mfine/piksi_firmware/languages","stargazers_url":"https://api.github.com/repos/mfine/piksi_firmware/stargazers","contributors_url":"https://api.github.com/repos/mfine/piksi_firmware/contributors","subscribers_url":"https://api.github.com/repos/mfine/piksi_firmware/subscribers","subscription_url":"https://api.github.com/repos/mfine/piksi_firmware/subscription","commits_url":"https://api.github.com/repos/mfine/piksi_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfine/piksi_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfine/piksi_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfine/piksi_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfine/piksi_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/mfine/piksi_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfine/piksi_firmware/merges","archive_url":"https://api.github.com/repos/mfine/piksi_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfine/piksi_firmware/downloads","issues_url":"https://api.github.com/repos/mfine/piksi_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/mfine/piksi_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/mfine/piksi_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/mfine/piksi_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfine/piksi_firmware/labels{/name}","releases_url":"https://api.github.com/repos/mfine/piksi_firmware/releases{/id}","created_at":"2015-03-05T18:35:33Z","updated_at":"2015-03-10T02:00:02Z","pushed_at":"2015-03-24T19:29:04Z","git_url":"git://github.com/mfine/piksi_firmware.git","ssh_url":"git@github.com:mfine/piksi_firmware.git","clone_url":"https://github.com/mfine/piksi_firmware.git","svn_url":"https://github.com/mfine/piksi_firmware","homepage":"swift-nav.com","size":3203,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swift-nav:master","ref":"master","sha":"490199ba1d4f4566c0f3c4b0a36fe893d6cf4b9c","user":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars.githubusercontent.com/u/1069835?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"repo":{"id":2464156,"name":"piksi_firmware","full_name":"swift-nav/piksi_firmware","owner":{"login":"swift-nav","id":1069835,"avatar_url":"https://avatars.githubusercontent.com/u/1069835?v=3","gravatar_id":"","url":"https://api.github.com/users/swift-nav","html_url":"https://github.com/swift-nav","followers_url":"https://api.github.com/users/swift-nav/followers","following_url":"https://api.github.com/users/swift-nav/following{/other_user}","gists_url":"https://api.github.com/users/swift-nav/gists{/gist_id}","starred_url":"https://api.github.com/users/swift-nav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swift-nav/subscriptions","organizations_url":"https://api.github.com/users/swift-nav/orgs","repos_url":"https://api.github.com/users/swift-nav/repos","events_url":"https://api.github.com/users/swift-nav/events{/privacy}","received_events_url":"https://api.github.com/users/swift-nav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swift-nav/piksi_firmware","description":"Firmware for the Piksi GNSS receiver.","fork":false,"url":"https://api.github.com/repos/swift-nav/piksi_firmware","forks_url":"https://api.github.com/repos/swift-nav/piksi_firmware/forks","keys_url":"https://api.github.com/repos/swift-nav/piksi_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swift-nav/piksi_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swift-nav/piksi_firmware/teams","hooks_url":"https://api.github.com/repos/swift-nav/piksi_firmware/hooks","issue_events_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/swift-nav/piksi_firmware/events","assignees_url":"https://api.github.com/repos/swift-nav/piksi_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/swift-nav/piksi_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/swift-nav/piksi_firmware/tags","blobs_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/swift-nav/piksi_firmware/languages","stargazers_url":"https://api.github.com/repos/swift-nav/piksi_firmware/stargazers","contributors_url":"https://api.github.com/repos/swift-nav/piksi_firmware/contributors","subscribers_url":"https://api.github.com/repos/swift-nav/piksi_firmware/subscribers","subscription_url":"https://api.github.com/repos/swift-nav/piksi_firmware/subscription","commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/swift-nav/piksi_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/swift-nav/piksi_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/swift-nav/piksi_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/swift-nav/piksi_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swift-nav/piksi_firmware/merges","archive_url":"https://api.github.com/repos/swift-nav/piksi_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swift-nav/piksi_firmware/downloads","issues_url":"https://api.github.com/repos/swift-nav/piksi_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/swift-nav/piksi_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/swift-nav/piksi_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swift-nav/piksi_firmware/labels{/name}","releases_url":"https://api.github.com/repos/swift-nav/piksi_firmware/releases{/id}","created_at":"2011-09-26T23:35:50Z","updated_at":"2015-03-24T18:19:55Z","pushed_at":"2015-03-24T19:35:44Z","git_url":"git://github.com/swift-nav/piksi_firmware.git","ssh_url":"git@github.com:swift-nav/piksi_firmware.git","clone_url":"https://github.com/swift-nav/piksi_firmware.git","svn_url":"https://github.com/swift-nav/piksi_firmware","homepage":"swift-nav.com","size":5250,"stargazers_count":55,"watchers_count":55,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":63,"forks":43,"open_issues":63,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273"},"html":{"href":"https://github.com/swift-nav/piksi_firmware/pull/273"},"issue":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/273"},"comments":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/swift-nav/piksi_firmware/statuses/08f1a6ac2b53c44e7bf6b837512b7715d49aa794"}}}}