{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/25376285","id":25376285,"diff_hunk":"@@ -5,7 +5,7 @@ include(\"rich.jl\")\n function withtag(f, io::IO, tag, attrs...)\n     print(io, \"<$tag\")\n     for (attr, value) in attrs\n-        print(io, \" $attr=\\\"$value\\\"\")\n+        print(io, \" \", htmlescape(attr), \"=\\\"\", htmlescape(value), \"\\\"\")","path":"base/markdown/render/html.jl","position":5,"original_position":5,"commit_id":"2998db3391a27ce8aaf66c0dc4930e8f816bd556","original_commit_id":"2998db3391a27ce8aaf66c0dc4930e8f816bd556","user":{"login":"one-more-minute","id":2234614,"avatar_url":"https://avatars.githubusercontent.com/u/2234614?v=3","gravatar_id":"","url":"https://api.github.com/users/one-more-minute","html_url":"https://github.com/one-more-minute","followers_url":"https://api.github.com/users/one-more-minute/followers","following_url":"https://api.github.com/users/one-more-minute/following{/other_user}","gists_url":"https://api.github.com/users/one-more-minute/gists{/gist_id}","starred_url":"https://api.github.com/users/one-more-minute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/one-more-minute/subscriptions","organizations_url":"https://api.github.com/users/one-more-minute/orgs","repos_url":"https://api.github.com/users/one-more-minute/repos","events_url":"https://api.github.com/users/one-more-minute/events{/privacy}","received_events_url":"https://api.github.com/users/one-more-minute/received_events","type":"User","site_admin":false},"body":"Do attributes ever need to be escaped? As far as I know something special characters aren't valid attribute names anyway, and since the values are quoted they shouldn't need escaping.","created_at":"2015-02-25T20:35:38Z","updated_at":"2015-02-25T20:35:38Z","html_url":"https://github.com/JuliaLang/julia/pull/10061#discussion_r25376285","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/10061","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/25376285"},"html":{"href":"https://github.com/JuliaLang/julia/pull/10061#discussion_r25376285"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10061"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/10061","id":28598532,"html_url":"https://github.com/JuliaLang/julia/pull/10061","diff_url":"https://github.com/JuliaLang/julia/pull/10061.diff","patch_url":"https://github.com/JuliaLang/julia/pull/10061.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/10061","number":10061,"state":"open","locked":false,"title":"htmlescape markdown","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"body":"Throwing this out there, IMO html escaping is required for rendering markdown in html.\r\n\r\ncc @one-more-minute @MichaelHatherly\r\n\r\nNote: This breaks the Ref test, so I'm not sure what I should do to fix it?\r\n\r\nI need to read the Markdown spec a little more carefully, I'm not sure what the precise rules for escaping are. http://spec.commonmark.org/ I think I'm doing a little too much here (e.g. I wonder if links need different behaviour).\r\n\r\n*This was mentioned in #5239 and #9933.*","created_at":"2015-02-03T23:10:02Z","updated_at":"2015-02-25T20:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"828d7794cc77450ba3db89820f2625d88c1e4f22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/10061/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/10061/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/10061/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/2998db3391a27ce8aaf66c0dc4930e8f816bd556","head":{"label":"hayd:htmlescape","ref":"htmlescape","sha":"2998db3391a27ce8aaf66c0dc4930e8f816bd556","user":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"repo":{"id":14515015,"name":"julia","full_name":"hayd/julia","owner":{"login":"hayd","id":1931852,"avatar_url":"https://avatars.githubusercontent.com/u/1931852?v=3","gravatar_id":"","url":"https://api.github.com/users/hayd","html_url":"https://github.com/hayd","followers_url":"https://api.github.com/users/hayd/followers","following_url":"https://api.github.com/users/hayd/following{/other_user}","gists_url":"https://api.github.com/users/hayd/gists{/gist_id}","starred_url":"https://api.github.com/users/hayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayd/subscriptions","organizations_url":"https://api.github.com/users/hayd/orgs","repos_url":"https://api.github.com/users/hayd/repos","events_url":"https://api.github.com/users/hayd/events{/privacy}","received_events_url":"https://api.github.com/users/hayd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hayd/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/hayd/julia","forks_url":"https://api.github.com/repos/hayd/julia/forks","keys_url":"https://api.github.com/repos/hayd/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hayd/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hayd/julia/teams","hooks_url":"https://api.github.com/repos/hayd/julia/hooks","issue_events_url":"https://api.github.com/repos/hayd/julia/issues/events{/number}","events_url":"https://api.github.com/repos/hayd/julia/events","assignees_url":"https://api.github.com/repos/hayd/julia/assignees{/user}","branches_url":"https://api.github.com/repos/hayd/julia/branches{/branch}","tags_url":"https://api.github.com/repos/hayd/julia/tags","blobs_url":"https://api.github.com/repos/hayd/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hayd/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hayd/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/hayd/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hayd/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/hayd/julia/languages","stargazers_url":"https://api.github.com/repos/hayd/julia/stargazers","contributors_url":"https://api.github.com/repos/hayd/julia/contributors","subscribers_url":"https://api.github.com/repos/hayd/julia/subscribers","subscription_url":"https://api.github.com/repos/hayd/julia/subscription","commits_url":"https://api.github.com/repos/hayd/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/hayd/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/hayd/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/hayd/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/hayd/julia/contents/{+path}","compare_url":"https://api.github.com/repos/hayd/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hayd/julia/merges","archive_url":"https://api.github.com/repos/hayd/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hayd/julia/downloads","issues_url":"https://api.github.com/repos/hayd/julia/issues{/number}","pulls_url":"https://api.github.com/repos/hayd/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/hayd/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/hayd/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hayd/julia/labels{/name}","releases_url":"https://api.github.com/repos/hayd/julia/releases{/id}","created_at":"2013-11-19T05:18:39Z","updated_at":"2015-02-25T19:50:26Z","pushed_at":"2015-02-25T19:50:24Z","git_url":"git://github.com/hayd/julia.git","ssh_url":"git@github.com:hayd/julia.git","clone_url":"https://github.com/hayd/julia.git","svn_url":"https://github.com/hayd/julia","homepage":"http://julialang.org/","size":59821,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"aa1a922b4121b18b45f7cbd0c5bacbbe03edd94c","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-02-25T19:49:24Z","pushed_at":"2015-02-25T20:13:34Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":175463,"stargazers_count":5125,"watchers_count":5125,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1073,"mirror_url":null,"open_issues_count":1155,"forks":1073,"open_issues":1155,"watchers":5125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10061"},"html":{"href":"https://github.com/JuliaLang/julia/pull/10061"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/10061"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/10061/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10061/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/10061/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/2998db3391a27ce8aaf66c0dc4930e8f816bd556"}}}}