{"action":"created","issue":{"url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/1","labels_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/1/comments","events_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/1/events","html_url":"https://github.com/mjzffr/firefox-media-tests/pull/1","id":74147573,"number":1,"title":"Add eme tests","user":{"login":"sydvicious","id":984554,"avatar_url":"https://avatars.githubusercontent.com/u/984554?v=3","gravatar_id":"","url":"https://api.github.com/users/sydvicious","html_url":"https://github.com/sydvicious","followers_url":"https://api.github.com/users/sydvicious/followers","following_url":"https://api.github.com/users/sydvicious/following{/other_user}","gists_url":"https://api.github.com/users/sydvicious/gists{/gist_id}","starred_url":"https://api.github.com/users/sydvicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sydvicious/subscriptions","organizations_url":"https://api.github.com/users/sydvicious/orgs","repos_url":"https://api.github.com/users/sydvicious/repos","events_url":"https://api.github.com/users/sydvicious/events{/privacy}","received_events_url":"https://api.github.com/users/sydvicious/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T22:24:01Z","updated_at":"2015-05-13T19:49:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mjzffr/firefox-media-tests/pulls/1","html_url":"https://github.com/mjzffr/firefox-media-tests/pull/1","diff_url":"https://github.com/mjzffr/firefox-media-tests/pull/1.diff","patch_url":"https://github.com/mjzffr/firefox-media-tests/pull/1.patch"},"body":"Add tests for EME. Move youtube tests to their own directory."},"comment":{"url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/comments/101794525","html_url":"https://github.com/mjzffr/firefox-media-tests/pull/1#issuecomment-101794525","issue_url":"https://api.github.com/repos/mjzffr/firefox-media-tests/issues/1","id":101794525,"user":{"login":"mjzffr","id":6024326,"avatar_url":"https://avatars.githubusercontent.com/u/6024326?v=3","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T19:49:14Z","updated_at":"2015-05-13T19:49:14Z","body":"Given that there isn't really anything specific to EME in `eme_puppeteer.py`, I think all/most of the \"EME\" identifiers should be changed to \"Video\": e.g. `VideoPuppeteer`, `execute_video_script`, `VideoException`, etc. The content of `eme_puppeteer.py` can be completely moved into `media_player.py` as well. When we refactor later on, `VideoPuppeteer` will likely be a base class for other site/vendor-specific \"puppeteers\".\r\n\r\nAlong the same lines, since `test_eme_playback.py` is actually generic, so let's just put all the `test_*` files into one `playback` directory like before and I'll move out the YouTube-specific stuff in a different commit."}}