{"action":"created","comment":{"url":"https://api.github.com/repos/timholy/Images.jl/pulls/comments/25907089","id":25907089,"diff_hunk":"@@ -354,6 +354,22 @@ for CV in subtypes(AbstractRGB)\n         zero{T}(::Type{$CV{T}}) = $CV{T}(zero(T),zero(T),zero(T))\n         zero{T}(::Type{AlphaColorValue{$CV{T},T}}) = AlphaColorValue{$CV{T},T}(zero(T),zero(T),zero(T),zero(T))\n         zero{T}(::Type{AlphaColor{$CV{T},T}}) = AlphaColorValue{$CV{T},T}(zero(T),zero(T),zero(T),zero(T))\n+\n+        atan2{T}(a::$CV{T}, b::$CV{T}) = $CV{T}(atan2(a.r, b.r), atan2(a.g, b.g), atan2(a.b, b.b))\n+        atan2{T}(a::AlphaColorValue{$CV{T},T}, b::AlphaColorValue{$CV{T},T}) = AlphaColorValue{$CV{T},T}(atan2(a.c.r, b.c.r), atan2(a.c.g, b.c.g), atan2(a.c.b, b.c.b), atan2(a.alpha, b.alpha))\n+        atan2{T}(a::AlphaColor{$CV{T},T}, b::AlphaColor{$CV{T},T}) = AlphaColorValue{$CV{T},T}(atan2(a.c.r, b.c.r), atan2(a.c.g, b.c.g), atan2(a.c.b, b.c.b), atan2(a.alpha, b.alpha))\n+        hypot{T}(a::$CV{T}, b::$CV{T}) = $CV{T}(hypot(a.r, b.r), hypot(a.g, b.g), hypot(a.b, b.b))\n+        hypot{T}(a::AlphaColorValue{$CV{T},T}, b::AlphaColorValue{$CV{T},T}) = AlphaColorValue{$CV{T},T}(hypot(a.c.r, b.c.r), hypot(a.c.g, b.c.g), hypot(a.c.b, b.c.b), hypot(a.alpha, b.alpha))\n+        hypot{T}(a::AlphaColor{$CV{T},T}, b::AlphaColor{$CV{T},T}) = AlphaColorValue{$CV{T},T}(hypot(a.c.r, b.c.r), hypot(a.c.g, b.c.g), hypot(a.c.b, b.c.b), hypot(a.alpha, b.alpha))","path":"src/colortypes.jl","position":19,"original_position":19,"commit_id":"aab29d2aef0fe50f107e8c04ddaf3a577f9ae7f7","original_commit_id":"aab29d2aef0fe50f107e8c04ddaf3a577f9ae7f7","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?v=3","gravatar_id":"","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"body":"@timholy, I just copied the format from above, but I'm wondering if `AlphaColorValue` on the RHS should just be `AlphaColor` (here and above)?","created_at":"2015-03-05T22:13:00Z","updated_at":"2015-03-05T22:13:00Z","html_url":"https://github.com/timholy/Images.jl/pull/264#discussion_r25907089","pull_request_url":"https://api.github.com/repos/timholy/Images.jl/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/comments/25907089"},"html":{"href":"https://github.com/timholy/Images.jl/pull/264#discussion_r25907089"},"pull_request":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/timholy/Images.jl/pulls/264","id":30599261,"html_url":"https://github.com/timholy/Images.jl/pull/264","diff_url":"https://github.com/timholy/Images.jl/pull/264.diff","patch_url":"https://github.com/timholy/Images.jl/pull/264.patch","issue_url":"https://api.github.com/repos/timholy/Images.jl/issues/264","number":264,"state":"open","locked":false,"title":"WIP: Fix atan2, hypot functions on Image{Gray} (fixes #263)","user":{"login":"kmsquire","id":223250,"avatar_url":"https://avatars.githubusercontent.com/u/223250?v=3","gravatar_id":"","url":"https://api.github.com/users/kmsquire","html_url":"https://github.com/kmsquire","followers_url":"https://api.github.com/users/kmsquire/followers","following_url":"https://api.github.com/users/kmsquire/following{/other_user}","gists_url":"https://api.github.com/users/kmsquire/gists{/gist_id}","starred_url":"https://api.github.com/users/kmsquire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmsquire/subscriptions","organizations_url":"https://api.github.com/users/kmsquire/orgs","repos_url":"https://api.github.com/users/kmsquire/repos","events_url":"https://api.github.com/users/kmsquire/events{/privacy}","received_events_url":"https://api.github.com/users/kmsquire/received_events","type":"User","site_admin":false},"body":"* Used by magnitude, orientation functions\r\n* Added Image{Gray} tests to test/edge.jl\r\n\r\nI believe these will work, but I've only tested on Julia v0.4 so far, and only on gray-scale images.  ","created_at":"2015-03-05T21:50:37Z","updated_at":"2015-03-05T22:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e94a05f13df0d13c4352939b2eab1a550c7764a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/timholy/Images.jl/pulls/264/commits","review_comments_url":"https://api.github.com/repos/timholy/Images.jl/pulls/264/comments","review_comment_url":"https://api.github.com/repos/timholy/Images.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/timholy/Images.jl/issues/264/comments","statuses_url":"https://api.github.com/repos/timholy/Images.jl/statuses/aab29d2aef0fe50f107e8c04ddaf3a577f9ae7f7","head":{"label":"timholy:kms/hypot-atan2-fix","ref":"kms/hypot-atan2-fix","sha":"aab29d2aef0fe50f107e8c04ddaf3a577f9ae7f7","user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"repo":{"id":7018954,"name":"Images.jl","full_name":"timholy/Images.jl","owner":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timholy/Images.jl","description":"An image library for Julia","fork":false,"url":"https://api.github.com/repos/timholy/Images.jl","forks_url":"https://api.github.com/repos/timholy/Images.jl/forks","keys_url":"https://api.github.com/repos/timholy/Images.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timholy/Images.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timholy/Images.jl/teams","hooks_url":"https://api.github.com/repos/timholy/Images.jl/hooks","issue_events_url":"https://api.github.com/repos/timholy/Images.jl/issues/events{/number}","events_url":"https://api.github.com/repos/timholy/Images.jl/events","assignees_url":"https://api.github.com/repos/timholy/Images.jl/assignees{/user}","branches_url":"https://api.github.com/repos/timholy/Images.jl/branches{/branch}","tags_url":"https://api.github.com/repos/timholy/Images.jl/tags","blobs_url":"https://api.github.com/repos/timholy/Images.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timholy/Images.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timholy/Images.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/timholy/Images.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timholy/Images.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/timholy/Images.jl/languages","stargazers_url":"https://api.github.com/repos/timholy/Images.jl/stargazers","contributors_url":"https://api.github.com/repos/timholy/Images.jl/contributors","subscribers_url":"https://api.github.com/repos/timholy/Images.jl/subscribers","subscription_url":"https://api.github.com/repos/timholy/Images.jl/subscription","commits_url":"https://api.github.com/repos/timholy/Images.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/timholy/Images.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/timholy/Images.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/timholy/Images.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/timholy/Images.jl/contents/{+path}","compare_url":"https://api.github.com/repos/timholy/Images.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timholy/Images.jl/merges","archive_url":"https://api.github.com/repos/timholy/Images.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timholy/Images.jl/downloads","issues_url":"https://api.github.com/repos/timholy/Images.jl/issues{/number}","pulls_url":"https://api.github.com/repos/timholy/Images.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/timholy/Images.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/timholy/Images.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timholy/Images.jl/labels{/name}","releases_url":"https://api.github.com/repos/timholy/Images.jl/releases{/id}","created_at":"2012-12-05T14:43:16Z","updated_at":"2015-03-04T23:06:24Z","pushed_at":"2015-03-05T22:11:45Z","git_url":"git://github.com/timholy/Images.jl.git","ssh_url":"git@github.com:timholy/Images.jl.git","clone_url":"https://github.com/timholy/Images.jl.git","svn_url":"https://github.com/timholy/Images.jl","homepage":null,"size":4001,"stargazers_count":61,"watchers_count":61,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":27,"forks":45,"open_issues":27,"watchers":61,"default_branch":"master"}},"base":{"label":"timholy:master","ref":"master","sha":"68126750d07dec407ed0dbbd8ba01be28ce176d1","user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"repo":{"id":7018954,"name":"Images.jl","full_name":"timholy/Images.jl","owner":{"login":"timholy","id":1525481,"avatar_url":"https://avatars.githubusercontent.com/u/1525481?v=3","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timholy/Images.jl","description":"An image library for Julia","fork":false,"url":"https://api.github.com/repos/timholy/Images.jl","forks_url":"https://api.github.com/repos/timholy/Images.jl/forks","keys_url":"https://api.github.com/repos/timholy/Images.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timholy/Images.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timholy/Images.jl/teams","hooks_url":"https://api.github.com/repos/timholy/Images.jl/hooks","issue_events_url":"https://api.github.com/repos/timholy/Images.jl/issues/events{/number}","events_url":"https://api.github.com/repos/timholy/Images.jl/events","assignees_url":"https://api.github.com/repos/timholy/Images.jl/assignees{/user}","branches_url":"https://api.github.com/repos/timholy/Images.jl/branches{/branch}","tags_url":"https://api.github.com/repos/timholy/Images.jl/tags","blobs_url":"https://api.github.com/repos/timholy/Images.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timholy/Images.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timholy/Images.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/timholy/Images.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timholy/Images.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/timholy/Images.jl/languages","stargazers_url":"https://api.github.com/repos/timholy/Images.jl/stargazers","contributors_url":"https://api.github.com/repos/timholy/Images.jl/contributors","subscribers_url":"https://api.github.com/repos/timholy/Images.jl/subscribers","subscription_url":"https://api.github.com/repos/timholy/Images.jl/subscription","commits_url":"https://api.github.com/repos/timholy/Images.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/timholy/Images.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/timholy/Images.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/timholy/Images.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/timholy/Images.jl/contents/{+path}","compare_url":"https://api.github.com/repos/timholy/Images.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timholy/Images.jl/merges","archive_url":"https://api.github.com/repos/timholy/Images.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timholy/Images.jl/downloads","issues_url":"https://api.github.com/repos/timholy/Images.jl/issues{/number}","pulls_url":"https://api.github.com/repos/timholy/Images.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/timholy/Images.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/timholy/Images.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timholy/Images.jl/labels{/name}","releases_url":"https://api.github.com/repos/timholy/Images.jl/releases{/id}","created_at":"2012-12-05T14:43:16Z","updated_at":"2015-03-04T23:06:24Z","pushed_at":"2015-03-05T22:11:45Z","git_url":"git://github.com/timholy/Images.jl.git","ssh_url":"git@github.com:timholy/Images.jl.git","clone_url":"https://github.com/timholy/Images.jl.git","svn_url":"https://github.com/timholy/Images.jl","homepage":null,"size":4001,"stargazers_count":61,"watchers_count":61,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":27,"forks":45,"open_issues":27,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/264"},"html":{"href":"https://github.com/timholy/Images.jl/pull/264"},"issue":{"href":"https://api.github.com/repos/timholy/Images.jl/issues/264"},"comments":{"href":"https://api.github.com/repos/timholy/Images.jl/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/timholy/Images.jl/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/timholy/Images.jl/statuses/aab29d2aef0fe50f107e8c04ddaf3a577f9ae7f7"}}}}