{"action":"created","issue":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/2364","labels_url":"https://api.github.com/repos/kangax/fabric.js/issues/2364/labels{/name}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/2364/comments","events_url":"https://api.github.com/repos/kangax/fabric.js/issues/2364/events","html_url":"https://github.com/kangax/fabric.js/pull/2364","id":97433802,"number":2364,"title":"Fix svg base markup","user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-27T10:35:24Z","updated_at":"2015-07-27T10:49:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kangax/fabric.js/pulls/2364","html_url":"https://github.com/kangax/fabric.js/pull/2364","diff_url":"https://github.com/kangax/fabric.js/pull/2364.diff","patch_url":"https://github.com/kangax/fabric.js/pull/2364.patch"},"body":"Side effects to be checked:\r\n\r\nGroup class does not export svgStyles, so it will not have shadow in any case. ( special svg style method required to output fewer properties).\r\n\r\nImage class export svg style twice, ( for image and rect border) side effects to be checked with shadow and with other properties.\r\n\r\nPathgroup class should be ok.\r\n\r\nAlso i noticed that all classes exports:\r\nsvgTransform + svgTrasnformMatrix\r\nwhile pathgroup exports:\r\nsvgTransformMatrix + svgTransform"},"comment":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/comments/125163754","html_url":"https://github.com/kangax/fabric.js/pull/2364#issuecomment-125163754","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/2364","id":125163754,"user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T10:49:53Z","updated_at":"2015-07-27T10:49:53Z","body":"/cc: @MohamedElamry"}}