{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/44098769","id":44098769,"diff_hunk":"@@ -17,27 +17,33 @@\n \n # SQLcontext.R: SQLContext-driven functions\n \n+\n+#' map top level R type to SQL type","path":"R/pkg/R/SQLContext.R","position":5,"original_position":5,"commit_id":"463713daa50ec07d63d4b03ce1916d2cb040d410","original_commit_id":"463713daa50ec07d63d4b03ce1916d2cb040d410","user":{"login":"sun-rui","id":2528327,"avatar_url":"https://avatars.githubusercontent.com/u/2528327?v=3","gravatar_id":"","url":"https://api.github.com/users/sun-rui","html_url":"https://github.com/sun-rui","followers_url":"https://api.github.com/users/sun-rui/followers","following_url":"https://api.github.com/users/sun-rui/following{/other_user}","gists_url":"https://api.github.com/users/sun-rui/gists{/gist_id}","starred_url":"https://api.github.com/users/sun-rui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sun-rui/subscriptions","organizations_url":"https://api.github.com/users/sun-rui/orgs","repos_url":"https://api.github.com/users/sun-rui/repos","events_url":"https://api.github.com/users/sun-rui/events{/privacy}","received_events_url":"https://api.github.com/users/sun-rui/received_events","type":"User","site_admin":false},"body":"#' is for Roxygen. so use # here.","created_at":"2015-11-06T02:53:34Z","updated_at":"2015-11-06T02:53:34Z","html_url":"https://github.com/apache/spark/pull/9099#discussion_r44098769","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/9099","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/44098769"},"html":{"href":"https://github.com/apache/spark/pull/9099#discussion_r44098769"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/9099"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9099","id":47566167,"html_url":"https://github.com/apache/spark/pull/9099","diff_url":"https://github.com/apache/spark/pull/9099.diff","patch_url":"https://github.com/apache/spark/pull/9099.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/9099","number":9099,"state":"open","locked":false,"title":"[SPARK-11086][SPARKR] Use dropFactors column-wise instead of nested loop when createDataFrame","user":{"login":"zero323","id":1554276,"avatar_url":"https://avatars.githubusercontent.com/u/1554276?v=3","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"body":"Use `dropFactors` column-wise instead of nested loop when `createDataFrame` from a `data.frame`\r\n\r\nAt this moment SparkR createDataFrame is using nested loop to convert factors to character when called on a local data.frame.  It works but is incredibly slow especially with data.table (~ 2 orders of magnitude compared to PySpark / Pandas version on a DateFrame of size 1M rows x 2 columns).\r\n\r\nA simple improvement is to apply `dropFactor `column-wise and then reshape output list.\r\n\r\nIt should at least partially address [SPARK-8277](https://issues.apache.org/jira/browse/SPARK-8277).\r\n","created_at":"2015-10-13T17:55:15Z","updated_at":"2015-11-06T02:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2a3b747caa6a5eb086b45271ee5e56f4ec31801","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/9099/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/9099/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/9099/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/463713daa50ec07d63d4b03ce1916d2cb040d410","head":{"label":"zero323:SPARK-11086","ref":"SPARK-11086","sha":"463713daa50ec07d63d4b03ce1916d2cb040d410","user":{"login":"zero323","id":1554276,"avatar_url":"https://avatars.githubusercontent.com/u/1554276?v=3","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"repo":{"id":43824676,"name":"spark","full_name":"zero323/spark","owner":{"login":"zero323","id":1554276,"avatar_url":"https://avatars.githubusercontent.com/u/1554276?v=3","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zero323/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/zero323/spark","forks_url":"https://api.github.com/repos/zero323/spark/forks","keys_url":"https://api.github.com/repos/zero323/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero323/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero323/spark/teams","hooks_url":"https://api.github.com/repos/zero323/spark/hooks","issue_events_url":"https://api.github.com/repos/zero323/spark/issues/events{/number}","events_url":"https://api.github.com/repos/zero323/spark/events","assignees_url":"https://api.github.com/repos/zero323/spark/assignees{/user}","branches_url":"https://api.github.com/repos/zero323/spark/branches{/branch}","tags_url":"https://api.github.com/repos/zero323/spark/tags","blobs_url":"https://api.github.com/repos/zero323/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero323/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero323/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero323/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero323/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/zero323/spark/languages","stargazers_url":"https://api.github.com/repos/zero323/spark/stargazers","contributors_url":"https://api.github.com/repos/zero323/spark/contributors","subscribers_url":"https://api.github.com/repos/zero323/spark/subscribers","subscription_url":"https://api.github.com/repos/zero323/spark/subscription","commits_url":"https://api.github.com/repos/zero323/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero323/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero323/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero323/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero323/spark/contents/{+path}","compare_url":"https://api.github.com/repos/zero323/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero323/spark/merges","archive_url":"https://api.github.com/repos/zero323/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero323/spark/downloads","issues_url":"https://api.github.com/repos/zero323/spark/issues{/number}","pulls_url":"https://api.github.com/repos/zero323/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/zero323/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/zero323/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero323/spark/labels{/name}","releases_url":"https://api.github.com/repos/zero323/spark/releases{/id}","created_at":"2015-10-07T15:16:38Z","updated_at":"2015-10-07T15:17:09Z","pushed_at":"2015-11-05T02:08:50Z","git_url":"git://github.com/zero323/spark.git","ssh_url":"git@github.com:zero323/spark.git","clone_url":"https://github.com/zero323/spark.git","svn_url":"https://github.com/zero323/spark","homepage":null,"size":127856,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d0b56339625727744e2c30fc2167bc6a457d37f7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-11-06T02:22:59Z","pushed_at":"2015-11-06T02:22:32Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1649545,"stargazers_count":6037,"watchers_count":6037,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5616,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":367,"forks":5616,"open_issues":367,"watchers":6037,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/9099"},"html":{"href":"https://github.com/apache/spark/pull/9099"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/9099"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/9099/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/9099/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/9099/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/463713daa50ec07d63d4b03ce1916d2cb040d410"}}}}