{"action":"closed","number":2280,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280","id":26817752,"html_url":"https://github.com/spring-projects/spring-boot/pull/2280","diff_url":"https://github.com/spring-projects/spring-boot/pull/2280.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/2280.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/2280","number":2280,"state":"closed","locked":false,"title":"Auto-configuration for SendGrid's Java client","user":{"login":"maciejwalkowiak","id":1357927,"avatar_url":"https://avatars.githubusercontent.com/u/1357927?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejwalkowiak","html_url":"https://github.com/maciejwalkowiak","followers_url":"https://api.github.com/users/maciejwalkowiak/followers","following_url":"https://api.github.com/users/maciejwalkowiak/following{/other_user}","gists_url":"https://api.github.com/users/maciejwalkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejwalkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejwalkowiak/subscriptions","organizations_url":"https://api.github.com/users/maciejwalkowiak/orgs","repos_url":"https://api.github.com/users/maciejwalkowiak/repos","events_url":"https://api.github.com/users/maciejwalkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/maciejwalkowiak/received_events","type":"User","site_admin":false},"body":"Pull for #2160. **SendGrid** gets auto-configured if:\r\n\r\n- `com.sendgrid.SendGrid` is on classpath\r\n- property: `sendgrid.username` is defined\r\n- additionally auto-configures proxy when `sendgrid.proxy.host` and `sendgrid.proxy.port` is defined\r\n\r\n**Documentation** - only *Appendix A. Common application properties* section has been updated with new properties.\r\n\r\n**Unit tests** - testing proxy creation could be improved if I could set up some mock HTTP server (for example with [Jadler](https://github.com/jadler-mocking/jadler/wiki)) and see if there are requests coming in. At the moment there is a check if `SendGrid` bean is created but there is no really a way to check if it's created with proxy or not.","created_at":"2015-01-05T11:13:29Z","updated_at":"2015-03-05T16:10:38Z","closed_at":"2015-03-05T16:10:38Z","merged_at":null,"merge_commit_sha":"0ac221526632c7449ed848ad4014fbb121f24753","assignee":null,"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/28","html_url":"https://github.com/spring-projects/spring-boot/milestones/1.3.0","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/28/labels","id":818466,"number":28,"title":"1.3.0","description":"","creator":{"login":"philwebb","id":519772,"avatar_url":"https://avatars.githubusercontent.com/u/519772?v=3","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":108,"closed_issues":5,"state":"open","created_at":"2014-10-08T15:00:46Z","updated_at":"2015-03-05T16:10:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/2280/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/2652e1728fceea92c91dc6569f7edb1a2fd01dbf","head":{"label":"maciejwalkowiak:gh-2160","ref":"gh-2160","sha":"2652e1728fceea92c91dc6569f7edb1a2fd01dbf","user":{"login":"maciejwalkowiak","id":1357927,"avatar_url":"https://avatars.githubusercontent.com/u/1357927?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejwalkowiak","html_url":"https://github.com/maciejwalkowiak","followers_url":"https://api.github.com/users/maciejwalkowiak/followers","following_url":"https://api.github.com/users/maciejwalkowiak/following{/other_user}","gists_url":"https://api.github.com/users/maciejwalkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejwalkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejwalkowiak/subscriptions","organizations_url":"https://api.github.com/users/maciejwalkowiak/orgs","repos_url":"https://api.github.com/users/maciejwalkowiak/repos","events_url":"https://api.github.com/users/maciejwalkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/maciejwalkowiak/received_events","type":"User","site_admin":false},"repo":{"id":19567331,"name":"spring-boot","full_name":"maciejwalkowiak/spring-boot","owner":{"login":"maciejwalkowiak","id":1357927,"avatar_url":"https://avatars.githubusercontent.com/u/1357927?v=3","gravatar_id":"","url":"https://api.github.com/users/maciejwalkowiak","html_url":"https://github.com/maciejwalkowiak","followers_url":"https://api.github.com/users/maciejwalkowiak/followers","following_url":"https://api.github.com/users/maciejwalkowiak/following{/other_user}","gists_url":"https://api.github.com/users/maciejwalkowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/maciejwalkowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciejwalkowiak/subscriptions","organizations_url":"https://api.github.com/users/maciejwalkowiak/orgs","repos_url":"https://api.github.com/users/maciejwalkowiak/repos","events_url":"https://api.github.com/users/maciejwalkowiak/events{/privacy}","received_events_url":"https://api.github.com/users/maciejwalkowiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maciejwalkowiak/spring-boot","description":"Spring Boot","fork":true,"url":"https://api.github.com/repos/maciejwalkowiak/spring-boot","forks_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/forks","keys_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/teams","hooks_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/events","assignees_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/tags","blobs_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/languages","stargazers_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/subscription","commits_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/merges","archive_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/downloads","issues_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/maciejwalkowiak/spring-boot/releases{/id}","created_at":"2014-05-08T09:08:33Z","updated_at":"2015-01-03T15:31:36Z","pushed_at":"2015-01-05T11:08:58Z","git_url":"git://github.com/maciejwalkowiak/spring-boot.git","ssh_url":"git@github.com:maciejwalkowiak/spring-boot.git","clone_url":"https://github.com/maciejwalkowiak/spring-boot.git","svn_url":"https://github.com/maciejwalkowiak/spring-boot","homepage":"http://projects.spring.io/spring-boot","size":18645,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"1f775793ee3c93b696ffea79e0761a56d5a7084e","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":6296790,"name":"spring-boot","full_name":"spring-projects/spring-boot","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-boot","description":"Spring Boot","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-boot","forks_url":"https://api.github.com/repos/spring-projects/spring-boot/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-boot/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-boot/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-boot/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-boot/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-boot/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-boot/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-boot/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-boot/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-boot/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-boot/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-boot/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-boot/releases{/id}","created_at":"2012-10-19T15:02:57Z","updated_at":"2015-03-05T16:10:36Z","pushed_at":"2015-03-05T16:10:36Z","git_url":"git://github.com/spring-projects/spring-boot.git","ssh_url":"git@github.com:spring-projects/spring-boot.git","clone_url":"https://github.com/spring-projects/spring-boot.git","svn_url":"https://github.com/spring-projects/spring-boot","homepage":"http://projects.spring.io/spring-boot","size":52027,"stargazers_count":1736,"watchers_count":1736,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1608,"mirror_url":null,"open_issues_count":350,"forks":1608,"open_issues":350,"watchers":1736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280"},"html":{"href":"https://github.com/spring-projects/spring-boot/pull/2280"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/2280"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/issues/2280/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-boot/pulls/2280/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-boot/statuses/2652e1728fceea92c91dc6569f7edb1a2fd01dbf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":3,"additions":297,"deletions":0,"changed_files":8}}