{"action":"created","issue":{"url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/136","labels_url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/136/comments","events_url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/136/events","html_url":"https://github.com/Lejdborg/NMSSH/pull/136","id":90292488,"number":136,"title":"update sequence around the method \"libssh2_sftp_write\"","user":{"login":"oganosin","id":9837435,"avatar_url":"https://avatars.githubusercontent.com/u/9837435?v=3","gravatar_id":"","url":"https://api.github.com/users/oganosin","html_url":"https://github.com/oganosin","followers_url":"https://api.github.com/users/oganosin/followers","following_url":"https://api.github.com/users/oganosin/following{/other_user}","gists_url":"https://api.github.com/users/oganosin/gists{/gist_id}","starred_url":"https://api.github.com/users/oganosin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oganosin/subscriptions","organizations_url":"https://api.github.com/users/oganosin/orgs","repos_url":"https://api.github.com/users/oganosin/repos","events_url":"https://api.github.com/users/oganosin/events{/privacy}","received_events_url":"https://api.github.com/users/oganosin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-23T05:33:00Z","updated_at":"2015-06-23T13:28:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Lejdborg/NMSSH/pulls/136","html_url":"https://github.com/Lejdborg/NMSSH/pull/136","diff_url":"https://github.com/Lejdborg/NMSSH/pull/136.diff","patch_url":"https://github.com/Lejdborg/NMSSH/pull/136.patch"},"body":"Since the return value of this method is not buffer size, but actual number of bytes written.\r\nSee this page : http://www.libssh2.org/libssh2_sftp_write.html\r\n\r\nAnd add property that has buffer size that help to set buffer size from outside of library."},"comment":{"url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/comments/114502191","html_url":"https://github.com/Lejdborg/NMSSH/pull/136#issuecomment-114502191","issue_url":"https://api.github.com/repos/Lejdborg/NMSSH/issues/136","id":114502191,"user":{"login":"oganosin","id":9837435,"avatar_url":"https://avatars.githubusercontent.com/u/9837435?v=3","gravatar_id":"","url":"https://api.github.com/users/oganosin","html_url":"https://github.com/oganosin","followers_url":"https://api.github.com/users/oganosin/followers","following_url":"https://api.github.com/users/oganosin/following{/other_user}","gists_url":"https://api.github.com/users/oganosin/gists{/gist_id}","starred_url":"https://api.github.com/users/oganosin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oganosin/subscriptions","organizations_url":"https://api.github.com/users/oganosin/orgs","repos_url":"https://api.github.com/users/oganosin/repos","events_url":"https://api.github.com/users/oganosin/events{/privacy}","received_events_url":"https://api.github.com/users/oganosin/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T13:28:08Z","updated_at":"2015-06-23T13:28:08Z","body":"On the server I tested, the performance grow up particularly when I increase buffer size.\r\nBut I know it's depend on the server and network setting even though I'm not sure the detail.\r\nThat's why I don't change buffer size but add property and setter method.\r\n\r\nPlease test on your side too when you are available.\r\n\r\nThanks"}}