{"action":"created","issue":{"url":"https://api.github.com/repos/avocado-framework/avocado/issues/613","labels_url":"https://api.github.com/repos/avocado-framework/avocado/issues/613/labels{/name}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/613/comments","events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/613/events","html_url":"https://github.com/avocado-framework/avocado/pull/613","id":79417728,"number":613,"title":"RFC: FIXME: Draft of params.set()","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-22T11:29:31Z","updated_at":"2015-05-22T12:46:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/613","html_url":"https://github.com/avocado-framework/avocado/pull/613","diff_url":"https://github.com/avocado-framework/avocado/pull/613.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/613.patch"},"body":"Currently `avocado-virt` tries to override `--qemu-bin` by writing to params. With the new layout this is not supported. This pull request demonstrates one way to solve this problem by overriding all occurrences of the key for given path + defaults. It's one of the safest methods, another - less intrusive - variant would be to only update cache, which would require the queries to be always the same (even different default would cause cache-miss and lookup from params).\r\n\r\nAnyway there is one big drawback. This solution modifies directly the mux-tree, which means the following variant would have these values set. So in order to support this properly we'd have to either copy the variant or use additional storage for these queries.\r\n\r\nThe worst thing about this is theoretical. In my opinion test parameters are by definition static. They shouldn't be writable and that's actually something I did on purpose. When developing it I thought on this and now the time probably come, here is an alternative version, which I had in mind but thought it's not yet required: https://github.com/avocado-framework/avocado/pull/614"},"comment":{"url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments/104650857","html_url":"https://github.com/avocado-framework/avocado/pull/613#issuecomment-104650857","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/613","id":104650857,"user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"created_at":"2015-05-22T12:46:42Z","updated_at":"2015-05-22T12:46:42Z","body":"@lmr, @clebergnu, @ruda, @adereis: Hi guys, this is something controversal we need to settle before we modify avocado-virt. Actually when you try using multiplex file with avocado-virt it fails because it can't modify the params.\r\n\r\nSo my question is which way do you want to go and we should probably fix this ASAP as avocado-virt is broken."}}