{"action":"created","issue":{"url":"https://api.github.com/repos/barosl/homu/issues/47","labels_url":"https://api.github.com/repos/barosl/homu/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/barosl/homu/issues/47/comments","events_url":"https://api.github.com/repos/barosl/homu/issues/47/events","html_url":"https://github.com/barosl/homu/pull/47","id":55388981,"number":47,"title":"Replace empty statuses with \"discussing\" or \"stale\"","user":{"login":"iKevinY","id":2434728,"avatar_url":"https://avatars.githubusercontent.com/u/2434728?v=3","gravatar_id":"","url":"https://api.github.com/users/iKevinY","html_url":"https://github.com/iKevinY","followers_url":"https://api.github.com/users/iKevinY/followers","following_url":"https://api.github.com/users/iKevinY/following{/other_user}","gists_url":"https://api.github.com/users/iKevinY/gists{/gist_id}","starred_url":"https://api.github.com/users/iKevinY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iKevinY/subscriptions","organizations_url":"https://api.github.com/users/iKevinY/orgs","repos_url":"https://api.github.com/users/iKevinY/repos","events_url":"https://api.github.com/users/iKevinY/events{/privacy}","received_events_url":"https://api.github.com/users/iKevinY/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-24T23:28:46Z","updated_at":"2015-01-25T01:16:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/barosl/homu/pulls/47","html_url":"https://github.com/barosl/homu/pull/47","diff_url":"https://github.com/barosl/homu/pull/47.diff","patch_url":"https://github.com/barosl/homu/pull/47.patch"},"body":"This PR causes Homu to imitate Bors' behaviour so that \"empty statuses\" are replaced with \"discussing\" or \"stale\", depending on whether the PR can be merged. I guess this is sort of related to #45, though this implementation is of course not based on activity.\r\n\r\nAlso, the \"Number\" table header is wider than the 5-digit pull request numbers and that felt like a waste of precious horizontal pixels, so I changed it to \"PR #\". I can definitely rebase if this change is undesired."},"comment":{"url":"https://api.github.com/repos/barosl/homu/issues/comments/71345759","html_url":"https://github.com/barosl/homu/pull/47#issuecomment-71345759","issue_url":"https://api.github.com/repos/barosl/homu/issues/47","id":71345759,"user":{"login":"barosl","id":573768,"avatar_url":"https://avatars.githubusercontent.com/u/573768?v=3","gravatar_id":"","url":"https://api.github.com/users/barosl","html_url":"https://github.com/barosl","followers_url":"https://api.github.com/users/barosl/followers","following_url":"https://api.github.com/users/barosl/following{/other_user}","gists_url":"https://api.github.com/users/barosl/gists{/gist_id}","starred_url":"https://api.github.com/users/barosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barosl/subscriptions","organizations_url":"https://api.github.com/users/barosl/orgs","repos_url":"https://api.github.com/users/barosl/repos","events_url":"https://api.github.com/users/barosl/events{/privacy}","received_events_url":"https://api.github.com/users/barosl/received_events","type":"User","site_admin":false},"created_at":"2015-01-25T01:16:19Z","updated_at":"2015-01-25T01:16:19Z","body":"I'm slightly against this change.\r\n\r\nThe `Status` field was originally meant to be mapped directly to the [GitHub Statuses API](https://developer.github.com/v3/repos/statuses/). It has only four statuses: `success`, `failure`, `error`, and `pending`.\r\n\r\nIn bors, there were whole a lot more statuses: `bad`, `stale`, `discussing`, `unreviewed`, `approved`, `pending`, `tested`, `closed`. Although they are useful to categorize the PRs, I find it too confusing to have too many statuses. Those information should be provided by independent fields IMO, and that's why Homu has a dedicated `mergeable` field. This approach also increases chances to filter the PRs by some random condition, e.g. as seen by @Gankro's #33.\r\n\r\nAlso, I think it is good to use the similar terms with other CI solutions. For example, `bad` in bors was actually `error` + `failure` in Homu. `tested` was `success`, and there are some additional names that are not found in others. When I first saw the bors queue, I was overwhelmed by the number of the statuses it has. I think complying to the de facto standard of the continuous integration world is a good thing to have.\r\n\r\nBut these are just my preferences, so I want to hear more opinions on this issue. I do agree colorizing the queue may increase the readability. So let's see."}}