{"action":"created","issue":{"url":"https://api.github.com/repos/oasp/oasp4j/issues/179","labels_url":"https://api.github.com/repos/oasp/oasp4j/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/oasp/oasp4j/issues/179/comments","events_url":"https://api.github.com/repos/oasp/oasp4j/issues/179/events","html_url":"https://github.com/oasp/oasp4j/pull/179","id":57790815,"number":179,"title":"#4: Added implementation of Orika bean mapper","user":{"login":"oelsabba","id":10420200,"avatar_url":"https://avatars.githubusercontent.com/u/10420200?v=3","gravatar_id":"","url":"https://api.github.com/users/oelsabba","html_url":"https://github.com/oelsabba","followers_url":"https://api.github.com/users/oelsabba/followers","following_url":"https://api.github.com/users/oelsabba/following{/other_user}","gists_url":"https://api.github.com/users/oelsabba/gists{/gist_id}","starred_url":"https://api.github.com/users/oelsabba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oelsabba/subscriptions","organizations_url":"https://api.github.com/users/oelsabba/orgs","repos_url":"https://api.github.com/users/oelsabba/repos","events_url":"https://api.github.com/users/oelsabba/events{/privacy}","received_events_url":"https://api.github.com/users/oelsabba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-16T11:02:30Z","updated_at":"2015-02-18T08:45:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oasp/oasp4j/pulls/179","html_url":"https://github.com/oasp/oasp4j/pull/179","diff_url":"https://github.com/oasp/oasp4j/pull/179.diff","patch_url":"https://github.com/oasp/oasp4j/pull/179.patch"},"body":"Please do NOT regard merging this branch right now. In this branch an implementation of the Orika bean mapper (http://orika-mapper.github.io/orika-docs/) is introduced. Moreover, a test case is added to verify bi-directional mapping using Orika.\r\n\r\nI created a PR for that to have it reviewed/available as early as possible.\r\n\r\nIt is still missing JUnit parametrized tests that take as parameters both Orika and Dozer bean mappers together.\r\n\r\nLooking forward for your review"},"comment":{"url":"https://api.github.com/repos/oasp/oasp4j/issues/comments/74830626","html_url":"https://github.com/oasp/oasp4j/pull/179#issuecomment-74830626","issue_url":"https://api.github.com/repos/oasp/oasp4j/issues/179","id":74830626,"user":{"login":"hohwille","id":1923119,"avatar_url":"https://avatars.githubusercontent.com/u/1923119?v=3","gravatar_id":"","url":"https://api.github.com/users/hohwille","html_url":"https://github.com/hohwille","followers_url":"https://api.github.com/users/hohwille/followers","following_url":"https://api.github.com/users/hohwille/following{/other_user}","gists_url":"https://api.github.com/users/hohwille/gists{/gist_id}","starred_url":"https://api.github.com/users/hohwille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohwille/subscriptions","organizations_url":"https://api.github.com/users/hohwille/orgs","repos_url":"https://api.github.com/users/hohwille/repos","events_url":"https://api.github.com/users/hohwille/events{/privacy}","received_events_url":"https://api.github.com/users/hohwille/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T08:45:56Z","updated_at":"2015-02-18T08:45:56Z","body":"> Would appreciate if you take a look at the OrikaDozerParametrizedTest.classand tell me whether this is what you were targeting by parametrized tests?\r\n\r\nThanks for asking: You have mistaken exactly what was my suggestion. You should parameterize the technique which is dozer and orika instead of the tests. If you extract this to an abstract class that provides a method getBeanMapper() so that all @Test methods are run twice and the first run will receive a DozerMapper instance and the second run a OrikaMapper instance from getBeanMapper() you are at the point I intended."}}