{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/komoot/photon/pulls/66","id":16932412,"html_url":"https://github.com/komoot/photon/pull/66","diff_url":"https://github.com/komoot/photon/pull/66.diff","patch_url":"https://github.com/komoot/photon/pull/66.patch","issue_url":"https://api.github.com/repos/komoot/photon/issues/66","number":66,"state":"closed","locked":false,"title":"fixed snapshotting","user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"body":"There were several issues with the current snapshotting like GetSnapshot vs. RestoreSnapshot - some of them only jumped to my eyes when looking at the [ES tests](https://github.com/elasticsearch/elasticsearch/blob/master/src/test/java/org/elasticsearch/snapshots/SharedClusterSnapshotRestoreTests.java#L126). Also moved some log.error statements into exceptions as it does not make sense to continue in those cases.\r\n\r\nThere is an additional test for it now but the whole test suite does not execute properly - depends on #65\r\n\r\nUpgraded to elasticsearch as ES docs say: *Before version 1.2.0 the snapshot operation fails if cluster has any relocating or initializing primaries of indices participating in the snapshot. Starting with version 1.2.0, Elasticsearch waits for are relocating or initializing shards to start before snapshotting them.*\r\n","created_at":"2014-06-10T10:28:18Z","updated_at":"2015-03-13T15:11:20Z","closed_at":"2015-03-13T15:11:20Z","merged_at":null,"merge_commit_sha":"9504b9be1265d1a9ca8f5af72b50e73994b481cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/komoot/photon/pulls/66/commits","review_comments_url":"https://api.github.com/repos/komoot/photon/pulls/66/comments","review_comment_url":"https://api.github.com/repos/komoot/photon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/komoot/photon/issues/66/comments","statuses_url":"https://api.github.com/repos/komoot/photon/statuses/30d8458b389856816ae49db6cbbe1f7276ec22ca","head":{"label":"karussell:snapshot","ref":"snapshot","sha":"30d8458b389856816ae49db6cbbe1f7276ec22ca","user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"komoot:master","ref":"master","sha":"721add4d49ba9c2ff579b3617b7c55ae1eebba43","user":{"login":"komoot","id":1555772,"avatar_url":"https://avatars.githubusercontent.com/u/1555772?v=3","gravatar_id":"","url":"https://api.github.com/users/komoot","html_url":"https://github.com/komoot","followers_url":"https://api.github.com/users/komoot/followers","following_url":"https://api.github.com/users/komoot/following{/other_user}","gists_url":"https://api.github.com/users/komoot/gists{/gist_id}","starred_url":"https://api.github.com/users/komoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komoot/subscriptions","organizations_url":"https://api.github.com/users/komoot/orgs","repos_url":"https://api.github.com/users/komoot/repos","events_url":"https://api.github.com/users/komoot/events{/privacy}","received_events_url":"https://api.github.com/users/komoot/received_events","type":"Organization","site_admin":false},"repo":{"id":12247534,"name":"photon","full_name":"komoot/photon","owner":{"login":"komoot","id":1555772,"avatar_url":"https://avatars.githubusercontent.com/u/1555772?v=3","gravatar_id":"","url":"https://api.github.com/users/komoot","html_url":"https://github.com/komoot","followers_url":"https://api.github.com/users/komoot/followers","following_url":"https://api.github.com/users/komoot/following{/other_user}","gists_url":"https://api.github.com/users/komoot/gists{/gist_id}","starred_url":"https://api.github.com/users/komoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komoot/subscriptions","organizations_url":"https://api.github.com/users/komoot/orgs","repos_url":"https://api.github.com/users/komoot/repos","events_url":"https://api.github.com/users/komoot/events{/privacy}","received_events_url":"https://api.github.com/users/komoot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/komoot/photon","description":"an open source geocoder for openstreetmap data","fork":false,"url":"https://api.github.com/repos/komoot/photon","forks_url":"https://api.github.com/repos/komoot/photon/forks","keys_url":"https://api.github.com/repos/komoot/photon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/komoot/photon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/komoot/photon/teams","hooks_url":"https://api.github.com/repos/komoot/photon/hooks","issue_events_url":"https://api.github.com/repos/komoot/photon/issues/events{/number}","events_url":"https://api.github.com/repos/komoot/photon/events","assignees_url":"https://api.github.com/repos/komoot/photon/assignees{/user}","branches_url":"https://api.github.com/repos/komoot/photon/branches{/branch}","tags_url":"https://api.github.com/repos/komoot/photon/tags","blobs_url":"https://api.github.com/repos/komoot/photon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/komoot/photon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/komoot/photon/git/refs{/sha}","trees_url":"https://api.github.com/repos/komoot/photon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/komoot/photon/statuses/{sha}","languages_url":"https://api.github.com/repos/komoot/photon/languages","stargazers_url":"https://api.github.com/repos/komoot/photon/stargazers","contributors_url":"https://api.github.com/repos/komoot/photon/contributors","subscribers_url":"https://api.github.com/repos/komoot/photon/subscribers","subscription_url":"https://api.github.com/repos/komoot/photon/subscription","commits_url":"https://api.github.com/repos/komoot/photon/commits{/sha}","git_commits_url":"https://api.github.com/repos/komoot/photon/git/commits{/sha}","comments_url":"https://api.github.com/repos/komoot/photon/comments{/number}","issue_comment_url":"https://api.github.com/repos/komoot/photon/issues/comments{/number}","contents_url":"https://api.github.com/repos/komoot/photon/contents/{+path}","compare_url":"https://api.github.com/repos/komoot/photon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/komoot/photon/merges","archive_url":"https://api.github.com/repos/komoot/photon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/komoot/photon/downloads","issues_url":"https://api.github.com/repos/komoot/photon/issues{/number}","pulls_url":"https://api.github.com/repos/komoot/photon/pulls{/number}","milestones_url":"https://api.github.com/repos/komoot/photon/milestones{/number}","notifications_url":"https://api.github.com/repos/komoot/photon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/komoot/photon/labels{/name}","releases_url":"https://api.github.com/repos/komoot/photon/releases{/id}","created_at":"2013-08-20T16:06:16Z","updated_at":"2015-03-10T09:52:55Z","pushed_at":"2015-03-10T09:52:55Z","git_url":"git://github.com/komoot/photon.git","ssh_url":"git@github.com:komoot/photon.git","clone_url":"https://github.com/komoot/photon.git","svn_url":"https://github.com/komoot/photon","homepage":"","size":5813,"stargazers_count":194,"watchers_count":194,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":42,"forks":40,"open_issues":42,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/komoot/photon/pulls/66"},"html":{"href":"https://github.com/komoot/photon/pull/66"},"issue":{"href":"https://api.github.com/repos/komoot/photon/issues/66"},"comments":{"href":"https://api.github.com/repos/komoot/photon/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/komoot/photon/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/komoot/photon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/komoot/photon/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/komoot/photon/statuses/30d8458b389856816ae49db6cbbe1f7276ec22ca"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":166,"deletions":113,"changed_files":5}}