{"action":"closed","issue":{"url":"https://api.github.com/repos/OrchardCMS/OrchardTest/issues/2276","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardTest/issues/2276/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardTest/issues/2276/comments","events_url":"https://api.github.com/repos/OrchardCMS/OrchardTest/issues/2276/events","html_url":"https://github.com/OrchardCMS/OrchardTest/issues/2276","id":67824336,"number":2276,"title":"Exceptions in INotificationProvider cannot log in","user":{"login":"orchardbot","id":11788683,"avatar_url":"https://avatars.githubusercontent.com/u/11788683?v=3","gravatar_id":"","url":"https://api.github.com/users/orchardbot","html_url":"https://github.com/orchardbot","followers_url":"https://api.github.com/users/orchardbot/followers","following_url":"https://api.github.com/users/orchardbot/following{/other_user}","gists_url":"https://api.github.com/users/orchardbot/gists{/gist_id}","starred_url":"https://api.github.com/users/orchardbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orchardbot/subscriptions","organizations_url":"https://api.github.com/users/orchardbot/orgs","repos_url":"https://api.github.com/users/orchardbot/repos","events_url":"https://api.github.com/users/orchardbot/events{/privacy}","received_events_url":"https://api.github.com/users/orchardbot/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OrchardCMS/OrchardTest/labels/resolved","name":"resolved","color":"ededed"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/OrchardCMS/OrchardTest/milestones/9","html_url":"https://github.com/OrchardCMS/OrchardTest/milestones/Orchard%201.4","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardTest/milestones/9/labels","id":1062854,"number":9,"title":"Orchard 1.4","description":"Please read our release notes for Orchard 1.4:\n[url:http://docs.orchardproject.net/Documentation/Orchard-1-4-Release-Notes]","creator":{"login":"orchardbot","id":11788683,"avatar_url":"https://avatars.githubusercontent.com/u/11788683?v=3","gravatar_id":"","url":"https://api.github.com/users/orchardbot","html_url":"https://github.com/orchardbot","followers_url":"https://api.github.com/users/orchardbot/followers","following_url":"https://api.github.com/users/orchardbot/following{/other_user}","gists_url":"https://api.github.com/users/orchardbot/gists{/gist_id}","starred_url":"https://api.github.com/users/orchardbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orchardbot/subscriptions","organizations_url":"https://api.github.com/users/orchardbot/orgs","repos_url":"https://api.github.com/users/orchardbot/repos","events_url":"https://api.github.com/users/orchardbot/events{/privacy}","received_events_url":"https://api.github.com/users/orchardbot/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":167,"state":"closed","created_at":"2015-04-11T05:02:11Z","updated_at":"2015-04-11T19:33:05Z","due_on":"2012-02-29T08:00:00Z","closed_at":"2015-04-11T05:02:11Z"},"comments":2,"created_at":"2012-02-20T11:04:31Z","updated_at":"2015-04-11T19:33:05Z","closed_at":"2015-04-11T19:33:05Z","body":"__Sarkie__ created:\r\nhttps://orchard.codeplex.com/workitem/18449\r\n\r\nIf you have implemented an INotificationProvider and it is relying on new columns that will be run in Datamigrations, it will throw an error and it's impossible to log in.\r\n\nCurrently have to try, catch every GetNotifications() method just in case there is a new column we are doing logic on.\r\n\nI believe that the GetNotifications method should have a try catch on the iterator in the Orchard code, so a module can't take down the site, I'm guessing in the NotificationManager.cs.\n"}}