{"action":"created","comment":{"url":"https://api.github.com/repos/backbee/BackBee/pulls/comments/32409333","id":32409333,"diff_hunk":"@@ -404,9 +408,9 @@ public function extend($basedir = null, $overwrite = false)\n         }\n \n         if (\n-            false === empty($this->environment)\n-            && false === strpos($this->environment, $basedir)\n-            && true === file_exists($basedir.DIRECTORY_SEPARATOR.$this->environment)\n+            !empty($this->environment)\n+            && !strpos($this->environment, $basedir)","path":"Config/Config.php","position":null,"original_position":94,"commit_id":"b845b653addfdeb3e670094e11c791e0b701ec96","original_commit_id":"a8900e69149c35310971dc42eb94f1702887cb4f","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"Yup, strpos is misused but we dont have specific (boolean return) function for this use case in PHP.\r\n\r\nI mean, a kind of ``exists`` which always return a boolean is missing ^^","created_at":"2015-06-15T11:03:20Z","updated_at":"2015-06-15T11:03:20Z","html_url":"https://github.com/backbee/BackBee/pull/458#discussion_r32409333","pull_request_url":"https://api.github.com/repos/backbee/BackBee/pulls/458","_links":{"self":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/comments/32409333"},"html":{"href":"https://github.com/backbee/BackBee/pull/458#discussion_r32409333"},"pull_request":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/backbee/BackBee/pulls/458","id":37675176,"html_url":"https://github.com/backbee/BackBee/pull/458","diff_url":"https://github.com/backbee/BackBee/pull/458.diff","patch_url":"https://github.com/backbee/BackBee/pull/458.patch","issue_url":"https://api.github.com/repos/backbee/BackBee/issues/458","number":458,"state":"open","locked":false,"title":"Config component review","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"Some refactorings since I have read this component to write docs","created_at":"2015-06-15T09:57:07Z","updated_at":"2015-06-15T11:03:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6720c6516549ed7037235fc0d03501a43bf4059b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/backbee/BackBee/pulls/458/commits","review_comments_url":"https://api.github.com/repos/backbee/BackBee/pulls/458/comments","review_comment_url":"https://api.github.com/repos/backbee/BackBee/pulls/comments{/number}","comments_url":"https://api.github.com/repos/backbee/BackBee/issues/458/comments","statuses_url":"https://api.github.com/repos/backbee/BackBee/statuses/b845b653addfdeb3e670094e11c791e0b701ec96","head":{"label":"mickaelandrieu:config-component-review","ref":"config-component-review","sha":"b845b653addfdeb3e670094e11c791e0b701ec96","user":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"repo":{"id":31269708,"name":"BackBee","full_name":"mickaelandrieu/BackBee","owner":{"login":"mickaelandrieu","id":1247388,"avatar_url":"https://avatars.githubusercontent.com/u/1247388?v=3","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mickaelandrieu/BackBee","description":"BackBee, the Next Generation Open-Source CMS","fork":true,"url":"https://api.github.com/repos/mickaelandrieu/BackBee","forks_url":"https://api.github.com/repos/mickaelandrieu/BackBee/forks","keys_url":"https://api.github.com/repos/mickaelandrieu/BackBee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mickaelandrieu/BackBee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mickaelandrieu/BackBee/teams","hooks_url":"https://api.github.com/repos/mickaelandrieu/BackBee/hooks","issue_events_url":"https://api.github.com/repos/mickaelandrieu/BackBee/issues/events{/number}","events_url":"https://api.github.com/repos/mickaelandrieu/BackBee/events","assignees_url":"https://api.github.com/repos/mickaelandrieu/BackBee/assignees{/user}","branches_url":"https://api.github.com/repos/mickaelandrieu/BackBee/branches{/branch}","tags_url":"https://api.github.com/repos/mickaelandrieu/BackBee/tags","blobs_url":"https://api.github.com/repos/mickaelandrieu/BackBee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mickaelandrieu/BackBee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mickaelandrieu/BackBee/git/refs{/sha}","trees_url":"https://api.github.com/repos/mickaelandrieu/BackBee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mickaelandrieu/BackBee/statuses/{sha}","languages_url":"https://api.github.com/repos/mickaelandrieu/BackBee/languages","stargazers_url":"https://api.github.com/repos/mickaelandrieu/BackBee/stargazers","contributors_url":"https://api.github.com/repos/mickaelandrieu/BackBee/contributors","subscribers_url":"https://api.github.com/repos/mickaelandrieu/BackBee/subscribers","subscription_url":"https://api.github.com/repos/mickaelandrieu/BackBee/subscription","commits_url":"https://api.github.com/repos/mickaelandrieu/BackBee/commits{/sha}","git_commits_url":"https://api.github.com/repos/mickaelandrieu/BackBee/git/commits{/sha}","comments_url":"https://api.github.com/repos/mickaelandrieu/BackBee/comments{/number}","issue_comment_url":"https://api.github.com/repos/mickaelandrieu/BackBee/issues/comments{/number}","contents_url":"https://api.github.com/repos/mickaelandrieu/BackBee/contents/{+path}","compare_url":"https://api.github.com/repos/mickaelandrieu/BackBee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mickaelandrieu/BackBee/merges","archive_url":"https://api.github.com/repos/mickaelandrieu/BackBee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mickaelandrieu/BackBee/downloads","issues_url":"https://api.github.com/repos/mickaelandrieu/BackBee/issues{/number}","pulls_url":"https://api.github.com/repos/mickaelandrieu/BackBee/pulls{/number}","milestones_url":"https://api.github.com/repos/mickaelandrieu/BackBee/milestones{/number}","notifications_url":"https://api.github.com/repos/mickaelandrieu/BackBee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mickaelandrieu/BackBee/labels{/name}","releases_url":"https://api.github.com/repos/mickaelandrieu/BackBee/releases{/id}","created_at":"2015-02-24T16:37:40Z","updated_at":"2015-05-07T08:59:07Z","pushed_at":"2015-06-15T10:58:29Z","git_url":"git://github.com/mickaelandrieu/BackBee.git","ssh_url":"git@github.com:mickaelandrieu/BackBee.git","clone_url":"https://github.com/mickaelandrieu/BackBee.git","svn_url":"https://github.com/mickaelandrieu/BackBee","homepage":null,"size":26115,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"backbee:master","ref":"master","sha":"e80f04e8993d4a2f14ea453fe69b4081ee2bfa3e","user":{"login":"backbee","id":8198689,"avatar_url":"https://avatars.githubusercontent.com/u/8198689?v=3","gravatar_id":"","url":"https://api.github.com/users/backbee","html_url":"https://github.com/backbee","followers_url":"https://api.github.com/users/backbee/followers","following_url":"https://api.github.com/users/backbee/following{/other_user}","gists_url":"https://api.github.com/users/backbee/gists{/gist_id}","starred_url":"https://api.github.com/users/backbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backbee/subscriptions","organizations_url":"https://api.github.com/users/backbee/orgs","repos_url":"https://api.github.com/users/backbee/repos","events_url":"https://api.github.com/users/backbee/events{/privacy}","received_events_url":"https://api.github.com/users/backbee/received_events","type":"Organization","site_admin":false},"repo":{"id":21970893,"name":"BackBee","full_name":"backbee/BackBee","owner":{"login":"backbee","id":8198689,"avatar_url":"https://avatars.githubusercontent.com/u/8198689?v=3","gravatar_id":"","url":"https://api.github.com/users/backbee","html_url":"https://github.com/backbee","followers_url":"https://api.github.com/users/backbee/followers","following_url":"https://api.github.com/users/backbee/following{/other_user}","gists_url":"https://api.github.com/users/backbee/gists{/gist_id}","starred_url":"https://api.github.com/users/backbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/backbee/subscriptions","organizations_url":"https://api.github.com/users/backbee/orgs","repos_url":"https://api.github.com/users/backbee/repos","events_url":"https://api.github.com/users/backbee/events{/privacy}","received_events_url":"https://api.github.com/users/backbee/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/backbee/BackBee","description":"BackBee, the Next Generation Core library","fork":false,"url":"https://api.github.com/repos/backbee/BackBee","forks_url":"https://api.github.com/repos/backbee/BackBee/forks","keys_url":"https://api.github.com/repos/backbee/BackBee/keys{/key_id}","collaborators_url":"https://api.github.com/repos/backbee/BackBee/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/backbee/BackBee/teams","hooks_url":"https://api.github.com/repos/backbee/BackBee/hooks","issue_events_url":"https://api.github.com/repos/backbee/BackBee/issues/events{/number}","events_url":"https://api.github.com/repos/backbee/BackBee/events","assignees_url":"https://api.github.com/repos/backbee/BackBee/assignees{/user}","branches_url":"https://api.github.com/repos/backbee/BackBee/branches{/branch}","tags_url":"https://api.github.com/repos/backbee/BackBee/tags","blobs_url":"https://api.github.com/repos/backbee/BackBee/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/backbee/BackBee/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/backbee/BackBee/git/refs{/sha}","trees_url":"https://api.github.com/repos/backbee/BackBee/git/trees{/sha}","statuses_url":"https://api.github.com/repos/backbee/BackBee/statuses/{sha}","languages_url":"https://api.github.com/repos/backbee/BackBee/languages","stargazers_url":"https://api.github.com/repos/backbee/BackBee/stargazers","contributors_url":"https://api.github.com/repos/backbee/BackBee/contributors","subscribers_url":"https://api.github.com/repos/backbee/BackBee/subscribers","subscription_url":"https://api.github.com/repos/backbee/BackBee/subscription","commits_url":"https://api.github.com/repos/backbee/BackBee/commits{/sha}","git_commits_url":"https://api.github.com/repos/backbee/BackBee/git/commits{/sha}","comments_url":"https://api.github.com/repos/backbee/BackBee/comments{/number}","issue_comment_url":"https://api.github.com/repos/backbee/BackBee/issues/comments{/number}","contents_url":"https://api.github.com/repos/backbee/BackBee/contents/{+path}","compare_url":"https://api.github.com/repos/backbee/BackBee/compare/{base}...{head}","merges_url":"https://api.github.com/repos/backbee/BackBee/merges","archive_url":"https://api.github.com/repos/backbee/BackBee/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/backbee/BackBee/downloads","issues_url":"https://api.github.com/repos/backbee/BackBee/issues{/number}","pulls_url":"https://api.github.com/repos/backbee/BackBee/pulls{/number}","milestones_url":"https://api.github.com/repos/backbee/BackBee/milestones{/number}","notifications_url":"https://api.github.com/repos/backbee/BackBee/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/backbee/BackBee/labels{/name}","releases_url":"https://api.github.com/repos/backbee/BackBee/releases{/id}","created_at":"2014-07-18T06:51:12Z","updated_at":"2015-06-03T06:12:00Z","pushed_at":"2015-06-15T10:58:29Z","git_url":"git://github.com/backbee/BackBee.git","ssh_url":"git@github.com:backbee/BackBee.git","clone_url":"https://github.com/backbee/BackBee.git","svn_url":"https://github.com/backbee/BackBee","homepage":"","size":27920,"stargazers_count":26,"watchers_count":26,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":73,"forks":11,"open_issues":73,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/458"},"html":{"href":"https://github.com/backbee/BackBee/pull/458"},"issue":{"href":"https://api.github.com/repos/backbee/BackBee/issues/458"},"comments":{"href":"https://api.github.com/repos/backbee/BackBee/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/backbee/BackBee/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/backbee/BackBee/statuses/b845b653addfdeb3e670094e11c791e0b701ec96"}}}}