{"action":"created","comment":{"url":"https://api.github.com/repos/apache/storm/pulls/comments/28283336","id":28283336,"diff_hunk":"@@ -85,6 +85,10 @@ def init_storm_env():\n JAR_JVM_OPTS = shlex.split(os.getenv('STORM_JAR_JVM_OPTS', ''))\n JAVA_HOME = os.getenv('JAVA_HOME', None)\n JAVA_CMD = 'java' if not JAVA_HOME else os.path.join(JAVA_HOME, 'bin', 'java')\n+NIMBUS_EXTRA_CLASSPATHS = os.getenv('NIMBUS_EXTRA_CLASSPATHS', None)\n+SUPERVISOR_EXTRA_CLASSPATHS = os.getenv('SUPERVISOR_EXTRA_CLASSPATHS', None)","path":"bin/storm.py","position":5,"original_position":5,"commit_id":"c106f1337f84cf7f46be0a133b3bd17b57412d3f","original_commit_id":"c106f1337f84cf7f46be0a133b3bd17b57412d3f","user":{"login":"revans2","id":3441321,"avatar_url":"https://avatars.githubusercontent.com/u/3441321?v=3","gravatar_id":"","url":"https://api.github.com/users/revans2","html_url":"https://github.com/revans2","followers_url":"https://api.github.com/users/revans2/followers","following_url":"https://api.github.com/users/revans2/following{/other_user}","gists_url":"https://api.github.com/users/revans2/gists{/gist_id}","starred_url":"https://api.github.com/users/revans2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revans2/subscriptions","organizations_url":"https://api.github.com/users/revans2/orgs","repos_url":"https://api.github.com/users/revans2/repos","events_url":"https://api.github.com/users/revans2/events{/privacy}","received_events_url":"https://api.github.com/users/revans2/received_events","type":"User","site_admin":false},"body":"I don't see a reason to have NIMBUS and SUPERVISOR specific class paths options.  If you have a good use case, please let me know otherwise I would like to see them removed.","created_at":"2015-04-13T21:55:05Z","updated_at":"2015-04-13T21:55:05Z","html_url":"https://github.com/apache/storm/pull/516#discussion_r28283336","pull_request_url":"https://api.github.com/repos/apache/storm/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/comments/28283336"},"html":{"href":"https://github.com/apache/storm/pull/516#discussion_r28283336"},"pull_request":{"href":"https://api.github.com/repos/apache/storm/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/516","id":32864060,"html_url":"https://github.com/apache/storm/pull/516","diff_url":"https://github.com/apache/storm/pull/516.diff","patch_url":"https://github.com/apache/storm/pull/516.patch","issue_url":"https://api.github.com/repos/apache/storm/issues/516","number":516,"state":"open","locked":false,"title":"[STORM-483] extlib for external, extlib-daemon for daemo-only external","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"body":"1. Packaging creates two new directories named \"extlib\" and \"extlib-daemon\" for holding external jars, and daemons-only external jars, respectively.\r\n2. \"bin/storm\" takes the jars from the above two directories and optional external classpaths, and puts into classpath for launching exec_storm_class (for daemons).\r\n3. In supervisor, when launching a worker, worker-classpath is built from scratch (include extlib but not include extlib-daemon), rather than inherited from supervisor's current-classpath . This is for avoiding classpath leakage from daemons to workers.\r\nThanks Robert and Naga's comments and proposal.","created_at":"2015-04-08T14:16:10Z","updated_at":"2015-04-13T21:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a020a6e580bfd76ff0f7c9efc6e2ae5949dab76","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/storm/pulls/516/commits","review_comments_url":"https://api.github.com/repos/apache/storm/pulls/516/comments","review_comment_url":"https://api.github.com/repos/apache/storm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/storm/issues/516/comments","statuses_url":"https://api.github.com/repos/apache/storm/statuses/c106f1337f84cf7f46be0a133b3bd17b57412d3f","head":{"label":"zhuoliu:master","ref":"master","sha":"c106f1337f84cf7f46be0a133b3bd17b57412d3f","user":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"repo":{"id":32997908,"name":"storm","full_name":"zhuoliu/storm","owner":{"login":"zhuoliu","id":11683054,"avatar_url":"https://avatars.githubusercontent.com/u/11683054?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoliu","html_url":"https://github.com/zhuoliu","followers_url":"https://api.github.com/users/zhuoliu/followers","following_url":"https://api.github.com/users/zhuoliu/following{/other_user}","gists_url":"https://api.github.com/users/zhuoliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoliu/subscriptions","organizations_url":"https://api.github.com/users/zhuoliu/orgs","repos_url":"https://api.github.com/users/zhuoliu/repos","events_url":"https://api.github.com/users/zhuoliu/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoliu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhuoliu/storm","description":"Mirror of Apache Storm","fork":true,"url":"https://api.github.com/repos/zhuoliu/storm","forks_url":"https://api.github.com/repos/zhuoliu/storm/forks","keys_url":"https://api.github.com/repos/zhuoliu/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuoliu/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuoliu/storm/teams","hooks_url":"https://api.github.com/repos/zhuoliu/storm/hooks","issue_events_url":"https://api.github.com/repos/zhuoliu/storm/issues/events{/number}","events_url":"https://api.github.com/repos/zhuoliu/storm/events","assignees_url":"https://api.github.com/repos/zhuoliu/storm/assignees{/user}","branches_url":"https://api.github.com/repos/zhuoliu/storm/branches{/branch}","tags_url":"https://api.github.com/repos/zhuoliu/storm/tags","blobs_url":"https://api.github.com/repos/zhuoliu/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuoliu/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuoliu/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuoliu/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuoliu/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuoliu/storm/languages","stargazers_url":"https://api.github.com/repos/zhuoliu/storm/stargazers","contributors_url":"https://api.github.com/repos/zhuoliu/storm/contributors","subscribers_url":"https://api.github.com/repos/zhuoliu/storm/subscribers","subscription_url":"https://api.github.com/repos/zhuoliu/storm/subscription","commits_url":"https://api.github.com/repos/zhuoliu/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuoliu/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuoliu/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuoliu/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuoliu/storm/contents/{+path}","compare_url":"https://api.github.com/repos/zhuoliu/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuoliu/storm/merges","archive_url":"https://api.github.com/repos/zhuoliu/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuoliu/storm/downloads","issues_url":"https://api.github.com/repos/zhuoliu/storm/issues{/number}","pulls_url":"https://api.github.com/repos/zhuoliu/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuoliu/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuoliu/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuoliu/storm/labels{/name}","releases_url":"https://api.github.com/repos/zhuoliu/storm/releases{/id}","created_at":"2015-03-27T16:47:03Z","updated_at":"2015-04-08T14:15:51Z","pushed_at":"2015-04-08T14:15:51Z","git_url":"git://github.com/zhuoliu/storm.git","ssh_url":"git@github.com:zhuoliu/storm.git","clone_url":"https://github.com/zhuoliu/storm.git","svn_url":"https://github.com/zhuoliu/storm","homepage":null,"size":19335,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a6935d4befc2c5f751f40a4107ccb9d7f5e17db3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":14135470,"name":"storm","full_name":"apache/storm","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/storm","description":"Mirror of Apache Storm","fork":false,"url":"https://api.github.com/repos/apache/storm","forks_url":"https://api.github.com/repos/apache/storm/forks","keys_url":"https://api.github.com/repos/apache/storm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/storm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/storm/teams","hooks_url":"https://api.github.com/repos/apache/storm/hooks","issue_events_url":"https://api.github.com/repos/apache/storm/issues/events{/number}","events_url":"https://api.github.com/repos/apache/storm/events","assignees_url":"https://api.github.com/repos/apache/storm/assignees{/user}","branches_url":"https://api.github.com/repos/apache/storm/branches{/branch}","tags_url":"https://api.github.com/repos/apache/storm/tags","blobs_url":"https://api.github.com/repos/apache/storm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/storm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/storm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/storm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/storm/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/storm/languages","stargazers_url":"https://api.github.com/repos/apache/storm/stargazers","contributors_url":"https://api.github.com/repos/apache/storm/contributors","subscribers_url":"https://api.github.com/repos/apache/storm/subscribers","subscription_url":"https://api.github.com/repos/apache/storm/subscription","commits_url":"https://api.github.com/repos/apache/storm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/storm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/storm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/storm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/storm/contents/{+path}","compare_url":"https://api.github.com/repos/apache/storm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/storm/merges","archive_url":"https://api.github.com/repos/apache/storm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/storm/downloads","issues_url":"https://api.github.com/repos/apache/storm/issues{/number}","pulls_url":"https://api.github.com/repos/apache/storm/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/storm/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/storm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/storm/labels{/name}","releases_url":"https://api.github.com/repos/apache/storm/releases{/id}","created_at":"2013-11-05T08:00:14Z","updated_at":"2015-04-13T21:52:15Z","pushed_at":"2015-04-13T21:52:14Z","git_url":"git://github.com/apache/storm.git","ssh_url":"git@github.com:apache/storm.git","clone_url":"https://github.com/apache/storm.git","svn_url":"https://github.com/apache/storm","homepage":null,"size":917947,"stargazers_count":1791,"watchers_count":1791,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1173,"mirror_url":"git://git.apache.org/incubator-storm.git","open_issues_count":72,"forks":1173,"open_issues":72,"watchers":1791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/storm/pulls/516"},"html":{"href":"https://github.com/apache/storm/pull/516"},"issue":{"href":"https://api.github.com/repos/apache/storm/issues/516"},"comments":{"href":"https://api.github.com/repos/apache/storm/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/storm/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/storm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/storm/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/apache/storm/statuses/c106f1337f84cf7f46be0a133b3bd17b57412d3f"}}}}