{"action":"created","issue":{"url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/5","labels_url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/5/comments","events_url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/5/events","html_url":"https://github.com/HenrikBengtsson/matrixStats/issues/5","id":55247530,"number":5,"title":"INCONSISTENCY: rowAlls(<character>, value, na.rm=FALSE) gives NAs if NAs","user":{"login":"HenrikBengtsson","id":1616850,"avatar_url":"https://avatars.githubusercontent.com/u/1616850?v=3","gravatar_id":"","url":"https://api.github.com/users/HenrikBengtsson","html_url":"https://github.com/HenrikBengtsson","followers_url":"https://api.github.com/users/HenrikBengtsson/followers","following_url":"https://api.github.com/users/HenrikBengtsson/following{/other_user}","gists_url":"https://api.github.com/users/HenrikBengtsson/gists{/gist_id}","starred_url":"https://api.github.com/users/HenrikBengtsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenrikBengtsson/subscriptions","organizations_url":"https://api.github.com/users/HenrikBengtsson/orgs","repos_url":"https://api.github.com/users/HenrikBengtsson/repos","events_url":"https://api.github.com/users/HenrikBengtsson/events{/privacy}","received_events_url":"https://api.github.com/users/HenrikBengtsson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/milestones/1","labels_url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/milestones/1/labels","id":951913,"number":1,"title":"0.14.0","description":"","creator":{"login":"HenrikBengtsson","id":1616850,"avatar_url":"https://avatars.githubusercontent.com/u/1616850?v=3","gravatar_id":"","url":"https://api.github.com/users/HenrikBengtsson","html_url":"https://github.com/HenrikBengtsson","followers_url":"https://api.github.com/users/HenrikBengtsson/followers","following_url":"https://api.github.com/users/HenrikBengtsson/following{/other_user}","gists_url":"https://api.github.com/users/HenrikBengtsson/gists{/gist_id}","starred_url":"https://api.github.com/users/HenrikBengtsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenrikBengtsson/subscriptions","organizations_url":"https://api.github.com/users/HenrikBengtsson/orgs","repos_url":"https://api.github.com/users/HenrikBengtsson/repos","events_url":"https://api.github.com/users/HenrikBengtsson/events{/privacy}","received_events_url":"https://api.github.com/users/HenrikBengtsson/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":8,"state":"open","created_at":"2015-01-26T19:05:37Z","updated_at":"2015-02-10T21:51:28Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-01-23T05:50:01Z","updated_at":"2015-02-10T21:51:28Z","closed_at":"2015-02-10T21:51:28Z","body":"`rowAlls(x, value, na.rm=FALSE)` where `x` is a character matrix gives `NA`s if `NA`s in `x`.  However, if there are `NA`s, we know that not all of them can take the value `value`, so we should return `FALSE`.  See also `all(c(TRUE,NA,TRUE)) == FALSE`."},"comment":{"url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/comments/73791621","html_url":"https://github.com/HenrikBengtsson/matrixStats/issues/5#issuecomment-73791621","issue_url":"https://api.github.com/repos/HenrikBengtsson/matrixStats/issues/5","id":73791621,"user":{"login":"HenrikBengtsson","id":1616850,"avatar_url":"https://avatars.githubusercontent.com/u/1616850?v=3","gravatar_id":"","url":"https://api.github.com/users/HenrikBengtsson","html_url":"https://github.com/HenrikBengtsson","followers_url":"https://api.github.com/users/HenrikBengtsson/followers","following_url":"https://api.github.com/users/HenrikBengtsson/following{/other_user}","gists_url":"https://api.github.com/users/HenrikBengtsson/gists{/gist_id}","starred_url":"https://api.github.com/users/HenrikBengtsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenrikBengtsson/subscriptions","organizations_url":"https://api.github.com/users/HenrikBengtsson/orgs","repos_url":"https://api.github.com/users/HenrikBengtsson/repos","events_url":"https://api.github.com/users/HenrikBengtsson/events{/privacy}","received_events_url":"https://api.github.com/users/HenrikBengtsson/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T21:51:27Z","updated_at":"2015-02-10T21:51:27Z","body":"Hmm... it may be hard to rely on `rowCounts(x, value)` to infer `rowAlls(x, value)` and `rowAnys(x, value)`, particularly when there are missing values and `na.rm=FALSE`.  \r\n\r\nFalling back to use `rowAlls(x == value)` and `rowAnys(x == value)` for now.  Sub optimal, but at least fixing the bug of returning incorrect values.\r\n\r\nNote that this bug fix was only needed for non-numeric and non-logical types on `value`, e.g. characters.\r\n"}}