{"action":"created","comment":{"url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/comments/34218749","id":34218749,"diff_hunk":"@@ -30,4 +31,4 @@ on s1.ProductID = s2.ProductID;\n \n END $$\n \n-DELIMITER ;\n\\ No newline at end of file\n+DELIMITER ;","path":"config/StoredProcedures/GetAllInventory.sql","position":24,"original_position":24,"commit_id":"20fab512edeead5aedcf0ae2d5690ecddfe875ad","original_commit_id":"20fab512edeead5aedcf0ae2d5690ecddfe875ad","user":{"login":"kunmckeighan","id":4606806,"avatar_url":"https://avatars.githubusercontent.com/u/4606806?v=3","gravatar_id":"","url":"https://api.github.com/users/kunmckeighan","html_url":"https://github.com/kunmckeighan","followers_url":"https://api.github.com/users/kunmckeighan/followers","following_url":"https://api.github.com/users/kunmckeighan/following{/other_user}","gists_url":"https://api.github.com/users/kunmckeighan/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmckeighan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmckeighan/subscriptions","organizations_url":"https://api.github.com/users/kunmckeighan/orgs","repos_url":"https://api.github.com/users/kunmckeighan/repos","events_url":"https://api.github.com/users/kunmckeighan/events{/privacy}","received_events_url":"https://api.github.com/users/kunmckeighan/received_events","type":"User","site_admin":false},"body":"The new sp returns the same result as the old one for our current testing data. But what if a run which has a larger ID has a smaller DateCreated. Using \"MAX(R.DateCreated) AS LastRunDate, MAX(R.RunID) AS LastRun\" together in the select statement, there is a possibility that the LastRunDate and the LastRunID do not come from the same run. I would recommend not change it.","created_at":"2015-07-09T02:17:58Z","updated_at":"2015-07-09T02:17:58Z","html_url":"https://github.com/johnschroeder/team-c-api/pull/41#discussion_r34218749","pull_request_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/comments/34218749"},"html":{"href":"https://github.com/johnschroeder/team-c-api/pull/41#discussion_r34218749"},"pull_request":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41","id":39333564,"html_url":"https://github.com/johnschroeder/team-c-api/pull/41","diff_url":"https://github.com/johnschroeder/team-c-api/pull/41.diff","patch_url":"https://github.com/johnschroeder/team-c-api/pull/41.patch","issue_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/41","number":41,"state":"open","locked":false,"title":"Im 120","user":{"login":"kunmckeighan","id":4606806,"avatar_url":"https://avatars.githubusercontent.com/u/4606806?v=3","gravatar_id":"","url":"https://api.github.com/users/kunmckeighan","html_url":"https://github.com/kunmckeighan","followers_url":"https://api.github.com/users/kunmckeighan/followers","following_url":"https://api.github.com/users/kunmckeighan/following{/other_user}","gists_url":"https://api.github.com/users/kunmckeighan/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmckeighan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmckeighan/subscriptions","organizations_url":"https://api.github.com/users/kunmckeighan/orgs","repos_url":"https://api.github.com/users/kunmckeighan/repos","events_url":"https://api.github.com/users/kunmckeighan/events{/privacy}","received_events_url":"https://api.github.com/users/kunmckeighan/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-07T04:10:01Z","updated_at":"2015-07-09T02:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29848b9f2d20c8a0b98648a32640f8e538e59aa7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41/commits","review_comments_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41/comments","review_comment_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/41/comments","statuses_url":"https://api.github.com/repos/johnschroeder/team-c-api/statuses/20fab512edeead5aedcf0ae2d5690ecddfe875ad","head":{"label":"johnschroeder:IM-120","ref":"IM-120","sha":"20fab512edeead5aedcf0ae2d5690ecddfe875ad","user":{"login":"johnschroeder","id":6404228,"avatar_url":"https://avatars.githubusercontent.com/u/6404228?v=3","gravatar_id":"","url":"https://api.github.com/users/johnschroeder","html_url":"https://github.com/johnschroeder","followers_url":"https://api.github.com/users/johnschroeder/followers","following_url":"https://api.github.com/users/johnschroeder/following{/other_user}","gists_url":"https://api.github.com/users/johnschroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/johnschroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnschroeder/subscriptions","organizations_url":"https://api.github.com/users/johnschroeder/orgs","repos_url":"https://api.github.com/users/johnschroeder/repos","events_url":"https://api.github.com/users/johnschroeder/events{/privacy}","received_events_url":"https://api.github.com/users/johnschroeder/received_events","type":"User","site_admin":false},"repo":{"id":35451894,"name":"team-c-api","full_name":"johnschroeder/team-c-api","owner":{"login":"johnschroeder","id":6404228,"avatar_url":"https://avatars.githubusercontent.com/u/6404228?v=3","gravatar_id":"","url":"https://api.github.com/users/johnschroeder","html_url":"https://github.com/johnschroeder","followers_url":"https://api.github.com/users/johnschroeder/followers","following_url":"https://api.github.com/users/johnschroeder/following{/other_user}","gists_url":"https://api.github.com/users/johnschroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/johnschroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnschroeder/subscriptions","organizations_url":"https://api.github.com/users/johnschroeder/orgs","repos_url":"https://api.github.com/users/johnschroeder/repos","events_url":"https://api.github.com/users/johnschroeder/events{/privacy}","received_events_url":"https://api.github.com/users/johnschroeder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnschroeder/team-c-api","description":"API Repo","fork":false,"url":"https://api.github.com/repos/johnschroeder/team-c-api","forks_url":"https://api.github.com/repos/johnschroeder/team-c-api/forks","keys_url":"https://api.github.com/repos/johnschroeder/team-c-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnschroeder/team-c-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnschroeder/team-c-api/teams","hooks_url":"https://api.github.com/repos/johnschroeder/team-c-api/hooks","issue_events_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/events{/number}","events_url":"https://api.github.com/repos/johnschroeder/team-c-api/events","assignees_url":"https://api.github.com/repos/johnschroeder/team-c-api/assignees{/user}","branches_url":"https://api.github.com/repos/johnschroeder/team-c-api/branches{/branch}","tags_url":"https://api.github.com/repos/johnschroeder/team-c-api/tags","blobs_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnschroeder/team-c-api/statuses/{sha}","languages_url":"https://api.github.com/repos/johnschroeder/team-c-api/languages","stargazers_url":"https://api.github.com/repos/johnschroeder/team-c-api/stargazers","contributors_url":"https://api.github.com/repos/johnschroeder/team-c-api/contributors","subscribers_url":"https://api.github.com/repos/johnschroeder/team-c-api/subscribers","subscription_url":"https://api.github.com/repos/johnschroeder/team-c-api/subscription","commits_url":"https://api.github.com/repos/johnschroeder/team-c-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnschroeder/team-c-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnschroeder/team-c-api/contents/{+path}","compare_url":"https://api.github.com/repos/johnschroeder/team-c-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnschroeder/team-c-api/merges","archive_url":"https://api.github.com/repos/johnschroeder/team-c-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnschroeder/team-c-api/downloads","issues_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues{/number}","pulls_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls{/number}","milestones_url":"https://api.github.com/repos/johnschroeder/team-c-api/milestones{/number}","notifications_url":"https://api.github.com/repos/johnschroeder/team-c-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnschroeder/team-c-api/labels{/name}","releases_url":"https://api.github.com/repos/johnschroeder/team-c-api/releases{/id}","created_at":"2015-05-11T21:47:00Z","updated_at":"2015-05-11T22:01:21Z","pushed_at":"2015-07-09T02:00:39Z","git_url":"git://github.com/johnschroeder/team-c-api.git","ssh_url":"git@github.com:johnschroeder/team-c-api.git","clone_url":"https://github.com/johnschroeder/team-c-api.git","svn_url":"https://github.com/johnschroeder/team-c-api","homepage":null,"size":1180,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"johnschroeder:master","ref":"master","sha":"1ded8bfae9361fb457f34f8fa52ee9681b61947f","user":{"login":"johnschroeder","id":6404228,"avatar_url":"https://avatars.githubusercontent.com/u/6404228?v=3","gravatar_id":"","url":"https://api.github.com/users/johnschroeder","html_url":"https://github.com/johnschroeder","followers_url":"https://api.github.com/users/johnschroeder/followers","following_url":"https://api.github.com/users/johnschroeder/following{/other_user}","gists_url":"https://api.github.com/users/johnschroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/johnschroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnschroeder/subscriptions","organizations_url":"https://api.github.com/users/johnschroeder/orgs","repos_url":"https://api.github.com/users/johnschroeder/repos","events_url":"https://api.github.com/users/johnschroeder/events{/privacy}","received_events_url":"https://api.github.com/users/johnschroeder/received_events","type":"User","site_admin":false},"repo":{"id":35451894,"name":"team-c-api","full_name":"johnschroeder/team-c-api","owner":{"login":"johnschroeder","id":6404228,"avatar_url":"https://avatars.githubusercontent.com/u/6404228?v=3","gravatar_id":"","url":"https://api.github.com/users/johnschroeder","html_url":"https://github.com/johnschroeder","followers_url":"https://api.github.com/users/johnschroeder/followers","following_url":"https://api.github.com/users/johnschroeder/following{/other_user}","gists_url":"https://api.github.com/users/johnschroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/johnschroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnschroeder/subscriptions","organizations_url":"https://api.github.com/users/johnschroeder/orgs","repos_url":"https://api.github.com/users/johnschroeder/repos","events_url":"https://api.github.com/users/johnschroeder/events{/privacy}","received_events_url":"https://api.github.com/users/johnschroeder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnschroeder/team-c-api","description":"API Repo","fork":false,"url":"https://api.github.com/repos/johnschroeder/team-c-api","forks_url":"https://api.github.com/repos/johnschroeder/team-c-api/forks","keys_url":"https://api.github.com/repos/johnschroeder/team-c-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnschroeder/team-c-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnschroeder/team-c-api/teams","hooks_url":"https://api.github.com/repos/johnschroeder/team-c-api/hooks","issue_events_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/events{/number}","events_url":"https://api.github.com/repos/johnschroeder/team-c-api/events","assignees_url":"https://api.github.com/repos/johnschroeder/team-c-api/assignees{/user}","branches_url":"https://api.github.com/repos/johnschroeder/team-c-api/branches{/branch}","tags_url":"https://api.github.com/repos/johnschroeder/team-c-api/tags","blobs_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnschroeder/team-c-api/statuses/{sha}","languages_url":"https://api.github.com/repos/johnschroeder/team-c-api/languages","stargazers_url":"https://api.github.com/repos/johnschroeder/team-c-api/stargazers","contributors_url":"https://api.github.com/repos/johnschroeder/team-c-api/contributors","subscribers_url":"https://api.github.com/repos/johnschroeder/team-c-api/subscribers","subscription_url":"https://api.github.com/repos/johnschroeder/team-c-api/subscription","commits_url":"https://api.github.com/repos/johnschroeder/team-c-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnschroeder/team-c-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnschroeder/team-c-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnschroeder/team-c-api/contents/{+path}","compare_url":"https://api.github.com/repos/johnschroeder/team-c-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnschroeder/team-c-api/merges","archive_url":"https://api.github.com/repos/johnschroeder/team-c-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnschroeder/team-c-api/downloads","issues_url":"https://api.github.com/repos/johnschroeder/team-c-api/issues{/number}","pulls_url":"https://api.github.com/repos/johnschroeder/team-c-api/pulls{/number}","milestones_url":"https://api.github.com/repos/johnschroeder/team-c-api/milestones{/number}","notifications_url":"https://api.github.com/repos/johnschroeder/team-c-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnschroeder/team-c-api/labels{/name}","releases_url":"https://api.github.com/repos/johnschroeder/team-c-api/releases{/id}","created_at":"2015-05-11T21:47:00Z","updated_at":"2015-05-11T22:01:21Z","pushed_at":"2015-07-09T02:00:39Z","git_url":"git://github.com/johnschroeder/team-c-api.git","ssh_url":"git@github.com:johnschroeder/team-c-api.git","clone_url":"https://github.com/johnschroeder/team-c-api.git","svn_url":"https://github.com/johnschroeder/team-c-api","homepage":null,"size":1180,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41"},"html":{"href":"https://github.com/johnschroeder/team-c-api/pull/41"},"issue":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/issues/41"},"comments":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/johnschroeder/team-c-api/statuses/20fab512edeead5aedcf0ae2d5690ecddfe875ad"}}}}