{"action":"created","issue":{"url":"https://api.github.com/repos/18F/C2/issues/815","labels_url":"https://api.github.com/repos/18F/C2/issues/815/labels{/name}","comments_url":"https://api.github.com/repos/18F/C2/issues/815/comments","events_url":"https://api.github.com/repos/18F/C2/issues/815/events","html_url":"https://github.com/18F/C2/pull/815","id":118089640,"number":815,"title":"[Delivers #108372360] 18f approver can cancel","user":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/18F/C2/labels/QA-needed","name":"QA-needed","color":"fef2c0"}],"state":"open","locked":false,"assignee":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2015-11-20T17:41:05Z","updated_at":"2015-11-23T14:19:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/C2/pulls/815","html_url":"https://github.com/18F/C2/pull/815","diff_url":"https://github.com/18F/C2/pull/815.diff","patch_url":"https://github.com/18F/C2/pull/815.patch"},"body":"Story: https://www.pivotaltracker.com/story/show/108372360\r\n\r\nThis PR adds a couple methods to distinguish a *purchaser* from another kind of approver, and amends the gsa18f policy to allow non-purchaser approver on gsa18f procurement to cancel the proposal.\r\n\r\nTesting:\r\n\r\n* Verify who the gsa18f purchaser user is. That is controlled via Roles so you should be able to manage/view it from the `/admin` UI. Verify you will be able to login as that user.\r\n* Create a gsa18f procurement\r\n* Login as the approver and verify that you can cancel the procurement"},"comment":{"url":"https://api.github.com/repos/18F/C2/issues/comments/158944473","html_url":"https://github.com/18F/C2/pull/815#issuecomment-158944473","issue_url":"https://api.github.com/repos/18F/C2/issues/815","id":158944473,"user":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T14:19:53Z","updated_at":"2015-11-23T14:19:53Z","body":"@jessieay thanks for testing. Sounds like you ran into several issues -- was the Role + client_slug issue a bug in the `db:seeds` command?\r\n\r\nYou actually tested one of the two use cases:\r\n\r\n* The `purchaser` should not be able to cancel\r\n* The `approver` should be able to cancel\r\n\r\nI'm sorry I didn't make it more clear in the description. The original Story has more details."}}