{"action":"closed","number":358,"pull_request":{"url":"https://api.github.com/repos/acplt/open62541/pulls/358","id":43744414,"html_url":"https://github.com/acplt/open62541/pull/358","diff_url":"https://github.com/acplt/open62541/pull/358.diff","patch_url":"https://github.com/acplt/open62541/pull/358.patch","issue_url":"https://api.github.com/repos/acplt/open62541/issues/358","number":358,"state":"closed","locked":false,"title":"Updated  to ensure no duplicate UA_Server_addNode entries occur","user":{"login":"ngoossens","id":1468852,"avatar_url":"https://avatars.githubusercontent.com/u/1468852?v=3","gravatar_id":"","url":"https://api.github.com/users/ngoossens","html_url":"https://github.com/ngoossens","followers_url":"https://api.github.com/users/ngoossens/followers","following_url":"https://api.github.com/users/ngoossens/following{/other_user}","gists_url":"https://api.github.com/users/ngoossens/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoossens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoossens/subscriptions","organizations_url":"https://api.github.com/users/ngoossens/orgs","repos_url":"https://api.github.com/users/ngoossens/repos","events_url":"https://api.github.com/users/ngoossens/events{/privacy}","received_events_url":"https://api.github.com/users/ngoossens/received_events","type":"User","site_admin":false},"body":"There are two paths that call `self.getFirstParentNode()` (Line #656 & Line #668), these can both generate the same UA_Server_addNode call which can cause a double free issue in `nodeEntryFromNode` in `src/server/ua_nodestore.c`. \r\n\r\nAdded an if statement to ensure that the duplicate does not occur.","created_at":"2015-08-31T08:59:31Z","updated_at":"2015-09-01T06:29:31Z","closed_at":"2015-09-01T06:29:31Z","merged_at":null,"merge_commit_sha":"adebbecfb1faec06a08fa5e687c486824d12d937","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/acplt/open62541/pulls/358/commits","review_comments_url":"https://api.github.com/repos/acplt/open62541/pulls/358/comments","review_comment_url":"https://api.github.com/repos/acplt/open62541/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acplt/open62541/issues/358/comments","statuses_url":"https://api.github.com/repos/acplt/open62541/statuses/22a01ee20095714816b2a5ce130da020888696b9","head":{"label":"ngoossens:namespace-generation-fix","ref":"namespace-generation-fix","sha":"22a01ee20095714816b2a5ce130da020888696b9","user":{"login":"ngoossens","id":1468852,"avatar_url":"https://avatars.githubusercontent.com/u/1468852?v=3","gravatar_id":"","url":"https://api.github.com/users/ngoossens","html_url":"https://github.com/ngoossens","followers_url":"https://api.github.com/users/ngoossens/followers","following_url":"https://api.github.com/users/ngoossens/following{/other_user}","gists_url":"https://api.github.com/users/ngoossens/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoossens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoossens/subscriptions","organizations_url":"https://api.github.com/users/ngoossens/orgs","repos_url":"https://api.github.com/users/ngoossens/repos","events_url":"https://api.github.com/users/ngoossens/events{/privacy}","received_events_url":"https://api.github.com/users/ngoossens/received_events","type":"User","site_admin":false},"repo":{"id":41545628,"name":"open62541","full_name":"ngoossens/open62541","owner":{"login":"ngoossens","id":1468852,"avatar_url":"https://avatars.githubusercontent.com/u/1468852?v=3","gravatar_id":"","url":"https://api.github.com/users/ngoossens","html_url":"https://github.com/ngoossens","followers_url":"https://api.github.com/users/ngoossens/followers","following_url":"https://api.github.com/users/ngoossens/following{/other_user}","gists_url":"https://api.github.com/users/ngoossens/gists{/gist_id}","starred_url":"https://api.github.com/users/ngoossens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngoossens/subscriptions","organizations_url":"https://api.github.com/users/ngoossens/orgs","repos_url":"https://api.github.com/users/ngoossens/repos","events_url":"https://api.github.com/users/ngoossens/events{/privacy}","received_events_url":"https://api.github.com/users/ngoossens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngoossens/open62541","description":"An open source and free communication stack implementation of IEC 62541 aka OPC UA (OPC Unified Architecture) licensed under LGPL + static linking exception.","fork":true,"url":"https://api.github.com/repos/ngoossens/open62541","forks_url":"https://api.github.com/repos/ngoossens/open62541/forks","keys_url":"https://api.github.com/repos/ngoossens/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngoossens/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngoossens/open62541/teams","hooks_url":"https://api.github.com/repos/ngoossens/open62541/hooks","issue_events_url":"https://api.github.com/repos/ngoossens/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/ngoossens/open62541/events","assignees_url":"https://api.github.com/repos/ngoossens/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/ngoossens/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/ngoossens/open62541/tags","blobs_url":"https://api.github.com/repos/ngoossens/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngoossens/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngoossens/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngoossens/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngoossens/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/ngoossens/open62541/languages","stargazers_url":"https://api.github.com/repos/ngoossens/open62541/stargazers","contributors_url":"https://api.github.com/repos/ngoossens/open62541/contributors","subscribers_url":"https://api.github.com/repos/ngoossens/open62541/subscribers","subscription_url":"https://api.github.com/repos/ngoossens/open62541/subscription","commits_url":"https://api.github.com/repos/ngoossens/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngoossens/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngoossens/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngoossens/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngoossens/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/ngoossens/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngoossens/open62541/merges","archive_url":"https://api.github.com/repos/ngoossens/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngoossens/open62541/downloads","issues_url":"https://api.github.com/repos/ngoossens/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/ngoossens/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/ngoossens/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/ngoossens/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngoossens/open62541/labels{/name}","releases_url":"https://api.github.com/repos/ngoossens/open62541/releases{/id}","created_at":"2015-08-28T12:13:26Z","updated_at":"2015-08-28T12:13:26Z","pushed_at":"2015-08-31T08:54:24Z","git_url":"git://github.com/ngoossens/open62541.git","ssh_url":"git@github.com:ngoossens/open62541.git","clone_url":"https://github.com/ngoossens/open62541.git","svn_url":"https://github.com/ngoossens/open62541","homepage":"","size":15594,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acplt:master","ref":"master","sha":"f3379eaa19e27658647618b01ab1ad89729c06a8","user":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"repo":{"id":15333809,"name":"open62541","full_name":"acplt/open62541","owner":{"login":"acplt","id":6001152,"avatar_url":"https://avatars.githubusercontent.com/u/6001152?v=3","gravatar_id":"","url":"https://api.github.com/users/acplt","html_url":"https://github.com/acplt","followers_url":"https://api.github.com/users/acplt/followers","following_url":"https://api.github.com/users/acplt/following{/other_user}","gists_url":"https://api.github.com/users/acplt/gists{/gist_id}","starred_url":"https://api.github.com/users/acplt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acplt/subscriptions","organizations_url":"https://api.github.com/users/acplt/orgs","repos_url":"https://api.github.com/users/acplt/repos","events_url":"https://api.github.com/users/acplt/events{/privacy}","received_events_url":"https://api.github.com/users/acplt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acplt/open62541","description":"An open source and free communication stack implementation of IEC 62541 aka OPC UA (OPC Unified Architecture) licensed under LGPL + static linking exception.","fork":false,"url":"https://api.github.com/repos/acplt/open62541","forks_url":"https://api.github.com/repos/acplt/open62541/forks","keys_url":"https://api.github.com/repos/acplt/open62541/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acplt/open62541/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acplt/open62541/teams","hooks_url":"https://api.github.com/repos/acplt/open62541/hooks","issue_events_url":"https://api.github.com/repos/acplt/open62541/issues/events{/number}","events_url":"https://api.github.com/repos/acplt/open62541/events","assignees_url":"https://api.github.com/repos/acplt/open62541/assignees{/user}","branches_url":"https://api.github.com/repos/acplt/open62541/branches{/branch}","tags_url":"https://api.github.com/repos/acplt/open62541/tags","blobs_url":"https://api.github.com/repos/acplt/open62541/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acplt/open62541/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acplt/open62541/git/refs{/sha}","trees_url":"https://api.github.com/repos/acplt/open62541/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acplt/open62541/statuses/{sha}","languages_url":"https://api.github.com/repos/acplt/open62541/languages","stargazers_url":"https://api.github.com/repos/acplt/open62541/stargazers","contributors_url":"https://api.github.com/repos/acplt/open62541/contributors","subscribers_url":"https://api.github.com/repos/acplt/open62541/subscribers","subscription_url":"https://api.github.com/repos/acplt/open62541/subscription","commits_url":"https://api.github.com/repos/acplt/open62541/commits{/sha}","git_commits_url":"https://api.github.com/repos/acplt/open62541/git/commits{/sha}","comments_url":"https://api.github.com/repos/acplt/open62541/comments{/number}","issue_comment_url":"https://api.github.com/repos/acplt/open62541/issues/comments{/number}","contents_url":"https://api.github.com/repos/acplt/open62541/contents/{+path}","compare_url":"https://api.github.com/repos/acplt/open62541/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acplt/open62541/merges","archive_url":"https://api.github.com/repos/acplt/open62541/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acplt/open62541/downloads","issues_url":"https://api.github.com/repos/acplt/open62541/issues{/number}","pulls_url":"https://api.github.com/repos/acplt/open62541/pulls{/number}","milestones_url":"https://api.github.com/repos/acplt/open62541/milestones{/number}","notifications_url":"https://api.github.com/repos/acplt/open62541/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acplt/open62541/labels{/name}","releases_url":"https://api.github.com/repos/acplt/open62541/releases{/id}","created_at":"2013-12-20T08:45:05Z","updated_at":"2015-08-25T13:21:57Z","pushed_at":"2015-08-31T14:28:29Z","git_url":"git://github.com/acplt/open62541.git","ssh_url":"git@github.com:acplt/open62541.git","clone_url":"https://github.com/acplt/open62541.git","svn_url":"https://github.com/acplt/open62541","homepage":"","size":15594,"stargazers_count":45,"watchers_count":45,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":32,"forks":25,"open_issues":32,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acplt/open62541/pulls/358"},"html":{"href":"https://github.com/acplt/open62541/pull/358"},"issue":{"href":"https://api.github.com/repos/acplt/open62541/issues/358"},"comments":{"href":"https://api.github.com/repos/acplt/open62541/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/acplt/open62541/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/acplt/open62541/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acplt/open62541/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/acplt/open62541/statuses/22a01ee20095714816b2a5ce130da020888696b9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":5,"deletions":4,"changed_files":1}}