{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/30470138","id":30470138,"diff_hunk":"@@ -46,6 +47,14 @@ def zsh_completion_caveats\n     end\n   end\n \n+  def fish_completion_caveats\n+    if keg and keg.completion_installed? :fish then <<-EOS.undent\n+      fish completion has been installed to:\n+        #{HOMEBREW_PREFIX}/etc/fish/completions\n+      EOS","path":"Library/Homebrew/caveats.rb","position":16,"original_position":16,"commit_id":"1d37181bc36e96dc3d2ad5a82c3d7073dc757f34","original_commit_id":"1d37181bc36e96dc3d2ad5a82c3d7073dc757f34","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://avatars.githubusercontent.com/u/125011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://api.github.com/users/mikemcquaid/followers","following_url":"https://api.github.com/users/mikemcquaid/following{/other_user}","gists_url":"https://api.github.com/users/mikemcquaid/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemcquaid/subscriptions","organizations_url":"https://api.github.com/users/mikemcquaid/orgs","repos_url":"https://api.github.com/users/mikemcquaid/repos","events_url":"https://api.github.com/users/mikemcquaid/events{/privacy}","received_events_url":"https://api.github.com/users/mikemcquaid/received_events","type":"User","site_admin":true},"body":"Not sure what I think about this considering the relatively niche popularity of fish. Maybe worth sniffing for what the user's shell is?","created_at":"2015-05-17T12:52:04Z","updated_at":"2015-05-17T12:52:04Z","html_url":"https://github.com/Homebrew/homebrew/pull/39828#discussion_r30470138","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments/30470138"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39828#discussion_r30470138"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828","id":35578937,"html_url":"https://github.com/Homebrew/homebrew/pull/39828","diff_url":"https://github.com/Homebrew/homebrew/pull/39828.diff","patch_url":"https://github.com/Homebrew/homebrew/pull/39828.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39828","number":39828,"state":"open","locked":false,"title":"Add support for installing fish completions","user":{"login":"languitar","id":1336287,"avatar_url":"https://avatars.githubusercontent.com/u/1336287?v=3","gravatar_id":"","url":"https://api.github.com/users/languitar","html_url":"https://github.com/languitar","followers_url":"https://api.github.com/users/languitar/followers","following_url":"https://api.github.com/users/languitar/following{/other_user}","gists_url":"https://api.github.com/users/languitar/gists{/gist_id}","starred_url":"https://api.github.com/users/languitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/languitar/subscriptions","organizations_url":"https://api.github.com/users/languitar/orgs","repos_url":"https://api.github.com/users/languitar/repos","events_url":"https://api.github.com/users/languitar/events{/privacy}","received_events_url":"https://api.github.com/users/languitar/received_events","type":"User","site_admin":false},"body":"This pull request introduces support for installing completions for the fish shell comparable to bash and zsh completions. I have adapted formulae where I know about existing fish completions accordingly. Would be glad if this was accepted.","created_at":"2015-05-16T23:22:07Z","updated_at":"2015-05-17T12:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa97e1c96ea848f7afb023aeb34ad7806d0e6788","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/issues/39828/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/1d37181bc36e96dc3d2ad5a82c3d7073dc757f34","head":{"label":"languitar:fish-completions","ref":"fish-completions","sha":"1d37181bc36e96dc3d2ad5a82c3d7073dc757f34","user":{"login":"languitar","id":1336287,"avatar_url":"https://avatars.githubusercontent.com/u/1336287?v=3","gravatar_id":"","url":"https://api.github.com/users/languitar","html_url":"https://github.com/languitar","followers_url":"https://api.github.com/users/languitar/followers","following_url":"https://api.github.com/users/languitar/following{/other_user}","gists_url":"https://api.github.com/users/languitar/gists{/gist_id}","starred_url":"https://api.github.com/users/languitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/languitar/subscriptions","organizations_url":"https://api.github.com/users/languitar/orgs","repos_url":"https://api.github.com/users/languitar/repos","events_url":"https://api.github.com/users/languitar/events{/privacy}","received_events_url":"https://api.github.com/users/languitar/received_events","type":"User","site_admin":false},"repo":{"id":12210495,"name":"homebrew","full_name":"languitar/homebrew","owner":{"login":"languitar","id":1336287,"avatar_url":"https://avatars.githubusercontent.com/u/1336287?v=3","gravatar_id":"","url":"https://api.github.com/users/languitar","html_url":"https://github.com/languitar","followers_url":"https://api.github.com/users/languitar/followers","following_url":"https://api.github.com/users/languitar/following{/other_user}","gists_url":"https://api.github.com/users/languitar/gists{/gist_id}","starred_url":"https://api.github.com/users/languitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/languitar/subscriptions","organizations_url":"https://api.github.com/users/languitar/orgs","repos_url":"https://api.github.com/users/languitar/repos","events_url":"https://api.github.com/users/languitar/events{/privacy}","received_events_url":"https://api.github.com/users/languitar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/languitar/homebrew","description":"The missing package manager for OS X.","fork":true,"url":"https://api.github.com/repos/languitar/homebrew","forks_url":"https://api.github.com/repos/languitar/homebrew/forks","keys_url":"https://api.github.com/repos/languitar/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/languitar/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/languitar/homebrew/teams","hooks_url":"https://api.github.com/repos/languitar/homebrew/hooks","issue_events_url":"https://api.github.com/repos/languitar/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/languitar/homebrew/events","assignees_url":"https://api.github.com/repos/languitar/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/languitar/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/languitar/homebrew/tags","blobs_url":"https://api.github.com/repos/languitar/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/languitar/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/languitar/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/languitar/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/languitar/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/languitar/homebrew/languages","stargazers_url":"https://api.github.com/repos/languitar/homebrew/stargazers","contributors_url":"https://api.github.com/repos/languitar/homebrew/contributors","subscribers_url":"https://api.github.com/repos/languitar/homebrew/subscribers","subscription_url":"https://api.github.com/repos/languitar/homebrew/subscription","commits_url":"https://api.github.com/repos/languitar/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/languitar/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/languitar/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/languitar/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/languitar/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/languitar/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/languitar/homebrew/merges","archive_url":"https://api.github.com/repos/languitar/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/languitar/homebrew/downloads","issues_url":"https://api.github.com/repos/languitar/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/languitar/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/languitar/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/languitar/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/languitar/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/languitar/homebrew/releases{/id}","created_at":"2013-08-19T07:52:19Z","updated_at":"2014-06-19T16:08:04Z","pushed_at":"2015-05-16T23:18:49Z","git_url":"git://github.com/languitar/homebrew.git","ssh_url":"git@github.com:languitar/homebrew.git","clone_url":"https://github.com/languitar/homebrew.git","svn_url":"https://github.com/languitar/homebrew","homepage":"http://brew.sh","size":42977,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"e4e6da9e6904fecdfd82dccb74fb7e64af4ada97","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":206084,"name":"homebrew","full_name":"Homebrew/homebrew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew","description":":beer: The missing package manager for OS X.","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew","forks_url":"https://api.github.com/repos/Homebrew/homebrew/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew/releases{/id}","created_at":"2009-05-20T19:38:37Z","updated_at":"2015-05-17T10:41:57Z","pushed_at":"2015-05-17T11:50:53Z","git_url":"git://github.com/Homebrew/homebrew.git","ssh_url":"git@github.com:Homebrew/homebrew.git","clone_url":"https://github.com/Homebrew/homebrew.git","svn_url":"https://github.com/Homebrew/homebrew","homepage":"http://brew.sh","size":1522966,"stargazers_count":22954,"watchers_count":22954,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":11564,"mirror_url":null,"open_issues_count":402,"forks":11564,"open_issues":402,"watchers":22954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/39828"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39828"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/issues/39828/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew/pulls/39828/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew/statuses/1d37181bc36e96dc3d2ad5a82c3d7073dc757f34"}}}}