{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/48312941","id":48312941,"diff_hunk":"@@ -0,0 +1,423 @@\n+/**\n+ * Copyright 2015 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import {Layout} from '../../../src/layout';\n+import {assertHttpsUrl} from '../../../src/url';\n+import {assert} from '../../../src/asserts';\n+import {cidFor} from '../../../src/cid';\n+import {getService} from '../../../src/service';\n+import {log} from '../../../src/log';\n+import {viewerFor} from '../../../src/viewer';\n+import {onDocumentReady} from '../../../src/document-state';\n+import {xhrFor} from '../../../src/xhr';\n+\n+\n+const TAG_ = 'AmpUserNotification';\n+\n+/**\n+ * @export\n+ * @typedef {{\n+ *   elementId: string,\n+ *   ampUserId: string\n+ * }}\n+ */\n+let PostRequestMetadata;\n+\n+/**\n+ * @export\n+ * @typedef {{\n+ *   showNotification: boolean\n+ * }}\n+ */\n+let PostResponseMetadata;\n+\n+/**\n+ * @typedef {{\n+ *   promise: !Promise,\n+ *   resolve: function(*)\n+ * }}\n+ */\n+let UserNotificationDefer;\n+\n+\n+class NotificationInterface {\n+\n+  /**\n+   * Retrieves the id to associate to the Notification.\n+   * @return {string}\n+   */\n+  getId() {}\n+\n+  /**\n+   * Promise that is resolved with a boolean on wether this Notification\n+   * should be shown or not.\n+   * @return {!Promise<boolean>}\n+   */\n+  shouldShow() {}\n+\n+  /**\n+   * Turns the Notification Component visible.\n+   */\n+  show() {}\n+\n+  /**\n+   * Hides the Notification Component.\n+   */\n+  hide() {}\n+\n+  /**\n+   * Returns a Promise that is only ever resolved if the current\n+   * Notifiation has been dismissed by the user.\n+   * @return {!Promise}\n+   */\n+  isDismissed() {}\n+}\n+\n+/**\n+ * Component class that handles a simple notification.\n+ * @implements {NotificationInterface}\n+ */\n+export class AmpUserNotification extends AMP.BaseElement {\n+\n+  /** @override */\n+  isLayoutSupported(layout) {\n+    return layout == Layout.NODISPLAY;\n+  }\n+\n+  /**\n+   * @private\n+   */\n+  isExperimentOn_() {\n+\n+  }\n+\n+  /** @override */\n+  buildCallback() {\n+\n+    /** @private @const {!Window} */\n+    this.win_ = this.getWin();\n+\n+    /** @private @const {!UserNotificationService} */\n+    this.userNotification_ = getUserNotification_(this.win_);\n+\n+    this.elementId_ = assert(this.element.id, 'amp-user-notification should ' +\n+        'have an id.');\n+\n+    /** @private {?string} */\n+    this.ampUserId_ = null;\n+\n+    assert(this.element.hasAttribute('data-show-if-href'),\n+        `\"amp-user-notification\" (${this.elementId_}) ` +\n+        'should have \"data-show-if-href\" attribute.');\n+    /** @private @const {string} */\n+    this.showIfHref_ = assertHttpsUrl(\n+        this.element.getAttribute('data-show-if-href'), this.element);\n+\n+    assert(this.element.hasAttribute('data-dismiss-href'),\n+        `\"amp-user-notification\" (${this.elementId_}) ` +\n+        'should have \"data-dismiss-href\" attribute.');\n+    /** @private @const {string} */\n+    this.dismissHref_ = assertHttpsUrl(\n+        this.element.getAttribute('data-dismiss-href'), this.element);\n+\n+    /** @private {?Promise} */\n+    this.getIfHrefPromise_ = null;\n+\n+    /** @private {?function(boolean)} */\n+    this.dialogResolve_ = null;\n+\n+    /** @private @const {!Promise} */\n+    this.layoutPromise_ = new Promise((resolve, reject) => {","path":"extensions/amp-user-notification/0.1/amp-user-notification.js","position":143,"original_position":143,"commit_id":"c4c48a3d5958babcfe3ed6fba12b48c5549cfb79","original_commit_id":"c4c48a3d5958babcfe3ed6fba12b48c5549cfb79","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"no longer needed.","created_at":"2015-12-23T00:19:39Z","updated_at":"2015-12-23T00:19:39Z","html_url":"https://github.com/ampproject/amphtml/pull/1178#discussion_r48312941","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1178","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/48312941"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1178#discussion_r48312941"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1178"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/1178","id":53926257,"html_url":"https://github.com/ampproject/amphtml/pull/1178","diff_url":"https://github.com/ampproject/amphtml/pull/1178.diff","patch_url":"https://github.com/ampproject/amphtml/pull/1178.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/1178","number":1178,"state":"open","locked":false,"title":"feature(amp-user-notification): add amp-user-notification element.","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/ampproject/amphtml/issues/902\r\n\r\ncouple of tasks i need to complete, writing down just so i dont forget.\r\n\r\n- [ ] add tag to validator\r\n- [ ] create nicer demo with transition to the next notification\r\n- [ ] finish style section\r\n- [x] document the notification queuing","created_at":"2015-12-17T02:10:13Z","updated_at":"2015-12-23T00:19:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71a768007d43dfdea7d471be8bc02bb761c26dae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1178/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/1178/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/1178/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/c4c48a3d5958babcfe3ed6fba12b48c5549cfb79","head":{"label":"erwinmombay:amp-notify","ref":"amp-notify","sha":"c4c48a3d5958babcfe3ed6fba12b48c5549cfb79","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"repo":{"id":43843790,"name":"amphtml","full_name":"erwinmombay/amphtml","owner":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erwinmombay/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/erwinmombay/amphtml","forks_url":"https://api.github.com/repos/erwinmombay/amphtml/forks","keys_url":"https://api.github.com/repos/erwinmombay/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erwinmombay/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erwinmombay/amphtml/teams","hooks_url":"https://api.github.com/repos/erwinmombay/amphtml/hooks","issue_events_url":"https://api.github.com/repos/erwinmombay/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/erwinmombay/amphtml/events","assignees_url":"https://api.github.com/repos/erwinmombay/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/erwinmombay/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/erwinmombay/amphtml/tags","blobs_url":"https://api.github.com/repos/erwinmombay/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erwinmombay/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erwinmombay/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/erwinmombay/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erwinmombay/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/erwinmombay/amphtml/languages","stargazers_url":"https://api.github.com/repos/erwinmombay/amphtml/stargazers","contributors_url":"https://api.github.com/repos/erwinmombay/amphtml/contributors","subscribers_url":"https://api.github.com/repos/erwinmombay/amphtml/subscribers","subscription_url":"https://api.github.com/repos/erwinmombay/amphtml/subscription","commits_url":"https://api.github.com/repos/erwinmombay/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/erwinmombay/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/erwinmombay/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/erwinmombay/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/erwinmombay/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/erwinmombay/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erwinmombay/amphtml/merges","archive_url":"https://api.github.com/repos/erwinmombay/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erwinmombay/amphtml/downloads","issues_url":"https://api.github.com/repos/erwinmombay/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/erwinmombay/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/erwinmombay/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/erwinmombay/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erwinmombay/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/erwinmombay/amphtml/releases{/id}","created_at":"2015-10-07T20:45:56Z","updated_at":"2015-10-07T20:45:57Z","pushed_at":"2015-12-23T00:16:36Z","git_url":"git://github.com/erwinmombay/amphtml.git","ssh_url":"git@github.com:erwinmombay/amphtml.git","clone_url":"https://github.com/erwinmombay/amphtml.git","svn_url":"https://github.com/erwinmombay/amphtml","homepage":"","size":14164,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"180a2e6cf95dded51d7599b5fd5d282ce448860e","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","created_at":"2015-09-01T22:10:53Z","updated_at":"2015-12-23T00:04:27Z","pushed_at":"2015-12-23T00:17:40Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":15920,"stargazers_count":5094,"watchers_count":5094,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":500,"mirror_url":null,"open_issues_count":187,"forks":500,"open_issues":187,"watchers":5094,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1178"},"html":{"href":"https://github.com/ampproject/amphtml/pull/1178"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1178"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/1178/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1178/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/1178/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/c4c48a3d5958babcfe3ed6fba12b48c5549cfb79"}}}}