{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/29025915","id":29025915,"diff_hunk":"@@ -0,0 +1,52 @@\n+package com.hazelcast.map.impl.operation;\n+\n+import com.hazelcast.map.QueryResultSizeExceededException;\n+import com.hazelcast.map.impl.QueryResult;\n+import com.hazelcast.query.TruePredicate;\n+import org.junit.Test;\n+\n+import static org.junit.Assert.assertEquals;\n+\n+public class QueryPartitionOperationTest extends QueryOperationTestSupport {\n+\n+    @Override\n+    protected AbstractMapOperation createQueryOperation() {\n+        return new QueryPartitionOperation(MAP_NAME, TruePredicate.INSTANCE);\n+    }\n+\n+    @Test\n+    public void testConstructor() {\n+        new QueryPartitionOperation();","path":"hazelcast/src/test/java/com/hazelcast/map/impl/operation/QueryPartitionOperationTest.java","position":19,"original_position":19,"commit_id":"367b54f933ddc600cc14fe95fbcd079f6a47c4c0","original_commit_id":"367b54f933ddc600cc14fe95fbcd079f6a47c4c0","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"I see that very differently:\r\n* It provided the only usage in code for the default constructor, so there is no need for a `@SuppressWarnings(\"unused\")` in the class.\r\n* It ensures that the default constructor doesn't get deleted, because it looks unused, which will cause runtime exceptions, not compile time exceptions.\r\n* It increases code coverage with a unit test (not all tests are executed in all builds, especially the slow nightly integration tests which will use the constructor).","created_at":"2015-04-24T06:17:55Z","updated_at":"2015-04-24T06:17:55Z","html_url":"https://github.com/hazelcast/hazelcast/pull/5124#discussion_r29025915","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/29025915"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5124#discussion_r29025915"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124","id":33747843,"html_url":"https://github.com/hazelcast/hazelcast/pull/5124","diff_url":"https://github.com/hazelcast/hazelcast/pull/5124.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/5124.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5124","number":5124,"state":"open","locked":false,"title":"Added max result size limit for query operations.","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"This is the actual implementation of the \"unbounded return values\" feature for HZ 3.5.\r\n\r\nMost of the code is new test code. I hope I covered all needed classes and scenarios. I have no idea how to test the new client. Maybe we have to do a follow-up PR with some changes if the new client is fully wired and in place.\r\n\r\nThere is also a big issue with `ClientMapProxy.entrySet()` which seems to have a O(n²) complexity, so it takes too long to test it at the moment. I will create a separate issue for that, please let's not discuss that in this PR. It is not an issue of this feature or these changes. It's most probably a very old problem.","created_at":"2015-04-21T10:27:28Z","updated_at":"2015-04-24T06:17:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b916d79ca5d009b8e9fe3f4ce24b178fb40dde3","assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.5","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55/labels","id":819785,"number":55,"title":"3.5","description":null,"creator":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"open_issues":134,"closed_issues":427,"state":"open","created_at":"2014-10-09T13:04:53Z","updated_at":"2015-04-24T04:59:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/5124/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/367b54f933ddc600cc14fe95fbcd079f6a47c4c0","head":{"label":"Donnerbart:unboundedReturnValues","ref":"unboundedReturnValues","sha":"367b54f933ddc600cc14fe95fbcd079f6a47c4c0","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":13138412,"name":"hazelcast","full_name":"Donnerbart/hazelcast","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast/releases{/id}","created_at":"2013-09-27T01:15:56Z","updated_at":"2015-04-23T14:15:35Z","pushed_at":"2015-04-23T15:10:08Z","git_url":"git://github.com/Donnerbart/hazelcast.git","ssh_url":"git@github.com:Donnerbart/hazelcast.git","clone_url":"https://github.com/Donnerbart/hazelcast.git","svn_url":"https://github.com/Donnerbart/hazelcast","homepage":"www.hazelcast.com","size":65176,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"e6cfbf3678a536939926d4bb809cc4173c0a26ec","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-04-24T00:45:57Z","pushed_at":"2015-04-24T06:05:10Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":135870,"stargazers_count":1090,"watchers_count":1090,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":519,"mirror_url":null,"open_issues_count":490,"forks":519,"open_issues":490,"watchers":1090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/5124"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5124"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/5124/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/5124/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/367b54f933ddc600cc14fe95fbcd079f6a47c4c0"}}}}