{"push_id":854439536,"size":7,"distinct_size":7,"ref":"refs/heads/jenkins","head":"87b7c330653431d43e3ca5fc3eb1dc28342ac1a3","before":"6c5f371a27f901d5bc60cf5a2a11cf6629f96f78","commits":[{"sha":"9a3211ce2ebdd3debd2e20e28d83dd13cb0ac467","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"i965/skl: Add fast color clear infrastructure\n\nPatch was originally called:\ni965/skl: Enable fast color clears on SKL\n\nSkylake introduces some differences in the way that fast clears are programmed\nand in the restrictions for using fast clears. Since some of these are\nnon-obvious, and fast clears are currently disabled globally, we can enable the\nsimple stuff here and leave the weirder stuff and separately reviewable work.\n\nBased on a patch originally from Kristian.\n\nNote that within this patch the change in scaling factors could be achieved with\nthis hunk instead. I've opted to keep things more like how the docs describe it\nhowever.\n--- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c\n+++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c\n@@ -150,9 +150,13 @@ intel_get_non_msrt_mcs_alignment(struct brw_context *brw,\n       /* In release builds, fall through */\n    case I915_TILING_Y:\n       *width_px = 32 / mt->cpp;\n-      *height = 4;\n+      if (brw->gen >= 9)\n+         *height = 2;\n+      else\n+         *height = 4;\n\nv2: Add braces for the multiline (Matt + Chad)\nComment updates (requested by Chad)\nModified commit message\n\nReviewed-by: Neil Roberts <neil@linux.intel.com>\nSigned-off-by: Ben Widawsky <ben@bwidawsk.net>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/9a3211ce2ebdd3debd2e20e28d83dd13cb0ac467"},{"sha":"6b000346e44a224061855c6b9473077bf30987b7","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"i965/skl: skip fast clears for certain surface formats\n\nInitially I had this planned as a patch to be squashed in to the enabling patch\nbecause there is no point enabling fast clears without this. However, Chad\nmerged a patch which disables fast clears on gen9 explicitly, and so I can hide\nthis behind the revert of that patch. I really wanted this patch\nas a distinct patch for review because it is behaviorally different on gen9 than\nprevious gens. This is a new, weird, and poorly documented restriction for SKL.\n(In fact, I am still not 100% certain the restriction is entirely necessary, but\nthere are around 30 piglit regressions without this).\n\nSKL adds compressible render targets and as a result mutates some of the\nprogramming for fast clears and resolves. There is a new internal surface type\ncalled the CCS. The old AUX_MCS bit becomes AUX_CCS_D. \"The Auxiliary surface is\na CCS (Color Control Surface) with compression disabled or an MCS with\ncompression enabled, depending on number of multisamples. MCS (Multisample\nControl Surface) is a special type of CCS.\"\n\nv2: Use better English in commit message (Matt)\ns/compressable/compressible/ (Matt)\nDon't compare bools to true (Matt)\n\nSigned-off-by: Ben Widawsky <ben@bwidawsk.net>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/6b000346e44a224061855c6b9473077bf30987b7"},{"sha":"64ada1688a636ba38edcee7ff8571ef405710cae","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"i965/meta/gen9: Individually fast clear color attachments\n\nThe impetus for this patch comes from a seemingly benign statement within the\nspec (quoted within the patch). For me, this patch was at some point critical\nfor getting stable piglit results (though this did not seem to be the case on a\nbranch Chad was working on).\n\nIt is very important for clearing multiple color buffer attachments and can be\nobserved in the following piglit tests:\nspec/arb_framebuffer_object/fbo-drawbuffers-none glclear\nspec/ext_framebuffer_multisample/blit-multiple-render-targets 0\n\nSigned-off-by: Ben Widawsky <ben@bwidawsk.net>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/64ada1688a636ba38edcee7ff8571ef405710cae"},{"sha":"9e970b6cd65f1e2e70d6e6a59aefc87833d011d8","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"Revert \"i965/gen9: Disable MCS for 1x color surfaces\"\n\nThis reverts commit dcd59a9e322edeea74187bcad65a8e56c0bfaaa2.\n\nReviewed-by: Neil Roberts <neil@linux.intel.com>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/9e970b6cd65f1e2e70d6e6a59aefc87833d011d8"},{"sha":"0313275cd350e0df66a8ab16ae1339138d6e291f","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"Revert \"i965/gen9: Enable rep clears on gen9\"\n\nThis reverts commit 8a0c85b25853decb4a110b6d36d79c4f095d437b.\n\nIt's not a strict revert because I don't want to bring back the gen < 9 check at\nthis point in time.\n\nReviewed-by: Neil Roberts <neil@linux.intel.com>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/0313275cd350e0df66a8ab16ae1339138d6e291f"},{"sha":"64cbe30cb9dc98e182af5c69d3aacfd4f7a47ca4","author":{"email":"cf148a1c890adeeb4308e9e093ed95f3d05c8318@intel.com","name":"Ben Widawsky"},"message":"i965/gen9: Support fast clears for 32b float\n\nSKL supports the ability to do fast clears and resolves of 32b RGBA as both\ninteger and floats. This patch only enables float color clears because we\nhaven't yet enabled integer color clears, (HW support for that was added in\nBDW).\n\nThis is enabled separate because it is a new feature to SKL and so it might have\nsome issues.\n\nNOTE: This patch has 2 regressions with 16F_LUMINANCE and 16F_INTENSITY which\nneeds to be resolved before merging. The rest of the test suites are happy.\n./bin/ext_framebuffer_multisample-formats [2468]\n...\nTesting GL_LUMINANCE16F_ARB\nProbe at (0,0)\n  Expected: 0.000000\n  Observed: 0.500000\nProbe at (0,0)\n  Expected: 0.000000\n  Observed: 0.500000\n\nNot-Signed-off-by: Ben Widawsky <ben@bwidawsk.net>","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/64cbe30cb9dc98e182af5c69d3aacfd4f7a47ca4"},{"sha":"87b7c330653431d43e3ca5fc3eb1dc28342ac1a3","author":{"email":"822ec91a7ef82248fd36162ca8ac3283eba70848@linux.intel.com","name":"Neil Roberts"},"message":"i965/skl: Hacks for fast clear\n\nThe spec says that for multisampled buffers only the values 0 and 1\nare allowed. This patch adds that restriction.\n\nHowever I found that setting the fast clear color value to 0.0f or\n1.0f like you would expect doesn't work and both values get read back\nas 0.0f. By experimenation I found that for whatever reason setting it\nto 0 and -1 as integers does work. This isn't necessary for\nsingle-sampled buffers.","distinct":true,"url":"https://api.github.com/repos/bpeel/mesa/commits/87b7c330653431d43e3ca5fc3eb1dc28342ac1a3"}]}