{"action":"closed","number":1689,"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689","id":35294411,"html_url":"https://github.com/EFForg/https-everywhere/pull/1689","diff_url":"https://github.com/EFForg/https-everywhere/pull/1689.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/1689.patch","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/1689","number":1689,"state":"closed","locked":false,"title":"Make 'make clean' clean up pkg/xpi-amo and pkg/xpi-eff","user":{"login":"mnordhoff","id":1025227,"avatar_url":"https://avatars.githubusercontent.com/u/1025227?v=3","gravatar_id":"","url":"https://api.github.com/users/mnordhoff","html_url":"https://github.com/mnordhoff","followers_url":"https://api.github.com/users/mnordhoff/followers","following_url":"https://api.github.com/users/mnordhoff/following{/other_user}","gists_url":"https://api.github.com/users/mnordhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mnordhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnordhoff/subscriptions","organizations_url":"https://api.github.com/users/mnordhoff/orgs","repos_url":"https://api.github.com/users/mnordhoff/repos","events_url":"https://api.github.com/users/mnordhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mnordhoff/received_events","type":"User","site_admin":false},"body":"For normal functioning, this change is 100% unnecessary. (makexpi.sh itself cleans them up before it starts building.) Nonetheless, as relatively large build artifacts (15 MB total), my sense of order in the universe wants `make clean` to handle them. :-P","created_at":"2015-05-13T04:57:19Z","updated_at":"2015-05-13T17:13:04Z","closed_at":"2015-05-13T17:13:04Z","merged_at":"2015-05-13T17:13:04Z","merge_commit_sha":"26b082b69a6e65d50fbd5e4b48667cf913ffb7c4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689/commits","review_comments_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689/comments","review_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/1689/comments","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/0934228f73888fb16244428c34d39cd1cb86dd46","head":{"label":"mnordhoff:make-clean-xpi-amo-xpi-eff","ref":"make-clean-xpi-amo-xpi-eff","sha":"0934228f73888fb16244428c34d39cd1cb86dd46","user":{"login":"mnordhoff","id":1025227,"avatar_url":"https://avatars.githubusercontent.com/u/1025227?v=3","gravatar_id":"","url":"https://api.github.com/users/mnordhoff","html_url":"https://github.com/mnordhoff","followers_url":"https://api.github.com/users/mnordhoff/followers","following_url":"https://api.github.com/users/mnordhoff/following{/other_user}","gists_url":"https://api.github.com/users/mnordhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mnordhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnordhoff/subscriptions","organizations_url":"https://api.github.com/users/mnordhoff/orgs","repos_url":"https://api.github.com/users/mnordhoff/repos","events_url":"https://api.github.com/users/mnordhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mnordhoff/received_events","type":"User","site_admin":false},"repo":{"id":30882909,"name":"https-everywhere","full_name":"mnordhoff/https-everywhere","owner":{"login":"mnordhoff","id":1025227,"avatar_url":"https://avatars.githubusercontent.com/u/1025227?v=3","gravatar_id":"","url":"https://api.github.com/users/mnordhoff","html_url":"https://github.com/mnordhoff","followers_url":"https://api.github.com/users/mnordhoff/followers","following_url":"https://api.github.com/users/mnordhoff/following{/other_user}","gists_url":"https://api.github.com/users/mnordhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mnordhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnordhoff/subscriptions","organizations_url":"https://api.github.com/users/mnordhoff/orgs","repos_url":"https://api.github.com/users/mnordhoff/repos","events_url":"https://api.github.com/users/mnordhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mnordhoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnordhoff/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":true,"url":"https://api.github.com/repos/mnordhoff/https-everywhere","forks_url":"https://api.github.com/repos/mnordhoff/https-everywhere/forks","keys_url":"https://api.github.com/repos/mnordhoff/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnordhoff/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnordhoff/https-everywhere/teams","hooks_url":"https://api.github.com/repos/mnordhoff/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/mnordhoff/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/mnordhoff/https-everywhere/events","assignees_url":"https://api.github.com/repos/mnordhoff/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/mnordhoff/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/mnordhoff/https-everywhere/tags","blobs_url":"https://api.github.com/repos/mnordhoff/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnordhoff/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnordhoff/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnordhoff/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnordhoff/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/mnordhoff/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/mnordhoff/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/mnordhoff/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/mnordhoff/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/mnordhoff/https-everywhere/subscription","commits_url":"https://api.github.com/repos/mnordhoff/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnordhoff/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnordhoff/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnordhoff/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnordhoff/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/mnordhoff/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnordhoff/https-everywhere/merges","archive_url":"https://api.github.com/repos/mnordhoff/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnordhoff/https-everywhere/downloads","issues_url":"https://api.github.com/repos/mnordhoff/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/mnordhoff/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/mnordhoff/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/mnordhoff/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnordhoff/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/mnordhoff/https-everywhere/releases{/id}","created_at":"2015-02-16T18:53:58Z","updated_at":"2015-03-23T21:06:16Z","pushed_at":"2015-05-13T12:59:46Z","git_url":"git://github.com/mnordhoff/https-everywhere.git","ssh_url":"git@github.com:mnordhoff/https-everywhere.git","clone_url":"https://github.com/mnordhoff/https-everywhere.git","svn_url":"https://github.com/mnordhoff/https-everywhere","homepage":"https://eff.org/https-everywhere","size":63249,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"875e7ad6b315aff9993a42a834c3589e30f6227a","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":14939303,"name":"https-everywhere","full_name":"EFForg/https-everywhere","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":false,"url":"https://api.github.com/repos/EFForg/https-everywhere","forks_url":"https://api.github.com/repos/EFForg/https-everywhere/forks","keys_url":"https://api.github.com/repos/EFForg/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/https-everywhere/teams","hooks_url":"https://api.github.com/repos/EFForg/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/https-everywhere/events","assignees_url":"https://api.github.com/repos/EFForg/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/https-everywhere/tags","blobs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/EFForg/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/EFForg/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/EFForg/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/EFForg/https-everywhere/subscription","commits_url":"https://api.github.com/repos/EFForg/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/https-everywhere/merges","archive_url":"https://api.github.com/repos/EFForg/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/https-everywhere/downloads","issues_url":"https://api.github.com/repos/EFForg/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/https-everywhere/releases{/id}","created_at":"2013-12-04T23:53:07Z","updated_at":"2015-05-12T20:13:35Z","pushed_at":"2015-05-13T17:13:04Z","git_url":"git://github.com/EFForg/https-everywhere.git","ssh_url":"git@github.com:EFForg/https-everywhere.git","clone_url":"https://github.com/EFForg/https-everywhere.git","svn_url":"https://github.com/EFForg/https-everywhere","homepage":"https://eff.org/https-everywhere","size":161225,"stargazers_count":600,"watchers_count":600,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":266,"forks":284,"open_issues":266,"watchers":600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/1689"},"issue":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/1689"},"comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/1689/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1689/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/https-everywhere/statuses/0934228f73888fb16244428c34d39cd1cb86dd46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}