{"action":"opened","number":145,"pull_request":{"url":"https://api.github.com/repos/Geal/nom/pulls/145","id":53950610,"html_url":"https://github.com/Geal/nom/pull/145","diff_url":"https://github.com/Geal/nom/pull/145.diff","patch_url":"https://github.com/Geal/nom/pull/145.patch","issue_url":"https://api.github.com/repos/Geal/nom/issues/145","number":145,"state":"open","locked":false,"title":"Add AtEof trait to determine when input has finished.","user":{"login":"jsgf","id":147966,"avatar_url":"https://avatars.githubusercontent.com/u/147966?v=3","gravatar_id":"","url":"https://api.github.com/users/jsgf","html_url":"https://github.com/jsgf","followers_url":"https://api.github.com/users/jsgf/followers","following_url":"https://api.github.com/users/jsgf/following{/other_user}","gists_url":"https://api.github.com/users/jsgf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsgf/subscriptions","organizations_url":"https://api.github.com/users/jsgf/orgs","repos_url":"https://api.github.com/users/jsgf/repos","events_url":"https://api.github.com/users/jsgf/events{/privacy}","received_events_url":"https://api.github.com/users/jsgf/received_events","type":"User","site_admin":false},"body":"This is an attempt to address issue #144.\r\n\r\nWith this trait, it becomes possible to distinguish between a partial input\r\nand a complete input. If there's a partial input, then it makes sense to\r\nreturn Incomplete, but if the input is finished then it's just a plain\r\nError. The need_more() function encapsulates this logic.\r\n\r\nThis is still a work in progress; it breaks a couple of unit tests, presumably because they're expecting Incomplete where now they're getting eof.","created_at":"2015-12-17T09:11:16Z","updated_at":"2015-12-17T09:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geal/nom/pulls/145/commits","review_comments_url":"https://api.github.com/repos/Geal/nom/pulls/145/comments","review_comment_url":"https://api.github.com/repos/Geal/nom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geal/nom/issues/145/comments","statuses_url":"https://api.github.com/repos/Geal/nom/statuses/a58a017e94348863d11d98849c3eefd2718ef844","head":{"label":"jsgf:master","ref":"master","sha":"a58a017e94348863d11d98849c3eefd2718ef844","user":{"login":"jsgf","id":147966,"avatar_url":"https://avatars.githubusercontent.com/u/147966?v=3","gravatar_id":"","url":"https://api.github.com/users/jsgf","html_url":"https://github.com/jsgf","followers_url":"https://api.github.com/users/jsgf/followers","following_url":"https://api.github.com/users/jsgf/following{/other_user}","gists_url":"https://api.github.com/users/jsgf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsgf/subscriptions","organizations_url":"https://api.github.com/users/jsgf/orgs","repos_url":"https://api.github.com/users/jsgf/repos","events_url":"https://api.github.com/users/jsgf/events{/privacy}","received_events_url":"https://api.github.com/users/jsgf/received_events","type":"User","site_admin":false},"repo":{"id":48158932,"name":"nom","full_name":"jsgf/nom","owner":{"login":"jsgf","id":147966,"avatar_url":"https://avatars.githubusercontent.com/u/147966?v=3","gravatar_id":"","url":"https://api.github.com/users/jsgf","html_url":"https://github.com/jsgf","followers_url":"https://api.github.com/users/jsgf/followers","following_url":"https://api.github.com/users/jsgf/following{/other_user}","gists_url":"https://api.github.com/users/jsgf/gists{/gist_id}","starred_url":"https://api.github.com/users/jsgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsgf/subscriptions","organizations_url":"https://api.github.com/users/jsgf/orgs","repos_url":"https://api.github.com/users/jsgf/repos","events_url":"https://api.github.com/users/jsgf/events{/privacy}","received_events_url":"https://api.github.com/users/jsgf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsgf/nom","description":"Rust parser combinator framework","fork":true,"url":"https://api.github.com/repos/jsgf/nom","forks_url":"https://api.github.com/repos/jsgf/nom/forks","keys_url":"https://api.github.com/repos/jsgf/nom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsgf/nom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsgf/nom/teams","hooks_url":"https://api.github.com/repos/jsgf/nom/hooks","issue_events_url":"https://api.github.com/repos/jsgf/nom/issues/events{/number}","events_url":"https://api.github.com/repos/jsgf/nom/events","assignees_url":"https://api.github.com/repos/jsgf/nom/assignees{/user}","branches_url":"https://api.github.com/repos/jsgf/nom/branches{/branch}","tags_url":"https://api.github.com/repos/jsgf/nom/tags","blobs_url":"https://api.github.com/repos/jsgf/nom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsgf/nom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsgf/nom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsgf/nom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsgf/nom/statuses/{sha}","languages_url":"https://api.github.com/repos/jsgf/nom/languages","stargazers_url":"https://api.github.com/repos/jsgf/nom/stargazers","contributors_url":"https://api.github.com/repos/jsgf/nom/contributors","subscribers_url":"https://api.github.com/repos/jsgf/nom/subscribers","subscription_url":"https://api.github.com/repos/jsgf/nom/subscription","commits_url":"https://api.github.com/repos/jsgf/nom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsgf/nom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsgf/nom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsgf/nom/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsgf/nom/contents/{+path}","compare_url":"https://api.github.com/repos/jsgf/nom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsgf/nom/merges","archive_url":"https://api.github.com/repos/jsgf/nom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsgf/nom/downloads","issues_url":"https://api.github.com/repos/jsgf/nom/issues{/number}","pulls_url":"https://api.github.com/repos/jsgf/nom/pulls{/number}","milestones_url":"https://api.github.com/repos/jsgf/nom/milestones{/number}","notifications_url":"https://api.github.com/repos/jsgf/nom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsgf/nom/labels{/name}","releases_url":"https://api.github.com/repos/jsgf/nom/releases{/id}","created_at":"2015-12-17T07:19:28Z","updated_at":"2015-12-17T07:19:29Z","pushed_at":"2015-12-17T09:03:16Z","git_url":"git://github.com/jsgf/nom.git","ssh_url":"git@github.com:jsgf/nom.git","clone_url":"https://github.com/jsgf/nom.git","svn_url":"https://github.com/jsgf/nom","homepage":"","size":6045,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Geal:master","ref":"master","sha":"86bb786ee298a8995326473f571e562736f680c9","user":{"login":"Geal","id":119296,"avatar_url":"https://avatars.githubusercontent.com/u/119296?v=3","gravatar_id":"","url":"https://api.github.com/users/Geal","html_url":"https://github.com/Geal","followers_url":"https://api.github.com/users/Geal/followers","following_url":"https://api.github.com/users/Geal/following{/other_user}","gists_url":"https://api.github.com/users/Geal/gists{/gist_id}","starred_url":"https://api.github.com/users/Geal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geal/subscriptions","organizations_url":"https://api.github.com/users/Geal/orgs","repos_url":"https://api.github.com/users/Geal/repos","events_url":"https://api.github.com/users/Geal/events{/privacy}","received_events_url":"https://api.github.com/users/Geal/received_events","type":"User","site_admin":false},"repo":{"id":27029984,"name":"nom","full_name":"Geal/nom","owner":{"login":"Geal","id":119296,"avatar_url":"https://avatars.githubusercontent.com/u/119296?v=3","gravatar_id":"","url":"https://api.github.com/users/Geal","html_url":"https://github.com/Geal","followers_url":"https://api.github.com/users/Geal/followers","following_url":"https://api.github.com/users/Geal/following{/other_user}","gists_url":"https://api.github.com/users/Geal/gists{/gist_id}","starred_url":"https://api.github.com/users/Geal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geal/subscriptions","organizations_url":"https://api.github.com/users/Geal/orgs","repos_url":"https://api.github.com/users/Geal/repos","events_url":"https://api.github.com/users/Geal/events{/privacy}","received_events_url":"https://api.github.com/users/Geal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Geal/nom","description":"Rust parser combinator framework","fork":false,"url":"https://api.github.com/repos/Geal/nom","forks_url":"https://api.github.com/repos/Geal/nom/forks","keys_url":"https://api.github.com/repos/Geal/nom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geal/nom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geal/nom/teams","hooks_url":"https://api.github.com/repos/Geal/nom/hooks","issue_events_url":"https://api.github.com/repos/Geal/nom/issues/events{/number}","events_url":"https://api.github.com/repos/Geal/nom/events","assignees_url":"https://api.github.com/repos/Geal/nom/assignees{/user}","branches_url":"https://api.github.com/repos/Geal/nom/branches{/branch}","tags_url":"https://api.github.com/repos/Geal/nom/tags","blobs_url":"https://api.github.com/repos/Geal/nom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geal/nom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geal/nom/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geal/nom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geal/nom/statuses/{sha}","languages_url":"https://api.github.com/repos/Geal/nom/languages","stargazers_url":"https://api.github.com/repos/Geal/nom/stargazers","contributors_url":"https://api.github.com/repos/Geal/nom/contributors","subscribers_url":"https://api.github.com/repos/Geal/nom/subscribers","subscription_url":"https://api.github.com/repos/Geal/nom/subscription","commits_url":"https://api.github.com/repos/Geal/nom/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geal/nom/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geal/nom/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geal/nom/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geal/nom/contents/{+path}","compare_url":"https://api.github.com/repos/Geal/nom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geal/nom/merges","archive_url":"https://api.github.com/repos/Geal/nom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geal/nom/downloads","issues_url":"https://api.github.com/repos/Geal/nom/issues{/number}","pulls_url":"https://api.github.com/repos/Geal/nom/pulls{/number}","milestones_url":"https://api.github.com/repos/Geal/nom/milestones{/number}","notifications_url":"https://api.github.com/repos/Geal/nom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geal/nom/labels{/name}","releases_url":"https://api.github.com/repos/Geal/nom/releases{/id}","created_at":"2014-11-23T11:16:23Z","updated_at":"2015-12-17T02:52:33Z","pushed_at":"2015-12-06T14:14:03Z","git_url":"git://github.com/Geal/nom.git","ssh_url":"git@github.com:Geal/nom.git","clone_url":"https://github.com/Geal/nom.git","svn_url":"https://github.com/Geal/nom","homepage":"","size":6048,"stargazers_count":645,"watchers_count":645,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":25,"forks":51,"open_issues":25,"watchers":645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geal/nom/pulls/145"},"html":{"href":"https://github.com/Geal/nom/pull/145"},"issue":{"href":"https://api.github.com/repos/Geal/nom/issues/145"},"comments":{"href":"https://api.github.com/repos/Geal/nom/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/Geal/nom/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/Geal/nom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geal/nom/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/Geal/nom/statuses/a58a017e94348863d11d98849c3eefd2718ef844"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":60,"deletions":34,"changed_files":6}}