{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/45507066","id":45507066,"diff_hunk":"@@ -29,14 +29,13 @@ with this program; if not, write to the Free Software Foundation, Inc.,\n #include \"convert_json.h\"\n #include \"exceptions.h\"\n \n-static bool parseDependsLine(std::istream &is,\n-\t\tstd::string &dep, std::set<char> &symbols)\n+static bool parseDependsString(std::string &dep,","path":"src/mods.cpp","position":6,"original_position":6,"commit_id":"2e2a5db85a2bf8c9a25230ef3a75d142a980917f","original_commit_id":"01ddabdb4243516a2866bda29c172723386d58e9","user":{"login":"rubenwardy","id":2122943,"avatar_url":"https://avatars.githubusercontent.com/u/2122943?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenwardy","html_url":"https://github.com/rubenwardy","followers_url":"https://api.github.com/users/rubenwardy/followers","following_url":"https://api.github.com/users/rubenwardy/following{/other_user}","gists_url":"https://api.github.com/users/rubenwardy/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenwardy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenwardy/subscriptions","organizations_url":"https://api.github.com/users/rubenwardy/orgs","repos_url":"https://api.github.com/users/rubenwardy/repos","events_url":"https://api.github.com/users/rubenwardy/events{/privacy}","received_events_url":"https://api.github.com/users/rubenwardy/received_events","type":"User","site_admin":false},"body":"Oh, it also returns a list of symbols.","created_at":"2015-11-20T19:22:51Z","updated_at":"2015-11-20T19:22:51Z","html_url":"https://github.com/minetest/minetest/pull/3392#discussion_r45507066","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/3392","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/45507066"},"html":{"href":"https://github.com/minetest/minetest/pull/3392#discussion_r45507066"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3392"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/3392","id":51383328,"html_url":"https://github.com/minetest/minetest/pull/3392","diff_url":"https://github.com/minetest/minetest/pull/3392.diff","patch_url":"https://github.com/minetest/minetest/pull/3392.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/3392","number":3392,"state":"open","locked":false,"title":"[WIP] Add the ability to set the dependecies of a mod in mod.conf and add conflicts and provides","user":{"login":"TeTpaAka","id":6652859,"avatar_url":"https://avatars.githubusercontent.com/u/6652859?v=3","gravatar_id":"","url":"https://api.github.com/users/TeTpaAka","html_url":"https://github.com/TeTpaAka","followers_url":"https://api.github.com/users/TeTpaAka/followers","following_url":"https://api.github.com/users/TeTpaAka/following{/other_user}","gists_url":"https://api.github.com/users/TeTpaAka/gists{/gist_id}","starred_url":"https://api.github.com/users/TeTpaAka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeTpaAka/subscriptions","organizations_url":"https://api.github.com/users/TeTpaAka/orgs","repos_url":"https://api.github.com/users/TeTpaAka/repos","events_url":"https://api.github.com/users/TeTpaAka/events{/privacy}","received_events_url":"https://api.github.com/users/TeTpaAka/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [x] move dependencies to mod.conf\r\n- [x] add conflicts to mod.conf\r\n- [x] add provides to mod.conf\r\n- [ ] add preloads to mod.conf\r\n- [ ] make the changes visible for the user in the menu\r\n    - [x] load the dependencies also from mod.conf\r\n    - [ ] add boxes like the dependencies for the other options\r\n- [ ] add description.txt into mod.conf\r\n- [ ] document the changes\r\n\r\nimplements #3200, though it is still heavily WIP.","created_at":"2015-11-20T17:19:16Z","updated_at":"2015-11-20T19:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb4d071a2186076f85868b2eccd3054884ad2b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/3392/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/3392/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/3392/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/2e2a5db85a2bf8c9a25230ef3a75d142a980917f","head":{"label":"TeTpaAka:mod_conf","ref":"mod_conf","sha":"2e2a5db85a2bf8c9a25230ef3a75d142a980917f","user":{"login":"TeTpaAka","id":6652859,"avatar_url":"https://avatars.githubusercontent.com/u/6652859?v=3","gravatar_id":"","url":"https://api.github.com/users/TeTpaAka","html_url":"https://github.com/TeTpaAka","followers_url":"https://api.github.com/users/TeTpaAka/followers","following_url":"https://api.github.com/users/TeTpaAka/following{/other_user}","gists_url":"https://api.github.com/users/TeTpaAka/gists{/gist_id}","starred_url":"https://api.github.com/users/TeTpaAka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeTpaAka/subscriptions","organizations_url":"https://api.github.com/users/TeTpaAka/orgs","repos_url":"https://api.github.com/users/TeTpaAka/repos","events_url":"https://api.github.com/users/TeTpaAka/events{/privacy}","received_events_url":"https://api.github.com/users/TeTpaAka/received_events","type":"User","site_admin":false},"repo":{"id":35455174,"name":"minetest","full_name":"TeTpaAka/minetest","owner":{"login":"TeTpaAka","id":6652859,"avatar_url":"https://avatars.githubusercontent.com/u/6652859?v=3","gravatar_id":"","url":"https://api.github.com/users/TeTpaAka","html_url":"https://github.com/TeTpaAka","followers_url":"https://api.github.com/users/TeTpaAka/followers","following_url":"https://api.github.com/users/TeTpaAka/following{/other_user}","gists_url":"https://api.github.com/users/TeTpaAka/gists{/gist_id}","starred_url":"https://api.github.com/users/TeTpaAka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeTpaAka/subscriptions","organizations_url":"https://api.github.com/users/TeTpaAka/orgs","repos_url":"https://api.github.com/users/TeTpaAka/repos","events_url":"https://api.github.com/users/TeTpaAka/events{/privacy}","received_events_url":"https://api.github.com/users/TeTpaAka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TeTpaAka/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/TeTpaAka/minetest","forks_url":"https://api.github.com/repos/TeTpaAka/minetest/forks","keys_url":"https://api.github.com/repos/TeTpaAka/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeTpaAka/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeTpaAka/minetest/teams","hooks_url":"https://api.github.com/repos/TeTpaAka/minetest/hooks","issue_events_url":"https://api.github.com/repos/TeTpaAka/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/TeTpaAka/minetest/events","assignees_url":"https://api.github.com/repos/TeTpaAka/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/TeTpaAka/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/TeTpaAka/minetest/tags","blobs_url":"https://api.github.com/repos/TeTpaAka/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeTpaAka/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeTpaAka/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeTpaAka/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeTpaAka/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/TeTpaAka/minetest/languages","stargazers_url":"https://api.github.com/repos/TeTpaAka/minetest/stargazers","contributors_url":"https://api.github.com/repos/TeTpaAka/minetest/contributors","subscribers_url":"https://api.github.com/repos/TeTpaAka/minetest/subscribers","subscription_url":"https://api.github.com/repos/TeTpaAka/minetest/subscription","commits_url":"https://api.github.com/repos/TeTpaAka/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeTpaAka/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeTpaAka/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeTpaAka/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeTpaAka/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/TeTpaAka/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeTpaAka/minetest/merges","archive_url":"https://api.github.com/repos/TeTpaAka/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeTpaAka/minetest/downloads","issues_url":"https://api.github.com/repos/TeTpaAka/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/TeTpaAka/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/TeTpaAka/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/TeTpaAka/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeTpaAka/minetest/labels{/name}","releases_url":"https://api.github.com/repos/TeTpaAka/minetest/releases{/id}","created_at":"2015-05-11T23:16:43Z","updated_at":"2015-05-11T23:16:46Z","pushed_at":"2015-11-20T19:16:47Z","git_url":"git://github.com/TeTpaAka/minetest.git","ssh_url":"git@github.com:TeTpaAka/minetest.git","clone_url":"https://github.com/TeTpaAka/minetest.git","svn_url":"https://github.com/TeTpaAka/minetest","homepage":"http://minetest.net/","size":40930,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"2f58e4d9624b4f31c5064dc640e0ad40d8adb9ea","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-11-19T00:58:29Z","pushed_at":"2015-11-20T19:16:48Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":110372,"stargazers_count":1685,"watchers_count":1685,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"open_issues_count":636,"forks":564,"open_issues":636,"watchers":1685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3392"},"html":{"href":"https://github.com/minetest/minetest/pull/3392"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/3392"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/3392/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3392/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/3392/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/2e2a5db85a2bf8c9a25230ef3a75d142a980917f"}}}}