{"action":"closed","number":1132,"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132","id":44620944,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1132","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1132.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1132.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1132","number":1132,"state":"closed","locked":false,"title":"Get rid of unnecessary instance variables, and implied dependencies.","user":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"body":"In the meantime before #1117 gets merged, here is a PR to cleanup the use of unnecessary instance variables, and the nasty effect of not setting `@result` in `Json` adapter breaking `FlattenJson` adapter.","created_at":"2015-09-10T02:04:15Z","updated_at":"2015-09-12T15:51:38Z","closed_at":"2015-09-12T15:51:38Z","merged_at":"2015-09-12T15:51:38Z","merge_commit_sha":"a00203e34aa31affffec26aad7aa57841f7d6657","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1132/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/a9d07cd68f0d2f3b5e3a33ba39a42ada6c5c25dd","head":{"label":"beauby:fix-flatten-json","ref":"fix-flatten-json","sha":"a9d07cd68f0d2f3b5e3a33ba39a42ada6c5c25dd","user":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"repo":{"id":30326986,"name":"active_model_serializers","full_name":"beauby/active_model_serializers","owner":{"login":"beauby","id":2215778,"avatar_url":"https://avatars.githubusercontent.com/u/2215778?v=3","gravatar_id":"","url":"https://api.github.com/users/beauby","html_url":"https://github.com/beauby","followers_url":"https://api.github.com/users/beauby/followers","following_url":"https://api.github.com/users/beauby/following{/other_user}","gists_url":"https://api.github.com/users/beauby/gists{/gist_id}","starred_url":"https://api.github.com/users/beauby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beauby/subscriptions","organizations_url":"https://api.github.com/users/beauby/orgs","repos_url":"https://api.github.com/users/beauby/repos","events_url":"https://api.github.com/users/beauby/events{/privacy}","received_events_url":"https://api.github.com/users/beauby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beauby/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/beauby/active_model_serializers","forks_url":"https://api.github.com/repos/beauby/active_model_serializers/forks","keys_url":"https://api.github.com/repos/beauby/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beauby/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beauby/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/beauby/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/beauby/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/beauby/active_model_serializers/events","assignees_url":"https://api.github.com/repos/beauby/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/beauby/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/beauby/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/beauby/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beauby/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beauby/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/beauby/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beauby/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/beauby/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/beauby/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/beauby/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/beauby/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/beauby/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/beauby/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/beauby/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/beauby/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/beauby/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/beauby/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/beauby/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beauby/active_model_serializers/merges","archive_url":"https://api.github.com/repos/beauby/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beauby/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/beauby/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/beauby/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/beauby/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/beauby/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beauby/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/beauby/active_model_serializers/releases{/id}","created_at":"2015-02-04T23:25:42Z","updated_at":"2015-02-04T23:25:43Z","pushed_at":"2015-09-11T18:41:49Z","git_url":"git://github.com/beauby/active_model_serializers.git","ssh_url":"git@github.com:beauby/active_model_serializers.git","clone_url":"https://github.com/beauby/active_model_serializers.git","svn_url":"https://github.com/beauby/active_model_serializers","homepage":"","size":1921,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails-api:master","ref":"master","sha":"1388ae82f26133d62f4e6cdfc40d1c659e121935","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","created_at":"2011-12-01T06:39:26Z","updated_at":"2015-09-12T14:04:59Z","pushed_at":"2015-09-12T15:51:38Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":7438,"stargazers_count":2960,"watchers_count":2960,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":675,"mirror_url":null,"open_issues_count":159,"forks":675,"open_issues":159,"watchers":2960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1132"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1132"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/a9d07cd68f0d2f3b5e3a33ba39a42ada6c5c25dd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"NullVoxPopuli","id":199018,"avatar_url":"https://avatars.githubusercontent.com/u/199018?v=3","gravatar_id":"","url":"https://api.github.com/users/NullVoxPopuli","html_url":"https://github.com/NullVoxPopuli","followers_url":"https://api.github.com/users/NullVoxPopuli/followers","following_url":"https://api.github.com/users/NullVoxPopuli/following{/other_user}","gists_url":"https://api.github.com/users/NullVoxPopuli/gists{/gist_id}","starred_url":"https://api.github.com/users/NullVoxPopuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullVoxPopuli/subscriptions","organizations_url":"https://api.github.com/users/NullVoxPopuli/orgs","repos_url":"https://api.github.com/users/NullVoxPopuli/repos","events_url":"https://api.github.com/users/NullVoxPopuli/events{/privacy}","received_events_url":"https://api.github.com/users/NullVoxPopuli/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":8,"deletions":9,"changed_files":2}}