{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3708","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3708/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3708/comments","events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3708/events","html_url":"https://github.com/angular-ui/bootstrap/pull/3708","id":80582074,"number":3708,"title":"dateParser needs to handle invalid base dates","user":{"login":"JohannesRudolph","id":130103,"avatar_url":"https://avatars.githubusercontent.com/u/130103?v=3","gravatar_id":"","url":"https://api.github.com/users/JohannesRudolph","html_url":"https://github.com/JohannesRudolph","followers_url":"https://api.github.com/users/JohannesRudolph/followers","following_url":"https://api.github.com/users/JohannesRudolph/following{/other_user}","gists_url":"https://api.github.com/users/JohannesRudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/JohannesRudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohannesRudolph/subscriptions","organizations_url":"https://api.github.com/users/JohannesRudolph/orgs","repos_url":"https://api.github.com/users/JohannesRudolph/repos","events_url":"https://api.github.com/users/JohannesRudolph/events{/privacy}","received_events_url":"https://api.github.com/users/JohannesRudolph/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/component:%20datepicker","name":"component: datepicker","color":"ffffff"},{"url":"https://api.github.com/repos/angular-ui/bootstrap/labels/needs:%20review","name":"needs: review","color":"5319e7"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.13.1%20(Performance)","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/20/labels","id":1040683,"number":20,"title":"0.13.1 (Performance)","description":"Performance tweaks and fixes for 0.13 .","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":19,"state":"open","created_at":"2015-03-26T20:06:14Z","updated_at":"2015-06-08T08:16:54Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-05-25T16:09:13Z","updated_at":"2015-06-08T08:16:54Z","closed_at":"2015-06-08T08:16:54Z","pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3708","html_url":"https://github.com/angular-ui/bootstrap/pull/3708","diff_url":"https://github.com/angular-ui/bootstrap/pull/3708.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3708.patch"},"body":"I noticed that datePicker would fail in the following scenario (reproducible with the official sample): \r\n - clear input text\r\n - enter a valid date according to format\r\n - observe that the date is parsed as invalid date\r\n\r\nThe underlying issue seems to be that the dateParser is handled an invalid base date (as in: a Javascript InvalidDate object). This pull request fixes this scenario and should be trivial to review as it contains a failing test which passes with the suggested fix. "},"comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments/109901750","html_url":"https://github.com/angular-ui/bootstrap/pull/3708#issuecomment-109901750","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3708","id":109901750,"user":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T08:16:54Z","updated_at":"2015-06-08T08:16:54Z","body":"Closing in favor of #3759"}}