{"action":"created","comment":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/26914561","id":26914561,"diff_hunk":"@@ -93,6 +93,10 @@ googleAnalytics.trackingId = null\n // set per-environment serverURL stem for creating absolute links\n def env = System.getenv()\n \n+filtering {\n+    loadFromFiles = Boolean.parseBoolean(env['LOAD_FILTERS_FROM_FILES'])","path":"grails-app/conf/Config.groovy","position":14,"original_position":14,"commit_id":"a042790c160e1f714f0e2876594e16e87f87228a","original_commit_id":"a042790c160e1f714f0e2876594e16e87f87228a","user":{"login":"danfruehauf","id":830676,"avatar_url":"https://avatars.githubusercontent.com/u/830676?v=3","gravatar_id":"","url":"https://api.github.com/users/danfruehauf","html_url":"https://github.com/danfruehauf","followers_url":"https://api.github.com/users/danfruehauf/followers","following_url":"https://api.github.com/users/danfruehauf/following{/other_user}","gists_url":"https://api.github.com/users/danfruehauf/gists{/gist_id}","starred_url":"https://api.github.com/users/danfruehauf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfruehauf/subscriptions","organizations_url":"https://api.github.com/users/danfruehauf/orgs","repos_url":"https://api.github.com/users/danfruehauf/repos","events_url":"https://api.github.com/users/danfruehauf/events{/privacy}","received_events_url":"https://api.github.com/users/danfruehauf/received_events","type":"User","site_admin":false},"body":"If the path is not specified - imply dynamic filtering.","created_at":"2015-03-23T05:09:54Z","updated_at":"2015-03-23T05:09:54Z","html_url":"https://github.com/aodn/aodn-portal/pull/1658#discussion_r26914561","pull_request_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658","_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments/26914561"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1658#discussion_r26914561"},"pull_request":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658"}}},"pull_request":{"url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658","id":31705411,"html_url":"https://github.com/aodn/aodn-portal/pull/1658","diff_url":"https://github.com/aodn/aodn-portal/pull/1658.diff","patch_url":"https://github.com/aodn/aodn-portal/pull/1658.patch","issue_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1658","number":1658,"state":"open","locked":false,"title":"Determine filter source (GeoServer/files) from env var","user":{"login":"dnahodil","id":2774917,"avatar_url":"https://avatars.githubusercontent.com/u/2774917?v=3","gravatar_id":"","url":"https://api.github.com/users/dnahodil","html_url":"https://github.com/dnahodil","followers_url":"https://api.github.com/users/dnahodil/followers","following_url":"https://api.github.com/users/dnahodil/following{/other_user}","gists_url":"https://api.github.com/users/dnahodil/gists{/gist_id}","starred_url":"https://api.github.com/users/dnahodil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnahodil/subscriptions","organizations_url":"https://api.github.com/users/dnahodil/orgs","repos_url":"https://api.github.com/users/dnahodil/repos","events_url":"https://api.github.com/users/dnahodil/events{/privacy}","received_events_url":"https://api.github.com/users/dnahodil/received_events","type":"User","site_admin":false},"body":"I've accidentally committed the `dynamicFilters` setting a couple of times already today. :S\r\n\r\nI've set it up so it can be loaded from an environment variable to make it easier when you're working from filesystem for an extended period. Default is 'false' which is to read from GeoServer.\r\n\r\nI also took it out of the feature toggles section as per a previous discussion with @jkburges and @danfruehauf.","created_at":"2015-03-23T05:05:52Z","updated_at":"2015-03-23T05:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a822179395e454cfc66a35f602eb82972db3a946","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658/commits","review_comments_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658/comments","review_comment_url":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/issues/1658/comments","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/a042790c160e1f714f0e2876594e16e87f87228a","head":{"label":"aodn:filter_source_from_env_var","ref":"filter_source_from_env_var","sha":"a042790c160e1f714f0e2876594e16e87f87228a","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2015-03-23T04:21:06Z","pushed_at":"2015-03-23T05:05:53Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":68844,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":80,"forks":12,"open_issues":80,"watchers":3,"default_branch":"master"}},"base":{"label":"aodn:master","ref":"master","sha":"edfe99026ae47a4b3d464dcf8ba9af5a00f5f357","user":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"repo":{"id":6806252,"name":"aodn-portal","full_name":"aodn/aodn-portal","owner":{"login":"aodn","id":2802166,"avatar_url":"https://avatars.githubusercontent.com/u/2802166?v=3","gravatar_id":"","url":"https://api.github.com/users/aodn","html_url":"https://github.com/aodn","followers_url":"https://api.github.com/users/aodn/followers","following_url":"https://api.github.com/users/aodn/following{/other_user}","gists_url":"https://api.github.com/users/aodn/gists{/gist_id}","starred_url":"https://api.github.com/users/aodn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aodn/subscriptions","organizations_url":"https://api.github.com/users/aodn/orgs","repos_url":"https://api.github.com/users/aodn/repos","events_url":"https://api.github.com/users/aodn/events{/privacy}","received_events_url":"https://api.github.com/users/aodn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aodn/aodn-portal","description":"AODN Open Geospatial Portal","fork":false,"url":"https://api.github.com/repos/aodn/aodn-portal","forks_url":"https://api.github.com/repos/aodn/aodn-portal/forks","keys_url":"https://api.github.com/repos/aodn/aodn-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aodn/aodn-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aodn/aodn-portal/teams","hooks_url":"https://api.github.com/repos/aodn/aodn-portal/hooks","issue_events_url":"https://api.github.com/repos/aodn/aodn-portal/issues/events{/number}","events_url":"https://api.github.com/repos/aodn/aodn-portal/events","assignees_url":"https://api.github.com/repos/aodn/aodn-portal/assignees{/user}","branches_url":"https://api.github.com/repos/aodn/aodn-portal/branches{/branch}","tags_url":"https://api.github.com/repos/aodn/aodn-portal/tags","blobs_url":"https://api.github.com/repos/aodn/aodn-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aodn/aodn-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aodn/aodn-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/aodn/aodn-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aodn/aodn-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/aodn/aodn-portal/languages","stargazers_url":"https://api.github.com/repos/aodn/aodn-portal/stargazers","contributors_url":"https://api.github.com/repos/aodn/aodn-portal/contributors","subscribers_url":"https://api.github.com/repos/aodn/aodn-portal/subscribers","subscription_url":"https://api.github.com/repos/aodn/aodn-portal/subscription","commits_url":"https://api.github.com/repos/aodn/aodn-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/aodn/aodn-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/aodn/aodn-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/aodn/aodn-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/aodn/aodn-portal/contents/{+path}","compare_url":"https://api.github.com/repos/aodn/aodn-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aodn/aodn-portal/merges","archive_url":"https://api.github.com/repos/aodn/aodn-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aodn/aodn-portal/downloads","issues_url":"https://api.github.com/repos/aodn/aodn-portal/issues{/number}","pulls_url":"https://api.github.com/repos/aodn/aodn-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/aodn/aodn-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/aodn/aodn-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aodn/aodn-portal/labels{/name}","releases_url":"https://api.github.com/repos/aodn/aodn-portal/releases{/id}","created_at":"2012-11-22T01:42:50Z","updated_at":"2015-03-23T04:21:06Z","pushed_at":"2015-03-23T05:05:53Z","git_url":"git://github.com/aodn/aodn-portal.git","ssh_url":"git@github.com:aodn/aodn-portal.git","clone_url":"https://github.com/aodn/aodn-portal.git","svn_url":"https://github.com/aodn/aodn-portal","homepage":"","size":68844,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":80,"forks":12,"open_issues":80,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658"},"html":{"href":"https://github.com/aodn/aodn-portal/pull/1658"},"issue":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1658"},"comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/issues/1658/comments"},"review_comments":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658/comments"},"review_comment":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aodn/aodn-portal/pulls/1658/commits"},"statuses":{"href":"https://api.github.com/repos/aodn/aodn-portal/statuses/a042790c160e1f714f0e2876594e16e87f87228a"}}}}