{"action":"created","issue":{"url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/21","labels_url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/21/comments","events_url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/21/events","html_url":"https://github.com/akvo/akvo-caddisfly/issues/21","id":111589414,"number":21,"title":"Start button visibility","user":{"login":"ldporsius","id":9623423,"avatar_url":"https://avatars.githubusercontent.com/u/9623423?v=3","gravatar_id":"","url":"https://api.github.com/users/ldporsius","html_url":"https://github.com/ldporsius","followers_url":"https://api.github.com/users/ldporsius/followers","following_url":"https://api.github.com/users/ldporsius/following{/other_user}","gists_url":"https://api.github.com/users/ldporsius/gists{/gist_id}","starred_url":"https://api.github.com/users/ldporsius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldporsius/subscriptions","organizations_url":"https://api.github.com/users/ldporsius/orgs","repos_url":"https://api.github.com/users/ldporsius/repos","events_url":"https://api.github.com/users/ldporsius/events{/privacy}","received_events_url":"https://api.github.com/users/ldporsius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-15T10:35:54Z","updated_at":"2015-10-15T11:12:40Z","closed_at":null,"body":" The visibility of the button depends on the quality checks. Only if the conditions are met, the button shows. But, as long as the button is not pressed, the app keeps doing the quality checks. And, because it takes time to find the finder patterns needed to do the quality checks, and of course the checks itself, the conditions are then again not met. They are set to 'false' at the start of each cycle. The result: a start button that flickers: it's there/now it's gone. And a contrast icon that flickers: red/green.\r\n\r\nPossible solution: make the conditions (contrast, exposure, focus) global. Then they will keep the previous value until it changes. On the downside: if quality checks fail, the previous value will still be there. So: Keep the value in a global and set to false only if failure?"},"comment":{"url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/comments/148354919","html_url":"https://github.com/akvo/akvo-caddisfly/issues/21#issuecomment-148354919","issue_url":"https://api.github.com/repos/akvo/akvo-caddisfly/issues/21","id":148354919,"user":{"login":"mtwestra","id":478954,"avatar_url":"https://avatars.githubusercontent.com/u/478954?v=3","gravatar_id":"","url":"https://api.github.com/users/mtwestra","html_url":"https://github.com/mtwestra","followers_url":"https://api.github.com/users/mtwestra/followers","following_url":"https://api.github.com/users/mtwestra/following{/other_user}","gists_url":"https://api.github.com/users/mtwestra/gists{/gist_id}","starred_url":"https://api.github.com/users/mtwestra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtwestra/subscriptions","organizations_url":"https://api.github.com/users/mtwestra/orgs","repos_url":"https://api.github.com/users/mtwestra/repos","events_url":"https://api.github.com/users/mtwestra/events{/privacy}","received_events_url":"https://api.github.com/users/mtwestra/received_events","type":"User","site_admin":false},"created_at":"2015-10-15T11:12:40Z","updated_at":"2015-10-15T11:12:40Z","body":"Yes, this sounds like a good approach. But it also shouldn't last too long, so something like 3 iterations?\nm\n\nOn 15 Oct 2015, at 13:05, Linda Porsius <notifications@github.com> wrote:\n\n> The contrast icon stabilizes by use of a global. But the start button keeps switching between visible/gone if values lie around the limit set. The limit is e.g. 70%. In each call the value changes somewhat, let's say: 68%, 71%, etc. \n> Maybe what we could do, is: wait a number of iterations until we can decide if values stay around the limit, or are definitely to low or high enough. \n> If on the average they are above the limit, we take a chance and show the button, trusting that it will remain that way. After pressing start, the checks still keep running, so we should end up with an image of good quality. This is only to prevent confronting the user with a button that disappears while they were just about to press it.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n\n"}}