{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/34113505","id":34113505,"diff_hunk":"@@ -36,6 +35,24 @@ object SlickDataAccess {\n   implicit class StringToClob(val str: String) extends AnyVal {\n     def toClob: Clob = new SerialClob(str.toCharArray)\n   }\n+\n+  implicit class ConfigWithUniqueSchema(val config: Config) extends AnyVal {","path":"src/main/scala/cromwell/engine/db/slick/SlickDataAccess.scala","position":17,"original_position":17,"commit_id":"e09e8815d2ffefca3b7575d4a6f620cbc62a30fa","original_commit_id":"e09e8815d2ffefca3b7575d4a6f620cbc62a30fa","user":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"body":"This function below (optionally) inserts a unique string into the config value `url`, that is seconds later used internally by slick to connect to the database.\r\n\r\nWhen this code snippet activates for the default in memory database (see also reference.conf) this allows two things:\r\n\r\nFirst, quick google searches weren't clear on a one-liner way to make slick behave like liquibase, only updating a schema. If special checks weren't added, each time the schema creation ran, after the first time, it would bomb out on \"table already exists\". There were a couple of search hits on how to peek in the database to see if the tables existed, but I ultimately backed off on this because...\r\n\r\nSecondly, providing a clean, unique database each call to `DataAccess()`/`new SlickDataAccess()` leaves the behavior `SlickDataAccess` similar to the old `DummyDataAccess`. The coercion bug wasn't discovered earlier as `DummyDataAccess` was being used for tests. Now they can just use `DataAccess()` and a clean database will be created for the test.","created_at":"2015-07-08T03:30:54Z","updated_at":"2015-07-08T03:30:54Z","html_url":"https://github.com/broadinstitute/cromwell/pull/84#discussion_r34113505","pull_request_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/34113505"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/84#discussion_r34113505"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84","id":39432283,"html_url":"https://github.com/broadinstitute/cromwell/pull/84","diff_url":"https://github.com/broadinstitute/cromwell/pull/84.diff","patch_url":"https://github.com/broadinstitute/cromwell/pull/84.patch","issue_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/84","number":84,"state":"open","locked":false,"title":"Updates to fix coercion errors. DSDEEPB-727","user":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"body":"Fixed Symbol doubly qualifying the symbol names. (thx mcovarr/scottfrazer)\r\nAdded `WdlType.fromRawString`, with test against respective `WdlValue.toRawString`.\r\n`DummyDataAccess` replaced with using `DataAccess` instances, with cleanup of connections.\r\nWhen creating in memory databases will create unique `DataAccess` instances, just like Dummy.\r\nTestSlickDatabase now prints a warning, instead of an error, when unable to connect to MySql.","created_at":"2015-07-08T00:53:39Z","updated_at":"2015-07-08T03:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd0e55072cca4230119c900d00291fbf9058493f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/84/comments","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/e09e8815d2ffefca3b7575d4a6f620cbc62a30fa","head":{"label":"broadinstitute:ks_coercion_errors","ref":"ks_coercion_errors","sha":"e09e8815d2ffefca3b7575d4a6f620cbc62a30fa","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","created_at":"2015-04-17T19:39:36Z","updated_at":"2015-06-17T07:32:01Z","pushed_at":"2015-07-08T03:30:44Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"http://broadinstitute.github.io/cromwell/","size":2916,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"9b3469c61dbc14082e81dc175e2a6e61518a9baa","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","created_at":"2015-04-17T19:39:36Z","updated_at":"2015-06-17T07:32:01Z","pushed_at":"2015-07-08T03:30:44Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"http://broadinstitute.github.io/cromwell/","size":2916,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/84"},"issue":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/84"},"comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/cromwell/statuses/e09e8815d2ffefca3b7575d4a6f620cbc62a30fa"}}}}