{"action":"created","comment":{"url":"https://api.github.com/repos/GPII/gpii-express/pulls/comments/39518877","id":39518877,"diff_hunk":"@@ -22,8 +22,8 @@ gpii.express.router[\"static\"].init = function (that) {\n     that.staticHandler = express[\"static\"](that.options.content);\n };\n \n-gpii.express.router[\"static\"].route = function (that, req, res) {\n-    that.staticHandler(req, res);\n+gpii.express.router[\"static\"].route = function (that, req, res, next) {\n+    that.staticHandler(req, res, next);","path":"src/js/static.js","position":7,"original_position":7,"commit_id":"8730441601db239870046c796b85c0f020a302a1","original_commit_id":"8730441601db239870046c796b85c0f020a302a1","user":{"login":"the-t-in-rtf","id":5765222,"avatar_url":"https://avatars.githubusercontent.com/u/5765222?v=3","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"body":"I believe that this was only possible because we had a \"bad actor\" from the express 3.x days that had \"router-like middleware\".  I cannot reproduce it with the unpatched code and any combination of normal `gpii.express.middleware` and `gpii.express.router` modules.","created_at":"2015-09-15T14:46:22Z","updated_at":"2015-09-15T14:46:22Z","html_url":"https://github.com/GPII/gpii-express/pull/11#discussion_r39518877","pull_request_url":"https://api.github.com/repos/GPII/gpii-express/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/comments/39518877"},"html":{"href":"https://github.com/GPII/gpii-express/pull/11#discussion_r39518877"},"pull_request":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/GPII/gpii-express/pulls/11","id":45049562,"html_url":"https://github.com/GPII/gpii-express/pull/11","diff_url":"https://github.com/GPII/gpii-express/pull/11.diff","patch_url":"https://github.com/GPII/gpii-express/pull/11.patch","issue_url":"https://api.github.com/repos/GPII/gpii-express/issues/11","number":11,"state":"open","locked":false,"title":"GPII-1279:  Fixed problems with static middleware.","user":{"login":"the-t-in-rtf","id":5765222,"avatar_url":"https://avatars.githubusercontent.com/u/5765222?v=3","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"body":"There was a bug that would cause the static middleware to throw errors.  See [GPII-1279](https://issues.gpii.net/browse/GPII-1279) for details.","created_at":"2015-09-15T13:35:28Z","updated_at":"2015-09-15T14:46:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c46fa535ef1d81effc750fe1ad8b5186a15b51c","assignee":{"login":"amb26","id":561418,"avatar_url":"https://avatars.githubusercontent.com/u/561418?v=3","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GPII/gpii-express/pulls/11/commits","review_comments_url":"https://api.github.com/repos/GPII/gpii-express/pulls/11/comments","review_comment_url":"https://api.github.com/repos/GPII/gpii-express/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPII/gpii-express/issues/11/comments","statuses_url":"https://api.github.com/repos/GPII/gpii-express/statuses/8730441601db239870046c796b85c0f020a302a1","head":{"label":"the-t-in-rtf:GPII-1279","ref":"GPII-1279","sha":"8730441601db239870046c796b85c0f020a302a1","user":{"login":"the-t-in-rtf","id":5765222,"avatar_url":"https://avatars.githubusercontent.com/u/5765222?v=3","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"repo":{"id":30924618,"name":"gpii-express","full_name":"the-t-in-rtf/gpii-express","owner":{"login":"the-t-in-rtf","id":5765222,"avatar_url":"https://avatars.githubusercontent.com/u/5765222?v=3","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/the-t-in-rtf/gpii-express","description":"A fluid module to load express.js","fork":true,"url":"https://api.github.com/repos/the-t-in-rtf/gpii-express","forks_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/forks","keys_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/teams","hooks_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/hooks","issue_events_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/issues/events{/number}","events_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/events","assignees_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/assignees{/user}","branches_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/branches{/branch}","tags_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/tags","blobs_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/statuses/{sha}","languages_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/languages","stargazers_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/stargazers","contributors_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/contributors","subscribers_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/subscribers","subscription_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/subscription","commits_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/contents/{+path}","compare_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/merges","archive_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/downloads","issues_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/issues{/number}","pulls_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/pulls{/number}","milestones_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/milestones{/number}","notifications_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/labels{/name}","releases_url":"https://api.github.com/repos/the-t-in-rtf/gpii-express/releases{/id}","created_at":"2015-02-17T16:02:26Z","updated_at":"2015-03-03T15:50:27Z","pushed_at":"2015-09-15T12:42:42Z","git_url":"git://github.com/the-t-in-rtf/gpii-express.git","ssh_url":"git@github.com:the-t-in-rtf/gpii-express.git","clone_url":"https://github.com/the-t-in-rtf/gpii-express.git","svn_url":"https://github.com/the-t-in-rtf/gpii-express","homepage":null,"size":364,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GPII:master","ref":"master","sha":"a70110d98e45bca8c1d2a2db9034a64e78709477","user":{"login":"GPII","id":1343050,"avatar_url":"https://avatars.githubusercontent.com/u/1343050?v=3","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"repo":{"id":30625709,"name":"gpii-express","full_name":"GPII/gpii-express","owner":{"login":"GPII","id":1343050,"avatar_url":"https://avatars.githubusercontent.com/u/1343050?v=3","gravatar_id":"","url":"https://api.github.com/users/GPII","html_url":"https://github.com/GPII","followers_url":"https://api.github.com/users/GPII/followers","following_url":"https://api.github.com/users/GPII/following{/other_user}","gists_url":"https://api.github.com/users/GPII/gists{/gist_id}","starred_url":"https://api.github.com/users/GPII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPII/subscriptions","organizations_url":"https://api.github.com/users/GPII/orgs","repos_url":"https://api.github.com/users/GPII/repos","events_url":"https://api.github.com/users/GPII/events{/privacy}","received_events_url":"https://api.github.com/users/GPII/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GPII/gpii-express","description":"A fluid module to load express.js","fork":false,"url":"https://api.github.com/repos/GPII/gpii-express","forks_url":"https://api.github.com/repos/GPII/gpii-express/forks","keys_url":"https://api.github.com/repos/GPII/gpii-express/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPII/gpii-express/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPII/gpii-express/teams","hooks_url":"https://api.github.com/repos/GPII/gpii-express/hooks","issue_events_url":"https://api.github.com/repos/GPII/gpii-express/issues/events{/number}","events_url":"https://api.github.com/repos/GPII/gpii-express/events","assignees_url":"https://api.github.com/repos/GPII/gpii-express/assignees{/user}","branches_url":"https://api.github.com/repos/GPII/gpii-express/branches{/branch}","tags_url":"https://api.github.com/repos/GPII/gpii-express/tags","blobs_url":"https://api.github.com/repos/GPII/gpii-express/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPII/gpii-express/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPII/gpii-express/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPII/gpii-express/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPII/gpii-express/statuses/{sha}","languages_url":"https://api.github.com/repos/GPII/gpii-express/languages","stargazers_url":"https://api.github.com/repos/GPII/gpii-express/stargazers","contributors_url":"https://api.github.com/repos/GPII/gpii-express/contributors","subscribers_url":"https://api.github.com/repos/GPII/gpii-express/subscribers","subscription_url":"https://api.github.com/repos/GPII/gpii-express/subscription","commits_url":"https://api.github.com/repos/GPII/gpii-express/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPII/gpii-express/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPII/gpii-express/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPII/gpii-express/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPII/gpii-express/contents/{+path}","compare_url":"https://api.github.com/repos/GPII/gpii-express/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPII/gpii-express/merges","archive_url":"https://api.github.com/repos/GPII/gpii-express/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPII/gpii-express/downloads","issues_url":"https://api.github.com/repos/GPII/gpii-express/issues{/number}","pulls_url":"https://api.github.com/repos/GPII/gpii-express/pulls{/number}","milestones_url":"https://api.github.com/repos/GPII/gpii-express/milestones{/number}","notifications_url":"https://api.github.com/repos/GPII/gpii-express/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPII/gpii-express/labels{/name}","releases_url":"https://api.github.com/repos/GPII/gpii-express/releases{/id}","created_at":"2015-02-11T02:12:46Z","updated_at":"2015-06-03T18:30:00Z","pushed_at":"2015-09-15T13:35:28Z","git_url":"git://github.com/GPII/gpii-express.git","ssh_url":"git@github.com:GPII/gpii-express.git","clone_url":"https://github.com/GPII/gpii-express.git","svn_url":"https://github.com/GPII/gpii-express","homepage":null,"size":354,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/11"},"html":{"href":"https://github.com/GPII/gpii-express/pull/11"},"issue":{"href":"https://api.github.com/repos/GPII/gpii-express/issues/11"},"comments":{"href":"https://api.github.com/repos/GPII/gpii-express/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPII/gpii-express/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/GPII/gpii-express/statuses/8730441601db239870046c796b85c0f020a302a1"}}}}