{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/30845675","id":30845675,"diff_hunk":"@@ -29,7 +29,13 @@ std::map<std::string, pt::ptree> getQueryPacksContent() {\n   Status status = osquery::parseJSON(pack_path, pack_tree);\n   pt::ptree pack_file_element = pack_tree.get_child(\"test_pack_test\");\n \n-  result = QueryPackParsePacks(pack_file_element, false, true);\n+  ConfigDataInstance config;\n+  const auto& pack_parser = config.getParser(\"packs\");\n+  if (pack_parser == nullptr) {\n+    return result;\n+  }\n+  const auto& queryPackParser = std::static_pointer_cast<QueryPackConfigParserPlugin>(pack_parser);","path":"osquery/config/parsers/tests/query_packs_tests.cpp","position":24,"original_position":24,"commit_id":"886ad6e928ef064966b8d7f8a7f27d9eec106065","original_commit_id":"886ad6e928ef064966b8d7f8a7f27d9eec106065","user":{"login":"theopolis","id":981645,"avatar_url":"https://avatars.githubusercontent.com/u/981645?v=3","gravatar_id":"","url":"https://api.github.com/users/theopolis","html_url":"https://github.com/theopolis","followers_url":"https://api.github.com/users/theopolis/followers","following_url":"https://api.github.com/users/theopolis/following{/other_user}","gists_url":"https://api.github.com/users/theopolis/gists{/gist_id}","starred_url":"https://api.github.com/users/theopolis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theopolis/subscriptions","organizations_url":"https://api.github.com/users/theopolis/orgs","repos_url":"https://api.github.com/users/theopolis/repos","events_url":"https://api.github.com/users/theopolis/events{/privacy}","received_events_url":"https://api.github.com/users/theopolis/received_events","type":"User","site_admin":false},"body":"Check and make sure queryPackParser != nullptr","created_at":"2015-05-21T20:46:27Z","updated_at":"2015-05-21T20:46:27Z","html_url":"https://github.com/facebook/osquery/pull/1155#discussion_r30845675","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/1155","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/30845675"},"html":{"href":"https://github.com/facebook/osquery/pull/1155#discussion_r30845675"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1155"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/1155","id":35975457,"html_url":"https://github.com/facebook/osquery/pull/1155","diff_url":"https://github.com/facebook/osquery/pull/1155.diff","patch_url":"https://github.com/facebook/osquery/pull/1155.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/1155","number":1155,"state":"open","locked":false,"title":"Osquery packs table","user":{"login":"javuto","id":1271349,"avatar_url":"https://avatars.githubusercontent.com/u/1271349?v=3","gravatar_id":"","url":"https://api.github.com/users/javuto","html_url":"https://github.com/javuto","followers_url":"https://api.github.com/users/javuto/followers","following_url":"https://api.github.com/users/javuto/following{/other_user}","gists_url":"https://api.github.com/users/javuto/gists{/gist_id}","starred_url":"https://api.github.com/users/javuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javuto/subscriptions","organizations_url":"https://api.github.com/users/javuto/orgs","repos_url":"https://api.github.com/users/javuto/repos","events_url":"https://api.github.com/users/javuto/events{/privacy}","received_events_url":"https://api.github.com/users/javuto/received_events","type":"User","site_admin":false},"body":"Query packs table to check what queries are loaded and verify whether they are scheduled or not","created_at":"2015-05-21T20:44:20Z","updated_at":"2015-05-21T20:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b40d6e2bcc9e2c92f3f44170e6ba3fe7a0dac34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/1155/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/1155/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/1155/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/886ad6e928ef064966b8d7f8a7f27d9eec106065","head":{"label":"javuto:osquery_packs_table","ref":"osquery_packs_table","sha":"886ad6e928ef064966b8d7f8a7f27d9eec106065","user":{"login":"javuto","id":1271349,"avatar_url":"https://avatars.githubusercontent.com/u/1271349?v=3","gravatar_id":"","url":"https://api.github.com/users/javuto","html_url":"https://github.com/javuto","followers_url":"https://api.github.com/users/javuto/followers","following_url":"https://api.github.com/users/javuto/following{/other_user}","gists_url":"https://api.github.com/users/javuto/gists{/gist_id}","starred_url":"https://api.github.com/users/javuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javuto/subscriptions","organizations_url":"https://api.github.com/users/javuto/orgs","repos_url":"https://api.github.com/users/javuto/repos","events_url":"https://api.github.com/users/javuto/events{/privacy}","received_events_url":"https://api.github.com/users/javuto/received_events","type":"User","site_admin":false},"repo":{"id":34071717,"name":"osquery","full_name":"javuto/osquery","owner":{"login":"javuto","id":1271349,"avatar_url":"https://avatars.githubusercontent.com/u/1271349?v=3","gravatar_id":"","url":"https://api.github.com/users/javuto","html_url":"https://github.com/javuto","followers_url":"https://api.github.com/users/javuto/followers","following_url":"https://api.github.com/users/javuto/following{/other_user}","gists_url":"https://api.github.com/users/javuto/gists{/gist_id}","starred_url":"https://api.github.com/users/javuto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javuto/subscriptions","organizations_url":"https://api.github.com/users/javuto/orgs","repos_url":"https://api.github.com/users/javuto/repos","events_url":"https://api.github.com/users/javuto/events{/privacy}","received_events_url":"https://api.github.com/users/javuto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javuto/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/javuto/osquery","forks_url":"https://api.github.com/repos/javuto/osquery/forks","keys_url":"https://api.github.com/repos/javuto/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javuto/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javuto/osquery/teams","hooks_url":"https://api.github.com/repos/javuto/osquery/hooks","issue_events_url":"https://api.github.com/repos/javuto/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/javuto/osquery/events","assignees_url":"https://api.github.com/repos/javuto/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/javuto/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/javuto/osquery/tags","blobs_url":"https://api.github.com/repos/javuto/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javuto/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javuto/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/javuto/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javuto/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/javuto/osquery/languages","stargazers_url":"https://api.github.com/repos/javuto/osquery/stargazers","contributors_url":"https://api.github.com/repos/javuto/osquery/contributors","subscribers_url":"https://api.github.com/repos/javuto/osquery/subscribers","subscription_url":"https://api.github.com/repos/javuto/osquery/subscription","commits_url":"https://api.github.com/repos/javuto/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/javuto/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/javuto/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/javuto/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/javuto/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/javuto/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javuto/osquery/merges","archive_url":"https://api.github.com/repos/javuto/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javuto/osquery/downloads","issues_url":"https://api.github.com/repos/javuto/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/javuto/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/javuto/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/javuto/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javuto/osquery/labels{/name}","releases_url":"https://api.github.com/repos/javuto/osquery/releases{/id}","created_at":"2015-04-16T17:59:16Z","updated_at":"2015-05-08T19:21:42Z","pushed_at":"2015-05-21T20:42:51Z","git_url":"git://github.com/javuto/osquery.git","ssh_url":"git@github.com:javuto/osquery.git","clone_url":"https://github.com/javuto/osquery.git","svn_url":"https://github.com/javuto/osquery","homepage":"https://osquery.io","size":5083,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4ff2fc1db2c46170cd27f533396188588dea06bb","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","created_at":"2014-07-29T20:27:33Z","updated_at":"2015-05-21T15:30:50Z","pushed_at":"2015-05-21T20:44:20Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":17421,"stargazers_count":4217,"watchers_count":4217,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":31,"forks":335,"open_issues":31,"watchers":4217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1155"},"html":{"href":"https://github.com/facebook/osquery/pull/1155"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/1155"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/1155/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1155/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/1155/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/886ad6e928ef064966b8d7f8a7f27d9eec106065"}}}}