{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/41974291","id":41974291,"diff_hunk":"@@ -955,6 +959,7 @@ type testFunc func(*client.Client)\n func addFlags(fs *pflag.FlagSet) {\n \tfs.IntVar(\n \t\t&maxConcurrency, \"max-concurrency\", -1, \"Maximum number of tests to be run simultaneously. Unlimited if set to negative.\")\n+\tfs.StringVar(&etcdServer, \"etcd-server\", \"\", \"etcd server URL.\")","path":"cmd/integration/integration.go","position":22,"original_position":22,"commit_id":"d9838d7f93978dd428625ed8c383354eb800a601","original_commit_id":"d9838d7f93978dd428625ed8c383354eb800a601","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"this also needs port, right? (maybe ... URL in http://host:port format)?\r\n\r\nAlso, how about being consistent with other places and use \"etcd-servers\" instead to handle multiple etcd servers too:\r\nhttps://github.com/kubernetes/kubernetes/blob/master/cmd/kube-apiserver/app/server.go#L214","created_at":"2015-10-14T09:51:25Z","updated_at":"2015-10-14T09:51:25Z","html_url":"https://github.com/kubernetes/kubernetes/pull/15586#discussion_r41974291","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/41974291"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15586#discussion_r41974291"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586","id":47606110,"html_url":"https://github.com/kubernetes/kubernetes/pull/15586","diff_url":"https://github.com/kubernetes/kubernetes/pull/15586.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/15586.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15586","number":15586,"state":"open","locked":false,"title":"Use a random port for the test etcd server","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"This allows us to run multiple instances of the verification checks, the integration test, etc. simultaneously on a single host (e.g. the PR Jenkins).\r\n\r\nref #14781\r\n\r\n@kubernetes/goog-testing ","created_at":"2015-10-14T00:36:09Z","updated_at":"2015-10-14T09:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d8ab496e5f1eb3f0739e12748a065e2ca70d5f7","assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15586/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d9838d7f93978dd428625ed8c383354eb800a601","head":{"label":"ixdy:etcd-in-tests","ref":"etcd-in-tests","sha":"d9838d7f93978dd428625ed8c383354eb800a601","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"repo":{"id":30381779,"name":"kubernetes","full_name":"ixdy/kubernetes","owner":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ixdy/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ixdy/kubernetes","forks_url":"https://api.github.com/repos/ixdy/kubernetes/forks","keys_url":"https://api.github.com/repos/ixdy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ixdy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ixdy/kubernetes/teams","hooks_url":"https://api.github.com/repos/ixdy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ixdy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ixdy/kubernetes/events","assignees_url":"https://api.github.com/repos/ixdy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ixdy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ixdy/kubernetes/tags","blobs_url":"https://api.github.com/repos/ixdy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ixdy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ixdy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ixdy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ixdy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ixdy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ixdy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ixdy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ixdy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ixdy/kubernetes/subscription","commits_url":"https://api.github.com/repos/ixdy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ixdy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ixdy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ixdy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ixdy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ixdy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ixdy/kubernetes/merges","archive_url":"https://api.github.com/repos/ixdy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ixdy/kubernetes/downloads","issues_url":"https://api.github.com/repos/ixdy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ixdy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ixdy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ixdy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ixdy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ixdy/kubernetes/releases{/id}","created_at":"2015-02-05T22:25:25Z","updated_at":"2015-02-26T20:09:10Z","pushed_at":"2015-10-14T00:46:13Z","git_url":"git://github.com/ixdy/kubernetes.git","ssh_url":"git@github.com:ixdy/kubernetes.git","clone_url":"https://github.com/ixdy/kubernetes.git","svn_url":"https://github.com/ixdy/kubernetes","homepage":"http://kubernetes.io","size":114289,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0e0ae670ad8b4f95f599799580f76c6b56a8eb95","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-10-14T09:21:24Z","pushed_at":"2015-10-14T09:46:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":458154,"stargazers_count":10690,"watchers_count":10690,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2705,"mirror_url":null,"open_issues_count":2027,"forks":2705,"open_issues":2027,"watchers":10690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15586"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15586"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15586/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15586/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d9838d7f93978dd428625ed8c383354eb800a601"}}}}