{"action":"opened","number":24629,"pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629","id":30761037,"html_url":"https://github.com/brianchandotcom/liferay-portal/pull/24629","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/24629.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/24629.patch","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24629","number":24629,"state":"open","locked":false,"title":"LPS-54041 Portal Service Access Control Profile","user":{"login":"mikakoivisto","id":595740,"avatar_url":"https://avatars.githubusercontent.com/u/595740?v=3","gravatar_id":"","url":"https://api.github.com/users/mikakoivisto","html_url":"https://github.com/mikakoivisto","followers_url":"https://api.github.com/users/mikakoivisto/followers","following_url":"https://api.github.com/users/mikakoivisto/following{/other_user}","gists_url":"https://api.github.com/users/mikakoivisto/gists{/gist_id}","starred_url":"https://api.github.com/users/mikakoivisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikakoivisto/subscriptions","organizations_url":"https://api.github.com/users/mikakoivisto/orgs","repos_url":"https://api.github.com/users/mikakoivisto/repos","events_url":"https://api.github.com/users/mikakoivisto/events{/privacy}","received_events_url":"https://api.github.com/users/mikakoivisto/received_events","type":"User","site_admin":false},"body":"Hi Brian, \r\n\r\nI'm sending this in small pieces for you to review as I progress. You can either merge it into master or just send me a pull request with your changes so I can include them in the next piece. I think this way it's easiest for you to review as we go. \r\n\r\nFirst little background on what we are doing. We are creating a way for portal administrator to create predefined service access control profiles that declare what services or service methods can be called. Basically this is creating a more fine grained control than what we already have in OAuth where you can only define either READ or WRITE. This will also be completely separate from OAuth and can be attached to any Remote API authorisation method. These profiles can the be granted to different applications. Enforcing the profiles will be done by a new AccessControlPolicy.\r\n\r\nThis module will provide the backend implementation for the public API we'll be creating in portal-service com.liferay.portal.security.ac where two new interfaces will be added: ServiceAccessControlProfile and ServiceAccessControlProfileService. Each profile is tied to a portal instance. We decided to put this part under modules/portal because it is a portal wide service.","created_at":"2015-03-09T13:45:34Z","updated_at":"2015-03-09T13:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629/commits","review_comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629/comments","review_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24629/comments","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/0437a6083a388bb51c191c54c61ccce11ce393fe","head":{"label":"mikakoivisto:LPS-54041","ref":"LPS-54041","sha":"0437a6083a388bb51c191c54c61ccce11ce393fe","user":{"login":"mikakoivisto","id":595740,"avatar_url":"https://avatars.githubusercontent.com/u/595740?v=3","gravatar_id":"","url":"https://api.github.com/users/mikakoivisto","html_url":"https://github.com/mikakoivisto","followers_url":"https://api.github.com/users/mikakoivisto/followers","following_url":"https://api.github.com/users/mikakoivisto/following{/other_user}","gists_url":"https://api.github.com/users/mikakoivisto/gists{/gist_id}","starred_url":"https://api.github.com/users/mikakoivisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikakoivisto/subscriptions","organizations_url":"https://api.github.com/users/mikakoivisto/orgs","repos_url":"https://api.github.com/users/mikakoivisto/repos","events_url":"https://api.github.com/users/mikakoivisto/events{/privacy}","received_events_url":"https://api.github.com/users/mikakoivisto/received_events","type":"User","site_admin":false},"repo":{"id":1926222,"name":"liferay-portal","full_name":"mikakoivisto/liferay-portal","owner":{"login":"mikakoivisto","id":595740,"avatar_url":"https://avatars.githubusercontent.com/u/595740?v=3","gravatar_id":"","url":"https://api.github.com/users/mikakoivisto","html_url":"https://github.com/mikakoivisto","followers_url":"https://api.github.com/users/mikakoivisto/followers","following_url":"https://api.github.com/users/mikakoivisto/following{/other_user}","gists_url":"https://api.github.com/users/mikakoivisto/gists{/gist_id}","starred_url":"https://api.github.com/users/mikakoivisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikakoivisto/subscriptions","organizations_url":"https://api.github.com/users/mikakoivisto/orgs","repos_url":"https://api.github.com/users/mikakoivisto/repos","events_url":"https://api.github.com/users/mikakoivisto/events{/privacy}","received_events_url":"https://api.github.com/users/mikakoivisto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikakoivisto/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/mikakoivisto/liferay-portal","forks_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/forks","keys_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/teams","hooks_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/events","assignees_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/tags","blobs_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/subscription","commits_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/merges","archive_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/downloads","issues_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/mikakoivisto/liferay-portal/releases{/id}","created_at":"2011-06-20T22:11:46Z","updated_at":"2015-03-04T08:40:59Z","pushed_at":"2015-03-06T08:47:51Z","git_url":"git://github.com/mikakoivisto/liferay-portal.git","ssh_url":"git@github.com:mikakoivisto/liferay-portal.git","clone_url":"https://github.com/mikakoivisto/liferay-portal.git","svn_url":"https://github.com/mikakoivisto/liferay-portal","homepage":"http://liferay.com","size":4111909,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"brianchandotcom:master","ref":"master","sha":"4724fe5eae8630d2fef21094c344f8ed831a7f9b","user":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"repo":{"id":1920851,"name":"liferay-portal","full_name":"brianchandotcom/liferay-portal","owner":{"login":"brianchandotcom","id":282080,"avatar_url":"https://avatars.githubusercontent.com/u/282080?v=3","gravatar_id":"","url":"https://api.github.com/users/brianchandotcom","html_url":"https://github.com/brianchandotcom","followers_url":"https://api.github.com/users/brianchandotcom/followers","following_url":"https://api.github.com/users/brianchandotcom/following{/other_user}","gists_url":"https://api.github.com/users/brianchandotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/brianchandotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianchandotcom/subscriptions","organizations_url":"https://api.github.com/users/brianchandotcom/orgs","repos_url":"https://api.github.com/users/brianchandotcom/repos","events_url":"https://api.github.com/users/brianchandotcom/events{/privacy}","received_events_url":"https://api.github.com/users/brianchandotcom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianchandotcom/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/brianchandotcom/liferay-portal","forks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/releases{/id}","created_at":"2011-06-19T21:37:56Z","updated_at":"2015-03-09T04:34:35Z","pushed_at":"2015-03-09T12:25:04Z","git_url":"git://github.com/brianchandotcom/liferay-portal.git","ssh_url":"git@github.com:brianchandotcom/liferay-portal.git","clone_url":"https://github.com/brianchandotcom/liferay-portal.git","svn_url":"https://github.com/brianchandotcom/liferay-portal","homepage":"http://liferay.com","size":4685698,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629"},"html":{"href":"https://github.com/brianchandotcom/liferay-portal/pull/24629"},"issue":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24629"},"comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/24629/comments"},"review_comments":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629/comments"},"review_comment":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/24629/commits"},"statuses":{"href":"https://api.github.com/repos/brianchandotcom/liferay-portal/statuses/0437a6083a388bb51c191c54c61ccce11ce393fe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":64,"deletions":0,"changed_files":3}}