{"action":"created","issue":{"url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/72","labels_url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/72/comments","events_url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/72/events","html_url":"https://github.com/AOSC-Dev/autobuild3/issues/72","id":109793801,"number":72,"title":"AB_FLAGS_XXX do not work in defines","user":{"login":"Icenowy","id":1916518,"avatar_url":"https://avatars.githubusercontent.com/u/1916518?v=3","gravatar_id":"","url":"https://api.github.com/users/Icenowy","html_url":"https://github.com/Icenowy","followers_url":"https://api.github.com/users/Icenowy/followers","following_url":"https://api.github.com/users/Icenowy/following{/other_user}","gists_url":"https://api.github.com/users/Icenowy/gists{/gist_id}","starred_url":"https://api.github.com/users/Icenowy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Icenowy/subscriptions","organizations_url":"https://api.github.com/users/Icenowy/orgs","repos_url":"https://api.github.com/users/Icenowy/repos","events_url":"https://api.github.com/users/Icenowy/events{/privacy}","received_events_url":"https://api.github.com/users/Icenowy/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AOSC-Dev/autobuild3/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"MingcongBai","id":5006263,"avatar_url":"https://avatars.githubusercontent.com/u/5006263?v=3","gravatar_id":"","url":"https://api.github.com/users/MingcongBai","html_url":"https://github.com/MingcongBai","followers_url":"https://api.github.com/users/MingcongBai/followers","following_url":"https://api.github.com/users/MingcongBai/following{/other_user}","gists_url":"https://api.github.com/users/MingcongBai/gists{/gist_id}","starred_url":"https://api.github.com/users/MingcongBai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MingcongBai/subscriptions","organizations_url":"https://api.github.com/users/MingcongBai/orgs","repos_url":"https://api.github.com/users/MingcongBai/repos","events_url":"https://api.github.com/users/MingcongBai/events{/privacy}","received_events_url":"https://api.github.com/users/MingcongBai/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-10-05T13:16:48Z","updated_at":"2015-10-05T13:42:48Z","closed_at":null,"body":"as the title says\ntest case is extra-libs/js-24"},"comment":{"url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/comments/145531206","html_url":"https://github.com/AOSC-Dev/autobuild3/issues/72#issuecomment-145531206","issue_url":"https://api.github.com/repos/AOSC-Dev/autobuild3/issues/72","id":145531206,"user":{"login":"MingcongBai","id":5006263,"avatar_url":"https://avatars.githubusercontent.com/u/5006263?v=3","gravatar_id":"","url":"https://api.github.com/users/MingcongBai","html_url":"https://github.com/MingcongBai","followers_url":"https://api.github.com/users/MingcongBai/followers","following_url":"https://api.github.com/users/MingcongBai/following{/other_user}","gists_url":"https://api.github.com/users/MingcongBai/gists{/gist_id}","starred_url":"https://api.github.com/users/MingcongBai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MingcongBai/subscriptions","organizations_url":"https://api.github.com/users/MingcongBai/orgs","repos_url":"https://api.github.com/users/MingcongBai/repos","events_url":"https://api.github.com/users/MingcongBai/events{/privacy}","received_events_url":"https://api.github.com/users/MingcongBai/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T13:42:48Z","updated_at":"2015-10-05T13:42:48Z","body":"> As mentioned in IRC, flag-dependent decisions in arch/_common.sh should be moved into another file to be sourced after arch_loaddef.\r\n\r\nJust making sure, I will move the parts with\r\n\r\n```\r\n...\r\nif ((AB_FLAGS_PIE)); then LDFLAGS_COMMON+='-fPIE -pie ' CFLAGS_COMMON+='-fPIE '; fi\r\nif ((AB_FLAGS_SSP)); then CFLAGS_COMMON+='-fstack-protector-strong --param=ssp-buffer-size=4 '; fi\r\nif ((AB_FLAGS_RRO)); then LDFLAGS_COMMON+='-Wl,-z,relro '; fi\r\nif ((AB_FLAGS_NOW)); then LDFLAGS_COMMON+='-Wl,-z,now '; fi\r\n...\r\n```\r\n\r\nTo another file sourced after defines, right?"}}