{"action":"created","issue":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/376","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/376/comments","events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/376/events","html_url":"https://github.com/gnuradio/gnuradio/pull/376","id":56897439,"number":376,"title":"Corr only","user":{"login":"bistromath","id":399787,"avatar_url":"https://avatars.githubusercontent.com/u/399787?v=3","gravatar_id":"","url":"https://api.github.com/users/bistromath","html_url":"https://github.com/bistromath","followers_url":"https://api.github.com/users/bistromath/followers","following_url":"https://api.github.com/users/bistromath/following{/other_user}","gists_url":"https://api.github.com/users/bistromath/gists{/gist_id}","starred_url":"https://api.github.com/users/bistromath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bistromath/subscriptions","organizations_url":"https://api.github.com/users/bistromath/orgs","repos_url":"https://api.github.com/users/bistromath/repos","events_url":"https://api.github.com/users/bistromath/events{/privacy}","received_events_url":"https://api.github.com/users/bistromath/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gnuradio/gnuradio/labels/master","name":"master","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-07T04:46:46Z","updated_at":"2015-02-07T04:56:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/376","html_url":"https://github.com/gnuradio/gnuradio/pull/376","diff_url":"https://github.com/gnuradio/gnuradio/pull/376.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/376.patch"},"body":"This branch separates out my and Andy Walls's work on modifying the correlate and sync block from the MSK branch on which it was based, and rebases the work on master.\r\n\r\nMy work allows the user to modulate a candidate (preamble) vector with the modulator of their choice using the modulate_vector block, allowing the correlate_and_sync block to therefore be modulation independent. I've updated the test_corr_and_sync example in gr-digital/examples to show the operation of the new block.\r\n\r\nAndy's work fixed a lot of bugs in the block, adjusted phase_est and time_est calculations, Volkified the work function, and generally cleaned things up."},"comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments/73350170","html_url":"https://github.com/gnuradio/gnuradio/pull/376#issuecomment-73350170","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/376","id":73350170,"user":{"login":"bistromath","id":399787,"avatar_url":"https://avatars.githubusercontent.com/u/399787?v=3","gravatar_id":"","url":"https://api.github.com/users/bistromath","html_url":"https://github.com/bistromath","followers_url":"https://api.github.com/users/bistromath/followers","following_url":"https://api.github.com/users/bistromath/following{/other_user}","gists_url":"https://api.github.com/users/bistromath/gists{/gist_id}","starred_url":"https://api.github.com/users/bistromath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bistromath/subscriptions","organizations_url":"https://api.github.com/users/bistromath/orgs","repos_url":"https://api.github.com/users/bistromath/repos","events_url":"https://api.github.com/users/bistromath/events{/privacy}","received_events_url":"https://api.github.com/users/bistromath/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T04:56:54Z","updated_at":"2015-02-07T04:56:54Z","body":"Oh, I thought API breakage was OK for master (but not for maint). The API\nnecessarily changes as the utility of the block is now significantly\ndifferent. This is not intended for maint.\n\nOn Fri, Feb 6, 2015 at 8:55 PM, Johnathan Corgan <notifications@github.com>\nwrote:\n\n> Ultimately, this will be up to @trondeau <https://github.com/trondeau> to\n> review and merge, but one thing I noticed--there is a public API visible\n> change in correlate_and_sync_cc::make, which would force this as-is to go\n> into the 3.8 branch.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/gnuradio/gnuradio/pull/376#issuecomment-73350116>.\n>\n"}}