{"action":"opened","number":535,"pull_request":{"url":"https://api.github.com/repos/GMOD/Apollo/pulls/535","id":42197152,"html_url":"https://github.com/GMOD/Apollo/pull/535","diff_url":"https://github.com/GMOD/Apollo/pull/535.diff","patch_url":"https://github.com/GMOD/Apollo/pull/535.patch","issue_url":"https://api.github.com/repos/GMOD/Apollo/issues/535","number":535,"state":"open","locked":false,"title":"Fixup non canon","user":{"login":"cmdcolin","id":6511937,"avatar_url":"https://avatars.githubusercontent.com/u/6511937?v=3","gravatar_id":"","url":"https://api.github.com/users/cmdcolin","html_url":"https://github.com/cmdcolin","followers_url":"https://api.github.com/users/cmdcolin/followers","following_url":"https://api.github.com/users/cmdcolin/following{/other_user}","gists_url":"https://api.github.com/users/cmdcolin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmdcolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmdcolin/subscriptions","organizations_url":"https://api.github.com/users/cmdcolin/orgs","repos_url":"https://api.github.com/users/cmdcolin/repos","events_url":"https://api.github.com/users/cmdcolin/events{/privacy}","received_events_url":"https://api.github.com/users/cmdcolin/received_events","type":"User","site_admin":false},"body":"Here is an initial fix for #531 \r\nIt does fix (in test cases that I had) the issues with sequence alterations miscalculating non-canon splice sites on the negative strand\r\n\r\n\r\nHere are some remaining issues that are I think not big problems, but just notable.\r\n\r\n- Haven't really tested deletions very much but seems to work if it's in an intron (doens't affective non canon splice site flags)\r\n- Insertions larger than 2 bp inside a splice site cause a string out of bounds exception (I am probably just overlooking something here)\r\n- Non-canon splice sites exclamation marks are slightly off center in the plus strand features but they do seem to be calculated appropriately otherwise?\r\n\r\nI just wanted to get this available for review ASAP, please test and comment :+1: \r\n\r\n\r\n","created_at":"2015-08-12T01:45:45Z","updated_at":"2015-08-12T01:45:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GMOD/Apollo/pulls/535/commits","review_comments_url":"https://api.github.com/repos/GMOD/Apollo/pulls/535/comments","review_comment_url":"https://api.github.com/repos/GMOD/Apollo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GMOD/Apollo/issues/535/comments","statuses_url":"https://api.github.com/repos/GMOD/Apollo/statuses/0acbd91921f8236b0cc41ce9a0996bccf49a716d","head":{"label":"GMOD:fixup_non_canon","ref":"fixup_non_canon","sha":"0acbd91921f8236b0cc41ce9a0996bccf49a716d","user":{"login":"GMOD","id":342482,"avatar_url":"https://avatars.githubusercontent.com/u/342482?v=3","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"repo":{"id":13471446,"name":"Apollo","full_name":"GMOD/Apollo","owner":{"login":"GMOD","id":342482,"avatar_url":"https://avatars.githubusercontent.com/u/342482?v=3","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GMOD/Apollo","description":"Genome annotation editor, with a Java servlet backend and a Javascript client that runs in a web browser as a JBrowse plugin","fork":false,"url":"https://api.github.com/repos/GMOD/Apollo","forks_url":"https://api.github.com/repos/GMOD/Apollo/forks","keys_url":"https://api.github.com/repos/GMOD/Apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMOD/Apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMOD/Apollo/teams","hooks_url":"https://api.github.com/repos/GMOD/Apollo/hooks","issue_events_url":"https://api.github.com/repos/GMOD/Apollo/issues/events{/number}","events_url":"https://api.github.com/repos/GMOD/Apollo/events","assignees_url":"https://api.github.com/repos/GMOD/Apollo/assignees{/user}","branches_url":"https://api.github.com/repos/GMOD/Apollo/branches{/branch}","tags_url":"https://api.github.com/repos/GMOD/Apollo/tags","blobs_url":"https://api.github.com/repos/GMOD/Apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMOD/Apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMOD/Apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMOD/Apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMOD/Apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/GMOD/Apollo/languages","stargazers_url":"https://api.github.com/repos/GMOD/Apollo/stargazers","contributors_url":"https://api.github.com/repos/GMOD/Apollo/contributors","subscribers_url":"https://api.github.com/repos/GMOD/Apollo/subscribers","subscription_url":"https://api.github.com/repos/GMOD/Apollo/subscription","commits_url":"https://api.github.com/repos/GMOD/Apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMOD/Apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMOD/Apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMOD/Apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMOD/Apollo/contents/{+path}","compare_url":"https://api.github.com/repos/GMOD/Apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMOD/Apollo/merges","archive_url":"https://api.github.com/repos/GMOD/Apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMOD/Apollo/downloads","issues_url":"https://api.github.com/repos/GMOD/Apollo/issues{/number}","pulls_url":"https://api.github.com/repos/GMOD/Apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/GMOD/Apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/GMOD/Apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMOD/Apollo/labels{/name}","releases_url":"https://api.github.com/repos/GMOD/Apollo/releases{/id}","created_at":"2013-10-10T13:05:28Z","updated_at":"2015-07-29T14:42:02Z","pushed_at":"2015-08-12T01:45:45Z","git_url":"git://github.com/GMOD/Apollo.git","ssh_url":"git@github.com:GMOD/Apollo.git","clone_url":"https://github.com/GMOD/Apollo.git","svn_url":"https://github.com/GMOD/Apollo","homepage":"","size":134618,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":172,"forks":18,"open_issues":172,"watchers":13,"default_branch":"master"}},"base":{"label":"GMOD:master","ref":"master","sha":"9d004f50d5e5922aef8cee15729e890f4ac112c0","user":{"login":"GMOD","id":342482,"avatar_url":"https://avatars.githubusercontent.com/u/342482?v=3","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"repo":{"id":13471446,"name":"Apollo","full_name":"GMOD/Apollo","owner":{"login":"GMOD","id":342482,"avatar_url":"https://avatars.githubusercontent.com/u/342482?v=3","gravatar_id":"","url":"https://api.github.com/users/GMOD","html_url":"https://github.com/GMOD","followers_url":"https://api.github.com/users/GMOD/followers","following_url":"https://api.github.com/users/GMOD/following{/other_user}","gists_url":"https://api.github.com/users/GMOD/gists{/gist_id}","starred_url":"https://api.github.com/users/GMOD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMOD/subscriptions","organizations_url":"https://api.github.com/users/GMOD/orgs","repos_url":"https://api.github.com/users/GMOD/repos","events_url":"https://api.github.com/users/GMOD/events{/privacy}","received_events_url":"https://api.github.com/users/GMOD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GMOD/Apollo","description":"Genome annotation editor, with a Java servlet backend and a Javascript client that runs in a web browser as a JBrowse plugin","fork":false,"url":"https://api.github.com/repos/GMOD/Apollo","forks_url":"https://api.github.com/repos/GMOD/Apollo/forks","keys_url":"https://api.github.com/repos/GMOD/Apollo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMOD/Apollo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMOD/Apollo/teams","hooks_url":"https://api.github.com/repos/GMOD/Apollo/hooks","issue_events_url":"https://api.github.com/repos/GMOD/Apollo/issues/events{/number}","events_url":"https://api.github.com/repos/GMOD/Apollo/events","assignees_url":"https://api.github.com/repos/GMOD/Apollo/assignees{/user}","branches_url":"https://api.github.com/repos/GMOD/Apollo/branches{/branch}","tags_url":"https://api.github.com/repos/GMOD/Apollo/tags","blobs_url":"https://api.github.com/repos/GMOD/Apollo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMOD/Apollo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMOD/Apollo/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMOD/Apollo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMOD/Apollo/statuses/{sha}","languages_url":"https://api.github.com/repos/GMOD/Apollo/languages","stargazers_url":"https://api.github.com/repos/GMOD/Apollo/stargazers","contributors_url":"https://api.github.com/repos/GMOD/Apollo/contributors","subscribers_url":"https://api.github.com/repos/GMOD/Apollo/subscribers","subscription_url":"https://api.github.com/repos/GMOD/Apollo/subscription","commits_url":"https://api.github.com/repos/GMOD/Apollo/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMOD/Apollo/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMOD/Apollo/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMOD/Apollo/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMOD/Apollo/contents/{+path}","compare_url":"https://api.github.com/repos/GMOD/Apollo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMOD/Apollo/merges","archive_url":"https://api.github.com/repos/GMOD/Apollo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMOD/Apollo/downloads","issues_url":"https://api.github.com/repos/GMOD/Apollo/issues{/number}","pulls_url":"https://api.github.com/repos/GMOD/Apollo/pulls{/number}","milestones_url":"https://api.github.com/repos/GMOD/Apollo/milestones{/number}","notifications_url":"https://api.github.com/repos/GMOD/Apollo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMOD/Apollo/labels{/name}","releases_url":"https://api.github.com/repos/GMOD/Apollo/releases{/id}","created_at":"2013-10-10T13:05:28Z","updated_at":"2015-07-29T14:42:02Z","pushed_at":"2015-08-12T01:45:45Z","git_url":"git://github.com/GMOD/Apollo.git","ssh_url":"git@github.com:GMOD/Apollo.git","clone_url":"https://github.com/GMOD/Apollo.git","svn_url":"https://github.com/GMOD/Apollo","homepage":"","size":134618,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":172,"forks":18,"open_issues":172,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GMOD/Apollo/pulls/535"},"html":{"href":"https://github.com/GMOD/Apollo/pull/535"},"issue":{"href":"https://api.github.com/repos/GMOD/Apollo/issues/535"},"comments":{"href":"https://api.github.com/repos/GMOD/Apollo/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/GMOD/Apollo/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/GMOD/Apollo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GMOD/Apollo/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/GMOD/Apollo/statuses/0acbd91921f8236b0cc41ce9a0996bccf49a716d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":7,"additions":108,"deletions":278,"changed_files":3}}