{"action":"created","comment":{"url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/comments/28173491","id":28173491,"diff_hunk":"@@ -8,26 +8,27 @@ The data subset selector file specifies subsets of M-Lab data, either for single\n {\n     \"file_format_version\": 1.1,\n     \"duration\": \"30d\",\n-    \"metric\": \"download_throughput\",\n+    \"metrics\": [\"download_throughput\"],\n     \"ip_translation\":{\n         \"strategy\": \"maxmind\",\n         \"params\": {\n           \"db_snapshots\": [\"2014-08-04\"]\n         }\n     },\n-    \"site\": \"lga01\",\n-    \"client_provider\": \"Verizon\",\n-    \"start_time\": \"2014-07-01T00:00:00Z\"\n+    \"start_times\": [\"2014-07-01T00:00:00Z\"],\n+    \"sites\": [\"lga01\", \"lga02\"],\n+    \"client_providers\": [\"Verizon\", \"comcast\", \"cablevision\"],\n+    \"client_countries\": [\"us\"]\n }\n ```\n \n # Field Specifications\n \n-`file_format_version`: Specifies the version of this format file. This must be 1.\n+`file_format_version`: Specifies the version of this format file. This must be 1.1","path":"documentation/selector-file-spec.md","position":25,"original_position":25,"commit_id":"dc5c813c6708bdba08a9eea4d68961e970a1761f","original_commit_id":"dc5c813c6708bdba08a9eea4d68961e970a1761f","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"body":"Missing ending period.","created_at":"2015-04-10T19:31:16Z","updated_at":"2015-04-10T19:31:16Z","html_url":"https://github.com/m-lab-tools/telescope/pull/45#discussion_r28173491","pull_request_url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/comments/28173491"},"html":{"href":"https://github.com/m-lab-tools/telescope/pull/45#discussion_r28173491"},"pull_request":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45","id":32643653,"html_url":"https://github.com/m-lab-tools/telescope/pull/45","diff_url":"https://github.com/m-lab-tools/telescope/pull/45.diff","patch_url":"https://github.com/m-lab-tools/telescope/pull/45.patch","issue_url":"https://api.github.com/repos/m-lab-tools/telescope/issues/45","number":45,"state":"open","locked":false,"title":"Support client country property with minor code cleanup","user":{"login":"collina","id":582005,"avatar_url":"https://avatars.githubusercontent.com/u/582005?v=3","gravatar_id":"","url":"https://api.github.com/users/collina","html_url":"https://github.com/collina","followers_url":"https://api.github.com/users/collina/followers","following_url":"https://api.github.com/users/collina/following{/other_user}","gists_url":"https://api.github.com/users/collina/gists{/gist_id}","starred_url":"https://api.github.com/users/collina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collina/subscriptions","organizations_url":"https://api.github.com/users/collina/orgs","repos_url":"https://api.github.com/users/collina/repos","events_url":"https://api.github.com/users/collina/events{/privacy}","received_events_url":"https://api.github.com/users/collina/received_events","type":"User","site_admin":false},"body":"In addition, covers tickets: #23","created_at":"2015-04-05T03:46:02Z","updated_at":"2015-04-10T19:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cf08fb9acc344fd67bac57ed5b99919111bc482","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45/commits","review_comments_url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45/comments","review_comment_url":"https://api.github.com/repos/m-lab-tools/telescope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m-lab-tools/telescope/issues/45/comments","statuses_url":"https://api.github.com/repos/m-lab-tools/telescope/statuses/dc5c813c6708bdba08a9eea4d68961e970a1761f","head":{"label":"collina:support_client_country","ref":"support_client_country","sha":"dc5c813c6708bdba08a9eea4d68961e970a1761f","user":{"login":"collina","id":582005,"avatar_url":"https://avatars.githubusercontent.com/u/582005?v=3","gravatar_id":"","url":"https://api.github.com/users/collina","html_url":"https://github.com/collina","followers_url":"https://api.github.com/users/collina/followers","following_url":"https://api.github.com/users/collina/following{/other_user}","gists_url":"https://api.github.com/users/collina/gists{/gist_id}","starred_url":"https://api.github.com/users/collina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collina/subscriptions","organizations_url":"https://api.github.com/users/collina/orgs","repos_url":"https://api.github.com/users/collina/repos","events_url":"https://api.github.com/users/collina/events{/privacy}","received_events_url":"https://api.github.com/users/collina/received_events","type":"User","site_admin":false},"repo":{"id":33387375,"name":"telescope","full_name":"collina/telescope","owner":{"login":"collina","id":582005,"avatar_url":"https://avatars.githubusercontent.com/u/582005?v=3","gravatar_id":"","url":"https://api.github.com/users/collina","html_url":"https://github.com/collina","followers_url":"https://api.github.com/users/collina/followers","following_url":"https://api.github.com/users/collina/following{/other_user}","gists_url":"https://api.github.com/users/collina/gists{/gist_id}","starred_url":"https://api.github.com/users/collina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collina/subscriptions","organizations_url":"https://api.github.com/users/collina/orgs","repos_url":"https://api.github.com/users/collina/repos","events_url":"https://api.github.com/users/collina/events{/privacy}","received_events_url":"https://api.github.com/users/collina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/collina/telescope","description":"Python framework designed to extract raw measurements from M-Lab to allow the easy production of research","fork":true,"url":"https://api.github.com/repos/collina/telescope","forks_url":"https://api.github.com/repos/collina/telescope/forks","keys_url":"https://api.github.com/repos/collina/telescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/collina/telescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/collina/telescope/teams","hooks_url":"https://api.github.com/repos/collina/telescope/hooks","issue_events_url":"https://api.github.com/repos/collina/telescope/issues/events{/number}","events_url":"https://api.github.com/repos/collina/telescope/events","assignees_url":"https://api.github.com/repos/collina/telescope/assignees{/user}","branches_url":"https://api.github.com/repos/collina/telescope/branches{/branch}","tags_url":"https://api.github.com/repos/collina/telescope/tags","blobs_url":"https://api.github.com/repos/collina/telescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/collina/telescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/collina/telescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/collina/telescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/collina/telescope/statuses/{sha}","languages_url":"https://api.github.com/repos/collina/telescope/languages","stargazers_url":"https://api.github.com/repos/collina/telescope/stargazers","contributors_url":"https://api.github.com/repos/collina/telescope/contributors","subscribers_url":"https://api.github.com/repos/collina/telescope/subscribers","subscription_url":"https://api.github.com/repos/collina/telescope/subscription","commits_url":"https://api.github.com/repos/collina/telescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/collina/telescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/collina/telescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/collina/telescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/collina/telescope/contents/{+path}","compare_url":"https://api.github.com/repos/collina/telescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/collina/telescope/merges","archive_url":"https://api.github.com/repos/collina/telescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/collina/telescope/downloads","issues_url":"https://api.github.com/repos/collina/telescope/issues{/number}","pulls_url":"https://api.github.com/repos/collina/telescope/pulls{/number}","milestones_url":"https://api.github.com/repos/collina/telescope/milestones{/number}","notifications_url":"https://api.github.com/repos/collina/telescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/collina/telescope/labels{/name}","releases_url":"https://api.github.com/repos/collina/telescope/releases{/id}","created_at":"2015-04-03T23:23:05Z","updated_at":"2015-04-03T23:23:06Z","pushed_at":"2015-04-09T02:30:43Z","git_url":"git://github.com/collina/telescope.git","ssh_url":"git@github.com:collina/telescope.git","clone_url":"https://github.com/collina/telescope.git","svn_url":"https://github.com/collina/telescope","homepage":"http://measurementlab.net","size":3527,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"m-lab-tools:development","ref":"development","sha":"cdd99a45fbaccd640776c4d96ed194ba15a0e7e1","user":{"login":"m-lab-tools","id":4070910,"avatar_url":"https://avatars.githubusercontent.com/u/4070910?v=3","gravatar_id":"","url":"https://api.github.com/users/m-lab-tools","html_url":"https://github.com/m-lab-tools","followers_url":"https://api.github.com/users/m-lab-tools/followers","following_url":"https://api.github.com/users/m-lab-tools/following{/other_user}","gists_url":"https://api.github.com/users/m-lab-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/m-lab-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-lab-tools/subscriptions","organizations_url":"https://api.github.com/users/m-lab-tools/orgs","repos_url":"https://api.github.com/users/m-lab-tools/repos","events_url":"https://api.github.com/users/m-lab-tools/events{/privacy}","received_events_url":"https://api.github.com/users/m-lab-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":25479533,"name":"telescope","full_name":"m-lab-tools/telescope","owner":{"login":"m-lab-tools","id":4070910,"avatar_url":"https://avatars.githubusercontent.com/u/4070910?v=3","gravatar_id":"","url":"https://api.github.com/users/m-lab-tools","html_url":"https://github.com/m-lab-tools","followers_url":"https://api.github.com/users/m-lab-tools/followers","following_url":"https://api.github.com/users/m-lab-tools/following{/other_user}","gists_url":"https://api.github.com/users/m-lab-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/m-lab-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-lab-tools/subscriptions","organizations_url":"https://api.github.com/users/m-lab-tools/orgs","repos_url":"https://api.github.com/users/m-lab-tools/repos","events_url":"https://api.github.com/users/m-lab-tools/events{/privacy}","received_events_url":"https://api.github.com/users/m-lab-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m-lab-tools/telescope","description":"Python framework designed to extract raw measurements from M-Lab to allow the easy production of research","fork":false,"url":"https://api.github.com/repos/m-lab-tools/telescope","forks_url":"https://api.github.com/repos/m-lab-tools/telescope/forks","keys_url":"https://api.github.com/repos/m-lab-tools/telescope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-lab-tools/telescope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-lab-tools/telescope/teams","hooks_url":"https://api.github.com/repos/m-lab-tools/telescope/hooks","issue_events_url":"https://api.github.com/repos/m-lab-tools/telescope/issues/events{/number}","events_url":"https://api.github.com/repos/m-lab-tools/telescope/events","assignees_url":"https://api.github.com/repos/m-lab-tools/telescope/assignees{/user}","branches_url":"https://api.github.com/repos/m-lab-tools/telescope/branches{/branch}","tags_url":"https://api.github.com/repos/m-lab-tools/telescope/tags","blobs_url":"https://api.github.com/repos/m-lab-tools/telescope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-lab-tools/telescope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-lab-tools/telescope/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-lab-tools/telescope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-lab-tools/telescope/statuses/{sha}","languages_url":"https://api.github.com/repos/m-lab-tools/telescope/languages","stargazers_url":"https://api.github.com/repos/m-lab-tools/telescope/stargazers","contributors_url":"https://api.github.com/repos/m-lab-tools/telescope/contributors","subscribers_url":"https://api.github.com/repos/m-lab-tools/telescope/subscribers","subscription_url":"https://api.github.com/repos/m-lab-tools/telescope/subscription","commits_url":"https://api.github.com/repos/m-lab-tools/telescope/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-lab-tools/telescope/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-lab-tools/telescope/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-lab-tools/telescope/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-lab-tools/telescope/contents/{+path}","compare_url":"https://api.github.com/repos/m-lab-tools/telescope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-lab-tools/telescope/merges","archive_url":"https://api.github.com/repos/m-lab-tools/telescope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-lab-tools/telescope/downloads","issues_url":"https://api.github.com/repos/m-lab-tools/telescope/issues{/number}","pulls_url":"https://api.github.com/repos/m-lab-tools/telescope/pulls{/number}","milestones_url":"https://api.github.com/repos/m-lab-tools/telescope/milestones{/number}","notifications_url":"https://api.github.com/repos/m-lab-tools/telescope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-lab-tools/telescope/labels{/name}","releases_url":"https://api.github.com/repos/m-lab-tools/telescope/releases{/id}","created_at":"2014-10-20T18:09:08Z","updated_at":"2015-04-03T14:56:39Z","pushed_at":"2015-04-09T02:30:43Z","git_url":"git://github.com/m-lab-tools/telescope.git","ssh_url":"git@github.com:m-lab-tools/telescope.git","clone_url":"https://github.com/m-lab-tools/telescope.git","svn_url":"https://github.com/m-lab-tools/telescope","homepage":"http://measurementlab.net","size":4072,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45"},"html":{"href":"https://github.com/m-lab-tools/telescope/pull/45"},"issue":{"href":"https://api.github.com/repos/m-lab-tools/telescope/issues/45"},"comments":{"href":"https://api.github.com/repos/m-lab-tools/telescope/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m-lab-tools/telescope/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/m-lab-tools/telescope/statuses/dc5c813c6708bdba08a9eea4d68961e970a1761f"}}}}