{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/35524889","id":35524889,"diff_hunk":"@@ -119,12 +123,12 @@\n     @Override\n     public boolean start() {\n         if (isSAMLPluginEnabled()) {\n-            setup();\n             s_logger.info(\"SAML auth plugin loaded\");\n+            return setup();\n         } else {","path":"plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java","position":18,"original_position":18,"commit_id":"db8de3221797047ac070a61b167b5430a3653b7e","original_commit_id":"db8de3221797047ac070a61b167b5430a3653b7e","user":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"body":"@bhaisaab I feel we can go with the if-else style because it anyhow is doing the same thing plus it give better code readability and logging. Your take?  ","created_at":"2015-07-27T11:01:06Z","updated_at":"2015-07-27T11:01:06Z","html_url":"https://github.com/apache/cloudstack/pull/618#discussion_r35524889","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/35524889"},"html":{"href":"https://github.com/apache/cloudstack/pull/618#discussion_r35524889"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/618","id":40635396,"html_url":"https://github.com/apache/cloudstack/pull/618","diff_url":"https://github.com/apache/cloudstack/pull/618.diff","patch_url":"https://github.com/apache/cloudstack/pull/618.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/618","number":618,"state":"open","locked":false,"title":"Dereference NULL return value","user":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"body":"No check on the null value of metadatafile. If null, the following operations failed. Added null check for the metadatafile. ","created_at":"2015-07-23T04:05:42Z","updated_at":"2015-07-27T11:01:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6283413174804d36a4588943dd13bc1cbd361875","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/618/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/618/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/618/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/db8de3221797047ac070a61b167b5430a3653b7e","head":{"label":"kansal:master","ref":"master","sha":"db8de3221797047ac070a61b167b5430a3653b7e","user":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"repo":{"id":39490442,"name":"cloudstack","full_name":"kansal/cloudstack","owner":{"login":"kansal","id":4276209,"avatar_url":"https://avatars.githubusercontent.com/u/4276209?v=3","gravatar_id":"","url":"https://api.github.com/users/kansal","html_url":"https://github.com/kansal","followers_url":"https://api.github.com/users/kansal/followers","following_url":"https://api.github.com/users/kansal/following{/other_user}","gists_url":"https://api.github.com/users/kansal/gists{/gist_id}","starred_url":"https://api.github.com/users/kansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansal/subscriptions","organizations_url":"https://api.github.com/users/kansal/orgs","repos_url":"https://api.github.com/users/kansal/repos","events_url":"https://api.github.com/users/kansal/events{/privacy}","received_events_url":"https://api.github.com/users/kansal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kansal/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/kansal/cloudstack","forks_url":"https://api.github.com/repos/kansal/cloudstack/forks","keys_url":"https://api.github.com/repos/kansal/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kansal/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kansal/cloudstack/teams","hooks_url":"https://api.github.com/repos/kansal/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/kansal/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/kansal/cloudstack/events","assignees_url":"https://api.github.com/repos/kansal/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/kansal/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/kansal/cloudstack/tags","blobs_url":"https://api.github.com/repos/kansal/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kansal/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kansal/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kansal/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kansal/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/kansal/cloudstack/languages","stargazers_url":"https://api.github.com/repos/kansal/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/kansal/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/kansal/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/kansal/cloudstack/subscription","commits_url":"https://api.github.com/repos/kansal/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kansal/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kansal/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kansal/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/kansal/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/kansal/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kansal/cloudstack/merges","archive_url":"https://api.github.com/repos/kansal/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kansal/cloudstack/downloads","issues_url":"https://api.github.com/repos/kansal/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/kansal/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/kansal/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/kansal/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kansal/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/kansal/cloudstack/releases{/id}","created_at":"2015-07-22T06:50:43Z","updated_at":"2015-07-22T06:51:05Z","pushed_at":"2015-07-27T08:31:38Z","git_url":"git://github.com/kansal/cloudstack.git","ssh_url":"git@github.com:kansal/cloudstack.git","clone_url":"https://github.com/kansal/cloudstack.git","svn_url":"https://github.com/kansal/cloudstack","homepage":null,"size":488992,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8875d7ae15e05cc2c9110e98354520011fc32d08","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-07-22T09:42:52Z","pushed_at":"2015-07-27T10:46:06Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":751323,"stargazers_count":266,"watchers_count":266,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":332,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":25,"forks":332,"open_issues":25,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/618"},"html":{"href":"https://github.com/apache/cloudstack/pull/618"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/618"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/db8de3221797047ac070a61b167b5430a3653b7e"}}}}