{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3","id":40968278,"html_url":"https://github.com/Sovietaced/edmunds/pull/3","diff_url":"https://github.com/Sovietaced/edmunds/pull/3.diff","patch_url":"https://github.com/Sovietaced/edmunds/pull/3.patch","issue_url":"https://api.github.com/repos/Sovietaced/edmunds/issues/3","number":3,"state":"open","locked":false,"title":"Full decoding now pulls more data","user":{"login":"fabrouy","id":5365733,"avatar_url":"https://avatars.githubusercontent.com/u/5365733?v=3","gravatar_id":"","url":"https://api.github.com/users/fabrouy","html_url":"https://github.com/fabrouy","followers_url":"https://api.github.com/users/fabrouy/followers","following_url":"https://api.github.com/users/fabrouy/following{/other_user}","gists_url":"https://api.github.com/users/fabrouy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabrouy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabrouy/subscriptions","organizations_url":"https://api.github.com/users/fabrouy/orgs","repos_url":"https://api.github.com/users/fabrouy/repos","events_url":"https://api.github.com/users/fabrouy/events{/privacy}","received_events_url":"https://api.github.com/users/fabrouy/received_events","type":"User","site_admin":false},"body":"Hey Jason,\r\n\r\nI wrote a couple lines. My idea was to return more data when you fully decode a vin number.\r\n\r\n- I created a transmission and drivetrain class.\r\n- I updated engine class with more attributes.\r\n- I fixed how colors where pulled (it was only pulling first two array positions) and made a couple changes regarding how the object gets constructed. I wanted to make it easy to access interior and exterior colors.\r\n- Had a similar approach for options. \r\n- I commented out the AS dependency (could not make it work with it, is it necessary?)\r\n- I updated the exception class, I think keys where wrong.\r\n- Updated sanitization. It failed for me when tried to basic decode because some of the params (that are passed to the request object when full decoding) where not initialized.\r\n\r\nTests for this are missing, but check it out, let me know what you think.\r\n\r\nRegards,\r\n\r\n","created_at":"2015-07-28T01:48:39Z","updated_at":"2015-07-28T01:48:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Sovietaced/edmunds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sovietaced/edmunds/issues/3/comments","statuses_url":"https://api.github.com/repos/Sovietaced/edmunds/statuses/88eaa8e6add804cbe95e56b6dbc43430a69b155f","head":{"label":"fabrouy:master","ref":"master","sha":"88eaa8e6add804cbe95e56b6dbc43430a69b155f","user":{"login":"fabrouy","id":5365733,"avatar_url":"https://avatars.githubusercontent.com/u/5365733?v=3","gravatar_id":"","url":"https://api.github.com/users/fabrouy","html_url":"https://github.com/fabrouy","followers_url":"https://api.github.com/users/fabrouy/followers","following_url":"https://api.github.com/users/fabrouy/following{/other_user}","gists_url":"https://api.github.com/users/fabrouy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabrouy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabrouy/subscriptions","organizations_url":"https://api.github.com/users/fabrouy/orgs","repos_url":"https://api.github.com/users/fabrouy/repos","events_url":"https://api.github.com/users/fabrouy/events{/privacy}","received_events_url":"https://api.github.com/users/fabrouy/received_events","type":"User","site_admin":false},"repo":{"id":39353323,"name":"edmunds","full_name":"fabrouy/edmunds","owner":{"login":"fabrouy","id":5365733,"avatar_url":"https://avatars.githubusercontent.com/u/5365733?v=3","gravatar_id":"","url":"https://api.github.com/users/fabrouy","html_url":"https://github.com/fabrouy","followers_url":"https://api.github.com/users/fabrouy/followers","following_url":"https://api.github.com/users/fabrouy/following{/other_user}","gists_url":"https://api.github.com/users/fabrouy/gists{/gist_id}","starred_url":"https://api.github.com/users/fabrouy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabrouy/subscriptions","organizations_url":"https://api.github.com/users/fabrouy/orgs","repos_url":"https://api.github.com/users/fabrouy/repos","events_url":"https://api.github.com/users/fabrouy/events{/privacy}","received_events_url":"https://api.github.com/users/fabrouy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabrouy/edmunds","description":"Edmunds.com Ruby API Wrapper","fork":true,"url":"https://api.github.com/repos/fabrouy/edmunds","forks_url":"https://api.github.com/repos/fabrouy/edmunds/forks","keys_url":"https://api.github.com/repos/fabrouy/edmunds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabrouy/edmunds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabrouy/edmunds/teams","hooks_url":"https://api.github.com/repos/fabrouy/edmunds/hooks","issue_events_url":"https://api.github.com/repos/fabrouy/edmunds/issues/events{/number}","events_url":"https://api.github.com/repos/fabrouy/edmunds/events","assignees_url":"https://api.github.com/repos/fabrouy/edmunds/assignees{/user}","branches_url":"https://api.github.com/repos/fabrouy/edmunds/branches{/branch}","tags_url":"https://api.github.com/repos/fabrouy/edmunds/tags","blobs_url":"https://api.github.com/repos/fabrouy/edmunds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabrouy/edmunds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabrouy/edmunds/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabrouy/edmunds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabrouy/edmunds/statuses/{sha}","languages_url":"https://api.github.com/repos/fabrouy/edmunds/languages","stargazers_url":"https://api.github.com/repos/fabrouy/edmunds/stargazers","contributors_url":"https://api.github.com/repos/fabrouy/edmunds/contributors","subscribers_url":"https://api.github.com/repos/fabrouy/edmunds/subscribers","subscription_url":"https://api.github.com/repos/fabrouy/edmunds/subscription","commits_url":"https://api.github.com/repos/fabrouy/edmunds/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabrouy/edmunds/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabrouy/edmunds/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabrouy/edmunds/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabrouy/edmunds/contents/{+path}","compare_url":"https://api.github.com/repos/fabrouy/edmunds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabrouy/edmunds/merges","archive_url":"https://api.github.com/repos/fabrouy/edmunds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabrouy/edmunds/downloads","issues_url":"https://api.github.com/repos/fabrouy/edmunds/issues{/number}","pulls_url":"https://api.github.com/repos/fabrouy/edmunds/pulls{/number}","milestones_url":"https://api.github.com/repos/fabrouy/edmunds/milestones{/number}","notifications_url":"https://api.github.com/repos/fabrouy/edmunds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabrouy/edmunds/labels{/name}","releases_url":"https://api.github.com/repos/fabrouy/edmunds/releases{/id}","created_at":"2015-07-19T23:50:29Z","updated_at":"2015-07-19T23:50:29Z","pushed_at":"2015-07-28T00:41:51Z","git_url":"git://github.com/fabrouy/edmunds.git","ssh_url":"git@github.com:fabrouy/edmunds.git","clone_url":"https://github.com/fabrouy/edmunds.git","svn_url":"https://github.com/fabrouy/edmunds","homepage":"","size":424,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sovietaced:master","ref":"master","sha":"d7c6bf0c2ec2a92a7ca87ccb57c93e4f639dd0b0","user":{"login":"Sovietaced","id":1274471,"avatar_url":"https://avatars.githubusercontent.com/u/1274471?v=3","gravatar_id":"","url":"https://api.github.com/users/Sovietaced","html_url":"https://github.com/Sovietaced","followers_url":"https://api.github.com/users/Sovietaced/followers","following_url":"https://api.github.com/users/Sovietaced/following{/other_user}","gists_url":"https://api.github.com/users/Sovietaced/gists{/gist_id}","starred_url":"https://api.github.com/users/Sovietaced/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sovietaced/subscriptions","organizations_url":"https://api.github.com/users/Sovietaced/orgs","repos_url":"https://api.github.com/users/Sovietaced/repos","events_url":"https://api.github.com/users/Sovietaced/events{/privacy}","received_events_url":"https://api.github.com/users/Sovietaced/received_events","type":"User","site_admin":false},"repo":{"id":31517458,"name":"edmunds","full_name":"Sovietaced/edmunds","owner":{"login":"Sovietaced","id":1274471,"avatar_url":"https://avatars.githubusercontent.com/u/1274471?v=3","gravatar_id":"","url":"https://api.github.com/users/Sovietaced","html_url":"https://github.com/Sovietaced","followers_url":"https://api.github.com/users/Sovietaced/followers","following_url":"https://api.github.com/users/Sovietaced/following{/other_user}","gists_url":"https://api.github.com/users/Sovietaced/gists{/gist_id}","starred_url":"https://api.github.com/users/Sovietaced/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sovietaced/subscriptions","organizations_url":"https://api.github.com/users/Sovietaced/orgs","repos_url":"https://api.github.com/users/Sovietaced/repos","events_url":"https://api.github.com/users/Sovietaced/events{/privacy}","received_events_url":"https://api.github.com/users/Sovietaced/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sovietaced/edmunds","description":"Edmunds.com Ruby API Wrapper","fork":false,"url":"https://api.github.com/repos/Sovietaced/edmunds","forks_url":"https://api.github.com/repos/Sovietaced/edmunds/forks","keys_url":"https://api.github.com/repos/Sovietaced/edmunds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sovietaced/edmunds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sovietaced/edmunds/teams","hooks_url":"https://api.github.com/repos/Sovietaced/edmunds/hooks","issue_events_url":"https://api.github.com/repos/Sovietaced/edmunds/issues/events{/number}","events_url":"https://api.github.com/repos/Sovietaced/edmunds/events","assignees_url":"https://api.github.com/repos/Sovietaced/edmunds/assignees{/user}","branches_url":"https://api.github.com/repos/Sovietaced/edmunds/branches{/branch}","tags_url":"https://api.github.com/repos/Sovietaced/edmunds/tags","blobs_url":"https://api.github.com/repos/Sovietaced/edmunds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sovietaced/edmunds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sovietaced/edmunds/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sovietaced/edmunds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sovietaced/edmunds/statuses/{sha}","languages_url":"https://api.github.com/repos/Sovietaced/edmunds/languages","stargazers_url":"https://api.github.com/repos/Sovietaced/edmunds/stargazers","contributors_url":"https://api.github.com/repos/Sovietaced/edmunds/contributors","subscribers_url":"https://api.github.com/repos/Sovietaced/edmunds/subscribers","subscription_url":"https://api.github.com/repos/Sovietaced/edmunds/subscription","commits_url":"https://api.github.com/repos/Sovietaced/edmunds/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sovietaced/edmunds/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sovietaced/edmunds/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sovietaced/edmunds/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sovietaced/edmunds/contents/{+path}","compare_url":"https://api.github.com/repos/Sovietaced/edmunds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sovietaced/edmunds/merges","archive_url":"https://api.github.com/repos/Sovietaced/edmunds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sovietaced/edmunds/downloads","issues_url":"https://api.github.com/repos/Sovietaced/edmunds/issues{/number}","pulls_url":"https://api.github.com/repos/Sovietaced/edmunds/pulls{/number}","milestones_url":"https://api.github.com/repos/Sovietaced/edmunds/milestones{/number}","notifications_url":"https://api.github.com/repos/Sovietaced/edmunds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sovietaced/edmunds/labels{/name}","releases_url":"https://api.github.com/repos/Sovietaced/edmunds/releases{/id}","created_at":"2015-03-02T01:03:26Z","updated_at":"2015-04-06T18:07:47Z","pushed_at":"2015-04-06T18:07:47Z","git_url":"git://github.com/Sovietaced/edmunds.git","ssh_url":"git@github.com:Sovietaced/edmunds.git","clone_url":"https://github.com/Sovietaced/edmunds.git","svn_url":"https://github.com/Sovietaced/edmunds","homepage":"","size":424,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3"},"html":{"href":"https://github.com/Sovietaced/edmunds/pull/3"},"issue":{"href":"https://api.github.com/repos/Sovietaced/edmunds/issues/3"},"comments":{"href":"https://api.github.com/repos/Sovietaced/edmunds/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Sovietaced/edmunds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sovietaced/edmunds/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Sovietaced/edmunds/statuses/88eaa8e6add804cbe95e56b6dbc43430a69b155f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":140,"deletions":25,"changed_files":11}}