{"action":"created","comment":{"url":"https://api.github.com/repos/rheit/zdoom/pulls/comments/41093581","id":41093581,"diff_hunk":"@@ -236,4 +236,7 @@ DEFINE_SPECIAL(Ceiling_LowerToLowest, 253, 2, 2, 2)\n DEFINE_SPECIAL(Ceiling_LowerToFloor, 254, 2, 2, 2)\r\n DEFINE_SPECIAL(Ceiling_CrushRaiseAndStaySilA, 255, 4, 5, 5)\r\n \r\n+DEFINE_SPECIAL(Line_SetVisualPortal, 155, -1, -1, 3)\r\n+DEFINE_SPECIAL(Line_SetPortal, 156, -1, -1, 3)\r","path":"src/actionspecials.h","position":14,"original_position":14,"commit_id":"d0df4c1744a8b30c147e82b82e1f5a5f27cefc2d","original_commit_id":"d0df4c1744a8b30c147e82b82e1f5a5f27cefc2d","user":{"login":"Blzut3","id":4406100,"avatar_url":"https://avatars.githubusercontent.com/u/4406100?v=3","gravatar_id":"","url":"https://api.github.com/users/Blzut3","html_url":"https://github.com/Blzut3","followers_url":"https://api.github.com/users/Blzut3/followers","following_url":"https://api.github.com/users/Blzut3/following{/other_user}","gists_url":"https://api.github.com/users/Blzut3/gists{/gist_id}","starred_url":"https://api.github.com/users/Blzut3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blzut3/subscriptions","organizations_url":"https://api.github.com/users/Blzut3/orgs","repos_url":"https://api.github.com/users/Blzut3/repos","events_url":"https://api.github.com/users/Blzut3/events{/privacy}","received_events_url":"https://api.github.com/users/Blzut3/received_events","type":"User","site_admin":false},"body":"Please keep these in numerical order.  What do you mean by the comment \"// vavoom? interferes with Line_SetVisualPortal\"?","created_at":"2015-10-04T02:04:35Z","updated_at":"2015-10-04T02:04:35Z","html_url":"https://github.com/rheit/zdoom/pull/336#discussion_r41093581","pull_request_url":"https://api.github.com/repos/rheit/zdoom/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/comments/41093581"},"html":{"href":"https://github.com/rheit/zdoom/pull/336#discussion_r41093581"},"pull_request":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/rheit/zdoom/pulls/336","id":37099621,"html_url":"https://github.com/rheit/zdoom/pull/336","diff_url":"https://github.com/rheit/zdoom/pull/336.diff","patch_url":"https://github.com/rheit/zdoom/pull/336.patch","issue_url":"https://api.github.com/repos/rheit/zdoom/issues/336","number":336,"state":"open","locked":false,"title":"Portals2 visual","user":{"login":"jewalky","id":5638098,"avatar_url":"https://avatars.githubusercontent.com/u/5638098?v=3","gravatar_id":"","url":"https://api.github.com/users/jewalky","html_url":"https://github.com/jewalky","followers_url":"https://api.github.com/users/jewalky/followers","following_url":"https://api.github.com/users/jewalky/following{/other_user}","gists_url":"https://api.github.com/users/jewalky/gists{/gist_id}","starred_url":"https://api.github.com/users/jewalky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewalky/subscriptions","organizations_url":"https://api.github.com/users/jewalky/orgs","repos_url":"https://api.github.com/users/jewalky/repos","events_url":"https://api.github.com/users/jewalky/events{/privacy}","received_events_url":"https://api.github.com/users/jewalky/received_events","type":"User","site_admin":false},"body":"The latest VISUAL portal code. Means fully working line special 155. Line special 156 is available, but as of now behaves exactly like 155.\r\n\r\nFor other features, There's now a CVar r_portal_recursions that controls both mirror and portal recursions dynamically (only for horizontal portals for now, doesn't include plane portals), and r_highlight_portals CVar that helps debugging portal-related stuff on a level.\r\nPlus, on top of that, this code adds advanced clipping for both mirrors and wall portals in software mode, making it possible to put mirrors on arbitrary places without having to put empty space behind them.","created_at":"2015-06-07T01:25:51Z","updated_at":"2015-10-04T02:04:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e75795be3596011a2e69bbece6287e317a1cfb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rheit/zdoom/pulls/336/commits","review_comments_url":"https://api.github.com/repos/rheit/zdoom/pulls/336/comments","review_comment_url":"https://api.github.com/repos/rheit/zdoom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rheit/zdoom/issues/336/comments","statuses_url":"https://api.github.com/repos/rheit/zdoom/statuses/d0df4c1744a8b30c147e82b82e1f5a5f27cefc2d","head":{"label":"jewalky:portals2_visual","ref":"portals2_visual","sha":"d0df4c1744a8b30c147e82b82e1f5a5f27cefc2d","user":{"login":"jewalky","id":5638098,"avatar_url":"https://avatars.githubusercontent.com/u/5638098?v=3","gravatar_id":"","url":"https://api.github.com/users/jewalky","html_url":"https://github.com/jewalky","followers_url":"https://api.github.com/users/jewalky/followers","following_url":"https://api.github.com/users/jewalky/following{/other_user}","gists_url":"https://api.github.com/users/jewalky/gists{/gist_id}","starred_url":"https://api.github.com/users/jewalky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewalky/subscriptions","organizations_url":"https://api.github.com/users/jewalky/orgs","repos_url":"https://api.github.com/users/jewalky/repos","events_url":"https://api.github.com/users/jewalky/events{/privacy}","received_events_url":"https://api.github.com/users/jewalky/received_events","type":"User","site_admin":false},"repo":{"id":25505261,"name":"zdoom","full_name":"jewalky/zdoom","owner":{"login":"jewalky","id":5638098,"avatar_url":"https://avatars.githubusercontent.com/u/5638098?v=3","gravatar_id":"","url":"https://api.github.com/users/jewalky","html_url":"https://github.com/jewalky","followers_url":"https://api.github.com/users/jewalky/followers","following_url":"https://api.github.com/users/jewalky/following{/other_user}","gists_url":"https://api.github.com/users/jewalky/gists{/gist_id}","starred_url":"https://api.github.com/users/jewalky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jewalky/subscriptions","organizations_url":"https://api.github.com/users/jewalky/orgs","repos_url":"https://api.github.com/users/jewalky/repos","events_url":"https://api.github.com/users/jewalky/events{/privacy}","received_events_url":"https://api.github.com/users/jewalky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jewalky/zdoom","description":"ZDoom is an enhanced port of the official DOOM source code to Win32. As such, it not only works with (and requires) Windows 95/NT 4.0, but it also adds new features not found in the version published by id Software.","fork":true,"url":"https://api.github.com/repos/jewalky/zdoom","forks_url":"https://api.github.com/repos/jewalky/zdoom/forks","keys_url":"https://api.github.com/repos/jewalky/zdoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jewalky/zdoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jewalky/zdoom/teams","hooks_url":"https://api.github.com/repos/jewalky/zdoom/hooks","issue_events_url":"https://api.github.com/repos/jewalky/zdoom/issues/events{/number}","events_url":"https://api.github.com/repos/jewalky/zdoom/events","assignees_url":"https://api.github.com/repos/jewalky/zdoom/assignees{/user}","branches_url":"https://api.github.com/repos/jewalky/zdoom/branches{/branch}","tags_url":"https://api.github.com/repos/jewalky/zdoom/tags","blobs_url":"https://api.github.com/repos/jewalky/zdoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jewalky/zdoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jewalky/zdoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jewalky/zdoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jewalky/zdoom/statuses/{sha}","languages_url":"https://api.github.com/repos/jewalky/zdoom/languages","stargazers_url":"https://api.github.com/repos/jewalky/zdoom/stargazers","contributors_url":"https://api.github.com/repos/jewalky/zdoom/contributors","subscribers_url":"https://api.github.com/repos/jewalky/zdoom/subscribers","subscription_url":"https://api.github.com/repos/jewalky/zdoom/subscription","commits_url":"https://api.github.com/repos/jewalky/zdoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jewalky/zdoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jewalky/zdoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jewalky/zdoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/jewalky/zdoom/contents/{+path}","compare_url":"https://api.github.com/repos/jewalky/zdoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jewalky/zdoom/merges","archive_url":"https://api.github.com/repos/jewalky/zdoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jewalky/zdoom/downloads","issues_url":"https://api.github.com/repos/jewalky/zdoom/issues{/number}","pulls_url":"https://api.github.com/repos/jewalky/zdoom/pulls{/number}","milestones_url":"https://api.github.com/repos/jewalky/zdoom/milestones{/number}","notifications_url":"https://api.github.com/repos/jewalky/zdoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jewalky/zdoom/labels{/name}","releases_url":"https://api.github.com/repos/jewalky/zdoom/releases{/id}","created_at":"2014-10-21T06:04:24Z","updated_at":"2015-03-08T23:01:49Z","pushed_at":"2015-08-27T12:16:20Z","git_url":"git://github.com/jewalky/zdoom.git","ssh_url":"git@github.com:jewalky/zdoom.git","clone_url":"https://github.com/jewalky/zdoom.git","svn_url":"https://github.com/jewalky/zdoom","homepage":"http://zdoom.org","size":21512,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rheit:master","ref":"master","sha":"662345adb8f65506d341fc82f2c3c599ae9722b7","user":{"login":"rheit","id":4649210,"avatar_url":"https://avatars.githubusercontent.com/u/4649210?v=3","gravatar_id":"","url":"https://api.github.com/users/rheit","html_url":"https://github.com/rheit","followers_url":"https://api.github.com/users/rheit/followers","following_url":"https://api.github.com/users/rheit/following{/other_user}","gists_url":"https://api.github.com/users/rheit/gists{/gist_id}","starred_url":"https://api.github.com/users/rheit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rheit/subscriptions","organizations_url":"https://api.github.com/users/rheit/orgs","repos_url":"https://api.github.com/users/rheit/repos","events_url":"https://api.github.com/users/rheit/events{/privacy}","received_events_url":"https://api.github.com/users/rheit/received_events","type":"User","site_admin":false},"repo":{"id":10679421,"name":"zdoom","full_name":"rheit/zdoom","owner":{"login":"rheit","id":4649210,"avatar_url":"https://avatars.githubusercontent.com/u/4649210?v=3","gravatar_id":"","url":"https://api.github.com/users/rheit","html_url":"https://github.com/rheit","followers_url":"https://api.github.com/users/rheit/followers","following_url":"https://api.github.com/users/rheit/following{/other_user}","gists_url":"https://api.github.com/users/rheit/gists{/gist_id}","starred_url":"https://api.github.com/users/rheit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rheit/subscriptions","organizations_url":"https://api.github.com/users/rheit/orgs","repos_url":"https://api.github.com/users/rheit/repos","events_url":"https://api.github.com/users/rheit/events{/privacy}","received_events_url":"https://api.github.com/users/rheit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rheit/zdoom","description":"Unifying all Doom engine games and adding countless possibilities.","fork":false,"url":"https://api.github.com/repos/rheit/zdoom","forks_url":"https://api.github.com/repos/rheit/zdoom/forks","keys_url":"https://api.github.com/repos/rheit/zdoom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rheit/zdoom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rheit/zdoom/teams","hooks_url":"https://api.github.com/repos/rheit/zdoom/hooks","issue_events_url":"https://api.github.com/repos/rheit/zdoom/issues/events{/number}","events_url":"https://api.github.com/repos/rheit/zdoom/events","assignees_url":"https://api.github.com/repos/rheit/zdoom/assignees{/user}","branches_url":"https://api.github.com/repos/rheit/zdoom/branches{/branch}","tags_url":"https://api.github.com/repos/rheit/zdoom/tags","blobs_url":"https://api.github.com/repos/rheit/zdoom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rheit/zdoom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rheit/zdoom/git/refs{/sha}","trees_url":"https://api.github.com/repos/rheit/zdoom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rheit/zdoom/statuses/{sha}","languages_url":"https://api.github.com/repos/rheit/zdoom/languages","stargazers_url":"https://api.github.com/repos/rheit/zdoom/stargazers","contributors_url":"https://api.github.com/repos/rheit/zdoom/contributors","subscribers_url":"https://api.github.com/repos/rheit/zdoom/subscribers","subscription_url":"https://api.github.com/repos/rheit/zdoom/subscription","commits_url":"https://api.github.com/repos/rheit/zdoom/commits{/sha}","git_commits_url":"https://api.github.com/repos/rheit/zdoom/git/commits{/sha}","comments_url":"https://api.github.com/repos/rheit/zdoom/comments{/number}","issue_comment_url":"https://api.github.com/repos/rheit/zdoom/issues/comments{/number}","contents_url":"https://api.github.com/repos/rheit/zdoom/contents/{+path}","compare_url":"https://api.github.com/repos/rheit/zdoom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rheit/zdoom/merges","archive_url":"https://api.github.com/repos/rheit/zdoom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rheit/zdoom/downloads","issues_url":"https://api.github.com/repos/rheit/zdoom/issues{/number}","pulls_url":"https://api.github.com/repos/rheit/zdoom/pulls{/number}","milestones_url":"https://api.github.com/repos/rheit/zdoom/milestones{/number}","notifications_url":"https://api.github.com/repos/rheit/zdoom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rheit/zdoom/labels{/name}","releases_url":"https://api.github.com/repos/rheit/zdoom/releases{/id}","created_at":"2013-06-14T01:08:55Z","updated_at":"2015-09-30T19:38:57Z","pushed_at":"2015-10-03T22:29:15Z","git_url":"git://github.com/rheit/zdoom.git","ssh_url":"git@github.com:rheit/zdoom.git","clone_url":"https://github.com/rheit/zdoom.git","svn_url":"https://github.com/rheit/zdoom","homepage":"http://zdoom.org","size":29357,"stargazers_count":131,"watchers_count":131,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":17,"forks":101,"open_issues":17,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/336"},"html":{"href":"https://github.com/rheit/zdoom/pull/336"},"issue":{"href":"https://api.github.com/repos/rheit/zdoom/issues/336"},"comments":{"href":"https://api.github.com/repos/rheit/zdoom/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rheit/zdoom/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/rheit/zdoom/statuses/d0df4c1744a8b30c147e82b82e1f5a5f27cefc2d"}}}}