{"action":"created","comment":{"url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/comments/46097766","id":46097766,"diff_hunk":"@@ -400,23 +400,21 @@ Ext.define('DevCycleMobile.controller.Groups', {\n \t\tvar riderRecord = riderStore.first();\n \t\tvar thisRiderId = riderRecord.get(\"riderId\");\n \n-\n \t\tvar canCreateGroup = false;\n-\t\tif(groupName != '' && groupName.length <= NAME_MAX) {\n-\t\t\tif(groupCode == '') {\n-\t\t\t\t// generate random code \n+\t\tif(groupName !== '' && groupName.length <= NAME_MAX) {\n+\t\t\tif(groupCode === '') {\n+\t\t\t\t// generate random code\n \t\t\t\tgroupCode = Math.random().toString(36).slice(2).substring(0,3);\n \t\t\t\tExt.getCmp('create_group_code').setValue(groupCode.toUpperCase());\n \t\t\t\tcanCreateGroup = true;\n-\t\t\t}\n-\t\t\telse if(groupCode.length >= CODE_MIN && groupCode.length <= CODE_MAX) {\n+\t\t\t} else if((new RegExp(\"\\\\\\w{\"+CODE_MIN+\",\"+CODE_MAX+\"}$\")).test(groupCode)) {\n+                // A valid code was entered","path":"app/controller/Groups.js","position":18,"original_position":18,"commit_id":"2adc2a52f0c42d56ec2a1be55f5dc844d9739059","original_commit_id":"2adc2a52f0c42d56ec2a1be55f5dc844d9739059","user":{"login":"bbesmanoff","id":732753,"avatar_url":"https://avatars.githubusercontent.com/u/732753?v=3","gravatar_id":"","url":"https://api.github.com/users/bbesmanoff","html_url":"https://github.com/bbesmanoff","followers_url":"https://api.github.com/users/bbesmanoff/followers","following_url":"https://api.github.com/users/bbesmanoff/following{/other_user}","gists_url":"https://api.github.com/users/bbesmanoff/gists{/gist_id}","starred_url":"https://api.github.com/users/bbesmanoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbesmanoff/subscriptions","organizations_url":"https://api.github.com/users/bbesmanoff/orgs","repos_url":"https://api.github.com/users/bbesmanoff/repos","events_url":"https://api.github.com/users/bbesmanoff/events{/privacy}","received_events_url":"https://api.github.com/users/bbesmanoff/received_events","type":"User","site_admin":false},"body":"whitespace","created_at":"2015-11-29T20:47:50Z","updated_at":"2015-11-29T20:47:50Z","html_url":"https://github.com/TourTrak/devcycle-mobile-app/pull/20#discussion_r46097766","pull_request_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/comments/46097766"},"html":{"href":"https://github.com/TourTrak/devcycle-mobile-app/pull/20#discussion_r46097766"},"pull_request":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20","id":52047149,"html_url":"https://github.com/TourTrak/devcycle-mobile-app/pull/20","diff_url":"https://github.com/TourTrak/devcycle-mobile-app/pull/20.diff","patch_url":"https://github.com/TourTrak/devcycle-mobile-app/pull/20.patch","issue_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/20","number":20,"state":"open","locked":false,"title":"Group Code Validation","user":{"login":"cman131","id":1238910,"avatar_url":"https://avatars.githubusercontent.com/u/1238910?v=3","gravatar_id":"","url":"https://api.github.com/users/cman131","html_url":"https://github.com/cman131","followers_url":"https://api.github.com/users/cman131/followers","following_url":"https://api.github.com/users/cman131/following{/other_user}","gists_url":"https://api.github.com/users/cman131/gists{/gist_id}","starred_url":"https://api.github.com/users/cman131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cman131/subscriptions","organizations_url":"https://api.github.com/users/cman131/orgs","repos_url":"https://api.github.com/users/cman131/repos","events_url":"https://api.github.com/users/cman131/events{/privacy}","received_events_url":"https://api.github.com/users/cman131/received_events","type":"User","site_admin":false},"body":"Group code's with a space or other invalid character will result in an alert","created_at":"2015-11-28T19:50:31Z","updated_at":"2015-11-29T20:47:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26aad9d2717f22b800489c1261955c53c9be269c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20/commits","review_comments_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20/comments","review_comment_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/20/comments","statuses_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/statuses/2adc2a52f0c42d56ec2a1be55f5dc844d9739059","head":{"label":"cman131:staging","ref":"staging","sha":"2adc2a52f0c42d56ec2a1be55f5dc844d9739059","user":{"login":"cman131","id":1238910,"avatar_url":"https://avatars.githubusercontent.com/u/1238910?v=3","gravatar_id":"","url":"https://api.github.com/users/cman131","html_url":"https://github.com/cman131","followers_url":"https://api.github.com/users/cman131/followers","following_url":"https://api.github.com/users/cman131/following{/other_user}","gists_url":"https://api.github.com/users/cman131/gists{/gist_id}","starred_url":"https://api.github.com/users/cman131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cman131/subscriptions","organizations_url":"https://api.github.com/users/cman131/orgs","repos_url":"https://api.github.com/users/cman131/repos","events_url":"https://api.github.com/users/cman131/events{/privacy}","received_events_url":"https://api.github.com/users/cman131/received_events","type":"User","site_admin":false},"repo":{"id":41763278,"name":"devcycle-mobile-app","full_name":"cman131/devcycle-mobile-app","owner":{"login":"cman131","id":1238910,"avatar_url":"https://avatars.githubusercontent.com/u/1238910?v=3","gravatar_id":"","url":"https://api.github.com/users/cman131","html_url":"https://github.com/cman131","followers_url":"https://api.github.com/users/cman131/followers","following_url":"https://api.github.com/users/cman131/following{/other_user}","gists_url":"https://api.github.com/users/cman131/gists{/gist_id}","starred_url":"https://api.github.com/users/cman131/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cman131/subscriptions","organizations_url":"https://api.github.com/users/cman131/orgs","repos_url":"https://api.github.com/users/cman131/repos","events_url":"https://api.github.com/users/cman131/events{/privacy}","received_events_url":"https://api.github.com/users/cman131/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cman131/devcycle-mobile-app","description":"The hybrid cross platform mobile app build for the TD Five Boro Bike Tour. ","fork":true,"url":"https://api.github.com/repos/cman131/devcycle-mobile-app","forks_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/forks","keys_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/teams","hooks_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/hooks","issue_events_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/issues/events{/number}","events_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/events","assignees_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/assignees{/user}","branches_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/branches{/branch}","tags_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/tags","blobs_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/statuses/{sha}","languages_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/languages","stargazers_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/stargazers","contributors_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/contributors","subscribers_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/subscribers","subscription_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/subscription","commits_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/contents/{+path}","compare_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/merges","archive_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/downloads","issues_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/issues{/number}","pulls_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/pulls{/number}","milestones_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/milestones{/number}","notifications_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/labels{/name}","releases_url":"https://api.github.com/repos/cman131/devcycle-mobile-app/releases{/id}","created_at":"2015-09-01T21:04:28Z","updated_at":"2015-09-01T21:04:35Z","pushed_at":"2015-11-28T19:24:26Z","git_url":"git://github.com/cman131/devcycle-mobile-app.git","ssh_url":"git@github.com:cman131/devcycle-mobile-app.git","clone_url":"https://github.com/cman131/devcycle-mobile-app.git","svn_url":"https://github.com/cman131/devcycle-mobile-app","homepage":"http://www.se.rit.edu/~devcycle/","size":867316,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TourTrak:staging","ref":"staging","sha":"b5a33bd20ec80c713d60477ff08a7453c030230b","user":{"login":"TourTrak","id":14322364,"avatar_url":"https://avatars.githubusercontent.com/u/14322364?v=3","gravatar_id":"","url":"https://api.github.com/users/TourTrak","html_url":"https://github.com/TourTrak","followers_url":"https://api.github.com/users/TourTrak/followers","following_url":"https://api.github.com/users/TourTrak/following{/other_user}","gists_url":"https://api.github.com/users/TourTrak/gists{/gist_id}","starred_url":"https://api.github.com/users/TourTrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TourTrak/subscriptions","organizations_url":"https://api.github.com/users/TourTrak/orgs","repos_url":"https://api.github.com/users/TourTrak/repos","events_url":"https://api.github.com/users/TourTrak/events{/privacy}","received_events_url":"https://api.github.com/users/TourTrak/received_events","type":"Organization","site_admin":false},"repo":{"id":14897076,"name":"devcycle-mobile-app","full_name":"TourTrak/devcycle-mobile-app","owner":{"login":"TourTrak","id":14322364,"avatar_url":"https://avatars.githubusercontent.com/u/14322364?v=3","gravatar_id":"","url":"https://api.github.com/users/TourTrak","html_url":"https://github.com/TourTrak","followers_url":"https://api.github.com/users/TourTrak/followers","following_url":"https://api.github.com/users/TourTrak/following{/other_user}","gists_url":"https://api.github.com/users/TourTrak/gists{/gist_id}","starred_url":"https://api.github.com/users/TourTrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TourTrak/subscriptions","organizations_url":"https://api.github.com/users/TourTrak/orgs","repos_url":"https://api.github.com/users/TourTrak/repos","events_url":"https://api.github.com/users/TourTrak/events{/privacy}","received_events_url":"https://api.github.com/users/TourTrak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TourTrak/devcycle-mobile-app","description":"The hybrid cross platform mobile app build for the TD Five Boro Bike Tour. ","fork":false,"url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app","forks_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/forks","keys_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/teams","hooks_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/hooks","issue_events_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/events{/number}","events_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/events","assignees_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/assignees{/user}","branches_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/branches{/branch}","tags_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/tags","blobs_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/statuses/{sha}","languages_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/languages","stargazers_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/stargazers","contributors_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/contributors","subscribers_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/subscribers","subscription_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/subscription","commits_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/contents/{+path}","compare_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/merges","archive_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/downloads","issues_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues{/number}","pulls_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls{/number}","milestones_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/milestones{/number}","notifications_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/labels{/name}","releases_url":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/releases{/id}","created_at":"2013-12-03T15:09:34Z","updated_at":"2015-09-19T03:56:14Z","pushed_at":"2015-11-29T01:27:36Z","git_url":"git://github.com/TourTrak/devcycle-mobile-app.git","ssh_url":"git@github.com:TourTrak/devcycle-mobile-app.git","clone_url":"https://github.com/TourTrak/devcycle-mobile-app.git","svn_url":"https://github.com/TourTrak/devcycle-mobile-app","homepage":"http://www.se.rit.edu/~devcycle/","size":867326,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20"},"html":{"href":"https://github.com/TourTrak/devcycle-mobile-app/pull/20"},"issue":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/20"},"comments":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/TourTrak/devcycle-mobile-app/statuses/2adc2a52f0c42d56ec2a1be55f5dc844d9739059"}}}}