{"comment":{"url":"https://api.github.com/repos/zhekov/geany/comments/10204047","html_url":"https://github.com/zhekov/geany/commit/690cb922be902f023881d455ae0c0a87d1c62170#commitcomment-10204047","id":10204047,"user":{"login":"zhekov","id":1112714,"avatar_url":"https://avatars.githubusercontent.com/u/1112714?v=3","gravatar_id":"","url":"https://api.github.com/users/zhekov","html_url":"https://github.com/zhekov","followers_url":"https://api.github.com/users/zhekov/followers","following_url":"https://api.github.com/users/zhekov/following{/other_user}","gists_url":"https://api.github.com/users/zhekov/gists{/gist_id}","starred_url":"https://api.github.com/users/zhekov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhekov/subscriptions","organizations_url":"https://api.github.com/users/zhekov/orgs","repos_url":"https://api.github.com/users/zhekov/repos","events_url":"https://api.github.com/users/zhekov/events{/privacy}","received_events_url":"https://api.github.com/users/zhekov/received_events","type":"User","site_admin":false},"position":159,"line":774,"path":"src/build.c","commit_id":"690cb922be902f023881d455ae0c0a87d1c62170","created_at":"2015-03-15T18:18:26Z","updated_at":"2015-03-15T18:18:26Z","body":"To spawn a command line under Unix, we normally parse it g_shell_parse_argv(), be it inside or outside the spawning module, and that parsing also checks for errors. It is only because we execute this one command like with the shell, and thus we pass is in argv, that we *can* get away without checking it. However, being executed via sh, it should follow the shell syntax; and spawn_check_command under unix invokes g_shell_parse_argv(), which checks exactly for shell syntax. And of course, being a command line, cmd is checked under Windows.\r\n\r\nThat are my reasons. If you want, I'll remove the check, and unify the spawn_with_callbacks() for both OS, it's a small change."}}