{"action":"created","issue":{"url":"https://api.github.com/repos/hybridauth/hybridauth/issues/461","labels_url":"https://api.github.com/repos/hybridauth/hybridauth/issues/461/labels{/name}","comments_url":"https://api.github.com/repos/hybridauth/hybridauth/issues/461/comments","events_url":"https://api.github.com/repos/hybridauth/hybridauth/issues/461/events","html_url":"https://github.com/hybridauth/hybridauth/pull/461","id":72647217,"number":461,"title":"Apply some PSR-2 standards rules","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-02T13:38:08Z","updated_at":"2015-05-02T14:40:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hybridauth/hybridauth/pulls/461","html_url":"https://github.com/hybridauth/hybridauth/pull/461","diff_url":"https://github.com/hybridauth/hybridauth/pull/461.diff","patch_url":"https://github.com/hybridauth/hybridauth/pull/461.patch"},"body":"This PR applies most of the PSR-2 (and 1) standards.\r\n\r\nThis was made with the great [PHP Coding Standards Fixer](http://cs.sensiolabs.org/) tool.\r\n\r\nI put the list of applied fixers. You can see what was did here: http://cs.sensiolabs.org/#usage\r\n\r\nApplied fixers:\r\n\r\n * indentation\r\n * parenthesis\r\n * trailing_spaces\r\n * braces\r\n * eof_ending\r\n * function_call_space\r\n * function_declaration\r\n * lowercase_constants\r\n * lowercase_keywords\r\n * method_argument_space\r\n * visibility\r\n\r\nSymfony [code standards](http://symfony.com/doc/current/contributing/code/standards.html) could be also applied. This is not required but I recommend to use it. Tell me if you want it so I will update this PR (or make another one).\r\n\r\nI also updated `.editorconfig` file and added `fabpot/php-cs-fixer` as dev dependencies to make contributor using it.\r\n\r\nTwo another things could be done after this:\r\n\r\n * Subscribe to [Scrutinizer CI](https://scrutinizer-ci.com/) to get informed of code quality variations. See an example here: https://github.com/Soullivaneuh/IsoCodesValidator (badges)\r\n * Update `CONTRIBUTING.md` file to talk about the new style guide.\r\n\r\nThis PR is a **proposition** related to #34 and #459. I'm waiting your opinions and questions.\r\n\r\nYou can obviously not accept it but I think it would be a great improvement to get PSR-2 compliant onto this project, before 3.0 stable.\r\n\r\nBest regards"},"comment":{"url":"https://api.github.com/repos/hybridauth/hybridauth/issues/comments/98366513","html_url":"https://github.com/hybridauth/hybridauth/pull/461#issuecomment-98366513","issue_url":"https://api.github.com/repos/hybridauth/hybridauth/issues/461","id":98366513,"user":{"login":"miled","id":380139,"avatar_url":"https://avatars.githubusercontent.com/u/380139?v=3","gravatar_id":"","url":"https://api.github.com/users/miled","html_url":"https://github.com/miled","followers_url":"https://api.github.com/users/miled/followers","following_url":"https://api.github.com/users/miled/following{/other_user}","gists_url":"https://api.github.com/users/miled/gists{/gist_id}","starred_url":"https://api.github.com/users/miled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miled/subscriptions","organizations_url":"https://api.github.com/users/miled/orgs","repos_url":"https://api.github.com/users/miled/repos","events_url":"https://api.github.com/users/miled/events{/privacy}","received_events_url":"https://api.github.com/users/miled/received_events","type":"User","site_admin":false},"created_at":"2015-05-02T14:40:30Z","updated_at":"2015-05-02T14:40:30Z","body":"I wish to keep the current style. The reason why I didn't use PSR-2 is because it's a recommendation more than a standard, besides it does not bring any additional value.\r\n\r\nV3 will be PSR-1 and PSR-4 compliant, tho."}}