{"action":"created","comment":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/43372290","id":43372290,"diff_hunk":"@@ -364,6 +364,27 @@ public JSONObject changeLibraryLocation(HttpSession session, JSONObject json) {\n \n     return JSONUtils.SimpleJSONResponse(\"Note saved successfully\");\n   }\n+  \n+  public JSONObject changeLibraryIdBarcode(HttpSession session, JSONObject json) {\n+    Long libraryId = json.getLong(\"libraryId\");\n+    String idBarcode = json.getString(\"identificationBarcode\");\n+    \n+    try {\n+      if (!\"\".equals(idBarcode)) {","path":"spring/src/main/java/uk/ac/bbsrc/tgac/miso/spring/ajax/LibraryControllerHelperService.java","position":10,"original_position":10,"commit_id":"508c430595eefec715448030cb9dec3cb2a9461e","original_commit_id":"508c430595eefec715448030cb9dec3cb2a9461e","user":{"login":"frankie13","id":13831831,"avatar_url":"https://avatars.githubusercontent.com/u/13831831?v=3","gravatar_id":"","url":"https://api.github.com/users/frankie13","html_url":"https://github.com/frankie13","followers_url":"https://api.github.com/users/frankie13/followers","following_url":"https://api.github.com/users/frankie13/following{/other_user}","gists_url":"https://api.github.com/users/frankie13/gists{/gist_id}","starred_url":"https://api.github.com/users/frankie13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankie13/subscriptions","organizations_url":"https://api.github.com/users/frankie13/orgs","repos_url":"https://api.github.com/users/frankie13/repos","events_url":"https://api.github.com/users/frankie13/events{/privacy}","received_events_url":"https://api.github.com/users/frankie13/received_events","type":"User","site_admin":false},"body":"also just found:\r\n`miso.core.src.main.java.uk.ac.bbsrc.tgac.miso.core.util.LimsUtils.isStringEmptyOrNull(String s)`\r\n\r\nWhich seems like a very clear way of doing it - assuming we want null checking here.","created_at":"2015-10-29T11:06:22Z","updated_at":"2015-10-29T11:06:22Z","html_url":"https://github.com/TGAC/miso-lims/pull/17#discussion_r43372290","pull_request_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/43372290"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/17#discussion_r43372290"},"pull_request":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/17","id":48889803,"html_url":"https://github.com/TGAC/miso-lims/pull/17","diff_url":"https://github.com/TGAC/miso-lims/pull/17.diff","patch_url":"https://github.com/TGAC/miso-lims/pull/17.patch","issue_url":"https://api.github.com/repos/TGAC/miso-lims/issues/17","number":17,"state":"open","locked":false,"title":"Allows for manual entry of identificationBarcodes (for manufaturer-barcoded tubes, boxes, plates, etc.) or auto-generation of identificationBarcodes.","user":{"login":"callunity","id":8324996,"avatar_url":"https://avatars.githubusercontent.com/u/8324996?v=3","gravatar_id":"","url":"https://api.github.com/users/callunity","html_url":"https://github.com/callunity","followers_url":"https://api.github.com/users/callunity/followers","following_url":"https://api.github.com/users/callunity/following{/other_user}","gists_url":"https://api.github.com/users/callunity/gists{/gist_id}","starred_url":"https://api.github.com/users/callunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callunity/subscriptions","organizations_url":"https://api.github.com/users/callunity/orgs","repos_url":"https://api.github.com/users/callunity/repos","events_url":"https://api.github.com/users/callunity/events{/privacy}","received_events_url":"https://api.github.com/users/callunity/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-27T15:49:37Z","updated_at":"2015-10-29T11:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cc7935d8474034cbb6855e8446abbc44d866ceb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/17/commits","review_comments_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/17/comments","review_comment_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/issues/17/comments","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/508c430595eefec715448030cb9dec3cb2a9461e","head":{"label":"oicr-gsi:manual-entry-IDbarcodes","ref":"manual-entry-IDbarcodes","sha":"508c430595eefec715448030cb9dec3cb2a9461e","user":{"login":"oicr-gsi","id":4701585,"avatar_url":"https://avatars.githubusercontent.com/u/4701585?v=3","gravatar_id":"","url":"https://api.github.com/users/oicr-gsi","html_url":"https://github.com/oicr-gsi","followers_url":"https://api.github.com/users/oicr-gsi/followers","following_url":"https://api.github.com/users/oicr-gsi/following{/other_user}","gists_url":"https://api.github.com/users/oicr-gsi/gists{/gist_id}","starred_url":"https://api.github.com/users/oicr-gsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oicr-gsi/subscriptions","organizations_url":"https://api.github.com/users/oicr-gsi/orgs","repos_url":"https://api.github.com/users/oicr-gsi/repos","events_url":"https://api.github.com/users/oicr-gsi/events{/privacy}","received_events_url":"https://api.github.com/users/oicr-gsi/received_events","type":"Organization","site_admin":false},"repo":{"id":37474147,"name":"miso-lims","full_name":"oicr-gsi/miso-lims","owner":{"login":"oicr-gsi","id":4701585,"avatar_url":"https://avatars.githubusercontent.com/u/4701585?v=3","gravatar_id":"","url":"https://api.github.com/users/oicr-gsi","html_url":"https://github.com/oicr-gsi","followers_url":"https://api.github.com/users/oicr-gsi/followers","following_url":"https://api.github.com/users/oicr-gsi/following{/other_user}","gists_url":"https://api.github.com/users/oicr-gsi/gists{/gist_id}","starred_url":"https://api.github.com/users/oicr-gsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oicr-gsi/subscriptions","organizations_url":"https://api.github.com/users/oicr-gsi/orgs","repos_url":"https://api.github.com/users/oicr-gsi/repos","events_url":"https://api.github.com/users/oicr-gsi/events{/privacy}","received_events_url":"https://api.github.com/users/oicr-gsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oicr-gsi/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":true,"url":"https://api.github.com/repos/oicr-gsi/miso-lims","forks_url":"https://api.github.com/repos/oicr-gsi/miso-lims/forks","keys_url":"https://api.github.com/repos/oicr-gsi/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oicr-gsi/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oicr-gsi/miso-lims/teams","hooks_url":"https://api.github.com/repos/oicr-gsi/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/oicr-gsi/miso-lims/events","assignees_url":"https://api.github.com/repos/oicr-gsi/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/oicr-gsi/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/oicr-gsi/miso-lims/tags","blobs_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oicr-gsi/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/oicr-gsi/miso-lims/languages","stargazers_url":"https://api.github.com/repos/oicr-gsi/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/oicr-gsi/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/oicr-gsi/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/oicr-gsi/miso-lims/subscription","commits_url":"https://api.github.com/repos/oicr-gsi/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/oicr-gsi/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/oicr-gsi/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/oicr-gsi/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/oicr-gsi/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oicr-gsi/miso-lims/merges","archive_url":"https://api.github.com/repos/oicr-gsi/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oicr-gsi/miso-lims/downloads","issues_url":"https://api.github.com/repos/oicr-gsi/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/oicr-gsi/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/oicr-gsi/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/oicr-gsi/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oicr-gsi/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/oicr-gsi/miso-lims/releases{/id}","created_at":"2015-06-15T15:35:57Z","updated_at":"2015-09-10T20:51:58Z","pushed_at":"2015-10-28T15:31:08Z","git_url":"git://github.com/oicr-gsi/miso-lims.git","ssh_url":"git@github.com:oicr-gsi/miso-lims.git","clone_url":"https://github.com/oicr-gsi/miso-lims.git","svn_url":"https://github.com/oicr-gsi/miso-lims","homepage":null,"size":74743,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":1,"default_branch":"oicr"}},"base":{"label":"TGAC:develop","ref":"develop","sha":"97558c5733430f67f0396d7ccf07f13f3cfb6aa5","user":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars.githubusercontent.com/u/1872319?v=3","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"repo":{"id":4726428,"name":"miso-lims","full_name":"TGAC/miso-lims","owner":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars.githubusercontent.com/u/1872319?v=3","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TGAC/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":false,"url":"https://api.github.com/repos/TGAC/miso-lims","forks_url":"https://api.github.com/repos/TGAC/miso-lims/forks","keys_url":"https://api.github.com/repos/TGAC/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TGAC/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TGAC/miso-lims/teams","hooks_url":"https://api.github.com/repos/TGAC/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/TGAC/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/TGAC/miso-lims/events","assignees_url":"https://api.github.com/repos/TGAC/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/TGAC/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/TGAC/miso-lims/tags","blobs_url":"https://api.github.com/repos/TGAC/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TGAC/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TGAC/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/TGAC/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/TGAC/miso-lims/languages","stargazers_url":"https://api.github.com/repos/TGAC/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/TGAC/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/TGAC/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/TGAC/miso-lims/subscription","commits_url":"https://api.github.com/repos/TGAC/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/TGAC/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/TGAC/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/TGAC/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/TGAC/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TGAC/miso-lims/merges","archive_url":"https://api.github.com/repos/TGAC/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TGAC/miso-lims/downloads","issues_url":"https://api.github.com/repos/TGAC/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/TGAC/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/TGAC/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/TGAC/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TGAC/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/TGAC/miso-lims/releases{/id}","created_at":"2012-06-20T13:17:28Z","updated_at":"2015-10-08T16:57:01Z","pushed_at":"2015-10-28T15:31:09Z","git_url":"git://github.com/TGAC/miso-lims.git","ssh_url":"git@github.com:TGAC/miso-lims.git","clone_url":"https://github.com/TGAC/miso-lims.git","svn_url":"https://github.com/TGAC/miso-lims","homepage":null,"size":77185,"stargazers_count":29,"watchers_count":29,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":4,"forks":15,"open_issues":4,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/17"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/17"},"issue":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/17"},"comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/TGAC/miso-lims/statuses/508c430595eefec715448030cb9dec3cb2a9461e"}}}}