{"action":"closed","number":3088,"pull_request":{"url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088","id":38840496,"html_url":"https://github.com/tomchristie/django-rest-framework/pull/3088","diff_url":"https://github.com/tomchristie/django-rest-framework/pull/3088.diff","patch_url":"https://github.com/tomchristie/django-rest-framework/pull/3088.patch","issue_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/3088","number":3088,"state":"closed","locked":false,"title":"Handle AttributeError as well (when the imported module exists but the specified function/class does not).","user":{"login":"atleta","id":6267837,"avatar_url":"https://avatars.githubusercontent.com/u/6267837?v=3","gravatar_id":"","url":"https://api.github.com/users/atleta","html_url":"https://github.com/atleta","followers_url":"https://api.github.com/users/atleta/followers","following_url":"https://api.github.com/users/atleta/following{/other_user}","gists_url":"https://api.github.com/users/atleta/gists{/gist_id}","starred_url":"https://api.github.com/users/atleta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atleta/subscriptions","organizations_url":"https://api.github.com/users/atleta/orgs","repos_url":"https://api.github.com/users/atleta/repos","events_url":"https://api.github.com/users/atleta/events{/privacy}","received_events_url":"https://api.github.com/users/atleta/received_events","type":"User","site_admin":false},"body":"This is a minor fix to show the meaningful ImportError (referencing the setting name and the value) when the specified module does exist but the function or class does not. (Which raises an AttributeError instead of an ImportError, and which the original code allowed to propagate.)","created_at":"2015-06-30T03:56:55Z","updated_at":"2015-07-02T08:52:53Z","closed_at":"2015-07-02T08:52:53Z","merged_at":"2015-07-02T08:52:53Z","merge_commit_sha":"663f7b70c396c80cd14f15156688d034f265bd36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088/commits","review_comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088/comments","review_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/3088/comments","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/f0bced64134b10c2cafbb206c04fe0fa774d205d","head":{"label":"atleta:master","ref":"master","sha":"f0bced64134b10c2cafbb206c04fe0fa774d205d","user":{"login":"atleta","id":6267837,"avatar_url":"https://avatars.githubusercontent.com/u/6267837?v=3","gravatar_id":"","url":"https://api.github.com/users/atleta","html_url":"https://github.com/atleta","followers_url":"https://api.github.com/users/atleta/followers","following_url":"https://api.github.com/users/atleta/following{/other_user}","gists_url":"https://api.github.com/users/atleta/gists{/gist_id}","starred_url":"https://api.github.com/users/atleta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atleta/subscriptions","organizations_url":"https://api.github.com/users/atleta/orgs","repos_url":"https://api.github.com/users/atleta/repos","events_url":"https://api.github.com/users/atleta/events{/privacy}","received_events_url":"https://api.github.com/users/atleta/received_events","type":"User","site_admin":false},"repo":{"id":38286307,"name":"django-rest-framework","full_name":"atleta/django-rest-framework","owner":{"login":"atleta","id":6267837,"avatar_url":"https://avatars.githubusercontent.com/u/6267837?v=3","gravatar_id":"","url":"https://api.github.com/users/atleta","html_url":"https://github.com/atleta","followers_url":"https://api.github.com/users/atleta/followers","following_url":"https://api.github.com/users/atleta/following{/other_user}","gists_url":"https://api.github.com/users/atleta/gists{/gist_id}","starred_url":"https://api.github.com/users/atleta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atleta/subscriptions","organizations_url":"https://api.github.com/users/atleta/orgs","repos_url":"https://api.github.com/users/atleta/repos","events_url":"https://api.github.com/users/atleta/events{/privacy}","received_events_url":"https://api.github.com/users/atleta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atleta/django-rest-framework","description":"Web APIs for Django.","fork":true,"url":"https://api.github.com/repos/atleta/django-rest-framework","forks_url":"https://api.github.com/repos/atleta/django-rest-framework/forks","keys_url":"https://api.github.com/repos/atleta/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atleta/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atleta/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/atleta/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/atleta/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/atleta/django-rest-framework/events","assignees_url":"https://api.github.com/repos/atleta/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/atleta/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/atleta/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/atleta/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atleta/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atleta/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/atleta/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atleta/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/atleta/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/atleta/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/atleta/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/atleta/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/atleta/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/atleta/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/atleta/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/atleta/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/atleta/django-rest-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/atleta/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/atleta/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atleta/django-rest-framework/merges","archive_url":"https://api.github.com/repos/atleta/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atleta/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/atleta/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/atleta/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/atleta/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/atleta/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atleta/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/atleta/django-rest-framework/releases{/id}","created_at":"2015-06-30T03:46:51Z","updated_at":"2015-06-30T03:46:53Z","pushed_at":"2015-06-30T03:52:17Z","git_url":"git://github.com/atleta/django-rest-framework.git","ssh_url":"git@github.com:atleta/django-rest-framework.git","clone_url":"https://github.com/atleta/django-rest-framework.git","svn_url":"https://github.com/atleta/django-rest-framework","homepage":"www.django-rest-framework.org","size":18637,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tomchristie:master","ref":"master","sha":"5833a1847f5ffddd6b61fe38b17d054c03f58e75","user":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"repo":{"id":1431547,"name":"django-rest-framework","full_name":"tomchristie/django-rest-framework","owner":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomchristie/django-rest-framework","description":"Web APIs for Django.","fork":false,"url":"https://api.github.com/repos/tomchristie/django-rest-framework","forks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/forks","keys_url":"https://api.github.com/repos/tomchristie/django-rest-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomchristie/django-rest-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomchristie/django-rest-framework/teams","hooks_url":"https://api.github.com/repos/tomchristie/django-rest-framework/hooks","issue_events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/events{/number}","events_url":"https://api.github.com/repos/tomchristie/django-rest-framework/events","assignees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/assignees{/user}","branches_url":"https://api.github.com/repos/tomchristie/django-rest-framework/branches{/branch}","tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/tags","blobs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tomchristie/django-rest-framework/languages","stargazers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/stargazers","contributors_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contributors","subscribers_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscribers","subscription_url":"https://api.github.com/repos/tomchristie/django-rest-framework/subscription","commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomchristie/django-rest-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomchristie/django-rest-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomchristie/django-rest-framework/contents/{+path}","compare_url":"https://api.github.com/repos/tomchristie/django-rest-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomchristie/django-rest-framework/merges","archive_url":"https://api.github.com/repos/tomchristie/django-rest-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomchristie/django-rest-framework/downloads","issues_url":"https://api.github.com/repos/tomchristie/django-rest-framework/issues{/number}","pulls_url":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tomchristie/django-rest-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tomchristie/django-rest-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomchristie/django-rest-framework/labels{/name}","releases_url":"https://api.github.com/repos/tomchristie/django-rest-framework/releases{/id}","created_at":"2011-03-02T17:13:56Z","updated_at":"2015-07-01T20:14:13Z","pushed_at":"2015-07-02T08:52:53Z","git_url":"git://github.com/tomchristie/django-rest-framework.git","ssh_url":"git@github.com:tomchristie/django-rest-framework.git","clone_url":"https://github.com/tomchristie/django-rest-framework.git","svn_url":"https://github.com/tomchristie/django-rest-framework","homepage":"www.django-rest-framework.org","size":33646,"stargazers_count":4241,"watchers_count":4241,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1355,"mirror_url":null,"open_issues_count":120,"forks":1355,"open_issues":120,"watchers":4241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088"},"html":{"href":"https://github.com/tomchristie/django-rest-framework/pull/3088"},"issue":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/3088"},"comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/issues/3088/comments"},"review_comments":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088/comments"},"review_comment":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/pulls/3088/commits"},"statuses":{"href":"https://api.github.com/repos/tomchristie/django-rest-framework/statuses/f0bced64134b10c2cafbb206c04fe0fa774d205d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomchristie","id":647359,"avatar_url":"https://avatars.githubusercontent.com/u/647359?v=3","gravatar_id":"","url":"https://api.github.com/users/tomchristie","html_url":"https://github.com/tomchristie","followers_url":"https://api.github.com/users/tomchristie/followers","following_url":"https://api.github.com/users/tomchristie/following{/other_user}","gists_url":"https://api.github.com/users/tomchristie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomchristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomchristie/subscriptions","organizations_url":"https://api.github.com/users/tomchristie/orgs","repos_url":"https://api.github.com/users/tomchristie/repos","events_url":"https://api.github.com/users/tomchristie/events{/privacy}","received_events_url":"https://api.github.com/users/tomchristie/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}