{"action":"closed","number":483,"pull_request":{"url":"https://api.github.com/repos/twall/jna/pulls/483","id":41760406,"html_url":"https://github.com/twall/jna/pull/483","diff_url":"https://github.com/twall/jna/pull/483.diff","patch_url":"https://github.com/twall/jna/pull/483.patch","issue_url":"https://api.github.com/repos/twall/jna/issues/483","number":483,"state":"closed","locked":false,"title":"Found and fixed duplicate method definitions for the same API","user":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"body":"- Added duplicate method detection tests for Kernel32, Advapi32 and User32 as they contain most of the low-level API(s) (welcome to add more...) - this is how the issues were discovered and fixed\r\n\r\nKernel32:\r\n- Removed duplicate GetDiskFreeSpaceEx - preserved the one with LARGE_INTEGER definition as it matches the API definition\r\n- Added GetDiskFreeSpace API\r\n- Removed duplicate ReadFile - left and modified the remaining one to use _byte[]_ argument in order to match the WriteFile definition\r\n- Removed duplicate FormatMessage - kept the one with _PointerByReference_ since it is the definition that closest matches the API (+ it is the only one used in the current code)\r\n\r\nUser32:\r\n- Removed duplicate SetWindowLong - kept the one with the _int_(s) as it matches the API definition\r\n- Removed duplicate CallNextHookEx - kept the one with LPARAM as  it matches the API definition\r\n\r\nPlease note that the \"changes\" seem more than that but this is misleading - my IDE (Eclipse) is set up so that on \"Save\" it trims trailing white spaces in the source lines, replaces TAB(s) with 4 spaces, removes unused imports and adds missing _@Override_(s). I think this is recommended behavior, but do let me know if you disagree and I will configure it otherwise.","created_at":"2015-08-06T07:50:39Z","updated_at":"2015-08-10T13:11:56Z","closed_at":"2015-08-10T13:11:56Z","merged_at":"2015-08-10T13:11:56Z","merge_commit_sha":"c286772f6ea0366933aceaf99e3932e26ae78022","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twall/jna/pulls/483/commits","review_comments_url":"https://api.github.com/repos/twall/jna/pulls/483/comments","review_comment_url":"https://api.github.com/repos/twall/jna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twall/jna/issues/483/comments","statuses_url":"https://api.github.com/repos/twall/jna/statuses/70288cc6a08940c0a90aa72cfd8213116bdde305","head":{"label":"lgoldstein:duplicate-methods","ref":"duplicate-methods","sha":"70288cc6a08940c0a90aa72cfd8213116bdde305","user":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"repo":{"id":34726840,"name":"jna","full_name":"lgoldstein/jna","owner":{"login":"lgoldstein","id":1436205,"avatar_url":"https://avatars.githubusercontent.com/u/1436205?v=3","gravatar_id":"","url":"https://api.github.com/users/lgoldstein","html_url":"https://github.com/lgoldstein","followers_url":"https://api.github.com/users/lgoldstein/followers","following_url":"https://api.github.com/users/lgoldstein/following{/other_user}","gists_url":"https://api.github.com/users/lgoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/lgoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgoldstein/subscriptions","organizations_url":"https://api.github.com/users/lgoldstein/orgs","repos_url":"https://api.github.com/users/lgoldstein/repos","events_url":"https://api.github.com/users/lgoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/lgoldstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgoldstein/jna","description":"Java Native Access","fork":true,"url":"https://api.github.com/repos/lgoldstein/jna","forks_url":"https://api.github.com/repos/lgoldstein/jna/forks","keys_url":"https://api.github.com/repos/lgoldstein/jna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgoldstein/jna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgoldstein/jna/teams","hooks_url":"https://api.github.com/repos/lgoldstein/jna/hooks","issue_events_url":"https://api.github.com/repos/lgoldstein/jna/issues/events{/number}","events_url":"https://api.github.com/repos/lgoldstein/jna/events","assignees_url":"https://api.github.com/repos/lgoldstein/jna/assignees{/user}","branches_url":"https://api.github.com/repos/lgoldstein/jna/branches{/branch}","tags_url":"https://api.github.com/repos/lgoldstein/jna/tags","blobs_url":"https://api.github.com/repos/lgoldstein/jna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgoldstein/jna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgoldstein/jna/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgoldstein/jna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgoldstein/jna/statuses/{sha}","languages_url":"https://api.github.com/repos/lgoldstein/jna/languages","stargazers_url":"https://api.github.com/repos/lgoldstein/jna/stargazers","contributors_url":"https://api.github.com/repos/lgoldstein/jna/contributors","subscribers_url":"https://api.github.com/repos/lgoldstein/jna/subscribers","subscription_url":"https://api.github.com/repos/lgoldstein/jna/subscription","commits_url":"https://api.github.com/repos/lgoldstein/jna/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgoldstein/jna/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgoldstein/jna/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgoldstein/jna/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgoldstein/jna/contents/{+path}","compare_url":"https://api.github.com/repos/lgoldstein/jna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgoldstein/jna/merges","archive_url":"https://api.github.com/repos/lgoldstein/jna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgoldstein/jna/downloads","issues_url":"https://api.github.com/repos/lgoldstein/jna/issues{/number}","pulls_url":"https://api.github.com/repos/lgoldstein/jna/pulls{/number}","milestones_url":"https://api.github.com/repos/lgoldstein/jna/milestones{/number}","notifications_url":"https://api.github.com/repos/lgoldstein/jna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgoldstein/jna/labels{/name}","releases_url":"https://api.github.com/repos/lgoldstein/jna/releases{/id}","created_at":"2015-04-28T11:34:11Z","updated_at":"2015-04-28T11:34:14Z","pushed_at":"2015-08-10T05:05:05Z","git_url":"git://github.com/lgoldstein/jna.git","ssh_url":"git@github.com:lgoldstein/jna.git","clone_url":"https://github.com/lgoldstein/jna.git","svn_url":"https://github.com/lgoldstein/jna","homepage":"","size":218246,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twall:master","ref":"master","sha":"ab7eea6d48420ab8705bc8f06120134f806f05b0","user":{"login":"twall","id":756909,"avatar_url":"https://avatars.githubusercontent.com/u/756909?v=3","gravatar_id":"","url":"https://api.github.com/users/twall","html_url":"https://github.com/twall","followers_url":"https://api.github.com/users/twall/followers","following_url":"https://api.github.com/users/twall/following{/other_user}","gists_url":"https://api.github.com/users/twall/gists{/gist_id}","starred_url":"https://api.github.com/users/twall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twall/subscriptions","organizations_url":"https://api.github.com/users/twall/orgs","repos_url":"https://api.github.com/users/twall/repos","events_url":"https://api.github.com/users/twall/events{/privacy}","received_events_url":"https://api.github.com/users/twall/received_events","type":"User","site_admin":false},"repo":{"id":1680733,"name":"jna","full_name":"twall/jna","owner":{"login":"twall","id":756909,"avatar_url":"https://avatars.githubusercontent.com/u/756909?v=3","gravatar_id":"","url":"https://api.github.com/users/twall","html_url":"https://github.com/twall","followers_url":"https://api.github.com/users/twall/followers","following_url":"https://api.github.com/users/twall/following{/other_user}","gists_url":"https://api.github.com/users/twall/gists{/gist_id}","starred_url":"https://api.github.com/users/twall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twall/subscriptions","organizations_url":"https://api.github.com/users/twall/orgs","repos_url":"https://api.github.com/users/twall/repos","events_url":"https://api.github.com/users/twall/events{/privacy}","received_events_url":"https://api.github.com/users/twall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twall/jna","description":"Java Native Access","fork":false,"url":"https://api.github.com/repos/twall/jna","forks_url":"https://api.github.com/repos/twall/jna/forks","keys_url":"https://api.github.com/repos/twall/jna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twall/jna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twall/jna/teams","hooks_url":"https://api.github.com/repos/twall/jna/hooks","issue_events_url":"https://api.github.com/repos/twall/jna/issues/events{/number}","events_url":"https://api.github.com/repos/twall/jna/events","assignees_url":"https://api.github.com/repos/twall/jna/assignees{/user}","branches_url":"https://api.github.com/repos/twall/jna/branches{/branch}","tags_url":"https://api.github.com/repos/twall/jna/tags","blobs_url":"https://api.github.com/repos/twall/jna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twall/jna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twall/jna/git/refs{/sha}","trees_url":"https://api.github.com/repos/twall/jna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twall/jna/statuses/{sha}","languages_url":"https://api.github.com/repos/twall/jna/languages","stargazers_url":"https://api.github.com/repos/twall/jna/stargazers","contributors_url":"https://api.github.com/repos/twall/jna/contributors","subscribers_url":"https://api.github.com/repos/twall/jna/subscribers","subscription_url":"https://api.github.com/repos/twall/jna/subscription","commits_url":"https://api.github.com/repos/twall/jna/commits{/sha}","git_commits_url":"https://api.github.com/repos/twall/jna/git/commits{/sha}","comments_url":"https://api.github.com/repos/twall/jna/comments{/number}","issue_comment_url":"https://api.github.com/repos/twall/jna/issues/comments{/number}","contents_url":"https://api.github.com/repos/twall/jna/contents/{+path}","compare_url":"https://api.github.com/repos/twall/jna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twall/jna/merges","archive_url":"https://api.github.com/repos/twall/jna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twall/jna/downloads","issues_url":"https://api.github.com/repos/twall/jna/issues{/number}","pulls_url":"https://api.github.com/repos/twall/jna/pulls{/number}","milestones_url":"https://api.github.com/repos/twall/jna/milestones{/number}","notifications_url":"https://api.github.com/repos/twall/jna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twall/jna/labels{/name}","releases_url":"https://api.github.com/repos/twall/jna/releases{/id}","created_at":"2011-04-29T13:30:29Z","updated_at":"2015-08-10T12:31:35Z","pushed_at":"2015-08-10T13:11:56Z","git_url":"git://github.com/twall/jna.git","ssh_url":"git@github.com:twall/jna.git","clone_url":"https://github.com/twall/jna.git","svn_url":"https://github.com/twall/jna","homepage":"","size":226056,"stargazers_count":1821,"watchers_count":1821,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":526,"mirror_url":null,"open_issues_count":99,"forks":526,"open_issues":99,"watchers":1821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twall/jna/pulls/483"},"html":{"href":"https://github.com/twall/jna/pull/483"},"issue":{"href":"https://api.github.com/repos/twall/jna/issues/483"},"comments":{"href":"https://api.github.com/repos/twall/jna/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/twall/jna/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/twall/jna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twall/jna/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/twall/jna/statuses/70288cc6a08940c0a90aa72cfd8213116bdde305"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":1037,"deletions":1025,"changed_files":12}}