{"action":"created","comment":{"url":"https://api.github.com/repos/AuScope/portal-core/pulls/comments/38501948","id":38501948,"diff_hunk":"@@ -77,6 +77,24 @@ Ext.define('portal.widgets.grid.plugin.RowExpanderContainer', {\n     },\n     \n     /**\n+     * Every time we are forced to regenerate a component, ensure we get a unique DOM ID to render into. \n+     * Recycling the same nodes seems to result in some difficult to nail down ext errors.\n+     * \n+     * see https://jira.csiro.au/browse/AUS-2588\n+     */\n+    renderId: function(out, values) {\n+        var idCounter = 0;\n+        if (this.recordStatus[values.id]) {\n+            idCounter = this.recordStatus[values.id].idCounter - 1;","path":"src/main/webapp/portal-core/js/portal/widgets/grid/plugin/RowExpanderContainer.js","position":21,"original_position":21,"commit_id":"5f381a760af2684c1bd2b9644f9dccfe39560263","original_commit_id":"5f381a760af2684c1bd2b9644f9dccfe39560263","user":{"login":"joshvote","id":2755196,"avatar_url":"https://avatars.githubusercontent.com/u/2755196?v=3","gravatar_id":"","url":"https://api.github.com/users/joshvote","html_url":"https://github.com/joshvote","followers_url":"https://api.github.com/users/joshvote/followers","following_url":"https://api.github.com/users/joshvote/following{/other_user}","gists_url":"https://api.github.com/users/joshvote/gists{/gist_id}","starred_url":"https://api.github.com/users/joshvote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshvote/subscriptions","organizations_url":"https://api.github.com/users/joshvote/orgs","repos_url":"https://api.github.com/users/joshvote/repos","events_url":"https://api.github.com/users/joshvote/events{/privacy}","received_events_url":"https://api.github.com/users/joshvote/received_events","type":"User","site_admin":false},"body":"The ID counter is always pointing to the next free ID. The -1 happens there so we can render the \"current\" ID","created_at":"2015-09-02T06:25:22Z","updated_at":"2015-09-02T06:25:22Z","html_url":"https://github.com/AuScope/portal-core/pull/30#discussion_r38501948","pull_request_url":"https://api.github.com/repos/AuScope/portal-core/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/comments/38501948"},"html":{"href":"https://github.com/AuScope/portal-core/pull/30#discussion_r38501948"},"pull_request":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/AuScope/portal-core/pulls/30","id":43843834,"html_url":"https://github.com/AuScope/portal-core/pull/30","diff_url":"https://github.com/AuScope/portal-core/pull/30.diff","patch_url":"https://github.com/AuScope/portal-core/pull/30.patch","issue_url":"https://api.github.com/repos/AuScope/portal-core/issues/30","number":30,"state":"closed","locked":false,"title":"AUS-2588 Fixing JS error on layer open","user":{"login":"joshvote","id":2755196,"avatar_url":"https://avatars.githubusercontent.com/u/2755196?v=3","gravatar_id":"","url":"https://api.github.com/users/joshvote","html_url":"https://github.com/joshvote","followers_url":"https://api.github.com/users/joshvote/followers","following_url":"https://api.github.com/users/joshvote/following{/other_user}","gists_url":"https://api.github.com/users/joshvote/gists{/gist_id}","starred_url":"https://api.github.com/users/joshvote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshvote/subscriptions","organizations_url":"https://api.github.com/users/joshvote/orgs","repos_url":"https://api.github.com/users/joshvote/repos","events_url":"https://api.github.com/users/joshvote/events{/privacy}","received_events_url":"https://api.github.com/users/joshvote/received_events","type":"User","site_admin":false},"body":"See https://jira.csiro.au/browse/AUS-2588","created_at":"2015-09-01T07:07:59Z","updated_at":"2015-09-02T06:25:23Z","closed_at":"2015-09-02T01:14:19Z","merged_at":"2015-09-02T01:14:19Z","merge_commit_sha":"d9476b9034b01ea2a3d518108908497175a582cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AuScope/portal-core/pulls/30/commits","review_comments_url":"https://api.github.com/repos/AuScope/portal-core/pulls/30/comments","review_comment_url":"https://api.github.com/repos/AuScope/portal-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AuScope/portal-core/issues/30/comments","statuses_url":"https://api.github.com/repos/AuScope/portal-core/statuses/5f381a760af2684c1bd2b9644f9dccfe39560263","head":{"label":"joshvote:AUS-2588","ref":"AUS-2588","sha":"5f381a760af2684c1bd2b9644f9dccfe39560263","user":{"login":"joshvote","id":2755196,"avatar_url":"https://avatars.githubusercontent.com/u/2755196?v=3","gravatar_id":"","url":"https://api.github.com/users/joshvote","html_url":"https://github.com/joshvote","followers_url":"https://api.github.com/users/joshvote/followers","following_url":"https://api.github.com/users/joshvote/following{/other_user}","gists_url":"https://api.github.com/users/joshvote/gists{/gist_id}","starred_url":"https://api.github.com/users/joshvote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshvote/subscriptions","organizations_url":"https://api.github.com/users/joshvote/orgs","repos_url":"https://api.github.com/users/joshvote/repos","events_url":"https://api.github.com/users/joshvote/events{/privacy}","received_events_url":"https://api.github.com/users/joshvote/received_events","type":"User","site_admin":false},"repo":{"id":22453491,"name":"portal-core","full_name":"joshvote/portal-core","owner":{"login":"joshvote","id":2755196,"avatar_url":"https://avatars.githubusercontent.com/u/2755196?v=3","gravatar_id":"","url":"https://api.github.com/users/joshvote","html_url":"https://github.com/joshvote","followers_url":"https://api.github.com/users/joshvote/followers","following_url":"https://api.github.com/users/joshvote/following{/other_user}","gists_url":"https://api.github.com/users/joshvote/gists{/gist_id}","starred_url":"https://api.github.com/users/joshvote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshvote/subscriptions","organizations_url":"https://api.github.com/users/joshvote/orgs","repos_url":"https://api.github.com/users/joshvote/repos","events_url":"https://api.github.com/users/joshvote/events{/privacy}","received_events_url":"https://api.github.com/users/joshvote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshvote/portal-core","description":"","fork":true,"url":"https://api.github.com/repos/joshvote/portal-core","forks_url":"https://api.github.com/repos/joshvote/portal-core/forks","keys_url":"https://api.github.com/repos/joshvote/portal-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshvote/portal-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshvote/portal-core/teams","hooks_url":"https://api.github.com/repos/joshvote/portal-core/hooks","issue_events_url":"https://api.github.com/repos/joshvote/portal-core/issues/events{/number}","events_url":"https://api.github.com/repos/joshvote/portal-core/events","assignees_url":"https://api.github.com/repos/joshvote/portal-core/assignees{/user}","branches_url":"https://api.github.com/repos/joshvote/portal-core/branches{/branch}","tags_url":"https://api.github.com/repos/joshvote/portal-core/tags","blobs_url":"https://api.github.com/repos/joshvote/portal-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshvote/portal-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshvote/portal-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshvote/portal-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshvote/portal-core/statuses/{sha}","languages_url":"https://api.github.com/repos/joshvote/portal-core/languages","stargazers_url":"https://api.github.com/repos/joshvote/portal-core/stargazers","contributors_url":"https://api.github.com/repos/joshvote/portal-core/contributors","subscribers_url":"https://api.github.com/repos/joshvote/portal-core/subscribers","subscription_url":"https://api.github.com/repos/joshvote/portal-core/subscription","commits_url":"https://api.github.com/repos/joshvote/portal-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshvote/portal-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshvote/portal-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshvote/portal-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshvote/portal-core/contents/{+path}","compare_url":"https://api.github.com/repos/joshvote/portal-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshvote/portal-core/merges","archive_url":"https://api.github.com/repos/joshvote/portal-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshvote/portal-core/downloads","issues_url":"https://api.github.com/repos/joshvote/portal-core/issues{/number}","pulls_url":"https://api.github.com/repos/joshvote/portal-core/pulls{/number}","milestones_url":"https://api.github.com/repos/joshvote/portal-core/milestones{/number}","notifications_url":"https://api.github.com/repos/joshvote/portal-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshvote/portal-core/labels{/name}","releases_url":"https://api.github.com/repos/joshvote/portal-core/releases{/id}","created_at":"2014-07-31T02:39:29Z","updated_at":"2015-01-20T05:02:18Z","pushed_at":"2015-09-01T07:07:02Z","git_url":"git://github.com/joshvote/portal-core.git","ssh_url":"git@github.com:joshvote/portal-core.git","clone_url":"https://github.com/joshvote/portal-core.git","svn_url":"https://github.com/joshvote/portal-core","homepage":null,"size":51614,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AuScope:master","ref":"master","sha":"dbdca30d408447c1b336acc10a2e12dd547499a1","user":{"login":"AuScope","id":8154611,"avatar_url":"https://avatars.githubusercontent.com/u/8154611?v=3","gravatar_id":"","url":"https://api.github.com/users/AuScope","html_url":"https://github.com/AuScope","followers_url":"https://api.github.com/users/AuScope/followers","following_url":"https://api.github.com/users/AuScope/following{/other_user}","gists_url":"https://api.github.com/users/AuScope/gists{/gist_id}","starred_url":"https://api.github.com/users/AuScope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuScope/subscriptions","organizations_url":"https://api.github.com/users/AuScope/orgs","repos_url":"https://api.github.com/users/AuScope/repos","events_url":"https://api.github.com/users/AuScope/events{/privacy}","received_events_url":"https://api.github.com/users/AuScope/received_events","type":"Organization","site_admin":false},"repo":{"id":22411628,"name":"portal-core","full_name":"AuScope/portal-core","owner":{"login":"AuScope","id":8154611,"avatar_url":"https://avatars.githubusercontent.com/u/8154611?v=3","gravatar_id":"","url":"https://api.github.com/users/AuScope","html_url":"https://github.com/AuScope","followers_url":"https://api.github.com/users/AuScope/followers","following_url":"https://api.github.com/users/AuScope/following{/other_user}","gists_url":"https://api.github.com/users/AuScope/gists{/gist_id}","starred_url":"https://api.github.com/users/AuScope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AuScope/subscriptions","organizations_url":"https://api.github.com/users/AuScope/orgs","repos_url":"https://api.github.com/users/AuScope/repos","events_url":"https://api.github.com/users/AuScope/events{/privacy}","received_events_url":"https://api.github.com/users/AuScope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AuScope/portal-core","description":"","fork":false,"url":"https://api.github.com/repos/AuScope/portal-core","forks_url":"https://api.github.com/repos/AuScope/portal-core/forks","keys_url":"https://api.github.com/repos/AuScope/portal-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AuScope/portal-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AuScope/portal-core/teams","hooks_url":"https://api.github.com/repos/AuScope/portal-core/hooks","issue_events_url":"https://api.github.com/repos/AuScope/portal-core/issues/events{/number}","events_url":"https://api.github.com/repos/AuScope/portal-core/events","assignees_url":"https://api.github.com/repos/AuScope/portal-core/assignees{/user}","branches_url":"https://api.github.com/repos/AuScope/portal-core/branches{/branch}","tags_url":"https://api.github.com/repos/AuScope/portal-core/tags","blobs_url":"https://api.github.com/repos/AuScope/portal-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AuScope/portal-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AuScope/portal-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/AuScope/portal-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AuScope/portal-core/statuses/{sha}","languages_url":"https://api.github.com/repos/AuScope/portal-core/languages","stargazers_url":"https://api.github.com/repos/AuScope/portal-core/stargazers","contributors_url":"https://api.github.com/repos/AuScope/portal-core/contributors","subscribers_url":"https://api.github.com/repos/AuScope/portal-core/subscribers","subscription_url":"https://api.github.com/repos/AuScope/portal-core/subscription","commits_url":"https://api.github.com/repos/AuScope/portal-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/AuScope/portal-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/AuScope/portal-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/AuScope/portal-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/AuScope/portal-core/contents/{+path}","compare_url":"https://api.github.com/repos/AuScope/portal-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AuScope/portal-core/merges","archive_url":"https://api.github.com/repos/AuScope/portal-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AuScope/portal-core/downloads","issues_url":"https://api.github.com/repos/AuScope/portal-core/issues{/number}","pulls_url":"https://api.github.com/repos/AuScope/portal-core/pulls{/number}","milestones_url":"https://api.github.com/repos/AuScope/portal-core/milestones{/number}","notifications_url":"https://api.github.com/repos/AuScope/portal-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AuScope/portal-core/labels{/name}","releases_url":"https://api.github.com/repos/AuScope/portal-core/releases{/id}","created_at":"2014-07-30T06:15:56Z","updated_at":"2015-05-05T02:17:58Z","pushed_at":"2015-09-02T01:14:19Z","git_url":"git://github.com/AuScope/portal-core.git","ssh_url":"git@github.com:AuScope/portal-core.git","clone_url":"https://github.com/AuScope/portal-core.git","svn_url":"https://github.com/AuScope/portal-core","homepage":"","size":52527,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/30"},"html":{"href":"https://github.com/AuScope/portal-core/pull/30"},"issue":{"href":"https://api.github.com/repos/AuScope/portal-core/issues/30"},"comments":{"href":"https://api.github.com/repos/AuScope/portal-core/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AuScope/portal-core/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/AuScope/portal-core/statuses/5f381a760af2684c1bd2b9644f9dccfe39560263"}}}}