{"action":"created","issue":{"url":"https://api.github.com/repos/FAForever/fa/issues/780","labels_url":"https://api.github.com/repos/FAForever/fa/issues/780/labels{/name}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/780/comments","events_url":"https://api.github.com/repos/FAForever/fa/issues/780/events","html_url":"https://github.com/FAForever/fa/issues/780","id":95764314,"number":780,"title":"Sera T2 Transport allows active shields in hooks","user":{"login":"Varaxis","id":10490884,"avatar_url":"https://avatars.githubusercontent.com/u/10490884?v=3","gravatar_id":"","url":"https://api.github.com/users/Varaxis","html_url":"https://github.com/Varaxis","followers_url":"https://api.github.com/users/Varaxis/followers","following_url":"https://api.github.com/users/Varaxis/following{/other_user}","gists_url":"https://api.github.com/users/Varaxis/gists{/gist_id}","starred_url":"https://api.github.com/users/Varaxis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Varaxis/subscriptions","organizations_url":"https://api.github.com/users/Varaxis/orgs","repos_url":"https://api.github.com/users/Varaxis/repos","events_url":"https://api.github.com/users/Varaxis/events{/privacy}","received_events_url":"https://api.github.com/users/Varaxis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/FAForever/fa/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/FAForever/fa/labels/sim","name":"sim","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/FAForever/fa/milestones/13","html_url":"https://github.com/FAForever/fa/milestones/3643","labels_url":"https://api.github.com/repos/FAForever/fa/milestones/13/labels","id":1211200,"number":13,"title":"3643","description":"","creator":{"login":"Sheeo","id":37968,"avatar_url":"https://avatars.githubusercontent.com/u/37968?v=3","gravatar_id":"","url":"https://api.github.com/users/Sheeo","html_url":"https://github.com/Sheeo","followers_url":"https://api.github.com/users/Sheeo/followers","following_url":"https://api.github.com/users/Sheeo/following{/other_user}","gists_url":"https://api.github.com/users/Sheeo/gists{/gist_id}","starred_url":"https://api.github.com/users/Sheeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sheeo/subscriptions","organizations_url":"https://api.github.com/users/Sheeo/orgs","repos_url":"https://api.github.com/users/Sheeo/repos","events_url":"https://api.github.com/users/Sheeo/events{/privacy}","received_events_url":"https://api.github.com/users/Sheeo/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2015-07-16T13:03:46Z","updated_at":"2015-07-18T08:18:31Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-07-17T23:28:02Z","updated_at":"2015-07-18T19:01:14Z","closed_at":null,"body":"Sera T2 Transport allows all shields to be active, both bubbles and personal shields. No other transport allows this, based on testing in sandbox."},"comment":{"url":"https://api.github.com/repos/FAForever/fa/issues/comments/122580557","html_url":"https://github.com/FAForever/fa/issues/780#issuecomment-122580557","issue_url":"https://api.github.com/repos/FAForever/fa/issues/780","id":122580557,"user":{"login":"ChrisKitching","id":3526849,"avatar_url":"https://avatars.githubusercontent.com/u/3526849?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisKitching","html_url":"https://github.com/ChrisKitching","followers_url":"https://api.github.com/users/ChrisKitching/followers","following_url":"https://api.github.com/users/ChrisKitching/following{/other_user}","gists_url":"https://api.github.com/users/ChrisKitching/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisKitching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisKitching/subscriptions","organizations_url":"https://api.github.com/users/ChrisKitching/orgs","repos_url":"https://api.github.com/users/ChrisKitching/repos","events_url":"https://api.github.com/users/ChrisKitching/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisKitching/received_events","type":"User","site_admin":false},"created_at":"2015-07-18T19:01:14Z","updated_at":"2015-07-18T19:01:14Z","body":"> So what probably needs to be done to fix this is to redo the Sera T2 Transport (XSA0104) to properly inherit from AirTransport base class.\r\n\r\nYup. Do that. It's almost certainly a trivial matter of deleting most of the script :P\r\n\r\n> it saves sim execution time.\r\n\r\nAnd, more usefully, gives us abstractions that make sense (AirTransport itself inherits from BaseTransport (a base class of \"things that hold other things\" which encompasses things such as aircraft carriers, the CZAR, and kennels, all of which previously had variously inconsistent copies of identical code in them :/))"}}