{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/41220188","id":41220188,"diff_hunk":"@@ -11,10 +11,11 @@ module bank_header\n !===============================================================================\n \n   type, bind(C) :: Bank\n-    real(C_DOUBLE) :: wgt    ! weight of bank site\n-    real(C_DOUBLE) :: xyz(3) ! location of bank particle\n-    real(C_DOUBLE) :: uvw(3) ! diretional cosines\n-    real(C_DOUBLE) :: E      ! energy\n+    real(C_DOUBLE) :: wgt           ! weight of bank site\n+    real(C_DOUBLE) :: xyz(3)        ! location of bank particle\n+    real(C_DOUBLE) :: uvw(3)        ! diretional cosines\n+    real(C_DOUBLE) :: E             ! energy\n+    integer        :: delayed_group ! delayed group","path":"src/bank_header.F90","position":12,"original_position":12,"commit_id":"66ee8358d66d030689fd98b3f64da9861715713b","original_commit_id":"66ee8358d66d030689fd98b3f64da9861715713b","user":{"login":"paulromano","id":743095,"avatar_url":"https://avatars.githubusercontent.com/u/743095?v=3","gravatar_id":"","url":"https://api.github.com/users/paulromano","html_url":"https://github.com/paulromano","followers_url":"https://api.github.com/users/paulromano/followers","following_url":"https://api.github.com/users/paulromano/following{/other_user}","gists_url":"https://api.github.com/users/paulromano/gists{/gist_id}","starred_url":"https://api.github.com/users/paulromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulromano/subscriptions","organizations_url":"https://api.github.com/users/paulromano/orgs","repos_url":"https://api.github.com/users/paulromano/repos","events_url":"https://api.github.com/users/paulromano/events{/privacy}","received_events_url":"https://api.github.com/users/paulromano/received_events","type":"User","site_admin":false},"body":"Type this as `integer(C_INT)`","created_at":"2015-10-06T02:13:40Z","updated_at":"2015-10-06T02:13:40Z","html_url":"https://github.com/mit-crpg/openmc/pull/368#discussion_r41220188","pull_request_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/368","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments/41220188"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/368#discussion_r41220188"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/openmc/pulls/368","id":32509208,"html_url":"https://github.com/mit-crpg/openmc/pull/368","diff_url":"https://github.com/mit-crpg/openmc/pull/368.diff","patch_url":"https://github.com/mit-crpg/openmc/pull/368.patch","issue_url":"https://api.github.com/repos/mit-crpg/openmc/issues/368","number":368,"state":"open","locked":false,"title":"Delayed nu fission score and delayed group filter","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This PR incorporates two features into OpenMC necessary to compute delayed fractions and delayed neutron spectrums for the different delayed groups. The features include:\r\n\r\n- Delayed nu fission score `delay-nu-fission`: This score can be used to tally the delayed fission production rate, either cumulatively or in each delayed group separately. Energy in and energy out filters are supported, which are necessary to compute the delayed neutron spectrums.\r\n- Delayed group filter `delaygroup`: This filter can only be used with the `delay-nu-fission` score and allows tallies of the delayed fission rate to be formed for all delayed groups. There are no bin options for this filter; rather the bins attribute is set to an empty string and the delayed fission rate is tallied for each delayed group separately. Setting the bins attribute to an empty string seems awkward, so I'm open to thoughts on other ways to incorporate this filter.\r\n\r\nOne complication of implementing these features is the different number of delayed groups in different cross section libraries (e.g. ENDF/B-VII.1 has 6 and JEFF 3.1.1 has 8 delayed groups). Since the number of delayed groups is not known prior to reading in the input files, a constant `MAX_DELAYED_GROUPS` is set to 8 so the `delay-nu-fission` score bins can be used for the 6 and 8 delayed group structures. The `delay-nu-fission` score is then output for the `MAX_DELAYED_GROUPS`, with any groups not present returned as 0.0. A check is performed when the ace files are parsed and an error message is output if a nuclide with a number of delayed groups greater than `MAX_DELAYED_GROUPS` is encountered. ","created_at":"2015-04-02T13:03:09Z","updated_at":"2015-10-06T02:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0e0fc359bad5f8d099ddf58b30ee39cd0a88773","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/368/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/368/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/issues/368/comments","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/66ee8358d66d030689fd98b3f64da9861715713b","head":{"label":"samuelshaner:delayed-tallies","ref":"delayed-tallies","sha":"66ee8358d66d030689fd98b3f64da9861715713b","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":30840720,"name":"openmc","full_name":"samuelshaner/openmc","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/openmc","description":"OpenMC Monte Carlo Code","fork":true,"url":"https://api.github.com/repos/samuelshaner/openmc","forks_url":"https://api.github.com/repos/samuelshaner/openmc/forks","keys_url":"https://api.github.com/repos/samuelshaner/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/openmc/teams","hooks_url":"https://api.github.com/repos/samuelshaner/openmc/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/openmc/events","assignees_url":"https://api.github.com/repos/samuelshaner/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/openmc/tags","blobs_url":"https://api.github.com/repos/samuelshaner/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/openmc/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/openmc/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/openmc/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/openmc/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/openmc/subscription","commits_url":"https://api.github.com/repos/samuelshaner/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/openmc/merges","archive_url":"https://api.github.com/repos/samuelshaner/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/openmc/downloads","issues_url":"https://api.github.com/repos/samuelshaner/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/openmc/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/openmc/releases{/id}","created_at":"2015-02-15T20:23:50Z","updated_at":"2015-02-15T20:41:35Z","pushed_at":"2015-10-05T14:12:23Z","git_url":"git://github.com/samuelshaner/openmc.git","ssh_url":"git@github.com:samuelshaner/openmc.git","clone_url":"https://github.com/samuelshaner/openmc.git","svn_url":"https://github.com/samuelshaner/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":22315,"stargazers_count":0,"watchers_count":0,"language":"FORTRAN","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"99a8762b7b169b95c2e75c728571ba1fea41d3d0","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":2081118,"name":"openmc","full_name":"mit-crpg/openmc","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/openmc","description":"OpenMC Monte Carlo Code","fork":false,"url":"https://api.github.com/repos/mit-crpg/openmc","forks_url":"https://api.github.com/repos/mit-crpg/openmc/forks","keys_url":"https://api.github.com/repos/mit-crpg/openmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/openmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/openmc/teams","hooks_url":"https://api.github.com/repos/mit-crpg/openmc/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/openmc/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/openmc/events","assignees_url":"https://api.github.com/repos/mit-crpg/openmc/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/openmc/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/openmc/tags","blobs_url":"https://api.github.com/repos/mit-crpg/openmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/openmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/openmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/openmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/openmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/openmc/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/openmc/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/openmc/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/openmc/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/openmc/subscription","commits_url":"https://api.github.com/repos/mit-crpg/openmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/openmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/openmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/openmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/openmc/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/openmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/openmc/merges","archive_url":"https://api.github.com/repos/mit-crpg/openmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/openmc/downloads","issues_url":"https://api.github.com/repos/mit-crpg/openmc/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/openmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/openmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/openmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/openmc/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/openmc/releases{/id}","created_at":"2011-07-21T00:33:27Z","updated_at":"2015-09-07T02:19:23Z","pushed_at":"2015-10-05T23:57:58Z","git_url":"git://github.com/mit-crpg/openmc.git","ssh_url":"git@github.com:mit-crpg/openmc.git","clone_url":"https://github.com/mit-crpg/openmc.git","svn_url":"https://github.com/mit-crpg/openmc","homepage":"http://mit-crpg.github.io/openmc/","size":39099,"stargazers_count":59,"watchers_count":59,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":81,"mirror_url":null,"open_issues_count":41,"forks":81,"open_issues":41,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/368"},"html":{"href":"https://github.com/mit-crpg/openmc/pull/368"},"issue":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/368"},"comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/openmc/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/openmc/statuses/66ee8358d66d030689fd98b3f64da9861715713b"}}}}