{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50","id":44313305,"html_url":"https://github.com/GregRos/IEMod.pw/pull/50","diff_url":"https://github.com/GregRos/IEMod.pw/pull/50.diff","patch_url":"https://github.com/GregRos/IEMod.pw/pull/50.patch","issue_url":"https://api.github.com/repos/GregRos/IEMod.pw/issues/50","number":50,"state":"closed","locked":false,"title":"Fix to Obsidian Bug introduced in 2.01","user":{"login":"tjayharvey","id":13974045,"avatar_url":"https://avatars.githubusercontent.com/u/13974045?v=3","gravatar_id":"","url":"https://api.github.com/users/tjayharvey","html_url":"https://github.com/tjayharvey","followers_url":"https://api.github.com/users/tjayharvey/followers","following_url":"https://api.github.com/users/tjayharvey/following{/other_user}","gists_url":"https://api.github.com/users/tjayharvey/gists{/gist_id}","starred_url":"https://api.github.com/users/tjayharvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjayharvey/subscriptions","organizations_url":"https://api.github.com/users/tjayharvey/orgs","repos_url":"https://api.github.com/users/tjayharvey/repos","events_url":"https://api.github.com/users/tjayharvey/events{/privacy}","received_events_url":"https://api.github.com/users/tjayharvey/received_events","type":"User","site_admin":false},"body":"In 2.01, Obsidian introduced a bug whereby a spell cast on the caster that then has an AE around them (such as Returning Storm, Death Ring, etc) would not cast. It's not clear to me where this bug was introduced as the relevant code all looks the same in both versions, but it's possible it's something on the Object Bundles that has changed. Regardless, the problem looks to be that there is a check in AI.Player.Attack that looks at whether it's legal for the attack owner to attack the target. If so, then the cast either reverts to autoattack if AI autoattack is on and an eligible target exists, or just gets removed from the queue.\r\n\r\nIn the case of the returning storm in 2.01, the druid caster is both the owner and the target, and apparently it's not legal for the druid to attack themselves, so it's failing this check and reverting. \r\n\r\nI've installed a mod to fix the problem for now, simply by exempting self-targeted attacks from performing this check. It's probably not as safe as however Obsidian intends to fix it, but it's available now instead of in a week or two.\r\n\r\nDo we want to install this for now and rip it out when Obsidian patches it? Do we want to make it optional if so?","created_at":"2015-09-07T00:49:06Z","updated_at":"2015-09-08T19:25:22Z","closed_at":"2015-09-08T19:25:22Z","merged_at":"2015-09-08T19:25:22Z","merge_commit_sha":"5a9ab418cef05ff044ac30b13a9e09100a8a250a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50/commits","review_comments_url":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50/comments","review_comment_url":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GregRos/IEMod.pw/issues/50/comments","statuses_url":"https://api.github.com/repos/GregRos/IEMod.pw/statuses/beff2627d16ecc59d6cebc468292ade20027b42c","head":{"label":"tjayharvey:master","ref":"master","sha":"beff2627d16ecc59d6cebc468292ade20027b42c","user":{"login":"tjayharvey","id":13974045,"avatar_url":"https://avatars.githubusercontent.com/u/13974045?v=3","gravatar_id":"","url":"https://api.github.com/users/tjayharvey","html_url":"https://github.com/tjayharvey","followers_url":"https://api.github.com/users/tjayharvey/followers","following_url":"https://api.github.com/users/tjayharvey/following{/other_user}","gists_url":"https://api.github.com/users/tjayharvey/gists{/gist_id}","starred_url":"https://api.github.com/users/tjayharvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjayharvey/subscriptions","organizations_url":"https://api.github.com/users/tjayharvey/orgs","repos_url":"https://api.github.com/users/tjayharvey/repos","events_url":"https://api.github.com/users/tjayharvey/events{/privacy}","received_events_url":"https://api.github.com/users/tjayharvey/received_events","type":"User","site_admin":false},"repo":{"id":41451656,"name":"IEMod.pw","full_name":"tjayharvey/IEMod.pw","owner":{"login":"tjayharvey","id":13974045,"avatar_url":"https://avatars.githubusercontent.com/u/13974045?v=3","gravatar_id":"","url":"https://api.github.com/users/tjayharvey","html_url":"https://github.com/tjayharvey","followers_url":"https://api.github.com/users/tjayharvey/followers","following_url":"https://api.github.com/users/tjayharvey/following{/other_user}","gists_url":"https://api.github.com/users/tjayharvey/gists{/gist_id}","starred_url":"https://api.github.com/users/tjayharvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjayharvey/subscriptions","organizations_url":"https://api.github.com/users/tjayharvey/orgs","repos_url":"https://api.github.com/users/tjayharvey/repos","events_url":"https://api.github.com/users/tjayharvey/events{/privacy}","received_events_url":"https://api.github.com/users/tjayharvey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjayharvey/IEMod.pw","description":"","fork":true,"url":"https://api.github.com/repos/tjayharvey/IEMod.pw","forks_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/forks","keys_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/teams","hooks_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/hooks","issue_events_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/issues/events{/number}","events_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/events","assignees_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/assignees{/user}","branches_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/branches{/branch}","tags_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/tags","blobs_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/statuses/{sha}","languages_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/languages","stargazers_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/stargazers","contributors_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/contributors","subscribers_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/subscribers","subscription_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/subscription","commits_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/contents/{+path}","compare_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/merges","archive_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/downloads","issues_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/issues{/number}","pulls_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/pulls{/number}","milestones_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/milestones{/number}","notifications_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/labels{/name}","releases_url":"https://api.github.com/repos/tjayharvey/IEMod.pw/releases{/id}","created_at":"2015-08-26T21:51:06Z","updated_at":"2015-08-26T21:51:07Z","pushed_at":"2015-09-07T00:51:31Z","git_url":"git://github.com/tjayharvey/IEMod.pw.git","ssh_url":"git@github.com:tjayharvey/IEMod.pw.git","clone_url":"https://github.com/tjayharvey/IEMod.pw.git","svn_url":"https://github.com/tjayharvey/IEMod.pw","homepage":null,"size":44195,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GregRos:master","ref":"master","sha":"b62784741fcca74e5017f68b979165dece7fba4f","user":{"login":"GregRos","id":1788329,"avatar_url":"https://avatars.githubusercontent.com/u/1788329?v=3","gravatar_id":"","url":"https://api.github.com/users/GregRos","html_url":"https://github.com/GregRos","followers_url":"https://api.github.com/users/GregRos/followers","following_url":"https://api.github.com/users/GregRos/following{/other_user}","gists_url":"https://api.github.com/users/GregRos/gists{/gist_id}","starred_url":"https://api.github.com/users/GregRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregRos/subscriptions","organizations_url":"https://api.github.com/users/GregRos/orgs","repos_url":"https://api.github.com/users/GregRos/repos","events_url":"https://api.github.com/users/GregRos/events{/privacy}","received_events_url":"https://api.github.com/users/GregRos/received_events","type":"User","site_admin":false},"repo":{"id":40316140,"name":"IEMod.pw","full_name":"GregRos/IEMod.pw","owner":{"login":"GregRos","id":1788329,"avatar_url":"https://avatars.githubusercontent.com/u/1788329?v=3","gravatar_id":"","url":"https://api.github.com/users/GregRos","html_url":"https://github.com/GregRos","followers_url":"https://api.github.com/users/GregRos/followers","following_url":"https://api.github.com/users/GregRos/following{/other_user}","gists_url":"https://api.github.com/users/GregRos/gists{/gist_id}","starred_url":"https://api.github.com/users/GregRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregRos/subscriptions","organizations_url":"https://api.github.com/users/GregRos/orgs","repos_url":"https://api.github.com/users/GregRos/repos","events_url":"https://api.github.com/users/GregRos/events{/privacy}","received_events_url":"https://api.github.com/users/GregRos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GregRos/IEMod.pw","description":"A mod for Pillars of Eternity","fork":false,"url":"https://api.github.com/repos/GregRos/IEMod.pw","forks_url":"https://api.github.com/repos/GregRos/IEMod.pw/forks","keys_url":"https://api.github.com/repos/GregRos/IEMod.pw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GregRos/IEMod.pw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GregRos/IEMod.pw/teams","hooks_url":"https://api.github.com/repos/GregRos/IEMod.pw/hooks","issue_events_url":"https://api.github.com/repos/GregRos/IEMod.pw/issues/events{/number}","events_url":"https://api.github.com/repos/GregRos/IEMod.pw/events","assignees_url":"https://api.github.com/repos/GregRos/IEMod.pw/assignees{/user}","branches_url":"https://api.github.com/repos/GregRos/IEMod.pw/branches{/branch}","tags_url":"https://api.github.com/repos/GregRos/IEMod.pw/tags","blobs_url":"https://api.github.com/repos/GregRos/IEMod.pw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GregRos/IEMod.pw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GregRos/IEMod.pw/git/refs{/sha}","trees_url":"https://api.github.com/repos/GregRos/IEMod.pw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GregRos/IEMod.pw/statuses/{sha}","languages_url":"https://api.github.com/repos/GregRos/IEMod.pw/languages","stargazers_url":"https://api.github.com/repos/GregRos/IEMod.pw/stargazers","contributors_url":"https://api.github.com/repos/GregRos/IEMod.pw/contributors","subscribers_url":"https://api.github.com/repos/GregRos/IEMod.pw/subscribers","subscription_url":"https://api.github.com/repos/GregRos/IEMod.pw/subscription","commits_url":"https://api.github.com/repos/GregRos/IEMod.pw/commits{/sha}","git_commits_url":"https://api.github.com/repos/GregRos/IEMod.pw/git/commits{/sha}","comments_url":"https://api.github.com/repos/GregRos/IEMod.pw/comments{/number}","issue_comment_url":"https://api.github.com/repos/GregRos/IEMod.pw/issues/comments{/number}","contents_url":"https://api.github.com/repos/GregRos/IEMod.pw/contents/{+path}","compare_url":"https://api.github.com/repos/GregRos/IEMod.pw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GregRos/IEMod.pw/merges","archive_url":"https://api.github.com/repos/GregRos/IEMod.pw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GregRos/IEMod.pw/downloads","issues_url":"https://api.github.com/repos/GregRos/IEMod.pw/issues{/number}","pulls_url":"https://api.github.com/repos/GregRos/IEMod.pw/pulls{/number}","milestones_url":"https://api.github.com/repos/GregRos/IEMod.pw/milestones{/number}","notifications_url":"https://api.github.com/repos/GregRos/IEMod.pw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GregRos/IEMod.pw/labels{/name}","releases_url":"https://api.github.com/repos/GregRos/IEMod.pw/releases{/id}","created_at":"2015-08-06T16:45:08Z","updated_at":"2015-09-03T14:04:48Z","pushed_at":"2015-09-08T19:25:22Z","git_url":"git://github.com/GregRos/IEMod.pw.git","ssh_url":"git@github.com:GregRos/IEMod.pw.git","clone_url":"https://github.com/GregRos/IEMod.pw.git","svn_url":"https://github.com/GregRos/IEMod.pw","homepage":"","size":44318,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50"},"html":{"href":"https://github.com/GregRos/IEMod.pw/pull/50"},"issue":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/issues/50"},"comments":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/GregRos/IEMod.pw/statuses/beff2627d16ecc59d6cebc468292ade20027b42c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"GregRos","id":1788329,"avatar_url":"https://avatars.githubusercontent.com/u/1788329?v=3","gravatar_id":"","url":"https://api.github.com/users/GregRos","html_url":"https://github.com/GregRos","followers_url":"https://api.github.com/users/GregRos/followers","following_url":"https://api.github.com/users/GregRos/following{/other_user}","gists_url":"https://api.github.com/users/GregRos/gists{/gist_id}","starred_url":"https://api.github.com/users/GregRos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregRos/subscriptions","organizations_url":"https://api.github.com/users/GregRos/orgs","repos_url":"https://api.github.com/users/GregRos/repos","events_url":"https://api.github.com/users/GregRos/events{/privacy}","received_events_url":"https://api.github.com/users/GregRos/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":2,"additions":198,"deletions":0,"changed_files":2}}