{"action":"created","comment":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/42109603","id":42109603,"diff_hunk":"@@ -293,27 +293,8 @@ require(['jquery', 'underscore', 'oae.core', 'iso3166'], function($, _, oae, iso\n                     'text': oae.api.i18n.translate('__MSG__THIS_USERNAME_HAS_ALREADY_BEEN_TAKEN__')\n                 },\n                 'emaildomain': {\n-                    'method': function(value, element) {\n-                        var configuredEmailDomain = oae.data.me.tenant.emailDomain;\n-\n-                        // If the tenant has not been configured with an email domain, any email address\n-                        // can be used to sign up\n-                        if (!configuredEmailDomain) {\n-                            return true;\n-                        }\n-\n-                        // Only accept email addresses that are either an exact match or have the\n-                        // configured email domain as the suffix\n-                        var enteredEmailDomain = value.split('@').pop();\n-                        var exactMatch = (enteredEmailDomain === configuredEmailDomain);\n-                        var emailDomainSuffix = '.' + configuredEmailDomain;\n-                        var suffixPosition = enteredEmailDomain.indexOf(emailDomainSuffix);\n-                        var suffixMatch = (suffixPosition > 0 && suffixPosition === (enteredEmailDomain.length - emailDomainSuffix.length));\n-\n-                        // Verify the entered email address matches the configured email domain\n-                        return (exactMatch || suffixMatch);\n-                    },\n-                    'text': oae.api.i18n.translate('__MSG__YOU_CAN_ONLY_REGISTER_WITH_A_TENANT_EMAIL_ADDRESS__', null, {'emailDomain': oae.data.me.tenant.emailDomain})\n+                    'method': oae.api.util.validation().isValidEmailDomainForTenant,\n+                    'text': oae.api.i18n.translate('__MSG__YOU_CAN_ONLY_REGISTER_WITH_A_TENANT_EMAIL_ADDRESS__', null, {'emailDomain': oae.data.me.tenant.emailDomain.toLowerCase()})","path":"ui/js/signup.js","position":26,"original_position":26,"commit_id":"f82ce6b38531a6753c53c6e20b3defc0038defd2","original_commit_id":"f82ce6b38531a6753c53c6e20b3defc0038defd2","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"body":"Yes: https://github.com/oaeproject/Hilary/issues/1248","created_at":"2015-10-15T11:01:58Z","updated_at":"2015-10-15T11:01:58Z","html_url":"https://github.com/oaeproject/3akai-ux/pull/4079#discussion_r42109603","pull_request_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/42109603"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4079#discussion_r42109603"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079"}}},"pull_request":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079","id":47523045,"html_url":"https://github.com/oaeproject/3akai-ux/pull/4079","diff_url":"https://github.com/oaeproject/3akai-ux/pull/4079.diff","patch_url":"https://github.com/oaeproject/3akai-ux/pull/4079.patch","issue_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4079","number":4079,"state":"open","locked":false,"title":"Show email address field if invitation email domain is not valid for the current tenant","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"body":"Now that WAYF is merged, it is possible to transfer your invitation from the network tenant to another, and accept it there.\r\n\r\nThis also means that a user may want to accept an invitation from the gmail account, which takes them to the network tenant, then head over to their unadopted umichigan tenant to create an account with email address umich.edu. However since the invitation has a gmail.com email address, the email address field on the signup form is not present.","created_at":"2015-10-13T11:52:45Z","updated_at":"2015-10-15T11:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b7e1567fbf71a0932e2cf6ba3adfad587ae3cd2","assignee":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079/commits","review_comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079/comments","review_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4079/comments","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/f82ce6b38531a6753c53c6e20b3defc0038defd2","head":{"label":"mrvisser:wayf-showemail","ref":"wayf-showemail","sha":"f82ce6b38531a6753c53c6e20b3defc0038defd2","user":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"repo":{"id":3808076,"name":"3akai-ux","full_name":"mrvisser/3akai-ux","owner":{"login":"mrvisser","id":102265,"avatar_url":"https://avatars.githubusercontent.com/u/102265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrvisser","html_url":"https://github.com/mrvisser","followers_url":"https://api.github.com/users/mrvisser/followers","following_url":"https://api.github.com/users/mrvisser/following{/other_user}","gists_url":"https://api.github.com/users/mrvisser/gists{/gist_id}","starred_url":"https://api.github.com/users/mrvisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrvisser/subscriptions","organizations_url":"https://api.github.com/users/mrvisser/orgs","repos_url":"https://api.github.com/users/mrvisser/repos","events_url":"https://api.github.com/users/mrvisser/events{/privacy}","received_events_url":"https://api.github.com/users/mrvisser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrvisser/3akai-ux","description":"Front-end development for Sakai 3","fork":true,"url":"https://api.github.com/repos/mrvisser/3akai-ux","forks_url":"https://api.github.com/repos/mrvisser/3akai-ux/forks","keys_url":"https://api.github.com/repos/mrvisser/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrvisser/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrvisser/3akai-ux/teams","hooks_url":"https://api.github.com/repos/mrvisser/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/mrvisser/3akai-ux/events","assignees_url":"https://api.github.com/repos/mrvisser/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/mrvisser/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/mrvisser/3akai-ux/tags","blobs_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrvisser/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/mrvisser/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/mrvisser/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/mrvisser/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/mrvisser/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/mrvisser/3akai-ux/subscription","commits_url":"https://api.github.com/repos/mrvisser/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrvisser/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrvisser/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrvisser/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/mrvisser/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrvisser/3akai-ux/merges","archive_url":"https://api.github.com/repos/mrvisser/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrvisser/3akai-ux/downloads","issues_url":"https://api.github.com/repos/mrvisser/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/mrvisser/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/mrvisser/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/mrvisser/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrvisser/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/mrvisser/3akai-ux/releases{/id}","created_at":"2012-03-23T12:28:27Z","updated_at":"2015-05-13T12:36:09Z","pushed_at":"2015-10-13T11:52:29Z","git_url":"git://github.com/mrvisser/3akai-ux.git","ssh_url":"git@github.com:mrvisser/3akai-ux.git","clone_url":"https://github.com/mrvisser/3akai-ux.git","svn_url":"https://github.com/mrvisser/3akai-ux","homepage":"3akai.sakaiproject.org/dev","size":133224,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"oaeproject:master","ref":"master","sha":"b481a94804b0fbfa7f929574cfba9f3ed879d00e","user":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"repo":{"id":761723,"name":"3akai-ux","full_name":"oaeproject/3akai-ux","owner":{"login":"oaeproject","id":4659912,"avatar_url":"https://avatars.githubusercontent.com/u/4659912?v=3","gravatar_id":"","url":"https://api.github.com/users/oaeproject","html_url":"https://github.com/oaeproject","followers_url":"https://api.github.com/users/oaeproject/followers","following_url":"https://api.github.com/users/oaeproject/following{/other_user}","gists_url":"https://api.github.com/users/oaeproject/gists{/gist_id}","starred_url":"https://api.github.com/users/oaeproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaeproject/subscriptions","organizations_url":"https://api.github.com/users/oaeproject/orgs","repos_url":"https://api.github.com/users/oaeproject/repos","events_url":"https://api.github.com/users/oaeproject/events{/privacy}","received_events_url":"https://api.github.com/users/oaeproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oaeproject/3akai-ux","description":"Open Academic Environment (OAE) Front-End","fork":false,"url":"https://api.github.com/repos/oaeproject/3akai-ux","forks_url":"https://api.github.com/repos/oaeproject/3akai-ux/forks","keys_url":"https://api.github.com/repos/oaeproject/3akai-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaeproject/3akai-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaeproject/3akai-ux/teams","hooks_url":"https://api.github.com/repos/oaeproject/3akai-ux/hooks","issue_events_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/events{/number}","events_url":"https://api.github.com/repos/oaeproject/3akai-ux/events","assignees_url":"https://api.github.com/repos/oaeproject/3akai-ux/assignees{/user}","branches_url":"https://api.github.com/repos/oaeproject/3akai-ux/branches{/branch}","tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/tags","blobs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/oaeproject/3akai-ux/languages","stargazers_url":"https://api.github.com/repos/oaeproject/3akai-ux/stargazers","contributors_url":"https://api.github.com/repos/oaeproject/3akai-ux/contributors","subscribers_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscribers","subscription_url":"https://api.github.com/repos/oaeproject/3akai-ux/subscription","commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaeproject/3akai-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaeproject/3akai-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/oaeproject/3akai-ux/contents/{+path}","compare_url":"https://api.github.com/repos/oaeproject/3akai-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaeproject/3akai-ux/merges","archive_url":"https://api.github.com/repos/oaeproject/3akai-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaeproject/3akai-ux/downloads","issues_url":"https://api.github.com/repos/oaeproject/3akai-ux/issues{/number}","pulls_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/oaeproject/3akai-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/oaeproject/3akai-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaeproject/3akai-ux/labels{/name}","releases_url":"https://api.github.com/repos/oaeproject/3akai-ux/releases{/id}","created_at":"2010-07-07T12:48:50Z","updated_at":"2015-09-08T04:00:40Z","pushed_at":"2015-10-13T11:52:45Z","git_url":"git://github.com/oaeproject/3akai-ux.git","ssh_url":"git@github.com:oaeproject/3akai-ux.git","clone_url":"https://github.com/oaeproject/3akai-ux.git","svn_url":"https://github.com/oaeproject/3akai-ux","homepage":"http://www.oaeproject.org","size":174222,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"open_issues_count":65,"forks":223,"open_issues":65,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/4079"},"issue":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4079"},"comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/issues/4079/comments"},"review_comments":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079/comments"},"review_comment":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/4079/commits"},"statuses":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/statuses/f82ce6b38531a6753c53c6e20b3defc0038defd2"}}}}