{"action":"opened","number":483,"pull_request":{"url":"https://api.github.com/repos/kanaka/noVNC/pulls/483","id":34604532,"html_url":"https://github.com/kanaka/noVNC/pull/483","diff_url":"https://github.com/kanaka/noVNC/pull/483.diff","patch_url":"https://github.com/kanaka/noVNC/pull/483.patch","issue_url":"https://api.github.com/repos/kanaka/noVNC/issues/483","number":483,"state":"open","locked":false,"title":"Make noVNC compatible with Content Security Policies","user":{"login":"fabian-z","id":6495713,"avatar_url":"https://avatars.githubusercontent.com/u/6495713?v=3","gravatar_id":"","url":"https://api.github.com/users/fabian-z","html_url":"https://github.com/fabian-z","followers_url":"https://api.github.com/users/fabian-z/followers","following_url":"https://api.github.com/users/fabian-z/following{/other_user}","gists_url":"https://api.github.com/users/fabian-z/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian-z/subscriptions","organizations_url":"https://api.github.com/users/fabian-z/orgs","repos_url":"https://api.github.com/users/fabian-z/repos","events_url":"https://api.github.com/users/fabian-z/events{/privacy}","received_events_url":"https://api.github.com/users/fabian-z/received_events","type":"User","site_admin":false},"body":"This pull request simply moves the style and onsubmit declarations from #keyboardinput in vnc.html to base.css and ui.js, making it possible to use noVNC on mobile devices with an active Content Security Policy after these small changes.\r\n\r\nAn example policy header working with noVNC (note ws://127.0.0.1:8080 needs to be replaced with the scheme, host & port noVNC should connect to):\r\n\r\n```\r\ndefault-src 'none'; font-src 'self'; script-src 'self'; img-src 'self' data:; style-src 'self'; connect-src 'self' ws://127.0.0.1:8080;\r\n```\r\n\r\nI admit this is not terribly useful if noVNC should connect to different clients, but for integration into specific applications this may improve security, and the needed changes are not too big.\r\n","created_at":"2015-05-03T17:36:29Z","updated_at":"2015-05-03T17:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e41bf537fdc4c5758c4f17d05fab9410582fa5c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kanaka/noVNC/pulls/483/commits","review_comments_url":"https://api.github.com/repos/kanaka/noVNC/pulls/483/comments","review_comment_url":"https://api.github.com/repos/kanaka/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kanaka/noVNC/issues/483/comments","statuses_url":"https://api.github.com/repos/kanaka/noVNC/statuses/f083331cafa5e90ac41965b12df3b5f7432dbd29","head":{"label":"fabian-z:master","ref":"master","sha":"f083331cafa5e90ac41965b12df3b5f7432dbd29","user":{"login":"fabian-z","id":6495713,"avatar_url":"https://avatars.githubusercontent.com/u/6495713?v=3","gravatar_id":"","url":"https://api.github.com/users/fabian-z","html_url":"https://github.com/fabian-z","followers_url":"https://api.github.com/users/fabian-z/followers","following_url":"https://api.github.com/users/fabian-z/following{/other_user}","gists_url":"https://api.github.com/users/fabian-z/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian-z/subscriptions","organizations_url":"https://api.github.com/users/fabian-z/orgs","repos_url":"https://api.github.com/users/fabian-z/repos","events_url":"https://api.github.com/users/fabian-z/events{/privacy}","received_events_url":"https://api.github.com/users/fabian-z/received_events","type":"User","site_admin":false},"repo":{"id":34994293,"name":"noVNC","full_name":"fabian-z/noVNC","owner":{"login":"fabian-z","id":6495713,"avatar_url":"https://avatars.githubusercontent.com/u/6495713?v=3","gravatar_id":"","url":"https://api.github.com/users/fabian-z","html_url":"https://github.com/fabian-z","followers_url":"https://api.github.com/users/fabian-z/followers","following_url":"https://api.github.com/users/fabian-z/following{/other_user}","gists_url":"https://api.github.com/users/fabian-z/gists{/gist_id}","starred_url":"https://api.github.com/users/fabian-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabian-z/subscriptions","organizations_url":"https://api.github.com/users/fabian-z/orgs","repos_url":"https://api.github.com/users/fabian-z/repos","events_url":"https://api.github.com/users/fabian-z/events{/privacy}","received_events_url":"https://api.github.com/users/fabian-z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabian-z/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/fabian-z/noVNC","forks_url":"https://api.github.com/repos/fabian-z/noVNC/forks","keys_url":"https://api.github.com/repos/fabian-z/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabian-z/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabian-z/noVNC/teams","hooks_url":"https://api.github.com/repos/fabian-z/noVNC/hooks","issue_events_url":"https://api.github.com/repos/fabian-z/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/fabian-z/noVNC/events","assignees_url":"https://api.github.com/repos/fabian-z/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/fabian-z/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/fabian-z/noVNC/tags","blobs_url":"https://api.github.com/repos/fabian-z/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabian-z/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabian-z/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabian-z/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabian-z/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/fabian-z/noVNC/languages","stargazers_url":"https://api.github.com/repos/fabian-z/noVNC/stargazers","contributors_url":"https://api.github.com/repos/fabian-z/noVNC/contributors","subscribers_url":"https://api.github.com/repos/fabian-z/noVNC/subscribers","subscription_url":"https://api.github.com/repos/fabian-z/noVNC/subscription","commits_url":"https://api.github.com/repos/fabian-z/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabian-z/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabian-z/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabian-z/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabian-z/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/fabian-z/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabian-z/noVNC/merges","archive_url":"https://api.github.com/repos/fabian-z/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabian-z/noVNC/downloads","issues_url":"https://api.github.com/repos/fabian-z/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/fabian-z/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/fabian-z/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/fabian-z/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabian-z/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/fabian-z/noVNC/releases{/id}","created_at":"2015-05-03T17:26:29Z","updated_at":"2015-05-03T17:28:27Z","pushed_at":"2015-05-03T17:28:26Z","git_url":"git://github.com/fabian-z/noVNC.git","ssh_url":"git@github.com:fabian-z/noVNC.git","clone_url":"https://github.com/fabian-z/noVNC.git","svn_url":"https://github.com/fabian-z/noVNC","homepage":"novnc.com","size":13333,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kanaka:master","ref":"master","sha":"8ce27ddb4bb51e7e67bfac91505da73c22b09a79","user":{"login":"kanaka","id":70127,"avatar_url":"https://avatars.githubusercontent.com/u/70127?v=3","gravatar_id":"","url":"https://api.github.com/users/kanaka","html_url":"https://github.com/kanaka","followers_url":"https://api.github.com/users/kanaka/followers","following_url":"https://api.github.com/users/kanaka/following{/other_user}","gists_url":"https://api.github.com/users/kanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaka/subscriptions","organizations_url":"https://api.github.com/users/kanaka/orgs","repos_url":"https://api.github.com/users/kanaka/repos","events_url":"https://api.github.com/users/kanaka/events{/privacy}","received_events_url":"https://api.github.com/users/kanaka/received_events","type":"User","site_admin":false},"repo":{"id":598164,"name":"noVNC","full_name":"kanaka/noVNC","owner":{"login":"kanaka","id":70127,"avatar_url":"https://avatars.githubusercontent.com/u/70127?v=3","gravatar_id":"","url":"https://api.github.com/users/kanaka","html_url":"https://github.com/kanaka","followers_url":"https://api.github.com/users/kanaka/followers","following_url":"https://api.github.com/users/kanaka/following{/other_user}","gists_url":"https://api.github.com/users/kanaka/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaka/subscriptions","organizations_url":"https://api.github.com/users/kanaka/orgs","repos_url":"https://api.github.com/users/kanaka/repos","events_url":"https://api.github.com/users/kanaka/events{/privacy}","received_events_url":"https://api.github.com/users/kanaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanaka/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/kanaka/noVNC","forks_url":"https://api.github.com/repos/kanaka/noVNC/forks","keys_url":"https://api.github.com/repos/kanaka/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanaka/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanaka/noVNC/teams","hooks_url":"https://api.github.com/repos/kanaka/noVNC/hooks","issue_events_url":"https://api.github.com/repos/kanaka/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/kanaka/noVNC/events","assignees_url":"https://api.github.com/repos/kanaka/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/kanaka/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/kanaka/noVNC/tags","blobs_url":"https://api.github.com/repos/kanaka/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanaka/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanaka/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanaka/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanaka/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/kanaka/noVNC/languages","stargazers_url":"https://api.github.com/repos/kanaka/noVNC/stargazers","contributors_url":"https://api.github.com/repos/kanaka/noVNC/contributors","subscribers_url":"https://api.github.com/repos/kanaka/noVNC/subscribers","subscription_url":"https://api.github.com/repos/kanaka/noVNC/subscription","commits_url":"https://api.github.com/repos/kanaka/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanaka/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanaka/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanaka/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanaka/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/kanaka/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanaka/noVNC/merges","archive_url":"https://api.github.com/repos/kanaka/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanaka/noVNC/downloads","issues_url":"https://api.github.com/repos/kanaka/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/kanaka/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/kanaka/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/kanaka/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanaka/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/kanaka/noVNC/releases{/id}","created_at":"2010-04-07T01:55:44Z","updated_at":"2015-05-03T10:30:59Z","pushed_at":"2015-05-03T17:36:30Z","git_url":"git://github.com/kanaka/noVNC.git","ssh_url":"git@github.com:kanaka/noVNC.git","clone_url":"https://github.com/kanaka/noVNC.git","svn_url":"https://github.com/kanaka/noVNC","homepage":"novnc.com","size":13333,"stargazers_count":2098,"watchers_count":2098,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":372,"mirror_url":null,"open_issues_count":40,"forks":372,"open_issues":40,"watchers":2098,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/483"},"html":{"href":"https://github.com/kanaka/noVNC/pull/483"},"issue":{"href":"https://api.github.com/repos/kanaka/noVNC/issues/483"},"comments":{"href":"https://api.github.com/repos/kanaka/noVNC/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kanaka/noVNC/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/kanaka/noVNC/statuses/f083331cafa5e90ac41965b12df3b5f7432dbd29"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":2,"changed_files":3}}