{"action":"created","comment":{"url":"https://api.github.com/repos/endophage/gotuf/pulls/comments/34856070","id":34856070,"diff_hunk":"@@ -20,7 +20,13 @@ type KeyService interface {\n \t// the private key into the appropriate signing service.\n \t// The role isn't currently used for anything, but it's here to support\n \t// future features\n-\tCreate(role string, algorithm data.KeyAlgorithm) (*data.PublicKey, error)\n+\tCreate(role string, algorithm data.KeyAlgorithm) (data.Key, error)\n+\n+\t// GetKey retrieves the public key if present, otherwise it returns nil\n+\tGetKey(keyID string) data.Key\n+\n+\t// DeleteKey deletes the specified key\n+\tDeleteKey(keyID string) error","path":"signed/interface.go","position":11,"original_position":11,"commit_id":"4307ea26b7927692d9ba747753876160b36a4ca4","original_commit_id":"4307ea26b7927692d9ba747753876160b36a4ca4","user":{"login":"diogomonica","id":55332,"avatar_url":"https://avatars.githubusercontent.com/u/55332?v=3","gravatar_id":"","url":"https://api.github.com/users/diogomonica","html_url":"https://github.com/diogomonica","followers_url":"https://api.github.com/users/diogomonica/followers","following_url":"https://api.github.com/users/diogomonica/following{/other_user}","gists_url":"https://api.github.com/users/diogomonica/gists{/gist_id}","starred_url":"https://api.github.com/users/diogomonica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogomonica/subscriptions","organizations_url":"https://api.github.com/users/diogomonica/orgs","repos_url":"https://api.github.com/users/diogomonica/repos","events_url":"https://api.github.com/users/diogomonica/events{/privacy}","received_events_url":"https://api.github.com/users/diogomonica/received_events","type":"User","site_admin":false},"body":"Don't forget to rename this to Remove","created_at":"2015-07-17T01:36:50Z","updated_at":"2015-07-17T01:36:50Z","html_url":"https://github.com/endophage/gotuf/pull/18#discussion_r34856070","pull_request_url":"https://api.github.com/repos/endophage/gotuf/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/comments/34856070"},"html":{"href":"https://github.com/endophage/gotuf/pull/18#discussion_r34856070"},"pull_request":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/endophage/gotuf/pulls/18","id":40185845,"html_url":"https://github.com/endophage/gotuf/pull/18","diff_url":"https://github.com/endophage/gotuf/pull/18.diff","patch_url":"https://github.com/endophage/gotuf/pull/18.patch","issue_url":"https://api.github.com/repos/endophage/gotuf/issues/18","number":18,"state":"open","locked":false,"title":"Changes to support notary's unify-cryptoservice branch","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"body":"- Add RSAPKCS1v15Signature signature algorithm (for hardware signing)\r\n\r\n- Use data.Key interface more widely, to allow alternative key\r\n  implementations\r\n\r\n- Add additional functions to the CryptoService interface","created_at":"2015-07-16T23:06:32Z","updated_at":"2015-07-17T01:36:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1358a12142eea1bccdb341824c0a075fe590a0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/endophage/gotuf/pulls/18/commits","review_comments_url":"https://api.github.com/repos/endophage/gotuf/pulls/18/comments","review_comment_url":"https://api.github.com/repos/endophage/gotuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endophage/gotuf/issues/18/comments","statuses_url":"https://api.github.com/repos/endophage/gotuf/statuses/4307ea26b7927692d9ba747753876160b36a4ca4","head":{"label":"endophage:unify-cryptoservice","ref":"unify-cryptoservice","sha":"4307ea26b7927692d9ba747753876160b36a4ca4","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"repo":{"id":36679556,"name":"gotuf","full_name":"endophage/gotuf","owner":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endophage/gotuf","description":"This is a fully compliant implementation of the TUF specification. Heavily influenced by flynn/go-tuf and sharing some code.","fork":false,"url":"https://api.github.com/repos/endophage/gotuf","forks_url":"https://api.github.com/repos/endophage/gotuf/forks","keys_url":"https://api.github.com/repos/endophage/gotuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endophage/gotuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endophage/gotuf/teams","hooks_url":"https://api.github.com/repos/endophage/gotuf/hooks","issue_events_url":"https://api.github.com/repos/endophage/gotuf/issues/events{/number}","events_url":"https://api.github.com/repos/endophage/gotuf/events","assignees_url":"https://api.github.com/repos/endophage/gotuf/assignees{/user}","branches_url":"https://api.github.com/repos/endophage/gotuf/branches{/branch}","tags_url":"https://api.github.com/repos/endophage/gotuf/tags","blobs_url":"https://api.github.com/repos/endophage/gotuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endophage/gotuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endophage/gotuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/endophage/gotuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endophage/gotuf/statuses/{sha}","languages_url":"https://api.github.com/repos/endophage/gotuf/languages","stargazers_url":"https://api.github.com/repos/endophage/gotuf/stargazers","contributors_url":"https://api.github.com/repos/endophage/gotuf/contributors","subscribers_url":"https://api.github.com/repos/endophage/gotuf/subscribers","subscription_url":"https://api.github.com/repos/endophage/gotuf/subscription","commits_url":"https://api.github.com/repos/endophage/gotuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/endophage/gotuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/endophage/gotuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/endophage/gotuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/endophage/gotuf/contents/{+path}","compare_url":"https://api.github.com/repos/endophage/gotuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endophage/gotuf/merges","archive_url":"https://api.github.com/repos/endophage/gotuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endophage/gotuf/downloads","issues_url":"https://api.github.com/repos/endophage/gotuf/issues{/number}","pulls_url":"https://api.github.com/repos/endophage/gotuf/pulls{/number}","milestones_url":"https://api.github.com/repos/endophage/gotuf/milestones{/number}","notifications_url":"https://api.github.com/repos/endophage/gotuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endophage/gotuf/labels{/name}","releases_url":"https://api.github.com/repos/endophage/gotuf/releases{/id}","created_at":"2015-06-01T18:19:45Z","updated_at":"2015-06-01T18:27:18Z","pushed_at":"2015-07-17T00:57:51Z","git_url":"git://github.com/endophage/gotuf.git","ssh_url":"git@github.com:endophage/gotuf.git","clone_url":"https://github.com/endophage/gotuf.git","svn_url":"https://github.com/endophage/gotuf","homepage":null,"size":3320,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"endophage:master","ref":"master","sha":"70ebab1f4b2db4da78fab2a82e48ac0cf30bd136","user":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"repo":{"id":36679556,"name":"gotuf","full_name":"endophage/gotuf","owner":{"login":"endophage","id":1302091,"avatar_url":"https://avatars.githubusercontent.com/u/1302091?v=3","gravatar_id":"","url":"https://api.github.com/users/endophage","html_url":"https://github.com/endophage","followers_url":"https://api.github.com/users/endophage/followers","following_url":"https://api.github.com/users/endophage/following{/other_user}","gists_url":"https://api.github.com/users/endophage/gists{/gist_id}","starred_url":"https://api.github.com/users/endophage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endophage/subscriptions","organizations_url":"https://api.github.com/users/endophage/orgs","repos_url":"https://api.github.com/users/endophage/repos","events_url":"https://api.github.com/users/endophage/events{/privacy}","received_events_url":"https://api.github.com/users/endophage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endophage/gotuf","description":"This is a fully compliant implementation of the TUF specification. Heavily influenced by flynn/go-tuf and sharing some code.","fork":false,"url":"https://api.github.com/repos/endophage/gotuf","forks_url":"https://api.github.com/repos/endophage/gotuf/forks","keys_url":"https://api.github.com/repos/endophage/gotuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endophage/gotuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endophage/gotuf/teams","hooks_url":"https://api.github.com/repos/endophage/gotuf/hooks","issue_events_url":"https://api.github.com/repos/endophage/gotuf/issues/events{/number}","events_url":"https://api.github.com/repos/endophage/gotuf/events","assignees_url":"https://api.github.com/repos/endophage/gotuf/assignees{/user}","branches_url":"https://api.github.com/repos/endophage/gotuf/branches{/branch}","tags_url":"https://api.github.com/repos/endophage/gotuf/tags","blobs_url":"https://api.github.com/repos/endophage/gotuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endophage/gotuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endophage/gotuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/endophage/gotuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endophage/gotuf/statuses/{sha}","languages_url":"https://api.github.com/repos/endophage/gotuf/languages","stargazers_url":"https://api.github.com/repos/endophage/gotuf/stargazers","contributors_url":"https://api.github.com/repos/endophage/gotuf/contributors","subscribers_url":"https://api.github.com/repos/endophage/gotuf/subscribers","subscription_url":"https://api.github.com/repos/endophage/gotuf/subscription","commits_url":"https://api.github.com/repos/endophage/gotuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/endophage/gotuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/endophage/gotuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/endophage/gotuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/endophage/gotuf/contents/{+path}","compare_url":"https://api.github.com/repos/endophage/gotuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endophage/gotuf/merges","archive_url":"https://api.github.com/repos/endophage/gotuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endophage/gotuf/downloads","issues_url":"https://api.github.com/repos/endophage/gotuf/issues{/number}","pulls_url":"https://api.github.com/repos/endophage/gotuf/pulls{/number}","milestones_url":"https://api.github.com/repos/endophage/gotuf/milestones{/number}","notifications_url":"https://api.github.com/repos/endophage/gotuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endophage/gotuf/labels{/name}","releases_url":"https://api.github.com/repos/endophage/gotuf/releases{/id}","created_at":"2015-06-01T18:19:45Z","updated_at":"2015-06-01T18:27:18Z","pushed_at":"2015-07-17T00:57:51Z","git_url":"git://github.com/endophage/gotuf.git","ssh_url":"git@github.com:endophage/gotuf.git","clone_url":"https://github.com/endophage/gotuf.git","svn_url":"https://github.com/endophage/gotuf","homepage":null,"size":3320,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/18"},"html":{"href":"https://github.com/endophage/gotuf/pull/18"},"issue":{"href":"https://api.github.com/repos/endophage/gotuf/issues/18"},"comments":{"href":"https://api.github.com/repos/endophage/gotuf/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endophage/gotuf/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/endophage/gotuf/statuses/4307ea26b7927692d9ba747753876160b36a4ca4"}}}}