{"action":"created","issue":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1550","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1550/labels{/name}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1550/comments","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1550/events","html_url":"https://github.com/react-bootstrap/react-bootstrap/issues/1550","id":120770228,"number":1550,"title":"\"Cannot read property 'scrollHeight'\" error on resize after Modal unmount","user":{"login":"mjomble","id":2202751,"avatar_url":"https://avatars.githubusercontent.com/u/2202751?v=3","gravatar_id":"","url":"https://api.github.com/users/mjomble","html_url":"https://github.com/mjomble","followers_url":"https://api.github.com/users/mjomble/followers","following_url":"https://api.github.com/users/mjomble/following{/other_user}","gists_url":"https://api.github.com/users/mjomble/gists{/gist_id}","starred_url":"https://api.github.com/users/mjomble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjomble/subscriptions","organizations_url":"https://api.github.com/users/mjomble/orgs","repos_url":"https://api.github.com/users/mjomble/repos","events_url":"https://api.github.com/users/mjomble/events{/privacy}","received_events_url":"https://api.github.com/users/mjomble/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-07T13:08:56Z","updated_at":"2015-12-07T14:32:51Z","closed_at":"2015-12-07T14:32:51Z","body":"The error can be reproduced on this fiddle: https://jsfiddle.net/7vwzLjo2/\r\n\r\n`_onShow` sets up the resize handler and `_onHide` removes it, but if you unmount the Modal from the DOM after `_onShow`, the resize handler remains active and runs code that references `this._modal` which is now null.\r\n\r\nAdding a `componentWillUnmount` that removes the handler fixes the issue.\r\nI would've made a pull request, but wasn't sure if the rest of the `_onHide` code needs to run as well, etc."},"comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments/162541265","html_url":"https://github.com/react-bootstrap/react-bootstrap/issues/1550#issuecomment-162541265","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1550","id":162541265,"user":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T14:32:51Z","updated_at":"2015-12-07T14:32:51Z","body":"Dupe of https://github.com/react-bootstrap/react-bootstrap/issues/1538."}}