{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/comments/39122413","id":39122413,"diff_hunk":"@@ -53,9 +82,14 @@ define(\"ember-cli/test-loader\",\n       new TestLoader().loadModules();\n     };\n \n+    TestLoader.addModuleIncludeMatcher = addModuleIncludeMatcher;","path":"test-loader.js","position":51,"original_position":51,"commit_id":"ba78280e4d0c6c826416ed7ca7fd8a2f3b7a740b","original_commit_id":"ba78280e4d0c6c826416ed7ca7fd8a2f3b7a740b","user":{"login":"toddjordan","id":3609063,"avatar_url":"https://avatars.githubusercontent.com/u/3609063?v=3","gravatar_id":"","url":"https://api.github.com/users/toddjordan","html_url":"https://github.com/toddjordan","followers_url":"https://api.github.com/users/toddjordan/followers","following_url":"https://api.github.com/users/toddjordan/following{/other_user}","gists_url":"https://api.github.com/users/toddjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/toddjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddjordan/subscriptions","organizations_url":"https://api.github.com/users/toddjordan/orgs","repos_url":"https://api.github.com/users/toddjordan/repos","events_url":"https://api.github.com/users/toddjordan/events{/privacy}","received_events_url":"https://api.github.com/users/toddjordan/received_events","type":"User","site_admin":false},"body":"I guess adding it to TestLoader will save us a line of code on the other end, instead of setting the function to a separate variable off the module, we can just invoke it directly on TestLoader. (I'm talking about the other pull request: https://github.com/ember-cli/ember-cli-qunit/pull/77/files)","created_at":"2015-09-10T03:54:37Z","updated_at":"2015-09-10T03:54:37Z","html_url":"https://github.com/ember-cli/ember-cli-test-loader/pull/14#discussion_r39122413","pull_request_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/comments/39122413"},"html":{"href":"https://github.com/ember-cli/ember-cli-test-loader/pull/14#discussion_r39122413"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14","id":44623188,"html_url":"https://github.com/ember-cli/ember-cli-test-loader/pull/14","diff_url":"https://github.com/ember-cli/ember-cli-test-loader/pull/14.diff","patch_url":"https://github.com/ember-cli/ember-cli-test-loader/pull/14.patch","issue_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/14","number":14,"state":"open","locked":false,"title":"Allow additional matchers to be added without monkey patching prototype.","user":{"login":"rwjblue","id":12637,"avatar_url":"https://avatars.githubusercontent.com/u/12637?v=3","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"body":"Currently, `TestLoader.prototype.shouldLoadModule` is monkey patched by ember-cli-qunit / ember-cli-mocha to add their own custom rules for matching modules.\n\nThis change allows additional addons to add their own custom matchers (for example adding additional extension types) or to suppress a certain subset of modules (for example JSHint or JSCS tests).","created_at":"2015-09-10T02:53:56Z","updated_at":"2015-09-10T03:54:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22b8255fc02fdc2649b1aad5907acd487ae4bdb0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14/commits","review_comments_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14/comments","review_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/14/comments","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/statuses/ba78280e4d0c6c826416ed7ca7fd8a2f3b7a740b","head":{"label":"ember-cli:allow-additional-matchers","ref":"allow-additional-matchers","sha":"ba78280e4d0c6c826416ed7ca7fd8a2f3b7a740b","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":20378586,"name":"ember-cli-test-loader","full_name":"ember-cli/ember-cli-test-loader","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli-test-loader","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader","forks_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/releases{/id}","created_at":"2014-06-01T14:11:34Z","updated_at":"2015-04-15T17:36:53Z","pushed_at":"2015-09-10T02:53:57Z","git_url":"git://github.com/ember-cli/ember-cli-test-loader.git","ssh_url":"git@github.com:ember-cli/ember-cli-test-loader.git","clone_url":"https://github.com/ember-cli/ember-cli-test-loader.git","svn_url":"https://github.com/ember-cli/ember-cli-test-loader","homepage":"","size":272,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"6a0922054bc81765909c4113ce71a8e390db673f","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":20378586,"name":"ember-cli-test-loader","full_name":"ember-cli/ember-cli-test-loader","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars.githubusercontent.com/u/10262982?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/ember-cli-test-loader","description":"","fork":false,"url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader","forks_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/forks","keys_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/teams","hooks_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/events","assignees_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/tags","blobs_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/languages","stargazers_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/subscription","commits_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/merges","archive_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/downloads","issues_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/releases{/id}","created_at":"2014-06-01T14:11:34Z","updated_at":"2015-04-15T17:36:53Z","pushed_at":"2015-09-10T02:53:57Z","git_url":"git://github.com/ember-cli/ember-cli-test-loader.git","ssh_url":"git@github.com:ember-cli/ember-cli-test-loader.git","clone_url":"https://github.com/ember-cli/ember-cli-test-loader.git","svn_url":"https://github.com/ember-cli/ember-cli-test-loader","homepage":"","size":272,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14"},"html":{"href":"https://github.com/ember-cli/ember-cli-test-loader/pull/14"},"issue":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/14"},"comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/ember-cli-test-loader/statuses/ba78280e4d0c6c826416ed7ca7fd8a2f3b7a740b"}}}}