{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/6818","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6818/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6818/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6818/events","html_url":"https://github.com/mozilla/pdf.js/pull/6818","id":124211561,"number":6818,"title":"Make `hasHtml` true by default","user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-annotations","name":"4-annotations","color":"DDDDDD"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-29T13:32:16Z","updated_at":"2015-12-29T13:54:25Z","closed_at":"2015-12-29T13:54:25Z","pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/6818","html_url":"https://github.com/mozilla/pdf.js/pull/6818","diff_url":"https://github.com/mozilla/pdf.js/pull/6818.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/6818.patch"},"body":"Each annotation type has some kind of HTML element, so we make `hasHtml` default to true to avoid repeating this for each annotation type. Annotation types override this when necessary."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/167794696","html_url":"https://github.com/mozilla/pdf.js/pull/6818#issuecomment-167794696","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/6818","id":167794696,"user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars.githubusercontent.com/u/1993262?v=3","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T13:54:25Z","updated_at":"2015-12-29T13:54:25Z","body":"I found that this will not work because it makes unsupported annotations (that fall back to the base annotation rendering) also get `hasHtml` being true. This causes an error in the display layer as there is no associated annotation element. Therefore we need to postpone this change for now."}}