{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/47405655","id":47405655,"diff_hunk":"@@ -64,70 +64,71 @@\n import numpy as np\n import matplotlib.pyplot as plt\n \n-# Construct test image\n-\n+# Constructing test image.\n image = np.zeros((100, 100))\n-\n-\n-# Classic straight-line Hough transform\n-\n idx = np.arange(25, 75)\n image[idx[::-1], idx] = 255\n image[idx, idx] = 255\n \n+# Classic straight-line Hough transform.\n h, theta, d = hough_line(image)\n \n-fig, (ax1, ax2, ax3) = plt.subplots(1, 3, figsize=(8,4))\n+# Generating figure 1.\n+fig, (ax1, ax2, ax3) = plt.subplots(1, 3, figsize=(12, 6))\n+plt.tight_layout()\n \n-ax1.imshow(image, cmap=plt.cm.gray)\n+ax1.imshow(image, cmap=cm.gray)\n ax1.set_title('Input image')\n ax1.set_axis_off()\n \n-ax2.imshow(np.log(1 + h),\n-             extent=[np.rad2deg(theta[-1]), np.rad2deg(theta[0]),\n-                     d[-1], d[0]],\n-             cmap=plt.cm.gray, aspect=1/1.5)\n+ax2.imshow(np.log(1 + h), extent=[np.rad2deg(theta[-1]), np.rad2deg(theta[0]),\n+           d[-1], d[0]], cmap=cm.gray, aspect=1/1.5)\n ax2.set_title('Hough transform')\n ax2.set_xlabel('Angles (degrees)')\n ax2.set_ylabel('Distance (pixels)')\n ax2.axis('image')\n \n-ax3.imshow(image, cmap=plt.cm.gray)\n-rows, cols = image.shape\n+ax3.imshow(image, cmap=cm.gray)\n+row1, col1 = np.shape(image)","path":"doc/examples/plot_line_hough_transform.py","position":69,"original_position":69,"commit_id":"e18db6d091de594101c7287ff6ebcd742debb707","original_commit_id":"e18db6d091de594101c7287ff6ebcd742debb707","user":{"login":"emmanuelle","id":263366,"avatar_url":"https://avatars.githubusercontent.com/u/263366?v=3","gravatar_id":"","url":"https://api.github.com/users/emmanuelle","html_url":"https://github.com/emmanuelle","followers_url":"https://api.github.com/users/emmanuelle/followers","following_url":"https://api.github.com/users/emmanuelle/following{/other_user}","gists_url":"https://api.github.com/users/emmanuelle/gists{/gist_id}","starred_url":"https://api.github.com/users/emmanuelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmanuelle/subscriptions","organizations_url":"https://api.github.com/users/emmanuelle/orgs","repos_url":"https://api.github.com/users/emmanuelle/repos","events_url":"https://api.github.com/users/emmanuelle/events{/privacy}","received_events_url":"https://api.github.com/users/emmanuelle/received_events","type":"User","site_admin":false},"body":"I tend to prefer ``image.shape`` (the objected-oriented way of calling ``shape``) to ``np.shape(image)``. What was your reason for changing it?\r\n\r\nAlso, why did you change ``rows, cols``?","created_at":"2015-12-11T21:10:10Z","updated_at":"2015-12-11T21:10:10Z","html_url":"https://github.com/scikit-image/scikit-image/pull/1810#discussion_r47405655","pull_request_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810","_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/47405655"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/1810#discussion_r47405655"},"pull_request":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810","id":53329346,"html_url":"https://github.com/scikit-image/scikit-image/pull/1810","diff_url":"https://github.com/scikit-image/scikit-image/pull/1810.diff","patch_url":"https://github.com/scikit-image/scikit-image/pull/1810.patch","issue_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/1810","number":1810,"state":"open","locked":false,"title":"Solving white space + improving code +PEP8","user":{"login":"alexandrejaguar","id":5776022,"avatar_url":"https://avatars.githubusercontent.com/u/5776022?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrejaguar","html_url":"https://github.com/alexandrejaguar","followers_url":"https://api.github.com/users/alexandrejaguar/followers","following_url":"https://api.github.com/users/alexandrejaguar/following{/other_user}","gists_url":"https://api.github.com/users/alexandrejaguar/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrejaguar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrejaguar/subscriptions","organizations_url":"https://api.github.com/users/alexandrejaguar/orgs","repos_url":"https://api.github.com/users/alexandrejaguar/repos","events_url":"https://api.github.com/users/alexandrejaguar/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrejaguar/received_events","type":"User","site_admin":false},"body":"Hi everyone,\r\nplease check if this is you wanted.\r\nThank you very much.","created_at":"2015-12-10T22:49:45Z","updated_at":"2015-12-11T21:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1aac0724602f7dafa0ff74a410a79fd38f696e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810/commits","review_comments_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810/comments","review_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/1810/comments","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/e18db6d091de594101c7287ff6ebcd742debb707","head":{"label":"alexandrejaguar:master","ref":"master","sha":"e18db6d091de594101c7287ff6ebcd742debb707","user":{"login":"alexandrejaguar","id":5776022,"avatar_url":"https://avatars.githubusercontent.com/u/5776022?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrejaguar","html_url":"https://github.com/alexandrejaguar","followers_url":"https://api.github.com/users/alexandrejaguar/followers","following_url":"https://api.github.com/users/alexandrejaguar/following{/other_user}","gists_url":"https://api.github.com/users/alexandrejaguar/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrejaguar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrejaguar/subscriptions","organizations_url":"https://api.github.com/users/alexandrejaguar/orgs","repos_url":"https://api.github.com/users/alexandrejaguar/repos","events_url":"https://api.github.com/users/alexandrejaguar/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrejaguar/received_events","type":"User","site_admin":false},"repo":{"id":47785649,"name":"scikit-image","full_name":"alexandrejaguar/scikit-image","owner":{"login":"alexandrejaguar","id":5776022,"avatar_url":"https://avatars.githubusercontent.com/u/5776022?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandrejaguar","html_url":"https://github.com/alexandrejaguar","followers_url":"https://api.github.com/users/alexandrejaguar/followers","following_url":"https://api.github.com/users/alexandrejaguar/following{/other_user}","gists_url":"https://api.github.com/users/alexandrejaguar/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrejaguar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrejaguar/subscriptions","organizations_url":"https://api.github.com/users/alexandrejaguar/orgs","repos_url":"https://api.github.com/users/alexandrejaguar/repos","events_url":"https://api.github.com/users/alexandrejaguar/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrejaguar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexandrejaguar/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":true,"url":"https://api.github.com/repos/alexandrejaguar/scikit-image","forks_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/forks","keys_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/teams","hooks_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/events","assignees_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/tags","blobs_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/languages","stargazers_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/subscription","commits_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/merges","archive_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/downloads","issues_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/alexandrejaguar/scikit-image/releases{/id}","created_at":"2015-12-10T20:28:29Z","updated_at":"2015-12-10T20:28:31Z","pushed_at":"2015-12-10T23:52:53Z","git_url":"git://github.com/alexandrejaguar/scikit-image.git","ssh_url":"git@github.com:alexandrejaguar/scikit-image.git","clone_url":"https://github.com/alexandrejaguar/scikit-image.git","svn_url":"https://github.com/alexandrejaguar/scikit-image","homepage":"http://scikit-image.org","size":39903,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-image:master","ref":"master","sha":"966e0fd685babb39ce99e48f1512cb98134bd7ec","user":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"repo":{"id":2014929,"name":"scikit-image","full_name":"scikit-image/scikit-image","owner":{"login":"scikit-image","id":897180,"avatar_url":"https://avatars.githubusercontent.com/u/897180?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-image","html_url":"https://github.com/scikit-image","followers_url":"https://api.github.com/users/scikit-image/followers","following_url":"https://api.github.com/users/scikit-image/following{/other_user}","gists_url":"https://api.github.com/users/scikit-image/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-image/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-image/subscriptions","organizations_url":"https://api.github.com/users/scikit-image/orgs","repos_url":"https://api.github.com/users/scikit-image/repos","events_url":"https://api.github.com/users/scikit-image/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-image/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-image/scikit-image","description":"Image Processing SciKit (Toolbox for SciPy)","fork":false,"url":"https://api.github.com/repos/scikit-image/scikit-image","forks_url":"https://api.github.com/repos/scikit-image/scikit-image/forks","keys_url":"https://api.github.com/repos/scikit-image/scikit-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-image/scikit-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-image/scikit-image/teams","hooks_url":"https://api.github.com/repos/scikit-image/scikit-image/hooks","issue_events_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-image/scikit-image/events","assignees_url":"https://api.github.com/repos/scikit-image/scikit-image/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-image/scikit-image/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-image/scikit-image/tags","blobs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-image/scikit-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-image/scikit-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-image/scikit-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-image/scikit-image/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-image/scikit-image/languages","stargazers_url":"https://api.github.com/repos/scikit-image/scikit-image/stargazers","contributors_url":"https://api.github.com/repos/scikit-image/scikit-image/contributors","subscribers_url":"https://api.github.com/repos/scikit-image/scikit-image/subscribers","subscription_url":"https://api.github.com/repos/scikit-image/scikit-image/subscription","commits_url":"https://api.github.com/repos/scikit-image/scikit-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-image/scikit-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-image/scikit-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-image/scikit-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-image/scikit-image/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-image/scikit-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-image/scikit-image/merges","archive_url":"https://api.github.com/repos/scikit-image/scikit-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-image/scikit-image/downloads","issues_url":"https://api.github.com/repos/scikit-image/scikit-image/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-image/scikit-image/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-image/scikit-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-image/scikit-image/labels{/name}","releases_url":"https://api.github.com/repos/scikit-image/scikit-image/releases{/id}","created_at":"2011-07-07T22:07:20Z","updated_at":"2015-12-11T02:06:20Z","pushed_at":"2015-12-11T19:48:47Z","git_url":"git://github.com/scikit-image/scikit-image.git","ssh_url":"git@github.com:scikit-image/scikit-image.git","clone_url":"https://github.com/scikit-image/scikit-image.git","svn_url":"https://github.com/scikit-image/scikit-image","homepage":"http://scikit-image.org","size":65391,"stargazers_count":902,"watchers_count":902,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":460,"mirror_url":null,"open_issues_count":229,"forks":460,"open_issues":229,"watchers":902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/1810"},"issue":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/1810"},"comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/issues/1810/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/1810/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-image/scikit-image/statuses/e18db6d091de594101c7287ff6ebcd742debb707"}}}}