{"action":"closed","number":196,"pull_request":{"url":"https://api.github.com/repos/ndlib/sipity/pulls/196","id":30390191,"html_url":"https://github.com/ndlib/sipity/pull/196","diff_url":"https://github.com/ndlib/sipity/pull/196.diff","patch_url":"https://github.com/ndlib/sipity/pull/196.patch","issue_url":"https://api.github.com/repos/ndlib/sipity/issues/196","number":196,"state":"closed","locked":false,"title":"Working on accessible objects form","user":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars.githubusercontent.com/u/2130?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"body":"## Adjusting method signature\r\n\r\n@9a2bfa9f8d79399281efa2b9da4475b29f8f8c00\r\n\r\n\r\n## Including AttachmentQueries into query repository\r\n\r\n@f925c9f2985c2a95086e7af6ee36afec7374003a\r\n\r\nThis was an apparent oversight\r\n\r\n## Fixing a typo\r\n\r\n@595b3d08f59b1f77c9feaf32e65fb22e3bef916d\r\n\r\n[skip ci]\r\n\r\n## Adding AccessPolicyForm\r\n\r\n@af4fa27242aa8fb139899b7a603231818193375a\r\n\r\nResponsible for exposing a means for defining what are the access\r\ntypes.\r\n\r\n## Adding Attachment#to_s method\r\n\r\n@fec4efd085ac4cc5bc195466cac6a8e78695f366\r\n\r\nTo help with consistent rendering. I could be using an attachment\r\ndecorator.\r\n\r\n## Reworking spec definition\r\n\r\n@1c20df5becb14af2ae2aea3403b5a233d5a4b97e\r\n\r\n\r\n## Adding AttachmentQueries#accessible_objects\r\n\r\n@561da0f8c029fdce8d1009a8f9dc05bfbb90e30b\r\n\r\nIt removes some of the crazier conditionals that were in play.\r\n\r\n## Renaming object for clarity\r\n\r\n@1fc02063bd081aec28749eef23065ede4c476aee\r\n\r\n\r\n## Leveraging more consise method\r\n\r\n@a63fb9ed4aa374382a4756bdeb561f7d141b6a22\r\n\r\nInstead of relying on merging an array, push that idea down to the\r\nrepository.\r\n\r\n## Adding AccessibleObjectFromInput\r\n\r\n@f1b77294bb4aab0d282736baee4eae750aca1e52\r\n\r\n\r\n## Leveraging ExtractInputDateFromInput\r\n\r\n@6ccd9c394b442f9db1bdafc1b7fd21c32b1c8953\r\n\r\nBecause the method exists to handle either the complicated user input\r\nor the simple user input.\r\n\r\n## Exposing apply_access_policies_for command\r\n\r\n@88bf8ee057fff87937c8536d7cf837acdd0fa6a9\r\n\r\n\r\n## Exposing means of updating accessible objects\r\n\r\n@fef87fbdc3816eb5ac8383de3736196fd50f3af9\r\n\r\nThis is incomplete, in that we are capturing the form information and\r\nnot yet mapping it to the underlying layer. It also does not assume\r\nan unhappy path.\r\n\r\n## Tidying up method interface\r\n\r\n@51984e16866c1e34ebe36042d3b41bee5991b30b\r\n\r\n\r\n## Adding validation for AccessPolicyForm\r\n\r\n@4f0aab3b91363daa15be1e3046665a8217be4a11\r\n\r\n\r\n## Adjusting indices\r\n\r\n@d39839647229d311ab9560fa3ee46cb03840ecf3\r\n\r\nIt was a mistake that the access rights had a unique constraint on\r\nentity_id and entity_type; With that constraint, it was impossible to\r\nhave access policies change over time.\r\n\r\n## Adding Services::ApplyAccessPoliciesTo\r\n\r\n@b8f853cd8cb21721d53b10126b0cd6070502e8f5\r\n\r\n> Responsible for rebuilding access policies for accessible objects\r\n> associated with the given work.\r\n\r\n## Wiring in Services::ApplyAccessPoliciesTo\r\n\r\n@ca9c80101a3ed5626c6d81edd4eb234730f66f36\r\n\r\n\r\n## Extracting AccessRight::EMBARGO_THEN_OPEN_ACCESS\r\n\r\n@f41b8b32886644f68dafaf5cac973ab08c33bb8f\r\n\r\n> This is not a valid persisted access_right_code, but is something\r\n> that a user can specify via the UI.\r\n\r\nBy moving this to a constant, and in the same namespace, I keep a\r\nsymmetry in the method definition.\r\n\r\n## Removing repetition of knowledge\r\n\r\n@7c6b63a9be4c930447d2a403976b799004c464b8\r\n\r\nConcerning the access_right_codes, I'm opting to instead expose only\r\nmethods that are valid access_codes and how they are handled.\r\n\r\n## Appeasing the Rubocop\r\n\r\n@edc5ef0bb29119ac471134aac21c0fd9bff71d68\r\n\r\n\r\n## Adding Conversions::ConvertToDate\r\n\r\n@1db587386f0f04dfa07eb9f5dd725f76b9a9ee65\r\n\r\n\r\n## Splicing in usage of ConvertToDate\r\n\r\n@8f08cec42b2d4b135dbe57c8793f76a29c876b43\r\n\r\nInstead of duplicating this behavior, consolidating the conversion and\r\nreusing it.\r\n\r\n## Appeasing the hound\r\n\r\n@06f3616f071d54cadded3fe414250c8f649bd71f\r\n\r\n\r\n## Tidying up collaboration interaction\r\n\r\n@0e5e473d41cf430fe96d59a7b7e3d3c75ba8e7c0\r\n\r\n\r\n## Appeasing the hound\r\n\r\n@781c1dfe86ef5a213e55352da48eb36ca676506b\r\n","created_at":"2015-03-03T16:44:02Z","updated_at":"2015-03-03T17:24:09Z","closed_at":"2015-03-03T17:24:09Z","merged_at":null,"merge_commit_sha":"bf6d3e6afcc87032fa95c04d56ed15dc74d3ade8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/sipity/pulls/196/commits","review_comments_url":"https://api.github.com/repos/ndlib/sipity/pulls/196/comments","review_comment_url":"https://api.github.com/repos/ndlib/sipity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndlib/sipity/issues/196/comments","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/781c1dfe86ef5a213e55352da48eb36ca676506b","head":{"label":"ndlib:working-on-accessible-objects-form","ref":"working-on-accessible-objects-form","sha":"781c1dfe86ef5a213e55352da48eb36ca676506b","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":26916085,"name":"sipity","full_name":"ndlib/sipity","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/sipity","description":"Sipity is a patron-oriented deposit interface into CurateND.","fork":false,"url":"https://api.github.com/repos/ndlib/sipity","forks_url":"https://api.github.com/repos/ndlib/sipity/forks","keys_url":"https://api.github.com/repos/ndlib/sipity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/sipity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/sipity/teams","hooks_url":"https://api.github.com/repos/ndlib/sipity/hooks","issue_events_url":"https://api.github.com/repos/ndlib/sipity/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/sipity/events","assignees_url":"https://api.github.com/repos/ndlib/sipity/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/sipity/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/sipity/tags","blobs_url":"https://api.github.com/repos/ndlib/sipity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/sipity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/sipity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/sipity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/sipity/languages","stargazers_url":"https://api.github.com/repos/ndlib/sipity/stargazers","contributors_url":"https://api.github.com/repos/ndlib/sipity/contributors","subscribers_url":"https://api.github.com/repos/ndlib/sipity/subscribers","subscription_url":"https://api.github.com/repos/ndlib/sipity/subscription","commits_url":"https://api.github.com/repos/ndlib/sipity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/sipity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/sipity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/sipity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/sipity/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/sipity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/sipity/merges","archive_url":"https://api.github.com/repos/ndlib/sipity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/sipity/downloads","issues_url":"https://api.github.com/repos/ndlib/sipity/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/sipity/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/sipity/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/sipity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/sipity/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/sipity/releases{/id}","created_at":"2014-11-20T14:31:53Z","updated_at":"2015-03-03T01:50:48Z","pushed_at":"2015-03-03T17:16:26Z","git_url":"git://github.com/ndlib/sipity.git","ssh_url":"git@github.com:ndlib/sipity.git","clone_url":"https://github.com/ndlib/sipity.git","svn_url":"https://github.com/ndlib/sipity","homepage":"https://github.com/ndlib/sipity","size":9425,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"f0dbca1cc53eb1261ca62adbe3682c4b99feddaf","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":26916085,"name":"sipity","full_name":"ndlib/sipity","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/sipity","description":"Sipity is a patron-oriented deposit interface into CurateND.","fork":false,"url":"https://api.github.com/repos/ndlib/sipity","forks_url":"https://api.github.com/repos/ndlib/sipity/forks","keys_url":"https://api.github.com/repos/ndlib/sipity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/sipity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/sipity/teams","hooks_url":"https://api.github.com/repos/ndlib/sipity/hooks","issue_events_url":"https://api.github.com/repos/ndlib/sipity/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/sipity/events","assignees_url":"https://api.github.com/repos/ndlib/sipity/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/sipity/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/sipity/tags","blobs_url":"https://api.github.com/repos/ndlib/sipity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/sipity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/sipity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/sipity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/sipity/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/sipity/languages","stargazers_url":"https://api.github.com/repos/ndlib/sipity/stargazers","contributors_url":"https://api.github.com/repos/ndlib/sipity/contributors","subscribers_url":"https://api.github.com/repos/ndlib/sipity/subscribers","subscription_url":"https://api.github.com/repos/ndlib/sipity/subscription","commits_url":"https://api.github.com/repos/ndlib/sipity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/sipity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/sipity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/sipity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/sipity/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/sipity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/sipity/merges","archive_url":"https://api.github.com/repos/ndlib/sipity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/sipity/downloads","issues_url":"https://api.github.com/repos/ndlib/sipity/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/sipity/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/sipity/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/sipity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/sipity/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/sipity/releases{/id}","created_at":"2014-11-20T14:31:53Z","updated_at":"2015-03-03T01:50:48Z","pushed_at":"2015-03-03T17:16:26Z","git_url":"git://github.com/ndlib/sipity.git","ssh_url":"git@github.com:ndlib/sipity.git","clone_url":"https://github.com/ndlib/sipity.git","svn_url":"https://github.com/ndlib/sipity","homepage":"https://github.com/ndlib/sipity","size":9425,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/196"},"html":{"href":"https://github.com/ndlib/sipity/pull/196"},"issue":{"href":"https://api.github.com/repos/ndlib/sipity/issues/196"},"comments":{"href":"https://api.github.com/repos/ndlib/sipity/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndlib/sipity/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/sipity/statuses/781c1dfe86ef5a213e55352da48eb36ca676506b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":26,"additions":604,"deletions":24,"changed_files":23}}