{"action":"created","comment":{"url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments/37088733","id":37088733,"diff_hunk":"@@ -0,0 +1,70 @@\n+module CC\n+  module Analyzer\n+    class Container\n+      TIMEOUT = 15 * 60 # 15m\n+\n+      def initialize(image, command = nil, log = nil)\n+        @image = image\n+        @command = command\n+        @log = log || NullContainerLog.new\n+\n+        @output_delimeter = \"\\n\"\n+        @on_output = ->(*)","path":"lib/cc/analyzer/container.rb","position":12,"original_position":12,"commit_id":"81fd528dd70cee9e1d973edb2e69d56829cf0720","original_commit_id":"81fd528dd70cee9e1d973edb2e69d56829cf0720","user":{"login":"pbrisbin","id":50812,"avatar_url":"https://avatars.githubusercontent.com/u/50812?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrisbin","html_url":"https://github.com/pbrisbin","followers_url":"https://api.github.com/users/pbrisbin/followers","following_url":"https://api.github.com/users/pbrisbin/following{/other_user}","gists_url":"https://api.github.com/users/pbrisbin/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrisbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrisbin/subscriptions","organizations_url":"https://api.github.com/users/pbrisbin/orgs","repos_url":"https://api.github.com/users/pbrisbin/repos","events_url":"https://api.github.com/users/pbrisbin/events{/privacy}","received_events_url":"https://api.github.com/users/pbrisbin/received_events","type":"User","site_admin":false},"body":"Should be `->(*) { }` basically a no-op default.","created_at":"2015-08-14T15:39:39Z","updated_at":"2015-08-14T15:39:39Z","html_url":"https://github.com/codeclimate/codeclimate/pull/89#discussion_r37088733","pull_request_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments/37088733"},"html":{"href":"https://github.com/codeclimate/codeclimate/pull/89#discussion_r37088733"},"pull_request":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89","id":42468586,"html_url":"https://github.com/codeclimate/codeclimate/pull/89","diff_url":"https://github.com/codeclimate/codeclimate/pull/89.diff","patch_url":"https://github.com/codeclimate/codeclimate/pull/89.patch","issue_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/89","number":89,"state":"open","locked":false,"title":"WIP: Sketch for improving Engine","user":{"login":"pbrisbin","id":50812,"avatar_url":"https://avatars.githubusercontent.com/u/50812?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrisbin","html_url":"https://github.com/pbrisbin","followers_url":"https://api.github.com/users/pbrisbin/followers","following_url":"https://api.github.com/users/pbrisbin/following{/other_user}","gists_url":"https://api.github.com/users/pbrisbin/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrisbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrisbin/subscriptions","organizations_url":"https://api.github.com/users/pbrisbin/orgs","repos_url":"https://api.github.com/users/pbrisbin/repos","events_url":"https://api.github.com/users/pbrisbin/events{/privacy}","received_events_url":"https://api.github.com/users/pbrisbin/received_events","type":"User","site_admin":false},"body":"/cc @codeclimate/review\n\nThis is as sketch. It's built on top of pb-container-log. If we think this is a\ngood direction, I'll wait for that to merge and open a new PR from this branch\nafter rebasing, adding/fixing tests etc.\n\n---\n\nNew responsibility breakdown:\n\n**Container**: launch a docker container, give its stdout to the caller,\ncapture its stderr, monitor its process, handle timeouts, call life-cycle\nevents on the container-log given.\n\n**Engine::ContainerLog**: perform the statsd calls on container life-cycle\nevents and then forward those events to the log its been given; sort of a\nContainerLog middleware stack idea.\n\n**Engine**: launch and run a Container for the engine, specify how to shuttle\nnull-delimited stdout to the formatter, compose its container-log with the one\ngiven.\n\nBenefits:\n\n- Engine is smaller, more focused\n- Container is reusable for Clone in builder\n- Container is easier to reason about (i.e. the complex timeout logic is\n  clearer IMO)\n\nNotable change:\n\nRather than spawning `docker kill` I'm using Ruby's `Process.kill`, the two\nshould be equivalent and this was more convenient with the way the code is now\n(e.g. no need to track container-name).","created_at":"2015-08-14T15:38:23Z","updated_at":"2015-08-14T15:39:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"262d8b21ce4c8cbf304a2992d3220dc4078cbe0d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89/commits","review_comments_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89/comments","review_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/89/comments","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/81fd528dd70cee9e1d973edb2e69d56829cf0720","head":{"label":"codeclimate:pb-container","ref":"pb-container","sha":"81fd528dd70cee9e1d973edb2e69d56829cf0720","user":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":37724576,"name":"codeclimate","full_name":"codeclimate/codeclimate","owner":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeclimate/codeclimate","description":"Code Climate CLI","fork":false,"url":"https://api.github.com/repos/codeclimate/codeclimate","forks_url":"https://api.github.com/repos/codeclimate/codeclimate/forks","keys_url":"https://api.github.com/repos/codeclimate/codeclimate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeclimate/codeclimate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeclimate/codeclimate/teams","hooks_url":"https://api.github.com/repos/codeclimate/codeclimate/hooks","issue_events_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/events{/number}","events_url":"https://api.github.com/repos/codeclimate/codeclimate/events","assignees_url":"https://api.github.com/repos/codeclimate/codeclimate/assignees{/user}","branches_url":"https://api.github.com/repos/codeclimate/codeclimate/branches{/branch}","tags_url":"https://api.github.com/repos/codeclimate/codeclimate/tags","blobs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeclimate/codeclimate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeclimate/codeclimate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/{sha}","languages_url":"https://api.github.com/repos/codeclimate/codeclimate/languages","stargazers_url":"https://api.github.com/repos/codeclimate/codeclimate/stargazers","contributors_url":"https://api.github.com/repos/codeclimate/codeclimate/contributors","subscribers_url":"https://api.github.com/repos/codeclimate/codeclimate/subscribers","subscription_url":"https://api.github.com/repos/codeclimate/codeclimate/subscription","commits_url":"https://api.github.com/repos/codeclimate/codeclimate/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeclimate/codeclimate/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeclimate/codeclimate/contents/{+path}","compare_url":"https://api.github.com/repos/codeclimate/codeclimate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeclimate/codeclimate/merges","archive_url":"https://api.github.com/repos/codeclimate/codeclimate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeclimate/codeclimate/downloads","issues_url":"https://api.github.com/repos/codeclimate/codeclimate/issues{/number}","pulls_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls{/number}","milestones_url":"https://api.github.com/repos/codeclimate/codeclimate/milestones{/number}","notifications_url":"https://api.github.com/repos/codeclimate/codeclimate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeclimate/codeclimate/labels{/name}","releases_url":"https://api.github.com/repos/codeclimate/codeclimate/releases{/id}","created_at":"2015-06-19T13:54:41Z","updated_at":"2015-08-14T13:00:01Z","pushed_at":"2015-08-14T15:38:24Z","git_url":"git://github.com/codeclimate/codeclimate.git","ssh_url":"git@github.com:codeclimate/codeclimate.git","clone_url":"https://github.com/codeclimate/codeclimate.git","svn_url":"https://github.com/codeclimate/codeclimate","homepage":null,"size":1174,"stargazers_count":443,"watchers_count":443,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":17,"forks":29,"open_issues":17,"watchers":443,"default_branch":"master"}},"base":{"label":"codeclimate:pb-container-log","ref":"pb-container-log","sha":"4aa15a3b218b9f45073c16b7e4f25c553721725f","user":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"repo":{"id":37724576,"name":"codeclimate","full_name":"codeclimate/codeclimate","owner":{"login":"codeclimate","id":789641,"avatar_url":"https://avatars.githubusercontent.com/u/789641?v=3","gravatar_id":"","url":"https://api.github.com/users/codeclimate","html_url":"https://github.com/codeclimate","followers_url":"https://api.github.com/users/codeclimate/followers","following_url":"https://api.github.com/users/codeclimate/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate/subscriptions","organizations_url":"https://api.github.com/users/codeclimate/orgs","repos_url":"https://api.github.com/users/codeclimate/repos","events_url":"https://api.github.com/users/codeclimate/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeclimate/codeclimate","description":"Code Climate CLI","fork":false,"url":"https://api.github.com/repos/codeclimate/codeclimate","forks_url":"https://api.github.com/repos/codeclimate/codeclimate/forks","keys_url":"https://api.github.com/repos/codeclimate/codeclimate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeclimate/codeclimate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeclimate/codeclimate/teams","hooks_url":"https://api.github.com/repos/codeclimate/codeclimate/hooks","issue_events_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/events{/number}","events_url":"https://api.github.com/repos/codeclimate/codeclimate/events","assignees_url":"https://api.github.com/repos/codeclimate/codeclimate/assignees{/user}","branches_url":"https://api.github.com/repos/codeclimate/codeclimate/branches{/branch}","tags_url":"https://api.github.com/repos/codeclimate/codeclimate/tags","blobs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeclimate/codeclimate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeclimate/codeclimate/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeclimate/codeclimate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeclimate/codeclimate/statuses/{sha}","languages_url":"https://api.github.com/repos/codeclimate/codeclimate/languages","stargazers_url":"https://api.github.com/repos/codeclimate/codeclimate/stargazers","contributors_url":"https://api.github.com/repos/codeclimate/codeclimate/contributors","subscribers_url":"https://api.github.com/repos/codeclimate/codeclimate/subscribers","subscription_url":"https://api.github.com/repos/codeclimate/codeclimate/subscription","commits_url":"https://api.github.com/repos/codeclimate/codeclimate/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeclimate/codeclimate/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeclimate/codeclimate/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeclimate/codeclimate/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeclimate/codeclimate/contents/{+path}","compare_url":"https://api.github.com/repos/codeclimate/codeclimate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeclimate/codeclimate/merges","archive_url":"https://api.github.com/repos/codeclimate/codeclimate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeclimate/codeclimate/downloads","issues_url":"https://api.github.com/repos/codeclimate/codeclimate/issues{/number}","pulls_url":"https://api.github.com/repos/codeclimate/codeclimate/pulls{/number}","milestones_url":"https://api.github.com/repos/codeclimate/codeclimate/milestones{/number}","notifications_url":"https://api.github.com/repos/codeclimate/codeclimate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeclimate/codeclimate/labels{/name}","releases_url":"https://api.github.com/repos/codeclimate/codeclimate/releases{/id}","created_at":"2015-06-19T13:54:41Z","updated_at":"2015-08-14T13:00:01Z","pushed_at":"2015-08-14T15:38:24Z","git_url":"git://github.com/codeclimate/codeclimate.git","ssh_url":"git@github.com:codeclimate/codeclimate.git","clone_url":"https://github.com/codeclimate/codeclimate.git","svn_url":"https://github.com/codeclimate/codeclimate","homepage":null,"size":1174,"stargazers_count":443,"watchers_count":443,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":17,"forks":29,"open_issues":17,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89"},"html":{"href":"https://github.com/codeclimate/codeclimate/pull/89"},"issue":{"href":"https://api.github.com/repos/codeclimate/codeclimate/issues/89"},"comments":{"href":"https://api.github.com/repos/codeclimate/codeclimate/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeclimate/codeclimate/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/codeclimate/codeclimate/statuses/81fd528dd70cee9e1d973edb2e69d56829cf0720"}}}}