{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15510","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15510/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15510/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15510/events","html_url":"https://github.com/kubernetes/kubernetes/pull/15510","id":111073808,"number":15510,"title":"Addresses issue #6596.","user":{"login":"aveshagarwal","id":3596412,"avatar_url":"https://avatars.githubusercontent.com/u/3596412?v=3","gravatar_id":"","url":"https://api.github.com/users/aveshagarwal","html_url":"https://github.com/aveshagarwal","followers_url":"https://api.github.com/users/aveshagarwal/followers","following_url":"https://api.github.com/users/aveshagarwal/following{/other_user}","gists_url":"https://api.github.com/users/aveshagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/aveshagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aveshagarwal/subscriptions","organizations_url":"https://api.github.com/users/aveshagarwal/orgs","repos_url":"https://api.github.com/users/aveshagarwal/repos","events_url":"https://api.github.com/users/aveshagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/aveshagarwal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-merge","name":"needs-ok-to-merge","color":"ededed"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-10-12T23:25:06Z","updated_at":"2015-10-24T21:24:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15510","html_url":"https://github.com/kubernetes/kubernetes/pull/15510","diff_url":"https://github.com/kubernetes/kubernetes/pull/15510.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/15510.patch"},"body":"Addresses issue #6596.\r\nRemoves ForTesting_ReferencesAllowBlankSelfLinks.\r\nFixes controller's persistentvolumes unit tests."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/150852473","html_url":"https://github.com/kubernetes/kubernetes/pull/15510#issuecomment-150852473","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15510","id":150852473,"user":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"created_at":"2015-10-24T21:24:51Z","updated_at":"2015-10-24T21:24:51Z","body":"Here is my current understanding of the main objectives of the original issue and what their status is today:\r\n\r\n1.  _Make a `selfLink` required for objects that should have one_ -- all objects should have selfLinks in the context of kubelet / controller.\r\n2.  _Have an officially sanctioned way to indicate that an object necessarily does not have a `selfLink` or to assign a dummy one -- possibly as a sibling to `testapi.SelfLink`_ -- `testapi.Default.SelfLink` is that way\r\n3.  _Remove the `ForTesting_ReferencesAllowBlankSelfLinks` flag from the API package_ -- done in this PR\r\n4.  _Make all tests set `selfLinks` correctly using `testapi.SelfLink`_ -- done in this PR, though `testapi.Default.SelfLink` is the function being used (which is correct)\r\n\r\n@lavalamp @derekwaynecarr You guys are also familiar w/ this area of the code -- have we missed anything?\r\n"}}