{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/29384142","id":29384142,"diff_hunk":"@@ -50,27 +50,22 @@ module.exports = function(config) {\n   config.set({\n     basePath: '',\n \n-    frameworks: ['browserify', 'qunit'],\n+    frameworks: ['qunit'],\n \n     autoWatch: false,\n \n     singleRun: true,\n \n     files: [\n+      // include and execute the standalone test bundle first\n+      '../build/temp/tests.js',\n+\n+      // then include video.js through globals to run the API tests\n       '../build/temp/video-js.min.css',\n       '../build/temp/video.min.js',\n-      '../build/temp/tests.js',\n+      'api/api.js'\n     ],\n \n-    preprocessors: {\n-      '../test/unit/**/*.js': [ 'browserify' ]\n-    },\n-\n-    browserify: {\n-      debug: true,\n-      transform: [ 'babelify', 'browserify-istanbul' ]","path":"test/karma.conf.js","position":28,"original_position":28,"commit_id":"3dee6725acf9efcaac70e291a3e8c0b22c6cfec8","original_commit_id":"3dee6725acf9efcaac70e291a3e8c0b22c6cfec8","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"Does removing istanbul kill something we need for coverage? (@mmcc)","created_at":"2015-04-29T21:41:49Z","updated_at":"2015-04-29T21:41:49Z","html_url":"https://github.com/videojs/video.js/pull/2098#discussion_r29384142","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2098","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/29384142"},"html":{"href":"https://github.com/videojs/video.js/pull/2098#discussion_r29384142"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2098"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2098","id":34408913,"html_url":"https://github.com/videojs/video.js/pull/2098","diff_url":"https://github.com/videojs/video.js/pull/2098.diff","patch_url":"https://github.com/videojs/video.js/pull/2098.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2098","number":2098,"state":"open","locked":false,"title":"Grunt improvements","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"body":"Get test/index.html working when loaded directly into a browser. Remove extra browserifying via karma. Add timing info to to grunt output.","created_at":"2015-04-29T21:38:40Z","updated_at":"2015-04-29T21:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb8911b8362ce8113e93ad259f175197b5cb9e0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2098/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2098/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2098/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/3dee6725acf9efcaac70e291a3e8c0b22c6cfec8","head":{"label":"dmlap:test-and-build-improvements","ref":"test-and-build-improvements","sha":"3dee6725acf9efcaac70e291a3e8c0b22c6cfec8","user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"repo":{"id":7782368,"name":"video.js","full_name":"dmlap/video.js","owner":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmlap/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/dmlap/video.js","forks_url":"https://api.github.com/repos/dmlap/video.js/forks","keys_url":"https://api.github.com/repos/dmlap/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlap/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlap/video.js/teams","hooks_url":"https://api.github.com/repos/dmlap/video.js/hooks","issue_events_url":"https://api.github.com/repos/dmlap/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/dmlap/video.js/events","assignees_url":"https://api.github.com/repos/dmlap/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/dmlap/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/dmlap/video.js/tags","blobs_url":"https://api.github.com/repos/dmlap/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlap/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlap/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlap/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlap/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlap/video.js/languages","stargazers_url":"https://api.github.com/repos/dmlap/video.js/stargazers","contributors_url":"https://api.github.com/repos/dmlap/video.js/contributors","subscribers_url":"https://api.github.com/repos/dmlap/video.js/subscribers","subscription_url":"https://api.github.com/repos/dmlap/video.js/subscription","commits_url":"https://api.github.com/repos/dmlap/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlap/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlap/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlap/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlap/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/dmlap/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlap/video.js/merges","archive_url":"https://api.github.com/repos/dmlap/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlap/video.js/downloads","issues_url":"https://api.github.com/repos/dmlap/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/dmlap/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlap/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlap/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlap/video.js/labels{/name}","releases_url":"https://api.github.com/repos/dmlap/video.js/releases{/id}","created_at":"2013-01-23T19:48:25Z","updated_at":"2015-04-29T21:07:18Z","pushed_at":"2015-04-29T21:39:21Z","git_url":"git://github.com/dmlap/video.js.git","ssh_url":"git@github.com:dmlap/video.js.git","clone_url":"https://github.com/dmlap/video.js.git","svn_url":"https://github.com/dmlap/video.js","homepage":"videojs.com","size":15299,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"b5968f13e2f6b7147d683ba4d3232c4fa03d98ad","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-04-29T21:05:32Z","pushed_at":"2015-04-29T21:38:40Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":24793,"stargazers_count":8729,"watchers_count":8729,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2406,"mirror_url":null,"open_issues_count":191,"forks":2406,"open_issues":191,"watchers":8729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2098"},"html":{"href":"https://github.com/videojs/video.js/pull/2098"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2098"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2098/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2098/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2098/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/3dee6725acf9efcaac70e291a3e8c0b22c6cfec8"}}}}