{"action":"created","issue":{"url":"https://api.github.com/repos/nathamanath/URI.js/issues/2","labels_url":"https://api.github.com/repos/nathamanath/URI.js/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/nathamanath/URI.js/issues/2/comments","events_url":"https://api.github.com/repos/nathamanath/URI.js/issues/2/events","html_url":"https://github.com/nathamanath/URI.js/issues/2","id":84802818,"number":2,"title":"Values with ampersand break parseParams","user":{"login":"cshold","id":1730309,"avatar_url":"https://avatars.githubusercontent.com/u/1730309?v=3","gravatar_id":"","url":"https://api.github.com/users/cshold","html_url":"https://github.com/cshold","followers_url":"https://api.github.com/users/cshold/followers","following_url":"https://api.github.com/users/cshold/following{/other_user}","gists_url":"https://api.github.com/users/cshold/gists{/gist_id}","starred_url":"https://api.github.com/users/cshold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshold/subscriptions","organizations_url":"https://api.github.com/users/cshold/orgs","repos_url":"https://api.github.com/users/cshold/repos","events_url":"https://api.github.com/users/cshold/events{/privacy}","received_events_url":"https://api.github.com/users/cshold/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nathamanath/URI.js/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-03T22:45:29Z","updated_at":"2015-10-23T13:25:16Z","closed_at":null,"body":"Hey, solid plugin. Parameters that have ampersands in them — eg. `category=Big%20&%20Tall` in the URL — cause `Cannot read property 'match' of undefined` from `valueType`'s first `match` conditional.\r\n\r\nLooks like the root cause is `params = search.split('&');` in `parseParams`, as it doesn't take into account any other possible ampersands."},"comment":{"url":"https://api.github.com/repos/nathamanath/URI.js/issues/comments/150569889","html_url":"https://github.com/nathamanath/URI.js/issues/2#issuecomment-150569889","issue_url":"https://api.github.com/repos/nathamanath/URI.js/issues/2","id":150569889,"user":{"login":"nathamanath","id":2699713,"avatar_url":"https://avatars.githubusercontent.com/u/2699713?v=3","gravatar_id":"","url":"https://api.github.com/users/nathamanath","html_url":"https://github.com/nathamanath","followers_url":"https://api.github.com/users/nathamanath/followers","following_url":"https://api.github.com/users/nathamanath/following{/other_user}","gists_url":"https://api.github.com/users/nathamanath/gists{/gist_id}","starred_url":"https://api.github.com/users/nathamanath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathamanath/subscriptions","organizations_url":"https://api.github.com/users/nathamanath/orgs","repos_url":"https://api.github.com/users/nathamanath/repos","events_url":"https://api.github.com/users/nathamanath/events{/privacy}","received_events_url":"https://api.github.com/users/nathamanath/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T13:25:16Z","updated_at":"2015-10-23T13:25:16Z","body":"Hi, sorry for the slow response on this I completely missed the notification email!\r\n\r\nInteresting, I guess to achieve this we would split the search string based on a regex... So split only on ampersands which are followed by an ampersand-free string and then an equals.\r\n\r\nThanks for the bug report :) Ill have a look at it"}}