{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/32694231","id":32694231,"diff_hunk":"@@ -4236,7 +4230,6 @@ def put(self, indices, values, mode='raise'):\n         if m is nomask:\n             m = getmask(values)\n         else:\n-            m = m.copy()","path":"numpy/ma/core.py","position":24,"original_position":24,"commit_id":"4bda89f5ad429e1b76f5d9df1ed74de8c1d7b90d","original_commit_id":"4bda89f5ad429e1b76f5d9df1ed74de8c1d7b90d","user":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"I was questioning the removal of `m.copy`. I assume this is becase `m` is shared. BTW, cannot this now be written\r\n```\r\nif m is nomask:\r\n    blaj\r\nelif getmask(values) is nomask:\r\n    blah\r\nelse:\r\n    blah\r\n```","created_at":"2015-06-18T02:10:41Z","updated_at":"2015-06-18T02:10:41Z","html_url":"https://github.com/numpy/numpy/pull/5580#discussion_r32694231","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/5580","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/32694231"},"html":{"href":"https://github.com/numpy/numpy/pull/5580#discussion_r32694231"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5580"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/5580","id":29500642,"html_url":"https://github.com/numpy/numpy/pull/5580","diff_url":"https://github.com/numpy/numpy/pull/5580.diff","patch_url":"https://github.com/numpy/numpy/pull/5580.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/5580","number":5580,"state":"open","locked":false,"title":"BUG: Fix masked arrays to properly edit views. ( #5558 )","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"body":"A detailed description of the bug is available at issue https://github.com/numpy/numpy/issues/5558. In short, when changing a view of a masked array, the data is properly propagated to the original, but changes to the mask are not. This pull request attempts to address this by ensuring the mask will also be properly altered.","created_at":"2015-02-18T04:30:50Z","updated_at":"2015-06-18T02:10:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb0cfe3c2d5a374980ca0ceb7a92e15e3cccd3f5","assignee":null,"milestone":{"url":"https://api.github.com/repos/numpy/numpy/milestones/35","html_url":"https://github.com/numpy/numpy/milestones/1.10.0%20release","labels_url":"https://api.github.com/repos/numpy/numpy/milestones/35/labels","id":1055363,"number":35,"title":"1.10.0 release","description":"Marker for PRs that should go into Numpy 1.10.1.","creator":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":45,"state":"open","created_at":"2015-04-07T00:02:10Z","updated_at":"2015-06-17T21:11:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/5580/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/5580/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/5580/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/4bda89f5ad429e1b76f5d9df1ed74de8c1d7b90d","head":{"label":"jakirkham:fix_masked_array_views","ref":"fix_masked_array_views","sha":"4bda89f5ad429e1b76f5d9df1ed74de8c1d7b90d","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"repo":{"id":30688596,"name":"numpy","full_name":"jakirkham/numpy","owner":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakirkham/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/jakirkham/numpy","forks_url":"https://api.github.com/repos/jakirkham/numpy/forks","keys_url":"https://api.github.com/repos/jakirkham/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakirkham/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakirkham/numpy/teams","hooks_url":"https://api.github.com/repos/jakirkham/numpy/hooks","issue_events_url":"https://api.github.com/repos/jakirkham/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/jakirkham/numpy/events","assignees_url":"https://api.github.com/repos/jakirkham/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/jakirkham/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/jakirkham/numpy/tags","blobs_url":"https://api.github.com/repos/jakirkham/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakirkham/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakirkham/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakirkham/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakirkham/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/jakirkham/numpy/languages","stargazers_url":"https://api.github.com/repos/jakirkham/numpy/stargazers","contributors_url":"https://api.github.com/repos/jakirkham/numpy/contributors","subscribers_url":"https://api.github.com/repos/jakirkham/numpy/subscribers","subscription_url":"https://api.github.com/repos/jakirkham/numpy/subscription","commits_url":"https://api.github.com/repos/jakirkham/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakirkham/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakirkham/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakirkham/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakirkham/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/jakirkham/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakirkham/numpy/merges","archive_url":"https://api.github.com/repos/jakirkham/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakirkham/numpy/downloads","issues_url":"https://api.github.com/repos/jakirkham/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/jakirkham/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/jakirkham/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/jakirkham/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakirkham/numpy/labels{/name}","releases_url":"https://api.github.com/repos/jakirkham/numpy/releases{/id}","created_at":"2015-02-12T06:12:08Z","updated_at":"2015-05-04T04:26:19Z","pushed_at":"2015-05-04T04:26:15Z","git_url":"git://github.com/jakirkham/numpy.git","ssh_url":"git@github.com:jakirkham/numpy.git","clone_url":"https://github.com/jakirkham/numpy.git","svn_url":"https://github.com/jakirkham/numpy","homepage":"http://www.numpy.org/","size":38953,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"6032b8d7fc8ad2a8e1f1465cc5242873a03ba0ea","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","created_at":"2010-09-13T23:02:39Z","updated_at":"2015-06-17T23:11:56Z","pushed_at":"2015-06-18T00:18:19Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":67631,"stargazers_count":1983,"watchers_count":1983,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1025,"mirror_url":null,"open_issues_count":877,"forks":1025,"open_issues":877,"watchers":1983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5580"},"html":{"href":"https://github.com/numpy/numpy/pull/5580"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/5580"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/5580/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5580/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5580/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/4bda89f5ad429e1b76f5d9df1ed74de8c1d7b90d"}}}}