{"action":"created","comment":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/37469008","id":37469008,"diff_hunk":"@@ -0,0 +1,199 @@\n+#include \"IDEAS2DScanActionController.h\"\n+\n+#include \"application/IDEAS/IDEAS.h\"\n+#include \"actions3/AMActionSupport.h\"\n+#include \"actions3/actions/AMWaitAction.h\"\n+#include \"application/AMAppControllerSupport.h\"\n+#include \"actions3/AMListAction3.h\"\n+#include \"actions3/AMActionSupport.h\"\n+#include \"dataman/AM2DScan.h\"\n+#include \"beamline/IDEAS/IDEASBeamline.h\"\n+#include \"analysis/AM2DNormalizationAB.h\"\n+#include \"dataman/export/AMExporter2DAscii.h\"\n+#include \"dataman/export/AMSMAKExporter.h\"\n+#include \"dataman/export/AMExporterOptionSMAK.h\"\n+\n+IDEAS2DScanActionController::IDEAS2DScanActionController(IDEAS2DScanConfiguration *configuration, QObject *parent)\n+\t: AMStepScanActionController(configuration, parent)\n+{\n+\tconfiguration_ = configuration;\n+\n+\tscan_ = new AM2DScan();\n+\tscan_->setScanConfiguration(configuration_);\n+\tscan_->setFileFormat(\"amCDFv1\");\n+\tscan_->setIndexType(\"fileSystem\");\n+\n+\t// SMAK format requires a specific spectra file format.\n+\tAMExporterOptionSMAK *exportOptions = IDEAS::buildSMAKExporterOption(\"IDEAS2DDefault\", true, true);\n+\tif(exportOptions->id() > 0)\n+\t\tAMAppControllerSupport::registerClass<IDEAS2DScanConfiguration, AMSMAKExporter, AMExporterOptionSMAK>(exportOptions->id());\n+\n+\tQString scanName;\n+\n+\tif(configuration_->userScanName() == \"\"){\n+\n+\t\tscanName = configuration_->autoScanName();\n+\t\tscan_->setName(QString(\"%1\").arg(scanName));","path":"source/acquaman/IDEAS/IDEAS2DScanActionController.cpp","position":36,"original_position":36,"commit_id":"4706639617c25e6fd2285ac9d39b70ea09605d2f","original_commit_id":"4706639617c25e6fd2285ac9d39b70ea09605d2f","user":{"login":"epengr","id":677939,"avatar_url":"https://avatars.githubusercontent.com/u/677939?v=3","gravatar_id":"","url":"https://api.github.com/users/epengr","html_url":"https://github.com/epengr","followers_url":"https://api.github.com/users/epengr/followers","following_url":"https://api.github.com/users/epengr/following{/other_user}","gists_url":"https://api.github.com/users/epengr/gists{/gist_id}","starred_url":"https://api.github.com/users/epengr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epengr/subscriptions","organizations_url":"https://api.github.com/users/epengr/orgs","repos_url":"https://api.github.com/users/epengr/repos","events_url":"https://api.github.com/users/epengr/events{/privacy}","received_events_url":"https://api.github.com/users/epengr/received_events","type":"User","site_admin":false},"body":"Just curious if htere's a reason for this 'round-about way of setting the name, and not just ```scan_->setName(scanName)```","created_at":"2015-08-19T21:14:01Z","updated_at":"2015-08-19T21:14:01Z","html_url":"https://github.com/acquaman/acquaman/pull/1541#discussion_r37469008","pull_request_url":"https://api.github.com/repos/acquaman/acquaman/pulls/1541","_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments/37469008"},"html":{"href":"https://github.com/acquaman/acquaman/pull/1541#discussion_r37469008"},"pull_request":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/1541"}}},"pull_request":{"url":"https://api.github.com/repos/acquaman/acquaman/pulls/1541","id":42863482,"html_url":"https://github.com/acquaman/acquaman/pull/1541","diff_url":"https://github.com/acquaman/acquaman/pull/1541.diff","patch_url":"https://github.com/acquaman/acquaman/pull/1541.patch","issue_url":"https://api.github.com/repos/acquaman/acquaman/issues/1541","number":1541,"state":"open","locked":false,"title":"Pull Request for Issue1094: Implement 2D Macro Mapping on IDEAS","user":{"login":"dretrex","id":602741,"avatar_url":"https://avatars.githubusercontent.com/u/602741?v=3","gravatar_id":"","url":"https://api.github.com/users/dretrex","html_url":"https://github.com/dretrex","followers_url":"https://api.github.com/users/dretrex/followers","following_url":"https://api.github.com/users/dretrex/following{/other_user}","gists_url":"https://api.github.com/users/dretrex/gists{/gist_id}","starred_url":"https://api.github.com/users/dretrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dretrex/subscriptions","organizations_url":"https://api.github.com/users/dretrex/orgs","repos_url":"https://api.github.com/users/dretrex/repos","events_url":"https://api.github.com/users/dretrex/events{/privacy}","received_events_url":"https://api.github.com/users/dretrex/received_events","type":"User","site_admin":false},"body":"This turned out to be much more than implementing 2D macro mapping on IDEAS.  I used this as an opportunity to bring IDEAS up to date with all the other changes that have happened over the time it has been shut down.\r\n\r\nThings that were done (broad strokes):\r\n- Made an IDEASScanConfiguration/IDEASScanConfigurationDbObject\r\n- Made a database upgrade to get old data to be loadable with new inheritance structure.\r\n- Made a 2D scan configuration/view/controller.\r\n- Updated all the XAS classes to properly use the new inheritance and general code cleanup.\r\n- Implemented a user configuration for IDEAS.\r\n- Some general code cleanup that was found along the way.","created_at":"2015-08-19T21:00:36Z","updated_at":"2015-08-19T21:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e04bae4a93da5605f9d99210adf59017c3b815b","assignee":{"login":"iainworkman","id":7461599,"avatar_url":"https://avatars.githubusercontent.com/u/7461599?v=3","gravatar_id":"","url":"https://api.github.com/users/iainworkman","html_url":"https://github.com/iainworkman","followers_url":"https://api.github.com/users/iainworkman/followers","following_url":"https://api.github.com/users/iainworkman/following{/other_user}","gists_url":"https://api.github.com/users/iainworkman/gists{/gist_id}","starred_url":"https://api.github.com/users/iainworkman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iainworkman/subscriptions","organizations_url":"https://api.github.com/users/iainworkman/orgs","repos_url":"https://api.github.com/users/iainworkman/repos","events_url":"https://api.github.com/users/iainworkman/events{/privacy}","received_events_url":"https://api.github.com/users/iainworkman/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/acquaman/acquaman/pulls/1541/commits","review_comments_url":"https://api.github.com/repos/acquaman/acquaman/pulls/1541/comments","review_comment_url":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acquaman/acquaman/issues/1541/comments","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/4706639617c25e6fd2285ac9d39b70ea09605d2f","head":{"label":"acquaman:Issue1094","ref":"Issue1094","sha":"4706639617c25e6fd2285ac9d39b70ea09605d2f","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","created_at":"2011-02-06T02:19:01Z","updated_at":"2015-05-08T18:04:51Z","pushed_at":"2015-08-19T21:00:36Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":145928,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":130,"forks":2,"open_issues":130,"watchers":8,"default_branch":"master"}},"base":{"label":"acquaman:master","ref":"master","sha":"83b3345d0a404f42d5e60df137ece7ea48fa7d83","user":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"repo":{"id":1333343,"name":"acquaman","full_name":"acquaman/acquaman","owner":{"login":"acquaman","id":602716,"avatar_url":"https://avatars.githubusercontent.com/u/602716?v=3","gravatar_id":"","url":"https://api.github.com/users/acquaman","html_url":"https://github.com/acquaman","followers_url":"https://api.github.com/users/acquaman/followers","following_url":"https://api.github.com/users/acquaman/following{/other_user}","gists_url":"https://api.github.com/users/acquaman/gists{/gist_id}","starred_url":"https://api.github.com/users/acquaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acquaman/subscriptions","organizations_url":"https://api.github.com/users/acquaman/orgs","repos_url":"https://api.github.com/users/acquaman/repos","events_url":"https://api.github.com/users/acquaman/events{/privacy}","received_events_url":"https://api.github.com/users/acquaman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acquaman/acquaman","description":"Acquisition and Data Management for Big Science","fork":false,"url":"https://api.github.com/repos/acquaman/acquaman","forks_url":"https://api.github.com/repos/acquaman/acquaman/forks","keys_url":"https://api.github.com/repos/acquaman/acquaman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acquaman/acquaman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acquaman/acquaman/teams","hooks_url":"https://api.github.com/repos/acquaman/acquaman/hooks","issue_events_url":"https://api.github.com/repos/acquaman/acquaman/issues/events{/number}","events_url":"https://api.github.com/repos/acquaman/acquaman/events","assignees_url":"https://api.github.com/repos/acquaman/acquaman/assignees{/user}","branches_url":"https://api.github.com/repos/acquaman/acquaman/branches{/branch}","tags_url":"https://api.github.com/repos/acquaman/acquaman/tags","blobs_url":"https://api.github.com/repos/acquaman/acquaman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acquaman/acquaman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acquaman/acquaman/git/refs{/sha}","trees_url":"https://api.github.com/repos/acquaman/acquaman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acquaman/acquaman/statuses/{sha}","languages_url":"https://api.github.com/repos/acquaman/acquaman/languages","stargazers_url":"https://api.github.com/repos/acquaman/acquaman/stargazers","contributors_url":"https://api.github.com/repos/acquaman/acquaman/contributors","subscribers_url":"https://api.github.com/repos/acquaman/acquaman/subscribers","subscription_url":"https://api.github.com/repos/acquaman/acquaman/subscription","commits_url":"https://api.github.com/repos/acquaman/acquaman/commits{/sha}","git_commits_url":"https://api.github.com/repos/acquaman/acquaman/git/commits{/sha}","comments_url":"https://api.github.com/repos/acquaman/acquaman/comments{/number}","issue_comment_url":"https://api.github.com/repos/acquaman/acquaman/issues/comments{/number}","contents_url":"https://api.github.com/repos/acquaman/acquaman/contents/{+path}","compare_url":"https://api.github.com/repos/acquaman/acquaman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acquaman/acquaman/merges","archive_url":"https://api.github.com/repos/acquaman/acquaman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acquaman/acquaman/downloads","issues_url":"https://api.github.com/repos/acquaman/acquaman/issues{/number}","pulls_url":"https://api.github.com/repos/acquaman/acquaman/pulls{/number}","milestones_url":"https://api.github.com/repos/acquaman/acquaman/milestones{/number}","notifications_url":"https://api.github.com/repos/acquaman/acquaman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acquaman/acquaman/labels{/name}","releases_url":"https://api.github.com/repos/acquaman/acquaman/releases{/id}","created_at":"2011-02-06T02:19:01Z","updated_at":"2015-05-08T18:04:51Z","pushed_at":"2015-08-19T21:00:36Z","git_url":"git://github.com/acquaman/acquaman.git","ssh_url":"git@github.com:acquaman/acquaman.git","clone_url":"https://github.com/acquaman/acquaman.git","svn_url":"https://github.com/acquaman/acquaman","homepage":"","size":145928,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":130,"forks":2,"open_issues":130,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/1541"},"html":{"href":"https://github.com/acquaman/acquaman/pull/1541"},"issue":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/1541"},"comments":{"href":"https://api.github.com/repos/acquaman/acquaman/issues/1541/comments"},"review_comments":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/1541/comments"},"review_comment":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acquaman/acquaman/pulls/1541/commits"},"statuses":{"href":"https://api.github.com/repos/acquaman/acquaman/statuses/4706639617c25e6fd2285ac9d39b70ea09605d2f"}}}}