{"action":"created","issue":{"url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/120","labels_url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/120/comments","events_url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/120/events","html_url":"https://github.com/yaoweibin/nginx_tcp_proxy_module/issues/120","id":96126408,"number":120,"title":"nginx_tcp_proxy_module isn't compatible with NGINX HUP config reloads","user":{"login":"jamesmulcahy","id":1479642,"avatar_url":"https://avatars.githubusercontent.com/u/1479642?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmulcahy","html_url":"https://github.com/jamesmulcahy","followers_url":"https://api.github.com/users/jamesmulcahy/followers","following_url":"https://api.github.com/users/jamesmulcahy/following{/other_user}","gists_url":"https://api.github.com/users/jamesmulcahy/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmulcahy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmulcahy/subscriptions","organizations_url":"https://api.github.com/users/jamesmulcahy/orgs","repos_url":"https://api.github.com/users/jamesmulcahy/repos","events_url":"https://api.github.com/users/jamesmulcahy/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmulcahy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-20T18:25:06Z","updated_at":"2015-07-28T15:39:58Z","closed_at":null,"body":"I'm finding that when using SIGHUP to cause NGINX to reload it's configuration, it's failing to proxy new TCP connections for a brief period.  TCP connections that are already established, are unaffected by this and remain active without any problems.  TCP connections are are made a short while after the SIGHUP are handled without any problems.  Those made at the \"instant\" that the SIGHUP is occurring are, are unsuccessful (EOF/Connection Reset by Peer).\r\n\r\nIn the NGINX error log, I see entries such as:\r\n\r\n2015/07/20 11:11:11 [error] 74661#0: *11379464 upstream servers are busy or encounter error! while connecting to upstream, client: 127.0.0.1, server: 0.0.0.0:7000\r\n2015/07/20 11:11:12 [error] 74660#0: *11379465 upstream servers are busy or encounter error! while connecting to upstream, client: 127.0.0.1, server: 0.0.0.0:7000\r\n\r\nBut there are no problems with the upstream servers, and they are unchanged between the old and new configurations.  I suspect that what's happening, is that the nginx_tcp_proxy_module is starting to route connections before it's managed to re-initialise the list of upstream servers, and fails to proxy the new connection as a result.\r\n\r\nI don't have an individual reproducer for this, but I seem occurs frequently on release 0.4.5.\r\n"},"comment":{"url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/comments/125657375","html_url":"https://github.com/yaoweibin/nginx_tcp_proxy_module/issues/120#issuecomment-125657375","issue_url":"https://api.github.com/repos/yaoweibin/nginx_tcp_proxy_module/issues/120","id":125657375,"user":{"login":"jamesmulcahy","id":1479642,"avatar_url":"https://avatars.githubusercontent.com/u/1479642?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmulcahy","html_url":"https://github.com/jamesmulcahy","followers_url":"https://api.github.com/users/jamesmulcahy/followers","following_url":"https://api.github.com/users/jamesmulcahy/following{/other_user}","gists_url":"https://api.github.com/users/jamesmulcahy/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmulcahy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmulcahy/subscriptions","organizations_url":"https://api.github.com/users/jamesmulcahy/orgs","repos_url":"https://api.github.com/users/jamesmulcahy/repos","events_url":"https://api.github.com/users/jamesmulcahy/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmulcahy/received_events","type":"User","site_admin":false},"created_at":"2015-07-28T15:39:57Z","updated_at":"2015-07-28T15:39:57Z","body":"I've just upgraded to the native NGINX tcp proxying in 1.9.x, and can confirm that it's not vulnerable to this issue.  I appreciate that's no use/help for fixing this issue, but it might be a useful workaround for others who find themselves in this situation."}}