{"action":"created","comment":{"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/24940868","id":24940868,"diff_hunk":"@@ -180,7 +180,27 @@ public void onResponse(ImageContainer response, boolean isImmediate) {\n             public void onErrorResponse(VolleyError error) {\n \n             }\n-        }, 0, 0, false, true);\n+        }, 0, 0, false, true, 0);\n+    }\n+\n+    /**\n+     * get Image for background caching\n+     * @param requestUrl\n+     * @param ttl allow a custom ttl for caching\n+     * @return\n+     */\n+    public ImageContainer getImageBackground(String requestUrl, long ttl) {","path":"src/com/android/volley/toolbox/ImageLoader.java","position":14,"original_position":14,"commit_id":"6fb6a7174852be6ee17433eaa1e2770aeda608d7","original_commit_id":"6fb6a7174852be6ee17433eaa1e2770aeda608d7","user":{"login":"carolineleung","id":719749,"avatar_url":"https://avatars.githubusercontent.com/u/719749?v=3","gravatar_id":"","url":"https://api.github.com/users/carolineleung","html_url":"https://github.com/carolineleung","followers_url":"https://api.github.com/users/carolineleung/followers","following_url":"https://api.github.com/users/carolineleung/following{/other_user}","gists_url":"https://api.github.com/users/carolineleung/gists{/gist_id}","starred_url":"https://api.github.com/users/carolineleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolineleung/subscriptions","organizations_url":"https://api.github.com/users/carolineleung/orgs","repos_url":"https://api.github.com/users/carolineleung/repos","events_url":"https://api.github.com/users/carolineleung/events{/privacy}","received_events_url":"https://api.github.com/users/carolineleung/received_events","type":"User","site_admin":false},"body":"Can we chain this overloaded method with the existing `getImageBackground` instead of having separate impl?","created_at":"2015-02-18T21:05:30Z","updated_at":"2015-02-18T21:05:30Z","html_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80#discussion_r24940868","pull_request_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/24940868"},"html":{"href":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80#discussion_r24940868"},"pull_request":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80","id":29558782,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80","diff_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80.diff","patch_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80.patch","issue_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/80","number":80,"state":"open","locked":false,"title":"add image ttl for background fetches","user":{"login":"nwadams","id":879170,"avatar_url":"https://avatars.githubusercontent.com/u/879170?v=3","gravatar_id":"","url":"https://api.github.com/users/nwadams","html_url":"https://github.com/nwadams","followers_url":"https://api.github.com/users/nwadams/followers","following_url":"https://api.github.com/users/nwadams/following{/other_user}","gists_url":"https://api.github.com/users/nwadams/gists{/gist_id}","starred_url":"https://api.github.com/users/nwadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwadams/subscriptions","organizations_url":"https://api.github.com/users/nwadams/orgs","repos_url":"https://api.github.com/users/nwadams/repos","events_url":"https://api.github.com/users/nwadams/events{/privacy}","received_events_url":"https://api.github.com/users/nwadams/received_events","type":"User","site_admin":false},"body":"@lxdvs ","created_at":"2015-02-18T20:12:54Z","updated_at":"2015-02-18T21:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c78416491b2f1bcddc45dd075637febe67d6be46","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80/commits","review_comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80/comments","review_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/80/comments","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/6fb6a7174852be6ee17433eaa1e2770aeda608d7","head":{"label":"lxdvs:nick/image_ttl","ref":"nick/image_ttl","sha":"6fb6a7174852be6ee17433eaa1e2770aeda608d7","user":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"repo":{"id":10260163,"name":"Volley-OkHttp-Android","full_name":"lxdvs/Volley-OkHttp-Android","owner":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android","description":"This is a clone of Volley, with the relevant changes made to make it work with Square's OkHttp library. It also has Jackson integrated to provide a convenient object model.","fork":false,"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android","forks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/forks","keys_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/teams","hooks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/hooks","issue_events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/events{/number}","events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/events","assignees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/assignees{/user}","branches_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/branches{/branch}","tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/tags","blobs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/languages","stargazers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/stargazers","contributors_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contributors","subscribers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscribers","subscription_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscription","commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contents/{+path}","compare_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/merges","archive_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/downloads","issues_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues{/number}","pulls_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/labels{/name}","releases_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/releases{/id}","created_at":"2013-05-24T05:53:31Z","updated_at":"2015-02-12T03:58:54Z","pushed_at":"2015-02-18T20:12:18Z","git_url":"git://github.com/lxdvs/Volley-OkHttp-Android.git","ssh_url":"git@github.com:lxdvs/Volley-OkHttp-Android.git","clone_url":"https://github.com/lxdvs/Volley-OkHttp-Android.git","svn_url":"https://github.com/lxdvs/Volley-OkHttp-Android","homepage":"","size":7722,"stargazers_count":82,"watchers_count":82,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":3,"forks":32,"open_issues":3,"watchers":82,"default_branch":"master"}},"base":{"label":"lxdvs:bnb","ref":"bnb","sha":"e9c5cee4355a72b16d5191d87aff374ab5ea6062","user":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"repo":{"id":10260163,"name":"Volley-OkHttp-Android","full_name":"lxdvs/Volley-OkHttp-Android","owner":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android","description":"This is a clone of Volley, with the relevant changes made to make it work with Square's OkHttp library. It also has Jackson integrated to provide a convenient object model.","fork":false,"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android","forks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/forks","keys_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/teams","hooks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/hooks","issue_events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/events{/number}","events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/events","assignees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/assignees{/user}","branches_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/branches{/branch}","tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/tags","blobs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/languages","stargazers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/stargazers","contributors_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contributors","subscribers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscribers","subscription_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscription","commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contents/{+path}","compare_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/merges","archive_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/downloads","issues_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues{/number}","pulls_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/labels{/name}","releases_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/releases{/id}","created_at":"2013-05-24T05:53:31Z","updated_at":"2015-02-12T03:58:54Z","pushed_at":"2015-02-18T20:12:18Z","git_url":"git://github.com/lxdvs/Volley-OkHttp-Android.git","ssh_url":"git@github.com:lxdvs/Volley-OkHttp-Android.git","clone_url":"https://github.com/lxdvs/Volley-OkHttp-Android.git","svn_url":"https://github.com/lxdvs/Volley-OkHttp-Android","homepage":"","size":7722,"stargazers_count":82,"watchers_count":82,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":3,"forks":32,"open_issues":3,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80"},"html":{"href":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/80"},"issue":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/80"},"comments":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/6fb6a7174852be6ee17433eaa1e2770aeda608d7"}}}}