{"action":"created","comment":{"url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/comments/35918982","id":35918982,"diff_hunk":"@@ -202,18 +215,17 @@ def build(self):\n \n         nics = [{'port-id': port_id} for port_id in self.create_nics(self.info['networks'])]\n \n-        volume = self.runner.get_cinder_client().volumes.create(size=self.info['disk'],\n-                                                                imageRef=self.info['image'])\n-        self.record_resource('volume', volume.id)\n-\n-        while volume.status != 'available':\n-            time.sleep(3)\n-            volume = self.runner.get_cinder_client().volumes.get(volume.id)\n-\n-        bdm = {'vda': '%s:::1' % (volume.id,)}\n+        if self.info['boot_volume']:\n+            bdm_v2 = [{'source_type': 'image', 'uuid': self.info['image'],\n+                        'destination_type': 'volume', 'volume_size': self.info['boot_volume'],\n+                        'delete_on_termination': 'true', 'boot_index': '0'}]\n+            image = None\n+        else:\n+            image = self.info['image']\n+            bdm_v2 = None","path":"overcast/runner/__init__.py","position":49,"original_position":49,"commit_id":"6e81d47b5932bf4e36e76e2c745966569b07b00e","original_commit_id":"2a9d4956e10311089218355a9e08346fa89bb52d","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"body":"I will try to fix it along with the volume config fix","created_at":"2015-07-30T20:51:12Z","updated_at":"2015-07-30T20:51:12Z","html_url":"https://github.com/overcastcloud/python-overcast/pull/19#discussion_r35918982","pull_request_url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/comments/35918982"},"html":{"href":"https://github.com/overcastcloud/python-overcast/pull/19#discussion_r35918982"},"pull_request":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19","id":41199818,"html_url":"https://github.com/overcastcloud/python-overcast/pull/19","diff_url":"https://github.com/overcastcloud/python-overcast/pull/19.diff","patch_url":"https://github.com/overcastcloud/python-overcast/pull/19.patch","issue_url":"https://api.github.com/repos/overcastcloud/python-overcast/issues/19","number":19,"state":"open","locked":false,"title":"Support selecting from boot from volume and image","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"body":"This patch allow one to select booting a node from volume and image by changing\r\n\"boot_volume\" to a name which is mapped in the map file under volumes section.\r\n\r\nAlso changed nova boot from using block_device_mapping after cinder volume creation\r\nto block_device_mapping_v2, which will do both creating volume and boot from the\r\nvolume. So overcast do not need to manage the volume separately, but nova will\r\nhandle creating/deleting volume along with the node.","created_at":"2015-07-30T05:43:11Z","updated_at":"2015-07-30T20:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c9b98766ac81fae035b9cdf0185052f31e1c3bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19/commits","review_comments_url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19/comments","review_comment_url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/overcastcloud/python-overcast/issues/19/comments","statuses_url":"https://api.github.com/repos/overcastcloud/python-overcast/statuses/6e81d47b5932bf4e36e76e2c745966569b07b00e","head":{"label":"hkumarmk:boot_from_image","ref":"boot_from_image","sha":"6e81d47b5932bf4e36e76e2c745966569b07b00e","user":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"repo":{"id":33879331,"name":"python-overcast","full_name":"hkumarmk/python-overcast","owner":{"login":"hkumarmk","id":6316902,"avatar_url":"https://avatars.githubusercontent.com/u/6316902?v=3","gravatar_id":"","url":"https://api.github.com/users/hkumarmk","html_url":"https://github.com/hkumarmk","followers_url":"https://api.github.com/users/hkumarmk/followers","following_url":"https://api.github.com/users/hkumarmk/following{/other_user}","gists_url":"https://api.github.com/users/hkumarmk/gists{/gist_id}","starred_url":"https://api.github.com/users/hkumarmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkumarmk/subscriptions","organizations_url":"https://api.github.com/users/hkumarmk/orgs","repos_url":"https://api.github.com/users/hkumarmk/repos","events_url":"https://api.github.com/users/hkumarmk/events{/privacy}","received_events_url":"https://api.github.com/users/hkumarmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkumarmk/python-overcast","description":"","fork":true,"url":"https://api.github.com/repos/hkumarmk/python-overcast","forks_url":"https://api.github.com/repos/hkumarmk/python-overcast/forks","keys_url":"https://api.github.com/repos/hkumarmk/python-overcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkumarmk/python-overcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkumarmk/python-overcast/teams","hooks_url":"https://api.github.com/repos/hkumarmk/python-overcast/hooks","issue_events_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues/events{/number}","events_url":"https://api.github.com/repos/hkumarmk/python-overcast/events","assignees_url":"https://api.github.com/repos/hkumarmk/python-overcast/assignees{/user}","branches_url":"https://api.github.com/repos/hkumarmk/python-overcast/branches{/branch}","tags_url":"https://api.github.com/repos/hkumarmk/python-overcast/tags","blobs_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkumarmk/python-overcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hkumarmk/python-overcast/languages","stargazers_url":"https://api.github.com/repos/hkumarmk/python-overcast/stargazers","contributors_url":"https://api.github.com/repos/hkumarmk/python-overcast/contributors","subscribers_url":"https://api.github.com/repos/hkumarmk/python-overcast/subscribers","subscription_url":"https://api.github.com/repos/hkumarmk/python-overcast/subscription","commits_url":"https://api.github.com/repos/hkumarmk/python-overcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkumarmk/python-overcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkumarmk/python-overcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkumarmk/python-overcast/contents/{+path}","compare_url":"https://api.github.com/repos/hkumarmk/python-overcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkumarmk/python-overcast/merges","archive_url":"https://api.github.com/repos/hkumarmk/python-overcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkumarmk/python-overcast/downloads","issues_url":"https://api.github.com/repos/hkumarmk/python-overcast/issues{/number}","pulls_url":"https://api.github.com/repos/hkumarmk/python-overcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hkumarmk/python-overcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hkumarmk/python-overcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkumarmk/python-overcast/labels{/name}","releases_url":"https://api.github.com/repos/hkumarmk/python-overcast/releases{/id}","created_at":"2015-04-13T16:15:59Z","updated_at":"2015-04-13T16:15:59Z","pushed_at":"2015-07-30T20:42:02Z","git_url":"git://github.com/hkumarmk/python-overcast.git","ssh_url":"git@github.com:hkumarmk/python-overcast.git","clone_url":"https://github.com/hkumarmk/python-overcast.git","svn_url":"https://github.com/hkumarmk/python-overcast","homepage":null,"size":207,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"overcastcloud:master","ref":"master","sha":"7dd213453b89d197adad7d16715586a56ff535e6","user":{"login":"overcastcloud","id":11595717,"avatar_url":"https://avatars.githubusercontent.com/u/11595717?v=3","gravatar_id":"","url":"https://api.github.com/users/overcastcloud","html_url":"https://github.com/overcastcloud","followers_url":"https://api.github.com/users/overcastcloud/followers","following_url":"https://api.github.com/users/overcastcloud/following{/other_user}","gists_url":"https://api.github.com/users/overcastcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/overcastcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcastcloud/subscriptions","organizations_url":"https://api.github.com/users/overcastcloud/orgs","repos_url":"https://api.github.com/users/overcastcloud/repos","events_url":"https://api.github.com/users/overcastcloud/events{/privacy}","received_events_url":"https://api.github.com/users/overcastcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":32794027,"name":"python-overcast","full_name":"overcastcloud/python-overcast","owner":{"login":"overcastcloud","id":11595717,"avatar_url":"https://avatars.githubusercontent.com/u/11595717?v=3","gravatar_id":"","url":"https://api.github.com/users/overcastcloud","html_url":"https://github.com/overcastcloud","followers_url":"https://api.github.com/users/overcastcloud/followers","following_url":"https://api.github.com/users/overcastcloud/following{/other_user}","gists_url":"https://api.github.com/users/overcastcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/overcastcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overcastcloud/subscriptions","organizations_url":"https://api.github.com/users/overcastcloud/orgs","repos_url":"https://api.github.com/users/overcastcloud/repos","events_url":"https://api.github.com/users/overcastcloud/events{/privacy}","received_events_url":"https://api.github.com/users/overcastcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/overcastcloud/python-overcast","description":"","fork":false,"url":"https://api.github.com/repos/overcastcloud/python-overcast","forks_url":"https://api.github.com/repos/overcastcloud/python-overcast/forks","keys_url":"https://api.github.com/repos/overcastcloud/python-overcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overcastcloud/python-overcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overcastcloud/python-overcast/teams","hooks_url":"https://api.github.com/repos/overcastcloud/python-overcast/hooks","issue_events_url":"https://api.github.com/repos/overcastcloud/python-overcast/issues/events{/number}","events_url":"https://api.github.com/repos/overcastcloud/python-overcast/events","assignees_url":"https://api.github.com/repos/overcastcloud/python-overcast/assignees{/user}","branches_url":"https://api.github.com/repos/overcastcloud/python-overcast/branches{/branch}","tags_url":"https://api.github.com/repos/overcastcloud/python-overcast/tags","blobs_url":"https://api.github.com/repos/overcastcloud/python-overcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overcastcloud/python-overcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overcastcloud/python-overcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/overcastcloud/python-overcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overcastcloud/python-overcast/statuses/{sha}","languages_url":"https://api.github.com/repos/overcastcloud/python-overcast/languages","stargazers_url":"https://api.github.com/repos/overcastcloud/python-overcast/stargazers","contributors_url":"https://api.github.com/repos/overcastcloud/python-overcast/contributors","subscribers_url":"https://api.github.com/repos/overcastcloud/python-overcast/subscribers","subscription_url":"https://api.github.com/repos/overcastcloud/python-overcast/subscription","commits_url":"https://api.github.com/repos/overcastcloud/python-overcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/overcastcloud/python-overcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/overcastcloud/python-overcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/overcastcloud/python-overcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/overcastcloud/python-overcast/contents/{+path}","compare_url":"https://api.github.com/repos/overcastcloud/python-overcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overcastcloud/python-overcast/merges","archive_url":"https://api.github.com/repos/overcastcloud/python-overcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overcastcloud/python-overcast/downloads","issues_url":"https://api.github.com/repos/overcastcloud/python-overcast/issues{/number}","pulls_url":"https://api.github.com/repos/overcastcloud/python-overcast/pulls{/number}","milestones_url":"https://api.github.com/repos/overcastcloud/python-overcast/milestones{/number}","notifications_url":"https://api.github.com/repos/overcastcloud/python-overcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overcastcloud/python-overcast/labels{/name}","releases_url":"https://api.github.com/repos/overcastcloud/python-overcast/releases{/id}","created_at":"2015-03-24T11:19:06Z","updated_at":"2015-04-28T11:10:27Z","pushed_at":"2015-07-30T20:42:02Z","git_url":"git://github.com/overcastcloud/python-overcast.git","ssh_url":"git@github.com:overcastcloud/python-overcast.git","clone_url":"https://github.com/overcastcloud/python-overcast.git","svn_url":"https://github.com/overcastcloud/python-overcast","homepage":null,"size":369,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19"},"html":{"href":"https://github.com/overcastcloud/python-overcast/pull/19"},"issue":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/issues/19"},"comments":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/overcastcloud/python-overcast/statuses/6e81d47b5932bf4e36e76e2c745966569b07b00e"}}}}