{"action":"created","issue":{"url":"https://api.github.com/repos/janl/mustache.js/issues/421","labels_url":"https://api.github.com/repos/janl/mustache.js/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/janl/mustache.js/issues/421/comments","events_url":"https://api.github.com/repos/janl/mustache.js/issues/421/events","html_url":"https://github.com/janl/mustache.js/pull/421","id":56286226,"number":421,"title":"Run jshint before tests","user":{"login":"phillipj","id":1231635,"avatar_url":"https://avatars.githubusercontent.com/u/1231635?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipj","html_url":"https://github.com/phillipj","followers_url":"https://api.github.com/users/phillipj/followers","following_url":"https://api.github.com/users/phillipj/following{/other_user}","gists_url":"https://api.github.com/users/phillipj/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipj/subscriptions","organizations_url":"https://api.github.com/users/phillipj/orgs","repos_url":"https://api.github.com/users/phillipj/repos","events_url":"https://api.github.com/users/phillipj/events{/privacy}","received_events_url":"https://api.github.com/users/phillipj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-02T20:08:20Z","updated_at":"2015-02-02T21:20:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/janl/mustache.js/pulls/421","html_url":"https://github.com/janl/mustache.js/pull/421","diff_url":"https://github.com/janl/mustache.js/pull/421.diff","patch_url":"https://github.com/janl/mustache.js/pull/421.patch"},"body":"Hi,\r\n`jshint` should also be able to break the build, not just broken tests. Atm `jshint` run as a part of the `Rakefile`, that's a bit too late. It forces the maintainer doing a new mustache.js release to clean up codestyle violations. IMO it should be the PR developer's responsibility to clean up the code.\r\n\r\nThis PR includes a good example; clumpsy me left an unused variable in my previous refactoring PR #414. That might have broken the release script and someone else would have to fix my mistake. I would ofcourse have fixed it immediately if the travis run would have failed."},"comment":{"url":"https://api.github.com/repos/janl/mustache.js/issues/comments/72540218","html_url":"https://github.com/janl/mustache.js/pull/421#issuecomment-72540218","issue_url":"https://api.github.com/repos/janl/mustache.js/issues/421","id":72540218,"user":{"login":"dasilvacontin","id":1260830,"avatar_url":"https://avatars.githubusercontent.com/u/1260830?v=3","gravatar_id":"","url":"https://api.github.com/users/dasilvacontin","html_url":"https://github.com/dasilvacontin","followers_url":"https://api.github.com/users/dasilvacontin/followers","following_url":"https://api.github.com/users/dasilvacontin/following{/other_user}","gists_url":"https://api.github.com/users/dasilvacontin/gists{/gist_id}","starred_url":"https://api.github.com/users/dasilvacontin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dasilvacontin/subscriptions","organizations_url":"https://api.github.com/users/dasilvacontin/orgs","repos_url":"https://api.github.com/users/dasilvacontin/repos","events_url":"https://api.github.com/users/dasilvacontin/events{/privacy}","received_events_url":"https://api.github.com/users/dasilvacontin/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T21:20:50Z","updated_at":"2015-02-02T21:20:50Z","body":"I'm not sure which version changed the behaviour, or with which version it started failing. Only that it's working with 1.4.x, whilst with < 1.4 it's not working. Maybe we should enforce an npm version? I should really read more about this."}}