{"action":"closed","number":6787,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/6787","id":39202330,"html_url":"https://github.com/mrdoob/three.js/pull/6787","diff_url":"https://github.com/mrdoob/three.js/pull/6787.diff","patch_url":"https://github.com/mrdoob/three.js/pull/6787.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/6787","number":6787,"state":"closed","locked":false,"title":"mods to support blacklisted android devices","user":{"login":"Cy-Bo-Rg","id":5455606,"avatar_url":"https://avatars.githubusercontent.com/u/5455606?v=3","gravatar_id":"","url":"https://api.github.com/users/Cy-Bo-Rg","html_url":"https://github.com/Cy-Bo-Rg","followers_url":"https://api.github.com/users/Cy-Bo-Rg/followers","following_url":"https://api.github.com/users/Cy-Bo-Rg/following{/other_user}","gists_url":"https://api.github.com/users/Cy-Bo-Rg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cy-Bo-Rg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cy-Bo-Rg/subscriptions","organizations_url":"https://api.github.com/users/Cy-Bo-Rg/orgs","repos_url":"https://api.github.com/users/Cy-Bo-Rg/repos","events_url":"https://api.github.com/users/Cy-Bo-Rg/events{/privacy}","received_events_url":"https://api.github.com/users/Cy-Bo-Rg/received_events","type":"User","site_admin":false},"body":"I've added again a few lines to support blacklisted android devices with black screen problem (appearing since rev68).\r\nI've added a modified index.html called index_mobile.html which fixes\r\nresize problems and refresh fix problems in black listed android devices on stock browser.\r\nI've removed a variable from a demo which was declared but was not used. issue #6766\r\n\r\nMy device is a Galaxy Tab 2.0 GT-P3110 running Android 4.1.2 on a Power VR SGX-540 (blacklisted)\r\nAlmost all demos works perfectly with this mod. Without the lines added in the \"src/Three.js\" , the device shows a black screen.\r\nWith the lines , it shows the demos but with a wrong refresh rate (1 to 5 fps) and the windows doesn't properly resize.\r\nWith the modified index_mobile.html the window resizes correctly and the refresh rate is at its maximum possible (60+fps on some demos).\r\nOn the same device the Crosswalk Chromium webview crashes sometimes and has a lower FPS than with this fix; the same happens on Chrome (latest beta build) and Firefox (latest beta build).\r\nTo make a comparison, the \"material/skin\" demo runs at 2 fps on crosswalk while on android stock browser with this fix runs at 8 fps (6-5 while rotating the view).\r\n\r\nRelated issues  #2119 (unreasonably closed)\r\nThere are many related issues but I couldn't find all of them because they reside in other revisions now.\r\n\r\nHere are some screens of the android stock browser running three.js rev71.\r\nWithout lines added in src/Three.js , current index.html.\r\n![screenshot_2015-07-04-05-57-03](https://cloud.githubusercontent.com/assets/5455606/8506408/eec2d8dc-2212-11e5-9a54-13148a8f6dad.png)\r\n\r\nWith lines added in the build but without modified index. Doesn't properly resize , the frame rate is wrong and the image refreshes at 1 to 5 fps.\r\n![screenshot_2015-07-04-05-58-39](https://cloud.githubusercontent.com/assets/5455606/8506409/f68ebd42-2212-11e5-9f83-f1c9e810851f.png)\r\n\r\nWith lines added in the build and with index_mobile.html : 100% playable.\r\n![screenshot_2015-07-04-06-03-48](https://cloud.githubusercontent.com/assets/5455606/8506438/990e7854-2214-11e5-9f2e-a81a4b85896e.png)\r\n\r\nThis video shows the problem and the fix in action.\r\nhttps://www.youtube.com/watch?v=P_i0uOPWBuI\r\nThese modifications won't alter the behavior on desktop,which remains the same.\r\n\r\nI've highly tested this refresh workaround since rev66. It always works.\r\nBut I know for sure that it is present starting from rev54 because I can run helloenjoy samsung racer s with the refresh fix.\r\n\r\n\r\n\r\n","created_at":"2015-07-04T04:10:22Z","updated_at":"2015-07-08T13:12:26Z","closed_at":"2015-07-08T13:12:26Z","merged_at":null,"merge_commit_sha":"bb5cad25005c0b8c554530ba65a71632a2f7d8a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6787/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/6787/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/6787/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/5306eeffc0e57ca96bd525d95847128e6ced8c8b","head":{"label":"Cy-Bo-Rg:dev","ref":"dev","sha":"5306eeffc0e57ca96bd525d95847128e6ced8c8b","user":{"login":"Cy-Bo-Rg","id":5455606,"avatar_url":"https://avatars.githubusercontent.com/u/5455606?v=3","gravatar_id":"","url":"https://api.github.com/users/Cy-Bo-Rg","html_url":"https://github.com/Cy-Bo-Rg","followers_url":"https://api.github.com/users/Cy-Bo-Rg/followers","following_url":"https://api.github.com/users/Cy-Bo-Rg/following{/other_user}","gists_url":"https://api.github.com/users/Cy-Bo-Rg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cy-Bo-Rg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cy-Bo-Rg/subscriptions","organizations_url":"https://api.github.com/users/Cy-Bo-Rg/orgs","repos_url":"https://api.github.com/users/Cy-Bo-Rg/repos","events_url":"https://api.github.com/users/Cy-Bo-Rg/events{/privacy}","received_events_url":"https://api.github.com/users/Cy-Bo-Rg/received_events","type":"User","site_admin":false},"repo":{"id":38491156,"name":"three.js","full_name":"Cy-Bo-Rg/three.js","owner":{"login":"Cy-Bo-Rg","id":5455606,"avatar_url":"https://avatars.githubusercontent.com/u/5455606?v=3","gravatar_id":"","url":"https://api.github.com/users/Cy-Bo-Rg","html_url":"https://github.com/Cy-Bo-Rg","followers_url":"https://api.github.com/users/Cy-Bo-Rg/followers","following_url":"https://api.github.com/users/Cy-Bo-Rg/following{/other_user}","gists_url":"https://api.github.com/users/Cy-Bo-Rg/gists{/gist_id}","starred_url":"https://api.github.com/users/Cy-Bo-Rg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cy-Bo-Rg/subscriptions","organizations_url":"https://api.github.com/users/Cy-Bo-Rg/orgs","repos_url":"https://api.github.com/users/Cy-Bo-Rg/repos","events_url":"https://api.github.com/users/Cy-Bo-Rg/events{/privacy}","received_events_url":"https://api.github.com/users/Cy-Bo-Rg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cy-Bo-Rg/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/Cy-Bo-Rg/three.js","forks_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/forks","keys_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/teams","hooks_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/hooks","issue_events_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/events","assignees_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/tags","blobs_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/languages","stargazers_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/stargazers","contributors_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/contributors","subscribers_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/subscribers","subscription_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/subscription","commits_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/merges","archive_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/downloads","issues_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/labels{/name}","releases_url":"https://api.github.com/repos/Cy-Bo-Rg/three.js/releases{/id}","created_at":"2015-07-03T12:14:52Z","updated_at":"2015-07-03T12:15:02Z","pushed_at":"2015-07-08T01:06:53Z","git_url":"git://github.com/Cy-Bo-Rg/three.js.git","ssh_url":"git@github.com:Cy-Bo-Rg/three.js.git","clone_url":"https://github.com/Cy-Bo-Rg/three.js.git","svn_url":"https://github.com/Cy-Bo-Rg/three.js","homepage":"http://threejs.org/","size":324168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"28448557903a5964fdb96a14eae282d5a50e7885","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","created_at":"2010-03-23T18:58:01Z","updated_at":"2015-07-08T12:55:44Z","pushed_at":"2015-07-08T01:07:04Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":382101,"stargazers_count":20238,"watchers_count":20238,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":6115,"mirror_url":null,"open_issues_count":805,"forks":6115,"open_issues":805,"watchers":20238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6787"},"html":{"href":"https://github.com/mrdoob/three.js/pull/6787"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6787"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/6787/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6787/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/6787/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/5306eeffc0e57ca96bd525d95847128e6ced8c8b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":19,"review_comments":0,"commits":3,"additions":66,"deletions":3,"changed_files":3}}