{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/46669687","id":46669687,"diff_hunk":"@@ -15,7 +15,8 @@ function testPBKDF2(password, salt, iterations, keylen, expected) {\n   var actual = crypto.pbkdf2Sync(password, salt, iterations, keylen);\n   assert.equal(actual.toString('binary'), expected);\n \n-  crypto.pbkdf2(password, salt, iterations, keylen, function(err, actual) {\n+  crypto.pbkdf2(password, salt, iterations, keylen, 'sha1',\n+  function(err, actual) {","path":"test/parallel/test-crypto-pbkdf2.js","position":6,"original_position":6,"commit_id":"fbcf2f5be0ff7e25470a48f6858ff862ea98cc80","original_commit_id":"fbcf2f5be0ff7e25470a48f6858ff862ea98cc80","user":{"login":"tomgco","id":524382,"avatar_url":"https://avatars.githubusercontent.com/u/524382?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgco","html_url":"https://github.com/tomgco","followers_url":"https://api.github.com/users/tomgco/followers","following_url":"https://api.github.com/users/tomgco/following{/other_user}","gists_url":"https://api.github.com/users/tomgco/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgco/subscriptions","organizations_url":"https://api.github.com/users/tomgco/orgs","repos_url":"https://api.github.com/users/tomgco/repos","events_url":"https://api.github.com/users/tomgco/events{/privacy}","received_events_url":"https://api.github.com/users/tomgco/received_events","type":"User","site_admin":false},"body":"For me it did, I can modify this to use a fat arrow if that makes it nicer?","created_at":"2015-12-04T10:49:17Z","updated_at":"2015-12-04T10:49:17Z","html_url":"https://github.com/nodejs/node/pull/4047#discussion_r46669687","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/4047","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/46669687"},"html":{"href":"https://github.com/nodejs/node/pull/4047#discussion_r46669687"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/4047"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4047","id":51982367,"html_url":"https://github.com/nodejs/node/pull/4047","diff_url":"https://github.com/nodejs/node/pull/4047.diff","patch_url":"https://github.com/nodejs/node/pull/4047.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/4047","number":4047,"state":"open","locked":false,"title":"crypto: pbkdf.js deprecate digest overload.","user":{"login":"tomgco","id":524382,"avatar_url":"https://avatars.githubusercontent.com/u/524382?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgco","html_url":"https://github.com/tomgco","followers_url":"https://api.github.com/users/tomgco/followers","following_url":"https://api.github.com/users/tomgco/following{/other_user}","gists_url":"https://api.github.com/users/tomgco/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgco/subscriptions","organizations_url":"https://api.github.com/users/tomgco/orgs","repos_url":"https://api.github.com/users/tomgco/repos","events_url":"https://api.github.com/users/tomgco/events{/privacy}","received_events_url":"https://api.github.com/users/tomgco/received_events","type":"User","site_admin":false},"body":"As per #3292, this PR introduces a deprecation notice about removing\r\nthe 'default digest' overload which currently defaults to the soon\r\nto be defunct SHA1 digest.\r\n\r\nInstead it should be left up to the documentation and implementor to\r\nsuggest a suitable digest function.\r\n\r\nI have also updated some of the tests to specifically use the ‘sha1’ digest\r\nto not warn with this commit.\r\n\r\nThanks :dancers: ","created_at":"2015-11-27T10:55:04Z","updated_at":"2015-12-04T10:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46c76e0a902b98f7afe042281aadbda862469b06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/4047/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/4047/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4047/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/fbcf2f5be0ff7e25470a48f6858ff862ea98cc80","head":{"label":"tomgco:pbkdf2-deprecate-override","ref":"pbkdf2-deprecate-override","sha":"fbcf2f5be0ff7e25470a48f6858ff862ea98cc80","user":{"login":"tomgco","id":524382,"avatar_url":"https://avatars.githubusercontent.com/u/524382?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgco","html_url":"https://github.com/tomgco","followers_url":"https://api.github.com/users/tomgco/followers","following_url":"https://api.github.com/users/tomgco/following{/other_user}","gists_url":"https://api.github.com/users/tomgco/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgco/subscriptions","organizations_url":"https://api.github.com/users/tomgco/orgs","repos_url":"https://api.github.com/users/tomgco/repos","events_url":"https://api.github.com/users/tomgco/events{/privacy}","received_events_url":"https://api.github.com/users/tomgco/received_events","type":"User","site_admin":false},"repo":{"id":42928627,"name":"node","full_name":"tomgco/node","owner":{"login":"tomgco","id":524382,"avatar_url":"https://avatars.githubusercontent.com/u/524382?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgco","html_url":"https://github.com/tomgco","followers_url":"https://api.github.com/users/tomgco/followers","following_url":"https://api.github.com/users/tomgco/following{/other_user}","gists_url":"https://api.github.com/users/tomgco/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgco/subscriptions","organizations_url":"https://api.github.com/users/tomgco/orgs","repos_url":"https://api.github.com/users/tomgco/repos","events_url":"https://api.github.com/users/tomgco/events{/privacy}","received_events_url":"https://api.github.com/users/tomgco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomgco/node","description":"✨Node.js  ✨","fork":true,"url":"https://api.github.com/repos/tomgco/node","forks_url":"https://api.github.com/repos/tomgco/node/forks","keys_url":"https://api.github.com/repos/tomgco/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomgco/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomgco/node/teams","hooks_url":"https://api.github.com/repos/tomgco/node/hooks","issue_events_url":"https://api.github.com/repos/tomgco/node/issues/events{/number}","events_url":"https://api.github.com/repos/tomgco/node/events","assignees_url":"https://api.github.com/repos/tomgco/node/assignees{/user}","branches_url":"https://api.github.com/repos/tomgco/node/branches{/branch}","tags_url":"https://api.github.com/repos/tomgco/node/tags","blobs_url":"https://api.github.com/repos/tomgco/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomgco/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomgco/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomgco/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomgco/node/statuses/{sha}","languages_url":"https://api.github.com/repos/tomgco/node/languages","stargazers_url":"https://api.github.com/repos/tomgco/node/stargazers","contributors_url":"https://api.github.com/repos/tomgco/node/contributors","subscribers_url":"https://api.github.com/repos/tomgco/node/subscribers","subscription_url":"https://api.github.com/repos/tomgco/node/subscription","commits_url":"https://api.github.com/repos/tomgco/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomgco/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomgco/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomgco/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomgco/node/contents/{+path}","compare_url":"https://api.github.com/repos/tomgco/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomgco/node/merges","archive_url":"https://api.github.com/repos/tomgco/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomgco/node/downloads","issues_url":"https://api.github.com/repos/tomgco/node/issues{/number}","pulls_url":"https://api.github.com/repos/tomgco/node/pulls{/number}","milestones_url":"https://api.github.com/repos/tomgco/node/milestones{/number}","notifications_url":"https://api.github.com/repos/tomgco/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomgco/node/labels{/name}","releases_url":"https://api.github.com/repos/tomgco/node/releases{/id}","created_at":"2015-09-22T11:02:40Z","updated_at":"2015-09-22T11:03:25Z","pushed_at":"2015-11-27T10:52:58Z","git_url":"git://github.com/tomgco/node.git","ssh_url":"git@github.com:tomgco/node.git","clone_url":"https://github.com/tomgco/node.git","svn_url":"https://github.com/tomgco/node","homepage":"https://nodejs.org","size":153838,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"7b09aade8468e1c930f36b9c81e6ac2ed5bc8732","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-12-04T09:51:59Z","pushed_at":"2015-12-04T08:43:44Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":175530,"stargazers_count":17906,"watchers_count":17906,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1938,"mirror_url":null,"open_issues_count":605,"forks":1938,"open_issues":605,"watchers":17906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/4047"},"html":{"href":"https://github.com/nodejs/node/pull/4047"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/4047"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/4047/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/4047/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/4047/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/fbcf2f5be0ff7e25470a48f6858ff862ea98cc80"}}}}