{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/31854727","id":31854727,"diff_hunk":"@@ -508,11 +508,15 @@ int main(int argc, char *argv[])\n \thints->ep_attr->type = FI_EP_MSG;\n \thints->caps = FI_MSG;\n \thints->mode = FI_LOCAL_MR;\n-\thints->addr_format = FI_SOCKADDR;\n \n-\trc = ft_read_addr_opts(&node, &service, hints, &flags, &opts);\n-\tif (rc)\n-\t\treturn 1;\n+\tif (!opts.dst_node) {\n+\t\tflags |= FI_SOURCE;\n+\t\tnode = opts.src_node;\n+\t\tservice = opts.src_port;\n+\t} else {\n+\t\tnode = opts.dst_node;\n+\t\tservice = opts.dst_port;\n+\t}","path":"ported/libibverbs/rc_pingpong.c","position":25,"original_position":25,"commit_id":"34527458130ceadf0187b15cd067f031a8886da6","original_commit_id":"34527458130ceadf0187b15cd067f031a8886da6","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"body":"yea, good point. i'll update.","created_at":"2015-06-05T21:48:51Z","updated_at":"2015-06-05T21:48:51Z","html_url":"https://github.com/ofiwg/fabtests/pull/271#discussion_r31854727","pull_request_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/31854727"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/271#discussion_r31854727"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/271","id":37062555,"html_url":"https://github.com/ofiwg/fabtests/pull/271","diff_url":"https://github.com/ofiwg/fabtests/pull/271.diff","patch_url":"https://github.com/ofiwg/fabtests/pull/271.patch","issue_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271","number":271,"state":"open","locked":false,"title":"Fix addressing issues in fabtests","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"body":"fabtests were assuming various things about addressing\r\n\r\n1) Remove usage of getaddrinfo() from the tests themselves\r\n- tests should provide client and server node names, and\r\nfi_getinfo should do the right thing for address resolution\r\n\r\n2) Rename 'src_addr' and 'dst_addr' in command line options\r\nto 'src_node' and 'dst_node'. Removed FI_SOCKADDR_IN requirement.\r\n- portable OFI programs shouldn't assume any format of address.\r\ninterfaces can be chosen with names.\r\n\r\ne.g. to use IPoIB, use node-ib0, vs. passing in IP address of ib0\r\ninterface.\r\n\r\n3) fix bug in ud_pingpong.c where hints->dest_addr was used for\r\nav_insert, vs fi->dest_addr\r\n- fi->dest_addr was obtained from getinfo(), vs. hints which is\r\na hardcoded address (also portable OFI programs should use\r\nfi_getinfo for getting correct address structures)\r\n\r\nSigned-off-by: Sayantan Sur <sayantan.sur@intel.com>\r\n\r\nTested with sockets provider, seems to be working.\r\n\r\n@jithinjosepkl @shantonu @goodell @jsquyres @shefty @hppritcha Please review!","created_at":"2015-06-05T19:30:29Z","updated_at":"2015-06-05T21:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7510f647c1d2d9b49edc72aa8f3639b5290a6023","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/271/commits","review_comments_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/271/comments","review_comment_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271/comments","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/34527458130ceadf0187b15cd067f031a8886da6","head":{"label":"sayantansur:fabtests-addr","ref":"fabtests-addr","sha":"34527458130ceadf0187b15cd067f031a8886da6","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"repo":{"id":29753620,"name":"fabtests","full_name":"sayantansur/fabtests","owner":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sayantansur/fabtests","description":"","fork":true,"url":"https://api.github.com/repos/sayantansur/fabtests","forks_url":"https://api.github.com/repos/sayantansur/fabtests/forks","keys_url":"https://api.github.com/repos/sayantansur/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sayantansur/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sayantansur/fabtests/teams","hooks_url":"https://api.github.com/repos/sayantansur/fabtests/hooks","issue_events_url":"https://api.github.com/repos/sayantansur/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/sayantansur/fabtests/events","assignees_url":"https://api.github.com/repos/sayantansur/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/sayantansur/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/sayantansur/fabtests/tags","blobs_url":"https://api.github.com/repos/sayantansur/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sayantansur/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sayantansur/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sayantansur/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sayantansur/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/sayantansur/fabtests/languages","stargazers_url":"https://api.github.com/repos/sayantansur/fabtests/stargazers","contributors_url":"https://api.github.com/repos/sayantansur/fabtests/contributors","subscribers_url":"https://api.github.com/repos/sayantansur/fabtests/subscribers","subscription_url":"https://api.github.com/repos/sayantansur/fabtests/subscription","commits_url":"https://api.github.com/repos/sayantansur/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sayantansur/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sayantansur/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sayantansur/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sayantansur/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/sayantansur/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sayantansur/fabtests/merges","archive_url":"https://api.github.com/repos/sayantansur/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sayantansur/fabtests/downloads","issues_url":"https://api.github.com/repos/sayantansur/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/sayantansur/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/sayantansur/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/sayantansur/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sayantansur/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/sayantansur/fabtests/releases{/id}","created_at":"2015-01-23T21:18:51Z","updated_at":"2015-03-17T23:04:24Z","pushed_at":"2015-06-05T19:28:03Z","git_url":"git://github.com/sayantansur/fabtests.git","ssh_url":"git@github.com:sayantansur/fabtests.git","clone_url":"https://github.com/sayantansur/fabtests.git","svn_url":"https://github.com/sayantansur/fabtests","homepage":null,"size":1145,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"a639b3cda6bd1933cc984e43d847b9e5d4d126ff","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996869,"name":"fabtests","full_name":"ofiwg/fabtests","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/fabtests","description":"","fork":false,"url":"https://api.github.com/repos/ofiwg/fabtests","forks_url":"https://api.github.com/repos/ofiwg/fabtests/forks","keys_url":"https://api.github.com/repos/ofiwg/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/fabtests/teams","hooks_url":"https://api.github.com/repos/ofiwg/fabtests/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/fabtests/events","assignees_url":"https://api.github.com/repos/ofiwg/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/fabtests/tags","blobs_url":"https://api.github.com/repos/ofiwg/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/fabtests/languages","stargazers_url":"https://api.github.com/repos/ofiwg/fabtests/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/fabtests/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/fabtests/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/fabtests/subscription","commits_url":"https://api.github.com/repos/ofiwg/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/fabtests/merges","archive_url":"https://api.github.com/repos/ofiwg/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/fabtests/downloads","issues_url":"https://api.github.com/repos/ofiwg/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/fabtests/releases{/id}","created_at":"2014-08-15T17:13:04Z","updated_at":"2015-05-28T10:16:59Z","pushed_at":"2015-06-05T19:30:30Z","git_url":"git://github.com/ofiwg/fabtests.git","ssh_url":"git@github.com:ofiwg/fabtests.git","clone_url":"https://github.com/ofiwg/fabtests.git","svn_url":"https://github.com/ofiwg/fabtests","homepage":null,"size":3367,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":13,"forks":28,"open_issues":13,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/271"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/271"},"issue":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/271"},"comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/fabtests/statuses/34527458130ceadf0187b15cd067f031a8886da6"}}}}