{"action":"closed","number":181,"pull_request":{"url":"https://api.github.com/repos/mrash/fwknop/pulls/181","id":54204940,"html_url":"https://github.com/mrash/fwknop/pull/181","diff_url":"https://github.com/mrash/fwknop/pull/181.diff","patch_url":"https://github.com/mrash/fwknop/pull/181.patch","issue_url":"https://api.github.com/repos/mrash/fwknop/issues/181","number":181,"state":"closed","locked":false,"title":"X-Forwarded-For HTTP header support","user":{"login":"vaygr","id":8810597,"avatar_url":"https://avatars.githubusercontent.com/u/8810597?v=3","gravatar_id":"","url":"https://api.github.com/users/vaygr","html_url":"https://github.com/vaygr","followers_url":"https://api.github.com/users/vaygr/followers","following_url":"https://api.github.com/users/vaygr/following{/other_user}","gists_url":"https://api.github.com/users/vaygr/gists{/gist_id}","starred_url":"https://api.github.com/users/vaygr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaygr/subscriptions","organizations_url":"https://api.github.com/users/vaygr/orgs","repos_url":"https://api.github.com/users/vaygr/repos","events_url":"https://api.github.com/users/vaygr/events{/privacy}","received_events_url":"https://api.github.com/users/vaygr/received_events","type":"User","site_admin":false},"body":"The idea here is to support X-Forwarded-For header for HTTP requests proxied from a frontend, for example, when we use '-s' IP-autodetection flag from the client. So when we have some complex multi-tier setup, it would be good to pass client's real IP address in some header.\r\n\r\nThere could be an option to customize the header name as well. Probably we should think of \"trusted\" sources too, like it's done for every modern HTTP-server's module (mod_rpaf for Apache, mod_realip for nginx, mod_extforward for LigHTTPD).\r\n\r\nThis is just the first draft of the solution; thoughts/patches are welcome.","created_at":"2015-12-20T18:30:11Z","updated_at":"2015-12-30T01:47:33Z","closed_at":"2015-12-30T01:47:33Z","merged_at":"2015-12-30T01:47:33Z","merge_commit_sha":"38a824e6f5b7e5439a82c90fbbe1bd0cf5e8dd36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrash/fwknop/pulls/181/commits","review_comments_url":"https://api.github.com/repos/mrash/fwknop/pulls/181/comments","review_comment_url":"https://api.github.com/repos/mrash/fwknop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrash/fwknop/issues/181/comments","statuses_url":"https://api.github.com/repos/mrash/fwknop/statuses/4a7411ba5730d152b044da5df7d60d0d903a2d7b","head":{"label":"vaygr:xff","ref":"xff","sha":"4a7411ba5730d152b044da5df7d60d0d903a2d7b","user":{"login":"vaygr","id":8810597,"avatar_url":"https://avatars.githubusercontent.com/u/8810597?v=3","gravatar_id":"","url":"https://api.github.com/users/vaygr","html_url":"https://github.com/vaygr","followers_url":"https://api.github.com/users/vaygr/followers","following_url":"https://api.github.com/users/vaygr/following{/other_user}","gists_url":"https://api.github.com/users/vaygr/gists{/gist_id}","starred_url":"https://api.github.com/users/vaygr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaygr/subscriptions","organizations_url":"https://api.github.com/users/vaygr/orgs","repos_url":"https://api.github.com/users/vaygr/repos","events_url":"https://api.github.com/users/vaygr/events{/privacy}","received_events_url":"https://api.github.com/users/vaygr/received_events","type":"User","site_admin":false},"repo":{"id":46510973,"name":"fwknop","full_name":"vaygr/fwknop","owner":{"login":"vaygr","id":8810597,"avatar_url":"https://avatars.githubusercontent.com/u/8810597?v=3","gravatar_id":"","url":"https://api.github.com/users/vaygr","html_url":"https://github.com/vaygr","followers_url":"https://api.github.com/users/vaygr/followers","following_url":"https://api.github.com/users/vaygr/following{/other_user}","gists_url":"https://api.github.com/users/vaygr/gists{/gist_id}","starred_url":"https://api.github.com/users/vaygr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaygr/subscriptions","organizations_url":"https://api.github.com/users/vaygr/orgs","repos_url":"https://api.github.com/users/vaygr/repos","events_url":"https://api.github.com/users/vaygr/events{/privacy}","received_events_url":"https://api.github.com/users/vaygr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vaygr/fwknop","description":"Single Packet Authorization > Port Knocking","fork":true,"url":"https://api.github.com/repos/vaygr/fwknop","forks_url":"https://api.github.com/repos/vaygr/fwknop/forks","keys_url":"https://api.github.com/repos/vaygr/fwknop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaygr/fwknop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaygr/fwknop/teams","hooks_url":"https://api.github.com/repos/vaygr/fwknop/hooks","issue_events_url":"https://api.github.com/repos/vaygr/fwknop/issues/events{/number}","events_url":"https://api.github.com/repos/vaygr/fwknop/events","assignees_url":"https://api.github.com/repos/vaygr/fwknop/assignees{/user}","branches_url":"https://api.github.com/repos/vaygr/fwknop/branches{/branch}","tags_url":"https://api.github.com/repos/vaygr/fwknop/tags","blobs_url":"https://api.github.com/repos/vaygr/fwknop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaygr/fwknop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaygr/fwknop/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaygr/fwknop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaygr/fwknop/statuses/{sha}","languages_url":"https://api.github.com/repos/vaygr/fwknop/languages","stargazers_url":"https://api.github.com/repos/vaygr/fwknop/stargazers","contributors_url":"https://api.github.com/repos/vaygr/fwknop/contributors","subscribers_url":"https://api.github.com/repos/vaygr/fwknop/subscribers","subscription_url":"https://api.github.com/repos/vaygr/fwknop/subscription","commits_url":"https://api.github.com/repos/vaygr/fwknop/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaygr/fwknop/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaygr/fwknop/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaygr/fwknop/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaygr/fwknop/contents/{+path}","compare_url":"https://api.github.com/repos/vaygr/fwknop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaygr/fwknop/merges","archive_url":"https://api.github.com/repos/vaygr/fwknop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaygr/fwknop/downloads","issues_url":"https://api.github.com/repos/vaygr/fwknop/issues{/number}","pulls_url":"https://api.github.com/repos/vaygr/fwknop/pulls{/number}","milestones_url":"https://api.github.com/repos/vaygr/fwknop/milestones{/number}","notifications_url":"https://api.github.com/repos/vaygr/fwknop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaygr/fwknop/labels{/name}","releases_url":"https://api.github.com/repos/vaygr/fwknop/releases{/id}","created_at":"2015-11-19T18:09:59Z","updated_at":"2015-11-19T18:10:05Z","pushed_at":"2015-12-20T18:19:59Z","git_url":"git://github.com/vaygr/fwknop.git","ssh_url":"git@github.com:vaygr/fwknop.git","clone_url":"https://github.com/vaygr/fwknop.git","svn_url":"https://github.com/vaygr/fwknop","homepage":"http://www.cipherdyne.org/fwknop/","size":15062,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrash:master","ref":"master","sha":"dd2f4c2c3895ef41d91e1b655327a5afa4346947","user":{"login":"mrash","id":380228,"avatar_url":"https://avatars.githubusercontent.com/u/380228?v=3","gravatar_id":"","url":"https://api.github.com/users/mrash","html_url":"https://github.com/mrash","followers_url":"https://api.github.com/users/mrash/followers","following_url":"https://api.github.com/users/mrash/following{/other_user}","gists_url":"https://api.github.com/users/mrash/gists{/gist_id}","starred_url":"https://api.github.com/users/mrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrash/subscriptions","organizations_url":"https://api.github.com/users/mrash/orgs","repos_url":"https://api.github.com/users/mrash/repos","events_url":"https://api.github.com/users/mrash/events{/privacy}","received_events_url":"https://api.github.com/users/mrash/received_events","type":"User","site_admin":false},"repo":{"id":1887353,"name":"fwknop","full_name":"mrash/fwknop","owner":{"login":"mrash","id":380228,"avatar_url":"https://avatars.githubusercontent.com/u/380228?v=3","gravatar_id":"","url":"https://api.github.com/users/mrash","html_url":"https://github.com/mrash","followers_url":"https://api.github.com/users/mrash/followers","following_url":"https://api.github.com/users/mrash/following{/other_user}","gists_url":"https://api.github.com/users/mrash/gists{/gist_id}","starred_url":"https://api.github.com/users/mrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrash/subscriptions","organizations_url":"https://api.github.com/users/mrash/orgs","repos_url":"https://api.github.com/users/mrash/repos","events_url":"https://api.github.com/users/mrash/events{/privacy}","received_events_url":"https://api.github.com/users/mrash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrash/fwknop","description":"Single Packet Authorization > Port Knocking","fork":false,"url":"https://api.github.com/repos/mrash/fwknop","forks_url":"https://api.github.com/repos/mrash/fwknop/forks","keys_url":"https://api.github.com/repos/mrash/fwknop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrash/fwknop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrash/fwknop/teams","hooks_url":"https://api.github.com/repos/mrash/fwknop/hooks","issue_events_url":"https://api.github.com/repos/mrash/fwknop/issues/events{/number}","events_url":"https://api.github.com/repos/mrash/fwknop/events","assignees_url":"https://api.github.com/repos/mrash/fwknop/assignees{/user}","branches_url":"https://api.github.com/repos/mrash/fwknop/branches{/branch}","tags_url":"https://api.github.com/repos/mrash/fwknop/tags","blobs_url":"https://api.github.com/repos/mrash/fwknop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrash/fwknop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrash/fwknop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrash/fwknop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrash/fwknop/statuses/{sha}","languages_url":"https://api.github.com/repos/mrash/fwknop/languages","stargazers_url":"https://api.github.com/repos/mrash/fwknop/stargazers","contributors_url":"https://api.github.com/repos/mrash/fwknop/contributors","subscribers_url":"https://api.github.com/repos/mrash/fwknop/subscribers","subscription_url":"https://api.github.com/repos/mrash/fwknop/subscription","commits_url":"https://api.github.com/repos/mrash/fwknop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrash/fwknop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrash/fwknop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrash/fwknop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrash/fwknop/contents/{+path}","compare_url":"https://api.github.com/repos/mrash/fwknop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrash/fwknop/merges","archive_url":"https://api.github.com/repos/mrash/fwknop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrash/fwknop/downloads","issues_url":"https://api.github.com/repos/mrash/fwknop/issues{/number}","pulls_url":"https://api.github.com/repos/mrash/fwknop/pulls{/number}","milestones_url":"https://api.github.com/repos/mrash/fwknop/milestones{/number}","notifications_url":"https://api.github.com/repos/mrash/fwknop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrash/fwknop/labels{/name}","releases_url":"https://api.github.com/repos/mrash/fwknop/releases{/id}","created_at":"2011-06-13T05:12:31Z","updated_at":"2015-12-29T13:02:37Z","pushed_at":"2015-12-30T01:47:33Z","git_url":"git://github.com/mrash/fwknop.git","ssh_url":"git@github.com:mrash/fwknop.git","clone_url":"https://github.com/mrash/fwknop.git","svn_url":"https://github.com/mrash/fwknop","homepage":"http://www.cipherdyne.org/fwknop/","size":15131,"stargazers_count":143,"watchers_count":143,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":38,"forks":40,"open_issues":38,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrash/fwknop/pulls/181"},"html":{"href":"https://github.com/mrash/fwknop/pull/181"},"issue":{"href":"https://api.github.com/repos/mrash/fwknop/issues/181"},"comments":{"href":"https://api.github.com/repos/mrash/fwknop/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/mrash/fwknop/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/mrash/fwknop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrash/fwknop/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/mrash/fwknop/statuses/4a7411ba5730d152b044da5df7d60d0d903a2d7b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mrash","id":380228,"avatar_url":"https://avatars.githubusercontent.com/u/380228?v=3","gravatar_id":"","url":"https://api.github.com/users/mrash","html_url":"https://github.com/mrash","followers_url":"https://api.github.com/users/mrash/followers","following_url":"https://api.github.com/users/mrash/following{/other_user}","gists_url":"https://api.github.com/users/mrash/gists{/gist_id}","starred_url":"https://api.github.com/users/mrash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrash/subscriptions","organizations_url":"https://api.github.com/users/mrash/orgs","repos_url":"https://api.github.com/users/mrash/repos","events_url":"https://api.github.com/users/mrash/events{/privacy}","received_events_url":"https://api.github.com/users/mrash/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":35,"deletions":3,"changed_files":2}}