{"action":"created","comment":{"url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/comments/42890855","id":42890855,"diff_hunk":"@@ -71,4 +146,15 @@ module.exports = function(grunt) {\n     task: 'package',\n     group: 'Operations'\n   });\n+\n+  function isValidTarget(target) {\n+    if (target.length) {\n+      var validTargets = ['acquia'];\n+      return (validTargets.indexOf(target) > -1);\n+    }\n+    else {\n+      return false;\n+    }","path":"tasks/package.js","position":145,"original_position":145,"commit_id":"f01ee024d97dfce21812b41c93d4948b9975d31f","original_commit_id":"f01ee024d97dfce21812b41c93d4948b9975d31f","user":{"login":"grayside","id":283489,"avatar_url":"https://avatars.githubusercontent.com/u/283489?v=3","gravatar_id":"","url":"https://api.github.com/users/grayside","html_url":"https://github.com/grayside","followers_url":"https://api.github.com/users/grayside/followers","following_url":"https://api.github.com/users/grayside/following{/other_user}","gists_url":"https://api.github.com/users/grayside/gists{/gist_id}","starred_url":"https://api.github.com/users/grayside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayside/subscriptions","organizations_url":"https://api.github.com/users/grayside/orgs","repos_url":"https://api.github.com/users/grayside/repos","events_url":"https://api.github.com/users/grayside/events{/privacy}","received_events_url":"https://api.github.com/users/grayside/received_events","type":"User","site_admin":false},"body":"I don't think we need to whitelist targets. Let people configure whichever keys they want to build out a target/profile. We should document any \"magic keys\" such as `acquia` that provide special sauce.","created_at":"2015-10-23T17:25:05Z","updated_at":"2015-10-23T17:25:05Z","html_url":"https://github.com/phase2/grunt-drupal-tasks/pull/195#discussion_r42890855","pull_request_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/comments/42890855"},"html":{"href":"https://github.com/phase2/grunt-drupal-tasks/pull/195#discussion_r42890855"},"pull_request":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195","id":48542534,"html_url":"https://github.com/phase2/grunt-drupal-tasks/pull/195","diff_url":"https://github.com/phase2/grunt-drupal-tasks/pull/195.diff","patch_url":"https://github.com/phase2/grunt-drupal-tasks/pull/195.patch","issue_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/195","number":195,"state":"open","locked":false,"title":"Initial swing and proof of concept for acquia packaging.","user":{"login":"mpgeek","id":1072643,"avatar_url":"https://avatars.githubusercontent.com/u/1072643?v=3","gravatar_id":"","url":"https://api.github.com/users/mpgeek","html_url":"https://github.com/mpgeek","followers_url":"https://api.github.com/users/mpgeek/followers","following_url":"https://api.github.com/users/mpgeek/following{/other_user}","gists_url":"https://api.github.com/users/mpgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mpgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpgeek/subscriptions","organizations_url":"https://api.github.com/users/mpgeek/orgs","repos_url":"https://api.github.com/users/mpgeek/repos","events_url":"https://api.github.com/users/mpgeek/events{/privacy}","received_events_url":"https://api.github.com/users/mpgeek/received_events","type":"User","site_admin":false},"body":"This is a work in progress. Issuing a PR for visibility and review. At this point i'm wondering if this is the right architecture for release packaging. Most importantly, packaging does a little disassembly of the `html` build (as the original `package` command does), and splits it out into subdirectories. This structure is inspired by teh [Vista Campus repo](https://bitbucket.org/phase2tech/vista-campus/), which is directly deployed to Acquia.\r\n\r\nAnother question here is how the packaging should be invoked. Right now it's\r\n\r\n```bash\r\ngrunt package --target=acquia\r\n```\r\n\r\nI thought it might make sense to have the `:compress` modifier work regardless of vendor target, but no work towards that was done. Compressing still works with the default command, i.e. no `--target` specifier.\r\n\r\nThe code style definitely needs work, as this is really POC-ey. Further, no work towards the recieving repository has been considered. The idea there is that should be configured by the derivative project.\r\n\r\nFinally, some thought might want to be thrown at how this will work with gadget. Does it make any sense to move the logic in its entirety to derivative project setup, rather than accounting for vendors on this side?\r\n","created_at":"2015-10-23T05:01:19Z","updated_at":"2015-10-23T17:25:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c2c35f62bd806843eb4846cf45025eea6f05f7c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195/commits","review_comments_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195/comments","review_comment_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/195/comments","statuses_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/statuses/f01ee024d97dfce21812b41c93d4948b9975d31f","head":{"label":"mpgeek:feature/release-packaging--acquia","ref":"feature/release-packaging--acquia","sha":"f01ee024d97dfce21812b41c93d4948b9975d31f","user":{"login":"mpgeek","id":1072643,"avatar_url":"https://avatars.githubusercontent.com/u/1072643?v=3","gravatar_id":"","url":"https://api.github.com/users/mpgeek","html_url":"https://github.com/mpgeek","followers_url":"https://api.github.com/users/mpgeek/followers","following_url":"https://api.github.com/users/mpgeek/following{/other_user}","gists_url":"https://api.github.com/users/mpgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mpgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpgeek/subscriptions","organizations_url":"https://api.github.com/users/mpgeek/orgs","repos_url":"https://api.github.com/users/mpgeek/repos","events_url":"https://api.github.com/users/mpgeek/events{/privacy}","received_events_url":"https://api.github.com/users/mpgeek/received_events","type":"User","site_admin":false},"repo":{"id":43723331,"name":"grunt-drupal-tasks","full_name":"mpgeek/grunt-drupal-tasks","owner":{"login":"mpgeek","id":1072643,"avatar_url":"https://avatars.githubusercontent.com/u/1072643?v=3","gravatar_id":"","url":"https://api.github.com/users/mpgeek","html_url":"https://github.com/mpgeek","followers_url":"https://api.github.com/users/mpgeek/followers","following_url":"https://api.github.com/users/mpgeek/following{/other_user}","gists_url":"https://api.github.com/users/mpgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/mpgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpgeek/subscriptions","organizations_url":"https://api.github.com/users/mpgeek/orgs","repos_url":"https://api.github.com/users/mpgeek/repos","events_url":"https://api.github.com/users/mpgeek/events{/privacy}","received_events_url":"https://api.github.com/users/mpgeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpgeek/grunt-drupal-tasks","description":"Grunt-based build and testing tasks for Drupal","fork":true,"url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks","forks_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/forks","keys_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/teams","hooks_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/hooks","issue_events_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/events","assignees_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/tags","blobs_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/languages","stargazers_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/stargazers","contributors_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/contributors","subscribers_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/subscribers","subscription_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/subscription","commits_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/merges","archive_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/downloads","issues_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/labels{/name}","releases_url":"https://api.github.com/repos/mpgeek/grunt-drupal-tasks/releases{/id}","created_at":"2015-10-06T01:12:01Z","updated_at":"2015-10-06T01:12:01Z","pushed_at":"2015-10-23T04:53:16Z","git_url":"git://github.com/mpgeek/grunt-drupal-tasks.git","ssh_url":"git@github.com:mpgeek/grunt-drupal-tasks.git","clone_url":"https://github.com/mpgeek/grunt-drupal-tasks.git","svn_url":"https://github.com/mpgeek/grunt-drupal-tasks","homepage":"","size":496,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phase2:master","ref":"master","sha":"d89be5fff9c15e0284e08b9aad62c0313b51d61b","user":{"login":"phase2","id":148441,"avatar_url":"https://avatars.githubusercontent.com/u/148441?v=3","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"repo":{"id":24077193,"name":"grunt-drupal-tasks","full_name":"phase2/grunt-drupal-tasks","owner":{"login":"phase2","id":148441,"avatar_url":"https://avatars.githubusercontent.com/u/148441?v=3","gravatar_id":"","url":"https://api.github.com/users/phase2","html_url":"https://github.com/phase2","followers_url":"https://api.github.com/users/phase2/followers","following_url":"https://api.github.com/users/phase2/following{/other_user}","gists_url":"https://api.github.com/users/phase2/gists{/gist_id}","starred_url":"https://api.github.com/users/phase2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase2/subscriptions","organizations_url":"https://api.github.com/users/phase2/orgs","repos_url":"https://api.github.com/users/phase2/repos","events_url":"https://api.github.com/users/phase2/events{/privacy}","received_events_url":"https://api.github.com/users/phase2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phase2/grunt-drupal-tasks","description":"Grunt-based build and testing tasks for Drupal","fork":false,"url":"https://api.github.com/repos/phase2/grunt-drupal-tasks","forks_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/forks","keys_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/teams","hooks_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/hooks","issue_events_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/events","assignees_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/tags","blobs_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/languages","stargazers_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/stargazers","contributors_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/contributors","subscribers_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/subscribers","subscription_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/subscription","commits_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/merges","archive_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/downloads","issues_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/labels{/name}","releases_url":"https://api.github.com/repos/phase2/grunt-drupal-tasks/releases{/id}","created_at":"2014-09-15T23:05:13Z","updated_at":"2015-10-09T18:59:01Z","pushed_at":"2015-10-23T05:01:20Z","git_url":"git://github.com/phase2/grunt-drupal-tasks.git","ssh_url":"git@github.com:phase2/grunt-drupal-tasks.git","clone_url":"https://github.com/phase2/grunt-drupal-tasks.git","svn_url":"https://github.com/phase2/grunt-drupal-tasks","homepage":"","size":2141,"stargazers_count":100,"watchers_count":100,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":34,"forks":30,"open_issues":34,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195"},"html":{"href":"https://github.com/phase2/grunt-drupal-tasks/pull/195"},"issue":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/195"},"comments":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/phase2/grunt-drupal-tasks/statuses/f01ee024d97dfce21812b41c93d4948b9975d31f"}}}}