{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22993086","id":22993086,"diff_hunk":"@@ -64,6 +64,11 @@\n     var req = {\n       addEventListener: function(name, cb) {\n         req['on' + name] = cb;\n+      },\n+      then: function(cb, eb) {\n+        // error-handler `eb`is never used, since the mock never fails.\n+        return Promise.resolve(0).then(cb); // set resolve to 0.\n+","path":"shared/test/unit/mocks/mock_navigator_moz_settings.js","position":8,"original_position":8,"commit_id":"a63175ae7293b6647f1649961a222dd6ce8dda5b","original_commit_id":"a63175ae7293b6647f1649961a222dd6ce8dda5b","user":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"body":"*moving the conversation back to [Bugzilla](https://bugzilla.mozilla.org/show_bug.cgi?id=1120947)*","created_at":"2015-01-15T06:44:21Z","updated_at":"2015-01-15T06:44:21Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27385#discussion_r22993086","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/22993086"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27385#discussion_r22993086"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385","id":27354902,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27385","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27385.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27385.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27385","number":27385,"state":"open","locked":false,"title":"Bug 1120947: settings mock now  properly then-able","user":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"body":"This is a less invasive patch for the same bug.","created_at":"2015-01-14T14:54:47Z","updated_at":"2015-01-15T06:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a65c4ce931881e84168031835c039f1d7b3b564a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27385/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a63175ae7293b6647f1649961a222dd6ce8dda5b","head":{"label":"mozfreddyb:bug-1120947-fix-settings-mock-thenable","ref":"bug-1120947-fix-settings-mock-thenable","sha":"a63175ae7293b6647f1649961a222dd6ce8dda5b","user":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"repo":{"id":12944840,"name":"gaia","full_name":"mozfreddyb/gaia","owner":{"login":"mozfreddyb","id":5418775,"avatar_url":"https://avatars.githubusercontent.com/u/5418775?v=3","gravatar_id":"","url":"https://api.github.com/users/mozfreddyb","html_url":"https://github.com/mozfreddyb","followers_url":"https://api.github.com/users/mozfreddyb/followers","following_url":"https://api.github.com/users/mozfreddyb/following{/other_user}","gists_url":"https://api.github.com/users/mozfreddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/mozfreddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozfreddyb/subscriptions","organizations_url":"https://api.github.com/users/mozfreddyb/orgs","repos_url":"https://api.github.com/users/mozfreddyb/repos","events_url":"https://api.github.com/users/mozfreddyb/events{/privacy}","received_events_url":"https://api.github.com/users/mozfreddyb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mozfreddyb/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","fork":true,"url":"https://api.github.com/repos/mozfreddyb/gaia","forks_url":"https://api.github.com/repos/mozfreddyb/gaia/forks","keys_url":"https://api.github.com/repos/mozfreddyb/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozfreddyb/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozfreddyb/gaia/teams","hooks_url":"https://api.github.com/repos/mozfreddyb/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozfreddyb/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozfreddyb/gaia/events","assignees_url":"https://api.github.com/repos/mozfreddyb/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozfreddyb/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozfreddyb/gaia/tags","blobs_url":"https://api.github.com/repos/mozfreddyb/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozfreddyb/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozfreddyb/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozfreddyb/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozfreddyb/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozfreddyb/gaia/languages","stargazers_url":"https://api.github.com/repos/mozfreddyb/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozfreddyb/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozfreddyb/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozfreddyb/gaia/subscription","commits_url":"https://api.github.com/repos/mozfreddyb/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozfreddyb/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozfreddyb/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozfreddyb/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozfreddyb/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozfreddyb/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozfreddyb/gaia/merges","archive_url":"https://api.github.com/repos/mozfreddyb/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozfreddyb/gaia/downloads","issues_url":"https://api.github.com/repos/mozfreddyb/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozfreddyb/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozfreddyb/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozfreddyb/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozfreddyb/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozfreddyb/gaia/releases{/id}","created_at":"2013-09-19T09:15:44Z","updated_at":"2014-08-04T08:54:43Z","pushed_at":"2015-01-14T15:11:08Z","git_url":"git://github.com/mozfreddyb/gaia.git","ssh_url":"git@github.com:mozfreddyb/gaia.git","clone_url":"https://github.com/mozfreddyb/gaia.git","svn_url":"https://github.com/mozfreddyb/gaia","homepage":"https://wiki.mozilla.org/B2G","size":853203,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"3d1d81bc3e731a58fb1f7b75bb8443f1c62a5ee2","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-01-15T06:07:39Z","pushed_at":"2015-01-15T06:07:38Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1378892,"stargazers_count":1851,"watchers_count":1851,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2161,"mirror_url":null,"open_issues_count":837,"forks":2161,"open_issues":837,"watchers":1851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27385"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27385"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27385/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27385/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/a63175ae7293b6647f1649961a222dd6ce8dda5b"}}}}