{"action":"created","issue":{"url":"https://api.github.com/repos/jdavis/twofactorauth/issues/982","labels_url":"https://api.github.com/repos/jdavis/twofactorauth/issues/982/labels{/name}","comments_url":"https://api.github.com/repos/jdavis/twofactorauth/issues/982/comments","events_url":"https://api.github.com/repos/jdavis/twofactorauth/issues/982/events","html_url":"https://github.com/jdavis/twofactorauth/pull/982","id":58516058,"number":982,"title":"Add 1Password to Providers","user":{"login":"ahelpingchip","id":735119,"avatar_url":"https://avatars.githubusercontent.com/u/735119?v=3","gravatar_id":"","url":"https://api.github.com/users/ahelpingchip","html_url":"https://github.com/ahelpingchip","followers_url":"https://api.github.com/users/ahelpingchip/followers","following_url":"https://api.github.com/users/ahelpingchip/following{/other_user}","gists_url":"https://api.github.com/users/ahelpingchip/gists{/gist_id}","starred_url":"https://api.github.com/users/ahelpingchip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahelpingchip/subscriptions","organizations_url":"https://api.github.com/users/ahelpingchip/orgs","repos_url":"https://api.github.com/users/ahelpingchip/repos","events_url":"https://api.github.com/users/ahelpingchip/events{/privacy}","received_events_url":"https://api.github.com/users/ahelpingchip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-02-22T20:04:46Z","updated_at":"2015-02-22T20:41:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jdavis/twofactorauth/pulls/982","html_url":"https://github.com/jdavis/twofactorauth/pull/982","diff_url":"https://github.com/jdavis/twofactorauth/pull/982.diff","patch_url":"https://github.com/jdavis/twofactorauth/pull/982.patch"},"body":"Before anything else, yes, I know 1Password is on the Blacklist/Exclusion list. :)\r\n\r\nI think this addition bears merit, however, since I am adding 1Password as a *2FA Provider*. 1Password recently added the ability to generate TOTP tokens — in other words, it can perform the same function that Google Authenticator provides.\r\n\r\nhttps://blog.agilebits.com/2015/01/26/totp-for-1password-users/\r\n\r\nOf course, worth noting is that AgileBits themselves say that using 1Password in this manner is arguably *not* 2FA, since you are storing your TOTP token and password in the same place. That all said, I still believe it is worth adding:\r\n\r\n* A user could conceivably generate his/her TOTP token in 1Password without also storing his/her password there. (this is admittedly a bit contrived.)\r\n* In many cases, people who use password managers on their phone (1Password, Keepass, Dashlane) already have their TOTP tokens in another app on the same phone anyway (Google Authenticator, Authy). Putting them now in the same app is not significantly less secure.\r\n* This might be a feature not too many people are aware of, so I think it's worth adding for awareness' sake.\r\n\r\nMy apologies if I end up starting another long debate. :)"},"comment":{"url":"https://api.github.com/repos/jdavis/twofactorauth/issues/comments/75456545","html_url":"https://github.com/jdavis/twofactorauth/pull/982#issuecomment-75456545","issue_url":"https://api.github.com/repos/jdavis/twofactorauth/issues/982","id":75456545,"user":{"login":"jamcat22","id":1897053,"avatar_url":"https://avatars.githubusercontent.com/u/1897053?v=3","gravatar_id":"","url":"https://api.github.com/users/jamcat22","html_url":"https://github.com/jamcat22","followers_url":"https://api.github.com/users/jamcat22/followers","following_url":"https://api.github.com/users/jamcat22/following{/other_user}","gists_url":"https://api.github.com/users/jamcat22/gists{/gist_id}","starred_url":"https://api.github.com/users/jamcat22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamcat22/subscriptions","organizations_url":"https://api.github.com/users/jamcat22/orgs","repos_url":"https://api.github.com/users/jamcat22/repos","events_url":"https://api.github.com/users/jamcat22/events{/privacy}","received_events_url":"https://api.github.com/users/jamcat22/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T20:41:42Z","updated_at":"2015-02-22T20:41:42Z","body":"I don't think it should be a provider because as I understand it it just allows you to add Google Authenticator tokens to the app. It doesn't look like it has its own token protocol.\n\nI love that they have added the functionality, but I think the providers section is for different ways for websites to use 2FA, and Google Authenticator is already on there.\n"}}