{"action":"created","issue":{"url":"https://api.github.com/repos/oscarotero/Gettext/issues/72","labels_url":"https://api.github.com/repos/oscarotero/Gettext/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/oscarotero/Gettext/issues/72/comments","events_url":"https://api.github.com/repos/oscarotero/Gettext/issues/72/events","html_url":"https://github.com/oscarotero/Gettext/pull/72","id":71603628,"number":72,"title":"Avoid adding empty strings","user":{"login":"mlocati","id":928116,"avatar_url":"https://avatars.githubusercontent.com/u/928116?v=3","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-28T14:22:43Z","updated_at":"2015-04-28T14:34:08Z","closed_at":"2015-04-28T14:33:53Z","pull_request":{"url":"https://api.github.com/repos/oscarotero/Gettext/pulls/72","html_url":"https://github.com/oscarotero/Gettext/pull/72","diff_url":"https://github.com/oscarotero/Gettext/pull/72.diff","patch_url":"https://github.com/oscarotero/Gettext/pull/72.patch"},"body":"The PhpFunctionsScanner extracts empty strings too (eg `echo __('');`). So, we risk to generate a .po file like this:\r\n```po\r\n# PO headers\r\nmsgid \"\"\r\nmsgstr \"\"\r\n\"Header 1: value\\n\"\r\n\"Header 2: value\\n\"\r\n\r\n# Empty string extracted from code\r\nmsgid \"\"\r\nmsgstr \"\"\r\n\r\n...\r\n```\r\nThis is wrong, since the msgid must be unique (and this specific case messes up the gettext headers)."},"comment":{"url":"https://api.github.com/repos/oscarotero/Gettext/issues/comments/97085988","html_url":"https://github.com/oscarotero/Gettext/pull/72#issuecomment-97085988","issue_url":"https://api.github.com/repos/oscarotero/Gettext/issues/72","id":97085988,"user":{"login":"oscarotero","id":377873,"avatar_url":"https://avatars.githubusercontent.com/u/377873?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarotero","html_url":"https://github.com/oscarotero","followers_url":"https://api.github.com/users/oscarotero/followers","following_url":"https://api.github.com/users/oscarotero/following{/other_user}","gists_url":"https://api.github.com/users/oscarotero/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarotero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarotero/subscriptions","organizations_url":"https://api.github.com/users/oscarotero/orgs","repos_url":"https://api.github.com/users/oscarotero/repos","events_url":"https://api.github.com/users/oscarotero/events{/privacy}","received_events_url":"https://api.github.com/users/oscarotero/received_events","type":"User","site_admin":false},"created_at":"2015-04-28T14:34:08Z","updated_at":"2015-04-28T14:34:08Z","body":"Thank you :)"}}