{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23359888","id":23359888,"diff_hunk":"@@ -124,9 +124,11 @@ bool CGUIWindowPVRChannels::Update(const std::string &strDirectory, bool updateF\n   bool bReturn = CGUIWindowPVRBase::Update(strDirectory);\n \n   /* empty list for hidden channels */\n-  if (m_vecItems->Size() == 0 && m_bShowHiddenChannels)","path":"xbmc/pvr/windows/GUIWindowPVRChannels.cpp","position":4,"original_position":4,"commit_id":"3e0fa45518db053b443667cd230ee7ee73c21573","original_commit_id":"3e0fa45518db053b443667cd230ee7ee73c21573","user":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"body":"I think this whole method is not needed anymore (@xhaggi?) since it should not be possible to set `m_bShowHiddenChannels` to true unless there actually are some hidden channels to display.","created_at":"2015-01-22T07:58:14Z","updated_at":"2015-01-22T07:58:14Z","html_url":"https://github.com/xbmc/xbmc/pull/6238#discussion_r23359888","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6238","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23359888"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6238#discussion_r23359888"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6238"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6238","id":27784187,"html_url":"https://github.com/xbmc/xbmc/pull/6238","diff_url":"https://github.com/xbmc/xbmc/pull/6238.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6238.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6238","number":6238,"state":"open","locked":false,"title":"[PVR] Fix CGUIWindowPVRChannels::Update (back from hidden can not work)","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"Found during creation from indication of deleted recordings and undelete of them a fault on the PVR channel window, the \"m_vecItems->Size()\" return always minimum one (folder back as last) this changed to \"m_vecItems->GetObjectCount() == 0\" works and go back to normal channels if no hidden is present.\r\n","created_at":"2015-01-21T18:47:48Z","updated_at":"2015-01-22T07:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c429f055db57e409c8d08247cf0b9c540e933f33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6238/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6238/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6238/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/3e0fa45518db053b443667cd230ee7ee73c21573","head":{"label":"AlwinEsch:CGUIWindowPVRChannels_Update_Fix","ref":"CGUIWindowPVRChannels_Update_Fix","sha":"3e0fa45518db053b443667cd230ee7ee73c21573","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"repo":{"id":17647639,"name":"kodi","full_name":"AlwinEsch/kodi","owner":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlwinEsch/kodi","description":"Kodi Main Repository","fork":true,"url":"https://api.github.com/repos/AlwinEsch/kodi","forks_url":"https://api.github.com/repos/AlwinEsch/kodi/forks","keys_url":"https://api.github.com/repos/AlwinEsch/kodi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlwinEsch/kodi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlwinEsch/kodi/teams","hooks_url":"https://api.github.com/repos/AlwinEsch/kodi/hooks","issue_events_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/events{/number}","events_url":"https://api.github.com/repos/AlwinEsch/kodi/events","assignees_url":"https://api.github.com/repos/AlwinEsch/kodi/assignees{/user}","branches_url":"https://api.github.com/repos/AlwinEsch/kodi/branches{/branch}","tags_url":"https://api.github.com/repos/AlwinEsch/kodi/tags","blobs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlwinEsch/kodi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlwinEsch/kodi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlwinEsch/kodi/statuses/{sha}","languages_url":"https://api.github.com/repos/AlwinEsch/kodi/languages","stargazers_url":"https://api.github.com/repos/AlwinEsch/kodi/stargazers","contributors_url":"https://api.github.com/repos/AlwinEsch/kodi/contributors","subscribers_url":"https://api.github.com/repos/AlwinEsch/kodi/subscribers","subscription_url":"https://api.github.com/repos/AlwinEsch/kodi/subscription","commits_url":"https://api.github.com/repos/AlwinEsch/kodi/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlwinEsch/kodi/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlwinEsch/kodi/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/comments/{number}","contents_url":"https://api.github.com/repos/AlwinEsch/kodi/contents/{+path}","compare_url":"https://api.github.com/repos/AlwinEsch/kodi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlwinEsch/kodi/merges","archive_url":"https://api.github.com/repos/AlwinEsch/kodi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlwinEsch/kodi/downloads","issues_url":"https://api.github.com/repos/AlwinEsch/kodi/issues{/number}","pulls_url":"https://api.github.com/repos/AlwinEsch/kodi/pulls{/number}","milestones_url":"https://api.github.com/repos/AlwinEsch/kodi/milestones{/number}","notifications_url":"https://api.github.com/repos/AlwinEsch/kodi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlwinEsch/kodi/labels{/name}","releases_url":"https://api.github.com/repos/AlwinEsch/kodi/releases{/id}","created_at":"2014-03-11T22:34:10Z","updated_at":"2015-01-21T18:54:12Z","pushed_at":"2015-01-21T23:02:50Z","git_url":"git://github.com/AlwinEsch/kodi.git","ssh_url":"git@github.com:AlwinEsch/kodi.git","clone_url":"https://github.com/AlwinEsch/kodi.git","svn_url":"https://github.com/AlwinEsch/kodi","homepage":"http://kodi.tv","size":494960,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"2625161eea2c83152c364b671c9b9ea07c01d277","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-01-22T07:54:05Z","pushed_at":"2015-01-22T07:54:05Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1798084,"stargazers_count":3631,"watchers_count":3631,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2611,"mirror_url":null,"open_issues_count":254,"forks":2611,"open_issues":254,"watchers":3631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6238"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6238"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6238"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6238/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6238/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6238/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/3e0fa45518db053b443667cd230ee7ee73c21573"}}}}