{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/43147659","id":43147659,"diff_hunk":"@@ -13,7 +13,7 @@ We should try and list out all the validation rules we know of by file type. E.g\n | :x: | banned_identifier | | Banned or deprecated JavaScript Identifier | | | | |\n | :x: | complex_prefs_defaults_code | | Complex code should not appear in preference defaults files | | | | |\n | :x: | called_dangerous_global | | `%s` called in potentially dangerous manner' | | | | |\n-| :x: | eval | | In order to prevent vulnerabilities, the `setTimeout` 'and `setInterval` functions should be called only with function expressions as their first argument. | | | | |\n+| :x: | EVAL | | In order to prevent vulnerabilities, the `setTimeout` 'and `setInterval` functions should be called only with function expressions as their first argument. | | [testcases/javascript/actions.py](https://github.com/mozilla/amo-validator/blob/7a8011aba8bf8c665aef2b51eb26d0697b3e19c3/validator/testcases/javascript/actions.py#L488) | | |","path":"docs/rules.md","position":5,"original_position":5,"commit_id":"11a9440bcd24ce395bb5e13e627ed88fec2648f9","original_commit_id":"11a9440bcd24ce395bb5e13e627ed88fec2648f9","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"EVAL  should go in the last column.","created_at":"2015-10-27T16:33:57Z","updated_at":"2015-10-27T16:33:57Z","html_url":"https://github.com/mozilla/addons-validator/pull/163#discussion_r43147659","pull_request_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/163","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/43147659"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/163#discussion_r43147659"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/163","id":48896214,"html_url":"https://github.com/mozilla/addons-validator/pull/163","diff_url":"https://github.com/mozilla/addons-validator/pull/163.diff","patch_url":"https://github.com/mozilla/addons-validator/pull/163.patch","issue_url":"https://api.github.com/repos/mozilla/addons-validator/issues/163","number":163,"state":"open","locked":false,"title":"Create amend JS rule","user":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"body":"Resolves #111","created_at":"2015-10-27T16:31:27Z","updated_at":"2015-10-27T16:33:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"643ee8ea1b1ae925aff83698c17e0f1b6fa0dd62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/163/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/163/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/issues/163/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/11a9440bcd24ce395bb5e13e627ed88fec2648f9","head":{"label":"Nolski:eval","ref":"eval","sha":"11a9440bcd24ce395bb5e13e627ed88fec2648f9","user":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"repo":{"id":44769156,"name":"addons-validator","full_name":"Nolski/addons-validator","owner":{"login":"Nolski","id":2600677,"avatar_url":"https://avatars.githubusercontent.com/u/2600677?v=3","gravatar_id":"","url":"https://api.github.com/users/Nolski","html_url":"https://github.com/Nolski","followers_url":"https://api.github.com/users/Nolski/followers","following_url":"https://api.github.com/users/Nolski/following{/other_user}","gists_url":"https://api.github.com/users/Nolski/gists{/gist_id}","starred_url":"https://api.github.com/users/Nolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nolski/subscriptions","organizations_url":"https://api.github.com/users/Nolski/orgs","repos_url":"https://api.github.com/users/Nolski/repos","events_url":"https://api.github.com/users/Nolski/events{/privacy}","received_events_url":"https://api.github.com/users/Nolski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nolski/addons-validator","description":"The new Firefox Add-ons validator, written in ES6/JavaScript.","fork":true,"url":"https://api.github.com/repos/Nolski/addons-validator","forks_url":"https://api.github.com/repos/Nolski/addons-validator/forks","keys_url":"https://api.github.com/repos/Nolski/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nolski/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nolski/addons-validator/teams","hooks_url":"https://api.github.com/repos/Nolski/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/Nolski/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/Nolski/addons-validator/events","assignees_url":"https://api.github.com/repos/Nolski/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/Nolski/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/Nolski/addons-validator/tags","blobs_url":"https://api.github.com/repos/Nolski/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nolski/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nolski/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nolski/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nolski/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Nolski/addons-validator/languages","stargazers_url":"https://api.github.com/repos/Nolski/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/Nolski/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/Nolski/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/Nolski/addons-validator/subscription","commits_url":"https://api.github.com/repos/Nolski/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nolski/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nolski/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nolski/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nolski/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/Nolski/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nolski/addons-validator/merges","archive_url":"https://api.github.com/repos/Nolski/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nolski/addons-validator/downloads","issues_url":"https://api.github.com/repos/Nolski/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/Nolski/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Nolski/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Nolski/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nolski/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/Nolski/addons-validator/releases{/id}","created_at":"2015-10-22T19:44:20Z","updated_at":"2015-10-22T19:44:21Z","pushed_at":"2015-10-27T16:32:27Z","git_url":"git://github.com/Nolski/addons-validator.git","ssh_url":"git@github.com:Nolski/addons-validator.git","clone_url":"https://github.com/Nolski/addons-validator.git","svn_url":"https://github.com/Nolski/addons-validator","homepage":"","size":1424,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6e49a8dd2649f93da5436e7229165768480535f1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":42436885,"name":"addons-validator","full_name":"mozilla/addons-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-validator","description":"The new Firefox Add-ons validator, written in ES6/JavaScript.","fork":false,"url":"https://api.github.com/repos/mozilla/addons-validator","forks_url":"https://api.github.com/repos/mozilla/addons-validator/forks","keys_url":"https://api.github.com/repos/mozilla/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-validator/events","assignees_url":"https://api.github.com/repos/mozilla/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-validator/merges","archive_url":"https://api.github.com/repos/mozilla/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-validator/releases{/id}","created_at":"2015-09-14T08:34:44Z","updated_at":"2015-10-24T03:57:22Z","pushed_at":"2015-10-27T16:32:27Z","git_url":"git://github.com/mozilla/addons-validator.git","ssh_url":"git@github.com:mozilla/addons-validator.git","clone_url":"https://github.com/mozilla/addons-validator.git","svn_url":"https://github.com/mozilla/addons-validator","homepage":"","size":1424,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":38,"forks":2,"open_issues":38,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/163"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/163"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/163"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-validator/statuses/11a9440bcd24ce395bb5e13e627ed88fec2648f9"}}}}