{"action":"created","comment":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/46169334","id":46169334,"diff_hunk":"@@ -139,6 +139,22 @@ func (s *RingpopTestSuite) TestHandleEvents() {\n \ts.Equal(11, listener.EventCount(), \"expected 11 total events to be recorded\")\n }\n \n+func (s *RingpopTestSuite) TestRingpopReady() {\n+\ts.False(s.ringpop.Ready())\n+\t// Create single node cluster.\n+\ts.ringpop.Bootstrap(&BootstrapOptions{\n+\t\tswim.BootstrapOptions{\n+\t\t\tHosts: []string{\"127.0.0.1:3001\"},","path":"ringpop_test.go","position":9,"original_position":9,"commit_id":"7243fbeda809d8733dba96f63c038d70d11d2f9f","original_commit_id":"7243fbeda809d8733dba96f63c038d70d11d2f9f","user":{"login":"dansimau","id":203031,"avatar_url":"https://avatars.githubusercontent.com/u/203031?v=3","gravatar_id":"","url":"https://api.github.com/users/dansimau","html_url":"https://github.com/dansimau","followers_url":"https://api.github.com/users/dansimau/followers","following_url":"https://api.github.com/users/dansimau/following{/other_user}","gists_url":"https://api.github.com/users/dansimau/gists{/gist_id}","starred_url":"https://api.github.com/users/dansimau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansimau/subscriptions","organizations_url":"https://api.github.com/users/dansimau/orgs","repos_url":"https://api.github.com/users/dansimau/repos","events_url":"https://api.github.com/users/dansimau/events{/privacy}","received_events_url":"https://api.github.com/users/dansimau/received_events","type":"User","site_admin":false},"body":"Yes, because calling Bootstrap with a host list that contains only yourself creates a single node cluster.","created_at":"2015-11-30T16:52:07Z","updated_at":"2015-11-30T16:52:07Z","html_url":"https://github.com/uber/ringpop-go/pull/32#discussion_r46169334","pull_request_url":"https://api.github.com/repos/uber/ringpop-go/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments/46169334"},"html":{"href":"https://github.com/uber/ringpop-go/pull/32#discussion_r46169334"},"pull_request":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/32","id":52146529,"html_url":"https://github.com/uber/ringpop-go/pull/32","diff_url":"https://github.com/uber/ringpop-go/pull/32.diff","patch_url":"https://github.com/uber/ringpop-go/pull/32.patch","issue_url":"https://api.github.com/repos/uber/ringpop-go/issues/32","number":32,"state":"open","locked":false,"title":"Add Ringpop.Ready() method","user":{"login":"dansimau","id":203031,"avatar_url":"https://avatars.githubusercontent.com/u/203031?v=3","gravatar_id":"","url":"https://api.github.com/users/dansimau","html_url":"https://github.com/dansimau","followers_url":"https://api.github.com/users/dansimau/followers","following_url":"https://api.github.com/users/dansimau/following{/other_user}","gists_url":"https://api.github.com/users/dansimau/gists{/gist_id}","starred_url":"https://api.github.com/users/dansimau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansimau/subscriptions","organizations_url":"https://api.github.com/users/dansimau/orgs","repos_url":"https://api.github.com/users/dansimau/repos","events_url":"https://api.github.com/users/dansimau/events{/privacy}","received_events_url":"https://api.github.com/users/dansimau/received_events","type":"User","site_admin":false},"body":"Returns whether or not Ringpop is bootstrapped and thus ready to receive\r\nrequests. This is analogous to the IsReady flag in ringpop-node.","created_at":"2015-11-30T16:33:17Z","updated_at":"2015-11-30T16:52:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd46cd90304b98bb3e0225f5a67cfa7d83c78058","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop-go/pulls/32/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop-go/pulls/32/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop-go/issues/32/comments","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/7243fbeda809d8733dba96f63c038d70d11d2f9f","head":{"label":"uber:ready-flag","ref":"ready-flag","sha":"7243fbeda809d8733dba96f63c038d70d11d2f9f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","created_at":"2015-06-05T22:48:53Z","updated_at":"2015-11-30T06:02:18Z","pushed_at":"2015-11-30T16:48:24Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":1779,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":21,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"fac97a2501efb45e5edb5e4f6098570dce158466","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":36959143,"name":"ringpop-go","full_name":"uber/ringpop-go","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop-go","description":"Scalable, fault-tolerant application-layer sharding for Go applications","fork":false,"url":"https://api.github.com/repos/uber/ringpop-go","forks_url":"https://api.github.com/repos/uber/ringpop-go/forks","keys_url":"https://api.github.com/repos/uber/ringpop-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop-go/teams","hooks_url":"https://api.github.com/repos/uber/ringpop-go/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop-go/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop-go/events","assignees_url":"https://api.github.com/repos/uber/ringpop-go/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop-go/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop-go/tags","blobs_url":"https://api.github.com/repos/uber/ringpop-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop-go/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop-go/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop-go/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop-go/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop-go/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop-go/subscription","commits_url":"https://api.github.com/repos/uber/ringpop-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop-go/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop-go/merges","archive_url":"https://api.github.com/repos/uber/ringpop-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop-go/downloads","issues_url":"https://api.github.com/repos/uber/ringpop-go/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop-go/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop-go/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop-go/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop-go/releases{/id}","created_at":"2015-06-05T22:48:53Z","updated_at":"2015-11-30T06:02:18Z","pushed_at":"2015-11-30T16:48:24Z","git_url":"git://github.com/uber/ringpop-go.git","ssh_url":"git@github.com:uber/ringpop-go.git","clone_url":"https://github.com/uber/ringpop-go.git","svn_url":"https://github.com/uber/ringpop-go","homepage":"http://www.uber.com","size":1779,"stargazers_count":21,"watchers_count":21,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/32"},"html":{"href":"https://github.com/uber/ringpop-go/pull/32"},"issue":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/32"},"comments":{"href":"https://api.github.com/repos/uber/ringpop-go/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop-go/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop-go/statuses/7243fbeda809d8733dba96f63c038d70d11d2f9f"}}}}