{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72","id":47297033,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/72","diff_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/72.diff","patch_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/72.patch","issue_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/72","number":72,"state":"closed","locked":false,"title":"move use of existing vertex into generator base class","user":{"login":"pinkenburg","id":7316141,"avatar_url":"https://avatars.githubusercontent.com/u/7316141?v=3","gravatar_id":"","url":"https://api.github.com/users/pinkenburg","html_url":"https://github.com/pinkenburg","followers_url":"https://api.github.com/users/pinkenburg/followers","following_url":"https://api.github.com/users/pinkenburg/following{/other_user}","gists_url":"https://api.github.com/users/pinkenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkenburg/subscriptions","organizations_url":"https://api.github.com/users/pinkenburg/orgs","repos_url":"https://api.github.com/users/pinkenburg/repos","events_url":"https://api.github.com/users/pinkenburg/events{/privacy}","received_events_url":"https://api.github.com/users/pinkenburg/received_events","type":"User","site_admin":false},"body":"I moved that code from the simple event generator into the PHG4ParticleGeneratorBase class and added a call to it to the other single particle generators. It works as before - please in the future put common functionality like this into the base class. Less work for everyone else","created_at":"2015-10-09T17:16:37Z","updated_at":"2015-10-09T17:39:26Z","closed_at":"2015-10-09T17:39:26Z","merged_at":"2015-10-09T17:39:26Z","merge_commit_sha":"59d99cb63a5b2c78d84b4bbfceaf3a1645b8ae1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72/commits","review_comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72/comments","review_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/72/comments","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/66103a9d6f24076330e8f1db0a7c612690ca627b","head":{"label":"pinkenburg:master","ref":"master","sha":"66103a9d6f24076330e8f1db0a7c612690ca627b","user":{"login":"pinkenburg","id":7316141,"avatar_url":"https://avatars.githubusercontent.com/u/7316141?v=3","gravatar_id":"","url":"https://api.github.com/users/pinkenburg","html_url":"https://github.com/pinkenburg","followers_url":"https://api.github.com/users/pinkenburg/followers","following_url":"https://api.github.com/users/pinkenburg/following{/other_user}","gists_url":"https://api.github.com/users/pinkenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkenburg/subscriptions","organizations_url":"https://api.github.com/users/pinkenburg/orgs","repos_url":"https://api.github.com/users/pinkenburg/repos","events_url":"https://api.github.com/users/pinkenburg/events{/privacy}","received_events_url":"https://api.github.com/users/pinkenburg/received_events","type":"User","site_admin":false},"repo":{"id":40304296,"name":"coresoftware","full_name":"pinkenburg/coresoftware","owner":{"login":"pinkenburg","id":7316141,"avatar_url":"https://avatars.githubusercontent.com/u/7316141?v=3","gravatar_id":"","url":"https://api.github.com/users/pinkenburg","html_url":"https://github.com/pinkenburg","followers_url":"https://api.github.com/users/pinkenburg/followers","following_url":"https://api.github.com/users/pinkenburg/following{/other_user}","gists_url":"https://api.github.com/users/pinkenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkenburg/subscriptions","organizations_url":"https://api.github.com/users/pinkenburg/orgs","repos_url":"https://api.github.com/users/pinkenburg/repos","events_url":"https://api.github.com/users/pinkenburg/events{/privacy}","received_events_url":"https://api.github.com/users/pinkenburg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pinkenburg/coresoftware","description":"Our big core software repository","fork":true,"url":"https://api.github.com/repos/pinkenburg/coresoftware","forks_url":"https://api.github.com/repos/pinkenburg/coresoftware/forks","keys_url":"https://api.github.com/repos/pinkenburg/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pinkenburg/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pinkenburg/coresoftware/teams","hooks_url":"https://api.github.com/repos/pinkenburg/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/pinkenburg/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/pinkenburg/coresoftware/events","assignees_url":"https://api.github.com/repos/pinkenburg/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/pinkenburg/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/pinkenburg/coresoftware/tags","blobs_url":"https://api.github.com/repos/pinkenburg/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pinkenburg/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pinkenburg/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/pinkenburg/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pinkenburg/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/pinkenburg/coresoftware/languages","stargazers_url":"https://api.github.com/repos/pinkenburg/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/pinkenburg/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/pinkenburg/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/pinkenburg/coresoftware/subscription","commits_url":"https://api.github.com/repos/pinkenburg/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/pinkenburg/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/pinkenburg/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/pinkenburg/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/pinkenburg/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/pinkenburg/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pinkenburg/coresoftware/merges","archive_url":"https://api.github.com/repos/pinkenburg/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pinkenburg/coresoftware/downloads","issues_url":"https://api.github.com/repos/pinkenburg/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/pinkenburg/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/pinkenburg/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/pinkenburg/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pinkenburg/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/pinkenburg/coresoftware/releases{/id}","created_at":"2015-08-06T12:45:06Z","updated_at":"2015-08-06T12:45:08Z","pushed_at":"2015-10-09T17:02:58Z","git_url":"git://github.com/pinkenburg/coresoftware.git","ssh_url":"git@github.com:pinkenburg/coresoftware.git","clone_url":"https://github.com/pinkenburg/coresoftware.git","svn_url":"https://github.com/pinkenburg/coresoftware","homepage":null,"size":2971,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sPHENIX-Collaboration:master","ref":"master","sha":"baf507afd2cdf636a72bd65b9348ff83de894d6b","user":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":34742432,"name":"coresoftware","full_name":"sPHENIX-Collaboration/coresoftware","owner":{"login":"sPHENIX-Collaboration","id":12069843,"avatar_url":"https://avatars.githubusercontent.com/u/12069843?v=3","gravatar_id":"","url":"https://api.github.com/users/sPHENIX-Collaboration","html_url":"https://github.com/sPHENIX-Collaboration","followers_url":"https://api.github.com/users/sPHENIX-Collaboration/followers","following_url":"https://api.github.com/users/sPHENIX-Collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sPHENIX-Collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sPHENIX-Collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sPHENIX-Collaboration/subscriptions","organizations_url":"https://api.github.com/users/sPHENIX-Collaboration/orgs","repos_url":"https://api.github.com/users/sPHENIX-Collaboration/repos","events_url":"https://api.github.com/users/sPHENIX-Collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sPHENIX-Collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sPHENIX-Collaboration/coresoftware","description":"Our big core software repository","fork":false,"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware","forks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/forks","keys_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/teams","hooks_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/hooks","issue_events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/events{/number}","events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/events","assignees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/assignees{/user}","branches_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/branches{/branch}","tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/tags","blobs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/refs{/sha}","trees_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/{sha}","languages_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/languages","stargazers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/stargazers","contributors_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contributors","subscribers_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscribers","subscription_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/subscription","commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/commits{/sha}","git_commits_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/git/commits{/sha}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/comments{/number}","issue_comment_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/comments{/number}","contents_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/contents/{+path}","compare_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/merges","archive_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/downloads","issues_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues{/number}","pulls_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls{/number}","milestones_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/milestones{/number}","notifications_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/labels{/name}","releases_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/releases{/id}","created_at":"2015-04-28T16:29:55Z","updated_at":"2015-09-22T14:48:05Z","pushed_at":"2015-10-09T17:39:27Z","git_url":"git://github.com/sPHENIX-Collaboration/coresoftware.git","ssh_url":"git@github.com:sPHENIX-Collaboration/coresoftware.git","clone_url":"https://github.com/sPHENIX-Collaboration/coresoftware.git","svn_url":"https://github.com/sPHENIX-Collaboration/coresoftware","homepage":"https://wiki.bnl.gov/sPHENIX/index.php/Main_Page","size":3877,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72"},"html":{"href":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/72"},"issue":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/72"},"comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/statuses/66103a9d6f24076330e8f1db0a7c612690ca627b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pinkenburg","id":7316141,"avatar_url":"https://avatars.githubusercontent.com/u/7316141?v=3","gravatar_id":"","url":"https://api.github.com/users/pinkenburg","html_url":"https://github.com/pinkenburg","followers_url":"https://api.github.com/users/pinkenburg/followers","following_url":"https://api.github.com/users/pinkenburg/following{/other_user}","gists_url":"https://api.github.com/users/pinkenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkenburg/subscriptions","organizations_url":"https://api.github.com/users/pinkenburg/orgs","repos_url":"https://api.github.com/users/pinkenburg/repos","events_url":"https://api.github.com/users/pinkenburg/events{/privacy}","received_events_url":"https://api.github.com/users/pinkenburg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":126,"deletions":106,"changed_files":8}}