{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/34581426","id":34581426,"diff_hunk":"@@ -0,0 +1,161 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.serializer\n+\n+import java.io.ByteArrayOutputStream\n+import java.nio.ByteBuffer\n+import java.util.zip.{Inflater, Deflater}\n+\n+import scala.collection.mutable\n+\n+import com.esotericsoftware.kryo.{Kryo, Serializer => KSerializer}\n+import com.esotericsoftware.kryo.io.{Input => KryoInput, Output => KryoOutput}\n+import org.apache.avro.generic.{GenericData, GenericRecord}\n+import org.apache.avro.io._\n+import org.apache.avro.{Schema, SchemaNormalization}","path":"core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala","position":30,"original_position":30,"commit_id":"d421bf5e54eb4678c6d21a44d100e84fe19d94ed","original_commit_id":"d421bf5e54eb4678c6d21a44d100e84fe19d94ed","user":{"login":"squito","id":71240,"avatar_url":"https://avatars.githubusercontent.com/u/71240?v=3","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"body":"super nit: class imports go before more deeply nested packages (its not just alphabetic), so it should be:\r\n\r\n```\r\nimport org.apache.avro.{Schema, SchemaNormalization}\r\nimport org.apache.avro.generic.{GenericData, GenericRecord}\r\nimport org.apache.avro.io._\r\n```\r\n\r\nI recommend using the **plugin** (not IntelliJ's builtin ordering) as described on the wiki: https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide#SparkCodeStyleGuide-Imports","created_at":"2015-07-14T15:31:28Z","updated_at":"2015-07-14T15:31:28Z","html_url":"https://github.com/apache/spark/pull/7004#discussion_r34581426","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7004","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/34581426"},"html":{"href":"https://github.com/apache/spark/pull/7004#discussion_r34581426"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7004"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7004","id":38500023,"html_url":"https://github.com/apache/spark/pull/7004","diff_url":"https://github.com/apache/spark/pull/7004.diff","patch_url":"https://github.com/apache/spark/pull/7004.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7004","number":7004,"state":"open","locked":false,"title":"[SPARK-746][CORE] Added Avro Serialization to Kryo","user":{"login":"JDrit","id":2280727,"avatar_url":"https://avatars.githubusercontent.com/u/2280727?v=3","gravatar_id":"","url":"https://api.github.com/users/JDrit","html_url":"https://github.com/JDrit","followers_url":"https://api.github.com/users/JDrit/followers","following_url":"https://api.github.com/users/JDrit/following{/other_user}","gists_url":"https://api.github.com/users/JDrit/gists{/gist_id}","starred_url":"https://api.github.com/users/JDrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDrit/subscriptions","organizations_url":"https://api.github.com/users/JDrit/orgs","repos_url":"https://api.github.com/users/JDrit/repos","events_url":"https://api.github.com/users/JDrit/events{/privacy}","received_events_url":"https://api.github.com/users/JDrit/received_events","type":"User","site_admin":false},"body":"Added a custom Kryo serializer for generic Avro records to reduce the network IO\r\ninvolved during a shuffle. This compresses the schema and allows for users to\r\nregister their schemas ahead of time to further reduce traffic.\r\n\r\nCurrently Kryo tries to use its default serializer for generic Records, which will include\r\na lot of unneeded data in each record.\r\n","created_at":"2015-06-24T23:53:24Z","updated_at":"2015-07-14T15:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57986e4ac97128ce3baa90ef15f70e776c847195","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7004/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7004/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7004/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/d421bf5e54eb4678c6d21a44d100e84fe19d94ed","head":{"label":"JDrit:Avro_serialization","ref":"Avro_serialization","sha":"d421bf5e54eb4678c6d21a44d100e84fe19d94ed","user":{"login":"JDrit","id":2280727,"avatar_url":"https://avatars.githubusercontent.com/u/2280727?v=3","gravatar_id":"","url":"https://api.github.com/users/JDrit","html_url":"https://github.com/JDrit","followers_url":"https://api.github.com/users/JDrit/followers","following_url":"https://api.github.com/users/JDrit/following{/other_user}","gists_url":"https://api.github.com/users/JDrit/gists{/gist_id}","starred_url":"https://api.github.com/users/JDrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDrit/subscriptions","organizations_url":"https://api.github.com/users/JDrit/orgs","repos_url":"https://api.github.com/users/JDrit/repos","events_url":"https://api.github.com/users/JDrit/events{/privacy}","received_events_url":"https://api.github.com/users/JDrit/received_events","type":"User","site_admin":false},"repo":{"id":37872032,"name":"spark","full_name":"JDrit/spark","owner":{"login":"JDrit","id":2280727,"avatar_url":"https://avatars.githubusercontent.com/u/2280727?v=3","gravatar_id":"","url":"https://api.github.com/users/JDrit","html_url":"https://github.com/JDrit","followers_url":"https://api.github.com/users/JDrit/followers","following_url":"https://api.github.com/users/JDrit/following{/other_user}","gists_url":"https://api.github.com/users/JDrit/gists{/gist_id}","starred_url":"https://api.github.com/users/JDrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JDrit/subscriptions","organizations_url":"https://api.github.com/users/JDrit/orgs","repos_url":"https://api.github.com/users/JDrit/repos","events_url":"https://api.github.com/users/JDrit/events{/privacy}","received_events_url":"https://api.github.com/users/JDrit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JDrit/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/JDrit/spark","forks_url":"https://api.github.com/repos/JDrit/spark/forks","keys_url":"https://api.github.com/repos/JDrit/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JDrit/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JDrit/spark/teams","hooks_url":"https://api.github.com/repos/JDrit/spark/hooks","issue_events_url":"https://api.github.com/repos/JDrit/spark/issues/events{/number}","events_url":"https://api.github.com/repos/JDrit/spark/events","assignees_url":"https://api.github.com/repos/JDrit/spark/assignees{/user}","branches_url":"https://api.github.com/repos/JDrit/spark/branches{/branch}","tags_url":"https://api.github.com/repos/JDrit/spark/tags","blobs_url":"https://api.github.com/repos/JDrit/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JDrit/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JDrit/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/JDrit/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JDrit/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/JDrit/spark/languages","stargazers_url":"https://api.github.com/repos/JDrit/spark/stargazers","contributors_url":"https://api.github.com/repos/JDrit/spark/contributors","subscribers_url":"https://api.github.com/repos/JDrit/spark/subscribers","subscription_url":"https://api.github.com/repos/JDrit/spark/subscription","commits_url":"https://api.github.com/repos/JDrit/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/JDrit/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/JDrit/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/JDrit/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/JDrit/spark/contents/{+path}","compare_url":"https://api.github.com/repos/JDrit/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JDrit/spark/merges","archive_url":"https://api.github.com/repos/JDrit/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JDrit/spark/downloads","issues_url":"https://api.github.com/repos/JDrit/spark/issues{/number}","pulls_url":"https://api.github.com/repos/JDrit/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/JDrit/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/JDrit/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JDrit/spark/labels{/name}","releases_url":"https://api.github.com/repos/JDrit/spark/releases{/id}","created_at":"2015-06-22T18:08:27Z","updated_at":"2015-06-22T18:08:49Z","pushed_at":"2015-07-01T19:47:28Z","git_url":"git://github.com/JDrit/spark.git","ssh_url":"git@github.com:JDrit/spark.git","clone_url":"https://github.com/JDrit/spark.git","svn_url":"https://github.com/JDrit/spark","homepage":null,"size":110602,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b71d3254e50838ccae43bdb0ff186fda25f03152","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-14T13:25:43Z","pushed_at":"2015-07-14T15:29:59Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1512303,"stargazers_count":4751,"watchers_count":4751,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4221,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":357,"forks":4221,"open_issues":357,"watchers":4751,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7004"},"html":{"href":"https://github.com/apache/spark/pull/7004"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7004"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7004/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7004/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7004/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/d421bf5e54eb4678c6d21a44d100e84fe19d94ed"}}}}