{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/46758600","id":46758600,"diff_hunk":"@@ -525,6 +525,34 @@ QUnit.test( \"jQuery.Deferred.then - spec compatibility\", function( assert ) {\n \t} catch ( _ ) {}\n } );\n \n+QUnit[ window.console ? \"test\" : \"skip\" ]( \"jQuery.Deferred.exceptionHook\", function( assert ) {","path":"test/unit/deferred.js","position":4,"original_position":4,"commit_id":"c3112908b0b8a5dbb489f1e6ebd46f56a3401cea","original_commit_id":"c3112908b0b8a5dbb489f1e6ebd46f56a3401cea","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"Something like `QUnit.testIf(condition, function)` would be useful I agree.","created_at":"2015-12-05T14:01:51Z","updated_at":"2015-12-05T14:01:51Z","html_url":"https://github.com/jquery/jquery/pull/2737#discussion_r46758600","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/2737","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/46758600"},"html":{"href":"https://github.com/jquery/jquery/pull/2737#discussion_r46758600"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2737"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/2737","id":51566505,"html_url":"https://github.com/jquery/jquery/pull/2737","diff_url":"https://github.com/jquery/jquery/pull/2737.diff","patch_url":"https://github.com/jquery/jquery/pull/2737.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/2737","number":2737,"state":"open","locked":false,"title":"Deferred: Warn on exceptions that are likely programming errors","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"body":"Fixes gh-2736\r\n\r\nStill a WIP with some details to be worked out. I'm not really happy with the stack trace that results, it's only showing the immediate prior call. The gist, however, is that nearly all exceptions of these types are programming mistakes and should be reported ASAP. If devs don't like being warned about them they can set `jQuery.Deferred.exceptionHook = null` and not be bothered, or define a custom hook that filters out the noisy false positives.","created_at":"2015-11-23T19:13:56Z","updated_at":"2015-12-05T14:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ae01af8bba736f862f7ebbf934770a1f927c04e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/2737/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/2737/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/2737/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/c3112908b0b8a5dbb489f1e6ebd46f56a3401cea","head":{"label":"dmethvin:2736-unhandled-exceptions","ref":"2736-unhandled-exceptions","sha":"c3112908b0b8a5dbb489f1e6ebd46f56a3401cea","user":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"repo":{"id":1148694,"name":"jquery","full_name":"dmethvin/jquery","owner":{"login":"dmethvin","id":157858,"avatar_url":"https://avatars.githubusercontent.com/u/157858?v=3","gravatar_id":"","url":"https://api.github.com/users/dmethvin","html_url":"https://github.com/dmethvin","followers_url":"https://api.github.com/users/dmethvin/followers","following_url":"https://api.github.com/users/dmethvin/following{/other_user}","gists_url":"https://api.github.com/users/dmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmethvin/subscriptions","organizations_url":"https://api.github.com/users/dmethvin/orgs","repos_url":"https://api.github.com/users/dmethvin/repos","events_url":"https://api.github.com/users/dmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/dmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmethvin/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/dmethvin/jquery","forks_url":"https://api.github.com/repos/dmethvin/jquery/forks","keys_url":"https://api.github.com/repos/dmethvin/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmethvin/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmethvin/jquery/teams","hooks_url":"https://api.github.com/repos/dmethvin/jquery/hooks","issue_events_url":"https://api.github.com/repos/dmethvin/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/dmethvin/jquery/events","assignees_url":"https://api.github.com/repos/dmethvin/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/dmethvin/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/dmethvin/jquery/tags","blobs_url":"https://api.github.com/repos/dmethvin/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmethvin/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmethvin/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmethvin/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmethvin/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/dmethvin/jquery/languages","stargazers_url":"https://api.github.com/repos/dmethvin/jquery/stargazers","contributors_url":"https://api.github.com/repos/dmethvin/jquery/contributors","subscribers_url":"https://api.github.com/repos/dmethvin/jquery/subscribers","subscription_url":"https://api.github.com/repos/dmethvin/jquery/subscription","commits_url":"https://api.github.com/repos/dmethvin/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmethvin/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmethvin/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmethvin/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmethvin/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/dmethvin/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmethvin/jquery/merges","archive_url":"https://api.github.com/repos/dmethvin/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmethvin/jquery/downloads","issues_url":"https://api.github.com/repos/dmethvin/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/dmethvin/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/dmethvin/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/dmethvin/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmethvin/jquery/labels{/name}","releases_url":"https://api.github.com/repos/dmethvin/jquery/releases{/id}","created_at":"2010-12-08T03:37:21Z","updated_at":"2015-08-27T06:15:45Z","pushed_at":"2015-12-01T00:40:08Z","git_url":"git://github.com/dmethvin/jquery.git","ssh_url":"git@github.com:dmethvin/jquery.git","clone_url":"https://github.com/dmethvin/jquery.git","svn_url":"https://github.com/dmethvin/jquery","homepage":"http://jquery.com/","size":18649,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"eaa3e9f0cfc68083556cf61195821d90e369f646","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","created_at":"2009-04-03T15:20:14Z","updated_at":"2015-12-05T12:43:56Z","pushed_at":"2015-12-05T09:36:44Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"http://jquery.com/","size":41250,"stargazers_count":36987,"watchers_count":36987,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":9607,"mirror_url":null,"open_issues_count":69,"forks":9607,"open_issues":69,"watchers":36987,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2737"},"html":{"href":"https://github.com/jquery/jquery/pull/2737"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/2737"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/2737/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2737/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/2737/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/c3112908b0b8a5dbb489f1e6ebd46f56a3401cea"}}}}