{"action":"created","issue":{"url":"https://api.github.com/repos/anvilresearch/connect/issues/305","labels_url":"https://api.github.com/repos/anvilresearch/connect/issues/305/labels{/name}","comments_url":"https://api.github.com/repos/anvilresearch/connect/issues/305/comments","events_url":"https://api.github.com/repos/anvilresearch/connect/issues/305/events","html_url":"https://github.com/anvilresearch/connect/pull/305","id":123452051,"number":305,"title":"Ensure writable `logs` folder on boot","user":{"login":"bauglir","id":47904,"avatar_url":"https://avatars.githubusercontent.com/u/47904?v=3","gravatar_id":"","url":"https://api.github.com/users/bauglir","html_url":"https://github.com/bauglir","followers_url":"https://api.github.com/users/bauglir/followers","following_url":"https://api.github.com/users/bauglir/following{/other_user}","gists_url":"https://api.github.com/users/bauglir/gists{/gist_id}","starred_url":"https://api.github.com/users/bauglir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bauglir/subscriptions","organizations_url":"https://api.github.com/users/bauglir/orgs","repos_url":"https://api.github.com/users/bauglir/repos","events_url":"https://api.github.com/users/bauglir/events{/privacy}","received_events_url":"https://api.github.com/users/bauglir/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-22T10:08:51Z","updated_at":"2015-12-24T15:11:53Z","closed_at":"2015-12-23T16:36:59Z","pull_request":{"url":"https://api.github.com/repos/anvilresearch/connect/pulls/305","html_url":"https://github.com/anvilresearch/connect/pull/305","diff_url":"https://github.com/anvilresearch/connect/pull/305.diff","patch_url":"https://github.com/anvilresearch/connect/pull/305.patch"},"body":"If the `logs` folder is not available the server will boot up fine, but crash as soon as a log entry is made.I think it's probably better to crash as soon as possible.\r\n\r\nI did use the asynchronous versions of `stat` and `access` here, which may cause server boot to be aborted while it's doing other things. I'm not exactly sure if this could actually happen though nor that if it did whether that'd be harmful.\r\n\r\nAny input on that is welcome. I can always switch the logic out of the synchronous versions. I don't think keeping the asynchronous version and only setting up the export when the `logs` folder has been verified would work.\r\n\r\nAnother solution of course would be to add the `logs` folder to the repository itself, but I'm leaning toward creating it if necessary to keep the repository clear of 'empty' folders."},"comment":{"url":"https://api.github.com/repos/anvilresearch/connect/issues/comments/167122369","html_url":"https://github.com/anvilresearch/connect/pull/305#issuecomment-167122369","issue_url":"https://api.github.com/repos/anvilresearch/connect/issues/305","id":167122369,"user":{"login":"bauglir","id":47904,"avatar_url":"https://avatars.githubusercontent.com/u/47904?v=3","gravatar_id":"","url":"https://api.github.com/users/bauglir","html_url":"https://github.com/bauglir","followers_url":"https://api.github.com/users/bauglir/followers","following_url":"https://api.github.com/users/bauglir/following{/other_user}","gists_url":"https://api.github.com/users/bauglir/gists{/gist_id}","starred_url":"https://api.github.com/users/bauglir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bauglir/subscriptions","organizations_url":"https://api.github.com/users/bauglir/orgs","repos_url":"https://api.github.com/users/bauglir/repos","events_url":"https://api.github.com/users/bauglir/events{/privacy}","received_events_url":"https://api.github.com/users/bauglir/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T15:11:53Z","updated_at":"2015-12-24T15:11:53Z","body":"I'll take care of refactoring that out and adding some tests. That should bring the coverage back up over 80% (I hope :smile:)"}}