{"action":"created","issue":{"url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267/labels{/name}","comments_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267/comments","events_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267/events","html_url":"https://github.com/Lasagne/Lasagne/pull/267","id":80548859,"number":267,"title":"increase coverage for convolution layers","user":{"login":"benanne","id":43829,"avatar_url":"https://avatars.githubusercontent.com/u/43829?v=3","gravatar_id":"","url":"https://api.github.com/users/benanne","html_url":"https://github.com/benanne","followers_url":"https://api.github.com/users/benanne/followers","following_url":"https://api.github.com/users/benanne/following{/other_user}","gists_url":"https://api.github.com/users/benanne/gists{/gist_id}","starred_url":"https://api.github.com/users/benanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benanne/subscriptions","organizations_url":"https://api.github.com/users/benanne/orgs","repos_url":"https://api.github.com/users/benanne/repos","events_url":"https://api.github.com/users/benanne/events{/privacy}","received_events_url":"https://api.github.com/users/benanne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/Lasagne/Lasagne/milestones/1","html_url":"https://github.com/Lasagne/Lasagne/milestones/First%20release","labels_url":"https://api.github.com/repos/Lasagne/Lasagne/milestones/1/labels","id":908462,"number":1,"title":"First release","description":"Things to do for the first release.","creator":{"login":"benanne","id":43829,"avatar_url":"https://avatars.githubusercontent.com/u/43829?v=3","gravatar_id":"","url":"https://api.github.com/users/benanne","html_url":"https://github.com/benanne","followers_url":"https://api.github.com/users/benanne/followers","following_url":"https://api.github.com/users/benanne/following{/other_user}","gists_url":"https://api.github.com/users/benanne/gists{/gist_id}","starred_url":"https://api.github.com/users/benanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benanne/subscriptions","organizations_url":"https://api.github.com/users/benanne/orgs","repos_url":"https://api.github.com/users/benanne/repos","events_url":"https://api.github.com/users/benanne/events{/privacy}","received_events_url":"https://api.github.com/users/benanne/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":45,"state":"open","created_at":"2014-12-18T15:32:21Z","updated_at":"2015-05-25T14:12:24Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-05-25T14:10:25Z","updated_at":"2015-05-31T16:51:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Lasagne/Lasagne/pulls/267","html_url":"https://github.com/Lasagne/Lasagne/pull/267","diff_url":"https://github.com/Lasagne/Lasagne/pull/267.diff","patch_url":"https://github.com/Lasagne/Lasagne/pull/267.patch"},"body":"This PR does a few things:\r\n* fixes a bug in all convolution implementations which made bias-less layers unusable (the same one that @ebenolson fixed in `NINLayer`, see https://github.com/ebenolson/Lasagne/commit/ffce108e87d4f14a7e2c2499bb4ccb1c9c86f02e)\r\n* moves the `border_mode` validity check into the constructor for all layers, so constructing a layer with an invalid border mode string fails as early as possible (previously this check was in `get_output_for()` and `get_output_shape_for()` for a few implementations)\r\n* adds tests for bias-less layers (`b=None`), linear layers (`nonlinearity=None`) and invalid border mode checks\r\n\r\nIt brings coverage for `lasagne/layers/conv.py` up to almost 100%. It falls just two lines short of that: the `b=None` case in `get_output_for()` is not covered for `Conv1DLayer` and `Conv2DLayer`. I'm not sure how to go about covering these two lines effectively. Adding the `b=None` case to all test configurations in `conv2d_test_sets()` seems wasteful, it will increase the test duration by a lot and the benefit is negligible. It seems like a single \"output test\" should be sufficient. Any ideas?\r\n\r\nI'll try to get the coverage for `corrmm`, `dnn` and `cuda-convnet` up to 100% as well in this PR (at least the convolution parts, might leave the pooling parts for later)."},"comment":{"url":"https://api.github.com/repos/Lasagne/Lasagne/issues/comments/107222966","html_url":"https://github.com/Lasagne/Lasagne/pull/267#issuecomment-107222966","issue_url":"https://api.github.com/repos/Lasagne/Lasagne/issues/267","id":107222966,"user":{"login":"benanne","id":43829,"avatar_url":"https://avatars.githubusercontent.com/u/43829?v=3","gravatar_id":"","url":"https://api.github.com/users/benanne","html_url":"https://github.com/benanne","followers_url":"https://api.github.com/users/benanne/followers","following_url":"https://api.github.com/users/benanne/following{/other_user}","gists_url":"https://api.github.com/users/benanne/gists{/gist_id}","starred_url":"https://api.github.com/users/benanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benanne/subscriptions","organizations_url":"https://api.github.com/users/benanne/orgs","repos_url":"https://api.github.com/users/benanne/repos","events_url":"https://api.github.com/users/benanne/events{/privacy}","received_events_url":"https://api.github.com/users/benanne/received_events","type":"User","site_admin":false},"created_at":"2015-05-31T16:51:11Z","updated_at":"2015-05-31T16:51:11Z","body":"I think this is ready."}}