{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/zendesk/global_uid/pulls/26","id":29792166,"html_url":"https://github.com/zendesk/global_uid/pull/26","diff_url":"https://github.com/zendesk/global_uid/pull/26.diff","patch_url":"https://github.com/zendesk/global_uid/pull/26.patch","issue_url":"https://api.github.com/repos/zendesk/global_uid/issues/26","number":26,"state":"open","locked":false,"title":"Inherit global_uid_disabled from LHS of HABTM associations on Rails 4.1+","user":{"login":"adammw","id":153219,"avatar_url":"https://avatars.githubusercontent.com/u/153219?v=3","gravatar_id":"","url":"https://api.github.com/users/adammw","html_url":"https://github.com/adammw","followers_url":"https://api.github.com/users/adammw/followers","following_url":"https://api.github.com/users/adammw/following{/other_user}","gists_url":"https://api.github.com/users/adammw/gists{/gist_id}","starred_url":"https://api.github.com/users/adammw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammw/subscriptions","organizations_url":"https://api.github.com/users/adammw/orgs","repos_url":"https://api.github.com/users/adammw/repos","events_url":"https://api.github.com/users/adammw/events{/privacy}","received_events_url":"https://api.github.com/users/adammw/received_events","type":"User","site_admin":false},"body":":koala:\r\n\r\nInherit the global_uid_disabled state of models from the left-hand-side of a has_and_belongs_to_many association. Without this patch, any models using has_and_belongs_to_many that also have Global UID disabled will get Global UID errors on the join table association complaining that the corresponding table for that model does not exist.\r\n\r\nConceptually similar to https://github.com/zendesk/active_record_shards/commit/6c740539b3f2a3d9f98148424ae37056ed16b1be\r\n\r\n/cc @zendesk/quokka @bquorning @pschambacher @grosser @osheroff\r\n\r\n### Risks\r\n - Only fixes the problem on Rails 4.1+\r\n - Change in behaviour for has_and_belongs_to_many associations if the previous behaviour was expected","created_at":"2015-02-23T08:29:27Z","updated_at":"2015-02-23T08:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/global_uid/pulls/26/commits","review_comments_url":"https://api.github.com/repos/zendesk/global_uid/pulls/26/comments","review_comment_url":"https://api.github.com/repos/zendesk/global_uid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/global_uid/issues/26/comments","statuses_url":"https://api.github.com/repos/zendesk/global_uid/statuses/701f213e767e65a2a7103ff8f406b2097871fe95","head":{"label":"zendesk:adammw/habtm","ref":"adammw/habtm","sha":"701f213e767e65a2a7103ff8f406b2097871fe95","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":1601158,"name":"global_uid","full_name":"zendesk/global_uid","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/global_uid","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/global_uid","forks_url":"https://api.github.com/repos/zendesk/global_uid/forks","keys_url":"https://api.github.com/repos/zendesk/global_uid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/global_uid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/global_uid/teams","hooks_url":"https://api.github.com/repos/zendesk/global_uid/hooks","issue_events_url":"https://api.github.com/repos/zendesk/global_uid/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/global_uid/events","assignees_url":"https://api.github.com/repos/zendesk/global_uid/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/global_uid/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/global_uid/tags","blobs_url":"https://api.github.com/repos/zendesk/global_uid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/global_uid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/global_uid/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/global_uid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/global_uid/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/global_uid/languages","stargazers_url":"https://api.github.com/repos/zendesk/global_uid/stargazers","contributors_url":"https://api.github.com/repos/zendesk/global_uid/contributors","subscribers_url":"https://api.github.com/repos/zendesk/global_uid/subscribers","subscription_url":"https://api.github.com/repos/zendesk/global_uid/subscription","commits_url":"https://api.github.com/repos/zendesk/global_uid/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/global_uid/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/global_uid/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/global_uid/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/global_uid/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/global_uid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/global_uid/merges","archive_url":"https://api.github.com/repos/zendesk/global_uid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/global_uid/downloads","issues_url":"https://api.github.com/repos/zendesk/global_uid/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/global_uid/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/global_uid/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/global_uid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/global_uid/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/global_uid/releases{/id}","created_at":"2011-04-11T21:08:21Z","updated_at":"2014-11-19T09:34:19Z","pushed_at":"2015-02-23T08:23:18Z","git_url":"git://github.com/zendesk/global_uid.git","ssh_url":"git@github.com:zendesk/global_uid.git","clone_url":"https://github.com/zendesk/global_uid.git","svn_url":"https://github.com/zendesk/global_uid","homepage":"","size":567,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"915b2d31e2f3f5b38aa60126343239fad6660f5c","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":1601158,"name":"global_uid","full_name":"zendesk/global_uid","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/global_uid","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/global_uid","forks_url":"https://api.github.com/repos/zendesk/global_uid/forks","keys_url":"https://api.github.com/repos/zendesk/global_uid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/global_uid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/global_uid/teams","hooks_url":"https://api.github.com/repos/zendesk/global_uid/hooks","issue_events_url":"https://api.github.com/repos/zendesk/global_uid/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/global_uid/events","assignees_url":"https://api.github.com/repos/zendesk/global_uid/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/global_uid/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/global_uid/tags","blobs_url":"https://api.github.com/repos/zendesk/global_uid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/global_uid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/global_uid/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/global_uid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/global_uid/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/global_uid/languages","stargazers_url":"https://api.github.com/repos/zendesk/global_uid/stargazers","contributors_url":"https://api.github.com/repos/zendesk/global_uid/contributors","subscribers_url":"https://api.github.com/repos/zendesk/global_uid/subscribers","subscription_url":"https://api.github.com/repos/zendesk/global_uid/subscription","commits_url":"https://api.github.com/repos/zendesk/global_uid/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/global_uid/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/global_uid/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/global_uid/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/global_uid/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/global_uid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/global_uid/merges","archive_url":"https://api.github.com/repos/zendesk/global_uid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/global_uid/downloads","issues_url":"https://api.github.com/repos/zendesk/global_uid/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/global_uid/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/global_uid/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/global_uid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/global_uid/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/global_uid/releases{/id}","created_at":"2011-04-11T21:08:21Z","updated_at":"2014-11-19T09:34:19Z","pushed_at":"2015-02-23T08:23:18Z","git_url":"git://github.com/zendesk/global_uid.git","ssh_url":"git@github.com:zendesk/global_uid.git","clone_url":"https://github.com/zendesk/global_uid.git","svn_url":"https://github.com/zendesk/global_uid","homepage":"","size":567,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/global_uid/pulls/26"},"html":{"href":"https://github.com/zendesk/global_uid/pull/26"},"issue":{"href":"https://api.github.com/repos/zendesk/global_uid/issues/26"},"comments":{"href":"https://api.github.com/repos/zendesk/global_uid/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/global_uid/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/global_uid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/global_uid/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/global_uid/statuses/701f213e767e65a2a7103ff8f406b2097871fe95"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":37,"deletions":0,"changed_files":3}}