{"action":"opened","number":439,"pull_request":{"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439","id":34710197,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/439","diff_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/439.diff","patch_url":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/439.patch","issue_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/439","number":439,"state":"open","locked":false,"title":"Do not try to use localStorage if not available","user":{"login":"elemoine","id":76594,"avatar_url":"https://avatars.githubusercontent.com/u/76594?v=3","gravatar_id":"","url":"https://api.github.com/users/elemoine","html_url":"https://github.com/elemoine","followers_url":"https://api.github.com/users/elemoine/followers","following_url":"https://api.github.com/users/elemoine/following{/other_user}","gists_url":"https://api.github.com/users/elemoine/gists{/gist_id}","starred_url":"https://api.github.com/users/elemoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemoine/subscriptions","organizations_url":"https://api.github.com/users/elemoine/orgs","repos_url":"https://api.github.com/users/elemoine/repos","events_url":"https://api.github.com/users/elemoine/events{/privacy}","received_events_url":"https://api.github.com/users/elemoine/received_events","type":"User","site_admin":false},"body":"With this commit we just don't use the localStorage if it's not available. In particular the localStorage is not available in Safari when the private mode is used.\r\n\r\n@jaykayone, I couldn't fully test this commit as Chrome in incognito mode still allows to read/write from/to the localStorage. It's a simple change, so we could merge it and then have you test it again.\r\n\r\nFixes https://github.com/Geoportail-Luxembourg/geoportailv3/issues/438.","created_at":"2015-05-05T10:04:01Z","updated_at":"2015-05-05T10:04:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439/commits","review_comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439/comments","review_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/439/comments","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e7e810a7c396fd459edd5a5d11c6fe29b6b3de62","head":{"label":"Geoportail-Luxembourg:elemoine_localstorage","ref":"elemoine_localstorage","sha":"e7e810a7c396fd459edd5a5d11c6fe29b6b3de62","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-04-28T14:47:33Z","pushed_at":"2015-05-05T10:00:53Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":82049,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":43,"forks":0,"open_issues":43,"watchers":4,"default_branch":"master"}},"base":{"label":"Geoportail-Luxembourg:master","ref":"master","sha":"f46e383efa5e9247e6ce56a428712d292f31db68","user":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"repo":{"id":24669372,"name":"geoportailv3","full_name":"Geoportail-Luxembourg/geoportailv3","owner":{"login":"Geoportail-Luxembourg","id":5592884,"avatar_url":"https://avatars.githubusercontent.com/u/5592884?v=3","gravatar_id":"","url":"https://api.github.com/users/Geoportail-Luxembourg","html_url":"https://github.com/Geoportail-Luxembourg","followers_url":"https://api.github.com/users/Geoportail-Luxembourg/followers","following_url":"https://api.github.com/users/Geoportail-Luxembourg/following{/other_user}","gists_url":"https://api.github.com/users/Geoportail-Luxembourg/gists{/gist_id}","starred_url":"https://api.github.com/users/Geoportail-Luxembourg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geoportail-Luxembourg/subscriptions","organizations_url":"https://api.github.com/users/Geoportail-Luxembourg/orgs","repos_url":"https://api.github.com/users/Geoportail-Luxembourg/repos","events_url":"https://api.github.com/users/Geoportail-Luxembourg/events{/privacy}","received_events_url":"https://api.github.com/users/Geoportail-Luxembourg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","description":"geoportailv3 is the implementation of the v3 of the map viewer of the luxembourgish geoportal","fork":false,"url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3","forks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/forks","keys_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/teams","hooks_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/hooks","issue_events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/events{/number}","events_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/events","assignees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/assignees{/user}","branches_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/branches{/branch}","tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/tags","blobs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/{sha}","languages_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/languages","stargazers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/stargazers","contributors_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contributors","subscribers_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscribers","subscription_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/subscription","commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/contents/{+path}","compare_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/merges","archive_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/downloads","issues_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues{/number}","pulls_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls{/number}","milestones_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/milestones{/number}","notifications_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/labels{/name}","releases_url":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/releases{/id}","created_at":"2014-10-01T07:23:27Z","updated_at":"2015-04-28T14:47:33Z","pushed_at":"2015-05-05T10:00:53Z","git_url":"git://github.com/Geoportail-Luxembourg/geoportailv3.git","ssh_url":"git@github.com:Geoportail-Luxembourg/geoportailv3.git","clone_url":"https://github.com/Geoportail-Luxembourg/geoportailv3.git","svn_url":"https://github.com/Geoportail-Luxembourg/geoportailv3","homepage":"","size":82049,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":43,"forks":0,"open_issues":43,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439"},"html":{"href":"https://github.com/Geoportail-Luxembourg/geoportailv3/pull/439"},"issue":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/439"},"comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/Geoportail-Luxembourg/geoportailv3/statuses/e7e810a7c396fd459edd5a5d11c6fe29b6b3de62"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":9,"changed_files":1}}