{"action":"created","issue":{"url":"https://api.github.com/repos/GarageGames/Torque2D/issues/263","labels_url":"https://api.github.com/repos/GarageGames/Torque2D/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/GarageGames/Torque2D/issues/263/comments","events_url":"https://api.github.com/repos/GarageGames/Torque2D/issues/263/events","html_url":"https://github.com/GarageGames/Torque2D/issues/263","id":115202958,"number":263,"title":"GetVersionEx Deprecated Warning","user":{"login":"chaigler","id":3131257,"avatar_url":"https://avatars.githubusercontent.com/u/3131257?v=3","gravatar_id":"","url":"https://api.github.com/users/chaigler","html_url":"https://github.com/chaigler","followers_url":"https://api.github.com/users/chaigler/followers","following_url":"https://api.github.com/users/chaigler/following{/other_user}","gists_url":"https://api.github.com/users/chaigler/gists{/gist_id}","starred_url":"https://api.github.com/users/chaigler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaigler/subscriptions","organizations_url":"https://api.github.com/users/chaigler/orgs","repos_url":"https://api.github.com/users/chaigler/repos","events_url":"https://api.github.com/users/chaigler/events{/privacy}","received_events_url":"https://api.github.com/users/chaigler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GarageGames/Torque2D/labels/Windows","name":"Windows","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-11-05T03:43:26Z","updated_at":"2015-11-05T16:50:25Z","closed_at":null,"body":"T2D calls GetVersionEx (or, rather, GetVersionExW) in a few places in an attempt to determine the Windows version and do various hacky things (like work around very old Voodoo & Windows 2000 bugs...). \r\n\r\nUnfortunately this is wrong on two fronts. First, GetVersionEx has been deprecated since Windows 8.1 and will return the wrong version information depending on app compatibility settings, etc. More importantly, the workarounds used by the engine really shouldn't be necessary anymore, and seem like old left overs from the TGE codebase. In particular, the engine does things like disable DirectInput & delete the GL context on versions of Windows older than Win2k. Is anyone still releasing games that support Windows 98 and below?\r\n\r\nIn my opinion the correct way to go about this is to remove the calls to GetVersionEx altogether and do some cleanup on the winInput.cc and winOGLVideo.cc so the engine stops trying to support 20 year old operating systems. The other approach is to check for the Windows version the \"correct\" way, like so: http://stackoverflow.com/questions/22303824/warning-c4996-getversionexw-was-declared-deprecated\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/GarageGames/Torque2D/issues/comments/154119647","html_url":"https://github.com/GarageGames/Torque2D/issues/263#issuecomment-154119647","issue_url":"https://api.github.com/repos/GarageGames/Torque2D/issues/263","id":154119647,"user":{"login":"yurembo","id":3521581,"avatar_url":"https://avatars.githubusercontent.com/u/3521581?v=3","gravatar_id":"","url":"https://api.github.com/users/yurembo","html_url":"https://github.com/yurembo","followers_url":"https://api.github.com/users/yurembo/followers","following_url":"https://api.github.com/users/yurembo/following{/other_user}","gists_url":"https://api.github.com/users/yurembo/gists{/gist_id}","starred_url":"https://api.github.com/users/yurembo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurembo/subscriptions","organizations_url":"https://api.github.com/users/yurembo/orgs","repos_url":"https://api.github.com/users/yurembo/repos","events_url":"https://api.github.com/users/yurembo/events{/privacy}","received_events_url":"https://api.github.com/users/yurembo/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T16:50:24Z","updated_at":"2015-11-05T16:50:24Z","body":"I upload 4 files to development branch, then download and test Torque 2D.\nEverything is fine!\n\n2015-11-05 21:40 GMT+05:00 Peter Robinson <notifications@github.com>:\n\n> I've never used TortoiseGit so I can't tell you exactly. After you've\n> tested an committed your changes I can help you submit a pull request\n> though with just the needed commit.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/GarageGames/Torque2D/issues/263#issuecomment-154116364>\n> .\n>\n"}}