{"action":"created","issue":{"url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/149","labels_url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/149/comments","events_url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/149/events","html_url":"https://github.com/joequery/Stupid-Table-Plugin/issues/149","id":94522325,"number":149,"title":"What happened to data-sort-desc?","user":{"login":"svivian","id":207887,"avatar_url":"https://avatars.githubusercontent.com/u/207887?v=3","gravatar_id":"","url":"https://api.github.com/users/svivian","html_url":"https://github.com/svivian","followers_url":"https://api.github.com/users/svivian/followers","following_url":"https://api.github.com/users/svivian/following{/other_user}","gists_url":"https://api.github.com/users/svivian/gists{/gist_id}","starred_url":"https://api.github.com/users/svivian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svivian/subscriptions","organizations_url":"https://api.github.com/users/svivian/orgs","repos_url":"https://api.github.com/users/svivian/repos","events_url":"https://api.github.com/users/svivian/events{/privacy}","received_events_url":"https://api.github.com/users/svivian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-12T01:22:24Z","updated_at":"2015-07-16T01:04:28Z","closed_at":null,"body":"Hey Joe, haven't checked in with this project in a little while but I was just setting up a new table and found that the `data-sort-desc` attribute isn't working.\r\n\r\nLooking in the code I don't see any checks for `.data('sort-desc')` or similar. Was it removed?"},"comment":{"url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/comments/121793853","html_url":"https://github.com/joequery/Stupid-Table-Plugin/issues/149#issuecomment-121793853","issue_url":"https://api.github.com/repos/joequery/Stupid-Table-Plugin/issues/149","id":121793853,"user":{"login":"svivian","id":207887,"avatar_url":"https://avatars.githubusercontent.com/u/207887?v=3","gravatar_id":"","url":"https://api.github.com/users/svivian","html_url":"https://github.com/svivian","followers_url":"https://api.github.com/users/svivian/followers","following_url":"https://api.github.com/users/svivian/following{/other_user}","gists_url":"https://api.github.com/users/svivian/gists{/gist_id}","starred_url":"https://api.github.com/users/svivian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svivian/subscriptions","organizations_url":"https://api.github.com/users/svivian/orgs","repos_url":"https://api.github.com/users/svivian/repos","events_url":"https://api.github.com/users/svivian/events{/privacy}","received_events_url":"https://api.github.com/users/svivian/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T01:04:28Z","updated_at":"2015-07-16T01:04:28Z","body":"Heh, my previous comment also started out quite long with some of the same reasons why \"beforedatasort\" wouldn't work, before I cut it down. On balance, the \"alterColumnRows\" system seems like a better way to go, and not really inefficient.\r\n\r\nI think the column issue I mentioned is not a big one. (In fact it already exists for the current callbacks.) The only thing I'd suggest is maybe it would be valuable to pass the type of column being sorted into the callback, since `--` may mean different things in an int or string column, i.e. I can easily make all my int columns check for blanks without having to store/maintain the exact column indices.\r\n\r\nSo for `alterColumnRows` callback we'd have\r\n\r\n- `column` (the column index)\r\n- `direction` (asc/desc)\r\n- `datatype` (int/string etc)\r\n- `data` or `columnRows` (the array of values)\r\n\r\nIf you're happy I can go ahead and work on this in the next few days."}}