{"action":"closed","number":203,"pull_request":{"url":"https://api.github.com/repos/rhinstaller/blivet/pulls/203","id":42558473,"html_url":"https://github.com/rhinstaller/blivet/pull/203","diff_url":"https://github.com/rhinstaller/blivet/pull/203.diff","patch_url":"https://github.com/rhinstaller/blivet/pull/203.patch","issue_url":"https://api.github.com/repos/rhinstaller/blivet/issues/203","number":203,"state":"closed","locked":false,"title":"Change labelFormatOK to classmethods","user":{"login":"vojtechtrefny","id":5063197,"avatar_url":"https://avatars.githubusercontent.com/u/5063197?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechtrefny","html_url":"https://github.com/vojtechtrefny","followers_url":"https://api.github.com/users/vojtechtrefny/followers","following_url":"https://api.github.com/users/vojtechtrefny/following{/other_user}","gists_url":"https://api.github.com/users/vojtechtrefny/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechtrefny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechtrefny/subscriptions","organizations_url":"https://api.github.com/users/vojtechtrefny/orgs","repos_url":"https://api.github.com/users/vojtechtrefny/repos","events_url":"https://api.github.com/users/vojtechtrefny/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechtrefny/received_events","type":"User","site_admin":false},"body":"This allows fslabel validity checks without creating the format.\r\n\r\nI think the best solution would be to just remove this tasks and move the labelFormatOK method to blivet.formats.FS class (and its subclasses) similarly to isNameValid method for lvmvg/lvmlv/btrfs names validation but it would require API change.","created_at":"2015-08-17T06:49:47Z","updated_at":"2015-08-19T09:57:40Z","closed_at":"2015-08-19T09:57:40Z","merged_at":null,"merge_commit_sha":"5237a464796ba0097e3d8a8a949587a3bf913a37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/203/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/203/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/issues/203/comments","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/0ac220164a8eb2b225ca62276f5a9052387e3666","head":{"label":"vojtechtrefny:master_label-tasks","ref":"master_label-tasks","sha":"0ac220164a8eb2b225ca62276f5a9052387e3666","user":{"login":"vojtechtrefny","id":5063197,"avatar_url":"https://avatars.githubusercontent.com/u/5063197?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechtrefny","html_url":"https://github.com/vojtechtrefny","followers_url":"https://api.github.com/users/vojtechtrefny/followers","following_url":"https://api.github.com/users/vojtechtrefny/following{/other_user}","gists_url":"https://api.github.com/users/vojtechtrefny/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechtrefny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechtrefny/subscriptions","organizations_url":"https://api.github.com/users/vojtechtrefny/orgs","repos_url":"https://api.github.com/users/vojtechtrefny/repos","events_url":"https://api.github.com/users/vojtechtrefny/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechtrefny/received_events","type":"User","site_admin":false},"repo":{"id":32306871,"name":"blivet","full_name":"vojtechtrefny/blivet","owner":{"login":"vojtechtrefny","id":5063197,"avatar_url":"https://avatars.githubusercontent.com/u/5063197?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechtrefny","html_url":"https://github.com/vojtechtrefny","followers_url":"https://api.github.com/users/vojtechtrefny/followers","following_url":"https://api.github.com/users/vojtechtrefny/following{/other_user}","gists_url":"https://api.github.com/users/vojtechtrefny/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechtrefny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechtrefny/subscriptions","organizations_url":"https://api.github.com/users/vojtechtrefny/orgs","repos_url":"https://api.github.com/users/vojtechtrefny/repos","events_url":"https://api.github.com/users/vojtechtrefny/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechtrefny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vojtechtrefny/blivet","description":"A python module for configuration of block devices","fork":true,"url":"https://api.github.com/repos/vojtechtrefny/blivet","forks_url":"https://api.github.com/repos/vojtechtrefny/blivet/forks","keys_url":"https://api.github.com/repos/vojtechtrefny/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vojtechtrefny/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vojtechtrefny/blivet/teams","hooks_url":"https://api.github.com/repos/vojtechtrefny/blivet/hooks","issue_events_url":"https://api.github.com/repos/vojtechtrefny/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/vojtechtrefny/blivet/events","assignees_url":"https://api.github.com/repos/vojtechtrefny/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/vojtechtrefny/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/vojtechtrefny/blivet/tags","blobs_url":"https://api.github.com/repos/vojtechtrefny/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vojtechtrefny/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vojtechtrefny/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/vojtechtrefny/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vojtechtrefny/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/vojtechtrefny/blivet/languages","stargazers_url":"https://api.github.com/repos/vojtechtrefny/blivet/stargazers","contributors_url":"https://api.github.com/repos/vojtechtrefny/blivet/contributors","subscribers_url":"https://api.github.com/repos/vojtechtrefny/blivet/subscribers","subscription_url":"https://api.github.com/repos/vojtechtrefny/blivet/subscription","commits_url":"https://api.github.com/repos/vojtechtrefny/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/vojtechtrefny/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/vojtechtrefny/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/vojtechtrefny/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/vojtechtrefny/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/vojtechtrefny/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vojtechtrefny/blivet/merges","archive_url":"https://api.github.com/repos/vojtechtrefny/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vojtechtrefny/blivet/downloads","issues_url":"https://api.github.com/repos/vojtechtrefny/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/vojtechtrefny/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/vojtechtrefny/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/vojtechtrefny/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vojtechtrefny/blivet/labels{/name}","releases_url":"https://api.github.com/repos/vojtechtrefny/blivet/releases{/id}","created_at":"2015-03-16T06:56:33Z","updated_at":"2015-03-16T06:56:34Z","pushed_at":"2015-08-17T07:03:08Z","git_url":"git://github.com/vojtechtrefny/blivet.git","ssh_url":"git@github.com:vojtechtrefny/blivet.git","clone_url":"https://github.com/vojtechtrefny/blivet.git","svn_url":"https://github.com/vojtechtrefny/blivet","homepage":null,"size":6292,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:master","ref":"master","sha":"21030ec63cfa70d99bfb7fe12e6a93521b2444b8","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":16584540,"name":"blivet","full_name":"rhinstaller/blivet","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/blivet","description":"A python module for configuration of block devices","fork":false,"url":"https://api.github.com/repos/rhinstaller/blivet","forks_url":"https://api.github.com/repos/rhinstaller/blivet/forks","keys_url":"https://api.github.com/repos/rhinstaller/blivet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/blivet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/blivet/teams","hooks_url":"https://api.github.com/repos/rhinstaller/blivet/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/blivet/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/blivet/events","assignees_url":"https://api.github.com/repos/rhinstaller/blivet/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/blivet/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/blivet/tags","blobs_url":"https://api.github.com/repos/rhinstaller/blivet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/blivet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/blivet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/blivet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/blivet/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/blivet/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/blivet/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/blivet/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/blivet/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/blivet/subscription","commits_url":"https://api.github.com/repos/rhinstaller/blivet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/blivet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/blivet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/blivet/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/blivet/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/blivet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/blivet/merges","archive_url":"https://api.github.com/repos/rhinstaller/blivet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/blivet/downloads","issues_url":"https://api.github.com/repos/rhinstaller/blivet/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/blivet/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/blivet/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/blivet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/blivet/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/blivet/releases{/id}","created_at":"2014-02-06T16:02:44Z","updated_at":"2015-08-09T20:10:44Z","pushed_at":"2015-08-19T09:57:24Z","git_url":"git://github.com/rhinstaller/blivet.git","ssh_url":"git@github.com:rhinstaller/blivet.git","clone_url":"https://github.com/rhinstaller/blivet.git","svn_url":"https://github.com/rhinstaller/blivet","homepage":null,"size":11473,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"open_issues_count":27,"forks":25,"open_issues":27,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/203"},"html":{"href":"https://github.com/rhinstaller/blivet/pull/203"},"issue":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/203"},"comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/blivet/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/blivet/statuses/0ac220164a8eb2b225ca62276f5a9052387e3666"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":16,"deletions":8,"changed_files":1}}