{"action":"created","issue":{"url":"https://api.github.com/repos/capistrano/sshkit/issues/260","labels_url":"https://api.github.com/repos/capistrano/sshkit/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/capistrano/sshkit/issues/260/comments","events_url":"https://api.github.com/repos/capistrano/sshkit/issues/260/events","html_url":"https://github.com/capistrano/sshkit/pull/260","id":81193626,"number":260,"title":"Combine on_stdout and on_stderr into on_data on interaction handler api","user":{"login":"robd","id":11879,"avatar_url":"https://avatars.githubusercontent.com/u/11879?v=3","gravatar_id":"","url":"https://api.github.com/users/robd","html_url":"https://github.com/robd","followers_url":"https://api.github.com/users/robd/followers","following_url":"https://api.github.com/users/robd/following{/other_user}","gists_url":"https://api.github.com/users/robd/gists{/gist_id}","starred_url":"https://api.github.com/users/robd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robd/subscriptions","organizations_url":"https://api.github.com/users/robd/orgs","repos_url":"https://api.github.com/users/robd/repos","events_url":"https://api.github.com/users/robd/events{/privacy}","received_events_url":"https://api.github.com/users/robd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-27T00:06:41Z","updated_at":"2015-07-17T08:46:31Z","closed_at":"2015-07-17T08:45:48Z","pull_request":{"url":"https://api.github.com/repos/capistrano/sshkit/pulls/260","html_url":"https://github.com/capistrano/sshkit/pull/260","diff_url":"https://github.com/capistrano/sshkit/pull/260.diff","patch_url":"https://github.com/capistrano/sshkit/pull/260.patch"},"body":"The current `interaction handler` API is overly complex, requiring users to implement both `on_stdout` and `on_stderr`. In many cases, you don't care which stream the data is arriving on. \r\n\r\nTherefore I propose to replace two methods (`on_stdout` and `on_stderr`) with a single `on_data` method. The `stream_name` (`:stdout` or `:stderr`) is now passed as a parameter so can still be used if the user needs to distinguish between the two.\r\n\r\nIf people are agreed that the single method API is better, we might as well fix this now before the `interaction_handler` API is officially released."},"comment":{"url":"https://api.github.com/repos/capistrano/sshkit/issues/comments/122219482","html_url":"https://github.com/capistrano/sshkit/pull/260#issuecomment-122219482","issue_url":"https://api.github.com/repos/capistrano/sshkit/issues/260","id":122219482,"user":{"login":"leehambley","id":18952,"avatar_url":"https://avatars.githubusercontent.com/u/18952?v=3","gravatar_id":"","url":"https://api.github.com/users/leehambley","html_url":"https://github.com/leehambley","followers_url":"https://api.github.com/users/leehambley/followers","following_url":"https://api.github.com/users/leehambley/following{/other_user}","gists_url":"https://api.github.com/users/leehambley/gists{/gist_id}","starred_url":"https://api.github.com/users/leehambley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leehambley/subscriptions","organizations_url":"https://api.github.com/users/leehambley/orgs","repos_url":"https://api.github.com/users/leehambley/repos","events_url":"https://api.github.com/users/leehambley/events{/privacy}","received_events_url":"https://api.github.com/users/leehambley/received_events","type":"User","site_admin":false},"created_at":"2015-07-17T08:46:31Z","updated_at":"2015-07-17T08:46:31Z","body":"Let's be pragmatic and keep things moving, I'd really appreciate it if I could rely on you to do the doc changes though, as @mattbrictson suggested, so I don't forget to remind you :)"}}