{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/25118408","id":25118408,"diff_hunk":"@@ -104,14 +105,32 @@ function (chai, _, $, sinon, View, RouterMock, FileReaderMock, ProfileMock,\n         return view.render()\n           .then(function () {\n             assert.equal(view.$('.avatar-wrapper img').length, 1);\n+            return view.remove();\n+          })\n+          .then(function () {\n+            assert.isTrue(profileClientMock.deleteAvatar.calledWith(\n+              accessToken, 'foo'));\n+            assert.isNull(account.get('profileImageUrl'));\n+            assert.equal(routerMock.page, 'settings');\n+          });\n+      });\n \n-            return view.remove()\n-              .then(function () {\n-                assert.isTrue(profileClientMock.deleteAvatar.calledWith(\n-                  accessToken, 'foo'));\n-                assert.isNull(account.get('profileImageUrl'));\n-                assert.equal(routerMock.page, 'settings');\n-              });","path":"app/tests/spec/views/settings/avatar_change.js","position":34,"original_position":34,"commit_id":"9dcd9b650cc4d30d907987f78ac419e88587270d","original_commit_id":"9dcd9b650cc4d30d907987f78ac419e88587270d","user":{"login":"zaach","id":3903,"avatar_url":"https://avatars.githubusercontent.com/u/3903?v=3","gravatar_id":"","url":"https://api.github.com/users/zaach","html_url":"https://github.com/zaach","followers_url":"https://api.github.com/users/zaach/followers","following_url":"https://api.github.com/users/zaach/following{/other_user}","gists_url":"https://api.github.com/users/zaach/gists{/gist_id}","starred_url":"https://api.github.com/users/zaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaach/subscriptions","organizations_url":"https://api.github.com/users/zaach/orgs","repos_url":"https://api.github.com/users/zaach/repos","events_url":"https://api.github.com/users/zaach/events{/privacy}","received_events_url":"https://api.github.com/users/zaach/received_events","type":"User","site_admin":false},"body":"Unrelated: fix the unnecessary promise nesting.","created_at":"2015-02-21T02:41:20Z","updated_at":"2015-02-21T02:41:20Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/2123#discussion_r25118408","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/25118408"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/2123#discussion_r25118408"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123","id":29747309,"html_url":"https://github.com/mozilla/fxa-content-server/pull/2123","diff_url":"https://github.com/mozilla/fxa-content-server/pull/2123.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/2123.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2123","number":2123,"state":"open","locked":false,"title":"fix(avatars): show error if avatar removal fails","user":{"login":"zaach","id":3903,"avatar_url":"https://avatars.githubusercontent.com/u/3903?v=3","gravatar_id":"","url":"https://api.github.com/users/zaach","html_url":"https://github.com/zaach","followers_url":"https://api.github.com/users/zaach/followers","following_url":"https://api.github.com/users/zaach/following{/other_user}","gists_url":"https://api.github.com/users/zaach/gists{/gist_id}","starred_url":"https://api.github.com/users/zaach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaach/subscriptions","organizations_url":"https://api.github.com/users/zaach/orgs","repos_url":"https://api.github.com/users/zaach/repos","events_url":"https://api.github.com/users/zaach/events{/privacy}","received_events_url":"https://api.github.com/users/zaach/received_events","type":"User","site_admin":false},"body":"Fixes #2116.\r\n\r\n@shane-tomlinson or @vladikoff r?","created_at":"2015-02-21T02:40:09Z","updated_at":"2015-02-21T02:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43f4d10532933d09ea07b8c664aa6106447fa4db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2123/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/9dcd9b650cc4d30d907987f78ac419e88587270d","head":{"label":"mozilla:issue-2116-show-delete-image-error","ref":"issue-2116-show-delete-image-error","sha":"9dcd9b650cc4d30d907987f78ac419e88587270d","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","created_at":"2013-07-30T23:35:35Z","updated_at":"2015-02-20T23:15:38Z","pushed_at":"2015-02-21T02:38:52Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":16144,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":211,"forks":29,"open_issues":211,"watchers":45,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"f48532b72737e68987be43d7ff25c768115eb111","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","created_at":"2013-07-30T23:35:35Z","updated_at":"2015-02-20T23:15:38Z","pushed_at":"2015-02-21T02:38:52Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":16144,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":211,"forks":29,"open_issues":211,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/2123"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2123"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/2123/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/2123/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/9dcd9b650cc4d30d907987f78ac419e88587270d"}}}}