{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openldap/pulls/comments/36221844","id":36221844,"diff_hunk":"@@ -0,0 +1,47 @@\n+FROM centos:centos7\n+\n+# OpenLDAP server image for OpenShift Origin\n+#\n+# Volumes:\n+# * /var/lib/ldap/data - Datastore for OpenLDAP\n+# * /etc/openldap/     - Config directory for slapd\n+# Environment:\n+# * $OPENLDAP_ADMIN_PASSWORD         - OpenLDAP administrator password\n+# * $OPENLDAP_DEBUG_LEVEL (Optional) - OpenLDAP debugging level, defaults to 256\n+\n+MAINTAINER Steve Kuznetsov <skuznets@redhat.com>\n+\n+ENV OPENLDAP_VERSION=2.4.41 \\\n+    HOME=/var/lib/openldap\n+\n+LABEL io.k8s.description=\"OpenLDAP is an open source implementation of the Lightweight Directory Access Protocol.\" \\\n+      io.k8s.display-name=\"OpenLDAP 2.4.41\" \\\n+      io.openshift.expose-services=\"389:ldap,636:ldaps\" \\\n+      io.openshift.tags=\"directory,ldap,openldap,openldap2441\" \\\n+      io.openshift.non-scalable=\"true\"\n+\n+# Install OpenLDAP Server\n+RUN yum install -y openldap openldap-servers openldap-clients && \\\n+    yum clean all -y && \\\n+    mkdir -p /var/lib/ldap && \\\n+    mkdir -p /etc/openldap && \\\n+    chmod a+rw -R /var/lib/ldap && \\\n+    chmod a+rw -R /etc/openldap\n+\n+# Set OpenLDAP data and config directories in a data volume\n+VOLUME [\"/var/lib/ldap\", \"/etc/openldap\"]","path":"2.4.41/Dockerfile","position":32,"original_position":32,"commit_id":"a09de142c018bf5d599128827ad9a1d8a1fc630d","original_commit_id":"a09de142c018bf5d599128827ad9a1d8a1fc630d","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"@bparees You've got more experience writing these, but I would have made my config (minus secrets) part of my image directly, not implied that it should be a bound volume.  Which way is best?","created_at":"2015-08-04T18:11:53Z","updated_at":"2015-08-04T18:11:53Z","html_url":"https://github.com/openshift/openldap/pull/8#discussion_r36221844","pull_request_url":"https://api.github.com/repos/openshift/openldap/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/openshift/openldap/pulls/comments/36221844"},"html":{"href":"https://github.com/openshift/openldap/pull/8#discussion_r36221844"},"pull_request":{"href":"https://api.github.com/repos/openshift/openldap/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openldap/pulls/8","id":41494115,"html_url":"https://github.com/openshift/openldap/pull/8","diff_url":"https://github.com/openshift/openldap/pull/8.diff","patch_url":"https://github.com/openshift/openldap/pull/8.patch","issue_url":"https://api.github.com/repos/openshift/openldap/issues/8","number":8,"state":"open","locked":false,"title":"[WIP] Added LDAPS support","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"body":"Builds on #6 \r\nFixes #2 \r\n\r\n@liggitt  PTAL","created_at":"2015-08-03T18:14:38Z","updated_at":"2015-08-04T18:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2924f70baa23d3fd5fa8007f4f1dfbd6f317057","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openldap/pulls/8/commits","review_comments_url":"https://api.github.com/repos/openshift/openldap/pulls/8/comments","review_comment_url":"https://api.github.com/repos/openshift/openldap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openldap/issues/8/comments","statuses_url":"https://api.github.com/repos/openshift/openldap/statuses/a09de142c018bf5d599128827ad9a1d8a1fc630d","head":{"label":"stevekuznetsov:skuznets/ldaps","ref":"skuznets/ldaps","sha":"a09de142c018bf5d599128827ad9a1d8a1fc630d","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"repo":{"id":39910918,"name":"openldap","full_name":"stevekuznetsov/openldap","owner":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars.githubusercontent.com/u/7328370?v=3","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevekuznetsov/openldap","description":"OpenShift OpenLDAP Docker image for OpenShift Origin testing","fork":true,"url":"https://api.github.com/repos/stevekuznetsov/openldap","forks_url":"https://api.github.com/repos/stevekuznetsov/openldap/forks","keys_url":"https://api.github.com/repos/stevekuznetsov/openldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevekuznetsov/openldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevekuznetsov/openldap/teams","hooks_url":"https://api.github.com/repos/stevekuznetsov/openldap/hooks","issue_events_url":"https://api.github.com/repos/stevekuznetsov/openldap/issues/events{/number}","events_url":"https://api.github.com/repos/stevekuznetsov/openldap/events","assignees_url":"https://api.github.com/repos/stevekuznetsov/openldap/assignees{/user}","branches_url":"https://api.github.com/repos/stevekuznetsov/openldap/branches{/branch}","tags_url":"https://api.github.com/repos/stevekuznetsov/openldap/tags","blobs_url":"https://api.github.com/repos/stevekuznetsov/openldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevekuznetsov/openldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevekuznetsov/openldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevekuznetsov/openldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevekuznetsov/openldap/statuses/{sha}","languages_url":"https://api.github.com/repos/stevekuznetsov/openldap/languages","stargazers_url":"https://api.github.com/repos/stevekuznetsov/openldap/stargazers","contributors_url":"https://api.github.com/repos/stevekuznetsov/openldap/contributors","subscribers_url":"https://api.github.com/repos/stevekuznetsov/openldap/subscribers","subscription_url":"https://api.github.com/repos/stevekuznetsov/openldap/subscription","commits_url":"https://api.github.com/repos/stevekuznetsov/openldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevekuznetsov/openldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevekuznetsov/openldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevekuznetsov/openldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevekuznetsov/openldap/contents/{+path}","compare_url":"https://api.github.com/repos/stevekuznetsov/openldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevekuznetsov/openldap/merges","archive_url":"https://api.github.com/repos/stevekuznetsov/openldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevekuznetsov/openldap/downloads","issues_url":"https://api.github.com/repos/stevekuznetsov/openldap/issues{/number}","pulls_url":"https://api.github.com/repos/stevekuznetsov/openldap/pulls{/number}","milestones_url":"https://api.github.com/repos/stevekuznetsov/openldap/milestones{/number}","notifications_url":"https://api.github.com/repos/stevekuznetsov/openldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevekuznetsov/openldap/labels{/name}","releases_url":"https://api.github.com/repos/stevekuznetsov/openldap/releases{/id}","created_at":"2015-07-29T18:58:45Z","updated_at":"2015-07-29T20:46:14Z","pushed_at":"2015-08-03T18:58:06Z","git_url":"git://github.com/stevekuznetsov/openldap.git","ssh_url":"git@github.com:stevekuznetsov/openldap.git","clone_url":"https://github.com/stevekuznetsov/openldap.git","svn_url":"https://github.com/stevekuznetsov/openldap","homepage":"https://openshift.com","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f78b4814015041e1888c2c1f6e607822f9306494","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":39910454,"name":"openldap","full_name":"openshift/openldap","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openldap","description":"","fork":false,"url":"https://api.github.com/repos/openshift/openldap","forks_url":"https://api.github.com/repos/openshift/openldap/forks","keys_url":"https://api.github.com/repos/openshift/openldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openldap/teams","hooks_url":"https://api.github.com/repos/openshift/openldap/hooks","issue_events_url":"https://api.github.com/repos/openshift/openldap/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openldap/events","assignees_url":"https://api.github.com/repos/openshift/openldap/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openldap/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openldap/tags","blobs_url":"https://api.github.com/repos/openshift/openldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openldap/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openldap/languages","stargazers_url":"https://api.github.com/repos/openshift/openldap/stargazers","contributors_url":"https://api.github.com/repos/openshift/openldap/contributors","subscribers_url":"https://api.github.com/repos/openshift/openldap/subscribers","subscription_url":"https://api.github.com/repos/openshift/openldap/subscription","commits_url":"https://api.github.com/repos/openshift/openldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openldap/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openldap/merges","archive_url":"https://api.github.com/repos/openshift/openldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openldap/downloads","issues_url":"https://api.github.com/repos/openshift/openldap/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openldap/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openldap/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openldap/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openldap/releases{/id}","created_at":"2015-07-29T18:49:06Z","updated_at":"2015-08-03T17:32:34Z","pushed_at":"2015-08-03T18:58:06Z","git_url":"git://github.com/openshift/openldap.git","ssh_url":"git@github.com:openshift/openldap.git","clone_url":"https://github.com/openshift/openldap.git","svn_url":"https://github.com/openshift/openldap","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openldap/pulls/8"},"html":{"href":"https://github.com/openshift/openldap/pull/8"},"issue":{"href":"https://api.github.com/repos/openshift/openldap/issues/8"},"comments":{"href":"https://api.github.com/repos/openshift/openldap/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openldap/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openldap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openldap/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openldap/statuses/a09de142c018bf5d599128827ad9a1d8a1fc630d"}}}}