{"action":"closed","number":700,"pull_request":{"url":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700","id":39620874,"html_url":"https://github.com/pantheon-systems/documentation/pull/700","diff_url":"https://github.com/pantheon-systems/documentation/pull/700.diff","patch_url":"https://github.com/pantheon-systems/documentation/pull/700.patch","issue_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/700","number":700,"state":"closed","locked":false,"title":"Linkchecker external check","user":{"login":"rachelwhitton","id":10119525,"avatar_url":"https://avatars.githubusercontent.com/u/10119525?v=3","gravatar_id":"","url":"https://api.github.com/users/rachelwhitton","html_url":"https://github.com/rachelwhitton","followers_url":"https://api.github.com/users/rachelwhitton/followers","following_url":"https://api.github.com/users/rachelwhitton/following{/other_user}","gists_url":"https://api.github.com/users/rachelwhitton/gists{/gist_id}","starred_url":"https://api.github.com/users/rachelwhitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachelwhitton/subscriptions","organizations_url":"https://api.github.com/users/rachelwhitton/orgs","repos_url":"https://api.github.com/users/rachelwhitton/repos","events_url":"https://api.github.com/users/rachelwhitton/events{/privacy}","received_events_url":"https://api.github.com/users/rachelwhitton/received_events","type":"User","site_admin":false},"body":"This PR fixes broken URLs and redirects identified with the following linkchecker command: \r\n`linkchecker http://localhost:8000/docs --check-extern` which crawls URL's outside of the docs site. \r\n\r\n[f7ef53f](https://github.com/pantheon-systems/documentation/commit/f7ef53f079346d994c5c645c3df8154c98f5a9b0) removes `/` from breadcrumb logic to address broken links generated when rendered. Here's example output [before](https://gist.github.com/rachelwhitton/d6f82589e9b14668cc57) that commit and [after](https://gist.github.com/rachelwhitton/4c72fabc76ecc8617769). This does not affect the look or function of breadcrumbs. \r\n\r\nWith external links now being checked, some false positives are generated as a result of timeouts (just a guess..)\r\n**Example:**\r\n```\r\nURL        `https://mariadb.com/kb/en/mariadb/documentation/clients-and-utilities/mysql-client/mysql-command-line-client/'\r\nName       `MySQL CLI'\r\nParent URL http://localhost:8000/docs/articles/sites/create/importing-a-large-site, line 190, col 30\r\nReal URL   https://mariadb.com/kb/en/mariadb/documentation/clients-and-utilities/mysql-client/mysql-command-line-client/\r\nCheck time 4.471 seconds\r\nResult     Error: ConnectionError: ('Connection aborted.', BadStatusLine(\"''\",))\r\n```\r\n\r\nConsidering the amount of links checked (16566 links in 1622 URLs checked) --- less than 10 false positives is not bad IMO. \r\n\r\n@bmackinney can you review? \r\n","created_at":"2015-07-09T19:46:52Z","updated_at":"2015-07-13T19:34:07Z","closed_at":"2015-07-13T19:34:06Z","merged_at":"2015-07-13T19:34:06Z","merge_commit_sha":"52745f230cade1009c387d3f6b2ec3881d084495","assignee":{"login":"rachelwhitton","id":10119525,"avatar_url":"https://avatars.githubusercontent.com/u/10119525?v=3","gravatar_id":"","url":"https://api.github.com/users/rachelwhitton","html_url":"https://github.com/rachelwhitton","followers_url":"https://api.github.com/users/rachelwhitton/followers","following_url":"https://api.github.com/users/rachelwhitton/following{/other_user}","gists_url":"https://api.github.com/users/rachelwhitton/gists{/gist_id}","starred_url":"https://api.github.com/users/rachelwhitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachelwhitton/subscriptions","organizations_url":"https://api.github.com/users/rachelwhitton/orgs","repos_url":"https://api.github.com/users/rachelwhitton/repos","events_url":"https://api.github.com/users/rachelwhitton/events{/privacy}","received_events_url":"https://api.github.com/users/rachelwhitton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700/commits","review_comments_url":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700/comments","review_comment_url":"https://api.github.com/repos/pantheon-systems/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/700/comments","statuses_url":"https://api.github.com/repos/pantheon-systems/documentation/statuses/0815690817de23dcc4f21fa3fa8e2b9c4fc74684","head":{"label":"pantheon-systems:linkchecker-external-check","ref":"linkchecker-external-check","sha":"0815690817de23dcc4f21fa3fa8e2b9c4fc74684","user":{"login":"pantheon-systems","id":513357,"avatar_url":"https://avatars.githubusercontent.com/u/513357?v=3","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":26826032,"name":"documentation","full_name":"pantheon-systems/documentation","owner":{"login":"pantheon-systems","id":513357,"avatar_url":"https://avatars.githubusercontent.com/u/513357?v=3","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantheon-systems/documentation","description":"Pantheon Docs","fork":false,"url":"https://api.github.com/repos/pantheon-systems/documentation","forks_url":"https://api.github.com/repos/pantheon-systems/documentation/forks","keys_url":"https://api.github.com/repos/pantheon-systems/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantheon-systems/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantheon-systems/documentation/teams","hooks_url":"https://api.github.com/repos/pantheon-systems/documentation/hooks","issue_events_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/pantheon-systems/documentation/events","assignees_url":"https://api.github.com/repos/pantheon-systems/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/pantheon-systems/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/pantheon-systems/documentation/tags","blobs_url":"https://api.github.com/repos/pantheon-systems/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantheon-systems/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantheon-systems/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantheon-systems/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantheon-systems/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/pantheon-systems/documentation/languages","stargazers_url":"https://api.github.com/repos/pantheon-systems/documentation/stargazers","contributors_url":"https://api.github.com/repos/pantheon-systems/documentation/contributors","subscribers_url":"https://api.github.com/repos/pantheon-systems/documentation/subscribers","subscription_url":"https://api.github.com/repos/pantheon-systems/documentation/subscription","commits_url":"https://api.github.com/repos/pantheon-systems/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantheon-systems/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantheon-systems/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantheon-systems/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/pantheon-systems/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantheon-systems/documentation/merges","archive_url":"https://api.github.com/repos/pantheon-systems/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantheon-systems/documentation/downloads","issues_url":"https://api.github.com/repos/pantheon-systems/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/pantheon-systems/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/pantheon-systems/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/pantheon-systems/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantheon-systems/documentation/labels{/name}","releases_url":"https://api.github.com/repos/pantheon-systems/documentation/releases{/id}","created_at":"2014-11-18T19:26:21Z","updated_at":"2015-07-01T20:26:57Z","pushed_at":"2015-07-13T19:34:06Z","git_url":"git://github.com/pantheon-systems/documentation.git","ssh_url":"git@github.com:pantheon-systems/documentation.git","clone_url":"https://github.com/pantheon-systems/documentation.git","svn_url":"https://github.com/pantheon-systems/documentation","homepage":"https://pantheon.io/docs","size":86874,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":44,"forks":42,"open_issues":44,"watchers":20,"default_branch":"master"}},"base":{"label":"pantheon-systems:master","ref":"master","sha":"c3390bd917461461b52d3811729cd5927f8e9655","user":{"login":"pantheon-systems","id":513357,"avatar_url":"https://avatars.githubusercontent.com/u/513357?v=3","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":26826032,"name":"documentation","full_name":"pantheon-systems/documentation","owner":{"login":"pantheon-systems","id":513357,"avatar_url":"https://avatars.githubusercontent.com/u/513357?v=3","gravatar_id":"","url":"https://api.github.com/users/pantheon-systems","html_url":"https://github.com/pantheon-systems","followers_url":"https://api.github.com/users/pantheon-systems/followers","following_url":"https://api.github.com/users/pantheon-systems/following{/other_user}","gists_url":"https://api.github.com/users/pantheon-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/pantheon-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantheon-systems/subscriptions","organizations_url":"https://api.github.com/users/pantheon-systems/orgs","repos_url":"https://api.github.com/users/pantheon-systems/repos","events_url":"https://api.github.com/users/pantheon-systems/events{/privacy}","received_events_url":"https://api.github.com/users/pantheon-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pantheon-systems/documentation","description":"Pantheon Docs","fork":false,"url":"https://api.github.com/repos/pantheon-systems/documentation","forks_url":"https://api.github.com/repos/pantheon-systems/documentation/forks","keys_url":"https://api.github.com/repos/pantheon-systems/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantheon-systems/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantheon-systems/documentation/teams","hooks_url":"https://api.github.com/repos/pantheon-systems/documentation/hooks","issue_events_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/pantheon-systems/documentation/events","assignees_url":"https://api.github.com/repos/pantheon-systems/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/pantheon-systems/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/pantheon-systems/documentation/tags","blobs_url":"https://api.github.com/repos/pantheon-systems/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantheon-systems/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantheon-systems/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantheon-systems/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantheon-systems/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/pantheon-systems/documentation/languages","stargazers_url":"https://api.github.com/repos/pantheon-systems/documentation/stargazers","contributors_url":"https://api.github.com/repos/pantheon-systems/documentation/contributors","subscribers_url":"https://api.github.com/repos/pantheon-systems/documentation/subscribers","subscription_url":"https://api.github.com/repos/pantheon-systems/documentation/subscription","commits_url":"https://api.github.com/repos/pantheon-systems/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantheon-systems/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantheon-systems/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantheon-systems/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantheon-systems/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/pantheon-systems/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantheon-systems/documentation/merges","archive_url":"https://api.github.com/repos/pantheon-systems/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantheon-systems/documentation/downloads","issues_url":"https://api.github.com/repos/pantheon-systems/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/pantheon-systems/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/pantheon-systems/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/pantheon-systems/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantheon-systems/documentation/labels{/name}","releases_url":"https://api.github.com/repos/pantheon-systems/documentation/releases{/id}","created_at":"2014-11-18T19:26:21Z","updated_at":"2015-07-01T20:26:57Z","pushed_at":"2015-07-13T19:34:06Z","git_url":"git://github.com/pantheon-systems/documentation.git","ssh_url":"git@github.com:pantheon-systems/documentation.git","clone_url":"https://github.com/pantheon-systems/documentation.git","svn_url":"https://github.com/pantheon-systems/documentation","homepage":"https://pantheon.io/docs","size":86874,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":44,"forks":42,"open_issues":44,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700"},"html":{"href":"https://github.com/pantheon-systems/documentation/pull/700"},"issue":{"href":"https://api.github.com/repos/pantheon-systems/documentation/issues/700"},"comments":{"href":"https://api.github.com/repos/pantheon-systems/documentation/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/pantheon-systems/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantheon-systems/documentation/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/pantheon-systems/documentation/statuses/0815690817de23dcc4f21fa3fa8e2b9c4fc74684"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rachelwhitton","id":10119525,"avatar_url":"https://avatars.githubusercontent.com/u/10119525?v=3","gravatar_id":"","url":"https://api.github.com/users/rachelwhitton","html_url":"https://github.com/rachelwhitton","followers_url":"https://api.github.com/users/rachelwhitton/followers","following_url":"https://api.github.com/users/rachelwhitton/following{/other_user}","gists_url":"https://api.github.com/users/rachelwhitton/gists{/gist_id}","starred_url":"https://api.github.com/users/rachelwhitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachelwhitton/subscriptions","organizations_url":"https://api.github.com/users/rachelwhitton/orgs","repos_url":"https://api.github.com/users/rachelwhitton/repos","events_url":"https://api.github.com/users/rachelwhitton/events{/privacy}","received_events_url":"https://api.github.com/users/rachelwhitton/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":6,"additions":30,"deletions":30,"changed_files":16}}