{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/40355533","id":40355533,"diff_hunk":"@@ -56,22 +56,24 @@ describe('rxFloatingHeader', function () {\n         });\n \n         it('should float the header after scrolling to middle of table', function () {\n-            rxFloatingHeader.scrollToElement(middleRow);\n-            expect(rxFloatingHeader.compareYLocations(filterHeader, middleRowY)).to.eventually.be.true;\n+            encore.rxFloatingHeader.scrollToElement(middleRow);\n+            expect(encore.rxFloatingHeader.compareYLocations(filterHeader, middleRowY)).to.eventually.be.true;\n         });\n \n         it('should have the right distance between the float header and the middle of the table', function () {\n-            expect(rxFloatingHeader.compareYLocations(titlesHeader, middleRowY + filterHeight)).to.eventually.be.true;\n+            var offset = middleRowY + filterHeight;\n+            expect(encore.rxFloatingHeader.compareYLocations(titlesHeader, offset)).to.eventually.be.true;","path":"src/rxFloatingHeader/docs/rxFloatingHeader.midway.js","position":39,"original_position":39,"commit_id":"716bddc7f0328f897b26abce293895c98559ac4d","original_commit_id":"716bddc7f0328f897b26abce293895c98559ac4d","user":{"login":"CITguy","id":545605,"avatar_url":"https://avatars.githubusercontent.com/u/545605?v=3","gravatar_id":"","url":"https://api.github.com/users/CITguy","html_url":"https://github.com/CITguy","followers_url":"https://api.github.com/users/CITguy/followers","following_url":"https://api.github.com/users/CITguy/following{/other_user}","gists_url":"https://api.github.com/users/CITguy/gists{/gist_id}","starred_url":"https://api.github.com/users/CITguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CITguy/subscriptions","organizations_url":"https://api.github.com/users/CITguy/orgs","repos_url":"https://api.github.com/users/CITguy/repos","events_url":"https://api.github.com/users/CITguy/events{/privacy}","received_events_url":"https://api.github.com/users/CITguy/received_events","type":"User","site_admin":false},"body":"@Droogans: I ask because I'm still getting an error for this test.","created_at":"2015-09-24T18:37:54Z","updated_at":"2015-09-24T18:37:54Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/1229#discussion_r40355533","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/40355533"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1229#discussion_r40355533"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229","id":45832528,"html_url":"https://github.com/rackerlabs/encore-ui/pull/1229","diff_url":"https://github.com/rackerlabs/encore-ui/pull/1229.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/1229.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1229","number":1229,"state":"open","locked":false,"title":"fix(rxFloatingHeader): Pass local protractor tests.","user":{"login":"Droogans","id":1214609,"avatar_url":"https://avatars.githubusercontent.com/u/1214609?v=3","gravatar_id":"","url":"https://api.github.com/users/Droogans","html_url":"https://github.com/Droogans","followers_url":"https://api.github.com/users/Droogans/followers","following_url":"https://api.github.com/users/Droogans/following{/other_user}","gists_url":"https://api.github.com/users/Droogans/gists{/gist_id}","starred_url":"https://api.github.com/users/Droogans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Droogans/subscriptions","organizations_url":"https://api.github.com/users/Droogans/orgs","repos_url":"https://api.github.com/users/Droogans/repos","events_url":"https://api.github.com/users/Droogans/events{/privacy}","received_events_url":"https://api.github.com/users/Droogans/received_events","type":"User","site_admin":false},"body":"This isn't an issue on Travis, but when running tests locally, there\r\nis an issue where the floating header will be off by one pixel on\r\nhigher resolution displays. This fix adds a tolerance around the\r\nlocation of the floating header during protractor tests to be\r\n+/- 2 pixels.","created_at":"2015-09-23T21:14:50Z","updated_at":"2015-09-24T18:37:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8a308ef1472ded32b6bab26b523b3279c8f9146","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1229/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/716bddc7f0328f897b26abce293895c98559ac4d","head":{"label":"Droogans:e2e-floating-header-tolerance","ref":"e2e-floating-header-tolerance","sha":"716bddc7f0328f897b26abce293895c98559ac4d","user":{"login":"Droogans","id":1214609,"avatar_url":"https://avatars.githubusercontent.com/u/1214609?v=3","gravatar_id":"","url":"https://api.github.com/users/Droogans","html_url":"https://github.com/Droogans","followers_url":"https://api.github.com/users/Droogans/followers","following_url":"https://api.github.com/users/Droogans/following{/other_user}","gists_url":"https://api.github.com/users/Droogans/gists{/gist_id}","starred_url":"https://api.github.com/users/Droogans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Droogans/subscriptions","organizations_url":"https://api.github.com/users/Droogans/orgs","repos_url":"https://api.github.com/users/Droogans/repos","events_url":"https://api.github.com/users/Droogans/events{/privacy}","received_events_url":"https://api.github.com/users/Droogans/received_events","type":"User","site_admin":false},"repo":{"id":16555871,"name":"encore-ui","full_name":"Droogans/encore-ui","owner":{"login":"Droogans","id":1214609,"avatar_url":"https://avatars.githubusercontent.com/u/1214609?v=3","gravatar_id":"","url":"https://api.github.com/users/Droogans","html_url":"https://github.com/Droogans","followers_url":"https://api.github.com/users/Droogans/followers","following_url":"https://api.github.com/users/Droogans/following{/other_user}","gists_url":"https://api.github.com/users/Droogans/gists{/gist_id}","starred_url":"https://api.github.com/users/Droogans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Droogans/subscriptions","organizations_url":"https://api.github.com/users/Droogans/orgs","repos_url":"https://api.github.com/users/Droogans/repos","events_url":"https://api.github.com/users/Droogans/events{/privacy}","received_events_url":"https://api.github.com/users/Droogans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Droogans/encore-ui","description":"UI Layer for Encore","fork":true,"url":"https://api.github.com/repos/Droogans/encore-ui","forks_url":"https://api.github.com/repos/Droogans/encore-ui/forks","keys_url":"https://api.github.com/repos/Droogans/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Droogans/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Droogans/encore-ui/teams","hooks_url":"https://api.github.com/repos/Droogans/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/Droogans/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Droogans/encore-ui/events","assignees_url":"https://api.github.com/repos/Droogans/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Droogans/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Droogans/encore-ui/tags","blobs_url":"https://api.github.com/repos/Droogans/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Droogans/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Droogans/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Droogans/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Droogans/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Droogans/encore-ui/languages","stargazers_url":"https://api.github.com/repos/Droogans/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/Droogans/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/Droogans/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/Droogans/encore-ui/subscription","commits_url":"https://api.github.com/repos/Droogans/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Droogans/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Droogans/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Droogans/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Droogans/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Droogans/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Droogans/encore-ui/merges","archive_url":"https://api.github.com/repos/Droogans/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Droogans/encore-ui/downloads","issues_url":"https://api.github.com/repos/Droogans/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Droogans/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Droogans/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Droogans/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Droogans/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/Droogans/encore-ui/releases{/id}","created_at":"2014-02-05T19:40:52Z","updated_at":"2015-05-08T16:52:18Z","pushed_at":"2015-09-23T21:14:12Z","git_url":"git://github.com/Droogans/encore-ui.git","ssh_url":"git@github.com:Droogans/encore-ui.git","clone_url":"https://github.com/Droogans/encore-ui.git","svn_url":"https://github.com/Droogans/encore-ui","homepage":null,"size":6616,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"e30ffa504f8db5ff3e8b6146b9c9398597a5360a","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","created_at":"2013-07-15T20:06:52Z","updated_at":"2015-09-10T15:50:43Z","pushed_at":"2015-09-24T18:35:38Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":34185,"stargazers_count":37,"watchers_count":37,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":79,"forks":44,"open_issues":79,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1229"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1229"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/716bddc7f0328f897b26abce293895c98559ac4d"}}}}