{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/18691","labels_url":"https://api.github.com/repos/owncloud/core/issues/18691/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/18691/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/18691/events","html_url":"https://github.com/owncloud/core/pull/18691","id":103966114,"number":18691,"title":"Decode request content only on getContent","user":{"login":"Xenopathic","id":2016878,"avatar_url":"https://avatars.githubusercontent.com/u/2016878?v=3","gravatar_id":"","url":"https://api.github.com/users/Xenopathic","html_url":"https://github.com/Xenopathic","followers_url":"https://api.github.com/users/Xenopathic/followers","following_url":"https://api.github.com/users/Xenopathic/following{/other_user}","gists_url":"https://api.github.com/users/Xenopathic/gists{/gist_id}","starred_url":"https://api.github.com/users/Xenopathic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xenopathic/subscriptions","organizations_url":"https://api.github.com/users/Xenopathic/orgs","repos_url":"https://api.github.com/users/Xenopathic/repos","events_url":"https://api.github.com/users/Xenopathic/events{/privacy}","received_events_url":"https://api.github.com/users/Xenopathic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/backport-request","name":"backport-request","color":"006b75"},{"url":"https://api.github.com/repos/owncloud/core/labels/sev1-critical","name":"sev1-critical","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/37","html_url":"https://github.com/owncloud/core/milestones/8.2-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/37/labels","id":993629,"number":37,"title":"8.2-current","description":"","creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":643,"closed_issues":558,"state":"open","created_at":"2015-02-24T16:19:37Z","updated_at":"2015-08-31T12:24:40Z","due_on":"2015-10-20T04:00:00Z","closed_at":null},"comments":7,"created_at":"2015-08-31T00:33:46Z","updated_at":"2015-08-31T12:58:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/18691","html_url":"https://github.com/owncloud/core/pull/18691","diff_url":"https://github.com/owncloud/core/pull/18691.diff","patch_url":"https://github.com/owncloud/core/pull/18691.patch"},"body":"Delay reading `php://input` until the content is actually needed, avoiding the bug with `php://input` only being able to be read once in PHP <5.6.\r\n\r\nThe Request unit tests pass locally, and my own tests PUTting data with the `application/json` and `application/x-www-form-urlencoded` now succeed. A quick play with the web UI shows basic functions working fine too. Also, `lib/oc-tests/test_shareGroup.py` in smashbox also now succeeds (reported broken in #18588)!\r\n\r\nFixes #17712, fixes #18661, fixes #18428 (hopefully?), fixes #18588 \r\n\r\nref owncloud/smashbox#128\r\n\r\n@nickvergessen @LukasReschke @karlitschek @DeepDiver1975 @PVince81 @MorrisJobke @oparoz \r\n\r\n@karlitschek This bug also affects older versions of ownCloud, albeit with a lower severity (see #17712, #18661). Perhaps we want to backport this?"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/136363992","html_url":"https://github.com/owncloud/core/pull/18691#issuecomment-136363992","issue_url":"https://api.github.com/repos/owncloud/core/issues/18691","id":136363992,"user":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T12:58:45Z","updated_at":"2015-08-31T12:58:45Z","body":"Tested and works :+1: Also the code looks really good "}}