{"action":"created","comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/22777152","id":22777152,"diff_hunk":"@@ -0,0 +1,33 @@\n+package org.asciidoctor.ast;\n+\n+import org.jruby.Ruby;\n+\n+public class InlineImpl extends AbstractNodeImpl implements Inline  {\n+\n+    protected Inline delegate;\n+\n+    public InlineImpl(Inline delegate, Ruby ruby) {\n+        super(delegate, ruby);\n+        this.delegate = delegate;\n+    }\n+\n+    @Override\n+    public String render() {","path":"asciidoctorj-core/src/main/java/org/asciidoctor/ast/InlineImpl.java","position":15,"original_position":15,"commit_id":"2e34bda1b2372e137b03e34f4c2692f9c7410dee","original_commit_id":"2e34bda1b2372e137b03e34f4c2692f9c7410dee","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"body":"Will do so in upcoming PRs :)\r\n\r\n\r\n\r\n> Am 12.01.2015 um 07:54 schrieb Dan Allen <notifications@github.com>:\r\n> \r\n> In asciidoctorj-core/src/main/java/org/asciidoctor/ast/InlineImpl.java:\r\n> \r\n> > @@ -0,0 +1,33 @@\r\n> > +package org.asciidoctor.ast;\r\n> > +\r\n> > +import org.jruby.Ruby;\r\n> > +\r\n> > +public class InlineImpl extends AbstractNodeImpl implements Inline  {\r\n> > +\r\n> > +    protected Inline delegate;\r\n> > +\r\n> > +    public InlineImpl(Inline delegate, Ruby ruby) {\r\n> > +        super(delegate, ruby);\r\n> > +        this.delegate = delegate;\r\n> > +    }\r\n> > +\r\n> > +    @Override\r\n> > +    public String render() {\r\n> Anywhere the term \"render\" is used, it should be marked as deprecated. \"convert\" is the preferred terminology.\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> ","created_at":"2015-01-12T07:19:50Z","updated_at":"2015-01-12T07:19:50Z","html_url":"https://github.com/asciidoctor/asciidoctorj/pull/266#discussion_r22777152","pull_request_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/22777152"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/266#discussion_r22777152"},"pull_request":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266","id":27150396,"html_url":"https://github.com/asciidoctor/asciidoctorj/pull/266","diff_url":"https://github.com/asciidoctor/asciidoctorj/pull/266.diff","patch_url":"https://github.com/asciidoctor/asciidoctorj/pull/266.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/266","number":266,"state":"closed","locked":false,"title":"Added new Java counterparts for List and ListItem nodes.","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"body":"Also provided an implementation for the Inline interface.\r\nAdditionally moved Ruby to Java node conversion to separate class org.asciidoctor.ast.NodeFactory.\r\n\r\nI tried hard for a DynamicProxy based approach and it worked fine for converters.\r\nBut the whole approach got mixed up when TreeConverters are added.\r\nIt seems to be impossible or at least very hard to mix and match JRuby type conversion and own DynamicProxies.","created_at":"2015-01-10T15:39:42Z","updated_at":"2015-01-12T07:19:50Z","closed_at":"2015-01-11T08:23:58Z","merged_at":"2015-01-11T08:23:58Z","merge_commit_sha":"5b71f9466b60ad9ed2b1fc6fff2cca92535c72ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/{number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/266/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/2e34bda1b2372e137b03e34f4c2692f9c7410dee","head":{"label":"robertpanzer:ListNodesAndNodeFactory","ref":"ListNodesAndNodeFactory","sha":"2e34bda1b2372e137b03e34f4c2692f9c7410dee","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"repo":{"id":27998582,"name":"asciidoctorj","full_name":"robertpanzer/asciidoctorj","owner":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertpanzer/asciidoctorj","description":"Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":true,"url":"https://api.github.com/repos/robertpanzer/asciidoctorj","forks_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/forks","keys_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/events","assignees_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues/comments/{number}","contents_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/merges","archive_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/releases{/id}","created_at":"2014-12-14T15:33:22Z","updated_at":"2015-01-02T13:21:18Z","pushed_at":"2015-01-10T15:33:33Z","git_url":"git://github.com/robertpanzer/asciidoctorj.git","ssh_url":"git@github.com:robertpanzer/asciidoctorj.git","clone_url":"https://github.com/robertpanzer/asciidoctorj.git","svn_url":"https://github.com/robertpanzer/asciidoctorj","homepage":"http://asciidoctor.org","size":1572,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:converters","ref":"converters","sha":"5565c8d5ed2794bdefa33560f69b6526a8786b9e","user":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":8862411,"name":"asciidoctorj","full_name":"asciidoctor/asciidoctorj","owner":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asciidoctor/asciidoctorj","description":":coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctorj","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/comments/{number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/releases{/id}","created_at":"2013-03-18T19:36:27Z","updated_at":"2015-01-08T13:05:55Z","pushed_at":"2015-01-11T19:00:46Z","git_url":"git://github.com/asciidoctor/asciidoctorj.git","ssh_url":"git@github.com:asciidoctor/asciidoctorj.git","clone_url":"https://github.com/asciidoctor/asciidoctorj.git","svn_url":"https://github.com/asciidoctor/asciidoctorj","homepage":"http://asciidoctor.org","size":2864,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":25,"forks":37,"open_issues":25,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/266"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/266"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/2e34bda1b2372e137b03e34f4c2692f9c7410dee"}}}}