{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10","id":32854003,"html_url":"https://github.com/hoetmaaiers/ogone-rails/pull/10","diff_url":"https://github.com/hoetmaaiers/ogone-rails/pull/10.diff","patch_url":"https://github.com/hoetmaaiers/ogone-rails/pull/10.patch","issue_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/10","number":10,"state":"closed","locked":false,"title":"Fix amount conversion","user":{"login":"radnan","id":758244,"avatar_url":"https://avatars.githubusercontent.com/u/758244?v=3","gravatar_id":"","url":"https://api.github.com/users/radnan","html_url":"https://github.com/radnan","followers_url":"https://api.github.com/users/radnan/followers","following_url":"https://api.github.com/users/radnan/following{/other_user}","gists_url":"https://api.github.com/users/radnan/gists{/gist_id}","starred_url":"https://api.github.com/users/radnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radnan/subscriptions","organizations_url":"https://api.github.com/users/radnan/orgs","repos_url":"https://api.github.com/users/radnan/repos","events_url":"https://api.github.com/users/radnan/events{/privacy}","received_events_url":"https://api.github.com/users/radnan/received_events","type":"User","site_admin":false},"body":"We should not be relying on floats for currency calculations and use decimal type instead.\r\n\r\nFor example using `586.80` as an amount, we get `58679` in cents using float conversion. Whereas we get the correct value of `58680` using the `BigDecimal` type.","created_at":"2015-04-08T12:16:21Z","updated_at":"2015-04-08T12:22:14Z","closed_at":"2015-04-08T12:22:14Z","merged_at":"2015-04-08T12:22:14Z","merge_commit_sha":"31b1b55073a72d7e24c51fd82d6e2f5c92ba5e47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10/commits","review_comments_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10/comments","review_comment_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/10/comments","statuses_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/statuses/532fb1078778abc134e83784cd90d1ed1464ba33","head":{"label":"radnan:fix-amount-conversion","ref":"fix-amount-conversion","sha":"532fb1078778abc134e83784cd90d1ed1464ba33","user":{"login":"radnan","id":758244,"avatar_url":"https://avatars.githubusercontent.com/u/758244?v=3","gravatar_id":"","url":"https://api.github.com/users/radnan","html_url":"https://github.com/radnan","followers_url":"https://api.github.com/users/radnan/followers","following_url":"https://api.github.com/users/radnan/following{/other_user}","gists_url":"https://api.github.com/users/radnan/gists{/gist_id}","starred_url":"https://api.github.com/users/radnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radnan/subscriptions","organizations_url":"https://api.github.com/users/radnan/orgs","repos_url":"https://api.github.com/users/radnan/repos","events_url":"https://api.github.com/users/radnan/events{/privacy}","received_events_url":"https://api.github.com/users/radnan/received_events","type":"User","site_admin":false},"repo":{"id":33601338,"name":"ogone-rails","full_name":"radnan/ogone-rails","owner":{"login":"radnan","id":758244,"avatar_url":"https://avatars.githubusercontent.com/u/758244?v=3","gravatar_id":"","url":"https://api.github.com/users/radnan","html_url":"https://github.com/radnan","followers_url":"https://api.github.com/users/radnan/followers","following_url":"https://api.github.com/users/radnan/following{/other_user}","gists_url":"https://api.github.com/users/radnan/gists{/gist_id}","starred_url":"https://api.github.com/users/radnan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radnan/subscriptions","organizations_url":"https://api.github.com/users/radnan/orgs","repos_url":"https://api.github.com/users/radnan/repos","events_url":"https://api.github.com/users/radnan/events{/privacy}","received_events_url":"https://api.github.com/users/radnan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radnan/ogone-rails","description":"A Ruby gem to simplify the use of Ogone online payments service.","fork":true,"url":"https://api.github.com/repos/radnan/ogone-rails","forks_url":"https://api.github.com/repos/radnan/ogone-rails/forks","keys_url":"https://api.github.com/repos/radnan/ogone-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radnan/ogone-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radnan/ogone-rails/teams","hooks_url":"https://api.github.com/repos/radnan/ogone-rails/hooks","issue_events_url":"https://api.github.com/repos/radnan/ogone-rails/issues/events{/number}","events_url":"https://api.github.com/repos/radnan/ogone-rails/events","assignees_url":"https://api.github.com/repos/radnan/ogone-rails/assignees{/user}","branches_url":"https://api.github.com/repos/radnan/ogone-rails/branches{/branch}","tags_url":"https://api.github.com/repos/radnan/ogone-rails/tags","blobs_url":"https://api.github.com/repos/radnan/ogone-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radnan/ogone-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radnan/ogone-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/radnan/ogone-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radnan/ogone-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/radnan/ogone-rails/languages","stargazers_url":"https://api.github.com/repos/radnan/ogone-rails/stargazers","contributors_url":"https://api.github.com/repos/radnan/ogone-rails/contributors","subscribers_url":"https://api.github.com/repos/radnan/ogone-rails/subscribers","subscription_url":"https://api.github.com/repos/radnan/ogone-rails/subscription","commits_url":"https://api.github.com/repos/radnan/ogone-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/radnan/ogone-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/radnan/ogone-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/radnan/ogone-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/radnan/ogone-rails/contents/{+path}","compare_url":"https://api.github.com/repos/radnan/ogone-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radnan/ogone-rails/merges","archive_url":"https://api.github.com/repos/radnan/ogone-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radnan/ogone-rails/downloads","issues_url":"https://api.github.com/repos/radnan/ogone-rails/issues{/number}","pulls_url":"https://api.github.com/repos/radnan/ogone-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/radnan/ogone-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/radnan/ogone-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radnan/ogone-rails/labels{/name}","releases_url":"https://api.github.com/repos/radnan/ogone-rails/releases{/id}","created_at":"2015-04-08T10:56:36Z","updated_at":"2015-04-08T10:56:36Z","pushed_at":"2015-04-08T12:13:07Z","git_url":"git://github.com/radnan/ogone-rails.git","ssh_url":"git@github.com:radnan/ogone-rails.git","clone_url":"https://github.com/radnan/ogone-rails.git","svn_url":"https://github.com/radnan/ogone-rails","homepage":"","size":141,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hoetmaaiers:master","ref":"master","sha":"5b9c3112363e23ed1fa6296837ef062781c8b6bd","user":{"login":"hoetmaaiers","id":468045,"avatar_url":"https://avatars.githubusercontent.com/u/468045?v=3","gravatar_id":"","url":"https://api.github.com/users/hoetmaaiers","html_url":"https://github.com/hoetmaaiers","followers_url":"https://api.github.com/users/hoetmaaiers/followers","following_url":"https://api.github.com/users/hoetmaaiers/following{/other_user}","gists_url":"https://api.github.com/users/hoetmaaiers/gists{/gist_id}","starred_url":"https://api.github.com/users/hoetmaaiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoetmaaiers/subscriptions","organizations_url":"https://api.github.com/users/hoetmaaiers/orgs","repos_url":"https://api.github.com/users/hoetmaaiers/repos","events_url":"https://api.github.com/users/hoetmaaiers/events{/privacy}","received_events_url":"https://api.github.com/users/hoetmaaiers/received_events","type":"User","site_admin":false},"repo":{"id":4283214,"name":"ogone-rails","full_name":"hoetmaaiers/ogone-rails","owner":{"login":"hoetmaaiers","id":468045,"avatar_url":"https://avatars.githubusercontent.com/u/468045?v=3","gravatar_id":"","url":"https://api.github.com/users/hoetmaaiers","html_url":"https://github.com/hoetmaaiers","followers_url":"https://api.github.com/users/hoetmaaiers/followers","following_url":"https://api.github.com/users/hoetmaaiers/following{/other_user}","gists_url":"https://api.github.com/users/hoetmaaiers/gists{/gist_id}","starred_url":"https://api.github.com/users/hoetmaaiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoetmaaiers/subscriptions","organizations_url":"https://api.github.com/users/hoetmaaiers/orgs","repos_url":"https://api.github.com/users/hoetmaaiers/repos","events_url":"https://api.github.com/users/hoetmaaiers/events{/privacy}","received_events_url":"https://api.github.com/users/hoetmaaiers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoetmaaiers/ogone-rails","description":"A Ruby gem to simplify the use of Ogone online payments service.","fork":false,"url":"https://api.github.com/repos/hoetmaaiers/ogone-rails","forks_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/forks","keys_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/teams","hooks_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/hooks","issue_events_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/events{/number}","events_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/events","assignees_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/assignees{/user}","branches_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/branches{/branch}","tags_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/tags","blobs_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/languages","stargazers_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/stargazers","contributors_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/contributors","subscribers_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/subscribers","subscription_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/subscription","commits_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/contents/{+path}","compare_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/merges","archive_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/downloads","issues_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues{/number}","pulls_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/labels{/name}","releases_url":"https://api.github.com/repos/hoetmaaiers/ogone-rails/releases{/id}","created_at":"2012-05-10T10:37:22Z","updated_at":"2014-11-26T17:52:46Z","pushed_at":"2015-04-08T12:22:14Z","git_url":"git://github.com/hoetmaaiers/ogone-rails.git","ssh_url":"git@github.com:hoetmaaiers/ogone-rails.git","clone_url":"https://github.com/hoetmaaiers/ogone-rails.git","svn_url":"https://github.com/hoetmaaiers/ogone-rails","homepage":"","size":370,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10"},"html":{"href":"https://github.com/hoetmaaiers/ogone-rails/pull/10"},"issue":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/10"},"comments":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/hoetmaaiers/ogone-rails/statuses/532fb1078778abc134e83784cd90d1ed1464ba33"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hoetmaaiers","id":468045,"avatar_url":"https://avatars.githubusercontent.com/u/468045?v=3","gravatar_id":"","url":"https://api.github.com/users/hoetmaaiers","html_url":"https://github.com/hoetmaaiers","followers_url":"https://api.github.com/users/hoetmaaiers/followers","following_url":"https://api.github.com/users/hoetmaaiers/following{/other_user}","gists_url":"https://api.github.com/users/hoetmaaiers/gists{/gist_id}","starred_url":"https://api.github.com/users/hoetmaaiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoetmaaiers/subscriptions","organizations_url":"https://api.github.com/users/hoetmaaiers/orgs","repos_url":"https://api.github.com/users/hoetmaaiers/repos","events_url":"https://api.github.com/users/hoetmaaiers/events{/privacy}","received_events_url":"https://api.github.com/users/hoetmaaiers/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":6,"deletions":1,"changed_files":2}}