{"action":"created","issue":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/2058","labels_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2058/labels{/name}","comments_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2058/comments","events_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2058/events","html_url":"https://github.com/diydrones/ardupilot/pull/2058","id":66716249,"number":2058,"title":"SerialManager and GCS_MAVLink: fix baudrate for telem2 port ","user":{"login":"mikeclement","id":6856775,"avatar_url":"https://avatars.githubusercontent.com/u/6856775?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeclement","html_url":"https://github.com/mikeclement","followers_url":"https://api.github.com/users/mikeclement/followers","following_url":"https://api.github.com/users/mikeclement/following{/other_user}","gists_url":"https://api.github.com/users/mikeclement/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeclement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeclement/subscriptions","organizations_url":"https://api.github.com/users/mikeclement/orgs","repos_url":"https://api.github.com/users/mikeclement/repos","events_url":"https://api.github.com/users/mikeclement/events{/privacy}","received_events_url":"https://api.github.com/users/mikeclement/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/diydrones/ardupilot/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-06T22:05:15Z","updated_at":"2015-04-06T22:19:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/diydrones/ardupilot/pulls/2058","html_url":"https://github.com/diydrones/ardupilot/pull/2058","diff_url":"https://github.com/diydrones/ardupilot/pull/2058.diff","patch_url":"https://github.com/diydrones/ardupilot/pull/2058.patch"},"body":"After merging commits made since February, we could no longer exchange MAVLink traffic with companion computer. The companion was connected to telem2 port at 115,200 baud or 1,500,000 baud (as set in `SERIAL2_BAUD`). We updated `SERIAL2_PROTOCOL` to `1` per recent changes, to no avail.\r\n\r\nAfter source inspection, we discovered that `AP_SerialManager::find_baudrate()` does not require the new `instance` argument, and therefore always returns the baud rate for the first-scanned port with matching protocol. Since (in our configuration) the first-scanned port is always the telemetry radio port (defaulting to 57,600 baud), that baud rate is selected for any port. In effect, it appeared that the parameter `SERIAL1_BAUD` was being applied to *all* ports.\r\n\r\nThe submitted pull request adds the `instance` argument to `AP_SerialManager::find_baudrate()` and replicates logic from `AP_SerialManager::find_serial()` for matching on the correct port instance."},"comment":{"url":"https://api.github.com/repos/diydrones/ardupilot/issues/comments/90262609","html_url":"https://github.com/diydrones/ardupilot/pull/2058#issuecomment-90262609","issue_url":"https://api.github.com/repos/diydrones/ardupilot/issues/2058","id":90262609,"user":{"login":"magicrub","id":4782875,"avatar_url":"https://avatars.githubusercontent.com/u/4782875?v=3","gravatar_id":"","url":"https://api.github.com/users/magicrub","html_url":"https://github.com/magicrub","followers_url":"https://api.github.com/users/magicrub/followers","following_url":"https://api.github.com/users/magicrub/following{/other_user}","gists_url":"https://api.github.com/users/magicrub/gists{/gist_id}","starred_url":"https://api.github.com/users/magicrub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicrub/subscriptions","organizations_url":"https://api.github.com/users/magicrub/orgs","repos_url":"https://api.github.com/users/magicrub/repos","events_url":"https://api.github.com/users/magicrub/events{/privacy}","received_events_url":"https://api.github.com/users/magicrub/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T22:19:54Z","updated_at":"2015-04-06T22:19:54Z","body":"nice find! I've had some intermittent issues with telem2, I hope this solves it."}}