{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4439","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4439/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4439/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4439/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4439","id":107308847,"number":4439,"title":"Remove MiqRegion.seed from most specs","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/performance","name":"performance","color":"fad8c7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/test","name":"test","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-19T04:04:48Z","updated_at":"2015-09-25T17:08:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4439","html_url":"https://github.com/ManageIQ/manageiq/pull/4439","diff_url":"https://github.com/ManageIQ/manageiq/pull/4439.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4439.patch"},"body":"Followup to #4437 - ~~first 3 commits are from over there.~~\r\n\r\nNow that a typical seed does not lock on `MiqRegion.my_region`, there is no reason to always create a region for seeding.  Remove these from specs.\r\n\r\nAlso in store:\r\n\r\n- more consistent logging\r\n- seeds more stringent with `save!` calls\r\n- `find_or_update_by!`, typically returning the record being seeded (for easier access from tests)\r\n- fewer queries: convert a `create` and `update` into just a `create`.\r\n\r\nOutstanding: The slowest part of the 3 second no-op seed is loading `features`. If we add file date checking or something, then we could probably cut this time further in half. Since all servers are blocking on each other while running through this scenario, performance wise, this may have a significant impact on server startup times across a cluster.\r\n\r\n/cc @Fryguy look at other PR first, this just lets you know what is next\r\n/cc @matthewd thanks\r\n/cc @dmetzger57 fyi"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/143289284","html_url":"https://github.com/ManageIQ/manageiq/pull/4439#issuecomment-143289284","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4439","id":143289284,"user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"created_at":"2015-09-25T17:08:42Z","updated_at":"2015-09-25T17:08:42Z","body":"@chessbyte renamed keys. Thanks. It reads better.\r\n\r\nAny other feedback?"}}