{"action":"created","comment":{"url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/comments/37699097","id":37699097,"diff_hunk":"@@ -9,21 +9,48 @@\n import UIKit\n \n class HomeTableViewController: UITableViewController {\n+    \n+    private let articles = Article.allArticles()\n+    \n     override func viewDidLoad() {\n         super.viewDidLoad()\n         \n-        tableView.estimatedRowHeight = 58\n-//        tableView.rowHeight = UITableViewAutomaticDimension\n+        tableView.rowHeight = UITableViewAutomaticDimension\n     }\n-    \n+   \n     override func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {\n-        return 1\n+        return articles.count\n     }\n     \n     override func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {\n         \n-        let cell = tableView.dequeueReusableCellWithIdentifier(\"ArticleCell\") as UITableViewCell!\n+        let cell = tableView.dequeueReusableCellWithIdentifier(\"ArticleCell\") as! ArticleTableViewCell\n+        let article = articles[indexPath.row]\n+        \n+        cell.title = article.title\n+        cell.url = article.url\n+        cell.date = article.date\n         \n         return cell\n     }\n+    \n+    override func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {\n+        let article = articles[indexPath.row]\n+        performSegueWithIdentifier(\"WebSegue\", sender: article)\n+    }\n+    \n+    override func prepareForSegue(segue: UIStoryboardSegue, sender: AnyObject?) {\n+        if segue.identifier == \"WebSegue\" {","path":"Reading List App/Reading List App/HomeTableViewController.swift","position":40,"original_position":40,"commit_id":"a956f749f6960058d9f28bb502d445f9e2a849f2","original_commit_id":"a956f749f6960058d9f28bb502d445f9e2a849f2","user":{"login":"IanKeen","id":1118013,"avatar_url":"https://avatars.githubusercontent.com/u/1118013?v=3","gravatar_id":"","url":"https://api.github.com/users/IanKeen","html_url":"https://github.com/IanKeen","followers_url":"https://api.github.com/users/IanKeen/followers","following_url":"https://api.github.com/users/IanKeen/following{/other_user}","gists_url":"https://api.github.com/users/IanKeen/gists{/gist_id}","starred_url":"https://api.github.com/users/IanKeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanKeen/subscriptions","organizations_url":"https://api.github.com/users/IanKeen/orgs","repos_url":"https://api.github.com/users/IanKeen/repos","events_url":"https://api.github.com/users/IanKeen/events{/privacy}","received_events_url":"https://api.github.com/users/IanKeen/received_events","type":"User","site_admin":false},"body":"Its good practice to make any hardcoded value (Int, String, etc..) into a constant\r\n\r\nWhy?\r\n-Safety, you never have to worry about typos because the compiler will tell you if you've made a mistake.\r\n-Maintenance, if you ever need to change a value you do it in 1 place and 1 place only.\r\n","created_at":"2015-08-22T19:51:49Z","updated_at":"2015-08-22T19:51:49Z","html_url":"https://github.com/iosdevelopershq/reading-list-app/pull/11#discussion_r37699097","pull_request_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/comments/37699097"},"html":{"href":"https://github.com/iosdevelopershq/reading-list-app/pull/11#discussion_r37699097"},"pull_request":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11","id":42817061,"html_url":"https://github.com/iosdevelopershq/reading-list-app/pull/11","diff_url":"https://github.com/iosdevelopershq/reading-list-app/pull/11.diff","patch_url":"https://github.com/iosdevelopershq/reading-list-app/pull/11.patch","issue_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/11","number":11,"state":"open","locked":false,"title":"Article cell and web view","user":{"login":"andysolomon","id":311253,"avatar_url":"https://avatars.githubusercontent.com/u/311253?v=3","gravatar_id":"","url":"https://api.github.com/users/andysolomon","html_url":"https://github.com/andysolomon","followers_url":"https://api.github.com/users/andysolomon/followers","following_url":"https://api.github.com/users/andysolomon/following{/other_user}","gists_url":"https://api.github.com/users/andysolomon/gists{/gist_id}","starred_url":"https://api.github.com/users/andysolomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andysolomon/subscriptions","organizations_url":"https://api.github.com/users/andysolomon/orgs","repos_url":"https://api.github.com/users/andysolomon/repos","events_url":"https://api.github.com/users/andysolomon/events{/privacy}","received_events_url":"https://api.github.com/users/andysolomon/received_events","type":"User","site_admin":false},"body":"https://vimeo.com/136656380","created_at":"2015-08-19T13:56:57Z","updated_at":"2015-08-22T19:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6450ddf729bc3f69530fd7fe102432b9d61d75e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11/commits","review_comments_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11/comments","review_comment_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/11/comments","statuses_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/statuses/a956f749f6960058d9f28bb502d445f9e2a849f2","head":{"label":"andysolomon:articleCellAndWebView","ref":"articleCellAndWebView","sha":"a956f749f6960058d9f28bb502d445f9e2a849f2","user":{"login":"andysolomon","id":311253,"avatar_url":"https://avatars.githubusercontent.com/u/311253?v=3","gravatar_id":"","url":"https://api.github.com/users/andysolomon","html_url":"https://github.com/andysolomon","followers_url":"https://api.github.com/users/andysolomon/followers","following_url":"https://api.github.com/users/andysolomon/following{/other_user}","gists_url":"https://api.github.com/users/andysolomon/gists{/gist_id}","starred_url":"https://api.github.com/users/andysolomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andysolomon/subscriptions","organizations_url":"https://api.github.com/users/andysolomon/orgs","repos_url":"https://api.github.com/users/andysolomon/repos","events_url":"https://api.github.com/users/andysolomon/events{/privacy}","received_events_url":"https://api.github.com/users/andysolomon/received_events","type":"User","site_admin":false},"repo":{"id":38521057,"name":"reading-list-app","full_name":"andysolomon/reading-list-app","owner":{"login":"andysolomon","id":311253,"avatar_url":"https://avatars.githubusercontent.com/u/311253?v=3","gravatar_id":"","url":"https://api.github.com/users/andysolomon","html_url":"https://github.com/andysolomon","followers_url":"https://api.github.com/users/andysolomon/followers","following_url":"https://api.github.com/users/andysolomon/following{/other_user}","gists_url":"https://api.github.com/users/andysolomon/gists{/gist_id}","starred_url":"https://api.github.com/users/andysolomon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andysolomon/subscriptions","organizations_url":"https://api.github.com/users/andysolomon/orgs","repos_url":"https://api.github.com/users/andysolomon/repos","events_url":"https://api.github.com/users/andysolomon/events{/privacy}","received_events_url":"https://api.github.com/users/andysolomon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andysolomon/reading-list-app","description":"Social Reading List","fork":true,"url":"https://api.github.com/repos/andysolomon/reading-list-app","forks_url":"https://api.github.com/repos/andysolomon/reading-list-app/forks","keys_url":"https://api.github.com/repos/andysolomon/reading-list-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andysolomon/reading-list-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andysolomon/reading-list-app/teams","hooks_url":"https://api.github.com/repos/andysolomon/reading-list-app/hooks","issue_events_url":"https://api.github.com/repos/andysolomon/reading-list-app/issues/events{/number}","events_url":"https://api.github.com/repos/andysolomon/reading-list-app/events","assignees_url":"https://api.github.com/repos/andysolomon/reading-list-app/assignees{/user}","branches_url":"https://api.github.com/repos/andysolomon/reading-list-app/branches{/branch}","tags_url":"https://api.github.com/repos/andysolomon/reading-list-app/tags","blobs_url":"https://api.github.com/repos/andysolomon/reading-list-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andysolomon/reading-list-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andysolomon/reading-list-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/andysolomon/reading-list-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andysolomon/reading-list-app/statuses/{sha}","languages_url":"https://api.github.com/repos/andysolomon/reading-list-app/languages","stargazers_url":"https://api.github.com/repos/andysolomon/reading-list-app/stargazers","contributors_url":"https://api.github.com/repos/andysolomon/reading-list-app/contributors","subscribers_url":"https://api.github.com/repos/andysolomon/reading-list-app/subscribers","subscription_url":"https://api.github.com/repos/andysolomon/reading-list-app/subscription","commits_url":"https://api.github.com/repos/andysolomon/reading-list-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/andysolomon/reading-list-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/andysolomon/reading-list-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/andysolomon/reading-list-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/andysolomon/reading-list-app/contents/{+path}","compare_url":"https://api.github.com/repos/andysolomon/reading-list-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andysolomon/reading-list-app/merges","archive_url":"https://api.github.com/repos/andysolomon/reading-list-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andysolomon/reading-list-app/downloads","issues_url":"https://api.github.com/repos/andysolomon/reading-list-app/issues{/number}","pulls_url":"https://api.github.com/repos/andysolomon/reading-list-app/pulls{/number}","milestones_url":"https://api.github.com/repos/andysolomon/reading-list-app/milestones{/number}","notifications_url":"https://api.github.com/repos/andysolomon/reading-list-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andysolomon/reading-list-app/labels{/name}","releases_url":"https://api.github.com/repos/andysolomon/reading-list-app/releases{/id}","created_at":"2015-07-04T04:07:24Z","updated_at":"2015-07-15T16:13:06Z","pushed_at":"2015-08-19T13:55:21Z","git_url":"git://github.com/andysolomon/reading-list-app.git","ssh_url":"git@github.com:andysolomon/reading-list-app.git","clone_url":"https://github.com/andysolomon/reading-list-app.git","svn_url":"https://github.com/andysolomon/reading-list-app","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iosdevelopershq:master","ref":"master","sha":"0c7c1bda586274a56b1f5257ad5b648dd574d278","user":{"login":"iosdevelopershq","id":12520666,"avatar_url":"https://avatars.githubusercontent.com/u/12520666?v=3","gravatar_id":"","url":"https://api.github.com/users/iosdevelopershq","html_url":"https://github.com/iosdevelopershq","followers_url":"https://api.github.com/users/iosdevelopershq/followers","following_url":"https://api.github.com/users/iosdevelopershq/following{/other_user}","gists_url":"https://api.github.com/users/iosdevelopershq/gists{/gist_id}","starred_url":"https://api.github.com/users/iosdevelopershq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosdevelopershq/subscriptions","organizations_url":"https://api.github.com/users/iosdevelopershq/orgs","repos_url":"https://api.github.com/users/iosdevelopershq/repos","events_url":"https://api.github.com/users/iosdevelopershq/events{/privacy}","received_events_url":"https://api.github.com/users/iosdevelopershq/received_events","type":"Organization","site_admin":false},"repo":{"id":38520524,"name":"reading-list-app","full_name":"iosdevelopershq/reading-list-app","owner":{"login":"iosdevelopershq","id":12520666,"avatar_url":"https://avatars.githubusercontent.com/u/12520666?v=3","gravatar_id":"","url":"https://api.github.com/users/iosdevelopershq","html_url":"https://github.com/iosdevelopershq","followers_url":"https://api.github.com/users/iosdevelopershq/followers","following_url":"https://api.github.com/users/iosdevelopershq/following{/other_user}","gists_url":"https://api.github.com/users/iosdevelopershq/gists{/gist_id}","starred_url":"https://api.github.com/users/iosdevelopershq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iosdevelopershq/subscriptions","organizations_url":"https://api.github.com/users/iosdevelopershq/orgs","repos_url":"https://api.github.com/users/iosdevelopershq/repos","events_url":"https://api.github.com/users/iosdevelopershq/events{/privacy}","received_events_url":"https://api.github.com/users/iosdevelopershq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iosdevelopershq/reading-list-app","description":"Social Reading List","fork":false,"url":"https://api.github.com/repos/iosdevelopershq/reading-list-app","forks_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/forks","keys_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/teams","hooks_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/hooks","issue_events_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/events{/number}","events_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/events","assignees_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/assignees{/user}","branches_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/branches{/branch}","tags_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/tags","blobs_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/statuses/{sha}","languages_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/languages","stargazers_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/stargazers","contributors_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/contributors","subscribers_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/subscribers","subscription_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/subscription","commits_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/contents/{+path}","compare_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/merges","archive_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/downloads","issues_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues{/number}","pulls_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls{/number}","milestones_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/milestones{/number}","notifications_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/labels{/name}","releases_url":"https://api.github.com/repos/iosdevelopershq/reading-list-app/releases{/id}","created_at":"2015-07-04T03:43:21Z","updated_at":"2015-08-20T02:11:23Z","pushed_at":"2015-08-19T13:56:57Z","git_url":"git://github.com/iosdevelopershq/reading-list-app.git","ssh_url":"git@github.com:iosdevelopershq/reading-list-app.git","clone_url":"https://github.com/iosdevelopershq/reading-list-app.git","svn_url":"https://github.com/iosdevelopershq/reading-list-app","homepage":null,"size":14213,"stargazers_count":14,"watchers_count":14,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":2,"forks":11,"open_issues":2,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11"},"html":{"href":"https://github.com/iosdevelopershq/reading-list-app/pull/11"},"issue":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/11"},"comments":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/iosdevelopershq/reading-list-app/statuses/a956f749f6960058d9f28bb502d445f9e2a849f2"}}}}