{"action":"closed","number":6060,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060","id":32113003,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6060","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6060.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6060.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6060","number":6060,"state":"closed","locked":false,"title":"[ubuntu-cluster] fix a serious bug when node both act as master and minion","user":{"login":"resouer","id":1701782,"avatar_url":"https://avatars.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},"body":"We found a serious bug (a extra comma) may break the ubuntu-cluster install process when a node acts both as master and minion.\r\n\r\nWe are still working on PR https://github.com/GoogleCloudPlatform/kubernetes/pull/5498 based on advices from @rjnagal. In order to make ubuntu-cluster fully automatically. But we hope owners can merge this PR first, for usage consideration.","created_at":"2015-03-27T14:47:47Z","updated_at":"2015-03-27T16:53:14Z","closed_at":"2015-03-27T16:53:14Z","merged_at":"2015-03-27T16:53:14Z","merge_commit_sha":"cc1284258338f1630569d665bc01246a160369d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6060/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/88dca5643895956afe10e9e40b135b400472e9e0","head":{"label":"ZJU-SEL:hotfix","ref":"hotfix","sha":"88dca5643895956afe10e9e40b135b400472e9e0","user":{"login":"ZJU-SEL","id":5188515,"avatar_url":"https://avatars.githubusercontent.com/u/5188515?v=3","gravatar_id":"","url":"https://api.github.com/users/ZJU-SEL","html_url":"https://github.com/ZJU-SEL","followers_url":"https://api.github.com/users/ZJU-SEL/followers","following_url":"https://api.github.com/users/ZJU-SEL/following{/other_user}","gists_url":"https://api.github.com/users/ZJU-SEL/gists{/gist_id}","starred_url":"https://api.github.com/users/ZJU-SEL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZJU-SEL/subscriptions","organizations_url":"https://api.github.com/users/ZJU-SEL/orgs","repos_url":"https://api.github.com/users/ZJU-SEL/repos","events_url":"https://api.github.com/users/ZJU-SEL/events{/privacy}","received_events_url":"https://api.github.com/users/ZJU-SEL/received_events","type":"Organization","site_admin":false},"repo":{"id":29713851,"name":"kubernetes","full_name":"ZJU-SEL/kubernetes","owner":{"login":"ZJU-SEL","id":5188515,"avatar_url":"https://avatars.githubusercontent.com/u/5188515?v=3","gravatar_id":"","url":"https://api.github.com/users/ZJU-SEL","html_url":"https://github.com/ZJU-SEL","followers_url":"https://api.github.com/users/ZJU-SEL/followers","following_url":"https://api.github.com/users/ZJU-SEL/following{/other_user}","gists_url":"https://api.github.com/users/ZJU-SEL/gists{/gist_id}","starred_url":"https://api.github.com/users/ZJU-SEL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZJU-SEL/subscriptions","organizations_url":"https://api.github.com/users/ZJU-SEL/orgs","repos_url":"https://api.github.com/users/ZJU-SEL/repos","events_url":"https://api.github.com/users/ZJU-SEL/events{/privacy}","received_events_url":"https://api.github.com/users/ZJU-SEL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZJU-SEL/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ZJU-SEL/kubernetes","forks_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/forks","keys_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/teams","hooks_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/events","assignees_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/tags","blobs_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/subscription","commits_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/merges","archive_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/downloads","issues_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ZJU-SEL/kubernetes/releases{/id}","created_at":"2015-01-23T03:02:22Z","updated_at":"2015-03-16T02:55:58Z","pushed_at":"2015-03-27T07:14:12Z","git_url":"git://github.com/ZJU-SEL/kubernetes.git","ssh_url":"git@github.com:ZJU-SEL/kubernetes.git","clone_url":"https://github.com/ZJU-SEL/kubernetes.git","svn_url":"https://github.com/ZJU-SEL/kubernetes","homepage":"http://kubernetes.io","size":38145,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"a4bf91c8c0c39eaaec79405bbf9f1a7ba2480df2","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-27T16:38:40Z","pushed_at":"2015-03-27T16:53:14Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":116935,"stargazers_count":6780,"watchers_count":6780,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1292,"mirror_url":null,"open_issues_count":807,"forks":1292,"open_issues":807,"watchers":6780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/6060"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6060"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/6060/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/6060/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/88dca5643895956afe10e9e40b135b400472e9e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars.githubusercontent.com/u/5751682?v=3","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}