{"action":"created","issue":{"url":"https://api.github.com/repos/reicast/reicast-emulator/issues/767","labels_url":"https://api.github.com/repos/reicast/reicast-emulator/issues/767/labels{/name}","comments_url":"https://api.github.com/repos/reicast/reicast-emulator/issues/767/comments","events_url":"https://api.github.com/repos/reicast/reicast-emulator/issues/767/events","html_url":"https://github.com/reicast/reicast-emulator/pull/767","id":101711768,"number":767,"title":"cfg: Reimplement ConfigFile using C++ maps and strings","user":{"login":"Holzhaus","id":1834516,"avatar_url":"https://avatars.githubusercontent.com/u/1834516?v=3","gravatar_id":"","url":"https://api.github.com/users/Holzhaus","html_url":"https://github.com/Holzhaus","followers_url":"https://api.github.com/users/Holzhaus/followers","following_url":"https://api.github.com/users/Holzhaus/following{/other_user}","gists_url":"https://api.github.com/users/Holzhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/Holzhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Holzhaus/subscriptions","organizations_url":"https://api.github.com/users/Holzhaus/orgs","repos_url":"https://api.github.com/users/Holzhaus/repos","events_url":"https://api.github.com/users/Holzhaus/events{/privacy}","received_events_url":"https://api.github.com/users/Holzhaus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/reicast/reicast-emulator/labels/to%20review","name":"to review","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-08-18T17:51:08Z","updated_at":"2015-08-24T11:58:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reicast/reicast-emulator/pulls/767","html_url":"https://github.com/reicast/reicast-emulator/pull/767","diff_url":"https://github.com/reicast/reicast-emulator/pull/767.diff","patch_url":"https://github.com/reicast/reicast-emulator/pull/767.patch"},"body":"I reimplemented the stuff from `cfg/ini.cpp` with C++ maps and string, since the original implementation was somewhat complicated to read and also kept segfaulting sometimes for no reason (I didn't find the error at least).\r\n\r\nBonus: It's shorter.\r\n\r\n~~*IMPORTANT:* I currently didn't implement the `flags` stuff, so there are no virtual entries and everything is always saved. @skmp: If you want me to implement that too first, please tell me.~~ **EDIT:** Virtual entry support works now."},"comment":{"url":"https://api.github.com/repos/reicast/reicast-emulator/issues/comments/134165845","html_url":"https://github.com/reicast/reicast-emulator/pull/767#issuecomment-134165845","issue_url":"https://api.github.com/repos/reicast/reicast-emulator/issues/767","id":134165845,"user":{"login":"skmp","id":393266,"avatar_url":"https://avatars.githubusercontent.com/u/393266?v=3","gravatar_id":"","url":"https://api.github.com/users/skmp","html_url":"https://github.com/skmp","followers_url":"https://api.github.com/users/skmp/followers","following_url":"https://api.github.com/users/skmp/following{/other_user}","gists_url":"https://api.github.com/users/skmp/gists{/gist_id}","starred_url":"https://api.github.com/users/skmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmp/subscriptions","organizations_url":"https://api.github.com/users/skmp/orgs","repos_url":"https://api.github.com/users/skmp/repos","events_url":"https://api.github.com/users/skmp/events{/privacy}","received_events_url":"https://api.github.com/users/skmp/received_events","type":"User","site_admin":false},"created_at":"2015-08-24T11:58:23Z","updated_at":"2015-08-24T11:58:23Z","body":"```\r\n\tcfgPath=GetPath(\"/emu.cfg\");\r\n\tFILE* cfgfile = fopen(cfgPath.c_str(),\"r\");\r\n```\r\n\r\nNow it won't create the file at all :p"}}