{"push_id":647005934,"size":25,"distinct_size":0,"ref":"refs/heads/558-WorkArea-Organize-form-objects-by-Work-Area","head":"7f54be6bb5862f076673e3402d9f3523a3ca9bfd","before":"a72a208dfde1787e60fa306791600e89c9f21c03","commits":[{"sha":"7a3f898d1ec2399ed356109b9419586d0e1b8700","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Claiming issue 562\n\nrelates to #562\n\n$ ./script/start-issue 562\n\n[skip ci]","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/7a3f898d1ec2399ed356109b9419586d0e1b8700"},{"sha":"43d5c22099ad2f7b0992e580f6023caa1a4ce6e0","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Adding the Processing::StrategyUsage\n\nInstead of being owned by a proxy, a strategy should be associated\nwith a user; This will reduce the need for duplication of strategies.\nI believe it will also obviate the need for the ApplicationConcept.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/43d5c22099ad2f7b0992e580f6023caa1a4ce6e0"},{"sha":"c7f2a35b7f99ecc43700866db1232e2bf14e597b","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Adding ApplicationConcept.strategy_usage\n\nThis is an interim step as I'm working at migrating data from one form\nto another.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/c7f2a35b7f99ecc43700866db1232e2bf14e597b"},{"sha":"001e4152d7c3c9c844d0fbbcf87adc10fbc614a9","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Correcting processing script to reflect assoc\n\nGiven that associations were removed (the :through construct was\nremoved); I have since rebuild the state diagram","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/001e4152d7c3c9c844d0fbbcf87adc10fbc614a9"},{"sha":"4d1a86b0426989742dfb7c3f41c00c25c71195c6","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Updated Sipity ETD Workflow Diagram","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/4d1a86b0426989742dfb7c3f41c00c25c71195c6"},{"sha":"cfc27efe65999c4cfdd877c76ef4f9f09e1caf9d","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Refactoring DB Seeds to be more modular","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/cfc27efe65999c4cfdd877c76ef4f9f09e1caf9d"},{"sha":"a5dbbe6c4ffc6ab2ecf5651f8d988885125da4c1","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Splcing in StrategyUsage for CreateWorkArea\n\nThis is an intermediary step in that I need to factor away both the\nApplication Concept and the foreign key constraint on the Processing\nStrategy.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/a5dbbe6c4ffc6ab2ecf5651f8d988885125da4c1"},{"sha":"8f6ca1a5a7ff0e453818171c5e9519844ae87698","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Removing creation of ApplicationConcept\n\nAs I said, this was experimental. As such I don't want to keep\nkicking it around.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/8f6ca1a5a7ff0e453818171c5e9519844ae87698"},{"sha":"1c8b21b8c980ebb917325e6b50987f16002f7e69","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Removing ApplicationConcept\n\nThe experiment is being replaced with the StrategyUsage table; A more\nexplicit relationship","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/1c8b21b8c980ebb917325e6b50987f16002f7e69"},{"sha":"36cacd68b8972ffe99facbb8e7df8459d8454ce7","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Tidying up some spec warnings","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/36cacd68b8972ffe99facbb8e7df8459d8454ce7"},{"sha":"de04e79b5af722017c84b32aa017b650cbdfdcea","author":{"email":"71819a9b1a638e9141273f896be434a93da2ed82@nd.edu","name":"rbalekai"},"message":"Merge pull request #563 from ndlib/fixing-sipity-diagram-builder\n\nFixing sipity diagram builder","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/de04e79b5af722017c84b32aa017b650cbdfdcea"},{"sha":"0881a593103d0356340fb7b562faeb7019bfc800","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Preparing StrategyUsage to deprecate foreign key\n\nInstead of having a foreign key (proxy_for) on a Processing::Strategy\nI want to create a joining table (StrategyUsage). The reason being\nthat a given Work Type (e.g. Master's Thesis) has a processing\nstrategy and all Work Area's share the same processing strategy.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/0881a593103d0356340fb7b562faeb7019bfc800"},{"sha":"1ccd318d469774e1824a9b1f9553b476595ace0d","author":{"email":"92ebbd1222de0f5edf10c71dc36ed0a251e36406@gmail.com","name":"Dan Brubaker Horst"},"message":"Merge pull request #564 from ndlib/562-Create-Processing-StrategyUsage-class\n\n562 create processing strategy usage class","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/1ccd318d469774e1824a9b1f9553b476595ace0d"},{"sha":"ffb5622a3160fd6ef4cca0e040a1dc5864205f7e","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Removing Processing::Strategy.proxy_for relationship\n\nTests are broken but this is the moment in which they all break. Now\nto rebuild from there.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/ffb5622a3160fd6ef4cca0e040a1dc5864205f7e"},{"sha":"8fe435b6e070699ebe92caeb223f8c6c8935c44c","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Refactoring to remove belongs_to","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/8fe435b6e070699ebe92caeb223f8c6c8935c44c"},{"sha":"0b662c32d84969c562a920f2e60fcbcf1b8a0800","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Fixing seed data for build","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/0b662c32d84969c562a920f2e60fcbcf1b8a0800"},{"sha":"12547e72215ae196074f0e840fa31bbef1d6b586","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Removing deprecated method test","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/12547e72215ae196074f0e840fa31bbef1d6b586"},{"sha":"67cb1c05fcce3473f55f4a5dc88dc4e1f6fc0ddf","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Refactoring to use CreateWorkService\n\nInstead of the complicated repository method, I'm favoring a service\nobject that can better compose existing behavior. The tests continue\nto fail as this is simply an extract class from method.\n\nThis begs the question:\n\n> Why do some repository methods delegate to a service object and\n> other methods have inline behavior?\n\nMy short answer is that methods are very readable, but classes allow\nencapsulation of ideas. So, as a repository method gets more\ncomplicated it becomes a primary candidate for factoring into a class.\n\nAnother way to think about it is that repository methods provide a\nconvenience method for Presenter and Form interaction with the data.\n\nMy suspicion is that each form should leverage a collaborating service\nclass instead of service method(s); The service class could be swapped\nout as well. But forms are a complicated critter; They need data from\nthe persistence layer and need to issue a command to update the\npersistence layer. (They leverage both commands and queries).\n\nWith the separation of CommandRepository and QueryRepository, our code\nis at a point where forms could be composed of a QueryService and\nCommandService object. And that is how things may move going forward.\nBut for now we factor towards an understanding of how our code is\ngrowing and taking shape.","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/67cb1c05fcce3473f55f4a5dc88dc4e1f6fc0ddf"},{"sha":"ddbe55a613bc49ab8b5b55f40ff060584b903b25","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Adding PowerConverter :work_type","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/ddbe55a613bc49ab8b5b55f40ff060584b903b25"},{"sha":"ae3cf582321df242e5f7dfe3d427a69c62782c1f","author":{"email":"cf980b0cb529ff541807b289951c7805cfbdb5b6@gmail.com","name":"Jeremy Friesen"},"message":"Adding FindOrCreateWorkTypeService\n\n> Responsible for finding or creating the corresponding work type and the\n> requisite processing entries.\n\nAlso consider that the existing tests are using a piecemeal approach\nto work type creation (and strategy creation). This is a class that\ncan be leveraged instead of a FactoryGirl construct (which would not\nbe leveraged in production).","distinct":false,"url":"https://api.github.com/repos/ndlib/sipity/commits/ae3cf582321df242e5f7dfe3d427a69c62782c1f"}]}