{"action":"created","comment":{"url":"https://api.github.com/repos/dartsim/dart/pulls/comments/36182862","id":36182862,"diff_hunk":"@@ -2,6 +2,7 @@\n # CMake settings\n #===============================================================================\n cmake_minimum_required(VERSION 2.8.6 FATAL_ERROR)\n+cmake_policy(SET CMP0042 NEW)","path":"CMakeLists.txt","position":4,"original_position":4,"commit_id":"e3228ea2d6f5f433e1c19bb12e4c6c49db1081fe","original_commit_id":"e3228ea2d6f5f433e1c19bb12e4c6c49db1081fe","user":{"login":"jslee02","id":4038467,"avatar_url":"https://avatars.githubusercontent.com/u/4038467?v=3","gravatar_id":"","url":"https://api.github.com/users/jslee02","html_url":"https://github.com/jslee02","followers_url":"https://api.github.com/users/jslee02/followers","following_url":"https://api.github.com/users/jslee02/following{/other_user}","gists_url":"https://api.github.com/users/jslee02/gists{/gist_id}","starred_url":"https://api.github.com/users/jslee02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslee02/subscriptions","organizations_url":"https://api.github.com/users/jslee02/orgs","repos_url":"https://api.github.com/users/jslee02/repos","events_url":"https://api.github.com/users/jslee02/events{/privacy}","received_events_url":"https://api.github.com/users/jslee02/received_events","type":"User","site_admin":false},"body":"[It seems cmake less than 3.0.0 doesn't recognize this policy](https://travis-ci.org/dartsim/dart/builds/74006048). There is policy existence checker which is supported by cmake 2.8.6. How about this?\r\n\r\n```cmake\r\nif(POLICY CMP0042)\r\n  # MACOSX_RPATH is enabled by default.\r\n  cmake_policy(SET CMP0042 NEW)\r\nendif(POLICY CMP0042)\r\n```","created_at":"2015-08-04T12:44:01Z","updated_at":"2015-08-04T12:44:01Z","html_url":"https://github.com/dartsim/dart/pull/483#discussion_r36182862","pull_request_url":"https://api.github.com/repos/dartsim/dart/pulls/483","_links":{"self":{"href":"https://api.github.com/repos/dartsim/dart/pulls/comments/36182862"},"html":{"href":"https://github.com/dartsim/dart/pull/483#discussion_r36182862"},"pull_request":{"href":"https://api.github.com/repos/dartsim/dart/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/dartsim/dart/pulls/483","id":41535622,"html_url":"https://github.com/dartsim/dart/pull/483","diff_url":"https://github.com/dartsim/dart/pull/483.diff","patch_url":"https://github.com/dartsim/dart/pull/483.patch","issue_url":"https://api.github.com/repos/dartsim/dart/issues/483","number":483,"state":"open","locked":false,"title":"Fixed CMake warnings","user":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"body":"This pull request sets the [`CMP0042` policy](http://www.cmake.org/cmake/help/v3.0/policy/CMP0042.html) in CMake:\r\n\r\n> MACOSX_RPATH is enabled by default.\r\n>\r\n> CMake 2.8.12 and newer has support for using `@rpath` in a target’s install name. This was enabled by setting the target property MACOSX_RPATH. The `@rpath` in an install name is a more flexible and powerful mechanism than @executable_path or `@loader_path` for locating shared libraries.\r\n>\r\n> CMake 3.0 and later prefer this property to be ON by default. Projects wanting `@rpath` in a target’s install name may remove any setting of the INSTALL_NAME_DIR and CMAKE_INSTALL_NAME_DIR variables.\r\n>\r\n> This policy was introduced in CMake version 3.0. CMake version 3.0.2 warns when the policy is not set and uses OLD behavior. Use the cmake_policy command to set it to OLD or NEW explicitly.\r\n\r\nSetting this explicitly suppresses a warning when building with CMake >= 3.0 on OS X. From what I can tell online, `@rpath` is strictly better than the other options, so it is also a good thing to enable.\r\n\r\nI also noticed that CMake was warning about an unused `@only` flag option in `configure_file`. It appears that this flag is case-sensitive, so I changed it to uppercase.","created_at":"2015-08-04T05:29:09Z","updated_at":"2015-08-04T12:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce899aaf802dc0675640d81475de44e4cba4cb3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dartsim/dart/pulls/483/commits","review_comments_url":"https://api.github.com/repos/dartsim/dart/pulls/483/comments","review_comment_url":"https://api.github.com/repos/dartsim/dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dartsim/dart/issues/483/comments","statuses_url":"https://api.github.com/repos/dartsim/dart/statuses/e3228ea2d6f5f433e1c19bb12e4c6c49db1081fe","head":{"label":"mkoval:bugfix/CMP0042","ref":"bugfix/CMP0042","sha":"e3228ea2d6f5f433e1c19bb12e4c6c49db1081fe","user":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"repo":{"id":38646593,"name":"dart","full_name":"mkoval/dart","owner":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkoval/dart","description":"Dynamic Animation and Robotics Toolkit","fork":true,"url":"https://api.github.com/repos/mkoval/dart","forks_url":"https://api.github.com/repos/mkoval/dart/forks","keys_url":"https://api.github.com/repos/mkoval/dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoval/dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoval/dart/teams","hooks_url":"https://api.github.com/repos/mkoval/dart/hooks","issue_events_url":"https://api.github.com/repos/mkoval/dart/issues/events{/number}","events_url":"https://api.github.com/repos/mkoval/dart/events","assignees_url":"https://api.github.com/repos/mkoval/dart/assignees{/user}","branches_url":"https://api.github.com/repos/mkoval/dart/branches{/branch}","tags_url":"https://api.github.com/repos/mkoval/dart/tags","blobs_url":"https://api.github.com/repos/mkoval/dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoval/dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoval/dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoval/dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoval/dart/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoval/dart/languages","stargazers_url":"https://api.github.com/repos/mkoval/dart/stargazers","contributors_url":"https://api.github.com/repos/mkoval/dart/contributors","subscribers_url":"https://api.github.com/repos/mkoval/dart/subscribers","subscription_url":"https://api.github.com/repos/mkoval/dart/subscription","commits_url":"https://api.github.com/repos/mkoval/dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoval/dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoval/dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoval/dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoval/dart/contents/{+path}","compare_url":"https://api.github.com/repos/mkoval/dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoval/dart/merges","archive_url":"https://api.github.com/repos/mkoval/dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoval/dart/downloads","issues_url":"https://api.github.com/repos/mkoval/dart/issues{/number}","pulls_url":"https://api.github.com/repos/mkoval/dart/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoval/dart/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoval/dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoval/dart/labels{/name}","releases_url":"https://api.github.com/repos/mkoval/dart/releases{/id}","created_at":"2015-07-06T21:14:10Z","updated_at":"2015-07-06T21:14:16Z","pushed_at":"2015-08-04T05:58:12Z","git_url":"git://github.com/mkoval/dart.git","ssh_url":"git@github.com:mkoval/dart.git","clone_url":"https://github.com/mkoval/dart.git","svn_url":"https://github.com/mkoval/dart","homepage":"http://dartsim.github.io/","size":99359,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dartsim:master","ref":"master","sha":"99ed8a6f7eb4e6c3ebdcc6f210504db0e489e7f5","user":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"repo":{"id":2418592,"name":"dart","full_name":"dartsim/dart","owner":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dartsim/dart","description":"Dynamic Animation and Robotics Toolkit","fork":false,"url":"https://api.github.com/repos/dartsim/dart","forks_url":"https://api.github.com/repos/dartsim/dart/forks","keys_url":"https://api.github.com/repos/dartsim/dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dartsim/dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dartsim/dart/teams","hooks_url":"https://api.github.com/repos/dartsim/dart/hooks","issue_events_url":"https://api.github.com/repos/dartsim/dart/issues/events{/number}","events_url":"https://api.github.com/repos/dartsim/dart/events","assignees_url":"https://api.github.com/repos/dartsim/dart/assignees{/user}","branches_url":"https://api.github.com/repos/dartsim/dart/branches{/branch}","tags_url":"https://api.github.com/repos/dartsim/dart/tags","blobs_url":"https://api.github.com/repos/dartsim/dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dartsim/dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dartsim/dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/dartsim/dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dartsim/dart/statuses/{sha}","languages_url":"https://api.github.com/repos/dartsim/dart/languages","stargazers_url":"https://api.github.com/repos/dartsim/dart/stargazers","contributors_url":"https://api.github.com/repos/dartsim/dart/contributors","subscribers_url":"https://api.github.com/repos/dartsim/dart/subscribers","subscription_url":"https://api.github.com/repos/dartsim/dart/subscription","commits_url":"https://api.github.com/repos/dartsim/dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/dartsim/dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/dartsim/dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/dartsim/dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/dartsim/dart/contents/{+path}","compare_url":"https://api.github.com/repos/dartsim/dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dartsim/dart/merges","archive_url":"https://api.github.com/repos/dartsim/dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dartsim/dart/downloads","issues_url":"https://api.github.com/repos/dartsim/dart/issues{/number}","pulls_url":"https://api.github.com/repos/dartsim/dart/pulls{/number}","milestones_url":"https://api.github.com/repos/dartsim/dart/milestones{/number}","notifications_url":"https://api.github.com/repos/dartsim/dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dartsim/dart/labels{/name}","releases_url":"https://api.github.com/repos/dartsim/dart/releases{/id}","created_at":"2011-09-19T21:53:51Z","updated_at":"2015-07-27T18:46:29Z","pushed_at":"2015-08-04T12:36:43Z","git_url":"git://github.com/dartsim/dart.git","ssh_url":"git@github.com:dartsim/dart.git","clone_url":"https://github.com/dartsim/dart.git","svn_url":"https://github.com/dartsim/dart","homepage":"http://dartsim.github.io/","size":114076,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":111,"forks":50,"open_issues":111,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dartsim/dart/pulls/483"},"html":{"href":"https://github.com/dartsim/dart/pull/483"},"issue":{"href":"https://api.github.com/repos/dartsim/dart/issues/483"},"comments":{"href":"https://api.github.com/repos/dartsim/dart/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/dartsim/dart/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/dartsim/dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dartsim/dart/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/dartsim/dart/statuses/e3228ea2d6f5f433e1c19bb12e4c6c49db1081fe"}}}}