{"action":"closed","number":1580,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/1580","id":47811920,"html_url":"https://github.com/systemd/systemd/pull/1580","diff_url":"https://github.com/systemd/systemd/pull/1580.diff","patch_url":"https://github.com/systemd/systemd/pull/1580.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/1580","number":1580,"state":"closed","locked":false,"title":"nspawn: skip /sys-as-tmpfs if we don't use private-network","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"body":"Since v3.11/7dc5dbc (\"sysfs: Restrict mounting sysfs\"), the kernel\r\ndoesn't allow mounting sysfs if you don't have CAP_SYS_ADMIN rights over\r\nthe network namespace.\r\n\r\nSo the mounting /sys as a tmpfs code introduced in\r\nd8fc6a000fe21b0c1ba27fbfed8b42d00b349a4b doesn't work with user\r\nnamespaces if we don't use private-net. The reason is that we mount\r\nsysfs inside the container and we're in the network namespace of the host\r\nbut we don't have CAP_SYS_ADMIN over that namespace.\r\n\r\nTo fix that, we mount /sys as a sysfs (instead of tmpfs) if we don't use\r\nprivate network and ignore the /sys-as-a-tmpfs code if we find that /sys\r\nis already mounted as sysfs.\r\n\r\nFixes #1555","created_at":"2015-10-15T16:45:50Z","updated_at":"2015-10-20T08:23:58Z","closed_at":"2015-10-20T08:23:58Z","merged_at":null,"merge_commit_sha":"0417a046334e7cec6c57c7f2c0374ba0c40c4943","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/1580/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/1580/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/1580/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/b816108d85031084500b3476e529e24f9c6134f7","head":{"label":"iaguis:nspawn-sysfs-netns-2","ref":"nspawn-sysfs-netns-2","sha":"b816108d85031084500b3476e529e24f9c6134f7","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"repo":{"id":37249694,"name":"systemd","full_name":"iaguis/systemd","owner":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iaguis/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/iaguis/systemd","forks_url":"https://api.github.com/repos/iaguis/systemd/forks","keys_url":"https://api.github.com/repos/iaguis/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iaguis/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iaguis/systemd/teams","hooks_url":"https://api.github.com/repos/iaguis/systemd/hooks","issue_events_url":"https://api.github.com/repos/iaguis/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/iaguis/systemd/events","assignees_url":"https://api.github.com/repos/iaguis/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/iaguis/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/iaguis/systemd/tags","blobs_url":"https://api.github.com/repos/iaguis/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iaguis/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iaguis/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/iaguis/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iaguis/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/iaguis/systemd/languages","stargazers_url":"https://api.github.com/repos/iaguis/systemd/stargazers","contributors_url":"https://api.github.com/repos/iaguis/systemd/contributors","subscribers_url":"https://api.github.com/repos/iaguis/systemd/subscribers","subscription_url":"https://api.github.com/repos/iaguis/systemd/subscription","commits_url":"https://api.github.com/repos/iaguis/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/iaguis/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/iaguis/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/iaguis/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/iaguis/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/iaguis/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iaguis/systemd/merges","archive_url":"https://api.github.com/repos/iaguis/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iaguis/systemd/downloads","issues_url":"https://api.github.com/repos/iaguis/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/iaguis/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/iaguis/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/iaguis/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iaguis/systemd/labels{/name}","releases_url":"https://api.github.com/repos/iaguis/systemd/releases{/id}","created_at":"2015-06-11T08:44:22Z","updated_at":"2015-06-11T08:44:27Z","pushed_at":"2015-10-20T08:19:32Z","git_url":"git://github.com/iaguis/systemd.git","ssh_url":"git@github.com:iaguis/systemd.git","clone_url":"https://github.com/iaguis/systemd.git","svn_url":"https://github.com/iaguis/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":42573,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"8ee07361d0065a2d4ab9c4bf6aeb0893b05b2b6c","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars.githubusercontent.com/u/1918868?v=3","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"systemd upstream","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","created_at":"2015-03-25T15:27:27Z","updated_at":"2015-10-19T06:09:24Z","pushed_at":"2015-10-20T08:23:44Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":54634,"stargazers_count":635,"watchers_count":635,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":221,"forks":239,"open_issues":221,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1580"},"html":{"href":"https://github.com/systemd/systemd/pull/1580"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/1580"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/1580/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1580/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/1580/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/b816108d85031084500b3476e529e24f9c6134f7"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":3,"commits":1,"additions":68,"deletions":18,"changed_files":5}}