{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5","id":16904523,"html_url":"https://github.com/ccavanaugh/jgnash/pull/5","diff_url":"https://github.com/ccavanaugh/jgnash/pull/5.diff","patch_url":"https://github.com/ccavanaugh/jgnash/pull/5.patch","issue_url":"https://api.github.com/repos/ccavanaugh/jgnash/issues/5","number":5,"state":"closed","locked":false,"title":"Test to reproduce wrong account balance after upgrade from 2.12 to 2.13","user":{"login":"signed","id":567613,"avatar_url":"https://avatars.githubusercontent.com/u/567613?v=3","gravatar_id":"","url":"https://api.github.com/users/signed","html_url":"https://github.com/signed","followers_url":"https://api.github.com/users/signed/followers","following_url":"https://api.github.com/users/signed/following{/other_user}","gists_url":"https://api.github.com/users/signed/gists{/gist_id}","starred_url":"https://api.github.com/users/signed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signed/subscriptions","organizations_url":"https://api.github.com/users/signed/orgs","repos_url":"https://api.github.com/users/signed/repos","events_url":"https://api.github.com/users/signed/events{/privacy}","received_events_url":"https://api.github.com/users/signed/received_events","type":"User","site_admin":false},"body":"After upgrading from 2.12 to 2.13 I noticed that some account balances changed.\r\nI debugged into the sources and managed to create a minimal example to reproduce the problem (this pull request).\r\nI have a Transaction that contains two identical TransactionEntry (have the same hash). When the XML-File is loaded, only one remains in the Transaction.Set<TransactionEntry> transactionEntries. When the file is stored, the TransactionEntry is lost for good.\r\n\r\nWith jgnash 2.12 this worked fine. TransactionEntries where stored within a List instead of a HashSet\r\n\r\nI think the problem was introduced with\r\n596a9b8ce2e8c5a91233d186ff2481067a17c044 Using a set significantly improves Hibernate update performance.\r\n\r\nTo reproduce the problem merge to master, adjust the EngineFactory call and run the test.\r\n\r\nAny chance you can provide a patch for 2.13.x?","created_at":"2014-06-09T19:56:03Z","updated_at":"2015-06-21T16:52:45Z","closed_at":"2015-06-21T16:52:45Z","merged_at":null,"merge_commit_sha":"d0523551fe02e3ed6c808e1dc7126b728f4deae2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccavanaugh/jgnash/issues/5/comments","statuses_url":"https://api.github.com/repos/ccavanaugh/jgnash/statuses/6bd510623efaaf6733d9289d0ab732ea56dd15d5","head":{"label":"signed:losing-transaction-entries","ref":"losing-transaction-entries","sha":"6bd510623efaaf6733d9289d0ab732ea56dd15d5","user":{"login":"signed","id":567613,"avatar_url":"https://avatars.githubusercontent.com/u/567613?v=3","gravatar_id":"","url":"https://api.github.com/users/signed","html_url":"https://github.com/signed","followers_url":"https://api.github.com/users/signed/followers","following_url":"https://api.github.com/users/signed/following{/other_user}","gists_url":"https://api.github.com/users/signed/gists{/gist_id}","starred_url":"https://api.github.com/users/signed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signed/subscriptions","organizations_url":"https://api.github.com/users/signed/orgs","repos_url":"https://api.github.com/users/signed/repos","events_url":"https://api.github.com/users/signed/events{/privacy}","received_events_url":"https://api.github.com/users/signed/received_events","type":"User","site_admin":false},"repo":{"id":15495123,"name":"jgnash","full_name":"signed/jgnash","owner":{"login":"signed","id":567613,"avatar_url":"https://avatars.githubusercontent.com/u/567613?v=3","gravatar_id":"","url":"https://api.github.com/users/signed","html_url":"https://github.com/signed","followers_url":"https://api.github.com/users/signed/followers","following_url":"https://api.github.com/users/signed/following{/other_user}","gists_url":"https://api.github.com/users/signed/gists{/gist_id}","starred_url":"https://api.github.com/users/signed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signed/subscriptions","organizations_url":"https://api.github.com/users/signed/orgs","repos_url":"https://api.github.com/users/signed/repos","events_url":"https://api.github.com/users/signed/events{/privacy}","received_events_url":"https://api.github.com/users/signed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/signed/jgnash","description":"jGnash Personal Finance","fork":true,"url":"https://api.github.com/repos/signed/jgnash","forks_url":"https://api.github.com/repos/signed/jgnash/forks","keys_url":"https://api.github.com/repos/signed/jgnash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signed/jgnash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signed/jgnash/teams","hooks_url":"https://api.github.com/repos/signed/jgnash/hooks","issue_events_url":"https://api.github.com/repos/signed/jgnash/issues/events{/number}","events_url":"https://api.github.com/repos/signed/jgnash/events","assignees_url":"https://api.github.com/repos/signed/jgnash/assignees{/user}","branches_url":"https://api.github.com/repos/signed/jgnash/branches{/branch}","tags_url":"https://api.github.com/repos/signed/jgnash/tags","blobs_url":"https://api.github.com/repos/signed/jgnash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signed/jgnash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signed/jgnash/git/refs{/sha}","trees_url":"https://api.github.com/repos/signed/jgnash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signed/jgnash/statuses/{sha}","languages_url":"https://api.github.com/repos/signed/jgnash/languages","stargazers_url":"https://api.github.com/repos/signed/jgnash/stargazers","contributors_url":"https://api.github.com/repos/signed/jgnash/contributors","subscribers_url":"https://api.github.com/repos/signed/jgnash/subscribers","subscription_url":"https://api.github.com/repos/signed/jgnash/subscription","commits_url":"https://api.github.com/repos/signed/jgnash/commits{/sha}","git_commits_url":"https://api.github.com/repos/signed/jgnash/git/commits{/sha}","comments_url":"https://api.github.com/repos/signed/jgnash/comments{/number}","issue_comment_url":"https://api.github.com/repos/signed/jgnash/issues/comments{/number}","contents_url":"https://api.github.com/repos/signed/jgnash/contents/{+path}","compare_url":"https://api.github.com/repos/signed/jgnash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signed/jgnash/merges","archive_url":"https://api.github.com/repos/signed/jgnash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signed/jgnash/downloads","issues_url":"https://api.github.com/repos/signed/jgnash/issues{/number}","pulls_url":"https://api.github.com/repos/signed/jgnash/pulls{/number}","milestones_url":"https://api.github.com/repos/signed/jgnash/milestones{/number}","notifications_url":"https://api.github.com/repos/signed/jgnash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signed/jgnash/labels{/name}","releases_url":"https://api.github.com/repos/signed/jgnash/releases{/id}","created_at":"2013-12-28T16:15:14Z","updated_at":"2014-10-09T18:16:55Z","pushed_at":"2015-05-30T16:38:46Z","git_url":"git://github.com/signed/jgnash.git","ssh_url":"git@github.com:signed/jgnash.git","clone_url":"https://github.com/signed/jgnash.git","svn_url":"https://github.com/signed/jgnash","homepage":"","size":13039,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ccavanaugh:master","ref":"master","sha":"8f3f77496a48d45e623b82b0a49d827600df2bc6","user":{"login":"ccavanaugh","id":636962,"avatar_url":"https://avatars.githubusercontent.com/u/636962?v=3","gravatar_id":"","url":"https://api.github.com/users/ccavanaugh","html_url":"https://github.com/ccavanaugh","followers_url":"https://api.github.com/users/ccavanaugh/followers","following_url":"https://api.github.com/users/ccavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/ccavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/ccavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccavanaugh/subscriptions","organizations_url":"https://api.github.com/users/ccavanaugh/orgs","repos_url":"https://api.github.com/users/ccavanaugh/repos","events_url":"https://api.github.com/users/ccavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/ccavanaugh/received_events","type":"User","site_admin":false},"repo":{"id":8539874,"name":"jgnash","full_name":"ccavanaugh/jgnash","owner":{"login":"ccavanaugh","id":636962,"avatar_url":"https://avatars.githubusercontent.com/u/636962?v=3","gravatar_id":"","url":"https://api.github.com/users/ccavanaugh","html_url":"https://github.com/ccavanaugh","followers_url":"https://api.github.com/users/ccavanaugh/followers","following_url":"https://api.github.com/users/ccavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/ccavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/ccavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccavanaugh/subscriptions","organizations_url":"https://api.github.com/users/ccavanaugh/orgs","repos_url":"https://api.github.com/users/ccavanaugh/repos","events_url":"https://api.github.com/users/ccavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/ccavanaugh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccavanaugh/jgnash","description":"jGnash Personal Finance","fork":false,"url":"https://api.github.com/repos/ccavanaugh/jgnash","forks_url":"https://api.github.com/repos/ccavanaugh/jgnash/forks","keys_url":"https://api.github.com/repos/ccavanaugh/jgnash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccavanaugh/jgnash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccavanaugh/jgnash/teams","hooks_url":"https://api.github.com/repos/ccavanaugh/jgnash/hooks","issue_events_url":"https://api.github.com/repos/ccavanaugh/jgnash/issues/events{/number}","events_url":"https://api.github.com/repos/ccavanaugh/jgnash/events","assignees_url":"https://api.github.com/repos/ccavanaugh/jgnash/assignees{/user}","branches_url":"https://api.github.com/repos/ccavanaugh/jgnash/branches{/branch}","tags_url":"https://api.github.com/repos/ccavanaugh/jgnash/tags","blobs_url":"https://api.github.com/repos/ccavanaugh/jgnash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccavanaugh/jgnash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccavanaugh/jgnash/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccavanaugh/jgnash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccavanaugh/jgnash/statuses/{sha}","languages_url":"https://api.github.com/repos/ccavanaugh/jgnash/languages","stargazers_url":"https://api.github.com/repos/ccavanaugh/jgnash/stargazers","contributors_url":"https://api.github.com/repos/ccavanaugh/jgnash/contributors","subscribers_url":"https://api.github.com/repos/ccavanaugh/jgnash/subscribers","subscription_url":"https://api.github.com/repos/ccavanaugh/jgnash/subscription","commits_url":"https://api.github.com/repos/ccavanaugh/jgnash/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccavanaugh/jgnash/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccavanaugh/jgnash/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccavanaugh/jgnash/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccavanaugh/jgnash/contents/{+path}","compare_url":"https://api.github.com/repos/ccavanaugh/jgnash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccavanaugh/jgnash/merges","archive_url":"https://api.github.com/repos/ccavanaugh/jgnash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccavanaugh/jgnash/downloads","issues_url":"https://api.github.com/repos/ccavanaugh/jgnash/issues{/number}","pulls_url":"https://api.github.com/repos/ccavanaugh/jgnash/pulls{/number}","milestones_url":"https://api.github.com/repos/ccavanaugh/jgnash/milestones{/number}","notifications_url":"https://api.github.com/repos/ccavanaugh/jgnash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccavanaugh/jgnash/labels{/name}","releases_url":"https://api.github.com/repos/ccavanaugh/jgnash/releases{/id}","created_at":"2013-03-03T17:46:49Z","updated_at":"2015-06-13T22:25:46Z","pushed_at":"2015-06-21T10:31:29Z","git_url":"git://github.com/ccavanaugh/jgnash.git","ssh_url":"git@github.com:ccavanaugh/jgnash.git","clone_url":"https://github.com/ccavanaugh/jgnash.git","svn_url":"https://github.com/ccavanaugh/jgnash","homepage":"http://ccavanaugh.github.io/jgnash/","size":18221,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":0,"forks":24,"open_issues":0,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5"},"html":{"href":"https://github.com/ccavanaugh/jgnash/pull/5"},"issue":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/issues/5"},"comments":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ccavanaugh/jgnash/statuses/6bd510623efaaf6733d9289d0ab732ea56dd15d5"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":178,"deletions":0,"changed_files":2}}