{"action":"created","comment":{"url":"https://api.github.com/repos/burtcorp/humboldt/pulls/comments/45072573","id":45072573,"diff_hunk":"@@ -60,7 +61,19 @@ def run_local\n       end\n       input_glob = File.join(options[:data_path], options[:input])\n       hadoop_config_path = options[:hadoop_config] || default_hadoop_config_path\n-      run_command('hadoop', 'jar', project_jar, '-conf', hadoop_config_path, job_config, input_glob, output_path, *options[:extra_hadoop_args])\n+      hadoop_command = ['hadoop', 'jar', project_jar]\n+      hadoop_config = ['-conf', hadoop_config_path]\n+      job_args = [input_glob, output_path, *options[:extra_hadoop_args]]\n+      command = hadoop_command.dup\n+      if Rubydoop::VERSION > '2.0.0'","path":"lib/humboldt/cli.rb","position":17,"original_position":17,"commit_id":"35b8786d93359e117dfd0671df54db29713fad89","original_commit_id":"35b8786d93359e117dfd0671df54db29713fad89","user":{"login":"stenlarsson","id":7447895,"avatar_url":"https://avatars.githubusercontent.com/u/7447895?v=3","gravatar_id":"","url":"https://api.github.com/users/stenlarsson","html_url":"https://github.com/stenlarsson","followers_url":"https://api.github.com/users/stenlarsson/followers","following_url":"https://api.github.com/users/stenlarsson/following{/other_user}","gists_url":"https://api.github.com/users/stenlarsson/gists{/gist_id}","starred_url":"https://api.github.com/users/stenlarsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenlarsson/subscriptions","organizations_url":"https://api.github.com/users/stenlarsson/orgs","repos_url":"https://api.github.com/users/stenlarsson/repos","events_url":"https://api.github.com/users/stenlarsson/events{/privacy}","received_events_url":"https://api.github.com/users/stenlarsson/received_events","type":"User","site_admin":false},"body":"I think the comparison should be `>=`, not `>`.\r\n\r\nAlso, comparing strings might theoretically give the wrong result. Perhaps something like this instead:\r\n```ruby\r\nif Gem::Version.new(Rubydoop::VERSION) >= Gem::Version.new('2.0.0')\r\n```","created_at":"2015-11-17T15:24:44Z","updated_at":"2015-11-17T15:24:44Z","html_url":"https://github.com/burtcorp/humboldt/pull/21#discussion_r45072573","pull_request_url":"https://api.github.com/repos/burtcorp/humboldt/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/comments/45072573"},"html":{"href":"https://github.com/burtcorp/humboldt/pull/21#discussion_r45072573"},"pull_request":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/burtcorp/humboldt/pulls/21","id":45151985,"html_url":"https://github.com/burtcorp/humboldt/pull/21","diff_url":"https://github.com/burtcorp/humboldt/pull/21.diff","patch_url":"https://github.com/burtcorp/humboldt/pull/21.patch","issue_url":"https://api.github.com/repos/burtcorp/humboldt/issues/21","number":21,"state":"open","locked":false,"title":"Change the order of the command line arguments in run-local","user":{"login":"iconara","id":73330,"avatar_url":"https://avatars.githubusercontent.com/u/73330?v=3","gravatar_id":"","url":"https://api.github.com/users/iconara","html_url":"https://github.com/iconara","followers_url":"https://api.github.com/users/iconara/followers","following_url":"https://api.github.com/users/iconara/following{/other_user}","gists_url":"https://api.github.com/users/iconara/gists{/gist_id}","starred_url":"https://api.github.com/users/iconara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iconara/subscriptions","organizations_url":"https://api.github.com/users/iconara/orgs","repos_url":"https://api.github.com/users/iconara/repos","events_url":"https://api.github.com/users/iconara/events{/privacy}","received_events_url":"https://api.github.com/users/iconara/received_events","type":"User","site_admin":false},"body":"When using the next version of Rubydoop the first argument must be the job name, and with the current implementation the first argument is `-config`.","created_at":"2015-09-16T09:58:28Z","updated_at":"2015-11-17T15:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a459445374f1318c2938e5187acb4adb1350135","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/burtcorp/humboldt/pulls/21/commits","review_comments_url":"https://api.github.com/repos/burtcorp/humboldt/pulls/21/comments","review_comment_url":"https://api.github.com/repos/burtcorp/humboldt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/burtcorp/humboldt/issues/21/comments","statuses_url":"https://api.github.com/repos/burtcorp/humboldt/statuses/35b8786d93359e117dfd0671df54db29713fad89","head":{"label":"burtcorp:command-line-order","ref":"command-line-order","sha":"35b8786d93359e117dfd0671df54db29713fad89","user":{"login":"burtcorp","id":32987,"avatar_url":"https://avatars.githubusercontent.com/u/32987?v=3","gravatar_id":"","url":"https://api.github.com/users/burtcorp","html_url":"https://github.com/burtcorp","followers_url":"https://api.github.com/users/burtcorp/followers","following_url":"https://api.github.com/users/burtcorp/following{/other_user}","gists_url":"https://api.github.com/users/burtcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/burtcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtcorp/subscriptions","organizations_url":"https://api.github.com/users/burtcorp/orgs","repos_url":"https://api.github.com/users/burtcorp/repos","events_url":"https://api.github.com/users/burtcorp/events{/privacy}","received_events_url":"https://api.github.com/users/burtcorp/received_events","type":"Organization","site_admin":false},"repo":{"id":6072657,"name":"humboldt","full_name":"burtcorp/humboldt","owner":{"login":"burtcorp","id":32987,"avatar_url":"https://avatars.githubusercontent.com/u/32987?v=3","gravatar_id":"","url":"https://api.github.com/users/burtcorp","html_url":"https://github.com/burtcorp","followers_url":"https://api.github.com/users/burtcorp/followers","following_url":"https://api.github.com/users/burtcorp/following{/other_user}","gists_url":"https://api.github.com/users/burtcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/burtcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtcorp/subscriptions","organizations_url":"https://api.github.com/users/burtcorp/orgs","repos_url":"https://api.github.com/users/burtcorp/repos","events_url":"https://api.github.com/users/burtcorp/events{/privacy}","received_events_url":"https://api.github.com/users/burtcorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/burtcorp/humboldt","description":"Explore and measure all the things!","fork":false,"url":"https://api.github.com/repos/burtcorp/humboldt","forks_url":"https://api.github.com/repos/burtcorp/humboldt/forks","keys_url":"https://api.github.com/repos/burtcorp/humboldt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burtcorp/humboldt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burtcorp/humboldt/teams","hooks_url":"https://api.github.com/repos/burtcorp/humboldt/hooks","issue_events_url":"https://api.github.com/repos/burtcorp/humboldt/issues/events{/number}","events_url":"https://api.github.com/repos/burtcorp/humboldt/events","assignees_url":"https://api.github.com/repos/burtcorp/humboldt/assignees{/user}","branches_url":"https://api.github.com/repos/burtcorp/humboldt/branches{/branch}","tags_url":"https://api.github.com/repos/burtcorp/humboldt/tags","blobs_url":"https://api.github.com/repos/burtcorp/humboldt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burtcorp/humboldt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burtcorp/humboldt/git/refs{/sha}","trees_url":"https://api.github.com/repos/burtcorp/humboldt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burtcorp/humboldt/statuses/{sha}","languages_url":"https://api.github.com/repos/burtcorp/humboldt/languages","stargazers_url":"https://api.github.com/repos/burtcorp/humboldt/stargazers","contributors_url":"https://api.github.com/repos/burtcorp/humboldt/contributors","subscribers_url":"https://api.github.com/repos/burtcorp/humboldt/subscribers","subscription_url":"https://api.github.com/repos/burtcorp/humboldt/subscription","commits_url":"https://api.github.com/repos/burtcorp/humboldt/commits{/sha}","git_commits_url":"https://api.github.com/repos/burtcorp/humboldt/git/commits{/sha}","comments_url":"https://api.github.com/repos/burtcorp/humboldt/comments{/number}","issue_comment_url":"https://api.github.com/repos/burtcorp/humboldt/issues/comments{/number}","contents_url":"https://api.github.com/repos/burtcorp/humboldt/contents/{+path}","compare_url":"https://api.github.com/repos/burtcorp/humboldt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burtcorp/humboldt/merges","archive_url":"https://api.github.com/repos/burtcorp/humboldt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burtcorp/humboldt/downloads","issues_url":"https://api.github.com/repos/burtcorp/humboldt/issues{/number}","pulls_url":"https://api.github.com/repos/burtcorp/humboldt/pulls{/number}","milestones_url":"https://api.github.com/repos/burtcorp/humboldt/milestones{/number}","notifications_url":"https://api.github.com/repos/burtcorp/humboldt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burtcorp/humboldt/labels{/name}","releases_url":"https://api.github.com/repos/burtcorp/humboldt/releases{/id}","created_at":"2012-10-04T08:32:54Z","updated_at":"2015-04-02T11:57:30Z","pushed_at":"2015-10-19T13:59:10Z","git_url":"git://github.com/burtcorp/humboldt.git","ssh_url":"git@github.com:burtcorp/humboldt.git","clone_url":"https://github.com/burtcorp/humboldt.git","svn_url":"https://github.com/burtcorp/humboldt","homepage":null,"size":784,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"burtcorp:master","ref":"master","sha":"4f4486e0fd819b52e7e60d3379b70f0ac682b6ee","user":{"login":"burtcorp","id":32987,"avatar_url":"https://avatars.githubusercontent.com/u/32987?v=3","gravatar_id":"","url":"https://api.github.com/users/burtcorp","html_url":"https://github.com/burtcorp","followers_url":"https://api.github.com/users/burtcorp/followers","following_url":"https://api.github.com/users/burtcorp/following{/other_user}","gists_url":"https://api.github.com/users/burtcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/burtcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtcorp/subscriptions","organizations_url":"https://api.github.com/users/burtcorp/orgs","repos_url":"https://api.github.com/users/burtcorp/repos","events_url":"https://api.github.com/users/burtcorp/events{/privacy}","received_events_url":"https://api.github.com/users/burtcorp/received_events","type":"Organization","site_admin":false},"repo":{"id":6072657,"name":"humboldt","full_name":"burtcorp/humboldt","owner":{"login":"burtcorp","id":32987,"avatar_url":"https://avatars.githubusercontent.com/u/32987?v=3","gravatar_id":"","url":"https://api.github.com/users/burtcorp","html_url":"https://github.com/burtcorp","followers_url":"https://api.github.com/users/burtcorp/followers","following_url":"https://api.github.com/users/burtcorp/following{/other_user}","gists_url":"https://api.github.com/users/burtcorp/gists{/gist_id}","starred_url":"https://api.github.com/users/burtcorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burtcorp/subscriptions","organizations_url":"https://api.github.com/users/burtcorp/orgs","repos_url":"https://api.github.com/users/burtcorp/repos","events_url":"https://api.github.com/users/burtcorp/events{/privacy}","received_events_url":"https://api.github.com/users/burtcorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/burtcorp/humboldt","description":"Explore and measure all the things!","fork":false,"url":"https://api.github.com/repos/burtcorp/humboldt","forks_url":"https://api.github.com/repos/burtcorp/humboldt/forks","keys_url":"https://api.github.com/repos/burtcorp/humboldt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burtcorp/humboldt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burtcorp/humboldt/teams","hooks_url":"https://api.github.com/repos/burtcorp/humboldt/hooks","issue_events_url":"https://api.github.com/repos/burtcorp/humboldt/issues/events{/number}","events_url":"https://api.github.com/repos/burtcorp/humboldt/events","assignees_url":"https://api.github.com/repos/burtcorp/humboldt/assignees{/user}","branches_url":"https://api.github.com/repos/burtcorp/humboldt/branches{/branch}","tags_url":"https://api.github.com/repos/burtcorp/humboldt/tags","blobs_url":"https://api.github.com/repos/burtcorp/humboldt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burtcorp/humboldt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burtcorp/humboldt/git/refs{/sha}","trees_url":"https://api.github.com/repos/burtcorp/humboldt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burtcorp/humboldt/statuses/{sha}","languages_url":"https://api.github.com/repos/burtcorp/humboldt/languages","stargazers_url":"https://api.github.com/repos/burtcorp/humboldt/stargazers","contributors_url":"https://api.github.com/repos/burtcorp/humboldt/contributors","subscribers_url":"https://api.github.com/repos/burtcorp/humboldt/subscribers","subscription_url":"https://api.github.com/repos/burtcorp/humboldt/subscription","commits_url":"https://api.github.com/repos/burtcorp/humboldt/commits{/sha}","git_commits_url":"https://api.github.com/repos/burtcorp/humboldt/git/commits{/sha}","comments_url":"https://api.github.com/repos/burtcorp/humboldt/comments{/number}","issue_comment_url":"https://api.github.com/repos/burtcorp/humboldt/issues/comments{/number}","contents_url":"https://api.github.com/repos/burtcorp/humboldt/contents/{+path}","compare_url":"https://api.github.com/repos/burtcorp/humboldt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burtcorp/humboldt/merges","archive_url":"https://api.github.com/repos/burtcorp/humboldt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burtcorp/humboldt/downloads","issues_url":"https://api.github.com/repos/burtcorp/humboldt/issues{/number}","pulls_url":"https://api.github.com/repos/burtcorp/humboldt/pulls{/number}","milestones_url":"https://api.github.com/repos/burtcorp/humboldt/milestones{/number}","notifications_url":"https://api.github.com/repos/burtcorp/humboldt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burtcorp/humboldt/labels{/name}","releases_url":"https://api.github.com/repos/burtcorp/humboldt/releases{/id}","created_at":"2012-10-04T08:32:54Z","updated_at":"2015-04-02T11:57:30Z","pushed_at":"2015-10-19T13:59:10Z","git_url":"git://github.com/burtcorp/humboldt.git","ssh_url":"git@github.com:burtcorp/humboldt.git","clone_url":"https://github.com/burtcorp/humboldt.git","svn_url":"https://github.com/burtcorp/humboldt","homepage":null,"size":784,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/21"},"html":{"href":"https://github.com/burtcorp/humboldt/pull/21"},"issue":{"href":"https://api.github.com/repos/burtcorp/humboldt/issues/21"},"comments":{"href":"https://api.github.com/repos/burtcorp/humboldt/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/burtcorp/humboldt/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/burtcorp/humboldt/statuses/35b8786d93359e117dfd0671df54db29713fad89"}}}}