{"action":"closed","number":3928,"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3928","id":46025818,"html_url":"https://github.com/phpbb/phpbb/pull/3928","diff_url":"https://github.com/phpbb/phpbb/pull/3928.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3928.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3928","number":3928,"state":"closed","locked":false,"title":"[Ticket/14197]Modularize/refactor all buttons","user":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?v=3","gravatar_id":"","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"body":"To allow for a more consistent UI as well as easier maintainability and customization we should refactor all button variations to work off of the primary button module with modifer classes for the different varions. Then consolidate all of it into the buttons.css file and reorganize it.\r\n\r\nTickets: \r\nhttps://tracker.phpbb.com/browse/PHPBB3-14197\r\nhttps://tracker.phpbb.com/browse/PHPBB3-14193\r\n\r\nPHPBB3-14197","created_at":"2015-09-25T15:37:48Z","updated_at":"2015-10-02T17:06:05Z","closed_at":"2015-10-02T17:06:05Z","merged_at":null,"merge_commit_sha":"b901d2e674e938e31c3b963fd37dba170f1d6c87","assignee":null,"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/2","html_url":"https://github.com/phpbb/phpbb/milestones/3.2.0-a1","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/2/labels","id":835770,"number":2,"title":"3.2.0-a1","description":"/!\\ Feature freeze for the 3.2 release","creator":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":190,"state":"open","created_at":"2014-10-22T10:41:02Z","updated_at":"2015-10-02T17:06:05Z","due_on":"2015-09-19T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3928/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3928/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3928/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/e6ade6492343ee4fa9afd4d8fd72842913da889f","head":{"label":"hanakin:ticket/14197","ref":"ticket/14197","sha":"e6ade6492343ee4fa9afd4d8fd72842913da889f","user":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?v=3","gravatar_id":"","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"repo":{"id":20864087,"name":"phpbb","full_name":"hanakin/phpbb","owner":{"login":"hanakin","id":73081,"avatar_url":"https://avatars.githubusercontent.com/u/73081?v=3","gravatar_id":"","url":"https://api.github.com/users/hanakin","html_url":"https://github.com/hanakin","followers_url":"https://api.github.com/users/hanakin/followers","following_url":"https://api.github.com/users/hanakin/following{/other_user}","gists_url":"https://api.github.com/users/hanakin/gists{/gist_id}","starred_url":"https://api.github.com/users/hanakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanakin/subscriptions","organizations_url":"https://api.github.com/users/hanakin/orgs","repos_url":"https://api.github.com/users/hanakin/repos","events_url":"https://api.github.com/users/hanakin/events{/privacy}","received_events_url":"https://api.github.com/users/hanakin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hanakin/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/hanakin/phpbb","forks_url":"https://api.github.com/repos/hanakin/phpbb/forks","keys_url":"https://api.github.com/repos/hanakin/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanakin/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanakin/phpbb/teams","hooks_url":"https://api.github.com/repos/hanakin/phpbb/hooks","issue_events_url":"https://api.github.com/repos/hanakin/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/hanakin/phpbb/events","assignees_url":"https://api.github.com/repos/hanakin/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/hanakin/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/hanakin/phpbb/tags","blobs_url":"https://api.github.com/repos/hanakin/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanakin/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanakin/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanakin/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanakin/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/hanakin/phpbb/languages","stargazers_url":"https://api.github.com/repos/hanakin/phpbb/stargazers","contributors_url":"https://api.github.com/repos/hanakin/phpbb/contributors","subscribers_url":"https://api.github.com/repos/hanakin/phpbb/subscribers","subscription_url":"https://api.github.com/repos/hanakin/phpbb/subscription","commits_url":"https://api.github.com/repos/hanakin/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanakin/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanakin/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanakin/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanakin/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/hanakin/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanakin/phpbb/merges","archive_url":"https://api.github.com/repos/hanakin/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanakin/phpbb/downloads","issues_url":"https://api.github.com/repos/hanakin/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/hanakin/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/hanakin/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/hanakin/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanakin/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/hanakin/phpbb/releases{/id}","created_at":"2014-06-15T20:01:50Z","updated_at":"2015-01-05T21:36:33Z","pushed_at":"2015-10-02T03:14:06Z","git_url":"git://github.com/hanakin/phpbb.git","ssh_url":"git@github.com:hanakin/phpbb.git","clone_url":"https://github.com/hanakin/phpbb.git","svn_url":"https://github.com/hanakin/phpbb","homepage":"http://www.phpbb.com","size":59007,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:master","ref":"master","sha":"8451272d6995e161aeb530755527b49ae99d7c31","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments{/number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2015-10-02T01:09:09Z","pushed_at":"2015-10-02T16:39:06Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":202319,"stargazers_count":779,"watchers_count":779,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":492,"mirror_url":null,"open_issues_count":105,"forks":492,"open_issues":105,"watchers":779,"default_branch":"3.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3928"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3928"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3928"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3928/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3928/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3928/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/e6ade6492343ee4fa9afd4d8fd72842913da889f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":14,"review_comments":0,"commits":2,"additions":406,"deletions":494,"changed_files":83}}