{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/35271836","id":35271836,"diff_hunk":"@@ -0,0 +1,43 @@\n+/*\n+ *\n+ * Copyright 2015, Google Inc.\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are\n+ * met:\n+ *\n+ *     * Redistributions of source code must retain the above copyright\n+ * notice, this list of conditions and the following disclaimer.\n+ *     * Redistributions in binary form must reproduce the above\n+ * copyright notice, this list of conditions and the following disclaimer\n+ * in the documentation and/or other materials provided with the\n+ * distribution.\n+ *     * Neither the name of Google Inc. nor the names of its\n+ * contributors may be used to endorse or promote products derived from\n+ * this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ */\n+\n+/* This is just a compilation test, to see if we have Zookeeper C client \n+   library installed. */\n+\n+#include <stdlib.h>\n+#include <zookeeper/zookeeper.h>\n+","path":"test/build/zookeeper.c","position":39,"original_position":39,"commit_id":"cd62075eb6e9c4aba6d9de9be9e2a9615844c3d3","original_commit_id":"00de69835549d4504d9b38ad9278919d6bf0b964","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"body":"where are the tests? :)","created_at":"2015-07-22T22:26:24Z","updated_at":"2015-07-22T22:26:24Z","html_url":"https://github.com/grpc/grpc/pull/2549#discussion_r35271836","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/2549","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/35271836"},"html":{"href":"https://github.com/grpc/grpc/pull/2549#discussion_r35271836"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2549"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/2549","id":40399991,"html_url":"https://github.com/grpc/grpc/pull/2549","diff_url":"https://github.com/grpc/grpc/pull/2549.diff","patch_url":"https://github.com/grpc/grpc/pull/2549.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/2549","number":2549,"state":"open","locked":false,"title":"Zookeeper name resolver","user":{"login":"hongweiwang","id":2645523,"avatar_url":"https://avatars.githubusercontent.com/u/2645523?v=3","gravatar_id":"","url":"https://api.github.com/users/hongweiwang","html_url":"https://github.com/hongweiwang","followers_url":"https://api.github.com/users/hongweiwang/followers","following_url":"https://api.github.com/users/hongweiwang/following{/other_user}","gists_url":"https://api.github.com/users/hongweiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hongweiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongweiwang/subscriptions","organizations_url":"https://api.github.com/users/hongweiwang/orgs","repos_url":"https://api.github.com/users/hongweiwang/repos","events_url":"https://api.github.com/users/hongweiwang/events{/privacy}","received_events_url":"https://api.github.com/users/hongweiwang/received_events","type":"User","site_admin":false},"body":"Add zookeeper name resolver to gRPC. Zookeeper names in gRPC are represented as a URI.\r\n`zookeeper://host:port/name`\r\nWhere `host:port` is zookeeper server address. `name` is zookeeper path of the service. An example would be `zookeeper://127.0.0.1:2181/storage/mysql`.\r\n\r\nServices are registered in zookeeper server in hierarchical format `service/instance`, similar to [Apache Curator] (http://curator.apache.org/curator-x-discovery/index.html). Each service is a zookeeper node, and each instance is a child node of the service. Each instance node stores its address (host and port) in JSON format. ","created_at":"2015-07-20T21:35:07Z","updated_at":"2015-07-22T22:26:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"387a7e45e71fb440cdf2a5ad97fe97666e04a136","assignee":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars.githubusercontent.com/u/120217?v=3","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/2549/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/2549/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/2549/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/cd62075eb6e9c4aba6d9de9be9e2a9615844c3d3","head":{"label":"hongweiwang:zookeeper","ref":"zookeeper","sha":"cd62075eb6e9c4aba6d9de9be9e2a9615844c3d3","user":{"login":"hongweiwang","id":2645523,"avatar_url":"https://avatars.githubusercontent.com/u/2645523?v=3","gravatar_id":"","url":"https://api.github.com/users/hongweiwang","html_url":"https://github.com/hongweiwang","followers_url":"https://api.github.com/users/hongweiwang/followers","following_url":"https://api.github.com/users/hongweiwang/following{/other_user}","gists_url":"https://api.github.com/users/hongweiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hongweiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongweiwang/subscriptions","organizations_url":"https://api.github.com/users/hongweiwang/orgs","repos_url":"https://api.github.com/users/hongweiwang/repos","events_url":"https://api.github.com/users/hongweiwang/events{/privacy}","received_events_url":"https://api.github.com/users/hongweiwang/received_events","type":"User","site_admin":false},"repo":{"id":37952583,"name":"grpc","full_name":"hongweiwang/grpc","owner":{"login":"hongweiwang","id":2645523,"avatar_url":"https://avatars.githubusercontent.com/u/2645523?v=3","gravatar_id":"","url":"https://api.github.com/users/hongweiwang","html_url":"https://github.com/hongweiwang","followers_url":"https://api.github.com/users/hongweiwang/followers","following_url":"https://api.github.com/users/hongweiwang/following{/other_user}","gists_url":"https://api.github.com/users/hongweiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/hongweiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongweiwang/subscriptions","organizations_url":"https://api.github.com/users/hongweiwang/orgs","repos_url":"https://api.github.com/users/hongweiwang/repos","events_url":"https://api.github.com/users/hongweiwang/events{/privacy}","received_events_url":"https://api.github.com/users/hongweiwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hongweiwang/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/hongweiwang/grpc","forks_url":"https://api.github.com/repos/hongweiwang/grpc/forks","keys_url":"https://api.github.com/repos/hongweiwang/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongweiwang/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongweiwang/grpc/teams","hooks_url":"https://api.github.com/repos/hongweiwang/grpc/hooks","issue_events_url":"https://api.github.com/repos/hongweiwang/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/hongweiwang/grpc/events","assignees_url":"https://api.github.com/repos/hongweiwang/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/hongweiwang/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/hongweiwang/grpc/tags","blobs_url":"https://api.github.com/repos/hongweiwang/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongweiwang/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongweiwang/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongweiwang/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongweiwang/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/hongweiwang/grpc/languages","stargazers_url":"https://api.github.com/repos/hongweiwang/grpc/stargazers","contributors_url":"https://api.github.com/repos/hongweiwang/grpc/contributors","subscribers_url":"https://api.github.com/repos/hongweiwang/grpc/subscribers","subscription_url":"https://api.github.com/repos/hongweiwang/grpc/subscription","commits_url":"https://api.github.com/repos/hongweiwang/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongweiwang/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongweiwang/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongweiwang/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongweiwang/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/hongweiwang/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongweiwang/grpc/merges","archive_url":"https://api.github.com/repos/hongweiwang/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongweiwang/grpc/downloads","issues_url":"https://api.github.com/repos/hongweiwang/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/hongweiwang/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/hongweiwang/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/hongweiwang/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongweiwang/grpc/labels{/name}","releases_url":"https://api.github.com/repos/hongweiwang/grpc/releases{/id}","created_at":"2015-06-24T00:28:44Z","updated_at":"2015-06-24T00:28:48Z","pushed_at":"2015-07-22T22:09:13Z","git_url":"git://github.com/hongweiwang/grpc.git","ssh_url":"git@github.com:hongweiwang/grpc.git","clone_url":"https://github.com/hongweiwang/grpc.git","svn_url":"https://github.com/hongweiwang/grpc","homepage":"","size":37299,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"aabf72c21806d59efe8999268e1dc363ef845d85","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","created_at":"2014-12-08T18:58:53Z","updated_at":"2015-07-22T20:58:44Z","pushed_at":"2015-07-22T22:12:07Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":148926,"stargazers_count":2902,"watchers_count":2902,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":421,"mirror_url":null,"open_issues_count":419,"forks":421,"open_issues":419,"watchers":2902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2549"},"html":{"href":"https://github.com/grpc/grpc/pull/2549"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/2549"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/2549/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2549/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/2549/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/cd62075eb6e9c4aba6d9de9be9e2a9615844c3d3"}}}}