{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/41676530","id":41676530,"diff_hunk":"@@ -800,19 +803,22 @@ int Circle::intersection(Point* point, double angle, Point* points) {\n     else if (discr == 0) {\n       xcurr = x0;\n       ycurr = -b / (2*a);\n-      points[num].setCoords(xcurr, ycurr);\n+      zcurr = z0;\n+      points[num].setCoords(xcurr, ycurr, zcurr);\n+\n+      /* Check that point is in same direction as angle */\n       if (angle < M_PI && ycurr > y0)\n         num++;\n       else if (angle > M_PI && ycurr < y0)\n-        num++;\n-      return num;","path":"src/Surface.cpp","position":296,"original_position":296,"commit_id":"a5f0ec5eba662f9f69cd4ec7a1c5eea875efd8a2","original_commit_id":"a5f0ec5eba662f9f69cd4ec7a1c5eea875efd8a2","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"Good call, I think the return should still be there.","created_at":"2015-10-09T20:50:33Z","updated_at":"2015-10-09T20:50:33Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/188#discussion_r41676530","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/41676530"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/188#discussion_r41676530"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188","id":40867449,"html_url":"https://github.com/mit-crpg/OpenMOC/pull/188","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/188.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/188.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/188","number":188,"state":"open","locked":false,"title":"Modifications to support 3D geometry features","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"body":"This PR makes changes to many of the objects to support 3D geometry features. In particular, the z-component is added to points and lattices and the polar angle is introduced in functions to propagate the tracks forward in the z-direction. Surfaces and boundary conditions are added in the z-direction, but are required to be REFLECTIVE since they are not actually used in the Solver. The CMFD objects also is organized for a 3D mesh, but the z-direction is required to be of dimension 1 and have REFLECTIVE BCs. Many 3D features were intentionally left out of this PR such as reconfiguring the PolarQuad to support different polar angles/weights for each azimuthal angle.\r\n\r\nThis PR depends on PRs #182, #184, and #185 and will be updated as those are modified.","created_at":"2015-07-27T03:16:35Z","updated_at":"2015-10-09T20:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c778bfb9ed6afa5a516d310ac84914a952ffc3b","assignee":{"login":"geogunow","id":2420416,"avatar_url":"https://avatars.githubusercontent.com/u/2420416?v=3","gravatar_id":"","url":"https://api.github.com/users/geogunow","html_url":"https://github.com/geogunow","followers_url":"https://api.github.com/users/geogunow/followers","following_url":"https://api.github.com/users/geogunow/following{/other_user}","gists_url":"https://api.github.com/users/geogunow/gists{/gist_id}","starred_url":"https://api.github.com/users/geogunow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogunow/subscriptions","organizations_url":"https://api.github.com/users/geogunow/orgs","repos_url":"https://api.github.com/users/geogunow/repos","events_url":"https://api.github.com/users/geogunow/events{/privacy}","received_events_url":"https://api.github.com/users/geogunow/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/188/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/a5f0ec5eba662f9f69cd4ec7a1c5eea875efd8a2","head":{"label":"samuelshaner:3D-geometry","ref":"3D-geometry","sha":"a5f0ec5eba662f9f69cd4ec7a1c5eea875efd8a2","user":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"repo":{"id":17918430,"name":"OpenMOC","full_name":"samuelshaner/OpenMOC","owner":{"login":"samuelshaner","id":1244537,"avatar_url":"https://avatars.githubusercontent.com/u/1244537?v=3","gravatar_id":"","url":"https://api.github.com/users/samuelshaner","html_url":"https://github.com/samuelshaner","followers_url":"https://api.github.com/users/samuelshaner/followers","following_url":"https://api.github.com/users/samuelshaner/following{/other_user}","gists_url":"https://api.github.com/users/samuelshaner/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelshaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelshaner/subscriptions","organizations_url":"https://api.github.com/users/samuelshaner/orgs","repos_url":"https://api.github.com/users/samuelshaner/repos","events_url":"https://api.github.com/users/samuelshaner/events{/privacy}","received_events_url":"https://api.github.com/users/samuelshaner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samuelshaner/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/samuelshaner/OpenMOC","forks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/forks","keys_url":"https://api.github.com/repos/samuelshaner/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelshaner/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelshaner/OpenMOC/teams","hooks_url":"https://api.github.com/repos/samuelshaner/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/samuelshaner/OpenMOC/events","assignees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/samuelshaner/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/tags","blobs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelshaner/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelshaner/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/samuelshaner/OpenMOC/subscription","commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelshaner/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelshaner/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelshaner/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/samuelshaner/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelshaner/OpenMOC/merges","archive_url":"https://api.github.com/repos/samuelshaner/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelshaner/OpenMOC/downloads","issues_url":"https://api.github.com/repos/samuelshaner/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/samuelshaner/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelshaner/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelshaner/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelshaner/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/samuelshaner/OpenMOC/releases{/id}","created_at":"2014-03-19T20:03:02Z","updated_at":"2014-03-19T20:03:02Z","pushed_at":"2015-10-02T20:09:37Z","git_url":"git://github.com/samuelshaner/OpenMOC.git","ssh_url":"git@github.com:samuelshaner/OpenMOC.git","clone_url":"https://github.com/samuelshaner/OpenMOC.git","svn_url":"https://github.com/samuelshaner/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":93034,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mit-crpg:develop","ref":"develop","sha":"339de6163c7c1b0319bb87f498eba2c4a5b48ba6","user":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"name":"OpenMOC","full_name":"mit-crpg/OpenMOC","owner":{"login":"mit-crpg","id":1247634,"avatar_url":"https://avatars.githubusercontent.com/u/1247634?v=3","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","created_at":"2013-03-14T17:19:26Z","updated_at":"2015-10-08T06:36:45Z","pushed_at":"2015-10-03T18:52:41Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":116317,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":24,"forks":22,"open_issues":24,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/188"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/188"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/a5f0ec5eba662f9f69cd4ec7a1c5eea875efd8a2"}}}}