{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7","id":41990134,"html_url":"https://github.com/thefrontiergroup/fh-android-sdk/pull/7","diff_url":"https://github.com/thefrontiergroup/fh-android-sdk/pull/7.diff","patch_url":"https://github.com/thefrontiergroup/fh-android-sdk/pull/7.patch","issue_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/7","number":7,"state":"closed","locked":false,"title":"Update android async http","user":{"login":"psyren89","id":2491530,"avatar_url":"https://avatars.githubusercontent.com/u/2491530?v=3","gravatar_id":"","url":"https://api.github.com/users/psyren89","html_url":"https://github.com/psyren89","followers_url":"https://api.github.com/users/psyren89/followers","following_url":"https://api.github.com/users/psyren89/following{/other_user}","gists_url":"https://api.github.com/users/psyren89/gists{/gist_id}","starred_url":"https://api.github.com/users/psyren89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyren89/subscriptions","organizations_url":"https://api.github.com/users/psyren89/orgs","repos_url":"https://api.github.com/users/psyren89/repos","events_url":"https://api.github.com/users/psyren89/events{/privacy}","received_events_url":"https://api.github.com/users/psyren89/received_events","type":"User","site_admin":false},"body":"The old Android Async HTTP library was causing a major bug where params were not being sent with the correct content type, causing the backend to ignore them.\r\nBumping the version to the latest (1.4.6 -> 1.4.8) fixes this issue.\r\n\r\nThe offending line was [this](https://github.com/loopj/android-async-http/blob/57c66245728c648c8b9b8e5ee9d46c808502ce86/library/src/main/java/com/loopj/android/http/AsyncHttpClient.java#L1169):\r\n`if (uriRequest instanceof HttpEntityEnclosingRequestBase && ((HttpEntityEnclosingRequestBase) uriRequest).getEntity() != null) {`\r\nwhich has since been changed to [this](https://github.com/loopj/android-async-http/blob/cf70d2e43a46e8cfd0154ddef41b2526f3eadaaa/library/src/main/java/com/loopj/android/http/AsyncHttpClient.java#L1374):\r\n`if (uriRequest instanceof HttpEntityEnclosingRequestBase && ((HttpEntityEnclosingRequestBase) uriRequest).getEntity() != null && uriRequest.containsHeader(HEADER_CONTENT_TYPE)) {`\r\n\r\nWhile I was there, I also made a small optimisation to a List allocation.","created_at":"2015-08-10T06:15:46Z","updated_at":"2015-08-10T08:07:12Z","closed_at":"2015-08-10T08:07:12Z","merged_at":"2015-08-10T08:07:12Z","merge_commit_sha":"cb965618428440d0e3672317bf9ee1908e4f7c94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7/commits","review_comments_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7/comments","review_comment_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/7/comments","statuses_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/statuses/1cd790d79ca822bb9075055b667383d033863f26","head":{"label":"thefrontiergroup:update_android_async_http","ref":"update_android_async_http","sha":"1cd790d79ca822bb9075055b667383d033863f26","user":{"login":"thefrontiergroup","id":90945,"avatar_url":"https://avatars.githubusercontent.com/u/90945?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontiergroup","html_url":"https://github.com/thefrontiergroup","followers_url":"https://api.github.com/users/thefrontiergroup/followers","following_url":"https://api.github.com/users/thefrontiergroup/following{/other_user}","gists_url":"https://api.github.com/users/thefrontiergroup/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontiergroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontiergroup/subscriptions","organizations_url":"https://api.github.com/users/thefrontiergroup/orgs","repos_url":"https://api.github.com/users/thefrontiergroup/repos","events_url":"https://api.github.com/users/thefrontiergroup/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontiergroup/received_events","type":"Organization","site_admin":false},"repo":{"id":39047047,"name":"fh-android-sdk","full_name":"thefrontiergroup/fh-android-sdk","owner":{"login":"thefrontiergroup","id":90945,"avatar_url":"https://avatars.githubusercontent.com/u/90945?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontiergroup","html_url":"https://github.com/thefrontiergroup","followers_url":"https://api.github.com/users/thefrontiergroup/followers","following_url":"https://api.github.com/users/thefrontiergroup/following{/other_user}","gists_url":"https://api.github.com/users/thefrontiergroup/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontiergroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontiergroup/subscriptions","organizations_url":"https://api.github.com/users/thefrontiergroup/orgs","repos_url":"https://api.github.com/users/thefrontiergroup/repos","events_url":"https://api.github.com/users/thefrontiergroup/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontiergroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thefrontiergroup/fh-android-sdk","description":"FeedHenry Android Native SDK","fork":true,"url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk","forks_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/forks","keys_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/teams","hooks_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/events","assignees_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/tags","blobs_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/languages","stargazers_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/subscription","commits_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/merges","archive_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/downloads","issues_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/releases{/id}","created_at":"2015-07-14T01:41:16Z","updated_at":"2015-07-14T01:41:17Z","pushed_at":"2015-08-10T08:07:12Z","git_url":"git://github.com/thefrontiergroup/fh-android-sdk.git","ssh_url":"git@github.com:thefrontiergroup/fh-android-sdk.git","clone_url":"https://github.com/thefrontiergroup/fh-android-sdk.git","svn_url":"https://github.com/thefrontiergroup/fh-android-sdk","homepage":null,"size":6751,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"thefrontiergroup:master","ref":"master","sha":"e6fedc328cef0b35b7e095a948277dbbdcaedfde","user":{"login":"thefrontiergroup","id":90945,"avatar_url":"https://avatars.githubusercontent.com/u/90945?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontiergroup","html_url":"https://github.com/thefrontiergroup","followers_url":"https://api.github.com/users/thefrontiergroup/followers","following_url":"https://api.github.com/users/thefrontiergroup/following{/other_user}","gists_url":"https://api.github.com/users/thefrontiergroup/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontiergroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontiergroup/subscriptions","organizations_url":"https://api.github.com/users/thefrontiergroup/orgs","repos_url":"https://api.github.com/users/thefrontiergroup/repos","events_url":"https://api.github.com/users/thefrontiergroup/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontiergroup/received_events","type":"Organization","site_admin":false},"repo":{"id":39047047,"name":"fh-android-sdk","full_name":"thefrontiergroup/fh-android-sdk","owner":{"login":"thefrontiergroup","id":90945,"avatar_url":"https://avatars.githubusercontent.com/u/90945?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontiergroup","html_url":"https://github.com/thefrontiergroup","followers_url":"https://api.github.com/users/thefrontiergroup/followers","following_url":"https://api.github.com/users/thefrontiergroup/following{/other_user}","gists_url":"https://api.github.com/users/thefrontiergroup/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontiergroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontiergroup/subscriptions","organizations_url":"https://api.github.com/users/thefrontiergroup/orgs","repos_url":"https://api.github.com/users/thefrontiergroup/repos","events_url":"https://api.github.com/users/thefrontiergroup/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontiergroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thefrontiergroup/fh-android-sdk","description":"FeedHenry Android Native SDK","fork":true,"url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk","forks_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/forks","keys_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/teams","hooks_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/events","assignees_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/tags","blobs_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/languages","stargazers_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/subscription","commits_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/merges","archive_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/downloads","issues_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/releases{/id}","created_at":"2015-07-14T01:41:16Z","updated_at":"2015-07-14T01:41:17Z","pushed_at":"2015-08-10T08:07:12Z","git_url":"git://github.com/thefrontiergroup/fh-android-sdk.git","ssh_url":"git@github.com:thefrontiergroup/fh-android-sdk.git","clone_url":"https://github.com/thefrontiergroup/fh-android-sdk.git","svn_url":"https://github.com/thefrontiergroup/fh-android-sdk","homepage":null,"size":6751,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7"},"html":{"href":"https://github.com/thefrontiergroup/fh-android-sdk/pull/7"},"issue":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/7"},"comments":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/thefrontiergroup/fh-android-sdk/statuses/1cd790d79ca822bb9075055b667383d033863f26"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"psyren89","id":2491530,"avatar_url":"https://avatars.githubusercontent.com/u/2491530?v=3","gravatar_id":"","url":"https://api.github.com/users/psyren89","html_url":"https://github.com/psyren89","followers_url":"https://api.github.com/users/psyren89/followers","following_url":"https://api.github.com/users/psyren89/following{/other_user}","gists_url":"https://api.github.com/users/psyren89/gists{/gist_id}","starred_url":"https://api.github.com/users/psyren89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psyren89/subscriptions","organizations_url":"https://api.github.com/users/psyren89/orgs","repos_url":"https://api.github.com/users/psyren89/repos","events_url":"https://api.github.com/users/psyren89/events{/privacy}","received_events_url":"https://api.github.com/users/psyren89/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":2}}