{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/luigi/issues/1309","labels_url":"https://api.github.com/repos/spotify/luigi/issues/1309/labels{/name}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/1309/comments","events_url":"https://api.github.com/repos/spotify/luigi/issues/1309/events","html_url":"https://github.com/spotify/luigi/pull/1309","id":111215827,"number":1309,"title":"Remove id to name and params","user":{"login":"stephenpascoe","id":677427,"avatar_url":"https://avatars.githubusercontent.com/u/677427?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenpascoe","html_url":"https://github.com/stephenpascoe","followers_url":"https://api.github.com/users/stephenpascoe/followers","following_url":"https://api.github.com/users/stephenpascoe/following{/other_user}","gists_url":"https://api.github.com/users/stephenpascoe/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenpascoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenpascoe/subscriptions","organizations_url":"https://api.github.com/users/stephenpascoe/orgs","repos_url":"https://api.github.com/users/stephenpascoe/repos","events_url":"https://api.github.com/users/stephenpascoe/events{/privacy}","received_events_url":"https://api.github.com/users/stephenpascoe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-13T16:16:18Z","updated_at":"2015-10-13T20:57:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/1309","html_url":"https://github.com/spotify/luigi/pull/1309","diff_url":"https://github.com/spotify/luigi/pull/1309.diff","patch_url":"https://github.com/spotify/luigi/pull/1309.patch"},"body":"This PR removes the problematic function luigi.task.id_to_name_and_params().  It was being used extensively when the scheduler called TaskHistory methods.  Now these methods take a luigi.scheduler.Task() instance instead so that deserialisation of task_id is unnecessary.\r\n\r\nI have added a test which would catch #1270, #1171 and #1132.\r\n\r\nI have also optimised an SqlAlchemy query in DbTaskHistory()."},"comment":{"url":"https://api.github.com/repos/spotify/luigi/issues/comments/147851629","html_url":"https://github.com/spotify/luigi/pull/1309#issuecomment-147851629","issue_url":"https://api.github.com/repos/spotify/luigi/issues/1309","id":147851629,"user":{"login":"Tarrasch","id":294349,"avatar_url":"https://avatars.githubusercontent.com/u/294349?v=3","gravatar_id":"","url":"https://api.github.com/users/Tarrasch","html_url":"https://github.com/Tarrasch","followers_url":"https://api.github.com/users/Tarrasch/followers","following_url":"https://api.github.com/users/Tarrasch/following{/other_user}","gists_url":"https://api.github.com/users/Tarrasch/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarrasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarrasch/subscriptions","organizations_url":"https://api.github.com/users/Tarrasch/orgs","repos_url":"https://api.github.com/users/Tarrasch/repos","events_url":"https://api.github.com/users/Tarrasch/events{/privacy}","received_events_url":"https://api.github.com/users/Tarrasch/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T20:57:55Z","updated_at":"2015-10-13T20:57:55Z","body":"LGTM. But it seems like the first 3 commits could be squashed to keep history to only logical changes."}}