{"action":"created","issue":{"url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/64","labels_url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/64/comments","events_url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/64/events","html_url":"https://github.com/NSS-Cohort-9/atmebro/pull/64","id":103071285,"number":64,"title":"Eslint rules","user":{"login":"calebgregory","id":10540157,"avatar_url":"https://avatars.githubusercontent.com/u/10540157?v=3","gravatar_id":"","url":"https://api.github.com/users/calebgregory","html_url":"https://github.com/calebgregory","followers_url":"https://api.github.com/users/calebgregory/followers","following_url":"https://api.github.com/users/calebgregory/following{/other_user}","gists_url":"https://api.github.com/users/calebgregory/gists{/gist_id}","starred_url":"https://api.github.com/users/calebgregory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebgregory/subscriptions","organizations_url":"https://api.github.com/users/calebgregory/orgs","repos_url":"https://api.github.com/users/calebgregory/repos","events_url":"https://api.github.com/users/calebgregory/events{/privacy}","received_events_url":"https://api.github.com/users/calebgregory/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-25T16:56:17Z","updated_at":"2015-08-25T18:09:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/pulls/64","html_url":"https://github.com/NSS-Cohort-9/atmebro/pull/64","diff_url":"https://github.com/NSS-Cohort-9/atmebro/pull/64.diff","patch_url":"https://github.com/NSS-Cohort-9/atmebro/pull/64.patch"},"body":"### brace-style: [2, 1tbs, {\"allowSingleLine\": false}]\r\nThe following are considered warnings:\r\n```\r\nfunction foo()\r\n{\r\n  return true;\r\n}\r\n\r\nif (foo)\r\n{\r\n  bar();\r\n}\r\n\r\ntry\r\n{\r\n  somethingRisky();\r\n} catch(e)\r\n{\r\n  handleError();\r\n}\r\n\r\nif (foo) {\r\n  bar();\r\n}\r\nelse {\r\n  baz();\r\n}\r\n```\r\nwhile the following patterns are not warnings:\r\n```\r\nfunction foo() {\r\n  return true;\r\n}\r\n\r\nif (foo) {\r\n  bar();\r\n}\r\n\r\nif (foo) {\r\n  bar();\r\n} else {\r\n  baz();\r\n}\r\n\r\ntry {\r\n  somethingRisky();\r\n} catch(e) {\r\n  handleError();\r\n}\r\n\r\n// when there are no braces, there are no warnings\r\nif (foo) bar();\r\nelse if (baz) boom();\r\n```\r\n\r\n### comma-spacing: [2, {\"before\": false, \"after\": true}]\r\nThe following are considered warnings:\r\n```\r\n    var foo = 1 ,bar = 2;\r\n    var arr = [1 , 2];\r\n    var obj = {\"foo\": \"bar\" ,\"baz\": \"qur\"};\r\n    foo(a ,b);\r\n    new Foo(a ,b);\r\n    function foo(a ,b){}\r\n    a ,b\r\n```\r\nwhile the following patterns are not warnings:\r\n```\r\n    var foo = 1, bar = 2\r\n        , baz = 3;\r\n    var arr = [1, 2];\r\n    var obj = {\"foo\": \"bar\", \"baz\": \"qur\"};\r\n    foo(a, b);\r\n    new Foo(a, b);\r\n    function foo(a, b){}\r\n    a, b\r\n```\r\n\r\n### handle-callback-err: [2, \"^(err|error)$\"]\r\nThe following are considered warnings:\r\n```\r\nfunction loadData (err, data) {\r\n    doSomething(); // forgot to handle error\r\n}\r\n```\r\nwhile the following patterns are not warnings:\r\n```\r\nfunction loadData (err, data) {\r\n    if (err) {\r\n        console.log(err.stack);\r\n    }\r\n    doSomething();\r\n}\r\n\r\nfunction generateError (err) {\r\n    if (err) {}\r\n}\r\n```\r\nSpecifically, the linter is looking for an Error object named `err` or `error`.\r\n\r\n### space-in-parens: [2, never]\r\nThe following are considered warnings:\r\n```\r\nfoo( 'bar');\r\nfoo('bar' );\r\nfoo( 'bar' );\r\n\r\nvar foo = ( 1 + 2 ) * 3;\r\n( function () { return 'bar'; }() );\r\n```\r\nwhile the following patterns are not warnings:\r\n```\r\nfoo();\r\n\r\nfoo('bar');\r\n\r\nvar foo = (1 + 2) * 3;\r\n(function () { return 'bar'; }());\r\n```"},"comment":{"url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/comments/134689232","html_url":"https://github.com/NSS-Cohort-9/atmebro/pull/64#issuecomment-134689232","issue_url":"https://api.github.com/repos/NSS-Cohort-9/atmebro/issues/64","id":134689232,"user":{"login":"sscotth","id":1010488,"avatar_url":"https://avatars.githubusercontent.com/u/1010488?v=3","gravatar_id":"","url":"https://api.github.com/users/sscotth","html_url":"https://github.com/sscotth","followers_url":"https://api.github.com/users/sscotth/followers","following_url":"https://api.github.com/users/sscotth/following{/other_user}","gists_url":"https://api.github.com/users/sscotth/gists{/gist_id}","starred_url":"https://api.github.com/users/sscotth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sscotth/subscriptions","organizations_url":"https://api.github.com/users/sscotth/orgs","repos_url":"https://api.github.com/users/sscotth/repos","events_url":"https://api.github.com/users/sscotth/events{/privacy}","received_events_url":"https://api.github.com/users/sscotth/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T18:09:15Z","updated_at":"2015-08-25T18:09:15Z","body":"Approve so far. Finished?"}}