{"action":"created","issue":{"url":"https://api.github.com/repos/achingbrain/output-buffer/issues/1","labels_url":"https://api.github.com/repos/achingbrain/output-buffer/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/achingbrain/output-buffer/issues/1/comments","events_url":"https://api.github.com/repos/achingbrain/output-buffer/issues/1/events","html_url":"https://github.com/achingbrain/output-buffer/pull/1","id":56918247,"number":1,"title":"Separator improvements","user":{"login":"chocolateboy","id":31533,"avatar_url":"https://avatars.githubusercontent.com/u/31533?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolateboy","html_url":"https://github.com/chocolateboy","followers_url":"https://api.github.com/users/chocolateboy/followers","following_url":"https://api.github.com/users/chocolateboy/following{/other_user}","gists_url":"https://api.github.com/users/chocolateboy/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolateboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolateboy/subscriptions","organizations_url":"https://api.github.com/users/chocolateboy/orgs","repos_url":"https://api.github.com/users/chocolateboy/repos","events_url":"https://api.github.com/users/chocolateboy/events{/privacy}","received_events_url":"https://api.github.com/users/chocolateboy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-02-07T17:19:30Z","updated_at":"2015-02-09T17:34:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/achingbrain/output-buffer/pulls/1","html_url":"https://github.com/achingbrain/output-buffer/pull/1","diff_url":"https://github.com/achingbrain/output-buffer/pull/1.diff","patch_url":"https://github.com/achingbrain/output-buffer/pull/1.patch"},"body":"* separator improvements\r\n    * add support for [Windows/Mac OS 9 &c. line endings](https://en.wikipedia.org/wiki/Newline#Representations)\r\n    * allow the line separator to be specified\r\n    * use the (slightly faster) old append method if the line separator is a string\r\n* ignore null/undefined\r\n* comprehensive tests\r\n* add benchmark\r\n* README.md: update package name: `outputbuffer` -> `output-buffer`"},"comment":{"url":"https://api.github.com/repos/achingbrain/output-buffer/issues/comments/73552068","html_url":"https://github.com/achingbrain/output-buffer/pull/1#issuecomment-73552068","issue_url":"https://api.github.com/repos/achingbrain/output-buffer/issues/1","id":73552068,"user":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"created_at":"2015-02-09T17:34:02Z","updated_at":"2015-02-09T17:34:02Z","body":"Thinking about it, it might be better to just pass `this._sep` to [String.split](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split) and have done with it since it takes a String or a RegExp.\r\n\r\n```javascript\r\n'foo\\nbar\\nbaz'.split('\\n')\r\n> [\"foo\", \"bar\", \"baz\"]\r\n```\r\n\r\n```javascript\r\n'foo\\nbar\\nbaz'.split(/\\n/)\r\n> [\"foo\", \"bar\", \"baz\"]\r\n```\r\n\r\n```javascript\r\n'foo\\nbar\\nbaz'.split('/\\n/')\r\n> [\"foo\", \"bar\", \"baz\"]\r\n```"}}