{"action":"created","comment":{"url":"https://api.github.com/repos/leapmotion/autowiring/pulls/comments/42430573","id":42430573,"diff_hunk":"@@ -112,13 +110,10 @@ class Autowired:\n   }\n \n private:\n-  // The first deferred child known to need registration.  This is distinct from the m_pFlink entry in\n-  // the base class, which refers to the _next sibling_; by contrast, this type refers to the _first child_\n-  // which will be the first member registered via NotifyWhenAutowired.\n-  std::atomic<AutowirableSlot<T>*> m_pFirstChild{nullptr};\n-\n   std::vector<autowiring::registration_t> m_events;\n \n+  std::vector<autowiring::registration_t> m_autowired_notifications;","path":"autowiring/Autowired.h","position":26,"original_position":26,"commit_id":"5d0c20db0ceb963bf15e06def033a2d2885e7634","original_commit_id":"5d0c20db0ceb963bf15e06def033a2d2885e7634","user":{"login":"codemercenary","id":2961036,"avatar_url":"https://avatars.githubusercontent.com/u/2961036?v=3","gravatar_id":"","url":"https://api.github.com/users/codemercenary","html_url":"https://github.com/codemercenary","followers_url":"https://api.github.com/users/codemercenary/followers","following_url":"https://api.github.com/users/codemercenary/following{/other_user}","gists_url":"https://api.github.com/users/codemercenary/gists{/gist_id}","starred_url":"https://api.github.com/users/codemercenary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemercenary/subscriptions","organizations_url":"https://api.github.com/users/codemercenary/orgs","repos_url":"https://api.github.com/users/codemercenary/repos","events_url":"https://api.github.com/users/codemercenary/events{/privacy}","received_events_url":"https://api.github.com/users/codemercenary/received_events","type":"User","site_admin":false},"body":"I don't like this `std::vector` instance, though, and would normally try to find a way to remove it.  On the other hand, there is another identical vector right above it, so this is probably not too bad.","created_at":"2015-10-19T21:49:28Z","updated_at":"2015-10-19T21:49:28Z","html_url":"https://github.com/leapmotion/autowiring/pull/780#discussion_r42430573","pull_request_url":"https://api.github.com/repos/leapmotion/autowiring/pulls/780","_links":{"self":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/comments/42430573"},"html":{"href":"https://github.com/leapmotion/autowiring/pull/780#discussion_r42430573"},"pull_request":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/leapmotion/autowiring/pulls/780","id":47805510,"html_url":"https://github.com/leapmotion/autowiring/pull/780","diff_url":"https://github.com/leapmotion/autowiring/pull/780.diff","patch_url":"https://github.com/leapmotion/autowiring/pull/780.patch","issue_url":"https://api.github.com/repos/leapmotion/autowiring/issues/780","number":780,"state":"open","locked":false,"title":"Fix and test NotifyWhenAutowired call order","user":{"login":"codemercenary","id":2961036,"avatar_url":"https://avatars.githubusercontent.com/u/2961036?v=3","gravatar_id":"","url":"https://api.github.com/users/codemercenary","html_url":"https://github.com/codemercenary","followers_url":"https://api.github.com/users/codemercenary/followers","following_url":"https://api.github.com/users/codemercenary/following{/other_user}","gists_url":"https://api.github.com/users/codemercenary/gists{/gist_id}","starred_url":"https://api.github.com/users/codemercenary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemercenary/subscriptions","organizations_url":"https://api.github.com/users/codemercenary/orgs","repos_url":"https://api.github.com/users/codemercenary/repos","events_url":"https://api.github.com/users/codemercenary/events{/privacy}","received_events_url":"https://api.github.com/users/codemercenary/received_events","type":"User","site_admin":false},"body":"`NotifyWhenAutowired` is meant to carry an outer total order guarantee which states that notifications pertaining to the injection of a particular type into a context must be processed strictly in the order they are received.\r\n\r\n- [ ] Fixes #738","created_at":"2015-10-15T15:53:13Z","updated_at":"2015-10-19T21:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dcc1b2a91c095b3c095aba617e8dfedd5f0c1e5","assignee":{"login":"codemercenary","id":2961036,"avatar_url":"https://avatars.githubusercontent.com/u/2961036?v=3","gravatar_id":"","url":"https://api.github.com/users/codemercenary","html_url":"https://github.com/codemercenary","followers_url":"https://api.github.com/users/codemercenary/followers","following_url":"https://api.github.com/users/codemercenary/following{/other_user}","gists_url":"https://api.github.com/users/codemercenary/gists{/gist_id}","starred_url":"https://api.github.com/users/codemercenary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemercenary/subscriptions","organizations_url":"https://api.github.com/users/codemercenary/orgs","repos_url":"https://api.github.com/users/codemercenary/repos","events_url":"https://api.github.com/users/codemercenary/events{/privacy}","received_events_url":"https://api.github.com/users/codemercenary/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/leapmotion/autowiring/milestones/4","html_url":"https://github.com/leapmotion/autowiring/milestones/v0.7.6","labels_url":"https://api.github.com/repos/leapmotion/autowiring/milestones/4/labels","id":1357675,"number":4,"title":"v0.7.6","description":"We've got fixes in here now that need to be released downstream, time to set a date.","creator":{"login":"codemercenary","id":2961036,"avatar_url":"https://avatars.githubusercontent.com/u/2961036?v=3","gravatar_id":"","url":"https://api.github.com/users/codemercenary","html_url":"https://github.com/codemercenary","followers_url":"https://api.github.com/users/codemercenary/followers","following_url":"https://api.github.com/users/codemercenary/following{/other_user}","gists_url":"https://api.github.com/users/codemercenary/gists{/gist_id}","starred_url":"https://api.github.com/users/codemercenary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemercenary/subscriptions","organizations_url":"https://api.github.com/users/codemercenary/orgs","repos_url":"https://api.github.com/users/codemercenary/repos","events_url":"https://api.github.com/users/codemercenary/events{/privacy}","received_events_url":"https://api.github.com/users/codemercenary/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2015-10-15T16:44:33Z","updated_at":"2015-10-19T19:09:48Z","due_on":"2015-10-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/leapmotion/autowiring/pulls/780/commits","review_comments_url":"https://api.github.com/repos/leapmotion/autowiring/pulls/780/comments","review_comment_url":"https://api.github.com/repos/leapmotion/autowiring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leapmotion/autowiring/issues/780/comments","statuses_url":"https://api.github.com/repos/leapmotion/autowiring/statuses/5d0c20db0ceb963bf15e06def033a2d2885e7634","head":{"label":"leapmotion:fix-nwaw","ref":"fix-nwaw","sha":"5d0c20db0ceb963bf15e06def033a2d2885e7634","user":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars.githubusercontent.com/u/2242710?v=3","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"repo":{"id":22234733,"name":"autowiring","full_name":"leapmotion/autowiring","owner":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars.githubusercontent.com/u/2242710?v=3","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapmotion/autowiring","description":"A C++ Inversion of Control Framework","fork":false,"url":"https://api.github.com/repos/leapmotion/autowiring","forks_url":"https://api.github.com/repos/leapmotion/autowiring/forks","keys_url":"https://api.github.com/repos/leapmotion/autowiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapmotion/autowiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapmotion/autowiring/teams","hooks_url":"https://api.github.com/repos/leapmotion/autowiring/hooks","issue_events_url":"https://api.github.com/repos/leapmotion/autowiring/issues/events{/number}","events_url":"https://api.github.com/repos/leapmotion/autowiring/events","assignees_url":"https://api.github.com/repos/leapmotion/autowiring/assignees{/user}","branches_url":"https://api.github.com/repos/leapmotion/autowiring/branches{/branch}","tags_url":"https://api.github.com/repos/leapmotion/autowiring/tags","blobs_url":"https://api.github.com/repos/leapmotion/autowiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapmotion/autowiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapmotion/autowiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapmotion/autowiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapmotion/autowiring/statuses/{sha}","languages_url":"https://api.github.com/repos/leapmotion/autowiring/languages","stargazers_url":"https://api.github.com/repos/leapmotion/autowiring/stargazers","contributors_url":"https://api.github.com/repos/leapmotion/autowiring/contributors","subscribers_url":"https://api.github.com/repos/leapmotion/autowiring/subscribers","subscription_url":"https://api.github.com/repos/leapmotion/autowiring/subscription","commits_url":"https://api.github.com/repos/leapmotion/autowiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapmotion/autowiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapmotion/autowiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapmotion/autowiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapmotion/autowiring/contents/{+path}","compare_url":"https://api.github.com/repos/leapmotion/autowiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapmotion/autowiring/merges","archive_url":"https://api.github.com/repos/leapmotion/autowiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapmotion/autowiring/downloads","issues_url":"https://api.github.com/repos/leapmotion/autowiring/issues{/number}","pulls_url":"https://api.github.com/repos/leapmotion/autowiring/pulls{/number}","milestones_url":"https://api.github.com/repos/leapmotion/autowiring/milestones{/number}","notifications_url":"https://api.github.com/repos/leapmotion/autowiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapmotion/autowiring/labels{/name}","releases_url":"https://api.github.com/repos/leapmotion/autowiring/releases{/id}","created_at":"2014-07-24T22:39:49Z","updated_at":"2015-10-15T00:30:39Z","pushed_at":"2015-10-19T21:31:56Z","git_url":"git://github.com/leapmotion/autowiring.git","ssh_url":"git@github.com:leapmotion/autowiring.git","clone_url":"https://github.com/leapmotion/autowiring.git","svn_url":"https://github.com/leapmotion/autowiring","homepage":"http://autowiring.io/","size":42232,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":88,"default_branch":"develop"}},"base":{"label":"leapmotion:develop","ref":"develop","sha":"55f75152a7a452ee8c227412e10f1be1ffa91c17","user":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars.githubusercontent.com/u/2242710?v=3","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"repo":{"id":22234733,"name":"autowiring","full_name":"leapmotion/autowiring","owner":{"login":"leapmotion","id":2242710,"avatar_url":"https://avatars.githubusercontent.com/u/2242710?v=3","gravatar_id":"","url":"https://api.github.com/users/leapmotion","html_url":"https://github.com/leapmotion","followers_url":"https://api.github.com/users/leapmotion/followers","following_url":"https://api.github.com/users/leapmotion/following{/other_user}","gists_url":"https://api.github.com/users/leapmotion/gists{/gist_id}","starred_url":"https://api.github.com/users/leapmotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leapmotion/subscriptions","organizations_url":"https://api.github.com/users/leapmotion/orgs","repos_url":"https://api.github.com/users/leapmotion/repos","events_url":"https://api.github.com/users/leapmotion/events{/privacy}","received_events_url":"https://api.github.com/users/leapmotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leapmotion/autowiring","description":"A C++ Inversion of Control Framework","fork":false,"url":"https://api.github.com/repos/leapmotion/autowiring","forks_url":"https://api.github.com/repos/leapmotion/autowiring/forks","keys_url":"https://api.github.com/repos/leapmotion/autowiring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leapmotion/autowiring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leapmotion/autowiring/teams","hooks_url":"https://api.github.com/repos/leapmotion/autowiring/hooks","issue_events_url":"https://api.github.com/repos/leapmotion/autowiring/issues/events{/number}","events_url":"https://api.github.com/repos/leapmotion/autowiring/events","assignees_url":"https://api.github.com/repos/leapmotion/autowiring/assignees{/user}","branches_url":"https://api.github.com/repos/leapmotion/autowiring/branches{/branch}","tags_url":"https://api.github.com/repos/leapmotion/autowiring/tags","blobs_url":"https://api.github.com/repos/leapmotion/autowiring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leapmotion/autowiring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leapmotion/autowiring/git/refs{/sha}","trees_url":"https://api.github.com/repos/leapmotion/autowiring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leapmotion/autowiring/statuses/{sha}","languages_url":"https://api.github.com/repos/leapmotion/autowiring/languages","stargazers_url":"https://api.github.com/repos/leapmotion/autowiring/stargazers","contributors_url":"https://api.github.com/repos/leapmotion/autowiring/contributors","subscribers_url":"https://api.github.com/repos/leapmotion/autowiring/subscribers","subscription_url":"https://api.github.com/repos/leapmotion/autowiring/subscription","commits_url":"https://api.github.com/repos/leapmotion/autowiring/commits{/sha}","git_commits_url":"https://api.github.com/repos/leapmotion/autowiring/git/commits{/sha}","comments_url":"https://api.github.com/repos/leapmotion/autowiring/comments{/number}","issue_comment_url":"https://api.github.com/repos/leapmotion/autowiring/issues/comments{/number}","contents_url":"https://api.github.com/repos/leapmotion/autowiring/contents/{+path}","compare_url":"https://api.github.com/repos/leapmotion/autowiring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leapmotion/autowiring/merges","archive_url":"https://api.github.com/repos/leapmotion/autowiring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leapmotion/autowiring/downloads","issues_url":"https://api.github.com/repos/leapmotion/autowiring/issues{/number}","pulls_url":"https://api.github.com/repos/leapmotion/autowiring/pulls{/number}","milestones_url":"https://api.github.com/repos/leapmotion/autowiring/milestones{/number}","notifications_url":"https://api.github.com/repos/leapmotion/autowiring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leapmotion/autowiring/labels{/name}","releases_url":"https://api.github.com/repos/leapmotion/autowiring/releases{/id}","created_at":"2014-07-24T22:39:49Z","updated_at":"2015-10-15T00:30:39Z","pushed_at":"2015-10-19T21:31:56Z","git_url":"git://github.com/leapmotion/autowiring.git","ssh_url":"git@github.com:leapmotion/autowiring.git","clone_url":"https://github.com/leapmotion/autowiring.git","svn_url":"https://github.com/leapmotion/autowiring","homepage":"http://autowiring.io/","size":42232,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":88,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/780"},"html":{"href":"https://github.com/leapmotion/autowiring/pull/780"},"issue":{"href":"https://api.github.com/repos/leapmotion/autowiring/issues/780"},"comments":{"href":"https://api.github.com/repos/leapmotion/autowiring/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leapmotion/autowiring/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/leapmotion/autowiring/statuses/5d0c20db0ceb963bf15e06def033a2d2885e7634"}}}}