{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6625","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6625/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6625/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6625/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6625","id":104591643,"number":6625,"title":"BLOCKING: Consensus: Move blocksize and related parameters to consensusparams ...without removing consensus/consensus.h [#6526 alternative]","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-09-02T23:26:24Z","updated_at":"2015-12-03T11:57:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6625","html_url":"https://github.com/bitcoin/bitcoin/pull/6625","diff_url":"https://github.com/bitcoin/bitcoin/pull/6625.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6625.patch"},"body":"This is a replacement for #6526 with my nits integrated in the commits where they were more relevant.\r\nIt has a smaller diff (138 additions and 65 deletions VS +116 −95) is more amenable to any block size change proposal (many of them will need a function), to #6382 (adding new test chains for block size tests) and to libconsenusus-related #6591 (which is also part of the process of making chainparams less global #5970).\r\nI will rebase #6382, #6591 and #5970 on top of this. Please, @theuni close #6526 in favor of this if it passes your review.\r\n\r\nBlocking:\r\n\r\n- Consensus: Adapt declarations of most obviously consensus functions #6591 [jtimon/consensus-params-0.12.99]\r\n- Chainparams cleanup #5970 [chainparams_cleanup] (depends on #6163)\r\n- Chainparams: Introduce std::numeric_limits<uint64_t>::max() new testnet chains to test different block sizes #6382 [chainparams-sizetest-0.11.99]"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/161610648","html_url":"https://github.com/bitcoin/bitcoin/pull/6625#issuecomment-161610648","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6625","id":161610648,"user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T11:57:57Z","updated_at":"2015-12-03T11:57:57Z","body":"Rebased(7)\r\nLike I said the only disruptive commit is the last one and is the one that is requiring rebase all the time. Prediction: Next time this PR requires rebase, it will probably be due to the last commit and https://github.com/bitcoin/bitcoin/compare/master...jtimon:incomplete-consensus-blocksize-0.12.99 will remain without conflicts. The third commit is somewhat disruptive too, so I may be wrong, but if I am right, I will just drop the last commit, sorry @theuni "}}