{"action":"created","comment":{"url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/comments/31290268","id":31290268,"diff_hunk":"@@ -80,7 +80,7 @@\n     private final HtmlElement bodyTag = htmlElement(byInner(By.htmlTag(\"tbody\")));\n     private final HtmlElement headerTag = htmlElement(byInner(By.htmlTag(\"thead\")));\n \n-    public HtmlTable(Locator parent) { super(parent); }\n+    public HtmlTable(Locator parent) { super(HtmlElement.class, parent); }\n     public HtmlTable(Element parent) { super(parent); }","path":"src/main/java/com/redhat/darcy/web/HtmlTable.java","position":6,"original_position":6,"commit_id":"e37bc03253ad073be83f6545087999587c719aec","original_commit_id":"e37bc03253ad073be83f6545087999587c719aec","user":{"login":"alechenninger","id":3496559,"avatar_url":"https://avatars.githubusercontent.com/u/3496559?v=3","gravatar_id":"","url":"https://api.github.com/users/alechenninger","html_url":"https://github.com/alechenninger","followers_url":"https://api.github.com/users/alechenninger/followers","following_url":"https://api.github.com/users/alechenninger/following{/other_user}","gists_url":"https://api.github.com/users/alechenninger/gists{/gist_id}","starred_url":"https://api.github.com/users/alechenninger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alechenninger/subscriptions","organizations_url":"https://api.github.com/users/alechenninger/orgs","repos_url":"https://api.github.com/users/alechenninger/repos","events_url":"https://api.github.com/users/alechenninger/events{/privacy}","received_events_url":"https://api.github.com/users/alechenninger/received_events","type":"User","site_admin":false},"body":"Few issues:\r\n\r\n- class should extend `AbstractViewElement<HtmlElement>`\r\n- you don't need to cast to `HtmlElement` below if you do this\r\n- should accept `HtmlElement` not `Element` in constructor 2 since we're saying the parent is an `HtmlElement`...","created_at":"2015-05-29T00:17:19Z","updated_at":"2015-05-29T00:17:19Z","html_url":"https://github.com/darcy-framework/darcy-web/pull/38#discussion_r31290268","pull_request_url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/comments/31290268"},"html":{"href":"https://github.com/darcy-framework/darcy-web/pull/38#discussion_r31290268"},"pull_request":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38","id":36041217,"html_url":"https://github.com/darcy-framework/darcy-web/pull/38","diff_url":"https://github.com/darcy-framework/darcy-web/pull/38.diff","patch_url":"https://github.com/darcy-framework/darcy-web/pull/38.patch","issue_url":"https://api.github.com/repos/darcy-framework/darcy-web/issues/38","number":38,"state":"open","locked":false,"title":"Update HtmlTable/JQueryDataTable to play nice with AbstractViewElement","user":{"login":"dmcneil","id":1447896,"avatar_url":"https://avatars.githubusercontent.com/u/1447896?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcneil","html_url":"https://github.com/dmcneil","followers_url":"https://api.github.com/users/dmcneil/followers","following_url":"https://api.github.com/users/dmcneil/following{/other_user}","gists_url":"https://api.github.com/users/dmcneil/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcneil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcneil/subscriptions","organizations_url":"https://api.github.com/users/dmcneil/orgs","repos_url":"https://api.github.com/users/dmcneil/repos","events_url":"https://api.github.com/users/dmcneil/events{/privacy}","received_events_url":"https://api.github.com/users/dmcneil/received_events","type":"User","site_admin":false},"body":"I expect this to come back but with these changes I got tests I was working on working with your AbstractViewElement fix that you emailed about last night.","created_at":"2015-05-22T15:21:51Z","updated_at":"2015-05-29T00:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e748edf55307c964b12151df7120f242412f24d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38/commits","review_comments_url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38/comments","review_comment_url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darcy-framework/darcy-web/issues/38/comments","statuses_url":"https://api.github.com/repos/darcy-framework/darcy-web/statuses/e37bc03253ad073be83f6545087999587c719aec","head":{"label":"dmcneil:ui-fix","ref":"ui-fix","sha":"e37bc03253ad073be83f6545087999587c719aec","user":{"login":"dmcneil","id":1447896,"avatar_url":"https://avatars.githubusercontent.com/u/1447896?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcneil","html_url":"https://github.com/dmcneil","followers_url":"https://api.github.com/users/dmcneil/followers","following_url":"https://api.github.com/users/dmcneil/following{/other_user}","gists_url":"https://api.github.com/users/dmcneil/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcneil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcneil/subscriptions","organizations_url":"https://api.github.com/users/dmcneil/orgs","repos_url":"https://api.github.com/users/dmcneil/repos","events_url":"https://api.github.com/users/dmcneil/events{/privacy}","received_events_url":"https://api.github.com/users/dmcneil/received_events","type":"User","site_admin":false},"repo":{"id":23391808,"name":"darcy-web","full_name":"dmcneil/darcy-web","owner":{"login":"dmcneil","id":1447896,"avatar_url":"https://avatars.githubusercontent.com/u/1447896?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcneil","html_url":"https://github.com/dmcneil","followers_url":"https://api.github.com/users/dmcneil/followers","following_url":"https://api.github.com/users/dmcneil/following{/other_user}","gists_url":"https://api.github.com/users/dmcneil/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcneil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcneil/subscriptions","organizations_url":"https://api.github.com/users/dmcneil/orgs","repos_url":"https://api.github.com/users/dmcneil/repos","events_url":"https://api.github.com/users/dmcneil/events{/privacy}","received_events_url":"https://api.github.com/users/dmcneil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmcneil/darcy-web","description":"Extension to darcy-ui that expands the DSL to support interaction with browsers and web applications.","fork":true,"url":"https://api.github.com/repos/dmcneil/darcy-web","forks_url":"https://api.github.com/repos/dmcneil/darcy-web/forks","keys_url":"https://api.github.com/repos/dmcneil/darcy-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmcneil/darcy-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmcneil/darcy-web/teams","hooks_url":"https://api.github.com/repos/dmcneil/darcy-web/hooks","issue_events_url":"https://api.github.com/repos/dmcneil/darcy-web/issues/events{/number}","events_url":"https://api.github.com/repos/dmcneil/darcy-web/events","assignees_url":"https://api.github.com/repos/dmcneil/darcy-web/assignees{/user}","branches_url":"https://api.github.com/repos/dmcneil/darcy-web/branches{/branch}","tags_url":"https://api.github.com/repos/dmcneil/darcy-web/tags","blobs_url":"https://api.github.com/repos/dmcneil/darcy-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmcneil/darcy-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmcneil/darcy-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmcneil/darcy-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmcneil/darcy-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dmcneil/darcy-web/languages","stargazers_url":"https://api.github.com/repos/dmcneil/darcy-web/stargazers","contributors_url":"https://api.github.com/repos/dmcneil/darcy-web/contributors","subscribers_url":"https://api.github.com/repos/dmcneil/darcy-web/subscribers","subscription_url":"https://api.github.com/repos/dmcneil/darcy-web/subscription","commits_url":"https://api.github.com/repos/dmcneil/darcy-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmcneil/darcy-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmcneil/darcy-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmcneil/darcy-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmcneil/darcy-web/contents/{+path}","compare_url":"https://api.github.com/repos/dmcneil/darcy-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmcneil/darcy-web/merges","archive_url":"https://api.github.com/repos/dmcneil/darcy-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmcneil/darcy-web/downloads","issues_url":"https://api.github.com/repos/dmcneil/darcy-web/issues{/number}","pulls_url":"https://api.github.com/repos/dmcneil/darcy-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dmcneil/darcy-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dmcneil/darcy-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmcneil/darcy-web/labels{/name}","releases_url":"https://api.github.com/repos/dmcneil/darcy-web/releases{/id}","created_at":"2014-08-27T14:06:57Z","updated_at":"2014-10-15T16:09:08Z","pushed_at":"2015-05-22T15:20:11Z","git_url":"git://github.com/dmcneil/darcy-web.git","ssh_url":"git@github.com:dmcneil/darcy-web.git","clone_url":"https://github.com/dmcneil/darcy-web.git","svn_url":"https://github.com/dmcneil/darcy-web","homepage":"","size":298,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darcy-framework:master","ref":"master","sha":"e7848941a52138fa060377cadc2160674620e733","user":{"login":"darcy-framework","id":7107495,"avatar_url":"https://avatars.githubusercontent.com/u/7107495?v=3","gravatar_id":"","url":"https://api.github.com/users/darcy-framework","html_url":"https://github.com/darcy-framework","followers_url":"https://api.github.com/users/darcy-framework/followers","following_url":"https://api.github.com/users/darcy-framework/following{/other_user}","gists_url":"https://api.github.com/users/darcy-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/darcy-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcy-framework/subscriptions","organizations_url":"https://api.github.com/users/darcy-framework/orgs","repos_url":"https://api.github.com/users/darcy-framework/repos","events_url":"https://api.github.com/users/darcy-framework/events{/privacy}","received_events_url":"https://api.github.com/users/darcy-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":18268795,"name":"darcy-web","full_name":"darcy-framework/darcy-web","owner":{"login":"darcy-framework","id":7107495,"avatar_url":"https://avatars.githubusercontent.com/u/7107495?v=3","gravatar_id":"","url":"https://api.github.com/users/darcy-framework","html_url":"https://github.com/darcy-framework","followers_url":"https://api.github.com/users/darcy-framework/followers","following_url":"https://api.github.com/users/darcy-framework/following{/other_user}","gists_url":"https://api.github.com/users/darcy-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/darcy-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcy-framework/subscriptions","organizations_url":"https://api.github.com/users/darcy-framework/orgs","repos_url":"https://api.github.com/users/darcy-framework/repos","events_url":"https://api.github.com/users/darcy-framework/events{/privacy}","received_events_url":"https://api.github.com/users/darcy-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/darcy-framework/darcy-web","description":"Extension to darcy-ui that expands the DSL to support interaction with browsers and web applications.","fork":false,"url":"https://api.github.com/repos/darcy-framework/darcy-web","forks_url":"https://api.github.com/repos/darcy-framework/darcy-web/forks","keys_url":"https://api.github.com/repos/darcy-framework/darcy-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darcy-framework/darcy-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darcy-framework/darcy-web/teams","hooks_url":"https://api.github.com/repos/darcy-framework/darcy-web/hooks","issue_events_url":"https://api.github.com/repos/darcy-framework/darcy-web/issues/events{/number}","events_url":"https://api.github.com/repos/darcy-framework/darcy-web/events","assignees_url":"https://api.github.com/repos/darcy-framework/darcy-web/assignees{/user}","branches_url":"https://api.github.com/repos/darcy-framework/darcy-web/branches{/branch}","tags_url":"https://api.github.com/repos/darcy-framework/darcy-web/tags","blobs_url":"https://api.github.com/repos/darcy-framework/darcy-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darcy-framework/darcy-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darcy-framework/darcy-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/darcy-framework/darcy-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darcy-framework/darcy-web/statuses/{sha}","languages_url":"https://api.github.com/repos/darcy-framework/darcy-web/languages","stargazers_url":"https://api.github.com/repos/darcy-framework/darcy-web/stargazers","contributors_url":"https://api.github.com/repos/darcy-framework/darcy-web/contributors","subscribers_url":"https://api.github.com/repos/darcy-framework/darcy-web/subscribers","subscription_url":"https://api.github.com/repos/darcy-framework/darcy-web/subscription","commits_url":"https://api.github.com/repos/darcy-framework/darcy-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/darcy-framework/darcy-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/darcy-framework/darcy-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/darcy-framework/darcy-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/darcy-framework/darcy-web/contents/{+path}","compare_url":"https://api.github.com/repos/darcy-framework/darcy-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darcy-framework/darcy-web/merges","archive_url":"https://api.github.com/repos/darcy-framework/darcy-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darcy-framework/darcy-web/downloads","issues_url":"https://api.github.com/repos/darcy-framework/darcy-web/issues{/number}","pulls_url":"https://api.github.com/repos/darcy-framework/darcy-web/pulls{/number}","milestones_url":"https://api.github.com/repos/darcy-framework/darcy-web/milestones{/number}","notifications_url":"https://api.github.com/repos/darcy-framework/darcy-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darcy-framework/darcy-web/labels{/name}","releases_url":"https://api.github.com/repos/darcy-framework/darcy-web/releases{/id}","created_at":"2014-03-30T17:01:57Z","updated_at":"2015-04-25T13:10:48Z","pushed_at":"2015-05-22T15:21:53Z","git_url":"git://github.com/darcy-framework/darcy-web.git","ssh_url":"git@github.com:darcy-framework/darcy-web.git","clone_url":"https://github.com/darcy-framework/darcy-web.git","svn_url":"https://github.com/darcy-framework/darcy-web","homepage":"","size":927,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38"},"html":{"href":"https://github.com/darcy-framework/darcy-web/pull/38"},"issue":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/issues/38"},"comments":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/darcy-framework/darcy-web/statuses/e37bc03253ad073be83f6545087999587c719aec"}}}}