{"action":"created","issue":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1287","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1287/labels{/name}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1287/comments","events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1287/events","html_url":"https://github.com/phoenixframework/phoenix/pull/1287","id":111742208,"number":1287,"title":"added encode_www_form to make sure the path helpers are properly escaping dynamic segments","user":{"login":"foxnewsnetwork","id":1010423,"avatar_url":"https://avatars.githubusercontent.com/u/1010423?v=3","gravatar_id":"","url":"https://api.github.com/users/foxnewsnetwork","html_url":"https://github.com/foxnewsnetwork","followers_url":"https://api.github.com/users/foxnewsnetwork/followers","following_url":"https://api.github.com/users/foxnewsnetwork/following{/other_user}","gists_url":"https://api.github.com/users/foxnewsnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/foxnewsnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foxnewsnetwork/subscriptions","organizations_url":"https://api.github.com/users/foxnewsnetwork/orgs","repos_url":"https://api.github.com/users/foxnewsnetwork/repos","events_url":"https://api.github.com/users/foxnewsnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/foxnewsnetwork/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-10-16T01:51:01Z","updated_at":"2015-10-16T16:58:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1287","html_url":"https://github.com/phoenixframework/phoenix/pull/1287","diff_url":"https://github.com/phoenixframework/phoenix/pull/1287.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/1287.patch"},"body":"This is in reference to:\r\n\r\nhttps://github.com/phoenixframework/phoenix/issues/1286\r\n\r\n@josevalim suggested to put the `encode_www_form` inside `to_param`, however, because we already use `to_param` to properly encode querystrings, doing so resulted in a double encoding. The next best place was to place the `encode_www_form` directly inside the `expand_segments` function.\r\n\r\nAdmittedly, I am a little surprised all the tests passed despite the fact I didn't also add `encode_www_form` to L238. I can spend a little more time trying to break into corner cases, but here's the working pr for now.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments/148771048","html_url":"https://github.com/phoenixframework/phoenix/pull/1287#issuecomment-148771048","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1287","id":148771048,"user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"created_at":"2015-10-16T16:58:44Z","updated_at":"2015-10-16T16:58:44Z","body":"@foxnewsnetwork it is a race condition somewhere. :("}}