{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/chef/pulls/comments/37071711","id":37071711,"diff_hunk":"@@ -88,12 +88,14 @@ def run()\n       end\n       role = name_args.first\n \n-      unless Clearwater::BoxManager.supported_roles.include? role\n-        ui.fatal \"#{role} is not a supported box role\"\n-        exit 1\n+      if supported_boxes != []\n+        Chef::Log.error \"Adding boxes #{supported_boxes.to_s}\"","path":"plugins/knife/knife-box-create.rb","position":17,"original_position":17,"commit_id":"e11c1cbf27a8e81484e9e413c3d4035455026b03","original_commit_id":"e11c1cbf27a8e81484e9e413c3d4035455026b03","user":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"body":"These logs are a bit misleading.","created_at":"2015-08-14T12:32:38Z","updated_at":"2015-08-14T12:32:38Z","html_url":"https://github.com/Metaswitch/chef/pull/217#discussion_r37071711","pull_request_url":"https://api.github.com/repos/Metaswitch/chef/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/comments/37071711"},"html":{"href":"https://github.com/Metaswitch/chef/pull/217#discussion_r37071711"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/chef/pulls/217","id":42450291,"html_url":"https://github.com/Metaswitch/chef/pull/217","diff_url":"https://github.com/Metaswitch/chef/pull/217.diff","patch_url":"https://github.com/Metaswitch/chef/pull/217.patch","issue_url":"https://api.github.com/repos/Metaswitch/chef/issues/217","number":217,"state":"open","locked":false,"title":"[Reviewer: Rob] Refactor out deployment resize function","user":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars.githubusercontent.com/u/5425325?v=3","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"body":"Rob, can you review this change to refactor the deployment resize commands. The main changes are to add a deployment utils module that holds the utility functions for the deployment class, and to make creating the local config a recipe in its own right","created_at":"2015-08-14T12:22:35Z","updated_at":"2015-08-14T12:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"747419e460ebb9485b349437533f7346fcb8f7dd","assignee":{"login":"rkd-msw","id":4363492,"avatar_url":"https://avatars.githubusercontent.com/u/4363492?v=3","gravatar_id":"","url":"https://api.github.com/users/rkd-msw","html_url":"https://github.com/rkd-msw","followers_url":"https://api.github.com/users/rkd-msw/followers","following_url":"https://api.github.com/users/rkd-msw/following{/other_user}","gists_url":"https://api.github.com/users/rkd-msw/gists{/gist_id}","starred_url":"https://api.github.com/users/rkd-msw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkd-msw/subscriptions","organizations_url":"https://api.github.com/users/rkd-msw/orgs","repos_url":"https://api.github.com/users/rkd-msw/repos","events_url":"https://api.github.com/users/rkd-msw/events{/privacy}","received_events_url":"https://api.github.com/users/rkd-msw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/chef/pulls/217/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/chef/pulls/217/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/chef/issues/217/comments","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/e11c1cbf27a8e81484e9e413c3d4035455026b03","head":{"label":"Metaswitch:refactor_resize","ref":"refactor_resize","sha":"e11c1cbf27a8e81484e9e413c3d4035455026b03","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885464,"name":"chef","full_name":"Metaswitch/chef","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chef","description":"Repo to hold chef recipes for Clearwater deployment","fork":false,"url":"https://api.github.com/repos/Metaswitch/chef","forks_url":"https://api.github.com/repos/Metaswitch/chef/forks","keys_url":"https://api.github.com/repos/Metaswitch/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chef/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chef/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chef/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chef/events","assignees_url":"https://api.github.com/repos/Metaswitch/chef/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chef/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chef/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chef/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chef/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chef/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chef/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chef/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/chef/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chef/merges","archive_url":"https://api.github.com/repos/Metaswitch/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chef/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chef/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chef/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chef/releases{/id}","created_at":"2013-05-06T11:34:36Z","updated_at":"2015-05-06T15:31:51Z","pushed_at":"2015-08-14T12:22:35Z","git_url":"git://github.com/Metaswitch/chef.git","ssh_url":"git@github.com:Metaswitch/chef.git","clone_url":"https://github.com/Metaswitch/chef.git","svn_url":"https://github.com/Metaswitch/chef","homepage":null,"size":2617,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"c5d3a37c59eeb749c7ffa97001ab9e0277fa1d34","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9885464,"name":"chef","full_name":"Metaswitch/chef","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars.githubusercontent.com/u/453759?v=3","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/chef","description":"Repo to hold chef recipes for Clearwater deployment","fork":false,"url":"https://api.github.com/repos/Metaswitch/chef","forks_url":"https://api.github.com/repos/Metaswitch/chef/forks","keys_url":"https://api.github.com/repos/Metaswitch/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/chef/teams","hooks_url":"https://api.github.com/repos/Metaswitch/chef/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/chef/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/chef/events","assignees_url":"https://api.github.com/repos/Metaswitch/chef/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/chef/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/chef/tags","blobs_url":"https://api.github.com/repos/Metaswitch/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/chef/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/chef/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/chef/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/chef/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/chef/subscription","commits_url":"https://api.github.com/repos/Metaswitch/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/chef/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/chef/merges","archive_url":"https://api.github.com/repos/Metaswitch/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/chef/downloads","issues_url":"https://api.github.com/repos/Metaswitch/chef/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/chef/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/chef/releases{/id}","created_at":"2013-05-06T11:34:36Z","updated_at":"2015-05-06T15:31:51Z","pushed_at":"2015-08-14T12:22:35Z","git_url":"git://github.com/Metaswitch/chef.git","ssh_url":"git@github.com:Metaswitch/chef.git","clone_url":"https://github.com/Metaswitch/chef.git","svn_url":"https://github.com/Metaswitch/chef","homepage":null,"size":2617,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/217"},"html":{"href":"https://github.com/Metaswitch/chef/pull/217"},"issue":{"href":"https://api.github.com/repos/Metaswitch/chef/issues/217"},"comments":{"href":"https://api.github.com/repos/Metaswitch/chef/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/chef/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/chef/statuses/e11c1cbf27a8e81484e9e413c3d4035455026b03"}}}}