{"action":"created","comment":{"url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/comments/47957023","id":47957023,"diff_hunk":"@@ -73,9 +73,21 @@ private void generateCommands() throws IOException, TemplateException {\n         }\n \n         if (ConverterUtil.hasContent(spec.getTypes())) {\n+            // Generate EnumConstant Types, which Element types can be dependant on\n+            // TODO Determine if dependency matters at code generation time... probably not.\n             for (final Ds3Type typeEntry : spec.getTypes().values()) {\n-                generateType(typeEntry);\n-                generateTypeMatcher(typeEntry);\n+                if (typeEntry.getElements().isEmpty()) {\n+                    generateTypeEnumConstant(typeEntry);\n+                    generateTypeEnumConstantMatcher(typeEntry);\n+                }\n+            }\n+\n+            // Generate Element Types\n+            for (final Ds3Type typeEntry : spec.getTypes().values()) {","path":"ds3-autogen-c/src/main/java/com/spectralogic/ds3autogen/c/CCodeGenerator.java","position":16,"original_position":16,"commit_id":"92388259629adc9d1edc6b188270484e443dfe4b","original_commit_id":"92388259629adc9d1edc6b188270484e443dfe4b","user":{"login":"DenverM80","id":8795876,"avatar_url":"https://avatars.githubusercontent.com/u/8795876?v=3","gravatar_id":"","url":"https://api.github.com/users/DenverM80","html_url":"https://github.com/DenverM80","followers_url":"https://api.github.com/users/DenverM80/followers","following_url":"https://api.github.com/users/DenverM80/following{/other_user}","gists_url":"https://api.github.com/users/DenverM80/gists{/gist_id}","starred_url":"https://api.github.com/users/DenverM80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenverM80/subscriptions","organizations_url":"https://api.github.com/users/DenverM80/orgs","repos_url":"https://api.github.com/users/DenverM80/repos","events_url":"https://api.github.com/users/DenverM80/events{/privacy}","received_events_url":"https://api.github.com/users/DenverM80/received_events","type":"User","site_admin":false},"body":"I / We still need to figure out if these are going into all separate files, or all EnumConsts are in one .h file and all the matchers go into one .c file etc - this will def need to get tweaked, but they work for now in these simple scenarios.","created_at":"2015-12-17T20:30:29Z","updated_at":"2015-12-17T20:30:29Z","html_url":"https://github.com/SpectraLogic/ds3_autogen/pull/85#discussion_r47957023","pull_request_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/comments/47957023"},"html":{"href":"https://github.com/SpectraLogic/ds3_autogen/pull/85#discussion_r47957023"},"pull_request":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85","id":54025006,"html_url":"https://github.com/SpectraLogic/ds3_autogen/pull/85","diff_url":"https://github.com/SpectraLogic/ds3_autogen/pull/85.diff","patch_url":"https://github.com/SpectraLogic/ds3_autogen/pull/85.patch","issue_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/85","number":85,"state":"open","locked":false,"title":"Response type","user":{"login":"DenverM80","id":8795876,"avatar_url":"https://avatars.githubusercontent.com/u/8795876?v=3","gravatar_id":"","url":"https://api.github.com/users/DenverM80","html_url":"https://github.com/DenverM80","followers_url":"https://api.github.com/users/DenverM80/followers","following_url":"https://api.github.com/users/DenverM80/following{/other_user}","gists_url":"https://api.github.com/users/DenverM80/gists{/gist_id}","starred_url":"https://api.github.com/users/DenverM80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenverM80/subscriptions","organizations_url":"https://api.github.com/users/DenverM80/orgs","repos_url":"https://api.github.com/users/DenverM80/repos","events_url":"https://api.github.com/users/DenverM80/events{/privacy}","received_events_url":"https://api.github.com/users/DenverM80/received_events","type":"User","site_admin":false},"body":"Testing started at 11:16 AM ...\r\n11:16:10 AM: Executing external tasks 'cleanTest test'...\r\n:ds3-autogen-c:cleanTest\r\n:ds3-autogen-api:compileJava UP-TO-DATE\r\n:ds3-autogen-api:processResources UP-TO-DATE\r\n:ds3-autogen-api:classes UP-TO-DATE\r\n:ds3-autogen-api:jar UP-TO-DATE\r\n:ds3-autogen-utils:compileJava UP-TO-DATE\r\n:ds3-autogen-utils:processResources UP-TO-DATE\r\n:ds3-autogen-utils:classes UP-TO-DATE\r\n:ds3-autogen-utils:jar UP-TO-DATE\r\n:ds3-autogen:compileJava UP-TO-DATE\r\n:ds3-autogen:processResources UP-TO-DATE\r\n:ds3-autogen:classes UP-TO-DATE\r\n:ds3-autogen:jar UP-TO-DATE\r\n:ds3-autogen-c:compileJava UP-TO-DATE\r\n:ds3-autogen-c:processResources UP-TO-DATE\r\n:ds3-autogen-c:classes UP-TO-DATE\r\n:ds3-autogen-c:compileTestJava UP-TO-DATE\r\n:ds3-autogen-c:processTestResources\r\n:ds3-autogen-c:testClasses\r\n:ds3-autogen-c:test\r\n[Test worker] DEBUG com.spectralogic.ds3autogen.c.models.Type - element[ApiVersion][java.lang.String]\r\n[Test worker] DEBUG com.spectralogic.ds3autogen.c.models.Type - element[BackendActivated][boolean]\r\n[Test worker] DEBUG com.spectralogic.ds3autogen.c.models.Type - element[BuildInformation][com.spectralogic.s3.common.platform.lang.BuildInformation]\r\n[Test worker] DEBUG com.spectralogic.ds3autogen.c.models.Type - element[SerialNumber][java.lang.String]\r\n[Test worker] INFO com.spectralogic.ds3autogen.c.CCodeGenerator_Test - Generated code:\r\n/*\r\n * ******************************************************************************\r\n *   Copyright 2014-2015 Spectra Logic Corporation. All Rights Reserved.\r\n *   Licensed under the Apache License, Version 2.0 (the \"License\"). You may not use\r\n *   this file except in compliance with the License. A copy of the License is located at\r\n *\r\n *   http://www.apache.org/licenses/LICENSE-2.0\r\n *\r\n *   or in the \"license\" file accompanying this file.\r\n *   This file is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\r\n *   CONDITIONS OF ANY KIND, either express or implied. See the License for the\r\n *   specific language governing permissions and limitations under the License.\r\n * ****************************************************************************\r\n */\r\n\r\n/* This Code is Auto-Generated; DO NOT MODIFY! */\r\n\r\n\r\ntypedef enum {\r\n    ds3_str* api_version;\r\n    ds3_bool backend_activated;\r\n    ds3_build_information* build_information;\r\n    ds3_str* serial_number;\r\n\r\n}ds3_get_system_information_response;\r\n\r\nBUILD SUCCESSFUL\r\nTotal time: 3.049 secs","created_at":"2015-12-17T20:08:26Z","updated_at":"2015-12-17T20:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58395b80322d4d15cf726b9fd9ca6ddde4fc1ac5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85/commits","review_comments_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85/comments","review_comment_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/85/comments","statuses_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/statuses/92388259629adc9d1edc6b188270484e443dfe4b","head":{"label":"DenverM80:ResponseType","ref":"ResponseType","sha":"92388259629adc9d1edc6b188270484e443dfe4b","user":{"login":"DenverM80","id":8795876,"avatar_url":"https://avatars.githubusercontent.com/u/8795876?v=3","gravatar_id":"","url":"https://api.github.com/users/DenverM80","html_url":"https://github.com/DenverM80","followers_url":"https://api.github.com/users/DenverM80/followers","following_url":"https://api.github.com/users/DenverM80/following{/other_user}","gists_url":"https://api.github.com/users/DenverM80/gists{/gist_id}","starred_url":"https://api.github.com/users/DenverM80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenverM80/subscriptions","organizations_url":"https://api.github.com/users/DenverM80/orgs","repos_url":"https://api.github.com/users/DenverM80/repos","events_url":"https://api.github.com/users/DenverM80/events{/privacy}","received_events_url":"https://api.github.com/users/DenverM80/received_events","type":"User","site_admin":false},"repo":{"id":48195535,"name":"ds3_autogen","full_name":"DenverM80/ds3_autogen","owner":{"login":"DenverM80","id":8795876,"avatar_url":"https://avatars.githubusercontent.com/u/8795876?v=3","gravatar_id":"","url":"https://api.github.com/users/DenverM80","html_url":"https://github.com/DenverM80","followers_url":"https://api.github.com/users/DenverM80/followers","following_url":"https://api.github.com/users/DenverM80/following{/other_user}","gists_url":"https://api.github.com/users/DenverM80/gists{/gist_id}","starred_url":"https://api.github.com/users/DenverM80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenverM80/subscriptions","organizations_url":"https://api.github.com/users/DenverM80/orgs","repos_url":"https://api.github.com/users/DenverM80/repos","events_url":"https://api.github.com/users/DenverM80/events{/privacy}","received_events_url":"https://api.github.com/users/DenverM80/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DenverM80/ds3_autogen","description":"","fork":true,"url":"https://api.github.com/repos/DenverM80/ds3_autogen","forks_url":"https://api.github.com/repos/DenverM80/ds3_autogen/forks","keys_url":"https://api.github.com/repos/DenverM80/ds3_autogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DenverM80/ds3_autogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DenverM80/ds3_autogen/teams","hooks_url":"https://api.github.com/repos/DenverM80/ds3_autogen/hooks","issue_events_url":"https://api.github.com/repos/DenverM80/ds3_autogen/issues/events{/number}","events_url":"https://api.github.com/repos/DenverM80/ds3_autogen/events","assignees_url":"https://api.github.com/repos/DenverM80/ds3_autogen/assignees{/user}","branches_url":"https://api.github.com/repos/DenverM80/ds3_autogen/branches{/branch}","tags_url":"https://api.github.com/repos/DenverM80/ds3_autogen/tags","blobs_url":"https://api.github.com/repos/DenverM80/ds3_autogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DenverM80/ds3_autogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DenverM80/ds3_autogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/DenverM80/ds3_autogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DenverM80/ds3_autogen/statuses/{sha}","languages_url":"https://api.github.com/repos/DenverM80/ds3_autogen/languages","stargazers_url":"https://api.github.com/repos/DenverM80/ds3_autogen/stargazers","contributors_url":"https://api.github.com/repos/DenverM80/ds3_autogen/contributors","subscribers_url":"https://api.github.com/repos/DenverM80/ds3_autogen/subscribers","subscription_url":"https://api.github.com/repos/DenverM80/ds3_autogen/subscription","commits_url":"https://api.github.com/repos/DenverM80/ds3_autogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/DenverM80/ds3_autogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/DenverM80/ds3_autogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/DenverM80/ds3_autogen/issues/comments{/number}","contents_url":"https://api.github.com/repos/DenverM80/ds3_autogen/contents/{+path}","compare_url":"https://api.github.com/repos/DenverM80/ds3_autogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DenverM80/ds3_autogen/merges","archive_url":"https://api.github.com/repos/DenverM80/ds3_autogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DenverM80/ds3_autogen/downloads","issues_url":"https://api.github.com/repos/DenverM80/ds3_autogen/issues{/number}","pulls_url":"https://api.github.com/repos/DenverM80/ds3_autogen/pulls{/number}","milestones_url":"https://api.github.com/repos/DenverM80/ds3_autogen/milestones{/number}","notifications_url":"https://api.github.com/repos/DenverM80/ds3_autogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DenverM80/ds3_autogen/labels{/name}","releases_url":"https://api.github.com/repos/DenverM80/ds3_autogen/releases{/id}","created_at":"2015-12-17T20:02:34Z","updated_at":"2015-12-17T20:02:35Z","pushed_at":"2015-12-17T20:05:32Z","git_url":"git://github.com/DenverM80/ds3_autogen.git","ssh_url":"git@github.com:DenverM80/ds3_autogen.git","clone_url":"https://github.com/DenverM80/ds3_autogen.git","svn_url":"https://github.com/DenverM80/ds3_autogen","homepage":null,"size":733,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpectraLogic:master","ref":"master","sha":"d6540337d3b600fec66b80e1b754d5796699c9a7","user":{"login":"SpectraLogic","id":7060807,"avatar_url":"https://avatars.githubusercontent.com/u/7060807?v=3","gravatar_id":"","url":"https://api.github.com/users/SpectraLogic","html_url":"https://github.com/SpectraLogic","followers_url":"https://api.github.com/users/SpectraLogic/followers","following_url":"https://api.github.com/users/SpectraLogic/following{/other_user}","gists_url":"https://api.github.com/users/SpectraLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SpectraLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpectraLogic/subscriptions","organizations_url":"https://api.github.com/users/SpectraLogic/orgs","repos_url":"https://api.github.com/users/SpectraLogic/repos","events_url":"https://api.github.com/users/SpectraLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SpectraLogic/received_events","type":"Organization","site_admin":false},"repo":{"id":43916943,"name":"ds3_autogen","full_name":"SpectraLogic/ds3_autogen","owner":{"login":"SpectraLogic","id":7060807,"avatar_url":"https://avatars.githubusercontent.com/u/7060807?v=3","gravatar_id":"","url":"https://api.github.com/users/SpectraLogic","html_url":"https://github.com/SpectraLogic","followers_url":"https://api.github.com/users/SpectraLogic/followers","following_url":"https://api.github.com/users/SpectraLogic/following{/other_user}","gists_url":"https://api.github.com/users/SpectraLogic/gists{/gist_id}","starred_url":"https://api.github.com/users/SpectraLogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpectraLogic/subscriptions","organizations_url":"https://api.github.com/users/SpectraLogic/orgs","repos_url":"https://api.github.com/users/SpectraLogic/repos","events_url":"https://api.github.com/users/SpectraLogic/events{/privacy}","received_events_url":"https://api.github.com/users/SpectraLogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpectraLogic/ds3_autogen","description":"","fork":false,"url":"https://api.github.com/repos/SpectraLogic/ds3_autogen","forks_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/forks","keys_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/teams","hooks_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/hooks","issue_events_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/events{/number}","events_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/events","assignees_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/assignees{/user}","branches_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/branches{/branch}","tags_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/tags","blobs_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/statuses/{sha}","languages_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/languages","stargazers_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/stargazers","contributors_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/contributors","subscribers_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/subscribers","subscription_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/subscription","commits_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/contents/{+path}","compare_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/merges","archive_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/downloads","issues_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues{/number}","pulls_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls{/number}","milestones_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/milestones{/number}","notifications_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/labels{/name}","releases_url":"https://api.github.com/repos/SpectraLogic/ds3_autogen/releases{/id}","created_at":"2015-10-08T21:21:28Z","updated_at":"2015-11-03T22:00:56Z","pushed_at":"2015-12-17T20:08:26Z","git_url":"git://github.com/SpectraLogic/ds3_autogen.git","ssh_url":"git@github.com:SpectraLogic/ds3_autogen.git","clone_url":"https://github.com/SpectraLogic/ds3_autogen.git","svn_url":"https://github.com/SpectraLogic/ds3_autogen","homepage":null,"size":714,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85"},"html":{"href":"https://github.com/SpectraLogic/ds3_autogen/pull/85"},"issue":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/85"},"comments":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/SpectraLogic/ds3_autogen/statuses/92388259629adc9d1edc6b188270484e443dfe4b"}}}}