{"action":"created","issue":{"url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/1","labels_url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/1/comments","events_url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/1/events","html_url":"https://github.com/werekraken/puppet-openldap/pull/1","id":117226777,"number":1,"title":"Patch ldap conf","user":{"login":"kronos-pbrideau","id":1564589,"avatar_url":"https://avatars.githubusercontent.com/u/1564589?v=3","gravatar_id":"","url":"https://api.github.com/users/kronos-pbrideau","html_url":"https://github.com/kronos-pbrideau","followers_url":"https://api.github.com/users/kronos-pbrideau/followers","following_url":"https://api.github.com/users/kronos-pbrideau/following{/other_user}","gists_url":"https://api.github.com/users/kronos-pbrideau/gists{/gist_id}","starred_url":"https://api.github.com/users/kronos-pbrideau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronos-pbrideau/subscriptions","organizations_url":"https://api.github.com/users/kronos-pbrideau/orgs","repos_url":"https://api.github.com/users/kronos-pbrideau/repos","events_url":"https://api.github.com/users/kronos-pbrideau/events{/privacy}","received_events_url":"https://api.github.com/users/kronos-pbrideau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-16T21:54:01Z","updated_at":"2015-11-17T16:17:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/werekraken/puppet-openldap/pulls/1","html_url":"https://github.com/werekraken/puppet-openldap/pull/1","diff_url":"https://github.com/werekraken/puppet-openldap/pull/1.diff","patch_url":"https://github.com/werekraken/puppet-openldap/pull/1.patch"},"body":"Would it be possible for you to include also these options?\r\n\r\n[ldap.conf](http://linux.die.net/man/5/ldap.conf)\r\nTIMELIMIT\r\nTIMEOUT\r\n\r\n[sudo-ldap] (http://www.sudo.ws/man/1.8.15/sudoers.ldap.man.html)\r\nBIND_TIMELIMIT\r\nSUDOERS_BASE\r\n"},"comment":{"url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/comments/157417991","html_url":"https://github.com/werekraken/puppet-openldap/pull/1#issuecomment-157417991","issue_url":"https://api.github.com/repos/werekraken/puppet-openldap/issues/1","id":157417991,"user":{"login":"werekraken","id":10225919,"avatar_url":"https://avatars.githubusercontent.com/u/10225919?v=3","gravatar_id":"","url":"https://api.github.com/users/werekraken","html_url":"https://github.com/werekraken","followers_url":"https://api.github.com/users/werekraken/followers","following_url":"https://api.github.com/users/werekraken/following{/other_user}","gists_url":"https://api.github.com/users/werekraken/gists{/gist_id}","starred_url":"https://api.github.com/users/werekraken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/werekraken/subscriptions","organizations_url":"https://api.github.com/users/werekraken/orgs","repos_url":"https://api.github.com/users/werekraken/repos","events_url":"https://api.github.com/users/werekraken/events{/privacy}","received_events_url":"https://api.github.com/users/werekraken/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T16:17:01Z","updated_at":"2015-11-17T16:17:01Z","body":"@kronos-pbrideau binddn, bindpw, timelimit, and timeout look good.\r\n\r\nbind_timelimit is a shared parameter, not sudo specific. For example, it is an nss_ldap option.\r\nhttp://linux.die.net/man/5/nss_ldap\r\nWe should drop the sudo on that and move it out of the \"# SUDO options\" section.\r\n\r\nAll the existing parameters are lowercase versions of the ldap.conf key. SUDOERS_BASE is the key, so for consistency the parameter should be sudoers_base. We should drop the sudo on that and leave it in the \"# SUDO options\" section."}}