{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/18353","labels_url":"https://api.github.com/repos/docker/docker/issues/18353/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/18353/comments","events_url":"https://api.github.com/repos/docker/docker/issues/18353/events","html_url":"https://github.com/docker/docker/pull/18353","id":119840149,"number":18353,"title":"Improved push and pull with upload manager and download manager","user":{"login":"aaronlehmann","id":10601430,"avatar_url":"https://avatars.githubusercontent.com/u/10601430?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronlehmann","html_url":"https://github.com/aaronlehmann","followers_url":"https://api.github.com/users/aaronlehmann/followers","following_url":"https://api.github.com/users/aaronlehmann/following{/other_user}","gists_url":"https://api.github.com/users/aaronlehmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlehmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlehmann/subscriptions","organizations_url":"https://api.github.com/users/aaronlehmann/orgs","repos_url":"https://api.github.com/users/aaronlehmann/repos","events_url":"https://api.github.com/users/aaronlehmann/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlehmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/distribution","name":"group/distribution","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/status/3-docs-review","name":"status/3-docs-review","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":32,"created_at":"2015-12-02T00:28:47Z","updated_at":"2015-12-09T19:44:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/18353","html_url":"https://github.com/docker/docker/pull/18353","diff_url":"https://github.com/docker/docker/pull/18353.diff","patch_url":"https://github.com/docker/docker/pull/18353.patch"},"body":"This commit adds a transfer manager which deduplicates and schedules\r\ntransfers, and also an upload manager and download manager that build on\r\ntop of the transfer manager to provide high-level interfaces for uploads\r\nand downloads. The push and pull code is modified to use these building\r\nblocks.\r\n\r\nSome benefits of the changes:\r\n\r\n- Simplification of push/pull code\r\n- Pushes can upload layers concurrently\r\n- Failed downloads and uploads are retried after backoff delays\r\n- Cancellation is supported, but individual transfers will only be\r\n  cancelled if all pushes or pulls using them are cancelled.\r\n- The distribution code is decoupled from Docker Engine packages and API\r\n  conventions (i.e. streamformatter), which will make it easier to split\r\n  out.\r\n\r\nThis commit also includes unit tests for the new distribution/xfer\r\npackage. The tests cover 87.8% of the statements in the package.\r\n\r\nfixes https://github.com/docker/docker/issues/18498"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/163369596","html_url":"https://github.com/docker/docker/pull/18353#issuecomment-163369596","issue_url":"https://api.github.com/repos/docker/docker/issues/18353","id":163369596,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T19:44:39Z","updated_at":"2015-12-09T19:44:39Z","body":"Some minor nits, LGTM otherwise \r\n\r\nping @moxiegirl @SvenDowideit for review "}}