{"action":"created","issue":{"url":"https://api.github.com/repos/jboeuf/grpc/issues/4","labels_url":"https://api.github.com/repos/jboeuf/grpc/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/jboeuf/grpc/issues/4/comments","events_url":"https://api.github.com/repos/jboeuf/grpc/issues/4/events","html_url":"https://github.com/jboeuf/grpc/pull/4","id":112705360,"number":4,"title":"PHP: Core credentials API refactoring","user":{"login":"stanley-cheung","id":11674202,"avatar_url":"https://avatars.githubusercontent.com/u/11674202?v=3","gravatar_id":"","url":"https://api.github.com/users/stanley-cheung","html_url":"https://github.com/stanley-cheung","followers_url":"https://api.github.com/users/stanley-cheung/followers","following_url":"https://api.github.com/users/stanley-cheung/following{/other_user}","gists_url":"https://api.github.com/users/stanley-cheung/gists{/gist_id}","starred_url":"https://api.github.com/users/stanley-cheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanley-cheung/subscriptions","organizations_url":"https://api.github.com/users/stanley-cheung/orgs","repos_url":"https://api.github.com/users/stanley-cheung/repos","events_url":"https://api.github.com/users/stanley-cheung/events{/privacy}","received_events_url":"https://api.github.com/users/stanley-cheung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-22T00:25:16Z","updated_at":"2015-10-27T00:09:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jboeuf/grpc/pulls/4","html_url":"https://github.com/jboeuf/grpc/pull/4","diff_url":"https://github.com/jboeuf/grpc/pull/4.diff","patch_url":"https://github.com/jboeuf/grpc/pull/4.patch"},"body":" * For issue grpc/grpc#3828 and PR grpc/grpc#3765\r\n * Split `grpc_credentials` into `grpc_channel_credentials` and `grpc_call_credentials`\r\n * Renamed `credentials.c` into `channel_credentials.c`, `Credentials` class into `ChannelCredentials` class, etc.\r\n * Added `call_credentials.c`, and `CallCredentials` class\r\n * Split the original `Credentials::createComposite` function into `ChannelCredentials::createComposite` and `CallCredentials::createComposite` \r\n * Removed the `Credentials::createGce` method because no one is calling it\r\n * Ran unit tests, generarted code test (against Node server with #3) and basic interop test (against Node server with #3) locally and all passed.\r\n * There should be no more reference to the naked `Credentials` or `credentials`"},"comment":{"url":"https://api.github.com/repos/jboeuf/grpc/issues/comments/151319443","html_url":"https://github.com/jboeuf/grpc/pull/4#issuecomment-151319443","issue_url":"https://api.github.com/repos/jboeuf/grpc/issues/4","id":151319443,"user":{"login":"jtattermusch","id":9939684,"avatar_url":"https://avatars.githubusercontent.com/u/9939684?v=3","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T00:09:30Z","updated_at":"2015-10-27T00:09:30Z","body":"is this ready for review?"}}