{"action":"created","comment":{"url":"https://api.github.com/repos/apache/phoenix/pulls/comments/26725524","id":26725524,"diff_hunk":"@@ -95,6 +95,11 @@ public Object toObject(byte[] b, int o, int l, PDataType actualType, SortOrder s\n   }\n \n   @Override\n+    public boolean isCastableTo(PDataType targetType) {","path":"phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedLong.java","position":4,"original_position":4,"commit_id":"bfe114af832dee4ea4ba4ee1cdc663e7461a1b6c","original_commit_id":"bfe114af832dee4ea4ba4ee1cdc663e7461a1b6c","user":{"login":"dhacker1341","id":1022832,"avatar_url":"https://avatars.githubusercontent.com/u/1022832?v=3","gravatar_id":"","url":"https://api.github.com/users/dhacker1341","html_url":"https://github.com/dhacker1341","followers_url":"https://api.github.com/users/dhacker1341/followers","following_url":"https://api.github.com/users/dhacker1341/following{/other_user}","gists_url":"https://api.github.com/users/dhacker1341/gists{/gist_id}","starred_url":"https://api.github.com/users/dhacker1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhacker1341/subscriptions","organizations_url":"https://api.github.com/users/dhacker1341/orgs","repos_url":"https://api.github.com/users/dhacker1341/repos","events_url":"https://api.github.com/users/dhacker1341/events{/privacy}","received_events_url":"https://api.github.com/users/dhacker1341/received_events","type":"User","site_admin":false},"body":"The problem with that is the smaller. Numbers in the jira like 22847 wind up being integer and not long so without doing both you have an arbitrarily small number where things just start working so cast(12949 as timestamp) will not work but cast(284484849 as timestamp) will. \n\n> On Mar 18, 2015, at 7:00 PM, James Taylor <notifications@github.com> wrote:\n> \n> In phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedLong.java:\n> \n> > @@ -95,6 +95,11 @@ public Object toObject(byte[] b, int o, int l, PDataType actualType, SortOrder s\n> >    }\n> >  \n> >    @Override\n> > +    public boolean isCastableTo(PDataType targetType) {\n> Was thinking to only make this change so that an UNSIGNED_LONG is castable to a TIMESTAMP. Allowing an INTEGER to be cast to a TIMESTAMP seems weird to me. How about we just start with this change for now and you adjust your tests accordingly?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n","created_at":"2015-03-19T02:18:38Z","updated_at":"2015-03-19T02:18:38Z","html_url":"https://github.com/apache/phoenix/pull/48#discussion_r26725524","pull_request_url":"https://api.github.com/repos/apache/phoenix/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments/26725524"},"html":{"href":"https://github.com/apache/phoenix/pull/48#discussion_r26725524"},"pull_request":{"href":"https://api.github.com/repos/apache/phoenix/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/apache/phoenix/pulls/48","id":31469603,"html_url":"https://github.com/apache/phoenix/pull/48","diff_url":"https://github.com/apache/phoenix/pull/48.diff","patch_url":"https://github.com/apache/phoenix/pull/48.patch","issue_url":"https://api.github.com/repos/apache/phoenix/issues/48","number":48,"state":"open","locked":false,"title":"PHOENIX-1744 Allow Integer, UnsignedInt and UnsignedLong to be Cast to T...","user":{"login":"dhacker1341","id":1022832,"avatar_url":"https://avatars.githubusercontent.com/u/1022832?v=3","gravatar_id":"","url":"https://api.github.com/users/dhacker1341","html_url":"https://github.com/dhacker1341","followers_url":"https://api.github.com/users/dhacker1341/followers","following_url":"https://api.github.com/users/dhacker1341/following{/other_user}","gists_url":"https://api.github.com/users/dhacker1341/gists{/gist_id}","starred_url":"https://api.github.com/users/dhacker1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhacker1341/subscriptions","organizations_url":"https://api.github.com/users/dhacker1341/orgs","repos_url":"https://api.github.com/users/dhacker1341/repos","events_url":"https://api.github.com/users/dhacker1341/events{/privacy}","received_events_url":"https://api.github.com/users/dhacker1341/received_events","type":"User","site_admin":false},"body":"...IMESTAMP","created_at":"2015-03-18T20:38:53Z","updated_at":"2015-03-19T02:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbc86fe07633ce01a97c664d5c2a79be8b5f965b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/phoenix/pulls/48/commits","review_comments_url":"https://api.github.com/repos/apache/phoenix/pulls/48/comments","review_comment_url":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/phoenix/issues/48/comments","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/bfe114af832dee4ea4ba4ee1cdc663e7461a1b6c","head":{"label":"dhacker1341:master","ref":"master","sha":"bfe114af832dee4ea4ba4ee1cdc663e7461a1b6c","user":{"login":"dhacker1341","id":1022832,"avatar_url":"https://avatars.githubusercontent.com/u/1022832?v=3","gravatar_id":"","url":"https://api.github.com/users/dhacker1341","html_url":"https://github.com/dhacker1341","followers_url":"https://api.github.com/users/dhacker1341/followers","following_url":"https://api.github.com/users/dhacker1341/following{/other_user}","gists_url":"https://api.github.com/users/dhacker1341/gists{/gist_id}","starred_url":"https://api.github.com/users/dhacker1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhacker1341/subscriptions","organizations_url":"https://api.github.com/users/dhacker1341/orgs","repos_url":"https://api.github.com/users/dhacker1341/repos","events_url":"https://api.github.com/users/dhacker1341/events{/privacy}","received_events_url":"https://api.github.com/users/dhacker1341/received_events","type":"User","site_admin":false},"repo":{"id":32480648,"name":"phoenix","full_name":"dhacker1341/phoenix","owner":{"login":"dhacker1341","id":1022832,"avatar_url":"https://avatars.githubusercontent.com/u/1022832?v=3","gravatar_id":"","url":"https://api.github.com/users/dhacker1341","html_url":"https://github.com/dhacker1341","followers_url":"https://api.github.com/users/dhacker1341/followers","following_url":"https://api.github.com/users/dhacker1341/following{/other_user}","gists_url":"https://api.github.com/users/dhacker1341/gists{/gist_id}","starred_url":"https://api.github.com/users/dhacker1341/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhacker1341/subscriptions","organizations_url":"https://api.github.com/users/dhacker1341/orgs","repos_url":"https://api.github.com/users/dhacker1341/repos","events_url":"https://api.github.com/users/dhacker1341/events{/privacy}","received_events_url":"https://api.github.com/users/dhacker1341/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhacker1341/phoenix","description":"Mirror of Apache Phoenix","fork":true,"url":"https://api.github.com/repos/dhacker1341/phoenix","forks_url":"https://api.github.com/repos/dhacker1341/phoenix/forks","keys_url":"https://api.github.com/repos/dhacker1341/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhacker1341/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhacker1341/phoenix/teams","hooks_url":"https://api.github.com/repos/dhacker1341/phoenix/hooks","issue_events_url":"https://api.github.com/repos/dhacker1341/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/dhacker1341/phoenix/events","assignees_url":"https://api.github.com/repos/dhacker1341/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/dhacker1341/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/dhacker1341/phoenix/tags","blobs_url":"https://api.github.com/repos/dhacker1341/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhacker1341/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhacker1341/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhacker1341/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhacker1341/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/dhacker1341/phoenix/languages","stargazers_url":"https://api.github.com/repos/dhacker1341/phoenix/stargazers","contributors_url":"https://api.github.com/repos/dhacker1341/phoenix/contributors","subscribers_url":"https://api.github.com/repos/dhacker1341/phoenix/subscribers","subscription_url":"https://api.github.com/repos/dhacker1341/phoenix/subscription","commits_url":"https://api.github.com/repos/dhacker1341/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhacker1341/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhacker1341/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhacker1341/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhacker1341/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/dhacker1341/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhacker1341/phoenix/merges","archive_url":"https://api.github.com/repos/dhacker1341/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhacker1341/phoenix/downloads","issues_url":"https://api.github.com/repos/dhacker1341/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/dhacker1341/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/dhacker1341/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/dhacker1341/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhacker1341/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/dhacker1341/phoenix/releases{/id}","created_at":"2015-03-18T19:49:31Z","updated_at":"2015-03-18T20:37:44Z","pushed_at":"2015-03-18T20:37:44Z","git_url":"git://github.com/dhacker1341/phoenix.git","ssh_url":"git@github.com:dhacker1341/phoenix.git","clone_url":"https://github.com/dhacker1341/phoenix.git","svn_url":"https://github.com/dhacker1341/phoenix","homepage":null,"size":25162,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"319fdcb569ce41273b627845c4860ecabf45417d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20473418,"name":"phoenix","full_name":"apache/phoenix","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/phoenix","description":"Mirror of Apache Phoenix","fork":false,"url":"https://api.github.com/repos/apache/phoenix","forks_url":"https://api.github.com/repos/apache/phoenix/forks","keys_url":"https://api.github.com/repos/apache/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/phoenix/teams","hooks_url":"https://api.github.com/repos/apache/phoenix/hooks","issue_events_url":"https://api.github.com/repos/apache/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/apache/phoenix/events","assignees_url":"https://api.github.com/repos/apache/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/apache/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/apache/phoenix/tags","blobs_url":"https://api.github.com/repos/apache/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/phoenix/languages","stargazers_url":"https://api.github.com/repos/apache/phoenix/stargazers","contributors_url":"https://api.github.com/repos/apache/phoenix/contributors","subscribers_url":"https://api.github.com/repos/apache/phoenix/subscribers","subscription_url":"https://api.github.com/repos/apache/phoenix/subscription","commits_url":"https://api.github.com/repos/apache/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/apache/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/phoenix/merges","archive_url":"https://api.github.com/repos/apache/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/phoenix/downloads","issues_url":"https://api.github.com/repos/apache/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/apache/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/apache/phoenix/releases{/id}","created_at":"2014-06-04T07:00:08Z","updated_at":"2015-03-19T00:59:21Z","pushed_at":"2015-03-19T01:01:28Z","git_url":"git://github.com/apache/phoenix.git","ssh_url":"git@github.com:apache/phoenix.git","clone_url":"https://github.com/apache/phoenix.git","svn_url":"https://github.com/apache/phoenix","homepage":null,"size":25162,"stargazers_count":49,"watchers_count":49,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":"git://git.apache.org/phoenix.git","open_issues_count":31,"forks":90,"open_issues":31,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/48"},"html":{"href":"https://github.com/apache/phoenix/pull/48"},"issue":{"href":"https://api.github.com/repos/apache/phoenix/issues/48"},"comments":{"href":"https://api.github.com/repos/apache/phoenix/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/phoenix/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/phoenix/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/apache/phoenix/statuses/bfe114af832dee4ea4ba4ee1cdc663e7461a1b6c"}}}}