{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/comments/30319566","id":30319566,"diff_hunk":"@@ -223,3 +256,8 @@ var _filter = function (pattern, options) {\n     return minimatch.filter(pattern, options);\n }\n exports.filter = _filter;\n+\n+var _findFiles = function (pattern) {\n+    return glob.sync(pattern);","path":"src/vso-task-lib/lib/vsotask.js","position":58,"original_position":58,"commit_id":"320c1dab154b7395ac9a27f9f4abb518dba06e1f","original_commit_id":"320c1dab154b7395ac9a27f9f4abb518dba06e1f","user":{"login":"madhurig","id":3269636,"avatar_url":"https://avatars.githubusercontent.com/u/3269636?v=3","gravatar_id":"","url":"https://api.github.com/users/madhurig","html_url":"https://github.com/madhurig","followers_url":"https://api.github.com/users/madhurig/followers","following_url":"https://api.github.com/users/madhurig/following{/other_user}","gists_url":"https://api.github.com/users/madhurig/gists{/gist_id}","starred_url":"https://api.github.com/users/madhurig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhurig/subscriptions","organizations_url":"https://api.github.com/users/madhurig/orgs","repos_url":"https://api.github.com/users/madhurig/repos","events_url":"https://api.github.com/users/madhurig/events{/privacy}","received_events_url":"https://api.github.com/users/madhurig/received_events","type":"User","site_admin":false},"body":"I was trying to avoid duplicating the code for find and filter in all the tasks. Will remove the glob.sync and use find and filter methods in the task implementation","created_at":"2015-05-14T13:22:23Z","updated_at":"2015-05-14T13:22:23Z","html_url":"https://github.com/Microsoft/vso-agent/pull/13#discussion_r30319566","pull_request_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/comments/30319566"},"html":{"href":"https://github.com/Microsoft/vso-agent/pull/13#discussion_r30319566"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13","id":35369032,"html_url":"https://github.com/Microsoft/vso-agent/pull/13","diff_url":"https://github.com/Microsoft/vso-agent/pull/13.diff","patch_url":"https://github.com/Microsoft/vso-agent/pull/13.patch","issue_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/13","number":13,"state":"open","locked":false,"title":"Users/madhurig/TestPub","user":{"login":"madhurig","id":3269636,"avatar_url":"https://avatars.githubusercontent.com/u/3269636?v=3","gravatar_id":"","url":"https://api.github.com/users/madhurig","html_url":"https://github.com/madhurig","followers_url":"https://api.github.com/users/madhurig/followers","following_url":"https://api.github.com/users/madhurig/following{/other_user}","gists_url":"https://api.github.com/users/madhurig/gists{/gist_id}","starred_url":"https://api.github.com/users/madhurig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhurig/subscriptions","organizations_url":"https://api.github.com/users/madhurig/orgs","repos_url":"https://api.github.com/users/madhurig/repos","events_url":"https://api.github.com/users/madhurig/events{/privacy}","received_events_url":"https://api.github.com/users/madhurig/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-13T20:48:57Z","updated_at":"2015-05-14T13:22:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78a2cfd0f6cfb5043d9da22ca2aeb0acf267beb5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/13/comments","statuses_url":"https://api.github.com/repos/Microsoft/vso-agent/statuses/320c1dab154b7395ac9a27f9f4abb518dba06e1f","head":{"label":"Microsoft:users/madhurig/TestPub","ref":"users/madhurig/TestPub","sha":"320c1dab154b7395ac9a27f9f4abb518dba06e1f","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27405247,"name":"vso-agent","full_name":"Microsoft/vso-agent","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vso-agent","description":"Visual Studio Online and TFS agent for OSX and Linux","fork":false,"url":"https://api.github.com/repos/Microsoft/vso-agent","forks_url":"https://api.github.com/repos/Microsoft/vso-agent/forks","keys_url":"https://api.github.com/repos/Microsoft/vso-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vso-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vso-agent/teams","hooks_url":"https://api.github.com/repos/Microsoft/vso-agent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vso-agent/events","assignees_url":"https://api.github.com/repos/Microsoft/vso-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vso-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vso-agent/tags","blobs_url":"https://api.github.com/repos/Microsoft/vso-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vso-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vso-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vso-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vso-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vso-agent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vso-agent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vso-agent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vso-agent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vso-agent/subscription","commits_url":"https://api.github.com/repos/Microsoft/vso-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vso-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vso-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vso-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vso-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vso-agent/merges","archive_url":"https://api.github.com/repos/Microsoft/vso-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vso-agent/downloads","issues_url":"https://api.github.com/repos/Microsoft/vso-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vso-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vso-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vso-agent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vso-agent/releases{/id}","created_at":"2014-12-01T23:24:24Z","updated_at":"2015-05-08T19:33:41Z","pushed_at":"2015-05-14T12:40:04Z","git_url":"git://github.com/Microsoft/vso-agent.git","ssh_url":"git@github.com:Microsoft/vso-agent.git","clone_url":"https://github.com/Microsoft/vso-agent.git","svn_url":"https://github.com/Microsoft/vso-agent","homepage":null,"size":1408,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":25,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"94a43a36d9f9a9d956936573299ba8389925f9b5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27405247,"name":"vso-agent","full_name":"Microsoft/vso-agent","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vso-agent","description":"Visual Studio Online and TFS agent for OSX and Linux","fork":false,"url":"https://api.github.com/repos/Microsoft/vso-agent","forks_url":"https://api.github.com/repos/Microsoft/vso-agent/forks","keys_url":"https://api.github.com/repos/Microsoft/vso-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vso-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vso-agent/teams","hooks_url":"https://api.github.com/repos/Microsoft/vso-agent/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vso-agent/events","assignees_url":"https://api.github.com/repos/Microsoft/vso-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vso-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vso-agent/tags","blobs_url":"https://api.github.com/repos/Microsoft/vso-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vso-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vso-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vso-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vso-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vso-agent/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vso-agent/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vso-agent/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vso-agent/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vso-agent/subscription","commits_url":"https://api.github.com/repos/Microsoft/vso-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vso-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vso-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vso-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vso-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vso-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vso-agent/merges","archive_url":"https://api.github.com/repos/Microsoft/vso-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vso-agent/downloads","issues_url":"https://api.github.com/repos/Microsoft/vso-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vso-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vso-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vso-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vso-agent/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vso-agent/releases{/id}","created_at":"2014-12-01T23:24:24Z","updated_at":"2015-05-08T19:33:41Z","pushed_at":"2015-05-14T12:40:04Z","git_url":"git://github.com/Microsoft/vso-agent.git","ssh_url":"git@github.com:Microsoft/vso-agent.git","clone_url":"https://github.com/Microsoft/vso-agent.git","svn_url":"https://github.com/Microsoft/vso-agent","homepage":null,"size":1408,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13"},"html":{"href":"https://github.com/Microsoft/vso-agent/pull/13"},"issue":{"href":"https://api.github.com/repos/Microsoft/vso-agent/issues/13"},"comments":{"href":"https://api.github.com/repos/Microsoft/vso-agent/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vso-agent/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vso-agent/statuses/320c1dab154b7395ac9a27f9f4abb518dba06e1f"}}}}