{"action":"created","issue":{"url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/1","labels_url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/1/comments","events_url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/1/events","html_url":"https://github.com/phamthienbao/RottenTomatoes/issues/1","id":104100099,"number":1,"title":"RottenTomatoes assignment - Completed","user":{"login":"phamthienbao","id":12556291,"avatar_url":"https://avatars.githubusercontent.com/u/12556291?v=3","gravatar_id":"","url":"https://api.github.com/users/phamthienbao","html_url":"https://github.com/phamthienbao","followers_url":"https://api.github.com/users/phamthienbao/followers","following_url":"https://api.github.com/users/phamthienbao/following{/other_user}","gists_url":"https://api.github.com/users/phamthienbao/gists{/gist_id}","starred_url":"https://api.github.com/users/phamthienbao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamthienbao/subscriptions","organizations_url":"https://api.github.com/users/phamthienbao/orgs","repos_url":"https://api.github.com/users/phamthienbao/repos","events_url":"https://api.github.com/users/phamthienbao/events{/privacy}","received_events_url":"https://api.github.com/users/phamthienbao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-31T17:52:30Z","updated_at":"2015-09-03T19:38:43Z","closed_at":null,"body":"Hello /cc @chug2k,\r\n\r\nI've completed for required feature of this assignment. Pls help me to review it.\r\n\r\nIn addition, I'm researching for optional feature as well as improving the existing features. \r\n\r\nThanks,\r\nBaoP"},"comment":{"url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/comments/137553299","html_url":"https://github.com/phamthienbao/RottenTomatoes/issues/1#issuecomment-137553299","issue_url":"https://api.github.com/repos/phamthienbao/RottenTomatoes/issues/1","id":137553299,"user":{"login":"chug2k","id":44512,"avatar_url":"https://avatars.githubusercontent.com/u/44512?v=3","gravatar_id":"","url":"https://api.github.com/users/chug2k","html_url":"https://github.com/chug2k","followers_url":"https://api.github.com/users/chug2k/followers","following_url":"https://api.github.com/users/chug2k/following{/other_user}","gists_url":"https://api.github.com/users/chug2k/gists{/gist_id}","starred_url":"https://api.github.com/users/chug2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chug2k/subscriptions","organizations_url":"https://api.github.com/users/chug2k/orgs","repos_url":"https://api.github.com/users/chug2k/repos","events_url":"https://api.github.com/users/chug2k/events{/privacy}","received_events_url":"https://api.github.com/users/chug2k/received_events","type":"User","site_admin":false},"created_at":"2015-09-03T19:38:43Z","updated_at":"2015-09-03T19:38:43Z","body":"Much better. :bird: \r\n\r\nI didn't mention this in class, but please be sure to follow the Swift code styling conventions for the homework. Here are a few useful guides:\r\n   - [Ray Wenderlich Swift Style Guide](https://github.com/raywenderlich/swift-style-guide)\r\n   - [Github Swift Style Guide](https://github.com/github/swift-style-guide)\r\n\r\nYou are a little bit sloppy with your brackets and indentation. Please make sure your code is always correctly indented. Also please avoid variable names like `movies_cells` and `index_path` - it should be `moviesCells` and `indexPath`. \r\n\r\nIn class I only used a NSDictionary, but it would have been nice if you implemented a model class. The SwiftyJSON library is useful for this - https://github.com/SwiftyJSON/SwiftyJSON. \r\n\r\n* Nice work with the custom Movie cell.\r\n* Nice work loading the images asynchronously.\r\n* Nice work implementing the error message on network failure. Next time consider using `UIView.animateWithDuration` to fade or slide the message instead of just `hidden = false`. \r\n* You should also show \"Network Error\" for the Movie Details screen, when you try to load the high resolution image and there is no network.\r\n\r\nI hope to see you complete more optional tasks this week!\r\n"}}