{"action":"created","issue":{"url":"https://api.github.com/repos/SFTtech/openage/issues/189","labels_url":"https://api.github.com/repos/SFTtech/openage/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/SFTtech/openage/issues/189/comments","events_url":"https://api.github.com/repos/SFTtech/openage/issues/189/events","html_url":"https://github.com/SFTtech/openage/issues/189","id":53755760,"number":189,"title":"Create test cases for existing subsystems","user":{"login":"TheJJ","id":673543,"avatar_url":"https://avatars.githubusercontent.com/u/673543?v=3","gravatar_id":"","url":"https://api.github.com/users/TheJJ","html_url":"https://github.com/TheJJ","followers_url":"https://api.github.com/users/TheJJ/followers","following_url":"https://api.github.com/users/TheJJ/following{/other_user}","gists_url":"https://api.github.com/users/TheJJ/gists{/gist_id}","starred_url":"https://api.github.com/users/TheJJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheJJ/subscriptions","organizations_url":"https://api.github.com/users/TheJJ/orgs","repos_url":"https://api.github.com/users/TheJJ/repos","events_url":"https://api.github.com/users/TheJJ/events{/privacy}","received_events_url":"https://api.github.com/users/TheJJ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SFTtech/openage/labels/c++","name":"c++","color":"000000"},{"url":"https://api.github.com/repos/SFTtech/openage/labels/code%20quality","name":"code quality","color":"006b75"},{"url":"https://api.github.com/repos/SFTtech/openage/labels/easy","name":"easy","color":"ccee20"},{"url":"https://api.github.com/repos/SFTtech/openage/labels/just%20do%20it","name":"just do it","color":"3fe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-08T14:27:35Z","updated_at":"2015-05-28T01:34:43Z","closed_at":null,"body":"Because reasons we should add more tests to the code.\r\n\r\nSubstems with test coverage:\r\n\r\n- [X] Pathfinding\r\n- [ ] Jobmanager\r\n- [ ] Terrain blending\r\n- [x] Coordinate system\r\n- [ ] Asset manager\r\n\r\nFor the missing ones, please create some creative tests.\r\nAn example how that could look like can be seen in `cpp/datastructure/`.\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7588860-create-test-cases-for-existing-subsystems?utm_campaign=plugin&utm_content=tracker%2F371436&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F371436&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/SFTtech/openage/issues/comments/106135371","html_url":"https://github.com/SFTtech/openage/issues/189#issuecomment-106135371","issue_url":"https://api.github.com/repos/SFTtech/openage/issues/189","id":106135371,"user":{"login":"kukinsula","id":2879984,"avatar_url":"https://avatars.githubusercontent.com/u/2879984?v=3","gravatar_id":"","url":"https://api.github.com/users/kukinsula","html_url":"https://github.com/kukinsula","followers_url":"https://api.github.com/users/kukinsula/followers","following_url":"https://api.github.com/users/kukinsula/following{/other_user}","gists_url":"https://api.github.com/users/kukinsula/gists{/gist_id}","starred_url":"https://api.github.com/users/kukinsula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kukinsula/subscriptions","organizations_url":"https://api.github.com/users/kukinsula/orgs","repos_url":"https://api.github.com/users/kukinsula/repos","events_url":"https://api.github.com/users/kukinsula/events{/privacy}","received_events_url":"https://api.github.com/users/kukinsula/received_events","type":"User","site_admin":false},"created_at":"2015-05-28T01:34:43Z","updated_at":"2015-05-28T01:34:43Z","body":"Hello everyone ! You asked for subsystems tests coverage and I was wondering if you would like to have more tests for the log subsystem (I know it's not in your list that's why I'm asking).\r\n\r\nI've been reading up the whole log subsystem and I realized that its test file only tests the log messages through a console LogSink but not through a FileSink. So I managed to also test it and write a few log messages in /tmp/openage-log-test. So now the log's test launches the previous test and the one I just created and it works fine.\r\n\r\nWould you guys accept this test ?"}}