{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/3739","labels_url":"https://api.github.com/repos/netty/netty/issues/3739/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/3739/comments","events_url":"https://api.github.com/repos/netty/netty/issues/3739/events","html_url":"https://github.com/netty/netty/pull/3739","id":73507693,"number":3739,"title":"Not defer close of Channel when in flush","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-06T04:06:38Z","updated_at":"2015-05-06T06:40:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3739","html_url":"https://github.com/netty/netty/pull/3739","diff_url":"https://github.com/netty/netty/pull/3739.diff","patch_url":"https://github.com/netty/netty/pull/3739.patch"},"body":"Motivation:\r\n\r\nBefore we defered the closing of the Channel when we were flushing. This is problematic as this means that if the user add a ChannelFutureListener that closed the Channel we was not excecute this until we are done with flushing. This can lead to more data send as expected.\r\n\r\nModifications:\r\n\r\n- Not defer closing when in flush\r\n\r\nResult:\r\n\r\nCorrectly respect order of events and closing the Channel ASAP"},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/99344275","html_url":"https://github.com/netty/netty/pull/3739#issuecomment-99344275","issue_url":"https://api.github.com/repos/netty/netty/issues/3739","id":99344275,"user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T06:40:01Z","updated_at":"2015-05-06T06:40:01Z","body":"Commit message:\r\n\r\n* Before we defered -> Previously, we deferred\r\n* the user add -> the user adds\r\n* that closed the Channel we was not excecute this until we are done with flushing - please rephrase\r\n* more data sent as expected -> more data is sent than expected\r\n* Not defer -> Do not defer\r\n\r\nCode looks OK though."}}