{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/comments/30948189","id":30948189,"diff_hunk":"@@ -1,10 +1,12 @@\n using GLPKMathProgInterface\n \n-include(joinpath(Pkg.dir(\"MathProgBase\"),\"test\",\"linprog.jl\"))\n+const mathprogbase_test = joinpath(Pkg.dir(\"MathProgBase\"), \"test\")","path":"test/runtests.jl","position":4,"original_position":4,"commit_id":"37ea8e480efd5cc14984300455fcf300c614b7e2","original_commit_id":"37ea8e480efd5cc14984300455fcf300c614b7e2","user":{"login":"carlobaldassi","id":223753,"avatar_url":"https://avatars.githubusercontent.com/u/223753?v=3","gravatar_id":"","url":"https://api.github.com/users/carlobaldassi","html_url":"https://github.com/carlobaldassi","followers_url":"https://api.github.com/users/carlobaldassi/followers","following_url":"https://api.github.com/users/carlobaldassi/following{/other_user}","gists_url":"https://api.github.com/users/carlobaldassi/gists{/gist_id}","starred_url":"https://api.github.com/users/carlobaldassi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlobaldassi/subscriptions","organizations_url":"https://api.github.com/users/carlobaldassi/orgs","repos_url":"https://api.github.com/users/carlobaldassi/repos","events_url":"https://api.github.com/users/carlobaldassi/events{/privacy}","received_events_url":"https://api.github.com/users/carlobaldassi/received_events","type":"User","site_admin":false},"body":"Sorry, I saw these comments after I hit merge.\r\nAnyway, this is equivalent to what was there before, so no harm done.\r\n(And I don't have strong opinions on what to use, as I develop from inside `.julia`.)","created_at":"2015-05-23T20:56:24Z","updated_at":"2015-05-23T20:56:24Z","html_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23#discussion_r30948189","pull_request_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/comments/30948189"},"html":{"href":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23#discussion_r30948189"},"pull_request":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23","id":36092930,"html_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23","diff_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23.diff","patch_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23.patch","issue_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/23","number":23,"state":"closed","locked":false,"title":"0.4-dev fixes","user":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"body":"1. Fix deprecation warning about `Dict` constructor\r\n2. Remove manual path construction for `include`\r\n3. The change in `runtests.jl` is some left over for my local testing (in order to workaround https://github.com/JuliaLang/julia/issues/8679) and I think it doesn't hurt to keep.\r\n","created_at":"2015-05-23T20:10:17Z","updated_at":"2015-05-23T20:56:24Z","closed_at":"2015-05-23T20:49:35Z","merged_at":"2015-05-23T20:49:35Z","merge_commit_sha":"052284ee536dfa679ac5eb10ff025ce92c84c3a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/23/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/statuses/37ea8e480efd5cc14984300455fcf300c614b7e2","head":{"label":"yuyichao:0.4-dev","ref":"0.4-dev","sha":"37ea8e480efd5cc14984300455fcf300c614b7e2","user":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"repo":{"id":36140318,"name":"GLPKMathProgInterface.jl","full_name":"yuyichao/GLPKMathProgInterface.jl","owner":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuyichao/GLPKMathProgInterface.jl","description":"Interface between the GLPK.jl wrapper and MathProgBase.jl","fork":true,"url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl","forks_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/forks","keys_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/teams","hooks_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/events","assignees_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/tags","blobs_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/languages","stargazers_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/subscription","commits_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/merges","archive_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/downloads","issues_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/yuyichao/GLPKMathProgInterface.jl/releases{/id}","created_at":"2015-05-23T20:04:58Z","updated_at":"2015-05-23T20:04:59Z","pushed_at":"2015-05-23T20:05:38Z","git_url":"git://github.com/yuyichao/GLPKMathProgInterface.jl.git","ssh_url":"git@github.com:yuyichao/GLPKMathProgInterface.jl.git","clone_url":"https://github.com/yuyichao/GLPKMathProgInterface.jl.git","svn_url":"https://github.com/yuyichao/GLPKMathProgInterface.jl","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"a70c14f2f10c25e458271f3964ec7ce4385c064e","user":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars.githubusercontent.com/u/5667382?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":10182174,"name":"GLPKMathProgInterface.jl","full_name":"JuliaOpt/GLPKMathProgInterface.jl","owner":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars.githubusercontent.com/u/5667382?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl","description":"Interface between the GLPK.jl wrapper and MathProgBase.jl","fork":false,"url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl","forks_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/releases{/id}","created_at":"2013-05-20T21:19:00Z","updated_at":"2015-02-13T01:23:56Z","pushed_at":"2015-05-23T20:49:35Z","git_url":"git://github.com/JuliaOpt/GLPKMathProgInterface.jl.git","ssh_url":"git@github.com:JuliaOpt/GLPKMathProgInterface.jl.git","clone_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl.git","svn_url":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl","homepage":null,"size":515,"stargazers_count":3,"watchers_count":3,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23"},"html":{"href":"https://github.com/JuliaOpt/GLPKMathProgInterface.jl/pull/23"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/23"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/GLPKMathProgInterface.jl/statuses/37ea8e480efd5cc14984300455fcf300c614b7e2"}}}}