{"action":"closed","number":11175,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175","id":44376462,"html_url":"https://github.com/cms-sw/cmssw/pull/11175","diff_url":"https://github.com/cms-sw/cmssw/pull/11175.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11175.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11175","number":11175,"state":"closed","locked":false,"title":"cleanup of uninitialized reads reported by valgrind (backport of #11173 )","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"A fraction of uninitialized value reads reported by valgrind in wflow 4.53 step3 is cleaned up.\r\nThe following summary is based on tests in 76X  with #11173\r\n- PileupJetIdAlgo is buggy and will need to be fixed by JME developers (I will start a separate thread for this). I have just gotten rid of uninitialized reads.\r\n    - confirmed with valgrind as fixed\r\n- HcalZDCMonitor counters initialized (cleans up occasional NANs in the plots)\r\n    - confirmed with valgrind as fixed\r\n- B2GDQM was missing initialization of semiE_LepJetPtCut (the default uninitialized value was between zero and any other value; it now becomes 30 GeV as desired in the config). Corresponding plots will change.\r\n    - confirmed with valgrind as fixed\r\n- EcalClusterLazyToolsBase had reads beyond vector size (should be harmless from the logic)\r\n    - confirmed with valgrind as fixed\r\n- patPFMETCorrections changes appear to be cosmetic\r\n    - the invalid read in SmearedJetProducerT calling StringCutObjectSelector still remains\r\n- changes in cscdqm::StripClusterFinder are towards cleaning of uninitialized values in StripClusterFitData::height_\r\n    - cleanup is not confirmed by valgrind\r\n\r\nTested in CMSSW_7_5_X_2015-09-06-2300 /test area sign584/: \r\n    - short matrix test comparisons show changes in affected plots in DQM\r\n    - reco products monitored with fwlite script are not affected","created_at":"2015-09-07T19:34:38Z","updated_at":"2015-09-11T06:54:52Z","closed_at":"2015-09-11T06:54:52Z","merged_at":"2015-09-11T06:54:52Z","merge_commit_sha":"2283bdce663e636127d5876c5791560cedd3d610","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":1295,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-09-11T06:54:52Z","due_on":"2015-05-31T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11175/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/322de3a8a36c0791d39347fdcef0a0cc56354653","head":{"label":"slava77:CMSSW_7_5_X_2015-09-06-2300/puMVAetc-valgrind","ref":"CMSSW_7_5_X_2015-09-06-2300/puMVAetc-valgrind","sha":"322de3a8a36c0791d39347fdcef0a0cc56354653","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"repo":{"id":10990410,"name":"cmssw","full_name":"slava77/cmssw","owner":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slava77/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/slava77/cmssw","forks_url":"https://api.github.com/repos/slava77/cmssw/forks","keys_url":"https://api.github.com/repos/slava77/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slava77/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slava77/cmssw/teams","hooks_url":"https://api.github.com/repos/slava77/cmssw/hooks","issue_events_url":"https://api.github.com/repos/slava77/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/slava77/cmssw/events","assignees_url":"https://api.github.com/repos/slava77/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/slava77/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/slava77/cmssw/tags","blobs_url":"https://api.github.com/repos/slava77/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slava77/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slava77/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/slava77/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slava77/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/slava77/cmssw/languages","stargazers_url":"https://api.github.com/repos/slava77/cmssw/stargazers","contributors_url":"https://api.github.com/repos/slava77/cmssw/contributors","subscribers_url":"https://api.github.com/repos/slava77/cmssw/subscribers","subscription_url":"https://api.github.com/repos/slava77/cmssw/subscription","commits_url":"https://api.github.com/repos/slava77/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/slava77/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/slava77/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/slava77/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/slava77/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/slava77/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slava77/cmssw/merges","archive_url":"https://api.github.com/repos/slava77/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slava77/cmssw/downloads","issues_url":"https://api.github.com/repos/slava77/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/slava77/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/slava77/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/slava77/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slava77/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/slava77/cmssw/releases{/id}","created_at":"2013-06-27T07:31:57Z","updated_at":"2014-06-24T14:25:44Z","pushed_at":"2015-09-10T20:34:33Z","git_url":"git://github.com/slava77/cmssw.git","ssh_url":"git@github.com:slava77/cmssw.git","clone_url":"https://github.com/slava77/cmssw.git","svn_url":"https://github.com/slava77/cmssw","homepage":null,"size":833979,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":49,"forks":1,"open_issues":49,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"b72e661db50fdf459244b0e95117fb978c5dad58","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-09-01T14:09:03Z","pushed_at":"2015-09-11T06:54:52Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1285876,"stargazers_count":258,"watchers_count":258,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1557,"mirror_url":null,"open_issues_count":248,"forks":1557,"open_issues":248,"watchers":258,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11175"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11175"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11175/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11175/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/322de3a8a36c0791d39347fdcef0a0cc56354653"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":8,"additions":18,"deletions":15,"changed_files":8}}