{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/41344000","id":41344000,"diff_hunk":"@@ -1416,6 +1440,177 @@ public struct Linger {\n \t\tpublic int l_linger;\n \t}\n \n+\t[Map]\n+\t[StructLayout (LayoutKind.Sequential)]\n+\t[CLSCompliant (false)]\n+\tpublic struct InAddr : IEquatable<InAddr> {\n+\t\tpublic uint s_addr;\n+\n+\t\tpublic InAddr (byte b0, byte b1, byte b2, byte b3)\n+\t\t{\n+\t\t\ts_addr = 0;\n+\t\t\tthis[0] = b0;","path":"mcs/class/Mono.Posix/Mono.Unix.Native/Syscall.cs","position":51,"original_position":51,"commit_id":"f9df9dc6bcbe4c02a4b743b3f33b730eede3d51c","original_commit_id":"f9df9dc6bcbe4c02a4b743b3f33b730eede3d51c","user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"body":"This seems inefficient, as you'll be evaluating the `ArgumentOufOfRangeException` check *4* times, when you *know* you shouldn't need any.\r\n\r\nI also wonder -- and I'm not sure how to verify :-( -- what byte ordering constraints there are, if any. I believe that you intend for `s_addr` to be in Network Byte Order...but should it be? I don't know what it should be, but this does give me pause.","created_at":"2015-10-07T01:45:03Z","updated_at":"2015-10-07T01:45:03Z","html_url":"https://github.com/mono/mono/pull/2097#discussion_r41344000","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/2097","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/41344000"},"html":{"href":"https://github.com/mono/mono/pull/2097#discussion_r41344000"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/2097"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/2097","id":46270241,"html_url":"https://github.com/mono/mono/pull/2097","diff_url":"https://github.com/mono/mono/pull/2097.diff","patch_url":"https://github.com/mono/mono/pull/2097.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/2097","number":2097,"state":"open","locked":false,"title":" [Mono.Posix] Add support for sending and receiving socket control messages","user":{"login":"steffen-kiess","id":947515,"avatar_url":"https://avatars.githubusercontent.com/u/947515?v=3","gravatar_id":"","url":"https://api.github.com/users/steffen-kiess","html_url":"https://github.com/steffen-kiess","followers_url":"https://api.github.com/users/steffen-kiess/followers","following_url":"https://api.github.com/users/steffen-kiess/following{/other_user}","gists_url":"https://api.github.com/users/steffen-kiess/gists{/gist_id}","starred_url":"https://api.github.com/users/steffen-kiess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffen-kiess/subscriptions","organizations_url":"https://api.github.com/users/steffen-kiess/orgs","repos_url":"https://api.github.com/users/steffen-kiess/repos","events_url":"https://api.github.com/users/steffen-kiess/events{/privacy}","received_events_url":"https://api.github.com/users/steffen-kiess/received_events","type":"User","site_admin":false},"body":"Add wrappers for struct cmsghdr, the macros for manipulating control messages (CMSG_*) and recvmsg() and sendmsg().\r\n\r\nThis commit is the third and last part of #1977\r\n\r\nThis pull request depends on #2006","created_at":"2015-09-29T12:27:40Z","updated_at":"2015-10-07T01:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c49375025dca03d977ffc3bbe1d84464db27f49","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/2097/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/2097/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/2097/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/f9df9dc6bcbe4c02a4b743b3f33b730eede3d51c","head":{"label":"steffen-kiess:posix-sockets-3","ref":"posix-sockets-3","sha":"f9df9dc6bcbe4c02a4b743b3f33b730eede3d51c","user":{"login":"steffen-kiess","id":947515,"avatar_url":"https://avatars.githubusercontent.com/u/947515?v=3","gravatar_id":"","url":"https://api.github.com/users/steffen-kiess","html_url":"https://github.com/steffen-kiess","followers_url":"https://api.github.com/users/steffen-kiess/followers","following_url":"https://api.github.com/users/steffen-kiess/following{/other_user}","gists_url":"https://api.github.com/users/steffen-kiess/gists{/gist_id}","starred_url":"https://api.github.com/users/steffen-kiess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffen-kiess/subscriptions","organizations_url":"https://api.github.com/users/steffen-kiess/orgs","repos_url":"https://api.github.com/users/steffen-kiess/repos","events_url":"https://api.github.com/users/steffen-kiess/events{/privacy}","received_events_url":"https://api.github.com/users/steffen-kiess/received_events","type":"User","site_admin":false},"repo":{"id":3240307,"name":"mono","full_name":"steffen-kiess/mono","owner":{"login":"steffen-kiess","id":947515,"avatar_url":"https://avatars.githubusercontent.com/u/947515?v=3","gravatar_id":"","url":"https://api.github.com/users/steffen-kiess","html_url":"https://github.com/steffen-kiess","followers_url":"https://api.github.com/users/steffen-kiess/followers","following_url":"https://api.github.com/users/steffen-kiess/following{/other_user}","gists_url":"https://api.github.com/users/steffen-kiess/gists{/gist_id}","starred_url":"https://api.github.com/users/steffen-kiess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffen-kiess/subscriptions","organizations_url":"https://api.github.com/users/steffen-kiess/orgs","repos_url":"https://api.github.com/users/steffen-kiess/repos","events_url":"https://api.github.com/users/steffen-kiess/events{/privacy}","received_events_url":"https://api.github.com/users/steffen-kiess/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steffen-kiess/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/steffen-kiess/mono","forks_url":"https://api.github.com/repos/steffen-kiess/mono/forks","keys_url":"https://api.github.com/repos/steffen-kiess/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffen-kiess/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffen-kiess/mono/teams","hooks_url":"https://api.github.com/repos/steffen-kiess/mono/hooks","issue_events_url":"https://api.github.com/repos/steffen-kiess/mono/issues/events{/number}","events_url":"https://api.github.com/repos/steffen-kiess/mono/events","assignees_url":"https://api.github.com/repos/steffen-kiess/mono/assignees{/user}","branches_url":"https://api.github.com/repos/steffen-kiess/mono/branches{/branch}","tags_url":"https://api.github.com/repos/steffen-kiess/mono/tags","blobs_url":"https://api.github.com/repos/steffen-kiess/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffen-kiess/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffen-kiess/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffen-kiess/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffen-kiess/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/steffen-kiess/mono/languages","stargazers_url":"https://api.github.com/repos/steffen-kiess/mono/stargazers","contributors_url":"https://api.github.com/repos/steffen-kiess/mono/contributors","subscribers_url":"https://api.github.com/repos/steffen-kiess/mono/subscribers","subscription_url":"https://api.github.com/repos/steffen-kiess/mono/subscription","commits_url":"https://api.github.com/repos/steffen-kiess/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffen-kiess/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffen-kiess/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffen-kiess/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffen-kiess/mono/contents/{+path}","compare_url":"https://api.github.com/repos/steffen-kiess/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffen-kiess/mono/merges","archive_url":"https://api.github.com/repos/steffen-kiess/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffen-kiess/mono/downloads","issues_url":"https://api.github.com/repos/steffen-kiess/mono/issues{/number}","pulls_url":"https://api.github.com/repos/steffen-kiess/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/steffen-kiess/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/steffen-kiess/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffen-kiess/mono/labels{/name}","releases_url":"https://api.github.com/repos/steffen-kiess/mono/releases{/id}","created_at":"2012-01-22T15:46:26Z","updated_at":"2015-08-24T16:56:09Z","pushed_at":"2015-09-29T12:25:14Z","git_url":"git://github.com/steffen-kiess/mono.git","ssh_url":"git@github.com:steffen-kiess/mono.git","clone_url":"https://github.com/steffen-kiess/mono.git","svn_url":"https://github.com/steffen-kiess/mono","homepage":"http://www.mono-project.com/","size":436519,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"24be79b2db0d9ca26559395149582068c45b2380","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","created_at":"2010-07-22T18:06:36Z","updated_at":"2015-10-06T19:52:01Z","pushed_at":"2015-10-06T22:13:23Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":1649069,"stargazers_count":3869,"watchers_count":3869,"language":"C#","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1921,"mirror_url":null,"open_issues_count":101,"forks":1921,"open_issues":101,"watchers":3869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/2097"},"html":{"href":"https://github.com/mono/mono/pull/2097"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/2097"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/2097/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/2097/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/2097/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/f9df9dc6bcbe4c02a4b743b3f33b730eede3d51c"}}}}