{"action":"created","comment":{"url":"https://api.github.com/repos/phutchins/pipo/pulls/comments/31913813","id":31913813,"diff_hunk":"@@ -86,9 +86,10 @@ function EncryptionManager() {\n           return callback(new Error(\"No payload found in signature\"));\n         }\n \n-        payloadString = payload.toString();\n+        payloadString = JSON.stringify(JSON.parse(payload.toString()));\n+        expectedPayloadString = JSON.stringify(JSON.parse(expectedPayloadString.toString()));\n \n-        if (payloadString.toString() !== expectedPayloadString.toString()) {\n+        if (payloadString != expectedPayloadString) {","path":"managers/encryption.js","position":9,"original_position":9,"commit_id":"a9de22287d0c9e58b5b5ae3f6e7a86544fdd2385","original_commit_id":"a9de22287d0c9e58b5b5ae3f6e7a86544fdd2385","user":{"login":"sambohler","id":4063920,"avatar_url":"https://avatars.githubusercontent.com/u/4063920?v=3","gravatar_id":"","url":"https://api.github.com/users/sambohler","html_url":"https://github.com/sambohler","followers_url":"https://api.github.com/users/sambohler/followers","following_url":"https://api.github.com/users/sambohler/following{/other_user}","gists_url":"https://api.github.com/users/sambohler/gists{/gist_id}","starred_url":"https://api.github.com/users/sambohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambohler/subscriptions","organizations_url":"https://api.github.com/users/sambohler/orgs","repos_url":"https://api.github.com/users/sambohler/repos","events_url":"https://api.github.com/users/sambohler/events{/privacy}","received_events_url":"https://api.github.com/users/sambohler/received_events","type":"User","site_admin":false},"body":"Change back to !==","created_at":"2015-06-08T13:32:51Z","updated_at":"2015-06-08T13:32:51Z","html_url":"https://github.com/phutchins/pipo/pull/12#discussion_r31913813","pull_request_url":"https://api.github.com/repos/phutchins/pipo/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/comments/31913813"},"html":{"href":"https://github.com/phutchins/pipo/pull/12#discussion_r31913813"},"pull_request":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/phutchins/pipo/pulls/12","id":37152996,"html_url":"https://github.com/phutchins/pipo/pull/12","diff_url":"https://github.com/phutchins/pipo/pull/12.diff","patch_url":"https://github.com/phutchins/pipo/pull/12.patch","issue_url":"https://api.github.com/repos/phutchins/pipo/issues/12","number":12,"state":"open","locked":false,"title":"Signature comparison was broken when newlines are different in files","user":{"login":"phutchins","id":1074345,"avatar_url":"https://avatars.githubusercontent.com/u/1074345?v=3","gravatar_id":"","url":"https://api.github.com/users/phutchins","html_url":"https://github.com/phutchins","followers_url":"https://api.github.com/users/phutchins/followers","following_url":"https://api.github.com/users/phutchins/following{/other_user}","gists_url":"https://api.github.com/users/phutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/phutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phutchins/subscriptions","organizations_url":"https://api.github.com/users/phutchins/orgs","repos_url":"https://api.github.com/users/phutchins/repos","events_url":"https://api.github.com/users/phutchins/events{/privacy}","received_events_url":"https://api.github.com/users/phutchins/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-08T13:29:27Z","updated_at":"2015-06-08T13:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6af18edaef9b731a50c0749f9cc390104d52f84c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phutchins/pipo/pulls/12/commits","review_comments_url":"https://api.github.com/repos/phutchins/pipo/pulls/12/comments","review_comment_url":"https://api.github.com/repos/phutchins/pipo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phutchins/pipo/issues/12/comments","statuses_url":"https://api.github.com/repos/phutchins/pipo/statuses/a9de22287d0c9e58b5b5ae3f6e7a86544fdd2385","head":{"label":"phutchins:bug/sigCompareFix","ref":"bug/sigCompareFix","sha":"a9de22287d0c9e58b5b5ae3f6e7a86544fdd2385","user":{"login":"phutchins","id":1074345,"avatar_url":"https://avatars.githubusercontent.com/u/1074345?v=3","gravatar_id":"","url":"https://api.github.com/users/phutchins","html_url":"https://github.com/phutchins","followers_url":"https://api.github.com/users/phutchins/followers","following_url":"https://api.github.com/users/phutchins/following{/other_user}","gists_url":"https://api.github.com/users/phutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/phutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phutchins/subscriptions","organizations_url":"https://api.github.com/users/phutchins/orgs","repos_url":"https://api.github.com/users/phutchins/repos","events_url":"https://api.github.com/users/phutchins/events{/privacy}","received_events_url":"https://api.github.com/users/phutchins/received_events","type":"User","site_admin":false},"repo":{"id":35233736,"name":"pipo","full_name":"phutchins/pipo","owner":{"login":"phutchins","id":1074345,"avatar_url":"https://avatars.githubusercontent.com/u/1074345?v=3","gravatar_id":"","url":"https://api.github.com/users/phutchins","html_url":"https://github.com/phutchins","followers_url":"https://api.github.com/users/phutchins/followers","following_url":"https://api.github.com/users/phutchins/following{/other_user}","gists_url":"https://api.github.com/users/phutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/phutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phutchins/subscriptions","organizations_url":"https://api.github.com/users/phutchins/orgs","repos_url":"https://api.github.com/users/phutchins/repos","events_url":"https://api.github.com/users/phutchins/events{/privacy}","received_events_url":"https://api.github.com/users/phutchins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phutchins/pipo","description":"Secure end to end client side encryption chat","fork":false,"url":"https://api.github.com/repos/phutchins/pipo","forks_url":"https://api.github.com/repos/phutchins/pipo/forks","keys_url":"https://api.github.com/repos/phutchins/pipo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phutchins/pipo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phutchins/pipo/teams","hooks_url":"https://api.github.com/repos/phutchins/pipo/hooks","issue_events_url":"https://api.github.com/repos/phutchins/pipo/issues/events{/number}","events_url":"https://api.github.com/repos/phutchins/pipo/events","assignees_url":"https://api.github.com/repos/phutchins/pipo/assignees{/user}","branches_url":"https://api.github.com/repos/phutchins/pipo/branches{/branch}","tags_url":"https://api.github.com/repos/phutchins/pipo/tags","blobs_url":"https://api.github.com/repos/phutchins/pipo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phutchins/pipo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phutchins/pipo/git/refs{/sha}","trees_url":"https://api.github.com/repos/phutchins/pipo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phutchins/pipo/statuses/{sha}","languages_url":"https://api.github.com/repos/phutchins/pipo/languages","stargazers_url":"https://api.github.com/repos/phutchins/pipo/stargazers","contributors_url":"https://api.github.com/repos/phutchins/pipo/contributors","subscribers_url":"https://api.github.com/repos/phutchins/pipo/subscribers","subscription_url":"https://api.github.com/repos/phutchins/pipo/subscription","commits_url":"https://api.github.com/repos/phutchins/pipo/commits{/sha}","git_commits_url":"https://api.github.com/repos/phutchins/pipo/git/commits{/sha}","comments_url":"https://api.github.com/repos/phutchins/pipo/comments{/number}","issue_comment_url":"https://api.github.com/repos/phutchins/pipo/issues/comments{/number}","contents_url":"https://api.github.com/repos/phutchins/pipo/contents/{+path}","compare_url":"https://api.github.com/repos/phutchins/pipo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phutchins/pipo/merges","archive_url":"https://api.github.com/repos/phutchins/pipo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phutchins/pipo/downloads","issues_url":"https://api.github.com/repos/phutchins/pipo/issues{/number}","pulls_url":"https://api.github.com/repos/phutchins/pipo/pulls{/number}","milestones_url":"https://api.github.com/repos/phutchins/pipo/milestones{/number}","notifications_url":"https://api.github.com/repos/phutchins/pipo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phutchins/pipo/labels{/name}","releases_url":"https://api.github.com/repos/phutchins/pipo/releases{/id}","created_at":"2015-05-07T17:28:33Z","updated_at":"2015-05-14T14:45:59Z","pushed_at":"2015-06-08T13:29:28Z","git_url":"git://github.com/phutchins/pipo.git","ssh_url":"git@github.com:phutchins/pipo.git","clone_url":"https://github.com/phutchins/pipo.git","svn_url":"https://github.com/phutchins/pipo","homepage":null,"size":15093,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"phutchins:master","ref":"master","sha":"8fdfd5a49b131fa18005f3171b73899de22187de","user":{"login":"phutchins","id":1074345,"avatar_url":"https://avatars.githubusercontent.com/u/1074345?v=3","gravatar_id":"","url":"https://api.github.com/users/phutchins","html_url":"https://github.com/phutchins","followers_url":"https://api.github.com/users/phutchins/followers","following_url":"https://api.github.com/users/phutchins/following{/other_user}","gists_url":"https://api.github.com/users/phutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/phutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phutchins/subscriptions","organizations_url":"https://api.github.com/users/phutchins/orgs","repos_url":"https://api.github.com/users/phutchins/repos","events_url":"https://api.github.com/users/phutchins/events{/privacy}","received_events_url":"https://api.github.com/users/phutchins/received_events","type":"User","site_admin":false},"repo":{"id":35233736,"name":"pipo","full_name":"phutchins/pipo","owner":{"login":"phutchins","id":1074345,"avatar_url":"https://avatars.githubusercontent.com/u/1074345?v=3","gravatar_id":"","url":"https://api.github.com/users/phutchins","html_url":"https://github.com/phutchins","followers_url":"https://api.github.com/users/phutchins/followers","following_url":"https://api.github.com/users/phutchins/following{/other_user}","gists_url":"https://api.github.com/users/phutchins/gists{/gist_id}","starred_url":"https://api.github.com/users/phutchins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phutchins/subscriptions","organizations_url":"https://api.github.com/users/phutchins/orgs","repos_url":"https://api.github.com/users/phutchins/repos","events_url":"https://api.github.com/users/phutchins/events{/privacy}","received_events_url":"https://api.github.com/users/phutchins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phutchins/pipo","description":"Secure end to end client side encryption chat","fork":false,"url":"https://api.github.com/repos/phutchins/pipo","forks_url":"https://api.github.com/repos/phutchins/pipo/forks","keys_url":"https://api.github.com/repos/phutchins/pipo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phutchins/pipo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phutchins/pipo/teams","hooks_url":"https://api.github.com/repos/phutchins/pipo/hooks","issue_events_url":"https://api.github.com/repos/phutchins/pipo/issues/events{/number}","events_url":"https://api.github.com/repos/phutchins/pipo/events","assignees_url":"https://api.github.com/repos/phutchins/pipo/assignees{/user}","branches_url":"https://api.github.com/repos/phutchins/pipo/branches{/branch}","tags_url":"https://api.github.com/repos/phutchins/pipo/tags","blobs_url":"https://api.github.com/repos/phutchins/pipo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phutchins/pipo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phutchins/pipo/git/refs{/sha}","trees_url":"https://api.github.com/repos/phutchins/pipo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phutchins/pipo/statuses/{sha}","languages_url":"https://api.github.com/repos/phutchins/pipo/languages","stargazers_url":"https://api.github.com/repos/phutchins/pipo/stargazers","contributors_url":"https://api.github.com/repos/phutchins/pipo/contributors","subscribers_url":"https://api.github.com/repos/phutchins/pipo/subscribers","subscription_url":"https://api.github.com/repos/phutchins/pipo/subscription","commits_url":"https://api.github.com/repos/phutchins/pipo/commits{/sha}","git_commits_url":"https://api.github.com/repos/phutchins/pipo/git/commits{/sha}","comments_url":"https://api.github.com/repos/phutchins/pipo/comments{/number}","issue_comment_url":"https://api.github.com/repos/phutchins/pipo/issues/comments{/number}","contents_url":"https://api.github.com/repos/phutchins/pipo/contents/{+path}","compare_url":"https://api.github.com/repos/phutchins/pipo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phutchins/pipo/merges","archive_url":"https://api.github.com/repos/phutchins/pipo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phutchins/pipo/downloads","issues_url":"https://api.github.com/repos/phutchins/pipo/issues{/number}","pulls_url":"https://api.github.com/repos/phutchins/pipo/pulls{/number}","milestones_url":"https://api.github.com/repos/phutchins/pipo/milestones{/number}","notifications_url":"https://api.github.com/repos/phutchins/pipo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phutchins/pipo/labels{/name}","releases_url":"https://api.github.com/repos/phutchins/pipo/releases{/id}","created_at":"2015-05-07T17:28:33Z","updated_at":"2015-05-14T14:45:59Z","pushed_at":"2015-06-08T13:29:28Z","git_url":"git://github.com/phutchins/pipo.git","ssh_url":"git@github.com:phutchins/pipo.git","clone_url":"https://github.com/phutchins/pipo.git","svn_url":"https://github.com/phutchins/pipo","homepage":null,"size":15093,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/12"},"html":{"href":"https://github.com/phutchins/pipo/pull/12"},"issue":{"href":"https://api.github.com/repos/phutchins/pipo/issues/12"},"comments":{"href":"https://api.github.com/repos/phutchins/pipo/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phutchins/pipo/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/phutchins/pipo/statuses/a9de22287d0c9e58b5b5ae3f6e7a86544fdd2385"}}}}