{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/43254985","id":43254985,"diff_hunk":"@@ -1,51 +1,46 @@\n \n-from openerp.osv import fields, osv\n+from odoo import api, fields, models\n \n-class website_config_settings(osv.osv_memory):\n+\n+class WebsiteConfigSettings(models.TransientModel):\n     _name = 'website.config.settings'\n     _inherit = 'res.config.settings'\n \n-    _columns = {\n-        'website_id': fields.many2one('website', string=\"website\", required=True),\n-        'website_name': fields.related('website_id', 'name', type=\"char\", string=\"Website Name\"),\n-\n-        'language_ids': fields.related('website_id', 'language_ids', type='many2many', relation='res.lang', string='Languages'),\n-        'default_lang_id': fields.related('website_id', 'default_lang_id', type='many2one', relation='res.lang', string='Default language'),\n-        'default_lang_code': fields.related('website_id', 'default_lang_code', type=\"char\", string=\"Default language code\"),\n-        'google_analytics_key': fields.related('website_id', 'google_analytics_key', type=\"char\", string='Google Analytics Key'),\n-        \n-        'social_twitter': fields.related('website_id', 'social_twitter', type=\"char\", string='Twitter Account'),\n-        'social_facebook': fields.related('website_id', 'social_facebook', type=\"char\", string='Facebook Account'),\n-        'social_github': fields.related('website_id', 'social_github', type=\"char\", string='GitHub Account'),\n-        'social_linkedin': fields.related('website_id', 'social_linkedin', type=\"char\", string='LinkedIn Account'),\n-        'social_youtube': fields.related('website_id', 'social_youtube', type=\"char\", string='Youtube Account'),\n-        'social_googleplus': fields.related('website_id', 'social_googleplus', type=\"char\", string='Google+ Account'),\n-        'compress_html': fields.related('website_id', 'compress_html', type=\"boolean\", string='Compress rendered HTML for a better Google PageSpeed result'),\n-        'cdn_activated': fields.related('website_id', 'cdn_activated', type=\"boolean\", string='Use a Content Delivery Network (CDN)'),\n-        'cdn_url': fields.related('website_id', 'cdn_url', type=\"char\", string='CDN Base URL'),\n-        'cdn_filters': fields.related('website_id', 'cdn_filters', type=\"text\", string='CDN Filters'),\n-        'module_website_form_editor': fields.boolean(\"Form builder: create and customize forms\"),\n-        'module_website_version': fields.boolean(\"A/B testing and versioning\"),\n-    }\n-\n-    def on_change_website_id(self, cr, uid, ids, website_id, context=None):\n-        if not website_id:\n-            return {'value': {}}\n-        website_data = self.pool.get('website').read(cr, uid, [website_id], [], context=context)[0]\n-        values = {'website_name': website_data['name']}\n-        for fname, v in website_data.items():\n-            if fname in self._columns:\n-                values[fname] = v[0] if v and self._columns[fname]._type == 'many2one' else v\n-        return {'value' : values}\n-\n-    # FIXME in trunk for god sake. Change the fields above to fields.char instead of fields.related, \n+    website_id = fields.Many2one('website', string=\"website\", required=True, default=lambda self: self.env['website'].search([])[0].id)\n+    website_name = fields.Char(related='website_id.name', string=\"Website Name\")\n+\n+    language_ids = fields.Many2many(related='website_id.language_ids', relation='res.lang', string='Languages')\n+    default_lang_id = fields.Many2one(related='website_id.default_lang_id', relation='res.lang', string='Default language')\n+    default_lang_code = fields.Char(related='website_id.default_lang_code', string=\"Default language code\")\n+    google_analytics_key = fields.Char(related='website_id.google_analytics_key', string='Google Analytics Key')\n+\n+    social_twitter = fields.Char(related='website_id.social_twitter', string='Twitter Account')\n+    social_facebook = fields.Char(related='website_id.social_facebook', string='Facebook Account')\n+    social_github = fields.Char(related='website_id.social_github', string='GitHub Account')\n+    social_linkedin = fields.Char(related='website_id.social_linkedin', string='LinkedIn Account')\n+    social_youtube = fields.Char(related='website_id.social_youtube', string='Youtube Account')\n+    social_googleplus = fields.Char(related='website_id.social_googleplus', string='Google+ Account')\n+    compress_html = fields.Boolean(related='website_id.compress_html', string='Compress rendered HTML for a better Google PageSpeed result')\n+    cdn_activated = fields.Boolean(related='website_id.cdn_activated', string='Use a Content Delivery Network (CDN)')\n+    cdn_url = fields.Char(related='website_id.cdn_url', string='CDN Base URL')\n+    cdn_filters = fields.Text(related='website_id.cdn_filters', string='CDN Filters')\n+    module_website_form_editor = fields.Boolean(string=\"Website form builder\")\n+    module_website_version = fields.Boolean(string=\"Website A/B testing and versioning\")\n+\n+    @api.onchange('website_id')\n+    def on_change_website_id(self):","path":"addons/website/models/res_config.py","position":67,"original_position":67,"commit_id":"343cfa5f986d582ceef32a709b78f483e94057d5","original_commit_id":"5365faddbf115dd153e242bb61c5ad0be02e5244","user":{"login":"mba-odoo","id":7599764,"avatar_url":"https://avatars.githubusercontent.com/u/7599764?v=3","gravatar_id":"","url":"https://api.github.com/users/mba-odoo","html_url":"https://github.com/mba-odoo","followers_url":"https://api.github.com/users/mba-odoo/followers","following_url":"https://api.github.com/users/mba-odoo/following{/other_user}","gists_url":"https://api.github.com/users/mba-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mba-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mba-odoo/subscriptions","organizations_url":"https://api.github.com/users/mba-odoo/orgs","repos_url":"https://api.github.com/users/mba-odoo/repos","events_url":"https://api.github.com/users/mba-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/mba-odoo/received_events","type":"User","site_admin":false},"body":"Hello @hmo-odoo ,\r\nit's used onchange of website_id(many2one with website model) need to set all fields of website_config_setting and there might be the field exist or may be many2one or simple so need to set all the fields value based on many2one of website_id so need this stuff.","created_at":"2015-10-28T13:34:20Z","updated_at":"2015-10-28T13:34:20Z","html_url":"https://github.com/odoo/odoo/pull/8230#discussion_r43254985","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/8230","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/43254985"},"html":{"href":"https://github.com/odoo/odoo/pull/8230#discussion_r43254985"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/8230"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/8230","id":43276732,"html_url":"https://github.com/odoo/odoo/pull/8230","diff_url":"https://github.com/odoo/odoo/pull/8230.diff","patch_url":"https://github.com/odoo/odoo/pull/8230.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/8230","number":8230,"state":"open","locked":false,"title":"[website] new API migration","user":{"login":"mba-odoo","id":7599764,"avatar_url":"https://avatars.githubusercontent.com/u/7599764?v=3","gravatar_id":"","url":"https://api.github.com/users/mba-odoo","html_url":"https://github.com/mba-odoo","followers_url":"https://api.github.com/users/mba-odoo/followers","following_url":"https://api.github.com/users/mba-odoo/following{/other_user}","gists_url":"https://api.github.com/users/mba-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mba-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mba-odoo/subscriptions","organizations_url":"https://api.github.com/users/mba-odoo/orgs","repos_url":"https://api.github.com/users/mba-odoo/repos","events_url":"https://api.github.com/users/mba-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/mba-odoo/received_events","type":"User","site_admin":false},"body":"Task: https://www.odoo.com/web#id=12131&view_type=form&model=project.task&menu_id=3942&action=327\r\nPad: https://pad.odoo.com/p/r.eLvFy2wnfbAiJdxS","created_at":"2015-08-25T11:56:17Z","updated_at":"2015-10-28T13:34:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76cca61103e48ebbbc8559f1ac43a4799f25a53","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/8230/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/8230/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/8230/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/343cfa5f986d582ceef32a709b78f483e94057d5","head":{"label":"odoo-dev:master-website-new-api-mba","ref":"master-website-new-api-mba","sha":"343cfa5f986d582ceef32a709b78f483e94057d5","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","created_at":"2014-05-16T11:16:19Z","updated_at":"2015-10-13T05:17:28Z","pushed_at":"2015-10-28T13:26:48Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1451055,"stargazers_count":62,"watchers_count":62,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":0,"forks":24,"open_issues":0,"watchers":62,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"cc552c008bb78be930937b5291853216265811e4","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","created_at":"2014-05-13T15:38:58Z","updated_at":"2015-10-28T03:15:56Z","pushed_at":"2015-10-28T13:34:04Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1605458,"stargazers_count":3298,"watchers_count":3298,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2936,"mirror_url":null,"open_issues_count":2701,"forks":2936,"open_issues":2701,"watchers":3298,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/8230"},"html":{"href":"https://github.com/odoo/odoo/pull/8230"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/8230"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/8230/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/8230/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/8230/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/343cfa5f986d582ceef32a709b78f483e94057d5"}}}}