{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/Wikia/chat/pulls/12","id":33628235,"html_url":"https://github.com/Wikia/chat/pull/12","diff_url":"https://github.com/Wikia/chat/pull/12.diff","patch_url":"https://github.com/Wikia/chat/pull/12.patch","issue_url":"https://api.github.com/repos/Wikia/chat/issues/12","number":12,"state":"closed","locked":false,"title":"Soc 547","user":{"login":"SeanColombo","id":237336,"avatar_url":"https://avatars.githubusercontent.com/u/237336?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanColombo","html_url":"https://github.com/SeanColombo","followers_url":"https://api.github.com/users/SeanColombo/followers","following_url":"https://api.github.com/users/SeanColombo/following{/other_user}","gists_url":"https://api.github.com/users/SeanColombo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanColombo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanColombo/subscriptions","organizations_url":"https://api.github.com/users/SeanColombo/orgs","repos_url":"https://api.github.com/users/SeanColombo/repos","events_url":"https://api.github.com/users/SeanColombo/events{/privacy}","received_events_url":"https://api.github.com/users/SeanColombo/received_events","type":"User","site_admin":false},"body":"This pull request will fix the bug which allowed users to reconnect from the same window, for up to 15 minutes after being banned from chat.\r\n\r\nThe problem was that an in-memory cache of authentication data was not being purged correctly when users with spaces or unicode in their username were banned. The issue has been fixed to no-longer be dependent upon username-encoding.\r\n\r\nThe exploit was reproduced in production and development, and then I deployed the fix and verified it in development also.  See screenshots on SOC-547.","created_at":"2015-04-19T23:37:32Z","updated_at":"2015-04-21T18:01:33Z","closed_at":"2015-04-21T18:01:33Z","merged_at":"2015-04-21T18:01:33Z","merge_commit_sha":"eeea69f5d1f71c4f65b82d4b1696e7b3aa335fa2","assignee":{"login":"owend","id":89825,"avatar_url":"https://avatars.githubusercontent.com/u/89825?v=3","gravatar_id":"","url":"https://api.github.com/users/owend","html_url":"https://github.com/owend","followers_url":"https://api.github.com/users/owend/followers","following_url":"https://api.github.com/users/owend/following{/other_user}","gists_url":"https://api.github.com/users/owend/gists{/gist_id}","starred_url":"https://api.github.com/users/owend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owend/subscriptions","organizations_url":"https://api.github.com/users/owend/orgs","repos_url":"https://api.github.com/users/owend/repos","events_url":"https://api.github.com/users/owend/events{/privacy}","received_events_url":"https://api.github.com/users/owend/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/chat/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Wikia/chat/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Wikia/chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/chat/issues/12/comments","statuses_url":"https://api.github.com/repos/Wikia/chat/statuses/0571b0f91acf796e8f08efa7386c0a46dc33fdb1","head":{"label":"Wikia:SOC-547","ref":"SOC-547","sha":"0571b0f91acf796e8f08efa7386c0a46dc33fdb1","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":23160247,"name":"chat","full_name":"Wikia/chat","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/chat","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/chat","forks_url":"https://api.github.com/repos/Wikia/chat/forks","keys_url":"https://api.github.com/repos/Wikia/chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/chat/teams","hooks_url":"https://api.github.com/repos/Wikia/chat/hooks","issue_events_url":"https://api.github.com/repos/Wikia/chat/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/chat/events","assignees_url":"https://api.github.com/repos/Wikia/chat/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/chat/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/chat/tags","blobs_url":"https://api.github.com/repos/Wikia/chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/chat/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/chat/languages","stargazers_url":"https://api.github.com/repos/Wikia/chat/stargazers","contributors_url":"https://api.github.com/repos/Wikia/chat/contributors","subscribers_url":"https://api.github.com/repos/Wikia/chat/subscribers","subscription_url":"https://api.github.com/repos/Wikia/chat/subscription","commits_url":"https://api.github.com/repos/Wikia/chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/chat/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/chat/merges","archive_url":"https://api.github.com/repos/Wikia/chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/chat/downloads","issues_url":"https://api.github.com/repos/Wikia/chat/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/chat/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/chat/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/chat/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/chat/releases{/id}","created_at":"2014-08-20T18:52:00Z","updated_at":"2015-04-17T04:35:09Z","pushed_at":"2015-04-21T18:01:33Z","git_url":"git://github.com/Wikia/chat.git","ssh_url":"git@github.com:Wikia/chat.git","clone_url":"https://github.com/Wikia/chat.git","svn_url":"https://github.com/Wikia/chat","homepage":null,"size":496,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"Wikia:release-4","ref":"release-4","sha":"de86bbadd646a53eefcc16761515f4e724520efc","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":23160247,"name":"chat","full_name":"Wikia/chat","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/chat","description":"","fork":false,"url":"https://api.github.com/repos/Wikia/chat","forks_url":"https://api.github.com/repos/Wikia/chat/forks","keys_url":"https://api.github.com/repos/Wikia/chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/chat/teams","hooks_url":"https://api.github.com/repos/Wikia/chat/hooks","issue_events_url":"https://api.github.com/repos/Wikia/chat/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/chat/events","assignees_url":"https://api.github.com/repos/Wikia/chat/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/chat/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/chat/tags","blobs_url":"https://api.github.com/repos/Wikia/chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/chat/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/chat/languages","stargazers_url":"https://api.github.com/repos/Wikia/chat/stargazers","contributors_url":"https://api.github.com/repos/Wikia/chat/contributors","subscribers_url":"https://api.github.com/repos/Wikia/chat/subscribers","subscription_url":"https://api.github.com/repos/Wikia/chat/subscription","commits_url":"https://api.github.com/repos/Wikia/chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/chat/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/chat/merges","archive_url":"https://api.github.com/repos/Wikia/chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/chat/downloads","issues_url":"https://api.github.com/repos/Wikia/chat/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/chat/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/chat/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/chat/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/chat/releases{/id}","created_at":"2014-08-20T18:52:00Z","updated_at":"2015-04-17T04:35:09Z","pushed_at":"2015-04-21T18:01:33Z","git_url":"git://github.com/Wikia/chat.git","ssh_url":"git@github.com:Wikia/chat.git","clone_url":"https://github.com/Wikia/chat.git","svn_url":"https://github.com/Wikia/chat","homepage":null,"size":496,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/chat/pulls/12"},"html":{"href":"https://github.com/Wikia/chat/pull/12"},"issue":{"href":"https://api.github.com/repos/Wikia/chat/issues/12"},"comments":{"href":"https://api.github.com/repos/Wikia/chat/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/chat/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/chat/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/chat/statuses/0571b0f91acf796e8f08efa7386c0a46dc33fdb1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"owend","id":89825,"avatar_url":"https://avatars.githubusercontent.com/u/89825?v=3","gravatar_id":"","url":"https://api.github.com/users/owend","html_url":"https://github.com/owend","followers_url":"https://api.github.com/users/owend/followers","following_url":"https://api.github.com/users/owend/following{/other_user}","gists_url":"https://api.github.com/users/owend/gists{/gist_id}","starred_url":"https://api.github.com/users/owend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owend/subscriptions","organizations_url":"https://api.github.com/users/owend/orgs","repos_url":"https://api.github.com/users/owend/repos","events_url":"https://api.github.com/users/owend/events{/privacy}","received_events_url":"https://api.github.com/users/owend/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":10,"additions":33,"deletions":14,"changed_files":2}}