{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/4097","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4097/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4097/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4097/events","html_url":"https://github.com/puppetlabs/puppet/pull/4097","id":96314202,"number":4097,"title":"PUP-4918 - Updated Red Hat logrotate and init scripts","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/puppetlabs/puppet/labels/PR%20Triage","name":"PR Triage","color":"eb6420"},{"url":"https://api.github.com/repos/puppetlabs/puppet/labels/Triaged","name":"Triaged","color":"fef2c0"},{"url":"https://api.github.com/repos/puppetlabs/puppet/labels/Unix","name":"Unix","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-07-21T13:26:55Z","updated_at":"2015-08-18T18:08:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4097","html_url":"https://github.com/puppetlabs/puppet/pull/4097","diff_url":"https://github.com/puppetlabs/puppet/pull/4097.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4097.patch"},"body":"This patch updates logrotate script and aligns it what is defined in\ndefaults.rb, specifically:\n\nhttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/defaults.rb#L1036-L1046\n\nand\n\nhttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/defaults.rb#L1258-L1274\n\nBecause of logrotate and puppet during restart were both \"fighting\" for correct\nfile permissions, this was causing issues with SELinux. Also fixed paths which\nhas been incorrect for Fedora/RHEL systems (`/var/log/puppetlabs` vs\n`/var/log/puppet`). It contains both now which seems to work just fine.\n\nI am not adding logrotate scriplet for master tho as I don't know if it\nsupports signals. When running master under webrick one should not expect fully\nworking log rotation tho. Open for discussion.\n\nAs part of this patch, I am also updating Red Hat startup scripts:\n\n* RHEL6 traditional UNIX-like \"reload\" command was actually sending HUP signal\n and therefore restarting daemon instead correct USR1\n* RHEL7 systemd unit was extended with \"reload\" command using USR1 signal"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/132301962","html_url":"https://github.com/puppetlabs/puppet/pull/4097#issuecomment-132301962","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4097","id":132301962,"user":{"login":"haus","id":98408,"avatar_url":"https://avatars.githubusercontent.com/u/98408?v=3","gravatar_id":"","url":"https://api.github.com/users/haus","html_url":"https://github.com/haus","followers_url":"https://api.github.com/users/haus/followers","following_url":"https://api.github.com/users/haus/following{/other_user}","gists_url":"https://api.github.com/users/haus/gists{/gist_id}","starred_url":"https://api.github.com/users/haus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haus/subscriptions","organizations_url":"https://api.github.com/users/haus/orgs","repos_url":"https://api.github.com/users/haus/repos","events_url":"https://api.github.com/users/haus/events{/privacy}","received_events_url":"https://api.github.com/users/haus/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T18:08:34Z","updated_at":"2015-08-18T18:08:34Z","body":"This looks reasonable to me."}}