{"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57","id":41968032,"html_url":"https://github.com/jenkinsci/envinject-plugin/pull/57","diff_url":"https://github.com/jenkinsci/envinject-plugin/pull/57.diff","patch_url":"https://github.com/jenkinsci/envinject-plugin/pull/57.patch","issue_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/57","number":57,"state":"closed","locked":false,"title":"[JENKINS-29867] - Permissions engine + global option for disabling the Injected vars","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"body":"https://issues.jenkins-ci.org/browse/JENKINS-29867\r\n\r\nIn several cases Jenkins users may expose passwords as a plain text in \"Injected variables\" action (e.g. password reassigning for a non-sensitive variable). It may make sense to add an option, which completely prohibits the exposure of environment variables.\r\n\r\n- [x] - ViewVars permissions\r\n- [x] - Global option, which allows to hide envinject actions\r\n- [x] - Unit tests\r\n- [x] - Bump the dependency on https://github.com/jenkinsci/envinject-lib after the release of https://github.com/jenkinsci/envinject-lib/pull/6\r\n\r\nDepends on https://github.com/jenkinsci/envinject-lib/pull/6\r\n\r\n@reviewbybees","created_at":"2015-08-09T09:50:22Z","updated_at":"2015-08-16T23:11:59Z","closed_at":"2015-08-16T23:11:58Z","merged_at":"2015-08-16T23:11:58Z","merge_commit_sha":"97caf85f194932eea74209ddfea6465617ab1538","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/57/comments","statuses_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/statuses/40a2c53c4d98e1e12fc084312d8db9ecf5d2fc14","head":{"label":"oleg-nenashev:JENKINS-29867-hide-envvars","ref":"JENKINS-29867-hide-envvars","sha":"40a2c53c4d98e1e12fc084312d8db9ecf5d2fc14","user":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"repo":{"id":32486099,"name":"envinject-plugin","full_name":"oleg-nenashev/envinject-plugin","owner":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oleg-nenashev/envinject-plugin","description":"","fork":true,"url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin","forks_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/forks","keys_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/teams","hooks_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/hooks","issue_events_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/events","assignees_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/tags","blobs_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/languages","stargazers_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/stargazers","contributors_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/contributors","subscribers_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/subscribers","subscription_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/subscription","commits_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/merges","archive_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/downloads","issues_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/labels{/name}","releases_url":"https://api.github.com/repos/oleg-nenashev/envinject-plugin/releases{/id}","created_at":"2015-03-18T21:46:06Z","updated_at":"2015-03-18T21:46:07Z","pushed_at":"2015-08-16T23:03:42Z","git_url":"git://github.com/oleg-nenashev/envinject-plugin.git","ssh_url":"git@github.com:oleg-nenashev/envinject-plugin.git","clone_url":"https://github.com/oleg-nenashev/envinject-plugin.git","svn_url":"https://github.com/oleg-nenashev/envinject-plugin","homepage":"","size":771,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8ba504042472bd09887b169f487f9f2daa3984b0","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":2059304,"name":"envinject-plugin","full_name":"jenkinsci/envinject-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/envinject-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/envinject-plugin","forks_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/envinject-plugin/releases{/id}","created_at":"2011-07-16T20:09:41Z","updated_at":"2015-08-12T03:20:05Z","pushed_at":"2015-08-16T23:11:59Z","git_url":"git://github.com/jenkinsci/envinject-plugin.git","ssh_url":"git@github.com:jenkinsci/envinject-plugin.git","clone_url":"https://github.com/jenkinsci/envinject-plugin.git","svn_url":"https://github.com/jenkinsci/envinject-plugin","homepage":"","size":1845,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":8,"forks":62,"open_issues":8,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57"},"html":{"href":"https://github.com/jenkinsci/envinject-plugin/pull/57"},"issue":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/57"},"comments":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/envinject-plugin/statuses/40a2c53c4d98e1e12fc084312d8db9ecf5d2fc14"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oleg-nenashev","id":3000480,"avatar_url":"https://avatars.githubusercontent.com/u/3000480?v=3","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false},"comments":10,"review_comments":72,"commits":1,"additions":545,"deletions":2,"changed_files":13}}