{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/comments/45357235","id":45357235,"diff_hunk":"@@ -448,7 +448,17 @@ func newWatcher(kapi client.KeysAPI, path string, socksProxy string, etcdPeers [\n \t\tfor {\n \t\t\t_, err := watcher.Next(context.Background())\n \t\t\tif err != nil {\n-\t\t\t\tlog.Printf(\"watch failed %v, sleeping for 1s\\n\", err.Error())\n+\t\t\t\tif err == context.Canceled {\n+\t\t\t\t\tlog.Println(\"context cancelled error\")\n+\t\t\t\t} else if err == context.DeadlineExceeded {\n+\t\t\t\t\tlog.Println(\"deadline exceeded error\")","path":"main.go","position":8,"original_position":8,"commit_id":"07fcd8041bcc133ff54fb2cd02c144a15b810da9","original_commit_id":"07fcd8041bcc133ff54fb2cd02c144a15b810da9","user":{"login":"Zapadlo","id":1801067,"avatar_url":"https://avatars.githubusercontent.com/u/1801067?v=3","gravatar_id":"","url":"https://api.github.com/users/Zapadlo","html_url":"https://github.com/Zapadlo","followers_url":"https://api.github.com/users/Zapadlo/followers","following_url":"https://api.github.com/users/Zapadlo/following{/other_user}","gists_url":"https://api.github.com/users/Zapadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Zapadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zapadlo/subscriptions","organizations_url":"https://api.github.com/users/Zapadlo/orgs","repos_url":"https://api.github.com/users/Zapadlo/repos","events_url":"https://api.github.com/users/Zapadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Zapadlo/received_events","type":"User","site_admin":false},"body":"Why not just print the error here?","created_at":"2015-11-19T15:48:29Z","updated_at":"2015-11-19T15:48:29Z","html_url":"https://github.com/Financial-Times/vulcan-config-builder/pull/1#discussion_r45357235","pull_request_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/comments/45357235"},"html":{"href":"https://github.com/Financial-Times/vulcan-config-builder/pull/1#discussion_r45357235"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1","id":51239066,"html_url":"https://github.com/Financial-Times/vulcan-config-builder/pull/1","diff_url":"https://github.com/Financial-Times/vulcan-config-builder/pull/1.diff","patch_url":"https://github.com/Financial-Times/vulcan-config-builder/pull/1.patch","issue_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/1","number":1,"state":"open","locked":false,"title":"better logging of error scenarios","user":{"login":"martingartonft","id":5197575,"avatar_url":"https://avatars.githubusercontent.com/u/5197575?v=3","gravatar_id":"","url":"https://api.github.com/users/martingartonft","html_url":"https://github.com/martingartonft","followers_url":"https://api.github.com/users/martingartonft/followers","following_url":"https://api.github.com/users/martingartonft/following{/other_user}","gists_url":"https://api.github.com/users/martingartonft/gists{/gist_id}","starred_url":"https://api.github.com/users/martingartonft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martingartonft/subscriptions","organizations_url":"https://api.github.com/users/martingartonft/orgs","repos_url":"https://api.github.com/users/martingartonft/repos","events_url":"https://api.github.com/users/martingartonft/events{/privacy}","received_events_url":"https://api.github.com/users/martingartonft/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-19T15:44:41Z","updated_at":"2015-11-19T15:48:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"478a65d07d2bdb62c87c6788d0f8b4420805c3bd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/1/comments","statuses_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/statuses/07fcd8041bcc133ff54fb2cd02c144a15b810da9","head":{"label":"Financial-Times:betterErrorLogging","ref":"betterErrorLogging","sha":"07fcd8041bcc133ff54fb2cd02c144a15b810da9","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":43962974,"name":"vulcan-config-builder","full_name":"Financial-Times/vulcan-config-builder","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/vulcan-config-builder","description":"","fork":false,"url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder","forks_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/forks","keys_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/teams","hooks_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/events","assignees_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/tags","blobs_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/subscription","commits_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/merges","archive_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/downloads","issues_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/releases{/id}","created_at":"2015-10-09T15:07:20Z","updated_at":"2015-11-02T19:11:31Z","pushed_at":"2015-11-19T15:44:42Z","git_url":"git://github.com/Financial-Times/vulcan-config-builder.git","ssh_url":"git@github.com:Financial-Times/vulcan-config-builder.git","clone_url":"https://github.com/Financial-Times/vulcan-config-builder.git","svn_url":"https://github.com/Financial-Times/vulcan-config-builder","homepage":null,"size":16,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"49dd7333240a71e7b379fa7f8aa50e7e433bdb3c","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":43962974,"name":"vulcan-config-builder","full_name":"Financial-Times/vulcan-config-builder","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/vulcan-config-builder","description":"","fork":false,"url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder","forks_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/forks","keys_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/teams","hooks_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/events","assignees_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/tags","blobs_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/subscription","commits_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/merges","archive_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/downloads","issues_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/releases{/id}","created_at":"2015-10-09T15:07:20Z","updated_at":"2015-11-02T19:11:31Z","pushed_at":"2015-11-19T15:44:42Z","git_url":"git://github.com/Financial-Times/vulcan-config-builder.git","ssh_url":"git@github.com:Financial-Times/vulcan-config-builder.git","clone_url":"https://github.com/Financial-Times/vulcan-config-builder.git","svn_url":"https://github.com/Financial-Times/vulcan-config-builder","homepage":null,"size":16,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1"},"html":{"href":"https://github.com/Financial-Times/vulcan-config-builder/pull/1"},"issue":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/1"},"comments":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/vulcan-config-builder/statuses/07fcd8041bcc133ff54fb2cd02c144a15b810da9"}}}}