{"action":"created","comment":{"url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/comments/42787835","id":42787835,"diff_hunk":"@@ -83,7 +94,6 @@ class BreakerActor (parentBreaker : ActorRef, breakerName : String) extends Acto\n             sender ! (new Error(\"Breaker trip\"), false)","path":"src/main/scala/Breaker/BreakerActor.scala","position":82,"original_position":82,"commit_id":"0107c1f3865deee48f16c2123b81378e487c722b","original_commit_id":"0107c1f3865deee48f16c2123b81378e487c722b","user":{"login":"tjadams","id":5125011,"avatar_url":"https://avatars.githubusercontent.com/u/5125011?v=3","gravatar_id":"","url":"https://api.github.com/users/tjadams","html_url":"https://github.com/tjadams","followers_url":"https://api.github.com/users/tjadams/followers","following_url":"https://api.github.com/users/tjadams/following{/other_user}","gists_url":"https://api.github.com/users/tjadams/gists{/gist_id}","starred_url":"https://api.github.com/users/tjadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjadams/subscriptions","organizations_url":"https://api.github.com/users/tjadams/orgs","repos_url":"https://api.github.com/users/tjadams/repos","events_url":"https://api.github.com/users/tjadams/events{/privacy}","received_events_url":"https://api.github.com/users/tjadams/received_events","type":"User","site_admin":false},"body":"This is not right. Double check the Node.js code at the `breaker.currentPower += request.power;` part. You'll see that even if it goes into the `if(breaker.powerAllocationList[...])` part then it will still go into the currentPower part. This code does not do that.","created_at":"2015-10-22T18:36:48Z","updated_at":"2015-10-22T18:36:48Z","html_url":"https://github.com/vpsinc/DCSimScala/pull/3#discussion_r42787835","pull_request_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/comments/42787835"},"html":{"href":"https://github.com/vpsinc/DCSimScala/pull/3#discussion_r42787835"},"pull_request":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3","id":48486132,"html_url":"https://github.com/vpsinc/DCSimScala/pull/3","diff_url":"https://github.com/vpsinc/DCSimScala/pull/3.diff","patch_url":"https://github.com/vpsinc/DCSimScala/pull/3.patch","issue_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/3","number":3,"state":"open","locked":false,"title":"Implement breaker","user":{"login":"elkanwang","id":4806046,"avatar_url":"https://avatars.githubusercontent.com/u/4806046?v=3","gravatar_id":"","url":"https://api.github.com/users/elkanwang","html_url":"https://github.com/elkanwang","followers_url":"https://api.github.com/users/elkanwang/followers","following_url":"https://api.github.com/users/elkanwang/following{/other_user}","gists_url":"https://api.github.com/users/elkanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/elkanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elkanwang/subscriptions","organizations_url":"https://api.github.com/users/elkanwang/orgs","repos_url":"https://api.github.com/users/elkanwang/repos","events_url":"https://api.github.com/users/elkanwang/events{/privacy}","received_events_url":"https://api.github.com/users/elkanwang/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-22T17:17:00Z","updated_at":"2015-10-22T18:36:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4c83d8b3ee4202966afe8ec9ee361fd53670116","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3/commits","review_comments_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3/comments","review_comment_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/3/comments","statuses_url":"https://api.github.com/repos/vpsinc/DCSimScala/statuses/0107c1f3865deee48f16c2123b81378e487c722b","head":{"label":"vpsinc:implementBreaker","ref":"implementBreaker","sha":"0107c1f3865deee48f16c2123b81378e487c722b","user":{"login":"vpsinc","id":7947106,"avatar_url":"https://avatars.githubusercontent.com/u/7947106?v=3","gravatar_id":"","url":"https://api.github.com/users/vpsinc","html_url":"https://github.com/vpsinc","followers_url":"https://api.github.com/users/vpsinc/followers","following_url":"https://api.github.com/users/vpsinc/following{/other_user}","gists_url":"https://api.github.com/users/vpsinc/gists{/gist_id}","starred_url":"https://api.github.com/users/vpsinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpsinc/subscriptions","organizations_url":"https://api.github.com/users/vpsinc/orgs","repos_url":"https://api.github.com/users/vpsinc/repos","events_url":"https://api.github.com/users/vpsinc/events{/privacy}","received_events_url":"https://api.github.com/users/vpsinc/received_events","type":"Organization","site_admin":false},"repo":{"id":44127359,"name":"DCSimScala","full_name":"vpsinc/DCSimScala","owner":{"login":"vpsinc","id":7947106,"avatar_url":"https://avatars.githubusercontent.com/u/7947106?v=3","gravatar_id":"","url":"https://api.github.com/users/vpsinc","html_url":"https://github.com/vpsinc","followers_url":"https://api.github.com/users/vpsinc/followers","following_url":"https://api.github.com/users/vpsinc/following{/other_user}","gists_url":"https://api.github.com/users/vpsinc/gists{/gist_id}","starred_url":"https://api.github.com/users/vpsinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpsinc/subscriptions","organizations_url":"https://api.github.com/users/vpsinc/orgs","repos_url":"https://api.github.com/users/vpsinc/repos","events_url":"https://api.github.com/users/vpsinc/events{/privacy}","received_events_url":"https://api.github.com/users/vpsinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vpsinc/DCSimScala","description":"Scala implementation of DCSim","fork":false,"url":"https://api.github.com/repos/vpsinc/DCSimScala","forks_url":"https://api.github.com/repos/vpsinc/DCSimScala/forks","keys_url":"https://api.github.com/repos/vpsinc/DCSimScala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpsinc/DCSimScala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpsinc/DCSimScala/teams","hooks_url":"https://api.github.com/repos/vpsinc/DCSimScala/hooks","issue_events_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/events{/number}","events_url":"https://api.github.com/repos/vpsinc/DCSimScala/events","assignees_url":"https://api.github.com/repos/vpsinc/DCSimScala/assignees{/user}","branches_url":"https://api.github.com/repos/vpsinc/DCSimScala/branches{/branch}","tags_url":"https://api.github.com/repos/vpsinc/DCSimScala/tags","blobs_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpsinc/DCSimScala/statuses/{sha}","languages_url":"https://api.github.com/repos/vpsinc/DCSimScala/languages","stargazers_url":"https://api.github.com/repos/vpsinc/DCSimScala/stargazers","contributors_url":"https://api.github.com/repos/vpsinc/DCSimScala/contributors","subscribers_url":"https://api.github.com/repos/vpsinc/DCSimScala/subscribers","subscription_url":"https://api.github.com/repos/vpsinc/DCSimScala/subscription","commits_url":"https://api.github.com/repos/vpsinc/DCSimScala/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpsinc/DCSimScala/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/comments{/number}","contents_url":"https://api.github.com/repos/vpsinc/DCSimScala/contents/{+path}","compare_url":"https://api.github.com/repos/vpsinc/DCSimScala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpsinc/DCSimScala/merges","archive_url":"https://api.github.com/repos/vpsinc/DCSimScala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpsinc/DCSimScala/downloads","issues_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues{/number}","pulls_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls{/number}","milestones_url":"https://api.github.com/repos/vpsinc/DCSimScala/milestones{/number}","notifications_url":"https://api.github.com/repos/vpsinc/DCSimScala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpsinc/DCSimScala/labels{/name}","releases_url":"https://api.github.com/repos/vpsinc/DCSimScala/releases{/id}","created_at":"2015-10-12T18:50:16Z","updated_at":"2015-10-12T19:00:07Z","pushed_at":"2015-10-22T17:42:12Z","git_url":"git://github.com/vpsinc/DCSimScala.git","ssh_url":"git@github.com:vpsinc/DCSimScala.git","clone_url":"https://github.com/vpsinc/DCSimScala.git","svn_url":"https://github.com/vpsinc/DCSimScala","homepage":null,"size":1264,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"vpsinc:master","ref":"master","sha":"3c717db055d3c1d8904189b54b6bc87a25af0cce","user":{"login":"vpsinc","id":7947106,"avatar_url":"https://avatars.githubusercontent.com/u/7947106?v=3","gravatar_id":"","url":"https://api.github.com/users/vpsinc","html_url":"https://github.com/vpsinc","followers_url":"https://api.github.com/users/vpsinc/followers","following_url":"https://api.github.com/users/vpsinc/following{/other_user}","gists_url":"https://api.github.com/users/vpsinc/gists{/gist_id}","starred_url":"https://api.github.com/users/vpsinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpsinc/subscriptions","organizations_url":"https://api.github.com/users/vpsinc/orgs","repos_url":"https://api.github.com/users/vpsinc/repos","events_url":"https://api.github.com/users/vpsinc/events{/privacy}","received_events_url":"https://api.github.com/users/vpsinc/received_events","type":"Organization","site_admin":false},"repo":{"id":44127359,"name":"DCSimScala","full_name":"vpsinc/DCSimScala","owner":{"login":"vpsinc","id":7947106,"avatar_url":"https://avatars.githubusercontent.com/u/7947106?v=3","gravatar_id":"","url":"https://api.github.com/users/vpsinc","html_url":"https://github.com/vpsinc","followers_url":"https://api.github.com/users/vpsinc/followers","following_url":"https://api.github.com/users/vpsinc/following{/other_user}","gists_url":"https://api.github.com/users/vpsinc/gists{/gist_id}","starred_url":"https://api.github.com/users/vpsinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpsinc/subscriptions","organizations_url":"https://api.github.com/users/vpsinc/orgs","repos_url":"https://api.github.com/users/vpsinc/repos","events_url":"https://api.github.com/users/vpsinc/events{/privacy}","received_events_url":"https://api.github.com/users/vpsinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vpsinc/DCSimScala","description":"Scala implementation of DCSim","fork":false,"url":"https://api.github.com/repos/vpsinc/DCSimScala","forks_url":"https://api.github.com/repos/vpsinc/DCSimScala/forks","keys_url":"https://api.github.com/repos/vpsinc/DCSimScala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpsinc/DCSimScala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpsinc/DCSimScala/teams","hooks_url":"https://api.github.com/repos/vpsinc/DCSimScala/hooks","issue_events_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/events{/number}","events_url":"https://api.github.com/repos/vpsinc/DCSimScala/events","assignees_url":"https://api.github.com/repos/vpsinc/DCSimScala/assignees{/user}","branches_url":"https://api.github.com/repos/vpsinc/DCSimScala/branches{/branch}","tags_url":"https://api.github.com/repos/vpsinc/DCSimScala/tags","blobs_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpsinc/DCSimScala/statuses/{sha}","languages_url":"https://api.github.com/repos/vpsinc/DCSimScala/languages","stargazers_url":"https://api.github.com/repos/vpsinc/DCSimScala/stargazers","contributors_url":"https://api.github.com/repos/vpsinc/DCSimScala/contributors","subscribers_url":"https://api.github.com/repos/vpsinc/DCSimScala/subscribers","subscription_url":"https://api.github.com/repos/vpsinc/DCSimScala/subscription","commits_url":"https://api.github.com/repos/vpsinc/DCSimScala/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpsinc/DCSimScala/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpsinc/DCSimScala/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues/comments{/number}","contents_url":"https://api.github.com/repos/vpsinc/DCSimScala/contents/{+path}","compare_url":"https://api.github.com/repos/vpsinc/DCSimScala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpsinc/DCSimScala/merges","archive_url":"https://api.github.com/repos/vpsinc/DCSimScala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpsinc/DCSimScala/downloads","issues_url":"https://api.github.com/repos/vpsinc/DCSimScala/issues{/number}","pulls_url":"https://api.github.com/repos/vpsinc/DCSimScala/pulls{/number}","milestones_url":"https://api.github.com/repos/vpsinc/DCSimScala/milestones{/number}","notifications_url":"https://api.github.com/repos/vpsinc/DCSimScala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpsinc/DCSimScala/labels{/name}","releases_url":"https://api.github.com/repos/vpsinc/DCSimScala/releases{/id}","created_at":"2015-10-12T18:50:16Z","updated_at":"2015-10-12T19:00:07Z","pushed_at":"2015-10-22T17:42:12Z","git_url":"git://github.com/vpsinc/DCSimScala.git","ssh_url":"git@github.com:vpsinc/DCSimScala.git","clone_url":"https://github.com/vpsinc/DCSimScala.git","svn_url":"https://github.com/vpsinc/DCSimScala","homepage":null,"size":1264,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3"},"html":{"href":"https://github.com/vpsinc/DCSimScala/pull/3"},"issue":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/issues/3"},"comments":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/vpsinc/DCSimScala/statuses/0107c1f3865deee48f16c2123b81378e487c722b"}}}}