{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/16659","labels_url":"https://api.github.com/repos/docker/docker/issues/16659/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/16659/comments","events_url":"https://api.github.com/repos/docker/docker/issues/16659/events","html_url":"https://github.com/docker/docker/pull/16659","id":108929656,"number":16659,"title":"Revert context","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/distribution","name":"group/distribution","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-29T18:26:40Z","updated_at":"2015-09-29T18:28:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/16659","html_url":"https://github.com/docker/docker/pull/16659","diff_url":"https://github.com/docker/docker/pull/16659.diff","patch_url":"https://github.com/docker/docker/pull/16659.patch"},"body":"Although having a request ID available throughout the codebase is very\r\nvaluable, the impact of requiring a Context as an argument to every\r\nfunction in the codepath of an API request, is too significant and was\r\nnot properly understood at the time of the review.\r\n\r\nFurthermore, mixing API-layer code with non-API-layer code makes the\r\nlatter usable only by API-layer code (one that has a notion of Context).\r\n\r\nPS: the following files had simple conflicts but make sure you review them properly:\r\n- api/server/container.go\r\n- builder/internals.go\r\n- daemon/container_unix.go\r\n- daemon/create.go"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/144147269","html_url":"https://github.com/docker/docker/pull/16659#issuecomment-144147269","issue_url":"https://api.github.com/repos/docker/docker/issues/16659","id":144147269,"user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T18:28:16Z","updated_at":"2015-09-29T18:28:16Z","body":"Ping @docker/core-maintainers @stevvooe "}}