{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments/46421025","id":46421025,"diff_hunk":"@@ -236,13 +300,13 @@ imports:\n `\n \n func TestSharedImport(t *testing.T) {\n-\tfinalImports := []*ImportFile{\n-\t\t&ImportFile{Name: \"http://my-fake-url\", Content: \"my-content\"},\n-\t\t&ImportFile{Name: \"http://my-fake-url1\", Content: \"my-content-1\"},\n-\t\t&ImportFile{Name: \"schema-import\", Content: \"schema-import\"},\n-\t\t&ImportFile{Name: \"schema-import-1\", Content: \"schema-import\"},\n-\t\t&ImportFile{Name: \"http://my-fake-url.schema\", Content: schema1},\n-\t\t&ImportFile{Name: \"http://my-fake-url1.schema\", Content: schema2},\n+\tfinalImports := []*common.ImportFile{\n+\t\t&common.ImportFile{Name: \"http://my-fake-url\", Path: \"http://my-fake-url\", Content: \"my-content\"},","path":"manager/manager/typeresolver_test.go","position":168,"original_position":168,"commit_id":"711fc7b1bbf2088b1d2f774b7c6e4f348e1fa28c","original_commit_id":"711fc7b1bbf2088b1d2f774b7c6e4f348e1fa28c","user":{"login":"bmelville","id":11277554,"avatar_url":"https://avatars.githubusercontent.com/u/11277554?v=3","gravatar_id":"","url":"https://api.github.com/users/bmelville","html_url":"https://github.com/bmelville","followers_url":"https://api.github.com/users/bmelville/followers","following_url":"https://api.github.com/users/bmelville/following{/other_user}","gists_url":"https://api.github.com/users/bmelville/gists{/gist_id}","starred_url":"https://api.github.com/users/bmelville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmelville/subscriptions","organizations_url":"https://api.github.com/users/bmelville/orgs","repos_url":"https://api.github.com/users/bmelville/repos","events_url":"https://api.github.com/users/bmelville/events{/privacy}","received_events_url":"https://api.github.com/users/bmelville/received_events","type":"User","site_admin":false},"body":"what happens if path is empty? We need to test that?","created_at":"2015-12-02T14:39:22Z","updated_at":"2015-12-02T14:39:22Z","html_url":"https://github.com/kubernetes/deployment-manager/pull/141#discussion_r46421025","pull_request_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments/46421025"},"html":{"href":"https://github.com/kubernetes/deployment-manager/pull/141#discussion_r46421025"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141","id":52333241,"html_url":"https://github.com/kubernetes/deployment-manager/pull/141","diff_url":"https://github.com/kubernetes/deployment-manager/pull/141.diff","patch_url":"https://github.com/kubernetes/deployment-manager/pull/141.patch","issue_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/141","number":141,"state":"open","locked":false,"title":"Add support for short github.com types. Refactor manager/manager/types to common/types and reuse them rather than redefine them.","user":{"login":"vaikas-google","id":11279988,"avatar_url":"https://avatars.githubusercontent.com/u/11279988?v=3","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},"body":"Support for short github.com types as per #25 ","created_at":"2015-12-01T23:38:10Z","updated_at":"2015-12-02T14:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ad6f9e5bf082d5878943f95c505357ca3bfda60","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141/commits","review_comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141/comments","review_comment_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/141/comments","statuses_url":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/711fc7b1bbf2088b1d2f774b7c6e4f348e1fa28c","head":{"label":"vaikas-google:master","ref":"master","sha":"711fc7b1bbf2088b1d2f774b7c6e4f348e1fa28c","user":{"login":"vaikas-google","id":11279988,"avatar_url":"https://avatars.githubusercontent.com/u/11279988?v=3","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},"repo":{"id":45497246,"name":"deployment-manager","full_name":"vaikas-google/deployment-manager","owner":{"login":"vaikas-google","id":11279988,"avatar_url":"https://avatars.githubusercontent.com/u/11279988?v=3","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vaikas-google/deployment-manager","description":"Deployment Manager on Kubernetes","fork":true,"url":"https://api.github.com/repos/vaikas-google/deployment-manager","forks_url":"https://api.github.com/repos/vaikas-google/deployment-manager/forks","keys_url":"https://api.github.com/repos/vaikas-google/deployment-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaikas-google/deployment-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaikas-google/deployment-manager/teams","hooks_url":"https://api.github.com/repos/vaikas-google/deployment-manager/hooks","issue_events_url":"https://api.github.com/repos/vaikas-google/deployment-manager/issues/events{/number}","events_url":"https://api.github.com/repos/vaikas-google/deployment-manager/events","assignees_url":"https://api.github.com/repos/vaikas-google/deployment-manager/assignees{/user}","branches_url":"https://api.github.com/repos/vaikas-google/deployment-manager/branches{/branch}","tags_url":"https://api.github.com/repos/vaikas-google/deployment-manager/tags","blobs_url":"https://api.github.com/repos/vaikas-google/deployment-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaikas-google/deployment-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaikas-google/deployment-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaikas-google/deployment-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaikas-google/deployment-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/vaikas-google/deployment-manager/languages","stargazers_url":"https://api.github.com/repos/vaikas-google/deployment-manager/stargazers","contributors_url":"https://api.github.com/repos/vaikas-google/deployment-manager/contributors","subscribers_url":"https://api.github.com/repos/vaikas-google/deployment-manager/subscribers","subscription_url":"https://api.github.com/repos/vaikas-google/deployment-manager/subscription","commits_url":"https://api.github.com/repos/vaikas-google/deployment-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaikas-google/deployment-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaikas-google/deployment-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaikas-google/deployment-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaikas-google/deployment-manager/contents/{+path}","compare_url":"https://api.github.com/repos/vaikas-google/deployment-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaikas-google/deployment-manager/merges","archive_url":"https://api.github.com/repos/vaikas-google/deployment-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaikas-google/deployment-manager/downloads","issues_url":"https://api.github.com/repos/vaikas-google/deployment-manager/issues{/number}","pulls_url":"https://api.github.com/repos/vaikas-google/deployment-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/vaikas-google/deployment-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/vaikas-google/deployment-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaikas-google/deployment-manager/labels{/name}","releases_url":"https://api.github.com/repos/vaikas-google/deployment-manager/releases{/id}","created_at":"2015-11-03T21:36:33Z","updated_at":"2015-11-03T21:36:34Z","pushed_at":"2015-12-01T23:34:57Z","git_url":"git://github.com/vaikas-google/deployment-manager.git","ssh_url":"git@github.com:vaikas-google/deployment-manager.git","clone_url":"https://github.com/vaikas-google/deployment-manager.git","svn_url":"https://github.com/vaikas-google/deployment-manager","homepage":null,"size":308,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"92371f1f4c6533fcf26c497514fb5e641bb1a6f0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":43723161,"name":"deployment-manager","full_name":"kubernetes/deployment-manager","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/deployment-manager","description":"Deployment Manager on Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/deployment-manager","forks_url":"https://api.github.com/repos/kubernetes/deployment-manager/forks","keys_url":"https://api.github.com/repos/kubernetes/deployment-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/deployment-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/deployment-manager/teams","hooks_url":"https://api.github.com/repos/kubernetes/deployment-manager/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/deployment-manager/events","assignees_url":"https://api.github.com/repos/kubernetes/deployment-manager/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/deployment-manager/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/deployment-manager/tags","blobs_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/deployment-manager/languages","stargazers_url":"https://api.github.com/repos/kubernetes/deployment-manager/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/deployment-manager/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/deployment-manager/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/deployment-manager/subscription","commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/deployment-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/deployment-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/deployment-manager/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/deployment-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/deployment-manager/merges","archive_url":"https://api.github.com/repos/kubernetes/deployment-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/deployment-manager/downloads","issues_url":"https://api.github.com/repos/kubernetes/deployment-manager/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/deployment-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/deployment-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/deployment-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/deployment-manager/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/deployment-manager/releases{/id}","created_at":"2015-10-06T01:07:32Z","updated_at":"2015-11-26T21:13:38Z","pushed_at":"2015-12-02T00:01:14Z","git_url":"git://github.com/kubernetes/deployment-manager.git","ssh_url":"git@github.com:kubernetes/deployment-manager.git","clone_url":"https://github.com/kubernetes/deployment-manager.git","svn_url":"https://github.com/kubernetes/deployment-manager","homepage":null,"size":5532,"stargazers_count":47,"watchers_count":47,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":42,"forks":16,"open_issues":42,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141"},"html":{"href":"https://github.com/kubernetes/deployment-manager/pull/141"},"issue":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/issues/141"},"comments":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/deployment-manager/statuses/711fc7b1bbf2088b1d2f774b7c6e4f348e1fa28c"}}}}