{"action":"opened","number":51,"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51","id":37526400,"html_url":"https://github.com/google/certificate-transparency-rfcs/pull/51","diff_url":"https://github.com/google/certificate-transparency-rfcs/pull/51.diff","patch_url":"https://github.com/google/certificate-transparency-rfcs/pull/51.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/51","number":51,"state":"open","locked":false,"title":"Remove X509ChainEntry, clarify content of extra_data","user":{"login":"mpalmer","id":357,"avatar_url":"https://avatars.githubusercontent.com/u/357?v=3","gravatar_id":"","url":"https://api.github.com/users/mpalmer","html_url":"https://github.com/mpalmer","followers_url":"https://api.github.com/users/mpalmer/followers","following_url":"https://api.github.com/users/mpalmer/following{/other_user}","gists_url":"https://api.github.com/users/mpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpalmer/subscriptions","organizations_url":"https://api.github.com/users/mpalmer/orgs","repos_url":"https://api.github.com/users/mpalmer/repos","events_url":"https://api.github.com/users/mpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/mpalmer/received_events","type":"User","site_admin":false},"body":"After `LogEntry` got nuked, I realised that `X509ChainEntry` was now also\r\nunused as a structure.  So, I nuked that.  It was referenced in a couple of\r\nplaces in the *text*, so I fixed those references up so they're now more\r\nclear as to what they're *actually* talking about.  Since I needed something\r\nto represent a certificate chain, I created `CertificateChain` as a\r\ntop-level structure.  I also cleaned up the structure definitions in a\r\ncouple of places:\r\n\r\n* Once we've got `CertificateChain` defined, it's pretty clear that that's\r\n  what the second element in PrecertChainEntryV2 is; and\r\n* I didn't see any reason to have a case statement to choose between a\r\n  `TBSCertificate` or a `TBSCertificate`, so I just made `signed_entry` in\r\n  `SignedCertificateTimestamp` a straight-up member.\r\n\r\nFor anyone playing along at home, the definition of `extra_data` in\r\n`/get-entries` is what tripped up alpha.ctlogs.org so badly, so I'm glad to\r\nbe able to clarify this for the future.","created_at":"2015-06-12T02:09:23Z","updated_at":"2015-06-12T02:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/51/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/357ad234ff9df46b4997394e26f4296b68e0775b","head":{"label":"mpalmer:no-more-x509-chain-entry","ref":"no-more-x509-chain-entry","sha":"357ad234ff9df46b4997394e26f4296b68e0775b","user":{"login":"mpalmer","id":357,"avatar_url":"https://avatars.githubusercontent.com/u/357?v=3","gravatar_id":"","url":"https://api.github.com/users/mpalmer","html_url":"https://github.com/mpalmer","followers_url":"https://api.github.com/users/mpalmer/followers","following_url":"https://api.github.com/users/mpalmer/following{/other_user}","gists_url":"https://api.github.com/users/mpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpalmer/subscriptions","organizations_url":"https://api.github.com/users/mpalmer/orgs","repos_url":"https://api.github.com/users/mpalmer/repos","events_url":"https://api.github.com/users/mpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/mpalmer/received_events","type":"User","site_admin":false},"repo":{"id":37257393,"name":"certificate-transparency-rfcs","full_name":"mpalmer/certificate-transparency-rfcs","owner":{"login":"mpalmer","id":357,"avatar_url":"https://avatars.githubusercontent.com/u/357?v=3","gravatar_id":"","url":"https://api.github.com/users/mpalmer","html_url":"https://github.com/mpalmer","followers_url":"https://api.github.com/users/mpalmer/followers","following_url":"https://api.github.com/users/mpalmer/following{/other_user}","gists_url":"https://api.github.com/users/mpalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mpalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpalmer/subscriptions","organizations_url":"https://api.github.com/users/mpalmer/orgs","repos_url":"https://api.github.com/users/mpalmer/repos","events_url":"https://api.github.com/users/mpalmer/events{/privacy}","received_events_url":"https://api.github.com/users/mpalmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpalmer/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":true,"url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/mpalmer/certificate-transparency-rfcs/releases{/id}","created_at":"2015-06-11T11:34:45Z","updated_at":"2015-06-11T11:34:46Z","pushed_at":"2015-06-12T02:08:12Z","git_url":"git://github.com/mpalmer/certificate-transparency-rfcs.git","ssh_url":"git@github.com:mpalmer/certificate-transparency-rfcs.git","clone_url":"https://github.com/mpalmer/certificate-transparency-rfcs.git","svn_url":"https://github.com/mpalmer/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1611,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"81e3c1903b39bfa4b9d4a041ec1e55fba69e41a4","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20069953,"name":"certificate-transparency-rfcs","full_name":"google/certificate-transparency-rfcs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/releases{/id}","created_at":"2014-05-22T17:15:59Z","updated_at":"2015-05-06T07:34:01Z","pushed_at":"2015-06-12T02:09:23Z","git_url":"git://github.com/google/certificate-transparency-rfcs.git","ssh_url":"git@github.com:google/certificate-transparency-rfcs.git","clone_url":"https://github.com/google/certificate-transparency-rfcs.git","svn_url":"https://github.com/google/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1611,"stargazers_count":23,"watchers_count":23,"language":"Makefile","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51"},"html":{"href":"https://github.com/google/certificate-transparency-rfcs/pull/51"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/51"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/357ad234ff9df46b4997394e26f4296b68e0775b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":12,"changed_files":1}}