{"action":"created","issue":{"url":"https://api.github.com/repos/ofiwg/fabtests/issues/271","labels_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271/comments","events_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271/events","html_url":"https://github.com/ofiwg/fabtests/pull/271","id":85615344,"number":271,"title":"Fix addressing issues in fabtests","user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-05T19:30:29Z","updated_at":"2015-06-05T22:52:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/271","html_url":"https://github.com/ofiwg/fabtests/pull/271","diff_url":"https://github.com/ofiwg/fabtests/pull/271.diff","patch_url":"https://github.com/ofiwg/fabtests/pull/271.patch"},"body":"fabtests were assuming various things about addressing\r\n\r\n1) Remove usage of getaddrinfo() from the tests themselves\r\n- tests should provide client and server node names, and\r\nfi_getinfo should do the right thing for address resolution\r\n\r\n2) Rename 'src_addr' and 'dst_addr' in command line options\r\nto 'src_node' and 'dst_node'. Removed FI_SOCKADDR_IN requirement.\r\n- portable OFI programs shouldn't assume any format of address.\r\ninterfaces can be chosen with names.\r\n\r\ne.g. to use IPoIB, use node-ib0, vs. passing in IP address of ib0\r\ninterface.\r\n\r\n3) fix bug in ud_pingpong.c where hints->dest_addr was used for\r\nav_insert, vs fi->dest_addr\r\n- fi->dest_addr was obtained from getinfo(), vs. hints which is\r\na hardcoded address (also portable OFI programs should use\r\nfi_getinfo for getting correct address structures)\r\n\r\nSigned-off-by: Sayantan Sur <sayantan.sur@intel.com>\r\n\r\nTested with sockets provider, seems to be working.\r\n\r\n@jithinjosepkl @shantonu @goodell @jsquyres @shefty @hppritcha Please review!"},"comment":{"url":"https://api.github.com/repos/ofiwg/fabtests/issues/comments/109469792","html_url":"https://github.com/ofiwg/fabtests/pull/271#issuecomment-109469792","issue_url":"https://api.github.com/repos/ofiwg/fabtests/issues/271","id":109469792,"user":{"login":"sayantansur","id":8459709,"avatar_url":"https://avatars.githubusercontent.com/u/8459709?v=3","gravatar_id":"","url":"https://api.github.com/users/sayantansur","html_url":"https://github.com/sayantansur","followers_url":"https://api.github.com/users/sayantansur/followers","following_url":"https://api.github.com/users/sayantansur/following{/other_user}","gists_url":"https://api.github.com/users/sayantansur/gists{/gist_id}","starred_url":"https://api.github.com/users/sayantansur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayantansur/subscriptions","organizations_url":"https://api.github.com/users/sayantansur/orgs","repos_url":"https://api.github.com/users/sayantansur/repos","events_url":"https://api.github.com/users/sayantansur/events{/privacy}","received_events_url":"https://api.github.com/users/sayantansur/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T22:52:33Z","updated_at":"2015-06-05T22:52:33Z","body":"Talked with Sean. Will fix the PR soon."}}