{"action":"created","issue":{"url":"https://api.github.com/repos/ralfstx/minimal-json/issues/38","labels_url":"https://api.github.com/repos/ralfstx/minimal-json/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/ralfstx/minimal-json/issues/38/comments","events_url":"https://api.github.com/repos/ralfstx/minimal-json/issues/38/events","html_url":"https://github.com/ralfstx/minimal-json/pull/38","id":53205939,"number":38,"title":"timeWriteToWriter shouldn't do UTF-8 conversion.  Also rework buffering.","user":{"login":"cakoose","id":239989,"avatar_url":"https://avatars.githubusercontent.com/u/239989?v=3","gravatar_id":"","url":"https://api.github.com/users/cakoose","html_url":"https://github.com/cakoose","followers_url":"https://api.github.com/users/cakoose/followers","following_url":"https://api.github.com/users/cakoose/following{/other_user}","gists_url":"https://api.github.com/users/cakoose/gists{/gist_id}","starred_url":"https://api.github.com/users/cakoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakoose/subscriptions","organizations_url":"https://api.github.com/users/cakoose/orgs","repos_url":"https://api.github.com/users/cakoose/repos","events_url":"https://api.github.com/users/cakoose/events{/privacy}","received_events_url":"https://api.github.com/users/cakoose/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2014-12-31T22:11:32Z","updated_at":"2015-01-17T21:35:45Z","closed_at":"2015-01-17T20:18:31Z","pull_request":{"url":"https://api.github.com/repos/ralfstx/minimal-json/pulls/38","html_url":"https://github.com/ralfstx/minimal-json/pull/38","diff_url":"https://github.com/ralfstx/minimal-json/pull/38.diff","patch_url":"https://github.com/ralfstx/minimal-json/pull/38.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/ralfstx/minimal-json/issues/comments/70385416","html_url":"https://github.com/ralfstx/minimal-json/pull/38#issuecomment-70385416","issue_url":"https://api.github.com/repos/ralfstx/minimal-json/issues/38","id":70385416,"user":{"login":"cakoose","id":239989,"avatar_url":"https://avatars.githubusercontent.com/u/239989?v=3","gravatar_id":"","url":"https://api.github.com/users/cakoose","html_url":"https://github.com/cakoose","followers_url":"https://api.github.com/users/cakoose/followers","following_url":"https://api.github.com/users/cakoose/following{/other_user}","gists_url":"https://api.github.com/users/cakoose/gists{/gist_id}","starred_url":"https://api.github.com/users/cakoose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakoose/subscriptions","organizations_url":"https://api.github.com/users/cakoose/orgs","repos_url":"https://api.github.com/users/cakoose/repos","events_url":"https://api.github.com/users/cakoose/events{/privacy}","received_events_url":"https://api.github.com/users/cakoose/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T21:35:45Z","updated_at":"2015-01-17T21:35:45Z","body":"Re: my second commit.\r\n\r\n`BufferedWriterBenchmark` writes through an `OutputStreamWriter`.  Since `OutputStreamWriter` is not efficient with small writes, wrapping a `BufferedWriter` helps there.\r\n\r\n`ByteArrayOutputStream` is already just a memory buffer; putting another memory buffer in front of it is useless.  The same is true for wrapping `StringWriter` -- wrapping it in a `BufferedWriter` is useless.  This makes sense if you think about the underlying implementation and also holds true if you benchmark it.\r\n\r\nMy change preserved the buffering on `OutputStreamWriter` (where it matters) but remove the buffering around `ByteArrayOutputStream` and `StringWriter` (where it only adds noise).\r\n\r\nDoes this make sense?\r\n\r\ntl;dr: remove the buffering in `timeWriteToWriter` and `timeWriteToOutputStream` to reduce noise."}}