{"action":"created","comment":{"url":"https://api.github.com/repos/docker/distribution/pulls/comments/27532842","id":27532842,"diff_hunk":"@@ -1,20 +1,36 @@\n package distribution\n \n-import (\n-\t\"io\"\n-\t\"time\"\n+import \"golang.org/x/net/context\"\n \n-\t\"github.com/docker/distribution/digest\"\n-\t\"github.com/docker/distribution/manifest\"\n-\t\"golang.org/x/net/context\"\n-)\n+// Scope defines the set of items that match a namespace.\n+type Scope interface {\n+\t// Contains returns true if the name belongs to the namespace.\n+\tContains(name string) (bool, error)","path":"registry.go","position":15,"original_position":15,"commit_id":"0d1305268934cb3ba838356b31b60f11ed6972e0","original_commit_id":"0d1305268934cb3ba838356b31b60f11ed6972e0","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"We can probably remove this. It really depends on how we define scope. If it is just a syntax-based set (ie, glob or equiv), then we don't need the error here.\r\n\r\nWhat if the implementation has to ask a registry?","created_at":"2015-03-31T23:22:21Z","updated_at":"2015-03-31T23:22:21Z","html_url":"https://github.com/docker/distribution/pull/193#discussion_r27532842","pull_request_url":"https://api.github.com/repos/docker/distribution/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments/27532842"},"html":{"href":"https://github.com/docker/distribution/pull/193#discussion_r27532842"},"pull_request":{"href":"https://api.github.com/repos/docker/distribution/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/docker/distribution/pulls/193","id":29670855,"html_url":"https://github.com/docker/distribution/pull/193","diff_url":"https://github.com/docker/distribution/pull/193.diff","patch_url":"https://github.com/docker/distribution/pull/193.patch","issue_url":"https://api.github.com/repos/docker/distribution/issues/193","number":193,"state":"open","locked":false,"title":"WIP: distribution interface improvements","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"This commit sketches out a series of proposed interface improvements for\r\ndefining interactions between distribution components. Please see doc.go for a\r\ngeneral overview.\r\n\r\nSigned-off-by: Stephen J Day <stephen.day@docker.com>\r\n\r\nConnects to #159 \r\nCloses #264","created_at":"2015-02-20T03:28:33Z","updated_at":"2015-03-31T23:22:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2bfc8ada17294f8cc5fc82f6d21a003caea01df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/distribution/pulls/193/commits","review_comments_url":"https://api.github.com/repos/docker/distribution/pulls/193/comments","review_comment_url":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/distribution/issues/193/comments","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/0d1305268934cb3ba838356b31b60f11ed6972e0","head":{"label":"stevvooe:distribution-interfaces","ref":"distribution-interfaces","sha":"0d1305268934cb3ba838356b31b60f11ed6972e0","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"repo":{"id":28724012,"name":"distribution","full_name":"stevvooe/distribution","owner":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars.githubusercontent.com/u/120601?v=3","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevvooe/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":true,"url":"https://api.github.com/repos/stevvooe/distribution","forks_url":"https://api.github.com/repos/stevvooe/distribution/forks","keys_url":"https://api.github.com/repos/stevvooe/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevvooe/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevvooe/distribution/teams","hooks_url":"https://api.github.com/repos/stevvooe/distribution/hooks","issue_events_url":"https://api.github.com/repos/stevvooe/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/stevvooe/distribution/events","assignees_url":"https://api.github.com/repos/stevvooe/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/stevvooe/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/stevvooe/distribution/tags","blobs_url":"https://api.github.com/repos/stevvooe/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevvooe/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevvooe/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevvooe/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevvooe/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/stevvooe/distribution/languages","stargazers_url":"https://api.github.com/repos/stevvooe/distribution/stargazers","contributors_url":"https://api.github.com/repos/stevvooe/distribution/contributors","subscribers_url":"https://api.github.com/repos/stevvooe/distribution/subscribers","subscription_url":"https://api.github.com/repos/stevvooe/distribution/subscription","commits_url":"https://api.github.com/repos/stevvooe/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevvooe/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevvooe/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevvooe/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevvooe/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/stevvooe/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevvooe/distribution/merges","archive_url":"https://api.github.com/repos/stevvooe/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevvooe/distribution/downloads","issues_url":"https://api.github.com/repos/stevvooe/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/stevvooe/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/stevvooe/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/stevvooe/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevvooe/distribution/labels{/name}","releases_url":"https://api.github.com/repos/stevvooe/distribution/releases{/id}","created_at":"2015-01-02T19:42:04Z","updated_at":"2015-03-24T23:56:34Z","pushed_at":"2015-03-25T23:00:09Z","git_url":"git://github.com/stevvooe/distribution.git","ssh_url":"git@github.com:stevvooe/distribution.git","clone_url":"https://github.com/stevvooe/distribution.git","svn_url":"https://github.com/stevvooe/distribution","homepage":null,"size":2377,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ac550484be8a212aea5b014906f8aaede81aa128","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":28366058,"name":"distribution","full_name":"docker/distribution","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/distribution","description":"The Docker toolset to pack, ship, store, and deliver content","fork":false,"url":"https://api.github.com/repos/docker/distribution","forks_url":"https://api.github.com/repos/docker/distribution/forks","keys_url":"https://api.github.com/repos/docker/distribution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/distribution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/distribution/teams","hooks_url":"https://api.github.com/repos/docker/distribution/hooks","issue_events_url":"https://api.github.com/repos/docker/distribution/issues/events{/number}","events_url":"https://api.github.com/repos/docker/distribution/events","assignees_url":"https://api.github.com/repos/docker/distribution/assignees{/user}","branches_url":"https://api.github.com/repos/docker/distribution/branches{/branch}","tags_url":"https://api.github.com/repos/docker/distribution/tags","blobs_url":"https://api.github.com/repos/docker/distribution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/distribution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/distribution/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/distribution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/distribution/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/distribution/languages","stargazers_url":"https://api.github.com/repos/docker/distribution/stargazers","contributors_url":"https://api.github.com/repos/docker/distribution/contributors","subscribers_url":"https://api.github.com/repos/docker/distribution/subscribers","subscription_url":"https://api.github.com/repos/docker/distribution/subscription","commits_url":"https://api.github.com/repos/docker/distribution/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/distribution/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/distribution/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/distribution/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/distribution/contents/{+path}","compare_url":"https://api.github.com/repos/docker/distribution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/distribution/merges","archive_url":"https://api.github.com/repos/docker/distribution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/distribution/downloads","issues_url":"https://api.github.com/repos/docker/distribution/issues{/number}","pulls_url":"https://api.github.com/repos/docker/distribution/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/distribution/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/distribution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/distribution/labels{/name}","releases_url":"https://api.github.com/repos/docker/distribution/releases{/id}","created_at":"2014-12-22T23:49:26Z","updated_at":"2015-03-31T18:23:43Z","pushed_at":"2015-03-30T22:28:55Z","git_url":"git://github.com/docker/distribution.git","ssh_url":"git@github.com:docker/distribution.git","clone_url":"https://github.com/docker/distribution.git","svn_url":"https://github.com/docker/distribution","homepage":null,"size":5148,"stargazers_count":190,"watchers_count":190,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":97,"forks":50,"open_issues":97,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/distribution/pulls/193"},"html":{"href":"https://github.com/docker/distribution/pull/193"},"issue":{"href":"https://api.github.com/repos/docker/distribution/issues/193"},"comments":{"href":"https://api.github.com/repos/docker/distribution/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/distribution/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/distribution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/distribution/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/docker/distribution/statuses/0d1305268934cb3ba838356b31b60f11ed6972e0"}}}}