{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/42406511","id":42406511,"diff_hunk":"@@ -142,67 +122,18 @@\n \t * @should fetch users assigned given role\n \t * @should not fetch user that does not belong to given role\n \t */\n-\t@Authorized( { PrivilegeConstants.VIEW_USERS })\n+\t@Authorized( { PrivilegeConstants.GET_USERS })\n \tpublic List<User> getUsersByRole(Role role) throws APIException;\n \t\n \t/**\n-\t * Save changes to given <code>user</code> to the database.\n-\t * \n-\t * @param user\n-\t * @throws APIException\n-\t * @see #saveUser(User, String)\n-\t * @deprecated replaced by {@link #saveUser(User, String)}\n-\t */\n-\t@Deprecated\n-\t@Authorized( { PrivilegeConstants.EDIT_USERS })\n-\tpublic void updateUser(User user) throws APIException;\n-\t\n-\t/**\n-\t * Use should be UserService.saveUser(user.addRole(role))\n-\t * \n-\t * @deprecated use {@link org.openmrs.User#addRole(Role)}\n-\t */\n-\t@Deprecated\n-\t@Authorized( { PrivilegeConstants.EDIT_USERS })\n-\tpublic void grantUserRole(User user, Role role) throws APIException;\n-\t\n-\t/**\n-\t * Use UserService.saveUser(user.removeRole(role))\n-\t * \n-\t * @deprecated use {@link org.openmrs.User#removeRole(Role)}\n-\t */\n-\t@Deprecated\n-\t@Authorized( { PrivilegeConstants.EDIT_USERS })\n-\tpublic void revokeUserRole(User user, Role role) throws APIException;\n-\t\n-\t/**\n-\t * Mark user as voided (effectively deleting user without removing their data &mdash; since\n-\t * anything the user touched in the database will still have their internal identifier and point\n-\t * to the voided user for historical tracking purposes.\n-\t * \n-\t * @param user\n-\t * @param reason\n-\t * @return the given user voided out\n-\t * @throws APIException\n-\t * @should void user and set attributes\n-\t * @deprecated use {@link #retireUser(User, String)}\n-\t */\n-\t@Deprecated\n-\t@Authorized( { PrivilegeConstants.EDIT_USERS })\n-\tpublic User voidUser(User user, String reason) throws APIException;\n-\t\n-\t/**\n-\t * Clear voided flag for user (equivalent to an \"undelete\" or Lazarus Effect for user)\n+\t * Updates a given <code>user</code> in the database.\n \t * \n \t * @param user\n-\t * @return the given user unvoided\n+\t * @return the saved user\n \t * @throws APIException\n-\t * @should unvoid and unmark all attributes\n-\t * @deprecated use {@link #unretireUser(User)}\n \t */\n-\t@Deprecated\n \t@Authorized( { PrivilegeConstants.EDIT_USERS })\n-\tpublic User unvoidUser(User user) throws APIException;\n+\tpublic User saveUser(User user) throws APIException;","path":"api/src/main/java/org/openmrs/api/UserService.java","position":138,"original_position":138,"commit_id":"d1d193f2b4a7d8d628c94dc7abc57fde993ae8a0","original_commit_id":"d1d193f2b4a7d8d628c94dc7abc57fde993ae8a0","user":{"login":"dkayiwa","id":1390773,"avatar_url":"https://avatars.githubusercontent.com/u/1390773?v=3","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"body":"Since i had to have saveUser that takes a user object, it is just the same. :)","created_at":"2015-10-19T18:17:06Z","updated_at":"2015-10-19T18:17:06Z","html_url":"https://github.com/openmrs/openmrs-core/pull/1597#discussion_r42406511","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/42406511"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/1597#discussion_r42406511"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597","id":47922901,"html_url":"https://github.com/openmrs/openmrs-core/pull/1597","diff_url":"https://github.com/openmrs/openmrs-core/pull/1597.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/1597.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1597","number":1597,"state":"open","locked":false,"title":"Removing deprecated methods - Trunk 4772","user":{"login":"dkayiwa","id":1390773,"avatar_url":"https://avatars.githubusercontent.com/u/1390773?v=3","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"body":"Removing deprecated methods - Trunk 4772","created_at":"2015-10-16T15:13:47Z","updated_at":"2015-10-19T18:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"374afc12d0eb5bb773ad61f29b397ffca1b852a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/1597/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/d1d193f2b4a7d8d628c94dc7abc57fde993ae8a0","head":{"label":"dkayiwa:TRUNK-4772","ref":"TRUNK-4772","sha":"d1d193f2b4a7d8d628c94dc7abc57fde993ae8a0","user":{"login":"dkayiwa","id":1390773,"avatar_url":"https://avatars.githubusercontent.com/u/1390773?v=3","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"repo":{"id":5452609,"name":"openmrs-core","full_name":"dkayiwa/openmrs-core","owner":{"login":"dkayiwa","id":1390773,"avatar_url":"https://avatars.githubusercontent.com/u/1390773?v=3","gravatar_id":"","url":"https://api.github.com/users/dkayiwa","html_url":"https://github.com/dkayiwa","followers_url":"https://api.github.com/users/dkayiwa/followers","following_url":"https://api.github.com/users/dkayiwa/following{/other_user}","gists_url":"https://api.github.com/users/dkayiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dkayiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkayiwa/subscriptions","organizations_url":"https://api.github.com/users/dkayiwa/orgs","repos_url":"https://api.github.com/users/dkayiwa/repos","events_url":"https://api.github.com/users/dkayiwa/events{/privacy}","received_events_url":"https://api.github.com/users/dkayiwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkayiwa/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/dkayiwa/openmrs-core","forks_url":"https://api.github.com/repos/dkayiwa/openmrs-core/forks","keys_url":"https://api.github.com/repos/dkayiwa/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkayiwa/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkayiwa/openmrs-core/teams","hooks_url":"https://api.github.com/repos/dkayiwa/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/dkayiwa/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/dkayiwa/openmrs-core/events","assignees_url":"https://api.github.com/repos/dkayiwa/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/dkayiwa/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/dkayiwa/openmrs-core/tags","blobs_url":"https://api.github.com/repos/dkayiwa/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkayiwa/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkayiwa/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkayiwa/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkayiwa/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/dkayiwa/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/dkayiwa/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/dkayiwa/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/dkayiwa/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/dkayiwa/openmrs-core/subscription","commits_url":"https://api.github.com/repos/dkayiwa/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkayiwa/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkayiwa/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkayiwa/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkayiwa/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/dkayiwa/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkayiwa/openmrs-core/merges","archive_url":"https://api.github.com/repos/dkayiwa/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkayiwa/openmrs-core/downloads","issues_url":"https://api.github.com/repos/dkayiwa/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/dkayiwa/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/dkayiwa/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/dkayiwa/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkayiwa/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/dkayiwa/openmrs-core/releases{/id}","created_at":"2012-08-17T13:33:34Z","updated_at":"2014-02-04T08:00:37Z","pushed_at":"2015-10-19T16:24:27Z","git_url":"git://github.com/dkayiwa/openmrs-core.git","ssh_url":"git@github.com:dkayiwa/openmrs-core.git","clone_url":"https://github.com/dkayiwa/openmrs-core.git","svn_url":"https://github.com/dkayiwa/openmrs-core","homepage":"http://openmrs.org","size":220382,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"75410c2f22ef28d9f763ae49135cd0b97e95a87e","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars.githubusercontent.com/u/860776?v=3","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","created_at":"2012-07-26T04:54:29Z","updated_at":"2015-10-18T18:41:20Z","pushed_at":"2015-10-19T16:24:30Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":270603,"stargazers_count":241,"watchers_count":241,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1198,"mirror_url":null,"open_issues_count":10,"forks":1198,"open_issues":10,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/1597"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1597"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/1597/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/1597/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/d1d193f2b4a7d8d628c94dc7abc57fde993ae8a0"}}}}