{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/489","labels_url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/489/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/489/comments","events_url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/489/events","html_url":"https://github.com/DoSomething/ds-mdata-responder/pull/489","id":103107825,"number":489,"title":"Add new DonorsChoose donation flow","user":{"login":"tongxiang","id":5678066,"avatar_url":"https://avatars.githubusercontent.com/u/5678066?v=3","gravatar_id":"","url":"https://api.github.com/users/tongxiang","html_url":"https://github.com/tongxiang","followers_url":"https://api.github.com/users/tongxiang/followers","following_url":"https://api.github.com/users/tongxiang/following{/other_user}","gists_url":"https://api.github.com/users/tongxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/tongxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tongxiang/subscriptions","organizations_url":"https://api.github.com/users/tongxiang/orgs","repos_url":"https://api.github.com/users/tongxiang/repos","events_url":"https://api.github.com/users/tongxiang/events{/privacy}","received_events_url":"https://api.github.com/users/tongxiang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-08-25T20:20:04Z","updated_at":"2015-08-25T20:39:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/pulls/489","html_url":"https://github.com/DoSomething/ds-mdata-responder/pull/489","diff_url":"https://github.com/DoSomething/ds-mdata-responder/pull/489.diff","patch_url":"https://github.com/DoSomething/ds-mdata-responder/pull/489.patch"},"body":"#### What's this PR do?\r\nIt changes the DonorsChoose donation flow to match [this new flow](https://docs.google.com/document/d/1CglUNrQ-T93ubuAZ0kt7Sm3otwTPnZ3TLGZF_PoEu70/edit#). \r\n\r\nA few important changes have been made, code-wise:\r\n1. The `findProject` method is now called by the `start` method. \r\n2. The `donorschooseConfigModel.js` has been changed to reflect new params. \r\n3. General refactoring to support the new order of messages and new param names. \r\n\r\n#### Where should the reviewer start?\r\n`DonorsChooseDonationaController.js`. \r\n\r\n#### How should this be manually tested?\r\n[This Postman collection](https://www.getpostman.com/collections/b6a81618402acc8c598c) should help us test it. \r\nFor some reason, however, the test API doesn't provide results which can be successfully donated to. Once we get the updated credentials from DonorsChoose, we'll test this flow again to confirm. \r\n\r\n#### What are the relevant tickets?\r\nCloses #481. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/comments/134733403","html_url":"https://github.com/DoSomething/ds-mdata-responder/pull/489#issuecomment-134733403","issue_url":"https://api.github.com/repos/DoSomething/ds-mdata-responder/issues/489","id":134733403,"user":{"login":"jonuy","id":696595,"avatar_url":"https://avatars.githubusercontent.com/u/696595?v=3","gravatar_id":"","url":"https://api.github.com/users/jonuy","html_url":"https://github.com/jonuy","followers_url":"https://api.github.com/users/jonuy/followers","following_url":"https://api.github.com/users/jonuy/following{/other_user}","gists_url":"https://api.github.com/users/jonuy/gists{/gist_id}","starred_url":"https://api.github.com/users/jonuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonuy/subscriptions","organizations_url":"https://api.github.com/users/jonuy/orgs","repos_url":"https://api.github.com/users/jonuy/repos","events_url":"https://api.github.com/users/jonuy/events{/privacy}","received_events_url":"https://api.github.com/users/jonuy/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T20:39:22Z","updated_at":"2015-08-25T20:39:22Z","body":"`npm test` passed on my machine. Testing through Postman also looked good. I did get the error you were mentioning though with the project returned from the DonorsChoose API. Have you already sent a note to Michaela or DonorsChoose about this? Otherwise, I can help with that.\r\n\r\nJust a few notes above on the code. Otherwise, looks good to merge when you're ready."}}