{"action":"opened","issue":{"url":"https://api.github.com/repos/Automattic/_s/issues/784","labels_url":"https://api.github.com/repos/Automattic/_s/issues/784/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/_s/issues/784/comments","events_url":"https://api.github.com/repos/Automattic/_s/issues/784/events","html_url":"https://github.com/Automattic/_s/issues/784","id":97257802,"number":784,"title":"Resolve strict comparison warnings","user":{"login":"grantpalin","id":183909,"avatar_url":"https://avatars.githubusercontent.com/u/183909?v=3","gravatar_id":"","url":"https://api.github.com/users/grantpalin","html_url":"https://github.com/grantpalin","followers_url":"https://api.github.com/users/grantpalin/followers","following_url":"https://api.github.com/users/grantpalin/following{/other_user}","gists_url":"https://api.github.com/users/grantpalin/gists{/gist_id}","starred_url":"https://api.github.com/users/grantpalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantpalin/subscriptions","organizations_url":"https://api.github.com/users/grantpalin/orgs","repos_url":"https://api.github.com/users/grantpalin/repos","events_url":"https://api.github.com/users/grantpalin/events{/privacy}","received_events_url":"https://api.github.com/users/grantpalin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-07-25T21:20:55Z","updated_at":"2015-07-25T21:20:55Z","closed_at":null,"body":"I've been working on a theme based off of _s. Running PHP_CodeSniffer with the WordPress checks yields numerous results, including several warnings on using strict comparisons (`===` and `!==` instead of `==` and `!=`). I decided to run the check against a fresh download from here.\r\n\r\nI ran the following command, which limits to just the relevant sniff:\r\n\r\n    phpcs --standard=WordPress --sniffs=WordPress.PHP.StrictComparisons .\r\n\r\nAnd the results:\r\n\r\n    FILE: C:\\Users\\Grant\\Downloads\\_s-master\\_s-master\\comments.php\r\n    ----------------------------------------------------------------------\r\n    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE\r\n    ----------------------------------------------------------------------\r\n     73 | WARNING | Found: !=. Use strict comparisons (=== or !==).\r\n    ----------------------------------------------------------------------\r\n    \r\n    FILE: ...\\Users\\Grant\\Downloads\\_s-master\\_s-master\\inc\\custom-header.php\r\n    ----------------------------------------------------------------------\r\n    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES\r\n    ----------------------------------------------------------------------\r\n     49 | WARNING | Found: ==. Use strict comparisons (=== or !==).\r\n     58 | WARNING | Found: ==. Use strict comparisons (=== or !==).\r\n    ----------------------------------------------------------------------\r\n    \r\n    FILE: ...\\Users\\Grant\\Downloads\\_s-master\\_s-master\\inc\\template-tags.php\r\n    ----------------------------------------------------------------------\r\n    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE\r\n    ----------------------------------------------------------------------\r\n     106 | WARNING | Found: ==. Use strict comparisons (=== or !==).\r\n    ----------------------------------------------------------------------\r\n    \r\n    FILE: ...\\Downloads\\_s-master\\_s-master\\template-parts\\content-search.php\r\n    ----------------------------------------------------------------------\r\n    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE\r\n    ----------------------------------------------------------------------\r\n     16 | WARNING | Found: ==. Use strict comparisons (=== or !==).\r\n    ----------------------------------------------------------------------\r\n    \r\n    FILE: ...s\\Grant\\Downloads\\_s-master\\_s-master\\template-parts\\content.php\r\n    ----------------------------------------------------------------------\r\n    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE\r\n    ----------------------------------------------------------------------\r\n     14 | WARNING | Found: ==. Use strict comparisons (=== or !==).\r\n    ----------------------------------------------------------------------\r\n\r\nThe first incidence seems like it may be left over from https://github.com/Automattic/_s/issues/632. The rest look like they can be easily resolved by amending the operator.\r\n\r\nIf there's no disagreement I can offer a pull request to resolve these warnings."}}