{"action":"opened","number":484,"pull_request":{"url":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484","id":30362458,"html_url":"https://github.com/pencilblue/pencilblue/pull/484","diff_url":"https://github.com/pencilblue/pencilblue/pull/484.diff","patch_url":"https://github.com/pencilblue/pencilblue/pull/484.patch","issue_url":"https://api.github.com/repos/pencilblue/pencilblue/issues/484","number":484,"state":"open","locked":false,"title":"Plugin Uninstall Error Typo. Stopped Active Plugins From Unregistering","user":{"login":"alexcurtis","id":379213,"avatar_url":"https://avatars.githubusercontent.com/u/379213?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcurtis","html_url":"https://github.com/alexcurtis","followers_url":"https://api.github.com/users/alexcurtis/followers","following_url":"https://api.github.com/users/alexcurtis/following{/other_user}","gists_url":"https://api.github.com/users/alexcurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcurtis/subscriptions","organizations_url":"https://api.github.com/users/alexcurtis/orgs","repos_url":"https://api.github.com/users/alexcurtis/repos","events_url":"https://api.github.com/users/alexcurtis/events{/privacy}","received_events_url":"https://api.github.com/users/alexcurtis/received_events","type":"User","site_admin":false},"body":"After great feedback from @brianhyder on the clean plugin. I added some code to remove the plugin from nav on uninstall.\r\n\r\nWhilst Installing <-> Uninstalling, I noticed that the plugin was not removing from nav until a process restart. Turns out there is an typo on the error param in the uninstall plugin job, which stops the plugin from being removed from `ACTIVE_PLUGINS` object.\r\n\r\n","created_at":"2015-03-03T10:38:30Z","updated_at":"2015-03-03T10:38:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484/commits","review_comments_url":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484/comments","review_comment_url":"https://api.github.com/repos/pencilblue/pencilblue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pencilblue/pencilblue/issues/484/comments","statuses_url":"https://api.github.com/repos/pencilblue/pencilblue/statuses/d9734a61ea76fea1f607986d895a9d3399b7d067","head":{"label":"alexcurtis:plugin_service_fix","ref":"plugin_service_fix","sha":"d9734a61ea76fea1f607986d895a9d3399b7d067","user":{"login":"alexcurtis","id":379213,"avatar_url":"https://avatars.githubusercontent.com/u/379213?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcurtis","html_url":"https://github.com/alexcurtis","followers_url":"https://api.github.com/users/alexcurtis/followers","following_url":"https://api.github.com/users/alexcurtis/following{/other_user}","gists_url":"https://api.github.com/users/alexcurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcurtis/subscriptions","organizations_url":"https://api.github.com/users/alexcurtis/orgs","repos_url":"https://api.github.com/users/alexcurtis/repos","events_url":"https://api.github.com/users/alexcurtis/events{/privacy}","received_events_url":"https://api.github.com/users/alexcurtis/received_events","type":"User","site_admin":false},"repo":{"id":31031543,"name":"pencilblue","full_name":"alexcurtis/pencilblue","owner":{"login":"alexcurtis","id":379213,"avatar_url":"https://avatars.githubusercontent.com/u/379213?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcurtis","html_url":"https://github.com/alexcurtis","followers_url":"https://api.github.com/users/alexcurtis/followers","following_url":"https://api.github.com/users/alexcurtis/following{/other_user}","gists_url":"https://api.github.com/users/alexcurtis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcurtis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcurtis/subscriptions","organizations_url":"https://api.github.com/users/alexcurtis/orgs","repos_url":"https://api.github.com/users/alexcurtis/repos","events_url":"https://api.github.com/users/alexcurtis/events{/privacy}","received_events_url":"https://api.github.com/users/alexcurtis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcurtis/pencilblue","description":"Full stack online publishing and CMS for Node.js","fork":true,"url":"https://api.github.com/repos/alexcurtis/pencilblue","forks_url":"https://api.github.com/repos/alexcurtis/pencilblue/forks","keys_url":"https://api.github.com/repos/alexcurtis/pencilblue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcurtis/pencilblue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcurtis/pencilblue/teams","hooks_url":"https://api.github.com/repos/alexcurtis/pencilblue/hooks","issue_events_url":"https://api.github.com/repos/alexcurtis/pencilblue/issues/events{/number}","events_url":"https://api.github.com/repos/alexcurtis/pencilblue/events","assignees_url":"https://api.github.com/repos/alexcurtis/pencilblue/assignees{/user}","branches_url":"https://api.github.com/repos/alexcurtis/pencilblue/branches{/branch}","tags_url":"https://api.github.com/repos/alexcurtis/pencilblue/tags","blobs_url":"https://api.github.com/repos/alexcurtis/pencilblue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcurtis/pencilblue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcurtis/pencilblue/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcurtis/pencilblue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcurtis/pencilblue/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcurtis/pencilblue/languages","stargazers_url":"https://api.github.com/repos/alexcurtis/pencilblue/stargazers","contributors_url":"https://api.github.com/repos/alexcurtis/pencilblue/contributors","subscribers_url":"https://api.github.com/repos/alexcurtis/pencilblue/subscribers","subscription_url":"https://api.github.com/repos/alexcurtis/pencilblue/subscription","commits_url":"https://api.github.com/repos/alexcurtis/pencilblue/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcurtis/pencilblue/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcurtis/pencilblue/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcurtis/pencilblue/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcurtis/pencilblue/contents/{+path}","compare_url":"https://api.github.com/repos/alexcurtis/pencilblue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcurtis/pencilblue/merges","archive_url":"https://api.github.com/repos/alexcurtis/pencilblue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcurtis/pencilblue/downloads","issues_url":"https://api.github.com/repos/alexcurtis/pencilblue/issues{/number}","pulls_url":"https://api.github.com/repos/alexcurtis/pencilblue/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcurtis/pencilblue/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcurtis/pencilblue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcurtis/pencilblue/labels{/name}","releases_url":"https://api.github.com/repos/alexcurtis/pencilblue/releases{/id}","created_at":"2015-02-19T19:05:27Z","updated_at":"2015-03-03T10:28:49Z","pushed_at":"2015-03-03T10:34:24Z","git_url":"git://github.com/alexcurtis/pencilblue.git","ssh_url":"git@github.com:alexcurtis/pencilblue.git","clone_url":"https://github.com/alexcurtis/pencilblue.git","svn_url":"https://github.com/alexcurtis/pencilblue","homepage":"https://pencilblue.org","size":10736,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pencilblue:master","ref":"master","sha":"23e3e3e003002aecfa5b9a347a4f0293d5fe7581","user":{"login":"pencilblue","id":6748264,"avatar_url":"https://avatars.githubusercontent.com/u/6748264?v=3","gravatar_id":"","url":"https://api.github.com/users/pencilblue","html_url":"https://github.com/pencilblue","followers_url":"https://api.github.com/users/pencilblue/followers","following_url":"https://api.github.com/users/pencilblue/following{/other_user}","gists_url":"https://api.github.com/users/pencilblue/gists{/gist_id}","starred_url":"https://api.github.com/users/pencilblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pencilblue/subscriptions","organizations_url":"https://api.github.com/users/pencilblue/orgs","repos_url":"https://api.github.com/users/pencilblue/repos","events_url":"https://api.github.com/users/pencilblue/events{/privacy}","received_events_url":"https://api.github.com/users/pencilblue/received_events","type":"Organization","site_admin":false},"repo":{"id":21303242,"name":"pencilblue","full_name":"pencilblue/pencilblue","owner":{"login":"pencilblue","id":6748264,"avatar_url":"https://avatars.githubusercontent.com/u/6748264?v=3","gravatar_id":"","url":"https://api.github.com/users/pencilblue","html_url":"https://github.com/pencilblue","followers_url":"https://api.github.com/users/pencilblue/followers","following_url":"https://api.github.com/users/pencilblue/following{/other_user}","gists_url":"https://api.github.com/users/pencilblue/gists{/gist_id}","starred_url":"https://api.github.com/users/pencilblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pencilblue/subscriptions","organizations_url":"https://api.github.com/users/pencilblue/orgs","repos_url":"https://api.github.com/users/pencilblue/repos","events_url":"https://api.github.com/users/pencilblue/events{/privacy}","received_events_url":"https://api.github.com/users/pencilblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pencilblue/pencilblue","description":"Full stack online publishing and CMS for Node.js","fork":false,"url":"https://api.github.com/repos/pencilblue/pencilblue","forks_url":"https://api.github.com/repos/pencilblue/pencilblue/forks","keys_url":"https://api.github.com/repos/pencilblue/pencilblue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pencilblue/pencilblue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pencilblue/pencilblue/teams","hooks_url":"https://api.github.com/repos/pencilblue/pencilblue/hooks","issue_events_url":"https://api.github.com/repos/pencilblue/pencilblue/issues/events{/number}","events_url":"https://api.github.com/repos/pencilblue/pencilblue/events","assignees_url":"https://api.github.com/repos/pencilblue/pencilblue/assignees{/user}","branches_url":"https://api.github.com/repos/pencilblue/pencilblue/branches{/branch}","tags_url":"https://api.github.com/repos/pencilblue/pencilblue/tags","blobs_url":"https://api.github.com/repos/pencilblue/pencilblue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pencilblue/pencilblue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pencilblue/pencilblue/git/refs{/sha}","trees_url":"https://api.github.com/repos/pencilblue/pencilblue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pencilblue/pencilblue/statuses/{sha}","languages_url":"https://api.github.com/repos/pencilblue/pencilblue/languages","stargazers_url":"https://api.github.com/repos/pencilblue/pencilblue/stargazers","contributors_url":"https://api.github.com/repos/pencilblue/pencilblue/contributors","subscribers_url":"https://api.github.com/repos/pencilblue/pencilblue/subscribers","subscription_url":"https://api.github.com/repos/pencilblue/pencilblue/subscription","commits_url":"https://api.github.com/repos/pencilblue/pencilblue/commits{/sha}","git_commits_url":"https://api.github.com/repos/pencilblue/pencilblue/git/commits{/sha}","comments_url":"https://api.github.com/repos/pencilblue/pencilblue/comments{/number}","issue_comment_url":"https://api.github.com/repos/pencilblue/pencilblue/issues/comments{/number}","contents_url":"https://api.github.com/repos/pencilblue/pencilblue/contents/{+path}","compare_url":"https://api.github.com/repos/pencilblue/pencilblue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pencilblue/pencilblue/merges","archive_url":"https://api.github.com/repos/pencilblue/pencilblue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pencilblue/pencilblue/downloads","issues_url":"https://api.github.com/repos/pencilblue/pencilblue/issues{/number}","pulls_url":"https://api.github.com/repos/pencilblue/pencilblue/pulls{/number}","milestones_url":"https://api.github.com/repos/pencilblue/pencilblue/milestones{/number}","notifications_url":"https://api.github.com/repos/pencilblue/pencilblue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pencilblue/pencilblue/labels{/name}","releases_url":"https://api.github.com/repos/pencilblue/pencilblue/releases{/id}","created_at":"2014-06-28T13:28:48Z","updated_at":"2015-03-02T09:01:07Z","pushed_at":"2015-03-02T21:40:18Z","git_url":"git://github.com/pencilblue/pencilblue.git","ssh_url":"git@github.com:pencilblue/pencilblue.git","clone_url":"https://github.com/pencilblue/pencilblue.git","svn_url":"https://github.com/pencilblue/pencilblue","homepage":"https://pencilblue.org","size":14204,"stargazers_count":649,"watchers_count":649,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":22,"forks":82,"open_issues":22,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484"},"html":{"href":"https://github.com/pencilblue/pencilblue/pull/484"},"issue":{"href":"https://api.github.com/repos/pencilblue/pencilblue/issues/484"},"comments":{"href":"https://api.github.com/repos/pencilblue/pencilblue/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/pencilblue/pencilblue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pencilblue/pencilblue/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/pencilblue/pencilblue/statuses/d9734a61ea76fea1f607986d895a9d3399b7d067"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}