{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4992","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4992/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4992/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4992/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/4992","id":59689513,"number":4992,"title":"Little to no validation occurs on a Minion on create","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/api/cluster","name":"api/cluster","color":"e1ed21"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/component/nodecontroller","name":"component/nodecontroller","color":"0052cc"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/priority/P2","name":"priority/P2","color":"fbca04"},{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/team/master","name":"team/master","color":"d2b48c"}],"state":"open","locked":false,"assignee":{"login":"rjnagal","id":5420489,"avatar_url":"https://avatars.githubusercontent.com/u/5420489?v=3","gravatar_id":"","url":"https://api.github.com/users/rjnagal","html_url":"https://github.com/rjnagal","followers_url":"https://api.github.com/users/rjnagal/followers","following_url":"https://api.github.com/users/rjnagal/following{/other_user}","gists_url":"https://api.github.com/users/rjnagal/gists{/gist_id}","starred_url":"https://api.github.com/users/rjnagal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjnagal/subscriptions","organizations_url":"https://api.github.com/users/rjnagal/orgs","repos_url":"https://api.github.com/users/rjnagal/repos","events_url":"https://api.github.com/users/rjnagal/events{/privacy}","received_events_url":"https://api.github.com/users/rjnagal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/6","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/milestones/v1.0","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones/6/labels","id":969317,"number":6,"title":"v1.0","description":"Issues that need to be resolved for v1.0 of Kubernetes.","creator":{"login":"goltermann","id":9358478,"avatar_url":"https://avatars.githubusercontent.com/u/9358478?v=3","gravatar_id":"","url":"https://api.github.com/users/goltermann","html_url":"https://github.com/goltermann","followers_url":"https://api.github.com/users/goltermann/followers","following_url":"https://api.github.com/users/goltermann/following{/other_user}","gists_url":"https://api.github.com/users/goltermann/gists{/gist_id}","starred_url":"https://api.github.com/users/goltermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goltermann/subscriptions","organizations_url":"https://api.github.com/users/goltermann/orgs","repos_url":"https://api.github.com/users/goltermann/repos","events_url":"https://api.github.com/users/goltermann/events{/privacy}","received_events_url":"https://api.github.com/users/goltermann/received_events","type":"User","site_admin":false},"open_issues":117,"closed_issues":74,"state":"open","created_at":"2015-02-06T20:27:16Z","updated_at":"2015-03-20T08:19:43Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-03-03T19:09:24Z","updated_at":"2015-03-20T08:27:48Z","closed_at":null,"body":"Looking at the current code:\r\n\r\nhttps://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/validation/validation.go#L826\r\n\r\nwe do no validation on a minion.Spec value, therefore any initial capacity or external ids avoid validation.\r\n\r\nthis can also result in our node controller when paired with a cloud provider to create invalid nodes."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/83956001","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/issues/4992#issuecomment-83956001","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/4992","id":83956001,"user":{"login":"kazegusuri","id":2457753,"avatar_url":"https://avatars.githubusercontent.com/u/2457753?v=3","gravatar_id":"","url":"https://api.github.com/users/kazegusuri","html_url":"https://github.com/kazegusuri","followers_url":"https://api.github.com/users/kazegusuri/followers","following_url":"https://api.github.com/users/kazegusuri/following{/other_user}","gists_url":"https://api.github.com/users/kazegusuri/gists{/gist_id}","starred_url":"https://api.github.com/users/kazegusuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazegusuri/subscriptions","organizations_url":"https://api.github.com/users/kazegusuri/orgs","repos_url":"https://api.github.com/users/kazegusuri/repos","events_url":"https://api.github.com/users/kazegusuri/events{/privacy}","received_events_url":"https://api.github.com/users/kazegusuri/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T08:27:48Z","updated_at":"2015-03-20T08:27:48Z","body":"ValidateMinion and ValidateMinionUpdate are called even for now, and they are called via strategy once #5441 is merged.\r\nI haven't touched validations to Node yet, so please do it thanks."}}