{"action":"opened","number":676,"pull_request":{"url":"https://api.github.com/repos/nodegit/nodegit/pulls/676","id":42383946,"html_url":"https://github.com/nodegit/nodegit/pull/676","diff_url":"https://github.com/nodegit/nodegit/pull/676.diff","patch_url":"https://github.com/nodegit/nodegit/pull/676.patch","issue_url":"https://api.github.com/repos/nodegit/nodegit/issues/676","number":676,"state":"open","locked":false,"title":"fix config.getString","user":{"login":"jdgarcia","id":899916,"avatar_url":"https://avatars.githubusercontent.com/u/899916?v=3","gravatar_id":"","url":"https://api.github.com/users/jdgarcia","html_url":"https://github.com/jdgarcia","followers_url":"https://api.github.com/users/jdgarcia/followers","following_url":"https://api.github.com/users/jdgarcia/following{/other_user}","gists_url":"https://api.github.com/users/jdgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgarcia/subscriptions","organizations_url":"https://api.github.com/users/jdgarcia/orgs","repos_url":"https://api.github.com/users/jdgarcia/repos","events_url":"https://api.github.com/users/jdgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/jdgarcia/received_events","type":"User","site_admin":false},"body":"- `getStringBuf` is a method on Config's `prototype`, so the `getString` method did not work. Fixed it to be on the prototype.\r\n- We were getting false positives on the config tests because we were catching all errors with the `finallyFn`. Updated the tests the rethrow errors after the `finallyFn` is done.","created_at":"2015-08-13T18:40:20Z","updated_at":"2015-08-13T18:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodegit/nodegit/pulls/676/commits","review_comments_url":"https://api.github.com/repos/nodegit/nodegit/pulls/676/comments","review_comment_url":"https://api.github.com/repos/nodegit/nodegit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodegit/nodegit/issues/676/comments","statuses_url":"https://api.github.com/repos/nodegit/nodegit/statuses/2e3f21abfa3a81285b89cce49c2d4baec680bac1","head":{"label":"nodegit:git-config-fixes","ref":"git-config-fixes","sha":"2e3f21abfa3a81285b89cce49c2d4baec680bac1","user":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"repo":{"id":1383170,"name":"nodegit","full_name":"nodegit/nodegit","owner":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodegit/nodegit","description":"Native Node bindings to Git.","fork":false,"url":"https://api.github.com/repos/nodegit/nodegit","forks_url":"https://api.github.com/repos/nodegit/nodegit/forks","keys_url":"https://api.github.com/repos/nodegit/nodegit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodegit/nodegit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodegit/nodegit/teams","hooks_url":"https://api.github.com/repos/nodegit/nodegit/hooks","issue_events_url":"https://api.github.com/repos/nodegit/nodegit/issues/events{/number}","events_url":"https://api.github.com/repos/nodegit/nodegit/events","assignees_url":"https://api.github.com/repos/nodegit/nodegit/assignees{/user}","branches_url":"https://api.github.com/repos/nodegit/nodegit/branches{/branch}","tags_url":"https://api.github.com/repos/nodegit/nodegit/tags","blobs_url":"https://api.github.com/repos/nodegit/nodegit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodegit/nodegit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodegit/nodegit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodegit/nodegit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodegit/nodegit/statuses/{sha}","languages_url":"https://api.github.com/repos/nodegit/nodegit/languages","stargazers_url":"https://api.github.com/repos/nodegit/nodegit/stargazers","contributors_url":"https://api.github.com/repos/nodegit/nodegit/contributors","subscribers_url":"https://api.github.com/repos/nodegit/nodegit/subscribers","subscription_url":"https://api.github.com/repos/nodegit/nodegit/subscription","commits_url":"https://api.github.com/repos/nodegit/nodegit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodegit/nodegit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodegit/nodegit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodegit/nodegit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodegit/nodegit/contents/{+path}","compare_url":"https://api.github.com/repos/nodegit/nodegit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodegit/nodegit/merges","archive_url":"https://api.github.com/repos/nodegit/nodegit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodegit/nodegit/downloads","issues_url":"https://api.github.com/repos/nodegit/nodegit/issues{/number}","pulls_url":"https://api.github.com/repos/nodegit/nodegit/pulls{/number}","milestones_url":"https://api.github.com/repos/nodegit/nodegit/milestones{/number}","notifications_url":"https://api.github.com/repos/nodegit/nodegit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodegit/nodegit/labels{/name}","releases_url":"https://api.github.com/repos/nodegit/nodegit/releases{/id}","created_at":"2011-02-18T16:42:46Z","updated_at":"2015-08-13T10:38:56Z","pushed_at":"2015-08-13T18:35:54Z","git_url":"git://github.com/nodegit/nodegit.git","ssh_url":"git@github.com:nodegit/nodegit.git","clone_url":"https://github.com/nodegit/nodegit.git","svn_url":"https://github.com/nodegit/nodegit","homepage":"http://www.nodegit.org/","size":23352,"stargazers_count":1228,"watchers_count":1228,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":61,"forks":171,"open_issues":61,"watchers":1228,"default_branch":"master"}},"base":{"label":"nodegit:master","ref":"master","sha":"93d7e57509313102c8d6769010283c9beff5b070","user":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"repo":{"id":1383170,"name":"nodegit","full_name":"nodegit/nodegit","owner":{"login":"nodegit","id":657068,"avatar_url":"https://avatars.githubusercontent.com/u/657068?v=3","gravatar_id":"","url":"https://api.github.com/users/nodegit","html_url":"https://github.com/nodegit","followers_url":"https://api.github.com/users/nodegit/followers","following_url":"https://api.github.com/users/nodegit/following{/other_user}","gists_url":"https://api.github.com/users/nodegit/gists{/gist_id}","starred_url":"https://api.github.com/users/nodegit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodegit/subscriptions","organizations_url":"https://api.github.com/users/nodegit/orgs","repos_url":"https://api.github.com/users/nodegit/repos","events_url":"https://api.github.com/users/nodegit/events{/privacy}","received_events_url":"https://api.github.com/users/nodegit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodegit/nodegit","description":"Native Node bindings to Git.","fork":false,"url":"https://api.github.com/repos/nodegit/nodegit","forks_url":"https://api.github.com/repos/nodegit/nodegit/forks","keys_url":"https://api.github.com/repos/nodegit/nodegit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodegit/nodegit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodegit/nodegit/teams","hooks_url":"https://api.github.com/repos/nodegit/nodegit/hooks","issue_events_url":"https://api.github.com/repos/nodegit/nodegit/issues/events{/number}","events_url":"https://api.github.com/repos/nodegit/nodegit/events","assignees_url":"https://api.github.com/repos/nodegit/nodegit/assignees{/user}","branches_url":"https://api.github.com/repos/nodegit/nodegit/branches{/branch}","tags_url":"https://api.github.com/repos/nodegit/nodegit/tags","blobs_url":"https://api.github.com/repos/nodegit/nodegit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodegit/nodegit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodegit/nodegit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodegit/nodegit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodegit/nodegit/statuses/{sha}","languages_url":"https://api.github.com/repos/nodegit/nodegit/languages","stargazers_url":"https://api.github.com/repos/nodegit/nodegit/stargazers","contributors_url":"https://api.github.com/repos/nodegit/nodegit/contributors","subscribers_url":"https://api.github.com/repos/nodegit/nodegit/subscribers","subscription_url":"https://api.github.com/repos/nodegit/nodegit/subscription","commits_url":"https://api.github.com/repos/nodegit/nodegit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodegit/nodegit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodegit/nodegit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodegit/nodegit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodegit/nodegit/contents/{+path}","compare_url":"https://api.github.com/repos/nodegit/nodegit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodegit/nodegit/merges","archive_url":"https://api.github.com/repos/nodegit/nodegit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodegit/nodegit/downloads","issues_url":"https://api.github.com/repos/nodegit/nodegit/issues{/number}","pulls_url":"https://api.github.com/repos/nodegit/nodegit/pulls{/number}","milestones_url":"https://api.github.com/repos/nodegit/nodegit/milestones{/number}","notifications_url":"https://api.github.com/repos/nodegit/nodegit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodegit/nodegit/labels{/name}","releases_url":"https://api.github.com/repos/nodegit/nodegit/releases{/id}","created_at":"2011-02-18T16:42:46Z","updated_at":"2015-08-13T10:38:56Z","pushed_at":"2015-08-13T18:35:54Z","git_url":"git://github.com/nodegit/nodegit.git","ssh_url":"git@github.com:nodegit/nodegit.git","clone_url":"https://github.com/nodegit/nodegit.git","svn_url":"https://github.com/nodegit/nodegit","homepage":"http://www.nodegit.org/","size":23352,"stargazers_count":1228,"watchers_count":1228,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"open_issues_count":61,"forks":171,"open_issues":61,"watchers":1228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/676"},"html":{"href":"https://github.com/nodegit/nodegit/pull/676"},"issue":{"href":"https://api.github.com/repos/nodegit/nodegit/issues/676"},"comments":{"href":"https://api.github.com/repos/nodegit/nodegit/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodegit/nodegit/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/nodegit/nodegit/statuses/2e3f21abfa3a81285b89cce49c2d4baec680bac1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":4,"changed_files":2}}