{"action":"created","comment":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/47306263","id":47306263,"diff_hunk":"@@ -14,47 +43,89 @@ Doesn't follow any specific convention.\n \n ### JSON\n \n-It also generates a json response but always with a root key. The root key **can't be overridden**, and will be automatically defined accordingly to the objects being serialized.\n+The response document always with a root key.\n+\n+The root key **can't be overridden**, and will be derived from the resource being serialized.\n+\n Doesn't follow any specific convention.\n \n ### JSON API\n \n This adapter follows **version 1.0** of the format specified in","path":"docs/general/adapters.md","position":56,"original_position":56,"commit_id":"609888737531058a8fa2ff6a9b63c6fbfc4a14bc","original_commit_id":"609888737531058a8fa2ff6a9b63c6fbfc4a14bc","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"We may want to consider the implementation of the JSON API objects external to the JSON API adapter, as discussed in https://github.com/rails-api/active_model_serializers/pull/1004#discussion_r46783510 (and relevant to the above comment)","created_at":"2015-12-11T00:10:44Z","updated_at":"2015-12-11T00:10:44Z","html_url":"https://github.com/rails-api/active_model_serializers/pull/1371#discussion_r47306263","pull_request_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371","_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments/47306263"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1371#discussion_r47306263"},"pull_request":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371"}}},"pull_request":{"url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371","id":53335117,"html_url":"https://github.com/rails-api/active_model_serializers/pull/1371","diff_url":"https://github.com/rails-api/active_model_serializers/pull/1371.diff","patch_url":"https://github.com/rails-api/active_model_serializers/pull/1371.patch","issue_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1371","number":1371,"state":"open","locked":false,"title":"[DOCS] Refactor, update, create documentation","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"I did a lot of re-organizing, included deduplication of content.\r\n\r\nI also wrote some new docs.\r\n\r\nThere are likely bugs:\r\n\r\n- spelling\r\n- doesn't make sense\r\n- broken link\r\n- missing link\r\n- out of place\r\n\r\nPlease help review!\r\n\r\nClick `view` on any of the files in the the diff to see how they render","created_at":"2015-12-10T23:48:24Z","updated_at":"2015-12-11T00:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edb196b5e2a7640cd6d170869ae9456562e69eec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371/commits","review_comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371/comments","review_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1371/comments","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/609888737531058a8fa2ff6a9b63c6fbfc4a14bc","head":{"label":"bf4:documentation_updates","ref":"documentation_updates","sha":"609888737531058a8fa2ff6a9b63c6fbfc4a14bc","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"repo":{"id":31333715,"name":"active_model_serializers","full_name":"bf4/active_model_serializers","owner":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bf4/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":true,"url":"https://api.github.com/repos/bf4/active_model_serializers","forks_url":"https://api.github.com/repos/bf4/active_model_serializers/forks","keys_url":"https://api.github.com/repos/bf4/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bf4/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bf4/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/bf4/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/bf4/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/bf4/active_model_serializers/events","assignees_url":"https://api.github.com/repos/bf4/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/bf4/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/bf4/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/bf4/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bf4/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bf4/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/bf4/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bf4/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/bf4/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/bf4/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/bf4/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/bf4/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/bf4/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/bf4/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/bf4/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/bf4/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/bf4/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/bf4/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/bf4/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bf4/active_model_serializers/merges","archive_url":"https://api.github.com/repos/bf4/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bf4/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/bf4/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/bf4/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/bf4/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/bf4/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bf4/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/bf4/active_model_serializers/releases{/id}","created_at":"2015-02-25T20:15:49Z","updated_at":"2015-02-25T20:15:50Z","pushed_at":"2015-12-11T00:05:58Z","git_url":"git://github.com/bf4/active_model_serializers.git","ssh_url":"git@github.com:bf4/active_model_serializers.git","clone_url":"https://github.com/bf4/active_model_serializers.git","svn_url":"https://github.com/bf4/active_model_serializers","homepage":"","size":2153,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0-8-stable"}},"base":{"label":"rails-api:master","ref":"master","sha":"f562449bd439d1295b91b41b01d5b780c793100a","user":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"repo":{"id":2889230,"name":"active_model_serializers","full_name":"rails-api/active_model_serializers","owner":{"login":"rails-api","id":2820360,"avatar_url":"https://avatars.githubusercontent.com/u/2820360?v=3","gravatar_id":"","url":"https://api.github.com/users/rails-api","html_url":"https://github.com/rails-api","followers_url":"https://api.github.com/users/rails-api/followers","following_url":"https://api.github.com/users/rails-api/following{/other_user}","gists_url":"https://api.github.com/users/rails-api/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-api/subscriptions","organizations_url":"https://api.github.com/users/rails-api/orgs","repos_url":"https://api.github.com/users/rails-api/repos","events_url":"https://api.github.com/users/rails-api/events{/privacy}","received_events_url":"https://api.github.com/users/rails-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-api/active_model_serializers","description":"ActiveModel::Serializer implementation and Rails hooks","fork":false,"url":"https://api.github.com/repos/rails-api/active_model_serializers","forks_url":"https://api.github.com/repos/rails-api/active_model_serializers/forks","keys_url":"https://api.github.com/repos/rails-api/active_model_serializers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-api/active_model_serializers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-api/active_model_serializers/teams","hooks_url":"https://api.github.com/repos/rails-api/active_model_serializers/hooks","issue_events_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/events{/number}","events_url":"https://api.github.com/repos/rails-api/active_model_serializers/events","assignees_url":"https://api.github.com/repos/rails-api/active_model_serializers/assignees{/user}","branches_url":"https://api.github.com/repos/rails-api/active_model_serializers/branches{/branch}","tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/tags","blobs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-api/active_model_serializers/languages","stargazers_url":"https://api.github.com/repos/rails-api/active_model_serializers/stargazers","contributors_url":"https://api.github.com/repos/rails-api/active_model_serializers/contributors","subscribers_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscribers","subscription_url":"https://api.github.com/repos/rails-api/active_model_serializers/subscription","commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-api/active_model_serializers/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-api/active_model_serializers/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-api/active_model_serializers/contents/{+path}","compare_url":"https://api.github.com/repos/rails-api/active_model_serializers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-api/active_model_serializers/merges","archive_url":"https://api.github.com/repos/rails-api/active_model_serializers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-api/active_model_serializers/downloads","issues_url":"https://api.github.com/repos/rails-api/active_model_serializers/issues{/number}","pulls_url":"https://api.github.com/repos/rails-api/active_model_serializers/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-api/active_model_serializers/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-api/active_model_serializers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-api/active_model_serializers/labels{/name}","releases_url":"https://api.github.com/repos/rails-api/active_model_serializers/releases{/id}","created_at":"2011-12-01T06:39:26Z","updated_at":"2015-12-10T16:29:19Z","pushed_at":"2015-12-11T00:05:59Z","git_url":"git://github.com/rails-api/active_model_serializers.git","ssh_url":"git@github.com:rails-api/active_model_serializers.git","clone_url":"https://github.com/rails-api/active_model_serializers.git","svn_url":"https://github.com/rails-api/active_model_serializers","homepage":"","size":3468,"stargazers_count":3185,"watchers_count":3185,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":189,"forks":744,"open_issues":189,"watchers":3185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371"},"html":{"href":"https://github.com/rails-api/active_model_serializers/pull/1371"},"issue":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1371"},"comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/issues/1371/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/pulls/1371/commits"},"statuses":{"href":"https://api.github.com/repos/rails-api/active_model_serializers/statuses/609888737531058a8fa2ff6a9b63c6fbfc4a14bc"}}}}