{"action":"created","comment":{"url":"https://api.github.com/repos/tellapart/aurproxy/pulls/comments/34280546","id":34280546,"diff_hunk":"@@ -168,6 +170,15 @@ def start_discovery(self, weight_adjustment_start):\n         for route in server.routes:\n           route.start(weight_adjustment_start)\n \n+  def move_file(self, source, destination):","path":"tellapart/aurproxy/backends/backend.py","position":15,"original_position":15,"commit_id":"9438ca5e4acdd9dc002bbbac21cdcae9e04b4ec2","original_commit_id":"9438ca5e4acdd9dc002bbbac21cdcae9e04b4ec2","user":{"login":"SEJeff","id":4603,"avatar_url":"https://avatars.githubusercontent.com/u/4603?v=3","gravatar_id":"","url":"https://api.github.com/users/SEJeff","html_url":"https://github.com/SEJeff","followers_url":"https://api.github.com/users/SEJeff/followers","following_url":"https://api.github.com/users/SEJeff/following{/other_user}","gists_url":"https://api.github.com/users/SEJeff/gists{/gist_id}","starred_url":"https://api.github.com/users/SEJeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEJeff/subscriptions","organizations_url":"https://api.github.com/users/SEJeff/orgs","repos_url":"https://api.github.com/users/SEJeff/repos","events_url":"https://api.github.com/users/SEJeff/events{/privacy}","received_events_url":"https://api.github.com/users/SEJeff/received_events","type":"User","site_admin":false},"body":"No real reason, just wanted it to be a method. I'll move it to utils.","created_at":"2015-07-09T17:31:01Z","updated_at":"2015-07-09T17:31:01Z","html_url":"https://github.com/tellapart/aurproxy/pull/12#discussion_r34280546","pull_request_url":"https://api.github.com/repos/tellapart/aurproxy/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/comments/34280546"},"html":{"href":"https://github.com/tellapart/aurproxy/pull/12#discussion_r34280546"},"pull_request":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/tellapart/aurproxy/pulls/12","id":39512618,"html_url":"https://github.com/tellapart/aurproxy/pull/12","diff_url":"https://github.com/tellapart/aurproxy/pull/12.diff","patch_url":"https://github.com/tellapart/aurproxy/pull/12.patch","issue_url":"https://api.github.com/repos/tellapart/aurproxy/issues/12","number":12,"state":"open","locked":false,"title":"Use native python bits where possible","user":{"login":"SEJeff","id":4603,"avatar_url":"https://avatars.githubusercontent.com/u/4603?v=3","gravatar_id":"","url":"https://api.github.com/users/SEJeff","html_url":"https://github.com/SEJeff","followers_url":"https://api.github.com/users/SEJeff/followers","following_url":"https://api.github.com/users/SEJeff/following{/other_user}","gists_url":"https://api.github.com/users/SEJeff/gists{/gist_id}","starred_url":"https://api.github.com/users/SEJeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEJeff/subscriptions","organizations_url":"https://api.github.com/users/SEJeff/orgs","repos_url":"https://api.github.com/users/SEJeff/repos","events_url":"https://api.github.com/users/SEJeff/events{/privacy}","received_events_url":"https://api.github.com/users/SEJeff/received_events","type":"User","site_admin":false},"body":"* Use native python code for moving files instead of forking `/usr/bin/mv`\r\n* Rewrite `aurproxy.utils.run_local()` to use `subprocess.Popen()` instead of fabric\r\n* Totally remove fabric as it isn't necessary any longer\r\n\r\nIf you're ok with it, I'll likely change the `kill $( cat /var/run/nginx.pid )` currently in the nginx backend to use `nginx -s` instead (using the new `run_local`). That way, it will show you the actual error from nginx if/when there is a reason that prevents nginx from reloading, such as no upstreams or an error in the rendered template.\r\n\r\nI'd also like to make the reload command configurable, but those are for future PRs.","created_at":"2015-07-08T19:16:34Z","updated_at":"2015-07-09T17:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36d01a8bf4fde765f96f20442ccb6138a829304a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tellapart/aurproxy/pulls/12/commits","review_comments_url":"https://api.github.com/repos/tellapart/aurproxy/pulls/12/comments","review_comment_url":"https://api.github.com/repos/tellapart/aurproxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tellapart/aurproxy/issues/12/comments","statuses_url":"https://api.github.com/repos/tellapart/aurproxy/statuses/9438ca5e4acdd9dc002bbbac21cdcae9e04b4ec2","head":{"label":"SEJeff:native-python-stuffz","ref":"native-python-stuffz","sha":"9438ca5e4acdd9dc002bbbac21cdcae9e04b4ec2","user":{"login":"SEJeff","id":4603,"avatar_url":"https://avatars.githubusercontent.com/u/4603?v=3","gravatar_id":"","url":"https://api.github.com/users/SEJeff","html_url":"https://github.com/SEJeff","followers_url":"https://api.github.com/users/SEJeff/followers","following_url":"https://api.github.com/users/SEJeff/following{/other_user}","gists_url":"https://api.github.com/users/SEJeff/gists{/gist_id}","starred_url":"https://api.github.com/users/SEJeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEJeff/subscriptions","organizations_url":"https://api.github.com/users/SEJeff/orgs","repos_url":"https://api.github.com/users/SEJeff/repos","events_url":"https://api.github.com/users/SEJeff/events{/privacy}","received_events_url":"https://api.github.com/users/SEJeff/received_events","type":"User","site_admin":false},"repo":{"id":36041166,"name":"aurproxy","full_name":"SEJeff/aurproxy","owner":{"login":"SEJeff","id":4603,"avatar_url":"https://avatars.githubusercontent.com/u/4603?v=3","gravatar_id":"","url":"https://api.github.com/users/SEJeff","html_url":"https://github.com/SEJeff","followers_url":"https://api.github.com/users/SEJeff/followers","following_url":"https://api.github.com/users/SEJeff/following{/other_user}","gists_url":"https://api.github.com/users/SEJeff/gists{/gist_id}","starred_url":"https://api.github.com/users/SEJeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SEJeff/subscriptions","organizations_url":"https://api.github.com/users/SEJeff/orgs","repos_url":"https://api.github.com/users/SEJeff/repos","events_url":"https://api.github.com/users/SEJeff/events{/privacy}","received_events_url":"https://api.github.com/users/SEJeff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SEJeff/aurproxy","description":"Load balancer manager with knowledge of Apache Aurora's service discovery mechanism and integration with Aurora's task lifecycle.","fork":true,"url":"https://api.github.com/repos/SEJeff/aurproxy","forks_url":"https://api.github.com/repos/SEJeff/aurproxy/forks","keys_url":"https://api.github.com/repos/SEJeff/aurproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SEJeff/aurproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SEJeff/aurproxy/teams","hooks_url":"https://api.github.com/repos/SEJeff/aurproxy/hooks","issue_events_url":"https://api.github.com/repos/SEJeff/aurproxy/issues/events{/number}","events_url":"https://api.github.com/repos/SEJeff/aurproxy/events","assignees_url":"https://api.github.com/repos/SEJeff/aurproxy/assignees{/user}","branches_url":"https://api.github.com/repos/SEJeff/aurproxy/branches{/branch}","tags_url":"https://api.github.com/repos/SEJeff/aurproxy/tags","blobs_url":"https://api.github.com/repos/SEJeff/aurproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SEJeff/aurproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SEJeff/aurproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/SEJeff/aurproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SEJeff/aurproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/SEJeff/aurproxy/languages","stargazers_url":"https://api.github.com/repos/SEJeff/aurproxy/stargazers","contributors_url":"https://api.github.com/repos/SEJeff/aurproxy/contributors","subscribers_url":"https://api.github.com/repos/SEJeff/aurproxy/subscribers","subscription_url":"https://api.github.com/repos/SEJeff/aurproxy/subscription","commits_url":"https://api.github.com/repos/SEJeff/aurproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/SEJeff/aurproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/SEJeff/aurproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/SEJeff/aurproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/SEJeff/aurproxy/contents/{+path}","compare_url":"https://api.github.com/repos/SEJeff/aurproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SEJeff/aurproxy/merges","archive_url":"https://api.github.com/repos/SEJeff/aurproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SEJeff/aurproxy/downloads","issues_url":"https://api.github.com/repos/SEJeff/aurproxy/issues{/number}","pulls_url":"https://api.github.com/repos/SEJeff/aurproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/SEJeff/aurproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/SEJeff/aurproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SEJeff/aurproxy/labels{/name}","releases_url":"https://api.github.com/repos/SEJeff/aurproxy/releases{/id}","created_at":"2015-05-21T22:52:14Z","updated_at":"2015-05-21T22:52:15Z","pushed_at":"2015-07-08T23:26:36Z","git_url":"git://github.com/SEJeff/aurproxy.git","ssh_url":"git@github.com:SEJeff/aurproxy.git","clone_url":"https://github.com/SEJeff/aurproxy.git","svn_url":"https://github.com/SEJeff/aurproxy","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tellapart:master","ref":"master","sha":"27005c14b3c420f569ac8206e926b84bbe847ca8","user":{"login":"tellapart","id":342225,"avatar_url":"https://avatars.githubusercontent.com/u/342225?v=3","gravatar_id":"","url":"https://api.github.com/users/tellapart","html_url":"https://github.com/tellapart","followers_url":"https://api.github.com/users/tellapart/followers","following_url":"https://api.github.com/users/tellapart/following{/other_user}","gists_url":"https://api.github.com/users/tellapart/gists{/gist_id}","starred_url":"https://api.github.com/users/tellapart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tellapart/subscriptions","organizations_url":"https://api.github.com/users/tellapart/orgs","repos_url":"https://api.github.com/users/tellapart/repos","events_url":"https://api.github.com/users/tellapart/events{/privacy}","received_events_url":"https://api.github.com/users/tellapart/received_events","type":"Organization","site_admin":false},"repo":{"id":34881289,"name":"aurproxy","full_name":"tellapart/aurproxy","owner":{"login":"tellapart","id":342225,"avatar_url":"https://avatars.githubusercontent.com/u/342225?v=3","gravatar_id":"","url":"https://api.github.com/users/tellapart","html_url":"https://github.com/tellapart","followers_url":"https://api.github.com/users/tellapart/followers","following_url":"https://api.github.com/users/tellapart/following{/other_user}","gists_url":"https://api.github.com/users/tellapart/gists{/gist_id}","starred_url":"https://api.github.com/users/tellapart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tellapart/subscriptions","organizations_url":"https://api.github.com/users/tellapart/orgs","repos_url":"https://api.github.com/users/tellapart/repos","events_url":"https://api.github.com/users/tellapart/events{/privacy}","received_events_url":"https://api.github.com/users/tellapart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tellapart/aurproxy","description":"Load balancer manager with knowledge of Apache Aurora's service discovery mechanism and integration with Aurora's task lifecycle.","fork":false,"url":"https://api.github.com/repos/tellapart/aurproxy","forks_url":"https://api.github.com/repos/tellapart/aurproxy/forks","keys_url":"https://api.github.com/repos/tellapart/aurproxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tellapart/aurproxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tellapart/aurproxy/teams","hooks_url":"https://api.github.com/repos/tellapart/aurproxy/hooks","issue_events_url":"https://api.github.com/repos/tellapart/aurproxy/issues/events{/number}","events_url":"https://api.github.com/repos/tellapart/aurproxy/events","assignees_url":"https://api.github.com/repos/tellapart/aurproxy/assignees{/user}","branches_url":"https://api.github.com/repos/tellapart/aurproxy/branches{/branch}","tags_url":"https://api.github.com/repos/tellapart/aurproxy/tags","blobs_url":"https://api.github.com/repos/tellapart/aurproxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tellapart/aurproxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tellapart/aurproxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tellapart/aurproxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tellapart/aurproxy/statuses/{sha}","languages_url":"https://api.github.com/repos/tellapart/aurproxy/languages","stargazers_url":"https://api.github.com/repos/tellapart/aurproxy/stargazers","contributors_url":"https://api.github.com/repos/tellapart/aurproxy/contributors","subscribers_url":"https://api.github.com/repos/tellapart/aurproxy/subscribers","subscription_url":"https://api.github.com/repos/tellapart/aurproxy/subscription","commits_url":"https://api.github.com/repos/tellapart/aurproxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tellapart/aurproxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tellapart/aurproxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tellapart/aurproxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tellapart/aurproxy/contents/{+path}","compare_url":"https://api.github.com/repos/tellapart/aurproxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tellapart/aurproxy/merges","archive_url":"https://api.github.com/repos/tellapart/aurproxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tellapart/aurproxy/downloads","issues_url":"https://api.github.com/repos/tellapart/aurproxy/issues{/number}","pulls_url":"https://api.github.com/repos/tellapart/aurproxy/pulls{/number}","milestones_url":"https://api.github.com/repos/tellapart/aurproxy/milestones{/number}","notifications_url":"https://api.github.com/repos/tellapart/aurproxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tellapart/aurproxy/labels{/name}","releases_url":"https://api.github.com/repos/tellapart/aurproxy/releases{/id}","created_at":"2015-04-30T23:13:15Z","updated_at":"2015-07-09T14:39:51Z","pushed_at":"2015-07-09T17:16:03Z","git_url":"git://github.com/tellapart/aurproxy.git","ssh_url":"git@github.com:tellapart/aurproxy.git","clone_url":"https://github.com/tellapart/aurproxy.git","svn_url":"https://github.com/tellapart/aurproxy","homepage":null,"size":274,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/12"},"html":{"href":"https://github.com/tellapart/aurproxy/pull/12"},"issue":{"href":"https://api.github.com/repos/tellapart/aurproxy/issues/12"},"comments":{"href":"https://api.github.com/repos/tellapart/aurproxy/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tellapart/aurproxy/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/tellapart/aurproxy/statuses/9438ca5e4acdd9dc002bbbac21cdcae9e04b4ec2"}}}}