{"action":"created","comment":{"url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/comments/48028399","id":48028399,"diff_hunk":"@@ -262,6 +262,9 @@ def package_give_acls(namespace, package):\n         namespaces=acls['namespaces'],\n     )\n     form.pkgname.data = package\n+    if str(form.namespace.data) in ['None', '']:","path":"pkgdb2/ui/acls.py","position":4,"original_position":4,"commit_id":"0be1f39a5fa8da19fffa5ba288eead7d662f0ced","original_commit_id":"0be1f39a5fa8da19fffa5ba288eead7d662f0ced","user":{"login":"ralphbean","id":331338,"avatar_url":"https://avatars.githubusercontent.com/u/331338?v=3","gravatar_id":"","url":"https://api.github.com/users/ralphbean","html_url":"https://github.com/ralphbean","followers_url":"https://api.github.com/users/ralphbean/followers","following_url":"https://api.github.com/users/ralphbean/following{/other_user}","gists_url":"https://api.github.com/users/ralphbean/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphbean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphbean/subscriptions","organizations_url":"https://api.github.com/users/ralphbean/orgs","repos_url":"https://api.github.com/users/ralphbean/repos","events_url":"https://api.github.com/users/ralphbean/events{/privacy}","received_events_url":"https://api.github.com/users/ralphbean/received_events","type":"User","site_admin":false},"body":"OH!  Hm.  Ok.","created_at":"2015-12-18T14:19:45Z","updated_at":"2015-12-18T14:19:45Z","html_url":"https://github.com/fedora-infra/pkgdb2/pull/304#discussion_r48028399","pull_request_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304","_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/comments/48028399"},"html":{"href":"https://github.com/fedora-infra/pkgdb2/pull/304#discussion_r48028399"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304","id":54077078,"html_url":"https://github.com/fedora-infra/pkgdb2/pull/304","diff_url":"https://github.com/fedora-infra/pkgdb2/pull/304.diff","patch_url":"https://github.com/fedora-infra/pkgdb2/pull/304.patch","issue_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/304","number":304,"state":"open","locked":false,"title":"Fix giving ACLs to someone","user":{"login":"pypingou","id":1240038,"avatar_url":"https://avatars.githubusercontent.com/u/1240038?v=3","gravatar_id":"","url":"https://api.github.com/users/pypingou","html_url":"https://github.com/pypingou","followers_url":"https://api.github.com/users/pypingou/followers","following_url":"https://api.github.com/users/pypingou/following{/other_user}","gists_url":"https://api.github.com/users/pypingou/gists{/gist_id}","starred_url":"https://api.github.com/users/pypingou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypingou/subscriptions","organizations_url":"https://api.github.com/users/pypingou/orgs","repos_url":"https://api.github.com/users/pypingou/repos","events_url":"https://api.github.com/users/pypingou/events{/privacy}","received_events_url":"https://api.github.com/users/pypingou/received_events","type":"User","site_admin":false},"body":"To give ACLs to someone we need the namespace (to figure out which\r\npackage we're talking about), but this namespace might not actually be\r\npassed on by the form, in this case, we'll just use the one provided in\r\nthe URL.\r\n\r\nAdjust the unit-tests to cover this situation","created_at":"2015-12-18T08:38:55Z","updated_at":"2015-12-18T14:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c541f71b37efc7f330b5f12cb89a63ee18532abb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304/commits","review_comments_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304/comments","review_comment_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/304/comments","statuses_url":"https://api.github.com/repos/fedora-infra/pkgdb2/statuses/0be1f39a5fa8da19fffa5ba288eead7d662f0ced","head":{"label":"fedora-infra:fix_give","ref":"fix_give","sha":"0be1f39a5fa8da19fffa5ba288eead7d662f0ced","user":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":9082212,"name":"pkgdb2","full_name":"fedora-infra/pkgdb2","owner":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedora-infra/pkgdb2","description":"Updated version of the Package Database","fork":false,"url":"https://api.github.com/repos/fedora-infra/pkgdb2","forks_url":"https://api.github.com/repos/fedora-infra/pkgdb2/forks","keys_url":"https://api.github.com/repos/fedora-infra/pkgdb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedora-infra/pkgdb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedora-infra/pkgdb2/teams","hooks_url":"https://api.github.com/repos/fedora-infra/pkgdb2/hooks","issue_events_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/events{/number}","events_url":"https://api.github.com/repos/fedora-infra/pkgdb2/events","assignees_url":"https://api.github.com/repos/fedora-infra/pkgdb2/assignees{/user}","branches_url":"https://api.github.com/repos/fedora-infra/pkgdb2/branches{/branch}","tags_url":"https://api.github.com/repos/fedora-infra/pkgdb2/tags","blobs_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedora-infra/pkgdb2/statuses/{sha}","languages_url":"https://api.github.com/repos/fedora-infra/pkgdb2/languages","stargazers_url":"https://api.github.com/repos/fedora-infra/pkgdb2/stargazers","contributors_url":"https://api.github.com/repos/fedora-infra/pkgdb2/contributors","subscribers_url":"https://api.github.com/repos/fedora-infra/pkgdb2/subscribers","subscription_url":"https://api.github.com/repos/fedora-infra/pkgdb2/subscription","commits_url":"https://api.github.com/repos/fedora-infra/pkgdb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedora-infra/pkgdb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedora-infra/pkgdb2/contents/{+path}","compare_url":"https://api.github.com/repos/fedora-infra/pkgdb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedora-infra/pkgdb2/merges","archive_url":"https://api.github.com/repos/fedora-infra/pkgdb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedora-infra/pkgdb2/downloads","issues_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues{/number}","pulls_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls{/number}","milestones_url":"https://api.github.com/repos/fedora-infra/pkgdb2/milestones{/number}","notifications_url":"https://api.github.com/repos/fedora-infra/pkgdb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedora-infra/pkgdb2/labels{/name}","releases_url":"https://api.github.com/repos/fedora-infra/pkgdb2/releases{/id}","created_at":"2013-03-28T17:17:21Z","updated_at":"2015-12-04T20:42:50Z","pushed_at":"2015-12-18T14:12:58Z","git_url":"git://github.com/fedora-infra/pkgdb2.git","ssh_url":"git@github.com:fedora-infra/pkgdb2.git","clone_url":"https://github.com/fedora-infra/pkgdb2.git","svn_url":"https://github.com/fedora-infra/pkgdb2","homepage":"https://admin.fedoraproject.org/pkgdb/","size":3947,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":11,"forks":22,"open_issues":11,"watchers":13,"default_branch":"master"}},"base":{"label":"fedora-infra:master","ref":"master","sha":"195e9d4ea574ef2ff13ab736fcfec0446d44dc58","user":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":9082212,"name":"pkgdb2","full_name":"fedora-infra/pkgdb2","owner":{"login":"fedora-infra","id":3316637,"avatar_url":"https://avatars.githubusercontent.com/u/3316637?v=3","gravatar_id":"","url":"https://api.github.com/users/fedora-infra","html_url":"https://github.com/fedora-infra","followers_url":"https://api.github.com/users/fedora-infra/followers","following_url":"https://api.github.com/users/fedora-infra/following{/other_user}","gists_url":"https://api.github.com/users/fedora-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/fedora-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedora-infra/subscriptions","organizations_url":"https://api.github.com/users/fedora-infra/orgs","repos_url":"https://api.github.com/users/fedora-infra/repos","events_url":"https://api.github.com/users/fedora-infra/events{/privacy}","received_events_url":"https://api.github.com/users/fedora-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedora-infra/pkgdb2","description":"Updated version of the Package Database","fork":false,"url":"https://api.github.com/repos/fedora-infra/pkgdb2","forks_url":"https://api.github.com/repos/fedora-infra/pkgdb2/forks","keys_url":"https://api.github.com/repos/fedora-infra/pkgdb2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedora-infra/pkgdb2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedora-infra/pkgdb2/teams","hooks_url":"https://api.github.com/repos/fedora-infra/pkgdb2/hooks","issue_events_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/events{/number}","events_url":"https://api.github.com/repos/fedora-infra/pkgdb2/events","assignees_url":"https://api.github.com/repos/fedora-infra/pkgdb2/assignees{/user}","branches_url":"https://api.github.com/repos/fedora-infra/pkgdb2/branches{/branch}","tags_url":"https://api.github.com/repos/fedora-infra/pkgdb2/tags","blobs_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedora-infra/pkgdb2/statuses/{sha}","languages_url":"https://api.github.com/repos/fedora-infra/pkgdb2/languages","stargazers_url":"https://api.github.com/repos/fedora-infra/pkgdb2/stargazers","contributors_url":"https://api.github.com/repos/fedora-infra/pkgdb2/contributors","subscribers_url":"https://api.github.com/repos/fedora-infra/pkgdb2/subscribers","subscription_url":"https://api.github.com/repos/fedora-infra/pkgdb2/subscription","commits_url":"https://api.github.com/repos/fedora-infra/pkgdb2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedora-infra/pkgdb2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedora-infra/pkgdb2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedora-infra/pkgdb2/contents/{+path}","compare_url":"https://api.github.com/repos/fedora-infra/pkgdb2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedora-infra/pkgdb2/merges","archive_url":"https://api.github.com/repos/fedora-infra/pkgdb2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedora-infra/pkgdb2/downloads","issues_url":"https://api.github.com/repos/fedora-infra/pkgdb2/issues{/number}","pulls_url":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls{/number}","milestones_url":"https://api.github.com/repos/fedora-infra/pkgdb2/milestones{/number}","notifications_url":"https://api.github.com/repos/fedora-infra/pkgdb2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedora-infra/pkgdb2/labels{/name}","releases_url":"https://api.github.com/repos/fedora-infra/pkgdb2/releases{/id}","created_at":"2013-03-28T17:17:21Z","updated_at":"2015-12-04T20:42:50Z","pushed_at":"2015-12-18T14:12:58Z","git_url":"git://github.com/fedora-infra/pkgdb2.git","ssh_url":"git@github.com:fedora-infra/pkgdb2.git","clone_url":"https://github.com/fedora-infra/pkgdb2.git","svn_url":"https://github.com/fedora-infra/pkgdb2","homepage":"https://admin.fedoraproject.org/pkgdb/","size":3947,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":11,"forks":22,"open_issues":11,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304"},"html":{"href":"https://github.com/fedora-infra/pkgdb2/pull/304"},"issue":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/304"},"comments":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/fedora-infra/pkgdb2/statuses/0be1f39a5fa8da19fffa5ba288eead7d662f0ced"}}}}