{"action":"opened","number":115,"pull_request":{"url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115","id":45421040,"html_url":"https://github.com/plone/Products.TinyMCE/pull/115","diff_url":"https://github.com/plone/Products.TinyMCE/pull/115.diff","patch_url":"https://github.com/plone/Products.TinyMCE/pull/115.patch","issue_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/115","number":115,"state":"open","locked":false,"title":"Moved utility globals outside the getValidtags method","user":{"login":"keul","id":284924,"avatar_url":"https://avatars.githubusercontent.com/u/284924?v=3","gravatar_id":"","url":"https://api.github.com/users/keul","html_url":"https://github.com/keul","followers_url":"https://api.github.com/users/keul/followers","following_url":"https://api.github.com/users/keul/following{/other_user}","gists_url":"https://api.github.com/users/keul/gists{/gist_id}","starred_url":"https://api.github.com/users/keul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keul/subscriptions","organizations_url":"https://api.github.com/users/keul/orgs","repos_url":"https://api.github.com/users/keul/repos","events_url":"https://api.github.com/users/keul/events{/privacy}","received_events_url":"https://api.github.com/users/keul/received_events","type":"User","site_admin":false},"body":"Right now customizing TinyMCE valid tags and attributes that are not manageable from Plone control panel, is a nightmare.\r\n\r\nThe ``getValidElements`` contains a lot of logic and some constants that are kept *inside* the method itself.\r\n\r\nMoving them at module level will open a way to use monkey-patching for changing simple behaviors.","created_at":"2015-09-18T15:43:31Z","updated_at":"2015-09-18T15:43:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115/commits","review_comments_url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115/comments","review_comment_url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/115/comments","statuses_url":"https://api.github.com/repos/plone/Products.TinyMCE/statuses/b1047dd41c33aeded792ec07386fe33dbe673f84","head":{"label":"plone:1.3.x-external-globals","ref":"1.3.x-external-globals","sha":"b1047dd41c33aeded792ec07386fe33dbe673f84","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2815453,"name":"Products.TinyMCE","full_name":"plone/Products.TinyMCE","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/Products.TinyMCE","description":"TinyMCE integration for Plone","fork":false,"url":"https://api.github.com/repos/plone/Products.TinyMCE","forks_url":"https://api.github.com/repos/plone/Products.TinyMCE/forks","keys_url":"https://api.github.com/repos/plone/Products.TinyMCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/Products.TinyMCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/Products.TinyMCE/teams","hooks_url":"https://api.github.com/repos/plone/Products.TinyMCE/hooks","issue_events_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/events{/number}","events_url":"https://api.github.com/repos/plone/Products.TinyMCE/events","assignees_url":"https://api.github.com/repos/plone/Products.TinyMCE/assignees{/user}","branches_url":"https://api.github.com/repos/plone/Products.TinyMCE/branches{/branch}","tags_url":"https://api.github.com/repos/plone/Products.TinyMCE/tags","blobs_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/Products.TinyMCE/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/Products.TinyMCE/languages","stargazers_url":"https://api.github.com/repos/plone/Products.TinyMCE/stargazers","contributors_url":"https://api.github.com/repos/plone/Products.TinyMCE/contributors","subscribers_url":"https://api.github.com/repos/plone/Products.TinyMCE/subscribers","subscription_url":"https://api.github.com/repos/plone/Products.TinyMCE/subscription","commits_url":"https://api.github.com/repos/plone/Products.TinyMCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/Products.TinyMCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/Products.TinyMCE/contents/{+path}","compare_url":"https://api.github.com/repos/plone/Products.TinyMCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/Products.TinyMCE/merges","archive_url":"https://api.github.com/repos/plone/Products.TinyMCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/Products.TinyMCE/downloads","issues_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues{/number}","pulls_url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/Products.TinyMCE/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/Products.TinyMCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/Products.TinyMCE/labels{/name}","releases_url":"https://api.github.com/repos/plone/Products.TinyMCE/releases{/id}","created_at":"2011-11-20T20:05:55Z","updated_at":"2015-03-25T08:30:48Z","pushed_at":"2015-09-18T15:43:31Z","git_url":"git://github.com/plone/Products.TinyMCE.git","ssh_url":"git@github.com:plone/Products.TinyMCE.git","clone_url":"https://github.com/plone/Products.TinyMCE.git","svn_url":"https://github.com/plone/Products.TinyMCE","homepage":"","size":21455,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":19,"forks":61,"open_issues":19,"watchers":22,"default_branch":"master"}},"base":{"label":"plone:1.3.x","ref":"1.3.x","sha":"217f00c0bfb6175b6efab78dc63f1bce007316f1","user":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"repo":{"id":2815453,"name":"Products.TinyMCE","full_name":"plone/Products.TinyMCE","owner":{"login":"plone","id":72034,"avatar_url":"https://avatars.githubusercontent.com/u/72034?v=3","gravatar_id":"","url":"https://api.github.com/users/plone","html_url":"https://github.com/plone","followers_url":"https://api.github.com/users/plone/followers","following_url":"https://api.github.com/users/plone/following{/other_user}","gists_url":"https://api.github.com/users/plone/gists{/gist_id}","starred_url":"https://api.github.com/users/plone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plone/subscriptions","organizations_url":"https://api.github.com/users/plone/orgs","repos_url":"https://api.github.com/users/plone/repos","events_url":"https://api.github.com/users/plone/events{/privacy}","received_events_url":"https://api.github.com/users/plone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plone/Products.TinyMCE","description":"TinyMCE integration for Plone","fork":false,"url":"https://api.github.com/repos/plone/Products.TinyMCE","forks_url":"https://api.github.com/repos/plone/Products.TinyMCE/forks","keys_url":"https://api.github.com/repos/plone/Products.TinyMCE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plone/Products.TinyMCE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plone/Products.TinyMCE/teams","hooks_url":"https://api.github.com/repos/plone/Products.TinyMCE/hooks","issue_events_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/events{/number}","events_url":"https://api.github.com/repos/plone/Products.TinyMCE/events","assignees_url":"https://api.github.com/repos/plone/Products.TinyMCE/assignees{/user}","branches_url":"https://api.github.com/repos/plone/Products.TinyMCE/branches{/branch}","tags_url":"https://api.github.com/repos/plone/Products.TinyMCE/tags","blobs_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/refs{/sha}","trees_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plone/Products.TinyMCE/statuses/{sha}","languages_url":"https://api.github.com/repos/plone/Products.TinyMCE/languages","stargazers_url":"https://api.github.com/repos/plone/Products.TinyMCE/stargazers","contributors_url":"https://api.github.com/repos/plone/Products.TinyMCE/contributors","subscribers_url":"https://api.github.com/repos/plone/Products.TinyMCE/subscribers","subscription_url":"https://api.github.com/repos/plone/Products.TinyMCE/subscription","commits_url":"https://api.github.com/repos/plone/Products.TinyMCE/commits{/sha}","git_commits_url":"https://api.github.com/repos/plone/Products.TinyMCE/git/commits{/sha}","comments_url":"https://api.github.com/repos/plone/Products.TinyMCE/comments{/number}","issue_comment_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues/comments{/number}","contents_url":"https://api.github.com/repos/plone/Products.TinyMCE/contents/{+path}","compare_url":"https://api.github.com/repos/plone/Products.TinyMCE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plone/Products.TinyMCE/merges","archive_url":"https://api.github.com/repos/plone/Products.TinyMCE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plone/Products.TinyMCE/downloads","issues_url":"https://api.github.com/repos/plone/Products.TinyMCE/issues{/number}","pulls_url":"https://api.github.com/repos/plone/Products.TinyMCE/pulls{/number}","milestones_url":"https://api.github.com/repos/plone/Products.TinyMCE/milestones{/number}","notifications_url":"https://api.github.com/repos/plone/Products.TinyMCE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plone/Products.TinyMCE/labels{/name}","releases_url":"https://api.github.com/repos/plone/Products.TinyMCE/releases{/id}","created_at":"2011-11-20T20:05:55Z","updated_at":"2015-03-25T08:30:48Z","pushed_at":"2015-09-18T15:43:31Z","git_url":"git://github.com/plone/Products.TinyMCE.git","ssh_url":"git@github.com:plone/Products.TinyMCE.git","clone_url":"https://github.com/plone/Products.TinyMCE.git","svn_url":"https://github.com/plone/Products.TinyMCE","homepage":"","size":21455,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":19,"forks":61,"open_issues":19,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115"},"html":{"href":"https://github.com/plone/Products.TinyMCE/pull/115"},"issue":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/issues/115"},"comments":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/plone/Products.TinyMCE/statuses/b1047dd41c33aeded792ec07386fe33dbe673f84"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":18,"changed_files":2}}