{"action":"closed","number":199,"pull_request":{"url":"https://api.github.com/repos/go-gorp/gorp/pulls/199","id":21087724,"html_url":"https://github.com/go-gorp/gorp/pull/199","diff_url":"https://github.com/go-gorp/gorp/pull/199.diff","patch_url":"https://github.com/go-gorp/gorp/pull/199.patch","issue_url":"https://api.github.com/repos/go-gorp/gorp/issues/199","number":199,"state":"closed","locked":false,"title":"Interface to assign ID with a query after insert (like OracleDialect)","user":{"login":"klaidliadon","id":5322228,"avatar_url":"https://avatars.githubusercontent.com/u/5322228?v=3","gravatar_id":"","url":"https://api.github.com/users/klaidliadon","html_url":"https://github.com/klaidliadon","followers_url":"https://api.github.com/users/klaidliadon/followers","following_url":"https://api.github.com/users/klaidliadon/following{/other_user}","gists_url":"https://api.github.com/users/klaidliadon/gists{/gist_id}","starred_url":"https://api.github.com/users/klaidliadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaidliadon/subscriptions","organizations_url":"https://api.github.com/users/klaidliadon/orgs","repos_url":"https://api.github.com/users/klaidliadon/repos","events_url":"https://api.github.com/users/klaidliadon/events{/privacy}","received_events_url":"https://api.github.com/users/klaidliadon/received_events","type":"User","site_admin":false},"body":"Hi, I noticed that in the former version of Oracle Dialect the automatic fetch of a generate id was missing.\r\nI created a new Interface for the purpose: `TargetQueryInserter`\r\n\r\nHere is an Example of usage:\r\n\r\n\tvar obj struct {\r\n\t\tId int64\r\n\t}\r\n\tvar t = dbMap.AddTable(obj)\r\n\tt.SetKeys(true, \"Id\")\r\n\tt.ColMap(\"Id\").GeneratedIdQuery = \"SELECT sequence.currval FROM DUAL\"\r\n","created_at":"2014-09-11T13:36:05Z","updated_at":"2015-07-08T12:01:41Z","closed_at":"2015-07-08T12:01:41Z","merged_at":"2015-07-08T12:01:41Z","merge_commit_sha":"e3823d2730db8f1ba7800a9967c753c22eee1554","assignee":null,"milestone":{"url":"https://api.github.com/repos/go-gorp/gorp/milestones/9","html_url":"https://github.com/go-gorp/gorp/milestones/v2-phase1","labels_url":"https://api.github.com/repos/go-gorp/gorp/milestones/9/labels","id":1188584,"number":9,"title":"v2-phase1","description":"https://github.com/go-gorp/gorp/issues/270","creator":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":6,"state":"open","created_at":"2015-07-01T08:38:14Z","updated_at":"2015-07-08T12:01:41Z","due_on":"2015-07-10T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/go-gorp/gorp/pulls/199/commits","review_comments_url":"https://api.github.com/repos/go-gorp/gorp/pulls/199/comments","review_comment_url":"https://api.github.com/repos/go-gorp/gorp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-gorp/gorp/issues/199/comments","statuses_url":"https://api.github.com/repos/go-gorp/gorp/statuses/60c0ffa601eafa7e0e223475e664459838ddcd37","head":{"label":"klaidliadon:master","ref":"master","sha":"60c0ffa601eafa7e0e223475e664459838ddcd37","user":{"login":"klaidliadon","id":5322228,"avatar_url":"https://avatars.githubusercontent.com/u/5322228?v=3","gravatar_id":"","url":"https://api.github.com/users/klaidliadon","html_url":"https://github.com/klaidliadon","followers_url":"https://api.github.com/users/klaidliadon/followers","following_url":"https://api.github.com/users/klaidliadon/following{/other_user}","gists_url":"https://api.github.com/users/klaidliadon/gists{/gist_id}","starred_url":"https://api.github.com/users/klaidliadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaidliadon/subscriptions","organizations_url":"https://api.github.com/users/klaidliadon/orgs","repos_url":"https://api.github.com/users/klaidliadon/repos","events_url":"https://api.github.com/users/klaidliadon/events{/privacy}","received_events_url":"https://api.github.com/users/klaidliadon/received_events","type":"User","site_admin":false},"repo":{"id":23919000,"name":"gorp","full_name":"klaidliadon/gorp","owner":{"login":"klaidliadon","id":5322228,"avatar_url":"https://avatars.githubusercontent.com/u/5322228?v=3","gravatar_id":"","url":"https://api.github.com/users/klaidliadon","html_url":"https://github.com/klaidliadon","followers_url":"https://api.github.com/users/klaidliadon/followers","following_url":"https://api.github.com/users/klaidliadon/following{/other_user}","gists_url":"https://api.github.com/users/klaidliadon/gists{/gist_id}","starred_url":"https://api.github.com/users/klaidliadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaidliadon/subscriptions","organizations_url":"https://api.github.com/users/klaidliadon/orgs","repos_url":"https://api.github.com/users/klaidliadon/repos","events_url":"https://api.github.com/users/klaidliadon/events{/privacy}","received_events_url":"https://api.github.com/users/klaidliadon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klaidliadon/gorp","description":"ORM-ish library for Go","fork":true,"url":"https://api.github.com/repos/klaidliadon/gorp","forks_url":"https://api.github.com/repos/klaidliadon/gorp/forks","keys_url":"https://api.github.com/repos/klaidliadon/gorp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klaidliadon/gorp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klaidliadon/gorp/teams","hooks_url":"https://api.github.com/repos/klaidliadon/gorp/hooks","issue_events_url":"https://api.github.com/repos/klaidliadon/gorp/issues/events{/number}","events_url":"https://api.github.com/repos/klaidliadon/gorp/events","assignees_url":"https://api.github.com/repos/klaidliadon/gorp/assignees{/user}","branches_url":"https://api.github.com/repos/klaidliadon/gorp/branches{/branch}","tags_url":"https://api.github.com/repos/klaidliadon/gorp/tags","blobs_url":"https://api.github.com/repos/klaidliadon/gorp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klaidliadon/gorp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klaidliadon/gorp/git/refs{/sha}","trees_url":"https://api.github.com/repos/klaidliadon/gorp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klaidliadon/gorp/statuses/{sha}","languages_url":"https://api.github.com/repos/klaidliadon/gorp/languages","stargazers_url":"https://api.github.com/repos/klaidliadon/gorp/stargazers","contributors_url":"https://api.github.com/repos/klaidliadon/gorp/contributors","subscribers_url":"https://api.github.com/repos/klaidliadon/gorp/subscribers","subscription_url":"https://api.github.com/repos/klaidliadon/gorp/subscription","commits_url":"https://api.github.com/repos/klaidliadon/gorp/commits{/sha}","git_commits_url":"https://api.github.com/repos/klaidliadon/gorp/git/commits{/sha}","comments_url":"https://api.github.com/repos/klaidliadon/gorp/comments{/number}","issue_comment_url":"https://api.github.com/repos/klaidliadon/gorp/issues/comments{/number}","contents_url":"https://api.github.com/repos/klaidliadon/gorp/contents/{+path}","compare_url":"https://api.github.com/repos/klaidliadon/gorp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klaidliadon/gorp/merges","archive_url":"https://api.github.com/repos/klaidliadon/gorp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klaidliadon/gorp/downloads","issues_url":"https://api.github.com/repos/klaidliadon/gorp/issues{/number}","pulls_url":"https://api.github.com/repos/klaidliadon/gorp/pulls{/number}","milestones_url":"https://api.github.com/repos/klaidliadon/gorp/milestones{/number}","notifications_url":"https://api.github.com/repos/klaidliadon/gorp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klaidliadon/gorp/labels{/name}","releases_url":"https://api.github.com/repos/klaidliadon/gorp/releases{/id}","created_at":"2014-09-11T13:18:37Z","updated_at":"2015-06-05T14:29:09Z","pushed_at":"2014-09-11T13:32:23Z","git_url":"git://github.com/klaidliadon/gorp.git","ssh_url":"git@github.com:klaidliadon/gorp.git","clone_url":"https://github.com/klaidliadon/gorp.git","svn_url":"https://github.com/klaidliadon/gorp","homepage":"","size":544,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"go-gorp:master","ref":"master","sha":"8ee631799d2fbf10e539619796044b1f83e0a3a1","user":{"login":"go-gorp","id":10610386,"avatar_url":"https://avatars.githubusercontent.com/u/10610386?v=3","gravatar_id":"","url":"https://api.github.com/users/go-gorp","html_url":"https://github.com/go-gorp","followers_url":"https://api.github.com/users/go-gorp/followers","following_url":"https://api.github.com/users/go-gorp/following{/other_user}","gists_url":"https://api.github.com/users/go-gorp/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gorp/subscriptions","organizations_url":"https://api.github.com/users/go-gorp/orgs","repos_url":"https://api.github.com/users/go-gorp/repos","events_url":"https://api.github.com/users/go-gorp/events{/privacy}","received_events_url":"https://api.github.com/users/go-gorp/received_events","type":"Organization","site_admin":false},"repo":{"id":3104806,"name":"gorp","full_name":"go-gorp/gorp","owner":{"login":"go-gorp","id":10610386,"avatar_url":"https://avatars.githubusercontent.com/u/10610386?v=3","gravatar_id":"","url":"https://api.github.com/users/go-gorp","html_url":"https://github.com/go-gorp","followers_url":"https://api.github.com/users/go-gorp/followers","following_url":"https://api.github.com/users/go-gorp/following{/other_user}","gists_url":"https://api.github.com/users/go-gorp/gists{/gist_id}","starred_url":"https://api.github.com/users/go-gorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-gorp/subscriptions","organizations_url":"https://api.github.com/users/go-gorp/orgs","repos_url":"https://api.github.com/users/go-gorp/repos","events_url":"https://api.github.com/users/go-gorp/events{/privacy}","received_events_url":"https://api.github.com/users/go-gorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-gorp/gorp","description":"Go Relational Persistence - an ORM-ish library for Go","fork":false,"url":"https://api.github.com/repos/go-gorp/gorp","forks_url":"https://api.github.com/repos/go-gorp/gorp/forks","keys_url":"https://api.github.com/repos/go-gorp/gorp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-gorp/gorp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-gorp/gorp/teams","hooks_url":"https://api.github.com/repos/go-gorp/gorp/hooks","issue_events_url":"https://api.github.com/repos/go-gorp/gorp/issues/events{/number}","events_url":"https://api.github.com/repos/go-gorp/gorp/events","assignees_url":"https://api.github.com/repos/go-gorp/gorp/assignees{/user}","branches_url":"https://api.github.com/repos/go-gorp/gorp/branches{/branch}","tags_url":"https://api.github.com/repos/go-gorp/gorp/tags","blobs_url":"https://api.github.com/repos/go-gorp/gorp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-gorp/gorp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-gorp/gorp/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-gorp/gorp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-gorp/gorp/statuses/{sha}","languages_url":"https://api.github.com/repos/go-gorp/gorp/languages","stargazers_url":"https://api.github.com/repos/go-gorp/gorp/stargazers","contributors_url":"https://api.github.com/repos/go-gorp/gorp/contributors","subscribers_url":"https://api.github.com/repos/go-gorp/gorp/subscribers","subscription_url":"https://api.github.com/repos/go-gorp/gorp/subscription","commits_url":"https://api.github.com/repos/go-gorp/gorp/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-gorp/gorp/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-gorp/gorp/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-gorp/gorp/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-gorp/gorp/contents/{+path}","compare_url":"https://api.github.com/repos/go-gorp/gorp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-gorp/gorp/merges","archive_url":"https://api.github.com/repos/go-gorp/gorp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-gorp/gorp/downloads","issues_url":"https://api.github.com/repos/go-gorp/gorp/issues{/number}","pulls_url":"https://api.github.com/repos/go-gorp/gorp/pulls{/number}","milestones_url":"https://api.github.com/repos/go-gorp/gorp/milestones{/number}","notifications_url":"https://api.github.com/repos/go-gorp/gorp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-gorp/gorp/labels{/name}","releases_url":"https://api.github.com/repos/go-gorp/gorp/releases{/id}","created_at":"2012-01-04T19:50:09Z","updated_at":"2015-07-07T20:48:52Z","pushed_at":"2015-07-08T12:01:41Z","git_url":"git://github.com/go-gorp/gorp.git","ssh_url":"git@github.com:go-gorp/gorp.git","clone_url":"https://github.com/go-gorp/gorp.git","svn_url":"https://github.com/go-gorp/gorp","homepage":"","size":2083,"stargazers_count":1622,"watchers_count":1622,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":68,"forks":225,"open_issues":68,"watchers":1622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-gorp/gorp/pulls/199"},"html":{"href":"https://github.com/go-gorp/gorp/pull/199"},"issue":{"href":"https://api.github.com/repos/go-gorp/gorp/issues/199"},"comments":{"href":"https://api.github.com/repos/go-gorp/gorp/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/go-gorp/gorp/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/go-gorp/gorp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-gorp/gorp/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/go-gorp/gorp/statuses/60c0ffa601eafa7e0e223475e664459838ddcd37"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"GeertJohan","id":564501,"avatar_url":"https://avatars.githubusercontent.com/u/564501?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertJohan","html_url":"https://github.com/GeertJohan","followers_url":"https://api.github.com/users/GeertJohan/followers","following_url":"https://api.github.com/users/GeertJohan/following{/other_user}","gists_url":"https://api.github.com/users/GeertJohan/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertJohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertJohan/subscriptions","organizations_url":"https://api.github.com/users/GeertJohan/orgs","repos_url":"https://api.github.com/users/GeertJohan/repos","events_url":"https://api.github.com/users/GeertJohan/events{/privacy}","received_events_url":"https://api.github.com/users/GeertJohan/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":42,"deletions":13,"changed_files":2}}