{"action":"closed","number":1199,"pull_request":{"url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199","id":48820473,"html_url":"https://github.com/mozilla/thimble.webmaker.org/pull/1199","diff_url":"https://github.com/mozilla/thimble.webmaker.org/pull/1199.diff","patch_url":"https://github.com/mozilla/thimble.webmaker.org/pull/1199.patch","issue_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/1199","number":1199,"state":"closed","locked":false,"title":"Fix #1198 - Renaming the project triggers multiple requests","user":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?v=3","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"body":"This fixes a few bugs:\r\n* we were adding/removing (and mostly adding) the click handler over and over when the any key handler ran.  Instead of doing this, I just add it once, then ignore it if the button is disabled when it fires\r\n* I've fixed the esc key handling so that it restores the title as it was before editing began. This includes both the 0 length string case, and also all other cases.\r\n* to fix the above, I had to fix a bug in the input field, where it wouldn't set the proper attribute on both an `input` and `span`.\r\n\r\nTesting this now only gives me 1 request for both the `enter` case and also the `click` of the Save button.  I also find the esc key does what I expect.\r\n\r\n@gideonthomas r?","created_at":"2015-10-27T01:58:39Z","updated_at":"2015-10-27T16:52:10Z","closed_at":"2015-10-27T16:52:10Z","merged_at":"2015-10-27T16:52:10Z","merge_commit_sha":"d018b4d66178ad451b2b0248e42aa467df8dc290","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199/commits","review_comments_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199/comments","review_comment_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/1199/comments","statuses_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/statuses/7244f4578245115021a6009e960bf913e207e5b8","head":{"label":"humphd:issue1198","ref":"issue1198","sha":"7244f4578245115021a6009e960bf913e207e5b8","user":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?v=3","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"repo":{"id":9695519,"name":"thimble.webmaker.org","full_name":"humphd/thimble.webmaker.org","owner":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?v=3","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/humphd/thimble.webmaker.org","description":"a minimal thimble on node.js POC","fork":true,"url":"https://api.github.com/repos/humphd/thimble.webmaker.org","forks_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/forks","keys_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/teams","hooks_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/hooks","issue_events_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/issues/events{/number}","events_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/events","assignees_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/assignees{/user}","branches_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/branches{/branch}","tags_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/tags","blobs_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/statuses/{sha}","languages_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/languages","stargazers_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/stargazers","contributors_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/contributors","subscribers_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/subscribers","subscription_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/subscription","commits_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/contents/{+path}","compare_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/merges","archive_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/downloads","issues_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/issues{/number}","pulls_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/pulls{/number}","milestones_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/milestones{/number}","notifications_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/labels{/name}","releases_url":"https://api.github.com/repos/humphd/thimble.webmaker.org/releases{/id}","created_at":"2013-04-26T13:08:45Z","updated_at":"2014-03-18T15:40:47Z","pushed_at":"2015-10-27T16:47:19Z","git_url":"git://github.com/humphd/thimble.webmaker.org.git","ssh_url":"git@github.com:humphd/thimble.webmaker.org.git","clone_url":"https://github.com/humphd/thimble.webmaker.org.git","svn_url":"https://github.com/humphd/thimble.webmaker.org","homepage":null,"size":19470,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:bramble","ref":"bramble","sha":"9895f330637315d81484138c457145a48a02ee77","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":9349840,"name":"thimble.webmaker.org","full_name":"mozilla/thimble.webmaker.org","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/thimble.webmaker.org","description":"Online code editor geared to people teaching and learning HTML, CSS, and JavaScript.","fork":false,"url":"https://api.github.com/repos/mozilla/thimble.webmaker.org","forks_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/forks","keys_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/teams","hooks_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/hooks","issue_events_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/events","assignees_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/tags","blobs_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/languages","stargazers_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/stargazers","contributors_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/contributors","subscribers_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/subscribers","subscription_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/subscription","commits_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/merges","archive_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/downloads","issues_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/thimble.webmaker.org/releases{/id}","created_at":"2013-04-10T15:54:34Z","updated_at":"2015-10-26T20:44:27Z","pushed_at":"2015-10-27T16:52:10Z","git_url":"git://github.com/mozilla/thimble.webmaker.org.git","ssh_url":"git@github.com:mozilla/thimble.webmaker.org.git","clone_url":"https://github.com/mozilla/thimble.webmaker.org.git","svn_url":"https://github.com/mozilla/thimble.webmaker.org","homepage":"https://thimble.mozilla.org","size":62824,"stargazers_count":211,"watchers_count":211,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":141,"forks":93,"open_issues":141,"watchers":211,"default_branch":"bramble"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199"},"html":{"href":"https://github.com/mozilla/thimble.webmaker.org/pull/1199"},"issue":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/1199"},"comments":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/issues/1199/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/pulls/1199/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/thimble.webmaker.org/statuses/7244f4578245115021a6009e960bf913e207e5b8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"humphd","id":427398,"avatar_url":"https://avatars.githubusercontent.com/u/427398?v=3","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"commits":1,"additions":19,"deletions":15,"changed_files":2}}