{"action":"created","issue":{"url":"https://api.github.com/repos/Samsung/jerryscript/issues/635","labels_url":"https://api.github.com/repos/Samsung/jerryscript/issues/635/labels{/name}","comments_url":"https://api.github.com/repos/Samsung/jerryscript/issues/635/comments","events_url":"https://api.github.com/repos/Samsung/jerryscript/issues/635/events","html_url":"https://github.com/Samsung/jerryscript/pull/635","id":107177141,"number":635,"title":"Remove ECMA_STRING_CONTAINER_CONCATENATION type from ecma_string","user":{"login":"LaszloLango","id":10030017,"avatar_url":"https://avatars.githubusercontent.com/u/10030017?v=3","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Samsung/jerryscript/labels/performance","name":"performance","color":"C0C0C0"}],"state":"closed","locked":false,"assignee":{"login":"LaszloLango","id":10030017,"avatar_url":"https://avatars.githubusercontent.com/u/10030017?v=3","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4","html_url":"https://github.com/Samsung/jerryscript/milestones/Engine%20optimization%20&%20enhancement","labels_url":"https://api.github.com/repos/Samsung/jerryscript/milestones/4/labels","id":1188990,"number":4,"title":"Engine optimization & enhancement","description":"","creator":{"login":"egavrin","id":782710,"avatar_url":"https://avatars.githubusercontent.com/u/782710?v=3","gravatar_id":"","url":"https://api.github.com/users/egavrin","html_url":"https://github.com/egavrin","followers_url":"https://api.github.com/users/egavrin/followers","following_url":"https://api.github.com/users/egavrin/following{/other_user}","gists_url":"https://api.github.com/users/egavrin/gists{/gist_id}","starred_url":"https://api.github.com/users/egavrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egavrin/subscriptions","organizations_url":"https://api.github.com/users/egavrin/orgs","repos_url":"https://api.github.com/users/egavrin/repos","events_url":"https://api.github.com/users/egavrin/events{/privacy}","received_events_url":"https://api.github.com/users/egavrin/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":42,"state":"open","created_at":"2015-07-01T13:22:04Z","updated_at":"2015-09-24T11:10:29Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2015-09-18T10:32:36Z","updated_at":"2015-09-28T14:45:22Z","closed_at":"2015-09-24T11:10:29Z","pull_request":{"url":"https://api.github.com/repos/Samsung/jerryscript/pulls/635","html_url":"https://github.com/Samsung/jerryscript/pull/635","diff_url":"https://github.com/Samsung/jerryscript/pull/635.diff","patch_url":"https://github.com/Samsung/jerryscript/pull/635.patch"},"body":"JerryScript-DCO-1.0-Signed-off-by: Kristof Kosztyo kkosztyo.u-szeged@partner.samsung.com\r\n\r\nBase rev: 66975236bc42fdfcfcb74b6996601c1401f2b62e\r\n\r\n                               Benchmark |         RSS<br>(+ is better) |        Perf<br>(+ is better) |\r\n                               --------- |                          --- |                         ---- |\r\n                              3d-cube.js |         152->   156 (-2.632) |       0.3486->0.3409 (2.209) | \r\n                  access-binary-trees.js |          96->   100 (-4.167) |      0.2488->0.2504 (-0.643) | \r\n                      access-fannkuch.js |           52->    52 (0.000) |       0.9333->0.9112 (2.368) | \r\n                         access-nbody.js |           72->    68 (5.556) |      0.4593->0.4596 (-0.065) | \r\n             bitops-3bit-bits-in-byte.js |           44->    44 (0.000) |        0.319->0.3091 (3.103) | \r\n                  bitops-bits-in-byte.js |           36->    36 (0.000) |       0.4385->0.4246 (3.170) | \r\n                   bitops-bitwise-and.js |           44->    40 (9.091) |        0.364->0.3608 (0.879) | \r\n                controlflow-recursive.js |         288->   292 (-1.389) |       0.2875->0.2816 (2.052) | \r\n                           crypto-aes.js |         224->   164 (26.786) |      2.2872->0.6263 (72.617) | \r\n                    date-format-xparb.js |          108->   108 (0.000) |      0.2919->0.2522 (13.600) | \r\n                          math-cordic.js |          48->    52 (-8.333) |       0.4142->0.3866 (6.663) | \r\n                    math-partial-sums.js |           44->    44 (0.000) |       0.2331->0.2331 (0.000) | \r\n                   math-spectral-norm.js |           56->    56 (0.000) |       0.2981->0.2934 (1.577) | \r\n                         string-fasta.js |           68->    64 (5.882) |      2.9977->1.4992 (49.988) | \r\n                         Geometric mean: |       RSS reduction: 2.5681% |           Speed up: 15.4631% |\r\n"},"comment":{"url":"https://api.github.com/repos/Samsung/jerryscript/issues/comments/143764000","html_url":"https://github.com/Samsung/jerryscript/pull/635#issuecomment-143764000","issue_url":"https://api.github.com/repos/Samsung/jerryscript/issues/635","id":143764000,"user":{"login":"ruben-ayrapetyan","id":11939769,"avatar_url":"https://avatars.githubusercontent.com/u/11939769?v=3","gravatar_id":"","url":"https://api.github.com/users/ruben-ayrapetyan","html_url":"https://github.com/ruben-ayrapetyan","followers_url":"https://api.github.com/users/ruben-ayrapetyan/followers","following_url":"https://api.github.com/users/ruben-ayrapetyan/following{/other_user}","gists_url":"https://api.github.com/users/ruben-ayrapetyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ruben-ayrapetyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruben-ayrapetyan/subscriptions","organizations_url":"https://api.github.com/users/ruben-ayrapetyan/orgs","repos_url":"https://api.github.com/users/ruben-ayrapetyan/repos","events_url":"https://api.github.com/users/ruben-ayrapetyan/events{/privacy}","received_events_url":"https://api.github.com/users/ruben-ayrapetyan/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T14:45:22Z","updated_at":"2015-09-28T14:45:22Z","body":"> I could suggest three solutions after your comment:\r\n1. Roll back to 6697523\r\n2. Use build option to switch between these two concat handling\r\n3. Leave as is\r\n\r\n@LaszloLango, considering https://github.com/Samsung/jerryscript/pull/635#issuecomment-143761322, what do you think of the fourth - to perform investigation of ways to improve / optimize concatenation representation and processing routines for various cases, producing a comprehensive solution?"}}