{"action":"created","issue":{"url":"https://api.github.com/repos/neovim/neovim/issues/2457","labels_url":"https://api.github.com/repos/neovim/neovim/issues/2457/labels{/name}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2457/comments","events_url":"https://api.github.com/repos/neovim/neovim/issues/2457/events","html_url":"https://github.com/neovim/neovim/pull/2457","id":69386560,"number":2457,"title":"[WIP] Enable -Wconversion: charset.c","user":{"login":"codonnell","id":224006,"avatar_url":"https://avatars.githubusercontent.com/u/224006?v=3","gravatar_id":"","url":"https://api.github.com/users/codonnell","html_url":"https://github.com/codonnell","followers_url":"https://api.github.com/users/codonnell/followers","following_url":"https://api.github.com/users/codonnell/following{/other_user}","gists_url":"https://api.github.com/users/codonnell/gists{/gist_id}","starred_url":"https://api.github.com/users/codonnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codonnell/subscriptions","organizations_url":"https://api.github.com/users/codonnell/orgs","repos_url":"https://api.github.com/users/codonnell/repos","events_url":"https://api.github.com/users/codonnell/events{/privacy}","received_events_url":"https://api.github.com/users/codonnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neovim/neovim/labels/WIP","name":"WIP","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-19T05:21:41Z","updated_at":"2015-04-21T15:36:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2457","html_url":"https://github.com/neovim/neovim/pull/2457","diff_url":"https://github.com/neovim/neovim/pull/2457.diff","patch_url":"https://github.com/neovim/neovim/pull/2457.patch"},"body":"Just creating this PR now so no one tries to duplicate my work."},"comment":{"url":"https://api.github.com/repos/neovim/neovim/issues/comments/94841277","html_url":"https://github.com/neovim/neovim/pull/2457#issuecomment-94841277","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2457","id":94841277,"user":{"login":"codonnell","id":224006,"avatar_url":"https://avatars.githubusercontent.com/u/224006?v=3","gravatar_id":"","url":"https://api.github.com/users/codonnell","html_url":"https://github.com/codonnell","followers_url":"https://api.github.com/users/codonnell/followers","following_url":"https://api.github.com/users/codonnell/following{/other_user}","gists_url":"https://api.github.com/users/codonnell/gists{/gist_id}","starred_url":"https://api.github.com/users/codonnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codonnell/subscriptions","organizations_url":"https://api.github.com/users/codonnell/orgs","repos_url":"https://api.github.com/users/codonnell/repos","events_url":"https://api.github.com/users/codonnell/events{/privacy}","received_events_url":"https://api.github.com/users/codonnell/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T15:36:34Z","updated_at":"2015-04-21T15:36:34Z","body":"I'd love some advice about how to handle some details of this conversion.\r\n\r\nThis file modifies a global array, `chartab`. This array consists of unsigned chars, each of which is used as a byte to store a few attributes of the character. Some bit arithmetic is done with mask constants to set attributes. These masks are macros (eg. `#define CT_ID_CHAR 0x20`), so they default to `int` type. Would it be a better to add a cast to the macros or change the type of the array itself?"}}