{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/38237773","id":38237773,"diff_hunk":"@@ -144,7 +144,19 @@ - (void)reloadImage\n         }\n       } else {\n         if (_onLoad) {\n-          NSDictionary *event = @{ @\"target\": self.reactTag };\n+          CGSize intrinsicSize = [dimensions CGSizeValue];","path":"Libraries/Image/RCTImageView.m","position":14,"original_position":14,"commit_id":"1ed263a406eec72ec7b3d2e304ad4dd051f76e5b","original_commit_id":"1ed263a406eec72ec7b3d2e304ad4dd051f76e5b","user":{"login":"ide","id":379606,"avatar_url":"https://avatars.githubusercontent.com/u/379606?v=3","gravatar_id":"","url":"https://api.github.com/users/ide","html_url":"https://github.com/ide","followers_url":"https://api.github.com/users/ide/followers","following_url":"https://api.github.com/users/ide/following{/other_user}","gists_url":"https://api.github.com/users/ide/gists{/gist_id}","starred_url":"https://api.github.com/users/ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ide/subscriptions","organizations_url":"https://api.github.com/users/ide/orgs","repos_url":"https://api.github.com/users/ide/repos","events_url":"https://api.github.com/users/ide/events{/privacy}","received_events_url":"https://api.github.com/users/ide/received_events","type":"User","site_admin":false},"body":"if dimensions is nil, then exclude the \"size\" from the event object (otherwise include it). This means that if we download an image that actually has 0 width or height, it will be reported to the JS code.","created_at":"2015-08-28T19:55:19Z","updated_at":"2015-08-28T19:55:19Z","html_url":"https://github.com/facebook/react-native/pull/2364#discussion_r38237773","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/2364","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/38237773"},"html":{"href":"https://github.com/facebook/react-native/pull/2364#discussion_r38237773"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/2364"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/2364","id":42613637,"html_url":"https://github.com/facebook/react-native/pull/2364","diff_url":"https://github.com/facebook/react-native/pull/2364.diff","patch_url":"https://github.com/facebook/react-native/pull/2364.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/2364","number":2364,"state":"open","locked":false,"title":"add image size to onLoad nativeEvent","user":{"login":"dubert","id":1843672,"avatar_url":"https://avatars.githubusercontent.com/u/1843672?v=3","gravatar_id":"","url":"https://api.github.com/users/dubert","html_url":"https://github.com/dubert","followers_url":"https://api.github.com/users/dubert/followers","following_url":"https://api.github.com/users/dubert/following{/other_user}","gists_url":"https://api.github.com/users/dubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubert/subscriptions","organizations_url":"https://api.github.com/users/dubert/orgs","repos_url":"https://api.github.com/users/dubert/repos","events_url":"https://api.github.com/users/dubert/events{/privacy}","received_events_url":"https://api.github.com/users/dubert/received_events","type":"User","site_admin":false},"body":"Issue: https://github.com/facebook/react-native/issues/494\r\nRelated: https://github.com/facebook/react-native/issues/2180\r\n\r\n","created_at":"2015-08-17T17:38:05Z","updated_at":"2015-08-28T19:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b898bf305b181f25ca288645c16756d2ffb4834","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/2364/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/2364/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/2364/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/1ed263a406eec72ec7b3d2e304ad4dd051f76e5b","head":{"label":"dubert:network-image-size-onload","ref":"network-image-size-onload","sha":"1ed263a406eec72ec7b3d2e304ad4dd051f76e5b","user":{"login":"dubert","id":1843672,"avatar_url":"https://avatars.githubusercontent.com/u/1843672?v=3","gravatar_id":"","url":"https://api.github.com/users/dubert","html_url":"https://github.com/dubert","followers_url":"https://api.github.com/users/dubert/followers","following_url":"https://api.github.com/users/dubert/following{/other_user}","gists_url":"https://api.github.com/users/dubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubert/subscriptions","organizations_url":"https://api.github.com/users/dubert/orgs","repos_url":"https://api.github.com/users/dubert/repos","events_url":"https://api.github.com/users/dubert/events{/privacy}","received_events_url":"https://api.github.com/users/dubert/received_events","type":"User","site_admin":false},"repo":{"id":40252101,"name":"react-native","full_name":"dubert/react-native","owner":{"login":"dubert","id":1843672,"avatar_url":"https://avatars.githubusercontent.com/u/1843672?v=3","gravatar_id":"","url":"https://api.github.com/users/dubert","html_url":"https://github.com/dubert","followers_url":"https://api.github.com/users/dubert/followers","following_url":"https://api.github.com/users/dubert/following{/other_user}","gists_url":"https://api.github.com/users/dubert/gists{/gist_id}","starred_url":"https://api.github.com/users/dubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubert/subscriptions","organizations_url":"https://api.github.com/users/dubert/orgs","repos_url":"https://api.github.com/users/dubert/repos","events_url":"https://api.github.com/users/dubert/events{/privacy}","received_events_url":"https://api.github.com/users/dubert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dubert/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/dubert/react-native","forks_url":"https://api.github.com/repos/dubert/react-native/forks","keys_url":"https://api.github.com/repos/dubert/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubert/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubert/react-native/teams","hooks_url":"https://api.github.com/repos/dubert/react-native/hooks","issue_events_url":"https://api.github.com/repos/dubert/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/dubert/react-native/events","assignees_url":"https://api.github.com/repos/dubert/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/dubert/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/dubert/react-native/tags","blobs_url":"https://api.github.com/repos/dubert/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubert/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubert/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubert/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubert/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/dubert/react-native/languages","stargazers_url":"https://api.github.com/repos/dubert/react-native/stargazers","contributors_url":"https://api.github.com/repos/dubert/react-native/contributors","subscribers_url":"https://api.github.com/repos/dubert/react-native/subscribers","subscription_url":"https://api.github.com/repos/dubert/react-native/subscription","commits_url":"https://api.github.com/repos/dubert/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubert/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubert/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubert/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubert/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/dubert/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubert/react-native/merges","archive_url":"https://api.github.com/repos/dubert/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubert/react-native/downloads","issues_url":"https://api.github.com/repos/dubert/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/dubert/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/dubert/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/dubert/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubert/react-native/labels{/name}","releases_url":"https://api.github.com/repos/dubert/react-native/releases{/id}","created_at":"2015-08-05T15:06:28Z","updated_at":"2015-08-05T15:06:30Z","pushed_at":"2015-08-20T00:39:39Z","git_url":"git://github.com/dubert/react-native.git","ssh_url":"git@github.com:dubert/react-native.git","clone_url":"https://github.com/dubert/react-native.git","svn_url":"https://github.com/dubert/react-native","homepage":"http://facebook.github.io/react-native/","size":23406,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f0dd9fb358efb94fba4dd2ba74fb4910bd929056","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","created_at":"2015-01-09T18:10:16Z","updated_at":"2015-08-28T19:47:12Z","pushed_at":"2015-08-28T19:15:41Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":48998,"stargazers_count":16997,"watchers_count":16997,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2240,"mirror_url":null,"open_issues_count":572,"forks":2240,"open_issues":572,"watchers":16997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/2364"},"html":{"href":"https://github.com/facebook/react-native/pull/2364"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/2364"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/2364/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/2364/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/2364/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/1ed263a406eec72ec7b3d2e304ad4dd051f76e5b"}}}}