{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/40999813","id":40999813,"diff_hunk":"@@ -75,6 +75,20 @@ def __call__( self, environ, start_response ):\n         # Galaxy would not have access to Galaxy itself, and be attempting to\n         # attack the system\n         if self.config_secret_header is not None:\n+            if environ.get('HTTP_GX_SECRET') is None:\n+                title = \"Access to Galaxy is denied\"\n+                message = \"\"\"\n+                Galaxy is configured to authenticate users via an external\n+                method (such as HTTP authentication in Apache), but\n+                no shared secret key was provided by the\n+                upstream (proxy) server.</p>\n+                <p>Please contact your local Galaxy administrator.  The\n+                variable <code>remote_user_secret</code> and\n+                <code>GX_SECRET</code> header must be set before you may\n+                access Galaxy.\n+                \"\"\"\n+                return self.error( start_response, title, message )\n+                ","path":"lib/galaxy/web/framework/middleware/remoteuser.py","position":17,"original_position":17,"commit_id":"63e30dac5d4a6b4be5176464e6f744fbb51c900f","original_commit_id":"63e30dac5d4a6b4be5176464e6f744fbb51c900f","user":{"login":"nsoranzo","id":4924623,"avatar_url":"https://avatars.githubusercontent.com/u/4924623?v=3","gravatar_id":"","url":"https://api.github.com/users/nsoranzo","html_url":"https://github.com/nsoranzo","followers_url":"https://api.github.com/users/nsoranzo/followers","following_url":"https://api.github.com/users/nsoranzo/following{/other_user}","gists_url":"https://api.github.com/users/nsoranzo/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoranzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoranzo/subscriptions","organizations_url":"https://api.github.com/users/nsoranzo/orgs","repos_url":"https://api.github.com/users/nsoranzo/repos","events_url":"https://api.github.com/users/nsoranzo/events{/privacy}","received_events_url":"https://api.github.com/users/nsoranzo/received_events","type":"User","site_admin":false},"body":"Can you also remove whitespaces from this empty line? Thanks!!","created_at":"2015-10-02T08:17:20Z","updated_at":"2015-10-02T08:17:20Z","html_url":"https://github.com/galaxyproject/galaxy/pull/827#discussion_r40999813","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/40999813"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/827#discussion_r40999813"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827","id":46569583,"html_url":"https://github.com/galaxyproject/galaxy/pull/827","diff_url":"https://github.com/galaxyproject/galaxy/pull/827.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/827.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/827","number":827,"state":"open","locked":false,"title":"Add check for HTTP_GX_SECRET","user":{"login":"golharam","id":671079,"avatar_url":"https://avatars.githubusercontent.com/u/671079?v=3","gravatar_id":"","url":"https://api.github.com/users/golharam","html_url":"https://github.com/golharam","followers_url":"https://api.github.com/users/golharam/followers","following_url":"https://api.github.com/users/golharam/following{/other_user}","gists_url":"https://api.github.com/users/golharam/gists{/gist_id}","starred_url":"https://api.github.com/users/golharam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golharam/subscriptions","organizations_url":"https://api.github.com/users/golharam/orgs","repos_url":"https://api.github.com/users/golharam/repos","events_url":"https://api.github.com/users/golharam/events{/privacy}","received_events_url":"https://api.github.com/users/golharam/received_events","type":"User","site_admin":false},"body":"If not provided, safe_str_cmp crashes and present debug trace log to user.","created_at":"2015-10-01T20:01:35Z","updated_at":"2015-10-02T08:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51debe91f5cf5c389d2e1bad76eb08dd119db72c","assignee":{"login":"erasche","id":458683,"avatar_url":"https://avatars.githubusercontent.com/u/458683?v=3","gravatar_id":"","url":"https://api.github.com/users/erasche","html_url":"https://github.com/erasche","followers_url":"https://api.github.com/users/erasche/followers","following_url":"https://api.github.com/users/erasche/following{/other_user}","gists_url":"https://api.github.com/users/erasche/gists{/gist_id}","starred_url":"https://api.github.com/users/erasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erasche/subscriptions","organizations_url":"https://api.github.com/users/erasche/orgs","repos_url":"https://api.github.com/users/erasche/repos","events_url":"https://api.github.com/users/erasche/events{/privacy}","received_events_url":"https://api.github.com/users/erasche/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/827/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/63e30dac5d4a6b4be5176464e6f744fbb51c900f","head":{"label":"golharam:patch-2","ref":"patch-2","sha":"63e30dac5d4a6b4be5176464e6f744fbb51c900f","user":{"login":"golharam","id":671079,"avatar_url":"https://avatars.githubusercontent.com/u/671079?v=3","gravatar_id":"","url":"https://api.github.com/users/golharam","html_url":"https://github.com/golharam","followers_url":"https://api.github.com/users/golharam/followers","following_url":"https://api.github.com/users/golharam/following{/other_user}","gists_url":"https://api.github.com/users/golharam/gists{/gist_id}","starred_url":"https://api.github.com/users/golharam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golharam/subscriptions","organizations_url":"https://api.github.com/users/golharam/orgs","repos_url":"https://api.github.com/users/golharam/repos","events_url":"https://api.github.com/users/golharam/events{/privacy}","received_events_url":"https://api.github.com/users/golharam/received_events","type":"User","site_admin":false},"repo":{"id":36388688,"name":"galaxy","full_name":"golharam/galaxy","owner":{"login":"golharam","id":671079,"avatar_url":"https://avatars.githubusercontent.com/u/671079?v=3","gravatar_id":"","url":"https://api.github.com/users/golharam","html_url":"https://github.com/golharam","followers_url":"https://api.github.com/users/golharam/followers","following_url":"https://api.github.com/users/golharam/following{/other_user}","gists_url":"https://api.github.com/users/golharam/gists{/gist_id}","starred_url":"https://api.github.com/users/golharam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golharam/subscriptions","organizations_url":"https://api.github.com/users/golharam/orgs","repos_url":"https://api.github.com/users/golharam/repos","events_url":"https://api.github.com/users/golharam/events{/privacy}","received_events_url":"https://api.github.com/users/golharam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/golharam/galaxy","description":"Data intensive biology for everyone.","fork":true,"url":"https://api.github.com/repos/golharam/galaxy","forks_url":"https://api.github.com/repos/golharam/galaxy/forks","keys_url":"https://api.github.com/repos/golharam/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golharam/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golharam/galaxy/teams","hooks_url":"https://api.github.com/repos/golharam/galaxy/hooks","issue_events_url":"https://api.github.com/repos/golharam/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/golharam/galaxy/events","assignees_url":"https://api.github.com/repos/golharam/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/golharam/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/golharam/galaxy/tags","blobs_url":"https://api.github.com/repos/golharam/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golharam/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golharam/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/golharam/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golharam/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/golharam/galaxy/languages","stargazers_url":"https://api.github.com/repos/golharam/galaxy/stargazers","contributors_url":"https://api.github.com/repos/golharam/galaxy/contributors","subscribers_url":"https://api.github.com/repos/golharam/galaxy/subscribers","subscription_url":"https://api.github.com/repos/golharam/galaxy/subscription","commits_url":"https://api.github.com/repos/golharam/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/golharam/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/golharam/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/golharam/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/golharam/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/golharam/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golharam/galaxy/merges","archive_url":"https://api.github.com/repos/golharam/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golharam/galaxy/downloads","issues_url":"https://api.github.com/repos/golharam/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/golharam/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/golharam/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/golharam/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golharam/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/golharam/galaxy/releases{/id}","created_at":"2015-05-27T18:54:15Z","updated_at":"2015-05-27T18:54:23Z","pushed_at":"2015-10-02T02:05:03Z","git_url":"git://github.com/golharam/galaxy.git","ssh_url":"git@github.com:golharam/galaxy.git","clone_url":"https://github.com/golharam/galaxy.git","svn_url":"https://github.com/golharam/galaxy","homepage":"http://galaxyproject.org/","size":60660,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"bf33c847e03ed0998f493c126c011fb492b07fb0","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars.githubusercontent.com/u/7937847?v=3","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive biology for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","created_at":"2015-02-23T14:18:06Z","updated_at":"2015-09-30T00:48:21Z","pushed_at":"2015-10-02T02:05:03Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"http://galaxyproject.org/","size":90181,"stargazers_count":70,"watchers_count":70,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":93,"forks":121,"open_issues":93,"watchers":70,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/827"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/827"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/827/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/827/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/63e30dac5d4a6b4be5176464e6f744fbb51c900f"}}}}