{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/29299343","id":29299343,"diff_hunk":"@@ -0,0 +1,14 @@\n+test_name \"Testing Master/Agent backwards compatibility\"\n+\n+# Agent running on the master is current, not legacy.\n+legacy_agents = agents.reject { |agent| agent == master }","path":"acceptance/suites/puppet3_tests/010_hello_world/testtest.rb","position":4,"original_position":4,"commit_id":"3f90c0e2a9ce3a091c707da20f426b08c78154f8","original_commit_id":"3f90c0e2a9ce3a091c707da20f426b08c78154f8","user":{"login":"waynr","id":1441126,"avatar_url":"https://avatars.githubusercontent.com/u/1441126?v=3","gravatar_id":"","url":"https://api.github.com/users/waynr","html_url":"https://github.com/waynr","followers_url":"https://api.github.com/users/waynr/followers","following_url":"https://api.github.com/users/waynr/following{/other_user}","gists_url":"https://api.github.com/users/waynr/gists{/gist_id}","starred_url":"https://api.github.com/users/waynr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waynr/subscriptions","organizations_url":"https://api.github.com/users/waynr/orgs","repos_url":"https://api.github.com/users/waynr/repos","events_url":"https://api.github.com/users/waynr/events{/privacy}","received_events_url":"https://api.github.com/users/waynr/received_events","type":"User","site_admin":false},"body":"The nomenclature here is a little strange, since it's not the fact that the agent machine isn't also the master that makes it \"legacy\", but the fact that it has puppet 3.x installed. I imagine this might be confusing for future readers of this code.","created_at":"2015-04-28T23:34:52Z","updated_at":"2015-04-28T23:34:52Z","html_url":"https://github.com/puppetlabs/puppet-server/pull/515#discussion_r29299343","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments/29299343"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/515#discussion_r29299343"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515","id":34313192,"html_url":"https://github.com/puppetlabs/puppet-server/pull/515","diff_url":"https://github.com/puppetlabs/puppet-server/pull/515.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/515.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/515","number":515,"state":"closed","locked":false,"title":"(SERVER-545) Add ability to test Puppet 3.x agents","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"body":"Without this patch there is no location to add acceptance tests that exercise\nPuppet 3.x agents against Puppet Server 2.0.  This patch addresses the problem\nby creating a new suite that maps to a new Jenkins job.  The pre_suite for this\nnew job will install Puppet 3.x legacy agents specified by the\nPUPPET_LEGACY_VERSION environment variable.","created_at":"2015-04-28T21:27:13Z","updated_at":"2015-04-28T23:34:53Z","closed_at":"2015-04-28T23:21:01Z","merged_at":"2015-04-28T23:21:01Z","merge_commit_sha":"a36793e477990b335f61fe6da6e8e826e7122bd3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/515/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/3f90c0e2a9ce3a091c707da20f426b08c78154f8","head":{"label":"jeffmccune:task/2.1.x/SERVER-545_beaker_puppet_3","ref":"task/2.1.x/SERVER-545_beaker_puppet_3","sha":"3f90c0e2a9ce3a091c707da20f426b08c78154f8","user":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"repo":{"id":26023101,"name":"puppet-server","full_name":"jeffmccune/puppet-server","owner":{"login":"jeffmccune","id":8972,"avatar_url":"https://avatars.githubusercontent.com/u/8972?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmccune","html_url":"https://github.com/jeffmccune","followers_url":"https://api.github.com/users/jeffmccune/followers","following_url":"https://api.github.com/users/jeffmccune/following{/other_user}","gists_url":"https://api.github.com/users/jeffmccune/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmccune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmccune/subscriptions","organizations_url":"https://api.github.com/users/jeffmccune/orgs","repos_url":"https://api.github.com/users/jeffmccune/repos","events_url":"https://api.github.com/users/jeffmccune/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmccune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmccune/puppet-server","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/jeffmccune/puppet-server","forks_url":"https://api.github.com/repos/jeffmccune/puppet-server/forks","keys_url":"https://api.github.com/repos/jeffmccune/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmccune/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmccune/puppet-server/teams","hooks_url":"https://api.github.com/repos/jeffmccune/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmccune/puppet-server/events","assignees_url":"https://api.github.com/repos/jeffmccune/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmccune/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/tags","blobs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmccune/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmccune/puppet-server/languages","stargazers_url":"https://api.github.com/repos/jeffmccune/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/jeffmccune/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/jeffmccune/puppet-server/subscription","commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmccune/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmccune/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmccune/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmccune/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmccune/puppet-server/merges","archive_url":"https://api.github.com/repos/jeffmccune/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmccune/puppet-server/downloads","issues_url":"https://api.github.com/repos/jeffmccune/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmccune/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmccune/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmccune/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmccune/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/jeffmccune/puppet-server/releases{/id}","created_at":"2014-10-31T16:07:28Z","updated_at":"2015-04-28T20:13:30Z","pushed_at":"2015-04-28T23:10:17Z","git_url":"git://github.com/jeffmccune/puppet-server.git","ssh_url":"git@github.com:jeffmccune/puppet-server.git","clone_url":"https://github.com/jeffmccune/puppet-server.git","svn_url":"https://github.com/jeffmccune/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":2693,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:2.1.x","ref":"2.1.x","sha":"d863c5aa92333dcb0e726908d91026a7545d37b2","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppet-server","full_name":"puppetlabs/puppet-server","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-server","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-server","forks_url":"https://api.github.com/repos/puppetlabs/puppet-server/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-server/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-server/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-server/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-server/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-server/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-server/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-server/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-server/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-server/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-server/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-server/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-server/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-server/releases{/id}","created_at":"2014-05-07T19:00:24Z","updated_at":"2015-04-27T14:09:16Z","pushed_at":"2015-04-28T23:21:01Z","git_url":"git://github.com/puppetlabs/puppet-server.git","ssh_url":"git@github.com:puppetlabs/puppet-server.git","clone_url":"https://github.com/puppetlabs/puppet-server.git","svn_url":"https://github.com/puppetlabs/puppet-server","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":6659,"stargazers_count":95,"watchers_count":95,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":5,"forks":50,"open_issues":5,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515"},"html":{"href":"https://github.com/puppetlabs/puppet-server/pull/515"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/515"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-server/statuses/3f90c0e2a9ce3a091c707da20f426b08c78154f8"}}}}