{"action":"closed","number":6371,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371","id":39152892,"html_url":"https://github.com/bitcoin/bitcoin/pull/6371","diff_url":"https://github.com/bitcoin/bitcoin/pull/6371.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6371.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6371","number":6371,"state":"closed","locked":false,"title":"banlist updates","user":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"body":"banlist: update set dirty to be more fine grained\r\n\r\n- move the SetBannedSetDirty(false) call from DumpData() into DumpBanlist()\r\n- ensure we only set false, if the write succeeded\r\n\r\nbanlist: better handling of banlist in StartNode()\r\n\r\n- only start working on/with banlist data, if reading in the banlist from\r\n  disk didn't fail\r\n- as CNode::setBannedIsDirty is false (default) when reading fails, we\r\n  don't need to explicitly set it to false to prevent writing banlist.dat\r\n  in that case either\r\n\r\nbanlist: add more banlist infos to log / add GUI signal\r\n\r\n- to match the peers.dat handling also supply a debug.log entry for how\r\n  many entries were loaded from banlist.dat and how long it took\r\n- add a GUI init message for loading the banlist (same as with peers.dat)\r\n\r\n- move the same message for peers.dat upwards in the code, to be able to\r\n  reuse the timing variable nStart and also just log, if our read from\r\n  peers.dat didn't fail\r\n\r\nbanlist (bugfix): allow CNode::SweepBanned() to run on interval\r\n\r\n- allows CNode::SweepBanned() to run, even if !CNode::BannedSetIsDirty(),\r\n  because if nBanUntil is over we want the ban to be disabled for these\r\n  nodes","created_at":"2015-07-03T07:49:07Z","updated_at":"2015-10-31T11:27:42Z","closed_at":"2015-10-31T11:27:42Z","merged_at":null,"merge_commit_sha":"5b3ef710451a50fd137675b43bb0cbf132796a42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6371/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/e8600c924d58f3ef0450fc269998452e5b17aecb","head":{"label":"Diapolo:banlist","ref":"banlist","sha":"e8600c924d58f3ef0450fc269998452e5b17aecb","user":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"repo":{"id":3744138,"name":"bitcoin","full_name":"Diapolo/bitcoin","owner":{"login":"Diapolo","id":1419649,"avatar_url":"https://avatars.githubusercontent.com/u/1419649?v=3","gravatar_id":"","url":"https://api.github.com/users/Diapolo","html_url":"https://github.com/Diapolo","followers_url":"https://api.github.com/users/Diapolo/followers","following_url":"https://api.github.com/users/Diapolo/following{/other_user}","gists_url":"https://api.github.com/users/Diapolo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diapolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diapolo/subscriptions","organizations_url":"https://api.github.com/users/Diapolo/orgs","repos_url":"https://api.github.com/users/Diapolo/repos","events_url":"https://api.github.com/users/Diapolo/events{/privacy}","received_events_url":"https://api.github.com/users/Diapolo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Diapolo/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/Diapolo/bitcoin","forks_url":"https://api.github.com/repos/Diapolo/bitcoin/forks","keys_url":"https://api.github.com/repos/Diapolo/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Diapolo/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Diapolo/bitcoin/teams","hooks_url":"https://api.github.com/repos/Diapolo/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/Diapolo/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/Diapolo/bitcoin/events","assignees_url":"https://api.github.com/repos/Diapolo/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/Diapolo/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/Diapolo/bitcoin/tags","blobs_url":"https://api.github.com/repos/Diapolo/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Diapolo/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Diapolo/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Diapolo/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Diapolo/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/Diapolo/bitcoin/languages","stargazers_url":"https://api.github.com/repos/Diapolo/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/Diapolo/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/Diapolo/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/Diapolo/bitcoin/subscription","commits_url":"https://api.github.com/repos/Diapolo/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Diapolo/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Diapolo/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Diapolo/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Diapolo/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/Diapolo/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Diapolo/bitcoin/merges","archive_url":"https://api.github.com/repos/Diapolo/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Diapolo/bitcoin/downloads","issues_url":"https://api.github.com/repos/Diapolo/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/Diapolo/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/Diapolo/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/Diapolo/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Diapolo/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/Diapolo/bitcoin/releases{/id}","created_at":"2012-03-16T23:43:46Z","updated_at":"2015-04-30T06:06:03Z","pushed_at":"2015-10-31T11:27:36Z","git_url":"git://github.com/Diapolo/bitcoin.git","ssh_url":"git@github.com:Diapolo/bitcoin.git","clone_url":"https://github.com/Diapolo/bitcoin.git","svn_url":"https://github.com/Diapolo/bitcoin","homepage":"http://www.bitcoin.org","size":56834,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"5ab5dca6f1bb1eccd47ea64834acc4fee0435b73","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","created_at":"2010-12-19T15:16:43Z","updated_at":"2015-10-31T05:05:20Z","pushed_at":"2015-10-31T10:07:33Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":143070,"stargazers_count":7709,"watchers_count":7709,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5315,"mirror_url":null,"open_issues_count":427,"forks":5315,"open_issues":427,"watchers":7709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/6371"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6371"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/6371/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6371/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/e8600c924d58f3ef0450fc269998452e5b17aecb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":19,"commits":4,"additions":30,"deletions":24,"changed_files":1}}