{"action":"created","issue":{"url":"https://api.github.com/repos/cmangos/issues/issues/749","labels_url":"https://api.github.com/repos/cmangos/issues/issues/749/labels{/name}","comments_url":"https://api.github.com/repos/cmangos/issues/issues/749/comments","events_url":"https://api.github.com/repos/cmangos/issues/issues/749/events","html_url":"https://github.com/cmangos/issues/issues/749","id":107332922,"number":749,"title":"[OS X] Build errors","user":{"login":"cala","id":1459044,"avatar_url":"https://avatars.githubusercontent.com/u/1459044?v=3","gravatar_id":"","url":"https://api.github.com/users/cala","html_url":"https://github.com/cala","followers_url":"https://api.github.com/users/cala/followers","following_url":"https://api.github.com/users/cala/following{/other_user}","gists_url":"https://api.github.com/users/cala/gists{/gist_id}","starred_url":"https://api.github.com/users/cala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cala/subscriptions","organizations_url":"https://api.github.com/users/cala/orgs","repos_url":"https://api.github.com/users/cala/repos","events_url":"https://api.github.com/users/cala/events{/privacy}","received_events_url":"https://api.github.com/users/cala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cmangos/issues/labels/System-Build","name":"System-Build","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"evil-at-wow","id":1056721,"avatar_url":"https://avatars.githubusercontent.com/u/1056721?v=3","gravatar_id":"","url":"https://api.github.com/users/evil-at-wow","html_url":"https://github.com/evil-at-wow","followers_url":"https://api.github.com/users/evil-at-wow/followers","following_url":"https://api.github.com/users/evil-at-wow/following{/other_user}","gists_url":"https://api.github.com/users/evil-at-wow/gists{/gist_id}","starred_url":"https://api.github.com/users/evil-at-wow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evil-at-wow/subscriptions","organizations_url":"https://api.github.com/users/evil-at-wow/orgs","repos_url":"https://api.github.com/users/evil-at-wow/repos","events_url":"https://api.github.com/users/evil-at-wow/events{/privacy}","received_events_url":"https://api.github.com/users/evil-at-wow/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-09-19T13:14:35Z","updated_at":"2015-09-20T22:06:32Z","closed_at":null,"body":"## Configuration\r\nI use Mac OS X 10.6.8 with XCode 3.2.6 and gcc 4.8.5\r\nAfter following the instructions from [here](https://github.com/evil-at-wow/cmangos-wotlk/commit/abaa4ef186fe843a2530980c0478ff572fafc6b5#commitcomment-13295632)\r\nCore revision: https://github.com/cmangos/mangos-wotlk/commit/62915db4d7ca219b419608f8a4845b9ad2ecb4fb\r\n\r\n## What happens\r\nI had the following errors when running `make` (`cmake` went fine):\r\n```\r\nIn file included from /Users/mangos/src/shared/Auth/HMACSHA1.h:22:0,\r\n                 from /Users/mangos/src/shared/Auth/HMACSHA1.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Auth/AuthCrypt.h:22:0,\r\n                 from /Users/mangos/src/shared/Auth/AuthCrypt.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Auth/Sha1.h:22:0,\r\n                 from /Users/mangos/src/shared/Auth/Sha1.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Auth/BigNumber.h:22:0,\r\n                 from /Users/mangos/src/shared/Auth/BigNumber.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Auth/SARC4.h:22:0,\r\n                 from /Users/mangos/src/shared/Auth/SARC4.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Config/Config.h:22:0,\r\n                 from /Users/mangos/src/shared/Config/Config.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Auth/Sha1.cpp.o] Error 1\r\nmake[2]: *** Waiting for unfinished jobs....\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Auth/BigNumber.cpp.o] Error 1\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Auth/HMACSHA1.cpp.o] Error 1\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Auth/AuthCrypt.cpp.o] Error 1\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Auth/SARC4.cpp.o] Error 1\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Config/Config.cpp.o] Error 1\r\nIn file included from /Users/mangos/src/shared/Database/DatabaseEnv.h:22:0,\r\n                 from /Users/mangos/src/shared/Database/Database.cpp:19:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nIn file included from /Users/mangos/src/shared/Util.h:22:0,\r\n                 from /Users/mangos/src/shared/Database/DatabaseMysql.cpp:21:\r\n/Users/mangos/src/shared/Common.h: In function 'float finiteAlways(float)':\r\n/Users/mangos/src/shared/Common.h:151:53: error: 'finite' was not declared in this scope\r\n inline float finiteAlways(float f) { return finite(f) ? f : 0.0f; }\r\n                                                     ^\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Database/Database.cpp.o] Error 1\r\nmake[2]: *** [src/shared/CMakeFiles/shared.dir/Database/DatabaseMysql.cpp.o] Error 1\r\nmake[1]: *** [src/shared/CMakeFiles/shared.dir/all] Error 2\r\nmake: *** [all] Error 2\r\n```\r\nI'm ready to run test or provide more feedback is needed. :)"},"comment":{"url":"https://api.github.com/repos/cmangos/issues/issues/comments/141840549","html_url":"https://github.com/cmangos/issues/issues/749#issuecomment-141840549","issue_url":"https://api.github.com/repos/cmangos/issues/issues/749","id":141840549,"user":{"login":"cala","id":1459044,"avatar_url":"https://avatars.githubusercontent.com/u/1459044?v=3","gravatar_id":"","url":"https://api.github.com/users/cala","html_url":"https://github.com/cala","followers_url":"https://api.github.com/users/cala/followers","following_url":"https://api.github.com/users/cala/following{/other_user}","gists_url":"https://api.github.com/users/cala/gists{/gist_id}","starred_url":"https://api.github.com/users/cala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cala/subscriptions","organizations_url":"https://api.github.com/users/cala/orgs","repos_url":"https://api.github.com/users/cala/repos","events_url":"https://api.github.com/users/cala/events{/privacy}","received_events_url":"https://api.github.com/users/cala/received_events","type":"User","site_admin":false},"created_at":"2015-09-20T22:06:32Z","updated_at":"2015-09-20T22:06:32Z","body":"I fixed the second error by changing the three calls of `finite()` in `/src/game/GridDefines.h` to `std::isfinite()`. The build now proceeds further (realmd is built). The first error remains along with all the nice warnings and some new warnings (several of them):\r\n```\r\n/Users/mangos/dep/include/gsoap/stdsoap2.h:1255:121: warning : invalid suffix on literal; C++11 requires a space between literal and identifier [-Wliteral-suffix]\r\n #  define DBGFUN3(FNAME, FMT1, ARG1, FMT2, ARG2, FMT3, ARG3) DBGLOG(TEST, SOAP_MESSAGE(fdebug, \"%s(%d): %s(\"FMT1\", \"FMT2\", \"FMT3\")\\n\", __FILE__, __LINE__, FNAME, (ARG1), (ARG2), (ARG3)))\r\n```"}}