{"action":"created","issue":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3317","labels_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3317/labels{/name}","comments_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3317/comments","events_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3317/events","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3317","id":119536421,"number":3317,"title":"Cleanup of TextInput definition and usage","user":{"login":"designedbyscience","id":22372,"avatar_url":"https://avatars.githubusercontent.com/u/22372?v=3","gravatar_id":"","url":"https://api.github.com/users/designedbyscience","html_url":"https://github.com/designedbyscience","followers_url":"https://api.github.com/users/designedbyscience/followers","following_url":"https://api.github.com/users/designedbyscience/following{/other_user}","gists_url":"https://api.github.com/users/designedbyscience/gists{/gist_id}","starred_url":"https://api.github.com/users/designedbyscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/designedbyscience/subscriptions","organizations_url":"https://api.github.com/users/designedbyscience/orgs","repos_url":"https://api.github.com/users/designedbyscience/repos","events_url":"https://api.github.com/users/designedbyscience/events{/privacy}","received_events_url":"https://api.github.com/users/designedbyscience/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"shaoshing","id":118264,"avatar_url":"https://avatars.githubusercontent.com/u/118264?v=3","gravatar_id":"","url":"https://api.github.com/users/shaoshing","html_url":"https://github.com/shaoshing","followers_url":"https://api.github.com/users/shaoshing/followers","following_url":"https://api.github.com/users/shaoshing/following{/other_user}","gists_url":"https://api.github.com/users/shaoshing/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoshing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoshing/subscriptions","organizations_url":"https://api.github.com/users/shaoshing/orgs","repos_url":"https://api.github.com/users/shaoshing/repos","events_url":"https://api.github.com/users/shaoshing/events{/privacy}","received_events_url":"https://api.github.com/users/shaoshing/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-11-30T17:09:01Z","updated_at":"2015-12-01T00:34:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/pulls/3317","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3317","diff_url":"https://github.com/adobe-photoshop/spaces-design/pull/3317.diff","patch_url":"https://github.com/adobe-photoshop/spaces-design/pull/3317.patch"},"body":"1. Removed property expansion in rendering the inputs\r\n2. `singleClick` and `live` seemingly accomplished the same goal. I renamed the property `doubleClickToEdit`, which is more informative than either of the other two, and set the default to `false`, since we only use this property in LayerFace and Library Assets\r\n3. `TextInput` does not use or need the `type` property. Removed\r\n4. `editable` and `disabled` also seemed to accomplish the same goal. Also, confusing with the `live` property. Condensed everything down to `disabled`\r\n5. `preventHorizontalScrolling` is used by elements with `doubleClickToEdit={true}`. I set this to default to `true`, as it doesn't harm anything and then allows us to not have 2 dependent properties that must be set in the usage of TextInput (not preventing horizontal scrolling is the exception)\r\n6. Fixed a typo in a CSS class name\r\n\r\nI'm going to update the specs, but high level, here are places where TextInput is used:\r\n* Export panel, suffix field\r\n* Layers panel, layer name\r\n* Libraries panel, creating a new library name input and asset names\r\n* Color panel, color string input\r\n* Datalists, all of them, including Search Bar\r\n"},"comment":{"url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/comments/160808979","html_url":"https://github.com/adobe-photoshop/spaces-design/pull/3317#issuecomment-160808979","issue_url":"https://api.github.com/repos/adobe-photoshop/spaces-design/issues/3317","id":160808979,"user":{"login":"shaoshing","id":118264,"avatar_url":"https://avatars.githubusercontent.com/u/118264?v=3","gravatar_id":"","url":"https://api.github.com/users/shaoshing","html_url":"https://github.com/shaoshing","followers_url":"https://api.github.com/users/shaoshing/followers","following_url":"https://api.github.com/users/shaoshing/following{/other_user}","gists_url":"https://api.github.com/users/shaoshing/gists{/gist_id}","starred_url":"https://api.github.com/users/shaoshing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaoshing/subscriptions","organizations_url":"https://api.github.com/users/shaoshing/orgs","repos_url":"https://api.github.com/users/shaoshing/repos","events_url":"https://api.github.com/users/shaoshing/events{/privacy}","received_events_url":"https://api.github.com/users/shaoshing/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T00:34:51Z","updated_at":"2015-12-01T00:34:51Z","body":"Hey @designedbyscience this looks awesome. Love the reduced number of params and the renames, and your detailed summary. I still have one question, then I am ready to merge it. :+1: "}}