{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/johnnoone/json-spec/pulls/8","id":54773234,"html_url":"https://github.com/johnnoone/json-spec/pull/8","diff_url":"https://github.com/johnnoone/json-spec/pull/8.diff","patch_url":"https://github.com/johnnoone/json-spec/pull/8.patch","issue_url":"https://api.github.com/repos/johnnoone/json-spec/issues/8","number":8,"state":"closed","locked":false,"title":"Improve subschema loading w fs provider","user":{"login":"rdowne","id":5874047,"avatar_url":"https://avatars.githubusercontent.com/u/5874047?v=3","gravatar_id":"","url":"https://api.github.com/users/rdowne","html_url":"https://github.com/rdowne","followers_url":"https://api.github.com/users/rdowne/followers","following_url":"https://api.github.com/users/rdowne/following{/other_user}","gists_url":"https://api.github.com/users/rdowne/gists{/gist_id}","starred_url":"https://api.github.com/users/rdowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdowne/subscriptions","organizations_url":"https://api.github.com/users/rdowne/orgs","repos_url":"https://api.github.com/users/rdowne/repos","events_url":"https://api.github.com/users/rdowne/events{/privacy}","received_events_url":"https://api.github.com/users/rdowne/received_events","type":"User","site_admin":false},"body":"Schemas that have version information in their names (e.g. \"/v1\") were failing to load with the FilesystemProvider, which uses as the spec a path fragment.  This PR modifies this, such that if a schema includes an \"id\" field, it replaces the spec with that value, such on the assumption that inbound references are more likely to use this value than the path fragment.\r\n\r\nAlso, the old \"util.loop\" function was slurping up *.pyc files in my __pycache__ dirs, so I replaced it with the simpler standard library module glob, which achieves the same functionality with less code.","created_at":"2015-12-30T02:19:42Z","updated_at":"2015-12-30T17:21:05Z","closed_at":"2015-12-30T17:21:05Z","merged_at":"2015-12-30T17:21:05Z","merge_commit_sha":"26bbae7249db883801bb876ee5f914454182edba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/johnnoone/json-spec/pulls/8/commits","review_comments_url":"https://api.github.com/repos/johnnoone/json-spec/pulls/8/comments","review_comment_url":"https://api.github.com/repos/johnnoone/json-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/johnnoone/json-spec/issues/8/comments","statuses_url":"https://api.github.com/repos/johnnoone/json-spec/statuses/4079f6445857b3c428650ca905aa6e9c9545ee40","head":{"label":"casetext:improve-subschema-loading-w-fs-provider","ref":"improve-subschema-loading-w-fs-provider","sha":"4079f6445857b3c428650ca905aa6e9c9545ee40","user":{"login":"casetext","id":5018617,"avatar_url":"https://avatars.githubusercontent.com/u/5018617?v=3","gravatar_id":"","url":"https://api.github.com/users/casetext","html_url":"https://github.com/casetext","followers_url":"https://api.github.com/users/casetext/followers","following_url":"https://api.github.com/users/casetext/following{/other_user}","gists_url":"https://api.github.com/users/casetext/gists{/gist_id}","starred_url":"https://api.github.com/users/casetext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casetext/subscriptions","organizations_url":"https://api.github.com/users/casetext/orgs","repos_url":"https://api.github.com/users/casetext/repos","events_url":"https://api.github.com/users/casetext/events{/privacy}","received_events_url":"https://api.github.com/users/casetext/received_events","type":"Organization","site_admin":false},"repo":{"id":48775907,"name":"json-spec","full_name":"casetext/json-spec","owner":{"login":"casetext","id":5018617,"avatar_url":"https://avatars.githubusercontent.com/u/5018617?v=3","gravatar_id":"","url":"https://api.github.com/users/casetext","html_url":"https://github.com/casetext","followers_url":"https://api.github.com/users/casetext/followers","following_url":"https://api.github.com/users/casetext/following{/other_user}","gists_url":"https://api.github.com/users/casetext/gists{/gist_id}","starred_url":"https://api.github.com/users/casetext/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casetext/subscriptions","organizations_url":"https://api.github.com/users/casetext/orgs","repos_url":"https://api.github.com/users/casetext/repos","events_url":"https://api.github.com/users/casetext/events{/privacy}","received_events_url":"https://api.github.com/users/casetext/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/casetext/json-spec","description":"Implements some tools for JSON","fork":true,"url":"https://api.github.com/repos/casetext/json-spec","forks_url":"https://api.github.com/repos/casetext/json-spec/forks","keys_url":"https://api.github.com/repos/casetext/json-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/casetext/json-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/casetext/json-spec/teams","hooks_url":"https://api.github.com/repos/casetext/json-spec/hooks","issue_events_url":"https://api.github.com/repos/casetext/json-spec/issues/events{/number}","events_url":"https://api.github.com/repos/casetext/json-spec/events","assignees_url":"https://api.github.com/repos/casetext/json-spec/assignees{/user}","branches_url":"https://api.github.com/repos/casetext/json-spec/branches{/branch}","tags_url":"https://api.github.com/repos/casetext/json-spec/tags","blobs_url":"https://api.github.com/repos/casetext/json-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/casetext/json-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/casetext/json-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/casetext/json-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/casetext/json-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/casetext/json-spec/languages","stargazers_url":"https://api.github.com/repos/casetext/json-spec/stargazers","contributors_url":"https://api.github.com/repos/casetext/json-spec/contributors","subscribers_url":"https://api.github.com/repos/casetext/json-spec/subscribers","subscription_url":"https://api.github.com/repos/casetext/json-spec/subscription","commits_url":"https://api.github.com/repos/casetext/json-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/casetext/json-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/casetext/json-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/casetext/json-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/casetext/json-spec/contents/{+path}","compare_url":"https://api.github.com/repos/casetext/json-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/casetext/json-spec/merges","archive_url":"https://api.github.com/repos/casetext/json-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/casetext/json-spec/downloads","issues_url":"https://api.github.com/repos/casetext/json-spec/issues{/number}","pulls_url":"https://api.github.com/repos/casetext/json-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/casetext/json-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/casetext/json-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/casetext/json-spec/labels{/name}","releases_url":"https://api.github.com/repos/casetext/json-spec/releases{/id}","created_at":"2015-12-30T01:58:49Z","updated_at":"2015-12-30T01:58:50Z","pushed_at":"2015-12-30T02:15:24Z","git_url":"git://github.com/casetext/json-spec.git","ssh_url":"git@github.com:casetext/json-spec.git","clone_url":"https://github.com/casetext/json-spec.git","svn_url":"https://github.com/casetext/json-spec","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"johnnoone:master","ref":"master","sha":"c968293dcb0687a645c0a6d3830976d1cf230970","user":{"login":"johnnoone","id":81812,"avatar_url":"https://avatars.githubusercontent.com/u/81812?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnoone","html_url":"https://github.com/johnnoone","followers_url":"https://api.github.com/users/johnnoone/followers","following_url":"https://api.github.com/users/johnnoone/following{/other_user}","gists_url":"https://api.github.com/users/johnnoone/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnoone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnoone/subscriptions","organizations_url":"https://api.github.com/users/johnnoone/orgs","repos_url":"https://api.github.com/users/johnnoone/repos","events_url":"https://api.github.com/users/johnnoone/events{/privacy}","received_events_url":"https://api.github.com/users/johnnoone/received_events","type":"User","site_admin":false},"repo":{"id":20410039,"name":"json-spec","full_name":"johnnoone/json-spec","owner":{"login":"johnnoone","id":81812,"avatar_url":"https://avatars.githubusercontent.com/u/81812?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnoone","html_url":"https://github.com/johnnoone","followers_url":"https://api.github.com/users/johnnoone/followers","following_url":"https://api.github.com/users/johnnoone/following{/other_user}","gists_url":"https://api.github.com/users/johnnoone/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnoone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnoone/subscriptions","organizations_url":"https://api.github.com/users/johnnoone/orgs","repos_url":"https://api.github.com/users/johnnoone/repos","events_url":"https://api.github.com/users/johnnoone/events{/privacy}","received_events_url":"https://api.github.com/users/johnnoone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnnoone/json-spec","description":"Implements some tools for JSON","fork":false,"url":"https://api.github.com/repos/johnnoone/json-spec","forks_url":"https://api.github.com/repos/johnnoone/json-spec/forks","keys_url":"https://api.github.com/repos/johnnoone/json-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnnoone/json-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnnoone/json-spec/teams","hooks_url":"https://api.github.com/repos/johnnoone/json-spec/hooks","issue_events_url":"https://api.github.com/repos/johnnoone/json-spec/issues/events{/number}","events_url":"https://api.github.com/repos/johnnoone/json-spec/events","assignees_url":"https://api.github.com/repos/johnnoone/json-spec/assignees{/user}","branches_url":"https://api.github.com/repos/johnnoone/json-spec/branches{/branch}","tags_url":"https://api.github.com/repos/johnnoone/json-spec/tags","blobs_url":"https://api.github.com/repos/johnnoone/json-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnnoone/json-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnnoone/json-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnnoone/json-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnnoone/json-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/johnnoone/json-spec/languages","stargazers_url":"https://api.github.com/repos/johnnoone/json-spec/stargazers","contributors_url":"https://api.github.com/repos/johnnoone/json-spec/contributors","subscribers_url":"https://api.github.com/repos/johnnoone/json-spec/subscribers","subscription_url":"https://api.github.com/repos/johnnoone/json-spec/subscription","commits_url":"https://api.github.com/repos/johnnoone/json-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnnoone/json-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnnoone/json-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnnoone/json-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnnoone/json-spec/contents/{+path}","compare_url":"https://api.github.com/repos/johnnoone/json-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnnoone/json-spec/merges","archive_url":"https://api.github.com/repos/johnnoone/json-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnnoone/json-spec/downloads","issues_url":"https://api.github.com/repos/johnnoone/json-spec/issues{/number}","pulls_url":"https://api.github.com/repos/johnnoone/json-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/johnnoone/json-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/johnnoone/json-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnnoone/json-spec/labels{/name}","releases_url":"https://api.github.com/repos/johnnoone/json-spec/releases{/id}","created_at":"2014-06-02T15:59:44Z","updated_at":"2015-10-21T06:29:43Z","pushed_at":"2015-12-30T17:21:05Z","git_url":"git://github.com/johnnoone/json-spec.git","ssh_url":"git@github.com:johnnoone/json-spec.git","clone_url":"https://github.com/johnnoone/json-spec.git","svn_url":"https://github.com/johnnoone/json-spec","homepage":null,"size":292,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/johnnoone/json-spec/pulls/8"},"html":{"href":"https://github.com/johnnoone/json-spec/pull/8"},"issue":{"href":"https://api.github.com/repos/johnnoone/json-spec/issues/8"},"comments":{"href":"https://api.github.com/repos/johnnoone/json-spec/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/johnnoone/json-spec/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/johnnoone/json-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/johnnoone/json-spec/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/johnnoone/json-spec/statuses/4079f6445857b3c428650ca905aa6e9c9545ee40"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"johnnoone","id":81812,"avatar_url":"https://avatars.githubusercontent.com/u/81812?v=3","gravatar_id":"","url":"https://api.github.com/users/johnnoone","html_url":"https://github.com/johnnoone","followers_url":"https://api.github.com/users/johnnoone/followers","following_url":"https://api.github.com/users/johnnoone/following{/other_user}","gists_url":"https://api.github.com/users/johnnoone/gists{/gist_id}","starred_url":"https://api.github.com/users/johnnoone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnnoone/subscriptions","organizations_url":"https://api.github.com/users/johnnoone/orgs","repos_url":"https://api.github.com/users/johnnoone/repos","events_url":"https://api.github.com/users/johnnoone/events{/privacy}","received_events_url":"https://api.github.com/users/johnnoone/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":8,"deletions":18,"changed_files":2}}