{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379","labels_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379/events","html_url":"https://github.com/puppetlabs/puppet-server/pull/379","id":56312764,"number":379,"title":"(SERVER-206) Close client on scripting container termination","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-02T23:56:52Z","updated_at":"2015-02-04T23:57:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/pulls/379","html_url":"https://github.com/puppetlabs/puppet-server/pull/379","diff_url":"https://github.com/puppetlabs/puppet-server/pull/379.diff","patch_url":"https://github.com/puppetlabs/puppet-server/pull/379.patch"},"body":"Add in a new `terminate` method to the master that closes the HTTP client and call it before terminating the JRuby scripting container.\r\n\r\nI'm definitely looking for some feedback on this one. In particular, I'm not sure about testing. I was having trouble figuring out how to test this. I did add a test to ensure that the master termination function works as intended, but wasn't sure how to write a test to ensure a client is closed before we destroy its scripting container, so any feedback or suggestions on that front are very much appreciated."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/comments/72966800","html_url":"https://github.com/puppetlabs/puppet-server/pull/379#issuecomment-72966800","issue_url":"https://api.github.com/repos/puppetlabs/puppet-server/issues/379","id":72966800,"user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T23:57:11Z","updated_at":"2015-02-04T23:57:11Z","body":"@cprice404 I've addressed your comments."}}