{"action":"opened","number":4258,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258","id":45336360,"html_url":"https://github.com/puppetlabs/puppet/pull/4258","diff_url":"https://github.com/puppetlabs/puppet/pull/4258.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4258.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4258","number":4258,"state":"open","locked":false,"title":"(PUP-1963) allow dependencies on/for generated resources","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"body":"Previously, generated resources could not have edge metaprams or\r\nparticipate in autorequire, since they were created AFTER those\r\ntransformations had occured on the catalog. This changes resource\r\ngeneration to occur before those transformations.\r\n\r\nBecause of this, the containment edges for generated resources now end\r\nup in the final relationship graph. This caused issues with purged\r\nresources, since the purge check now sees that a whit depends on the\r\npurged resource. This was resolved by excluding whits from the purge\r\nsafety check. Since whits can only be generated by containment edges,\r\nand generated resources previously could not have containment edges,\r\nthis is not a breaking change.\r\n\r\nIn order to maintain manifest ordering, it is necessary to add the\r\ngenerated resources into the catalog adjacent to the generating\r\nresource. This is achieved with new helpers on the catalog class to\r\nhandle ordered insertions.\r\n\r\nExisting spec tests handle verifying manifest ordering works correctly\r\nfor generated resources, and integration tests for things like\r\nresource purging handle reasonably complex generation cases. New tests\r\nhave been added only for the new edges that are being generated after\r\nthis commit.","created_at":"2015-09-17T20:15:22Z","updated_at":"2015-09-17T20:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4258/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/c984514d3b0bd61aa16b6f7519d8bb943f0ed8b8","head":{"label":"branan:bug/master/pup-1963-generate-resource-before-graph","ref":"bug/master/pup-1963-generate-resource-before-graph","sha":"c984514d3b0bd61aa16b6f7519d8bb943f0ed8b8","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"repo":{"id":5719668,"name":"puppet","full_name":"branan/puppet","owner":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/branan/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/branan/puppet","forks_url":"https://api.github.com/repos/branan/puppet/forks","keys_url":"https://api.github.com/repos/branan/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branan/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branan/puppet/teams","hooks_url":"https://api.github.com/repos/branan/puppet/hooks","issue_events_url":"https://api.github.com/repos/branan/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/branan/puppet/events","assignees_url":"https://api.github.com/repos/branan/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/branan/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/branan/puppet/tags","blobs_url":"https://api.github.com/repos/branan/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branan/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branan/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/branan/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branan/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/branan/puppet/languages","stargazers_url":"https://api.github.com/repos/branan/puppet/stargazers","contributors_url":"https://api.github.com/repos/branan/puppet/contributors","subscribers_url":"https://api.github.com/repos/branan/puppet/subscribers","subscription_url":"https://api.github.com/repos/branan/puppet/subscription","commits_url":"https://api.github.com/repos/branan/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/branan/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/branan/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/branan/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/branan/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/branan/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branan/puppet/merges","archive_url":"https://api.github.com/repos/branan/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branan/puppet/downloads","issues_url":"https://api.github.com/repos/branan/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/branan/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/branan/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/branan/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branan/puppet/labels{/name}","releases_url":"https://api.github.com/repos/branan/puppet/releases{/id}","created_at":"2012-09-07T16:54:25Z","updated_at":"2015-04-02T22:11:41Z","pushed_at":"2015-09-17T20:15:07Z","git_url":"git://github.com/branan/puppet.git","ssh_url":"git@github.com:branan/puppet.git","clone_url":"https://github.com/branan/puppet.git","svn_url":"https://github.com/branan/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":52633,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"4447a32a70d97d12594c1a6872f58931e4428ab0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-09-17T13:37:31Z","pushed_at":"2015-09-17T18:16:01Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":119343,"stargazers_count":3538,"watchers_count":3538,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1476,"mirror_url":null,"open_issues_count":35,"forks":1476,"open_issues":35,"watchers":3538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4258"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4258"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4258/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4258/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/c984514d3b0bd61aa16b6f7519d8bb943f0ed8b8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":183,"deletions":25,"changed_files":6}}