{"action":"created","issue":{"url":"https://api.github.com/repos/isRuslan/vim-es6/issues/5","labels_url":"https://api.github.com/repos/isRuslan/vim-es6/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/isRuslan/vim-es6/issues/5/comments","events_url":"https://api.github.com/repos/isRuslan/vim-es6/issues/5/events","html_url":"https://github.com/isRuslan/vim-es6/pull/5","id":113224259,"number":5,"title":"Some improvements to snippets code and to syntax highlighting","user":{"login":"s0ber","id":763624,"avatar_url":"https://avatars.githubusercontent.com/u/763624?v=3","gravatar_id":"","url":"https://api.github.com/users/s0ber","html_url":"https://github.com/s0ber","followers_url":"https://api.github.com/users/s0ber/followers","following_url":"https://api.github.com/users/s0ber/following{/other_user}","gists_url":"https://api.github.com/users/s0ber/gists{/gist_id}","starred_url":"https://api.github.com/users/s0ber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s0ber/subscriptions","organizations_url":"https://api.github.com/users/s0ber/orgs","repos_url":"https://api.github.com/users/s0ber/repos","events_url":"https://api.github.com/users/s0ber/events{/privacy}","received_events_url":"https://api.github.com/users/s0ber/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-25T12:54:32Z","updated_at":"2015-10-25T16:20:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/isRuslan/vim-es6/pulls/5","html_url":"https://github.com/isRuslan/vim-es6/pull/5","diff_url":"https://github.com/isRuslan/vim-es6/pull/5.diff","patch_url":"https://github.com/isRuslan/vim-es6/pull/5.patch"},"body":"@isRuslan Hi there! First of all, thanks for your package! It is very handy and useful. I've played with it a little bit, and found some small things, which can be improved. So, there are my changes.\r\n\r\nFirst of all, I've decided to use single quotes everywhere, due to AirBnb codestyle (which is commonly adopted by js community):\r\nhttps://github.com/airbnb/javascript#6.1\r\n\r\nI also removed snippets indenting, which was there by default.\r\n\r\nAlso, your syntax highlighting is great! But it doesn't solve indentation problems. So, whenever you press \"enter\", vim cursor will likely be in the beginning of the string. And to solve this, I just copypasted vim-javascript indentations rules. It works ok so far.\r\n\r\nAnother small issue, that was hurting me — `=>` snippet was not working in the middle of the string. I've fixed this only for UltiSnips snippet. (I've tried to use both of them, UltiSnips and Snipmate, and found out, that UltiSnips is more stable and simple.)\r\n\r\nAnd the last thing — there is small improvement to class declaration.\r\n\r\nI hope those changes are useful."},"comment":{"url":"https://api.github.com/repos/isRuslan/vim-es6/issues/comments/150938548","html_url":"https://github.com/isRuslan/vim-es6/pull/5#issuecomment-150938548","issue_url":"https://api.github.com/repos/isRuslan/vim-es6/issues/5","id":150938548,"user":{"login":"isRuslan","id":2136166,"avatar_url":"https://avatars.githubusercontent.com/u/2136166?v=3","gravatar_id":"","url":"https://api.github.com/users/isRuslan","html_url":"https://github.com/isRuslan","followers_url":"https://api.github.com/users/isRuslan/followers","following_url":"https://api.github.com/users/isRuslan/following{/other_user}","gists_url":"https://api.github.com/users/isRuslan/gists{/gist_id}","starred_url":"https://api.github.com/users/isRuslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isRuslan/subscriptions","organizations_url":"https://api.github.com/users/isRuslan/orgs","repos_url":"https://api.github.com/users/isRuslan/repos","events_url":"https://api.github.com/users/isRuslan/events{/privacy}","received_events_url":"https://api.github.com/users/isRuslan/received_events","type":"User","site_admin":false},"created_at":"2015-10-25T16:20:26Z","updated_at":"2015-10-25T16:20:26Z","body":"Wow, what are nice and useful changes, thanks @s0ber :+1: \r\nWe need indentation support here, to not be depend on other javascript-like vim-plugins, that's true.\r\nSo `vim-javascript/indent` be copy pasted here for a while, then I'll refresh it.\r\nThank for PR, this will be published as `v2.1`"}}