{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/54","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/54/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/54/events","html_url":"https://github.com/puppetlabs/puppetlabs-rsync/pull/54","id":53131612,"number":54,"title":"Private exec","user":{"login":"decibelhertz","id":3743131,"avatar_url":"https://avatars.githubusercontent.com/u/3743131?v=3","gravatar_id":"","url":"https://api.github.com/users/decibelhertz","html_url":"https://github.com/decibelhertz","followers_url":"https://api.github.com/users/decibelhertz/followers","following_url":"https://api.github.com/users/decibelhertz/following{/other_user}","gists_url":"https://api.github.com/users/decibelhertz/gists{/gist_id}","starred_url":"https://api.github.com/users/decibelhertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibelhertz/subscriptions","organizations_url":"https://api.github.com/users/decibelhertz/orgs","repos_url":"https://api.github.com/users/decibelhertz/repos","events_url":"https://api.github.com/users/decibelhertz/events{/privacy}","received_events_url":"https://api.github.com/users/decibelhertz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-12-30T17:28:32Z","updated_at":"2015-01-27T17:19:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/pulls/54","html_url":"https://github.com/puppetlabs/puppetlabs-rsync/pull/54","diff_url":"https://github.com/puppetlabs/puppetlabs-rsync/pull/54.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-rsync/pull/54.patch"},"body":"This PR addresses the same issue brought up in https://github.com/puppetlabs/puppetlabs-rsync/pull/45 and then some.\r\n\r\nIt also uses more functions to do input validation for `rsync::get` and `rsync::put` as well as makes a private type, `rsync::exec` that *put* and *get* are essentially wrapper for.\r\n\r\nRsync can also work with `rsync://` protocol, too.  So we should support that.  As the spec tests will now show, it also separates `$keyfile` and `$user`, since SSH does a better job of hunting for a user's key than a fixed, Linux-specific path as the default and we do not need to set *rsh* when using the *rsync* protocol."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/comments/71687647","html_url":"https://github.com/puppetlabs/puppetlabs-rsync/pull/54#issuecomment-71687647","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-rsync/issues/54","id":71687647,"user":{"login":"decibelhertz","id":3743131,"avatar_url":"https://avatars.githubusercontent.com/u/3743131?v=3","gravatar_id":"","url":"https://api.github.com/users/decibelhertz","html_url":"https://github.com/decibelhertz","followers_url":"https://api.github.com/users/decibelhertz/followers","following_url":"https://api.github.com/users/decibelhertz/following{/other_user}","gists_url":"https://api.github.com/users/decibelhertz/gists{/gist_id}","starred_url":"https://api.github.com/users/decibelhertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibelhertz/subscriptions","organizations_url":"https://api.github.com/users/decibelhertz/orgs","repos_url":"https://api.github.com/users/decibelhertz/repos","events_url":"https://api.github.com/users/decibelhertz/events{/privacy}","received_events_url":"https://api.github.com/users/decibelhertz/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T17:19:17Z","updated_at":"2015-01-27T17:19:17Z","body":"Thanks; that's about what I figured.  Got the _type_ working well; I need a few spare cycles to get the _provider_ happy..."}}