{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/34259691","id":34259691,"diff_hunk":"@@ -1212,31 +1316,52 @@ def apply_role(role, inst, in_queue)\n           end\n \n           old_nodes.each do |node_name|\n-            # Don't add deleted nodes to the run order\n+            # Don't add deleted nodes to the run order, they clearly won't have the old role\n             if NodeObject.find_node_by_name(node_name).nil?\n               @logger.debug \"skipping deleted node #{node_name}\"\n               next\n             end\n \n+            # An old node that is not in the new deployment, drop it\n             if new_nodes.nil? or !new_nodes.include?(node_name)\n               @logger.debug \"remove node #{node_name}\"\n               pending_node_actions[node_name] = { :remove => [], :add => [] } if pending_node_actions[node_name].nil?\n+\n               pending_node_actions[node_name][:remove] << role_name\n+\n+              # Remove roles are  a way to \"de-configure\" things on the node\n+              # when a role is not used anymore for that node. For instance, stopping a","path":"crowbar_framework/app/models/service_object.rb","position":369,"original_position":369,"commit_id":"63c46d33d9658602a64d58c2a6c1d09a40cdb52d","original_commit_id":"63c46d33d9658602a64d58c2a6c1d09a40cdb52d","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Metrics/LineLength: Line is too long. [87/80]","created_at":"2015-07-09T14:20:54Z","updated_at":"2015-07-09T14:20:54Z","html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1308#discussion_r34259691","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/34259691"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1308#discussion_r34259691"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308","id":39588085,"html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1308","diff_url":"https://github.com/crowbar/barclamp-crowbar/pull/1308.diff","patch_url":"https://github.com/crowbar/barclamp-crowbar/pull/1308.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1308","number":1308,"state":"open","locked":false,"title":"Comment the deployment and queueing processes","user":{"login":"bkutil","id":696026,"avatar_url":"https://avatars.githubusercontent.com/u/696026?v=3","gravatar_id":"","url":"https://api.github.com/users/bkutil","html_url":"https://github.com/bkutil","followers_url":"https://api.github.com/users/bkutil/followers","following_url":"https://api.github.com/users/bkutil/following{/other_user}","gists_url":"https://api.github.com/users/bkutil/gists{/gist_id}","starred_url":"https://api.github.com/users/bkutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkutil/subscriptions","organizations_url":"https://api.github.com/users/bkutil/orgs","repos_url":"https://api.github.com/users/bkutil/repos","events_url":"https://api.github.com/users/bkutil/events{/privacy}","received_events_url":"https://api.github.com/users/bkutil/received_events","type":"User","site_admin":false},"body":"Except for `elems` -> `roles` rename at https://github.com/crowbar/barclamp-crowbar/compare/master...bkutil:deployment_queue?expand=1#diff-0be8ea1f05c9441a59bb2b7ac65b1c62R1292 only adds documentation.","created_at":"2015-07-09T14:20:34Z","updated_at":"2015-07-09T14:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4cf2d18e18a1e66f87bb62443604bec749aae33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1308/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/63c46d33d9658602a64d58c2a6c1d09a40cdb52d","head":{"label":"bkutil:deployment_queue","ref":"deployment_queue","sha":"63c46d33d9658602a64d58c2a6c1d09a40cdb52d","user":{"login":"bkutil","id":696026,"avatar_url":"https://avatars.githubusercontent.com/u/696026?v=3","gravatar_id":"","url":"https://api.github.com/users/bkutil","html_url":"https://github.com/bkutil","followers_url":"https://api.github.com/users/bkutil/followers","following_url":"https://api.github.com/users/bkutil/following{/other_user}","gists_url":"https://api.github.com/users/bkutil/gists{/gist_id}","starred_url":"https://api.github.com/users/bkutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkutil/subscriptions","organizations_url":"https://api.github.com/users/bkutil/orgs","repos_url":"https://api.github.com/users/bkutil/repos","events_url":"https://api.github.com/users/bkutil/events{/privacy}","received_events_url":"https://api.github.com/users/bkutil/received_events","type":"User","site_admin":false},"repo":{"id":14868638,"name":"barclamp-crowbar","full_name":"bkutil/barclamp-crowbar","owner":{"login":"bkutil","id":696026,"avatar_url":"https://avatars.githubusercontent.com/u/696026?v=3","gravatar_id":"","url":"https://api.github.com/users/bkutil","html_url":"https://github.com/bkutil","followers_url":"https://api.github.com/users/bkutil/followers","following_url":"https://api.github.com/users/bkutil/following{/other_user}","gists_url":"https://api.github.com/users/bkutil/gists{/gist_id}","starred_url":"https://api.github.com/users/bkutil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkutil/subscriptions","organizations_url":"https://api.github.com/users/bkutil/orgs","repos_url":"https://api.github.com/users/bkutil/repos","events_url":"https://api.github.com/users/bkutil/events{/privacy}","received_events_url":"https://api.github.com/users/bkutil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkutil/barclamp-crowbar","description":"Crowbar Core Barclamp","fork":true,"url":"https://api.github.com/repos/bkutil/barclamp-crowbar","forks_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/bkutil/barclamp-crowbar/releases{/id}","created_at":"2013-12-02T16:54:48Z","updated_at":"2015-05-06T08:28:30Z","pushed_at":"2015-07-09T14:18:52Z","git_url":"git://github.com/bkutil/barclamp-crowbar.git","ssh_url":"git@github.com:bkutil/barclamp-crowbar.git","clone_url":"https://github.com/bkutil/barclamp-crowbar.git","svn_url":"https://github.com/bkutil/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":41659,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"46d837a890db77e116ec7e04cdc5e48fad504d7e","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351384,"name":"barclamp-crowbar","full_name":"crowbar/barclamp-crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-crowbar","description":"Crowbar Core: Core Application","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-crowbar","forks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/releases{/id}","created_at":"2011-09-08T20:47:56Z","updated_at":"2015-06-22T23:56:07Z","pushed_at":"2015-07-09T14:20:35Z","git_url":"git://github.com/crowbar/barclamp-crowbar.git","ssh_url":"git@github.com:crowbar/barclamp-crowbar.git","clone_url":"https://github.com/crowbar/barclamp-crowbar.git","svn_url":"https://github.com/crowbar/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":40894,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":16,"forks":191,"open_issues":16,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1308"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1308"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1308/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1308/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/63c46d33d9658602a64d58c2a6c1d09a40cdb52d"}}}}