{"action":"created","comment":{"url":"https://api.github.com/repos/postgis/postgis/pulls/comments/45992299","id":45992299,"diff_hunk":"@@ -1833,7 +1833,7 @@ extern size_t gserialized_from_lwgeom_size(const LWGEOM *geom);\n * will contain the size of the final output, which is useful for setting the PgSQL \n * VARSIZE information.\n */\n-extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, int is_geodetic, size_t *size);\n+extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, size_t *size);","path":"liblwgeom/liblwgeom.h.in","position":5,"original_position":5,"commit_id":"c4b758a867c507d978b1481d26ad95c2644065a8","original_commit_id":"c4b758a867c507d978b1481d26ad95c2644065a8","user":{"login":"robe2","id":4734450,"avatar_url":"https://avatars.githubusercontent.com/u/4734450?v=3","gravatar_id":"","url":"https://api.github.com/users/robe2","html_url":"https://github.com/robe2","followers_url":"https://api.github.com/users/robe2/followers","following_url":"https://api.github.com/users/robe2/following{/other_user}","gists_url":"https://api.github.com/users/robe2/gists{/gist_id}","starred_url":"https://api.github.com/users/robe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robe2/subscriptions","organizations_url":"https://api.github.com/users/robe2/orgs","repos_url":"https://api.github.com/users/robe2/repos","events_url":"https://api.github.com/users/robe2/events{/privacy}","received_events_url":"https://api.github.com/users/robe2/received_events","type":"User","site_admin":false},"body":"@pramsey   Can you look at this before my pull becomes stale and I have to redo it again.","created_at":"2015-11-26T16:06:05Z","updated_at":"2015-11-26T16:06:05Z","html_url":"https://github.com/postgis/postgis/pull/72#discussion_r45992299","pull_request_url":"https://api.github.com/repos/postgis/postgis/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/postgis/postgis/pulls/comments/45992299"},"html":{"href":"https://github.com/postgis/postgis/pull/72#discussion_r45992299"},"pull_request":{"href":"https://api.github.com/repos/postgis/postgis/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/postgis/postgis/pulls/72","id":51044935,"html_url":"https://github.com/postgis/postgis/pull/72","diff_url":"https://github.com/postgis/postgis/pull/72.diff","patch_url":"https://github.com/postgis/postgis/pull/72.patch","issue_url":"https://api.github.com/repos/postgis/postgis/issues/72","number":72,"state":"open","locked":false,"title":"#3361 gserialized_from_lwgeom takes is_geodetic arg but does nothing with it, geography_serialize may give you a geometry if not careful","user":{"login":"robe2","id":4734450,"avatar_url":"https://avatars.githubusercontent.com/u/4734450?v=3","gravatar_id":"","url":"https://api.github.com/users/robe2","html_url":"https://github.com/robe2","followers_url":"https://api.github.com/users/robe2/followers","following_url":"https://api.github.com/users/robe2/following{/other_user}","gists_url":"https://api.github.com/users/robe2/gists{/gist_id}","starred_url":"https://api.github.com/users/robe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robe2/subscriptions","organizations_url":"https://api.github.com/users/robe2/orgs","repos_url":"https://api.github.com/users/robe2/repos","events_url":"https://api.github.com/users/robe2/events{/privacy}","received_events_url":"https://api.github.com/users/robe2/received_events","type":"User","site_admin":false},"body":"This is to get rid of the bogus is_geodetic in gserialized_from_lwgeom that gets passed around in numerous functions, but actually does nothing.\r\n\r\nIn doing so I also changed geography_measurment.c - geography_point_outside  -- the original code suggested that it was supposed to return a geography, but since is_geodetic does nothing, it was probably just returning a geometry.  I couldn't find where this function is used, so perhaps it's not even used and just an artifact of bigone years","created_at":"2015-11-18T05:42:19Z","updated_at":"2015-11-26T16:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"830a7ee17b80d04742e0d10fd9b4f48bcd6517ee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/postgis/postgis/pulls/72/commits","review_comments_url":"https://api.github.com/repos/postgis/postgis/pulls/72/comments","review_comment_url":"https://api.github.com/repos/postgis/postgis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postgis/postgis/issues/72/comments","statuses_url":"https://api.github.com/repos/postgis/postgis/statuses/c4b758a867c507d978b1481d26ad95c2644065a8","head":{"label":"robe2:svn-trunk","ref":"svn-trunk","sha":"c4b758a867c507d978b1481d26ad95c2644065a8","user":{"login":"robe2","id":4734450,"avatar_url":"https://avatars.githubusercontent.com/u/4734450?v=3","gravatar_id":"","url":"https://api.github.com/users/robe2","html_url":"https://github.com/robe2","followers_url":"https://api.github.com/users/robe2/followers","following_url":"https://api.github.com/users/robe2/following{/other_user}","gists_url":"https://api.github.com/users/robe2/gists{/gist_id}","starred_url":"https://api.github.com/users/robe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robe2/subscriptions","organizations_url":"https://api.github.com/users/robe2/orgs","repos_url":"https://api.github.com/users/robe2/repos","events_url":"https://api.github.com/users/robe2/events{/privacy}","received_events_url":"https://api.github.com/users/robe2/received_events","type":"User","site_admin":false},"repo":{"id":46277018,"name":"postgis","full_name":"robe2/postgis","owner":{"login":"robe2","id":4734450,"avatar_url":"https://avatars.githubusercontent.com/u/4734450?v=3","gravatar_id":"","url":"https://api.github.com/users/robe2","html_url":"https://github.com/robe2","followers_url":"https://api.github.com/users/robe2/followers","following_url":"https://api.github.com/users/robe2/following{/other_user}","gists_url":"https://api.github.com/users/robe2/gists{/gist_id}","starred_url":"https://api.github.com/users/robe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robe2/subscriptions","organizations_url":"https://api.github.com/users/robe2/orgs","repos_url":"https://api.github.com/users/robe2/repos","events_url":"https://api.github.com/users/robe2/events{/privacy}","received_events_url":"https://api.github.com/users/robe2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robe2/postgis","description":"PostGIS spatial database extension to PostgreSQL [mirror]","fork":true,"url":"https://api.github.com/repos/robe2/postgis","forks_url":"https://api.github.com/repos/robe2/postgis/forks","keys_url":"https://api.github.com/repos/robe2/postgis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robe2/postgis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robe2/postgis/teams","hooks_url":"https://api.github.com/repos/robe2/postgis/hooks","issue_events_url":"https://api.github.com/repos/robe2/postgis/issues/events{/number}","events_url":"https://api.github.com/repos/robe2/postgis/events","assignees_url":"https://api.github.com/repos/robe2/postgis/assignees{/user}","branches_url":"https://api.github.com/repos/robe2/postgis/branches{/branch}","tags_url":"https://api.github.com/repos/robe2/postgis/tags","blobs_url":"https://api.github.com/repos/robe2/postgis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robe2/postgis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robe2/postgis/git/refs{/sha}","trees_url":"https://api.github.com/repos/robe2/postgis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robe2/postgis/statuses/{sha}","languages_url":"https://api.github.com/repos/robe2/postgis/languages","stargazers_url":"https://api.github.com/repos/robe2/postgis/stargazers","contributors_url":"https://api.github.com/repos/robe2/postgis/contributors","subscribers_url":"https://api.github.com/repos/robe2/postgis/subscribers","subscription_url":"https://api.github.com/repos/robe2/postgis/subscription","commits_url":"https://api.github.com/repos/robe2/postgis/commits{/sha}","git_commits_url":"https://api.github.com/repos/robe2/postgis/git/commits{/sha}","comments_url":"https://api.github.com/repos/robe2/postgis/comments{/number}","issue_comment_url":"https://api.github.com/repos/robe2/postgis/issues/comments{/number}","contents_url":"https://api.github.com/repos/robe2/postgis/contents/{+path}","compare_url":"https://api.github.com/repos/robe2/postgis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robe2/postgis/merges","archive_url":"https://api.github.com/repos/robe2/postgis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robe2/postgis/downloads","issues_url":"https://api.github.com/repos/robe2/postgis/issues{/number}","pulls_url":"https://api.github.com/repos/robe2/postgis/pulls{/number}","milestones_url":"https://api.github.com/repos/robe2/postgis/milestones{/number}","notifications_url":"https://api.github.com/repos/robe2/postgis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robe2/postgis/labels{/name}","releases_url":"https://api.github.com/repos/robe2/postgis/releases{/id}","created_at":"2015-11-16T13:43:05Z","updated_at":"2015-11-16T13:43:17Z","pushed_at":"2015-11-18T05:38:32Z","git_url":"git://github.com/robe2/postgis.git","ssh_url":"git@github.com:robe2/postgis.git","clone_url":"https://github.com/robe2/postgis.git","svn_url":"https://github.com/robe2/postgis","homepage":"","size":43633,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"svn-trunk"}},"base":{"label":"postgis:svn-trunk","ref":"svn-trunk","sha":"7af035d7c10fb181b47b5c2f084b4c6a1c918022","user":{"login":"postgis","id":1759716,"avatar_url":"https://avatars.githubusercontent.com/u/1759716?v=3","gravatar_id":"","url":"https://api.github.com/users/postgis","html_url":"https://github.com/postgis","followers_url":"https://api.github.com/users/postgis/followers","following_url":"https://api.github.com/users/postgis/following{/other_user}","gists_url":"https://api.github.com/users/postgis/gists{/gist_id}","starred_url":"https://api.github.com/users/postgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postgis/subscriptions","organizations_url":"https://api.github.com/users/postgis/orgs","repos_url":"https://api.github.com/users/postgis/repos","events_url":"https://api.github.com/users/postgis/events{/privacy}","received_events_url":"https://api.github.com/users/postgis/received_events","type":"Organization","site_admin":false},"repo":{"id":4407129,"name":"postgis","full_name":"postgis/postgis","owner":{"login":"postgis","id":1759716,"avatar_url":"https://avatars.githubusercontent.com/u/1759716?v=3","gravatar_id":"","url":"https://api.github.com/users/postgis","html_url":"https://github.com/postgis","followers_url":"https://api.github.com/users/postgis/followers","following_url":"https://api.github.com/users/postgis/following{/other_user}","gists_url":"https://api.github.com/users/postgis/gists{/gist_id}","starred_url":"https://api.github.com/users/postgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postgis/subscriptions","organizations_url":"https://api.github.com/users/postgis/orgs","repos_url":"https://api.github.com/users/postgis/repos","events_url":"https://api.github.com/users/postgis/events{/privacy}","received_events_url":"https://api.github.com/users/postgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postgis/postgis","description":"PostGIS spatial database extension to PostgreSQL [mirror]","fork":false,"url":"https://api.github.com/repos/postgis/postgis","forks_url":"https://api.github.com/repos/postgis/postgis/forks","keys_url":"https://api.github.com/repos/postgis/postgis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postgis/postgis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postgis/postgis/teams","hooks_url":"https://api.github.com/repos/postgis/postgis/hooks","issue_events_url":"https://api.github.com/repos/postgis/postgis/issues/events{/number}","events_url":"https://api.github.com/repos/postgis/postgis/events","assignees_url":"https://api.github.com/repos/postgis/postgis/assignees{/user}","branches_url":"https://api.github.com/repos/postgis/postgis/branches{/branch}","tags_url":"https://api.github.com/repos/postgis/postgis/tags","blobs_url":"https://api.github.com/repos/postgis/postgis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postgis/postgis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postgis/postgis/git/refs{/sha}","trees_url":"https://api.github.com/repos/postgis/postgis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postgis/postgis/statuses/{sha}","languages_url":"https://api.github.com/repos/postgis/postgis/languages","stargazers_url":"https://api.github.com/repos/postgis/postgis/stargazers","contributors_url":"https://api.github.com/repos/postgis/postgis/contributors","subscribers_url":"https://api.github.com/repos/postgis/postgis/subscribers","subscription_url":"https://api.github.com/repos/postgis/postgis/subscription","commits_url":"https://api.github.com/repos/postgis/postgis/commits{/sha}","git_commits_url":"https://api.github.com/repos/postgis/postgis/git/commits{/sha}","comments_url":"https://api.github.com/repos/postgis/postgis/comments{/number}","issue_comment_url":"https://api.github.com/repos/postgis/postgis/issues/comments{/number}","contents_url":"https://api.github.com/repos/postgis/postgis/contents/{+path}","compare_url":"https://api.github.com/repos/postgis/postgis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postgis/postgis/merges","archive_url":"https://api.github.com/repos/postgis/postgis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postgis/postgis/downloads","issues_url":"https://api.github.com/repos/postgis/postgis/issues{/number}","pulls_url":"https://api.github.com/repos/postgis/postgis/pulls{/number}","milestones_url":"https://api.github.com/repos/postgis/postgis/milestones{/number}","notifications_url":"https://api.github.com/repos/postgis/postgis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postgis/postgis/labels{/name}","releases_url":"https://api.github.com/repos/postgis/postgis/releases{/id}","created_at":"2012-05-22T13:31:25Z","updated_at":"2015-11-25T02:06:21Z","pushed_at":"2015-11-26T14:35:50Z","git_url":"git://github.com/postgis/postgis.git","ssh_url":"git@github.com:postgis/postgis.git","clone_url":"https://github.com/postgis/postgis.git","svn_url":"https://github.com/postgis/postgis","homepage":"","size":40263,"stargazers_count":226,"watchers_count":226,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":12,"forks":114,"open_issues":12,"watchers":226,"default_branch":"svn-trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/postgis/postgis/pulls/72"},"html":{"href":"https://github.com/postgis/postgis/pull/72"},"issue":{"href":"https://api.github.com/repos/postgis/postgis/issues/72"},"comments":{"href":"https://api.github.com/repos/postgis/postgis/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/postgis/postgis/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/postgis/postgis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postgis/postgis/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/postgis/postgis/statuses/c4b758a867c507d978b1481d26ad95c2644065a8"}}}}