{"action":"created","comment":{"url":"https://api.github.com/repos/opal/opal/pulls/comments/32731216","id":32731216,"diff_hunk":"@@ -1114,4 +1114,9 @@ def to_s\n   end\n \n   alias untaint taint\n+\n+  def Rational(*args)\n+    #Just a stub to let unrelated rubyspecs run.\n+    nil","path":"opal/corelib/kernel.rb","position":7,"original_position":7,"commit_id":"8c5c1131eaac3cbca97f8a0178c677671e45ef84","original_commit_id":"8c5c1131eaac3cbca97f8a0178c677671e45ef84","user":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"body":"@elia, it would be better, but then it fails with an exception, which I cannot use `fails` to filter out. I mean having it raise a NotImplementedError is no different in this case than the original NoMethodError that prompted me to add this stub. I agree, this is not pretty. The real solution is to go ahead and implement Rational, I guess :smile: ","created_at":"2015-06-18T13:51:00Z","updated_at":"2015-06-18T13:51:00Z","html_url":"https://github.com/opal/opal/pull/940#discussion_r32731216","pull_request_url":"https://api.github.com/repos/opal/opal/pulls/940","_links":{"self":{"href":"https://api.github.com/repos/opal/opal/pulls/comments/32731216"},"html":{"href":"https://github.com/opal/opal/pull/940#discussion_r32731216"},"pull_request":{"href":"https://api.github.com/repos/opal/opal/pulls/940"}}},"pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/940","id":38003760,"html_url":"https://github.com/opal/opal/pull/940","diff_url":"https://github.com/opal/opal/pull/940.diff","patch_url":"https://github.com/opal/opal/pull/940.patch","issue_url":"https://api.github.com/repos/opal/opal/issues/940","number":940,"state":"open","locked":false,"title":"Run all of RubySpec (that is within Opal's scope)","user":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"body":"The following is a list of 25 remaining RubySpecs we are *NOT* running as of this PR:\r\n\r\n* argf\r\n* bignum\r\n* binding\r\n* complex\r\n* continuation\r\n* dir\r\n* encoding\r\n* env\r\n* fiber\r\n* file\r\n* filetest\r\n* gc\r\n* io\r\n* main\r\n* marshal\r\n* mutex\r\n* objectspace\r\n* process\r\n* random\r\n* rational\r\n* signal\r\n* symbol\r\n* systemexit\r\n* thread\r\n* threadgroup\r\n\r\nAs of this PR, the total number of RubySpecs Opal is passing is :sparkles:6227:sparkles: This PR marks the end of the free lunch - from now on getting another hundred passing specs will be hard work :smile: \r\n\r\n:beers: ","created_at":"2015-06-18T13:02:21Z","updated_at":"2015-06-18T13:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c423658603549c3f4fbfece56184e1dc840a678","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opal/opal/pulls/940/commits","review_comments_url":"https://api.github.com/repos/opal/opal/pulls/940/comments","review_comment_url":"https://api.github.com/repos/opal/opal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opal/opal/issues/940/comments","statuses_url":"https://api.github.com/repos/opal/opal/statuses/8c5c1131eaac3cbca97f8a0178c677671e45ef84","head":{"label":"vais:rubyspecs","ref":"rubyspecs","sha":"8c5c1131eaac3cbca97f8a0178c677671e45ef84","user":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"repo":{"id":30140782,"name":"opal","full_name":"vais/opal","owner":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vais/opal","description":"Ruby to Javascript compiler","fork":true,"url":"https://api.github.com/repos/vais/opal","forks_url":"https://api.github.com/repos/vais/opal/forks","keys_url":"https://api.github.com/repos/vais/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vais/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vais/opal/teams","hooks_url":"https://api.github.com/repos/vais/opal/hooks","issue_events_url":"https://api.github.com/repos/vais/opal/issues/events{/number}","events_url":"https://api.github.com/repos/vais/opal/events","assignees_url":"https://api.github.com/repos/vais/opal/assignees{/user}","branches_url":"https://api.github.com/repos/vais/opal/branches{/branch}","tags_url":"https://api.github.com/repos/vais/opal/tags","blobs_url":"https://api.github.com/repos/vais/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vais/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vais/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/vais/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vais/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/vais/opal/languages","stargazers_url":"https://api.github.com/repos/vais/opal/stargazers","contributors_url":"https://api.github.com/repos/vais/opal/contributors","subscribers_url":"https://api.github.com/repos/vais/opal/subscribers","subscription_url":"https://api.github.com/repos/vais/opal/subscription","commits_url":"https://api.github.com/repos/vais/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/vais/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/vais/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/vais/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/vais/opal/contents/{+path}","compare_url":"https://api.github.com/repos/vais/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vais/opal/merges","archive_url":"https://api.github.com/repos/vais/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vais/opal/downloads","issues_url":"https://api.github.com/repos/vais/opal/issues{/number}","pulls_url":"https://api.github.com/repos/vais/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/vais/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/vais/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vais/opal/labels{/name}","releases_url":"https://api.github.com/repos/vais/opal/releases{/id}","created_at":"2015-02-01T08:29:46Z","updated_at":"2015-05-07T23:01:15Z","pushed_at":"2015-06-18T12:47:15Z","git_url":"git://github.com/vais/opal.git","ssh_url":"git@github.com:vais/opal.git","clone_url":"https://github.com/vais/opal.git","svn_url":"https://github.com/vais/opal","homepage":"http://opalrb.org","size":10343,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opal:master","ref":"master","sha":"effab6b70432cc14a40a06d3be932e92a22079e9","user":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"repo":{"id":184366,"name":"opal","full_name":"opal/opal","owner":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opal/opal","description":"Ruby to Javascript compiler","fork":false,"url":"https://api.github.com/repos/opal/opal","forks_url":"https://api.github.com/repos/opal/opal/forks","keys_url":"https://api.github.com/repos/opal/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opal/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opal/opal/teams","hooks_url":"https://api.github.com/repos/opal/opal/hooks","issue_events_url":"https://api.github.com/repos/opal/opal/issues/events{/number}","events_url":"https://api.github.com/repos/opal/opal/events","assignees_url":"https://api.github.com/repos/opal/opal/assignees{/user}","branches_url":"https://api.github.com/repos/opal/opal/branches{/branch}","tags_url":"https://api.github.com/repos/opal/opal/tags","blobs_url":"https://api.github.com/repos/opal/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opal/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opal/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opal/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opal/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/opal/opal/languages","stargazers_url":"https://api.github.com/repos/opal/opal/stargazers","contributors_url":"https://api.github.com/repos/opal/opal/contributors","subscribers_url":"https://api.github.com/repos/opal/opal/subscribers","subscription_url":"https://api.github.com/repos/opal/opal/subscription","commits_url":"https://api.github.com/repos/opal/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opal/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opal/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opal/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/opal/opal/contents/{+path}","compare_url":"https://api.github.com/repos/opal/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opal/opal/merges","archive_url":"https://api.github.com/repos/opal/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opal/opal/downloads","issues_url":"https://api.github.com/repos/opal/opal/issues{/number}","pulls_url":"https://api.github.com/repos/opal/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/opal/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/opal/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opal/opal/labels{/name}","releases_url":"https://api.github.com/repos/opal/opal/releases{/id}","created_at":"2009-04-24T08:53:34Z","updated_at":"2015-06-18T12:36:25Z","pushed_at":"2015-06-18T13:02:21Z","git_url":"git://github.com/opal/opal.git","ssh_url":"git@github.com:opal/opal.git","clone_url":"https://github.com/opal/opal.git","svn_url":"https://github.com/opal/opal","homepage":"http://opalrb.org","size":21058,"stargazers_count":2570,"watchers_count":2570,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":161,"mirror_url":null,"open_issues_count":118,"forks":161,"open_issues":118,"watchers":2570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opal/opal/pulls/940"},"html":{"href":"https://github.com/opal/opal/pull/940"},"issue":{"href":"https://api.github.com/repos/opal/opal/issues/940"},"comments":{"href":"https://api.github.com/repos/opal/opal/issues/940/comments"},"review_comments":{"href":"https://api.github.com/repos/opal/opal/pulls/940/comments"},"review_comment":{"href":"https://api.github.com/repos/opal/opal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opal/opal/pulls/940/commits"},"statuses":{"href":"https://api.github.com/repos/opal/opal/statuses/8c5c1131eaac3cbca97f8a0178c677671e45ef84"}}}}