{"action":"created","issue":{"url":"https://api.github.com/repos/getlantern/lantern/issues/2363","labels_url":"https://api.github.com/repos/getlantern/lantern/issues/2363/labels{/name}","comments_url":"https://api.github.com/repos/getlantern/lantern/issues/2363/comments","events_url":"https://api.github.com/repos/getlantern/lantern/issues/2363/events","html_url":"https://github.com/getlantern/lantern/issues/2363","id":66725588,"number":2363,"title":"Can we consolidate flashlight and lantern mobile more","user":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=3","gravatar_id":"","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/getlantern/lantern/labels/P1","name":"P1","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/getlantern/lantern/milestones/88","html_url":"https://github.com/getlantern/lantern/milestones/2.0%20Beta%206","labels_url":"https://api.github.com/repos/getlantern/lantern/milestones/88/labels","id":1046270,"number":88,"title":"2.0 Beta 6","description":"","creator":{"login":"myleshorton","id":1143966,"avatar_url":"https://avatars.githubusercontent.com/u/1143966?v=3","gravatar_id":"","url":"https://api.github.com/users/myleshorton","html_url":"https://github.com/myleshorton","followers_url":"https://api.github.com/users/myleshorton/followers","following_url":"https://api.github.com/users/myleshorton/following{/other_user}","gists_url":"https://api.github.com/users/myleshorton/gists{/gist_id}","starred_url":"https://api.github.com/users/myleshorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myleshorton/subscriptions","organizations_url":"https://api.github.com/users/myleshorton/orgs","repos_url":"https://api.github.com/users/myleshorton/repos","events_url":"https://api.github.com/users/myleshorton/events{/privacy}","received_events_url":"https://api.github.com/users/myleshorton/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":4,"state":"open","created_at":"2015-03-31T04:24:47Z","updated_at":"2015-04-07T17:25:12Z","due_on":"2015-04-30T07:00:00Z","closed_at":null},"comments":6,"created_at":"2015-04-06T22:58:33Z","updated_at":"2015-04-07T18:27:12Z","closed_at":null,"body":"Particularly the cloud.yaml."},"comment":{"url":"https://api.github.com/repos/getlantern/lantern/issues/comments/90690003","html_url":"https://github.com/getlantern/lantern/issues/2363#issuecomment-90690003","issue_url":"https://api.github.com/repos/getlantern/lantern/issues/2363","id":90690003,"user":{"login":"xiam","id":385670,"avatar_url":"https://avatars.githubusercontent.com/u/385670?v=3","gravatar_id":"","url":"https://api.github.com/users/xiam","html_url":"https://github.com/xiam","followers_url":"https://api.github.com/users/xiam/followers","following_url":"https://api.github.com/users/xiam/following{/other_user}","gists_url":"https://api.github.com/users/xiam/gists{/gist_id}","starred_url":"https://api.github.com/users/xiam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiam/subscriptions","organizations_url":"https://api.github.com/users/xiam/orgs","repos_url":"https://api.github.com/users/xiam/repos","events_url":"https://api.github.com/users/xiam/events{/privacy}","received_events_url":"https://api.github.com/users/xiam/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T18:27:11Z","updated_at":"2015-04-07T18:27:11Z","body":"I recall my first attempt was fixing this with build tags on the same codebase, and we ended up ditching all that because it was becoming far too complex. But it was based on code for another branch.\r\n\r\nThings may be easier now with the valencia branch, but we'll still have some problems derived from things we don't really need on Android, such as parsing flags, systray stuff, auto-updates (they won't even work), other thing was that flashlight required writing configuration files to disk and that was not trivially possible with Android. So it may be easier, but we'll probably end up adding a lot of conditional build tags again (and Go source files for supporting those build tags), just like my first attempt.\r\n\r\nI think we should start thinking and working on this on this right now, but I don't think we can have this completely sorted by the end of this week, maybe we can make a proper list of problems, discuss them and devise a plan.\r\n\r\nThe good thing about lantern-android and FireTweet is that they're completely independent from each other and we could replace the lantern-android backend anytime without changing Android code.\r\n\r\nI think releasing FireTweet would have a bigger impact than having a single codebase for flashlight-build, so we could keep on focusing on FireTweet and only add the things that are strictly required in lantern-android in order to make FireTweet faster. Having a single code base would definitely benefit us as Lantern developers, but it's not as easy as it may look and it would probably delay FireTweet for our users.\r\n\r\nI'll start with this list, maybe the problem is not as big as it seems. In the meantime I suggest we keep using lantern-android for FireTweet, and just add the strictly required features from flashlight-build, such as logging with loggly and geolocation.\r\n\r\nWhat do you think @atavism, @myleshorton?"}}