{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/31297005","id":31297005,"diff_hunk":"@@ -0,0 +1,203 @@\n+package controllers\n+\n+import (\n+\t\"encoding/json\"\n+\t\"reflect\"\n+\t\"time\"\n+\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/api\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/client\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/client/cache\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/controller/framework\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/credentialprovider\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/fields\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/labels\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/runtime\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/util\"\n+\t\"github.com/GoogleCloudPlatform/kubernetes/pkg/watch\"\n+\t\"github.com/golang/glog\"\n+)\n+\n+// DockerRegistryServiceControllerOptions contains options for the DockerRegistryServiceController\n+type DockerRegistryServiceControllerOptions struct {\n+\t// Resync is the time.Duration at which to fully re-list service accounts.\n+\t// If zero, re-list will be delayed as long as possible\n+\tResync time.Duration\n+\n+\tRegistryNamespace string\n+\n+\tRegistryServiceName string\n+\n+\tDockercfgController *DockercfgController\n+}\n+\n+// NewDockerRegistryServiceController returns a new *DockerRegistryServiceController.\n+func NewDockerRegistryServiceController(cl client.Interface, options DockerRegistryServiceControllerOptions) *DockerRegistryServiceController {\n+\te := &DockerRegistryServiceController{\n+\t\tclient: cl,\n+\t}\n+\n+\t_, e.serviceController = framework.NewInformer(\n+\t\t&cache.ListWatch{\n+\t\t\tListFunc: func() (runtime.Object, error) {\n+\t\t\t\treturn e.client.Services(options.RegistryNamespace).List(labels.Everything())\n+\t\t\t},\n+\t\t\tWatchFunc: func(rv string) (watch.Interface, error) {\n+\t\t\t\treturn e.client.Services(options.RegistryNamespace).Watch(labels.Everything(), fields.Everything(), rv)\n+\t\t\t},\n+\t\t},\n+\t\t&api.Service{},\n+\t\toptions.Resync,\n+\t\tframework.ResourceEventHandlerFuncs{\n+\t\t\tAddFunc:    e.serviceAdded,\n+\t\t\tUpdateFunc: e.serviceUpdated,\n+\t\t\tDeleteFunc: e.serviceDeleted,\n+\t\t},\n+\t)\n+\te.registryServiceName = options.RegistryServiceName\n+\te.dockercfgController = options.DockercfgController\n+\n+\treturn e\n+}\n+\n+// DockerRegistryServiceController manages ServiceToken secrets for Service objects\n+type DockerRegistryServiceController struct {\n+\tstopChan chan struct{}\n+\n+\tclient client.Interface\n+\n+\tregistryServiceName string\n+\n+\tdockercfgController *DockercfgController\n+\n+\tserviceController *framework.Controller\n+}\n+\n+// Runs controller loops and returns immediately\n+func (e *DockerRegistryServiceController) Run() {\n+\tif e.stopChan == nil {\n+\t\te.stopChan = make(chan struct{})\n+\t\tgo e.serviceController.Run(e.stopChan)\n+\t}\n+}\n+\n+// Stop gracefully shuts down this controller\n+func (e *DockerRegistryServiceController) Stop() {\n+\tif e.stopChan != nil {\n+\t\tclose(e.stopChan)\n+\t\te.stopChan = nil\n+\t}\n+}\n+\n+// serviceAdded reacts to the creation of a docker-registry service by updating all service account dockercfg secrets and\n+// changing all interestedURLs\n+func (e *DockerRegistryServiceController) serviceAdded(obj interface{}) {\n+\tservice := obj.(*api.Service)\n+\tif service.Name != e.registryServiceName {\n+\t\treturn\n+\t}\n+\n+\tserviceLocation := service.Spec.PortalIP\n+\tif len(serviceLocation) == 0 {\n+\t\tserviceLocation = OpenshiftDockerURL\n+\t}\n+\n+\tif err := e.handleLocationChange(serviceLocation); err != nil {\n+\t\tglog.Error(err)\n+\t}\n+}\n+\n+// serviceUpdated reacts to the creation of a docker-registry service by updating all service account dockercfg secrets and\n+// changing all interestedURLs, if needed\n+func (e *DockerRegistryServiceController) serviceUpdated(oldObj interface{}, newObj interface{}) {\n+\toldService := oldObj.(*api.Service)\n+\tnewService := newObj.(*api.Service)\n+\tif newService.Name != e.registryServiceName {\n+\t\treturn\n+\t}\n+\tif oldService.Spec.PortalIP == newService.Spec.PortalIP {\n+\t\treturn\n+\t}\n+\n+\tserviceLocation := newService.Spec.PortalIP\n+\tif len(serviceLocation) == 0 {\n+\t\tserviceLocation = OpenshiftDockerURL\n+\t}\n+\n+\tif err := e.handleLocationChange(serviceLocation); err != nil {\n+\t\tglog.Error(err)\n+\t}\n+}\n+\n+// serviceDeleted reacts to a Service deletion by deleting all corresponding ServiceToken Secrets","path":"pkg/serviceaccounts/controllers/docker_registry_service.go","position":132,"original_position":132,"commit_id":"17f92833228fe3b988b019eff15261b93127c23c","original_commit_id":"17f92833228fe3b988b019eff15261b93127c23c","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"fix comment","created_at":"2015-05-29T03:39:39Z","updated_at":"2015-05-29T03:39:39Z","html_url":"https://github.com/openshift/origin/pull/2507#discussion_r31297005","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2507","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/31297005"},"html":{"href":"https://github.com/openshift/origin/pull/2507#discussion_r31297005"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2507"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2507","id":36239039,"html_url":"https://github.com/openshift/origin/pull/2507","diff_url":"https://github.com/openshift/origin/pull/2507.diff","patch_url":"https://github.com/openshift/origin/pull/2507.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2507","number":2507,"state":"open","locked":false,"title":"auto-generate dockercfg secrets for service accounts","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"This adds a new service account controller that watches for added or deleted service account tokens and creates or deletes corresponding dockercfg secrets accordingly.  It automatically adds/removes references to the service accounts pull secrets and mountable secrets lists.\r\n\r\n@liggitt ptal","created_at":"2015-05-26T19:54:02Z","updated_at":"2015-05-29T03:39:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72639023bd7c4c0c1b9464c52c5c9de87629f7dd","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/4","html_url":"https://github.com/openshift/origin/milestones/0.6.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/4/labels","id":1057504,"number":4,"title":"0.6.0","description":"","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":32,"state":"open","created_at":"2015-04-08T03:08:19Z","updated_at":"2015-05-28T23:13:33Z","due_on":"2015-06-15T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2507/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2507/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2507/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/17f92833228fe3b988b019eff15261b93127c23c","head":{"label":"deads2k:auto-generate-pull-secret","ref":"auto-generate-pull-secret","sha":"17f92833228fe3b988b019eff15261b93127c23c","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"repo":{"id":24424126,"name":"origin","full_name":"deads2k/origin","owner":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deads2k/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/deads2k/origin","forks_url":"https://api.github.com/repos/deads2k/origin/forks","keys_url":"https://api.github.com/repos/deads2k/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deads2k/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deads2k/origin/teams","hooks_url":"https://api.github.com/repos/deads2k/origin/hooks","issue_events_url":"https://api.github.com/repos/deads2k/origin/issues/events{/number}","events_url":"https://api.github.com/repos/deads2k/origin/events","assignees_url":"https://api.github.com/repos/deads2k/origin/assignees{/user}","branches_url":"https://api.github.com/repos/deads2k/origin/branches{/branch}","tags_url":"https://api.github.com/repos/deads2k/origin/tags","blobs_url":"https://api.github.com/repos/deads2k/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deads2k/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deads2k/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/deads2k/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deads2k/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/deads2k/origin/languages","stargazers_url":"https://api.github.com/repos/deads2k/origin/stargazers","contributors_url":"https://api.github.com/repos/deads2k/origin/contributors","subscribers_url":"https://api.github.com/repos/deads2k/origin/subscribers","subscription_url":"https://api.github.com/repos/deads2k/origin/subscription","commits_url":"https://api.github.com/repos/deads2k/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/deads2k/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/deads2k/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/deads2k/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/deads2k/origin/contents/{+path}","compare_url":"https://api.github.com/repos/deads2k/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deads2k/origin/merges","archive_url":"https://api.github.com/repos/deads2k/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deads2k/origin/downloads","issues_url":"https://api.github.com/repos/deads2k/origin/issues{/number}","pulls_url":"https://api.github.com/repos/deads2k/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/deads2k/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/deads2k/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deads2k/origin/labels{/name}","releases_url":"https://api.github.com/repos/deads2k/origin/releases{/id}","created_at":"2014-09-24T17:02:12Z","updated_at":"2015-05-08T15:45:28Z","pushed_at":"2015-05-28T19:58:15Z","git_url":"git://github.com/deads2k/origin.git","ssh_url":"git@github.com:deads2k/origin.git","clone_url":"https://github.com/deads2k/origin.git","svn_url":"https://github.com/deads2k/origin","homepage":"https://openshift.github.io","size":112034,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"84b3ba91612c712676bb689b95872f4121fc5b8e","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-05-28T21:42:42Z","pushed_at":"2015-05-29T03:25:19Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":174910,"stargazers_count":441,"watchers_count":441,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":220,"mirror_url":null,"open_issues_count":237,"forks":220,"open_issues":237,"watchers":441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2507"},"html":{"href":"https://github.com/openshift/origin/pull/2507"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2507"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2507/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2507/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2507/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/17f92833228fe3b988b019eff15261b93127c23c"}}}}