{"action":"closed","number":4754,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754","id":47185264,"html_url":"https://github.com/ManageIQ/manageiq/pull/4754","diff_url":"https://github.com/ManageIQ/manageiq/pull/4754.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4754.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4754","number":4754,"state":"closed","locked":false,"title":"[api] Validate generic GETs","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"This allows RBAC identifiers to be applied to GET actions. This is\r\nneeded for the Tenants API where show/list actions have RBAC identifiers\r\nthat need to be honored.\r\n\r\nFor collections that _don't_ explicitly define a GET action in\r\n`config/api.yml` a work-around has been made to just return `nil` in\r\nvalidation if it can't find an `aspec` value, and to return an empty\r\nhash if no action hash can be found. An alternative may be to update the\r\n`api.yml` file to explicitly give each collection that allows GETs a\r\nshow action (with no identifier) so validation will not break for them.","created_at":"2015-10-08T17:58:27Z","updated_at":"2015-10-09T16:47:06Z","closed_at":"2015-10-09T16:47:06Z","merged_at":"2015-10-09T16:47:06Z","merge_commit_sha":"382f04780482bc36358504d070acbca40c309fef","assignee":null,"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/25","html_url":"https://github.com/ManageIQ/manageiq/milestones/Sprint%2031%20Ending%20Oct%2026,%202015","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/25/labels","id":1340373,"number":25,"title":"Sprint 31 Ending Oct 26, 2015","description":"","creator":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":73,"state":"open","created_at":"2015-10-06T14:05:26Z","updated_at":"2015-10-09T16:47:06Z","due_on":"2015-10-26T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4754/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d78efbc818ce63d837e72ca3e74965322955cfa4","head":{"label":"imtayadeway:api/rbac-validation-for-gets","ref":"api/rbac-validation-for-gets","sha":"d78efbc818ce63d837e72ca3e74965322955cfa4","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"repo":{"id":34932503,"name":"manageiq","full_name":"imtayadeway/manageiq","owner":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars.githubusercontent.com/u/1710874?v=3","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imtayadeway/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/imtayadeway/manageiq","forks_url":"https://api.github.com/repos/imtayadeway/manageiq/forks","keys_url":"https://api.github.com/repos/imtayadeway/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imtayadeway/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imtayadeway/manageiq/teams","hooks_url":"https://api.github.com/repos/imtayadeway/manageiq/hooks","issue_events_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/imtayadeway/manageiq/events","assignees_url":"https://api.github.com/repos/imtayadeway/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/imtayadeway/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/imtayadeway/manageiq/tags","blobs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imtayadeway/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imtayadeway/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/imtayadeway/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imtayadeway/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/imtayadeway/manageiq/languages","stargazers_url":"https://api.github.com/repos/imtayadeway/manageiq/stargazers","contributors_url":"https://api.github.com/repos/imtayadeway/manageiq/contributors","subscribers_url":"https://api.github.com/repos/imtayadeway/manageiq/subscribers","subscription_url":"https://api.github.com/repos/imtayadeway/manageiq/subscription","commits_url":"https://api.github.com/repos/imtayadeway/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/imtayadeway/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/imtayadeway/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/imtayadeway/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/imtayadeway/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/imtayadeway/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imtayadeway/manageiq/merges","archive_url":"https://api.github.com/repos/imtayadeway/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imtayadeway/manageiq/downloads","issues_url":"https://api.github.com/repos/imtayadeway/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/imtayadeway/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/imtayadeway/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/imtayadeway/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imtayadeway/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/imtayadeway/manageiq/releases{/id}","created_at":"2015-05-02T02:08:43Z","updated_at":"2015-05-02T02:09:00Z","pushed_at":"2015-10-08T18:46:33Z","git_url":"git://github.com/imtayadeway/manageiq.git","ssh_url":"git@github.com:imtayadeway/manageiq.git","clone_url":"https://github.com/imtayadeway/manageiq.git","svn_url":"https://github.com/imtayadeway/manageiq","homepage":"manageiq.org","size":108239,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"94ad9c8827aab54ff09dbb1efb4b9be9da76fc16","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-10-07T20:09:25Z","pushed_at":"2015-10-09T16:47:07Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":170434,"stargazers_count":156,"watchers_count":156,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":430,"forks":165,"open_issues":430,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4754"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4754"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4754/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4754/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/d78efbc818ce63d837e72ca3e74965322955cfa4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abellotti","id":5797328,"avatar_url":"https://avatars.githubusercontent.com/u/5797328?v=3","gravatar_id":"","url":"https://api.github.com/users/abellotti","html_url":"https://github.com/abellotti","followers_url":"https://api.github.com/users/abellotti/followers","following_url":"https://api.github.com/users/abellotti/following{/other_user}","gists_url":"https://api.github.com/users/abellotti/gists{/gist_id}","starred_url":"https://api.github.com/users/abellotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abellotti/subscriptions","organizations_url":"https://api.github.com/users/abellotti/orgs","repos_url":"https://api.github.com/users/abellotti/repos","events_url":"https://api.github.com/users/abellotti/events{/privacy}","received_events_url":"https://api.github.com/users/abellotti/received_events","type":"User","site_admin":false},"comments":3,"review_comments":5,"commits":2,"additions":8,"deletions":2,"changed_files":2}}