{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/karyon/pulls/comments/43422651","id":43422651,"diff_hunk":"@@ -7,14 +7,45 @@\n import java.util.Map.Entry;\n \n /**\n- * Utility class for creating common {@link HealthIndicatorStatus} instances\n+ * Immutable health check instance returned from a {@link HealthIndicator}\n  * \n+ * See {@link HealthIndicatorStatus} for utility methods to create HealthIndicatorStatus objects\n  * @author elandau\n- *\n  */\n-public final class HealthIndicatorStatuses {\n+public interface HealthIndicatorStatus {","path":"karyon3-api/src/main/java/com/netflix/karyon/api/health/HealthIndicatorStatus.java","position":18,"original_position":18,"commit_id":"686a2dc2b00babb73022359d73e237986ded7efa","original_commit_id":"686a2dc2b00babb73022359d73e237986ded7efa","user":{"login":"jhspaybar","id":1356513,"avatar_url":"https://avatars.githubusercontent.com/u/1356513?v=3","gravatar_id":"","url":"https://api.github.com/users/jhspaybar","html_url":"https://github.com/jhspaybar","followers_url":"https://api.github.com/users/jhspaybar/followers","following_url":"https://api.github.com/users/jhspaybar/following{/other_user}","gists_url":"https://api.github.com/users/jhspaybar/gists{/gist_id}","starred_url":"https://api.github.com/users/jhspaybar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhspaybar/subscriptions","organizations_url":"https://api.github.com/users/jhspaybar/orgs","repos_url":"https://api.github.com/users/jhspaybar/repos","events_url":"https://api.github.com/users/jhspaybar/events{/privacy}","received_events_url":"https://api.github.com/users/jhspaybar/received_events","type":"User","site_admin":false},"body":"I know this is more a meta question than a critique of this move(which I generally find to be a good idea), but should we really even be doing this much stuff?  Why isn't a health check just a true/false, and why are we so involved in this process and defining complex APIs?","created_at":"2015-10-29T18:09:04Z","updated_at":"2015-10-29T18:09:04Z","html_url":"https://github.com/Netflix/karyon/pull/308#discussion_r43422651","pull_request_url":"https://api.github.com/repos/Netflix/karyon/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/comments/43422651"},"html":{"href":"https://github.com/Netflix/karyon/pull/308#discussion_r43422651"},"pull_request":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/karyon/pulls/308","id":49044743,"html_url":"https://github.com/Netflix/karyon/pull/308","diff_url":"https://github.com/Netflix/karyon/pull/308.diff","patch_url":"https://github.com/Netflix/karyon/pull/308.patch","issue_url":"https://api.github.com/repos/Netflix/karyon/issues/308","number":308,"state":"open","locked":false,"title":"Move a bunch of interfaces and utility classes into the karyon-api","user":{"login":"elandau","id":913564,"avatar_url":"https://avatars.githubusercontent.com/u/913564?v=3","gravatar_id":"","url":"https://api.github.com/users/elandau","html_url":"https://github.com/elandau","followers_url":"https://api.github.com/users/elandau/followers","following_url":"https://api.github.com/users/elandau/following{/other_user}","gists_url":"https://api.github.com/users/elandau/gists{/gist_id}","starred_url":"https://api.github.com/users/elandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elandau/subscriptions","organizations_url":"https://api.github.com/users/elandau/orgs","repos_url":"https://api.github.com/users/elandau/repos","events_url":"https://api.github.com/users/elandau/events{/privacy}","received_events_url":"https://api.github.com/users/elandau/received_events","type":"User","site_admin":false},"body":"Also introduce concept of default modules to the Karyon override hierarchy to avoid using Guice's ImplementedBy.  \r\n\r\nNote that this is a breaking change, especially for health check APIs, as they were moved to different packages.","created_at":"2015-10-28T18:06:28Z","updated_at":"2015-10-29T18:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd59e29a065a1c381c9e6d30afa68e9705a4c527","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Netflix/karyon/pulls/308/commits","review_comments_url":"https://api.github.com/repos/Netflix/karyon/pulls/308/comments","review_comment_url":"https://api.github.com/repos/Netflix/karyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/karyon/issues/308/comments","statuses_url":"https://api.github.com/repos/Netflix/karyon/statuses/686a2dc2b00babb73022359d73e237986ded7efa","head":{"label":"elandau:3.x_transformers","ref":"3.x_transformers","sha":"686a2dc2b00babb73022359d73e237986ded7efa","user":{"login":"elandau","id":913564,"avatar_url":"https://avatars.githubusercontent.com/u/913564?v=3","gravatar_id":"","url":"https://api.github.com/users/elandau","html_url":"https://github.com/elandau","followers_url":"https://api.github.com/users/elandau/followers","following_url":"https://api.github.com/users/elandau/following{/other_user}","gists_url":"https://api.github.com/users/elandau/gists{/gist_id}","starred_url":"https://api.github.com/users/elandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elandau/subscriptions","organizations_url":"https://api.github.com/users/elandau/orgs","repos_url":"https://api.github.com/users/elandau/repos","events_url":"https://api.github.com/users/elandau/events{/privacy}","received_events_url":"https://api.github.com/users/elandau/received_events","type":"User","site_admin":false},"repo":{"id":22766295,"name":"karyon","full_name":"elandau/karyon","owner":{"login":"elandau","id":913564,"avatar_url":"https://avatars.githubusercontent.com/u/913564?v=3","gravatar_id":"","url":"https://api.github.com/users/elandau","html_url":"https://github.com/elandau","followers_url":"https://api.github.com/users/elandau/followers","following_url":"https://api.github.com/users/elandau/following{/other_user}","gists_url":"https://api.github.com/users/elandau/gists{/gist_id}","starred_url":"https://api.github.com/users/elandau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elandau/subscriptions","organizations_url":"https://api.github.com/users/elandau/orgs","repos_url":"https://api.github.com/users/elandau/repos","events_url":"https://api.github.com/users/elandau/events{/privacy}","received_events_url":"https://api.github.com/users/elandau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elandau/karyon","description":"The nucleus or the base container for Applications and Services built using the NetflixOSS ecosystem","fork":true,"url":"https://api.github.com/repos/elandau/karyon","forks_url":"https://api.github.com/repos/elandau/karyon/forks","keys_url":"https://api.github.com/repos/elandau/karyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elandau/karyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elandau/karyon/teams","hooks_url":"https://api.github.com/repos/elandau/karyon/hooks","issue_events_url":"https://api.github.com/repos/elandau/karyon/issues/events{/number}","events_url":"https://api.github.com/repos/elandau/karyon/events","assignees_url":"https://api.github.com/repos/elandau/karyon/assignees{/user}","branches_url":"https://api.github.com/repos/elandau/karyon/branches{/branch}","tags_url":"https://api.github.com/repos/elandau/karyon/tags","blobs_url":"https://api.github.com/repos/elandau/karyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elandau/karyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elandau/karyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/elandau/karyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elandau/karyon/statuses/{sha}","languages_url":"https://api.github.com/repos/elandau/karyon/languages","stargazers_url":"https://api.github.com/repos/elandau/karyon/stargazers","contributors_url":"https://api.github.com/repos/elandau/karyon/contributors","subscribers_url":"https://api.github.com/repos/elandau/karyon/subscribers","subscription_url":"https://api.github.com/repos/elandau/karyon/subscription","commits_url":"https://api.github.com/repos/elandau/karyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/elandau/karyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/elandau/karyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/elandau/karyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/elandau/karyon/contents/{+path}","compare_url":"https://api.github.com/repos/elandau/karyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elandau/karyon/merges","archive_url":"https://api.github.com/repos/elandau/karyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elandau/karyon/downloads","issues_url":"https://api.github.com/repos/elandau/karyon/issues{/number}","pulls_url":"https://api.github.com/repos/elandau/karyon/pulls{/number}","milestones_url":"https://api.github.com/repos/elandau/karyon/milestones{/number}","notifications_url":"https://api.github.com/repos/elandau/karyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elandau/karyon/labels{/name}","releases_url":"https://api.github.com/repos/elandau/karyon/releases{/id}","created_at":"2014-08-08T17:46:44Z","updated_at":"2015-04-21T21:48:44Z","pushed_at":"2015-10-29T17:20:42Z","git_url":"git://github.com/elandau/karyon.git","ssh_url":"git@github.com:elandau/karyon.git","clone_url":"https://github.com/elandau/karyon.git","svn_url":"https://github.com/elandau/karyon","homepage":null,"size":2773,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:3.x","ref":"3.x","sha":"95e2d4507372cf122554a78eeec6ace980c60e79","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":8059194,"name":"karyon","full_name":"Netflix/karyon","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/karyon","description":"The nucleus or the base container for Applications and Services built using the NetflixOSS ecosystem","fork":false,"url":"https://api.github.com/repos/Netflix/karyon","forks_url":"https://api.github.com/repos/Netflix/karyon/forks","keys_url":"https://api.github.com/repos/Netflix/karyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/karyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/karyon/teams","hooks_url":"https://api.github.com/repos/Netflix/karyon/hooks","issue_events_url":"https://api.github.com/repos/Netflix/karyon/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/karyon/events","assignees_url":"https://api.github.com/repos/Netflix/karyon/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/karyon/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/karyon/tags","blobs_url":"https://api.github.com/repos/Netflix/karyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/karyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/karyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/karyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/karyon/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/karyon/languages","stargazers_url":"https://api.github.com/repos/Netflix/karyon/stargazers","contributors_url":"https://api.github.com/repos/Netflix/karyon/contributors","subscribers_url":"https://api.github.com/repos/Netflix/karyon/subscribers","subscription_url":"https://api.github.com/repos/Netflix/karyon/subscription","commits_url":"https://api.github.com/repos/Netflix/karyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/karyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/karyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/karyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/karyon/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/karyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/karyon/merges","archive_url":"https://api.github.com/repos/Netflix/karyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/karyon/downloads","issues_url":"https://api.github.com/repos/Netflix/karyon/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/karyon/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/karyon/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/karyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/karyon/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/karyon/releases{/id}","created_at":"2013-02-06T20:18:55Z","updated_at":"2015-10-29T05:55:04Z","pushed_at":"2015-10-28T21:05:48Z","git_url":"git://github.com/Netflix/karyon.git","ssh_url":"git@github.com:Netflix/karyon.git","clone_url":"https://github.com/Netflix/karyon.git","svn_url":"https://github.com/Netflix/karyon","homepage":null,"size":6120,"stargazers_count":266,"watchers_count":266,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":120,"mirror_url":null,"open_issues_count":23,"forks":120,"open_issues":23,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/308"},"html":{"href":"https://github.com/Netflix/karyon/pull/308"},"issue":{"href":"https://api.github.com/repos/Netflix/karyon/issues/308"},"comments":{"href":"https://api.github.com/repos/Netflix/karyon/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/karyon/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/karyon/statuses/686a2dc2b00babb73022359d73e237986ded7efa"}}}}