{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9810","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9810/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9810/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9810/events","html_url":"https://github.com/cms-sw/cmssw/pull/9810","id":90329796,"number":9810,"title":"reimplementation of Track classifiers and Track Collection mergers","user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/visualization-pending","name":"visualization-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":65,"closed_issues":71,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-07-01T13:08:16Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-06-23T09:02:25Z","updated_at":"2015-07-01T13:44:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9810","html_url":"https://github.com/cms-sw/cmssw/pull/9810","diff_url":"https://github.com/cms-sw/cmssw/pull/9810.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9810.patch"},"body":"I have fully reimplemented track selectors and merger.\r\nSeparated all concerns:\r\none class to use mva,\r\none class to use cuts (mimics mva output)\r\none class to merge selectors\r\none class to merge collections.\r\nto be done\r\nre-implement duplicate identification and merging\r\nport to HLT\r\n\r\ndo not esclude that some non-main-stream use-cases are not covered yet.\r\nsome more cleanup and optimization is surely required.\r\n\r\nI have also implemented a macro to instantiate a sort of DynArray as C++14 does not support anymore\r\ndynamical array.\r\n\r\nFull backward compatibility is not maintained.\r\n1) \r\nThe vertex identification uses only delta-z and not the track-vertex association:\r\nthe latter (besides being utterly show to verify with the current implementation) it is only working\r\nfor Iter0:  tracks from all other iterations are not associated to any vertex\r\n2)\r\nquality  looseSetWithPV and  highPuritySetWithPV is not set (nobody is using it)\r\nand does not make much sense when using MVA anyhow (it can mark if the mva is prompt or detached, maybe.  TBD)\r\n3) Iter5 and 6 are MVA only\r\n\r\nIn my opinion it requires still a couple of weeks of work.\r\nI will not work for the next two weeks, so I prefer to submit this PR for reference and to collect feedback.\r\n\r\n\r\n\r\n\r\n \nAutomatically ported from CMSSW_7_5_X #9538 (original by @VinInn)."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/117680817","html_url":"https://github.com/cms-sw/cmssw/pull/9810#issuecomment-117680817","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9810","id":117680817,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-07-01T13:44:05Z","updated_at":"2015-07-01T13:44:05Z","body":"Pull request #9810 was updated. @smuzaffar, @civanch, @diguida, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @monttj, @cmsbuild, @alja, @franzoni, @Dr15Jones, @cerminar, @deguio, @slava77, @danduggan, @vadler, @mmusich, @davidlange6 can you please check and sign again."}}