{"action":"created","issue":{"url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/13","labels_url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/13/comments","events_url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/13/events","html_url":"https://github.com/evidenceprime/html-docx-js/pull/13","id":100765059,"number":13,"title":"Added images support","user":{"login":"N1kto","id":5045863,"avatar_url":"https://avatars.githubusercontent.com/u/5045863?v=3","gravatar_id":"","url":"https://api.github.com/users/N1kto","html_url":"https://github.com/N1kto","followers_url":"https://api.github.com/users/N1kto/followers","following_url":"https://api.github.com/users/N1kto/following{/other_user}","gists_url":"https://api.github.com/users/N1kto/gists{/gist_id}","starred_url":"https://api.github.com/users/N1kto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N1kto/subscriptions","organizations_url":"https://api.github.com/users/N1kto/orgs","repos_url":"https://api.github.com/users/N1kto/repos","events_url":"https://api.github.com/users/N1kto/events{/privacy}","received_events_url":"https://api.github.com/users/N1kto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-13T13:07:59Z","updated_at":"2015-08-19T08:54:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/evidenceprime/html-docx-js/pulls/13","html_url":"https://github.com/evidenceprime/html-docx-js/pull/13","diff_url":"https://github.com/evidenceprime/html-docx-js/pull/13.diff","patch_url":"https://github.com/evidenceprime/html-docx-js/pull/13.patch"},"body":"Please review support of images in Word export files. This should work for both inlined and regular (sourced from static files) images. "},"comment":{"url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/comments/132498417","html_url":"https://github.com/evidenceprime/html-docx-js/pull/13#issuecomment-132498417","issue_url":"https://api.github.com/repos/evidenceprime/html-docx-js/issues/13","id":132498417,"user":{"login":"anowak","id":389726,"avatar_url":"https://avatars.githubusercontent.com/u/389726?v=3","gravatar_id":"","url":"https://api.github.com/users/anowak","html_url":"https://github.com/anowak","followers_url":"https://api.github.com/users/anowak/followers","following_url":"https://api.github.com/users/anowak/following{/other_user}","gists_url":"https://api.github.com/users/anowak/gists{/gist_id}","starred_url":"https://api.github.com/users/anowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anowak/subscriptions","organizations_url":"https://api.github.com/users/anowak/orgs","repos_url":"https://api.github.com/users/anowak/repos","events_url":"https://api.github.com/users/anowak/events{/privacy}","received_events_url":"https://api.github.com/users/anowak/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T08:54:32Z","updated_at":"2015-08-19T08:54:32Z","body":"I don't see any tests nor documentation for this :)\r\n\r\nWhat I would propose:\r\n\r\n* drop the image inlining code and require all the images to be already provided as data uris. Please observe that e.g. on Node.js it is far easier to just convert `Buffer` with image to base64 representation than going through the canvas. Probably it is better to let the user do the legwork.\r\n* switch to callbacks instead of promises\r\n* add tests"}}