{"action":"created","comment":{"url":"https://api.github.com/repos/01org/libyami/pulls/comments/45152583","id":45152583,"diff_hunk":"@@ -38,16 +91,13 @@ ConfigPtr VaapiConfig::create(const DisplayPtr& display,\n         return ret;\n     VAStatus vaStatus;\n     VAConfigID config;\n-    vaStatus = vaCreateConfig(display->getID(), profile, entry, attribList, numAttribs, &config);\n \n-    // VAProfileH264Baseline is super profile for VAProfileH264ConstrainedBaseline\n-    // old i965 driver incorrectly claims supporting VAProfileH264Baseline, but not VAProfileH264ConstrainedBaseline\n-    if (vaStatus == VA_STATUS_ERROR_UNSUPPORTED_PROFILE\n-        && profile == VAProfileH264ConstrainedBaseline\n-        && entry == VAEntrypointVLD)\n-        vaStatus = vaCreateConfig(display->getID(),\n-                                  VAProfileH264Baseline,\n-                                  VAEntrypointVLD, attribList, numAttribs, &config);\n+    if (!checkProfileCompatible(display, profile)){","path":"vaapi/vaapicontext.cpp","position":78,"original_position":78,"commit_id":"fdb56bd4713484bfdd7f7b39fb504ad7074b8234","original_commit_id":"fdb56bd4713484bfdd7f7b39fb504ad7074b8234","user":{"login":"xuguangxin","id":6667546,"avatar_url":"https://avatars.githubusercontent.com/u/6667546?v=3","gravatar_id":"","url":"https://api.github.com/users/xuguangxin","html_url":"https://github.com/xuguangxin","followers_url":"https://api.github.com/users/xuguangxin/followers","following_url":"https://api.github.com/users/xuguangxin/following{/other_user}","gists_url":"https://api.github.com/users/xuguangxin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuguangxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuguangxin/subscriptions","organizations_url":"https://api.github.com/users/xuguangxin/orgs","repos_url":"https://api.github.com/users/xuguangxin/repos","events_url":"https://api.github.com/users/xuguangxin/events{/privacy}","received_events_url":"https://api.github.com/users/xuguangxin/received_events","type":"User","site_admin":false},"body":"for encoder we'd better think from other aspect. if they want encode a baseline profile. We give him a main profile. the target decoder may failed on encoded file.","created_at":"2015-11-18T02:25:26Z","updated_at":"2015-11-18T02:25:26Z","html_url":"https://github.com/01org/libyami/pull/343#discussion_r45152583","pull_request_url":"https://api.github.com/repos/01org/libyami/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments/45152583"},"html":{"href":"https://github.com/01org/libyami/pull/343#discussion_r45152583"},"pull_request":{"href":"https://api.github.com/repos/01org/libyami/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/01org/libyami/pulls/343","id":49671696,"html_url":"https://github.com/01org/libyami/pull/343","diff_url":"https://github.com/01org/libyami/pull/343.diff","patch_url":"https://github.com/01org/libyami/pull/343.patch","issue_url":"https://api.github.com/repos/01org/libyami/issues/343","number":343,"state":"open","locked":false,"title":"vaapicontext: check profile before create vacontext","user":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"body":"1. Check profile compatible before create va vacontext\r\n2. For h264, driver may declare support higher profile but don't support\r\nlower profile. In this case, higher profile should be created\r\n\r\nSigned-off-by: Zhong Li <zhong.li@intel.com>","created_at":"2015-11-04T10:33:41Z","updated_at":"2015-11-18T02:25:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48876ecfb831531d0ce5c45065ef38ee57372c64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/libyami/pulls/343/commits","review_comments_url":"https://api.github.com/repos/01org/libyami/pulls/343/comments","review_comment_url":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/libyami/issues/343/comments","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/fdb56bd4713484bfdd7f7b39fb504ad7074b8234","head":{"label":"lizhong1008:master","ref":"master","sha":"fdb56bd4713484bfdd7f7b39fb504ad7074b8234","user":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"repo":{"id":37236061,"name":"libyami","full_name":"lizhong1008/libyami","owner":{"login":"lizhong1008","id":12838465,"avatar_url":"https://avatars.githubusercontent.com/u/12838465?v=3","gravatar_id":"","url":"https://api.github.com/users/lizhong1008","html_url":"https://github.com/lizhong1008","followers_url":"https://api.github.com/users/lizhong1008/followers","following_url":"https://api.github.com/users/lizhong1008/following{/other_user}","gists_url":"https://api.github.com/users/lizhong1008/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhong1008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhong1008/subscriptions","organizations_url":"https://api.github.com/users/lizhong1008/orgs","repos_url":"https://api.github.com/users/lizhong1008/repos","events_url":"https://api.github.com/users/lizhong1008/events{/privacy}","received_events_url":"https://api.github.com/users/lizhong1008/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lizhong1008/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":true,"url":"https://api.github.com/repos/lizhong1008/libyami","forks_url":"https://api.github.com/repos/lizhong1008/libyami/forks","keys_url":"https://api.github.com/repos/lizhong1008/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizhong1008/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizhong1008/libyami/teams","hooks_url":"https://api.github.com/repos/lizhong1008/libyami/hooks","issue_events_url":"https://api.github.com/repos/lizhong1008/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/lizhong1008/libyami/events","assignees_url":"https://api.github.com/repos/lizhong1008/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/lizhong1008/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/lizhong1008/libyami/tags","blobs_url":"https://api.github.com/repos/lizhong1008/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizhong1008/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizhong1008/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizhong1008/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizhong1008/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/lizhong1008/libyami/languages","stargazers_url":"https://api.github.com/repos/lizhong1008/libyami/stargazers","contributors_url":"https://api.github.com/repos/lizhong1008/libyami/contributors","subscribers_url":"https://api.github.com/repos/lizhong1008/libyami/subscribers","subscription_url":"https://api.github.com/repos/lizhong1008/libyami/subscription","commits_url":"https://api.github.com/repos/lizhong1008/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizhong1008/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizhong1008/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizhong1008/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizhong1008/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/lizhong1008/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizhong1008/libyami/merges","archive_url":"https://api.github.com/repos/lizhong1008/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizhong1008/libyami/downloads","issues_url":"https://api.github.com/repos/lizhong1008/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/lizhong1008/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/lizhong1008/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/lizhong1008/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizhong1008/libyami/labels{/name}","releases_url":"https://api.github.com/repos/lizhong1008/libyami/releases{/id}","created_at":"2015-06-11T02:59:58Z","updated_at":"2015-09-16T07:19:32Z","pushed_at":"2015-11-17T03:33:00Z","git_url":"git://github.com/lizhong1008/libyami.git","ssh_url":"git@github.com:lizhong1008/libyami.git","clone_url":"https://github.com/lizhong1008/libyami.git","svn_url":"https://github.com/lizhong1008/libyami","homepage":null,"size":2226,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"8fe2149fa5ddba8a47fb43c0f371dc7681186e9c","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":18320220,"name":"libyami","full_name":"01org/libyami","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/libyami","description":"Yet Another Media Infrastructure. it is core part of media codec with hardware acceleration, it is yummy to your video experience on Linux like platform.","fork":false,"url":"https://api.github.com/repos/01org/libyami","forks_url":"https://api.github.com/repos/01org/libyami/forks","keys_url":"https://api.github.com/repos/01org/libyami/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/libyami/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/libyami/teams","hooks_url":"https://api.github.com/repos/01org/libyami/hooks","issue_events_url":"https://api.github.com/repos/01org/libyami/issues/events{/number}","events_url":"https://api.github.com/repos/01org/libyami/events","assignees_url":"https://api.github.com/repos/01org/libyami/assignees{/user}","branches_url":"https://api.github.com/repos/01org/libyami/branches{/branch}","tags_url":"https://api.github.com/repos/01org/libyami/tags","blobs_url":"https://api.github.com/repos/01org/libyami/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/libyami/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/libyami/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/libyami/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/libyami/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/libyami/languages","stargazers_url":"https://api.github.com/repos/01org/libyami/stargazers","contributors_url":"https://api.github.com/repos/01org/libyami/contributors","subscribers_url":"https://api.github.com/repos/01org/libyami/subscribers","subscription_url":"https://api.github.com/repos/01org/libyami/subscription","commits_url":"https://api.github.com/repos/01org/libyami/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/libyami/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/libyami/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/libyami/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/libyami/contents/{+path}","compare_url":"https://api.github.com/repos/01org/libyami/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/libyami/merges","archive_url":"https://api.github.com/repos/01org/libyami/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/libyami/downloads","issues_url":"https://api.github.com/repos/01org/libyami/issues{/number}","pulls_url":"https://api.github.com/repos/01org/libyami/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/libyami/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/libyami/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/libyami/labels{/name}","releases_url":"https://api.github.com/repos/01org/libyami/releases{/id}","created_at":"2014-04-01T06:44:19Z","updated_at":"2015-11-10T04:35:43Z","pushed_at":"2015-11-17T21:52:08Z","git_url":"git://github.com/01org/libyami.git","ssh_url":"git@github.com:01org/libyami.git","clone_url":"https://github.com/01org/libyami.git","svn_url":"https://github.com/01org/libyami","homepage":null,"size":2945,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":22,"forks":35,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/libyami/pulls/343"},"html":{"href":"https://github.com/01org/libyami/pull/343"},"issue":{"href":"https://api.github.com/repos/01org/libyami/issues/343"},"comments":{"href":"https://api.github.com/repos/01org/libyami/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/libyami/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/libyami/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/libyami/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/01org/libyami/statuses/fdb56bd4713484bfdd7f7b39fb504ad7074b8234"}}}}