{"action":"created","comment":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/43551568","id":43551568,"diff_hunk":"@@ -226,15 +226,26 @@ Operations.prototype.getPending = function getPending() {\n     return self.pending;\n };\n \n+Operations.prototype.getOutTombstone = function getOutTombstone(id) {\n+    var self = this;\n+\n+    var op = self.requests.out[id] || null;\n+    if (op && !op.isTombstone) {\n+        return null;\n+    }\n+\n+    return op;\n+};\n+","path":"operations.js","position":14,"original_position":14,"commit_id":"a99ed4c8813366f122cd67ce185906f5e4276f7f","original_commit_id":"a99ed4c8813366f122cd67ce185906f5e4276f7f","user":{"login":"rf","id":1093601,"avatar_url":"https://avatars.githubusercontent.com/u/1093601?v=3","gravatar_id":"","url":"https://api.github.com/users/rf","html_url":"https://github.com/rf","followers_url":"https://api.github.com/users/rf/followers","following_url":"https://api.github.com/users/rf/following{/other_user}","gists_url":"https://api.github.com/users/rf/gists{/gist_id}","starred_url":"https://api.github.com/users/rf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rf/subscriptions","organizations_url":"https://api.github.com/users/rf/orgs","repos_url":"https://api.github.com/users/rf/repos","events_url":"https://api.github.com/users/rf/events{/privacy}","received_events_url":"https://api.github.com/users/rf/received_events","type":"User","site_admin":false},"body":"nitpick: this is a bit of a weird pattern. Why not just have one `getOutReq` function that returns either a tombstone or a req, then check `.isTombstone` in `TChannelConnection#onCallErrorFrame`? \r\n\r\nI feel like this code obfuscates the flow for handling error frames when there's a tombstone.","created_at":"2015-10-30T20:59:05Z","updated_at":"2015-10-30T20:59:05Z","html_url":"https://github.com/uber/tchannel-node/pull/155#discussion_r43551568","pull_request_url":"https://api.github.com/repos/uber/tchannel-node/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments/43551568"},"html":{"href":"https://github.com/uber/tchannel-node/pull/155#discussion_r43551568"},"pull_request":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-node/pulls/155","id":49317172,"html_url":"https://github.com/uber/tchannel-node/pull/155","diff_url":"https://github.com/uber/tchannel-node/pull/155.diff","patch_url":"https://github.com/uber/tchannel-node/pull/155.patch","issue_url":"https://api.github.com/repos/uber/tchannel-node/issues/155","number":155,"state":"open","locked":false,"title":"Add logging of unknown error frames.","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"This adds an extra logsite for any unknown error frames.\nThese generally occur in race conditions.\n\nr: @jcorbin @rf","created_at":"2015-10-30T20:15:03Z","updated_at":"2015-10-30T20:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ba632a4e82151212b1a3756484ba22f54f7706","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-node/pulls/155/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-node/pulls/155/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-node/issues/155/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/a99ed4c8813366f122cd67ce185906f5e4276f7f","head":{"label":"uber:log-unknown-error-frame","ref":"log-unknown-error-frame","sha":"a99ed4c8813366f122cd67ce185906f5e4276f7f","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-10-29T04:01:31Z","pushed_at":"2015-10-30T20:55:57Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":7032,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":30,"forks":1,"open_issues":30,"watchers":16,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"ecfb37fcc8ad19382fc26a00d42d15b6170d81f0","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":42619114,"name":"tchannel-node","full_name":"uber/tchannel-node","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-node","description":"","fork":false,"url":"https://api.github.com/repos/uber/tchannel-node","forks_url":"https://api.github.com/repos/uber/tchannel-node/forks","keys_url":"https://api.github.com/repos/uber/tchannel-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-node/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-node/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-node/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-node/events","assignees_url":"https://api.github.com/repos/uber/tchannel-node/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-node/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-node/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-node/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-node/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-node/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-node/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-node/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-node/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-node/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-node/merges","archive_url":"https://api.github.com/repos/uber/tchannel-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-node/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-node/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-node/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-node/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-node/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-node/releases{/id}","created_at":"2015-09-16T23:37:37Z","updated_at":"2015-10-29T04:01:31Z","pushed_at":"2015-10-30T20:55:57Z","git_url":"git://github.com/uber/tchannel-node.git","ssh_url":"git@github.com:uber/tchannel-node.git","clone_url":"https://github.com/uber/tchannel-node.git","svn_url":"https://github.com/uber/tchannel-node","homepage":null,"size":7032,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":30,"forks":1,"open_issues":30,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/155"},"html":{"href":"https://github.com/uber/tchannel-node/pull/155"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/155"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-node/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-node/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-node/statuses/a99ed4c8813366f122cd67ce185906f5e4276f7f"}}}}