{"action":"created","comment":{"url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/comments/46883306","id":46883306,"diff_hunk":"@@ -0,0 +1,33 @@\n+import * as CounterActions from '../../actions/counter';\n+\n+export function CounterComponent(): ng.IDirective {\n+  return {\n+    restrict: 'E',\n+    controllerAs: 'ctrl',\n+    controller: CounterController,\n+    template: require('./counter.html'),\n+    scope: {}\n+  };\n+}\n+\n+class CounterController {","path":"src/components/counter/counter.ts","position":13,"original_position":13,"commit_id":"aca18e3bdb14f3d8d97bc16d62ba4399fd69c766","original_commit_id":"aca18e3bdb14f3d8d97bc16d62ba4399fd69c766","user":{"login":"e-schultz","id":3045906,"avatar_url":"https://avatars.githubusercontent.com/u/3045906?v=3","gravatar_id":"","url":"https://api.github.com/users/e-schultz","html_url":"https://github.com/e-schultz","followers_url":"https://api.github.com/users/e-schultz/followers","following_url":"https://api.github.com/users/e-schultz/following{/other_user}","gists_url":"https://api.github.com/users/e-schultz/gists{/gist_id}","starred_url":"https://api.github.com/users/e-schultz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-schultz/subscriptions","organizations_url":"https://api.github.com/users/e-schultz/orgs","repos_url":"https://api.github.com/users/e-schultz/repos","events_url":"https://api.github.com/users/e-schultz/events{/privacy}","received_events_url":"https://api.github.com/users/e-schultz/received_events","type":"User","site_admin":false},"body":"In sad-ui, we would have the controller be in it's own JS file outside of the directive-deffinition object, made it a bit easier to unit test as we could just \r\n\r\n```javascript\r\nimport controller from './controller-file`\r\n// later on in the tests\r\n\r\nlet ctrl = new Controller(my,mocks) { \r\n}\r\n```\r\n\r\nSuppose we can still do that here, but it'd be more\r\n\r\n```javascript\r\nimport {CounterComponent} from './counter';\r\n// later on in the test, something like ??\r\nlet ctrl = new CounterComponent().Controller(my,mocks)\r\n```\r\n\r\nor, could also just have an export class CounterController here.\r\n\r\nOn the other hand - when controllers are being this thin - having unit tests here are more just 'upping the lines of coverage', but not adding much value.\r\n\r\nThoughts?\r\n\r\n","created_at":"2015-12-07T21:52:49Z","updated_at":"2015-12-07T21:52:49Z","html_url":"https://github.com/rangle/angular-redux-starter/pull/12#discussion_r46883306","pull_request_url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/comments/46883306"},"html":{"href":"https://github.com/rangle/angular-redux-starter/pull/12#discussion_r46883306"},"pull_request":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12","id":52785920,"html_url":"https://github.com/rangle/angular-redux-starter/pull/12","diff_url":"https://github.com/rangle/angular-redux-starter/pull/12.diff","patch_url":"https://github.com/rangle/angular-redux-starter/pull/12.patch","issue_url":"https://api.github.com/repos/rangle/angular-redux-starter/issues/12","number":12,"state":"open","locked":false,"title":"feat: add a simple redux counter app","user":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"body":"@SethDavenport I removed the old flux ngcourse-next based application and put a simple redux counter application instead.\r\n\r\nNext step would be to port the react-redux-seed application in here","created_at":"2015-12-06T17:59:35Z","updated_at":"2015-12-07T21:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86b1c50ed2b0708ed28973f50be93b5143b607bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12/commits","review_comments_url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12/comments","review_comment_url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rangle/angular-redux-starter/issues/12/comments","statuses_url":"https://api.github.com/repos/rangle/angular-redux-starter/statuses/aca18e3bdb14f3d8d97bc16d62ba4399fd69c766","head":{"label":"igor-ka:feat/redux","ref":"feat/redux","sha":"aca18e3bdb14f3d8d97bc16d62ba4399fd69c766","user":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"repo":{"id":47142688,"name":"angular-redux-starter","full_name":"igor-ka/angular-redux-starter","owner":{"login":"igor-ka","id":12536242,"avatar_url":"https://avatars.githubusercontent.com/u/12536242?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ka","html_url":"https://github.com/igor-ka","followers_url":"https://api.github.com/users/igor-ka/followers","following_url":"https://api.github.com/users/igor-ka/following{/other_user}","gists_url":"https://api.github.com/users/igor-ka/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ka/subscriptions","organizations_url":"https://api.github.com/users/igor-ka/orgs","repos_url":"https://api.github.com/users/igor-ka/repos","events_url":"https://api.github.com/users/igor-ka/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igor-ka/angular-redux-starter","description":"Rangle's Angular/TypeScript/Webpack Starter Project","fork":true,"url":"https://api.github.com/repos/igor-ka/angular-redux-starter","forks_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/forks","keys_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/teams","hooks_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/hooks","issue_events_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/issues/events{/number}","events_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/events","assignees_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/assignees{/user}","branches_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/branches{/branch}","tags_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/tags","blobs_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/languages","stargazers_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/stargazers","contributors_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/contributors","subscribers_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/subscribers","subscription_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/subscription","commits_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/contents/{+path}","compare_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/merges","archive_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/downloads","issues_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/issues{/number}","pulls_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/labels{/name}","releases_url":"https://api.github.com/repos/igor-ka/angular-redux-starter/releases{/id}","created_at":"2015-11-30T20:01:17Z","updated_at":"2015-12-01T01:19:40Z","pushed_at":"2015-12-06T17:57:52Z","git_url":"git://github.com/igor-ka/angular-redux-starter.git","ssh_url":"git@github.com:igor-ka/angular-redux-starter.git","clone_url":"https://github.com/igor-ka/angular-redux-starter.git","svn_url":"https://github.com/igor-ka/angular-redux-starter","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rangle:master","ref":"master","sha":"569035be2623d43d2df63ab1df521384c0794bd7","user":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=3","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"repo":{"id":46129075,"name":"angular-redux-starter","full_name":"rangle/angular-redux-starter","owner":{"login":"rangle","id":4304982,"avatar_url":"https://avatars.githubusercontent.com/u/4304982?v=3","gravatar_id":"","url":"https://api.github.com/users/rangle","html_url":"https://github.com/rangle","followers_url":"https://api.github.com/users/rangle/followers","following_url":"https://api.github.com/users/rangle/following{/other_user}","gists_url":"https://api.github.com/users/rangle/gists{/gist_id}","starred_url":"https://api.github.com/users/rangle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rangle/subscriptions","organizations_url":"https://api.github.com/users/rangle/orgs","repos_url":"https://api.github.com/users/rangle/repos","events_url":"https://api.github.com/users/rangle/events{/privacy}","received_events_url":"https://api.github.com/users/rangle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rangle/angular-redux-starter","description":"Rangle's Angular/TypeScript/Webpack Starter Project","fork":false,"url":"https://api.github.com/repos/rangle/angular-redux-starter","forks_url":"https://api.github.com/repos/rangle/angular-redux-starter/forks","keys_url":"https://api.github.com/repos/rangle/angular-redux-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rangle/angular-redux-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rangle/angular-redux-starter/teams","hooks_url":"https://api.github.com/repos/rangle/angular-redux-starter/hooks","issue_events_url":"https://api.github.com/repos/rangle/angular-redux-starter/issues/events{/number}","events_url":"https://api.github.com/repos/rangle/angular-redux-starter/events","assignees_url":"https://api.github.com/repos/rangle/angular-redux-starter/assignees{/user}","branches_url":"https://api.github.com/repos/rangle/angular-redux-starter/branches{/branch}","tags_url":"https://api.github.com/repos/rangle/angular-redux-starter/tags","blobs_url":"https://api.github.com/repos/rangle/angular-redux-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rangle/angular-redux-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rangle/angular-redux-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/rangle/angular-redux-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rangle/angular-redux-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/rangle/angular-redux-starter/languages","stargazers_url":"https://api.github.com/repos/rangle/angular-redux-starter/stargazers","contributors_url":"https://api.github.com/repos/rangle/angular-redux-starter/contributors","subscribers_url":"https://api.github.com/repos/rangle/angular-redux-starter/subscribers","subscription_url":"https://api.github.com/repos/rangle/angular-redux-starter/subscription","commits_url":"https://api.github.com/repos/rangle/angular-redux-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/rangle/angular-redux-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/rangle/angular-redux-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/rangle/angular-redux-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/rangle/angular-redux-starter/contents/{+path}","compare_url":"https://api.github.com/repos/rangle/angular-redux-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rangle/angular-redux-starter/merges","archive_url":"https://api.github.com/repos/rangle/angular-redux-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rangle/angular-redux-starter/downloads","issues_url":"https://api.github.com/repos/rangle/angular-redux-starter/issues{/number}","pulls_url":"https://api.github.com/repos/rangle/angular-redux-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/rangle/angular-redux-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/rangle/angular-redux-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rangle/angular-redux-starter/labels{/name}","releases_url":"https://api.github.com/repos/rangle/angular-redux-starter/releases{/id}","created_at":"2015-11-13T15:13:31Z","updated_at":"2015-12-02T20:08:04Z","pushed_at":"2015-12-06T17:59:36Z","git_url":"git://github.com/rangle/angular-redux-starter.git","ssh_url":"git@github.com:rangle/angular-redux-starter.git","clone_url":"https://github.com/rangle/angular-redux-starter.git","svn_url":"https://github.com/rangle/angular-redux-starter","homepage":null,"size":29,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12"},"html":{"href":"https://github.com/rangle/angular-redux-starter/pull/12"},"issue":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/issues/12"},"comments":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/rangle/angular-redux-starter/statuses/aca18e3bdb14f3d8d97bc16d62ba4399fd69c766"}}}}