{"action":"closed","number":244,"pull_request":{"url":"https://api.github.com/repos/scopatz/xonsh/pulls/244","id":35595776,"html_url":"https://github.com/scopatz/xonsh/pull/244","diff_url":"https://github.com/scopatz/xonsh/pull/244.diff","patch_url":"https://github.com/scopatz/xonsh/pull/244.patch","issue_url":"https://api.github.com/repos/scopatz/xonsh/issues/244","number":244,"state":"closed","locked":false,"title":"Aliases as Environment Variable","user":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"body":"This changeset is a reorganization of the code to store aliases in an environment variable (`$ALIASES`) instead of in the global namespace.  I think I caught all the places we would need to make this change.\r\n\r\nI am not sure whether there was a reason to have the aliases live where they currently do, but it \"feels right\" to me to have them in the environment (away from the Python execution).  Non-trivial downside, of course, is that everyone has to rewrite their `.xonshrc`...\r\n\r\nHappy to discuss more or to make changes as necessary.","created_at":"2015-05-17T23:52:07Z","updated_at":"2015-07-13T17:10:55Z","closed_at":"2015-07-13T17:10:55Z","merged_at":null,"merge_commit_sha":"6c44b53493a26bf3c146be0d3c27c7cfaff3c7a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scopatz/xonsh/pulls/244/commits","review_comments_url":"https://api.github.com/repos/scopatz/xonsh/pulls/244/comments","review_comment_url":"https://api.github.com/repos/scopatz/xonsh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scopatz/xonsh/issues/244/comments","statuses_url":"https://api.github.com/repos/scopatz/xonsh/statuses/c8e620aa97b8070c184b8a1419a8660a361ae44a","head":{"label":"adqm:aliases","ref":"aliases","sha":"c8e620aa97b8070c184b8a1419a8660a361ae44a","user":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"repo":{"id":32187841,"name":"xonsh","full_name":"adqm/xonsh","owner":{"login":"adqm","id":549404,"avatar_url":"https://avatars.githubusercontent.com/u/549404?v=3","gravatar_id":"","url":"https://api.github.com/users/adqm","html_url":"https://github.com/adqm","followers_url":"https://api.github.com/users/adqm/followers","following_url":"https://api.github.com/users/adqm/following{/other_user}","gists_url":"https://api.github.com/users/adqm/gists{/gist_id}","starred_url":"https://api.github.com/users/adqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adqm/subscriptions","organizations_url":"https://api.github.com/users/adqm/orgs","repos_url":"https://api.github.com/users/adqm/repos","events_url":"https://api.github.com/users/adqm/events{/privacy}","received_events_url":"https://api.github.com/users/adqm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adqm/xonsh","description":"xonsh is a Python-ish, BASHwards-compatible shell.","fork":true,"url":"https://api.github.com/repos/adqm/xonsh","forks_url":"https://api.github.com/repos/adqm/xonsh/forks","keys_url":"https://api.github.com/repos/adqm/xonsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adqm/xonsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adqm/xonsh/teams","hooks_url":"https://api.github.com/repos/adqm/xonsh/hooks","issue_events_url":"https://api.github.com/repos/adqm/xonsh/issues/events{/number}","events_url":"https://api.github.com/repos/adqm/xonsh/events","assignees_url":"https://api.github.com/repos/adqm/xonsh/assignees{/user}","branches_url":"https://api.github.com/repos/adqm/xonsh/branches{/branch}","tags_url":"https://api.github.com/repos/adqm/xonsh/tags","blobs_url":"https://api.github.com/repos/adqm/xonsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adqm/xonsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adqm/xonsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/adqm/xonsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adqm/xonsh/statuses/{sha}","languages_url":"https://api.github.com/repos/adqm/xonsh/languages","stargazers_url":"https://api.github.com/repos/adqm/xonsh/stargazers","contributors_url":"https://api.github.com/repos/adqm/xonsh/contributors","subscribers_url":"https://api.github.com/repos/adqm/xonsh/subscribers","subscription_url":"https://api.github.com/repos/adqm/xonsh/subscription","commits_url":"https://api.github.com/repos/adqm/xonsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/adqm/xonsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/adqm/xonsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/adqm/xonsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/adqm/xonsh/contents/{+path}","compare_url":"https://api.github.com/repos/adqm/xonsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adqm/xonsh/merges","archive_url":"https://api.github.com/repos/adqm/xonsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adqm/xonsh/downloads","issues_url":"https://api.github.com/repos/adqm/xonsh/issues{/number}","pulls_url":"https://api.github.com/repos/adqm/xonsh/pulls{/number}","milestones_url":"https://api.github.com/repos/adqm/xonsh/milestones{/number}","notifications_url":"https://api.github.com/repos/adqm/xonsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adqm/xonsh/labels{/name}","releases_url":"https://api.github.com/repos/adqm/xonsh/releases{/id}","created_at":"2015-03-14T00:10:49Z","updated_at":"2015-05-07T12:12:54Z","pushed_at":"2015-07-13T17:06:45Z","git_url":"git://github.com/adqm/xonsh.git","ssh_url":"git@github.com:adqm/xonsh.git","clone_url":"https://github.com/adqm/xonsh.git","svn_url":"https://github.com/adqm/xonsh","homepage":"http://xonsh.org","size":2834,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scopatz:master","ref":"master","sha":"2afb9661159602bc7a98e460ccab11caa8b0fb71","user":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"repo":{"id":29620400,"name":"xonsh","full_name":"scopatz/xonsh","owner":{"login":"scopatz","id":320553,"avatar_url":"https://avatars.githubusercontent.com/u/320553?v=3","gravatar_id":"","url":"https://api.github.com/users/scopatz","html_url":"https://github.com/scopatz","followers_url":"https://api.github.com/users/scopatz/followers","following_url":"https://api.github.com/users/scopatz/following{/other_user}","gists_url":"https://api.github.com/users/scopatz/gists{/gist_id}","starred_url":"https://api.github.com/users/scopatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scopatz/subscriptions","organizations_url":"https://api.github.com/users/scopatz/orgs","repos_url":"https://api.github.com/users/scopatz/repos","events_url":"https://api.github.com/users/scopatz/events{/privacy}","received_events_url":"https://api.github.com/users/scopatz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scopatz/xonsh","description":"xonsh is a Python-ish, BASHwards-compatible shell.","fork":false,"url":"https://api.github.com/repos/scopatz/xonsh","forks_url":"https://api.github.com/repos/scopatz/xonsh/forks","keys_url":"https://api.github.com/repos/scopatz/xonsh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scopatz/xonsh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scopatz/xonsh/teams","hooks_url":"https://api.github.com/repos/scopatz/xonsh/hooks","issue_events_url":"https://api.github.com/repos/scopatz/xonsh/issues/events{/number}","events_url":"https://api.github.com/repos/scopatz/xonsh/events","assignees_url":"https://api.github.com/repos/scopatz/xonsh/assignees{/user}","branches_url":"https://api.github.com/repos/scopatz/xonsh/branches{/branch}","tags_url":"https://api.github.com/repos/scopatz/xonsh/tags","blobs_url":"https://api.github.com/repos/scopatz/xonsh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scopatz/xonsh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scopatz/xonsh/git/refs{/sha}","trees_url":"https://api.github.com/repos/scopatz/xonsh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scopatz/xonsh/statuses/{sha}","languages_url":"https://api.github.com/repos/scopatz/xonsh/languages","stargazers_url":"https://api.github.com/repos/scopatz/xonsh/stargazers","contributors_url":"https://api.github.com/repos/scopatz/xonsh/contributors","subscribers_url":"https://api.github.com/repos/scopatz/xonsh/subscribers","subscription_url":"https://api.github.com/repos/scopatz/xonsh/subscription","commits_url":"https://api.github.com/repos/scopatz/xonsh/commits{/sha}","git_commits_url":"https://api.github.com/repos/scopatz/xonsh/git/commits{/sha}","comments_url":"https://api.github.com/repos/scopatz/xonsh/comments{/number}","issue_comment_url":"https://api.github.com/repos/scopatz/xonsh/issues/comments{/number}","contents_url":"https://api.github.com/repos/scopatz/xonsh/contents/{+path}","compare_url":"https://api.github.com/repos/scopatz/xonsh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scopatz/xonsh/merges","archive_url":"https://api.github.com/repos/scopatz/xonsh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scopatz/xonsh/downloads","issues_url":"https://api.github.com/repos/scopatz/xonsh/issues{/number}","pulls_url":"https://api.github.com/repos/scopatz/xonsh/pulls{/number}","milestones_url":"https://api.github.com/repos/scopatz/xonsh/milestones{/number}","notifications_url":"https://api.github.com/repos/scopatz/xonsh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scopatz/xonsh/labels{/name}","releases_url":"https://api.github.com/repos/scopatz/xonsh/releases{/id}","created_at":"2015-01-21T22:05:27Z","updated_at":"2015-07-13T14:40:06Z","pushed_at":"2015-07-12T21:55:47Z","git_url":"git://github.com/scopatz/xonsh.git","ssh_url":"git@github.com:scopatz/xonsh.git","clone_url":"https://github.com/scopatz/xonsh.git","svn_url":"https://github.com/scopatz/xonsh","homepage":"http://xonsh.org","size":4317,"stargazers_count":412,"watchers_count":412,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":61,"forks":44,"open_issues":61,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/244"},"html":{"href":"https://github.com/scopatz/xonsh/pull/244"},"issue":{"href":"https://api.github.com/repos/scopatz/xonsh/issues/244"},"comments":{"href":"https://api.github.com/repos/scopatz/xonsh/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scopatz/xonsh/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/scopatz/xonsh/statuses/c8e620aa97b8070c184b8a1419a8660a361ae44a"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":3,"additions":38,"deletions":32,"changed_files":7}}