{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/35839228","id":35839228,"diff_hunk":"@@ -27,28 +28,104 @@ This command launches a router connected to your cluster master. The router list\n created by users and keeps a local router configuration up to date with those changes.`\n )\n \n-type templateRouterConfig struct {\n-\tConfig             *clientcmd.Config\n-\tTemplateFile       string\n-\tReloadScript       string\n+// routerConfig represents a container for all other router config types.\n+// Any global config belongs on this level.\n+type routerConfig struct {","path":"pkg/cmd/infra/router/router.go","position":18,"original_position":18,"commit_id":"4f7aaec83d55fcbe604e2d35aa50e3145f8f5aa3","original_commit_id":"4f7aaec83d55fcbe604e2d35aa50e3145f8f5aa3","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"f5 and template bits should probably be split into their own files:\r\n1. config struct\r\n2. flag bindings\r\n3. `make*Plugin` function","created_at":"2015-07-30T05:28:06Z","updated_at":"2015-07-30T05:28:06Z","html_url":"https://github.com/openshift/origin/pull/2940#discussion_r35839228","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/2940","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/35839228"},"html":{"href":"https://github.com/openshift/origin/pull/2940#discussion_r35839228"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/2940"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/2940","id":37166304,"html_url":"https://github.com/openshift/origin/pull/2940","diff_url":"https://github.com/openshift/origin/pull/2940.diff","patch_url":"https://github.com/openshift/origin/pull/2940.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/2940","number":2940,"state":"open","locked":false,"title":"F5 router plugin","user":{"login":"Miciah","id":2042465,"avatar_url":"https://avatars.githubusercontent.com/u/2042465?v=3","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-08T15:38:13Z","updated_at":"2015-07-30T05:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c822c2c14929fba7ee979d47b4e632005dea64db","assignee":null,"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/5","html_url":"https://github.com/openshift/origin/milestones/1.1.0","labels_url":"https://api.github.com/repos/openshift/origin/milestones/5/labels","id":1119756,"number":5,"title":"1.1.0","description":"Corresponds to the 3.1.0 OSE release","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":218,"closed_issues":98,"state":"open","created_at":"2015-05-20T04:04:56Z","updated_at":"2015-07-28T22:29:44Z","due_on":"2015-08-29T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openshift/origin/pulls/2940/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/2940/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/2940/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/4f7aaec83d55fcbe604e2d35aa50e3145f8f5aa3","head":{"label":"Miciah:f5-router-plugin","ref":"f5-router-plugin","sha":"4f7aaec83d55fcbe604e2d35aa50e3145f8f5aa3","user":{"login":"Miciah","id":2042465,"avatar_url":"https://avatars.githubusercontent.com/u/2042465?v=3","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"repo":{"id":31791406,"name":"origin","full_name":"Miciah/origin","owner":{"login":"Miciah","id":2042465,"avatar_url":"https://avatars.githubusercontent.com/u/2042465?v=3","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Miciah/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/Miciah/origin","forks_url":"https://api.github.com/repos/Miciah/origin/forks","keys_url":"https://api.github.com/repos/Miciah/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Miciah/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Miciah/origin/teams","hooks_url":"https://api.github.com/repos/Miciah/origin/hooks","issue_events_url":"https://api.github.com/repos/Miciah/origin/issues/events{/number}","events_url":"https://api.github.com/repos/Miciah/origin/events","assignees_url":"https://api.github.com/repos/Miciah/origin/assignees{/user}","branches_url":"https://api.github.com/repos/Miciah/origin/branches{/branch}","tags_url":"https://api.github.com/repos/Miciah/origin/tags","blobs_url":"https://api.github.com/repos/Miciah/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Miciah/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Miciah/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Miciah/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Miciah/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/Miciah/origin/languages","stargazers_url":"https://api.github.com/repos/Miciah/origin/stargazers","contributors_url":"https://api.github.com/repos/Miciah/origin/contributors","subscribers_url":"https://api.github.com/repos/Miciah/origin/subscribers","subscription_url":"https://api.github.com/repos/Miciah/origin/subscription","commits_url":"https://api.github.com/repos/Miciah/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Miciah/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Miciah/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Miciah/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Miciah/origin/contents/{+path}","compare_url":"https://api.github.com/repos/Miciah/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Miciah/origin/merges","archive_url":"https://api.github.com/repos/Miciah/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Miciah/origin/downloads","issues_url":"https://api.github.com/repos/Miciah/origin/issues{/number}","pulls_url":"https://api.github.com/repos/Miciah/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/Miciah/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/Miciah/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Miciah/origin/labels{/name}","releases_url":"https://api.github.com/repos/Miciah/origin/releases{/id}","created_at":"2015-03-06T22:14:05Z","updated_at":"2015-03-06T22:14:07Z","pushed_at":"2015-07-29T21:21:21Z","git_url":"git://github.com/Miciah/origin.git","ssh_url":"git@github.com:Miciah/origin.git","clone_url":"https://github.com/Miciah/origin.git","svn_url":"https://github.com/Miciah/origin","homepage":"http://www.openshift.org","size":122681,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e44836a66d09dbf07a59a5006a67cd941001e472","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-07-29T18:04:26Z","pushed_at":"2015-07-29T23:15:41Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":191167,"stargazers_count":579,"watchers_count":579,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":329,"mirror_url":null,"open_issues_count":448,"forks":329,"open_issues":448,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/2940"},"html":{"href":"https://github.com/openshift/origin/pull/2940"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/2940"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/2940/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/2940/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/2940/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/4f7aaec83d55fcbe604e2d35aa50e3145f8f5aa3"}}}}