{"action":"created","comment":{"url":"https://api.github.com/repos/jimhester/covr/pulls/comments/22868047","id":22868047,"diff_hunk":"@@ -0,0 +1,20 @@\n+FROM rocker/r-devel\n+MAINTAINER karl.forner@quartzbio.com\n+\n+RUN Rscript -e 'install.packages(\"digest\")'","path":"docker_checker/Dockerfile","position":4,"original_position":4,"commit_id":"9876f132bdf3e28fb9fb85a162dd2fabdf63b118","original_commit_id":"9876f132bdf3e28fb9fb85a162dd2fabdf63b118","user":{"login":"kforner","id":122744,"avatar_url":"https://avatars.githubusercontent.com/u/122744?v=3","gravatar_id":"","url":"https://api.github.com/users/kforner","html_url":"https://github.com/kforner","followers_url":"https://api.github.com/users/kforner/followers","following_url":"https://api.github.com/users/kforner/following{/other_user}","gists_url":"https://api.github.com/users/kforner/gists{/gist_id}","starred_url":"https://api.github.com/users/kforner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kforner/subscriptions","organizations_url":"https://api.github.com/users/kforner/orgs","repos_url":"https://api.github.com/users/kforner/repos","events_url":"https://api.github.com/users/kforner/events{/privacy}","received_events_url":"https://api.github.com/users/kforner/received_events","type":"User","site_admin":false},"body":"sure, it's the result of incremental changes. I'll clean it.","created_at":"2015-01-13T15:18:33Z","updated_at":"2015-01-13T15:18:33Z","html_url":"https://github.com/jimhester/covr/pull/30#discussion_r22868047","pull_request_url":"https://api.github.com/repos/jimhester/covr/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/jimhester/covr/pulls/comments/22868047"},"html":{"href":"https://github.com/jimhester/covr/pull/30#discussion_r22868047"},"pull_request":{"href":"https://api.github.com/repos/jimhester/covr/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/jimhester/covr/pulls/30","id":27230338,"html_url":"https://github.com/jimhester/covr/pull/30","diff_url":"https://github.com/jimhester/covr/pull/30.diff","patch_url":"https://github.com/jimhester/covr/pull/30.patch","issue_url":"https://api.github.com/repos/jimhester/covr/issues/30","number":30,"state":"open","locked":false,"title":"fixed coverage of blocks containing just a name, e.g. {x}. add tests, am...","user":{"login":"kforner","id":122744,"avatar_url":"https://avatars.githubusercontent.com/u/122744?v=3","gravatar_id":"","url":"https://api.github.com/users/kforner","html_url":"https://github.com/kforner","followers_url":"https://api.github.com/users/kforner/followers","following_url":"https://api.github.com/users/kforner/following{/other_user}","gists_url":"https://api.github.com/users/kforner/gists{/gist_id}","starred_url":"https://api.github.com/users/kforner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kforner/subscriptions","organizations_url":"https://api.github.com/users/kforner/orgs","repos_url":"https://api.github.com/users/kforner/repos","events_url":"https://api.github.com/users/kforner/events{/privacy}","received_events_url":"https://api.github.com/users/kforner/received_events","type":"User","site_admin":false},"body":"- improved coverage for blocks with simple expressions, such as:\r\nfunction(x) { x }\r\nfunction() {\r\n   x <- 1\r\n  x\r\n}\r\n\r\nso now expressions such as your a() function:\r\na <- function(x) {\r\nif (x <= 1) {\r\n1\r\n} else {\r\n2\r\n}\r\n}\r\ncan be covered exactly (i.e the \"1\" and \"2\" expressions).\r\n\r\nI also fixed the coverage statistics that assumed the unicity of first_line attributes. I added a test with a case with nested expressions which have same first_line.\r\n\r\nI added some tests, fixed the legacy ones, and provided a Makefile that automates testing with the docker rocker/r-base.\r\n\r\nIn conclusion: with these modifications, your package give the same results that my patched R, results that were checked during a year, so that's really encouraging.\r\n\r\nIf you find this pull request interesting, we could discuss some further optimizations. \r\n\r\n\r\n\r\n","created_at":"2015-01-12T22:05:48Z","updated_at":"2015-01-13T15:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d4235e97bac872395dd4fbcb0b071f8e9cef549","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jimhester/covr/pulls/30/commits","review_comments_url":"https://api.github.com/repos/jimhester/covr/pulls/30/comments","review_comment_url":"https://api.github.com/repos/jimhester/covr/pulls/comments/{number}","comments_url":"https://api.github.com/repos/jimhester/covr/issues/30/comments","statuses_url":"https://api.github.com/repos/jimhester/covr/statuses/9876f132bdf3e28fb9fb85a162dd2fabdf63b118","head":{"label":"kforner:master","ref":"master","sha":"9876f132bdf3e28fb9fb85a162dd2fabdf63b118","user":{"login":"kforner","id":122744,"avatar_url":"https://avatars.githubusercontent.com/u/122744?v=3","gravatar_id":"","url":"https://api.github.com/users/kforner","html_url":"https://github.com/kforner","followers_url":"https://api.github.com/users/kforner/followers","following_url":"https://api.github.com/users/kforner/following{/other_user}","gists_url":"https://api.github.com/users/kforner/gists{/gist_id}","starred_url":"https://api.github.com/users/kforner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kforner/subscriptions","organizations_url":"https://api.github.com/users/kforner/orgs","repos_url":"https://api.github.com/users/kforner/repos","events_url":"https://api.github.com/users/kforner/events{/privacy}","received_events_url":"https://api.github.com/users/kforner/received_events","type":"User","site_admin":false},"repo":{"id":29136564,"name":"covr","full_name":"kforner/covr","owner":{"login":"kforner","id":122744,"avatar_url":"https://avatars.githubusercontent.com/u/122744?v=3","gravatar_id":"","url":"https://api.github.com/users/kforner","html_url":"https://github.com/kforner","followers_url":"https://api.github.com/users/kforner/followers","following_url":"https://api.github.com/users/kforner/following{/other_user}","gists_url":"https://api.github.com/users/kforner/gists{/gist_id}","starred_url":"https://api.github.com/users/kforner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kforner/subscriptions","organizations_url":"https://api.github.com/users/kforner/orgs","repos_url":"https://api.github.com/users/kforner/repos","events_url":"https://api.github.com/users/kforner/events{/privacy}","received_events_url":"https://api.github.com/users/kforner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kforner/covr","description":"Test coverage reports for R","fork":true,"url":"https://api.github.com/repos/kforner/covr","forks_url":"https://api.github.com/repos/kforner/covr/forks","keys_url":"https://api.github.com/repos/kforner/covr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kforner/covr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kforner/covr/teams","hooks_url":"https://api.github.com/repos/kforner/covr/hooks","issue_events_url":"https://api.github.com/repos/kforner/covr/issues/events{/number}","events_url":"https://api.github.com/repos/kforner/covr/events","assignees_url":"https://api.github.com/repos/kforner/covr/assignees{/user}","branches_url":"https://api.github.com/repos/kforner/covr/branches{/branch}","tags_url":"https://api.github.com/repos/kforner/covr/tags","blobs_url":"https://api.github.com/repos/kforner/covr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kforner/covr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kforner/covr/git/refs{/sha}","trees_url":"https://api.github.com/repos/kforner/covr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kforner/covr/statuses/{sha}","languages_url":"https://api.github.com/repos/kforner/covr/languages","stargazers_url":"https://api.github.com/repos/kforner/covr/stargazers","contributors_url":"https://api.github.com/repos/kforner/covr/contributors","subscribers_url":"https://api.github.com/repos/kforner/covr/subscribers","subscription_url":"https://api.github.com/repos/kforner/covr/subscription","commits_url":"https://api.github.com/repos/kforner/covr/commits{/sha}","git_commits_url":"https://api.github.com/repos/kforner/covr/git/commits{/sha}","comments_url":"https://api.github.com/repos/kforner/covr/comments{/number}","issue_comment_url":"https://api.github.com/repos/kforner/covr/issues/comments/{number}","contents_url":"https://api.github.com/repos/kforner/covr/contents/{+path}","compare_url":"https://api.github.com/repos/kforner/covr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kforner/covr/merges","archive_url":"https://api.github.com/repos/kforner/covr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kforner/covr/downloads","issues_url":"https://api.github.com/repos/kforner/covr/issues{/number}","pulls_url":"https://api.github.com/repos/kforner/covr/pulls{/number}","milestones_url":"https://api.github.com/repos/kforner/covr/milestones{/number}","notifications_url":"https://api.github.com/repos/kforner/covr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kforner/covr/labels{/name}","releases_url":"https://api.github.com/repos/kforner/covr/releases{/id}","created_at":"2015-01-12T13:27:05Z","updated_at":"2015-01-12T19:27:53Z","pushed_at":"2015-01-12T19:27:53Z","git_url":"git://github.com/kforner/covr.git","ssh_url":"git@github.com:kforner/covr.git","clone_url":"https://github.com/kforner/covr.git","svn_url":"https://github.com/kforner/covr","homepage":"","size":471,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jimhester:master","ref":"master","sha":"29273862a70165c5ed6428282388e31c86787e30","user":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"repo":{"id":28287105,"name":"covr","full_name":"jimhester/covr","owner":{"login":"jimhester","id":205275,"avatar_url":"https://avatars.githubusercontent.com/u/205275?v=3","gravatar_id":"","url":"https://api.github.com/users/jimhester","html_url":"https://github.com/jimhester","followers_url":"https://api.github.com/users/jimhester/followers","following_url":"https://api.github.com/users/jimhester/following{/other_user}","gists_url":"https://api.github.com/users/jimhester/gists{/gist_id}","starred_url":"https://api.github.com/users/jimhester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimhester/subscriptions","organizations_url":"https://api.github.com/users/jimhester/orgs","repos_url":"https://api.github.com/users/jimhester/repos","events_url":"https://api.github.com/users/jimhester/events{/privacy}","received_events_url":"https://api.github.com/users/jimhester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimhester/covr","description":"Test coverage reports for R","fork":false,"url":"https://api.github.com/repos/jimhester/covr","forks_url":"https://api.github.com/repos/jimhester/covr/forks","keys_url":"https://api.github.com/repos/jimhester/covr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimhester/covr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimhester/covr/teams","hooks_url":"https://api.github.com/repos/jimhester/covr/hooks","issue_events_url":"https://api.github.com/repos/jimhester/covr/issues/events{/number}","events_url":"https://api.github.com/repos/jimhester/covr/events","assignees_url":"https://api.github.com/repos/jimhester/covr/assignees{/user}","branches_url":"https://api.github.com/repos/jimhester/covr/branches{/branch}","tags_url":"https://api.github.com/repos/jimhester/covr/tags","blobs_url":"https://api.github.com/repos/jimhester/covr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimhester/covr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimhester/covr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimhester/covr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimhester/covr/statuses/{sha}","languages_url":"https://api.github.com/repos/jimhester/covr/languages","stargazers_url":"https://api.github.com/repos/jimhester/covr/stargazers","contributors_url":"https://api.github.com/repos/jimhester/covr/contributors","subscribers_url":"https://api.github.com/repos/jimhester/covr/subscribers","subscription_url":"https://api.github.com/repos/jimhester/covr/subscription","commits_url":"https://api.github.com/repos/jimhester/covr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimhester/covr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimhester/covr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimhester/covr/issues/comments/{number}","contents_url":"https://api.github.com/repos/jimhester/covr/contents/{+path}","compare_url":"https://api.github.com/repos/jimhester/covr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimhester/covr/merges","archive_url":"https://api.github.com/repos/jimhester/covr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimhester/covr/downloads","issues_url":"https://api.github.com/repos/jimhester/covr/issues{/number}","pulls_url":"https://api.github.com/repos/jimhester/covr/pulls{/number}","milestones_url":"https://api.github.com/repos/jimhester/covr/milestones{/number}","notifications_url":"https://api.github.com/repos/jimhester/covr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimhester/covr/labels{/name}","releases_url":"https://api.github.com/repos/jimhester/covr/releases{/id}","created_at":"2014-12-21T03:26:04Z","updated_at":"2015-01-12T19:08:06Z","pushed_at":"2015-01-12T19:08:04Z","git_url":"git://github.com/jimhester/covr.git","ssh_url":"git@github.com:jimhester/covr.git","clone_url":"https://github.com/jimhester/covr.git","svn_url":"https://github.com/jimhester/covr","homepage":"","size":471,"stargazers_count":25,"watchers_count":25,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jimhester/covr/pulls/30"},"html":{"href":"https://github.com/jimhester/covr/pull/30"},"issue":{"href":"https://api.github.com/repos/jimhester/covr/issues/30"},"comments":{"href":"https://api.github.com/repos/jimhester/covr/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/jimhester/covr/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/jimhester/covr/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/jimhester/covr/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/jimhester/covr/statuses/9876f132bdf3e28fb9fb85a162dd2fabdf63b118"}}}}