{"action":"created","comment":{"url":"https://api.github.com/repos/apiaryio/dredd/pulls/comments/32616679","id":32616679,"diff_hunk":"@@ -327,20 +328,63 @@ describe 'TransactionRunner', ()->\n           done()\n \n     describe 'when a test has been manually set to skip in a hook', () ->\n+      clonedTransaction = null\n \n-      beforeEach () ->\n+      beforeEach (done) ->\n         sinon.stub configuration.emitter, 'emit'\n+\n+        clonedTransaction = clone(transaction)\n+\n         runner = new Runner(configuration)\n \n+        addHooks runner, [clonedTransaction], (err) ->\n+          done err if err\n+\n+          runner.hooks.beforeHooks =\n+            'Group Machine > Machine > Delete Message > Bogus example name' : [\n+              (transaction) ->\n+                transaction.skip = true\n+            ]\n+          done()\n+\n       afterEach () ->\n         configuration.emitter.emit.restore()\n \n       it 'should skip the test', (done) ->\n-        transaction.skip = true\n-        runner.executeTransaction transaction, () ->\n+        runner.executeAllTransactions [clonedTransaction], runner.hooks, () ->\n           assert.ok configuration.emitter.emit.calledWith 'test skip'\n           done()\n \n+      it 'should add skip message as a warning under `general` to the results on transaction', (done) ->\n+        runner.executeAllTransactions [clonedTransaction], runner.hooks, () ->\n+          messages = clonedTransaction['results']['general'].map (value, index) -> value['message']\n+          assert.include messages.join(), 'skipped'","path":"test/unit/transaction-runner-test.coffee","position":45,"original_position":45,"commit_id":"c0a7b3470003b0b679f162f1c0f2e8058d551417","original_commit_id":"c0a7b3470003b0b679f162f1c0f2e8058d551417","user":{"login":"kuba-kubula","id":136198,"avatar_url":"https://avatars.githubusercontent.com/u/136198?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba-kubula","html_url":"https://github.com/kuba-kubula","followers_url":"https://api.github.com/users/kuba-kubula/followers","following_url":"https://api.github.com/users/kuba-kubula/following{/other_user}","gists_url":"https://api.github.com/users/kuba-kubula/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba-kubula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba-kubula/subscriptions","organizations_url":"https://api.github.com/users/kuba-kubula/orgs","repos_url":"https://api.github.com/users/kuba-kubula/repos","events_url":"https://api.github.com/users/kuba-kubula/events{/privacy}","received_events_url":"https://api.github.com/users/kuba-kubula/received_events","type":"User","site_admin":false},"body":"please test for `'warning'` too, or add another `it` to test the severity `warning` (or add the warning filter into the `.map` function :100: ","created_at":"2015-06-17T11:23:07Z","updated_at":"2015-06-17T11:23:07Z","html_url":"https://github.com/apiaryio/dredd/pull/222#discussion_r32616679","pull_request_url":"https://api.github.com/repos/apiaryio/dredd/pulls/222","_links":{"self":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/comments/32616679"},"html":{"href":"https://github.com/apiaryio/dredd/pull/222#discussion_r32616679"},"pull_request":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/222"}}},"pull_request":{"url":"https://api.github.com/repos/apiaryio/dredd/pulls/222","id":37806607,"html_url":"https://github.com/apiaryio/dredd/pull/222","diff_url":"https://github.com/apiaryio/dredd/pull/222.diff","patch_url":"https://github.com/apiaryio/dredd/pull/222.patch","issue_url":"https://api.github.com/repos/apiaryio/dredd/issues/222","number":222,"state":"open","locked":false,"title":"Report skipped and programatically failed transactions","user":{"login":"netmilk","id":79609,"avatar_url":"https://avatars.githubusercontent.com/u/79609?v=3","gravatar_id":"","url":"https://api.github.com/users/netmilk","html_url":"https://github.com/netmilk","followers_url":"https://api.github.com/users/netmilk/followers","following_url":"https://api.github.com/users/netmilk/following{/other_user}","gists_url":"https://api.github.com/users/netmilk/gists{/gist_id}","starred_url":"https://api.github.com/users/netmilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmilk/subscriptions","organizations_url":"https://api.github.com/users/netmilk/orgs","repos_url":"https://api.github.com/users/netmilk/repos","events_url":"https://api.github.com/users/netmilk/events{/privacy}","received_events_url":"https://api.github.com/users/netmilk/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-16T15:18:02Z","updated_at":"2015-06-17T11:23:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81d7ef3f8c190efdb88abdb50166347788fab2bc","assignee":{"login":"kuba-kubula","id":136198,"avatar_url":"https://avatars.githubusercontent.com/u/136198?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba-kubula","html_url":"https://github.com/kuba-kubula","followers_url":"https://api.github.com/users/kuba-kubula/followers","following_url":"https://api.github.com/users/kuba-kubula/following{/other_user}","gists_url":"https://api.github.com/users/kuba-kubula/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba-kubula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba-kubula/subscriptions","organizations_url":"https://api.github.com/users/kuba-kubula/orgs","repos_url":"https://api.github.com/users/kuba-kubula/repos","events_url":"https://api.github.com/users/kuba-kubula/events{/privacy}","received_events_url":"https://api.github.com/users/kuba-kubula/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/dredd/pulls/222/commits","review_comments_url":"https://api.github.com/repos/apiaryio/dredd/pulls/222/comments","review_comment_url":"https://api.github.com/repos/apiaryio/dredd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apiaryio/dredd/issues/222/comments","statuses_url":"https://api.github.com/repos/apiaryio/dredd/statuses/c0a7b3470003b0b679f162f1c0f2e8058d551417","head":{"label":"apiaryio:netmilk/trans-skip-fail-to-report","ref":"netmilk/trans-skip-fail-to-report","sha":"c0a7b3470003b0b679f162f1c0f2e8058d551417","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":12590052,"name":"dredd","full_name":"apiaryio/dredd","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/dredd","description":"API Blueprint testing tool","fork":false,"url":"https://api.github.com/repos/apiaryio/dredd","forks_url":"https://api.github.com/repos/apiaryio/dredd/forks","keys_url":"https://api.github.com/repos/apiaryio/dredd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/dredd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/dredd/teams","hooks_url":"https://api.github.com/repos/apiaryio/dredd/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/dredd/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/dredd/events","assignees_url":"https://api.github.com/repos/apiaryio/dredd/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/dredd/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/dredd/tags","blobs_url":"https://api.github.com/repos/apiaryio/dredd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/dredd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/dredd/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/dredd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/dredd/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/dredd/languages","stargazers_url":"https://api.github.com/repos/apiaryio/dredd/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/dredd/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/dredd/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/dredd/subscription","commits_url":"https://api.github.com/repos/apiaryio/dredd/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/dredd/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/dredd/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/dredd/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/dredd/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/dredd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/dredd/merges","archive_url":"https://api.github.com/repos/apiaryio/dredd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/dredd/downloads","issues_url":"https://api.github.com/repos/apiaryio/dredd/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/dredd/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/dredd/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/dredd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/dredd/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/dredd/releases{/id}","created_at":"2013-09-04T12:21:35Z","updated_at":"2015-06-17T10:45:35Z","pushed_at":"2015-06-16T18:51:48Z","git_url":"git://github.com/apiaryio/dredd.git","ssh_url":"git@github.com:apiaryio/dredd.git","clone_url":"https://github.com/apiaryio/dredd.git","svn_url":"https://github.com/apiaryio/dredd","homepage":"http://dredd.readthedocs.org/","size":2688,"stargazers_count":508,"watchers_count":508,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":44,"forks":41,"open_issues":44,"watchers":508,"default_branch":"master"}},"base":{"label":"apiaryio:master","ref":"master","sha":"84a07fa2fe6f244a9ea44d439d5e9c339e6d5108","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":12590052,"name":"dredd","full_name":"apiaryio/dredd","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/dredd","description":"API Blueprint testing tool","fork":false,"url":"https://api.github.com/repos/apiaryio/dredd","forks_url":"https://api.github.com/repos/apiaryio/dredd/forks","keys_url":"https://api.github.com/repos/apiaryio/dredd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/dredd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/dredd/teams","hooks_url":"https://api.github.com/repos/apiaryio/dredd/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/dredd/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/dredd/events","assignees_url":"https://api.github.com/repos/apiaryio/dredd/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/dredd/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/dredd/tags","blobs_url":"https://api.github.com/repos/apiaryio/dredd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/dredd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/dredd/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/dredd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/dredd/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/dredd/languages","stargazers_url":"https://api.github.com/repos/apiaryio/dredd/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/dredd/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/dredd/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/dredd/subscription","commits_url":"https://api.github.com/repos/apiaryio/dredd/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/dredd/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/dredd/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/dredd/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/dredd/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/dredd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/dredd/merges","archive_url":"https://api.github.com/repos/apiaryio/dredd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/dredd/downloads","issues_url":"https://api.github.com/repos/apiaryio/dredd/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/dredd/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/dredd/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/dredd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/dredd/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/dredd/releases{/id}","created_at":"2013-09-04T12:21:35Z","updated_at":"2015-06-17T10:45:35Z","pushed_at":"2015-06-16T18:51:48Z","git_url":"git://github.com/apiaryio/dredd.git","ssh_url":"git@github.com:apiaryio/dredd.git","clone_url":"https://github.com/apiaryio/dredd.git","svn_url":"https://github.com/apiaryio/dredd","homepage":"http://dredd.readthedocs.org/","size":2688,"stargazers_count":508,"watchers_count":508,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":44,"forks":41,"open_issues":44,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/222"},"html":{"href":"https://github.com/apiaryio/dredd/pull/222"},"issue":{"href":"https://api.github.com/repos/apiaryio/dredd/issues/222"},"comments":{"href":"https://api.github.com/repos/apiaryio/dredd/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/dredd/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/dredd/statuses/c0a7b3470003b0b679f162f1c0f2e8058d551417"}}}}