{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/24254044","id":24254044,"diff_hunk":"@@ -271,13 +270,13 @@ auth_tcp = \"<%= @libvirtd_auth_tcp %>\"\n #\n # XXX this isn't actually enforced yet, only the per-client\n # limit is used so far\n-#max_requests = 20\n+max_requests = <%= @libvirtd_max_clients %>\n \n # Limit on concurrent requests from a single client\n # connection. To avoid one client monopolizing the server\n # this should be a small fraction of the global max_requests\n # and max_workers parameter\n-#max_client_requests = 5\n+max_client_requests = <%= @libvirtd_prio_workers %>","path":"chef/cookbooks/nova/templates/default/libvirtd.conf.erb","position":39,"original_position":39,"commit_id":"86548982e38a4acfcab4330c76f1e9f2df74d908","original_commit_id":"ed986ce681ede0fd16d77c92aa0a38187597a9fe","user":{"login":"jfehlig","id":1170408,"avatar_url":"https://avatars.githubusercontent.com/u/1170408?v=3","gravatar_id":"","url":"https://api.github.com/users/jfehlig","html_url":"https://github.com/jfehlig","followers_url":"https://api.github.com/users/jfehlig/followers","following_url":"https://api.github.com/users/jfehlig/following{/other_user}","gists_url":"https://api.github.com/users/jfehlig/gists{/gist_id}","starred_url":"https://api.github.com/users/jfehlig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfehlig/subscriptions","organizations_url":"https://api.github.com/users/jfehlig/orgs","repos_url":"https://api.github.com/users/jfehlig/repos","events_url":"https://api.github.com/users/jfehlig/events{/privacy}","received_events_url":"https://api.github.com/users/jfehlig/received_events","type":"User","site_admin":false},"body":"This implies the number of priority workers is related to max client requests and min workers, but it's not.  Do you think it is required to change priority workers?\r\n\r\nI think these changes depend on how nova manages connections to libvirtd.  If only one connection when nova initializes, then bumping max_workers and max_client_requests should be all thats needed.  If there is one connection per operartion, then bump max_clients and max_workers.\r\n\r\nNote that max_clients has changed to 5000 upstream, and addtional knobs have been added.  These changes are in SLES12:\r\n# The maximum number of concurrent client connections to allow\r\n# over all sockets combined.\r\n#max_clients = 5000\r\n\r\n# The maximum length of queue of connections waiting to be\r\n# accepted by the daemon. Note, that some protocols supporting\r\n# retransmission may obey this so that a later reattempt at\r\n# connection succeeds.\r\n#max_queued_clients = 1000\r\n\r\n# The maximum length of queue of accepted but not yet not\r\n# authenticated clients. The default value is zero, meaning\r\n# the feature is disabled.\r\n#max_anonymous_clients = 20","created_at":"2015-02-06T16:55:20Z","updated_at":"2015-02-06T16:55:20Z","html_url":"https://github.com/crowbar/barclamp-nova/pull/426#discussion_r24254044","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/24254044"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/426#discussion_r24254044"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426","id":28797923,"html_url":"https://github.com/crowbar/barclamp-nova/pull/426","diff_url":"https://github.com/crowbar/barclamp-nova/pull/426.diff","patch_url":"https://github.com/crowbar/barclamp-nova/pull/426.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/426","number":426,"state":"open","locked":false,"title":"Scale up libvirtd workers for powerful compute hosts","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"Partner tested OpenStack on a 8192 CPU machine and quickly ran into\r\nlimits on the libvirtd site. Try to scale this up a little.","created_at":"2015-02-06T10:18:37Z","updated_at":"2015-02-06T16:55:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ebc565f304439b1f96ed8a3ad78541929f514e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/426/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/86548982e38a4acfcab4330c76f1e9f2df74d908","head":{"label":"dirkmueller:master","ref":"master","sha":"86548982e38a4acfcab4330c76f1e9f2df74d908","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"repo":{"id":10646687,"name":"barclamp-nova","full_name":"dirkmueller/barclamp-nova","owner":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkmueller/barclamp-nova","description":"OpenStack Compute","fork":true,"url":"https://api.github.com/repos/dirkmueller/barclamp-nova","forks_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/forks","keys_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/events","assignees_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/merges","archive_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/dirkmueller/barclamp-nova/releases{/id}","created_at":"2013-06-12T16:13:55Z","updated_at":"2015-02-06T16:24:45Z","pushed_at":"2015-02-06T16:24:44Z","git_url":"git://github.com/dirkmueller/barclamp-nova.git","ssh_url":"git@github.com:dirkmueller/barclamp-nova.git","clone_url":"https://github.com/dirkmueller/barclamp-nova.git","svn_url":"https://github.com/dirkmueller/barclamp-nova","homepage":"https://github.com/dellcloudedge/crowbar","size":2379,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"717fc054edc4b0a167f33f231e1d61fd61126de3","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351631,"name":"barclamp-nova","full_name":"crowbar/barclamp-nova","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-nova","description":"OpenStack Nova: Compute component","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-nova","forks_url":"https://api.github.com/repos/crowbar/barclamp-nova/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-nova/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-nova/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-nova/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-nova/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-nova/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-nova/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-nova/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-nova/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-nova/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-nova/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-nova/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-nova/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-nova/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues/comments/{number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-nova/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-nova/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-nova/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-nova/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-nova/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-nova/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-nova/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-nova/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-nova/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-nova/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-nova/releases{/id}","created_at":"2011-09-08T21:23:08Z","updated_at":"2015-02-05T11:46:20Z","pushed_at":"2015-02-05T11:46:19Z","git_url":"git://github.com/crowbar/barclamp-nova.git","ssh_url":"git@github.com:crowbar/barclamp-nova.git","clone_url":"https://github.com/crowbar/barclamp-nova.git","svn_url":"https://github.com/crowbar/barclamp-nova","homepage":"https://github.com/crowbar/crowbar","size":4151,"stargazers_count":64,"watchers_count":64,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":9,"forks":193,"open_issues":9,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426"},"html":{"href":"https://github.com/crowbar/barclamp-nova/pull/426"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/426"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-nova/statuses/86548982e38a4acfcab4330c76f1e9f2df74d908"}}}}