{"action":"closed","number":360,"pull_request":{"url":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360","id":18909480,"html_url":"https://github.com/xp-framework/xp-framework/pull/360","diff_url":"https://github.com/xp-framework/xp-framework/pull/360.diff","patch_url":"https://github.com/xp-framework/xp-framework/pull/360.patch","issue_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/360","number":360,"state":"closed","locked":false,"title":"Sybase/MSSQL: Fix for repeated EED messages","user":{"login":"thekid","id":696742,"avatar_url":"https://avatars.githubusercontent.com/u/696742?v=3","gravatar_id":"","url":"https://api.github.com/users/thekid","html_url":"https://github.com/thekid","followers_url":"https://api.github.com/users/thekid/followers","following_url":"https://api.github.com/users/thekid/following{/other_user}","gists_url":"https://api.github.com/users/thekid/gists{/gist_id}","starred_url":"https://api.github.com/users/thekid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekid/subscriptions","organizations_url":"https://api.github.com/users/thekid/orgs","repos_url":"https://api.github.com/users/thekid/repos","events_url":"https://api.github.com/users/thekid/events{/privacy}","received_events_url":"https://api.github.com/users/thekid/received_events","type":"User","site_admin":false},"body":"This pull request fixes repeated EED server messages causing error handling to break subsequent queries. An error like this can be provoked by issuing a query as follows:\r\n\r\n```sql\r\nselect not_the_table_name.field1, not_the_table_name.field2 from table_name\r\n```\r\n\r\nThis pull request adds an integration test to verify this. If this test is run with the implementation existing on the master branch, the effect can nicely be seen:\r\n\r\n```\r\nF unittest.TestError(test= net.xp_framework.unittest.rdbms.integration.SybaseIntegrationTest::repeated_extend_errors, time= 0.027 seconds) {\r\n  Exception rdbms.SQLStatementFailedException (errorcode 0: Unexpected token 0x5F (number 0)) {\r\n    select 1\r\n  }\r\n```","created_at":"2014-07-25T17:54:54Z","updated_at":"2015-02-15T12:39:51Z","closed_at":"2015-02-15T12:39:49Z","merged_at":"2015-02-15T12:39:49Z","merge_commit_sha":"c1c6911aa026e8b5f4ab34cf08553a956c914e0e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360/commits","review_comments_url":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360/comments","review_comment_url":"https://api.github.com/repos/xp-framework/xp-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/360/comments","statuses_url":"https://api.github.com/repos/xp-framework/xp-framework/statuses/1ed3a5c9b2db234fd821aed27ef4acb32a9ce1de","head":{"label":"xp-framework:fix/repeated-eed-messages","ref":"fix/repeated-eed-messages","sha":"1ed3a5c9b2db234fd821aed27ef4acb32a9ce1de","user":{"login":"xp-framework","id":696817,"avatar_url":"https://avatars.githubusercontent.com/u/696817?v=3","gravatar_id":"","url":"https://api.github.com/users/xp-framework","html_url":"https://github.com/xp-framework","followers_url":"https://api.github.com/users/xp-framework/followers","following_url":"https://api.github.com/users/xp-framework/following{/other_user}","gists_url":"https://api.github.com/users/xp-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xp-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xp-framework/subscriptions","organizations_url":"https://api.github.com/users/xp-framework/orgs","repos_url":"https://api.github.com/users/xp-framework/repos","events_url":"https://api.github.com/users/xp-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xp-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":1618539,"name":"xp-framework","full_name":"xp-framework/xp-framework","owner":{"login":"xp-framework","id":696817,"avatar_url":"https://avatars.githubusercontent.com/u/696817?v=3","gravatar_id":"","url":"https://api.github.com/users/xp-framework","html_url":"https://github.com/xp-framework","followers_url":"https://api.github.com/users/xp-framework/followers","following_url":"https://api.github.com/users/xp-framework/following{/other_user}","gists_url":"https://api.github.com/users/xp-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xp-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xp-framework/subscriptions","organizations_url":"https://api.github.com/users/xp-framework/orgs","repos_url":"https://api.github.com/users/xp-framework/repos","events_url":"https://api.github.com/users/xp-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xp-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xp-framework/xp-framework","description":"[5.X] The XP framework is an all-purpose, object oriented PHP framework.","fork":false,"url":"https://api.github.com/repos/xp-framework/xp-framework","forks_url":"https://api.github.com/repos/xp-framework/xp-framework/forks","keys_url":"https://api.github.com/repos/xp-framework/xp-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xp-framework/xp-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xp-framework/xp-framework/teams","hooks_url":"https://api.github.com/repos/xp-framework/xp-framework/hooks","issue_events_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/events{/number}","events_url":"https://api.github.com/repos/xp-framework/xp-framework/events","assignees_url":"https://api.github.com/repos/xp-framework/xp-framework/assignees{/user}","branches_url":"https://api.github.com/repos/xp-framework/xp-framework/branches{/branch}","tags_url":"https://api.github.com/repos/xp-framework/xp-framework/tags","blobs_url":"https://api.github.com/repos/xp-framework/xp-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xp-framework/xp-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xp-framework/xp-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xp-framework/xp-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xp-framework/xp-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/xp-framework/xp-framework/languages","stargazers_url":"https://api.github.com/repos/xp-framework/xp-framework/stargazers","contributors_url":"https://api.github.com/repos/xp-framework/xp-framework/contributors","subscribers_url":"https://api.github.com/repos/xp-framework/xp-framework/subscribers","subscription_url":"https://api.github.com/repos/xp-framework/xp-framework/subscription","commits_url":"https://api.github.com/repos/xp-framework/xp-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xp-framework/xp-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xp-framework/xp-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/xp-framework/xp-framework/contents/{+path}","compare_url":"https://api.github.com/repos/xp-framework/xp-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xp-framework/xp-framework/merges","archive_url":"https://api.github.com/repos/xp-framework/xp-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xp-framework/xp-framework/downloads","issues_url":"https://api.github.com/repos/xp-framework/xp-framework/issues{/number}","pulls_url":"https://api.github.com/repos/xp-framework/xp-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/xp-framework/xp-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/xp-framework/xp-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xp-framework/xp-framework/labels{/name}","releases_url":"https://api.github.com/repos/xp-framework/xp-framework/releases{/id}","created_at":"2011-04-15T10:55:54Z","updated_at":"2015-02-15T12:35:01Z","pushed_at":"2015-02-15T12:39:49Z","git_url":"git://github.com/xp-framework/xp-framework.git","ssh_url":"git@github.com:xp-framework/xp-framework.git","clone_url":"https://github.com/xp-framework/xp-framework.git","svn_url":"https://github.com/xp-framework/xp-framework","homepage":"http://xp-framework.net/","size":47425,"stargazers_count":36,"watchers_count":36,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":9,"forks":28,"open_issues":9,"watchers":36,"default_branch":"master"}},"base":{"label":"xp-framework:master","ref":"master","sha":"bcb020647a2b2880071a38b7470b0e651cc77664","user":{"login":"xp-framework","id":696817,"avatar_url":"https://avatars.githubusercontent.com/u/696817?v=3","gravatar_id":"","url":"https://api.github.com/users/xp-framework","html_url":"https://github.com/xp-framework","followers_url":"https://api.github.com/users/xp-framework/followers","following_url":"https://api.github.com/users/xp-framework/following{/other_user}","gists_url":"https://api.github.com/users/xp-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xp-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xp-framework/subscriptions","organizations_url":"https://api.github.com/users/xp-framework/orgs","repos_url":"https://api.github.com/users/xp-framework/repos","events_url":"https://api.github.com/users/xp-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xp-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":1618539,"name":"xp-framework","full_name":"xp-framework/xp-framework","owner":{"login":"xp-framework","id":696817,"avatar_url":"https://avatars.githubusercontent.com/u/696817?v=3","gravatar_id":"","url":"https://api.github.com/users/xp-framework","html_url":"https://github.com/xp-framework","followers_url":"https://api.github.com/users/xp-framework/followers","following_url":"https://api.github.com/users/xp-framework/following{/other_user}","gists_url":"https://api.github.com/users/xp-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/xp-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xp-framework/subscriptions","organizations_url":"https://api.github.com/users/xp-framework/orgs","repos_url":"https://api.github.com/users/xp-framework/repos","events_url":"https://api.github.com/users/xp-framework/events{/privacy}","received_events_url":"https://api.github.com/users/xp-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xp-framework/xp-framework","description":"[5.X] The XP framework is an all-purpose, object oriented PHP framework.","fork":false,"url":"https://api.github.com/repos/xp-framework/xp-framework","forks_url":"https://api.github.com/repos/xp-framework/xp-framework/forks","keys_url":"https://api.github.com/repos/xp-framework/xp-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xp-framework/xp-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xp-framework/xp-framework/teams","hooks_url":"https://api.github.com/repos/xp-framework/xp-framework/hooks","issue_events_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/events{/number}","events_url":"https://api.github.com/repos/xp-framework/xp-framework/events","assignees_url":"https://api.github.com/repos/xp-framework/xp-framework/assignees{/user}","branches_url":"https://api.github.com/repos/xp-framework/xp-framework/branches{/branch}","tags_url":"https://api.github.com/repos/xp-framework/xp-framework/tags","blobs_url":"https://api.github.com/repos/xp-framework/xp-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xp-framework/xp-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xp-framework/xp-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/xp-framework/xp-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xp-framework/xp-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/xp-framework/xp-framework/languages","stargazers_url":"https://api.github.com/repos/xp-framework/xp-framework/stargazers","contributors_url":"https://api.github.com/repos/xp-framework/xp-framework/contributors","subscribers_url":"https://api.github.com/repos/xp-framework/xp-framework/subscribers","subscription_url":"https://api.github.com/repos/xp-framework/xp-framework/subscription","commits_url":"https://api.github.com/repos/xp-framework/xp-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/xp-framework/xp-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/xp-framework/xp-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/xp-framework/xp-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/xp-framework/xp-framework/contents/{+path}","compare_url":"https://api.github.com/repos/xp-framework/xp-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xp-framework/xp-framework/merges","archive_url":"https://api.github.com/repos/xp-framework/xp-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xp-framework/xp-framework/downloads","issues_url":"https://api.github.com/repos/xp-framework/xp-framework/issues{/number}","pulls_url":"https://api.github.com/repos/xp-framework/xp-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/xp-framework/xp-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/xp-framework/xp-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xp-framework/xp-framework/labels{/name}","releases_url":"https://api.github.com/repos/xp-framework/xp-framework/releases{/id}","created_at":"2011-04-15T10:55:54Z","updated_at":"2015-02-15T12:35:01Z","pushed_at":"2015-02-15T12:39:49Z","git_url":"git://github.com/xp-framework/xp-framework.git","ssh_url":"git@github.com:xp-framework/xp-framework.git","clone_url":"https://github.com/xp-framework/xp-framework.git","svn_url":"https://github.com/xp-framework/xp-framework","homepage":"http://xp-framework.net/","size":47425,"stargazers_count":36,"watchers_count":36,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":9,"forks":28,"open_issues":9,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360"},"html":{"href":"https://github.com/xp-framework/xp-framework/pull/360"},"issue":{"href":"https://api.github.com/repos/xp-framework/xp-framework/issues/360"},"comments":{"href":"https://api.github.com/repos/xp-framework/xp-framework/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/xp-framework/xp-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xp-framework/xp-framework/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/xp-framework/xp-framework/statuses/1ed3a5c9b2db234fd821aed27ef4acb32a9ce1de"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"thekid","id":696742,"avatar_url":"https://avatars.githubusercontent.com/u/696742?v=3","gravatar_id":"","url":"https://api.github.com/users/thekid","html_url":"https://github.com/thekid","followers_url":"https://api.github.com/users/thekid/followers","following_url":"https://api.github.com/users/thekid/following{/other_user}","gists_url":"https://api.github.com/users/thekid/gists{/gist_id}","starred_url":"https://api.github.com/users/thekid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thekid/subscriptions","organizations_url":"https://api.github.com/users/thekid/orgs","repos_url":"https://api.github.com/users/thekid/repos","events_url":"https://api.github.com/users/thekid/events{/privacy}","received_events_url":"https://api.github.com/users/thekid/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":8,"additions":137,"deletions":79,"changed_files":6}}