{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/46618522","id":46618522,"diff_hunk":"@@ -564,22 +564,23 @@ goog.scope(function() {\n                 gl.checkFramebufferStatus(gl.FRAMEBUFFER);\n                 this.expectError(gl.NO_ERROR);\n \n-                bufferedLogToConsole('gl.INVALID_ENUM is generated if one of the values in bufs is not an accepted value.');\n-                gl.drawBuffers(values.splice(2, 2));\n-                this.expectError(gl.INVALID_ENUM);\n+                bufferedLogToConsole('gl.INVALID_OPERATION is generated if the GL is bound to framebuffer object and one of the values in bufs is not an accepted value.');\n+                gl.drawBuffers(values.slice(0, 2));\n+                this.expectError(gl.INVALID_OPERATION);","path":"sdk/tests/deqp/functional/gles3/es3fNegativeBufferApiTests.js","position":9,"original_position":9,"commit_id":"bdf27360592c5f7ec70ec5a3d12337d71390a326","original_commit_id":"bdf27360592c5f7ec70ec5a3d12337d71390a326","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"body":"Agree that the ES 3.0.4 spec is unclear for this error case, but the manual page is pretty clear that INVALID_ENUM should be generated here. The reason it's generated is that DEPTH_ATTACHMENT is not a valid buffer to name in the drawBuffers call.\r\n\r\nThere is a bug here though. It should be calling:\r\n  gl.drawBuffers(values.slice(2, 4))\r\nnot \"splice\".","created_at":"2015-12-03T21:55:44Z","updated_at":"2015-12-03T21:55:44Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1347#discussion_r46618522","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/46618522"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1347#discussion_r46618522"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347","id":52554638,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1347","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1347.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1347.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1347","number":1347,"state":"open","locked":false,"title":"fix the errors when calling drawBuffers in negativebufferapi","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"body":"Fix the bug of http://code.google.com/p/chromium/issues/detail?id=565347. \r\n\r\nPTAL. Thanks a lot.","created_at":"2015-12-03T16:09:46Z","updated_at":"2015-12-03T21:55:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cd8cda6dd7d2af8e659b16cf14b4457049061a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1347/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/bdf27360592c5f7ec70ec5a3d12337d71390a326","head":{"label":"Richard-Yunchao:drawBuffers","ref":"drawBuffers","sha":"bdf27360592c5f7ec70ec5a3d12337d71390a326","user":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"repo":{"id":32059852,"name":"WebGL","full_name":"Richard-Yunchao/WebGL","owner":{"login":"Richard-Yunchao","id":11435653,"avatar_url":"https://avatars.githubusercontent.com/u/11435653?v=3","gravatar_id":"","url":"https://api.github.com/users/Richard-Yunchao","html_url":"https://github.com/Richard-Yunchao","followers_url":"https://api.github.com/users/Richard-Yunchao/followers","following_url":"https://api.github.com/users/Richard-Yunchao/following{/other_user}","gists_url":"https://api.github.com/users/Richard-Yunchao/gists{/gist_id}","starred_url":"https://api.github.com/users/Richard-Yunchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Richard-Yunchao/subscriptions","organizations_url":"https://api.github.com/users/Richard-Yunchao/orgs","repos_url":"https://api.github.com/users/Richard-Yunchao/repos","events_url":"https://api.github.com/users/Richard-Yunchao/events{/privacy}","received_events_url":"https://api.github.com/users/Richard-Yunchao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Richard-Yunchao/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/Richard-Yunchao/WebGL","forks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/forks","keys_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/teams","hooks_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/hooks","issue_events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/events","assignees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/tags","blobs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/languages","stargazers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/stargazers","contributors_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contributors","subscribers_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscribers","subscription_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/subscription","commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/merges","archive_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/downloads","issues_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/Richard-Yunchao/WebGL/releases{/id}","created_at":"2015-03-12T05:57:15Z","updated_at":"2015-03-16T06:06:31Z","pushed_at":"2015-12-03T17:10:35Z","git_url":"git://github.com/Richard-Yunchao/WebGL.git","ssh_url":"git@github.com:Richard-Yunchao/WebGL.git","clone_url":"https://github.com/Richard-Yunchao/WebGL.git","svn_url":"https://github.com/Richard-Yunchao/WebGL","homepage":null,"size":19768,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"2fe9c5a36cd69e8c7b646627f7fce1abb80f0cc6","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","created_at":"2012-07-27T17:21:51Z","updated_at":"2015-12-01T22:04:58Z","pushed_at":"2015-12-03T21:42:23Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":26302,"stargazers_count":468,"watchers_count":468,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":50,"forks":257,"open_issues":50,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1347"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1347"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1347/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1347/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/bdf27360592c5f7ec70ec5a3d12337d71390a326"}}}}