{"action":"created","issue":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/800","labels_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/800/labels{/name}","comments_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/800/comments","events_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/800/events","html_url":"https://github.com/sinkillerj/ProjectE/pull/800","id":89835704,"number":800,"title":"When a fix doesn't work, take a wrecking ball to it","user":{"login":"williewillus","id":2015032,"avatar_url":"https://avatars.githubusercontent.com/u/2015032?v=3","gravatar_id":"","url":"https://api.github.com/users/williewillus","html_url":"https://github.com/williewillus","followers_url":"https://api.github.com/users/williewillus/followers","following_url":"https://api.github.com/users/williewillus/following{/other_user}","gists_url":"https://api.github.com/users/williewillus/gists{/gist_id}","starred_url":"https://api.github.com/users/williewillus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williewillus/subscriptions","organizations_url":"https://api.github.com/users/williewillus/orgs","repos_url":"https://api.github.com/users/williewillus/repos","events_url":"https://api.github.com/users/williewillus/events{/privacy}","received_events_url":"https://api.github.com/users/williewillus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-06-20T23:34:37Z","updated_at":"2015-06-22T15:50:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/800","html_url":"https://github.com/sinkillerj/ProjectE/pull/800","diff_url":"https://github.com/sinkillerj/ProjectE/pull/800.diff","patch_url":"https://github.com/sinkillerj/ProjectE/pull/800.patch"},"body":"Summary: Completely and utterly unify the Transmutation interface. No more duplicated code (look at the diff to see just how much >.>)\r\n\r\nDetails:\r\n* Another writeToNBT crash was reported even after our last fix. I get mad.\r\n* The only reason the transmutation ever writes to nbt is to store the left side (lock and input slots) in either a TE or the Tablet NBT\r\n* So I just made it so anything in the left side is saved with the player in the new save code. Nothing will ever writeToNBT to a TE or ItemStack again :). \r\n* Enhancement - now your lock/input item will show up in all transmutation interfaces, not just that one tablet or table.\r\n* Merge the two copies of the same UI we had going on into one. It was surprising to see just how much of this gui/inv/container system was just two straight up copies of the same exact code with `transmutetile` substituted for `transmutetablet`\r\n* As a side result - table is no longer a TE, since it just tells MC to open the same gui as a tablet (think vanilla crafting table), and tablet no longer needs NBT data. Table no longer has that stupid one player restriction problem (cheap lazy solution when it was coded back then).\r\n* So much code ripped out....yummy. I like.\r\n\r\nI reached feature parity, but some testing may be needed since I ripped out a lot of stuff (mainly dupe code but still).\r\nHappy PR 800."},"comment":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/comments/114161129","html_url":"https://github.com/sinkillerj/ProjectE/pull/800#issuecomment-114161129","issue_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/800","id":114161129,"user":{"login":"williewillus","id":2015032,"avatar_url":"https://avatars.githubusercontent.com/u/2015032?v=3","gravatar_id":"","url":"https://api.github.com/users/williewillus","html_url":"https://github.com/williewillus","followers_url":"https://api.github.com/users/williewillus/followers","following_url":"https://api.github.com/users/williewillus/following{/other_user}","gists_url":"https://api.github.com/users/williewillus/gists{/gist_id}","starred_url":"https://api.github.com/users/williewillus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williewillus/subscriptions","organizations_url":"https://api.github.com/users/williewillus/orgs","repos_url":"https://api.github.com/users/williewillus/repos","events_url":"https://api.github.com/users/williewillus/events{/privacy}","received_events_url":"https://api.github.com/users/williewillus/received_events","type":"User","site_admin":false},"created_at":"2015-06-22T15:50:40Z","updated_at":"2015-06-22T15:50:40Z","body":"Ping me if there's any other concerns you have with this, devs."}}