{"action":"created","comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/37511746","id":37511746,"diff_hunk":"@@ -0,0 +1,249 @@\n+/*\n+ * Copyright (C) 2014 Kirk Scheper <kirkscheper@gmail.com>\n+ *\n+ * This file is part of paparazzi.\n+ *\n+ * paparazzi is free software; you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation; either version 2, or (at your option)\n+ * any later version.\n+ *\n+ * paparazzi is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with paparazzi; see the file COPYING. If not, write to\n+ * the Free Software Foundation, 59 Temple Place - Suite 330,\n+ * Boston, MA 02111-1307, USA.\n+ *\n+ */\n+\n+/**\n+ * @file subsystems/datalink/bluegiga.c\n+ * Datalink implementation for the BlueGiga Bluetooth radio chip trough SPI\n+ */\n+\n+#include \"mcu_periph/sys_time.h\"\n+#include \"subsystems/datalink/bluegiga.h\"\n+#include \"mcu_periph/spi.h\"\n+#include \"mcu_periph/gpio.h\"\n+\n+#ifndef BLUEGIGA_SPI_DEV\n+#error \"bluegiga: must define a BLUEGIGA_SPI_DEV\"\n+#endif\n+\n+#ifndef BLUEGIGA_SLAVE_IDX\n+#define BLUEGIGA_SLAVE_IDX SPI_SLAVE2","path":"sw/airborne/subsystems/datalink/bluegiga.c","position":38,"original_position":38,"commit_id":"1f79c3d672a96e5499ae75ffb9347980585d5a48","original_commit_id":"1f79c3d672a96e5499ae75ffb9347980585d5a48","user":{"login":"flixr","id":104257,"avatar_url":"https://avatars.githubusercontent.com/u/104257?v=3","gravatar_id":"","url":"https://api.github.com/users/flixr","html_url":"https://github.com/flixr","followers_url":"https://api.github.com/users/flixr/followers","following_url":"https://api.github.com/users/flixr/following{/other_user}","gists_url":"https://api.github.com/users/flixr/gists{/gist_id}","starred_url":"https://api.github.com/users/flixr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flixr/subscriptions","organizations_url":"https://api.github.com/users/flixr/orgs","repos_url":"https://api.github.com/users/flixr/repos","events_url":"https://api.github.com/users/flixr/events{/privacy}","received_events_url":"https://api.github.com/users/flixr/received_events","type":"User","site_admin":false},"body":"This does not make any sense, if I see it correctly, then the bluegiga_spi.slave_idx is not even used anywhere in the slave code.\r\nBetter completely remove this and set slave_idx to zero below, so that it works if SPI_SLAVE2 is not defined","created_at":"2015-08-20T09:40:56Z","updated_at":"2015-08-20T09:40:56Z","html_url":"https://github.com/paparazzi/paparazzi/pull/1303#discussion_r37511746","pull_request_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303","_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/37511746"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1303#discussion_r37511746"},"pull_request":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303"}}},"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303","id":42597394,"html_url":"https://github.com/paparazzi/paparazzi/pull/1303","diff_url":"https://github.com/paparazzi/paparazzi/pull/1303.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/1303.patch","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1303","number":1303,"state":"open","locked":false,"title":"[telemetry] BlueGiga (bluetooth) Telemetry and SPI slave on STM3","user":{"login":"dewagter","id":490108,"avatar_url":"https://avatars.githubusercontent.com/u/490108?v=3","gravatar_id":"","url":"https://api.github.com/users/dewagter","html_url":"https://github.com/dewagter","followers_url":"https://api.github.com/users/dewagter/followers","following_url":"https://api.github.com/users/dewagter/following{/other_user}","gists_url":"https://api.github.com/users/dewagter/gists{/gist_id}","starred_url":"https://api.github.com/users/dewagter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dewagter/subscriptions","organizations_url":"https://api.github.com/users/dewagter/orgs","repos_url":"https://api.github.com/users/dewagter/repos","events_url":"https://api.github.com/users/dewagter/events{/privacy}","received_events_url":"https://api.github.com/users/dewagter/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-17T15:00:40Z","updated_at":"2015-08-20T09:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a790c18dfb72fbeab6b286d34991c374e0812b17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303/commits","review_comments_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303/comments","review_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/1303/comments","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/1f79c3d672a96e5499ae75ffb9347980585d5a48","head":{"label":"tudelft:bluegiga_pull_request_kirk","ref":"bluegiga_pull_request_kirk","sha":"1f79c3d672a96e5499ae75ffb9347980585d5a48","user":{"login":"tudelft","id":491899,"avatar_url":"https://avatars.githubusercontent.com/u/491899?v=3","gravatar_id":"","url":"https://api.github.com/users/tudelft","html_url":"https://github.com/tudelft","followers_url":"https://api.github.com/users/tudelft/followers","following_url":"https://api.github.com/users/tudelft/following{/other_user}","gists_url":"https://api.github.com/users/tudelft/gists{/gist_id}","starred_url":"https://api.github.com/users/tudelft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudelft/subscriptions","organizations_url":"https://api.github.com/users/tudelft/orgs","repos_url":"https://api.github.com/users/tudelft/repos","events_url":"https://api.github.com/users/tudelft/events{/privacy}","received_events_url":"https://api.github.com/users/tudelft/received_events","type":"Organization","site_admin":false},"repo":{"id":1146901,"name":"paparazzi","full_name":"tudelft/paparazzi","owner":{"login":"tudelft","id":491899,"avatar_url":"https://avatars.githubusercontent.com/u/491899?v=3","gravatar_id":"","url":"https://api.github.com/users/tudelft","html_url":"https://github.com/tudelft","followers_url":"https://api.github.com/users/tudelft/followers","following_url":"https://api.github.com/users/tudelft/following{/other_user}","gists_url":"https://api.github.com/users/tudelft/gists{/gist_id}","starred_url":"https://api.github.com/users/tudelft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tudelft/subscriptions","organizations_url":"https://api.github.com/users/tudelft/orgs","repos_url":"https://api.github.com/users/tudelft/repos","events_url":"https://api.github.com/users/tudelft/events{/privacy}","received_events_url":"https://api.github.com/users/tudelft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tudelft/paparazzi","description":"TUDelft Paparazzi","fork":true,"url":"https://api.github.com/repos/tudelft/paparazzi","forks_url":"https://api.github.com/repos/tudelft/paparazzi/forks","keys_url":"https://api.github.com/repos/tudelft/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tudelft/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tudelft/paparazzi/teams","hooks_url":"https://api.github.com/repos/tudelft/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/tudelft/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/tudelft/paparazzi/events","assignees_url":"https://api.github.com/repos/tudelft/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/tudelft/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/tudelft/paparazzi/tags","blobs_url":"https://api.github.com/repos/tudelft/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tudelft/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tudelft/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/tudelft/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tudelft/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/tudelft/paparazzi/languages","stargazers_url":"https://api.github.com/repos/tudelft/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/tudelft/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/tudelft/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/tudelft/paparazzi/subscription","commits_url":"https://api.github.com/repos/tudelft/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/tudelft/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/tudelft/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/tudelft/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/tudelft/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/tudelft/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tudelft/paparazzi/merges","archive_url":"https://api.github.com/repos/tudelft/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tudelft/paparazzi/downloads","issues_url":"https://api.github.com/repos/tudelft/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/tudelft/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/tudelft/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/tudelft/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tudelft/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/tudelft/paparazzi/releases{/id}","created_at":"2010-12-07T15:47:38Z","updated_at":"2014-06-20T16:22:43Z","pushed_at":"2015-08-19T20:44:24Z","git_url":"git://github.com/tudelft/paparazzi.git","ssh_url":"git@github.com:tudelft/paparazzi.git","clone_url":"https://github.com/tudelft/paparazzi.git","svn_url":"https://github.com/tudelft/paparazzi","homepage":"http://paparazzi.enac.fr","size":318931,"stargazers_count":10,"watchers_count":10,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":10,"default_branch":"tudelft5.2"}},"base":{"label":"paparazzi:master","ref":"master","sha":"86e5253e3f7595d55676b9754bd8426d0d93e25e","user":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"name":"paparazzi","full_name":"paparazzi/paparazzi","owner":{"login":"paparazzi","id":318080,"avatar_url":"https://avatars.githubusercontent.com/u/318080?v=3","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","created_at":"2010-11-10T11:14:08Z","updated_at":"2015-08-18T14:09:14Z","pushed_at":"2015-08-19T21:21:04Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":121782,"stargazers_count":445,"watchers_count":445,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":119,"forks":477,"open_issues":119,"watchers":445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/1303"},"issue":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1303"},"comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/1303/comments"},"review_comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303/comments"},"review_comment":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/1303/commits"},"statuses":{"href":"https://api.github.com/repos/paparazzi/paparazzi/statuses/1f79c3d672a96e5499ae75ffb9347980585d5a48"}}}}