{"action":"created","comment":{"url":"https://api.github.com/repos/rmzelle/zotero/pulls/comments/30412323","id":30412323,"diff_hunk":"@@ -154,34 +154,16 @@ Zotero_Preferences.Export = {\n \t\tvar menulist = document.getElementById('zotero-quickCopy-locale-menu');\n \t\tvar menulistLabel = document.getElementById('zotero-quickCopy-locale-menu-label');\n \t\t\n-\t\tvar lastSelectedLocale = menulist.value;\n-\t\tvar localeLabel = \"\";\n-\t\tif (menulist.disabled === true) {\n-\t\t\tmenulist.removeItemAt(0);\n-\t\t}\n-\t\t\n \t\tif (mode == 'bibliography') {\n-\t\t\tvar defaultStyleLocale = Zotero.Styles.get(format).locale;\n-\t\t\tif (defaultStyleLocale) {\n-\t\t\t\tif (Zotero.Styles.locales[defaultStyleLocale] !== undefined) {\n-\t\t\t\t\tlocaleLabel = Zotero.Styles.locales[defaultStyleLocale];\n-\t\t\t\t} else {\n-\t\t\t\t\tlocaleLabel = defaultStyleLocale;\n-\t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\t\t\n-\t\tif (mode == 'bibliography' && !defaultStyleLocale) {\n-\t\t\tmenulist.value = lastSelectedLocale;\n-\t\t\tmenulist.disabled = false;\n+\t\t\tlet style = Zotero.Styles.get(format);\n+\t\t\tmenulist.value = style.locale || this._lastSelectedLocale;\n+\t\t\t\n \t\t\tmenulistLabel.disabled = false;\n+\t\t\tmenulist.disabled = !!style.locale;\n \t\t} else {\n-\t\t\tmenulist.insertItemAt(0, localeLabel, lastSelectedLocale);\n-\t\t\tmenulist.selectedIndex = 0;\n+\t\t\tmenulist.value = '';","path":"chrome/content/zotero/preferences/preferences_export.js","position":41,"original_position":41,"commit_id":"7fdfa9ca144edb97d60f6bca60445f401b086a1e","original_commit_id":"7fdfa9ca144edb97d60f6bca60445f401b086a1e","user":{"login":"rmzelle","id":77951,"avatar_url":"https://avatars.githubusercontent.com/u/77951?v=3","gravatar_id":"","url":"https://api.github.com/users/rmzelle","html_url":"https://github.com/rmzelle","followers_url":"https://api.github.com/users/rmzelle/followers","following_url":"https://api.github.com/users/rmzelle/following{/other_user}","gists_url":"https://api.github.com/users/rmzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/rmzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmzelle/subscriptions","organizations_url":"https://api.github.com/users/rmzelle/orgs","repos_url":"https://api.github.com/users/rmzelle/repos","events_url":"https://api.github.com/users/rmzelle/events{/privacy}","received_events_url":"https://api.github.com/users/rmzelle/received_events","type":"User","site_admin":false},"body":"And you can set `.value` to whatever, regardless of the entries that are in the menulist?","created_at":"2015-05-15T14:25:43Z","updated_at":"2015-05-15T14:25:43Z","html_url":"https://github.com/rmzelle/zotero/pull/1#discussion_r30412323","pull_request_url":"https://api.github.com/repos/rmzelle/zotero/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/comments/30412323"},"html":{"href":"https://github.com/rmzelle/zotero/pull/1#discussion_r30412323"},"pull_request":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/rmzelle/zotero/pulls/1","id":35483910,"html_url":"https://github.com/rmzelle/zotero/pull/1","diff_url":"https://github.com/rmzelle/zotero/pull/1.diff","patch_url":"https://github.com/rmzelle/zotero/pull/1.patch","issue_url":"https://api.github.com/repos/rmzelle/zotero/issues/1","number":1,"state":"open","locked":false,"title":"A little cleanup","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"body":"I think this is a bit more straight-forward. There's no adding/removing things from the drop-down list, which is something I was not a big fan of. I didn't update all locale menus though (e.g. style editor window).\r\n\r\nLet me know if you have some concerns.","created_at":"2015-05-15T04:28:30Z","updated_at":"2015-05-15T14:25:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9b55c12b12710d2180123b0aa2d555d1eb56e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rmzelle/zotero/pulls/1/commits","review_comments_url":"https://api.github.com/repos/rmzelle/zotero/pulls/1/comments","review_comment_url":"https://api.github.com/repos/rmzelle/zotero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmzelle/zotero/issues/1/comments","statuses_url":"https://api.github.com/repos/rmzelle/zotero/statuses/7fdfa9ca144edb97d60f6bca60445f401b086a1e","head":{"label":"aurimasv:pr623-disable-locale","ref":"pr623-disable-locale","sha":"7fdfa9ca144edb97d60f6bca60445f401b086a1e","user":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"repo":{"id":3656342,"name":"zotero","full_name":"aurimasv/zotero","owner":{"login":"aurimasv","id":1381759,"avatar_url":"https://avatars.githubusercontent.com/u/1381759?v=3","gravatar_id":"","url":"https://api.github.com/users/aurimasv","html_url":"https://github.com/aurimasv","followers_url":"https://api.github.com/users/aurimasv/followers","following_url":"https://api.github.com/users/aurimasv/following{/other_user}","gists_url":"https://api.github.com/users/aurimasv/gists{/gist_id}","starred_url":"https://api.github.com/users/aurimasv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurimasv/subscriptions","organizations_url":"https://api.github.com/users/aurimasv/orgs","repos_url":"https://api.github.com/users/aurimasv/repos","events_url":"https://api.github.com/users/aurimasv/events{/privacy}","received_events_url":"https://api.github.com/users/aurimasv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aurimasv/zotero","description":"","fork":true,"url":"https://api.github.com/repos/aurimasv/zotero","forks_url":"https://api.github.com/repos/aurimasv/zotero/forks","keys_url":"https://api.github.com/repos/aurimasv/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurimasv/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurimasv/zotero/teams","hooks_url":"https://api.github.com/repos/aurimasv/zotero/hooks","issue_events_url":"https://api.github.com/repos/aurimasv/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/aurimasv/zotero/events","assignees_url":"https://api.github.com/repos/aurimasv/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/aurimasv/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/aurimasv/zotero/tags","blobs_url":"https://api.github.com/repos/aurimasv/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurimasv/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurimasv/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurimasv/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurimasv/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/aurimasv/zotero/languages","stargazers_url":"https://api.github.com/repos/aurimasv/zotero/stargazers","contributors_url":"https://api.github.com/repos/aurimasv/zotero/contributors","subscribers_url":"https://api.github.com/repos/aurimasv/zotero/subscribers","subscription_url":"https://api.github.com/repos/aurimasv/zotero/subscription","commits_url":"https://api.github.com/repos/aurimasv/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurimasv/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurimasv/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurimasv/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurimasv/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/aurimasv/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurimasv/zotero/merges","archive_url":"https://api.github.com/repos/aurimasv/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurimasv/zotero/downloads","issues_url":"https://api.github.com/repos/aurimasv/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/aurimasv/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/aurimasv/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/aurimasv/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurimasv/zotero/labels{/name}","releases_url":"https://api.github.com/repos/aurimasv/zotero/releases{/id}","created_at":"2012-03-08T03:22:17Z","updated_at":"2015-02-20T01:28:38Z","pushed_at":"2015-05-15T04:25:47Z","git_url":"git://github.com/aurimasv/zotero.git","ssh_url":"git@github.com:aurimasv/zotero.git","clone_url":"https://github.com/aurimasv/zotero.git","svn_url":"https://github.com/aurimasv/zotero","homepage":"https://zotero.org","size":56006,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":1,"default_branch":"api_syncing-feed-reader"}},"base":{"label":"rmzelle:locale-selector","ref":"locale-selector","sha":"db7f6f0d297bcb538baa287006933023b12f1117","user":{"login":"rmzelle","id":77951,"avatar_url":"https://avatars.githubusercontent.com/u/77951?v=3","gravatar_id":"","url":"https://api.github.com/users/rmzelle","html_url":"https://github.com/rmzelle","followers_url":"https://api.github.com/users/rmzelle/followers","following_url":"https://api.github.com/users/rmzelle/following{/other_user}","gists_url":"https://api.github.com/users/rmzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/rmzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmzelle/subscriptions","organizations_url":"https://api.github.com/users/rmzelle/orgs","repos_url":"https://api.github.com/users/rmzelle/repos","events_url":"https://api.github.com/users/rmzelle/events{/privacy}","received_events_url":"https://api.github.com/users/rmzelle/received_events","type":"User","site_admin":false},"repo":{"id":2706599,"name":"zotero","full_name":"rmzelle/zotero","owner":{"login":"rmzelle","id":77951,"avatar_url":"https://avatars.githubusercontent.com/u/77951?v=3","gravatar_id":"","url":"https://api.github.com/users/rmzelle","html_url":"https://github.com/rmzelle","followers_url":"https://api.github.com/users/rmzelle/followers","following_url":"https://api.github.com/users/rmzelle/following{/other_user}","gists_url":"https://api.github.com/users/rmzelle/gists{/gist_id}","starred_url":"https://api.github.com/users/rmzelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmzelle/subscriptions","organizations_url":"https://api.github.com/users/rmzelle/orgs","repos_url":"https://api.github.com/users/rmzelle/repos","events_url":"https://api.github.com/users/rmzelle/events{/privacy}","received_events_url":"https://api.github.com/users/rmzelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmzelle/zotero","description":"","fork":true,"url":"https://api.github.com/repos/rmzelle/zotero","forks_url":"https://api.github.com/repos/rmzelle/zotero/forks","keys_url":"https://api.github.com/repos/rmzelle/zotero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmzelle/zotero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmzelle/zotero/teams","hooks_url":"https://api.github.com/repos/rmzelle/zotero/hooks","issue_events_url":"https://api.github.com/repos/rmzelle/zotero/issues/events{/number}","events_url":"https://api.github.com/repos/rmzelle/zotero/events","assignees_url":"https://api.github.com/repos/rmzelle/zotero/assignees{/user}","branches_url":"https://api.github.com/repos/rmzelle/zotero/branches{/branch}","tags_url":"https://api.github.com/repos/rmzelle/zotero/tags","blobs_url":"https://api.github.com/repos/rmzelle/zotero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmzelle/zotero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmzelle/zotero/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmzelle/zotero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmzelle/zotero/statuses/{sha}","languages_url":"https://api.github.com/repos/rmzelle/zotero/languages","stargazers_url":"https://api.github.com/repos/rmzelle/zotero/stargazers","contributors_url":"https://api.github.com/repos/rmzelle/zotero/contributors","subscribers_url":"https://api.github.com/repos/rmzelle/zotero/subscribers","subscription_url":"https://api.github.com/repos/rmzelle/zotero/subscription","commits_url":"https://api.github.com/repos/rmzelle/zotero/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmzelle/zotero/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmzelle/zotero/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmzelle/zotero/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmzelle/zotero/contents/{+path}","compare_url":"https://api.github.com/repos/rmzelle/zotero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmzelle/zotero/merges","archive_url":"https://api.github.com/repos/rmzelle/zotero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmzelle/zotero/downloads","issues_url":"https://api.github.com/repos/rmzelle/zotero/issues{/number}","pulls_url":"https://api.github.com/repos/rmzelle/zotero/pulls{/number}","milestones_url":"https://api.github.com/repos/rmzelle/zotero/milestones{/number}","notifications_url":"https://api.github.com/repos/rmzelle/zotero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmzelle/zotero/labels{/name}","releases_url":"https://api.github.com/repos/rmzelle/zotero/releases{/id}","created_at":"2011-11-04T01:58:56Z","updated_at":"2015-03-22T00:29:07Z","pushed_at":"2015-05-15T04:28:30Z","git_url":"git://github.com/rmzelle/zotero.git","ssh_url":"git@github.com:rmzelle/zotero.git","clone_url":"https://github.com/rmzelle/zotero.git","svn_url":"https://github.com/rmzelle/zotero","homepage":"http://zotero.org","size":52339,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/1"},"html":{"href":"https://github.com/rmzelle/zotero/pull/1"},"issue":{"href":"https://api.github.com/repos/rmzelle/zotero/issues/1"},"comments":{"href":"https://api.github.com/repos/rmzelle/zotero/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmzelle/zotero/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/rmzelle/zotero/statuses/7fdfa9ca144edb97d60f6bca60445f401b086a1e"}}}}