{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/6756","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/6756/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/6756/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/6756/events","html_url":"https://github.com/dotnet/roslyn/pull/6756","id":116684717,"number":6756,"title":"[Do Not Merge] Initial merge of new C#/VB project system","user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/4%20-%20In%20Review","name":"4 - In Review","color":"CCCCCC"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-11-13T02:10:55Z","updated_at":"2015-11-23T00:09:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/6756","html_url":"https://github.com/dotnet/roslyn/pull/6756","diff_url":"https://github.com/dotnet/roslyn/pull/6756.diff","patch_url":"https://github.com/dotnet/roslyn/pull/6756.patch"},"body":"This PR will be merged after we've RI'd _future_ into the internal Visual Studio tree.\r\n\r\nThis is the initial merge of the new C#/VB project system based on the [Common Project System](https://github.com/microsoft/vsprojectsystem).\r\n\r\nMake note, I welcome feedback across the code base, however, I'll be filing work items to track things such as naming, coding style, structure and bugs in the code and fixing those in future PRs, and not block the merge. However, I will fix issues that destabilize the product, block the build, etc.\r\n\r\nThis introduces 6 new binaries to the product:\r\n\r\n__Host Agnostic Layer:__\r\n* __Microsoft.VisualStudio.ProjectSystem.CSharp:__ _Components for editing C# projects agnostic of host._\r\n* __Microsoft.VisualStudio.ProjectSystem.VisualBasic:__ _Components for editing Visual Basic projects agnostic of host._\r\n* __Microsoft.VisualStudio.ProjectSystem.Managed:__ _Components that are shared between C# and VB projects agnostic of host_\r\n\r\n__Visual Studio Layer:__\r\n* __Microsoft.VisualStudio.ProjectSystem.CSharp.VS:__ _Components for editing C# projects within Visual Studio_\r\n* __Microsoft.VisualStudio.ProjectSystem.VisualBasic.VS:__ _Components for editing Visual Basic projects within Visual Studio_\r\n* __Microsoft.VisualStudio.ProjectSystem.Managed.VS:__ _Components that are shared between C# and VB projects within Visual Studio. We eventually expect this to be shared with other managed languages that move to CPS._\r\n\r\nThis project system _will not_ currently work with RTM bits of Visual Studio, as these components conflict with the current CPS bits, however, in the future you will be able to F5 from ProjectSystemSetup, which will deploy the project system locally and you can open a msbuildproj (temporary) to test out the project system. Tests also, unlike the rest of Roslyn (due to the scale), can be run directly from Team Explorer.\r\n\r\n__Work identified below to be done in future PRs:__\r\n\r\n- [ ] [Prevent projects from copying the same references, project references and nuget impls to the output](https://github.com/dotnet/roslyn/issues/6771)\r\n- [ ] [Figure out whether project system should be using ConfigureAwait(true/false) on its await calls](https://github.com/dotnet/roslyn/issues/6770)\r\n- [ ] [Code review feedback for merge of CPS](https://github.com/dotnet/roslyn/issues/6772)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/158821247","html_url":"https://github.com/dotnet/roslyn/pull/6756#issuecomment-158821247","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/6756","id":158821247,"user":{"login":"davkean","id":1103906,"avatar_url":"https://avatars.githubusercontent.com/u/1103906?v=3","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T00:09:49Z","updated_at":"2015-11-23T00:09:49Z","body":"Thanks @Pilchie, added those to the feedback work item here: https://github.com/dotnet/roslyn/issues/6772. I'll look at that on Monday."}}