{"action":"created","issue":{"url":"https://api.github.com/repos/libopenstorage/openstorage/issues/10","labels_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/10/comments","events_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/10/events","html_url":"https://github.com/libopenstorage/openstorage/pull/10","id":107946332,"number":10,"title":"<CODE for Review>","user":{"login":"kunalkushwaha","id":2758433,"avatar_url":"https://avatars.githubusercontent.com/u/2758433?v=3","gravatar_id":"","url":"https://api.github.com/users/kunalkushwaha","html_url":"https://github.com/kunalkushwaha","followers_url":"https://api.github.com/users/kunalkushwaha/followers","following_url":"https://api.github.com/users/kunalkushwaha/following{/other_user}","gists_url":"https://api.github.com/users/kunalkushwaha/gists{/gist_id}","starred_url":"https://api.github.com/users/kunalkushwaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunalkushwaha/subscriptions","organizations_url":"https://api.github.com/users/kunalkushwaha/orgs","repos_url":"https://api.github.com/users/kunalkushwaha/repos","events_url":"https://api.github.com/users/kunalkushwaha/events{/privacy}","received_events_url":"https://api.github.com/users/kunalkushwaha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-23T15:30:06Z","updated_at":"2015-09-24T18:39:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libopenstorage/openstorage/pulls/10","html_url":"https://github.com/libopenstorage/openstorage/pull/10","diff_url":"https://github.com/libopenstorage/openstorage/pull/10.diff","patch_url":"https://github.com/libopenstorage/openstorage/pull/10.patch"},"body":"Sample code for review and understanding driver code.\r\n\r\nFew things is not clear to me.\r\n1. Create()- In create function, the folder structure that is created, doesnt make any sense while mounting.\r\n2. I have not implement, Mount function, since it is not required.\r\n3. After mounting the volume in docker container, the data changes in that mounted folder is reflected in ``/var/lib/docker/volume/<volume-name>``\r\n4. I want to understand, how the create/mount  folder/file is reflected to actual IO Path. It is not clear to me.\r\n\r\nNOTE: This converted to local from nfs-driver.\r\n\r\nSigned-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>"},"comment":{"url":"https://api.github.com/repos/libopenstorage/openstorage/issues/comments/143014995","html_url":"https://github.com/libopenstorage/openstorage/pull/10#issuecomment-143014995","issue_url":"https://api.github.com/repos/libopenstorage/openstorage/issues/10","id":143014995,"user":{"login":"jvinod","id":10396455,"avatar_url":"https://avatars.githubusercontent.com/u/10396455?v=3","gravatar_id":"","url":"https://api.github.com/users/jvinod","html_url":"https://github.com/jvinod","followers_url":"https://api.github.com/users/jvinod/followers","following_url":"https://api.github.com/users/jvinod/following{/other_user}","gists_url":"https://api.github.com/users/jvinod/gists{/gist_id}","starred_url":"https://api.github.com/users/jvinod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvinod/subscriptions","organizations_url":"https://api.github.com/users/jvinod/orgs","repos_url":"https://api.github.com/users/jvinod/repos","events_url":"https://api.github.com/users/jvinod/events{/privacy}","received_events_url":"https://api.github.com/users/jvinod/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T18:39:05Z","updated_at":"2015-09-24T18:39:05Z","body":"@kunalkushwaha \r\n- Note that the nfs driver in the absence of a server defaults to a vfs driver\r\n- regarding the 404 : api/server/docker.go (the volume plugin implementation) expects the vol to exist on a create. The volume should be created separately using 'osd cli' before using it with docker. This will not be necessary after we address https://github.com/libopenstorage/openstorage/issues/7\r\n- you'd still need to implement Mount (bind mount to specified path) and Unmount\r\n- you don't need to implement the pseudo block device inside the vfs path."}}