{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/6784","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/6784/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/6784/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/6784/events","html_url":"https://github.com/mrdoob/three.js/issues/6784","id":92852849,"number":6784,"title":"\"Fit all\" (show all) feature","user":{"login":"pavelvasev","id":159179,"avatar_url":"https://avatars.githubusercontent.com/u/159179?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelvasev","html_url":"https://github.com/pavelvasev","followers_url":"https://api.github.com/users/pavelvasev/followers","following_url":"https://api.github.com/users/pavelvasev/following{/other_user}","gists_url":"https://api.github.com/users/pavelvasev/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelvasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelvasev/subscriptions","organizations_url":"https://api.github.com/users/pavelvasev/orgs","repos_url":"https://api.github.com/users/pavelvasev/repos","events_url":"https://api.github.com/users/pavelvasev/events{/privacy}","received_events_url":"https://api.github.com/users/pavelvasev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mrdoob/three.js/labels/Enhancement","name":"Enhancement","color":"deffdb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":23,"created_at":"2015-07-03T11:10:41Z","updated_at":"2015-07-08T18:20:13Z","closed_at":null,"body":"Dear ThreeJS developers!\r\n\r\nPlease implement \"fit all\" (\"show all\") feature to the camera and/or OrbitControl and other controls.\r\nThis feature is very missing thing. \r\n\r\nTo provide some help, here is implementation of same feature in X3dom:\r\nhttps://github.com/x3dom/x3dom/blob/master/src/Viewarea.js#L1077\r\n\r\nAlso, there is \"fit object\" (e.g. show object) feature:\r\nhttps://github.com/x3dom/x3dom/blob/master/src/Runtime.js#L631\r\n\r\nMany thanks in advance.\r\n\r\nPlease do not refer me to other feature requests like https://github.com/mrdoob/three.js/issues/1095\r\n\r\nIf you deny to do this, please at least point me, where is it better to code it, e.g. in camera, or in OrbitControl/etc, to get them (camera and control) synchronized?\r\n"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/119686786","html_url":"https://github.com/mrdoob/three.js/issues/6784#issuecomment-119686786","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/6784","id":119686786,"user":{"login":"pavelvasev","id":159179,"avatar_url":"https://avatars.githubusercontent.com/u/159179?v=3","gravatar_id":"","url":"https://api.github.com/users/pavelvasev","html_url":"https://github.com/pavelvasev","followers_url":"https://api.github.com/users/pavelvasev/followers","following_url":"https://api.github.com/users/pavelvasev/following{/other_user}","gists_url":"https://api.github.com/users/pavelvasev/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelvasev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelvasev/subscriptions","organizations_url":"https://api.github.com/users/pavelvasev/orgs","repos_url":"https://api.github.com/users/pavelvasev/repos","events_url":"https://api.github.com/users/pavelvasev/events{/privacy}","received_events_url":"https://api.github.com/users/pavelvasev/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T18:20:13Z","updated_at":"2015-07-08T18:20:13Z","body":"I must clarify. I mean that camera.focus method stays solid, but internally\nit calls 2 other methods, eg compute and assign. And both these methods are\ncallable by user too.\n08.07.2015 23:15 пользователь \"Pavel Vasev\" <pavel.vasev@gmail.com> написал:\n\n> Probably it will be good (if possible) to split camera focus\n> implementation on two parts (submethods)\n>\n> 1) compute new camera parameters (eg lookat, position)\n> 2) assign them to camera.\n>\n> So somebody could use both parts and somebody only part 1… for example for\n> camera animation. Also maybe it will allow to interconnect with camera\n> controllers easier.\n> 08.07.2015 22:38 пользователь \"Ricardo Cabello\" <notifications@github.com>\n> написал:\n>\n>> Some users might not like that solution, however, as it involves moving\n>> the camera to a new place.\n>>\n>> Yep, I think that's ok.\n>>\n>> Keep in mind that focusing controls on an object requires both camera and\n>> target to be positioned (the rotation center of controls). Therefore,\n>> implementing this on camera level would require camera to include target\n>> property.\n>>\n>> Even if the OP was asking this to be added to the controls, I would first\n>> focus (no pun intended 😅) in the cameras and later sort out the\n>> controls.\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/mrdoob/three.js/issues/6784#issuecomment-119672865>.\n>>\n>\n"}}