{"action":"created","issue":{"url":"https://api.github.com/repos/geotools/geotools/issues/809","labels_url":"https://api.github.com/repos/geotools/geotools/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/geotools/geotools/issues/809/comments","events_url":"https://api.github.com/repos/geotools/geotools/issues/809/events","html_url":"https://github.com/geotools/geotools/pull/809","id":66802344,"number":809,"title":"Add a method to custom the desired tables","user":{"login":"ebocher","id":1820572,"avatar_url":"https://avatars.githubusercontent.com/u/1820572?v=3","gravatar_id":"","url":"https://api.github.com/users/ebocher","html_url":"https://github.com/ebocher","followers_url":"https://api.github.com/users/ebocher/followers","following_url":"https://api.github.com/users/ebocher/following{/other_user}","gists_url":"https://api.github.com/users/ebocher/gists{/gist_id}","starred_url":"https://api.github.com/users/ebocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebocher/subscriptions","organizations_url":"https://api.github.com/users/ebocher/orgs","repos_url":"https://api.github.com/users/ebocher/repos","events_url":"https://api.github.com/users/ebocher/events{/privacy}","received_events_url":"https://api.github.com/users/ebocher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-07T07:15:59Z","updated_at":"2015-04-10T07:34:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geotools/geotools/pulls/809","html_url":"https://github.com/geotools/geotools/pull/809","diff_url":"https://github.com/geotools/geotools/pull/809.diff","patch_url":"https://github.com/geotools/geotools/pull/809.patch"},"body":"This PR shall cancel and replace the #805.\r\n\r\nThe code contribution licence file has been send by e-mail.\r\n"},"comment":{"url":"https://api.github.com/repos/geotools/geotools/issues/comments/91467593","html_url":"https://github.com/geotools/geotools/pull/809#issuecomment-91467593","issue_url":"https://api.github.com/repos/geotools/geotools/issues/809","id":91467593,"user":{"login":"aaime","id":325433,"avatar_url":"https://avatars.githubusercontent.com/u/325433?v=3","gravatar_id":"","url":"https://api.github.com/users/aaime","html_url":"https://github.com/aaime","followers_url":"https://api.github.com/users/aaime/followers","following_url":"https://api.github.com/users/aaime/following{/other_user}","gists_url":"https://api.github.com/users/aaime/gists{/gist_id}","starred_url":"https://api.github.com/users/aaime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaime/subscriptions","organizations_url":"https://api.github.com/users/aaime/orgs","repos_url":"https://api.github.com/users/aaime/repos","events_url":"https://api.github.com/users/aaime/events{/privacy}","received_events_url":"https://api.github.com/users/aaime/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T07:34:44Z","updated_at":"2015-04-10T07:34:44Z","body":"I did bother running the tests, the regression is evident. The old code starts with a list of candidate values, then checks against the values supported by the database, and performs an intersection between the two, and then runs the query with the subset that is both desired and supported, now the code just runs over the list of desired tables, without checking if they are supported.\r\nJDBCDataStore is a framework, not a single database implementation, the framework must work for all databases and continue to work as people upgrade the dbms and the drivers, so the checks against what table types are really supported must stay there."}}