{"action":"closed","number":8153,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8153","id":35957854,"html_url":"https://github.com/edx/edx-platform/pull/8153","diff_url":"https://github.com/edx/edx-platform/pull/8153.diff","patch_url":"https://github.com/edx/edx-platform/pull/8153.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8153","number":8153,"state":"closed","locked":false,"title":"Creating a settings object that is aware of the microsite settings.","user":{"login":"felipemontoya","id":2816902,"avatar_url":"https://avatars.githubusercontent.com/u/2816902?v=3","gravatar_id":"","url":"https://api.github.com/users/felipemontoya","html_url":"https://github.com/felipemontoya","followers_url":"https://api.github.com/users/felipemontoya/followers","following_url":"https://api.github.com/users/felipemontoya/following{/other_user}","gists_url":"https://api.github.com/users/felipemontoya/gists{/gist_id}","starred_url":"https://api.github.com/users/felipemontoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipemontoya/subscriptions","organizations_url":"https://api.github.com/users/felipemontoya/orgs","repos_url":"https://api.github.com/users/felipemontoya/repos","events_url":"https://api.github.com/users/felipemontoya/events{/privacy}","received_events_url":"https://api.github.com/users/felipemontoya/received_events","type":"User","site_admin":false},"body":"This PR creates a settings object which can look for a setting in the microsite configuration and default to the regular django.conf settings value when the microsite does not have a particular override.\r\n\r\nThis should not have any impact on running code, but will allow a developer to call\r\n\r\n    from microsite_configuration import settings\r\ninstead of \r\n\r\n    from django.conf import settings\r\n\r\nand then use the settings object as it would normally with django. e.g.\r\n\r\n    settings.SITE_NAME\r\n\r\nThe current instances of microsite.get_value are not being changed in this PR.\r\n\r\nThis is a part of the changes contained in #7867 . I'm spliting that PR to have more isolated changes and make it easier to merge.","created_at":"2015-05-21T17:30:32Z","updated_at":"2015-09-25T21:13:34Z","closed_at":"2015-09-25T21:13:34Z","merged_at":null,"merge_commit_sha":"ff2202a0ff8b4e9ab1512535cdf55c47263bdec6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/8153/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/8153/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8153/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/76ae538dca2da6a7327b3992438aeeee8f51c2c6","head":{"label":"eduNEXT:fmo/microsites-aware-settings","ref":"fmo/microsites-aware-settings","sha":"76ae538dca2da6a7327b3992438aeeee8f51c2c6","user":{"login":"eduNEXT","id":5911140,"avatar_url":"https://avatars.githubusercontent.com/u/5911140?v=3","gravatar_id":"","url":"https://api.github.com/users/eduNEXT","html_url":"https://github.com/eduNEXT","followers_url":"https://api.github.com/users/eduNEXT/followers","following_url":"https://api.github.com/users/eduNEXT/following{/other_user}","gists_url":"https://api.github.com/users/eduNEXT/gists{/gist_id}","starred_url":"https://api.github.com/users/eduNEXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduNEXT/subscriptions","organizations_url":"https://api.github.com/users/eduNEXT/orgs","repos_url":"https://api.github.com/users/eduNEXT/repos","events_url":"https://api.github.com/users/eduNEXT/events{/privacy}","received_events_url":"https://api.github.com/users/eduNEXT/received_events","type":"Organization","site_admin":false},"repo":{"id":16317689,"name":"edx-platform","full_name":"eduNEXT/edx-platform","owner":{"login":"eduNEXT","id":5911140,"avatar_url":"https://avatars.githubusercontent.com/u/5911140?v=3","gravatar_id":"","url":"https://api.github.com/users/eduNEXT","html_url":"https://github.com/eduNEXT","followers_url":"https://api.github.com/users/eduNEXT/followers","following_url":"https://api.github.com/users/eduNEXT/following{/other_user}","gists_url":"https://api.github.com/users/eduNEXT/gists{/gist_id}","starred_url":"https://api.github.com/users/eduNEXT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduNEXT/subscriptions","organizations_url":"https://api.github.com/users/eduNEXT/orgs","repos_url":"https://api.github.com/users/eduNEXT/repos","events_url":"https://api.github.com/users/eduNEXT/events{/privacy}","received_events_url":"https://api.github.com/users/eduNEXT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eduNEXT/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/eduNEXT/edx-platform","forks_url":"https://api.github.com/repos/eduNEXT/edx-platform/forks","keys_url":"https://api.github.com/repos/eduNEXT/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eduNEXT/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eduNEXT/edx-platform/teams","hooks_url":"https://api.github.com/repos/eduNEXT/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/eduNEXT/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/eduNEXT/edx-platform/events","assignees_url":"https://api.github.com/repos/eduNEXT/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/eduNEXT/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/eduNEXT/edx-platform/tags","blobs_url":"https://api.github.com/repos/eduNEXT/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eduNEXT/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eduNEXT/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/eduNEXT/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eduNEXT/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/eduNEXT/edx-platform/languages","stargazers_url":"https://api.github.com/repos/eduNEXT/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/eduNEXT/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/eduNEXT/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/eduNEXT/edx-platform/subscription","commits_url":"https://api.github.com/repos/eduNEXT/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/eduNEXT/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/eduNEXT/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/eduNEXT/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/eduNEXT/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/eduNEXT/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eduNEXT/edx-platform/merges","archive_url":"https://api.github.com/repos/eduNEXT/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eduNEXT/edx-platform/downloads","issues_url":"https://api.github.com/repos/eduNEXT/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/eduNEXT/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/eduNEXT/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/eduNEXT/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eduNEXT/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/eduNEXT/edx-platform/releases{/id}","created_at":"2014-01-28T16:31:38Z","updated_at":"2015-01-23T03:27:24Z","pushed_at":"2015-09-05T18:15:07Z","git_url":"git://github.com/eduNEXT/edx-platform.git","ssh_url":"git@github.com:eduNEXT/edx-platform.git","clone_url":"https://github.com/eduNEXT/edx-platform.git","svn_url":"https://github.com/eduNEXT/edx-platform","homepage":"http://code.edx.org/","size":492019,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"1ba4200a845fcb5a61a750c7ca197401b1663eb2","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-25T12:13:29Z","pushed_at":"2015-09-25T21:09:24Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2120093,"stargazers_count":2146,"watchers_count":2146,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1278,"mirror_url":null,"open_issues_count":139,"forks":1278,"open_issues":139,"watchers":2146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8153"},"html":{"href":"https://github.com/edx/edx-platform/pull/8153"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8153"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8153/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8153/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8153/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/76ae538dca2da6a7327b3992438aeeee8f51c2c6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":44,"review_comments":5,"commits":6,"additions":85,"deletions":0,"changed_files":3}}