{"action":"created","comment":{"url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/comments/33954814","id":33954814,"diff_hunk":"@@ -34,8 +34,11 @@ class KeyMapper\n           keyDownEvent.shiftKey = false\n         else if translation.alted? && @modifierStateHandler.isAltGr()\n           charCode = translation.alted\n-          keyDownEvent.altKey = false\n-          keyDownEvent.ctrlKey = false\n+          # do not remove alt+ctrl states for linux\n+          # TODO: what about darwin?\n+          if process.platform != 'linux'","path":"lib/key-mapper.coffee","position":8,"original_position":8,"commit_id":"00c7af0cb1affd6a584a3398b9c547a143aeb569","original_commit_id":"00c7af0cb1affd6a584a3398b9c547a143aeb569","user":{"login":"andischerer","id":930604,"avatar_url":"https://avatars.githubusercontent.com/u/930604?v=3","gravatar_id":"","url":"https://api.github.com/users/andischerer","html_url":"https://github.com/andischerer","followers_url":"https://api.github.com/users/andischerer/followers","following_url":"https://api.github.com/users/andischerer/following{/other_user}","gists_url":"https://api.github.com/users/andischerer/gists{/gist_id}","starred_url":"https://api.github.com/users/andischerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andischerer/subscriptions","organizations_url":"https://api.github.com/users/andischerer/orgs","repos_url":"https://api.github.com/users/andischerer/repos","events_url":"https://api.github.com/users/andischerer/events{/privacy}","received_events_url":"https://api.github.com/users/andischerer/received_events","type":"User","site_admin":false},"body":"Could you give me a short example why not resetting modifier state on linux ?","created_at":"2015-07-06T16:44:27Z","updated_at":"2015-07-06T16:44:27Z","html_url":"https://github.com/andischerer/atom-keyboard-localization/pull/39#discussion_r33954814","pull_request_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/comments/33954814"},"html":{"href":"https://github.com/andischerer/atom-keyboard-localization/pull/39#discussion_r33954814"},"pull_request":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39","id":39140109,"html_url":"https://github.com/andischerer/atom-keyboard-localization/pull/39","diff_url":"https://github.com/andischerer/atom-keyboard-localization/pull/39.diff","patch_url":"https://github.com/andischerer/atom-keyboard-localization/pull/39.patch","issue_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/39","number":39,"state":"open","locked":false,"title":"fix platform detection","user":{"login":"bgse","id":8385202,"avatar_url":"https://avatars.githubusercontent.com/u/8385202?v=3","gravatar_id":"","url":"https://api.github.com/users/bgse","html_url":"https://github.com/bgse","followers_url":"https://api.github.com/users/bgse/followers","following_url":"https://api.github.com/users/bgse/following{/other_user}","gists_url":"https://api.github.com/users/bgse/gists{/gist_id}","starred_url":"https://api.github.com/users/bgse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgse/subscriptions","organizations_url":"https://api.github.com/users/bgse/orgs","repos_url":"https://api.github.com/users/bgse/repos","events_url":"https://api.github.com/users/bgse/events{/privacy}","received_events_url":"https://api.github.com/users/bgse/received_events","type":"User","site_admin":false},"body":"Platform detection was not working properly, linux and win32 blocks both executed.","created_at":"2015-07-03T01:39:04Z","updated_at":"2015-07-06T16:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb28cc5d74eb6cd2cb0a7b063896266b76155b5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39/commits","review_comments_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39/comments","review_comment_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/39/comments","statuses_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/statuses/00c7af0cb1affd6a584a3398b9c547a143aeb569","head":{"label":"bgse:fix-platform-detection","ref":"fix-platform-detection","sha":"00c7af0cb1affd6a584a3398b9c547a143aeb569","user":{"login":"bgse","id":8385202,"avatar_url":"https://avatars.githubusercontent.com/u/8385202?v=3","gravatar_id":"","url":"https://api.github.com/users/bgse","html_url":"https://github.com/bgse","followers_url":"https://api.github.com/users/bgse/followers","following_url":"https://api.github.com/users/bgse/following{/other_user}","gists_url":"https://api.github.com/users/bgse/gists{/gist_id}","starred_url":"https://api.github.com/users/bgse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgse/subscriptions","organizations_url":"https://api.github.com/users/bgse/orgs","repos_url":"https://api.github.com/users/bgse/repos","events_url":"https://api.github.com/users/bgse/events{/privacy}","received_events_url":"https://api.github.com/users/bgse/received_events","type":"User","site_admin":false},"repo":{"id":38465380,"name":"atom-keyboard-localization","full_name":"bgse/atom-keyboard-localization","owner":{"login":"bgse","id":8385202,"avatar_url":"https://avatars.githubusercontent.com/u/8385202?v=3","gravatar_id":"","url":"https://api.github.com/users/bgse","html_url":"https://github.com/bgse","followers_url":"https://api.github.com/users/bgse/followers","following_url":"https://api.github.com/users/bgse/following{/other_user}","gists_url":"https://api.github.com/users/bgse/gists{/gist_id}","starred_url":"https://api.github.com/users/bgse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgse/subscriptions","organizations_url":"https://api.github.com/users/bgse/orgs","repos_url":"https://api.github.com/users/bgse/repos","events_url":"https://api.github.com/users/bgse/events{/privacy}","received_events_url":"https://api.github.com/users/bgse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgse/atom-keyboard-localization","description":"Foreign language keyboard support for atom.","fork":true,"url":"https://api.github.com/repos/bgse/atom-keyboard-localization","forks_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/forks","keys_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/teams","hooks_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/hooks","issue_events_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/issues/events{/number}","events_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/events","assignees_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/assignees{/user}","branches_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/branches{/branch}","tags_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/tags","blobs_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/statuses/{sha}","languages_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/languages","stargazers_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/stargazers","contributors_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/contributors","subscribers_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/subscribers","subscription_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/subscription","commits_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/contents/{+path}","compare_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/merges","archive_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/downloads","issues_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/issues{/number}","pulls_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/pulls{/number}","milestones_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/milestones{/number}","notifications_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/labels{/name}","releases_url":"https://api.github.com/repos/bgse/atom-keyboard-localization/releases{/id}","created_at":"2015-07-03T01:32:46Z","updated_at":"2015-07-03T01:40:21Z","pushed_at":"2015-07-06T13:34:28Z","git_url":"git://github.com/bgse/atom-keyboard-localization.git","ssh_url":"git@github.com:bgse/atom-keyboard-localization.git","clone_url":"https://github.com/bgse/atom-keyboard-localization.git","svn_url":"https://github.com/bgse/atom-keyboard-localization","homepage":"","size":696,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andischerer:master","ref":"master","sha":"b3cc73d6814043d869452ad95b19b563d4a962fd","user":{"login":"andischerer","id":930604,"avatar_url":"https://avatars.githubusercontent.com/u/930604?v=3","gravatar_id":"","url":"https://api.github.com/users/andischerer","html_url":"https://github.com/andischerer","followers_url":"https://api.github.com/users/andischerer/followers","following_url":"https://api.github.com/users/andischerer/following{/other_user}","gists_url":"https://api.github.com/users/andischerer/gists{/gist_id}","starred_url":"https://api.github.com/users/andischerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andischerer/subscriptions","organizations_url":"https://api.github.com/users/andischerer/orgs","repos_url":"https://api.github.com/users/andischerer/repos","events_url":"https://api.github.com/users/andischerer/events{/privacy}","received_events_url":"https://api.github.com/users/andischerer/received_events","type":"User","site_admin":false},"repo":{"id":30413751,"name":"atom-keyboard-localization","full_name":"andischerer/atom-keyboard-localization","owner":{"login":"andischerer","id":930604,"avatar_url":"https://avatars.githubusercontent.com/u/930604?v=3","gravatar_id":"","url":"https://api.github.com/users/andischerer","html_url":"https://github.com/andischerer","followers_url":"https://api.github.com/users/andischerer/followers","following_url":"https://api.github.com/users/andischerer/following{/other_user}","gists_url":"https://api.github.com/users/andischerer/gists{/gist_id}","starred_url":"https://api.github.com/users/andischerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andischerer/subscriptions","organizations_url":"https://api.github.com/users/andischerer/orgs","repos_url":"https://api.github.com/users/andischerer/repos","events_url":"https://api.github.com/users/andischerer/events{/privacy}","received_events_url":"https://api.github.com/users/andischerer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andischerer/atom-keyboard-localization","description":"Foreign language keyboard support for atom.","fork":false,"url":"https://api.github.com/repos/andischerer/atom-keyboard-localization","forks_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/forks","keys_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/teams","hooks_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/hooks","issue_events_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/events{/number}","events_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/events","assignees_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/assignees{/user}","branches_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/branches{/branch}","tags_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/tags","blobs_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/statuses/{sha}","languages_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/languages","stargazers_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/stargazers","contributors_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/contributors","subscribers_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/subscribers","subscription_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/subscription","commits_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/contents/{+path}","compare_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/merges","archive_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/downloads","issues_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues{/number}","pulls_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls{/number}","milestones_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/milestones{/number}","notifications_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/labels{/name}","releases_url":"https://api.github.com/repos/andischerer/atom-keyboard-localization/releases{/id}","created_at":"2015-02-06T13:37:50Z","updated_at":"2015-07-03T01:40:24Z","pushed_at":"2015-07-03T17:20:00Z","git_url":"git://github.com/andischerer/atom-keyboard-localization.git","ssh_url":"git@github.com:andischerer/atom-keyboard-localization.git","clone_url":"https://github.com/andischerer/atom-keyboard-localization.git","svn_url":"https://github.com/andischerer/atom-keyboard-localization","homepage":"","size":696,"stargazers_count":35,"watchers_count":35,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39"},"html":{"href":"https://github.com/andischerer/atom-keyboard-localization/pull/39"},"issue":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/39"},"comments":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/andischerer/atom-keyboard-localization/statuses/00c7af0cb1affd6a584a3398b9c547a143aeb569"}}}}