{"action":"created","comment":{"url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/comments/25547786","id":25547786,"diff_hunk":"@@ -2,18 +2,18 @@ import Ember from 'ember';\n \n export default Ember.Component.extend({\n   tagName: 'form',\n-  session: Ember.computed('email', function() {\n-    return this.editEmailService.sessionFor(this.get('email'));\n+  state: Ember.computed('email', function() {","path":"tests/dummy/app/components/edit-email.js","position":6,"original_position":6,"commit_id":"fb1ac8fa204479deef5b0c7a31b9e7205c46f2cf","original_commit_id":"fb1ac8fa204479deef5b0c7a31b9e7205c46f2cf","user":{"login":"thoov","id":166909,"avatar_url":"https://avatars.githubusercontent.com/u/166909?v=3","gravatar_id":"","url":"https://api.github.com/users/thoov","html_url":"https://github.com/thoov","followers_url":"https://api.github.com/users/thoov/followers","following_url":"https://api.github.com/users/thoov/following{/other_user}","gists_url":"https://api.github.com/users/thoov/gists{/gist_id}","starred_url":"https://api.github.com/users/thoov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoov/subscriptions","organizations_url":"https://api.github.com/users/thoov/orgs","repos_url":"https://api.github.com/users/thoov/repos","events_url":"https://api.github.com/users/thoov/events{/privacy}","received_events_url":"https://api.github.com/users/thoov/received_events","type":"User","site_admin":false},"body":"Here we should explicitly call:\r\n\r\n```js\r\neditEmailService: Ember.inject.service('edit-email')\r\n```\r\n\r\nAs I believe this gives better context to how editEmailService is being set ","created_at":"2015-02-27T23:31:19Z","updated_at":"2015-02-27T23:31:19Z","html_url":"https://github.com/stefanpenner/service-sessions/pull/4#discussion_r25547786","pull_request_url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/comments/25547786"},"html":{"href":"https://github.com/stefanpenner/service-sessions/pull/4#discussion_r25547786"},"pull_request":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4","id":30147462,"html_url":"https://github.com/stefanpenner/service-sessions/pull/4","diff_url":"https://github.com/stefanpenner/service-sessions/pull/4.diff","patch_url":"https://github.com/stefanpenner/service-sessions/pull/4.patch","issue_url":"https://api.github.com/repos/stefanpenner/service-sessions/issues/4","number":4,"state":"open","locked":false,"title":"Project rename including methods, variables, etc","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"body":"@stefanpenner I could merge myself, but I think this needs another set of eyes as well as confirm the name change still feels right.\r\n\r\nBesides the word *session* being replaced with *state*, I also renamed `endSessionFor()` -> `teardownStateFor()` because \"endState\" didn't seem to make sense and teardown is the opposite of setup.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/762949/6409001/34de0162-be12-11e4-8721-e21253fd16a0.png)\r\n","created_at":"2015-02-27T07:51:20Z","updated_at":"2015-02-27T23:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4f0f3b2218c5c76d996fbe3812327e53816ec2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4/commits","review_comments_url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4/comments","review_comment_url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stefanpenner/service-sessions/issues/4/comments","statuses_url":"https://api.github.com/repos/stefanpenner/service-sessions/statuses/fb1ac8fa204479deef5b0c7a31b9e7205c46f2cf","head":{"label":"jayphelps:rename","ref":"rename","sha":"fb1ac8fa204479deef5b0c7a31b9e7205c46f2cf","user":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"repo":{"id":31406730,"name":"ember-state-services","full_name":"jayphelps/ember-state-services","owner":{"login":"jayphelps","id":762949,"avatar_url":"https://avatars.githubusercontent.com/u/762949?v=3","gravatar_id":"","url":"https://api.github.com/users/jayphelps","html_url":"https://github.com/jayphelps","followers_url":"https://api.github.com/users/jayphelps/followers","following_url":"https://api.github.com/users/jayphelps/following{/other_user}","gists_url":"https://api.github.com/users/jayphelps/gists{/gist_id}","starred_url":"https://api.github.com/users/jayphelps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayphelps/subscriptions","organizations_url":"https://api.github.com/users/jayphelps/orgs","repos_url":"https://api.github.com/users/jayphelps/repos","events_url":"https://api.github.com/users/jayphelps/events{/privacy}","received_events_url":"https://api.github.com/users/jayphelps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayphelps/ember-state-services","description":"","fork":true,"url":"https://api.github.com/repos/jayphelps/ember-state-services","forks_url":"https://api.github.com/repos/jayphelps/ember-state-services/forks","keys_url":"https://api.github.com/repos/jayphelps/ember-state-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayphelps/ember-state-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayphelps/ember-state-services/teams","hooks_url":"https://api.github.com/repos/jayphelps/ember-state-services/hooks","issue_events_url":"https://api.github.com/repos/jayphelps/ember-state-services/issues/events{/number}","events_url":"https://api.github.com/repos/jayphelps/ember-state-services/events","assignees_url":"https://api.github.com/repos/jayphelps/ember-state-services/assignees{/user}","branches_url":"https://api.github.com/repos/jayphelps/ember-state-services/branches{/branch}","tags_url":"https://api.github.com/repos/jayphelps/ember-state-services/tags","blobs_url":"https://api.github.com/repos/jayphelps/ember-state-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayphelps/ember-state-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayphelps/ember-state-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayphelps/ember-state-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayphelps/ember-state-services/statuses/{sha}","languages_url":"https://api.github.com/repos/jayphelps/ember-state-services/languages","stargazers_url":"https://api.github.com/repos/jayphelps/ember-state-services/stargazers","contributors_url":"https://api.github.com/repos/jayphelps/ember-state-services/contributors","subscribers_url":"https://api.github.com/repos/jayphelps/ember-state-services/subscribers","subscription_url":"https://api.github.com/repos/jayphelps/ember-state-services/subscription","commits_url":"https://api.github.com/repos/jayphelps/ember-state-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayphelps/ember-state-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayphelps/ember-state-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayphelps/ember-state-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayphelps/ember-state-services/contents/{+path}","compare_url":"https://api.github.com/repos/jayphelps/ember-state-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayphelps/ember-state-services/merges","archive_url":"https://api.github.com/repos/jayphelps/ember-state-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayphelps/ember-state-services/downloads","issues_url":"https://api.github.com/repos/jayphelps/ember-state-services/issues{/number}","pulls_url":"https://api.github.com/repos/jayphelps/ember-state-services/pulls{/number}","milestones_url":"https://api.github.com/repos/jayphelps/ember-state-services/milestones{/number}","notifications_url":"https://api.github.com/repos/jayphelps/ember-state-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayphelps/ember-state-services/labels{/name}","releases_url":"https://api.github.com/repos/jayphelps/ember-state-services/releases{/id}","created_at":"2015-02-27T06:31:57Z","updated_at":"2015-02-27T06:34:09Z","pushed_at":"2015-02-27T07:46:17Z","git_url":"git://github.com/jayphelps/ember-state-services.git","ssh_url":"git@github.com:jayphelps/ember-state-services.git","clone_url":"https://github.com/jayphelps/ember-state-services.git","svn_url":"https://github.com/jayphelps/ember-state-services","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stefanpenner:master","ref":"master","sha":"b665cbd6fe2dc98a83762d8d88485ff80d81aeaa","user":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"repo":{"id":30444625,"name":"service-sessions","full_name":"stefanpenner/service-sessions","owner":{"login":"stefanpenner","id":1377,"avatar_url":"https://avatars.githubusercontent.com/u/1377?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanpenner","html_url":"https://github.com/stefanpenner","followers_url":"https://api.github.com/users/stefanpenner/followers","following_url":"https://api.github.com/users/stefanpenner/following{/other_user}","gists_url":"https://api.github.com/users/stefanpenner/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanpenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanpenner/subscriptions","organizations_url":"https://api.github.com/users/stefanpenner/orgs","repos_url":"https://api.github.com/users/stefanpenner/repos","events_url":"https://api.github.com/users/stefanpenner/events{/privacy}","received_events_url":"https://api.github.com/users/stefanpenner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanpenner/service-sessions","description":"","fork":false,"url":"https://api.github.com/repos/stefanpenner/service-sessions","forks_url":"https://api.github.com/repos/stefanpenner/service-sessions/forks","keys_url":"https://api.github.com/repos/stefanpenner/service-sessions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanpenner/service-sessions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanpenner/service-sessions/teams","hooks_url":"https://api.github.com/repos/stefanpenner/service-sessions/hooks","issue_events_url":"https://api.github.com/repos/stefanpenner/service-sessions/issues/events{/number}","events_url":"https://api.github.com/repos/stefanpenner/service-sessions/events","assignees_url":"https://api.github.com/repos/stefanpenner/service-sessions/assignees{/user}","branches_url":"https://api.github.com/repos/stefanpenner/service-sessions/branches{/branch}","tags_url":"https://api.github.com/repos/stefanpenner/service-sessions/tags","blobs_url":"https://api.github.com/repos/stefanpenner/service-sessions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanpenner/service-sessions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanpenner/service-sessions/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanpenner/service-sessions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanpenner/service-sessions/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanpenner/service-sessions/languages","stargazers_url":"https://api.github.com/repos/stefanpenner/service-sessions/stargazers","contributors_url":"https://api.github.com/repos/stefanpenner/service-sessions/contributors","subscribers_url":"https://api.github.com/repos/stefanpenner/service-sessions/subscribers","subscription_url":"https://api.github.com/repos/stefanpenner/service-sessions/subscription","commits_url":"https://api.github.com/repos/stefanpenner/service-sessions/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanpenner/service-sessions/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanpenner/service-sessions/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanpenner/service-sessions/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanpenner/service-sessions/contents/{+path}","compare_url":"https://api.github.com/repos/stefanpenner/service-sessions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanpenner/service-sessions/merges","archive_url":"https://api.github.com/repos/stefanpenner/service-sessions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanpenner/service-sessions/downloads","issues_url":"https://api.github.com/repos/stefanpenner/service-sessions/issues{/number}","pulls_url":"https://api.github.com/repos/stefanpenner/service-sessions/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanpenner/service-sessions/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanpenner/service-sessions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanpenner/service-sessions/labels{/name}","releases_url":"https://api.github.com/repos/stefanpenner/service-sessions/releases{/id}","created_at":"2015-02-07T04:10:34Z","updated_at":"2015-02-27T19:21:47Z","pushed_at":"2015-02-27T19:21:46Z","git_url":"git://github.com/stefanpenner/service-sessions.git","ssh_url":"git@github.com:stefanpenner/service-sessions.git","clone_url":"https://github.com/stefanpenner/service-sessions.git","svn_url":"https://github.com/stefanpenner/service-sessions","homepage":null,"size":140,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4"},"html":{"href":"https://github.com/stefanpenner/service-sessions/pull/4"},"issue":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/issues/4"},"comments":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/stefanpenner/service-sessions/statuses/fb1ac8fa204479deef5b0c7a31b9e7205c46f2cf"}}}}