{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/26701491","id":26701491,"diff_hunk":"@@ -1864,7 +1930,8 @@ static zend_op *zend_delayed_compile_end(uint32_t offset) /* {{{ */\n static void zend_emit_return_type_check(znode *expr, zend_arg_info *return_info) /* {{{ */\n {\n \tif (return_info->type_hint != IS_UNDEF) {\n-\t\tzend_emit_op(NULL, ZEND_VERIFY_RETURN_TYPE, expr, NULL);\n+\t\tzend_op *opline = zend_emit_op(NULL, ZEND_VERIFY_RETURN_TYPE, expr, NULL);\n+\t\topline->extended_value = (CG(declarables).strict_types ? 1 : 0);","path":"Zend/zend_compile.c","position":89,"original_position":89,"commit_id":"579e7fa457a7596fda24f43c64176406d91ed226","original_commit_id":"579e7fa457a7596fda24f43c64176406d91ed226","user":{"login":"nikic","id":216080,"avatar_url":"https://avatars.githubusercontent.com/u/216080?v=3","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"body":"Ternary here looks redundant - the declarable is already a boolean.","created_at":"2015-03-18T20:04:22Z","updated_at":"2015-03-18T20:04:22Z","html_url":"https://github.com/php/php-src/pull/1180#discussion_r26701491","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/1180","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/26701491"},"html":{"href":"https://github.com/php/php-src/pull/1180#discussion_r26701491"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/1180"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1180","id":31254790,"html_url":"https://github.com/php/php-src/pull/1180","diff_url":"https://github.com/php/php-src/pull/1180.diff","patch_url":"https://github.com/php/php-src/pull/1180.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1180","number":1180,"state":"open","locked":false,"title":"Scalar type hints v5","user":{"login":"ircmaxell","id":660654,"avatar_url":"https://avatars.githubusercontent.com/u/660654?v=3","gravatar_id":"","url":"https://api.github.com/users/ircmaxell","html_url":"https://github.com/ircmaxell","followers_url":"https://api.github.com/users/ircmaxell/followers","following_url":"https://api.github.com/users/ircmaxell/following{/other_user}","gists_url":"https://api.github.com/users/ircmaxell/gists{/gist_id}","starred_url":"https://api.github.com/users/ircmaxell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ircmaxell/subscriptions","organizations_url":"https://api.github.com/users/ircmaxell/orgs","repos_url":"https://api.github.com/users/ircmaxell/repos","events_url":"https://api.github.com/users/ircmaxell/events{/privacy}","received_events_url":"https://api.github.com/users/ircmaxell/received_events","type":"User","site_admin":false},"body":"A PR for scalar type declarations RFC: https://wiki.php.net/rfc/scalar_type_hints_v5","created_at":"2015-03-16T15:40:11Z","updated_at":"2015-03-18T20:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b0ebd81baf061e9bffa7d8bf85aaa6266dc5388","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1180/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1180/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1180/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/579e7fa457a7596fda24f43c64176406d91ed226","head":{"label":"ircmaxell:scalar_type_hints_v5","ref":"scalar_type_hints_v5","sha":"579e7fa457a7596fda24f43c64176406d91ed226","user":{"login":"ircmaxell","id":660654,"avatar_url":"https://avatars.githubusercontent.com/u/660654?v=3","gravatar_id":"","url":"https://api.github.com/users/ircmaxell","html_url":"https://github.com/ircmaxell","followers_url":"https://api.github.com/users/ircmaxell/followers","following_url":"https://api.github.com/users/ircmaxell/following{/other_user}","gists_url":"https://api.github.com/users/ircmaxell/gists{/gist_id}","starred_url":"https://api.github.com/users/ircmaxell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ircmaxell/subscriptions","organizations_url":"https://api.github.com/users/ircmaxell/orgs","repos_url":"https://api.github.com/users/ircmaxell/repos","events_url":"https://api.github.com/users/ircmaxell/events{/privacy}","received_events_url":"https://api.github.com/users/ircmaxell/received_events","type":"User","site_admin":false},"repo":{"id":3765522,"name":"php-src","full_name":"ircmaxell/php-src","owner":{"login":"ircmaxell","id":660654,"avatar_url":"https://avatars.githubusercontent.com/u/660654?v=3","gravatar_id":"","url":"https://api.github.com/users/ircmaxell","html_url":"https://github.com/ircmaxell","followers_url":"https://api.github.com/users/ircmaxell/followers","following_url":"https://api.github.com/users/ircmaxell/following{/other_user}","gists_url":"https://api.github.com/users/ircmaxell/gists{/gist_id}","starred_url":"https://api.github.com/users/ircmaxell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ircmaxell/subscriptions","organizations_url":"https://api.github.com/users/ircmaxell/orgs","repos_url":"https://api.github.com/users/ircmaxell/repos","events_url":"https://api.github.com/users/ircmaxell/events{/privacy}","received_events_url":"https://api.github.com/users/ircmaxell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ircmaxell/php-src","description":"git mirror of the PHP source code","fork":true,"url":"https://api.github.com/repos/ircmaxell/php-src","forks_url":"https://api.github.com/repos/ircmaxell/php-src/forks","keys_url":"https://api.github.com/repos/ircmaxell/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ircmaxell/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ircmaxell/php-src/teams","hooks_url":"https://api.github.com/repos/ircmaxell/php-src/hooks","issue_events_url":"https://api.github.com/repos/ircmaxell/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/ircmaxell/php-src/events","assignees_url":"https://api.github.com/repos/ircmaxell/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/ircmaxell/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/ircmaxell/php-src/tags","blobs_url":"https://api.github.com/repos/ircmaxell/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ircmaxell/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ircmaxell/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/ircmaxell/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ircmaxell/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/ircmaxell/php-src/languages","stargazers_url":"https://api.github.com/repos/ircmaxell/php-src/stargazers","contributors_url":"https://api.github.com/repos/ircmaxell/php-src/contributors","subscribers_url":"https://api.github.com/repos/ircmaxell/php-src/subscribers","subscription_url":"https://api.github.com/repos/ircmaxell/php-src/subscription","commits_url":"https://api.github.com/repos/ircmaxell/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/ircmaxell/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/ircmaxell/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/ircmaxell/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/ircmaxell/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/ircmaxell/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ircmaxell/php-src/merges","archive_url":"https://api.github.com/repos/ircmaxell/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ircmaxell/php-src/downloads","issues_url":"https://api.github.com/repos/ircmaxell/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/ircmaxell/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/ircmaxell/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/ircmaxell/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ircmaxell/php-src/labels{/name}","releases_url":"https://api.github.com/repos/ircmaxell/php-src/releases{/id}","created_at":"2012-03-19T15:53:16Z","updated_at":"2015-03-18T14:19:28Z","pushed_at":"2015-03-18T19:45:26Z","git_url":"git://github.com/ircmaxell/php-src.git","ssh_url":"git@github.com:ircmaxell/php-src.git","clone_url":"https://github.com/ircmaxell/php-src.git","svn_url":"https://github.com/ircmaxell/php-src","homepage":"http://www.php.net","size":212112,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"5c6db3b0f2a8fdc1ad5221abc9450d0599fc5ece","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","created_at":"2011-06-16T01:52:25Z","updated_at":"2015-03-18T19:59:41Z","pushed_at":"2015-03-18T19:59:13Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":1322417,"stargazers_count":5532,"watchers_count":5532,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1986,"mirror_url":null,"open_issues_count":179,"forks":1986,"open_issues":179,"watchers":5532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1180"},"html":{"href":"https://github.com/php/php-src/pull/1180"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1180"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1180/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1180/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1180/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/579e7fa457a7596fda24f43c64176406d91ed226"}}}}