{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/30868279","id":30868279,"diff_hunk":"@@ -0,0 +1,23 @@\n+<Workspace Version=\"0.8.1.1403\" X=\"17\" Y=\"66\" zoom=\"1\" Name=\"Home\" RunType=\"Manual\" RunPeriod=\"100\" HasRunWithoutCrash=\"True\">\n+  <NamespaceResolutionMap />\n+  <Elements>\n+    <Dynamo.Nodes.DSFunction guid=\"9bce1a0e-8623-4360-b48b-c0db96f47c0b\" type=\"Dynamo.Nodes.DSFunction\" nickname=\"Excel.WriteToFile\" x=\"635.5\" y=\"124.5\" isVisible=\"true\" isUpstreamVisible=\"true\" lacing=\"Shortest\" assembly=\"DSOffice.dll\" function=\"DSOffice.Excel.WriteToFile@string,string,int,int,var[][]\" />\n+    <Dynamo.Nodes.CodeBlockNodeModel guid=\"833e45ce-a9a9-4f5c-9304-cc99053895ee\" type=\"Dynamo.Nodes.CodeBlockNodeModel\" nickname=\"Code Block\" x=\"322\" y=\"98\" isVisible=\"true\" isUpstreamVisible=\"true\" lacing=\"Disabled\" CodeText=\"&quot;test&quot;;\" ShouldFocus=\"false\" />\n+    <Dynamo.Nodes.CodeBlockNodeModel guid=\"b0fd70fd-c4e0-42a1-9f6b-08aea7e0d2e9\" type=\"Dynamo.Nodes.CodeBlockNodeModel\" nickname=\"Code Block\" x=\"413\" y=\"183\" isVisible=\"true\" isUpstreamVisible=\"true\" lacing=\"Disabled\" CodeText=\"0;\" ShouldFocus=\"false\" />\n+    <Dynamo.Nodes.CodeBlockNodeModel guid=\"f8dffa86-e0d1-4569-9220-f718a6c65c82\" type=\"Dynamo.Nodes.CodeBlockNodeModel\" nickname=\"Code Block\" x=\"239\" y=\"334\" isVisible=\"true\" isUpstreamVisible=\"true\" lacing=\"Disabled\" CodeText=\"{};\" ShouldFocus=\"false\" />\n+    <Dynamo.Nodes.StringInput guid=\"a05edec7-9df2-4ac1-a133-5069e72c3257\" type=\"Dynamo.Nodes.StringInput\" nickname=\"String\" x=\"508\" y=\"32.5\" isVisible=\"true\" isUpstreamVisible=\"true\" lacing=\"Disabled\">\n+      <System.String>\n+      </System.String>\n+      <System.String value=\"\" />","path":"test/core/excel/WriteEmptyListToExcel.DYN","position":11,"original_position":11,"commit_id":"212ce8c4fad8bd1e517ee0dc3e97f7f79cea32dd","original_commit_id":"212ce8c4fad8bd1e517ee0dc3e97f7f79cea32dd","user":{"login":"Randy-Ma","id":5584246,"avatar_url":"https://avatars.githubusercontent.com/u/5584246?v=3","gravatar_id":"","url":"https://api.github.com/users/Randy-Ma","html_url":"https://github.com/Randy-Ma","followers_url":"https://api.github.com/users/Randy-Ma/followers","following_url":"https://api.github.com/users/Randy-Ma/following{/other_user}","gists_url":"https://api.github.com/users/Randy-Ma/gists{/gist_id}","starred_url":"https://api.github.com/users/Randy-Ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Randy-Ma/subscriptions","organizations_url":"https://api.github.com/users/Randy-Ma/orgs","repos_url":"https://api.github.com/users/Randy-Ma/repos","events_url":"https://api.github.com/users/Randy-Ma/events{/privacy}","received_events_url":"https://api.github.com/users/Randy-Ma/received_events","type":"User","site_admin":false},"body":"It seems something is wrong with StringInput because I am seeing two String nodes here.","created_at":"2015-05-22T04:04:13Z","updated_at":"2015-05-22T04:04:13Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/4538#discussion_r30868279","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/30868279"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/4538#discussion_r30868279"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538","id":35922553,"html_url":"https://github.com/DynamoDS/Dynamo/pull/4538","diff_url":"https://github.com/DynamoDS/Dynamo/pull/4538.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/4538.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4538","number":4538,"state":"open","locked":false,"title":"Handle empty list input to Excel.Write node","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=3","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nFix for http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-7451. This fixes an issue where the `Excel.WriteToFile` node fails on supplying an empty list or nested empty lists as input to the node. \r\n\r\nThe expected behaviour should be the consistent with the case for a sparse array with `null` values or empty lists scattered in between. An empty cell is created wherever there is a `null` value or empty list occurring in the input array. \r\n\r\nThe new behaviour for an empty list `{}` or list of nested empty lists, `{{...}, ...}` is that a single empty cell is created at the `startRow` and `startCol` values of the node.\r\n\r\n### Declarations\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] The level of testing this PR includes is appropriate\r\n\r\n### Reviewers\r\n\r\n@junmendoza  \r\n@Randy-Ma \r\n\r\n### FYIs\r\n\r\n@monikaprabhu ","created_at":"2015-05-21T11:04:40Z","updated_at":"2015-05-22T04:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b075e154dec2e02dd43fe6b5162942f8bb741f8","assignee":{"login":"Randy-Ma","id":5584246,"avatar_url":"https://avatars.githubusercontent.com/u/5584246?v=3","gravatar_id":"","url":"https://api.github.com/users/Randy-Ma","html_url":"https://github.com/Randy-Ma","followers_url":"https://api.github.com/users/Randy-Ma/followers","following_url":"https://api.github.com/users/Randy-Ma/following{/other_user}","gists_url":"https://api.github.com/users/Randy-Ma/gists{/gist_id}","starred_url":"https://api.github.com/users/Randy-Ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Randy-Ma/subscriptions","organizations_url":"https://api.github.com/users/Randy-Ma/orgs","repos_url":"https://api.github.com/users/Randy-Ma/repos","events_url":"https://api.github.com/users/Randy-Ma/events{/privacy}","received_events_url":"https://api.github.com/users/Randy-Ma/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4538/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/212ce8c4fad8bd1e517ee0dc3e97f7f79cea32dd","head":{"label":"aparajit-pratap:excelEmptyList","ref":"excelEmptyList","sha":"212ce8c4fad8bd1e517ee0dc3e97f7f79cea32dd","user":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=3","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"repo":{"id":15271868,"name":"Dynamo","full_name":"aparajit-pratap/Dynamo","owner":{"login":"aparajit-pratap","id":5710686,"avatar_url":"https://avatars.githubusercontent.com/u/5710686?v=3","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aparajit-pratap/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/aparajit-pratap/Dynamo","forks_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/forks","keys_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/teams","hooks_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/events","assignees_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/tags","blobs_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/languages","stargazers_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/subscription","commits_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/merges","archive_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/downloads","issues_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/aparajit-pratap/Dynamo/releases{/id}","created_at":"2013-12-18T02:34:41Z","updated_at":"2015-05-05T04:30:35Z","pushed_at":"2015-05-22T03:45:49Z","git_url":"git://github.com/aparajit-pratap/Dynamo.git","ssh_url":"git@github.com:aparajit-pratap/Dynamo.git","clone_url":"https://github.com/aparajit-pratap/Dynamo.git","svn_url":"https://github.com/aparajit-pratap/Dynamo","homepage":"http://dynamobim.org","size":821091,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"ead89fbada1d6313f0ef393c4ff2ce68bbaf30ab","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-05-22T02:29:20Z","pushed_at":"2015-05-22T03:55:59Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":948286,"stargazers_count":223,"watchers_count":223,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":617,"forks":170,"open_issues":617,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/4538"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4538"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4538/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4538/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/212ce8c4fad8bd1e517ee0dc3e97f7f79cea32dd"}}}}