{"action":"created","issue":{"url":"https://api.github.com/repos/therivenman/pygop/issues/13","labels_url":"https://api.github.com/repos/therivenman/pygop/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/therivenman/pygop/issues/13/comments","events_url":"https://api.github.com/repos/therivenman/pygop/issues/13/events","html_url":"https://github.com/therivenman/pygop/issues/13","id":46359090,"number":13,"title":"Cache room scans to improve performance","user":{"login":"bdunlay","id":420197,"avatar_url":"https://avatars.githubusercontent.com/u/420197?v=3","gravatar_id":"","url":"https://api.github.com/users/bdunlay","html_url":"https://github.com/bdunlay","followers_url":"https://api.github.com/users/bdunlay/followers","following_url":"https://api.github.com/users/bdunlay/following{/other_user}","gists_url":"https://api.github.com/users/bdunlay/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunlay/subscriptions","organizations_url":"https://api.github.com/users/bdunlay/orgs","repos_url":"https://api.github.com/users/bdunlay/repos","events_url":"https://api.github.com/users/bdunlay/events{/privacy}","received_events_url":"https://api.github.com/users/bdunlay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2014-10-21T06:24:09Z","updated_at":"2015-01-28T05:21:07Z","closed_at":"2015-01-28T05:21:07Z","body":"Every invocation of the CLI results in a room scan if you want to do anything by name. Because this information is only retained in memory, and the CLI is a quick invocation and return, we have to re-query rooms for literally every name-based command.\r\n\r\nI propose the following:\r\n- If no rooms cache, scan and create cache\r\n- Add CL param to invalidate the cache on demand\r\n- Invalidate cache after a certain period of time has passed\r\n- If a set fails from cache, scan rooms / retry / update cache\r\n\r\nThe real question is will this really improve performance by enough to make it worth the dev effort. Probably not. Might put this on the back burner until some more features are implemented."},"comment":{"url":"https://api.github.com/repos/therivenman/pygop/issues/comments/71782695","html_url":"https://github.com/therivenman/pygop/issues/13#issuecomment-71782695","issue_url":"https://api.github.com/repos/therivenman/pygop/issues/13","id":71782695,"user":{"login":"therivenman","id":948796,"avatar_url":"https://avatars.githubusercontent.com/u/948796?v=3","gravatar_id":"","url":"https://api.github.com/users/therivenman","html_url":"https://github.com/therivenman","followers_url":"https://api.github.com/users/therivenman/followers","following_url":"https://api.github.com/users/therivenman/following{/other_user}","gists_url":"https://api.github.com/users/therivenman/gists{/gist_id}","starred_url":"https://api.github.com/users/therivenman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therivenman/subscriptions","organizations_url":"https://api.github.com/users/therivenman/orgs","repos_url":"https://api.github.com/users/therivenman/repos","events_url":"https://api.github.com/users/therivenman/events{/privacy}","received_events_url":"https://api.github.com/users/therivenman/received_events","type":"User","site_admin":false},"created_at":"2015-01-28T05:21:07Z","updated_at":"2015-01-28T05:21:07Z","body":"This feature was implemented in commit 0a3b46e5daab16ce0f8234ba77060751b5f4be30.\r\n\r\nThanks @bdunlay!"}}