{"action":"created","issue":{"url":"https://api.github.com/repos/Qabel/qabel-core/issues/329","labels_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329/labels{/name}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329/comments","events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329/events","html_url":"https://github.com/Qabel/qabel-core/pull/329","id":75936827,"number":329,"title":"Refactored DropActor","user":{"login":"L-Henke","id":7975219,"avatar_url":"https://avatars.githubusercontent.com/u/7975219?v=3","gravatar_id":"","url":"https://api.github.com/users/L-Henke","html_url":"https://github.com/L-Henke","followers_url":"https://api.github.com/users/L-Henke/followers","following_url":"https://api.github.com/users/L-Henke/following{/other_user}","gists_url":"https://api.github.com/users/L-Henke/gists{/gist_id}","starred_url":"https://api.github.com/users/L-Henke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/L-Henke/subscriptions","organizations_url":"https://api.github.com/users/L-Henke/orgs","repos_url":"https://api.github.com/users/L-Henke/repos","events_url":"https://api.github.com/users/L-Henke/events{/privacy}","received_events_url":"https://api.github.com/users/L-Henke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jasinai","id":903551,"avatar_url":"https://avatars.githubusercontent.com/u/903551?v=3","gravatar_id":"","url":"https://api.github.com/users/jasinai","html_url":"https://github.com/jasinai","followers_url":"https://api.github.com/users/jasinai/followers","following_url":"https://api.github.com/users/jasinai/following{/other_user}","gists_url":"https://api.github.com/users/jasinai/gists{/gist_id}","starred_url":"https://api.github.com/users/jasinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasinai/subscriptions","organizations_url":"https://api.github.com/users/jasinai/orgs","repos_url":"https://api.github.com/users/jasinai/repos","events_url":"https://api.github.com/users/jasinai/events{/privacy}","received_events_url":"https://api.github.com/users/jasinai/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-05-13T10:30:41Z","updated_at":"2015-06-02T12:57:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/329","html_url":"https://github.com/Qabel/qabel-core/pull/329","diff_url":"https://github.com/Qabel/qabel-core/pull/329.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/329.patch"},"body":"Refactored DropActor to get resources via events. ~~The ContactActorTest has some concurrency issues, because modifying contacts is done in a different thread, which cannot be joined anymore. This might be avoided with a simple sleep, but maybe there is a cleaner solution.~~ EDIT: ContactActorTest now listens to contact added and removed events to wait until events has been processed.\r\n\r\n- [X] Get Contacts via event\r\n- [x] Get Identities via event\r\n- [x] Get DropServers via event\r\n- [x] Eliminated concurrency problems with ContactActorTest\r\n\r\n~~This is related to #327, but does not closes it in the current state.~~\r\nThe unregister method from https://github.com/Qabel/ackack/pull/7 is required for this PR.\r\n\r\nSynchronization may get further optimized.\r\n\r\nRequires #334 \r\n- [ ] Fix timeout with large persistence file\r\n- [ ] Default LocalSettings\r\n- [ ] Define when to emit config changes\r\n- [ ] Check synchronization in Config and ContactActor\r\n\r\nFixes #336 \r\nCloses #327 "},"comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments/107945107","html_url":"https://github.com/Qabel/qabel-core/pull/329#issuecomment-107945107","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/329","id":107945107,"user":{"login":"thechauffeur","id":150507,"avatar_url":"https://avatars.githubusercontent.com/u/150507?v=3","gravatar_id":"","url":"https://api.github.com/users/thechauffeur","html_url":"https://github.com/thechauffeur","followers_url":"https://api.github.com/users/thechauffeur/followers","following_url":"https://api.github.com/users/thechauffeur/following{/other_user}","gists_url":"https://api.github.com/users/thechauffeur/gists{/gist_id}","starred_url":"https://api.github.com/users/thechauffeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechauffeur/subscriptions","organizations_url":"https://api.github.com/users/thechauffeur/orgs","repos_url":"https://api.github.com/users/thechauffeur/repos","events_url":"https://api.github.com/users/thechauffeur/events{/privacy}","received_events_url":"https://api.github.com/users/thechauffeur/received_events","type":"User","site_admin":false},"created_at":"2015-06-02T12:57:43Z","updated_at":"2015-06-02T12:57:43Z","body":"@jasinai look at the tests. Look if they test the stuff they tested before and if they make sense. Good tests would be nice here ;)"}}