{"action":"created","comment":{"url":"https://api.github.com/repos/kvirc/KVIrc/pulls/comments/42593911","id":42593911,"diff_hunk":"@@ -109,13 +109,13 @@\n \t\tObviously (with the current implementations) all the conversation endpoints\n \t\tmust agree on the engine (or better algorithm) used and on the key(s).\n \t\tThe key is user specified, so you have to find a secure way to negotiate\n-\t\tit with your communication engpoints. If you can meet the persons in the \"real life\",\n-\t\tthis is the best way to exchange the keys, otherwise you can use mail & pgp.\n-\t\tYes, this is a \"miss\" of the crypt protocol: it is missing a public key handshake.[br]\n+\t\tit with your communication endpoints. If you can meet the persons in the \"real life\",\n+\t\tthis is the best way to exchange the keys, otherwise you can use mail & PGP.\n+\t\tYes, this is a shortcoming of the crypt protocol: it is missing a public key handshake.[br]\n \n \t\t[big]The first test[/big][br]\n-\t\tA cool way to test a crypting engine is to use a \"self query\": connect to\n-\t\tany irc server, and execute [cmd]query[/cmd] <yournickname>; a query window\n+\t\tA cool way to test a encrypting engine is to use a \"self query\": connect to","path":"src/kvilib/ext/KviCryptEngine.cpp","position":105,"original_position":105,"commit_id":"00caf93f436b6bf0fafa948b92ef3a4a7d954f70","original_commit_id":"00caf93f436b6bf0fafa948b92ef3a4a7d954f70","user":{"login":"blindsighttf2","id":6256971,"avatar_url":"https://avatars.githubusercontent.com/u/6256971?v=3","gravatar_id":"","url":"https://api.github.com/users/blindsighttf2","html_url":"https://github.com/blindsighttf2","followers_url":"https://api.github.com/users/blindsighttf2/followers","following_url":"https://api.github.com/users/blindsighttf2/following{/other_user}","gists_url":"https://api.github.com/users/blindsighttf2/gists{/gist_id}","starred_url":"https://api.github.com/users/blindsighttf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blindsighttf2/subscriptions","organizations_url":"https://api.github.com/users/blindsighttf2/orgs","repos_url":"https://api.github.com/users/blindsighttf2/repos","events_url":"https://api.github.com/users/blindsighttf2/events{/privacy}","received_events_url":"https://api.github.com/users/blindsighttf2/received_events","type":"User","site_admin":false},"body":"`an` not `a`. Also unless `encrypting engine` is the proper name of it, I'd use `encryption engine` since it flows better.","created_at":"2015-10-21T08:07:21Z","updated_at":"2015-10-21T08:07:21Z","html_url":"https://github.com/kvirc/KVIrc/pull/1661#discussion_r42593911","pull_request_url":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661","_links":{"self":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/comments/42593911"},"html":{"href":"https://github.com/kvirc/KVIrc/pull/1661#discussion_r42593911"},"pull_request":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661"}}},"pull_request":{"url":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661","id":47151470,"html_url":"https://github.com/kvirc/KVIrc/pull/1661","diff_url":"https://github.com/kvirc/KVIrc/pull/1661.diff","patch_url":"https://github.com/kvirc/KVIrc/pull/1661.patch","issue_url":"https://api.github.com/repos/kvirc/KVIrc/issues/1661","number":1661,"state":"open","locked":false,"title":"Split from #1631: cpp more strings and doc typos and fixes - need helpfull feedback","user":{"login":"un1versal","id":3521959,"avatar_url":"https://avatars.githubusercontent.com/u/3521959?v=3","gravatar_id":"","url":"https://api.github.com/users/un1versal","html_url":"https://github.com/un1versal","followers_url":"https://api.github.com/users/un1versal/followers","following_url":"https://api.github.com/users/un1versal/following{/other_user}","gists_url":"https://api.github.com/users/un1versal/gists{/gist_id}","starred_url":"https://api.github.com/users/un1versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/un1versal/subscriptions","organizations_url":"https://api.github.com/users/un1versal/orgs","repos_url":"https://api.github.com/users/un1versal/repos","events_url":"https://api.github.com/users/un1versal/events{/privacy}","received_events_url":"https://api.github.com/users/un1versal/received_events","type":"User","site_admin":false},"body":"This is also split from #1631 but this contains a more controversial subset of #1660 \r\nWhat I Tried to do here if it isnt obvious, is in addition to some typos and similar fixes to #1660, to capitalize where possible commands/actions or service but some maybe mixed up at this time.\r\n\r\n### Notes:\r\nPlease on the cases that fit into the categories below **just add with your review** this should be **lower case** and this **can be all capitals** where applicable. I will fix and push the changes as and when reviews come in.\r\n\r\nAUTH command vs auth \"authorize(d)\"\r\nSome of these may be incorrect where **AUTH means just authorized** and not AUTH the command.\r\n\r\n#### Excessive... use of... ellipses...\r\nOops... lines IMO its Oops!\r\n\r\n```\r\noops\r\no͝ops,o͞ops/\r\nexclamation informal\r\nexclamation: oops\r\n\r\n    used to show recognition of a mistake or minor accident, often as part of an apology.\r\n    \"“Oops! I'm sorry. I just made you miss your bus.”\"\r\n```\r\n\r\nAlso most sentences dont seem to be very reticent in nature.\r\nI purposefully capitalized the first letter after ellipses, to bring attention to the fact these have to be changed after review to something appropriate and correct.\r\n\r\nRest review as normal with helpful feedback to aid proper correction.\r\n\r\n### Please review and provide helpful feedback\r\n\r\nThank you.","created_at":"2015-10-08T13:22:24Z","updated_at":"2015-10-21T08:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fab62bc627618c6fc9d946af0229523f7c41ab7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661/commits","review_comments_url":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661/comments","review_comment_url":"https://api.github.com/repos/kvirc/KVIrc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kvirc/KVIrc/issues/1661/comments","statuses_url":"https://api.github.com/repos/kvirc/KVIrc/statuses/00caf93f436b6bf0fafa948b92ef3a4a7d954f70","head":{"label":"un1versal:Mary-Poppins","ref":"Mary-Poppins","sha":"00caf93f436b6bf0fafa948b92ef3a4a7d954f70","user":{"login":"un1versal","id":3521959,"avatar_url":"https://avatars.githubusercontent.com/u/3521959?v=3","gravatar_id":"","url":"https://api.github.com/users/un1versal","html_url":"https://github.com/un1versal","followers_url":"https://api.github.com/users/un1versal/followers","following_url":"https://api.github.com/users/un1versal/following{/other_user}","gists_url":"https://api.github.com/users/un1versal/gists{/gist_id}","starred_url":"https://api.github.com/users/un1versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/un1versal/subscriptions","organizations_url":"https://api.github.com/users/un1versal/orgs","repos_url":"https://api.github.com/users/un1versal/repos","events_url":"https://api.github.com/users/un1versal/events{/privacy}","received_events_url":"https://api.github.com/users/un1versal/received_events","type":"User","site_admin":false},"repo":{"id":40299092,"name":"KVIrc","full_name":"un1versal/KVIrc","owner":{"login":"un1versal","id":3521959,"avatar_url":"https://avatars.githubusercontent.com/u/3521959?v=3","gravatar_id":"","url":"https://api.github.com/users/un1versal","html_url":"https://github.com/un1versal","followers_url":"https://api.github.com/users/un1versal/followers","following_url":"https://api.github.com/users/un1versal/following{/other_user}","gists_url":"https://api.github.com/users/un1versal/gists{/gist_id}","starred_url":"https://api.github.com/users/un1versal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/un1versal/subscriptions","organizations_url":"https://api.github.com/users/un1versal/orgs","repos_url":"https://api.github.com/users/un1versal/repos","events_url":"https://api.github.com/users/un1versal/events{/privacy}","received_events_url":"https://api.github.com/users/un1versal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/un1versal/KVIrc","description":"The KVIrc IRC Client - Development fork only","fork":true,"url":"https://api.github.com/repos/un1versal/KVIrc","forks_url":"https://api.github.com/repos/un1versal/KVIrc/forks","keys_url":"https://api.github.com/repos/un1versal/KVIrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/un1versal/KVIrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/un1versal/KVIrc/teams","hooks_url":"https://api.github.com/repos/un1versal/KVIrc/hooks","issue_events_url":"https://api.github.com/repos/un1versal/KVIrc/issues/events{/number}","events_url":"https://api.github.com/repos/un1versal/KVIrc/events","assignees_url":"https://api.github.com/repos/un1versal/KVIrc/assignees{/user}","branches_url":"https://api.github.com/repos/un1versal/KVIrc/branches{/branch}","tags_url":"https://api.github.com/repos/un1versal/KVIrc/tags","blobs_url":"https://api.github.com/repos/un1versal/KVIrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/un1versal/KVIrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/un1versal/KVIrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/un1versal/KVIrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/un1versal/KVIrc/statuses/{sha}","languages_url":"https://api.github.com/repos/un1versal/KVIrc/languages","stargazers_url":"https://api.github.com/repos/un1versal/KVIrc/stargazers","contributors_url":"https://api.github.com/repos/un1versal/KVIrc/contributors","subscribers_url":"https://api.github.com/repos/un1versal/KVIrc/subscribers","subscription_url":"https://api.github.com/repos/un1versal/KVIrc/subscription","commits_url":"https://api.github.com/repos/un1versal/KVIrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/un1versal/KVIrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/un1versal/KVIrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/un1versal/KVIrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/un1versal/KVIrc/contents/{+path}","compare_url":"https://api.github.com/repos/un1versal/KVIrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/un1versal/KVIrc/merges","archive_url":"https://api.github.com/repos/un1versal/KVIrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/un1versal/KVIrc/downloads","issues_url":"https://api.github.com/repos/un1versal/KVIrc/issues{/number}","pulls_url":"https://api.github.com/repos/un1versal/KVIrc/pulls{/number}","milestones_url":"https://api.github.com/repos/un1versal/KVIrc/milestones{/number}","notifications_url":"https://api.github.com/repos/un1versal/KVIrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/un1versal/KVIrc/labels{/name}","releases_url":"https://api.github.com/repos/un1versal/KVIrc/releases{/id}","created_at":"2015-08-06T10:28:47Z","updated_at":"2015-09-10T06:50:25Z","pushed_at":"2015-10-20T15:28:08Z","git_url":"git://github.com/un1versal/KVIrc.git","ssh_url":"git@github.com:un1versal/KVIrc.git","clone_url":"https://github.com/un1versal/KVIrc.git","svn_url":"https://github.com/un1versal/KVIrc","homepage":"http://www.kvirc.net/","size":62212,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kvirc:master","ref":"master","sha":"ef870f00612d7a8916ea77933b293cac3d3c5773","user":{"login":"kvirc","id":4458336,"avatar_url":"https://avatars.githubusercontent.com/u/4458336?v=3","gravatar_id":"","url":"https://api.github.com/users/kvirc","html_url":"https://github.com/kvirc","followers_url":"https://api.github.com/users/kvirc/followers","following_url":"https://api.github.com/users/kvirc/following{/other_user}","gists_url":"https://api.github.com/users/kvirc/gists{/gist_id}","starred_url":"https://api.github.com/users/kvirc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvirc/subscriptions","organizations_url":"https://api.github.com/users/kvirc/orgs","repos_url":"https://api.github.com/users/kvirc/repos","events_url":"https://api.github.com/users/kvirc/events{/privacy}","received_events_url":"https://api.github.com/users/kvirc/received_events","type":"Organization","site_admin":false},"repo":{"id":39708674,"name":"KVIrc","full_name":"kvirc/KVIrc","owner":{"login":"kvirc","id":4458336,"avatar_url":"https://avatars.githubusercontent.com/u/4458336?v=3","gravatar_id":"","url":"https://api.github.com/users/kvirc","html_url":"https://github.com/kvirc","followers_url":"https://api.github.com/users/kvirc/followers","following_url":"https://api.github.com/users/kvirc/following{/other_user}","gists_url":"https://api.github.com/users/kvirc/gists{/gist_id}","starred_url":"https://api.github.com/users/kvirc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvirc/subscriptions","organizations_url":"https://api.github.com/users/kvirc/orgs","repos_url":"https://api.github.com/users/kvirc/repos","events_url":"https://api.github.com/users/kvirc/events{/privacy}","received_events_url":"https://api.github.com/users/kvirc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kvirc/KVIrc","description":"The KVIrc IRC Client","fork":false,"url":"https://api.github.com/repos/kvirc/KVIrc","forks_url":"https://api.github.com/repos/kvirc/KVIrc/forks","keys_url":"https://api.github.com/repos/kvirc/KVIrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvirc/KVIrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvirc/KVIrc/teams","hooks_url":"https://api.github.com/repos/kvirc/KVIrc/hooks","issue_events_url":"https://api.github.com/repos/kvirc/KVIrc/issues/events{/number}","events_url":"https://api.github.com/repos/kvirc/KVIrc/events","assignees_url":"https://api.github.com/repos/kvirc/KVIrc/assignees{/user}","branches_url":"https://api.github.com/repos/kvirc/KVIrc/branches{/branch}","tags_url":"https://api.github.com/repos/kvirc/KVIrc/tags","blobs_url":"https://api.github.com/repos/kvirc/KVIrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvirc/KVIrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvirc/KVIrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvirc/KVIrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvirc/KVIrc/statuses/{sha}","languages_url":"https://api.github.com/repos/kvirc/KVIrc/languages","stargazers_url":"https://api.github.com/repos/kvirc/KVIrc/stargazers","contributors_url":"https://api.github.com/repos/kvirc/KVIrc/contributors","subscribers_url":"https://api.github.com/repos/kvirc/KVIrc/subscribers","subscription_url":"https://api.github.com/repos/kvirc/KVIrc/subscription","commits_url":"https://api.github.com/repos/kvirc/KVIrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvirc/KVIrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvirc/KVIrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvirc/KVIrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kvirc/KVIrc/contents/{+path}","compare_url":"https://api.github.com/repos/kvirc/KVIrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvirc/KVIrc/merges","archive_url":"https://api.github.com/repos/kvirc/KVIrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvirc/KVIrc/downloads","issues_url":"https://api.github.com/repos/kvirc/KVIrc/issues{/number}","pulls_url":"https://api.github.com/repos/kvirc/KVIrc/pulls{/number}","milestones_url":"https://api.github.com/repos/kvirc/KVIrc/milestones{/number}","notifications_url":"https://api.github.com/repos/kvirc/KVIrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvirc/KVIrc/labels{/name}","releases_url":"https://api.github.com/repos/kvirc/KVIrc/releases{/id}","created_at":"2015-07-26T00:52:19Z","updated_at":"2015-10-17T21:00:17Z","pushed_at":"2015-10-21T07:50:39Z","git_url":"git://github.com/kvirc/KVIrc.git","ssh_url":"git@github.com:kvirc/KVIrc.git","clone_url":"https://github.com/kvirc/KVIrc.git","svn_url":"https://github.com/kvirc/KVIrc","homepage":"http://www.kvirc.net/","size":66404,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":212,"forks":14,"open_issues":212,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661"},"html":{"href":"https://github.com/kvirc/KVIrc/pull/1661"},"issue":{"href":"https://api.github.com/repos/kvirc/KVIrc/issues/1661"},"comments":{"href":"https://api.github.com/repos/kvirc/KVIrc/issues/1661/comments"},"review_comments":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661/comments"},"review_comment":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kvirc/KVIrc/pulls/1661/commits"},"statuses":{"href":"https://api.github.com/repos/kvirc/KVIrc/statuses/00caf93f436b6bf0fafa948b92ef3a4a7d954f70"}}}}