{"action":"closed","number":278,"pull_request":{"url":"https://api.github.com/repos/gaearon/redux/pulls/278","id":40187643,"html_url":"https://github.com/gaearon/redux/pull/278","diff_url":"https://github.com/gaearon/redux/pull/278.diff","patch_url":"https://github.com/gaearon/redux/pull/278.patch","issue_url":"https://api.github.com/repos/gaearon/redux/issues/278","number":278,"state":"closed","locked":false,"title":"WIP: tests for the examples","user":{"login":"sambs","id":51508,"avatar_url":"https://avatars.githubusercontent.com/u/51508?v=3","gravatar_id":"","url":"https://api.github.com/users/sambs","html_url":"https://github.com/sambs","followers_url":"https://api.github.com/users/sambs/followers","following_url":"https://api.github.com/users/sambs/following{/other_user}","gists_url":"https://api.github.com/users/sambs/gists{/gist_id}","starred_url":"https://api.github.com/users/sambs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambs/subscriptions","organizations_url":"https://api.github.com/users/sambs/orgs","repos_url":"https://api.github.com/users/sambs/repos","events_url":"https://api.github.com/users/sambs/events{/privacy}","received_events_url":"https://api.github.com/users/sambs/received_events","type":"User","site_admin":false},"body":"I thought I'd have a go at writing tests for the examples (Issue #157). Am I heading in the right direction?\r\n\r\nI separated out the creation of the store, so that I could more easily instantiate it in the actions tests... though maybe I should just be mocking the `dispatch` and `getState` and testing at a lower level?\r\n\r\nI also added an initialState prop to the App container as its pretty useful to be able to initiate the app in a given state ready for a specific test.","created_at":"2015-07-16T23:36:39Z","updated_at":"2015-07-31T10:56:31Z","closed_at":"2015-07-31T10:56:31Z","merged_at":null,"merge_commit_sha":"41752c02be2d06c1079b739e5524775ea287ec3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gaearon/redux/pulls/278/commits","review_comments_url":"https://api.github.com/repos/gaearon/redux/pulls/278/comments","review_comment_url":"https://api.github.com/repos/gaearon/redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gaearon/redux/issues/278/comments","statuses_url":"https://api.github.com/repos/gaearon/redux/statuses/67b44f02680c0e14ffbaad77ef17340092e184ec","head":{"label":"sambs:example-tests","ref":"example-tests","sha":"67b44f02680c0e14ffbaad77ef17340092e184ec","user":{"login":"sambs","id":51508,"avatar_url":"https://avatars.githubusercontent.com/u/51508?v=3","gravatar_id":"","url":"https://api.github.com/users/sambs","html_url":"https://github.com/sambs","followers_url":"https://api.github.com/users/sambs/followers","following_url":"https://api.github.com/users/sambs/following{/other_user}","gists_url":"https://api.github.com/users/sambs/gists{/gist_id}","starred_url":"https://api.github.com/users/sambs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambs/subscriptions","organizations_url":"https://api.github.com/users/sambs/orgs","repos_url":"https://api.github.com/users/sambs/repos","events_url":"https://api.github.com/users/sambs/events{/privacy}","received_events_url":"https://api.github.com/users/sambs/received_events","type":"User","site_admin":false},"repo":{"id":39210350,"name":"redux","full_name":"sambs/redux","owner":{"login":"sambs","id":51508,"avatar_url":"https://avatars.githubusercontent.com/u/51508?v=3","gravatar_id":"","url":"https://api.github.com/users/sambs","html_url":"https://github.com/sambs","followers_url":"https://api.github.com/users/sambs/followers","following_url":"https://api.github.com/users/sambs/following{/other_user}","gists_url":"https://api.github.com/users/sambs/gists{/gist_id}","starred_url":"https://api.github.com/users/sambs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambs/subscriptions","organizations_url":"https://api.github.com/users/sambs/orgs","repos_url":"https://api.github.com/users/sambs/repos","events_url":"https://api.github.com/users/sambs/events{/privacy}","received_events_url":"https://api.github.com/users/sambs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sambs/redux","description":"Atomic Flux with hot reloading","fork":true,"url":"https://api.github.com/repos/sambs/redux","forks_url":"https://api.github.com/repos/sambs/redux/forks","keys_url":"https://api.github.com/repos/sambs/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambs/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambs/redux/teams","hooks_url":"https://api.github.com/repos/sambs/redux/hooks","issue_events_url":"https://api.github.com/repos/sambs/redux/issues/events{/number}","events_url":"https://api.github.com/repos/sambs/redux/events","assignees_url":"https://api.github.com/repos/sambs/redux/assignees{/user}","branches_url":"https://api.github.com/repos/sambs/redux/branches{/branch}","tags_url":"https://api.github.com/repos/sambs/redux/tags","blobs_url":"https://api.github.com/repos/sambs/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambs/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambs/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambs/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambs/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/sambs/redux/languages","stargazers_url":"https://api.github.com/repos/sambs/redux/stargazers","contributors_url":"https://api.github.com/repos/sambs/redux/contributors","subscribers_url":"https://api.github.com/repos/sambs/redux/subscribers","subscription_url":"https://api.github.com/repos/sambs/redux/subscription","commits_url":"https://api.github.com/repos/sambs/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambs/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambs/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambs/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambs/redux/contents/{+path}","compare_url":"https://api.github.com/repos/sambs/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambs/redux/merges","archive_url":"https://api.github.com/repos/sambs/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambs/redux/downloads","issues_url":"https://api.github.com/repos/sambs/redux/issues{/number}","pulls_url":"https://api.github.com/repos/sambs/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/sambs/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/sambs/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambs/redux/labels{/name}","releases_url":"https://api.github.com/repos/sambs/redux/releases{/id}","created_at":"2015-07-16T17:18:01Z","updated_at":"2015-07-16T17:18:02Z","pushed_at":"2015-07-31T10:49:37Z","git_url":"git://github.com/sambs/redux.git","ssh_url":"git@github.com:sambs/redux.git","clone_url":"https://github.com/sambs/redux.git","svn_url":"https://github.com/sambs/redux","homepage":"https://medium.com/@dan_abramov/the-evolution-of-flux-frameworks-6c16ad26bb31","size":494,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gaearon:breaking-changes-1.0","ref":"breaking-changes-1.0","sha":"3cfdd730f5346b64033e89db92dc4205fd0e4c4d","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"repo":{"id":36535156,"name":"redux","full_name":"gaearon/redux","owner":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaearon/redux","description":"Predictable state container for JavaScript apps","fork":false,"url":"https://api.github.com/repos/gaearon/redux","forks_url":"https://api.github.com/repos/gaearon/redux/forks","keys_url":"https://api.github.com/repos/gaearon/redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaearon/redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaearon/redux/teams","hooks_url":"https://api.github.com/repos/gaearon/redux/hooks","issue_events_url":"https://api.github.com/repos/gaearon/redux/issues/events{/number}","events_url":"https://api.github.com/repos/gaearon/redux/events","assignees_url":"https://api.github.com/repos/gaearon/redux/assignees{/user}","branches_url":"https://api.github.com/repos/gaearon/redux/branches{/branch}","tags_url":"https://api.github.com/repos/gaearon/redux/tags","blobs_url":"https://api.github.com/repos/gaearon/redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaearon/redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaearon/redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaearon/redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaearon/redux/statuses/{sha}","languages_url":"https://api.github.com/repos/gaearon/redux/languages","stargazers_url":"https://api.github.com/repos/gaearon/redux/stargazers","contributors_url":"https://api.github.com/repos/gaearon/redux/contributors","subscribers_url":"https://api.github.com/repos/gaearon/redux/subscribers","subscription_url":"https://api.github.com/repos/gaearon/redux/subscription","commits_url":"https://api.github.com/repos/gaearon/redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaearon/redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaearon/redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaearon/redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaearon/redux/contents/{+path}","compare_url":"https://api.github.com/repos/gaearon/redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaearon/redux/merges","archive_url":"https://api.github.com/repos/gaearon/redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaearon/redux/downloads","issues_url":"https://api.github.com/repos/gaearon/redux/issues{/number}","pulls_url":"https://api.github.com/repos/gaearon/redux/pulls{/number}","milestones_url":"https://api.github.com/repos/gaearon/redux/milestones{/number}","notifications_url":"https://api.github.com/repos/gaearon/redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaearon/redux/labels{/name}","releases_url":"https://api.github.com/repos/gaearon/redux/releases{/id}","created_at":"2015-05-29T23:53:15Z","updated_at":"2015-07-31T10:48:19Z","pushed_at":"2015-07-31T10:53:42Z","git_url":"git://github.com/gaearon/redux.git","ssh_url":"git@github.com:gaearon/redux.git","clone_url":"https://github.com/gaearon/redux.git","svn_url":"https://github.com/gaearon/redux","homepage":"","size":5467,"stargazers_count":3253,"watchers_count":3253,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":212,"mirror_url":null,"open_issues_count":40,"forks":212,"open_issues":40,"watchers":3253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gaearon/redux/pulls/278"},"html":{"href":"https://github.com/gaearon/redux/pull/278"},"issue":{"href":"https://api.github.com/repos/gaearon/redux/issues/278"},"comments":{"href":"https://api.github.com/repos/gaearon/redux/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/gaearon/redux/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/gaearon/redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gaearon/redux/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/gaearon/redux/statuses/67b44f02680c0e14ffbaad77ef17340092e184ec"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":3,"commits":11,"additions":989,"deletions":12,"changed_files":19}}