{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/11225","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11225/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11225/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11225/events","html_url":"https://github.com/cms-sw/cmssw/pull/11225","id":105826282,"number":11225,"title":"change wrong input tag back to pMinRBXRechitR45EnergyFraction","user":{"login":"allenji","id":8128104,"avatar_url":"https://avatars.githubusercontent.com/u/8128104?v=3","gravatar_id":"","url":"https://api.github.com/users/allenji","html_url":"https://github.com/allenji","followers_url":"https://api.github.com/users/allenji/followers","following_url":"https://api.github.com/users/allenji/following{/other_user}","gists_url":"https://api.github.com/users/allenji/gists{/gist_id}","starred_url":"https://api.github.com/users/allenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenji/subscriptions","organizations_url":"https://api.github.com/users/allenji/orgs","repos_url":"https://api.github.com/users/allenji/repos","events_url":"https://api.github.com/users/allenji/events{/privacy}","received_events_url":"https://api.github.com/users/allenji/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":620,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-09-14T19:46:07Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2015-09-10T14:50:25Z","updated_at":"2015-09-14T21:12:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11225","html_url":"https://github.com/cms-sw/cmssw/pull/11225","diff_url":"https://github.com/cms-sw/cmssw/pull/11225.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11225.patch"},"body":"Hi,\r\n\r\nThe input tag in the IF condition is different from that used in the statement following IF. They should be both \"pMinRBXRechitR45EnergyFraction\", as set by the config file:\r\nhttps://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/RecoMET/METProducers/python/hcalnoiseinfoproducer_cfi.py#L36\r\n\r\nThe consequence caused by this inconsistency is that HcalNoiseAlgo::isProblematic(...) function will always returns true:https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/RecoMET/METAlgorithms/src/HcalNoiseAlgo.cc#L203\r\n\r\nThus in the RECO step, the RecoMET/METProducers/src/HcalNoiseInfoProducer.cc will regard all RBXs as problematic and store them in the event. This will affect our analysis  since we just want to reach RBXs that are either problematic or of highest energy.\r\n\r\nMaybe it's too late to get this code changed in the current reconstruction, it will be helpful if it's fixed in future reReco of data.\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/140207360","html_url":"https://github.com/cms-sw/cmssw/pull/11225#issuecomment-140207360","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11225","id":140207360,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T21:12:45Z","updated_at":"2015-09-14T21:12:45Z","body":"+1\r\n\r\nfor https://github.com/cms-sw/cmssw/pull/11225\t1382b41\r\n- the old buggy code was looking for pMinRechitR45EnergyFraction which was never defined (not in the configs in the release) and as a result, the cut on pMinRBXRechitR45EnergyFraction was defaulted to 0 instead of 0.1\r\n- jenkins tests pass and comparisons with baseline show differences only in the hcal monitoring plots: the number of entries in the RBX plots is smaller now\r\n(from run1 workflow 1000)\r\n![wf1000_rbxenergy](https://cloud.githubusercontent.com/assets/4676718/9861938/36c2c932-5afb-11e5-87f9-2d8ee21d7fb9.png)\r\n(from run1 workflow 4.53 )\r\n![wf1000_rbxn](https://cloud.githubusercontent.com/assets/4676718/9861941/3a8f2858-5afb-11e5-8807-346b9261bfbc.png)\r\n"}}