{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/47536394","id":47536394,"diff_hunk":"@@ -51,12 +51,18 @@ do {\n         let builddir = Path.join(getenv(\"SWIFT_BUILD_PATH\") ?? Path.join(rootd, \".build\"), configuration.dirname)\n \n         for pkg in dependencies {\n-            try llbuild(srcroot: pkg.path, targets: try pkg.targets(), dependencies: dependencies, prefix: builddir, tmpdir: Path.join(builddir, \"\\(pkg.name).o\"), configuration: configuration)\n+\t\t\ttry llbuild(srcroot: pkg.path, targets: try pkg.targets(), dependencies: dependencies, prefix: builddir, tmpdir: Path.join(builddir, \"\\(pkg.name).o\"),\n+\t\t\t\tconfiguration: configuration,\n+\t\t\t\tcompileExtraArgs: manifest.package.cflags,\n+\t\t\t\tlinkExtraArgs: manifest.package.ldflags)\n         }\n \n         do {\n             // build the current directory\n-            try llbuild(srcroot: rootd, targets: targets, dependencies: dependencies, prefix: builddir, tmpdir: Path.join(builddir, \"\\(pkgname).o\"), configuration: configuration)\n+            try llbuild(srcroot: rootd, targets: targets, dependencies: dependencies, prefix: builddir, tmpdir: Path.join(builddir, \"\\(pkgname).o\"),\n+\t\t\t\tconfiguration: configuration,\n+\t\t\t\tcompileExtraArgs: manifest.package.cflags,\n+\t\t\t\tlinkExtraArgs: manifest.package.ldflags)","path":"Sources/swift-build/main.swift","position":17,"original_position":17,"commit_id":"d294678f67136441177dcb19df176ad5aa4e56b8","original_commit_id":"d294678f67136441177dcb19df176ad5aa4e56b8","user":{"login":"Danappelxx","id":3291251,"avatar_url":"https://avatars.githubusercontent.com/u/3291251?v=3","gravatar_id":"","url":"https://api.github.com/users/Danappelxx","html_url":"https://github.com/Danappelxx","followers_url":"https://api.github.com/users/Danappelxx/followers","following_url":"https://api.github.com/users/Danappelxx/following{/other_user}","gists_url":"https://api.github.com/users/Danappelxx/gists{/gist_id}","starred_url":"https://api.github.com/users/Danappelxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danappelxx/subscriptions","organizations_url":"https://api.github.com/users/Danappelxx/orgs","repos_url":"https://api.github.com/users/Danappelxx/repos","events_url":"https://api.github.com/users/Danappelxx/events{/privacy}","received_events_url":"https://api.github.com/users/Danappelxx/received_events","type":"User","site_admin":false},"body":"This is somewhat strange style. Perhaps you should make line breaks on each argument, rather than after the first 5?","created_at":"2015-12-14T18:30:21Z","updated_at":"2015-12-14T18:30:21Z","html_url":"https://github.com/apple/swift-package-manager/pull/73#discussion_r47536394","pull_request_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/47536394"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/73#discussion_r47536394"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/73","id":53501608,"html_url":"https://github.com/apple/swift-package-manager/pull/73","diff_url":"https://github.com/apple/swift-package-manager/pull/73.diff","patch_url":"https://github.com/apple/swift-package-manager/pull/73.patch","issue_url":"https://api.github.com/repos/apple/swift-package-manager/issues/73","number":73,"state":"open","locked":false,"title":"pass extra header and library search path to swift-build","user":{"login":"OutOfBedlam","id":7237878,"avatar_url":"https://avatars.githubusercontent.com/u/7237878?v=3","gravatar_id":"","url":"https://api.github.com/users/OutOfBedlam","html_url":"https://github.com/OutOfBedlam","followers_url":"https://api.github.com/users/OutOfBedlam/followers","following_url":"https://api.github.com/users/OutOfBedlam/following{/other_user}","gists_url":"https://api.github.com/users/OutOfBedlam/gists{/gist_id}","starred_url":"https://api.github.com/users/OutOfBedlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutOfBedlam/subscriptions","organizations_url":"https://api.github.com/users/OutOfBedlam/orgs","repos_url":"https://api.github.com/users/OutOfBedlam/repos","events_url":"https://api.github.com/users/OutOfBedlam/events{/privacy}","received_events_url":"https://api.github.com/users/OutOfBedlam/received_events","type":"User","site_admin":false},"body":"make swift-build to receive extra header and library path\r\n\r\n- add header search path (--headers paths_separated_by_colon)\r\n- add lib search path (--libs paths_separated_by_colon)\r\n\r\n```sh\r\nswift build --headers /usr/include/glib-2.0:/usr/lib/x86_64-linux-gnu/glib-2.0/include \\\r\n            --libs /lib/x86_64-linux-gnu/\r\n```","created_at":"2015-12-13T15:00:39Z","updated_at":"2015-12-14T18:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"181b1d3e70e9e1b59250e5e293933872fad54e21","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/73/commits","review_comments_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/73/comments","review_comment_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/issues/73/comments","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/d294678f67136441177dcb19df176ad5aa4e56b8","head":{"label":"OutOfBedlam:master","ref":"master","sha":"d294678f67136441177dcb19df176ad5aa4e56b8","user":{"login":"OutOfBedlam","id":7237878,"avatar_url":"https://avatars.githubusercontent.com/u/7237878?v=3","gravatar_id":"","url":"https://api.github.com/users/OutOfBedlam","html_url":"https://github.com/OutOfBedlam","followers_url":"https://api.github.com/users/OutOfBedlam/followers","following_url":"https://api.github.com/users/OutOfBedlam/following{/other_user}","gists_url":"https://api.github.com/users/OutOfBedlam/gists{/gist_id}","starred_url":"https://api.github.com/users/OutOfBedlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutOfBedlam/subscriptions","organizations_url":"https://api.github.com/users/OutOfBedlam/orgs","repos_url":"https://api.github.com/users/OutOfBedlam/repos","events_url":"https://api.github.com/users/OutOfBedlam/events{/privacy}","received_events_url":"https://api.github.com/users/OutOfBedlam/received_events","type":"User","site_admin":false},"repo":{"id":47871872,"name":"swift-package-manager","full_name":"OutOfBedlam/swift-package-manager","owner":{"login":"OutOfBedlam","id":7237878,"avatar_url":"https://avatars.githubusercontent.com/u/7237878?v=3","gravatar_id":"","url":"https://api.github.com/users/OutOfBedlam","html_url":"https://github.com/OutOfBedlam","followers_url":"https://api.github.com/users/OutOfBedlam/followers","following_url":"https://api.github.com/users/OutOfBedlam/following{/other_user}","gists_url":"https://api.github.com/users/OutOfBedlam/gists{/gist_id}","starred_url":"https://api.github.com/users/OutOfBedlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutOfBedlam/subscriptions","organizations_url":"https://api.github.com/users/OutOfBedlam/orgs","repos_url":"https://api.github.com/users/OutOfBedlam/repos","events_url":"https://api.github.com/users/OutOfBedlam/events{/privacy}","received_events_url":"https://api.github.com/users/OutOfBedlam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OutOfBedlam/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":true,"url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager","forks_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/forks","keys_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/events","assignees_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/merges","archive_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/OutOfBedlam/swift-package-manager/releases{/id}","created_at":"2015-12-12T09:15:19Z","updated_at":"2015-12-12T09:15:20Z","pushed_at":"2015-12-14T12:50:19Z","git_url":"git://github.com/OutOfBedlam/swift-package-manager.git","ssh_url":"git@github.com:OutOfBedlam/swift-package-manager.git","clone_url":"https://github.com/OutOfBedlam/swift-package-manager.git","svn_url":"https://github.com/OutOfBedlam/swift-package-manager","homepage":"","size":340,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"3780a2cd4e4352627d5e6971d3b538d1a0822987","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44840041,"name":"swift-package-manager","full_name":"apple/swift-package-manager","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift-package-manager","forks_url":"https://api.github.com/repos/apple/swift-package-manager/forks","keys_url":"https://api.github.com/repos/apple/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/apple/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-package-manager/events","assignees_url":"https://api.github.com/repos/apple/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/apple/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/apple/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/apple/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-package-manager/merges","archive_url":"https://api.github.com/repos/apple/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/apple/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-package-manager/releases{/id}","created_at":"2015-10-23T21:41:12Z","updated_at":"2015-12-14T16:55:37Z","pushed_at":"2015-12-14T12:50:19Z","git_url":"git://github.com/apple/swift-package-manager.git","ssh_url":"git@github.com:apple/swift-package-manager.git","clone_url":"https://github.com/apple/swift-package-manager.git","svn_url":"https://github.com/apple/swift-package-manager","homepage":"","size":401,"stargazers_count":2824,"watchers_count":2824,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":181,"mirror_url":null,"open_issues_count":7,"forks":181,"open_issues":7,"watchers":2824,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/73"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/73"},"issue":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/73"},"comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-package-manager/statuses/d294678f67136441177dcb19df176ad5aa4e56b8"}}}}