{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/40477747","id":40477747,"diff_hunk":"@@ -0,0 +1,74 @@\n+// Copyright Joyent, Inc. and other Node contributors.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a\n+// copy of this software and associated documentation files (the\n+// \"Software\"), to deal in the Software without restriction, including\n+// without limitation the rights to use, copy, modify, merge, publish,\n+// distribute, sublicense, and/or sell copies of the Software, and to permit\n+// persons to whom the Software is furnished to do so, subject to the\n+// following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included\n+// in all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS\n+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN\n+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,\n+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE\n+// USE OR OTHER DEALINGS IN THE SOFTWARE.\n+\n+/*\n+ * The goal of this test is to make sure that when a top-level error\n+ * handler throws an error following the handling of a previous error,\n+ * the process reports the error message from the error thrown in the\n+ * top-level error handler, not the one from the previous error.\n+ */\n+\n+var domainErrHandlerExMessage = 'exception from domain error handler';","path":"test/parallel/test-domain-top-level-error-handler-throw.js","position":30,"original_position":29,"commit_id":"b17d13b0d69f9647f1092dcfb02cbf932e05b959","original_commit_id":"f0c0c30c8a92333305e090ff7b70057cc0f5be9f","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"body":"Will do.","created_at":"2015-09-25T21:31:59Z","updated_at":"2015-09-25T21:31:59Z","html_url":"https://github.com/nodejs/node/pull/3036#discussion_r40477747","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3036","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/40477747"},"html":{"href":"https://github.com/nodejs/node/pull/3036#discussion_r40477747"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3036"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3036","id":45850887,"html_url":"https://github.com/nodejs/node/pull/3036","diff_url":"https://github.com/nodejs/node/pull/3036.diff","patch_url":"https://github.com/nodejs/node/pull/3036.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3036","number":3036,"state":"open","locked":false,"title":"src: fix --abort-on-uncaught-exception","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"body":"Revert 0af4c9ea7434e4f505dbe071357e4bc3b4ab2a8a, parts of\r\n921f2de6cf999b5a4663615e37967b4269d755fe and port\r\nhttps://github.com/nodejs/node-v0.x-archive/pull/25835 from v0.12 to\r\nmaster so that node aborts at the right time when an error is thrown\r\nand --abort-on-uncaught-exception is used.\r\n\r\nThis change floats a patch on top of V8 that has not been submitted\r\nupstream. If this change turns out to be the preferred approach to fix\r\nissue #3035, the V8 related changes will be submitted upstream.\r\n\r\nFixes #3035.","created_at":"2015-09-24T01:33:16Z","updated_at":"2015-09-25T21:31:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4729adc3ce72d3d99c559368bc1ae7d58c8ddbca","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3036/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3036/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3036/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/b17d13b0d69f9647f1092dcfb02cbf932e05b959","head":{"label":"misterdjules:fix-abort-on-uncaught-exception","ref":"fix-abort-on-uncaught-exception","sha":"b17d13b0d69f9647f1092dcfb02cbf932e05b959","user":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"repo":{"id":41706362,"name":"node-1","full_name":"misterdjules/node-1","owner":{"login":"misterdjules","id":811047,"avatar_url":"https://avatars.githubusercontent.com/u/811047?v=3","gravatar_id":"","url":"https://api.github.com/users/misterdjules","html_url":"https://github.com/misterdjules","followers_url":"https://api.github.com/users/misterdjules/followers","following_url":"https://api.github.com/users/misterdjules/following{/other_user}","gists_url":"https://api.github.com/users/misterdjules/gists{/gist_id}","starred_url":"https://api.github.com/users/misterdjules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misterdjules/subscriptions","organizations_url":"https://api.github.com/users/misterdjules/orgs","repos_url":"https://api.github.com/users/misterdjules/repos","events_url":"https://api.github.com/users/misterdjules/events{/privacy}","received_events_url":"https://api.github.com/users/misterdjules/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misterdjules/node-1","description":"✨Future Node.js releases will be from this repo. ✨","fork":true,"url":"https://api.github.com/repos/misterdjules/node-1","forks_url":"https://api.github.com/repos/misterdjules/node-1/forks","keys_url":"https://api.github.com/repos/misterdjules/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misterdjules/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misterdjules/node-1/teams","hooks_url":"https://api.github.com/repos/misterdjules/node-1/hooks","issue_events_url":"https://api.github.com/repos/misterdjules/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/misterdjules/node-1/events","assignees_url":"https://api.github.com/repos/misterdjules/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/misterdjules/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/misterdjules/node-1/tags","blobs_url":"https://api.github.com/repos/misterdjules/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misterdjules/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misterdjules/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/misterdjules/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misterdjules/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/misterdjules/node-1/languages","stargazers_url":"https://api.github.com/repos/misterdjules/node-1/stargazers","contributors_url":"https://api.github.com/repos/misterdjules/node-1/contributors","subscribers_url":"https://api.github.com/repos/misterdjules/node-1/subscribers","subscription_url":"https://api.github.com/repos/misterdjules/node-1/subscription","commits_url":"https://api.github.com/repos/misterdjules/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/misterdjules/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/misterdjules/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/misterdjules/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/misterdjules/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/misterdjules/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misterdjules/node-1/merges","archive_url":"https://api.github.com/repos/misterdjules/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misterdjules/node-1/downloads","issues_url":"https://api.github.com/repos/misterdjules/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/misterdjules/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/misterdjules/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/misterdjules/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misterdjules/node-1/labels{/name}","releases_url":"https://api.github.com/repos/misterdjules/node-1/releases{/id}","created_at":"2015-08-31T23:49:01Z","updated_at":"2015-08-31T23:49:07Z","pushed_at":"2015-09-25T21:13:20Z","git_url":"git://github.com/misterdjules/node-1.git","ssh_url":"git@github.com:misterdjules/node-1.git","clone_url":"https://github.com/misterdjules/node-1.git","svn_url":"https://github.com/misterdjules/node-1","homepage":"https://iojs.org","size":149108,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"02448c69de580620e20b520e4f3eba6081873c61","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"✨Node.js  ✨","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-09-25T20:41:41Z","pushed_at":"2015-09-25T21:13:20Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":337268,"stargazers_count":15486,"watchers_count":15486,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1388,"mirror_url":null,"open_issues_count":465,"forks":1388,"open_issues":465,"watchers":15486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3036"},"html":{"href":"https://github.com/nodejs/node/pull/3036"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3036"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3036/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3036/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3036/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/b17d13b0d69f9647f1092dcfb02cbf932e05b959"}}}}