{"action":"created","issue":{"url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/7","labels_url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/7/comments","events_url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/7/events","html_url":"https://github.com/robertklep/ToggleProxy/pull/7","id":106289756,"number":7,"title":"Env var + refresh bug + ip change + no connection","user":{"login":"arnaudruffin","id":2727108,"avatar_url":"https://avatars.githubusercontent.com/u/2727108?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaudruffin","html_url":"https://github.com/arnaudruffin","followers_url":"https://api.github.com/users/arnaudruffin/followers","following_url":"https://api.github.com/users/arnaudruffin/following{/other_user}","gists_url":"https://api.github.com/users/arnaudruffin/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaudruffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaudruffin/subscriptions","organizations_url":"https://api.github.com/users/arnaudruffin/orgs","repos_url":"https://api.github.com/users/arnaudruffin/repos","events_url":"https://api.github.com/users/arnaudruffin/events{/privacy}","received_events_url":"https://api.github.com/users/arnaudruffin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-14T07:59:35Z","updated_at":"2015-09-15T13:14:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robertklep/ToggleProxy/pulls/7","html_url":"https://github.com/robertklep/ToggleProxy/pull/7","diff_url":"https://github.com/robertklep/ToggleProxy/pull/7.diff","patch_url":"https://github.com/robertklep/ToggleProxy/pull/7.patch"},"body":"Hello Robert\r\n\r\nAs mentionned in my mail, here are some modifications.\r\nMy first goal was to add the setting of environment variables (HTTP_PROXY....) so that app like Terminal could also benefit from the proxy settings. I fixed a pb with menu icons on dark themes (and took the liberty of changing the icons). I've also added a watcher on ip changes (in case you go from on interface to the other, or change your network location) and handle cases where you got no connection.\r\n\r\nUnfortunately I didn't  add time to investigate keychain access (to store password) and add a \"All proxies\" item in the menu. Maybe some other time\r\n\r\nRegards\r\nArnaud"},"comment":{"url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/comments/140384231","html_url":"https://github.com/robertklep/ToggleProxy/pull/7#issuecomment-140384231","issue_url":"https://api.github.com/repos/robertklep/ToggleProxy/issues/7","id":140384231,"user":{"login":"arnaudruffin","id":2727108,"avatar_url":"https://avatars.githubusercontent.com/u/2727108?v=3","gravatar_id":"","url":"https://api.github.com/users/arnaudruffin","html_url":"https://github.com/arnaudruffin","followers_url":"https://api.github.com/users/arnaudruffin/followers","following_url":"https://api.github.com/users/arnaudruffin/following{/other_user}","gists_url":"https://api.github.com/users/arnaudruffin/gists{/gist_id}","starred_url":"https://api.github.com/users/arnaudruffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnaudruffin/subscriptions","organizations_url":"https://api.github.com/users/arnaudruffin/orgs","repos_url":"https://api.github.com/users/arnaudruffin/repos","events_url":"https://api.github.com/users/arnaudruffin/events{/privacy}","received_events_url":"https://api.github.com/users/arnaudruffin/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T13:14:12Z","updated_at":"2015-09-15T13:14:12Z","body":"ok, I will have a look."}}