{"action":"created","issue":{"url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/1","labels_url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/1/comments","events_url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/1/events","html_url":"https://github.com/holic/basscss-color-lighten/issues/1","id":94947690,"number":1,"title":"Thoughts/Feedback","user":{"login":"jxnblk","id":3451712,"avatar_url":"https://avatars.githubusercontent.com/u/3451712?v=3","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-14T13:42:26Z","updated_at":"2015-07-15T18:42:47Z","closed_at":null,"body":"Hey, thanks for putting this together – just wanted to share some thoughts and feedback.\r\n\r\n1. Although it's not documented, I've split up the color modules by property in v7. See https://github.com/basscss/background-colors and https://github.com/basscss/border-colors – it would be good to follow a similar organization, but I'm open to splitting the darken and lighten modules apart from the core colors.\r\n\r\n2. I'm not sure I see the value in the `.lighten-x` styles for foreground colors. It seems like it would cause color contrast issues and set people up for making mistakes (i.e. low-contrast type) in their designs. There is already a `.muted` style to adjust opacity for text.\r\n\r\n3. Would you eventually want to pass ownership of this module to the Basscss org? There's a few private scripts that I use to manage everything, and I wouldn't want this module to get left behind (Although it does seem fairly feature complete already).\r\n\r\n4. Just putting this out there as an alternative: you could also make a pull request for the background-colors and border-colors modules, including these styles in each one.\r\n"},"comment":{"url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/comments/121708909","html_url":"https://github.com/holic/basscss-color-lighten/issues/1#issuecomment-121708909","issue_url":"https://api.github.com/repos/holic/basscss-color-lighten/issues/1","id":121708909,"user":{"login":"jxnblk","id":3451712,"avatar_url":"https://avatars.githubusercontent.com/u/3451712?v=3","gravatar_id":"","url":"https://api.github.com/users/jxnblk","html_url":"https://github.com/jxnblk","followers_url":"https://api.github.com/users/jxnblk/followers","following_url":"https://api.github.com/users/jxnblk/following{/other_user}","gists_url":"https://api.github.com/users/jxnblk/gists{/gist_id}","starred_url":"https://api.github.com/users/jxnblk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jxnblk/subscriptions","organizations_url":"https://api.github.com/users/jxnblk/orgs","repos_url":"https://api.github.com/users/jxnblk/repos","events_url":"https://api.github.com/users/jxnblk/events{/privacy}","received_events_url":"https://api.github.com/users/jxnblk/received_events","type":"User","site_admin":false},"created_at":"2015-07-15T18:42:46Z","updated_at":"2015-07-15T18:42:46Z","body":"Good to know. I think the pull request approach would be the best route to go for now.\r\n\r\nAs far as using the lighten utilities for foreground text, this is similar to the reason why I haven't included darken utilities as foreground colors. With the scale of alpha values being used here, there's almost no way that text would have enough contrast to be readable.\r\n\r\nI think the lighten utilities could be added to background-colors and border-colors, but for use as a foreground color, these would require higher alpha values.\r\n\r\nAs next steps, I'd say:\r\n1. Make pull requests for the background-color and border-color modules, then I'll merge then in.\r\n2. (If you want to) Make a separate pull request for foreground colors with higher alpha values, along with screenshot demonstrations and color contrast values against a few different background colors. I want to be sure that using Basscss doesn't easily result in color combinations with contrast lower than 4.5."}}