{"action":"created","comment":{"url":"https://api.github.com/repos/scala/scala/pulls/comments/31062741","id":31062741,"diff_hunk":"@@ -1487,6 +1486,8 @@ class Global(var currentSettings: Settings, var reporter: Reporter)\n       compileUnitsInternal(units, fromPhase)\n \n     private def compileUnitsInternal(units: List[CompilationUnit], fromPhase: Phase) {\n+      def currentTime = java.util.concurrent.TimeUnit.NANOSECONDS.toMillis(System.nanoTime())\n+","path":"src/compiler/scala/tools/nsc/Global.scala","position":13,"original_position":13,"commit_id":"f26afec0c1f20ce9fbe51b0c7994cdc5264f57df","original_commit_id":"f26afec0c1f20ce9fbe51b0c7994cdc5264f57df","user":{"login":"soc","id":42493,"avatar_url":"https://avatars.githubusercontent.com/u/42493?v=3","gravatar_id":"","url":"https://api.github.com/users/soc","html_url":"https://github.com/soc","followers_url":"https://api.github.com/users/soc/followers","following_url":"https://api.github.com/users/soc/following{/other_user}","gists_url":"https://api.github.com/users/soc/gists{/gist_id}","starred_url":"https://api.github.com/users/soc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soc/subscriptions","organizations_url":"https://api.github.com/users/soc/orgs","repos_url":"https://api.github.com/users/soc/repos","events_url":"https://api.github.com/users/soc/events{/privacy}","received_events_url":"https://api.github.com/users/soc/received_events","type":"User","site_admin":false},"body":"Wouldn't it make more sense to just change `val startTime` instead of introducing a single-use method?","created_at":"2015-05-26T18:15:20Z","updated_at":"2015-05-26T18:15:20Z","html_url":"https://github.com/scala/scala/pull/4511#discussion_r31062741","pull_request_url":"https://api.github.com/repos/scala/scala/pulls/4511","_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/comments/31062741"},"html":{"href":"https://github.com/scala/scala/pull/4511#discussion_r31062741"},"pull_request":{"href":"https://api.github.com/repos/scala/scala/pulls/4511"}}},"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/4511","id":35871559,"html_url":"https://github.com/scala/scala/pull/4511","diff_url":"https://github.com/scala/scala/pull/4511.diff","patch_url":"https://github.com/scala/scala/pull/4511.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/4511","number":4511,"state":"open","locked":false,"title":"SI-9322 Elapsed times in compiler calculated with System.currentTimeMillis and System.nanoTime","user":{"login":"sriggin","id":3334374,"avatar_url":"https://avatars.githubusercontent.com/u/3334374?v=3","gravatar_id":"","url":"https://api.github.com/users/sriggin","html_url":"https://github.com/sriggin","followers_url":"https://api.github.com/users/sriggin/followers","following_url":"https://api.github.com/users/sriggin/following{/other_user}","gists_url":"https://api.github.com/users/sriggin/gists{/gist_id}","starred_url":"https://api.github.com/users/sriggin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriggin/subscriptions","organizations_url":"https://api.github.com/users/sriggin/orgs","repos_url":"https://api.github.com/users/sriggin/repos","events_url":"https://api.github.com/users/sriggin/events{/privacy}","received_events_url":"https://api.github.com/users/sriggin/received_events","type":"User","site_admin":false},"body":"Changing this bit of code back seemed to fix the negative timestamps I was seeing in scalac's verbose output:\r\n\r\n> [loaded package loader resources.jar in 440ms]\r\n> [loaded package loader java in 5ms]\r\n> [loaded package loader lang in 62ms]\r\n\r\nIt looks like it was originally changed to improve performance by eliminating a possible system call, but since this is wrapping steps in the compiler, I wouldn't think this would be too expensive to add back.","created_at":"2015-05-20T20:18:30Z","updated_at":"2015-05-26T18:15:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6156dc79336bf346df0576dbe47af8efa6086860","assignee":null,"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/48","html_url":"https://github.com/scala/scala/milestones/2.11.7","labels_url":"https://api.github.com/repos/scala/scala/milestones/48/labels","id":985497,"number":48,"title":"2.11.7","description":"Merge to 2.11.x.\r\n","creator":{"login":"adriaanm","id":91083,"avatar_url":"https://avatars.githubusercontent.com/u/91083?v=3","gravatar_id":"","url":"https://api.github.com/users/adriaanm","html_url":"https://github.com/adriaanm","followers_url":"https://api.github.com/users/adriaanm/followers","following_url":"https://api.github.com/users/adriaanm/following{/other_user}","gists_url":"https://api.github.com/users/adriaanm/gists{/gist_id}","starred_url":"https://api.github.com/users/adriaanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriaanm/subscriptions","organizations_url":"https://api.github.com/users/adriaanm/orgs","repos_url":"https://api.github.com/users/adriaanm/repos","events_url":"https://api.github.com/users/adriaanm/events{/privacy}","received_events_url":"https://api.github.com/users/adriaanm/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":119,"state":"open","created_at":"2015-02-19T00:12:20Z","updated_at":"2015-05-26T13:13:18Z","due_on":"2015-06-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scala/scala/pulls/4511/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/4511/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/4511/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/f26afec0c1f20ce9fbe51b0c7994cdc5264f57df","head":{"label":"sriggin:SI-9322","ref":"SI-9322","sha":"f26afec0c1f20ce9fbe51b0c7994cdc5264f57df","user":{"login":"sriggin","id":3334374,"avatar_url":"https://avatars.githubusercontent.com/u/3334374?v=3","gravatar_id":"","url":"https://api.github.com/users/sriggin","html_url":"https://github.com/sriggin","followers_url":"https://api.github.com/users/sriggin/followers","following_url":"https://api.github.com/users/sriggin/following{/other_user}","gists_url":"https://api.github.com/users/sriggin/gists{/gist_id}","starred_url":"https://api.github.com/users/sriggin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriggin/subscriptions","organizations_url":"https://api.github.com/users/sriggin/orgs","repos_url":"https://api.github.com/users/sriggin/repos","events_url":"https://api.github.com/users/sriggin/events{/privacy}","received_events_url":"https://api.github.com/users/sriggin/received_events","type":"User","site_admin":false},"repo":{"id":35965383,"name":"scala","full_name":"sriggin/scala","owner":{"login":"sriggin","id":3334374,"avatar_url":"https://avatars.githubusercontent.com/u/3334374?v=3","gravatar_id":"","url":"https://api.github.com/users/sriggin","html_url":"https://github.com/sriggin","followers_url":"https://api.github.com/users/sriggin/followers","following_url":"https://api.github.com/users/sriggin/following{/other_user}","gists_url":"https://api.github.com/users/sriggin/gists{/gist_id}","starred_url":"https://api.github.com/users/sriggin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sriggin/subscriptions","organizations_url":"https://api.github.com/users/sriggin/orgs","repos_url":"https://api.github.com/users/sriggin/repos","events_url":"https://api.github.com/users/sriggin/events{/privacy}","received_events_url":"https://api.github.com/users/sriggin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sriggin/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/sriggin/scala","forks_url":"https://api.github.com/repos/sriggin/scala/forks","keys_url":"https://api.github.com/repos/sriggin/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sriggin/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sriggin/scala/teams","hooks_url":"https://api.github.com/repos/sriggin/scala/hooks","issue_events_url":"https://api.github.com/repos/sriggin/scala/issues/events{/number}","events_url":"https://api.github.com/repos/sriggin/scala/events","assignees_url":"https://api.github.com/repos/sriggin/scala/assignees{/user}","branches_url":"https://api.github.com/repos/sriggin/scala/branches{/branch}","tags_url":"https://api.github.com/repos/sriggin/scala/tags","blobs_url":"https://api.github.com/repos/sriggin/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sriggin/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sriggin/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/sriggin/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sriggin/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/sriggin/scala/languages","stargazers_url":"https://api.github.com/repos/sriggin/scala/stargazers","contributors_url":"https://api.github.com/repos/sriggin/scala/contributors","subscribers_url":"https://api.github.com/repos/sriggin/scala/subscribers","subscription_url":"https://api.github.com/repos/sriggin/scala/subscription","commits_url":"https://api.github.com/repos/sriggin/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/sriggin/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/sriggin/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/sriggin/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/sriggin/scala/contents/{+path}","compare_url":"https://api.github.com/repos/sriggin/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sriggin/scala/merges","archive_url":"https://api.github.com/repos/sriggin/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sriggin/scala/downloads","issues_url":"https://api.github.com/repos/sriggin/scala/issues{/number}","pulls_url":"https://api.github.com/repos/sriggin/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/sriggin/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/sriggin/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sriggin/scala/labels{/name}","releases_url":"https://api.github.com/repos/sriggin/scala/releases{/id}","created_at":"2015-05-20T18:10:56Z","updated_at":"2015-05-20T18:11:14Z","pushed_at":"2015-05-22T16:45:44Z","git_url":"git://github.com/sriggin/scala.git","ssh_url":"git@github.com:sriggin/scala.git","clone_url":"https://github.com/sriggin/scala.git","svn_url":"https://github.com/sriggin/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"bb302833c7bad6ff7591cdf6d10ec7ffdf683d6a","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2015-05-26T14:14:15Z","pushed_at":"2015-05-26T17:45:17Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":4236,"watchers_count":4236,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1090,"mirror_url":null,"open_issues_count":16,"forks":1090,"open_issues":16,"watchers":4236,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/4511"},"html":{"href":"https://github.com/scala/scala/pull/4511"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/4511"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/4511/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/4511/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/4511/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/f26afec0c1f20ce9fbe51b0c7994cdc5264f57df"}}}}