{"action":"reopened","number":2508,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/2508","id":52038023,"html_url":"https://github.com/qgis/QGIS/pull/2508","diff_url":"https://github.com/qgis/QGIS/pull/2508.diff","patch_url":"https://github.com/qgis/QGIS/pull/2508.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/2508","number":2508,"state":"open","locked":false,"title":"Update rubber band after editing nodes","user":{"login":"dgoedkoop","id":7602407,"avatar_url":"https://avatars.githubusercontent.com/u/7602407?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoedkoop","html_url":"https://github.com/dgoedkoop","followers_url":"https://api.github.com/users/dgoedkoop/followers","following_url":"https://api.github.com/users/dgoedkoop/following{/other_user}","gists_url":"https://api.github.com/users/dgoedkoop/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoedkoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoedkoop/subscriptions","organizations_url":"https://api.github.com/users/dgoedkoop/orgs","repos_url":"https://api.github.com/users/dgoedkoop/repos","events_url":"https://api.github.com/users/dgoedkoop/events{/privacy}","received_events_url":"https://api.github.com/users/dgoedkoop/received_events","type":"User","site_admin":false},"body":"It is a nice new functionality that the node editor puts a rubber band on the feature currently being edited. However, so far this rubber band is not updated when the nodes of the feature are actually edited. This PR is to fix that.\r\n\r\nIt uses a geometryChanged signal rather than just adding updateSelectFeature() in a few places, because only in this way the rubber band is also correctly updated after an undo operation. It splits updateSelectFeature() into two parts, because the geometryChanged signal is emitted with the new (or in case of an undo: previous) geometry as a parameter, before the geometry of the feature is actually changed.","created_at":"2015-11-28T10:45:49Z","updated_at":"2015-12-16T07:33:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4c46e286207227b85ce32eb4865f666e2f07e33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/2508/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/2508/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/2508/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/85eba57618906e7270f0fd3af6690cc2b98c6601","head":{"label":"dgoedkoop:nodeeditorrubberband","ref":"nodeeditorrubberband","sha":"85eba57618906e7270f0fd3af6690cc2b98c6601","user":{"login":"dgoedkoop","id":7602407,"avatar_url":"https://avatars.githubusercontent.com/u/7602407?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoedkoop","html_url":"https://github.com/dgoedkoop","followers_url":"https://api.github.com/users/dgoedkoop/followers","following_url":"https://api.github.com/users/dgoedkoop/following{/other_user}","gists_url":"https://api.github.com/users/dgoedkoop/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoedkoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoedkoop/subscriptions","organizations_url":"https://api.github.com/users/dgoedkoop/orgs","repos_url":"https://api.github.com/users/dgoedkoop/repos","events_url":"https://api.github.com/users/dgoedkoop/events{/privacy}","received_events_url":"https://api.github.com/users/dgoedkoop/received_events","type":"User","site_admin":false},"repo":{"id":45744772,"name":"QGIS","full_name":"dgoedkoop/QGIS","owner":{"login":"dgoedkoop","id":7602407,"avatar_url":"https://avatars.githubusercontent.com/u/7602407?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoedkoop","html_url":"https://github.com/dgoedkoop","followers_url":"https://api.github.com/users/dgoedkoop/followers","following_url":"https://api.github.com/users/dgoedkoop/following{/other_user}","gists_url":"https://api.github.com/users/dgoedkoop/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoedkoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoedkoop/subscriptions","organizations_url":"https://api.github.com/users/dgoedkoop/orgs","repos_url":"https://api.github.com/users/dgoedkoop/repos","events_url":"https://api.github.com/users/dgoedkoop/events{/privacy}","received_events_url":"https://api.github.com/users/dgoedkoop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgoedkoop/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/dgoedkoop/QGIS","forks_url":"https://api.github.com/repos/dgoedkoop/QGIS/forks","keys_url":"https://api.github.com/repos/dgoedkoop/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgoedkoop/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgoedkoop/QGIS/teams","hooks_url":"https://api.github.com/repos/dgoedkoop/QGIS/hooks","issue_events_url":"https://api.github.com/repos/dgoedkoop/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/dgoedkoop/QGIS/events","assignees_url":"https://api.github.com/repos/dgoedkoop/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/dgoedkoop/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/dgoedkoop/QGIS/tags","blobs_url":"https://api.github.com/repos/dgoedkoop/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgoedkoop/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgoedkoop/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgoedkoop/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgoedkoop/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/dgoedkoop/QGIS/languages","stargazers_url":"https://api.github.com/repos/dgoedkoop/QGIS/stargazers","contributors_url":"https://api.github.com/repos/dgoedkoop/QGIS/contributors","subscribers_url":"https://api.github.com/repos/dgoedkoop/QGIS/subscribers","subscription_url":"https://api.github.com/repos/dgoedkoop/QGIS/subscription","commits_url":"https://api.github.com/repos/dgoedkoop/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgoedkoop/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgoedkoop/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgoedkoop/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgoedkoop/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/dgoedkoop/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgoedkoop/QGIS/merges","archive_url":"https://api.github.com/repos/dgoedkoop/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgoedkoop/QGIS/downloads","issues_url":"https://api.github.com/repos/dgoedkoop/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/dgoedkoop/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/dgoedkoop/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/dgoedkoop/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgoedkoop/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/dgoedkoop/QGIS/releases{/id}","created_at":"2015-11-07T16:41:55Z","updated_at":"2015-11-07T16:44:17Z","pushed_at":"2015-12-15T20:05:29Z","git_url":"git://github.com/dgoedkoop/QGIS.git","ssh_url":"git@github.com:dgoedkoop/QGIS.git","clone_url":"https://github.com/dgoedkoop/QGIS.git","svn_url":"https://github.com/dgoedkoop/QGIS","homepage":"http://qgis.org","size":1184299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"497191bf40cb9fdbbeef986dc4e19da50fe8059b","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","created_at":"2011-05-02T08:06:26Z","updated_at":"2015-12-16T05:35:20Z","pushed_at":"2015-12-16T00:10:15Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1211380,"stargazers_count":821,"watchers_count":821,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":754,"mirror_url":null,"open_issues_count":48,"forks":754,"open_issues":48,"watchers":821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2508"},"html":{"href":"https://github.com/qgis/QGIS/pull/2508"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2508"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/2508/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2508/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/2508/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/85eba57618906e7270f0fd3af6690cc2b98c6601"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":3,"commits":3,"additions":40,"deletions":13,"changed_files":2}}