{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/ava/pulls/comments/38823872","id":38823872,"diff_hunk":"@@ -1,8 +1,10 @@\n 'use strict';\n+var Promise = require('pinkie-promise');\n+var promisify = require('pify');\n var util = require('util');\n var EventEmitter = require('events').EventEmitter;\n-var each = require('each-async');\n-var eachSerial = require('async-each-series');\n+var each = promisify(require('each-async'), Promise);","path":"lib/runner.js","position":8,"original_position":8,"commit_id":"49f49a6023543b96640fd796c3437e1673f7163c","original_commit_id":"49f49a6023543b96640fd796c3437e1673f7163c","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"body":"Just use `Promise.all()`","created_at":"2015-09-06T17:36:31Z","updated_at":"2015-09-06T17:36:31Z","html_url":"https://github.com/sindresorhus/ava/pull/39#discussion_r38823872","pull_request_url":"https://api.github.com/repos/sindresorhus/ava/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/comments/38823872"},"html":{"href":"https://github.com/sindresorhus/ava/pull/39#discussion_r38823872"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/ava/pulls/39","id":44301871,"html_url":"https://github.com/sindresorhus/ava/pull/39","diff_url":"https://github.com/sindresorhus/ava/pull/39.diff","patch_url":"https://github.com/sindresorhus/ava/pull/39.patch","issue_url":"https://api.github.com/repos/sindresorhus/ava/issues/39","number":39,"state":"open","locked":false,"title":"Promisification","user":{"login":"vdemedes","id":697676,"avatar_url":"https://avatars.githubusercontent.com/u/697676?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemedes","html_url":"https://github.com/vdemedes","followers_url":"https://api.github.com/users/vdemedes/followers","following_url":"https://api.github.com/users/vdemedes/following{/other_user}","gists_url":"https://api.github.com/users/vdemedes/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemedes/subscriptions","organizations_url":"https://api.github.com/users/vdemedes/orgs","repos_url":"https://api.github.com/users/vdemedes/repos","events_url":"https://api.github.com/users/vdemedes/events{/privacy}","received_events_url":"https://api.github.com/users/vdemedes/received_events","type":"User","site_admin":false},"body":"This PR is related to #38. After this PR is complete and callbacks are removed to the maximum extent, AVA's code should be much cleaner.\r\n\r\n\r\n### Overview\r\n\r\nAs stated in #38, `pinkie-promise` and `pify` modules are used in this PR.\r\n\r\n### Changes\r\n\r\n- [x] Promisify `Runner.prototype.serial`\r\n- [x] Promisify `Runner.prototype.concurrent`\r\n- [x] Promisify `Runner.prototype.run`\r\n- [x] Promisify `Test.prototype.run`\r\n- [x] Use promises in tests\r\n\r\n\r\nAs usual, let me know what you think and let's discuss this!","created_at":"2015-09-06T12:29:09Z","updated_at":"2015-09-06T17:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92d235e93886d2a169766c79ed2d8d598be2e60e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/ava/pulls/39/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/ava/pulls/39/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/ava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/ava/issues/39/comments","statuses_url":"https://api.github.com/repos/sindresorhus/ava/statuses/49f49a6023543b96640fd796c3437e1673f7163c","head":{"label":"vdemedes:promisification","ref":"promisification","sha":"49f49a6023543b96640fd796c3437e1673f7163c","user":{"login":"vdemedes","id":697676,"avatar_url":"https://avatars.githubusercontent.com/u/697676?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemedes","html_url":"https://github.com/vdemedes","followers_url":"https://api.github.com/users/vdemedes/followers","following_url":"https://api.github.com/users/vdemedes/following{/other_user}","gists_url":"https://api.github.com/users/vdemedes/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemedes/subscriptions","organizations_url":"https://api.github.com/users/vdemedes/orgs","repos_url":"https://api.github.com/users/vdemedes/repos","events_url":"https://api.github.com/users/vdemedes/events{/privacy}","received_events_url":"https://api.github.com/users/vdemedes/received_events","type":"User","site_admin":false},"repo":{"id":41728524,"name":"ava","full_name":"vdemedes/ava","owner":{"login":"vdemedes","id":697676,"avatar_url":"https://avatars.githubusercontent.com/u/697676?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemedes","html_url":"https://github.com/vdemedes","followers_url":"https://api.github.com/users/vdemedes/followers","following_url":"https://api.github.com/users/vdemedes/following{/other_user}","gists_url":"https://api.github.com/users/vdemedes/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemedes/subscriptions","organizations_url":"https://api.github.com/users/vdemedes/orgs","repos_url":"https://api.github.com/users/vdemedes/repos","events_url":"https://api.github.com/users/vdemedes/events{/privacy}","received_events_url":"https://api.github.com/users/vdemedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemedes/ava","description":"Simple concurrent test runner","fork":true,"url":"https://api.github.com/repos/vdemedes/ava","forks_url":"https://api.github.com/repos/vdemedes/ava/forks","keys_url":"https://api.github.com/repos/vdemedes/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemedes/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemedes/ava/teams","hooks_url":"https://api.github.com/repos/vdemedes/ava/hooks","issue_events_url":"https://api.github.com/repos/vdemedes/ava/issues/events{/number}","events_url":"https://api.github.com/repos/vdemedes/ava/events","assignees_url":"https://api.github.com/repos/vdemedes/ava/assignees{/user}","branches_url":"https://api.github.com/repos/vdemedes/ava/branches{/branch}","tags_url":"https://api.github.com/repos/vdemedes/ava/tags","blobs_url":"https://api.github.com/repos/vdemedes/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemedes/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemedes/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemedes/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemedes/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemedes/ava/languages","stargazers_url":"https://api.github.com/repos/vdemedes/ava/stargazers","contributors_url":"https://api.github.com/repos/vdemedes/ava/contributors","subscribers_url":"https://api.github.com/repos/vdemedes/ava/subscribers","subscription_url":"https://api.github.com/repos/vdemedes/ava/subscription","commits_url":"https://api.github.com/repos/vdemedes/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemedes/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemedes/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemedes/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemedes/ava/contents/{+path}","compare_url":"https://api.github.com/repos/vdemedes/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemedes/ava/merges","archive_url":"https://api.github.com/repos/vdemedes/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemedes/ava/downloads","issues_url":"https://api.github.com/repos/vdemedes/ava/issues{/number}","pulls_url":"https://api.github.com/repos/vdemedes/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemedes/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemedes/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemedes/ava/labels{/name}","releases_url":"https://api.github.com/repos/vdemedes/ava/releases{/id}","created_at":"2015-09-01T09:08:19Z","updated_at":"2015-09-01T09:08:20Z","pushed_at":"2015-09-06T14:27:02Z","git_url":"git://github.com/vdemedes/ava.git","ssh_url":"git@github.com:vdemedes/ava.git","clone_url":"https://github.com/vdemedes/ava.git","svn_url":"https://github.com/vdemedes/ava","homepage":"","size":2736,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"0b3dab2a497d5aec35797a2ce0314200ee8749d0","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":26820798,"name":"ava","full_name":"sindresorhus/ava","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/ava","description":"Simple concurrent test runner","fork":false,"url":"https://api.github.com/repos/sindresorhus/ava","forks_url":"https://api.github.com/repos/sindresorhus/ava/forks","keys_url":"https://api.github.com/repos/sindresorhus/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/ava/teams","hooks_url":"https://api.github.com/repos/sindresorhus/ava/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/ava/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/ava/events","assignees_url":"https://api.github.com/repos/sindresorhus/ava/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/ava/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/ava/tags","blobs_url":"https://api.github.com/repos/sindresorhus/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/ava/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/ava/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/ava/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/ava/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/ava/subscription","commits_url":"https://api.github.com/repos/sindresorhus/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/ava/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/ava/merges","archive_url":"https://api.github.com/repos/sindresorhus/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/ava/downloads","issues_url":"https://api.github.com/repos/sindresorhus/ava/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/ava/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/ava/releases{/id}","created_at":"2014-11-18T17:20:26Z","updated_at":"2015-09-06T10:47:14Z","pushed_at":"2015-09-06T14:27:02Z","git_url":"git://github.com/sindresorhus/ava.git","ssh_url":"git@github.com:sindresorhus/ava.git","clone_url":"https://github.com/sindresorhus/ava.git","svn_url":"https://github.com/sindresorhus/ava","homepage":"","size":3124,"stargazers_count":325,"watchers_count":325,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":20,"forks":9,"open_issues":20,"watchers":325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/39"},"html":{"href":"https://github.com/sindresorhus/ava/pull/39"},"issue":{"href":"https://api.github.com/repos/sindresorhus/ava/issues/39"},"comments":{"href":"https://api.github.com/repos/sindresorhus/ava/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/ava/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/ava/statuses/49f49a6023543b96640fd796c3437e1673f7163c"}}}}