{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/30540604","id":30540604,"diff_hunk":"@@ -327,41 +332,68 @@ public void createAdapter(Id.Adapter id, AdapterConfig config) {\n       String.format(\"%s/adapters/%s\", getNamespacePath(id.getNamespaceId()), id.getId()));\n     request.setContent(ChannelBuffers.wrappedBuffer(GSON.toJson(config).getBytes(Charsets.UTF_8)));\n     MockResponder responder = new MockResponder();\n-    adapterHttpHandler.createAdapter(request, responder, id.getNamespaceId(), id.getId());\n-    verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to create adapter.\");\n+\n+    try {\n+      adapterHttpHandler.createAdapter(request, responder, id.getNamespaceId(), id.getId());\n+      verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to create adapter.\");\n+    } catch (Exception e) {\n+      LOG.error(\"Error creating adapter\", e);\n+    }\n   }\n \n   public void startAdapter(Id.Adapter id) {\n     DefaultHttpRequest request = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.POST,\n       String.format(\"%s/adapters/%s/start\", getNamespacePath(id.getNamespaceId()), id.getId()));\n     MockResponder responder = new MockResponder();\n-    adapterHttpHandler.startStopAdapter(request, responder, id.getNamespaceId(), id.getId(), \"start\");\n-    verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to start adapter.\");\n+\n+    try {\n+      adapterHttpHandler.startStopAdapter(request, responder, id.getNamespaceId(), id.getId(), \"start\");\n+      verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to start adapter.\");\n+    } catch (Exception e) {\n+      LOG.error(\"Error starting adapter\", e);\n+    }\n   }\n \n   public void stopAdapter(Id.Adapter id) {\n     DefaultHttpRequest request = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.POST,\n       String.format(\"%s/adapters/%s/stop\", getNamespacePath(id.getNamespaceId()), id.getId()));\n     MockResponder responder = new MockResponder();\n-    adapterHttpHandler.startStopAdapter(request, responder, id.getNamespaceId(), id.getId(), \"stop\");\n-    verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to stop adapter.\");\n+\n+    try {\n+      adapterHttpHandler.startStopAdapter(request, responder, id.getNamespaceId(), id.getId(), \"stop\");\n+      verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to stop adapter.\");\n+    } catch (Exception e) {\n+      LOG.error(\"Error stopping adapter\", e);\n+    }\n   }\n \n   public List<RunRecord> getAdapterRuns(Id.Adapter id) {\n     DefaultHttpRequest request = new DefaultHttpRequest(HttpVersion.HTTP_1_1, HttpMethod.GET,\n       String.format(\"%s/adapters/%s/runs\", getNamespacePath(id.getNamespaceId()), id.getId()));\n     MockResponder responder = new MockResponder();\n-    adapterHttpHandler.getAdapterRuns(request, responder, id.getNamespaceId(), id.getId(), null, null, null, 100);\n-    verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to get runs for adapter.\");\n-    return responder.decodeResponseContent(RUN_RECORDS_TYPE);\n+\n+    try {\n+      adapterHttpHandler.getAdapterRuns(request, responder, id.getNamespaceId(), id.getId(), null, null, null, 100);\n+      verifyResponse(HttpResponseStatus.valueOf(200), responder.getStatus(), \"Failed to get runs for adapter.\");\n+      return responder.decodeResponseContent(RUN_RECORDS_TYPE);\n+    } catch (Exception e) {\n+      LOG.error(\"Error getting adapter runs\", e);","path":"cdap-app-fabric/src/main/java/co/cask/cdap/test/internal/AppFabricClient.java","position":74,"original_position":74,"commit_id":"8643a53c886b6fc983fa70ee9cdb773addd2a85d","original_commit_id":"8643a53c886b6fc983fa70ee9cdb773addd2a85d","user":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"body":"Don't see an extra space. Can you clarify?","created_at":"2015-05-18T19:44:31Z","updated_at":"2015-05-18T19:44:31Z","html_url":"https://github.com/caskdata/cdap/pull/2634#discussion_r30540604","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/2634","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/30540604"},"html":{"href":"https://github.com/caskdata/cdap/pull/2634#discussion_r30540604"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2634"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/2634","id":34870153,"html_url":"https://github.com/caskdata/cdap/pull/2634","diff_url":"https://github.com/caskdata/cdap/pull/2634.diff","patch_url":"https://github.com/caskdata/cdap/pull/2634.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/2634","number":2634,"state":"open","locked":false,"title":"CDAP-2422: Remove redundant catch blocks in AdapterHttpHandler","user":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"body":"https://issues.cask.co/browse/CDAP-2422\r\nhttp://builds.cask.co/browse/CDAP-DUT1812\r\n\r\nPreview before making changes to the rest of the HTTP handlers.","created_at":"2015-05-06T23:16:11Z","updated_at":"2015-05-18T19:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edde170b5926cfc23d96a69528838a46a1e1dd25","assignee":null,"milestone":{"url":"https://api.github.com/repos/caskdata/cdap/milestones/6","html_url":"https://github.com/caskdata/cdap/milestones/3.1.0","labels_url":"https://api.github.com/repos/caskdata/cdap/milestones/6/labels","id":1099347,"number":6,"title":"3.1.0","description":null,"creator":{"login":"jwang47","id":1084704,"avatar_url":"https://avatars.githubusercontent.com/u/1084704?v=3","gravatar_id":"","url":"https://api.github.com/users/jwang47","html_url":"https://github.com/jwang47","followers_url":"https://api.github.com/users/jwang47/followers","following_url":"https://api.github.com/users/jwang47/following{/other_user}","gists_url":"https://api.github.com/users/jwang47/gists{/gist_id}","starred_url":"https://api.github.com/users/jwang47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwang47/subscriptions","organizations_url":"https://api.github.com/users/jwang47/orgs","repos_url":"https://api.github.com/users/jwang47/repos","events_url":"https://api.github.com/users/jwang47/events{/privacy}","received_events_url":"https://api.github.com/users/jwang47/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":6,"state":"open","created_at":"2015-05-06T23:17:15Z","updated_at":"2015-05-16T06:07:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/2634/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/2634/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/2634/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/8643a53c886b6fc983fa70ee9cdb773addd2a85d","head":{"label":"caskdata:feature/adapter-handler-rm-redundant-catch","ref":"feature/adapter-handler-rm-redundant-catch","sha":"8643a53c886b6fc983fa70ee9cdb773addd2a85d","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-16T23:27:39Z","pushed_at":"2015-05-18T19:24:13Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":872912,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":17,"forks":17,"open_issues":17,"watchers":47,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"859559126b624d6bb8e69ca54bbc7113c0fa2847","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","created_at":"2014-08-02T09:00:10Z","updated_at":"2015-05-16T23:27:39Z","pushed_at":"2015-05-18T19:24:13Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":872912,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":17,"forks":17,"open_issues":17,"watchers":47,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2634"},"html":{"href":"https://github.com/caskdata/cdap/pull/2634"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2634"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/2634/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2634/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/2634/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/8643a53c886b6fc983fa70ee9cdb773addd2a85d"}}}}