{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4162","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4162/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4162/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4162/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4162","id":55503780,"number":4162,"title":"[MRG after #3907] TST Add test to check if estimators reset model when fit is called","user":{"login":"ragv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/ragv","html_url":"https://github.com/ragv","followers_url":"https://api.github.com/users/ragv/followers","following_url":"https://api.github.com/users/ragv/following{/other_user}","gists_url":"https://api.github.com/users/ragv/gists{/gist_id}","starred_url":"https://api.github.com/users/ragv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragv/subscriptions","organizations_url":"https://api.github.com/users/ragv/orgs","repos_url":"https://api.github.com/users/ragv/repos","events_url":"https://api.github.com/users/ragv/events{/privacy}","received_events_url":"https://api.github.com/users/ragv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-26T16:32:04Z","updated_at":"2015-01-27T08:30:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4162","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4162","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4162.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4162.patch"},"body":"@amueller Please take a look if this is sufficient...\r\n\r\n- [ ] `_fit` helper may no longer be needed... Ref #4064 "},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/71608605","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4162#issuecomment-71608605","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4162","id":71608605,"user":{"login":"ragv","id":9487348,"avatar_url":"https://avatars.githubusercontent.com/u/9487348?v=3","gravatar_id":"","url":"https://api.github.com/users/ragv","html_url":"https://github.com/ragv","followers_url":"https://api.github.com/users/ragv/followers","following_url":"https://api.github.com/users/ragv/following{/other_user}","gists_url":"https://api.github.com/users/ragv/gists{/gist_id}","starred_url":"https://api.github.com/users/ragv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragv/subscriptions","organizations_url":"https://api.github.com/users/ragv/orgs","repos_url":"https://api.github.com/users/ragv/repos","events_url":"https://api.github.com/users/ragv/events{/privacy}","received_events_url":"https://api.github.com/users/ragv/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T08:30:39Z","updated_at":"2015-01-27T08:30:39Z","body":"@amueller A few clusterers like `AgglomerativeClustering` do not have predict and access the `labels_` directly for the result...\r\n\r\nWe could : \r\n* Special case such clusterers and test them separately\r\n* Get the result from `clusterer.labels_` while checking equality of models ( inside `assert_same_model` / `assert_not_same_model` )\r\n\r\nwhich would be preferable?\r\n\r\n( Also why are they designed such ( without `predict` ) ? Is there any discussion on that? )"}}