{"action":"created","issue":{"url":"https://api.github.com/repos/fredreichbier/genie/issues/7","labels_url":"https://api.github.com/repos/fredreichbier/genie/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/fredreichbier/genie/issues/7/comments","events_url":"https://api.github.com/repos/fredreichbier/genie/issues/7/events","html_url":"https://github.com/fredreichbier/genie/pull/7","id":99834404,"number":7,"title":"show: raise ValueError if a filename isn't given to 'show' command","user":{"login":"Phrohdoh","id":4861023,"avatar_url":"https://avatars.githubusercontent.com/u/4861023?v=3","gravatar_id":"","url":"https://api.github.com/users/Phrohdoh","html_url":"https://github.com/Phrohdoh","followers_url":"https://api.github.com/users/Phrohdoh/followers","following_url":"https://api.github.com/users/Phrohdoh/following{/other_user}","gists_url":"https://api.github.com/users/Phrohdoh/gists{/gist_id}","starred_url":"https://api.github.com/users/Phrohdoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phrohdoh/subscriptions","organizations_url":"https://api.github.com/users/Phrohdoh/orgs","repos_url":"https://api.github.com/users/Phrohdoh/repos","events_url":"https://api.github.com/users/Phrohdoh/events{/privacy}","received_events_url":"https://api.github.com/users/Phrohdoh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-08T21:28:01Z","updated_at":"2015-09-18T08:50:10Z","closed_at":"2015-09-18T08:50:00Z","pull_request":{"url":"https://api.github.com/repos/fredreichbier/genie/pulls/7","html_url":"https://github.com/fredreichbier/genie/pull/7","diff_url":"https://github.com/fredreichbier/genie/pull/7.diff","patch_url":"https://github.com/fredreichbier/genie/pull/7.patch"},"body":"Turns\r\n```python\r\ngenie> help\r\n\r\nDocumented commands (type help <topic>):\r\n========================================\r\ndrs     help  palette  player  saveall    show\r\nexport  ls    play     save    savefirst  showanim\r\n\r\ngenie> show\r\nNow showing ''. Keys:\r\n        q       return to prompt\r\n        +/-     zoom\r\n        a       show the frame hotspot\r\n        arrow keys      to cycle between frames\r\n\r\nTraceback (most recent call last):\r\n  File \"browse_slp.py\", line 307, in do_show\r\n    self.loader.show_filename(name)\r\n  File \"browse_slp.py\", line 55, in show_filename\r\n    resource_id = _get_resource_id(filename)\r\n  File \"browse_slp.py\", line 20, in _get_resource_id\r\n    return int(filename.split('.')[0])\r\nValueError: invalid literal for int() with base 10: ''\r\n\r\ngenie>\r\n```\r\n\r\ninto\r\n\r\n```python\r\ngenie> help\r\n\r\nDocumented commands (type help <topic>):\r\n========================================\r\ndrs     help  palette  player  saveall    show\r\nexport  ls    play     save    savefirst  showanim\r\n\r\ngenie> show\r\nNow showing ''. Keys:\r\n        q       return to prompt\r\n        +/-     zoom\r\n        a       show the frame hotspot\r\n        arrow keys      to cycle between frames\r\n\r\nTraceback (most recent call last):\r\n  File \"browse_slp.py\", line 313, in do_show\r\n    self.loader.show_filename(name)\r\n  File \"browse_slp.py\", line 60, in show_filename\r\n    raise ValueError(\"no filename given\")\r\nValueError: no filename given\r\n\r\ngenie>\r\n```\r\n\r\nIf you instead want me to raise elsewhere (such as `do_show`) I can do that.\r\nOr we could give the user a message back indicating incorrect usage.\r\n\r\nJust let me know."},"comment":{"url":"https://api.github.com/repos/fredreichbier/genie/issues/comments/141384424","html_url":"https://github.com/fredreichbier/genie/pull/7#issuecomment-141384424","issue_url":"https://api.github.com/repos/fredreichbier/genie/issues/7","id":141384424,"user":{"login":"fredreichbier","id":28243,"avatar_url":"https://avatars.githubusercontent.com/u/28243?v=3","gravatar_id":"","url":"https://api.github.com/users/fredreichbier","html_url":"https://github.com/fredreichbier","followers_url":"https://api.github.com/users/fredreichbier/followers","following_url":"https://api.github.com/users/fredreichbier/following{/other_user}","gists_url":"https://api.github.com/users/fredreichbier/gists{/gist_id}","starred_url":"https://api.github.com/users/fredreichbier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredreichbier/subscriptions","organizations_url":"https://api.github.com/users/fredreichbier/orgs","repos_url":"https://api.github.com/users/fredreichbier/repos","events_url":"https://api.github.com/users/fredreichbier/events{/privacy}","received_events_url":"https://api.github.com/users/fredreichbier/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T08:50:10Z","updated_at":"2015-09-18T08:50:10Z","body":"Sorry for the delay, and thanks for the patch!"}}