{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/35793725","id":35793725,"diff_hunk":"@@ -89,9 +89,11 @@ private ExecuteOperationResponse executeOperationDMR(ExecuteOperationRequest req\n         Address opAddress = null;\n         String actualOperationName = null;\n \n+        String requestedOpName = request.getOperationName();\n         Collection<DMROperation> ops = resource.getResourceType().getOperations();\n+        MsgLogger.LOG.tracef(\"Checking if operation [%s] is supported by resource [%s].\", requestedOpName, resource);","path":"hawkular-wildfly-monitor/src/main/java/org/hawkular/agent/monitor/feedcomm/ExecuteOperationCommand.java","position":6,"original_position":6,"commit_id":"8c87801410f81df668cdc3251ce3cbf7f3414303","original_commit_id":"8c87801410f81df668cdc3251ce3cbf7f3414303","user":{"login":"jmazzitelli","id":2029470,"avatar_url":"https://avatars.githubusercontent.com/u/2029470?v=3","gravatar_id":"","url":"https://api.github.com/users/jmazzitelli","html_url":"https://github.com/jmazzitelli","followers_url":"https://api.github.com/users/jmazzitelli/followers","following_url":"https://api.github.com/users/jmazzitelli/following{/other_user}","gists_url":"https://api.github.com/users/jmazzitelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmazzitelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmazzitelli/subscriptions","organizations_url":"https://api.github.com/users/jmazzitelli/orgs","repos_url":"https://api.github.com/users/jmazzitelli/repos","events_url":"https://api.github.com/users/jmazzitelli/events{/privacy}","received_events_url":"https://api.github.com/users/jmazzitelli/received_events","type":"User","site_admin":false},"body":"You aren't logging the names of all valid operations though. From previous comment:\r\n\r\n    MsgLogger.LOG.tracef(\"Searching for operation [%s] among operations [%s] for resource [%s].\",\r\nrequestedOpName, ops, resource.getID());\r\n\r\nnotice \"among operations [%s]\" - and notice passing the \"ops\" collection.\r\n\r\nThis way, your log message will show you three things:\r\n\r\n1) the operation that is being requested\r\n2) the resource whose operation is being requested\r\n3) the list of valid operations for that resource\r\n\r\nSo the log message would look something like:\r\n\r\n   Searching for operation [deploy] among operations [{Deploy,Undeploy,Redeploy,Remove}] for resource [hostn~Local~/].\"\r\n\r\nFrom that one message, you'll be able to see \"ahh.. I passed in a bad operation name - \"deploy\" is all lowercase, but the operation names are captizalized\"\r\n\r\nI don't know what the toString will look like for DMROperations, its probably something like \"DMROperation[Deploy]\" - but we'll get the idea.","created_at":"2015-07-29T18:22:08Z","updated_at":"2015-07-29T18:22:08Z","html_url":"https://github.com/hawkular/hawkular-agent/pull/27#discussion_r35793725","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments/35793725"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/27#discussion_r35793725"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27","id":41129402,"html_url":"https://github.com/hawkular/hawkular-agent/pull/27","diff_url":"https://github.com/hawkular/hawkular-agent/pull/27.diff","patch_url":"https://github.com/hawkular/hawkular-agent/pull/27.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/27","number":27,"state":"open","locked":false,"title":"Debug output when searching for operations to perform","user":{"login":"ppalaga","id":1826249,"avatar_url":"https://avatars.githubusercontent.com/u/1826249?v=3","gravatar_id":"","url":"https://api.github.com/users/ppalaga","html_url":"https://github.com/ppalaga","followers_url":"https://api.github.com/users/ppalaga/followers","following_url":"https://api.github.com/users/ppalaga/following{/other_user}","gists_url":"https://api.github.com/users/ppalaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ppalaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppalaga/subscriptions","organizations_url":"https://api.github.com/users/ppalaga/orgs","repos_url":"https://api.github.com/users/ppalaga/repos","events_url":"https://api.github.com/users/ppalaga/events{/privacy}","received_events_url":"https://api.github.com/users/ppalaga/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-07-29T14:29:03Z","updated_at":"2015-07-29T18:22:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb3c13e6825f1025ca69a8c3e23e6b3fc224e47","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/27/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/8c87801410f81df668cdc3251ce3cbf7f3414303","head":{"label":"ppalaga:150729-trace","ref":"150729-trace","sha":"8c87801410f81df668cdc3251ce3cbf7f3414303","user":{"login":"ppalaga","id":1826249,"avatar_url":"https://avatars.githubusercontent.com/u/1826249?v=3","gravatar_id":"","url":"https://api.github.com/users/ppalaga","html_url":"https://github.com/ppalaga","followers_url":"https://api.github.com/users/ppalaga/followers","following_url":"https://api.github.com/users/ppalaga/following{/other_user}","gists_url":"https://api.github.com/users/ppalaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ppalaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppalaga/subscriptions","organizations_url":"https://api.github.com/users/ppalaga/orgs","repos_url":"https://api.github.com/users/ppalaga/repos","events_url":"https://api.github.com/users/ppalaga/events{/privacy}","received_events_url":"https://api.github.com/users/ppalaga/received_events","type":"User","site_admin":false},"repo":{"id":34785894,"name":"hawkular-agent","full_name":"ppalaga/hawkular-agent","owner":{"login":"ppalaga","id":1826249,"avatar_url":"https://avatars.githubusercontent.com/u/1826249?v=3","gravatar_id":"","url":"https://api.github.com/users/ppalaga","html_url":"https://github.com/ppalaga","followers_url":"https://api.github.com/users/ppalaga/followers","following_url":"https://api.github.com/users/ppalaga/following{/other_user}","gists_url":"https://api.github.com/users/ppalaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ppalaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppalaga/subscriptions","organizations_url":"https://api.github.com/users/ppalaga/orgs","repos_url":"https://api.github.com/users/ppalaga/repos","events_url":"https://api.github.com/users/ppalaga/events{/privacy}","received_events_url":"https://api.github.com/users/ppalaga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ppalaga/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":true,"url":"https://api.github.com/repos/ppalaga/hawkular-agent","forks_url":"https://api.github.com/repos/ppalaga/hawkular-agent/forks","keys_url":"https://api.github.com/repos/ppalaga/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppalaga/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppalaga/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/ppalaga/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/ppalaga/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/ppalaga/hawkular-agent/events","assignees_url":"https://api.github.com/repos/ppalaga/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/ppalaga/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/ppalaga/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/ppalaga/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppalaga/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppalaga/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppalaga/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppalaga/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/ppalaga/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/ppalaga/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/ppalaga/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/ppalaga/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/ppalaga/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/ppalaga/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppalaga/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppalaga/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppalaga/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppalaga/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/ppalaga/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppalaga/hawkular-agent/merges","archive_url":"https://api.github.com/repos/ppalaga/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppalaga/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/ppalaga/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/ppalaga/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/ppalaga/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/ppalaga/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppalaga/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/ppalaga/hawkular-agent/releases{/id}","created_at":"2015-04-29T09:50:07Z","updated_at":"2015-04-29T09:50:09Z","pushed_at":"2015-07-29T17:28:53Z","git_url":"git://github.com/ppalaga/hawkular-agent.git","ssh_url":"git@github.com:ppalaga/hawkular-agent.git","clone_url":"https://github.com/ppalaga/hawkular-agent.git","svn_url":"https://github.com/ppalaga/hawkular-agent","homepage":null,"size":699,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"956fb8b203de04bf9939cc97e60736c79b3fcd9e","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":33185377,"name":"hawkular-agent","full_name":"hawkular/hawkular-agent","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-agent","description":"Hawkular Agents that can be used to monitor managed products","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-agent","forks_url":"https://api.github.com/repos/hawkular/hawkular-agent/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-agent/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-agent/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-agent/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-agent/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-agent/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-agent/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-agent/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-agent/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-agent/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-agent/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-agent/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-agent/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-agent/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-agent/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-agent/releases{/id}","created_at":"2015-03-31T12:56:14Z","updated_at":"2015-05-24T11:55:16Z","pushed_at":"2015-07-29T17:28:53Z","git_url":"git://github.com/hawkular/hawkular-agent.git","ssh_url":"git@github.com:hawkular/hawkular-agent.git","clone_url":"https://github.com/hawkular/hawkular-agent.git","svn_url":"https://github.com/hawkular/hawkular-agent","homepage":null,"size":1347,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27"},"html":{"href":"https://github.com/hawkular/hawkular-agent/pull/27"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/27"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-agent/statuses/8c87801410f81df668cdc3251ce3cbf7f3414303"}}}}