{"action":"closed","number":140,"pull_request":{"url":"https://api.github.com/repos/skynetservices/skydns/pulls/140","id":30697788,"html_url":"https://github.com/skynetservices/skydns/pull/140","diff_url":"https://github.com/skynetservices/skydns/pull/140.diff","patch_url":"https://github.com/skynetservices/skydns/pull/140.patch","issue_url":"https://api.github.com/repos/skynetservices/skydns/issues/140","number":140,"state":"closed","locked":false,"title":"Abstract record retrieval behind an interface","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"Moves retrieval of records behind an interface as discussed in #116.\nStill has some rough edges (PTRRecords, TTLs may not be correct,\nsingle record lookups are possibly wrong).\n\nDoes this look roughly like what we discussed?","created_at":"2015-03-07T05:24:18Z","updated_at":"2015-03-09T09:52:00Z","closed_at":"2015-03-09T09:52:00Z","merged_at":"2015-03-09T09:52:00Z","merge_commit_sha":"26405b09d327db01ca23b0d184657e07c35fc07e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/skynetservices/skydns/pulls/140/commits","review_comments_url":"https://api.github.com/repos/skynetservices/skydns/pulls/140/comments","review_comment_url":"https://api.github.com/repos/skynetservices/skydns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skynetservices/skydns/issues/140/comments","statuses_url":"https://api.github.com/repos/skynetservices/skydns/statuses/489b964f15da8df337bb03685deb87fce5731b0f","head":{"label":"smarterclayton:extract_records_interface","ref":"extract_records_interface","sha":"489b964f15da8df337bb03685deb87fce5731b0f","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"repo":{"id":29321219,"name":"skydns","full_name":"smarterclayton/skydns","owner":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smarterclayton/skydns","description":"DNS service discovery for etcd","fork":true,"url":"https://api.github.com/repos/smarterclayton/skydns","forks_url":"https://api.github.com/repos/smarterclayton/skydns/forks","keys_url":"https://api.github.com/repos/smarterclayton/skydns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smarterclayton/skydns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smarterclayton/skydns/teams","hooks_url":"https://api.github.com/repos/smarterclayton/skydns/hooks","issue_events_url":"https://api.github.com/repos/smarterclayton/skydns/issues/events{/number}","events_url":"https://api.github.com/repos/smarterclayton/skydns/events","assignees_url":"https://api.github.com/repos/smarterclayton/skydns/assignees{/user}","branches_url":"https://api.github.com/repos/smarterclayton/skydns/branches{/branch}","tags_url":"https://api.github.com/repos/smarterclayton/skydns/tags","blobs_url":"https://api.github.com/repos/smarterclayton/skydns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smarterclayton/skydns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smarterclayton/skydns/git/refs{/sha}","trees_url":"https://api.github.com/repos/smarterclayton/skydns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smarterclayton/skydns/statuses/{sha}","languages_url":"https://api.github.com/repos/smarterclayton/skydns/languages","stargazers_url":"https://api.github.com/repos/smarterclayton/skydns/stargazers","contributors_url":"https://api.github.com/repos/smarterclayton/skydns/contributors","subscribers_url":"https://api.github.com/repos/smarterclayton/skydns/subscribers","subscription_url":"https://api.github.com/repos/smarterclayton/skydns/subscription","commits_url":"https://api.github.com/repos/smarterclayton/skydns/commits{/sha}","git_commits_url":"https://api.github.com/repos/smarterclayton/skydns/git/commits{/sha}","comments_url":"https://api.github.com/repos/smarterclayton/skydns/comments{/number}","issue_comment_url":"https://api.github.com/repos/smarterclayton/skydns/issues/comments{/number}","contents_url":"https://api.github.com/repos/smarterclayton/skydns/contents/{+path}","compare_url":"https://api.github.com/repos/smarterclayton/skydns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smarterclayton/skydns/merges","archive_url":"https://api.github.com/repos/smarterclayton/skydns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smarterclayton/skydns/downloads","issues_url":"https://api.github.com/repos/smarterclayton/skydns/issues{/number}","pulls_url":"https://api.github.com/repos/smarterclayton/skydns/pulls{/number}","milestones_url":"https://api.github.com/repos/smarterclayton/skydns/milestones{/number}","notifications_url":"https://api.github.com/repos/smarterclayton/skydns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smarterclayton/skydns/labels{/name}","releases_url":"https://api.github.com/repos/smarterclayton/skydns/releases{/id}","created_at":"2015-01-15T22:23:15Z","updated_at":"2015-01-15T22:23:17Z","pushed_at":"2015-03-09T00:48:00Z","git_url":"git://github.com/smarterclayton/skydns.git","ssh_url":"git@github.com:smarterclayton/skydns.git","clone_url":"https://github.com/smarterclayton/skydns.git","svn_url":"https://github.com/smarterclayton/skydns","homepage":"","size":506,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skynetservices:master","ref":"master","sha":"4a5c4248b93b5a57d81e70d75eb18811b1e74eaa","user":{"login":"skynetservices","id":2963370,"avatar_url":"https://avatars.githubusercontent.com/u/2963370?v=3","gravatar_id":"","url":"https://api.github.com/users/skynetservices","html_url":"https://github.com/skynetservices","followers_url":"https://api.github.com/users/skynetservices/followers","following_url":"https://api.github.com/users/skynetservices/following{/other_user}","gists_url":"https://api.github.com/users/skynetservices/gists{/gist_id}","starred_url":"https://api.github.com/users/skynetservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skynetservices/subscriptions","organizations_url":"https://api.github.com/users/skynetservices/orgs","repos_url":"https://api.github.com/users/skynetservices/repos","events_url":"https://api.github.com/users/skynetservices/events{/privacy}","received_events_url":"https://api.github.com/users/skynetservices/received_events","type":"Organization","site_admin":false},"repo":{"id":19206385,"name":"skydns","full_name":"skynetservices/skydns","owner":{"login":"skynetservices","id":2963370,"avatar_url":"https://avatars.githubusercontent.com/u/2963370?v=3","gravatar_id":"","url":"https://api.github.com/users/skynetservices","html_url":"https://github.com/skynetservices","followers_url":"https://api.github.com/users/skynetservices/followers","following_url":"https://api.github.com/users/skynetservices/following{/other_user}","gists_url":"https://api.github.com/users/skynetservices/gists{/gist_id}","starred_url":"https://api.github.com/users/skynetservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skynetservices/subscriptions","organizations_url":"https://api.github.com/users/skynetservices/orgs","repos_url":"https://api.github.com/users/skynetservices/repos","events_url":"https://api.github.com/users/skynetservices/events{/privacy}","received_events_url":"https://api.github.com/users/skynetservices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skynetservices/skydns","description":"DNS service discovery for etcd","fork":true,"url":"https://api.github.com/repos/skynetservices/skydns","forks_url":"https://api.github.com/repos/skynetservices/skydns/forks","keys_url":"https://api.github.com/repos/skynetservices/skydns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skynetservices/skydns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skynetservices/skydns/teams","hooks_url":"https://api.github.com/repos/skynetservices/skydns/hooks","issue_events_url":"https://api.github.com/repos/skynetservices/skydns/issues/events{/number}","events_url":"https://api.github.com/repos/skynetservices/skydns/events","assignees_url":"https://api.github.com/repos/skynetservices/skydns/assignees{/user}","branches_url":"https://api.github.com/repos/skynetservices/skydns/branches{/branch}","tags_url":"https://api.github.com/repos/skynetservices/skydns/tags","blobs_url":"https://api.github.com/repos/skynetservices/skydns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skynetservices/skydns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skynetservices/skydns/git/refs{/sha}","trees_url":"https://api.github.com/repos/skynetservices/skydns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skynetservices/skydns/statuses/{sha}","languages_url":"https://api.github.com/repos/skynetservices/skydns/languages","stargazers_url":"https://api.github.com/repos/skynetservices/skydns/stargazers","contributors_url":"https://api.github.com/repos/skynetservices/skydns/contributors","subscribers_url":"https://api.github.com/repos/skynetservices/skydns/subscribers","subscription_url":"https://api.github.com/repos/skynetservices/skydns/subscription","commits_url":"https://api.github.com/repos/skynetservices/skydns/commits{/sha}","git_commits_url":"https://api.github.com/repos/skynetservices/skydns/git/commits{/sha}","comments_url":"https://api.github.com/repos/skynetservices/skydns/comments{/number}","issue_comment_url":"https://api.github.com/repos/skynetservices/skydns/issues/comments{/number}","contents_url":"https://api.github.com/repos/skynetservices/skydns/contents/{+path}","compare_url":"https://api.github.com/repos/skynetservices/skydns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skynetservices/skydns/merges","archive_url":"https://api.github.com/repos/skynetservices/skydns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skynetservices/skydns/downloads","issues_url":"https://api.github.com/repos/skynetservices/skydns/issues{/number}","pulls_url":"https://api.github.com/repos/skynetservices/skydns/pulls{/number}","milestones_url":"https://api.github.com/repos/skynetservices/skydns/milestones{/number}","notifications_url":"https://api.github.com/repos/skynetservices/skydns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skynetservices/skydns/labels{/name}","releases_url":"https://api.github.com/repos/skynetservices/skydns/releases{/id}","created_at":"2014-04-27T14:25:30Z","updated_at":"2015-03-09T08:29:20Z","pushed_at":"2015-03-09T09:52:00Z","git_url":"git://github.com/skynetservices/skydns.git","ssh_url":"git@github.com:skynetservices/skydns.git","clone_url":"https://github.com/skynetservices/skydns.git","svn_url":"https://github.com/skynetservices/skydns","homepage":"","size":2839,"stargazers_count":522,"watchers_count":522,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":12,"forks":69,"open_issues":12,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skynetservices/skydns/pulls/140"},"html":{"href":"https://github.com/skynetservices/skydns/pull/140"},"issue":{"href":"https://api.github.com/repos/skynetservices/skydns/issues/140"},"comments":{"href":"https://api.github.com/repos/skynetservices/skydns/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/skynetservices/skydns/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/skynetservices/skydns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skynetservices/skydns/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/skynetservices/skydns/statuses/489b964f15da8df337bb03685deb87fce5731b0f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"comments":13,"review_comments":8,"commits":2,"additions":435,"deletions":476,"changed_files":11}}