{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/31189792","id":31189792,"diff_hunk":"@@ -885,9 +833,10 @@ pub enum TextOrientation {\n }\n \n /// Paints an image.\n-#[derive(Clone)]\n+#[derive(Clone, HeapSizeOf)]\n pub struct ImageDisplayItem {\n     pub base: BaseDisplayItem,\n+    #[ignore_heap_size = \"We exclude this here because it is non-owning\"]","path":"components/gfx/display_list/mod.rs","position":200,"original_position":200,"commit_id":"3ab39059a081050fded402d9934098e07ba93f2b","original_commit_id":"3ab39059a081050fded402d9934098e07ba93f2b","user":{"login":"nnethercote","id":1940286,"avatar_url":"https://avatars.githubusercontent.com/u/1940286?v=3","gravatar_id":"","url":"https://api.github.com/users/nnethercote","html_url":"https://github.com/nnethercote","followers_url":"https://api.github.com/users/nnethercote/followers","following_url":"https://api.github.com/users/nnethercote/following{/other_user}","gists_url":"https://api.github.com/users/nnethercote/gists{/gist_id}","starred_url":"https://api.github.com/users/nnethercote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnethercote/subscriptions","organizations_url":"https://api.github.com/users/nnethercote/orgs","repos_url":"https://api.github.com/users/nnethercote/repos","events_url":"https://api.github.com/users/nnethercote/events{/privacy}","received_events_url":"https://api.github.com/users/nnethercote/received_events","type":"User","site_admin":false},"body":"Again, \"Because it is non-owning\" is enough.","created_at":"2015-05-27T23:06:05Z","updated_at":"2015-05-27T23:06:05Z","html_url":"https://github.com/servo/servo/pull/6188#discussion_r31189792","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/6188","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/31189792"},"html":{"href":"https://github.com/servo/servo/pull/6188#discussion_r31189792"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/6188"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/6188","id":36230946,"html_url":"https://github.com/servo/servo/pull/6188","diff_url":"https://github.com/servo/servo/pull/6188.diff","patch_url":"https://github.com/servo/servo/pull/6188.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/6188","number":6188,"state":"open","locked":false,"title":"Add plugin for autoderiving HeapSize","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"Todo:  add zeroheapsize invocations for all the geom things\n\nr? @nnethercote for the gfx changes\n\nr? @kmcallister or @jdm for the plugin\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/servo/servo/6188)\n<!-- Reviewable:end -->\n","created_at":"2015-05-26T18:24:08Z","updated_at":"2015-05-27T23:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5ed6a572a6c73fbaeec53e7485efa1edfd68385","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/6188/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/6188/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/6188/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/3ab39059a081050fded402d9934098e07ba93f2b","head":{"label":"Manishearth:sizeof","ref":"sizeof","sha":"3ab39059a081050fded402d9934098e07ba93f2b","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"repo":{"id":17138296,"name":"servo","full_name":"Manishearth/servo","owner":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manishearth/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Manishearth/servo","forks_url":"https://api.github.com/repos/Manishearth/servo/forks","keys_url":"https://api.github.com/repos/Manishearth/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manishearth/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manishearth/servo/teams","hooks_url":"https://api.github.com/repos/Manishearth/servo/hooks","issue_events_url":"https://api.github.com/repos/Manishearth/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Manishearth/servo/events","assignees_url":"https://api.github.com/repos/Manishearth/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Manishearth/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Manishearth/servo/tags","blobs_url":"https://api.github.com/repos/Manishearth/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manishearth/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manishearth/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manishearth/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manishearth/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Manishearth/servo/languages","stargazers_url":"https://api.github.com/repos/Manishearth/servo/stargazers","contributors_url":"https://api.github.com/repos/Manishearth/servo/contributors","subscribers_url":"https://api.github.com/repos/Manishearth/servo/subscribers","subscription_url":"https://api.github.com/repos/Manishearth/servo/subscription","commits_url":"https://api.github.com/repos/Manishearth/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manishearth/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manishearth/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manishearth/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manishearth/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Manishearth/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manishearth/servo/merges","archive_url":"https://api.github.com/repos/Manishearth/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manishearth/servo/downloads","issues_url":"https://api.github.com/repos/Manishearth/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Manishearth/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Manishearth/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Manishearth/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manishearth/servo/labels{/name}","releases_url":"https://api.github.com/repos/Manishearth/servo/releases{/id}","created_at":"2014-02-24T14:18:00Z","updated_at":"2015-03-26T03:53:37Z","pushed_at":"2015-05-27T17:23:12Z","git_url":"git://github.com/Manishearth/servo.git","ssh_url":"git@github.com:Manishearth/servo.git","clone_url":"https://github.com/Manishearth/servo.git","svn_url":"https://github.com/Manishearth/servo","homepage":"","size":105428,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"8759d42559bc5c10f8d90903f33f75bddf44d9fe","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","created_at":"2012-02-08T19:07:25Z","updated_at":"2015-05-27T20:53:55Z","pushed_at":"2015-05-27T22:59:58Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"","size":1896462,"stargazers_count":4154,"watchers_count":4154,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":646,"mirror_url":null,"open_issues_count":894,"forks":646,"open_issues":894,"watchers":4154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/6188"},"html":{"href":"https://github.com/servo/servo/pull/6188"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/6188"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/6188/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/6188/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/6188/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/3ab39059a081050fded402d9934098e07ba93f2b"}}}}