{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/kinto/pulls/comments/32838260","id":32838260,"diff_hunk":"@@ -61,7 +64,11 @@ def process_record(self, new, old=None):\n         if old is None:\n             existing_record_members = set([])\n         else:\n-            existing_record_members = set(old['members'])\n+            try:\n+                existing_record_members = set(old['members'])\n+            except KeyError:","path":"kinto/views/groups.py","position":23,"original_position":23,"commit_id":"b46c6243e4a7e8042efee49e94cc784d6f0accc9","original_commit_id":"b46c6243e4a7e8042efee49e94cc784d6f0accc9","user":{"login":"leplatrem","id":546692,"avatar_url":"https://avatars.githubusercontent.com/u/546692?v=3","gravatar_id":"","url":"https://api.github.com/users/leplatrem","html_url":"https://github.com/leplatrem","followers_url":"https://api.github.com/users/leplatrem/followers","following_url":"https://api.github.com/users/leplatrem/following{/other_user}","gists_url":"https://api.github.com/users/leplatrem/gists{/gist_id}","starred_url":"https://api.github.com/users/leplatrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leplatrem/subscriptions","organizations_url":"https://api.github.com/users/leplatrem/orgs","repos_url":"https://api.github.com/users/leplatrem/repos","events_url":"https://api.github.com/users/leplatrem/events{/privacy}","received_events_url":"https://api.github.com/users/leplatrem/received_events","type":"User","site_admin":false},"body":"A test for this edge-case ?","created_at":"2015-06-19T15:14:22Z","updated_at":"2015-06-19T15:14:22Z","html_url":"https://github.com/mozilla-services/kinto/pull/78#discussion_r32838260","pull_request_url":"https://api.github.com/repos/mozilla-services/kinto/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/comments/32838260"},"html":{"href":"https://github.com/mozilla-services/kinto/pull/78#discussion_r32838260"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/kinto/pulls/78","id":38111560,"html_url":"https://github.com/mozilla-services/kinto/pull/78","diff_url":"https://github.com/mozilla-services/kinto/pull/78.diff","patch_url":"https://github.com/mozilla-services/kinto/pull/78.patch","issue_url":"https://api.github.com/repos/mozilla-services/kinto/issues/78","number":78,"state":"open","locked":false,"title":"Groups are not plugged to principal","user":{"login":"Natim","id":229453,"avatar_url":"https://avatars.githubusercontent.com/u/229453?v=3","gravatar_id":"","url":"https://api.github.com/users/Natim","html_url":"https://github.com/Natim","followers_url":"https://api.github.com/users/Natim/followers","following_url":"https://api.github.com/users/Natim/following{/other_user}","gists_url":"https://api.github.com/users/Natim/gists{/gist_id}","starred_url":"https://api.github.com/users/Natim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Natim/subscriptions","organizations_url":"https://api.github.com/users/Natim/orgs","repos_url":"https://api.github.com/users/Natim/repos","events_url":"https://api.github.com/users/Natim/events{/privacy}","received_events_url":"https://api.github.com/users/Natim/received_events","type":"User","site_admin":false},"body":"If you create a group and add people to it, then they cannot access records with the group as a permission principal.","created_at":"2015-06-19T14:15:52Z","updated_at":"2015-06-19T15:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"691c089cc33090b2a192837e0bef7b708d783564","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/kinto/pulls/78/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/kinto/pulls/78/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/kinto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/kinto/issues/78/comments","statuses_url":"https://api.github.com/repos/mozilla-services/kinto/statuses/b46c6243e4a7e8042efee49e94cc784d6f0accc9","head":{"label":"mozilla-services:78-groups-are-not-plugged","ref":"78-groups-are-not-plugged","sha":"b46c6243e4a7e8042efee49e94cc784d6f0accc9","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31315021,"name":"kinto","full_name":"mozilla-services/kinto","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/kinto","description":"store, sync. rince and repeat.","fork":false,"url":"https://api.github.com/repos/mozilla-services/kinto","forks_url":"https://api.github.com/repos/mozilla-services/kinto/forks","keys_url":"https://api.github.com/repos/mozilla-services/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/kinto/teams","hooks_url":"https://api.github.com/repos/mozilla-services/kinto/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/kinto/events","assignees_url":"https://api.github.com/repos/mozilla-services/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/kinto/tags","blobs_url":"https://api.github.com/repos/mozilla-services/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/kinto/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/kinto/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/kinto/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/kinto/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/kinto/subscription","commits_url":"https://api.github.com/repos/mozilla-services/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/kinto/merges","archive_url":"https://api.github.com/repos/mozilla-services/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/kinto/downloads","issues_url":"https://api.github.com/repos/mozilla-services/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/kinto/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/kinto/releases{/id}","created_at":"2015-02-25T13:34:23Z","updated_at":"2015-06-17T03:04:50Z","pushed_at":"2015-06-19T14:15:52Z","git_url":"git://github.com/mozilla-services/kinto.git","ssh_url":"git@github.com:mozilla-services/kinto.git","clone_url":"https://github.com/mozilla-services/kinto.git","svn_url":"https://github.com/mozilla-services/kinto","homepage":"http://kinto.readthedocs.org/","size":1524,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":8,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"ba32242abacda7c1c0b089112267dadc5f61291e","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31315021,"name":"kinto","full_name":"mozilla-services/kinto","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/kinto","description":"store, sync. rince and repeat.","fork":false,"url":"https://api.github.com/repos/mozilla-services/kinto","forks_url":"https://api.github.com/repos/mozilla-services/kinto/forks","keys_url":"https://api.github.com/repos/mozilla-services/kinto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/kinto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/kinto/teams","hooks_url":"https://api.github.com/repos/mozilla-services/kinto/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/kinto/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/kinto/events","assignees_url":"https://api.github.com/repos/mozilla-services/kinto/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/kinto/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/kinto/tags","blobs_url":"https://api.github.com/repos/mozilla-services/kinto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/kinto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/kinto/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/kinto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/kinto/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/kinto/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/kinto/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/kinto/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/kinto/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/kinto/subscription","commits_url":"https://api.github.com/repos/mozilla-services/kinto/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/kinto/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/kinto/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/kinto/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/kinto/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/kinto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/kinto/merges","archive_url":"https://api.github.com/repos/mozilla-services/kinto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/kinto/downloads","issues_url":"https://api.github.com/repos/mozilla-services/kinto/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/kinto/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/kinto/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/kinto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/kinto/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/kinto/releases{/id}","created_at":"2015-02-25T13:34:23Z","updated_at":"2015-06-17T03:04:50Z","pushed_at":"2015-06-19T14:15:52Z","git_url":"git://github.com/mozilla-services/kinto.git","ssh_url":"git@github.com:mozilla-services/kinto.git","clone_url":"https://github.com/mozilla-services/kinto.git","svn_url":"https://github.com/mozilla-services/kinto","homepage":"http://kinto.readthedocs.org/","size":1524,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/78"},"html":{"href":"https://github.com/mozilla-services/kinto/pull/78"},"issue":{"href":"https://api.github.com/repos/mozilla-services/kinto/issues/78"},"comments":{"href":"https://api.github.com/repos/mozilla-services/kinto/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/kinto/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/kinto/statuses/b46c6243e4a7e8042efee49e94cc784d6f0accc9"}}}}