{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49","id":33511828,"html_url":"https://github.com/fkling/JSNetworkX/pull/49","diff_url":"https://github.com/fkling/JSNetworkX/pull/49.diff","patch_url":"https://github.com/fkling/JSNetworkX/pull/49.patch","issue_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/49","number":49,"state":"closed","locked":false,"title":"Implement weighted and generic shortest path","user":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"body":"I still have to implement some of the tests for the ported methods. I'm not sure about the function signature of some weighted shortest path functions. \r\n\r\nMy idea was to make every required argument a formal parameter and let optional arguments be passed in an options object.\r\n\r\nFeedback on this is appreciated.","created_at":"2015-04-17T03:22:23Z","updated_at":"2015-04-23T06:43:16Z","closed_at":"2015-04-23T06:43:16Z","merged_at":null,"merge_commit_sha":"c8da6490ad24c930741654c16510f1c642a58f99","assignee":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49/commits","review_comments_url":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49/comments","review_comment_url":"https://api.github.com/repos/fkling/JSNetworkX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/49/comments","statuses_url":"https://api.github.com/repos/fkling/JSNetworkX/statuses/dc6366e11ad901bac404eaa559ba70f272759ea5","head":{"label":"fkling:shortest_path","ref":"shortest_path","sha":"dc6366e11ad901bac404eaa559ba70f272759ea5","user":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"repo":{"id":3966929,"name":"JSNetworkX","full_name":"fkling/JSNetworkX","owner":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fkling/JSNetworkX","description":"A port of the graph library NetworkX to JavaScript","fork":false,"url":"https://api.github.com/repos/fkling/JSNetworkX","forks_url":"https://api.github.com/repos/fkling/JSNetworkX/forks","keys_url":"https://api.github.com/repos/fkling/JSNetworkX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fkling/JSNetworkX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fkling/JSNetworkX/teams","hooks_url":"https://api.github.com/repos/fkling/JSNetworkX/hooks","issue_events_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/events{/number}","events_url":"https://api.github.com/repos/fkling/JSNetworkX/events","assignees_url":"https://api.github.com/repos/fkling/JSNetworkX/assignees{/user}","branches_url":"https://api.github.com/repos/fkling/JSNetworkX/branches{/branch}","tags_url":"https://api.github.com/repos/fkling/JSNetworkX/tags","blobs_url":"https://api.github.com/repos/fkling/JSNetworkX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fkling/JSNetworkX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fkling/JSNetworkX/git/refs{/sha}","trees_url":"https://api.github.com/repos/fkling/JSNetworkX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fkling/JSNetworkX/statuses/{sha}","languages_url":"https://api.github.com/repos/fkling/JSNetworkX/languages","stargazers_url":"https://api.github.com/repos/fkling/JSNetworkX/stargazers","contributors_url":"https://api.github.com/repos/fkling/JSNetworkX/contributors","subscribers_url":"https://api.github.com/repos/fkling/JSNetworkX/subscribers","subscription_url":"https://api.github.com/repos/fkling/JSNetworkX/subscription","commits_url":"https://api.github.com/repos/fkling/JSNetworkX/commits{/sha}","git_commits_url":"https://api.github.com/repos/fkling/JSNetworkX/git/commits{/sha}","comments_url":"https://api.github.com/repos/fkling/JSNetworkX/comments{/number}","issue_comment_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/comments{/number}","contents_url":"https://api.github.com/repos/fkling/JSNetworkX/contents/{+path}","compare_url":"https://api.github.com/repos/fkling/JSNetworkX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fkling/JSNetworkX/merges","archive_url":"https://api.github.com/repos/fkling/JSNetworkX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fkling/JSNetworkX/downloads","issues_url":"https://api.github.com/repos/fkling/JSNetworkX/issues{/number}","pulls_url":"https://api.github.com/repos/fkling/JSNetworkX/pulls{/number}","milestones_url":"https://api.github.com/repos/fkling/JSNetworkX/milestones{/number}","notifications_url":"https://api.github.com/repos/fkling/JSNetworkX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fkling/JSNetworkX/labels{/name}","releases_url":"https://api.github.com/repos/fkling/JSNetworkX/releases{/id}","created_at":"2012-04-08T21:09:47Z","updated_at":"2015-04-23T06:42:01Z","pushed_at":"2015-04-23T06:42:01Z","git_url":"git://github.com/fkling/JSNetworkX.git","ssh_url":"git@github.com:fkling/JSNetworkX.git","clone_url":"https://github.com/fkling/JSNetworkX.git","svn_url":"https://github.com/fkling/JSNetworkX","homepage":"http://jsnetworkx.org","size":2796,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":12,"forks":51,"open_issues":12,"watchers":220,"default_branch":"master"}},"base":{"label":"fkling:master","ref":"master","sha":"2a96e49d9d005c16faa7c296d5e44d51b8ad4ebc","user":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"repo":{"id":3966929,"name":"JSNetworkX","full_name":"fkling/JSNetworkX","owner":{"login":"fkling","id":179026,"avatar_url":"https://avatars.githubusercontent.com/u/179026?v=3","gravatar_id":"","url":"https://api.github.com/users/fkling","html_url":"https://github.com/fkling","followers_url":"https://api.github.com/users/fkling/followers","following_url":"https://api.github.com/users/fkling/following{/other_user}","gists_url":"https://api.github.com/users/fkling/gists{/gist_id}","starred_url":"https://api.github.com/users/fkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkling/subscriptions","organizations_url":"https://api.github.com/users/fkling/orgs","repos_url":"https://api.github.com/users/fkling/repos","events_url":"https://api.github.com/users/fkling/events{/privacy}","received_events_url":"https://api.github.com/users/fkling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fkling/JSNetworkX","description":"A port of the graph library NetworkX to JavaScript","fork":false,"url":"https://api.github.com/repos/fkling/JSNetworkX","forks_url":"https://api.github.com/repos/fkling/JSNetworkX/forks","keys_url":"https://api.github.com/repos/fkling/JSNetworkX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fkling/JSNetworkX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fkling/JSNetworkX/teams","hooks_url":"https://api.github.com/repos/fkling/JSNetworkX/hooks","issue_events_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/events{/number}","events_url":"https://api.github.com/repos/fkling/JSNetworkX/events","assignees_url":"https://api.github.com/repos/fkling/JSNetworkX/assignees{/user}","branches_url":"https://api.github.com/repos/fkling/JSNetworkX/branches{/branch}","tags_url":"https://api.github.com/repos/fkling/JSNetworkX/tags","blobs_url":"https://api.github.com/repos/fkling/JSNetworkX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fkling/JSNetworkX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fkling/JSNetworkX/git/refs{/sha}","trees_url":"https://api.github.com/repos/fkling/JSNetworkX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fkling/JSNetworkX/statuses/{sha}","languages_url":"https://api.github.com/repos/fkling/JSNetworkX/languages","stargazers_url":"https://api.github.com/repos/fkling/JSNetworkX/stargazers","contributors_url":"https://api.github.com/repos/fkling/JSNetworkX/contributors","subscribers_url":"https://api.github.com/repos/fkling/JSNetworkX/subscribers","subscription_url":"https://api.github.com/repos/fkling/JSNetworkX/subscription","commits_url":"https://api.github.com/repos/fkling/JSNetworkX/commits{/sha}","git_commits_url":"https://api.github.com/repos/fkling/JSNetworkX/git/commits{/sha}","comments_url":"https://api.github.com/repos/fkling/JSNetworkX/comments{/number}","issue_comment_url":"https://api.github.com/repos/fkling/JSNetworkX/issues/comments{/number}","contents_url":"https://api.github.com/repos/fkling/JSNetworkX/contents/{+path}","compare_url":"https://api.github.com/repos/fkling/JSNetworkX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fkling/JSNetworkX/merges","archive_url":"https://api.github.com/repos/fkling/JSNetworkX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fkling/JSNetworkX/downloads","issues_url":"https://api.github.com/repos/fkling/JSNetworkX/issues{/number}","pulls_url":"https://api.github.com/repos/fkling/JSNetworkX/pulls{/number}","milestones_url":"https://api.github.com/repos/fkling/JSNetworkX/milestones{/number}","notifications_url":"https://api.github.com/repos/fkling/JSNetworkX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fkling/JSNetworkX/labels{/name}","releases_url":"https://api.github.com/repos/fkling/JSNetworkX/releases{/id}","created_at":"2012-04-08T21:09:47Z","updated_at":"2015-04-23T06:42:01Z","pushed_at":"2015-04-23T06:42:01Z","git_url":"git://github.com/fkling/JSNetworkX.git","ssh_url":"git@github.com:fkling/JSNetworkX.git","clone_url":"https://github.com/fkling/JSNetworkX.git","svn_url":"https://github.com/fkling/JSNetworkX","homepage":"http://jsnetworkx.org","size":2796,"stargazers_count":220,"watchers_count":220,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":12,"forks":51,"open_issues":12,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49"},"html":{"href":"https://github.com/fkling/JSNetworkX/pull/49"},"issue":{"href":"https://api.github.com/repos/fkling/JSNetworkX/issues/49"},"comments":{"href":"https://api.github.com/repos/fkling/JSNetworkX/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/fkling/JSNetworkX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fkling/JSNetworkX/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/fkling/JSNetworkX/statuses/dc6366e11ad901bac404eaa559ba70f272759ea5"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":1178,"deletions":3,"changed_files":5}}