{"action":"created","issue":{"url":"https://api.github.com/repos/SquidPony/SquidLib/issues/85","labels_url":"https://api.github.com/repos/SquidPony/SquidLib/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/SquidPony/SquidLib/issues/85/comments","events_url":"https://api.github.com/repos/SquidPony/SquidLib/issues/85/events","html_url":"https://github.com/SquidPony/SquidLib/issues/85","id":109957761,"number":85,"title":"Decrease the number of warnings","user":{"login":"smelc","id":634720,"avatar_url":"https://avatars.githubusercontent.com/u/634720?v=3","gravatar_id":"","url":"https://api.github.com/users/smelc","html_url":"https://github.com/smelc","followers_url":"https://api.github.com/users/smelc/followers","following_url":"https://api.github.com/users/smelc/following{/other_user}","gists_url":"https://api.github.com/users/smelc/gists{/gist_id}","starred_url":"https://api.github.com/users/smelc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smelc/subscriptions","organizations_url":"https://api.github.com/users/smelc/orgs","repos_url":"https://api.github.com/users/smelc/repos","events_url":"https://api.github.com/users/smelc/events{/privacy}","received_events_url":"https://api.github.com/users/smelc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":27,"created_at":"2015-10-06T08:19:14Z","updated_at":"2015-10-07T07:36:56Z","closed_at":null,"body":"I'm programming under Eclipse with standard settings for warnings and errors, and I have a lot of warnings in SquidLib (more than 400). This is bad practice, because it makes the list of warnings unusable, in particular when you add a new one, you can't notice it.\r\n\r\nMost of the warnings comes from the Javadoc that is badly formed as follows (taken from `SquidLayers`):\r\n\r\n~~~~ {.java}\r\n    /**\r\n     * The pixel height of the entire map.\r\n     *\r\n     * @return\r\n     */\r\n    @Override\r\n    public float getHeight() {\r\n        return height * cellHeight;\r\n    }\r\n~~~~\r\n\r\nThe javadoc should be written in this manner:\r\n\r\n~~~~ {.java}\r\n    /**\r\n     * @return The pixel height of the entire map.\r\n     */\r\n    @Override\r\n    public float getHeight() {\r\n        return height * cellHeight;\r\n    }\r\n~~~~\r\n\r\nWould it possible to make the removal of these warnings a goal ? I can do it, or if you don't want a massive commit, I would like at least to do it in the classes involved in my pull requests. For the moment, I've been refraining myself, to avoid polluting my PR with too many irrelevant diffs.\r\n\r\nProgressively, we would reach the relevant warnings (for examples there are some about raw types that should be parameterized)."},"comment":{"url":"https://api.github.com/repos/SquidPony/SquidLib/issues/comments/146101986","html_url":"https://github.com/SquidPony/SquidLib/issues/85#issuecomment-146101986","issue_url":"https://api.github.com/repos/SquidPony/SquidLib/issues/85","id":146101986,"user":{"login":"tommyettinger","id":160684,"avatar_url":"https://avatars.githubusercontent.com/u/160684?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyettinger","html_url":"https://github.com/tommyettinger","followers_url":"https://api.github.com/users/tommyettinger/followers","following_url":"https://api.github.com/users/tommyettinger/following{/other_user}","gists_url":"https://api.github.com/users/tommyettinger/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyettinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyettinger/subscriptions","organizations_url":"https://api.github.com/users/tommyettinger/orgs","repos_url":"https://api.github.com/users/tommyettinger/repos","events_url":"https://api.github.com/users/tommyettinger/events{/privacy}","received_events_url":"https://api.github.com/users/tommyettinger/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T07:36:56Z","updated_at":"2015-10-07T07:36:56Z","body":"@smelc Sure, that works for me, but will Maven tolerate that?"}}