{"action":"closed","number":20786,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/20786","id":27076061,"html_url":"https://github.com/rust-lang/rust/pull/20786","diff_url":"https://github.com/rust-lang/rust/pull/20786.diff","patch_url":"https://github.com/rust-lang/rust/pull/20786.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/20786","number":20786,"state":"closed","locked":false,"title":"rustdoc: Stop adding #[deny(warnings)] to all tests","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"body":"Because we are warning about unstable APIs and there are many\r\nof these yet, this creates a high likelyhood doc tests will\r\nfail.\r\n\r\nThis doesn't seem right as a blanket policy to me anyway, though\r\ncertainly we want it in std. Probably more appropriate to add\r\na rustdoc option.","created_at":"2015-01-09T02:14:56Z","updated_at":"2015-01-09T07:00:04Z","closed_at":"2015-01-09T07:00:04Z","merged_at":"2015-01-09T07:00:04Z","merge_commit_sha":"2a1ffafca25ca9a4242b4d5b7fdcac2e5a367a85","assignee":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/20786/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/20786/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/20786/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/a728b4c9b8936ec63f88a3d8a6e5622e43ee4fc5","head":{"label":"brson:rustdocwarnings","ref":"rustdocwarnings","sha":"a728b4c9b8936ec63f88a3d8a6e5622e43ee4fc5","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"repo":{"id":779820,"name":"rust","full_name":"brson/rust","owner":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brson/rust","description":"pursuing the trifecta","fork":true,"url":"https://api.github.com/repos/brson/rust","forks_url":"https://api.github.com/repos/brson/rust/forks","keys_url":"https://api.github.com/repos/brson/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brson/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brson/rust/teams","hooks_url":"https://api.github.com/repos/brson/rust/hooks","issue_events_url":"https://api.github.com/repos/brson/rust/issues/events{/number}","events_url":"https://api.github.com/repos/brson/rust/events","assignees_url":"https://api.github.com/repos/brson/rust/assignees{/user}","branches_url":"https://api.github.com/repos/brson/rust/branches{/branch}","tags_url":"https://api.github.com/repos/brson/rust/tags","blobs_url":"https://api.github.com/repos/brson/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brson/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brson/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/brson/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brson/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/brson/rust/languages","stargazers_url":"https://api.github.com/repos/brson/rust/stargazers","contributors_url":"https://api.github.com/repos/brson/rust/contributors","subscribers_url":"https://api.github.com/repos/brson/rust/subscribers","subscription_url":"https://api.github.com/repos/brson/rust/subscription","commits_url":"https://api.github.com/repos/brson/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/brson/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/brson/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/brson/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/brson/rust/contents/{+path}","compare_url":"https://api.github.com/repos/brson/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brson/rust/merges","archive_url":"https://api.github.com/repos/brson/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brson/rust/downloads","issues_url":"https://api.github.com/repos/brson/rust/issues{/number}","pulls_url":"https://api.github.com/repos/brson/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/brson/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/brson/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brson/rust/labels{/name}","releases_url":"https://api.github.com/repos/brson/rust/releases{/id}","created_at":"2010-07-16T23:45:53Z","updated_at":"2015-01-02T02:35:12Z","pushed_at":"2015-01-09T02:14:43Z","git_url":"git://github.com/brson/rust.git","ssh_url":"git@github.com:brson/rust.git","clone_url":"https://github.com/brson/rust.git","svn_url":"https://github.com/brson/rust","homepage":"http://www.rust-lang.org","size":226055,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"44a287e6eb22ec3c2a687fc156813577464017f7","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments/{number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-01-09T07:00:02Z","pushed_at":"2015-01-09T07:00:00Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":422812,"stargazers_count":8380,"watchers_count":8380,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1633,"mirror_url":null,"open_issues_count":2284,"forks":1633,"open_issues":2284,"watchers":8380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20786"},"html":{"href":"https://github.com/rust-lang/rust/pull/20786"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/20786"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/20786/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20786/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/20786/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/a728b4c9b8936ec63f88a3d8a6e5622e43ee4fc5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}