{"action":"created","issue":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/153","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/153/comments","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/153/events","html_url":"https://github.com/ComputationalRadiationPhysics/libSplash/pull/153","id":56891968,"number":153,"title":"Close #152 Represent Bools as Enums","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"f-schmitt-zih","id":5120640,"avatar_url":"https://avatars.githubusercontent.com/u/5120640?v=3","gravatar_id":"","url":"https://api.github.com/users/f-schmitt-zih","html_url":"https://github.com/f-schmitt-zih","followers_url":"https://api.github.com/users/f-schmitt-zih/followers","following_url":"https://api.github.com/users/f-schmitt-zih/following{/other_user}","gists_url":"https://api.github.com/users/f-schmitt-zih/gists{/gist_id}","starred_url":"https://api.github.com/users/f-schmitt-zih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-schmitt-zih/subscriptions","organizations_url":"https://api.github.com/users/f-schmitt-zih/orgs","repos_url":"https://api.github.com/users/f-schmitt-zih/repos","events_url":"https://api.github.com/users/f-schmitt-zih/events{/privacy}","received_events_url":"https://api.github.com/users/f-schmitt-zih/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/milestones/6","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/milestones/6/labels","id":644611,"number":6,"title":"Version 1.3","description":"","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":11,"state":"open","created_at":"2014-04-30T07:52:09Z","updated_at":"2015-02-09T15:12:40Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-02-07T01:49:34Z","updated_at":"2015-02-10T05:36:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/pulls/153","html_url":"https://github.com/ComputationalRadiationPhysics/libSplash/pull/153","diff_url":"https://github.com/ComputationalRadiationPhysics/libSplash/pull/153.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/libSplash/pull/153.patch"},"body":"Proposal to change the internal representation of `bool` values to be compatible with `h5py` as documented in #152.\r\n\r\n- increases the major file format version since that won't be backwards compatible, e.g., for restarts from files\r\n\r\n### To Do\r\n\r\n- [x] add `h5py` compatibility tests to `.travis.yml` / `./run_tests`\r\n- [x] double-check `sizeof (bool)` which is `1 Byte` vs. real size of `8 Bytes` after conversation - correct in all cases (add a read/write test?)\r\n- [x] actually this is not an API change so `1.2.5` milestone would be ok, too. But it looks a bit odd to make such a change in a `revision` - so go for the `1.3` target version?\r\n- [x] add enum/bool read support (e.g., for restarts)"},"comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/comments/73647313","html_url":"https://github.com/ComputationalRadiationPhysics/libSplash/pull/153#issuecomment-73647313","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/libSplash/issues/153","id":73647313,"user":{"login":"f-schmitt-zih","id":5120640,"avatar_url":"https://avatars.githubusercontent.com/u/5120640?v=3","gravatar_id":"","url":"https://api.github.com/users/f-schmitt-zih","html_url":"https://github.com/f-schmitt-zih","followers_url":"https://api.github.com/users/f-schmitt-zih/followers","following_url":"https://api.github.com/users/f-schmitt-zih/following{/other_user}","gists_url":"https://api.github.com/users/f-schmitt-zih/gists{/gist_id}","starred_url":"https://api.github.com/users/f-schmitt-zih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f-schmitt-zih/subscriptions","organizations_url":"https://api.github.com/users/f-schmitt-zih/orgs","repos_url":"https://api.github.com/users/f-schmitt-zih/repos","events_url":"https://api.github.com/users/f-schmitt-zih/events{/privacy}","received_events_url":"https://api.github.com/users/f-schmitt-zih/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T05:36:43Z","updated_at":"2015-02-10T05:36:43Z","body":"Good job!"}}