{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/43181452","id":43181452,"diff_hunk":"@@ -24,7 +24,7 @@ use CGI::Session::Driver::chi;\n use pf::CHI;\n use HTML::Entities;\n use Locale::gettext qw(bindtextdomain textdomain bind_textdomain_codeset);\n-use Log::Log4perl;\n+use pf::log;","path":"lib/pf/Portal/Session.pm","position":5,"original_position":5,"commit_id":"f51245fec9934e6d22985e30f3d467b5509fe077","original_commit_id":"f51245fec9934e6d22985e30f3d467b5509fe077","user":{"login":"whitx","id":9321079,"avatar_url":"https://avatars.githubusercontent.com/u/9321079?v=3","gravatar_id":"","url":"https://api.github.com/users/whitx","html_url":"https://github.com/whitx","followers_url":"https://api.github.com/users/whitx/followers","following_url":"https://api.github.com/users/whitx/following{/other_user}","gists_url":"https://api.github.com/users/whitx/gists{/gist_id}","starred_url":"https://api.github.com/users/whitx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitx/subscriptions","organizations_url":"https://api.github.com/users/whitx/orgs","repos_url":"https://api.github.com/users/whitx/repos","events_url":"https://api.github.com/users/whitx/events{/privacy}","received_events_url":"https://api.github.com/users/whitx/received_events","type":"User","site_admin":false},"body":"Double call of pf::log","created_at":"2015-10-27T20:27:27Z","updated_at":"2015-10-27T20:27:27Z","html_url":"https://github.com/inverse-inc/packetfence/pull/780#discussion_r43181452","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/43181452"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/780#discussion_r43181452"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780","id":40269428,"html_url":"https://github.com/inverse-inc/packetfence/pull/780","diff_url":"https://github.com/inverse-inc/packetfence/pull/780.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/780.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/780","number":780,"state":"open","locked":false,"title":"Refactor all the logging to use pf::log instead of Log::Log4perl directly","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Description\r\n-----------\r\nRefactor all the logging to use pf::log instead of Log::Log4perl directly\r\n\r\nImpacts\r\n-------\r\nShould be none\r\n\r\n\r\nNEWS file entries\r\n-------\r\nNew Features\r\n++++++++++++\r\n\r\nEnhancements\r\n++++++++++++\r\n* Refactoring and code cleanup\r\n\r\nBug Fixes\r\n+++++++++\r\n\r\n\r\nFixes\r\n--------\r\nFixes #754\r\n\r\nDelete branch after merge\r\n-------------------------\r\nNO","created_at":"2015-07-17T20:41:03Z","updated_at":"2015-10-27T20:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec7cca823f737291eafdcf8ac59d98fb57c01d55","assignee":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/10","html_url":"https://github.com/inverse-inc/packetfence/milestones/PacketFence-5.5","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/10/labels","id":1240756,"number":10,"title":"PacketFence-5.5","description":"","creator":{"login":"louismunro","id":193997,"avatar_url":"https://avatars.githubusercontent.com/u/193997?v=3","gravatar_id":"","url":"https://api.github.com/users/louismunro","html_url":"https://github.com/louismunro","followers_url":"https://api.github.com/users/louismunro/followers","following_url":"https://api.github.com/users/louismunro/following{/other_user}","gists_url":"https://api.github.com/users/louismunro/gists{/gist_id}","starred_url":"https://api.github.com/users/louismunro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louismunro/subscriptions","organizations_url":"https://api.github.com/users/louismunro/orgs","repos_url":"https://api.github.com/users/louismunro/repos","events_url":"https://api.github.com/users/louismunro/events{/privacy}","received_events_url":"https://api.github.com/users/louismunro/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":18,"state":"open","created_at":"2015-08-04T18:46:01Z","updated_at":"2015-10-27T17:59:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/780/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/f51245fec9934e6d22985e30f3d467b5509fe077","head":{"label":"jrouzierinverse:feature/move-to-pf-log","ref":"feature/move-to-pf-log","sha":"f51245fec9934e6d22985e30f3d467b5509fe077","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"repo":{"id":6552051,"name":"packetfence","full_name":"jrouzierinverse/packetfence","owner":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrouzierinverse/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/jrouzierinverse/packetfence","forks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/forks","keys_url":"https://api.github.com/repos/jrouzierinverse/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrouzierinverse/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrouzierinverse/packetfence/teams","hooks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/hooks","issue_events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/events","assignees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/jrouzierinverse/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/tags","blobs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrouzierinverse/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/jrouzierinverse/packetfence/languages","stargazers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/stargazers","contributors_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contributors","subscribers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscribers","subscription_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscription","commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrouzierinverse/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/jrouzierinverse/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrouzierinverse/packetfence/merges","archive_url":"https://api.github.com/repos/jrouzierinverse/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrouzierinverse/packetfence/downloads","issues_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/jrouzierinverse/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/jrouzierinverse/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/jrouzierinverse/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrouzierinverse/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/jrouzierinverse/packetfence/releases{/id}","created_at":"2012-11-05T21:28:44Z","updated_at":"2014-09-04T14:49:59Z","pushed_at":"2015-10-26T13:50:10Z","git_url":"git://github.com/jrouzierinverse/packetfence.git","ssh_url":"git@github.com:jrouzierinverse/packetfence.git","clone_url":"https://github.com/jrouzierinverse/packetfence.git","svn_url":"https://github.com/jrouzierinverse/packetfence","homepage":"http://www.packetfence.org","size":142761,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"6a362a6cc6cc493dc67705f528d3ba86e3556fcd","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","created_at":"2012-03-01T20:21:13Z","updated_at":"2015-10-24T08:58:36Z","pushed_at":"2015-10-27T19:41:36Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":169030,"stargazers_count":141,"watchers_count":141,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":175,"forks":70,"open_issues":175,"watchers":141,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/780"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/780"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/780/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/780/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/f51245fec9934e6d22985e30f3d467b5509fe077"}}}}