{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45285946","id":45285946,"diff_hunk":"@@ -18,57 +18,179 @@ package e2e\n \n import (\n \t\"fmt\"\n+\t\"strings\"\n \n \t\"k8s.io/kubernetes/pkg/api\"\n \t\"k8s.io/kubernetes/pkg/util\"\n \n \t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n )\n \n+var timeOut = \"15s\"\n+var pollingInterval = \"3s\"","path":"test/e2e/downwardapi_volume.go","position":14,"original_position":14,"commit_id":"3770da5d0483661c6464b3a5047305a0ea29ea47","original_commit_id":"3770da5d0483661c6464b3a5047305a0ea29ea47","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"maybe just use the `poll` value defined in util.go?","created_at":"2015-11-19T00:59:20Z","updated_at":"2015-11-19T00:59:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/15502#discussion_r45285946","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/45285946"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15502#discussion_r45285946"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502","id":47466844,"html_url":"https://github.com/kubernetes/kubernetes/pull/15502","diff_url":"https://github.com/kubernetes/kubernetes/pull/15502.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/15502.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15502","number":15502,"state":"open","locked":false,"title":"downward api volume test e2e: update labels and annotations","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"body":"Adding e2e test for downward api volume plugin. To fix #14581","created_at":"2015-10-12T21:32:13Z","updated_at":"2015-11-19T00:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca82415483fa03d154876d04ee17a5b8f20fa491","assignee":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars.githubusercontent.com/u/8061296?v=3","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/15502/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3770da5d0483661c6464b3a5047305a0ea29ea47","head":{"label":"sdminonne:downwardapi_volume","ref":"downwardapi_volume","sha":"3770da5d0483661c6464b3a5047305a0ea29ea47","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":27047169,"name":"kubernetes","full_name":"sdminonne/kubernetes","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars.githubusercontent.com/u/9527409?v=3","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sdminonne/kubernetes","forks_url":"https://api.github.com/repos/sdminonne/kubernetes/forks","keys_url":"https://api.github.com/repos/sdminonne/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/kubernetes/teams","hooks_url":"https://api.github.com/repos/sdminonne/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/kubernetes/events","assignees_url":"https://api.github.com/repos/sdminonne/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/kubernetes/tags","blobs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sdminonne/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/kubernetes/subscription","commits_url":"https://api.github.com/repos/sdminonne/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdminonne/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/kubernetes/merges","archive_url":"https://api.github.com/repos/sdminonne/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/kubernetes/downloads","issues_url":"https://api.github.com/repos/sdminonne/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/kubernetes/releases{/id}","created_at":"2014-11-23T20:52:45Z","updated_at":"2015-05-06T22:08:25Z","pushed_at":"2015-11-18T14:07:55Z","git_url":"git://github.com/sdminonne/kubernetes.git","ssh_url":"git@github.com:sdminonne/kubernetes.git","clone_url":"https://github.com/sdminonne/kubernetes.git","svn_url":"https://github.com/sdminonne/kubernetes","homepage":null,"size":133413,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2a929883929e64ab2cab2192ae7606de18426e36","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-18T23:43:04Z","pushed_at":"2015-11-19T00:52:24Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":288204,"stargazers_count":11327,"watchers_count":11327,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2997,"mirror_url":null,"open_issues_count":2355,"forks":2997,"open_issues":2355,"watchers":11327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/15502"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15502"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/15502/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/15502/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3770da5d0483661c6464b3a5047305a0ea29ea47"}}}}