{"action":"closed","issue":{"url":"https://api.github.com/repos/wtsi-hgi/treeserve/issues/17","labels_url":"https://api.github.com/repos/wtsi-hgi/treeserve/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/wtsi-hgi/treeserve/issues/17/comments","events_url":"https://api.github.com/repos/wtsi-hgi/treeserve/issues/17/events","html_url":"https://github.com/wtsi-hgi/treeserve/issues/17","id":59309549,"number":17,"title":"json library uses huge amounts of memory","user":{"login":"emyr666","id":1455306,"avatar_url":"https://avatars.githubusercontent.com/u/1455306?v=3","gravatar_id":"","url":"https://api.github.com/users/emyr666","html_url":"https://github.com/emyr666","followers_url":"https://api.github.com/users/emyr666/followers","following_url":"https://api.github.com/users/emyr666/following{/other_user}","gists_url":"https://api.github.com/users/emyr666/gists{/gist_id}","starred_url":"https://api.github.com/users/emyr666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emyr666/subscriptions","organizations_url":"https://api.github.com/users/emyr666/orgs","repos_url":"https://api.github.com/users/emyr666/repos","events_url":"https://api.github.com/users/emyr666/events{/privacy}","received_events_url":"https://api.github.com/users/emyr666/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wtsi-hgi/treeserve/labels/invalid","name":"invalid","color":"e6e6e6"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-27T23:26:56Z","updated_at":"2015-03-01T09:26:16Z","closed_at":"2015-03-01T09:26:16Z","body":"I ran the proxygen branch version of testTree with and without the line that prints out the json.\r\n\r\nThis is the valgrind output without the json line...\r\n\r\n==6091== HEAP SUMMARY:\r\n==6091==     in use at exit: 0 bytes in 0 blocks\r\n==6091==   total heap usage: 107 allocs, 107 frees, 4,327 bytes allocate\r\n\r\nand with...\r\n\r\n==6075== HEAP SUMMARY:\r\n==6075==     in use at exit: 0 bytes in 0 blocks\r\n==6075==   total heap usage: 1,721 allocs, 1,721 frees, 103,331 bytes allocated\r\n\r\nI suspect that now we have the structure pretty much finalised, more streamlined toJSON functions could be written that aren't so bloaty. It's possible that the troubles we are having with fossa may actually be due to this, not the http layer. In any case, I will be rolling in the proxygen http library as it seems to be more featureful and standards compliant."}}