{"action":"created","issue":{"url":"https://api.github.com/repos/antecedent/patchwork/issues/29","labels_url":"https://api.github.com/repos/antecedent/patchwork/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/antecedent/patchwork/issues/29/comments","events_url":"https://api.github.com/repos/antecedent/patchwork/issues/29/events","html_url":"https://github.com/antecedent/patchwork/pull/29","id":109625959,"number":29,"title":"Fix return values from patched functions on HHVM","user":{"login":"rarescosma","id":520445,"avatar_url":"https://avatars.githubusercontent.com/u/520445?v=3","gravatar_id":"","url":"https://api.github.com/users/rarescosma","html_url":"https://github.com/rarescosma","followers_url":"https://api.github.com/users/rarescosma/followers","following_url":"https://api.github.com/users/rarescosma/following{/other_user}","gists_url":"https://api.github.com/users/rarescosma/gists{/gist_id}","starred_url":"https://api.github.com/users/rarescosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rarescosma/subscriptions","organizations_url":"https://api.github.com/users/rarescosma/orgs","repos_url":"https://api.github.com/users/rarescosma/repos","events_url":"https://api.github.com/users/rarescosma/events{/privacy}","received_events_url":"https://api.github.com/users/rarescosma/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-03T14:43:28Z","updated_at":"2015-10-09T18:41:26Z","closed_at":"2015-10-06T06:43:38Z","pull_request":{"url":"https://api.github.com/repos/antecedent/patchwork/pulls/29","html_url":"https://github.com/antecedent/patchwork/pull/29","diff_url":"https://github.com/antecedent/patchwork/pull/29.diff","patch_url":"https://github.com/antecedent/patchwork/pull/29.patch"},"body":"```\r\n$ php --version\r\nHipHop VM 3.9.1 (rel)\r\nCompiler: tags/HHVM-3.9.1-0-g0f72cfc2f0a01fdfeb72fbcfeb247b72998a66db\r\nRepo schema: 6416960c150a4a4726fda74b659105ded8819d9c\r\n```\r\n\r\nWhen running our phpunit test suite on HHVM we noticed a bunch of failures and notices. A little digging proved that return values from functions patched with Patchwork were always `null`. \r\n\r\nTurns out the `$result` is not initialized and returned properly in the `fb_intercept` closure. This is what the patch addresses. \r\n"},"comment":{"url":"https://api.github.com/repos/antecedent/patchwork/issues/comments/146957703","html_url":"https://github.com/antecedent/patchwork/pull/29#issuecomment-146957703","issue_url":"https://api.github.com/repos/antecedent/patchwork/issues/29","id":146957703,"user":{"login":"antecedent","id":388219,"avatar_url":"https://avatars.githubusercontent.com/u/388219?v=3","gravatar_id":"","url":"https://api.github.com/users/antecedent","html_url":"https://github.com/antecedent","followers_url":"https://api.github.com/users/antecedent/followers","following_url":"https://api.github.com/users/antecedent/following{/other_user}","gists_url":"https://api.github.com/users/antecedent/gists{/gist_id}","starred_url":"https://api.github.com/users/antecedent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antecedent/subscriptions","organizations_url":"https://api.github.com/users/antecedent/orgs","repos_url":"https://api.github.com/users/antecedent/repos","events_url":"https://api.github.com/users/antecedent/events{/privacy}","received_events_url":"https://api.github.com/users/antecedent/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T18:41:26Z","updated_at":"2015-10-09T18:41:26Z","body":"Version 1.3.5 has just been tagged :)"}}