{"action":"opened","number":60,"pull_request":{"url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60","id":36607276,"html_url":"https://github.com/alphagov/tsuru-ansible/pull/60","diff_url":"https://github.com/alphagov/tsuru-ansible/pull/60.diff","patch_url":"https://github.com/alphagov/tsuru-ansible/pull/60.patch","issue_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/60","number":60,"state":"open","locked":false,"title":"Refactor Makefile","user":{"login":"dcarley","id":260438,"avatar_url":"https://avatars.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false},"body":"No functional changes.\r\n\r\n---\r\n\r\n#### Makefile: Hard wrap long lines …\r\nSo that they're easier to read. The groupings in `.PHONY` are logical.\r\n\r\n#### Makefile: Move common deps to \"preflight\" target …\r\nSo that it's easy to see what dependencies are common between aws/gce.\r\n\r\n#### Makefile: break AWS check to separate target …\r\nTo match `check-env-var` and make the gce/aws targets look similar.\r\n\r\n#### Makefile: move ansible-playbook command to macro …\r\nSo that we don't duplicate the argument structure between aws/gce.","created_at":"2015-06-01T08:20:13Z","updated_at":"2015-06-01T08:20:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60/commits","review_comments_url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60/comments","review_comment_url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/60/comments","statuses_url":"https://api.github.com/repos/alphagov/tsuru-ansible/statuses/b56977c035cbe34d62597e685489c7e853f9bc64","head":{"label":"alphagov:makefile_refactor","ref":"makefile_refactor","sha":"b56977c035cbe34d62597e685489c7e853f9bc64","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":33112330,"name":"tsuru-ansible","full_name":"alphagov/tsuru-ansible","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/tsuru-ansible","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/tsuru-ansible","forks_url":"https://api.github.com/repos/alphagov/tsuru-ansible/forks","keys_url":"https://api.github.com/repos/alphagov/tsuru-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/tsuru-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/tsuru-ansible/teams","hooks_url":"https://api.github.com/repos/alphagov/tsuru-ansible/hooks","issue_events_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/tsuru-ansible/events","assignees_url":"https://api.github.com/repos/alphagov/tsuru-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/tsuru-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/tsuru-ansible/tags","blobs_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/tsuru-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/tsuru-ansible/languages","stargazers_url":"https://api.github.com/repos/alphagov/tsuru-ansible/stargazers","contributors_url":"https://api.github.com/repos/alphagov/tsuru-ansible/contributors","subscribers_url":"https://api.github.com/repos/alphagov/tsuru-ansible/subscribers","subscription_url":"https://api.github.com/repos/alphagov/tsuru-ansible/subscription","commits_url":"https://api.github.com/repos/alphagov/tsuru-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/tsuru-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/tsuru-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/tsuru-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/tsuru-ansible/merges","archive_url":"https://api.github.com/repos/alphagov/tsuru-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/tsuru-ansible/downloads","issues_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/tsuru-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/tsuru-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/tsuru-ansible/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/tsuru-ansible/releases{/id}","created_at":"2015-03-30T08:46:53Z","updated_at":"2015-05-19T18:16:22Z","pushed_at":"2015-06-01T08:18:50Z","git_url":"git://github.com/alphagov/tsuru-ansible.git","ssh_url":"git@github.com:alphagov/tsuru-ansible.git","clone_url":"https://github.com/alphagov/tsuru-ansible.git","svn_url":"https://github.com/alphagov/tsuru-ansible","homepage":null,"size":1176,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"147bd19561949c13143589fb6ddf6508b2195626","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":33112330,"name":"tsuru-ansible","full_name":"alphagov/tsuru-ansible","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/tsuru-ansible","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/tsuru-ansible","forks_url":"https://api.github.com/repos/alphagov/tsuru-ansible/forks","keys_url":"https://api.github.com/repos/alphagov/tsuru-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/tsuru-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/tsuru-ansible/teams","hooks_url":"https://api.github.com/repos/alphagov/tsuru-ansible/hooks","issue_events_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/tsuru-ansible/events","assignees_url":"https://api.github.com/repos/alphagov/tsuru-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/tsuru-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/tsuru-ansible/tags","blobs_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/tsuru-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/tsuru-ansible/languages","stargazers_url":"https://api.github.com/repos/alphagov/tsuru-ansible/stargazers","contributors_url":"https://api.github.com/repos/alphagov/tsuru-ansible/contributors","subscribers_url":"https://api.github.com/repos/alphagov/tsuru-ansible/subscribers","subscription_url":"https://api.github.com/repos/alphagov/tsuru-ansible/subscription","commits_url":"https://api.github.com/repos/alphagov/tsuru-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/tsuru-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/tsuru-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/tsuru-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/tsuru-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/tsuru-ansible/merges","archive_url":"https://api.github.com/repos/alphagov/tsuru-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/tsuru-ansible/downloads","issues_url":"https://api.github.com/repos/alphagov/tsuru-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/tsuru-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/tsuru-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/tsuru-ansible/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/tsuru-ansible/releases{/id}","created_at":"2015-03-30T08:46:53Z","updated_at":"2015-05-19T18:16:22Z","pushed_at":"2015-06-01T08:18:50Z","git_url":"git://github.com/alphagov/tsuru-ansible.git","ssh_url":"git@github.com:alphagov/tsuru-ansible.git","clone_url":"https://github.com/alphagov/tsuru-ansible.git","svn_url":"https://github.com/alphagov/tsuru-ansible","homepage":null,"size":1176,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60"},"html":{"href":"https://github.com/alphagov/tsuru-ansible/pull/60"},"issue":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/60"},"comments":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/tsuru-ansible/statuses/b56977c035cbe34d62597e685489c7e853f9bc64"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":28,"deletions":9,"changed_files":1}}