{"action":"created","comment":{"url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/comments/40510714","id":40510714,"diff_hunk":"@@ -1,10 +1,20 @@\n-if (phantom.args.length != 1) {\n-    console.log('Expected a target URL parameter.');\n-    phantom.exit(1);\n+console.log(\"Phantom version: \" + phantom.version.major + \".\" + phantom.version.minor + \".\" +  phantom.version.patch);\n+if (phantom.version.major > 1) {\n+    var args = require('system').args;\n+    if (args.length < 2) {\n+        console.log('Expected a target URL parameter.');\n+        phantom.exit(1);\n+    }\n+    var url = require('system').args[1];\n+} else {\n+    if (phantom.args.length < 1) {\n+        console.log('Expected a target URL parameter.');\n+        phantom.exit(1);\n+    }\n+    var url = phantom.args[0];","path":"example-projects/advanced/phantom/repl.js","position":17,"original_position":17,"commit_id":"e404ff5830a8103f2be28f0abd2883b9024b2db2","original_commit_id":"e404ff5830a8103f2be28f0abd2883b9024b2db2","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"body":"Ok will do","created_at":"2015-09-27T22:27:22Z","updated_at":"2015-09-27T22:27:22Z","html_url":"https://github.com/emezeske/lein-cljsbuild/pull/415#discussion_r40510714","pull_request_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415","_links":{"self":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/comments/40510714"},"html":{"href":"https://github.com/emezeske/lein-cljsbuild/pull/415#discussion_r40510714"},"pull_request":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415"}}},"pull_request":{"url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415","id":45964703,"html_url":"https://github.com/emezeske/lein-cljsbuild/pull/415","diff_url":"https://github.com/emezeske/lein-cljsbuild/pull/415.diff","patch_url":"https://github.com/emezeske/lein-cljsbuild/pull/415.patch","issue_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/415","number":415,"state":"open","locked":false,"title":"Accomodate js advanced sample files to handle phantom 2.0","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"body":"According to the final comment in this [blog post](https://nvbn.github.io/2015/06/08/cljs-test/) (Give back to Caesar what is Caesar's) I modified the advanced example in order to comply with the new way the ```phantom``` object is instrumented.\r\n\r\nI hope everything is ok. I tried, no issue.","created_at":"2015-09-25T00:05:13Z","updated_at":"2015-09-27T22:27:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f0bc93421427a1c629da01ddf4dbe9dba0d08ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415/commits","review_comments_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415/comments","review_comment_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/415/comments","statuses_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/statuses/e404ff5830a8103f2be28f0abd2883b9024b2db2","head":{"label":"arichiardi:master","ref":"master","sha":"e404ff5830a8103f2be28f0abd2883b9024b2db2","user":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"repo":{"id":43098587,"name":"lein-cljsbuild","full_name":"arichiardi/lein-cljsbuild","owner":{"login":"arichiardi","id":1724788,"avatar_url":"https://avatars.githubusercontent.com/u/1724788?v=3","gravatar_id":"","url":"https://api.github.com/users/arichiardi","html_url":"https://github.com/arichiardi","followers_url":"https://api.github.com/users/arichiardi/followers","following_url":"https://api.github.com/users/arichiardi/following{/other_user}","gists_url":"https://api.github.com/users/arichiardi/gists{/gist_id}","starred_url":"https://api.github.com/users/arichiardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichiardi/subscriptions","organizations_url":"https://api.github.com/users/arichiardi/orgs","repos_url":"https://api.github.com/users/arichiardi/repos","events_url":"https://api.github.com/users/arichiardi/events{/privacy}","received_events_url":"https://api.github.com/users/arichiardi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arichiardi/lein-cljsbuild","description":"Leiningen plugin to make ClojureScript development easy.","fork":true,"url":"https://api.github.com/repos/arichiardi/lein-cljsbuild","forks_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/forks","keys_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/teams","hooks_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/hooks","issue_events_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/issues/events{/number}","events_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/events","assignees_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/assignees{/user}","branches_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/branches{/branch}","tags_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/tags","blobs_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/languages","stargazers_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/stargazers","contributors_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/contributors","subscribers_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/subscribers","subscription_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/subscription","commits_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/contents/{+path}","compare_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/merges","archive_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/downloads","issues_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/issues{/number}","pulls_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/labels{/name}","releases_url":"https://api.github.com/repos/arichiardi/lein-cljsbuild/releases{/id}","created_at":"2015-09-24T23:32:03Z","updated_at":"2015-09-24T23:32:03Z","pushed_at":"2015-09-24T23:59:05Z","git_url":"git://github.com/arichiardi/lein-cljsbuild.git","ssh_url":"git@github.com:arichiardi/lein-cljsbuild.git","clone_url":"https://github.com/arichiardi/lein-cljsbuild.git","svn_url":"https://github.com/arichiardi/lein-cljsbuild","homepage":"","size":826,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emezeske:master","ref":"master","sha":"b866dfa95df688fe83ffed2c758a4dc19b3fc100","user":{"login":"emezeske","id":59582,"avatar_url":"https://avatars.githubusercontent.com/u/59582?v=3","gravatar_id":"","url":"https://api.github.com/users/emezeske","html_url":"https://github.com/emezeske","followers_url":"https://api.github.com/users/emezeske/followers","following_url":"https://api.github.com/users/emezeske/following{/other_user}","gists_url":"https://api.github.com/users/emezeske/gists{/gist_id}","starred_url":"https://api.github.com/users/emezeske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emezeske/subscriptions","organizations_url":"https://api.github.com/users/emezeske/orgs","repos_url":"https://api.github.com/users/emezeske/repos","events_url":"https://api.github.com/users/emezeske/events{/privacy}","received_events_url":"https://api.github.com/users/emezeske/received_events","type":"User","site_admin":false},"repo":{"id":3067051,"name":"lein-cljsbuild","full_name":"emezeske/lein-cljsbuild","owner":{"login":"emezeske","id":59582,"avatar_url":"https://avatars.githubusercontent.com/u/59582?v=3","gravatar_id":"","url":"https://api.github.com/users/emezeske","html_url":"https://github.com/emezeske","followers_url":"https://api.github.com/users/emezeske/followers","following_url":"https://api.github.com/users/emezeske/following{/other_user}","gists_url":"https://api.github.com/users/emezeske/gists{/gist_id}","starred_url":"https://api.github.com/users/emezeske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emezeske/subscriptions","organizations_url":"https://api.github.com/users/emezeske/orgs","repos_url":"https://api.github.com/users/emezeske/repos","events_url":"https://api.github.com/users/emezeske/events{/privacy}","received_events_url":"https://api.github.com/users/emezeske/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emezeske/lein-cljsbuild","description":"Leiningen plugin to make ClojureScript development easy.","fork":false,"url":"https://api.github.com/repos/emezeske/lein-cljsbuild","forks_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/forks","keys_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/teams","hooks_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/hooks","issue_events_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/events{/number}","events_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/events","assignees_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/assignees{/user}","branches_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/branches{/branch}","tags_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/tags","blobs_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/languages","stargazers_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/stargazers","contributors_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/contributors","subscribers_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/subscribers","subscription_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/subscription","commits_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/contents/{+path}","compare_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/merges","archive_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/downloads","issues_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues{/number}","pulls_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/labels{/name}","releases_url":"https://api.github.com/repos/emezeske/lein-cljsbuild/releases{/id}","created_at":"2011-12-29T05:16:58Z","updated_at":"2015-09-26T11:17:43Z","pushed_at":"2015-09-25T11:14:40Z","git_url":"git://github.com/emezeske/lein-cljsbuild.git","ssh_url":"git@github.com:emezeske/lein-cljsbuild.git","clone_url":"https://github.com/emezeske/lein-cljsbuild.git","svn_url":"https://github.com/emezeske/lein-cljsbuild","homepage":"","size":2212,"stargazers_count":766,"watchers_count":766,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":31,"forks":141,"open_issues":31,"watchers":766,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415"},"html":{"href":"https://github.com/emezeske/lein-cljsbuild/pull/415"},"issue":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/415"},"comments":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/emezeske/lein-cljsbuild/statuses/e404ff5830a8103f2be28f0abd2883b9024b2db2"}}}}