{"comment":{"url":"https://api.github.com/repos/eyakubovich/cni/comments/11272388","html_url":"https://github.com/eyakubovich/cni/commit/f088f60707aa1955a711ea8d3084377d8c968d17#commitcomment-11272388","id":11272388,"user":{"login":"marineam","id":153640,"avatar_url":"https://avatars.githubusercontent.com/u/153640?v=3","gravatar_id":"","url":"https://api.github.com/users/marineam","html_url":"https://github.com/marineam","followers_url":"https://api.github.com/users/marineam/followers","following_url":"https://api.github.com/users/marineam/following{/other_user}","gists_url":"https://api.github.com/users/marineam/gists{/gist_id}","starred_url":"https://api.github.com/users/marineam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marineam/subscriptions","organizations_url":"https://api.github.com/users/marineam/orgs","repos_url":"https://api.github.com/users/marineam/repos","events_url":"https://api.github.com/users/marineam/events{/privacy}","received_events_url":"https://api.github.com/users/marineam/received_events","type":"User","site_admin":false},"position":132,"line":132,"path":"plugins/ipam/dhcp/daemon.go","commit_id":"f088f60707aa1955a711ea8d3084377d8c968d17","created_at":"2015-05-19T22:03:27Z","updated_at":"2015-05-19T22:03:27Z","body":"You allow lfds to be more than 1 but you only use one. Unless you implement more than one asserting `lfds == 1` is probably best. Also a better error message than `LISTEN_FDS < 1` would be good considering from the name it isn't obvious whether LISTEN_FDS is a number of file descriptors (which it is) or a list of file descriptors (which is what I would have guessed)."}}