{"action":"created","comment":{"url":"https://api.github.com/repos/embox/embox/pulls/comments/34787152","id":34787152,"diff_hunk":"@@ -0,0 +1,14 @@\n+/**\n+ * @file\n+ * @brief Banana Pi interrupt controller HAL definitions.\n+ *\n+ * @date 15.04.15\n+ * @author Dmitrii Petukhov\n+ */\n+\n+#ifndef IRQCTRL_BPI_INTC_IMPL_H_\n+#define IRQCTRL_BPI_INTC_IMPL_H_\n+\n+#define __IRQCTRL_IRQS_TOTAL 123","path":"src/drivers/interrupt/bpi_intc.h","position":12,"original_position":12,"commit_id":"196e09ebb26067e9c58112b58baea43b1a2def7b","original_commit_id":"196e09ebb26067e9c58112b58baea43b1a2def7b","user":{"login":"abusalimov","id":530396,"avatar_url":"https://avatars.githubusercontent.com/u/530396?v=3","gravatar_id":"","url":"https://api.github.com/users/abusalimov","html_url":"https://github.com/abusalimov","followers_url":"https://api.github.com/users/abusalimov/followers","following_url":"https://api.github.com/users/abusalimov/following{/other_user}","gists_url":"https://api.github.com/users/abusalimov/gists{/gist_id}","starred_url":"https://api.github.com/users/abusalimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abusalimov/subscriptions","organizations_url":"https://api.github.com/users/abusalimov/orgs","repos_url":"https://api.github.com/users/abusalimov/repos","events_url":"https://api.github.com/users/abusalimov/events{/privacy}","received_events_url":"https://api.github.com/users/abusalimov/received_events","type":"User","site_admin":false},"body":"Are there really 123 interrupt lines? If so, why do `irqctrl_xxx` methods contain `assert(interrupt_nr < 16);`?","created_at":"2015-07-16T13:38:17Z","updated_at":"2015-07-16T13:38:17Z","html_url":"https://github.com/embox/embox/pull/745#discussion_r34787152","pull_request_url":"https://api.github.com/repos/embox/embox/pulls/745","_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/comments/34787152"},"html":{"href":"https://github.com/embox/embox/pull/745#discussion_r34787152"},"pull_request":{"href":"https://api.github.com/repos/embox/embox/pulls/745"}}},"pull_request":{"url":"https://api.github.com/repos/embox/embox/pulls/745","id":34488905,"html_url":"https://github.com/embox/embox/pull/745","diff_url":"https://github.com/embox/embox/pull/745.diff","patch_url":"https://github.com/embox/embox/pull/745.patch","issue_url":"https://api.github.com/repos/embox/embox/issues/745","number":745,"state":"open","locked":false,"title":"BananaPi port: working SGI","user":{"login":"dimart","id":2109133,"avatar_url":"https://avatars.githubusercontent.com/u/2109133?v=3","gravatar_id":"","url":"https://api.github.com/users/dimart","html_url":"https://github.com/dimart","followers_url":"https://api.github.com/users/dimart/followers","following_url":"https://api.github.com/users/dimart/following{/other_user}","gists_url":"https://api.github.com/users/dimart/gists{/gist_id}","starred_url":"https://api.github.com/users/dimart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimart/subscriptions","organizations_url":"https://api.github.com/users/dimart/orgs","repos_url":"https://api.github.com/users/dimart/repos","events_url":"https://api.github.com/users/dimart/events{/privacy}","received_events_url":"https://api.github.com/users/dimart/received_events","type":"User","site_admin":false},"body":"As discussed, this change provides basic support for SGI on BananaPi, successfully passing all IRQ tests.","created_at":"2015-04-30T18:44:23Z","updated_at":"2015-07-16T13:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0687263df14cb6e08d7114a8a4d855be75dd250b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/embox/embox/pulls/745/commits","review_comments_url":"https://api.github.com/repos/embox/embox/pulls/745/comments","review_comment_url":"https://api.github.com/repos/embox/embox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/embox/embox/issues/745/comments","statuses_url":"https://api.github.com/repos/embox/embox/statuses/196e09ebb26067e9c58112b58baea43b1a2def7b","head":{"label":"dimart:feature-bpi-gic-driver","ref":"feature-bpi-gic-driver","sha":"196e09ebb26067e9c58112b58baea43b1a2def7b","user":{"login":"dimart","id":2109133,"avatar_url":"https://avatars.githubusercontent.com/u/2109133?v=3","gravatar_id":"","url":"https://api.github.com/users/dimart","html_url":"https://github.com/dimart","followers_url":"https://api.github.com/users/dimart/followers","following_url":"https://api.github.com/users/dimart/following{/other_user}","gists_url":"https://api.github.com/users/dimart/gists{/gist_id}","starred_url":"https://api.github.com/users/dimart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimart/subscriptions","organizations_url":"https://api.github.com/users/dimart/orgs","repos_url":"https://api.github.com/users/dimart/repos","events_url":"https://api.github.com/users/dimart/events{/privacy}","received_events_url":"https://api.github.com/users/dimart/received_events","type":"User","site_admin":false},"repo":{"id":34004758,"name":"embox","full_name":"dimart/embox","owner":{"login":"dimart","id":2109133,"avatar_url":"https://avatars.githubusercontent.com/u/2109133?v=3","gravatar_id":"","url":"https://api.github.com/users/dimart","html_url":"https://github.com/dimart","followers_url":"https://api.github.com/users/dimart/followers","following_url":"https://api.github.com/users/dimart/following{/other_user}","gists_url":"https://api.github.com/users/dimart/gists{/gist_id}","starred_url":"https://api.github.com/users/dimart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimart/subscriptions","organizations_url":"https://api.github.com/users/dimart/orgs","repos_url":"https://api.github.com/users/dimart/repos","events_url":"https://api.github.com/users/dimart/events{/privacy}","received_events_url":"https://api.github.com/users/dimart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimart/embox","description":"OS Kernel","fork":true,"url":"https://api.github.com/repos/dimart/embox","forks_url":"https://api.github.com/repos/dimart/embox/forks","keys_url":"https://api.github.com/repos/dimart/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimart/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimart/embox/teams","hooks_url":"https://api.github.com/repos/dimart/embox/hooks","issue_events_url":"https://api.github.com/repos/dimart/embox/issues/events{/number}","events_url":"https://api.github.com/repos/dimart/embox/events","assignees_url":"https://api.github.com/repos/dimart/embox/assignees{/user}","branches_url":"https://api.github.com/repos/dimart/embox/branches{/branch}","tags_url":"https://api.github.com/repos/dimart/embox/tags","blobs_url":"https://api.github.com/repos/dimart/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimart/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimart/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimart/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimart/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/dimart/embox/languages","stargazers_url":"https://api.github.com/repos/dimart/embox/stargazers","contributors_url":"https://api.github.com/repos/dimart/embox/contributors","subscribers_url":"https://api.github.com/repos/dimart/embox/subscribers","subscription_url":"https://api.github.com/repos/dimart/embox/subscription","commits_url":"https://api.github.com/repos/dimart/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimart/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimart/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimart/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimart/embox/contents/{+path}","compare_url":"https://api.github.com/repos/dimart/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimart/embox/merges","archive_url":"https://api.github.com/repos/dimart/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimart/embox/downloads","issues_url":"https://api.github.com/repos/dimart/embox/issues{/number}","pulls_url":"https://api.github.com/repos/dimart/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/dimart/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/dimart/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimart/embox/labels{/name}","releases_url":"https://api.github.com/repos/dimart/embox/releases{/id}","created_at":"2015-04-15T16:11:52Z","updated_at":"2015-04-30T18:13:19Z","pushed_at":"2015-07-16T13:23:22Z","git_url":"git://github.com/dimart/embox.git","ssh_url":"git@github.com:dimart/embox.git","clone_url":"https://github.com/dimart/embox.git","svn_url":"https://github.com/dimart/embox","homepage":"","size":19715,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"embox:master","ref":"master","sha":"2561601aa302ef4479af3f48db6feb04d815c76e","user":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"repo":{"id":33078138,"name":"embox","full_name":"embox/embox","owner":{"login":"embox","id":9039916,"avatar_url":"https://avatars.githubusercontent.com/u/9039916?v=3","gravatar_id":"","url":"https://api.github.com/users/embox","html_url":"https://github.com/embox","followers_url":"https://api.github.com/users/embox/followers","following_url":"https://api.github.com/users/embox/following{/other_user}","gists_url":"https://api.github.com/users/embox/gists{/gist_id}","starred_url":"https://api.github.com/users/embox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embox/subscriptions","organizations_url":"https://api.github.com/users/embox/orgs","repos_url":"https://api.github.com/users/embox/repos","events_url":"https://api.github.com/users/embox/events{/privacy}","received_events_url":"https://api.github.com/users/embox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/embox/embox","description":"The OS Kernel","fork":false,"url":"https://api.github.com/repos/embox/embox","forks_url":"https://api.github.com/repos/embox/embox/forks","keys_url":"https://api.github.com/repos/embox/embox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/embox/embox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/embox/embox/teams","hooks_url":"https://api.github.com/repos/embox/embox/hooks","issue_events_url":"https://api.github.com/repos/embox/embox/issues/events{/number}","events_url":"https://api.github.com/repos/embox/embox/events","assignees_url":"https://api.github.com/repos/embox/embox/assignees{/user}","branches_url":"https://api.github.com/repos/embox/embox/branches{/branch}","tags_url":"https://api.github.com/repos/embox/embox/tags","blobs_url":"https://api.github.com/repos/embox/embox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/embox/embox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/embox/embox/git/refs{/sha}","trees_url":"https://api.github.com/repos/embox/embox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/embox/embox/statuses/{sha}","languages_url":"https://api.github.com/repos/embox/embox/languages","stargazers_url":"https://api.github.com/repos/embox/embox/stargazers","contributors_url":"https://api.github.com/repos/embox/embox/contributors","subscribers_url":"https://api.github.com/repos/embox/embox/subscribers","subscription_url":"https://api.github.com/repos/embox/embox/subscription","commits_url":"https://api.github.com/repos/embox/embox/commits{/sha}","git_commits_url":"https://api.github.com/repos/embox/embox/git/commits{/sha}","comments_url":"https://api.github.com/repos/embox/embox/comments{/number}","issue_comment_url":"https://api.github.com/repos/embox/embox/issues/comments{/number}","contents_url":"https://api.github.com/repos/embox/embox/contents/{+path}","compare_url":"https://api.github.com/repos/embox/embox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/embox/embox/merges","archive_url":"https://api.github.com/repos/embox/embox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/embox/embox/downloads","issues_url":"https://api.github.com/repos/embox/embox/issues{/number}","pulls_url":"https://api.github.com/repos/embox/embox/pulls{/number}","milestones_url":"https://api.github.com/repos/embox/embox/milestones{/number}","notifications_url":"https://api.github.com/repos/embox/embox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/embox/embox/labels{/name}","releases_url":"https://api.github.com/repos/embox/embox/releases{/id}","created_at":"2015-03-29T15:27:48Z","updated_at":"2015-07-16T07:38:52Z","pushed_at":"2015-07-16T13:23:24Z","git_url":"git://github.com/embox/embox.git","ssh_url":"git@github.com:embox/embox.git","clone_url":"https://github.com/embox/embox.git","svn_url":"https://github.com/embox/embox","homepage":"","size":36165,"stargazers_count":58,"watchers_count":58,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":76,"forks":14,"open_issues":76,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/embox/embox/pulls/745"},"html":{"href":"https://github.com/embox/embox/pull/745"},"issue":{"href":"https://api.github.com/repos/embox/embox/issues/745"},"comments":{"href":"https://api.github.com/repos/embox/embox/issues/745/comments"},"review_comments":{"href":"https://api.github.com/repos/embox/embox/pulls/745/comments"},"review_comment":{"href":"https://api.github.com/repos/embox/embox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/embox/embox/pulls/745/commits"},"statuses":{"href":"https://api.github.com/repos/embox/embox/statuses/196e09ebb26067e9c58112b58baea43b1a2def7b"}}}}