{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/37766269","id":37766269,"diff_hunk":"@@ -188,10 +187,7 @@ func (c *controller) watchNetworks() error {\n \t\t\t\tlview := c.networks\n \t\t\t\tc.Unlock()\n \t\t\t\tfor k, v := range lview {\n-\t\t\t\t\tglobal, _ := v.isGlobalScoped()\n-\t\t\t\t\tif global {\n-\t\t\t\t\t\ttmpview[k] = v\n-\t\t\t\t\t}\n+\t\t\t\t\ttmpview[k] = v","path":"store.go","position":206,"original_position":206,"commit_id":"88c6466e8a0a84150608b67f31198a872cffde2c","original_commit_id":"88c6466e8a0a84150608b67f31198a872cffde2c","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"body":"This is added as part of delete processing to make sure we dont end up removing locally scoped networks incorrectly during a watch event.\r\nWith this change, we will lose that protection and the local networks will be removed when there is a watch event happens for the networks with global scope. Can you please confirm if you tried a scenario of both global and locally scoped objects ?","created_at":"2015-08-24T15:49:13Z","updated_at":"2015-08-24T15:49:13Z","html_url":"https://github.com/docker/libnetwork/pull/466#discussion_r37766269","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/466","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/37766269"},"html":{"href":"https://github.com/docker/libnetwork/pull/466#discussion_r37766269"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/466"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/466","id":43003587,"html_url":"https://github.com/docker/libnetwork/pull/466","diff_url":"https://github.com/docker/libnetwork/pull/466.diff","patch_url":"https://github.com/docker/libnetwork/pull/466.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/466","number":466,"state":"open","locked":false,"title":"Add local datastore to persist states of LocalScope network","user":{"login":"chenchun","id":985861,"avatar_url":"https://avatars.githubusercontent.com/u/985861?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchun","html_url":"https://github.com/chenchun","followers_url":"https://api.github.com/users/chenchun/followers","following_url":"https://api.github.com/users/chenchun/following{/other_user}","gists_url":"https://api.github.com/users/chenchun/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchun/subscriptions","organizations_url":"https://api.github.com/users/chenchun/orgs","repos_url":"https://api.github.com/users/chenchun/repos","events_url":"https://api.github.com/users/chenchun/events{/privacy}","received_events_url":"https://api.github.com/users/chenchun/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Chun Chen <ramichen@tencent.com>\r\n\r\nFixes https://github.com/docker/libnetwork/issues/461","created_at":"2015-08-21T04:37:23Z","updated_at":"2015-08-24T15:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"535964792291ade9ca74f2c48c348e80ad9306d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/466/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/466/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/466/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/88c6466e8a0a84150608b67f31198a872cffde2c","head":{"label":"chenchun:localstore","ref":"localstore","sha":"88c6466e8a0a84150608b67f31198a872cffde2c","user":{"login":"chenchun","id":985861,"avatar_url":"https://avatars.githubusercontent.com/u/985861?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchun","html_url":"https://github.com/chenchun","followers_url":"https://api.github.com/users/chenchun/followers","following_url":"https://api.github.com/users/chenchun/following{/other_user}","gists_url":"https://api.github.com/users/chenchun/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchun/subscriptions","organizations_url":"https://api.github.com/users/chenchun/orgs","repos_url":"https://api.github.com/users/chenchun/repos","events_url":"https://api.github.com/users/chenchun/events{/privacy}","received_events_url":"https://api.github.com/users/chenchun/received_events","type":"User","site_admin":false},"repo":{"id":37978498,"name":"libnetwork","full_name":"chenchun/libnetwork","owner":{"login":"chenchun","id":985861,"avatar_url":"https://avatars.githubusercontent.com/u/985861?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchun","html_url":"https://github.com/chenchun","followers_url":"https://api.github.com/users/chenchun/followers","following_url":"https://api.github.com/users/chenchun/following{/other_user}","gists_url":"https://api.github.com/users/chenchun/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchun/subscriptions","organizations_url":"https://api.github.com/users/chenchun/orgs","repos_url":"https://api.github.com/users/chenchun/repos","events_url":"https://api.github.com/users/chenchun/events{/privacy}","received_events_url":"https://api.github.com/users/chenchun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenchun/libnetwork","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/chenchun/libnetwork","forks_url":"https://api.github.com/repos/chenchun/libnetwork/forks","keys_url":"https://api.github.com/repos/chenchun/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenchun/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenchun/libnetwork/teams","hooks_url":"https://api.github.com/repos/chenchun/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/chenchun/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/chenchun/libnetwork/events","assignees_url":"https://api.github.com/repos/chenchun/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/chenchun/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/chenchun/libnetwork/tags","blobs_url":"https://api.github.com/repos/chenchun/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenchun/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenchun/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenchun/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenchun/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/chenchun/libnetwork/languages","stargazers_url":"https://api.github.com/repos/chenchun/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/chenchun/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/chenchun/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/chenchun/libnetwork/subscription","commits_url":"https://api.github.com/repos/chenchun/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenchun/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenchun/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenchun/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenchun/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/chenchun/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenchun/libnetwork/merges","archive_url":"https://api.github.com/repos/chenchun/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenchun/libnetwork/downloads","issues_url":"https://api.github.com/repos/chenchun/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/chenchun/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/chenchun/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/chenchun/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenchun/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/chenchun/libnetwork/releases{/id}","created_at":"2015-06-24T10:36:27Z","updated_at":"2015-06-24T10:36:28Z","pushed_at":"2015-08-24T10:19:11Z","git_url":"git://github.com/chenchun/libnetwork.git","ssh_url":"git@github.com:chenchun/libnetwork.git","clone_url":"https://github.com/chenchun/libnetwork.git","svn_url":"https://github.com/chenchun/libnetwork","homepage":"","size":5015,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"0dca75517b2feb75890b20aaad2652f3a0d8ff10","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"networking for containers","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2015-08-24T01:36:11Z","pushed_at":"2015-08-24T10:19:12Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":11400,"stargazers_count":416,"watchers_count":416,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":72,"forks":141,"open_issues":72,"watchers":416,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/466"},"html":{"href":"https://github.com/docker/libnetwork/pull/466"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/466"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/466/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/466/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/466/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/88c6466e8a0a84150608b67f31198a872cffde2c"}}}}