{"action":"created","comment":{"url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/comments/33698813","id":33698813,"diff_hunk":"@@ -260,11 +262,41 @@ void HandleInputEvent(_THIS, PP_Resource event) {\n \n             state = SDL_PRESSED;\n             if (type == PP_INPUTEVENT_TYPE_KEYDOWN) {\n+#if !defined(NDEBUG)\n+              fprintf(stderr, \"KEYDOWN: %d\\n\", keysym.scancode);\n+#endif\n+              /*\n+               * PPAPI + Javascript recently started skipping KEYPRESS\n+               * events for letter + number keys when ALT is pressed.\n+               * Rather than wait for KEYPRESS to complete a keystroke,\n+               * emit immediately when ALT is pressed.\n+               * A similar situation exists for CTRL-H, CTRL-M, CTRL-Space.\n+               * Handling these explicitly as well (they require control\n+               * code decoding).\n+               * NOTE: The old behavior continues on OSX, so we must\n+               * also ignore KEYPRESS codes in case we are on OSX.\n+               */\n+              if (keysym.scancode == 17) ctrl_down = 1;\n+              if (keysym.scancode == 18) alt_down = 1;","path":"src/video/nacl/SDL_naclevents.c","position":28,"original_position":28,"commit_id":"09adc7fe7123cc019fb557ed17dc4ab09853c73a","original_commit_id":"09adc7fe7123cc019fb557ed17dc4ab09853c73a","user":{"login":"sbc100","id":515813,"avatar_url":"https://avatars.githubusercontent.com/u/515813?v=3","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"body":"Are there no macros we can use here rather than hardcoded numbed?","created_at":"2015-07-01T16:52:15Z","updated_at":"2015-07-01T16:52:15Z","html_url":"https://github.com/sbc100/SDL-mirror/pull/1#discussion_r33698813","pull_request_url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/comments/33698813"},"html":{"href":"https://github.com/sbc100/SDL-mirror/pull/1#discussion_r33698813"},"pull_request":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1","id":38616145,"html_url":"https://github.com/sbc100/SDL-mirror/pull/1","diff_url":"https://github.com/sbc100/SDL-mirror/pull/1.diff","patch_url":"https://github.com/sbc100/SDL-mirror/pull/1.patch","issue_url":"https://api.github.com/repos/sbc100/SDL-mirror/issues/1","number":1,"state":"open","locked":false,"title":"Handle ALT and some CTRL codes specially.","user":{"login":"flagxor","id":7519520,"avatar_url":"https://avatars.githubusercontent.com/u/7519520?v=3","gravatar_id":"","url":"https://api.github.com/users/flagxor","html_url":"https://github.com/flagxor","followers_url":"https://api.github.com/users/flagxor/followers","following_url":"https://api.github.com/users/flagxor/following{/other_user}","gists_url":"https://api.github.com/users/flagxor/gists{/gist_id}","starred_url":"https://api.github.com/users/flagxor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagxor/subscriptions","organizations_url":"https://api.github.com/users/flagxor/orgs","repos_url":"https://api.github.com/users/flagxor/repos","events_url":"https://api.github.com/users/flagxor/events{/privacy}","received_events_url":"https://api.github.com/users/flagxor/received_events","type":"User","site_admin":false},"body":"PPAPI + Javascript recently started skipping KEYPRESS\r\nevents for letter + number keys when ALT is pressed.\r\nRather than wait for KEYPRESS to complete a keystroke,\r\nemit immediately when ALT is pressed.\r\nA similar situation exists for CTRL-H, CTRL-M, CTRL-Space.\r\nHandling these explicitly as well (they require control\r\ncode decoding).\r\nNOTE: The old behavior continues on OSX, so we must\r\nalso ignore KEYPRESS codes in case we are on OSX.\r\n\r\nBUG=None\r\nTEST=xorg-server\r\nR=sbc@chromium.org","created_at":"2015-06-26T04:17:45Z","updated_at":"2015-07-01T16:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb4c3f5ccd1312364d3c217c0188a5206c499a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbc100/SDL-mirror/issues/1/comments","statuses_url":"https://api.github.com/repos/sbc100/SDL-mirror/statuses/09adc7fe7123cc019fb557ed17dc4ab09853c73a","head":{"label":"flagxor:SDL12_nacl","ref":"SDL12_nacl","sha":"09adc7fe7123cc019fb557ed17dc4ab09853c73a","user":{"login":"flagxor","id":7519520,"avatar_url":"https://avatars.githubusercontent.com/u/7519520?v=3","gravatar_id":"","url":"https://api.github.com/users/flagxor","html_url":"https://github.com/flagxor","followers_url":"https://api.github.com/users/flagxor/followers","following_url":"https://api.github.com/users/flagxor/following{/other_user}","gists_url":"https://api.github.com/users/flagxor/gists{/gist_id}","starred_url":"https://api.github.com/users/flagxor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagxor/subscriptions","organizations_url":"https://api.github.com/users/flagxor/orgs","repos_url":"https://api.github.com/users/flagxor/repos","events_url":"https://api.github.com/users/flagxor/events{/privacy}","received_events_url":"https://api.github.com/users/flagxor/received_events","type":"User","site_admin":false},"repo":{"id":38089812,"name":"SDL-mirror","full_name":"flagxor/SDL-mirror","owner":{"login":"flagxor","id":7519520,"avatar_url":"https://avatars.githubusercontent.com/u/7519520?v=3","gravatar_id":"","url":"https://api.github.com/users/flagxor","html_url":"https://github.com/flagxor","followers_url":"https://api.github.com/users/flagxor/followers","following_url":"https://api.github.com/users/flagxor/following{/other_user}","gists_url":"https://api.github.com/users/flagxor/gists{/gist_id}","starred_url":"https://api.github.com/users/flagxor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagxor/subscriptions","organizations_url":"https://api.github.com/users/flagxor/orgs","repos_url":"https://api.github.com/users/flagxor/repos","events_url":"https://api.github.com/users/flagxor/events{/privacy}","received_events_url":"https://api.github.com/users/flagxor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flagxor/SDL-mirror","description":"An unofficial, automated SDL2 and SDL1.2 HG mirror.","fork":true,"url":"https://api.github.com/repos/flagxor/SDL-mirror","forks_url":"https://api.github.com/repos/flagxor/SDL-mirror/forks","keys_url":"https://api.github.com/repos/flagxor/SDL-mirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flagxor/SDL-mirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flagxor/SDL-mirror/teams","hooks_url":"https://api.github.com/repos/flagxor/SDL-mirror/hooks","issue_events_url":"https://api.github.com/repos/flagxor/SDL-mirror/issues/events{/number}","events_url":"https://api.github.com/repos/flagxor/SDL-mirror/events","assignees_url":"https://api.github.com/repos/flagxor/SDL-mirror/assignees{/user}","branches_url":"https://api.github.com/repos/flagxor/SDL-mirror/branches{/branch}","tags_url":"https://api.github.com/repos/flagxor/SDL-mirror/tags","blobs_url":"https://api.github.com/repos/flagxor/SDL-mirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flagxor/SDL-mirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flagxor/SDL-mirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/flagxor/SDL-mirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flagxor/SDL-mirror/statuses/{sha}","languages_url":"https://api.github.com/repos/flagxor/SDL-mirror/languages","stargazers_url":"https://api.github.com/repos/flagxor/SDL-mirror/stargazers","contributors_url":"https://api.github.com/repos/flagxor/SDL-mirror/contributors","subscribers_url":"https://api.github.com/repos/flagxor/SDL-mirror/subscribers","subscription_url":"https://api.github.com/repos/flagxor/SDL-mirror/subscription","commits_url":"https://api.github.com/repos/flagxor/SDL-mirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/flagxor/SDL-mirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/flagxor/SDL-mirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/flagxor/SDL-mirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/flagxor/SDL-mirror/contents/{+path}","compare_url":"https://api.github.com/repos/flagxor/SDL-mirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flagxor/SDL-mirror/merges","archive_url":"https://api.github.com/repos/flagxor/SDL-mirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flagxor/SDL-mirror/downloads","issues_url":"https://api.github.com/repos/flagxor/SDL-mirror/issues{/number}","pulls_url":"https://api.github.com/repos/flagxor/SDL-mirror/pulls{/number}","milestones_url":"https://api.github.com/repos/flagxor/SDL-mirror/milestones{/number}","notifications_url":"https://api.github.com/repos/flagxor/SDL-mirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flagxor/SDL-mirror/labels{/name}","releases_url":"https://api.github.com/repos/flagxor/SDL-mirror/releases{/id}","created_at":"2015-06-26T04:04:50Z","updated_at":"2015-06-26T04:04:58Z","pushed_at":"2015-06-26T04:17:04Z","git_url":"git://github.com/flagxor/SDL-mirror.git","ssh_url":"git@github.com:flagxor/SDL-mirror.git","clone_url":"https://github.com/flagxor/SDL-mirror.git","svn_url":"https://github.com/flagxor/SDL-mirror","homepage":null,"size":119588,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sbc100:SDL12_nacl","ref":"SDL12_nacl","sha":"b3ef807c68dad8697ba8aba06b9df5da50745e66","user":{"login":"sbc100","id":515813,"avatar_url":"https://avatars.githubusercontent.com/u/515813?v=3","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"repo":{"id":20345796,"name":"SDL-mirror","full_name":"sbc100/SDL-mirror","owner":{"login":"sbc100","id":515813,"avatar_url":"https://avatars.githubusercontent.com/u/515813?v=3","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbc100/SDL-mirror","description":"An unofficial, automated SDL2 and SDL1.2 HG mirror.","fork":true,"url":"https://api.github.com/repos/sbc100/SDL-mirror","forks_url":"https://api.github.com/repos/sbc100/SDL-mirror/forks","keys_url":"https://api.github.com/repos/sbc100/SDL-mirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbc100/SDL-mirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbc100/SDL-mirror/teams","hooks_url":"https://api.github.com/repos/sbc100/SDL-mirror/hooks","issue_events_url":"https://api.github.com/repos/sbc100/SDL-mirror/issues/events{/number}","events_url":"https://api.github.com/repos/sbc100/SDL-mirror/events","assignees_url":"https://api.github.com/repos/sbc100/SDL-mirror/assignees{/user}","branches_url":"https://api.github.com/repos/sbc100/SDL-mirror/branches{/branch}","tags_url":"https://api.github.com/repos/sbc100/SDL-mirror/tags","blobs_url":"https://api.github.com/repos/sbc100/SDL-mirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbc100/SDL-mirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbc100/SDL-mirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbc100/SDL-mirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbc100/SDL-mirror/statuses/{sha}","languages_url":"https://api.github.com/repos/sbc100/SDL-mirror/languages","stargazers_url":"https://api.github.com/repos/sbc100/SDL-mirror/stargazers","contributors_url":"https://api.github.com/repos/sbc100/SDL-mirror/contributors","subscribers_url":"https://api.github.com/repos/sbc100/SDL-mirror/subscribers","subscription_url":"https://api.github.com/repos/sbc100/SDL-mirror/subscription","commits_url":"https://api.github.com/repos/sbc100/SDL-mirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbc100/SDL-mirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbc100/SDL-mirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbc100/SDL-mirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbc100/SDL-mirror/contents/{+path}","compare_url":"https://api.github.com/repos/sbc100/SDL-mirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbc100/SDL-mirror/merges","archive_url":"https://api.github.com/repos/sbc100/SDL-mirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbc100/SDL-mirror/downloads","issues_url":"https://api.github.com/repos/sbc100/SDL-mirror/issues{/number}","pulls_url":"https://api.github.com/repos/sbc100/SDL-mirror/pulls{/number}","milestones_url":"https://api.github.com/repos/sbc100/SDL-mirror/milestones{/number}","notifications_url":"https://api.github.com/repos/sbc100/SDL-mirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbc100/SDL-mirror/labels{/name}","releases_url":"https://api.github.com/repos/sbc100/SDL-mirror/releases{/id}","created_at":"2014-05-31T00:05:15Z","updated_at":"2014-06-30T21:48:03Z","pushed_at":"2015-06-26T04:17:45Z","git_url":"git://github.com/sbc100/SDL-mirror.git","ssh_url":"git@github.com:sbc100/SDL-mirror.git","clone_url":"https://github.com/sbc100/SDL-mirror.git","svn_url":"https://github.com/sbc100/SDL-mirror","homepage":null,"size":119867,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1"},"html":{"href":"https://github.com/sbc100/SDL-mirror/pull/1"},"issue":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/issues/1"},"comments":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sbc100/SDL-mirror/statuses/09adc7fe7123cc019fb557ed17dc4ab09853c73a"}}}}