{"action":"created","issue":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/750","labels_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/750/labels{/name}","comments_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/750/comments","events_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/750/events","html_url":"https://github.com/ankidroid/Anki-Android/pull/750","id":60615818,"number":750,"title":"Theme refactor:   Per Tim's request  - not a real pull request.   ","user":{"login":"jshevek","id":8716682,"avatar_url":"https://avatars.githubusercontent.com/u/8716682?v=3","gravatar_id":"","url":"https://api.github.com/users/jshevek","html_url":"https://github.com/jshevek","followers_url":"https://api.github.com/users/jshevek/followers","following_url":"https://api.github.com/users/jshevek/following{/other_user}","gists_url":"https://api.github.com/users/jshevek/gists{/gist_id}","starred_url":"https://api.github.com/users/jshevek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshevek/subscriptions","organizations_url":"https://api.github.com/users/jshevek/orgs","repos_url":"https://api.github.com/users/jshevek/repos","events_url":"https://api.github.com/users/jshevek/events{/privacy}","received_events_url":"https://api.github.com/users/jshevek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-03-11T06:18:57Z","updated_at":"2015-03-26T09:12:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/pulls/750","html_url":"https://github.com/ankidroid/Anki-Android/pull/750","diff_url":"https://github.com/ankidroid/Anki-Android/pull/750.diff","patch_url":"https://github.com/ankidroid/Anki-Android/pull/750.patch"},"body":"This is not a real pull request, as this code is a partial refactor, which is largely untested. Many of these changes will be reversed or improved upon before being ready for submission. \r\n\r\nI wish to restore theming ability to this app, and introduce an AMOLED friendly, night-viewing friendly theme.   In the course of this I will:\r\n\r\n-> remove as much programmatic changes to the UI appearance as is reasonable\r\n-> centralize all reference to images and colors into a few places.  \r\n-> create new icon images directly based on the old icons\r\n\r\nI'll also be changing some of night mode specific code.   If I have the time for it, I'll add  some very basic UI testing code. \r\n\r\nI've already merged some code with Allison, who is working on Material Design related upgrades to the app, but this branch still uses the original entirely non-CardView approach."},"comment":{"url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/comments/86417164","html_url":"https://github.com/ankidroid/Anki-Android/pull/750#issuecomment-86417164","issue_url":"https://api.github.com/repos/ankidroid/Anki-Android/issues/750","id":86417164,"user":{"login":"timrae","id":2818274,"avatar_url":"https://avatars.githubusercontent.com/u/2818274?v=3","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T09:12:44Z","updated_at":"2015-03-26T09:12:44Z","body":"Yes I think that's a good idea. Small PRs done over a short time (a day or two) or which concentrate on one or two specific files will work much better. \r\n\r\nIn addition to the gradual change from code to xml, removing all of the redundant themes (blue, flat, etc) from Themes.java, leaving only the white theme would also be useful. I think it's fine to temporarily break night mode if necessary for this.\r\n\r\nFinally, I believe @hssm has some refactoring planned in `AbstractFlashcardViewer.java` and `Reviewer.java`, so you might want to wait for that before undertaking any significant changes to those classes."}}