{"action":"created","issue":{"url":"https://api.github.com/repos/brson/multirust/issues/99","labels_url":"https://api.github.com/repos/brson/multirust/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/brson/multirust/issues/99/comments","events_url":"https://api.github.com/repos/brson/multirust/issues/99/events","html_url":"https://github.com/brson/multirust/pull/99","id":106198534,"number":99,"title":"Modify the PATH in multirustproxy for Windows support","user":{"login":"SpaceManiac","id":222630,"avatar_url":"https://avatars.githubusercontent.com/u/222630?v=3","gravatar_id":"","url":"https://api.github.com/users/SpaceManiac","html_url":"https://github.com/SpaceManiac","followers_url":"https://api.github.com/users/SpaceManiac/followers","following_url":"https://api.github.com/users/SpaceManiac/following{/other_user}","gists_url":"https://api.github.com/users/SpaceManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/SpaceManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpaceManiac/subscriptions","organizations_url":"https://api.github.com/users/SpaceManiac/orgs","repos_url":"https://api.github.com/users/SpaceManiac/repos","events_url":"https://api.github.com/users/SpaceManiac/events{/privacy}","received_events_url":"https://api.github.com/users/SpaceManiac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-13T04:34:50Z","updated_at":"2015-09-23T18:29:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brson/multirust/pulls/99","html_url":"https://github.com/brson/multirust/pull/99","diff_url":"https://github.com/brson/multirust/pull/99.diff","patch_url":"https://github.com/brson/multirust/pull/99.patch"},"body":"On Windows, shared libraries (DLLs) are searched for in the `PATH`, so it should be pointed to the `$sysroot/bin` directory where the DLLs are in the Windows Rust packages.\r\n\r\n`rustup` is also changed to point to a version which includes https://github.com/rust-lang/rustup/pull/29. This is sufficient, in my testing, to make multirust at least minimally functional under MSYS.\r\n\r\nThis has the side effect of causing `cargo` calls to `rustc` and `rustdoc` to just call the toolchain binaries directly rather than go through the proxies again. This shouldn't cause any problems, but I currently don't have a Linux machine to test on. If this behavior isn't desired, a check to only update `PATH` on windows could be added."},"comment":{"url":"https://api.github.com/repos/brson/multirust/issues/comments/142689763","html_url":"https://github.com/brson/multirust/pull/99#issuecomment-142689763","issue_url":"https://api.github.com/repos/brson/multirust/issues/99","id":142689763,"user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T18:29:18Z","updated_at":"2015-09-23T18:29:18Z","body":"@SpaceManiac ok, thanks for the note about that. I'm going to be working on this today - really want to get this working."}}