{"action":"created","issue":{"url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/32","labels_url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/32/comments","events_url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/32/events","html_url":"https://github.com/alecthomas/go_serialization_benchmarks/issues/32","id":105654144,"number":32,"title":"Fair Comparison For Timestamps","user":{"login":"pascaldekloe","id":4867072,"avatar_url":"https://avatars.githubusercontent.com/u/4867072?v=3","gravatar_id":"","url":"https://api.github.com/users/pascaldekloe","html_url":"https://github.com/pascaldekloe","followers_url":"https://api.github.com/users/pascaldekloe/followers","following_url":"https://api.github.com/users/pascaldekloe/following{/other_user}","gists_url":"https://api.github.com/users/pascaldekloe/gists{/gist_id}","starred_url":"https://api.github.com/users/pascaldekloe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascaldekloe/subscriptions","organizations_url":"https://api.github.com/users/pascaldekloe/orgs","repos_url":"https://api.github.com/users/pascaldekloe/repos","events_url":"https://api.github.com/users/pascaldekloe/events{/privacy}","received_events_url":"https://api.github.com/users/pascaldekloe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-09T18:20:28Z","updated_at":"2015-09-14T14:18:48Z","closed_at":"2015-09-14T13:39:00Z","body":"The test data struct has a time.Time field. Formats which don't support timestamps now benefit from the fact that they compete with a plain integer.\r\nTo be fair, we could create time.Unix objects and make BirthDay as time.Now().Round(time.Seconds) to get rid of the nanoseconds or simply switch to int64 for all."},"comment":{"url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/comments/140093844","html_url":"https://github.com/alecthomas/go_serialization_benchmarks/issues/32#issuecomment-140093844","issue_url":"https://api.github.com/repos/alecthomas/go_serialization_benchmarks/issues/32","id":140093844,"user":{"login":"pascaldekloe","id":4867072,"avatar_url":"https://avatars.githubusercontent.com/u/4867072?v=3","gravatar_id":"","url":"https://api.github.com/users/pascaldekloe","html_url":"https://github.com/pascaldekloe","followers_url":"https://api.github.com/users/pascaldekloe/followers","following_url":"https://api.github.com/users/pascaldekloe/following{/other_user}","gists_url":"https://api.github.com/users/pascaldekloe/gists{/gist_id}","starred_url":"https://api.github.com/users/pascaldekloe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascaldekloe/subscriptions","organizations_url":"https://api.github.com/users/pascaldekloe/orgs","repos_url":"https://api.github.com/users/pascaldekloe/repos","events_url":"https://api.github.com/users/pascaldekloe/events{/privacy}","received_events_url":"https://api.github.com/users/pascaldekloe/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T14:18:48Z","updated_at":"2015-09-14T14:18:48Z","body":"Either you use time.Time in your code or you don't.\r\n* If you do then every parse requires a malloc, even when the wire format is int64. Don't hide this.\r\n* If you don't and use a time.Time for the wire format anyway then that's just stupid. Don't base a benchmark on such mistake."}}