{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/620","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/620/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/620/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/620/events","html_url":"https://github.com/minetest/minetest_game/pull/620","id":100036878,"number":620,"title":"Flowers: Add sporeless mushrooms to fix spore cheat","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-10T11:02:30Z","updated_at":"2015-08-10T12:08:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/620","html_url":"https://github.com/minetest/minetest_game/pull/620","diff_url":"https://github.com/minetest/minetest_game/pull/620.diff","patch_url":"https://github.com/minetest/minetest_game/pull/620.patch"},"body":"I still have to test this but it's ready for initial review.\r\n\r\nUnpicked mushrooms are placed by mapgen and the spore growing ABM.\r\nThese drop a sporeless mushroom and 0 to 3 spores, with an average of just above 1 spore per mushroom for a slow multiplication of mushrooms when farming.\r\nSporeless mushrooms do not drop spores to avoid the cheat of repeated digging and placing a mushroom to generate spores too easily."},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/129423870","html_url":"https://github.com/minetest/minetest_game/pull/620#issuecomment-129423870","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/620","id":129423870,"user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T12:08:18Z","updated_at":"2015-08-10T12:08:18Z","body":"Nice, the spore drop rate didn't change. With my commit, we had an expected value of\r\n```\r\n1 * 1/2 * 1/3 +\r\n2 * 1/2 * 2/3 * 1/2 +\r\n3 * 1/2 * 2/3 * 1/2 * 1/2 +\r\n0 * 1/2 * 2/3 * 1/2 * 1/2\r\n```\r\nWhich equals 0.75 spores per mushroom dug, and a chance of 0.5 to get a mushroom back. Your change has an expected value of\r\n```\r\n1 * 1/2 +\r\n1 * 1/2 +\r\n1 * 1/4\r\n```\r\nWhich equals 1.25 spores. If you count the returned mushroom as one spore, you have 1.25 spores in average before and after.\r\n\r\n:+1: Like it\r\n"}}