{"action":"opened","number":227,"pull_request":{"url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227","id":32171814,"html_url":"https://github.com/libbitcoin/libbitcoin/pull/227","diff_url":"https://github.com/libbitcoin/libbitcoin/pull/227.diff","patch_url":"https://github.com/libbitcoin/libbitcoin/pull/227.patch","issue_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/227","number":227,"state":"open","locked":false,"title":"Mnemonic optimization","user":{"login":"swansontec","id":276214,"avatar_url":"https://avatars.githubusercontent.com/u/276214?v=3","gravatar_id":"","url":"https://api.github.com/users/swansontec","html_url":"https://github.com/swansontec","followers_url":"https://api.github.com/users/swansontec/followers","following_url":"https://api.github.com/users/swansontec/following{/other_user}","gists_url":"https://api.github.com/users/swansontec/gists{/gist_id}","starred_url":"https://api.github.com/users/swansontec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swansontec/subscriptions","organizations_url":"https://api.github.com/users/swansontec/orgs","repos_url":"https://api.github.com/users/swansontec/repos","events_url":"https://api.github.com/users/swansontec/events{/privacy}","received_events_url":"https://api.github.com/users/swansontec/received_events","type":"User","site_admin":false},"body":"I literally could not compile the mnemonic code on some of our boxes, since the compiler needed more RAM than was available. The problem isn't the raw data; it's the thousands of std::string constructor calls that the compiler has to emit. Besides taking a ton of time and memory to compile, these constructors now need to run each time the library boots up, adding run-time overhead.\r\n\r\nThis code is slightly less pretty, since it uses pointers instead of nicely-nested STL types, but I think the performance gains are well worth it. Being able to compile the code at all is nice, too.","created_at":"2015-03-28T21:41:34Z","updated_at":"2015-03-28T21:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592d2fa7361d29414738e43d47d8b7f32056c327","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227/commits","review_comments_url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227/comments","review_comment_url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/227/comments","statuses_url":"https://api.github.com/repos/libbitcoin/libbitcoin/statuses/71618f4c91e885980893b182b70fea68d9b7712e","head":{"label":"libbitcoin:mnemonic-optimization","ref":"mnemonic-optimization","sha":"71618f4c91e885980893b182b70fea68d9b7712e","user":{"login":"libbitcoin","id":4434452,"avatar_url":"https://avatars.githubusercontent.com/u/4434452?v=3","gravatar_id":"","url":"https://api.github.com/users/libbitcoin","html_url":"https://github.com/libbitcoin","followers_url":"https://api.github.com/users/libbitcoin/followers","following_url":"https://api.github.com/users/libbitcoin/following{/other_user}","gists_url":"https://api.github.com/users/libbitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/libbitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libbitcoin/subscriptions","organizations_url":"https://api.github.com/users/libbitcoin/orgs","repos_url":"https://api.github.com/users/libbitcoin/repos","events_url":"https://api.github.com/users/libbitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/libbitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":10071659,"name":"libbitcoin","full_name":"libbitcoin/libbitcoin","owner":{"login":"libbitcoin","id":4434452,"avatar_url":"https://avatars.githubusercontent.com/u/4434452?v=3","gravatar_id":"","url":"https://api.github.com/users/libbitcoin","html_url":"https://github.com/libbitcoin","followers_url":"https://api.github.com/users/libbitcoin/followers","following_url":"https://api.github.com/users/libbitcoin/following{/other_user}","gists_url":"https://api.github.com/users/libbitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/libbitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libbitcoin/subscriptions","organizations_url":"https://api.github.com/users/libbitcoin/orgs","repos_url":"https://api.github.com/users/libbitcoin/repos","events_url":"https://api.github.com/users/libbitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/libbitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libbitcoin/libbitcoin","description":"Bitcoin Cross-Platform C++ Development Toolkit","fork":false,"url":"https://api.github.com/repos/libbitcoin/libbitcoin","forks_url":"https://api.github.com/repos/libbitcoin/libbitcoin/forks","keys_url":"https://api.github.com/repos/libbitcoin/libbitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libbitcoin/libbitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libbitcoin/libbitcoin/teams","hooks_url":"https://api.github.com/repos/libbitcoin/libbitcoin/hooks","issue_events_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/libbitcoin/libbitcoin/events","assignees_url":"https://api.github.com/repos/libbitcoin/libbitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/libbitcoin/libbitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/libbitcoin/libbitcoin/tags","blobs_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libbitcoin/libbitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/libbitcoin/libbitcoin/languages","stargazers_url":"https://api.github.com/repos/libbitcoin/libbitcoin/stargazers","contributors_url":"https://api.github.com/repos/libbitcoin/libbitcoin/contributors","subscribers_url":"https://api.github.com/repos/libbitcoin/libbitcoin/subscribers","subscription_url":"https://api.github.com/repos/libbitcoin/libbitcoin/subscription","commits_url":"https://api.github.com/repos/libbitcoin/libbitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/libbitcoin/libbitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/libbitcoin/libbitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/libbitcoin/libbitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libbitcoin/libbitcoin/merges","archive_url":"https://api.github.com/repos/libbitcoin/libbitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libbitcoin/libbitcoin/downloads","issues_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/libbitcoin/libbitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/libbitcoin/libbitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libbitcoin/libbitcoin/labels{/name}","releases_url":"https://api.github.com/repos/libbitcoin/libbitcoin/releases{/id}","created_at":"2013-05-15T05:35:30Z","updated_at":"2015-03-26T19:36:32Z","pushed_at":"2015-03-28T21:41:35Z","git_url":"git://github.com/libbitcoin/libbitcoin.git","ssh_url":"git@github.com:libbitcoin/libbitcoin.git","clone_url":"https://github.com/libbitcoin/libbitcoin.git","svn_url":"https://github.com/libbitcoin/libbitcoin","homepage":"https://libbitcoin.org/","size":7135,"stargazers_count":110,"watchers_count":110,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":2,"forks":53,"open_issues":2,"watchers":110,"default_branch":"master"}},"base":{"label":"libbitcoin:master","ref":"master","sha":"6033e81a1726b561eb9af443982b475a27546956","user":{"login":"libbitcoin","id":4434452,"avatar_url":"https://avatars.githubusercontent.com/u/4434452?v=3","gravatar_id":"","url":"https://api.github.com/users/libbitcoin","html_url":"https://github.com/libbitcoin","followers_url":"https://api.github.com/users/libbitcoin/followers","following_url":"https://api.github.com/users/libbitcoin/following{/other_user}","gists_url":"https://api.github.com/users/libbitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/libbitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libbitcoin/subscriptions","organizations_url":"https://api.github.com/users/libbitcoin/orgs","repos_url":"https://api.github.com/users/libbitcoin/repos","events_url":"https://api.github.com/users/libbitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/libbitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":10071659,"name":"libbitcoin","full_name":"libbitcoin/libbitcoin","owner":{"login":"libbitcoin","id":4434452,"avatar_url":"https://avatars.githubusercontent.com/u/4434452?v=3","gravatar_id":"","url":"https://api.github.com/users/libbitcoin","html_url":"https://github.com/libbitcoin","followers_url":"https://api.github.com/users/libbitcoin/followers","following_url":"https://api.github.com/users/libbitcoin/following{/other_user}","gists_url":"https://api.github.com/users/libbitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/libbitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libbitcoin/subscriptions","organizations_url":"https://api.github.com/users/libbitcoin/orgs","repos_url":"https://api.github.com/users/libbitcoin/repos","events_url":"https://api.github.com/users/libbitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/libbitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libbitcoin/libbitcoin","description":"Bitcoin Cross-Platform C++ Development Toolkit","fork":false,"url":"https://api.github.com/repos/libbitcoin/libbitcoin","forks_url":"https://api.github.com/repos/libbitcoin/libbitcoin/forks","keys_url":"https://api.github.com/repos/libbitcoin/libbitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libbitcoin/libbitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libbitcoin/libbitcoin/teams","hooks_url":"https://api.github.com/repos/libbitcoin/libbitcoin/hooks","issue_events_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/libbitcoin/libbitcoin/events","assignees_url":"https://api.github.com/repos/libbitcoin/libbitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/libbitcoin/libbitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/libbitcoin/libbitcoin/tags","blobs_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libbitcoin/libbitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/libbitcoin/libbitcoin/languages","stargazers_url":"https://api.github.com/repos/libbitcoin/libbitcoin/stargazers","contributors_url":"https://api.github.com/repos/libbitcoin/libbitcoin/contributors","subscribers_url":"https://api.github.com/repos/libbitcoin/libbitcoin/subscribers","subscription_url":"https://api.github.com/repos/libbitcoin/libbitcoin/subscription","commits_url":"https://api.github.com/repos/libbitcoin/libbitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/libbitcoin/libbitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/libbitcoin/libbitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/libbitcoin/libbitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/libbitcoin/libbitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libbitcoin/libbitcoin/merges","archive_url":"https://api.github.com/repos/libbitcoin/libbitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libbitcoin/libbitcoin/downloads","issues_url":"https://api.github.com/repos/libbitcoin/libbitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/libbitcoin/libbitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/libbitcoin/libbitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libbitcoin/libbitcoin/labels{/name}","releases_url":"https://api.github.com/repos/libbitcoin/libbitcoin/releases{/id}","created_at":"2013-05-15T05:35:30Z","updated_at":"2015-03-26T19:36:32Z","pushed_at":"2015-03-28T21:41:35Z","git_url":"git://github.com/libbitcoin/libbitcoin.git","ssh_url":"git@github.com:libbitcoin/libbitcoin.git","clone_url":"https://github.com/libbitcoin/libbitcoin.git","svn_url":"https://github.com/libbitcoin/libbitcoin","homepage":"https://libbitcoin.org/","size":7135,"stargazers_count":110,"watchers_count":110,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":2,"forks":53,"open_issues":2,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227"},"html":{"href":"https://github.com/libbitcoin/libbitcoin/pull/227"},"issue":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/227"},"comments":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/libbitcoin/libbitcoin/statuses/71618f4c91e885980893b182b70fea68d9b7712e"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":8257,"deletions":8296,"changed_files":6}}