{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/golo-lang/pulls/comments/48354580","id":48354580,"diff_hunk":"@@ -0,0 +1,14 @@\n+/*\n+ * Copyright (c) 2012-2015 Institut National des Sciences Appliquées de Lyon (INSA-Lyon)\n+ *\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ */\n+\n+\n+/**\n+ * Helper class to resolve methods added by an augmentation.","path":"src/main/java/org/eclipse/golo/runtime/augmentation/package-info.java","position":12,"original_position":12,"commit_id":"241be546b12c7e235c362b800e9c1d5576e66fec","original_commit_id":"241be546b12c7e235c362b800e9c1d5576e66fec","user":{"login":"jponge","id":25961,"avatar_url":"https://avatars.githubusercontent.com/u/25961?v=3","gravatar_id":"","url":"https://api.github.com/users/jponge","html_url":"https://github.com/jponge","followers_url":"https://api.github.com/users/jponge/followers","following_url":"https://api.github.com/users/jponge/following{/other_user}","gists_url":"https://api.github.com/users/jponge/gists{/gist_id}","starred_url":"https://api.github.com/users/jponge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jponge/subscriptions","organizations_url":"https://api.github.com/users/jponge/orgs","repos_url":"https://api.github.com/users/jponge/repos","events_url":"https://api.github.com/users/jponge/events{/privacy}","received_events_url":"https://api.github.com/users/jponge/received_events","type":"User","site_admin":false},"body":"class*es*","created_at":"2015-12-23T15:43:26Z","updated_at":"2015-12-23T15:43:26Z","html_url":"https://github.com/eclipse/golo-lang/pull/334#discussion_r48354580","pull_request_url":"https://api.github.com/repos/eclipse/golo-lang/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/comments/48354580"},"html":{"href":"https://github.com/eclipse/golo-lang/pull/334#discussion_r48354580"},"pull_request":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/golo-lang/pulls/334","id":54461619,"html_url":"https://github.com/eclipse/golo-lang/pull/334","diff_url":"https://github.com/eclipse/golo-lang/pull/334.diff","patch_url":"https://github.com/eclipse/golo-lang/pull/334.patch","issue_url":"https://api.github.com/repos/eclipse/golo-lang/issues/334","number":334,"state":"open","locked":false,"title":"Refactor method and augmentation resolution","user":{"login":"yloiseau","id":7151021,"avatar_url":"https://avatars.githubusercontent.com/u/7151021?v=3","gravatar_id":"","url":"https://api.github.com/users/yloiseau","html_url":"https://github.com/yloiseau","followers_url":"https://api.github.com/users/yloiseau/followers","following_url":"https://api.github.com/users/yloiseau/following{/other_user}","gists_url":"https://api.github.com/users/yloiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/yloiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yloiseau/subscriptions","organizations_url":"https://api.github.com/users/yloiseau/orgs","repos_url":"https://api.github.com/users/yloiseau/repos","events_url":"https://api.github.com/users/yloiseau/events{/privacy}","received_events_url":"https://api.github.com/users/yloiseau/received_events","type":"User","site_admin":false},"body":"Change the way (augmented) methods are resolved at runtime, to deal\r\nwith the priorities discussed in #326.\r\n\r\nMove methods common between augmentation and regular method resolution\r\ninto a abstract superclass.\r\n\r\nRefactor method type matching, to better reuse and move it to the\r\nMethodInvocation object.\r\n\r\nFIX #275\r\n\r\nAlso some refactoring on tests.\r\n\r\nFIX: empty augmentation\r\n\r\nNot filled as an issue, but a class was generated to hold augment\r\nfunctions, even if there was no functions. This happened when using\r\nnamed augmentation, since a single IR node is created for declarations\r\nsuch as\r\n\r\n    augment Foo {\r\n      function plop = |this| -> \"plop\"\r\n    }\r\n\r\nand\r\n\r\n    augment Foo with Plop\r\n\r\nIn the first case a class `module$Foo` is created to hold the `plop`\r\nfunction. It was also created in the second case, but was empty.","created_at":"2015-12-23T11:36:23Z","updated_at":"2015-12-23T15:43:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0825a270966ca2b2c463dacfacbfbe34e7f3531d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/golo-lang/pulls/334/commits","review_comments_url":"https://api.github.com/repos/eclipse/golo-lang/pulls/334/comments","review_comment_url":"https://api.github.com/repos/eclipse/golo-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/golo-lang/issues/334/comments","statuses_url":"https://api.github.com/repos/eclipse/golo-lang/statuses/241be546b12c7e235c362b800e9c1d5576e66fec","head":{"label":"yloiseau:fix/326-augmentation-resolution","ref":"fix/326-augmentation-resolution","sha":"241be546b12c7e235c362b800e9c1d5576e66fec","user":{"login":"yloiseau","id":7151021,"avatar_url":"https://avatars.githubusercontent.com/u/7151021?v=3","gravatar_id":"","url":"https://api.github.com/users/yloiseau","html_url":"https://github.com/yloiseau","followers_url":"https://api.github.com/users/yloiseau/followers","following_url":"https://api.github.com/users/yloiseau/following{/other_user}","gists_url":"https://api.github.com/users/yloiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/yloiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yloiseau/subscriptions","organizations_url":"https://api.github.com/users/yloiseau/orgs","repos_url":"https://api.github.com/users/yloiseau/repos","events_url":"https://api.github.com/users/yloiseau/events{/privacy}","received_events_url":"https://api.github.com/users/yloiseau/received_events","type":"User","site_admin":false},"repo":{"id":18405136,"name":"golo-lang","full_name":"yloiseau/golo-lang","owner":{"login":"yloiseau","id":7151021,"avatar_url":"https://avatars.githubusercontent.com/u/7151021?v=3","gravatar_id":"","url":"https://api.github.com/users/yloiseau","html_url":"https://github.com/yloiseau","followers_url":"https://api.github.com/users/yloiseau/followers","following_url":"https://api.github.com/users/yloiseau/following{/other_user}","gists_url":"https://api.github.com/users/yloiseau/gists{/gist_id}","starred_url":"https://api.github.com/users/yloiseau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yloiseau/subscriptions","organizations_url":"https://api.github.com/users/yloiseau/orgs","repos_url":"https://api.github.com/users/yloiseau/repos","events_url":"https://api.github.com/users/yloiseau/events{/privacy}","received_events_url":"https://api.github.com/users/yloiseau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yloiseau/golo-lang","description":"Golo - a lightweight dynamic language for the JVM.","fork":true,"url":"https://api.github.com/repos/yloiseau/golo-lang","forks_url":"https://api.github.com/repos/yloiseau/golo-lang/forks","keys_url":"https://api.github.com/repos/yloiseau/golo-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yloiseau/golo-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yloiseau/golo-lang/teams","hooks_url":"https://api.github.com/repos/yloiseau/golo-lang/hooks","issue_events_url":"https://api.github.com/repos/yloiseau/golo-lang/issues/events{/number}","events_url":"https://api.github.com/repos/yloiseau/golo-lang/events","assignees_url":"https://api.github.com/repos/yloiseau/golo-lang/assignees{/user}","branches_url":"https://api.github.com/repos/yloiseau/golo-lang/branches{/branch}","tags_url":"https://api.github.com/repos/yloiseau/golo-lang/tags","blobs_url":"https://api.github.com/repos/yloiseau/golo-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yloiseau/golo-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yloiseau/golo-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/yloiseau/golo-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yloiseau/golo-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/yloiseau/golo-lang/languages","stargazers_url":"https://api.github.com/repos/yloiseau/golo-lang/stargazers","contributors_url":"https://api.github.com/repos/yloiseau/golo-lang/contributors","subscribers_url":"https://api.github.com/repos/yloiseau/golo-lang/subscribers","subscription_url":"https://api.github.com/repos/yloiseau/golo-lang/subscription","commits_url":"https://api.github.com/repos/yloiseau/golo-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/yloiseau/golo-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/yloiseau/golo-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/yloiseau/golo-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/yloiseau/golo-lang/contents/{+path}","compare_url":"https://api.github.com/repos/yloiseau/golo-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yloiseau/golo-lang/merges","archive_url":"https://api.github.com/repos/yloiseau/golo-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yloiseau/golo-lang/downloads","issues_url":"https://api.github.com/repos/yloiseau/golo-lang/issues{/number}","pulls_url":"https://api.github.com/repos/yloiseau/golo-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/yloiseau/golo-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/yloiseau/golo-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yloiseau/golo-lang/labels{/name}","releases_url":"https://api.github.com/repos/yloiseau/golo-lang/releases{/id}","created_at":"2014-04-03T14:03:52Z","updated_at":"2015-05-07T14:00:48Z","pushed_at":"2015-12-23T11:35:25Z","git_url":"git://github.com/yloiseau/golo-lang.git","ssh_url":"git@github.com:yloiseau/golo-lang.git","clone_url":"https://github.com/yloiseau/golo-lang.git","svn_url":"https://github.com/yloiseau/golo-lang","homepage":"http://golo-lang.org/","size":5016,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"a26db1a26a453ead6959e0138a872e5b43f235cb","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":8340103,"name":"golo-lang","full_name":"eclipse/golo-lang","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/golo-lang","description":"Golo - a lightweight dynamic language for the JVM.","fork":false,"url":"https://api.github.com/repos/eclipse/golo-lang","forks_url":"https://api.github.com/repos/eclipse/golo-lang/forks","keys_url":"https://api.github.com/repos/eclipse/golo-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/golo-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/golo-lang/teams","hooks_url":"https://api.github.com/repos/eclipse/golo-lang/hooks","issue_events_url":"https://api.github.com/repos/eclipse/golo-lang/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/golo-lang/events","assignees_url":"https://api.github.com/repos/eclipse/golo-lang/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/golo-lang/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/golo-lang/tags","blobs_url":"https://api.github.com/repos/eclipse/golo-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/golo-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/golo-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/golo-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/golo-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/golo-lang/languages","stargazers_url":"https://api.github.com/repos/eclipse/golo-lang/stargazers","contributors_url":"https://api.github.com/repos/eclipse/golo-lang/contributors","subscribers_url":"https://api.github.com/repos/eclipse/golo-lang/subscribers","subscription_url":"https://api.github.com/repos/eclipse/golo-lang/subscription","commits_url":"https://api.github.com/repos/eclipse/golo-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/golo-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/golo-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/golo-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/golo-lang/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/golo-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/golo-lang/merges","archive_url":"https://api.github.com/repos/eclipse/golo-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/golo-lang/downloads","issues_url":"https://api.github.com/repos/eclipse/golo-lang/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/golo-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/golo-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/golo-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/golo-lang/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/golo-lang/releases{/id}","created_at":"2013-02-21T17:25:34Z","updated_at":"2015-12-15T13:58:24Z","pushed_at":"2015-12-23T11:36:23Z","git_url":"git://github.com/eclipse/golo-lang.git","ssh_url":"git@github.com:eclipse/golo-lang.git","clone_url":"https://github.com/eclipse/golo-lang.git","svn_url":"https://github.com/eclipse/golo-lang","homepage":"http://golo-lang.org/","size":5069,"stargazers_count":130,"watchers_count":130,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":30,"forks":42,"open_issues":30,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/334"},"html":{"href":"https://github.com/eclipse/golo-lang/pull/334"},"issue":{"href":"https://api.github.com/repos/eclipse/golo-lang/issues/334"},"comments":{"href":"https://api.github.com/repos/eclipse/golo-lang/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/golo-lang/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/golo-lang/statuses/241be546b12c7e235c362b800e9c1d5576e66fec"}}}}