{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69","id":32980939,"html_url":"https://github.com/sparc-request/sparc-request/pull/69","diff_url":"https://github.com/sparc-request/sparc-request/pull/69.diff","patch_url":"https://github.com/sparc-request/sparc-request/pull/69.patch","issue_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/69","number":69,"state":"closed","locked":false,"title":"suppress hidden field for is_one_time_fee when its value is true","user":{"login":"robertjamesmiller","id":7772496,"avatar_url":"https://avatars.githubusercontent.com/u/7772496?v=3","gravatar_id":"","url":"https://api.github.com/users/robertjamesmiller","html_url":"https://github.com/robertjamesmiller","followers_url":"https://api.github.com/users/robertjamesmiller/followers","following_url":"https://api.github.com/users/robertjamesmiller/following{/other_user}","gists_url":"https://api.github.com/users/robertjamesmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/robertjamesmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertjamesmiller/subscriptions","organizations_url":"https://api.github.com/users/robertjamesmiller/orgs","repos_url":"https://api.github.com/users/robertjamesmiller/repos","events_url":"https://api.github.com/users/robertjamesmiller/events{/privacy}","received_events_url":"https://api.github.com/users/robertjamesmiller/received_events","type":"User","site_admin":false},"body":"Since last Fall in all of our environments, a service with Pricing Maps that have is_one_time_fee = true has them set to false on any \"Save\" call within Catalog manager for that service. The issue appears to be that a hidden field with a value of 0 is always present whereas the disabled checkbox's \"true\" value is not present:\r\nhttp://stackoverflow.com/questions/7730695/whats-the-difference-between-disabled-disabled-and-readonly-readonly-for-ht\r\n\r\nSince, readonly checkboxes won't work for us in this scenario: http://stackoverflow.com/questions/155291/can-html-checkboxes-be-set-to-readonly?page=1&tab=votes#tab-top , I've removed the hidden field when is_one_time_fee = true.\r\n\r\nPlease let me know if this fix (for us) causes issues for your institution.","created_at":"2015-04-09T18:08:30Z","updated_at":"2015-04-28T13:13:47Z","closed_at":"2015-04-28T13:13:47Z","merged_at":"2015-04-28T13:13:47Z","merge_commit_sha":"46e2001c18c204ee033a1db8c89f102b54fb9b40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69/commits","review_comments_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69/comments","review_comment_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/69/comments","statuses_url":"https://api.github.com/repos/sparc-request/sparc-request/statuses/5fdd90b7af0eaabae2efcf5ceafac8a0b55e5f90","head":{"label":"ui-icts:is_one_time_fee-bug-fix","ref":"is_one_time_fee-bug-fix","sha":"5fdd90b7af0eaabae2efcf5ceafac8a0b55e5f90","user":{"login":"ui-icts","id":1143216,"avatar_url":"https://avatars.githubusercontent.com/u/1143216?v=3","gravatar_id":"","url":"https://api.github.com/users/ui-icts","html_url":"https://github.com/ui-icts","followers_url":"https://api.github.com/users/ui-icts/followers","following_url":"https://api.github.com/users/ui-icts/following{/other_user}","gists_url":"https://api.github.com/users/ui-icts/gists{/gist_id}","starred_url":"https://api.github.com/users/ui-icts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ui-icts/subscriptions","organizations_url":"https://api.github.com/users/ui-icts/orgs","repos_url":"https://api.github.com/users/ui-icts/repos","events_url":"https://api.github.com/users/ui-icts/events{/privacy}","received_events_url":"https://api.github.com/users/ui-icts/received_events","type":"Organization","site_admin":false},"repo":{"id":24103912,"name":"sparc-request","full_name":"ui-icts/sparc-request","owner":{"login":"ui-icts","id":1143216,"avatar_url":"https://avatars.githubusercontent.com/u/1143216?v=3","gravatar_id":"","url":"https://api.github.com/users/ui-icts","html_url":"https://github.com/ui-icts","followers_url":"https://api.github.com/users/ui-icts/followers","following_url":"https://api.github.com/users/ui-icts/following{/other_user}","gists_url":"https://api.github.com/users/ui-icts/gists{/gist_id}","starred_url":"https://api.github.com/users/ui-icts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ui-icts/subscriptions","organizations_url":"https://api.github.com/users/ui-icts/orgs","repos_url":"https://api.github.com/users/ui-icts/repos","events_url":"https://api.github.com/users/ui-icts/events{/privacy}","received_events_url":"https://api.github.com/users/ui-icts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ui-icts/sparc-request","description":"","fork":true,"url":"https://api.github.com/repos/ui-icts/sparc-request","forks_url":"https://api.github.com/repos/ui-icts/sparc-request/forks","keys_url":"https://api.github.com/repos/ui-icts/sparc-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ui-icts/sparc-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ui-icts/sparc-request/teams","hooks_url":"https://api.github.com/repos/ui-icts/sparc-request/hooks","issue_events_url":"https://api.github.com/repos/ui-icts/sparc-request/issues/events{/number}","events_url":"https://api.github.com/repos/ui-icts/sparc-request/events","assignees_url":"https://api.github.com/repos/ui-icts/sparc-request/assignees{/user}","branches_url":"https://api.github.com/repos/ui-icts/sparc-request/branches{/branch}","tags_url":"https://api.github.com/repos/ui-icts/sparc-request/tags","blobs_url":"https://api.github.com/repos/ui-icts/sparc-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ui-icts/sparc-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ui-icts/sparc-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/ui-icts/sparc-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ui-icts/sparc-request/statuses/{sha}","languages_url":"https://api.github.com/repos/ui-icts/sparc-request/languages","stargazers_url":"https://api.github.com/repos/ui-icts/sparc-request/stargazers","contributors_url":"https://api.github.com/repos/ui-icts/sparc-request/contributors","subscribers_url":"https://api.github.com/repos/ui-icts/sparc-request/subscribers","subscription_url":"https://api.github.com/repos/ui-icts/sparc-request/subscription","commits_url":"https://api.github.com/repos/ui-icts/sparc-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/ui-icts/sparc-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/ui-icts/sparc-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/ui-icts/sparc-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/ui-icts/sparc-request/contents/{+path}","compare_url":"https://api.github.com/repos/ui-icts/sparc-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ui-icts/sparc-request/merges","archive_url":"https://api.github.com/repos/ui-icts/sparc-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ui-icts/sparc-request/downloads","issues_url":"https://api.github.com/repos/ui-icts/sparc-request/issues{/number}","pulls_url":"https://api.github.com/repos/ui-icts/sparc-request/pulls{/number}","milestones_url":"https://api.github.com/repos/ui-icts/sparc-request/milestones{/number}","notifications_url":"https://api.github.com/repos/ui-icts/sparc-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ui-icts/sparc-request/labels{/name}","releases_url":"https://api.github.com/repos/ui-icts/sparc-request/releases{/id}","created_at":"2014-09-16T14:51:35Z","updated_at":"2014-08-29T18:37:56Z","pushed_at":"2015-04-23T19:17:59Z","git_url":"git://github.com/ui-icts/sparc-request.git","ssh_url":"git@github.com:ui-icts/sparc-request.git","clone_url":"https://github.com/ui-icts/sparc-request.git","svn_url":"https://github.com/ui-icts/sparc-request","homepage":null,"size":10318,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sparc-request:master","ref":"master","sha":"aa7cc43b961a547579b69e3fe3ca56baed70678d","user":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars.githubusercontent.com/u/8311757?v=3","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"repo":{"id":22610009,"name":"sparc-request","full_name":"sparc-request/sparc-request","owner":{"login":"sparc-request","id":8311757,"avatar_url":"https://avatars.githubusercontent.com/u/8311757?v=3","gravatar_id":"","url":"https://api.github.com/users/sparc-request","html_url":"https://github.com/sparc-request","followers_url":"https://api.github.com/users/sparc-request/followers","following_url":"https://api.github.com/users/sparc-request/following{/other_user}","gists_url":"https://api.github.com/users/sparc-request/gists{/gist_id}","starred_url":"https://api.github.com/users/sparc-request/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparc-request/subscriptions","organizations_url":"https://api.github.com/users/sparc-request/orgs","repos_url":"https://api.github.com/users/sparc-request/repos","events_url":"https://api.github.com/users/sparc-request/events{/privacy}","received_events_url":"https://api.github.com/users/sparc-request/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sparc-request/sparc-request","description":"","fork":false,"url":"https://api.github.com/repos/sparc-request/sparc-request","forks_url":"https://api.github.com/repos/sparc-request/sparc-request/forks","keys_url":"https://api.github.com/repos/sparc-request/sparc-request/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparc-request/sparc-request/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparc-request/sparc-request/teams","hooks_url":"https://api.github.com/repos/sparc-request/sparc-request/hooks","issue_events_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/events{/number}","events_url":"https://api.github.com/repos/sparc-request/sparc-request/events","assignees_url":"https://api.github.com/repos/sparc-request/sparc-request/assignees{/user}","branches_url":"https://api.github.com/repos/sparc-request/sparc-request/branches{/branch}","tags_url":"https://api.github.com/repos/sparc-request/sparc-request/tags","blobs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparc-request/sparc-request/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparc-request/sparc-request/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparc-request/sparc-request/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparc-request/sparc-request/statuses/{sha}","languages_url":"https://api.github.com/repos/sparc-request/sparc-request/languages","stargazers_url":"https://api.github.com/repos/sparc-request/sparc-request/stargazers","contributors_url":"https://api.github.com/repos/sparc-request/sparc-request/contributors","subscribers_url":"https://api.github.com/repos/sparc-request/sparc-request/subscribers","subscription_url":"https://api.github.com/repos/sparc-request/sparc-request/subscription","commits_url":"https://api.github.com/repos/sparc-request/sparc-request/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparc-request/sparc-request/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparc-request/sparc-request/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparc-request/sparc-request/issues/comments{/number}","contents_url":"https://api.github.com/repos/sparc-request/sparc-request/contents/{+path}","compare_url":"https://api.github.com/repos/sparc-request/sparc-request/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparc-request/sparc-request/merges","archive_url":"https://api.github.com/repos/sparc-request/sparc-request/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparc-request/sparc-request/downloads","issues_url":"https://api.github.com/repos/sparc-request/sparc-request/issues{/number}","pulls_url":"https://api.github.com/repos/sparc-request/sparc-request/pulls{/number}","milestones_url":"https://api.github.com/repos/sparc-request/sparc-request/milestones{/number}","notifications_url":"https://api.github.com/repos/sparc-request/sparc-request/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparc-request/sparc-request/labels{/name}","releases_url":"https://api.github.com/repos/sparc-request/sparc-request/releases{/id}","created_at":"2014-08-04T15:47:11Z","updated_at":"2015-04-23T18:56:00Z","pushed_at":"2015-04-28T13:13:47Z","git_url":"git://github.com/sparc-request/sparc-request.git","ssh_url":"git@github.com:sparc-request/sparc-request.git","clone_url":"https://github.com/sparc-request/sparc-request.git","svn_url":"https://github.com/sparc-request/sparc-request","homepage":null,"size":11848,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69"},"html":{"href":"https://github.com/sparc-request/sparc-request/pull/69"},"issue":{"href":"https://api.github.com/repos/sparc-request/sparc-request/issues/69"},"comments":{"href":"https://api.github.com/repos/sparc-request/sparc-request/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sparc-request/sparc-request/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/sparc-request/sparc-request/statuses/5fdd90b7af0eaabae2efcf5ceafac8a0b55e5f90"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jleonardw9","id":1830708,"avatar_url":"https://avatars.githubusercontent.com/u/1830708?v=3","gravatar_id":"","url":"https://api.github.com/users/jleonardw9","html_url":"https://github.com/jleonardw9","followers_url":"https://api.github.com/users/jleonardw9/followers","following_url":"https://api.github.com/users/jleonardw9/following{/other_user}","gists_url":"https://api.github.com/users/jleonardw9/gists{/gist_id}","starred_url":"https://api.github.com/users/jleonardw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleonardw9/subscriptions","organizations_url":"https://api.github.com/users/jleonardw9/orgs","repos_url":"https://api.github.com/users/jleonardw9/repos","events_url":"https://api.github.com/users/jleonardw9/events{/privacy}","received_events_url":"https://api.github.com/users/jleonardw9/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}