{"action":"created","issue":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/1235","labels_url":"https://api.github.com/repos/torchbox/wagtail/issues/1235/labels{/name}","comments_url":"https://api.github.com/repos/torchbox/wagtail/issues/1235/comments","events_url":"https://api.github.com/repos/torchbox/wagtail/issues/1235/events","html_url":"https://github.com/torchbox/wagtail/pull/1235","id":70647150,"number":1235,"title":"Search promotions module","user":{"login":"kaedroho","id":1093808,"avatar_url":"https://avatars.githubusercontent.com/u/1093808?v=3","gravatar_id":"","url":"https://api.github.com/users/kaedroho","html_url":"https://github.com/kaedroho","followers_url":"https://api.github.com/users/kaedroho/followers","following_url":"https://api.github.com/users/kaedroho/following{/other_user}","gists_url":"https://api.github.com/users/kaedroho/gists{/gist_id}","starred_url":"https://api.github.com/users/kaedroho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaedroho/subscriptions","organizations_url":"https://api.github.com/users/kaedroho/orgs","repos_url":"https://api.github.com/users/kaedroho/repos","events_url":"https://api.github.com/users/kaedroho/events{/privacy}","received_events_url":"https://api.github.com/users/kaedroho/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/torchbox/wagtail/labels/Cleanup/Optimisation","name":"Cleanup/Optimisation","color":"0052cc"},{"url":"https://api.github.com/repos/torchbox/wagtail/labels/Enhancement","name":"Enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/torchbox/wagtail/labels/Needs%20work","name":"Needs work","color":"eabd04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/torchbox/wagtail/milestones/9","html_url":"https://github.com/torchbox/wagtail/milestones/1.1","labels_url":"https://api.github.com/repos/torchbox/wagtail/milestones/9/labels","id":861608,"number":9,"title":"1.1","description":"","creator":{"login":"davecranwell","id":352835,"avatar_url":"https://avatars.githubusercontent.com/u/352835?v=3","gravatar_id":"","url":"https://api.github.com/users/davecranwell","html_url":"https://github.com/davecranwell","followers_url":"https://api.github.com/users/davecranwell/followers","following_url":"https://api.github.com/users/davecranwell/following{/other_user}","gists_url":"https://api.github.com/users/davecranwell/gists{/gist_id}","starred_url":"https://api.github.com/users/davecranwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecranwell/subscriptions","organizations_url":"https://api.github.com/users/davecranwell/orgs","repos_url":"https://api.github.com/users/davecranwell/repos","events_url":"https://api.github.com/users/davecranwell/events{/privacy}","received_events_url":"https://api.github.com/users/davecranwell/received_events","type":"User","site_admin":false},"open_issues":81,"closed_issues":18,"state":"open","created_at":"2014-11-11T11:56:09Z","updated_at":"2015-07-09T16:17:44Z","due_on":"2015-08-30T23:00:00Z","closed_at":null},"comments":7,"created_at":"2015-04-24T10:05:24Z","updated_at":"2015-07-09T16:38:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/torchbox/wagtail/pulls/1235","html_url":"https://github.com/torchbox/wagtail/pull/1235","diff_url":"https://github.com/torchbox/wagtail/pull/1235.diff","patch_url":"https://github.com/torchbox/wagtail/pull/1235.patch"},"body":"Moves editors picks out of ``wagtailsearch`` into a new module called ``contrib.wagtailsearchpicks``.\r\n\r\nThis makes \"Promoted search results\" optional and also resolves the two-way dependency between ``wagtailsearch`` and ``wagtailcore``\r\n\r\nTODO:\r\n - [x] Move ``EditorsPick`` model\r\n - [x] Add ``{% get_search_picks %}`` template tag\r\n - ~~Move locale files~~ (best to do this just before/after merge)\r\n - [x] Documentation"},"comment":{"url":"https://api.github.com/repos/torchbox/wagtail/issues/comments/120064015","html_url":"https://github.com/torchbox/wagtail/pull/1235#issuecomment-120064015","issue_url":"https://api.github.com/repos/torchbox/wagtail/issues/1235","id":120064015,"user":{"login":"kaedroho","id":1093808,"avatar_url":"https://avatars.githubusercontent.com/u/1093808?v=3","gravatar_id":"","url":"https://api.github.com/users/kaedroho","html_url":"https://github.com/kaedroho","followers_url":"https://api.github.com/users/kaedroho/followers","following_url":"https://api.github.com/users/kaedroho/following{/other_user}","gists_url":"https://api.github.com/users/kaedroho/gists{/gist_id}","starred_url":"https://api.github.com/users/kaedroho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaedroho/subscriptions","organizations_url":"https://api.github.com/users/kaedroho/orgs","repos_url":"https://api.github.com/users/kaedroho/repos","events_url":"https://api.github.com/users/kaedroho/events{/privacy}","received_events_url":"https://api.github.com/users/kaedroho/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T16:38:48Z","updated_at":"2015-07-09T16:38:48Z","body":"> I see there are several places that still refer to \"Editor's Picks\" / \"search picks\", some more visible/important to fix than others - for example, the success message on add/edit, and the related_name on the SearchPromotion model.\r\n\r\nI left the UI as it is as it's wrong on master anyway (was planning on doing this in a seprate PR).\r\n\r\nSince we're no longer recommending users access promoted results using the ``Query`` object, I didn't see much benefit to changing the related name (and most implementations using promoted results will be using this related name)."}}