{"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/comments/42387019","id":42387019,"diff_hunk":"@@ -262,14 +295,45 @@ else if ( configPrecedence == Precedence.LOCAL )\n                 {\n                     logger.debug (\"No remote configuration to inject from \" + override.toString());\n                 }\n+                String oldVersion = plugin.getVersion();\n                 // Always force the version in a pluginMgmt block or set the version if there is an existing\n                 // one in build/plugins section.\n-                if ( pluginMgmt || plugin.getVersion() != null )\n+                if ( pluginMgmt || oldVersion != null )\n                 {\n-                    plugin.setVersion( override.getVersion() );\n-                    logger.info( \"Altered plugin version: \" + groupIdArtifactId + \"=\" + override.getVersion());\n-                }\n+                    // Handle the situation where we are updating a dependency that has an existing property - in this\n+                    // case we want to update the property instead.\n+                    // TODO: Handle the scenario where the version might be ${....}${....}\n+                    if ( oldVersion.startsWith( \"${\" ) )","path":"core/src/main/java/org/commonjava/maven/ext/manip/impl/PluginManipulator.java","position":75,"original_position":75,"commit_id":"4a30e4e5fcb1ea9ad744a428d06aab8feb0a6690","original_commit_id":"4a30e4e5fcb1ea9ad744a428d06aab8feb0a6690","user":{"login":"rnc","id":1169793,"avatar_url":"https://avatars.githubusercontent.com/u/1169793?v=3","gravatar_id":"","url":"https://api.github.com/users/rnc","html_url":"https://github.com/rnc","followers_url":"https://api.github.com/users/rnc/followers","following_url":"https://api.github.com/users/rnc/following{/other_user}","gists_url":"https://api.github.com/users/rnc/gists{/gist_id}","starred_url":"https://api.github.com/users/rnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnc/subscriptions","organizations_url":"https://api.github.com/users/rnc/orgs","repos_url":"https://api.github.com/users/rnc/repos","events_url":"https://api.github.com/users/rnc/events{/privacy}","received_events_url":"https://api.github.com/users/rnc/received_events","type":"User","site_admin":false},"body":"You're right it is _similar_ ; the only difference is in the debug line e.g. https://github.com/release-engineering/pom-manipulation-ext/blob/master/core/src/main/java/org/commonjava/maven/ext/manip/impl/DependencyManipulator.java#L604\r\n","created_at":"2015-10-19T15:40:23Z","updated_at":"2015-10-19T15:40:23Z","html_url":"https://github.com/release-engineering/pom-manipulation-ext/pull/238#discussion_r42387019","pull_request_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/comments/42387019"},"html":{"href":"https://github.com/release-engineering/pom-manipulation-ext/pull/238#discussion_r42387019"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238","id":48084364,"html_url":"https://github.com/release-engineering/pom-manipulation-ext/pull/238","diff_url":"https://github.com/release-engineering/pom-manipulation-ext/pull/238.diff","patch_url":"https://github.com/release-engineering/pom-manipulation-ext/pull/238.patch","issue_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/238","number":238,"state":"closed","locked":false,"title":"Issue #236 Update Plugin properties as per dependencies","user":{"login":"rnc","id":1169793,"avatar_url":"https://avatars.githubusercontent.com/u/1169793?v=3","gravatar_id":"","url":"https://api.github.com/users/rnc","html_url":"https://github.com/rnc","followers_url":"https://api.github.com/users/rnc/followers","following_url":"https://api.github.com/users/rnc/following{/other_user}","gists_url":"https://api.github.com/users/rnc/gists{/gist_id}","starred_url":"https://api.github.com/users/rnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnc/subscriptions","organizations_url":"https://api.github.com/users/rnc/orgs","repos_url":"https://api.github.com/users/rnc/repos","events_url":"https://api.github.com/users/rnc/events{/privacy}","received_events_url":"https://api.github.com/users/rnc/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-19T15:10:19Z","updated_at":"2015-10-19T15:40:23Z","closed_at":"2015-10-19T15:40:12Z","merged_at":"2015-10-19T15:40:12Z","merge_commit_sha":"d2c61028a5a1f4a2a3d1c13bc213c7668e1f3648","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238/commits","review_comments_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238/comments","review_comment_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/238/comments","statuses_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/statuses/4a30e4e5fcb1ea9ad744a428d06aab8feb0a6690","head":{"label":"rnc:master","ref":"master","sha":"4a30e4e5fcb1ea9ad744a428d06aab8feb0a6690","user":{"login":"rnc","id":1169793,"avatar_url":"https://avatars.githubusercontent.com/u/1169793?v=3","gravatar_id":"","url":"https://api.github.com/users/rnc","html_url":"https://github.com/rnc","followers_url":"https://api.github.com/users/rnc/followers","following_url":"https://api.github.com/users/rnc/following{/other_user}","gists_url":"https://api.github.com/users/rnc/gists{/gist_id}","starred_url":"https://api.github.com/users/rnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnc/subscriptions","organizations_url":"https://api.github.com/users/rnc/orgs","repos_url":"https://api.github.com/users/rnc/repos","events_url":"https://api.github.com/users/rnc/events{/privacy}","received_events_url":"https://api.github.com/users/rnc/received_events","type":"User","site_admin":false},"repo":{"id":19849168,"name":"pom-manipulation-ext","full_name":"rnc/pom-manipulation-ext","owner":{"login":"rnc","id":1169793,"avatar_url":"https://avatars.githubusercontent.com/u/1169793?v=3","gravatar_id":"","url":"https://api.github.com/users/rnc","html_url":"https://github.com/rnc","followers_url":"https://api.github.com/users/rnc/followers","following_url":"https://api.github.com/users/rnc/following{/other_user}","gists_url":"https://api.github.com/users/rnc/gists{/gist_id}","starred_url":"https://api.github.com/users/rnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnc/subscriptions","organizations_url":"https://api.github.com/users/rnc/orgs","repos_url":"https://api.github.com/users/rnc/repos","events_url":"https://api.github.com/users/rnc/events{/privacy}","received_events_url":"https://api.github.com/users/rnc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rnc/pom-manipulation-ext","description":"A more generic framework-style extension for preprocessing Maven pom.xml files before the build runs (from within Maven itself)","fork":true,"url":"https://api.github.com/repos/rnc/pom-manipulation-ext","forks_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/forks","keys_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/teams","hooks_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/hooks","issue_events_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/issues/events{/number}","events_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/events","assignees_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/assignees{/user}","branches_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/branches{/branch}","tags_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/tags","blobs_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/languages","stargazers_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/stargazers","contributors_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/contributors","subscribers_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/subscribers","subscription_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/subscription","commits_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/contents/{+path}","compare_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/merges","archive_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/downloads","issues_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/issues{/number}","pulls_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/labels{/name}","releases_url":"https://api.github.com/repos/rnc/pom-manipulation-ext/releases{/id}","created_at":"2014-05-16T08:09:28Z","updated_at":"2015-05-07T08:52:16Z","pushed_at":"2015-10-19T15:09:14Z","git_url":"git://github.com/rnc/pom-manipulation-ext.git","ssh_url":"git@github.com:rnc/pom-manipulation-ext.git","clone_url":"https://github.com/rnc/pom-manipulation-ext.git","svn_url":"https://github.com/rnc/pom-manipulation-ext","homepage":null,"size":1916,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"cf9ccc1958b5087d699e4b9684fd43c3f2595bec","user":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":19825381,"name":"pom-manipulation-ext","full_name":"release-engineering/pom-manipulation-ext","owner":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars.githubusercontent.com/u/9591189?v=3","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/release-engineering/pom-manipulation-ext","description":"A more generic framework-style extension for preprocessing Maven pom.xml files before the build runs (from within Maven itself)","fork":false,"url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext","forks_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/forks","keys_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/teams","hooks_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/events","assignees_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/tags","blobs_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/languages","stargazers_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/subscription","commits_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/merges","archive_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/downloads","issues_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/releases{/id}","created_at":"2014-05-15T15:46:03Z","updated_at":"2015-09-18T12:10:38Z","pushed_at":"2015-10-19T15:40:13Z","git_url":"git://github.com/release-engineering/pom-manipulation-ext.git","ssh_url":"git@github.com:release-engineering/pom-manipulation-ext.git","clone_url":"https://github.com/release-engineering/pom-manipulation-ext.git","svn_url":"https://github.com/release-engineering/pom-manipulation-ext","homepage":null,"size":2528,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238"},"html":{"href":"https://github.com/release-engineering/pom-manipulation-ext/pull/238"},"issue":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/238"},"comments":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/pom-manipulation-ext/statuses/4a30e4e5fcb1ea9ad744a428d06aab8feb0a6690"}}}}