{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/1361","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/1361/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/1361/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/1361/events","html_url":"https://github.com/dotnet/roslyn/pull/1361","id":62786082,"number":1361,"title":"only try to do inline rename on documents that support it (e.g., not venus)","user":{"login":"brettfo","id":926281,"avatar_url":"https://avatars.githubusercontent.com/u/926281?v=3","gravatar_id":"","url":"https://api.github.com/users/brettfo","html_url":"https://github.com/brettfo","followers_url":"https://api.github.com/users/brettfo/followers","following_url":"https://api.github.com/users/brettfo/following{/other_user}","gists_url":"https://api.github.com/users/brettfo/gists{/gist_id}","starred_url":"https://api.github.com/users/brettfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettfo/subscriptions","organizations_url":"https://api.github.com/users/brettfo/orgs","repos_url":"https://api.github.com/users/brettfo/repos","events_url":"https://api.github.com/users/brettfo/events{/privacy}","received_events_url":"https://api.github.com/users/brettfo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7"},{"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-not-required","name":"cla-not-required","color":"90EE90"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-18T20:02:57Z","updated_at":"2015-03-19T23:20:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/1361","html_url":"https://github.com/dotnet/roslyn/pull/1361","diff_url":"https://github.com/dotnet/roslyn/pull/1361.diff","patch_url":"https://github.com/dotnet/roslyn/pull/1361.patch"},"body":"We were incorrectly trying to do an inline rename in a Venus editor (which is not supported because they don't project all of their spans appropriately) and this was causing a crash when trying to update the tracking span.  The fix is to only track spans in documents that actually support renaming (like we used to do in the past) and then manually notify Venus of the rename (like we currently do in `ContainedLanguageRefactorNotifyService::TryOnAfterGlobalSymbolRenamed()`).  With these changes the behavior is consistent with Dev12.  There is an accompanying test in our private sources."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/83799652","html_url":"https://github.com/dotnet/roslyn/pull/1361#issuecomment-83799652","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/1361","id":83799652,"user":{"login":"jasonmalinowski","id":201340,"avatar_url":"https://avatars.githubusercontent.com/u/201340?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"created_at":"2015-03-19T23:20:41Z","updated_at":"2015-03-19T23:20:41Z","body":":+1:"}}