{"action":"created","comment":{"url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/comments/25861976","id":25861976,"diff_hunk":"@@ -66,6 +66,7 @@\n         <service id=\"ekino.new_relic.twig.new_relic_extension\" class=\"Ekino\\Bundle\\NewRelicBundle\\Twig\\NewRelicExtension\">\n             <argument type=\"service\" id=\"ekino.new_relic\" />\n             <argument type=\"service\" id=\"ekino.new_relic.interactor\" />\n+            <tag name=\"twig.extension\"/>","path":"Resources/config/services.xml","position":4,"original_position":4,"commit_id":"d0afadf3cd07725daa8b3f2d9eb67be3b0be93ca","original_commit_id":"d0afadf3cd07725daa8b3f2d9eb67be3b0be93ca","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars.githubusercontent.com/u/76576?v=3","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"i would add the <tag> after the last <argument>\r\n\r\nand why was this not needed before?","created_at":"2015-03-05T13:14:37Z","updated_at":"2015-03-05T13:14:37Z","html_url":"https://github.com/ekino/EkinoNewRelicBundle/pull/85#discussion_r25861976","pull_request_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/comments/25861976"},"html":{"href":"https://github.com/ekino/EkinoNewRelicBundle/pull/85#discussion_r25861976"},"pull_request":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85","id":30544015,"html_url":"https://github.com/ekino/EkinoNewRelicBundle/pull/85","diff_url":"https://github.com/ekino/EkinoNewRelicBundle/pull/85.diff","patch_url":"https://github.com/ekino/EkinoNewRelicBundle/pull/85.patch","issue_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/85","number":85,"state":"open","locked":false,"title":"Add fixes for method name and service tag for twig","user":{"login":"thormeier","id":2109047,"avatar_url":"https://avatars.githubusercontent.com/u/2109047?v=3","gravatar_id":"","url":"https://api.github.com/users/thormeier","html_url":"https://github.com/thormeier","followers_url":"https://api.github.com/users/thormeier/followers","following_url":"https://api.github.com/users/thormeier/following{/other_user}","gists_url":"https://api.github.com/users/thormeier/gists{/gist_id}","starred_url":"https://api.github.com/users/thormeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thormeier/subscriptions","organizations_url":"https://api.github.com/users/thormeier/orgs","repos_url":"https://api.github.com/users/thormeier/repos","events_url":"https://api.github.com/users/thormeier/events{/privacy}","received_events_url":"https://api.github.com/users/thormeier/received_events","type":"User","site_admin":false},"body":"Also wrong method names and missing tag so twig recognizes this as an extension. Really sorry, tested and everything works now as expected.","created_at":"2015-03-05T10:07:09Z","updated_at":"2015-03-05T13:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc0d624253c48b185965c7fc0de8bcf632db3597","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85/commits","review_comments_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85/comments","review_comment_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/85/comments","statuses_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/statuses/d0afadf3cd07725daa8b3f2d9eb67be3b0be93ca","head":{"label":"thormeier:twig-extensions-for-rum","ref":"twig-extensions-for-rum","sha":"d0afadf3cd07725daa8b3f2d9eb67be3b0be93ca","user":{"login":"thormeier","id":2109047,"avatar_url":"https://avatars.githubusercontent.com/u/2109047?v=3","gravatar_id":"","url":"https://api.github.com/users/thormeier","html_url":"https://github.com/thormeier","followers_url":"https://api.github.com/users/thormeier/followers","following_url":"https://api.github.com/users/thormeier/following{/other_user}","gists_url":"https://api.github.com/users/thormeier/gists{/gist_id}","starred_url":"https://api.github.com/users/thormeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thormeier/subscriptions","organizations_url":"https://api.github.com/users/thormeier/orgs","repos_url":"https://api.github.com/users/thormeier/repos","events_url":"https://api.github.com/users/thormeier/events{/privacy}","received_events_url":"https://api.github.com/users/thormeier/received_events","type":"User","site_admin":false},"repo":{"id":23489946,"name":"EkinoNewRelicBundle","full_name":"thormeier/EkinoNewRelicBundle","owner":{"login":"thormeier","id":2109047,"avatar_url":"https://avatars.githubusercontent.com/u/2109047?v=3","gravatar_id":"","url":"https://api.github.com/users/thormeier","html_url":"https://github.com/thormeier","followers_url":"https://api.github.com/users/thormeier/followers","following_url":"https://api.github.com/users/thormeier/following{/other_user}","gists_url":"https://api.github.com/users/thormeier/gists{/gist_id}","starred_url":"https://api.github.com/users/thormeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thormeier/subscriptions","organizations_url":"https://api.github.com/users/thormeier/orgs","repos_url":"https://api.github.com/users/thormeier/repos","events_url":"https://api.github.com/users/thormeier/events{/privacy}","received_events_url":"https://api.github.com/users/thormeier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thormeier/EkinoNewRelicBundle","description":"Add NewRelic support to Symfony2","fork":true,"url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle","forks_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/forks","keys_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/teams","hooks_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/hooks","issue_events_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/issues/events{/number}","events_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/events","assignees_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/assignees{/user}","branches_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/branches{/branch}","tags_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/tags","blobs_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/languages","stargazers_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/stargazers","contributors_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/contributors","subscribers_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/subscribers","subscription_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/subscription","commits_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/contents/{+path}","compare_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/merges","archive_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/downloads","issues_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/issues{/number}","pulls_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/labels{/name}","releases_url":"https://api.github.com/repos/thormeier/EkinoNewRelicBundle/releases{/id}","created_at":"2014-08-30T10:59:07Z","updated_at":"2014-08-12T02:52:33Z","pushed_at":"2015-03-05T10:41:05Z","git_url":"git://github.com/thormeier/EkinoNewRelicBundle.git","ssh_url":"git@github.com:thormeier/EkinoNewRelicBundle.git","clone_url":"https://github.com/thormeier/EkinoNewRelicBundle.git","svn_url":"https://github.com/thormeier/EkinoNewRelicBundle","homepage":null,"size":226,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ekino:master","ref":"master","sha":"c50be991dc2ff6647a5076e9ce5f38ee24fe0f93","user":{"login":"ekino","id":574481,"avatar_url":"https://avatars.githubusercontent.com/u/574481?v=3","gravatar_id":"","url":"https://api.github.com/users/ekino","html_url":"https://github.com/ekino","followers_url":"https://api.github.com/users/ekino/followers","following_url":"https://api.github.com/users/ekino/following{/other_user}","gists_url":"https://api.github.com/users/ekino/gists{/gist_id}","starred_url":"https://api.github.com/users/ekino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekino/subscriptions","organizations_url":"https://api.github.com/users/ekino/orgs","repos_url":"https://api.github.com/users/ekino/repos","events_url":"https://api.github.com/users/ekino/events{/privacy}","received_events_url":"https://api.github.com/users/ekino/received_events","type":"Organization","site_admin":false},"repo":{"id":5265166,"name":"EkinoNewRelicBundle","full_name":"ekino/EkinoNewRelicBundle","owner":{"login":"ekino","id":574481,"avatar_url":"https://avatars.githubusercontent.com/u/574481?v=3","gravatar_id":"","url":"https://api.github.com/users/ekino","html_url":"https://github.com/ekino","followers_url":"https://api.github.com/users/ekino/followers","following_url":"https://api.github.com/users/ekino/following{/other_user}","gists_url":"https://api.github.com/users/ekino/gists{/gist_id}","starred_url":"https://api.github.com/users/ekino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekino/subscriptions","organizations_url":"https://api.github.com/users/ekino/orgs","repos_url":"https://api.github.com/users/ekino/repos","events_url":"https://api.github.com/users/ekino/events{/privacy}","received_events_url":"https://api.github.com/users/ekino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ekino/EkinoNewRelicBundle","description":"Add NewRelic support to Symfony2","fork":false,"url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle","forks_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/forks","keys_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/teams","hooks_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/hooks","issue_events_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/events","assignees_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/tags","blobs_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/languages","stargazers_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/stargazers","contributors_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/contributors","subscribers_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/subscribers","subscription_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/subscription","commits_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/merges","archive_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/downloads","issues_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/labels{/name}","releases_url":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/releases{/id}","created_at":"2012-08-01T21:40:14Z","updated_at":"2015-03-04T21:00:45Z","pushed_at":"2015-03-04T21:00:45Z","git_url":"git://github.com/ekino/EkinoNewRelicBundle.git","ssh_url":"git@github.com:ekino/EkinoNewRelicBundle.git","clone_url":"https://github.com/ekino/EkinoNewRelicBundle.git","svn_url":"https://github.com/ekino/EkinoNewRelicBundle","homepage":null,"size":609,"stargazers_count":105,"watchers_count":105,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":21,"forks":33,"open_issues":21,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85"},"html":{"href":"https://github.com/ekino/EkinoNewRelicBundle/pull/85"},"issue":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/85"},"comments":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/ekino/EkinoNewRelicBundle/statuses/d0afadf3cd07725daa8b3f2d9eb67be3b0be93ca"}}}}