{"action":"created","issue":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/578","labels_url":"https://api.github.com/repos/mlr-org/mlr/issues/578/labels{/name}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/578/comments","events_url":"https://api.github.com/repos/mlr-org/mlr/issues/578/events","html_url":"https://github.com/mlr-org/mlr/pull/578","id":119524405,"number":578,"title":"fix memory leaks for benchmark()","user":{"login":"mllg","id":1260920,"avatar_url":"https://avatars.githubusercontent.com/u/1260920?v=3","gravatar_id":"","url":"https://api.github.com/users/mllg","html_url":"https://github.com/mllg","followers_url":"https://api.github.com/users/mllg/followers","following_url":"https://api.github.com/users/mllg/following{/other_user}","gists_url":"https://api.github.com/users/mllg/gists{/gist_id}","starred_url":"https://api.github.com/users/mllg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mllg/subscriptions","organizations_url":"https://api.github.com/users/mllg/orgs","repos_url":"https://api.github.com/users/mllg/repos","events_url":"https://api.github.com/users/mllg/events{/privacy}","received_events_url":"https://api.github.com/users/mllg/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-30T16:13:50Z","updated_at":"2015-11-30T18:39:49Z","closed_at":"2015-11-30T17:06:19Z","pull_request":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/578","html_url":"https://github.com/mlr-org/mlr/pull/578","diff_url":"https://github.com/mlr-org/mlr/pull/578.diff","patch_url":"https://github.com/mlr-org/mlr/pull/578.patch"},"body":"I ran into a problem where I could not perform a very basic benchmark study of different SVMs w/o mlr eating >30GB of memory. This should fix it:\r\n\r\n* `keep.preds` is now correctly passed down to `resample()`\r\n* Added argument `models` to `benchmark()`, also passed down to `resample()`\r\n* Some minor cleanups and simplifications in `benchmark()`"},"comment":{"url":"https://api.github.com/repos/mlr-org/mlr/issues/comments/160718422","html_url":"https://github.com/mlr-org/mlr/pull/578#issuecomment-160718422","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/578","id":160718422,"user":{"login":"mllg","id":1260920,"avatar_url":"https://avatars.githubusercontent.com/u/1260920?v=3","gravatar_id":"","url":"https://api.github.com/users/mllg","html_url":"https://github.com/mllg","followers_url":"https://api.github.com/users/mllg/followers","following_url":"https://api.github.com/users/mllg/following{/other_user}","gists_url":"https://api.github.com/users/mllg/gists{/gist_id}","starred_url":"https://api.github.com/users/mllg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mllg/subscriptions","organizations_url":"https://api.github.com/users/mllg/orgs","repos_url":"https://api.github.com/users/mllg/repos","events_url":"https://api.github.com/users/mllg/events{/privacy}","received_events_url":"https://api.github.com/users/mllg/received_events","type":"User","site_admin":false},"created_at":"2015-11-30T18:39:49Z","updated_at":"2015-11-30T18:39:49Z","body":"> 1) unit tests for keep.pred / the detected error\r\n\r\nIn #581 \r\n\r\n> 2) unit test for option \"models\"\r\n\r\nIn #581 \r\n\r\n> 3) doc effect of \"models\" in BMR object doc\r\n\r\nPart of ResampleResult, already documented there.\r\n\r\n> 4) either implement a BMR getter for the models or open a new issue for this. as this is in the thread for #443\r\n\r\nSee #582.\r\n"}}