{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/643","labels_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/643/labels{/name}","comments_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/643/comments","events_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/643/events","html_url":"https://github.com/ClusterLabs/resource-agents/pull/643","id":95212538,"number":643,"title":"iSCSILogicalUnit improvements","user":{"login":"fghaas","id":610707,"avatar_url":"https://avatars.githubusercontent.com/u/610707?v=3","gravatar_id":"","url":"https://api.github.com/users/fghaas","html_url":"https://github.com/fghaas","followers_url":"https://api.github.com/users/fghaas/followers","following_url":"https://api.github.com/users/fghaas/following{/other_user}","gists_url":"https://api.github.com/users/fghaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fghaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fghaas/subscriptions","organizations_url":"https://api.github.com/users/fghaas/orgs","repos_url":"https://api.github.com/users/fghaas/repos","events_url":"https://api.github.com/users/fghaas/events{/privacy}","received_events_url":"https://api.github.com/users/fghaas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-15T14:42:05Z","updated_at":"2015-07-27T12:23:48Z","closed_at":"2015-07-27T12:23:32Z","pull_request":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/pulls/643","html_url":"https://github.com/ClusterLabs/resource-agents/pull/643","diff_url":"https://github.com/ClusterLabs/resource-agents/pull/643.diff","patch_url":"https://github.com/ClusterLabs/resource-agents/pull/643.patch"},"body":"This PR contains three improvements to `iSCSILogicalUnit`. One is generic, the other two are specific to the `lio-t` implementation.\r\n\r\n- 1b3ac8f extends behavior previously present just for `lio` to `lio-t`, in that it checks for existence of the backing store ConfigFS entry in stop, as opposed to just that for the iSCSI LUN. Fixes #640.\r\n- 7e051ab is being more persistent on stop. `targetcli` will fail when attempting to delete a LUN that has already been deleted; previously we would bail out then and there letting the backing store entries linger (and keeping underlying block devices busy). Fixes #642.\r\n- aae6d1b is generic and checks the existence of the underlying block device on monitor. If the backing device is not there, we can safely assume that the LU is not exported. Fixes #641.\r\n\r\nIssue #631 is related and is pending a merge.\r\n\r\n@davidvossel, I believe you wrote the original `lio-t` implementation — would you mind taking a look? "},"comment":{"url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/comments/125185840","html_url":"https://github.com/ClusterLabs/resource-agents/pull/643#issuecomment-125185840","issue_url":"https://api.github.com/repos/ClusterLabs/resource-agents/issues/643","id":125185840,"user":{"login":"fghaas","id":610707,"avatar_url":"https://avatars.githubusercontent.com/u/610707?v=3","gravatar_id":"","url":"https://api.github.com/users/fghaas","html_url":"https://github.com/fghaas","followers_url":"https://api.github.com/users/fghaas/followers","following_url":"https://api.github.com/users/fghaas/following{/other_user}","gists_url":"https://api.github.com/users/fghaas/gists{/gist_id}","starred_url":"https://api.github.com/users/fghaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fghaas/subscriptions","organizations_url":"https://api.github.com/users/fghaas/orgs","repos_url":"https://api.github.com/users/fghaas/repos","events_url":"https://api.github.com/users/fghaas/events{/privacy}","received_events_url":"https://api.github.com/users/fghaas/received_events","type":"User","site_admin":false},"created_at":"2015-07-27T12:23:48Z","updated_at":"2015-07-27T12:23:48Z","body":"Merged after rebasing on current master."}}