{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30991219","id":30991219,"diff_hunk":"@@ -74,23 +75,34 @@ object CypherCompilerFactory {\n \n     val pickedPlannerName = plannerName.getOrElse(FallbackPlannerName)","path":"community/cypher/cypher-compiler-2.3/src/main/scala/org/neo4j/cypher/internal/compiler/v2_3/CypherCompiler.scala","position":28,"original_position":28,"commit_id":"7a5b56907692eff8b393ac413c4c9509c20ce9b5","original_commit_id":"7a5b56907692eff8b393ac413c4c9509c20ce9b5","user":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars.githubusercontent.com/u/88000?v=3","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"body":"I still find it confusing that we define defaults in `RuntimeName` and `PlannerName` but we don't use these defaults here?","created_at":"2015-05-25T18:53:19Z","updated_at":"2015-05-25T18:53:19Z","html_url":"https://github.com/neo4j/neo4j/pull/4680#discussion_r30991219","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4680","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/30991219"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4680#discussion_r30991219"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4680"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/4680","id":36044725,"html_url":"https://github.com/neo4j/neo4j/pull/4680","diff_url":"https://github.com/neo4j/neo4j/pull/4680.diff","patch_url":"https://github.com/neo4j/neo4j/pull/4680.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/4680","number":4680,"state":"open","locked":false,"title":"2.3 planner runtime refactor","user":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"body":"Refactoring effort to unify the way we handle fallbacks for plans and runtimes.","created_at":"2015-05-22T15:58:24Z","updated_at":"2015-05-25T18:53:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81d750cb44b23e56ef063e93162cfe09ace92c09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4680/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/4680/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/4680/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/7a5b56907692eff8b393ac413c4c9509c20ce9b5","head":{"label":"Mats-SX:2.3-planner-runtime-refactor","ref":"2.3-planner-runtime-refactor","sha":"7a5b56907692eff8b393ac413c4c9509c20ce9b5","user":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"repo":{"id":32784893,"name":"neo4j","full_name":"Mats-SX/neo4j","owner":{"login":"Mats-SX","id":2419675,"avatar_url":"https://avatars.githubusercontent.com/u/2419675?v=3","gravatar_id":"","url":"https://api.github.com/users/Mats-SX","html_url":"https://github.com/Mats-SX","followers_url":"https://api.github.com/users/Mats-SX/followers","following_url":"https://api.github.com/users/Mats-SX/following{/other_user}","gists_url":"https://api.github.com/users/Mats-SX/gists{/gist_id}","starred_url":"https://api.github.com/users/Mats-SX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mats-SX/subscriptions","organizations_url":"https://api.github.com/users/Mats-SX/orgs","repos_url":"https://api.github.com/users/Mats-SX/repos","events_url":"https://api.github.com/users/Mats-SX/events{/privacy}","received_events_url":"https://api.github.com/users/Mats-SX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mats-SX/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/Mats-SX/neo4j","forks_url":"https://api.github.com/repos/Mats-SX/neo4j/forks","keys_url":"https://api.github.com/repos/Mats-SX/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mats-SX/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mats-SX/neo4j/teams","hooks_url":"https://api.github.com/repos/Mats-SX/neo4j/hooks","issue_events_url":"https://api.github.com/repos/Mats-SX/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/Mats-SX/neo4j/events","assignees_url":"https://api.github.com/repos/Mats-SX/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/Mats-SX/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/Mats-SX/neo4j/tags","blobs_url":"https://api.github.com/repos/Mats-SX/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mats-SX/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mats-SX/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mats-SX/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mats-SX/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/Mats-SX/neo4j/languages","stargazers_url":"https://api.github.com/repos/Mats-SX/neo4j/stargazers","contributors_url":"https://api.github.com/repos/Mats-SX/neo4j/contributors","subscribers_url":"https://api.github.com/repos/Mats-SX/neo4j/subscribers","subscription_url":"https://api.github.com/repos/Mats-SX/neo4j/subscription","commits_url":"https://api.github.com/repos/Mats-SX/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mats-SX/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mats-SX/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mats-SX/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mats-SX/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/Mats-SX/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mats-SX/neo4j/merges","archive_url":"https://api.github.com/repos/Mats-SX/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mats-SX/neo4j/downloads","issues_url":"https://api.github.com/repos/Mats-SX/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/Mats-SX/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/Mats-SX/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/Mats-SX/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mats-SX/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/Mats-SX/neo4j/releases{/id}","created_at":"2015-03-24T08:02:04Z","updated_at":"2015-03-24T08:02:47Z","pushed_at":"2015-05-25T12:21:39Z","git_url":"git://github.com/Mats-SX/neo4j.git","ssh_url":"git@github.com:Mats-SX/neo4j.git","clone_url":"https://github.com/Mats-SX/neo4j.git","svn_url":"https://github.com/Mats-SX/neo4j","homepage":"http://neo4j.com","size":197341,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"e8f44148395ea72b7e069122c2a8b0394a598dbd","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-05-25T17:36:56Z","pushed_at":"2015-05-25T16:17:53Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":476977,"stargazers_count":1691,"watchers_count":1691,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":681,"mirror_url":null,"open_issues_count":439,"forks":681,"open_issues":439,"watchers":1691,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4680"},"html":{"href":"https://github.com/neo4j/neo4j/pull/4680"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4680"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/4680/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4680/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/4680/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/7a5b56907692eff8b393ac413c4c9509c20ce9b5"}}}}