{"action":"created","comment":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/33044164","id":33044164,"diff_hunk":"@@ -116,39 +118,18 @@ private boolean needRedraw(Range ranks, Thresholds newThreshold) {\n \t\t\t\t.collect(Collectors.toList());\n \t}\n \n-\tprivate void drawAnnotations(Collection<Annotation> annotations) {\n-\t\tGene prev = null;\n-\t\tfor (Annotation a : annotations) {\n-\t\t\tprev = loadAnnotations(a, prev);\n-\t\t}\n-\t}\n-\n-\tprivate Gene loadAnnotations(Annotation annotation, Gene prev) {\n+\tprivate Gene loadAnnotations(Annotation annotation) {\n \t\tGene g = new Gene(annotation);\n \t\tClusterDrawable left = getClusterDrawable(annotation, Double.MAX_VALUE,\n \t\t\t\t(x, acc) -> x <= acc);\n \t\tClusterDrawable right = getClusterDrawable(annotation, Double.MIN_VALUE,\n \t\t\t\t(x, acc) -> x >= acc);\n-\t\t/*if (left != null) {\n-\t\t\tcontent.getChildren().add(new Connection(g.translateXProperty().add(0),\n-\t\t\t\t\tg.translateYProperty().add(0), left.translateXProperty().add(0),\n-\t\t\t\t\tleft.translateYProperty().add(0)));\n-\t\t}\n-\t\tif (right != null) {\n-\t\t\tcontent.getChildren().add(new Connection(g.translateXProperty().add(\n-\t\t\t\t\tg.widthProperty()), g.translateYProperty().add(0),\n-\t\t\t\t\tright.translateXProperty().add(0), right.translateYProperty().add(0)));\n-\t\t}*/\n \t\tif (left != null && right != null) {\n \t\t\tg.translateXProperty().bind(Bindings.add(left.translateXProperty(), Bindings.subtract(\n \t\t\t\t\tBindings.divide(right.translateXProperty().subtract(left.translateXProperty()),\n \t\t\t\t\t\t\t2), g.widthProperty().divide(2))));\n-\t\t\tif (prev != null && g.getLayoutBounds().intersects(prev.getLayoutBounds())) {\n-\t\t\t\tg.translateYProperty().bind(prev.translateYProperty()\n-\t\t\t\t\t\t.add(prev.heightProperty()).add(ANNOTATION_HEIGHT));\n-\t\t\t} else {\n-\t\t\t\tg.translateYProperty().bind(left.translateYProperty().add(ANNOTATION_HEIGHT));\n-\t\t\t}\n+\t\t\tg.translateYProperty().setValue(ANNOTATION_HEIGHT\n+\t\t\t\t\t* (curAnnotationY++ % MAX_ANNOTATIONS));","path":"dnainator-javafx/src/main/java/nl/tudelft/dnainator/javafx/drawables/strains/Strain.java","position":60,"original_position":60,"commit_id":"675223067357fa02787cabc9005b84752951e4e2","original_commit_id":"675223067357fa02787cabc9005b84752951e4e2","user":{"login":"Balletie","id":3884925,"avatar_url":"https://avatars.githubusercontent.com/u/3884925?v=3","gravatar_id":"","url":"https://api.github.com/users/Balletie","html_url":"https://github.com/Balletie","followers_url":"https://api.github.com/users/Balletie/followers","following_url":"https://api.github.com/users/Balletie/following{/other_user}","gists_url":"https://api.github.com/users/Balletie/gists{/gist_id}","starred_url":"https://api.github.com/users/Balletie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balletie/subscriptions","organizations_url":"https://api.github.com/users/Balletie/orgs","repos_url":"https://api.github.com/users/Balletie/repos","events_url":"https://api.github.com/users/Balletie/events{/privacy}","received_events_url":"https://api.github.com/users/Balletie/received_events","type":"User","site_admin":false},"body":"At least it's not an infinite sequence..","created_at":"2015-06-23T14:08:13Z","updated_at":"2015-06-23T14:08:13Z","html_url":"https://github.com/DNAinator/dnainator/pull/184#discussion_r33044164","pull_request_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/184","_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments/33044164"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/184#discussion_r33044164"},"pull_request":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/184"}}},"pull_request":{"url":"https://api.github.com/repos/DNAinator/dnainator/pulls/184","id":38334964,"html_url":"https://github.com/DNAinator/dnainator/pull/184","diff_url":"https://github.com/DNAinator/dnainator/pull/184.diff","patch_url":"https://github.com/DNAinator/dnainator/pull/184.patch","issue_url":"https://api.github.com/repos/DNAinator/dnainator/issues/184","number":184,"state":"open","locked":false,"title":"[RDY] Redo annotations","user":{"login":"pvanagtmaal","id":5946464,"avatar_url":"https://avatars.githubusercontent.com/u/5946464?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanagtmaal","html_url":"https://github.com/pvanagtmaal","followers_url":"https://api.github.com/users/pvanagtmaal/followers","following_url":"https://api.github.com/users/pvanagtmaal/following{/other_user}","gists_url":"https://api.github.com/users/pvanagtmaal/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanagtmaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanagtmaal/subscriptions","organizations_url":"https://api.github.com/users/pvanagtmaal/orgs","repos_url":"https://api.github.com/users/pvanagtmaal/repos","events_url":"https://api.github.com/users/pvanagtmaal/events{/privacy}","received_events_url":"https://api.github.com/users/pvanagtmaal/received_events","type":"User","site_admin":false},"body":"Draw them differently\r\nRemove redundant info\r\nColor consistently","created_at":"2015-06-23T13:17:10Z","updated_at":"2015-06-23T14:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"937413ec9337daba8b59fa873392641539033f8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/184/commits","review_comments_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/184/comments","review_comment_url":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/issues/184/comments","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/675223067357fa02787cabc9005b84752951e4e2","head":{"label":"pvanagtmaal:piet-redo-annotations","ref":"piet-redo-annotations","sha":"675223067357fa02787cabc9005b84752951e4e2","user":{"login":"pvanagtmaal","id":5946464,"avatar_url":"https://avatars.githubusercontent.com/u/5946464?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanagtmaal","html_url":"https://github.com/pvanagtmaal","followers_url":"https://api.github.com/users/pvanagtmaal/followers","following_url":"https://api.github.com/users/pvanagtmaal/following{/other_user}","gists_url":"https://api.github.com/users/pvanagtmaal/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanagtmaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanagtmaal/subscriptions","organizations_url":"https://api.github.com/users/pvanagtmaal/orgs","repos_url":"https://api.github.com/users/pvanagtmaal/repos","events_url":"https://api.github.com/users/pvanagtmaal/events{/privacy}","received_events_url":"https://api.github.com/users/pvanagtmaal/received_events","type":"User","site_admin":false},"repo":{"id":35174674,"name":"dnainator","full_name":"pvanagtmaal/dnainator","owner":{"login":"pvanagtmaal","id":5946464,"avatar_url":"https://avatars.githubusercontent.com/u/5946464?v=3","gravatar_id":"","url":"https://api.github.com/users/pvanagtmaal","html_url":"https://github.com/pvanagtmaal","followers_url":"https://api.github.com/users/pvanagtmaal/followers","following_url":"https://api.github.com/users/pvanagtmaal/following{/other_user}","gists_url":"https://api.github.com/users/pvanagtmaal/gists{/gist_id}","starred_url":"https://api.github.com/users/pvanagtmaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvanagtmaal/subscriptions","organizations_url":"https://api.github.com/users/pvanagtmaal/orgs","repos_url":"https://api.github.com/users/pvanagtmaal/repos","events_url":"https://api.github.com/users/pvanagtmaal/events{/privacy}","received_events_url":"https://api.github.com/users/pvanagtmaal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pvanagtmaal/dnainator","description":"TI2806 Contextproject","fork":true,"url":"https://api.github.com/repos/pvanagtmaal/dnainator","forks_url":"https://api.github.com/repos/pvanagtmaal/dnainator/forks","keys_url":"https://api.github.com/repos/pvanagtmaal/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pvanagtmaal/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pvanagtmaal/dnainator/teams","hooks_url":"https://api.github.com/repos/pvanagtmaal/dnainator/hooks","issue_events_url":"https://api.github.com/repos/pvanagtmaal/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/pvanagtmaal/dnainator/events","assignees_url":"https://api.github.com/repos/pvanagtmaal/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/pvanagtmaal/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/pvanagtmaal/dnainator/tags","blobs_url":"https://api.github.com/repos/pvanagtmaal/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pvanagtmaal/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pvanagtmaal/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pvanagtmaal/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pvanagtmaal/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/pvanagtmaal/dnainator/languages","stargazers_url":"https://api.github.com/repos/pvanagtmaal/dnainator/stargazers","contributors_url":"https://api.github.com/repos/pvanagtmaal/dnainator/contributors","subscribers_url":"https://api.github.com/repos/pvanagtmaal/dnainator/subscribers","subscription_url":"https://api.github.com/repos/pvanagtmaal/dnainator/subscription","commits_url":"https://api.github.com/repos/pvanagtmaal/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pvanagtmaal/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pvanagtmaal/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pvanagtmaal/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pvanagtmaal/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/pvanagtmaal/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pvanagtmaal/dnainator/merges","archive_url":"https://api.github.com/repos/pvanagtmaal/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pvanagtmaal/dnainator/downloads","issues_url":"https://api.github.com/repos/pvanagtmaal/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/pvanagtmaal/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/pvanagtmaal/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/pvanagtmaal/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pvanagtmaal/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/pvanagtmaal/dnainator/releases{/id}","created_at":"2015-05-06T18:03:13Z","updated_at":"2015-05-06T18:03:14Z","pushed_at":"2015-06-23T14:01:07Z","git_url":"git://github.com/pvanagtmaal/dnainator.git","ssh_url":"git@github.com:pvanagtmaal/dnainator.git","clone_url":"https://github.com/pvanagtmaal/dnainator.git","svn_url":"https://github.com/pvanagtmaal/dnainator","homepage":null,"size":13740,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DNAinator:master","ref":"master","sha":"9aadf75314aca4e9a1ef6ca44c9adc51a2a192fb","user":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"repo":{"id":34383905,"name":"dnainator","full_name":"DNAinator/dnainator","owner":{"login":"DNAinator","id":12066097,"avatar_url":"https://avatars.githubusercontent.com/u/12066097?v=3","gravatar_id":"","url":"https://api.github.com/users/DNAinator","html_url":"https://github.com/DNAinator","followers_url":"https://api.github.com/users/DNAinator/followers","following_url":"https://api.github.com/users/DNAinator/following{/other_user}","gists_url":"https://api.github.com/users/DNAinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DNAinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNAinator/subscriptions","organizations_url":"https://api.github.com/users/DNAinator/orgs","repos_url":"https://api.github.com/users/DNAinator/repos","events_url":"https://api.github.com/users/DNAinator/events{/privacy}","received_events_url":"https://api.github.com/users/DNAinator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DNAinator/dnainator","description":"TI2806 Contextproject","fork":false,"url":"https://api.github.com/repos/DNAinator/dnainator","forks_url":"https://api.github.com/repos/DNAinator/dnainator/forks","keys_url":"https://api.github.com/repos/DNAinator/dnainator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNAinator/dnainator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNAinator/dnainator/teams","hooks_url":"https://api.github.com/repos/DNAinator/dnainator/hooks","issue_events_url":"https://api.github.com/repos/DNAinator/dnainator/issues/events{/number}","events_url":"https://api.github.com/repos/DNAinator/dnainator/events","assignees_url":"https://api.github.com/repos/DNAinator/dnainator/assignees{/user}","branches_url":"https://api.github.com/repos/DNAinator/dnainator/branches{/branch}","tags_url":"https://api.github.com/repos/DNAinator/dnainator/tags","blobs_url":"https://api.github.com/repos/DNAinator/dnainator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNAinator/dnainator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNAinator/dnainator/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNAinator/dnainator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNAinator/dnainator/statuses/{sha}","languages_url":"https://api.github.com/repos/DNAinator/dnainator/languages","stargazers_url":"https://api.github.com/repos/DNAinator/dnainator/stargazers","contributors_url":"https://api.github.com/repos/DNAinator/dnainator/contributors","subscribers_url":"https://api.github.com/repos/DNAinator/dnainator/subscribers","subscription_url":"https://api.github.com/repos/DNAinator/dnainator/subscription","commits_url":"https://api.github.com/repos/DNAinator/dnainator/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNAinator/dnainator/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNAinator/dnainator/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNAinator/dnainator/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNAinator/dnainator/contents/{+path}","compare_url":"https://api.github.com/repos/DNAinator/dnainator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNAinator/dnainator/merges","archive_url":"https://api.github.com/repos/DNAinator/dnainator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNAinator/dnainator/downloads","issues_url":"https://api.github.com/repos/DNAinator/dnainator/issues{/number}","pulls_url":"https://api.github.com/repos/DNAinator/dnainator/pulls{/number}","milestones_url":"https://api.github.com/repos/DNAinator/dnainator/milestones{/number}","notifications_url":"https://api.github.com/repos/DNAinator/dnainator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNAinator/dnainator/labels{/name}","releases_url":"https://api.github.com/repos/DNAinator/dnainator/releases{/id}","created_at":"2015-04-22T10:22:38Z","updated_at":"2015-06-02T19:49:41Z","pushed_at":"2015-06-23T14:05:27Z","git_url":"git://github.com/DNAinator/dnainator.git","ssh_url":"git@github.com:DNAinator/dnainator.git","clone_url":"https://github.com/DNAinator/dnainator.git","svn_url":"https://github.com/DNAinator/dnainator","homepage":null,"size":21720,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/184"},"html":{"href":"https://github.com/DNAinator/dnainator/pull/184"},"issue":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/184"},"comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DNAinator/dnainator/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/DNAinator/dnainator/statuses/675223067357fa02787cabc9005b84752951e4e2"}}}}