{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/25110475","id":25110475,"diff_hunk":"@@ -122,7 +133,7 @@\n   # Owner of the environments dir: for cases external service needs write\n   # access to manage it.\n   $server_environments_owner   = $user\n-  $server_environments_group   = 'root'\n+  $server_environments_group   = $root_group","path":"manifests/params.pp","position":53,"original_position":43,"commit_id":"d0f537f3d045eccb326b9e66d9b339d1bc2d6cd0","original_commit_id":"e5fa55c82e23dff296f1a264c53bcd3262131791","user":{"login":"genebean","id":966789,"avatar_url":"https://avatars.githubusercontent.com/u/966789?v=3","gravatar_id":"","url":"https://api.github.com/users/genebean","html_url":"https://github.com/genebean","followers_url":"https://api.github.com/users/genebean/followers","following_url":"https://api.github.com/users/genebean/following{/other_user}","gists_url":"https://api.github.com/users/genebean/gists{/gist_id}","starred_url":"https://api.github.com/users/genebean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genebean/subscriptions","organizations_url":"https://api.github.com/users/genebean/orgs","repos_url":"https://api.github.com/users/genebean/repos","events_url":"https://api.github.com/users/genebean/events{/privacy}","received_events_url":"https://api.github.com/users/genebean/received_events","type":"User","site_admin":false},"body":"I would think undef because, generally speaking, you will want it to inherit permissions from it's parent folder. There are also some interesting issues with permissions on Windows via Puppet outlined at https://docs.puppetlabs.com/puppet/3.6/reference/resources_file_windows.html","created_at":"2015-02-20T22:55:48Z","updated_at":"2015-02-20T22:55:48Z","html_url":"https://github.com/theforeman/puppet-puppet/pull/241#discussion_r25110475","pull_request_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/25110475"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/241#discussion_r25110475"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241","id":29403662,"html_url":"https://github.com/theforeman/puppet-puppet/pull/241","diff_url":"https://github.com/theforeman/puppet-puppet/pull/241.diff","patch_url":"https://github.com/theforeman/puppet-puppet/pull/241.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/241","number":241,"state":"open","locked":false,"title":"FreeBSD agent support","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"body":"For the master configuration there's more stuff missing from puppetlabs-apache, so that's not going to happen for now.\r\n\r\nThe server_vardir parameter is gone, which is theoretically OK because the version is bumped anyway. puppet-foreman_proxy would need to be updated in one line where this is used as default for a puppet_home setting.","created_at":"2015-02-16T22:03:19Z","updated_at":"2015-02-20T22:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2476a882fc9b372949fa15755c3cb2e11122d73","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/{number}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/241/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/d0f537f3d045eccb326b9e66d9b339d1bc2d6cd0","head":{"label":"mmoll:freebsd","ref":"freebsd","sha":"d0f537f3d045eccb326b9e66d9b339d1bc2d6cd0","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"repo":{"id":11692248,"name":"puppet-puppet","full_name":"mmoll/puppet-puppet","owner":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmoll/puppet-puppet","description":"Puppet module for Puppet client and server","fork":true,"url":"https://api.github.com/repos/mmoll/puppet-puppet","forks_url":"https://api.github.com/repos/mmoll/puppet-puppet/forks","keys_url":"https://api.github.com/repos/mmoll/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmoll/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmoll/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/mmoll/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/mmoll/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/mmoll/puppet-puppet/events","assignees_url":"https://api.github.com/repos/mmoll/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/mmoll/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/mmoll/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/mmoll/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmoll/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmoll/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmoll/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmoll/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/mmoll/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/mmoll/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/mmoll/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/mmoll/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/mmoll/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/mmoll/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmoll/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmoll/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmoll/puppet-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/mmoll/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/mmoll/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmoll/puppet-puppet/merges","archive_url":"https://api.github.com/repos/mmoll/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmoll/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/mmoll/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/mmoll/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/mmoll/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/mmoll/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmoll/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/mmoll/puppet-puppet/releases{/id}","created_at":"2013-07-26T18:38:29Z","updated_at":"2015-02-13T21:37:30Z","pushed_at":"2015-02-20T20:04:11Z","git_url":"git://github.com/mmoll/puppet-puppet.git","ssh_url":"git@github.com:mmoll/puppet-puppet.git","clone_url":"https://github.com/mmoll/puppet-puppet.git","svn_url":"https://github.com/mmoll/puppet-puppet","homepage":"","size":751,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"4cc6629697c111b73aee628f41158f0e7db81bbb","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449635,"name":"puppet-puppet","full_name":"theforeman/puppet-puppet","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-puppet","description":"Puppet module for Puppet client and server","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-puppet","forks_url":"https://api.github.com/repos/theforeman/puppet-puppet/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-puppet/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-puppet/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-puppet/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-puppet/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-puppet/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-puppet/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-puppet/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues/comments/{number}","contents_url":"https://api.github.com/repos/theforeman/puppet-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-puppet/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-puppet/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-puppet/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-puppet/releases{/id}","created_at":"2012-02-15T13:23:34Z","updated_at":"2015-02-13T21:38:09Z","pushed_at":"2015-02-13T21:38:07Z","git_url":"git://github.com/theforeman/puppet-puppet.git","ssh_url":"git@github.com:theforeman/puppet-puppet.git","clone_url":"https://github.com/theforeman/puppet-puppet.git","svn_url":"https://github.com/theforeman/puppet-puppet","homepage":"","size":2348,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":15,"forks":87,"open_issues":15,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/241"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/241"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/statuses/d0f537f3d045eccb326b9e66d9b339d1bc2d6cd0"}}}}