{"action":"opened","number":799,"pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/799","id":33351813,"html_url":"https://github.com/opal/opal/pull/799","diff_url":"https://github.com/opal/opal/pull/799.diff","patch_url":"https://github.com/opal/opal/pull/799.patch","issue_url":"https://api.github.com/repos/opal/opal/issues/799","number":799,"state":"open","locked":false,"title":"Fix underscore stripping regex in Kernel#Integer and Kernel#Float","user":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"body":"The regex /(\\d)_(\\d)/g did not handle some cases correctly, e.g.\r\n”10_1_0.5_5_5\" became “101_0.55_5” instead of the expected “1010.555”.\r\nThis issue was not caught by any of the rubyspec code for\r\nKernel#Integer and Kernel#Float, but surfaced when testing\r\nKernel#format. Changing the regex to /(\\d)_(?=\\d)/g fixed the issue.","created_at":"2015-04-15T13:01:12Z","updated_at":"2015-04-15T13:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opal/opal/pulls/799/commits","review_comments_url":"https://api.github.com/repos/opal/opal/pulls/799/comments","review_comment_url":"https://api.github.com/repos/opal/opal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opal/opal/issues/799/comments","statuses_url":"https://api.github.com/repos/opal/opal/statuses/0c08ea8e24709ff9029bcd2f3403d6e7d77c37e7","head":{"label":"vais:fix-underscore-stripping-regex","ref":"fix-underscore-stripping-regex","sha":"0c08ea8e24709ff9029bcd2f3403d6e7d77c37e7","user":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"repo":{"id":30140782,"name":"opal","full_name":"vais/opal","owner":{"login":"vais","id":77592,"avatar_url":"https://avatars.githubusercontent.com/u/77592?v=3","gravatar_id":"","url":"https://api.github.com/users/vais","html_url":"https://github.com/vais","followers_url":"https://api.github.com/users/vais/followers","following_url":"https://api.github.com/users/vais/following{/other_user}","gists_url":"https://api.github.com/users/vais/gists{/gist_id}","starred_url":"https://api.github.com/users/vais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vais/subscriptions","organizations_url":"https://api.github.com/users/vais/orgs","repos_url":"https://api.github.com/users/vais/repos","events_url":"https://api.github.com/users/vais/events{/privacy}","received_events_url":"https://api.github.com/users/vais/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vais/opal","description":"Ruby to Javascript compiler","fork":true,"url":"https://api.github.com/repos/vais/opal","forks_url":"https://api.github.com/repos/vais/opal/forks","keys_url":"https://api.github.com/repos/vais/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vais/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vais/opal/teams","hooks_url":"https://api.github.com/repos/vais/opal/hooks","issue_events_url":"https://api.github.com/repos/vais/opal/issues/events{/number}","events_url":"https://api.github.com/repos/vais/opal/events","assignees_url":"https://api.github.com/repos/vais/opal/assignees{/user}","branches_url":"https://api.github.com/repos/vais/opal/branches{/branch}","tags_url":"https://api.github.com/repos/vais/opal/tags","blobs_url":"https://api.github.com/repos/vais/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vais/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vais/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/vais/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vais/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/vais/opal/languages","stargazers_url":"https://api.github.com/repos/vais/opal/stargazers","contributors_url":"https://api.github.com/repos/vais/opal/contributors","subscribers_url":"https://api.github.com/repos/vais/opal/subscribers","subscription_url":"https://api.github.com/repos/vais/opal/subscription","commits_url":"https://api.github.com/repos/vais/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/vais/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/vais/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/vais/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/vais/opal/contents/{+path}","compare_url":"https://api.github.com/repos/vais/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vais/opal/merges","archive_url":"https://api.github.com/repos/vais/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vais/opal/downloads","issues_url":"https://api.github.com/repos/vais/opal/issues{/number}","pulls_url":"https://api.github.com/repos/vais/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/vais/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/vais/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vais/opal/labels{/name}","releases_url":"https://api.github.com/repos/vais/opal/releases{/id}","created_at":"2015-02-01T08:29:46Z","updated_at":"2015-04-15T12:00:33Z","pushed_at":"2015-04-15T12:58:39Z","git_url":"git://github.com/vais/opal.git","ssh_url":"git@github.com:vais/opal.git","clone_url":"https://github.com/vais/opal.git","svn_url":"https://github.com/vais/opal","homepage":"http://opalrb.org","size":9392,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opal:master","ref":"master","sha":"888604cb38a1fcbbced414c5bb879b5b83081c4a","user":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"repo":{"id":184366,"name":"opal","full_name":"opal/opal","owner":{"login":"opal","id":842643,"avatar_url":"https://avatars.githubusercontent.com/u/842643?v=3","gravatar_id":"","url":"https://api.github.com/users/opal","html_url":"https://github.com/opal","followers_url":"https://api.github.com/users/opal/followers","following_url":"https://api.github.com/users/opal/following{/other_user}","gists_url":"https://api.github.com/users/opal/gists{/gist_id}","starred_url":"https://api.github.com/users/opal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opal/subscriptions","organizations_url":"https://api.github.com/users/opal/orgs","repos_url":"https://api.github.com/users/opal/repos","events_url":"https://api.github.com/users/opal/events{/privacy}","received_events_url":"https://api.github.com/users/opal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opal/opal","description":"Ruby to Javascript compiler","fork":false,"url":"https://api.github.com/repos/opal/opal","forks_url":"https://api.github.com/repos/opal/opal/forks","keys_url":"https://api.github.com/repos/opal/opal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opal/opal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opal/opal/teams","hooks_url":"https://api.github.com/repos/opal/opal/hooks","issue_events_url":"https://api.github.com/repos/opal/opal/issues/events{/number}","events_url":"https://api.github.com/repos/opal/opal/events","assignees_url":"https://api.github.com/repos/opal/opal/assignees{/user}","branches_url":"https://api.github.com/repos/opal/opal/branches{/branch}","tags_url":"https://api.github.com/repos/opal/opal/tags","blobs_url":"https://api.github.com/repos/opal/opal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opal/opal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opal/opal/git/refs{/sha}","trees_url":"https://api.github.com/repos/opal/opal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opal/opal/statuses/{sha}","languages_url":"https://api.github.com/repos/opal/opal/languages","stargazers_url":"https://api.github.com/repos/opal/opal/stargazers","contributors_url":"https://api.github.com/repos/opal/opal/contributors","subscribers_url":"https://api.github.com/repos/opal/opal/subscribers","subscription_url":"https://api.github.com/repos/opal/opal/subscription","commits_url":"https://api.github.com/repos/opal/opal/commits{/sha}","git_commits_url":"https://api.github.com/repos/opal/opal/git/commits{/sha}","comments_url":"https://api.github.com/repos/opal/opal/comments{/number}","issue_comment_url":"https://api.github.com/repos/opal/opal/issues/comments{/number}","contents_url":"https://api.github.com/repos/opal/opal/contents/{+path}","compare_url":"https://api.github.com/repos/opal/opal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opal/opal/merges","archive_url":"https://api.github.com/repos/opal/opal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opal/opal/downloads","issues_url":"https://api.github.com/repos/opal/opal/issues{/number}","pulls_url":"https://api.github.com/repos/opal/opal/pulls{/number}","milestones_url":"https://api.github.com/repos/opal/opal/milestones{/number}","notifications_url":"https://api.github.com/repos/opal/opal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opal/opal/labels{/name}","releases_url":"https://api.github.com/repos/opal/opal/releases{/id}","created_at":"2009-04-24T08:53:34Z","updated_at":"2015-04-15T11:58:45Z","pushed_at":"2015-04-15T11:58:43Z","git_url":"git://github.com/opal/opal.git","ssh_url":"git@github.com:opal/opal.git","clone_url":"https://github.com/opal/opal.git","svn_url":"https://github.com/opal/opal","homepage":"http://opalrb.org","size":19430,"stargazers_count":2446,"watchers_count":2446,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":146,"mirror_url":null,"open_issues_count":115,"forks":146,"open_issues":115,"watchers":2446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opal/opal/pulls/799"},"html":{"href":"https://github.com/opal/opal/pull/799"},"issue":{"href":"https://api.github.com/repos/opal/opal/issues/799"},"comments":{"href":"https://api.github.com/repos/opal/opal/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/opal/opal/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/opal/opal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opal/opal/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/opal/opal/statuses/0c08ea8e24709ff9029bcd2f3403d6e7d77c37e7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}