{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/dom/issues/114","labels_url":"https://api.github.com/repos/whatwg/dom/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/dom/issues/114/comments","events_url":"https://api.github.com/repos/whatwg/dom/issues/114/events","html_url":"https://github.com/whatwg/dom/pull/114","id":118169889,"number":114,"title":"Change DOMTokenList's add() return value.","user":{"login":"yoavweiss","id":786187,"avatar_url":"https://avatars.githubusercontent.com/u/786187?v=3","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-11-21T04:31:01Z","updated_at":"2015-11-22T21:25:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whatwg/dom/pulls/114","html_url":"https://github.com/whatwg/dom/pull/114","diff_url":"https://github.com/whatwg/dom/pull/114.diff","patch_url":"https://github.com/whatwg/dom/pull/114.patch"},"body":"As [suggested](https://github.com/whatwg/dom/issues/111#issuecomment-158411312) by @bzbarsky:\r\n\r\nChange the return value of add() to have three states: \"supported\", \"not\r\nsupported\" and \"no supported tokens\".\r\n\r\nThe \"validation steps\" algorithm return values also change accordingly.\r\n\r\n/cc @foolip @zcorpan @annevk "},"comment":{"url":"https://api.github.com/repos/whatwg/dom/issues/comments/158800830","html_url":"https://github.com/whatwg/dom/pull/114#issuecomment-158800830","issue_url":"https://api.github.com/repos/whatwg/dom/issues/114","id":158800830,"user":{"login":"zcorpan","id":244772,"avatar_url":"https://avatars.githubusercontent.com/u/244772?v=3","gravatar_id":"","url":"https://api.github.com/users/zcorpan","html_url":"https://github.com/zcorpan","followers_url":"https://api.github.com/users/zcorpan/followers","following_url":"https://api.github.com/users/zcorpan/following{/other_user}","gists_url":"https://api.github.com/users/zcorpan/gists{/gist_id}","starred_url":"https://api.github.com/users/zcorpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcorpan/subscriptions","organizations_url":"https://api.github.com/users/zcorpan/orgs","repos_url":"https://api.github.com/users/zcorpan/repos","events_url":"https://api.github.com/users/zcorpan/events{/privacy}","received_events_url":"https://api.github.com/users/zcorpan/received_events","type":"User","site_admin":false},"created_at":"2015-11-22T21:25:07Z","updated_at":"2015-11-22T21:25:07Z","body":"OK I see what you are saying. I suppose we could make the classList case also be falsy, e.g. continue to return `undefined`. But I also don't expect people to check the return value for classList, and I don't expect classList to get a list of supported keywords. But certainly it is difficult to predict the future.\r\n\r\nI would be fine with changing back classList to return `undefined`, and either keep the other values as boolean, or use \"\" and \"supported\"."}}