{"action":"created","issue":{"url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/53","labels_url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/53/comments","events_url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/53/events","html_url":"https://github.com/HubSpot/dropwizard-guice/issues/53","id":67111862,"number":53,"title":"Extending InjectableHealthCheck with abstract class","user":{"login":"scho","id":57036,"avatar_url":"https://avatars.githubusercontent.com/u/57036?v=3","gravatar_id":"","url":"https://api.github.com/users/scho","html_url":"https://github.com/scho","followers_url":"https://api.github.com/users/scho/followers","following_url":"https://api.github.com/users/scho/following{/other_user}","gists_url":"https://api.github.com/users/scho/gists{/gist_id}","starred_url":"https://api.github.com/users/scho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scho/subscriptions","organizations_url":"https://api.github.com/users/scho/orgs","repos_url":"https://api.github.com/users/scho/repos","events_url":"https://api.github.com/users/scho/events{/privacy}","received_events_url":"https://api.github.com/users/scho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-08T11:52:26Z","updated_at":"2015-06-23T14:54:59Z","closed_at":null,"body":"I have several healthchecks that do almost the same thing (testing if another host is reachable). They all extend `InjectableHealthCheck`.\r\nI'd like to extract common functionality into an abstract superclass that extends `InjectableHealthCheck`. dropwizard-guice' `AutoConfig` doesn't check whether a sub type of `InjectableHealthCheck` is abtract or not. So guice tries to instantiate my abstract class, which obviously fails.\r\n\r\nSo basically dropwizard-guice needs to check whether the sub type can be instantiated or not.\r\n\r\nI guess it would a good idea to check this somewhere [here](https://github.com/HubSpot/dropwizard-guice/blob/master/src/main/java/com/hubspot/dropwizard/guice/AutoConfig.java#L82).\r\n\r\nIf you agree with fixing this problem the way I suggested, I'll do it and send a PR."},"comment":{"url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/comments/114533604","html_url":"https://github.com/HubSpot/dropwizard-guice/issues/53#issuecomment-114533604","issue_url":"https://api.github.com/repos/HubSpot/dropwizard-guice/issues/53","id":114533604,"user":{"login":"jhaber","id":611459,"avatar_url":"https://avatars.githubusercontent.com/u/611459?v=3","gravatar_id":"","url":"https://api.github.com/users/jhaber","html_url":"https://github.com/jhaber","followers_url":"https://api.github.com/users/jhaber/followers","following_url":"https://api.github.com/users/jhaber/following{/other_user}","gists_url":"https://api.github.com/users/jhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/jhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhaber/subscriptions","organizations_url":"https://api.github.com/users/jhaber/orgs","repos_url":"https://api.github.com/users/jhaber/repos","events_url":"https://api.github.com/users/jhaber/events{/privacy}","received_events_url":"https://api.github.com/users/jhaber/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T14:54:59Z","updated_at":"2015-06-23T14:54:59Z","body":"Are you taking into account that `AutoConfig` is limited to a certain set of packages? You can have an abstract health check in an autoconfig'ed package and the implementation in a different package"}}