{"action":"created","issue":{"url":"https://api.github.com/repos/Izzimach/react-three/issues/10","labels_url":"https://api.github.com/repos/Izzimach/react-three/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Izzimach/react-three/issues/10/comments","events_url":"https://api.github.com/repos/Izzimach/react-three/issues/10/events","html_url":"https://github.com/Izzimach/react-three/pull/10","id":54846411,"number":10,"title":"[ReactTHREE] Antialias the WebGL Renderer by default","user":{"login":"pcottle","id":1135007,"avatar_url":"https://avatars.githubusercontent.com/u/1135007?v=3","gravatar_id":"","url":"https://api.github.com/users/pcottle","html_url":"https://github.com/pcottle","followers_url":"https://api.github.com/users/pcottle/followers","following_url":"https://api.github.com/users/pcottle/following{/other_user}","gists_url":"https://api.github.com/users/pcottle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcottle/subscriptions","organizations_url":"https://api.github.com/users/pcottle/orgs","repos_url":"https://api.github.com/users/pcottle/repos","events_url":"https://api.github.com/users/pcottle/events{/privacy}","received_events_url":"https://api.github.com/users/pcottle/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-20T05:49:03Z","updated_at":"2015-01-21T02:09:46Z","closed_at":"2015-01-20T18:02:26Z","pull_request":{"url":"https://api.github.com/repos/Izzimach/react-three/pulls/10","html_url":"https://github.com/Izzimach/react-three/pull/10","diff_url":"https://github.com/Izzimach/react-three/pull/10.diff","patch_url":"https://github.com/Izzimach/react-three/pull/10.patch"},"body":"Three.JS supports antialiasing as a parameter passed into its Renderer, but it's false by default.\r\n\r\nA lot of modern hardware supports antialiasing now and it makes the WebGL views look a lot better. Compare before and after:\r\n\r\nbefore:\r\n![screen shot 2015-01-19 at 8 55 26 pm](https://cloud.githubusercontent.com/assets/1135007/5812686/85d66b92-a024-11e4-8ecf-d1d6544d28de.png)\r\n\r\nafter:\r\n![screen shot 2015-01-19 at 8 54 59 pm](https://cloud.githubusercontent.com/assets/1135007/5812683/818cc8ec-a024-11e4-9ce3-dc657c0d3058.png)\r\n\r\nI decided to enable this for all ThreeSCENE's by default (unless you pass in `false` in the props) but could just match the existing behavior and only check for the prop.\r\n\r\nMore info here:\r\nhttp://benchung.com/antialiasing-three-js/\r\n\r\nOpen to ideas about testing -- unfortunately the param gets passed into the `WebGLRenderer` and is then gobbled up by a private variable, so it's not like we can read it back out after init :-/"},"comment":{"url":"https://api.github.com/repos/Izzimach/react-three/issues/comments/70772747","html_url":"https://github.com/Izzimach/react-three/pull/10#issuecomment-70772747","issue_url":"https://api.github.com/repos/Izzimach/react-three/issues/10","id":70772747,"user":{"login":"pcottle","id":1135007,"avatar_url":"https://avatars.githubusercontent.com/u/1135007?v=3","gravatar_id":"","url":"https://api.github.com/users/pcottle","html_url":"https://github.com/pcottle","followers_url":"https://api.github.com/users/pcottle/followers","following_url":"https://api.github.com/users/pcottle/following{/other_user}","gists_url":"https://api.github.com/users/pcottle/gists{/gist_id}","starred_url":"https://api.github.com/users/pcottle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcottle/subscriptions","organizations_url":"https://api.github.com/users/pcottle/orgs","repos_url":"https://api.github.com/users/pcottle/repos","events_url":"https://api.github.com/users/pcottle/events{/privacy}","received_events_url":"https://api.github.com/users/pcottle/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T02:09:46Z","updated_at":"2015-01-21T02:09:46Z","body":"Thanks a bunch @Izzimach! Yeah the PhantomJS testing all passed since it seems to be using the canvas renderer. Props for at least having those tests though -- been trying to get around to it on Learn Git Branching but always procrastinated.\r\n\r\nAnyways love the project -- keep on trucking"}}