{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5","id":48779707,"html_url":"https://github.com/puppetlabs-operations/garethr-diamond/pull/5","diff_url":"https://github.com/puppetlabs-operations/garethr-diamond/pull/5.diff","patch_url":"https://github.com/puppetlabs-operations/garethr-diamond/pull/5.patch","issue_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/5","number":5,"state":"closed","locked":false,"title":"Include needed variables in diamond::config","user":{"login":"danieldreier","id":5070204,"avatar_url":"https://avatars.githubusercontent.com/u/5070204?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldreier","html_url":"https://github.com/danieldreier","followers_url":"https://api.github.com/users/danieldreier/followers","following_url":"https://api.github.com/users/danieldreier/following{/other_user}","gists_url":"https://api.github.com/users/danieldreier/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldreier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldreier/subscriptions","organizations_url":"https://api.github.com/users/danieldreier/orgs","repos_url":"https://api.github.com/users/danieldreier/repos","events_url":"https://api.github.com/users/danieldreier/events{/privacy}","received_events_url":"https://api.github.com/users/danieldreier/received_events","type":"User","site_admin":false},"body":"Explicitly pull graphite_protocol, stats_host, stats_port variables\r\ninto diamond::config so that the erb template will have them in scope.\r\n\r\nThis is required for the template to have access to those variables in\r\npuppet 4. Puppet 3 appears to find them anyway, so it hasn't been a\r\nproblem before.","created_at":"2015-10-26T18:39:07Z","updated_at":"2015-10-26T18:39:13Z","closed_at":"2015-10-26T18:39:13Z","merged_at":"2015-10-26T18:39:13Z","merge_commit_sha":"cf2b5629f7bd94e8753562238bc2ad13850921ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5/commits","review_comments_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5/comments","review_comment_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/5/comments","statuses_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/statuses/5459c9371f22e18992e4a5bb9b31bbe1838f3032","head":{"label":"danieldreier:fix_puppet4","ref":"fix_puppet4","sha":"5459c9371f22e18992e4a5bb9b31bbe1838f3032","user":{"login":"danieldreier","id":5070204,"avatar_url":"https://avatars.githubusercontent.com/u/5070204?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldreier","html_url":"https://github.com/danieldreier","followers_url":"https://api.github.com/users/danieldreier/followers","following_url":"https://api.github.com/users/danieldreier/following{/other_user}","gists_url":"https://api.github.com/users/danieldreier/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldreier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldreier/subscriptions","organizations_url":"https://api.github.com/users/danieldreier/orgs","repos_url":"https://api.github.com/users/danieldreier/repos","events_url":"https://api.github.com/users/danieldreier/events{/privacy}","received_events_url":"https://api.github.com/users/danieldreier/received_events","type":"User","site_admin":false},"repo":{"id":44580136,"name":"garethr-diamond","full_name":"danieldreier/garethr-diamond","owner":{"login":"danieldreier","id":5070204,"avatar_url":"https://avatars.githubusercontent.com/u/5070204?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldreier","html_url":"https://github.com/danieldreier","followers_url":"https://api.github.com/users/danieldreier/followers","following_url":"https://api.github.com/users/danieldreier/following{/other_user}","gists_url":"https://api.github.com/users/danieldreier/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldreier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldreier/subscriptions","organizations_url":"https://api.github.com/users/danieldreier/orgs","repos_url":"https://api.github.com/users/danieldreier/repos","events_url":"https://api.github.com/users/danieldreier/events{/privacy}","received_events_url":"https://api.github.com/users/danieldreier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danieldreier/garethr-diamond","description":"Puppet module for the Diamond stats collection daemon","fork":true,"url":"https://api.github.com/repos/danieldreier/garethr-diamond","forks_url":"https://api.github.com/repos/danieldreier/garethr-diamond/forks","keys_url":"https://api.github.com/repos/danieldreier/garethr-diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danieldreier/garethr-diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danieldreier/garethr-diamond/teams","hooks_url":"https://api.github.com/repos/danieldreier/garethr-diamond/hooks","issue_events_url":"https://api.github.com/repos/danieldreier/garethr-diamond/issues/events{/number}","events_url":"https://api.github.com/repos/danieldreier/garethr-diamond/events","assignees_url":"https://api.github.com/repos/danieldreier/garethr-diamond/assignees{/user}","branches_url":"https://api.github.com/repos/danieldreier/garethr-diamond/branches{/branch}","tags_url":"https://api.github.com/repos/danieldreier/garethr-diamond/tags","blobs_url":"https://api.github.com/repos/danieldreier/garethr-diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danieldreier/garethr-diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danieldreier/garethr-diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/danieldreier/garethr-diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danieldreier/garethr-diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/danieldreier/garethr-diamond/languages","stargazers_url":"https://api.github.com/repos/danieldreier/garethr-diamond/stargazers","contributors_url":"https://api.github.com/repos/danieldreier/garethr-diamond/contributors","subscribers_url":"https://api.github.com/repos/danieldreier/garethr-diamond/subscribers","subscription_url":"https://api.github.com/repos/danieldreier/garethr-diamond/subscription","commits_url":"https://api.github.com/repos/danieldreier/garethr-diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/danieldreier/garethr-diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/danieldreier/garethr-diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/danieldreier/garethr-diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/danieldreier/garethr-diamond/contents/{+path}","compare_url":"https://api.github.com/repos/danieldreier/garethr-diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danieldreier/garethr-diamond/merges","archive_url":"https://api.github.com/repos/danieldreier/garethr-diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danieldreier/garethr-diamond/downloads","issues_url":"https://api.github.com/repos/danieldreier/garethr-diamond/issues{/number}","pulls_url":"https://api.github.com/repos/danieldreier/garethr-diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/danieldreier/garethr-diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/danieldreier/garethr-diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danieldreier/garethr-diamond/labels{/name}","releases_url":"https://api.github.com/repos/danieldreier/garethr-diamond/releases{/id}","created_at":"2015-10-20T03:35:31Z","updated_at":"2015-10-20T03:35:33Z","pushed_at":"2015-10-26T18:23:02Z","git_url":"git://github.com/danieldreier/garethr-diamond.git","ssh_url":"git@github.com:danieldreier/garethr-diamond.git","clone_url":"https://github.com/danieldreier/garethr-diamond.git","svn_url":"https://github.com/danieldreier/garethr-diamond","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs-operations:plops_fork_master","ref":"plops_fork_master","sha":"ab750cb4bb10668a6ef19f993096c8c9cd2444de","user":{"login":"puppetlabs-operations","id":2043293,"avatar_url":"https://avatars.githubusercontent.com/u/2043293?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs-operations","html_url":"https://github.com/puppetlabs-operations","followers_url":"https://api.github.com/users/puppetlabs-operations/followers","following_url":"https://api.github.com/users/puppetlabs-operations/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs-operations/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs-operations/orgs","repos_url":"https://api.github.com/users/puppetlabs-operations/repos","events_url":"https://api.github.com/users/puppetlabs-operations/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs-operations/received_events","type":"Organization","site_admin":false},"repo":{"id":17687063,"name":"garethr-diamond","full_name":"puppetlabs-operations/garethr-diamond","owner":{"login":"puppetlabs-operations","id":2043293,"avatar_url":"https://avatars.githubusercontent.com/u/2043293?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs-operations","html_url":"https://github.com/puppetlabs-operations","followers_url":"https://api.github.com/users/puppetlabs-operations/followers","following_url":"https://api.github.com/users/puppetlabs-operations/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs-operations/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs-operations/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs-operations/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs-operations/orgs","repos_url":"https://api.github.com/users/puppetlabs-operations/repos","events_url":"https://api.github.com/users/puppetlabs-operations/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs-operations/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs-operations/garethr-diamond","description":"Puppet module for the Diamond stats collection daemon","fork":true,"url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond","forks_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/forks","keys_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/teams","hooks_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/events","assignees_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/tags","blobs_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/languages","stargazers_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/subscription","commits_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/merges","archive_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/downloads","issues_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/releases{/id}","created_at":"2014-03-12T22:55:31Z","updated_at":"2014-11-06T17:23:07Z","pushed_at":"2015-10-26T18:39:13Z","git_url":"git://github.com/puppetlabs-operations/garethr-diamond.git","ssh_url":"git@github.com:puppetlabs-operations/garethr-diamond.git","clone_url":"https://github.com/puppetlabs-operations/garethr-diamond.git","svn_url":"https://github.com/puppetlabs-operations/garethr-diamond","homepage":null,"size":389,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5"},"html":{"href":"https://github.com/puppetlabs-operations/garethr-diamond/pull/5"},"issue":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/5"},"comments":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs-operations/garethr-diamond/statuses/5459c9371f22e18992e4a5bb9b31bbe1838f3032"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danieldreier","id":5070204,"avatar_url":"https://avatars.githubusercontent.com/u/5070204?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldreier","html_url":"https://github.com/danieldreier","followers_url":"https://api.github.com/users/danieldreier/followers","following_url":"https://api.github.com/users/danieldreier/following{/other_user}","gists_url":"https://api.github.com/users/danieldreier/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldreier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldreier/subscriptions","organizations_url":"https://api.github.com/users/danieldreier/orgs","repos_url":"https://api.github.com/users/danieldreier/repos","events_url":"https://api.github.com/users/danieldreier/events{/privacy}","received_events_url":"https://api.github.com/users/danieldreier/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":17,"changed_files":1}}