{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/5875","labels_url":"https://api.github.com/repos/openshift/origin/issues/5875/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/5875/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/5875/events","html_url":"https://github.com/openshift/origin/pull/5875","id":116568160,"number":5875,"title":"Improve deployment scaling behavior","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":47,"created_at":"2015-11-12T15:07:36Z","updated_at":"2015-11-20T19:55:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/5875","html_url":"https://github.com/openshift/origin/pull/5875","diff_url":"https://github.com/openshift/origin/pull/5875.diff","patch_url":"https://github.com/openshift/origin/pull/5875.patch"},"body":"This change makes the DeploymentConfigController solely responsible for scaling RCs owned by a deployment config which aren't currently being manipulated by a deployer process. RCs owned by the deployment config will be reconciled so that the active deployment matches the config replica count and all other RCs are scaled to 0.\r\n\r\nRationale:\r\n\r\n* Prevents races with HPA, users performing manual scaling, the deployer process, and the deployer pod controller (which was also performing scaling operations.)\r\n* Aligns replica count handling with upstream deployments; today, the replica count for deployments follows the last successful deployment and requires users to scale RCs in order to adjust subsequent deployment replica counts. Now, changes to the config replica count will drive new deployments, and scale existing deployments.\r\n* Allows all scaling operations to target the deploymentConfig only rather than RCs.\r\n\r\nThis also adds a variety of new events to provide insight into what the controller is doing.\r\n\r\nFixes #5597\r\n\r\n### TODO\r\n- [x] deployerPodController unit tests\r\n- [x] update DC scaling subresource to scale the DC directly\r\n- [x] update deployment registry to remove restriction on scaling during an in-progress deployment\r\n- [x] e2e or extended tests to exercise scaling interactions\r\n- [x] discussion of https://github.com/openshift/origin/pull/5875#issuecomment-156197377\r\n- [x] implement compatibility logic for old clients which will still scale RCs directly\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/158508705","html_url":"https://github.com/openshift/origin/pull/5875#issuecomment-158508705","issue_url":"https://api.github.com/repos/openshift/origin/issues/5875","id":158508705,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T19:55:25Z","updated_at":"2015-11-20T19:55:25Z","body":"Evaluated for origin test up to 9ccc92df4e48f444e8f33c1e34b97a1579c04b2e"}}