{"action":"created","comment":{"url":"https://api.github.com/repos/opf/openproject/pulls/comments/37190019","id":37190019,"diff_hunk":"@@ -0,0 +1,86 @@\n+#-- copyright\n+# OpenProject is a project management system.\n+# Copyright (C) 2012-2015 the OpenProject Foundation (OPF)\n+#\n+# This program is free software; you can redistribute it and/or\n+# modify it under the terms of the GNU General Public License version 3.\n+#\n+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:\n+# Copyright (C) 2006-2013 Jean-Philippe Lang\n+# Copyright (C) 2010-2013 the ChiliProject Team\n+#\n+# This program is free software; you can redistribute it and/or\n+# modify it under the terms of the GNU General Public License\n+# as published by the Free Software Foundation; either version 2\n+# of the License, or (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with this program; if not, write to the Free Software\n+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+#\n+# See doc/COPYRIGHT.rdoc for more details.\n+#++\n+\n+#-- encoding: UTF-8\n+module JournalChanges\n+  def get_changes\n+    return @changes if @changes\n+    return {} if data.nil?\n+\n+    @changes = HashWithIndifferentAccess.new\n+\n+    if predecessor.nil?\n+      @changes = data.journaled_attributes\n+                 .reject { |_, new_value| new_value.nil? }\n+                 .inject({}) { |result, (attribute, new_value)|\n+                   result[attribute] = [nil, new_value]\n+                   result\n+                 }\n+    else\n+      normalized_new_data = JournalManager.normalize_newlines(data.journaled_attributes)\n+      normalized_old_data = JournalManager.normalize_newlines(predecessor.data.journaled_attributes)\n+\n+      normalized_new_data.select { |attribute, new_value|\n+        # we dont record changes for changes from nil to empty strings and vice versa\n+        old_value = normalized_old_data[attribute]\n+        new_value != old_value && (new_value.present? || old_value.present?)\n+      }.each do |attribute, new_value|\n+        @changes[attribute] = [normalized_old_data[attribute], new_value]\n+      end\n+    end\n+\n+    @changes.merge!(get_association_changes predecessor, 'attachable', 'attachments', :attachment_id, :filename)\n+    @changes.merge!(get_association_changes predecessor, 'customizable', 'custom_fields', :custom_field_id, :value)","path":"lib/plugins/acts_as_journalized/lib/journal_changes.rb","position":58,"original_position":58,"commit_id":"8a389cd8c1c70bcb4a5858cbd6a8ae2d4ad2db88","original_commit_id":"8a389cd8c1c70bcb4a5858cbd6a8ae2d4ad2db88","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [115/100]","created_at":"2015-08-17T14:03:11Z","updated_at":"2015-08-17T14:03:11Z","html_url":"https://github.com/opf/openproject/pull/3327#discussion_r37190019","pull_request_url":"https://api.github.com/repos/opf/openproject/pulls/3327","_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments/37190019"},"html":{"href":"https://github.com/opf/openproject/pull/3327#discussion_r37190019"},"pull_request":{"href":"https://api.github.com/repos/opf/openproject/pulls/3327"}}},"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/3327","id":41958357,"html_url":"https://github.com/opf/openproject/pull/3327","diff_url":"https://github.com/opf/openproject/pull/3327.diff","patch_url":"https://github.com/opf/openproject/pull/3327.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/3327","number":3327,"state":"open","locked":false,"title":"[20040] Merge branch 'dev' into feature/rails4","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"body":"https://community.openproject.org/work_packages/20040\r\n\r\nThis brings in latest changes from `dev` into #2104 - since this was a non-trivial merge, I'm issuing this as a PR.","created_at":"2015-08-08T18:33:20Z","updated_at":"2015-08-17T14:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a853a92fb38c07335aae5fa17732e219a6b6c554","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/3327/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/3327/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/3327/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/8a389cd8c1c70bcb4a5858cbd6a8ae2d4ad2db88","head":{"label":"myabc:feature/merge-dev-into-rails4","ref":"feature/merge-dev-into-rails4","sha":"8a389cd8c1c70bcb4a5858cbd6a8ae2d4ad2db88","user":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"repo":{"id":31470518,"name":"openproject","full_name":"myabc/openproject","owner":{"login":"myabc","id":755,"avatar_url":"https://avatars.githubusercontent.com/u/755?v=3","gravatar_id":"","url":"https://api.github.com/users/myabc","html_url":"https://github.com/myabc","followers_url":"https://api.github.com/users/myabc/followers","following_url":"https://api.github.com/users/myabc/following{/other_user}","gists_url":"https://api.github.com/users/myabc/gists{/gist_id}","starred_url":"https://api.github.com/users/myabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myabc/subscriptions","organizations_url":"https://api.github.com/users/myabc/orgs","repos_url":"https://api.github.com/users/myabc/repos","events_url":"https://api.github.com/users/myabc/events{/privacy}","received_events_url":"https://api.github.com/users/myabc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/myabc/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/myabc/openproject","forks_url":"https://api.github.com/repos/myabc/openproject/forks","keys_url":"https://api.github.com/repos/myabc/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myabc/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myabc/openproject/teams","hooks_url":"https://api.github.com/repos/myabc/openproject/hooks","issue_events_url":"https://api.github.com/repos/myabc/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/myabc/openproject/events","assignees_url":"https://api.github.com/repos/myabc/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/myabc/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/myabc/openproject/tags","blobs_url":"https://api.github.com/repos/myabc/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myabc/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myabc/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/myabc/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myabc/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/myabc/openproject/languages","stargazers_url":"https://api.github.com/repos/myabc/openproject/stargazers","contributors_url":"https://api.github.com/repos/myabc/openproject/contributors","subscribers_url":"https://api.github.com/repos/myabc/openproject/subscribers","subscription_url":"https://api.github.com/repos/myabc/openproject/subscription","commits_url":"https://api.github.com/repos/myabc/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/myabc/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/myabc/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/myabc/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/myabc/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/myabc/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myabc/openproject/merges","archive_url":"https://api.github.com/repos/myabc/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myabc/openproject/downloads","issues_url":"https://api.github.com/repos/myabc/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/myabc/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/myabc/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/myabc/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myabc/openproject/labels{/name}","releases_url":"https://api.github.com/repos/myabc/openproject/releases{/id}","created_at":"2015-02-28T17:43:54Z","updated_at":"2015-03-21T23:11:24Z","pushed_at":"2015-08-17T14:00:22Z","git_url":"git://github.com/myabc/openproject.git","ssh_url":"git@github.com:myabc/openproject.git","clone_url":"https://github.com/myabc/openproject.git","svn_url":"https://github.com/myabc/openproject","homepage":"https://www.openproject.org","size":69203,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:feature/rails4","ref":"feature/rails4","sha":"6520f7ed5ca9f1cded63ff6a81d65e9e7e098727","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-08-15T07:20:57Z","pushed_at":"2015-08-17T14:00:23Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":206880,"stargazers_count":700,"watchers_count":700,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":32,"forks":292,"open_issues":32,"watchers":700,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/3327"},"html":{"href":"https://github.com/opf/openproject/pull/3327"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/3327"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/3327/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/3327/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/3327/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/8a389cd8c1c70bcb4a5858cbd6a8ae2d4ad2db88"}}}}