{"action":"opened","number":30,"pull_request":{"url":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30","id":43889287,"html_url":"https://github.com/glassechidna/zxing-cpp/pull/30","diff_url":"https://github.com/glassechidna/zxing-cpp/pull/30.diff","patch_url":"https://github.com/glassechidna/zxing-cpp/pull/30.patch","issue_url":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/30","number":30,"state":"open","locked":false,"title":"Implement GreyscaleLuminanceSource::crop()","user":{"login":"chakrit","id":45545,"avatar_url":"https://avatars.githubusercontent.com/u/45545?v=3","gravatar_id":"","url":"https://api.github.com/users/chakrit","html_url":"https://github.com/chakrit","followers_url":"https://api.github.com/users/chakrit/followers","following_url":"https://api.github.com/users/chakrit/following{/other_user}","gists_url":"https://api.github.com/users/chakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrit/subscriptions","organizations_url":"https://api.github.com/users/chakrit/orgs","repos_url":"https://api.github.com/users/chakrit/repos","events_url":"https://api.github.com/users/chakrit/events{/privacy}","received_events_url":"https://api.github.com/users/chakrit/received_events","type":"User","site_admin":false},"body":"I tested this lib with a large image using `GenericMultipleBarcodeReader` and it throws `IllegalArgumentException(\"This luminance source does not support cropping.\")`.\r\n\r\nI read the code and it seems the class already does what looks like cropping in its constructor so I just use it to implement `crop()` and now the code works correctly, thus the PR.\r\n\r\nLet me know if this isn't the right fix.","created_at":"2015-09-01T15:24:59Z","updated_at":"2015-09-01T15:24:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30/commits","review_comments_url":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30/comments","review_comment_url":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/30/comments","statuses_url":"https://api.github.com/repos/glassechidna/zxing-cpp/statuses/37d829332147d7796b3f8503b633e2073e239b64","head":{"label":"chakrit:master","ref":"master","sha":"37d829332147d7796b3f8503b633e2073e239b64","user":{"login":"chakrit","id":45545,"avatar_url":"https://avatars.githubusercontent.com/u/45545?v=3","gravatar_id":"","url":"https://api.github.com/users/chakrit","html_url":"https://github.com/chakrit","followers_url":"https://api.github.com/users/chakrit/followers","following_url":"https://api.github.com/users/chakrit/following{/other_user}","gists_url":"https://api.github.com/users/chakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrit/subscriptions","organizations_url":"https://api.github.com/users/chakrit/orgs","repos_url":"https://api.github.com/users/chakrit/repos","events_url":"https://api.github.com/users/chakrit/events{/privacy}","received_events_url":"https://api.github.com/users/chakrit/received_events","type":"User","site_admin":false},"repo":{"id":41745529,"name":"zxing-cpp","full_name":"chakrit/zxing-cpp","owner":{"login":"chakrit","id":45545,"avatar_url":"https://avatars.githubusercontent.com/u/45545?v=3","gravatar_id":"","url":"https://api.github.com/users/chakrit","html_url":"https://github.com/chakrit","followers_url":"https://api.github.com/users/chakrit/followers","following_url":"https://api.github.com/users/chakrit/following{/other_user}","gists_url":"https://api.github.com/users/chakrit/gists{/gist_id}","starred_url":"https://api.github.com/users/chakrit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chakrit/subscriptions","organizations_url":"https://api.github.com/users/chakrit/orgs","repos_url":"https://api.github.com/users/chakrit/repos","events_url":"https://api.github.com/users/chakrit/events{/privacy}","received_events_url":"https://api.github.com/users/chakrit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chakrit/zxing-cpp","description":"ZXing C++ Library","fork":true,"url":"https://api.github.com/repos/chakrit/zxing-cpp","forks_url":"https://api.github.com/repos/chakrit/zxing-cpp/forks","keys_url":"https://api.github.com/repos/chakrit/zxing-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chakrit/zxing-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chakrit/zxing-cpp/teams","hooks_url":"https://api.github.com/repos/chakrit/zxing-cpp/hooks","issue_events_url":"https://api.github.com/repos/chakrit/zxing-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/chakrit/zxing-cpp/events","assignees_url":"https://api.github.com/repos/chakrit/zxing-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/chakrit/zxing-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/chakrit/zxing-cpp/tags","blobs_url":"https://api.github.com/repos/chakrit/zxing-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chakrit/zxing-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chakrit/zxing-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/chakrit/zxing-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chakrit/zxing-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/chakrit/zxing-cpp/languages","stargazers_url":"https://api.github.com/repos/chakrit/zxing-cpp/stargazers","contributors_url":"https://api.github.com/repos/chakrit/zxing-cpp/contributors","subscribers_url":"https://api.github.com/repos/chakrit/zxing-cpp/subscribers","subscription_url":"https://api.github.com/repos/chakrit/zxing-cpp/subscription","commits_url":"https://api.github.com/repos/chakrit/zxing-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/chakrit/zxing-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/chakrit/zxing-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/chakrit/zxing-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/chakrit/zxing-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/chakrit/zxing-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chakrit/zxing-cpp/merges","archive_url":"https://api.github.com/repos/chakrit/zxing-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chakrit/zxing-cpp/downloads","issues_url":"https://api.github.com/repos/chakrit/zxing-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/chakrit/zxing-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/chakrit/zxing-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/chakrit/zxing-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chakrit/zxing-cpp/labels{/name}","releases_url":"https://api.github.com/repos/chakrit/zxing-cpp/releases{/id}","created_at":"2015-09-01T15:05:06Z","updated_at":"2015-09-01T15:05:07Z","pushed_at":"2015-09-01T15:19:03Z","git_url":"git://github.com/chakrit/zxing-cpp.git","ssh_url":"git@github.com:chakrit/zxing-cpp.git","clone_url":"https://github.com/chakrit/zxing-cpp.git","svn_url":"https://github.com/chakrit/zxing-cpp","homepage":null,"size":699,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"glassechidna:master","ref":"master","sha":"4abdbb62c9939014eca3e43ac7dfa30daa344536","user":{"login":"glassechidna","id":9280406,"avatar_url":"https://avatars.githubusercontent.com/u/9280406?v=3","gravatar_id":"","url":"https://api.github.com/users/glassechidna","html_url":"https://github.com/glassechidna","followers_url":"https://api.github.com/users/glassechidna/followers","following_url":"https://api.github.com/users/glassechidna/following{/other_user}","gists_url":"https://api.github.com/users/glassechidna/gists{/gist_id}","starred_url":"https://api.github.com/users/glassechidna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassechidna/subscriptions","organizations_url":"https://api.github.com/users/glassechidna/orgs","repos_url":"https://api.github.com/users/glassechidna/repos","events_url":"https://api.github.com/users/glassechidna/events{/privacy}","received_events_url":"https://api.github.com/users/glassechidna/received_events","type":"Organization","site_admin":false},"repo":{"id":28079361,"name":"zxing-cpp","full_name":"glassechidna/zxing-cpp","owner":{"login":"glassechidna","id":9280406,"avatar_url":"https://avatars.githubusercontent.com/u/9280406?v=3","gravatar_id":"","url":"https://api.github.com/users/glassechidna","html_url":"https://github.com/glassechidna","followers_url":"https://api.github.com/users/glassechidna/followers","following_url":"https://api.github.com/users/glassechidna/following{/other_user}","gists_url":"https://api.github.com/users/glassechidna/gists{/gist_id}","starred_url":"https://api.github.com/users/glassechidna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassechidna/subscriptions","organizations_url":"https://api.github.com/users/glassechidna/orgs","repos_url":"https://api.github.com/users/glassechidna/repos","events_url":"https://api.github.com/users/glassechidna/events{/privacy}","received_events_url":"https://api.github.com/users/glassechidna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/glassechidna/zxing-cpp","description":"ZXing C++ Library","fork":false,"url":"https://api.github.com/repos/glassechidna/zxing-cpp","forks_url":"https://api.github.com/repos/glassechidna/zxing-cpp/forks","keys_url":"https://api.github.com/repos/glassechidna/zxing-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glassechidna/zxing-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glassechidna/zxing-cpp/teams","hooks_url":"https://api.github.com/repos/glassechidna/zxing-cpp/hooks","issue_events_url":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/glassechidna/zxing-cpp/events","assignees_url":"https://api.github.com/repos/glassechidna/zxing-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/glassechidna/zxing-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/glassechidna/zxing-cpp/tags","blobs_url":"https://api.github.com/repos/glassechidna/zxing-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glassechidna/zxing-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glassechidna/zxing-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/glassechidna/zxing-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glassechidna/zxing-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/glassechidna/zxing-cpp/languages","stargazers_url":"https://api.github.com/repos/glassechidna/zxing-cpp/stargazers","contributors_url":"https://api.github.com/repos/glassechidna/zxing-cpp/contributors","subscribers_url":"https://api.github.com/repos/glassechidna/zxing-cpp/subscribers","subscription_url":"https://api.github.com/repos/glassechidna/zxing-cpp/subscription","commits_url":"https://api.github.com/repos/glassechidna/zxing-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/glassechidna/zxing-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/glassechidna/zxing-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/glassechidna/zxing-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/glassechidna/zxing-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glassechidna/zxing-cpp/merges","archive_url":"https://api.github.com/repos/glassechidna/zxing-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glassechidna/zxing-cpp/downloads","issues_url":"https://api.github.com/repos/glassechidna/zxing-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/glassechidna/zxing-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/glassechidna/zxing-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glassechidna/zxing-cpp/labels{/name}","releases_url":"https://api.github.com/repos/glassechidna/zxing-cpp/releases{/id}","created_at":"2014-12-16T09:15:35Z","updated_at":"2015-08-31T02:47:33Z","pushed_at":"2015-08-30T17:48:24Z","git_url":"git://github.com/glassechidna/zxing-cpp.git","ssh_url":"git@github.com:glassechidna/zxing-cpp.git","clone_url":"https://github.com/glassechidna/zxing-cpp.git","svn_url":"https://github.com/glassechidna/zxing-cpp","homepage":null,"size":699,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":15,"forks":29,"open_issues":15,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30"},"html":{"href":"https://github.com/glassechidna/zxing-cpp/pull/30"},"issue":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/30"},"comments":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/glassechidna/zxing-cpp/statuses/37d829332147d7796b3f8503b633e2073e239b64"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":0,"changed_files":2}}