{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35950517","id":35950517,"diff_hunk":"@@ -510,9 +510,6 @@ var MessageManager = {\n         _isMessageBelongTo1to1Conversation(number, message);\n       if (isMessageInThread) {\n         threadId = message.threadId;\n-        // we need to set the current threadId,\n-        // because we start sms app in a new window\n-        Threads.registerMessage(message);","path":"apps/sms/services/js/message_manager.js","position":15,"original_position":15,"commit_id":"f15080a87fb987e55e8b32f4657b7aedd0cdcb79","original_commit_id":"1cfd5e3faa60fb3c052892319dba7cf51f17d3c2","user":{"login":"steveck-chung","id":1704452,"avatar_url":"https://avatars.githubusercontent.com/u/1704452?v=3","gravatar_id":"","url":"https://api.github.com/users/steveck-chung","html_url":"https://github.com/steveck-chung","followers_url":"https://api.github.com/users/steveck-chung/followers","following_url":"https://api.github.com/users/steveck-chung/following{/other_user}","gists_url":"https://api.github.com/users/steveck-chung/gists{/gist_id}","starred_url":"https://api.github.com/users/steveck-chung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveck-chung/subscriptions","organizations_url":"https://api.github.com/users/steveck-chung/orgs","repos_url":"https://api.github.com/users/steveck-chung/repos","events_url":"https://api.github.com/users/steveck-chung/events{/privacy}","received_events_url":"https://api.github.com/users/steveck-chung/received_events","type":"User","site_admin":false},"body":"Ok I think the original checking is not necessary since it's only for set the thread, and message here is not possible to be registered ahead.","created_at":"2015-07-31T06:59:42Z","updated_at":"2015-07-31T06:59:42Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/30630#discussion_r35950517","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/35950517"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30630#discussion_r35950517"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630","id":37928931,"html_url":"https://github.com/mozilla-b2g/gaia/pull/30630","diff_url":"https://github.com/mozilla-b2g/gaia/pull/30630.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/30630.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30630","number":30630,"state":"open","locked":false,"title":"Bug 1162030 - [Messages][NG] Figure out how navigation works","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-17T17:59:28Z","updated_at":"2015-07-31T06:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27812653825d887773905d07f10d506485bcd2ff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30630/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f15080a87fb987e55e8b32f4657b7aedd0cdcb79","head":{"label":"julienw:1162030-navigation-sms","ref":"1162030-navigation-sms","sha":"f15080a87fb987e55e8b32f4657b7aedd0cdcb79","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":6565987,"name":"gaia","full_name":"julienw/gaia","owner":{"login":"julienw","id":454175,"avatar_url":"https://avatars.githubusercontent.com/u/454175?v=3","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/julienw/gaia","forks_url":"https://api.github.com/repos/julienw/gaia/forks","keys_url":"https://api.github.com/repos/julienw/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/gaia/teams","hooks_url":"https://api.github.com/repos/julienw/gaia/hooks","issue_events_url":"https://api.github.com/repos/julienw/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/gaia/events","assignees_url":"https://api.github.com/repos/julienw/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/gaia/tags","blobs_url":"https://api.github.com/repos/julienw/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/gaia/languages","stargazers_url":"https://api.github.com/repos/julienw/gaia/stargazers","contributors_url":"https://api.github.com/repos/julienw/gaia/contributors","subscribers_url":"https://api.github.com/repos/julienw/gaia/subscribers","subscription_url":"https://api.github.com/repos/julienw/gaia/subscription","commits_url":"https://api.github.com/repos/julienw/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/gaia/merges","archive_url":"https://api.github.com/repos/julienw/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/gaia/downloads","issues_url":"https://api.github.com/repos/julienw/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/gaia/labels{/name}","releases_url":"https://api.github.com/repos/julienw/gaia/releases{/id}","created_at":"2012-11-06T17:18:15Z","updated_at":"2014-06-25T07:25:16Z","pushed_at":"2015-07-28T19:15:57Z","git_url":"git://github.com/julienw/gaia.git","ssh_url":"git@github.com:julienw/gaia.git","clone_url":"https://github.com/julienw/gaia.git","svn_url":"https://github.com/julienw/gaia","homepage":"https://wiki.mozilla.org/B2G","size":941468,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"3a14891fb02627fe9a39f11b8dfa6aeca9d9ee91","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-07-29T05:29:45Z","pushed_at":"2015-07-31T06:50:47Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1661246,"stargazers_count":1961,"watchers_count":1961,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2379,"mirror_url":null,"open_issues_count":1099,"forks":2379,"open_issues":1099,"watchers":1961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30630"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30630"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30630/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30630/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/f15080a87fb987e55e8b32f4657b7aedd0cdcb79"}}}}