{"action":"created","issue":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2215","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2215/labels{/name}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2215/comments","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2215/events","html_url":"https://github.com/jhipster/generator-jhipster/pull/2215","id":113209412,"number":2215,"title":"notification improvements","user":{"login":"deepu105","id":1107223,"avatar_url":"https://avatars.githubusercontent.com/u/1107223?v=3","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jhipster/generator-jhipster/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-25T06:07:30Z","updated_at":"2015-11-08T18:37:05Z","closed_at":"2015-10-27T09:32:41Z","pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2215","html_url":"https://github.com/jhipster/generator-jhipster/pull/2215","diff_url":"https://github.com/jhipster/generator-jhipster/pull/2215.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/2215.patch"},"body":"Following discussion in #1953,  #1951 and my discussion with Jdubois Im putting in this PR as an improvement over the existing notification system. \r\n\r\nThough the PR proposed by Matt #1951 is a great improvement and I personally like it better unfortunately it doesn't follow bootstrap style and hence doesn't go with our current bootstrap first setup, it will look out of place in many bootstrap themes. Hence I have added the toast feature to the current notification system as an optional feature since many people would like this as toasts rather than alerts including me.\r\nThis can be enabled by un commenting line ` //AlertServiceProvider.showAsToast(true);` in `app.js` this will make all alert/notification to look like toast (on width less than 480px it will be 100% width ).\r\n\r\nAlso while using AlertService.success/error/warning/info user can pass in additional position param like below, default is `top right`\r\n```\r\nAlertService.success(\"my message\", null, \"top left\");\r\n```\r\n\r\nthese position are css classes and top, bottom, left, right are predefined in bundled sass/css, user can easily add new and use that if required\r\n\r\n@mraible @gzsombor @atomfrede @gmarziou I would love to hear your opinion and if possible improvements on this, especially the toast look and feel when enabled, like adding drop shadow, transparency, better positioning etc. currently I have kept it at bare minimum styling\r\n\r\n@jdubois hope this will address your concerns over the notification system\r\n\r\nfix #1951 "},"comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments/154856157","html_url":"https://github.com/jhipster/generator-jhipster/pull/2215#issuecomment-154856157","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2215","id":154856157,"user":{"login":"mraible","id":17892,"avatar_url":"https://avatars.githubusercontent.com/u/17892?v=3","gravatar_id":"","url":"https://api.github.com/users/mraible","html_url":"https://github.com/mraible","followers_url":"https://api.github.com/users/mraible/followers","following_url":"https://api.github.com/users/mraible/following{/other_user}","gists_url":"https://api.github.com/users/mraible/gists{/gist_id}","starred_url":"https://api.github.com/users/mraible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mraible/subscriptions","organizations_url":"https://api.github.com/users/mraible/orgs","repos_url":"https://api.github.com/users/mraible/repos","events_url":"https://api.github.com/users/mraible/events{/privacy}","received_events_url":"https://api.github.com/users/mraible/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T18:37:05Z","updated_at":"2015-11-08T18:37:05Z","body":"I like these improvements @deepu105. Well done!"}}