{"action":"created","issue":{"url":"https://api.github.com/repos/alcohol/iso4217/issues/6","labels_url":"https://api.github.com/repos/alcohol/iso4217/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/alcohol/iso4217/issues/6/comments","events_url":"https://api.github.com/repos/alcohol/iso4217/issues/6/events","html_url":"https://github.com/alcohol/iso4217/pull/6","id":104879975,"number":6,"title":"HasCurrencies trait, refactoring & exception fixes","user":{"login":"tjbp","id":2157634,"avatar_url":"https://avatars.githubusercontent.com/u/2157634?v=3","gravatar_id":"","url":"https://api.github.com/users/tjbp","html_url":"https://github.com/tjbp","followers_url":"https://api.github.com/users/tjbp/followers","following_url":"https://api.github.com/users/tjbp/following{/other_user}","gists_url":"https://api.github.com/users/tjbp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjbp/subscriptions","organizations_url":"https://api.github.com/users/tjbp/orgs","repos_url":"https://api.github.com/users/tjbp/repos","events_url":"https://api.github.com/users/tjbp/events{/privacy}","received_events_url":"https://api.github.com/users/tjbp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-04T12:19:26Z","updated_at":"2015-09-05T10:56:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alcohol/iso4217/pulls/6","html_url":"https://github.com/alcohol/iso4217/pull/6","diff_url":"https://github.com/alcohol/iso4217/pull/6.diff","patch_url":"https://github.com/alcohol/iso4217/pull/6.patch"},"body":"Have swapped the logic between getByCode() and getByAlpha3() for consistency (shouldn't make any difference externally). Additionally I've corrected the Exception usage (InvalidArgumentException is for invalid argument types, rather than invalid formats; and OutOfBoundsException is a more specific child of RuntimeException.\r\n\r\nI've also added a trait for use in classes, as well as info on using it to the readme."},"comment":{"url":"https://api.github.com/repos/alcohol/iso4217/issues/comments/137943146","html_url":"https://github.com/alcohol/iso4217/pull/6#issuecomment-137943146","issue_url":"https://api.github.com/repos/alcohol/iso4217/issues/6","id":137943146,"user":{"login":"tjbp","id":2157634,"avatar_url":"https://avatars.githubusercontent.com/u/2157634?v=3","gravatar_id":"","url":"https://api.github.com/users/tjbp","html_url":"https://github.com/tjbp","followers_url":"https://api.github.com/users/tjbp/followers","following_url":"https://api.github.com/users/tjbp/following{/other_user}","gists_url":"https://api.github.com/users/tjbp/gists{/gist_id}","starred_url":"https://api.github.com/users/tjbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjbp/subscriptions","organizations_url":"https://api.github.com/users/tjbp/orgs","repos_url":"https://api.github.com/users/tjbp/repos","events_url":"https://api.github.com/users/tjbp/events{/privacy}","received_events_url":"https://api.github.com/users/tjbp/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T10:56:12Z","updated_at":"2015-09-05T10:56:12Z","body":"Understood on the trait, probably best not to add clutter. What do you mean by proper dep injection? Adding a setter to the trait for injecting the object (`public method setISO4217(ISO4217 $iso4217);`) would do that, or do you mean roping in a dep injection lib?"}}