{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23757671","id":23757671,"diff_hunk":"@@ -1263,4 +1265,20 @@ suite('system/TaskManager >', function() {\n     });\n \n   });\n+\n+  suite('orientation', function() {\n+    var app;\n+    setup(function() {\n+      app = MockService.currentApp = apps['http://sms.gaiamobile.org'];\n+      MockStackManager.mCurrent = 0;\n+    });\n+\n+    test('lock orientation when showing', function() {\n+      this.sinon.stub(screen, 'mozLockOrientation');\n+      showTaskManager(this.sinon.clock);\n+      assert.isTrue(screen.mozLockOrientation.called);","path":"apps/system/test/unit/task_manager_test.js","position":33,"original_position":33,"commit_id":"22465118fe51b0dd4ce99b912c075bf63a898bc4","original_commit_id":"22465118fe51b0dd4ce99b912c075bf63a898bc4","user":{"login":"etiennesegonzac","id":105194,"avatar_url":"https://avatars.githubusercontent.com/u/105194?v=3","gravatar_id":"","url":"https://api.github.com/users/etiennesegonzac","html_url":"https://github.com/etiennesegonzac","followers_url":"https://api.github.com/users/etiennesegonzac/followers","following_url":"https://api.github.com/users/etiennesegonzac/following{/other_user}","gists_url":"https://api.github.com/users/etiennesegonzac/gists{/gist_id}","starred_url":"https://api.github.com/users/etiennesegonzac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiennesegonzac/subscriptions","organizations_url":"https://api.github.com/users/etiennesegonzac/orgs","repos_url":"https://api.github.com/users/etiennesegonzac/repos","events_url":"https://api.github.com/users/etiennesegonzac/events{/privacy}","received_events_url":"https://api.github.com/users/etiennesegonzac/received_events","type":"User","site_admin":false},"body":"we should set `OrientationManager.defaultOrientation` and assert `calledWith(...)` here","created_at":"2015-01-29T10:10:59Z","updated_at":"2015-01-29T10:10:59Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/27695#discussion_r23757671","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/23757671"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27695#discussion_r23757671"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695","id":28085417,"html_url":"https://github.com/mozilla-b2g/gaia/pull/27695","diff_url":"https://github.com/mozilla-b2g/gaia/pull/27695.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/27695.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27695","number":27695,"state":"open","locked":false,"title":"Lock orientation when task manager shows. r=etienne","user":{"login":"sfoster","id":97747,"avatar_url":"https://avatars.githubusercontent.com/u/97747?v=3","gravatar_id":"","url":"https://api.github.com/users/sfoster","html_url":"https://github.com/sfoster","followers_url":"https://api.github.com/users/sfoster/followers","following_url":"https://api.github.com/users/sfoster/following{/other_user}","gists_url":"https://api.github.com/users/sfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/sfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfoster/subscriptions","organizations_url":"https://api.github.com/users/sfoster/orgs","repos_url":"https://api.github.com/users/sfoster/repos","events_url":"https://api.github.com/users/sfoster/events{/privacy}","received_events_url":"https://api.github.com/users/sfoster/received_events","type":"User","site_admin":false},"body":"Patch just calls lock/unlock orientation when showing/hiding task-manager, to ensure task-manager is always in default orientation. No luck with writing a marionette to test the expected behavior - I gather orientation support is a work-in-progress - so I've just asserted this the lock/unlock calls occur in a unit test.\r\n\r\n ","created_at":"2015-01-27T05:47:53Z","updated_at":"2015-01-29T10:10:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc0e9de3ebaf52cf199ec4e23b368eec5c435ed0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27695/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/22465118fe51b0dd4ce99b912c075bf63a898bc4","head":{"label":"sfoster:taskmanager-lock-orientation-bug-1118390","ref":"taskmanager-lock-orientation-bug-1118390","sha":"22465118fe51b0dd4ce99b912c075bf63a898bc4","user":{"login":"sfoster","id":97747,"avatar_url":"https://avatars.githubusercontent.com/u/97747?v=3","gravatar_id":"","url":"https://api.github.com/users/sfoster","html_url":"https://github.com/sfoster","followers_url":"https://api.github.com/users/sfoster/followers","following_url":"https://api.github.com/users/sfoster/following{/other_user}","gists_url":"https://api.github.com/users/sfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/sfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfoster/subscriptions","organizations_url":"https://api.github.com/users/sfoster/orgs","repos_url":"https://api.github.com/users/sfoster/repos","events_url":"https://api.github.com/users/sfoster/events{/privacy}","received_events_url":"https://api.github.com/users/sfoster/received_events","type":"User","site_admin":false},"repo":{"id":6138279,"name":"gaia","full_name":"sfoster/gaia","owner":{"login":"sfoster","id":97747,"avatar_url":"https://avatars.githubusercontent.com/u/97747?v=3","gravatar_id":"","url":"https://api.github.com/users/sfoster","html_url":"https://github.com/sfoster","followers_url":"https://api.github.com/users/sfoster/followers","following_url":"https://api.github.com/users/sfoster/following{/other_user}","gists_url":"https://api.github.com/users/sfoster/gists{/gist_id}","starred_url":"https://api.github.com/users/sfoster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfoster/subscriptions","organizations_url":"https://api.github.com/users/sfoster/orgs","repos_url":"https://api.github.com/users/sfoster/repos","events_url":"https://api.github.com/users/sfoster/events{/privacy}","received_events_url":"https://api.github.com/users/sfoster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfoster/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project","fork":true,"url":"https://api.github.com/repos/sfoster/gaia","forks_url":"https://api.github.com/repos/sfoster/gaia/forks","keys_url":"https://api.github.com/repos/sfoster/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfoster/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfoster/gaia/teams","hooks_url":"https://api.github.com/repos/sfoster/gaia/hooks","issue_events_url":"https://api.github.com/repos/sfoster/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/sfoster/gaia/events","assignees_url":"https://api.github.com/repos/sfoster/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/sfoster/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/sfoster/gaia/tags","blobs_url":"https://api.github.com/repos/sfoster/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfoster/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfoster/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfoster/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfoster/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/sfoster/gaia/languages","stargazers_url":"https://api.github.com/repos/sfoster/gaia/stargazers","contributors_url":"https://api.github.com/repos/sfoster/gaia/contributors","subscribers_url":"https://api.github.com/repos/sfoster/gaia/subscribers","subscription_url":"https://api.github.com/repos/sfoster/gaia/subscription","commits_url":"https://api.github.com/repos/sfoster/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfoster/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfoster/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfoster/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/sfoster/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/sfoster/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfoster/gaia/merges","archive_url":"https://api.github.com/repos/sfoster/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfoster/gaia/downloads","issues_url":"https://api.github.com/repos/sfoster/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/sfoster/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/sfoster/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/sfoster/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfoster/gaia/labels{/name}","releases_url":"https://api.github.com/repos/sfoster/gaia/releases{/id}","created_at":"2012-10-09T09:32:11Z","updated_at":"2015-01-29T06:17:39Z","pushed_at":"2015-01-29T06:57:13Z","git_url":"git://github.com/sfoster/gaia.git","ssh_url":"git@github.com:sfoster/gaia.git","clone_url":"https://github.com/sfoster/gaia.git","svn_url":"https://github.com/sfoster/gaia","homepage":"https://wiki.mozilla.org/B2G","size":869994,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"5a6e46a5a675b00200d62127350f4152593e642c","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-01-29T10:05:35Z","pushed_at":"2015-01-29T10:05:34Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1392072,"stargazers_count":1857,"watchers_count":1857,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2183,"mirror_url":null,"open_issues_count":843,"forks":2183,"open_issues":843,"watchers":1857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/27695"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27695"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/27695/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/27695/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/22465118fe51b0dd4ce99b912c075bf63a898bc4"}}}}