{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/465","labels_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/465/labels{/name}","comments_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/465/comments","events_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/465/events","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/465","id":117250795,"number":465,"title":"Add consider_imputations argument to Records class constructor","user":{"login":"martinholmer","id":12170745,"avatar_url":"https://avatars.githubusercontent.com/u/12170745?v=3","gravatar_id":"","url":"https://api.github.com/users/martinholmer","html_url":"https://github.com/martinholmer","followers_url":"https://api.github.com/users/martinholmer/followers","following_url":"https://api.github.com/users/martinholmer/following{/other_user}","gists_url":"https://api.github.com/users/martinholmer/gists{/gist_id}","starred_url":"https://api.github.com/users/martinholmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinholmer/subscriptions","organizations_url":"https://api.github.com/users/martinholmer/orgs","repos_url":"https://api.github.com/users/martinholmer/repos","events_url":"https://api.github.com/users/martinholmer/events{/privacy}","received_events_url":"https://api.github.com/users/martinholmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-17T00:20:26Z","updated_at":"2015-11-17T02:14:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/pulls/465","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/465","diff_url":"https://github.com/open-source-economics/Tax-Calculator/pull/465.diff","patch_url":"https://github.com/open-source-economics/Tax-Calculator/pull/465.patch"},"body":"The default value of the new argument is True, which was the implied logic before the addition, so that all code that calls the Records class constructor will work exactly as before.  This new constructor argument has been added to make explicit whether or not to do the variable imputations.  The addition of this argument makes the Records class constructor argument consider_imputations analogous to the Calculator class constructor argument sync_years.\r\n\r\nAlso, use this new argument to streamline logic of SimpleTaxIO class.\r\n\r\n@MattHJensen and @Amy-Xu,  Please review to confirm that this addition to the Records class constructor does not distrupt any existing uses of the Records class."},"comment":{"url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/comments/157239398","html_url":"https://github.com/open-source-economics/Tax-Calculator/pull/465#issuecomment-157239398","issue_url":"https://api.github.com/repos/open-source-economics/Tax-Calculator/issues/465","id":157239398,"user":{"login":"talumbau","id":1891418,"avatar_url":"https://avatars.githubusercontent.com/u/1891418?v=3","gravatar_id":"","url":"https://api.github.com/users/talumbau","html_url":"https://github.com/talumbau","followers_url":"https://api.github.com/users/talumbau/followers","following_url":"https://api.github.com/users/talumbau/following{/other_user}","gists_url":"https://api.github.com/users/talumbau/gists{/gist_id}","starred_url":"https://api.github.com/users/talumbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talumbau/subscriptions","organizations_url":"https://api.github.com/users/talumbau/orgs","repos_url":"https://api.github.com/users/talumbau/repos","events_url":"https://api.github.com/users/talumbau/events{/privacy}","received_events_url":"https://api.github.com/users/talumbau/received_events","type":"User","site_admin":false},"created_at":"2015-11-17T02:14:19Z","updated_at":"2015-11-17T02:14:19Z","body":"Hmm. For some reason the 'wget' of a necessary file was unsuccessful during the build. I restarted it and everything was fine. Travis CI had some problems earlier today (at least, according to their status page). Seems like just a fluke."}}