{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/30956773","id":30956773,"diff_hunk":"@@ -1624,14 +1644,37 @@ namespace aspect\n     // TODO: Compute artificial viscosity once per timestep instead of each time\n     // temperature system is assembled (as this might happen more than once per\n     // timestep for iterative solvers)\n-    const double nu\n-      = compute_viscosity (scratch,\n+\n+    double nu = 0;\n+\tint count_additions = 0;\n+\tdouble nu_additions = 0.0;\n+    if (use_smoothing == false)\n+    {\n+      nu = compute_viscosity (scratch,\n                            global_max_velocity,\n                            global_field_range.second - global_field_range.first,\n                            0.5 * (global_field_range.second + global_field_range.first),\n                            global_entropy_variation,\n                            cell->diameter(),\n                            advection_field);\n+    }\n+    else\n+    {\n+    \tfor (int k=0;k<4;k++) // RG: all of this won't work if 5 neighbors\n+    \t{\n+    \t\tif(cell->neighbor_index(k)!=-1) // RG: is there a neighbor function?","path":"source/simulator/assembly.cc","position":94,"original_position":94,"commit_id":"22bb2221d80d6675950cfae9101b887ad82ec540","original_commit_id":"22bb2221d80d6675950cfae9101b887ad82ec540","user":{"login":"rrgrove6","id":7593038,"avatar_url":"https://avatars.githubusercontent.com/u/7593038?v=3","gravatar_id":"","url":"https://api.github.com/users/rrgrove6","html_url":"https://github.com/rrgrove6","followers_url":"https://api.github.com/users/rrgrove6/followers","following_url":"https://api.github.com/users/rrgrove6/following{/other_user}","gists_url":"https://api.github.com/users/rrgrove6/gists{/gist_id}","starred_url":"https://api.github.com/users/rrgrove6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrgrove6/subscriptions","organizations_url":"https://api.github.com/users/rrgrove6/orgs","repos_url":"https://api.github.com/users/rrgrove6/repos","events_url":"https://api.github.com/users/rrgrove6/events{/privacy}","received_events_url":"https://api.github.com/users/rrgrove6/received_events","type":"User","site_admin":false},"body":"True. We just wanted to get it working for 2D and no AMR first and then get it working for everything else!","created_at":"2015-05-24T23:01:57Z","updated_at":"2015-05-24T23:01:57Z","html_url":"https://github.com/geodynamics/aspect/pull/425#discussion_r30956773","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/30956773"},"html":{"href":"https://github.com/geodynamics/aspect/pull/425#discussion_r30956773"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/425","id":36108997,"html_url":"https://github.com/geodynamics/aspect/pull/425","diff_url":"https://github.com/geodynamics/aspect/pull/425.diff","patch_url":"https://github.com/geodynamics/aspect/pull/425.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/425","number":425,"state":"open","locked":false,"title":"[WIP] Adding EV with smoothing to ASPECT","user":{"login":"rrgrove6","id":7593038,"avatar_url":"https://avatars.githubusercontent.com/u/7593038?v=3","gravatar_id":"","url":"https://api.github.com/users/rrgrove6","html_url":"https://github.com/rrgrove6","followers_url":"https://api.github.com/users/rrgrove6/followers","following_url":"https://api.github.com/users/rrgrove6/following{/other_user}","gists_url":"https://api.github.com/users/rrgrove6/gists{/gist_id}","starred_url":"https://api.github.com/users/rrgrove6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrgrove6/subscriptions","organizations_url":"https://api.github.com/users/rrgrove6/orgs","repos_url":"https://api.github.com/users/rrgrove6/repos","events_url":"https://api.github.com/users/rrgrove6/events{/privacy}","received_events_url":"https://api.github.com/users/rrgrove6/received_events","type":"User","site_admin":false},"body":"Implenting EV with smoothing.  Interestingly enough, at the moment it makes things slightly worse.  Of course, I can change the percent of the orginial nu that each cell retains to maybe get better results, but I wanted to create the pull request so that it can be open for everyone to see so that people can start giving their ideas on things that I may have messed up or possible ideas to make it better.  \r\n\r\nNOTE: Does not work if using AMR at the moment. That is to come after I figure out if everything I am doing is okay.\r\n\r\n![comparison](https://cloud.githubusercontent.com/assets/7593038/7789800/994f7f40-023c-11e5-8238-9bc2e0d9c1b8.png)\r\n","created_at":"2015-05-24T21:48:59Z","updated_at":"2015-05-24T23:01:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c520befff416bcea5ebd5644057a3a798a03c50f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/425/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/425/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/425/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/22bb2221d80d6675950cfae9101b887ad82ec540","head":{"label":"rrgrove6:ev_with_smoothing","ref":"ev_with_smoothing","sha":"22bb2221d80d6675950cfae9101b887ad82ec540","user":{"login":"rrgrove6","id":7593038,"avatar_url":"https://avatars.githubusercontent.com/u/7593038?v=3","gravatar_id":"","url":"https://api.github.com/users/rrgrove6","html_url":"https://github.com/rrgrove6","followers_url":"https://api.github.com/users/rrgrove6/followers","following_url":"https://api.github.com/users/rrgrove6/following{/other_user}","gists_url":"https://api.github.com/users/rrgrove6/gists{/gist_id}","starred_url":"https://api.github.com/users/rrgrove6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrgrove6/subscriptions","organizations_url":"https://api.github.com/users/rrgrove6/orgs","repos_url":"https://api.github.com/users/rrgrove6/repos","events_url":"https://api.github.com/users/rrgrove6/events{/privacy}","received_events_url":"https://api.github.com/users/rrgrove6/received_events","type":"User","site_admin":false},"repo":{"id":19822082,"name":"aspect","full_name":"rrgrove6/aspect","owner":{"login":"rrgrove6","id":7593038,"avatar_url":"https://avatars.githubusercontent.com/u/7593038?v=3","gravatar_id":"","url":"https://api.github.com/users/rrgrove6","html_url":"https://github.com/rrgrove6","followers_url":"https://api.github.com/users/rrgrove6/followers","following_url":"https://api.github.com/users/rrgrove6/following{/other_user}","gists_url":"https://api.github.com/users/rrgrove6/gists{/gist_id}","starred_url":"https://api.github.com/users/rrgrove6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrgrove6/subscriptions","organizations_url":"https://api.github.com/users/rrgrove6/orgs","repos_url":"https://api.github.com/users/rrgrove6/repos","events_url":"https://api.github.com/users/rrgrove6/events{/privacy}","received_events_url":"https://api.github.com/users/rrgrove6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrgrove6/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/rrgrove6/aspect","forks_url":"https://api.github.com/repos/rrgrove6/aspect/forks","keys_url":"https://api.github.com/repos/rrgrove6/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrgrove6/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrgrove6/aspect/teams","hooks_url":"https://api.github.com/repos/rrgrove6/aspect/hooks","issue_events_url":"https://api.github.com/repos/rrgrove6/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/rrgrove6/aspect/events","assignees_url":"https://api.github.com/repos/rrgrove6/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/rrgrove6/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/rrgrove6/aspect/tags","blobs_url":"https://api.github.com/repos/rrgrove6/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrgrove6/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrgrove6/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrgrove6/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrgrove6/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/rrgrove6/aspect/languages","stargazers_url":"https://api.github.com/repos/rrgrove6/aspect/stargazers","contributors_url":"https://api.github.com/repos/rrgrove6/aspect/contributors","subscribers_url":"https://api.github.com/repos/rrgrove6/aspect/subscribers","subscription_url":"https://api.github.com/repos/rrgrove6/aspect/subscription","commits_url":"https://api.github.com/repos/rrgrove6/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrgrove6/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrgrove6/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrgrove6/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrgrove6/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/rrgrove6/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrgrove6/aspect/merges","archive_url":"https://api.github.com/repos/rrgrove6/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrgrove6/aspect/downloads","issues_url":"https://api.github.com/repos/rrgrove6/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/rrgrove6/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/rrgrove6/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/rrgrove6/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrgrove6/aspect/labels{/name}","releases_url":"https://api.github.com/repos/rrgrove6/aspect/releases{/id}","created_at":"2014-05-15T14:20:52Z","updated_at":"2015-05-14T12:56:43Z","pushed_at":"2015-05-24T21:44:23Z","git_url":"git://github.com/rrgrove6/aspect.git","ssh_url":"git@github.com:rrgrove6/aspect.git","clone_url":"https://github.com/rrgrove6/aspect.git","svn_url":"https://github.com/rrgrove6/aspect","homepage":null,"size":101650,"stargazers_count":0,"watchers_count":0,"language":"Gnuplot","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"8dadd8e8b1d2f5fc7253fcf869c4e5b26778ebec","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars.githubusercontent.com/u/4052461?v=3","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extendible finite element code to simulate thermal convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","created_at":"2014-05-06T16:47:18Z","updated_at":"2015-05-08T16:13:02Z","pushed_at":"2015-05-24T23:00:02Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"http://aspect.dealii.org/","size":122783,"stargazers_count":10,"watchers_count":10,"language":"Gnuplot","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":57,"forks":33,"open_issues":57,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/425"},"html":{"href":"https://github.com/geodynamics/aspect/pull/425"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/425"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/22bb2221d80d6675950cfae9101b887ad82ec540"}}}}