{"action":"closed","number":20747,"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/20747","id":38948459,"html_url":"https://github.com/rails/rails/pull/20747","diff_url":"https://github.com/rails/rails/pull/20747.diff","patch_url":"https://github.com/rails/rails/pull/20747.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/20747","number":20747,"state":"closed","locked":false,"title":"Avoid crashing when minitest-rails is loaded.","user":{"login":"pwnall","id":11460,"avatar_url":"https://avatars.githubusercontent.com/u/11460?v=3","gravatar_id":"","url":"https://api.github.com/users/pwnall","html_url":"https://github.com/pwnall","followers_url":"https://api.github.com/users/pwnall/followers","following_url":"https://api.github.com/users/pwnall/following{/other_user}","gists_url":"https://api.github.com/users/pwnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwnall/subscriptions","organizations_url":"https://api.github.com/users/pwnall/orgs","repos_url":"https://api.github.com/users/pwnall/repos","events_url":"https://api.github.com/users/pwnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwnall/received_events","type":"User","site_admin":false},"body":"The improvments to the test runner's integration with minitest in commit b6fc8e25a10cc4abdd03018798b180270d6c5d7f add methods to the Minitest module that refer to the Rails module. Unfortunately, when the minitest-rails gem is loaded, the reference is incorrectly resolved to the Minitest::Rails module.\r\n\r\nI fixed this by switching those references to absolute references. I'm not sure how to add tests for this change, but I tested it manually and it works with the `rails5` branch of [minitest-rails](https://github.com/blowmage/minitest-rails).","created_at":"2015-07-01T05:01:39Z","updated_at":"2015-07-01T06:15:12Z","closed_at":"2015-07-01T06:15:12Z","merged_at":"2015-07-01T06:15:12Z","merge_commit_sha":"67603a01fc8a9360623a6929098462f5ce5a298b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/20747/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/20747/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/20747/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/e334ec4fe6baf40cf695c334762f8f2eea8a06ed","head":{"label":"pwnall:fix_minitest_rails","ref":"fix_minitest_rails","sha":"e334ec4fe6baf40cf695c334762f8f2eea8a06ed","user":{"login":"pwnall","id":11460,"avatar_url":"https://avatars.githubusercontent.com/u/11460?v=3","gravatar_id":"","url":"https://api.github.com/users/pwnall","html_url":"https://github.com/pwnall","followers_url":"https://api.github.com/users/pwnall/followers","following_url":"https://api.github.com/users/pwnall/following{/other_user}","gists_url":"https://api.github.com/users/pwnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwnall/subscriptions","organizations_url":"https://api.github.com/users/pwnall/orgs","repos_url":"https://api.github.com/users/pwnall/repos","events_url":"https://api.github.com/users/pwnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwnall/received_events","type":"User","site_admin":false},"repo":{"id":2346206,"name":"rails","full_name":"pwnall/rails","owner":{"login":"pwnall","id":11460,"avatar_url":"https://avatars.githubusercontent.com/u/11460?v=3","gravatar_id":"","url":"https://api.github.com/users/pwnall","html_url":"https://github.com/pwnall","followers_url":"https://api.github.com/users/pwnall/followers","following_url":"https://api.github.com/users/pwnall/following{/other_user}","gists_url":"https://api.github.com/users/pwnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwnall/subscriptions","organizations_url":"https://api.github.com/users/pwnall/orgs","repos_url":"https://api.github.com/users/pwnall/repos","events_url":"https://api.github.com/users/pwnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwnall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pwnall/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/pwnall/rails","forks_url":"https://api.github.com/repos/pwnall/rails/forks","keys_url":"https://api.github.com/repos/pwnall/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwnall/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwnall/rails/teams","hooks_url":"https://api.github.com/repos/pwnall/rails/hooks","issue_events_url":"https://api.github.com/repos/pwnall/rails/issues/events{/number}","events_url":"https://api.github.com/repos/pwnall/rails/events","assignees_url":"https://api.github.com/repos/pwnall/rails/assignees{/user}","branches_url":"https://api.github.com/repos/pwnall/rails/branches{/branch}","tags_url":"https://api.github.com/repos/pwnall/rails/tags","blobs_url":"https://api.github.com/repos/pwnall/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwnall/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwnall/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwnall/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwnall/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/pwnall/rails/languages","stargazers_url":"https://api.github.com/repos/pwnall/rails/stargazers","contributors_url":"https://api.github.com/repos/pwnall/rails/contributors","subscribers_url":"https://api.github.com/repos/pwnall/rails/subscribers","subscription_url":"https://api.github.com/repos/pwnall/rails/subscription","commits_url":"https://api.github.com/repos/pwnall/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwnall/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwnall/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwnall/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwnall/rails/contents/{+path}","compare_url":"https://api.github.com/repos/pwnall/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwnall/rails/merges","archive_url":"https://api.github.com/repos/pwnall/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwnall/rails/downloads","issues_url":"https://api.github.com/repos/pwnall/rails/issues{/number}","pulls_url":"https://api.github.com/repos/pwnall/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/pwnall/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/pwnall/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwnall/rails/labels{/name}","releases_url":"https://api.github.com/repos/pwnall/rails/releases{/id}","created_at":"2011-09-08T03:37:02Z","updated_at":"2015-03-10T00:47:33Z","pushed_at":"2015-07-01T05:04:34Z","git_url":"git://github.com/pwnall/rails.git","ssh_url":"git@github.com:pwnall/rails.git","clone_url":"https://github.com/pwnall/rails.git","svn_url":"https://github.com/pwnall/rails","homepage":"http://rubyonrails.org","size":143499,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"bc6ac8609cf79f28047c0928b9433e00e6ea1f09","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-07-01T06:13:40Z","pushed_at":"2015-07-01T06:15:12Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":425885,"stargazers_count":26738,"watchers_count":26738,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10669,"mirror_url":null,"open_issues_count":807,"forks":10669,"open_issues":807,"watchers":26738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/20747"},"html":{"href":"https://github.com/rails/rails/pull/20747"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/20747"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/20747/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/20747/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/20747/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/e334ec4fe6baf40cf695c334762f8f2eea8a06ed"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kaspth","id":350807,"avatar_url":"https://avatars.githubusercontent.com/u/350807?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspth","html_url":"https://github.com/kaspth","followers_url":"https://api.github.com/users/kaspth/followers","following_url":"https://api.github.com/users/kaspth/following{/other_user}","gists_url":"https://api.github.com/users/kaspth/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspth/subscriptions","organizations_url":"https://api.github.com/users/kaspth/orgs","repos_url":"https://api.github.com/users/kaspth/repos","events_url":"https://api.github.com/users/kaspth/events{/privacy}","received_events_url":"https://api.github.com/users/kaspth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}