{"action":"created","comment":{"url":"https://api.github.com/repos/zettio/weave/pulls/comments/24999510","id":24999510,"diff_hunk":"@@ -87,6 +89,18 @@ func main() {\n \t\trouterName = iface.HardwareAddr.String()\n \t}\n \n+\tif hostName == \"\" {\n+\t\tosHostName, err := os.Hostname()\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(err)\n+\t\t}\n+\t\tif osHostName == \"\" {\n+\t\t\thostName = \"<unknown>\"","path":"weaver/main.go","position":26,"original_position":26,"commit_id":"8f6a525bded61b0999333dc6fb2a8296fd9d6229","original_commit_id":"8f6a525bded61b0999333dc6fb2a8296fd9d6229","user":{"login":"rade","id":109109,"avatar_url":"https://avatars.githubusercontent.com/u/109109?v=3","gravatar_id":"","url":"https://api.github.com/users/rade","html_url":"https://github.com/rade","followers_url":"https://api.github.com/users/rade/followers","following_url":"https://api.github.com/users/rade/following{/other_user}","gists_url":"https://api.github.com/users/rade/gists{/gist_id}","starred_url":"https://api.github.com/users/rade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rade/subscriptions","organizations_url":"https://api.github.com/users/rade/orgs","repos_url":"https://api.github.com/users/rade/repos","events_url":"https://api.github.com/users/rade/events{/privacy}","received_events_url":"https://api.github.com/users/rade/received_events","type":"User","site_admin":false},"body":"I reckon that will look rather odd in the various places where that gets displayed. Set it to \"\", perhaps?","created_at":"2015-02-19T16:10:50Z","updated_at":"2015-02-19T16:10:50Z","html_url":"https://github.com/zettio/weave/pull/407#discussion_r24999510","pull_request_url":"https://api.github.com/repos/zettio/weave/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/zettio/weave/pulls/comments/24999510"},"html":{"href":"https://github.com/zettio/weave/pull/407#discussion_r24999510"},"pull_request":{"href":"https://api.github.com/repos/zettio/weave/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/zettio/weave/pulls/407","id":29621144,"html_url":"https://github.com/zettio/weave/pull/407","diff_url":"https://github.com/zettio/weave/pull/407.diff","patch_url":"https://github.com/zettio/weave/pull/407.patch","issue_url":"https://api.github.com/repos/zettio/weave/issues/407","number":407,"state":"open","locked":false,"title":"369 name weave peers","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"body":"Implement `-hostname` flag to weave router for inclusion in `weave status`:\r\n\r\n    root@weave01:~# weave status\r\n    weave router git-170724472555\r\n    Encryption off\r\n    Our name is 7a:85:0d:3f:4b:8b (weave01)\r\n    Sniffing traffic on &{25 65535 ethwe 26:47:3f:b1:9f:35 up|broadcast|multicast}\r\n    MACs:\r\n    e6:eb:3d:c2:f2:c0 -> 7a:85:0d:3f:4b:8b (2015-02-19 14:36:43.698599704 +0000 UTC)\r\n    ea:9b:f6:9a:a8:94 -> 7a:ee:54:05:6d:19 (2015-02-19 14:36:45.467878022 +0000 UTC)\r\n    02:c5:dc:fa:4f:19 -> 7a:c4:7d:e3:0f:9b (2015-02-19 14:36:50.594692416 +0000 UTC)\r\n    Peers:\r\n    Peer 7a:c4:7d:e3:0f:9b (weave03) (v37) (UID 12377675045837118970)\r\n       -> 7a:ee:54:05:6d:19 (weave02) [178.62.77.81:6783]\r\n       -> 7a:85:0d:3f:4b:8b (weave01) [178.62.57.35:6783]\r\n    Peer 7a:85:0d:3f:4b:8b (weave01) (v8) (UID 8327482320931219319)\r\n       -> 7a:c4:7d:e3:0f:9b (weave03) [178.62.106.102:59473]\r\n       -> 7a:ee:54:05:6d:19 (weave02) [178.62.77.81:48078]\r\n    Peer 7a:ee:54:05:6d:19 (weave02) (v4) (UID 13020696009711836879)\r\n       -> 7a:85:0d:3f:4b:8b (weave01) [178.62.57.35:6783]\r\n       -> 7a:c4:7d:e3:0f:9b (weave03) [178.62.106.102:53570]\r\n\r\nNotes:\r\n\r\n* `weave launch` does not accept user supplied `-hostname` as this would require introducing `getopt` or similar into the bash script and given [#307](https://github.com/zettio/weave/issues/307) is in the offing it didn't seem prudent; script supplies kernel hostname directly to weave router for now. Please advise if you would like this addressed before merging\r\n* Protocol version was increased due to binary incompatibility introduced by inclusion of hostname in the gossip protocol messages","created_at":"2015-02-19T15:39:06Z","updated_at":"2015-02-19T16:10:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e07a74a1446eb56b8f00d6d8d2bac9261e6d0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zettio/weave/pulls/407/commits","review_comments_url":"https://api.github.com/repos/zettio/weave/pulls/407/comments","review_comment_url":"https://api.github.com/repos/zettio/weave/pulls/comments/{number}","comments_url":"https://api.github.com/repos/zettio/weave/issues/407/comments","statuses_url":"https://api.github.com/repos/zettio/weave/statuses/8f6a525bded61b0999333dc6fb2a8296fd9d6229","head":{"label":"awh:369_name_weave_peers","ref":"369_name_weave_peers","sha":"8f6a525bded61b0999333dc6fb2a8296fd9d6229","user":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"repo":{"id":30765046,"name":"weave","full_name":"awh/weave","owner":{"login":"awh","id":1504438,"avatar_url":"https://avatars.githubusercontent.com/u/1504438?v=3","gravatar_id":"","url":"https://api.github.com/users/awh","html_url":"https://github.com/awh","followers_url":"https://api.github.com/users/awh/followers","following_url":"https://api.github.com/users/awh/following{/other_user}","gists_url":"https://api.github.com/users/awh/gists{/gist_id}","starred_url":"https://api.github.com/users/awh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awh/subscriptions","organizations_url":"https://api.github.com/users/awh/orgs","repos_url":"https://api.github.com/users/awh/repos","events_url":"https://api.github.com/users/awh/events{/privacy}","received_events_url":"https://api.github.com/users/awh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awh/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/awh/weave","forks_url":"https://api.github.com/repos/awh/weave/forks","keys_url":"https://api.github.com/repos/awh/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awh/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awh/weave/teams","hooks_url":"https://api.github.com/repos/awh/weave/hooks","issue_events_url":"https://api.github.com/repos/awh/weave/issues/events{/number}","events_url":"https://api.github.com/repos/awh/weave/events","assignees_url":"https://api.github.com/repos/awh/weave/assignees{/user}","branches_url":"https://api.github.com/repos/awh/weave/branches{/branch}","tags_url":"https://api.github.com/repos/awh/weave/tags","blobs_url":"https://api.github.com/repos/awh/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awh/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awh/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/awh/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awh/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/awh/weave/languages","stargazers_url":"https://api.github.com/repos/awh/weave/stargazers","contributors_url":"https://api.github.com/repos/awh/weave/contributors","subscribers_url":"https://api.github.com/repos/awh/weave/subscribers","subscription_url":"https://api.github.com/repos/awh/weave/subscription","commits_url":"https://api.github.com/repos/awh/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/awh/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/awh/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/awh/weave/issues/comments/{number}","contents_url":"https://api.github.com/repos/awh/weave/contents/{+path}","compare_url":"https://api.github.com/repos/awh/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awh/weave/merges","archive_url":"https://api.github.com/repos/awh/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awh/weave/downloads","issues_url":"https://api.github.com/repos/awh/weave/issues{/number}","pulls_url":"https://api.github.com/repos/awh/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/awh/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/awh/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awh/weave/labels{/name}","releases_url":"https://api.github.com/repos/awh/weave/releases{/id}","created_at":"2015-02-13T16:32:58Z","updated_at":"2015-02-18T15:43:35Z","pushed_at":"2015-02-19T15:07:19Z","git_url":"git://github.com/awh/weave.git","ssh_url":"git@github.com:awh/weave.git","clone_url":"https://github.com/awh/weave.git","svn_url":"https://github.com/awh/weave","homepage":"","size":5533,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zettio:master","ref":"master","sha":"2817638ef9c7923634bc0209ceefe951a29a521d","user":{"login":"zettio","id":8475709,"avatar_url":"https://avatars.githubusercontent.com/u/8475709?v=3","gravatar_id":"","url":"https://api.github.com/users/zettio","html_url":"https://github.com/zettio","followers_url":"https://api.github.com/users/zettio/followers","following_url":"https://api.github.com/users/zettio/following{/other_user}","gists_url":"https://api.github.com/users/zettio/gists{/gist_id}","starred_url":"https://api.github.com/users/zettio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettio/subscriptions","organizations_url":"https://api.github.com/users/zettio/orgs","repos_url":"https://api.github.com/users/zettio/repos","events_url":"https://api.github.com/users/zettio/events{/privacy}","received_events_url":"https://api.github.com/users/zettio/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"zettio/weave","owner":{"login":"zettio","id":8475709,"avatar_url":"https://avatars.githubusercontent.com/u/8475709?v=3","gravatar_id":"","url":"https://api.github.com/users/zettio","html_url":"https://github.com/zettio","followers_url":"https://api.github.com/users/zettio/followers","following_url":"https://api.github.com/users/zettio/following{/other_user}","gists_url":"https://api.github.com/users/zettio/gists{/gist_id}","starred_url":"https://api.github.com/users/zettio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zettio/subscriptions","organizations_url":"https://api.github.com/users/zettio/orgs","repos_url":"https://api.github.com/users/zettio/repos","events_url":"https://api.github.com/users/zettio/events{/privacy}","received_events_url":"https://api.github.com/users/zettio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zettio/weave","description":"The Docker Network","fork":false,"url":"https://api.github.com/repos/zettio/weave","forks_url":"https://api.github.com/repos/zettio/weave/forks","keys_url":"https://api.github.com/repos/zettio/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zettio/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zettio/weave/teams","hooks_url":"https://api.github.com/repos/zettio/weave/hooks","issue_events_url":"https://api.github.com/repos/zettio/weave/issues/events{/number}","events_url":"https://api.github.com/repos/zettio/weave/events","assignees_url":"https://api.github.com/repos/zettio/weave/assignees{/user}","branches_url":"https://api.github.com/repos/zettio/weave/branches{/branch}","tags_url":"https://api.github.com/repos/zettio/weave/tags","blobs_url":"https://api.github.com/repos/zettio/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zettio/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zettio/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/zettio/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zettio/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/zettio/weave/languages","stargazers_url":"https://api.github.com/repos/zettio/weave/stargazers","contributors_url":"https://api.github.com/repos/zettio/weave/contributors","subscribers_url":"https://api.github.com/repos/zettio/weave/subscribers","subscription_url":"https://api.github.com/repos/zettio/weave/subscription","commits_url":"https://api.github.com/repos/zettio/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/zettio/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/zettio/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/zettio/weave/issues/comments/{number}","contents_url":"https://api.github.com/repos/zettio/weave/contents/{+path}","compare_url":"https://api.github.com/repos/zettio/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zettio/weave/merges","archive_url":"https://api.github.com/repos/zettio/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zettio/weave/downloads","issues_url":"https://api.github.com/repos/zettio/weave/issues{/number}","pulls_url":"https://api.github.com/repos/zettio/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/zettio/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/zettio/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zettio/weave/labels{/name}","releases_url":"https://api.github.com/repos/zettio/weave/releases{/id}","created_at":"2014-08-18T05:19:07Z","updated_at":"2015-02-19T13:10:38Z","pushed_at":"2015-02-17T12:39:16Z","git_url":"git://github.com/zettio/weave.git","ssh_url":"git@github.com:zettio/weave.git","clone_url":"https://github.com/zettio/weave.git","svn_url":"https://github.com/zettio/weave","homepage":"","size":5533,"stargazers_count":2863,"watchers_count":2863,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":139,"mirror_url":null,"open_issues_count":83,"forks":139,"open_issues":83,"watchers":2863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zettio/weave/pulls/407"},"html":{"href":"https://github.com/zettio/weave/pull/407"},"issue":{"href":"https://api.github.com/repos/zettio/weave/issues/407"},"comments":{"href":"https://api.github.com/repos/zettio/weave/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/zettio/weave/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/zettio/weave/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/zettio/weave/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/zettio/weave/statuses/8f6a525bded61b0999333dc6fb2a8296fd9d6229"}}}}