{"action":"created","comment":{"url":"https://api.github.com/repos/staltz/cycle/pulls/comments/29656743","id":29656743,"diff_hunk":"@@ -83,15 +83,13 @@ function makeDiffAndPatchToElement$(rootElem) {\n       })\n       .first();\n     let cycleCustomElementMetadata = rootElem.cycleCustomElementMetadata;\n-    try {\n-      //let isCustomElement = !!rootElem.cycleCustomElementMetadata;\n-      //let k = isCustomElement ? ' is custom element ' : ' is top level';\n-      //console.log('%cVDOM diff and patch START' + k, 'color: #636300');\n-      rootElem = VDOM.patch(rootElem, VDOM.diff(oldVTree, newVTree));\n-      //console.log('%cVDOM diff and patch END' + k, 'color: #636300');\n-    } catch (err) {\n-      console.error(err);\n-    }\n+\n+    //let isCustomElement = !!rootElem.cycleCustomElementMetadata;\n+    //let k = isCustomElement ? ' is custom element ' : ' is top level';\n+    //console.log('%cVDOM diff and patch START' + k, 'color: #636300');\n+    rootElem = VDOM.patch(rootElem, VDOM.diff(oldVTree, newVTree));\n+    //console.log('%cVDOM diff and patch END' + k, 'color: #636300');\n+","path":"src/rendering/render-dom.js","position":19,"original_position":19,"commit_id":"9d44b961b1d2b92e3a91157a69067161786667a2","original_commit_id":"9d44b961b1d2b92e3a91157a69067161786667a2","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"body":":+1:","created_at":"2015-05-05T10:10:38Z","updated_at":"2015-05-05T10:10:38Z","html_url":"https://github.com/staltz/cycle/pull/111#discussion_r29656743","pull_request_url":"https://api.github.com/repos/staltz/cycle/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/staltz/cycle/pulls/comments/29656743"},"html":{"href":"https://github.com/staltz/cycle/pull/111#discussion_r29656743"},"pull_request":{"href":"https://api.github.com/repos/staltz/cycle/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/staltz/cycle/pulls/111","id":34710456,"html_url":"https://github.com/staltz/cycle/pull/111","diff_url":"https://github.com/staltz/cycle/pull/111.diff","patch_url":"https://github.com/staltz/cycle/pull/111.patch","issue_url":"https://api.github.com/repos/staltz/cycle/issues/111","number":111,"state":"open","locked":false,"title":"nostream: Properly dispose resources after the custom-element has been destroyed","user":{"login":"pH200","id":1430310,"avatar_url":"https://avatars.githubusercontent.com/u/1430310?v=3","gravatar_id":"","url":"https://api.github.com/users/pH200","html_url":"https://github.com/pH200","followers_url":"https://api.github.com/users/pH200/followers","following_url":"https://api.github.com/users/pH200/following{/other_user}","gists_url":"https://api.github.com/users/pH200/gists{/gist_id}","starred_url":"https://api.github.com/users/pH200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pH200/subscriptions","organizations_url":"https://api.github.com/users/pH200/orgs","repos_url":"https://api.github.com/users/pH200/repos","events_url":"https://api.github.com/users/pH200/events{/privacy}","received_events_url":"https://api.github.com/users/pH200/received_events","type":"User","site_admin":false},"body":"Reference: #108 ","created_at":"2015-05-05T10:07:46Z","updated_at":"2015-05-05T10:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab26c4ab74a4bd7088a7960e124d5a287870616","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/staltz/cycle/pulls/111/commits","review_comments_url":"https://api.github.com/repos/staltz/cycle/pulls/111/comments","review_comment_url":"https://api.github.com/repos/staltz/cycle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/staltz/cycle/issues/111/comments","statuses_url":"https://api.github.com/repos/staltz/cycle/statuses/9d44b961b1d2b92e3a91157a69067161786667a2","head":{"label":"pH200:nostream","ref":"nostream","sha":"9d44b961b1d2b92e3a91157a69067161786667a2","user":{"login":"pH200","id":1430310,"avatar_url":"https://avatars.githubusercontent.com/u/1430310?v=3","gravatar_id":"","url":"https://api.github.com/users/pH200","html_url":"https://github.com/pH200","followers_url":"https://api.github.com/users/pH200/followers","following_url":"https://api.github.com/users/pH200/following{/other_user}","gists_url":"https://api.github.com/users/pH200/gists{/gist_id}","starred_url":"https://api.github.com/users/pH200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pH200/subscriptions","organizations_url":"https://api.github.com/users/pH200/orgs","repos_url":"https://api.github.com/users/pH200/repos","events_url":"https://api.github.com/users/pH200/events{/privacy}","received_events_url":"https://api.github.com/users/pH200/received_events","type":"User","site_admin":false},"repo":{"id":34900319,"name":"cycle","full_name":"pH200/cycle","owner":{"login":"pH200","id":1430310,"avatar_url":"https://avatars.githubusercontent.com/u/1430310?v=3","gravatar_id":"","url":"https://api.github.com/users/pH200","html_url":"https://github.com/pH200","followers_url":"https://api.github.com/users/pH200/followers","following_url":"https://api.github.com/users/pH200/following{/other_user}","gists_url":"https://api.github.com/users/pH200/gists{/gist_id}","starred_url":"https://api.github.com/users/pH200/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pH200/subscriptions","organizations_url":"https://api.github.com/users/pH200/orgs","repos_url":"https://api.github.com/users/pH200/repos","events_url":"https://api.github.com/users/pH200/events{/privacy}","received_events_url":"https://api.github.com/users/pH200/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pH200/cycle","description":"An honestly reactive framework for web user interfaces","fork":true,"url":"https://api.github.com/repos/pH200/cycle","forks_url":"https://api.github.com/repos/pH200/cycle/forks","keys_url":"https://api.github.com/repos/pH200/cycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pH200/cycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pH200/cycle/teams","hooks_url":"https://api.github.com/repos/pH200/cycle/hooks","issue_events_url":"https://api.github.com/repos/pH200/cycle/issues/events{/number}","events_url":"https://api.github.com/repos/pH200/cycle/events","assignees_url":"https://api.github.com/repos/pH200/cycle/assignees{/user}","branches_url":"https://api.github.com/repos/pH200/cycle/branches{/branch}","tags_url":"https://api.github.com/repos/pH200/cycle/tags","blobs_url":"https://api.github.com/repos/pH200/cycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pH200/cycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pH200/cycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pH200/cycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pH200/cycle/statuses/{sha}","languages_url":"https://api.github.com/repos/pH200/cycle/languages","stargazers_url":"https://api.github.com/repos/pH200/cycle/stargazers","contributors_url":"https://api.github.com/repos/pH200/cycle/contributors","subscribers_url":"https://api.github.com/repos/pH200/cycle/subscribers","subscription_url":"https://api.github.com/repos/pH200/cycle/subscription","commits_url":"https://api.github.com/repos/pH200/cycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pH200/cycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pH200/cycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pH200/cycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pH200/cycle/contents/{+path}","compare_url":"https://api.github.com/repos/pH200/cycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pH200/cycle/merges","archive_url":"https://api.github.com/repos/pH200/cycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pH200/cycle/downloads","issues_url":"https://api.github.com/repos/pH200/cycle/issues{/number}","pulls_url":"https://api.github.com/repos/pH200/cycle/pulls{/number}","milestones_url":"https://api.github.com/repos/pH200/cycle/milestones{/number}","notifications_url":"https://api.github.com/repos/pH200/cycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pH200/cycle/labels{/name}","releases_url":"https://api.github.com/repos/pH200/cycle/releases{/id}","created_at":"2015-05-01T11:39:01Z","updated_at":"2015-05-03T18:54:31Z","pushed_at":"2015-05-05T10:05:42Z","git_url":"git://github.com/pH200/cycle.git","ssh_url":"git@github.com:pH200/cycle.git","clone_url":"https://github.com/pH200/cycle.git","svn_url":"https://github.com/pH200/cycle","homepage":"","size":2963,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"staltz:nostream","ref":"nostream","sha":"972acad3dc93b01f9ae01c1f1e2dd12f12eb0c6a","user":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"repo":{"id":26316966,"name":"cycle","full_name":"staltz/cycle","owner":{"login":"staltz","id":90512,"avatar_url":"https://avatars.githubusercontent.com/u/90512?v=3","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/staltz/cycle","description":"An honestly reactive framework for web user interfaces","fork":false,"url":"https://api.github.com/repos/staltz/cycle","forks_url":"https://api.github.com/repos/staltz/cycle/forks","keys_url":"https://api.github.com/repos/staltz/cycle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staltz/cycle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staltz/cycle/teams","hooks_url":"https://api.github.com/repos/staltz/cycle/hooks","issue_events_url":"https://api.github.com/repos/staltz/cycle/issues/events{/number}","events_url":"https://api.github.com/repos/staltz/cycle/events","assignees_url":"https://api.github.com/repos/staltz/cycle/assignees{/user}","branches_url":"https://api.github.com/repos/staltz/cycle/branches{/branch}","tags_url":"https://api.github.com/repos/staltz/cycle/tags","blobs_url":"https://api.github.com/repos/staltz/cycle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staltz/cycle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staltz/cycle/git/refs{/sha}","trees_url":"https://api.github.com/repos/staltz/cycle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staltz/cycle/statuses/{sha}","languages_url":"https://api.github.com/repos/staltz/cycle/languages","stargazers_url":"https://api.github.com/repos/staltz/cycle/stargazers","contributors_url":"https://api.github.com/repos/staltz/cycle/contributors","subscribers_url":"https://api.github.com/repos/staltz/cycle/subscribers","subscription_url":"https://api.github.com/repos/staltz/cycle/subscription","commits_url":"https://api.github.com/repos/staltz/cycle/commits{/sha}","git_commits_url":"https://api.github.com/repos/staltz/cycle/git/commits{/sha}","comments_url":"https://api.github.com/repos/staltz/cycle/comments{/number}","issue_comment_url":"https://api.github.com/repos/staltz/cycle/issues/comments{/number}","contents_url":"https://api.github.com/repos/staltz/cycle/contents/{+path}","compare_url":"https://api.github.com/repos/staltz/cycle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staltz/cycle/merges","archive_url":"https://api.github.com/repos/staltz/cycle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staltz/cycle/downloads","issues_url":"https://api.github.com/repos/staltz/cycle/issues{/number}","pulls_url":"https://api.github.com/repos/staltz/cycle/pulls{/number}","milestones_url":"https://api.github.com/repos/staltz/cycle/milestones{/number}","notifications_url":"https://api.github.com/repos/staltz/cycle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staltz/cycle/labels{/name}","releases_url":"https://api.github.com/repos/staltz/cycle/releases{/id}","created_at":"2014-11-07T11:28:45Z","updated_at":"2015-05-04T20:43:18Z","pushed_at":"2015-05-05T10:07:47Z","git_url":"git://github.com/staltz/cycle.git","ssh_url":"git@github.com:staltz/cycle.git","clone_url":"https://github.com/staltz/cycle.git","svn_url":"https://github.com/staltz/cycle","homepage":"","size":4677,"stargazers_count":953,"watchers_count":953,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":23,"forks":25,"open_issues":23,"watchers":953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/staltz/cycle/pulls/111"},"html":{"href":"https://github.com/staltz/cycle/pull/111"},"issue":{"href":"https://api.github.com/repos/staltz/cycle/issues/111"},"comments":{"href":"https://api.github.com/repos/staltz/cycle/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/staltz/cycle/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/staltz/cycle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/staltz/cycle/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/staltz/cycle/statuses/9d44b961b1d2b92e3a91157a69067161786667a2"}}}}