{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/25627794","id":25627794,"diff_hunk":"@@ -1,28 +1,29 @@\n module( \"progressbar: core\" );\n \n-test( \"markup structure\", function() {\n-\texpect( 5 );\n-\tvar element = $( \"#progressbar\" ).progressbar();\n-\tok( element.hasClass( \"ui-progressbar\" ), \"main element is .ui-progressbar\" );\n-\tok( !element.hasClass( \"ui-progressbar-indeterminate\" ),\n-\t\t\"main element is not .ui-progressbar-indeterminate\" );\n-\tequal( element.children().length, 1, \"main element contains one child\" );\n-\tok( element.children().eq( 0 ).hasClass( \"ui-progressbar-value\" ),\n-\t\t\"child is .ui-progressbar-value\" );\n+test( \"markup structure\", function( assert ) {\n+\texpect( 6 );\n+\tvar element = $( \"#progressbar\" ).progressbar(),\n+\t\tvalue = element.children().eq( 0 );\n+\n+\tassert.hasClasses( element, \"ui-progressbar ui-widget ui-widget-content\" );\n+\tassert.lacksClasses( value, \"ui-progressbar-complete\" );\n+\n+\telement.progressbar( \"option\", \"value\", 100 );\n+\tassert.lacksClasses( element, \"ui-progressbar-indeterminate\" );\n+\tassert.hasClasses( value, \"ui-progressbar-complete ui-widget-header ui-progressbar-value\" );\n+\tequal( element.children().length, 1, \"Main element contains one child\" );\n \tequal( element.children().children().length, 0, \"no overlay div\" );\n });\n \n-test( \"markup structure - indeterminate\", function() {\n-\texpect( 5 );\n+test( \"markup structure - indeterminate\", function( assert ) {\n+\texpect( 4 );\n \tvar element = $( \"#progressbar\" ).progressbar({ value: false });\n-\tok( element.hasClass( \"ui-progressbar\" ), \"main element is .ui-progressbar\" );\n-\tok( element.hasClass( \"ui-progressbar-indeterminate\" ),\n-\t\t\"main element is .ui-progressbar-indeterminate\" );\n-\tequal( element.children().length, 1, \"main element contains one child\" );\n-\tok( element.children().eq( 0 ).hasClass( \"ui-progressbar-value\" ),\n-\t\t\"child is .ui-progressbar-value\" );\n+\n+\tassert.hasClasses( element, \"ui-progressbar ui-progressbar-indeterminate\" );\n+\tequal( element.children().length, 1, \"Main element contains one child\" );\n+\tassert.hasClasses( element.children().eq( 0 ), \"ui-progressbar-value\" );","path":"tests/unit/progressbar/progressbar_core.js","position":41,"original_position":41,"commit_id":"e36a22aab532102b391cafdf4fc3156edb80f30d","original_commit_id":"e36a22aab532102b391cafdf4fc3156edb80f30d","user":{"login":"scottgonzalez","id":141167,"avatar_url":"https://avatars.githubusercontent.com/u/141167?v=3","gravatar_id":"","url":"https://api.github.com/users/scottgonzalez","html_url":"https://github.com/scottgonzalez","followers_url":"https://api.github.com/users/scottgonzalez/followers","following_url":"https://api.github.com/users/scottgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/scottgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/scottgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottgonzalez/subscriptions","organizations_url":"https://api.github.com/users/scottgonzalez/orgs","repos_url":"https://api.github.com/users/scottgonzalez/repos","events_url":"https://api.github.com/users/scottgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/scottgonzalez/received_events","type":"User","site_admin":false},"body":"Still using multiple references to `element.children()` instead of using a var like the previous test.","created_at":"2015-03-02T19:13:38Z","updated_at":"2015-03-02T19:13:38Z","html_url":"https://github.com/jquery/jquery-ui/pull/1411#discussion_r25627794","pull_request_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments/25627794"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1411#discussion_r25627794"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411","id":26746807,"html_url":"https://github.com/jquery/jquery-ui/pull/1411","diff_url":"https://github.com/jquery/jquery-ui/pull/1411.diff","patch_url":"https://github.com/jquery/jquery-ui/pull/1411.patch","issue_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1411","number":1411,"state":"open","locked":false,"title":"Classes","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"body":"This addes a new built in option to the widget factory classes which maps structural classes to theme classes. To make this possible it introduces three new documented widget methods _addClass, _removeClass, and _toggleClass.\r\n\r\n- [x] Droppable - switch `activeClass` and `hoverClass` to use classes instead\r\n- [x] Resizable  - Switch `ghost` option to use classes instead\r\n- [ ] Should resizable have an `icon` option? https://github.com/arschmitz/jquery-ui/commit/f0d86013ee7582f5cfd852e8f45c11a3c784306b#commitcomment-9961378","created_at":"2015-01-01T21:50:00Z","updated_at":"2015-03-02T19:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70046e3d3cd5a06871657a3d497f560cc4159935","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/issues/1411/comments","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/e36a22aab532102b391cafdf4fc3156edb80f30d","head":{"label":"arschmitz:classes","ref":"classes","sha":"e36a22aab532102b391cafdf4fc3156edb80f30d","user":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"repo":{"id":4218107,"name":"jquery-ui","full_name":"arschmitz/jquery-ui","owner":{"login":"arschmitz","id":462993,"avatar_url":"https://avatars.githubusercontent.com/u/462993?v=3","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschmitz/jquery-ui","description":"The official jQuery user interface library.","fork":true,"url":"https://api.github.com/repos/arschmitz/jquery-ui","forks_url":"https://api.github.com/repos/arschmitz/jquery-ui/forks","keys_url":"https://api.github.com/repos/arschmitz/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschmitz/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschmitz/jquery-ui/teams","hooks_url":"https://api.github.com/repos/arschmitz/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/arschmitz/jquery-ui/events","assignees_url":"https://api.github.com/repos/arschmitz/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/arschmitz/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/arschmitz/jquery-ui/tags","blobs_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschmitz/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/arschmitz/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/arschmitz/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/arschmitz/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/arschmitz/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/arschmitz/jquery-ui/subscription","commits_url":"https://api.github.com/repos/arschmitz/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschmitz/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschmitz/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschmitz/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/arschmitz/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschmitz/jquery-ui/merges","archive_url":"https://api.github.com/repos/arschmitz/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschmitz/jquery-ui/downloads","issues_url":"https://api.github.com/repos/arschmitz/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/arschmitz/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/arschmitz/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/arschmitz/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschmitz/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/arschmitz/jquery-ui/releases{/id}","created_at":"2012-05-03T19:57:50Z","updated_at":"2015-01-15T14:40:40Z","pushed_at":"2015-02-27T23:11:49Z","git_url":"git://github.com/arschmitz/jquery-ui.git","ssh_url":"git@github.com:arschmitz/jquery-ui.git","clone_url":"https://github.com/arschmitz/jquery-ui.git","svn_url":"https://github.com/arschmitz/jquery-ui","homepage":"http://jqueryui.com/","size":25544,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"c077e0a347826c7acca4ca2f775ca59e3b5f8d07","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":478996,"name":"jquery-ui","full_name":"jquery/jquery-ui","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars.githubusercontent.com/u/70142?v=3","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery-ui","description":"The official jQuery user interface library.","fork":false,"url":"https://api.github.com/repos/jquery/jquery-ui","forks_url":"https://api.github.com/repos/jquery/jquery-ui/forks","keys_url":"https://api.github.com/repos/jquery/jquery-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery-ui/teams","hooks_url":"https://api.github.com/repos/jquery/jquery-ui/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery-ui/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery-ui/events","assignees_url":"https://api.github.com/repos/jquery/jquery-ui/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery-ui/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery-ui/tags","blobs_url":"https://api.github.com/repos/jquery/jquery-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery-ui/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery-ui/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery-ui/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery-ui/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery-ui/subscription","commits_url":"https://api.github.com/repos/jquery/jquery-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery-ui/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery-ui/merges","archive_url":"https://api.github.com/repos/jquery/jquery-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery-ui/downloads","issues_url":"https://api.github.com/repos/jquery/jquery-ui/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery-ui/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery-ui/releases{/id}","created_at":"2010-01-19T14:40:34Z","updated_at":"2015-03-02T07:47:30Z","pushed_at":"2015-02-27T14:11:08Z","git_url":"git://github.com/jquery/jquery-ui.git","ssh_url":"git@github.com:jquery/jquery-ui.git","clone_url":"https://github.com/jquery/jquery-ui.git","svn_url":"https://github.com/jquery/jquery-ui","homepage":"http://jqueryui.com/","size":47126,"stargazers_count":8758,"watchers_count":8758,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3360,"mirror_url":null,"open_issues_count":19,"forks":3360,"open_issues":19,"watchers":8758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411"},"html":{"href":"https://github.com/jquery/jquery-ui/pull/1411"},"issue":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1411"},"comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery-ui/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery-ui/statuses/e36a22aab532102b391cafdf4fc3156edb80f30d"}}}}