{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/37701136","id":37701136,"diff_hunk":"@@ -841,6 +856,45 @@ func evalFuncExpr(expr *FuncExpr) (Datum, error) {\n }\n \n func evalCaseExpr(expr *CaseExpr) (Datum, error) {\n+\twhenVals := make([]Datum, 0, len(expr.Whens))\n+\tvar condType, valType reflect.Type\n+\tfor _, when := range expr.Whens {\n+\t\tcond, err := EvalExpr(when.Cond)\n+\t\tif err != nil {\n+\t\t\treturn DNull, err\n+\t\t}\n+\t\tif condType == nil {\n+\t\t\tcondType = reflect.TypeOf(cond)\n+\t\t} else if cond != DNull && reflect.TypeOf(cond) != condType {\n+\t\t\treturn DNull, fmt.Errorf(\"incompatible condition type %s\", cond.Type())\n+\t\t}\n+\n+\t\tval, err := EvalExpr(when.Val)\n+\t\tif err != nil {\n+\t\t\treturn DNull, err\n+\t\t}\n+\n+\t\tif valType == nil {\n+\t\t\tvalType = reflect.TypeOf(val)\n+\t\t} else if val != DNull && reflect.TypeOf(val) != valType {\n+\t\t\treturn DNull, fmt.Errorf(\"incompatible value type %s\", val.Type())\n+\t\t}\n+\n+\t\twhenVals = append(whenVals, val)\n+\t}\n+\n+\tvar elseVal Datum\n+\tif expr.Else != nil {\n+\t\tval, err := EvalExpr(expr.Else)\n+\t\tif err != nil {\n+\t\t\treturn DNull, err\n+\t\t}\n+\t\tif val != DNull && reflect.TypeOf(val) != valType {\n+\t\t\treturn DNull, fmt.Errorf(\"incompatible value type %s\", val.Type())\n+\t\t}\n+\t\telseVal = val\n+\t}","path":"sql/parser/eval.go","position":121,"original_position":131,"commit_id":"9c144708c29960f419357477fdd2586e39eef5f1","original_commit_id":"111891558afdee9296d08448c53d3cc09f63bf13","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"So I added the test case `SELECT ... WHERE CASE WHEN x <> 0 THEN y/x > 1.5 ELSE false END`, and it seems to work, which is the case because EvalExpr isn't substituting the column values. I'm not sure I understand the `NormalizeExpr` suggestion since that returns an `Expr` and we need a `Datum`.","created_at":"2015-08-23T00:19:09Z","updated_at":"2015-08-23T00:19:09Z","html_url":"https://github.com/cockroachdb/cockroach/pull/2208#discussion_r37701136","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/37701136"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/2208#discussion_r37701136"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208","id":43084320,"html_url":"https://github.com/cockroachdb/cockroach/pull/2208","diff_url":"https://github.com/cockroachdb/cockroach/pull/2208.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/2208.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2208","number":2208,"state":"open","locked":false,"title":"sql: Fix bug in `DBool.Compare`","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"Stolen from #2201.","created_at":"2015-08-21T21:45:45Z","updated_at":"2015-08-23T00:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6106acf2491b5569b6a5a66a4920edd5c7f20600","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2208/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9c144708c29960f419357477fdd2586e39eef5f1","head":{"label":"tamird:sql-bool-compare","ref":"sql-bool-compare","sha":"9c144708c29960f419357477fdd2586e39eef5f1","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":35114205,"name":"cockroach","full_name":"tamird/cockroach","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/tamird/cockroach","forks_url":"https://api.github.com/repos/tamird/cockroach/forks","keys_url":"https://api.github.com/repos/tamird/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/cockroach/teams","hooks_url":"https://api.github.com/repos/tamird/cockroach/hooks","issue_events_url":"https://api.github.com/repos/tamird/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/cockroach/events","assignees_url":"https://api.github.com/repos/tamird/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/cockroach/tags","blobs_url":"https://api.github.com/repos/tamird/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/cockroach/languages","stargazers_url":"https://api.github.com/repos/tamird/cockroach/stargazers","contributors_url":"https://api.github.com/repos/tamird/cockroach/contributors","subscribers_url":"https://api.github.com/repos/tamird/cockroach/subscribers","subscription_url":"https://api.github.com/repos/tamird/cockroach/subscription","commits_url":"https://api.github.com/repos/tamird/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/cockroach/merges","archive_url":"https://api.github.com/repos/tamird/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/cockroach/downloads","issues_url":"https://api.github.com/repos/tamird/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/tamird/cockroach/releases{/id}","created_at":"2015-05-05T17:34:04Z","updated_at":"2015-05-06T22:06:29Z","pushed_at":"2015-08-23T00:17:39Z","git_url":"git://github.com/tamird/cockroach.git","ssh_url":"git@github.com:tamird/cockroach.git","clone_url":"https://github.com/tamird/cockroach.git","svn_url":"https://github.com/tamird/cockroach","homepage":null,"size":28872,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"3184f2ee529ac84986b7b9f1c71e892153daa474","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","created_at":"2014-02-06T00:18:47Z","updated_at":"2015-08-22T20:06:13Z","pushed_at":"2015-08-23T00:17:40Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":null,"size":49972,"stargazers_count":5031,"watchers_count":5031,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":398,"mirror_url":null,"open_issues_count":158,"forks":398,"open_issues":158,"watchers":5031,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/2208"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/2208"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/2208/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2208/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9c144708c29960f419357477fdd2586e39eef5f1"}}}}