{"push_id":878153773,"size":63,"distinct_size":4,"ref":"refs/heads/viewmanager","head":"de845d9909fcbbddd232ea5350acd86bd51604f8","before":"d9138bfc9ce2582c1ac04b8844fe41fb221371fd","commits":[{"sha":"8c4f9ca07210e571d6646526e9a252a98b6c9d8d","author":{"email":"15e1c65842105c4d2dfe98f16ead5bdbe966f3ab@lge.com","name":"Gray Norton"},"message":"ENYO-2533: Move deferred reset & refresh logic to VDR\n\nNewDataList has some logic to defer refreshing and resetting when\nthe list is not showing.\n\nThis logic would apply equally to VirtualDataRepeater, so we'll\nmove it there.\n\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/8c4f9ca07210e571d6646526e9a252a98b6c9d8d"},{"sha":"f7a5f83edaf552bfb13f0fb73317222fe501ccd4","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2698: Account for popQueueCount when clearing history\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/f7a5f83edaf552bfb13f0fb73317222fe501ccd4"},{"sha":"c09b4c1f9af9b15ce44990f142668b497292b733","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2689: Clear queue and history instead of adding pop into the queue\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/c09b4c1f9af9b15ce44990f142668b497292b733"},{"sha":"e571c3ac838b973bd8a5d80b8448b7168f1a3799","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2689: Ensure queue and history arrays clears object references while clearing","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/e571c3ac838b973bd8a5d80b8448b7168f1a3799"},{"sha":"7b738e96920b2dda961de711f295efec41491b9a","author":{"email":"ff3a2ea19d282d5f9f33383556fc8b8a43c05bf0@pre101.com","name":"Roy Sutton"},"message":"Merge pull request #1308 from enyojs/ENYO-2689-stephen\n\nENYO-2698: Reset queue and history instead of enqueueing drop when clearing history","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/7b738e96920b2dda961de711f295efec41491b9a"},{"sha":"a78079840d0b99493722310d9288dc30ac74c354","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2697: Stop job when clearing to ensure drop handlePop does not get executed\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/a78079840d0b99493722310d9288dc30ac74c354"},{"sha":"4448b8d77d195229f3f6f5c67bbed778dc39b293","author":{"email":"15e1c65842105c4d2dfe98f16ead5bdbe966f3ab@lge.com","name":"Gray Norton"},"message":"Revert \"ENYO-2644: Override scrollToControl() in enyo/NewDataList\"\n\nThis reverts commit 37b81a69844807ba5ed16f81b7797ae16dadf8a9.\n\nThe original fix for ENYO-2644, which we're reverting here, didn't\nreally address the issue. It made the symptoms disappear, but\nnot in the way originally intended because the issue wasn't\nproperly diagnosed. It also introduced some new issues because\nit unintentionally skipped some logic related to scrolling options.\n\nThere were actually some performance- and customization-related\nbenefits to the change, so we'll likely want to reintroduce a\nversion of it at some point in the future, but we'll simply revert\nit for now since we are at a point in the release cycle where we\nneed to minimize risk of regressions.\n\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/4448b8d77d195229f3f6f5c67bbed778dc39b293"},{"sha":"ee42cfbe8ae1d98788dd0b953f0065eff8dfb1a9","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2697: Refactor enabledChanged with clear\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/ee42cfbe8ae1d98788dd0b953f0065eff8dfb1a9"},{"sha":"63ee03afdfd570c32c7829c917b5cd51c662c7ec","author":{"email":"15e1c65842105c4d2dfe98f16ead5bdbe966f3ab@lge.com","name":"Gray Norton"},"message":"ENYO-2644: Scrollable: Snap to boundaries\n\nOften, if you're scrolling to a target near the edge of a\nscrollable region, it makes sense to scroll all the way to\nthe edge.\n\nTo support this use case, we add an (experimental, for now)\noption called `boundarySnapThreshold` to ScrollMath.\n\nAt the same time, we do a bit of minor code cleanup on another\nexperimental feature of a similar nature (which supports snapping\nto the boundaries of items within the scrollable region in the\nspecific case where the items are evenly sized and spaced). Due\nto time constraints and the fact that these features are not\nready for wide use, leaving docs as a TODO for the moment.\n\nThis change was precipitated by an issue filed against Moonstone,\nwhere 5-way scrolling to the first / last item in a list was not\nscrolling all the way to the scroller boundary; as a result, the\nup / down arrows in the scroll controls were not being disabled,\nmaking it unclear that the end of the list had been reached.\n\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/63ee03afdfd570c32c7829c917b5cd51c662c7ec"},{"sha":"b37ecc4b2dacd77b28e5bf621b93d7add2f01c06","author":{"email":"15e1c65842105c4d2dfe98f16ead5bdbe966f3ab@lge.com","name":"Gray Norton"},"message":"ENYO-2669: VDR: Fix issue with child index\n\nOur old logic for updating `childrenByIndex` worked in most cases,\nbut wasn't bullet-proof. In particular, it didn't do well in cases\nwhere the indices of existing children changed in \"irregular\" ways.\n\nThe issue that exposed the problem was one in which a filter was\napplied to the underlying collection, causing a potentially random\nset of items to \"disappear\" and the indices of remaining items to\nchange, but similar problems could also have occurred when\nnon-contiguous items were added or removed, or when items were\nreordered. The new logic should work in all such cases.\n\nAlso did some minor cleanup and added some inline comments\ndescribing the logic in the infamous `doIt()` method.\n\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/b37ecc4b2dacd77b28e5bf621b93d7add2f01c06"},{"sha":"14fe0017b3cf20ee87077a727af251f1489f2e0e","author":{"email":"e48e19387019f32665951652750116e856c94378@gmail.com","name":"Cole Davis"},"message":"Merge pull request #1311 from enyojs/ENYO-2644-b-graynorton\n\nENYO-2644: Revert flawed initial fix, try another approach\r\n\r\nReviewed-By: Ryan Duffy (ryan.duffy@lge.com)\r\nIntegrated-By: Cole Davis (cole.davis@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/14fe0017b3cf20ee87077a727af251f1489f2e0e"},{"sha":"04a052ffb16469e0f4502dd5003798ada4abd613","author":{"email":"e48e19387019f32665951652750116e856c94378@gmail.com","name":"Cole Davis"},"message":"Merge pull request #1312 from enyojs/ENYO-2669-graynorton\n\nENYO-2669: VDR: Fix issue with child index\r\n\r\nReviewed-By: Derek Anderson (derek.anderson@lge.com)\r\nIntegrated-By: Cole Davis (cole.davis@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/04a052ffb16469e0f4502dd5003798ada4abd613"},{"sha":"5f5c2187aff5828975c29fd0125471e57482e6fc","author":{"email":"ea3cd978650417470535f3a4725b6b5042a6ab59@tiqtech.com","name":"Ryan Duffy"},"message":"Merge pull request #1310 from enyojs/ENYO-2697-stephen\n\nENYO-2697: Stop job when clearing to ensure drop handlePop does not g…\r\n\r\nReviewed-By: Derek Anderson (derek.anderson@lge.com)\r\nIntegrated-By: Ryan Duffy (ryan.duffy@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/5f5c2187aff5828975c29fd0125471e57482e6fc"},{"sha":"9d2517380211259aae24705de0422ad64340ca71","author":{"email":"318566004e1e3380f40695100406cfc5605f1e58@lge.com","name":"Jim Tang"},"message":"JSDoc cleanup\nEnyo-DCO-1.1-Signed-Off-By: Jim Tang (jim.tang@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/9d2517380211259aae24705de0422ad64340ca71"},{"sha":"704eb8745f7f312947d84450c2e8094d769ce698","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2541: Change function from popPanel to removePanel for LightPanels.replaceAt()\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/704eb8745f7f312947d84450c2e8094d769ce698"},{"sha":"b4db2819592f1fcb3bc2656241ea51e30bca5efa","author":{"email":"61e2f51ca8bab57ee8ea8bf4e59be45caf1b4dd9@stanfordalumni.org","name":"graynorton"},"message":"Merge pull request #1313 from enyojs/ENYO-2705-stephen\n\nENYO-2705: Change function from popPanel to removePanel for LightPane…\r\n\r\nReviewed-By: Derek Anderson (derek.anderson@lge.com) \r\nIntegrated-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/b4db2819592f1fcb3bc2656241ea51e30bca5efa"},{"sha":"be8975fd01c591662ec8d86f62b4664b20c62ba2","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@gecko.palm.com","name":"Jenkins"},"message":"Update version string to 2.6.0-pre.18.1","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/be8975fd01c591662ec8d86f62b4664b20c62ba2"},{"sha":"95dd0bc2cd690ffa37d6485b5fd9f4aba523774d","author":{"email":"318566004e1e3380f40695100406cfc5605f1e58@lge.com","name":"Jim Tang"},"message":"JSDoc cleanup\nEnyo-DCO-1.1-Signed-Off-By: Jim Tang (jim.tang@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/95dd0bc2cd690ffa37d6485b5fd9f4aba523774d"},{"sha":"302b81f81dff56a7f2d6097e18c85b3401f3b4c9","author":{"email":"6004103f6672b6ff145040c775024f35d6d44864@lge.com","name":"Stephen Choi"},"message":"ENYO-2719: Remove panel in reverse order\nEnyo-DCO-1.1-Signed-off-by: Stephen Choi <stephen.choi@lge.com>","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/302b81f81dff56a7f2d6097e18c85b3401f3b4c9"},{"sha":"327fdef89eb6c5a6f57aafc5df32a45cf7417ecc","author":{"email":"15e1c65842105c4d2dfe98f16ead5bdbe966f3ab@lge.com","name":"Gray Norton"},"message":"ENYO-2696: Restore async to VirtualDataRepeater.refresh()\n\nIn the original fix for ENYO-2514, we modified VDR.refresh() to\nmake it work synchronously, as the historical reasons for making it\nasync (inherited from DataRepeater) seemed not to apply, and the\nasync behavior was causing a problem in one case: when the refresh\nwas deferred because the repeater was hidden, the \"stale\" state of\nthe repeater would flash momentarily on screen after the repeater\nwas re-shown but before the refresh occurred.\n\nMaking refresh() synchronous fixed that case, but it appears that\nthere are still some cases where async refresh has significant perf\nbenefits, so in this change we're restoring the async behavior and\ntaking a different approach to fixing ENYO-2514.\n\nThe new issue (ENYO-2696) that prompted the change back to async\nwas one in which the collection underlying the repeater was emptied\nand immediately repopulated. In this case, the async approach\nresults in debouncing the refresh; it only refreshes once, after\nrepopulating, rather than once after emptying and again after\nrepopulating.\n\nTo solve the flashing-stale-content issue, we now use the CSS\nvisibility property to make the repeater invisible while it's in\nthe process of performing a deferred refresh.\n\nWhile making this change, also did some cleanup and added some\ninline comments.\n\nFinally, note that the logic for deferring refresh() and reset()\noriginally lived in NewDataList, not in VirtualDataRepeater. In\nthe process of reviewing and integrating the original fix for\nENYO-2514, we determined that it made sense to move it into VDR\nand wrote up a new issue (ENYO-2533) to track that work. Since\nwe're back in the same code now, we're making that change, too.\n\nEnyo-DCO-1.1-Signed-Off-By: Gray Norton (gray.norton@lge.com)","distinct":false,"url":"https://api.github.com/repos/PKRoma/enyo/commits/327fdef89eb6c5a6f57aafc5df32a45cf7417ecc"}]}