{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/2344","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/2344/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2344/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/2344/events","html_url":"https://github.com/dotnet/corefx/pull/2344","id":94825528,"number":2344,"title":"Replace all non-test uses of new T[0] with Array.Empty<T>","user":{"login":"James-Ko","id":9159214,"avatar_url":"https://avatars.githubusercontent.com/u/9159214?v=3","gravatar_id":"","url":"https://api.github.com/users/James-Ko","html_url":"https://github.com/James-Ko","followers_url":"https://api.github.com/users/James-Ko/followers","following_url":"https://api.github.com/users/James-Ko/following{/other_user}","gists_url":"https://api.github.com/users/James-Ko/gists{/gist_id}","starred_url":"https://api.github.com/users/James-Ko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/James-Ko/subscriptions","organizations_url":"https://api.github.com/users/James-Ko/orgs","repos_url":"https://api.github.com/users/James-Ko/repos","events_url":"https://api.github.com/users/James-Ko/events{/privacy}","received_events_url":"https://api.github.com/users/James-Ko/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-07-13T22:23:45Z","updated_at":"2015-07-16T00:12:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2344","html_url":"https://github.com/dotnet/corefx/pull/2344","diff_url":"https://github.com/dotnet/corefx/pull/2344.diff","patch_url":"https://github.com/dotnet/corefx/pull/2344.patch"},"body":"I ran a little shell command to find and replace most of the occurrences of `new T[0]` in the repo:\r\n\r\n    cd corefx\r\n    grep -rl \"new [^ (]*\\[0\\]\" . | grep -vi test | xargs start notepad++\r\n\r\nThere were about 18 matches, with an additional match I spotted in `Queue<T>.ToArray`.\r\n\r\nAdditional notes:\r\n\r\n - Removed caching of `EmptySequence` in `XElement` and `XAttribute`; this is already done by `Array.Empty`.\r\n - The build should fail at first because I forgot to add `using` statements to the classes I changed. Will fix once the compiler tells where it can't recognize `Array`."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/121784720","html_url":"https://github.com/dotnet/corefx/pull/2344#issuecomment-121784720","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2344","id":121784720,"user":{"login":"mmitche","id":8725170,"avatar_url":"https://avatars.githubusercontent.com/u/8725170?v=3","gravatar_id":"","url":"https://api.github.com/users/mmitche","html_url":"https://github.com/mmitche","followers_url":"https://api.github.com/users/mmitche/followers","following_url":"https://api.github.com/users/mmitche/following{/other_user}","gists_url":"https://api.github.com/users/mmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/mmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmitche/subscriptions","organizations_url":"https://api.github.com/users/mmitche/orgs","repos_url":"https://api.github.com/users/mmitche/repos","events_url":"https://api.github.com/users/mmitche/events{/privacy}","received_events_url":"https://api.github.com/users/mmitche/received_events","type":"User","site_admin":false},"created_at":"2015-07-16T00:12:06Z","updated_at":"2015-07-16T00:12:06Z","body":"This looks like maybe a change got merged in that accidentally enabled etw tests on Linux?  It doesn't makes sense to run them there anyway."}}