{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/36971181","id":36971181,"diff_hunk":"@@ -489,6 +491,7 @@ func TestValidateVolumes(t *testing.T) {\n \t\t\"empty path\":           {[]api.Volume{{Name: \"badpath\", VolumeSource: emptyPath}}, errors.ValidationErrorTypeRequired, \"[0].source.glusterfs.path\"},\n \t\t\"empty mon\":            {[]api.Volume{{Name: \"badmon\", VolumeSource: emptyMon}}, errors.ValidationErrorTypeRequired, \"[0].source.rbd.monitors\"},\n \t\t\"empty image\":          {[]api.Volume{{Name: \"badimage\", VolumeSource: emptyImage}}, errors.ValidationErrorTypeRequired, \"[0].source.rbd.image\"},\n+\t\t\"empty wwn\":            {[]api.Volume{{Name: \"badimage\", VolumeSource: zeroWWN}}, errors.ValidationErrorTypeRequired, \"[0].source.fc.targetWWNs\"},","path":"pkg/api/validation/validation_test.go","position":20,"original_position":20,"commit_id":"d1cd105756177e6090cb28ef9e4d9eb283658d82","original_commit_id":"d1cd105756177e6090cb28ef9e4d9eb283658d82","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"body":"Test for the other 2 required fields, also?","created_at":"2015-08-13T13:05:16Z","updated_at":"2015-08-13T13:05:16Z","html_url":"https://github.com/kubernetes/kubernetes/pull/12599#discussion_r36971181","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/36971181"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12599#discussion_r36971181"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599","id":42276876,"html_url":"https://github.com/kubernetes/kubernetes/pull/12599","diff_url":"https://github.com/kubernetes/kubernetes/pull/12599.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/12599.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12599","number":12599,"state":"open","locked":false,"title":"support fibre channel volume","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"Enable Fibre Channel block storage.\r\n\r\n@thockin @smarterclayton @markturansky @childsb","created_at":"2015-08-12T19:12:38Z","updated_at":"2015-08-13T13:05:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ccef3304e88869ad3aa40d9c8b1ed4a5100034","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/12599/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d1cd105756177e6090cb28ef9e4d9eb283658d82","head":{"label":"rootfs:fc_volume","ref":"fc_volume","sha":"d1cd105756177e6090cb28ef9e4d9eb283658d82","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"repo":{"id":29694119,"name":"kubernetes","full_name":"rootfs/kubernetes","owner":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rootfs/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/rootfs/kubernetes","forks_url":"https://api.github.com/repos/rootfs/kubernetes/forks","keys_url":"https://api.github.com/repos/rootfs/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rootfs/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rootfs/kubernetes/teams","hooks_url":"https://api.github.com/repos/rootfs/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rootfs/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rootfs/kubernetes/events","assignees_url":"https://api.github.com/repos/rootfs/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rootfs/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rootfs/kubernetes/tags","blobs_url":"https://api.github.com/repos/rootfs/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rootfs/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rootfs/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rootfs/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rootfs/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rootfs/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rootfs/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rootfs/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rootfs/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rootfs/kubernetes/subscription","commits_url":"https://api.github.com/repos/rootfs/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rootfs/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rootfs/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rootfs/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rootfs/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rootfs/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rootfs/kubernetes/merges","archive_url":"https://api.github.com/repos/rootfs/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rootfs/kubernetes/downloads","issues_url":"https://api.github.com/repos/rootfs/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rootfs/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rootfs/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rootfs/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rootfs/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rootfs/kubernetes/releases{/id}","created_at":"2015-01-22T18:48:37Z","updated_at":"2015-08-11T15:37:33Z","pushed_at":"2015-08-12T20:00:27Z","git_url":"git://github.com/rootfs/kubernetes.git","ssh_url":"git@github.com:rootfs/kubernetes.git","clone_url":"https://github.com/rootfs/kubernetes.git","svn_url":"https://github.com/rootfs/kubernetes","homepage":"http://kubernetes.io","size":99755,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5c08d276a082690567ab7902fb9eb752477a14f2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-08-13T12:57:38Z","pushed_at":"2015-08-13T13:03:37Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":345507,"stargazers_count":9678,"watchers_count":9678,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2317,"mirror_url":null,"open_issues_count":1737,"forks":2317,"open_issues":1737,"watchers":9678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/12599"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12599"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/12599/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/12599/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/d1cd105756177e6090cb28ef9e4d9eb283658d82"}}}}