{"action":"created","issue":{"url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/143","labels_url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/143/comments","events_url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/143/events","html_url":"https://github.com/beberlei/DoctrineExtensions/pull/143","id":64573851,"number":143,"title":"Added SQL_CALC_FOUND_ROWS to MysqlWalker","user":{"login":"federicojasson","id":3299231,"avatar_url":"https://avatars.githubusercontent.com/u/3299231?v=3","gravatar_id":"","url":"https://api.github.com/users/federicojasson","html_url":"https://github.com/federicojasson","followers_url":"https://api.github.com/users/federicojasson/followers","following_url":"https://api.github.com/users/federicojasson/following{/other_user}","gists_url":"https://api.github.com/users/federicojasson/gists{/gist_id}","starred_url":"https://api.github.com/users/federicojasson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federicojasson/subscriptions","organizations_url":"https://api.github.com/users/federicojasson/orgs","repos_url":"https://api.github.com/users/federicojasson/repos","events_url":"https://api.github.com/users/federicojasson/events{/privacy}","received_events_url":"https://api.github.com/users/federicojasson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-26T16:30:47Z","updated_at":"2015-04-08T18:30:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/beberlei/DoctrineExtensions/pulls/143","html_url":"https://github.com/beberlei/DoctrineExtensions/pull/143","diff_url":"https://github.com/beberlei/DoctrineExtensions/pull/143.diff","patch_url":"https://github.com/beberlei/DoctrineExtensions/pull/143.patch"},"body":"I added a functionality to MysqlWalker to allow the use of the SQL_CALC_FOUND_ROWS modifier in SELECT statements. It checks whether the hint mysqlWalker.sqlCalcFoundRows is set.\r\n\r\nI also removed the isDistinct check. Correct me if I'm wrong, but I think it's unnecessary.\r\n\r\nWhen the three modifiers are set, the resulting SELECT statement is as follows:\r\n\"SELECT SQL_NO_CACHE SQL_CALC_FOUND_ROWS DISTINCT ...\""},"comment":{"url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/comments/90996523","html_url":"https://github.com/beberlei/DoctrineExtensions/pull/143#issuecomment-90996523","issue_url":"https://api.github.com/repos/beberlei/DoctrineExtensions/issues/143","id":90996523,"user":{"login":"federicojasson","id":3299231,"avatar_url":"https://avatars.githubusercontent.com/u/3299231?v=3","gravatar_id":"","url":"https://api.github.com/users/federicojasson","html_url":"https://github.com/federicojasson","followers_url":"https://api.github.com/users/federicojasson/followers","following_url":"https://api.github.com/users/federicojasson/following{/other_user}","gists_url":"https://api.github.com/users/federicojasson/gists{/gist_id}","starred_url":"https://api.github.com/users/federicojasson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/federicojasson/subscriptions","organizations_url":"https://api.github.com/users/federicojasson/orgs","repos_url":"https://api.github.com/users/federicojasson/repos","events_url":"https://api.github.com/users/federicojasson/events{/privacy}","received_events_url":"https://api.github.com/users/federicojasson/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T18:30:23Z","updated_at":"2015-04-08T18:30:23Z","body":"Ok, the indentation has been fixed.\r\nAbout the tests, I see that there are currently no tests for the MysqlWalker class. I'm not very familiar with tests, so it might be better if someone else writes them."}}