{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/24097095","id":24097095,"diff_hunk":"@@ -1,11 +1,178 @@\n import FWCore.ParameterSet.Config as cms\n \n+#temporarily load regression weights with esprefer\n+from CondCore.DBCommon.CondDBCommon_cfi import *\n+\n+pfcluscorsource = cms.ESSource(\"PoolDBESSource\",\n+    CondDBCommon,\n+    DumpStat=cms.untracked.bool(False),\n+    toGet = cms.VPSet(\n+      cms.PSet(\n+        record = cms.string('GBRDWrapperRcd'),\n+        label = cms.untracked.string('GBRForestD_ecalPFClusterCor_EB_pfSize1_mean_50ns'),\n+        tag = cms.string('GBRForestD_ecalPFClusterCor_EB_pfSize1_mean_50ns')","path":"RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECAL_cfi.py","position":13,"original_position":13,"commit_id":"ad177c6fe1d7c541578fbdb95bd7a4df2dd7b44e","original_commit_id":"ad177c6fe1d7c541578fbdb95bd7a4df2dd7b44e","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=3","gravatar_id":"","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"body":"That's right.","created_at":"2015-02-04T16:40:12Z","updated_at":"2015-02-04T16:40:12Z","html_url":"https://github.com/cms-sw/cmssw/pull/7558#discussion_r24097095","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/24097095"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/7558#discussion_r24097095"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558","id":28648840,"html_url":"https://github.com/cms-sw/cmssw/pull/7558","diff_url":"https://github.com/cms-sw/cmssw/pull/7558.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/7558.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7558","number":7558,"state":"open","locked":false,"title":"Ecal PFCluster corrections (74x)","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=3","gravatar_id":"","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"body":"Adapt PFCluster energy correction code to use new regression weights in the conditions database (current implementation is using ESPrefer until this is available in a GT)\r\n\r\nThe PFAlgo also needed to be modified since it was still using hardcoded inlined corrections (taking the old corrections) instead of taking the corrected energy filled by the more modular correction scheme which @lgray added a while back.\r\n\r\nThe DataFormat change to CaloCluster adds just an additional float to store the uncertainty associated with the corrected energy (which is a new feature of the regression-based corrections which is not currently used anywhere, but intended to be used as input to the higher level electron and photon corrections)\r\n\r\nTwo caveats:\r\n1) The dataformat change introduces some potential issues with checksum and class version divergences and incompatibility once we try to backport this to 73x.  See https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3433/1.html\r\n\r\n2) I am still running some internal closure tests against the standalone validation code for the regression training (to make sure there are no trivial mistakes like variables being defined in a way which doesn't match the training, or passed in the wrong order to the BDT's in the CMSSW class).  Assuming that these checks will be positive, physics checks of this pull request can already start in principle.  (but would maybe hold off merging it until the outcome of those tests is confirmed)","created_at":"2015-02-04T15:51:26Z","updated_at":"2015-02-04T16:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff61de20d80dde359e8bc1e2fbc06f043d5c2749","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/50/labels","id":875803,"number":50,"title":"Next CMSSW_7_4_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":554,"state":"open","created_at":"2014-11-21T15:23:58Z","updated_at":"2015-02-04T16:24:34Z","due_on":"2015-01-26T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/7558/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/ad177c6fe1d7c541578fbdb95bd7a4df2dd7b44e","head":{"label":"bendavid:ecalpfcluscorfull_74x","ref":"ecalpfcluscorfull_74x","sha":"ad177c6fe1d7c541578fbdb95bd7a4df2dd7b44e","user":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=3","gravatar_id":"","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"repo":{"id":11927470,"name":"cmssw","full_name":"bendavid/cmssw","owner":{"login":"bendavid","id":4920798,"avatar_url":"https://avatars.githubusercontent.com/u/4920798?v=3","gravatar_id":"","url":"https://api.github.com/users/bendavid","html_url":"https://github.com/bendavid","followers_url":"https://api.github.com/users/bendavid/followers","following_url":"https://api.github.com/users/bendavid/following{/other_user}","gists_url":"https://api.github.com/users/bendavid/gists{/gist_id}","starred_url":"https://api.github.com/users/bendavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendavid/subscriptions","organizations_url":"https://api.github.com/users/bendavid/orgs","repos_url":"https://api.github.com/users/bendavid/repos","events_url":"https://api.github.com/users/bendavid/events{/privacy}","received_events_url":"https://api.github.com/users/bendavid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bendavid/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/bendavid/cmssw","forks_url":"https://api.github.com/repos/bendavid/cmssw/forks","keys_url":"https://api.github.com/repos/bendavid/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendavid/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendavid/cmssw/teams","hooks_url":"https://api.github.com/repos/bendavid/cmssw/hooks","issue_events_url":"https://api.github.com/repos/bendavid/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/bendavid/cmssw/events","assignees_url":"https://api.github.com/repos/bendavid/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/bendavid/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/bendavid/cmssw/tags","blobs_url":"https://api.github.com/repos/bendavid/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendavid/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendavid/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendavid/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendavid/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/bendavid/cmssw/languages","stargazers_url":"https://api.github.com/repos/bendavid/cmssw/stargazers","contributors_url":"https://api.github.com/repos/bendavid/cmssw/contributors","subscribers_url":"https://api.github.com/repos/bendavid/cmssw/subscribers","subscription_url":"https://api.github.com/repos/bendavid/cmssw/subscription","commits_url":"https://api.github.com/repos/bendavid/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendavid/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendavid/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendavid/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/bendavid/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/bendavid/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendavid/cmssw/merges","archive_url":"https://api.github.com/repos/bendavid/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendavid/cmssw/downloads","issues_url":"https://api.github.com/repos/bendavid/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/bendavid/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/bendavid/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/bendavid/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendavid/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/bendavid/cmssw/releases{/id}","created_at":"2013-08-06T15:27:02Z","updated_at":"2014-06-18T22:53:47Z","pushed_at":"2015-02-04T15:44:36Z","git_url":"git://github.com/bendavid/cmssw.git","ssh_url":"git@github.com:bendavid/cmssw.git","clone_url":"https://github.com/bendavid/cmssw.git","svn_url":"https://github.com/bendavid/cmssw","homepage":"cms-sw.github.io/cmssw","size":617155,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_4_X","ref":"CMSSW_7_4_X","sha":"29298c7d095e40da13fe173f07d1733db5db6961","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/{number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-02-04T14:47:47Z","pushed_at":"2015-02-04T16:01:19Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":787189,"stargazers_count":201,"watchers_count":201,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1239,"mirror_url":null,"open_issues_count":111,"forks":1239,"open_issues":111,"watchers":201,"default_branch":"CMSSW_7_4_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/7558"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/7558"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/7558/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/7558/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/ad177c6fe1d7c541578fbdb95bd7a4df2dd7b44e"}}}}