{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/algebird/pulls/comments/35603760","id":35603760,"diff_hunk":"@@ -68,6 +68,21 @@ class QTreeTest extends WordSpec with Matchers {\n   def trueRangeSum(list: Seq[Double], from: Double, to: Double) =\n     list.filter{ _ >= from }.filter{ _ < to }.sum\n \n+  for (k <- Seq(3, 11, 51, 101)) {\n+    s\"QTree with elements (1 to $k)\" should {\n+      val trueMedian = (1 + k) / 2\n+      s\"have median $trueMedian\" in {\n+        implicit val sg = new QTreeSemigroup[Double](k)","path":"algebird-test/src/test/scala/com/twitter/algebird/QTreeTest.scala","position":8,"original_position":8,"commit_id":"e50179c0420041df712c356cd53df9c7d07407fe","original_commit_id":"e50179c0420041df712c356cd53df9c7d07407fe","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"body":"`QTreeSemigroup[Unit]` should work, I think, and is cheaper. People seem to be cargo-culting `QTreeSemigroup[Double]` Can we switch here?","created_at":"2015-07-28T00:28:11Z","updated_at":"2015-07-28T00:28:11Z","html_url":"https://github.com/twitter/algebird/pull/472#discussion_r35603760","pull_request_url":"https://api.github.com/repos/twitter/algebird/pulls/472","_links":{"self":{"href":"https://api.github.com/repos/twitter/algebird/pulls/comments/35603760"},"html":{"href":"https://github.com/twitter/algebird/pull/472#discussion_r35603760"},"pull_request":{"href":"https://api.github.com/repos/twitter/algebird/pulls/472"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/algebird/pulls/472","id":40963365,"html_url":"https://github.com/twitter/algebird/pull/472","diff_url":"https://github.com/twitter/algebird/pull/472.diff","patch_url":"https://github.com/twitter/algebird/pull/472.patch","issue_url":"https://api.github.com/repos/twitter/algebird/issues/472","number":472,"state":"open","locked":false,"title":"Fix Qtree quantileBounds off-by-one error","user":{"login":"sid-kap","id":6425077,"avatar_url":"https://avatars.githubusercontent.com/u/6425077?v=3","gravatar_id":"","url":"https://api.github.com/users/sid-kap","html_url":"https://github.com/sid-kap","followers_url":"https://api.github.com/users/sid-kap/followers","following_url":"https://api.github.com/users/sid-kap/following{/other_user}","gists_url":"https://api.github.com/users/sid-kap/gists{/gist_id}","starred_url":"https://api.github.com/users/sid-kap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid-kap/subscriptions","organizations_url":"https://api.github.com/users/sid-kap/orgs","repos_url":"https://api.github.com/users/sid-kap/repos","events_url":"https://api.github.com/users/sid-kap/events{/privacy}","received_events_url":"https://api.github.com/users/sid-kap/received_events","type":"User","site_admin":false},"body":"See issue #377 ","created_at":"2015-07-28T00:04:35Z","updated_at":"2015-07-28T00:28:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb13ba27f2ab8debad5917c1034029543607250","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/algebird/pulls/472/commits","review_comments_url":"https://api.github.com/repos/twitter/algebird/pulls/472/comments","review_comment_url":"https://api.github.com/repos/twitter/algebird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/algebird/issues/472/comments","statuses_url":"https://api.github.com/repos/twitter/algebird/statuses/e50179c0420041df712c356cd53df9c7d07407fe","head":{"label":"sid-kap:qtree_off_by_one","ref":"qtree_off_by_one","sha":"e50179c0420041df712c356cd53df9c7d07407fe","user":{"login":"sid-kap","id":6425077,"avatar_url":"https://avatars.githubusercontent.com/u/6425077?v=3","gravatar_id":"","url":"https://api.github.com/users/sid-kap","html_url":"https://github.com/sid-kap","followers_url":"https://api.github.com/users/sid-kap/followers","following_url":"https://api.github.com/users/sid-kap/following{/other_user}","gists_url":"https://api.github.com/users/sid-kap/gists{/gist_id}","starred_url":"https://api.github.com/users/sid-kap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid-kap/subscriptions","organizations_url":"https://api.github.com/users/sid-kap/orgs","repos_url":"https://api.github.com/users/sid-kap/repos","events_url":"https://api.github.com/users/sid-kap/events{/privacy}","received_events_url":"https://api.github.com/users/sid-kap/received_events","type":"User","site_admin":false},"repo":{"id":38075853,"name":"algebird","full_name":"sid-kap/algebird","owner":{"login":"sid-kap","id":6425077,"avatar_url":"https://avatars.githubusercontent.com/u/6425077?v=3","gravatar_id":"","url":"https://api.github.com/users/sid-kap","html_url":"https://github.com/sid-kap","followers_url":"https://api.github.com/users/sid-kap/followers","following_url":"https://api.github.com/users/sid-kap/following{/other_user}","gists_url":"https://api.github.com/users/sid-kap/gists{/gist_id}","starred_url":"https://api.github.com/users/sid-kap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid-kap/subscriptions","organizations_url":"https://api.github.com/users/sid-kap/orgs","repos_url":"https://api.github.com/users/sid-kap/repos","events_url":"https://api.github.com/users/sid-kap/events{/privacy}","received_events_url":"https://api.github.com/users/sid-kap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sid-kap/algebird","description":"Abstract Algebra for Scala","fork":true,"url":"https://api.github.com/repos/sid-kap/algebird","forks_url":"https://api.github.com/repos/sid-kap/algebird/forks","keys_url":"https://api.github.com/repos/sid-kap/algebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sid-kap/algebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sid-kap/algebird/teams","hooks_url":"https://api.github.com/repos/sid-kap/algebird/hooks","issue_events_url":"https://api.github.com/repos/sid-kap/algebird/issues/events{/number}","events_url":"https://api.github.com/repos/sid-kap/algebird/events","assignees_url":"https://api.github.com/repos/sid-kap/algebird/assignees{/user}","branches_url":"https://api.github.com/repos/sid-kap/algebird/branches{/branch}","tags_url":"https://api.github.com/repos/sid-kap/algebird/tags","blobs_url":"https://api.github.com/repos/sid-kap/algebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sid-kap/algebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sid-kap/algebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/sid-kap/algebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sid-kap/algebird/statuses/{sha}","languages_url":"https://api.github.com/repos/sid-kap/algebird/languages","stargazers_url":"https://api.github.com/repos/sid-kap/algebird/stargazers","contributors_url":"https://api.github.com/repos/sid-kap/algebird/contributors","subscribers_url":"https://api.github.com/repos/sid-kap/algebird/subscribers","subscription_url":"https://api.github.com/repos/sid-kap/algebird/subscription","commits_url":"https://api.github.com/repos/sid-kap/algebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/sid-kap/algebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/sid-kap/algebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/sid-kap/algebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/sid-kap/algebird/contents/{+path}","compare_url":"https://api.github.com/repos/sid-kap/algebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sid-kap/algebird/merges","archive_url":"https://api.github.com/repos/sid-kap/algebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sid-kap/algebird/downloads","issues_url":"https://api.github.com/repos/sid-kap/algebird/issues{/number}","pulls_url":"https://api.github.com/repos/sid-kap/algebird/pulls{/number}","milestones_url":"https://api.github.com/repos/sid-kap/algebird/milestones{/number}","notifications_url":"https://api.github.com/repos/sid-kap/algebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sid-kap/algebird/labels{/name}","releases_url":"https://api.github.com/repos/sid-kap/algebird/releases{/id}","created_at":"2015-06-25T21:42:29Z","updated_at":"2015-06-25T21:42:30Z","pushed_at":"2015-07-28T00:19:58Z","git_url":"git://github.com/sid-kap/algebird.git","ssh_url":"git@github.com:sid-kap/algebird.git","clone_url":"https://github.com/sid-kap/algebird.git","svn_url":"https://github.com/sid-kap/algebird","homepage":"https://twitter.com/scalding","size":4682,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"twitter:develop","ref":"develop","sha":"4289d7e04867d37034996714547296a1cdc5c161","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":5275507,"name":"algebird","full_name":"twitter/algebird","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/algebird","description":"Abstract Algebra for Scala","fork":false,"url":"https://api.github.com/repos/twitter/algebird","forks_url":"https://api.github.com/repos/twitter/algebird/forks","keys_url":"https://api.github.com/repos/twitter/algebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/algebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/algebird/teams","hooks_url":"https://api.github.com/repos/twitter/algebird/hooks","issue_events_url":"https://api.github.com/repos/twitter/algebird/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/algebird/events","assignees_url":"https://api.github.com/repos/twitter/algebird/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/algebird/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/algebird/tags","blobs_url":"https://api.github.com/repos/twitter/algebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/algebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/algebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/algebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/algebird/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/algebird/languages","stargazers_url":"https://api.github.com/repos/twitter/algebird/stargazers","contributors_url":"https://api.github.com/repos/twitter/algebird/contributors","subscribers_url":"https://api.github.com/repos/twitter/algebird/subscribers","subscription_url":"https://api.github.com/repos/twitter/algebird/subscription","commits_url":"https://api.github.com/repos/twitter/algebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/algebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/algebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/algebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/algebird/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/algebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/algebird/merges","archive_url":"https://api.github.com/repos/twitter/algebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/algebird/downloads","issues_url":"https://api.github.com/repos/twitter/algebird/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/algebird/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/algebird/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/algebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/algebird/labels{/name}","releases_url":"https://api.github.com/repos/twitter/algebird/releases{/id}","created_at":"2012-08-02T17:24:42Z","updated_at":"2015-07-27T21:06:46Z","pushed_at":"2015-07-28T00:19:59Z","git_url":"git://github.com/twitter/algebird.git","ssh_url":"git@github.com:twitter/algebird.git","clone_url":"https://github.com/twitter/algebird.git","svn_url":"https://github.com/twitter/algebird","homepage":"https://twitter.com/scalding","size":7837,"stargazers_count":953,"watchers_count":953,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"open_issues_count":97,"forks":177,"open_issues":97,"watchers":953,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/algebird/pulls/472"},"html":{"href":"https://github.com/twitter/algebird/pull/472"},"issue":{"href":"https://api.github.com/repos/twitter/algebird/issues/472"},"comments":{"href":"https://api.github.com/repos/twitter/algebird/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/algebird/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/algebird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/algebird/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/algebird/statuses/e50179c0420041df712c356cd53df9c7d07407fe"}}}}