{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8","id":49182086,"html_url":"https://github.com/cargomedia/cm-janus/pull/8","diff_url":"https://github.com/cargomedia/cm-janus/pull/8.diff","patch_url":"https://github.com/cargomedia/cm-janus/pull/8.patch","issue_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/8","number":8,"state":"closed","locked":false,"title":"Define message interpreters","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"body":"### Browser -> cm-janus\r\nWe should deny illegal actions/plugins.\r\nWe should instantiate handler per plugin and attach listener to specific `handleId` at that time. We should store it per connection.\r\n- `Streaming`\r\n  - `{\"request\":\"watch\"}` holds the stream id. \r\n- `AudioBridge`\r\n  - ?\r\n\r\n\r\n### Janus -> cm-janus\r\nIn particular, for each handle involving a PeerConnection Janus provides notifications about its current state. To do so, the following events may be received as well:\r\n\r\n- `webrtcup`: ICE and DTLS succeeded, and so Janus correctly established a PeerConnection with the user/application;\r\n  - trigger `onSubscribe`, `onPublish` events\r\n- `media`: whether Janus is receiving (receiving: true/false) audio/video (type: \"audio/video\") on this PeerConnection;\r\n- `hangup`: the PeerConnection was closed, either by Janus or by the user/application, and as such cannot be used anymore.\r\n  - trigger `onUnSubscribe`, `onUnPublish` events\r\n\r\nAbove events could be intercepted and its data passed to cm applications via rpc calls.\r\n","created_at":"2015-10-29T18:39:40Z","updated_at":"2015-11-03T10:30:31Z","closed_at":"2015-11-03T10:30:31Z","merged_at":null,"merge_commit_sha":"d9edb541f46c7bdfc760a8514dd9d178dcbb30b1","assignee":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8/commits","review_comments_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8/comments","review_comment_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/8/comments","statuses_url":"https://api.github.com/repos/cargomedia/cm-janus/statuses/99a31bfe253e5c46ac93c63493ebf41d04eaf194","head":{"label":"vogdb:issue-8","ref":"issue-8","sha":"99a31bfe253e5c46ac93c63493ebf41d04eaf194","user":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"repo":{"id":44749606,"name":"cm-janus","full_name":"vogdb/cm-janus","owner":{"login":"vogdb","id":372386,"avatar_url":"https://avatars.githubusercontent.com/u/372386?v=3","gravatar_id":"","url":"https://api.github.com/users/vogdb","html_url":"https://github.com/vogdb","followers_url":"https://api.github.com/users/vogdb/followers","following_url":"https://api.github.com/users/vogdb/following{/other_user}","gists_url":"https://api.github.com/users/vogdb/gists{/gist_id}","starred_url":"https://api.github.com/users/vogdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogdb/subscriptions","organizations_url":"https://api.github.com/users/vogdb/orgs","repos_url":"https://api.github.com/users/vogdb/repos","events_url":"https://api.github.com/users/vogdb/events{/privacy}","received_events_url":"https://api.github.com/users/vogdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vogdb/cm-janus","description":"cm/janus bridge","fork":true,"url":"https://api.github.com/repos/vogdb/cm-janus","forks_url":"https://api.github.com/repos/vogdb/cm-janus/forks","keys_url":"https://api.github.com/repos/vogdb/cm-janus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vogdb/cm-janus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vogdb/cm-janus/teams","hooks_url":"https://api.github.com/repos/vogdb/cm-janus/hooks","issue_events_url":"https://api.github.com/repos/vogdb/cm-janus/issues/events{/number}","events_url":"https://api.github.com/repos/vogdb/cm-janus/events","assignees_url":"https://api.github.com/repos/vogdb/cm-janus/assignees{/user}","branches_url":"https://api.github.com/repos/vogdb/cm-janus/branches{/branch}","tags_url":"https://api.github.com/repos/vogdb/cm-janus/tags","blobs_url":"https://api.github.com/repos/vogdb/cm-janus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vogdb/cm-janus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vogdb/cm-janus/git/refs{/sha}","trees_url":"https://api.github.com/repos/vogdb/cm-janus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vogdb/cm-janus/statuses/{sha}","languages_url":"https://api.github.com/repos/vogdb/cm-janus/languages","stargazers_url":"https://api.github.com/repos/vogdb/cm-janus/stargazers","contributors_url":"https://api.github.com/repos/vogdb/cm-janus/contributors","subscribers_url":"https://api.github.com/repos/vogdb/cm-janus/subscribers","subscription_url":"https://api.github.com/repos/vogdb/cm-janus/subscription","commits_url":"https://api.github.com/repos/vogdb/cm-janus/commits{/sha}","git_commits_url":"https://api.github.com/repos/vogdb/cm-janus/git/commits{/sha}","comments_url":"https://api.github.com/repos/vogdb/cm-janus/comments{/number}","issue_comment_url":"https://api.github.com/repos/vogdb/cm-janus/issues/comments{/number}","contents_url":"https://api.github.com/repos/vogdb/cm-janus/contents/{+path}","compare_url":"https://api.github.com/repos/vogdb/cm-janus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vogdb/cm-janus/merges","archive_url":"https://api.github.com/repos/vogdb/cm-janus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vogdb/cm-janus/downloads","issues_url":"https://api.github.com/repos/vogdb/cm-janus/issues{/number}","pulls_url":"https://api.github.com/repos/vogdb/cm-janus/pulls{/number}","milestones_url":"https://api.github.com/repos/vogdb/cm-janus/milestones{/number}","notifications_url":"https://api.github.com/repos/vogdb/cm-janus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vogdb/cm-janus/labels{/name}","releases_url":"https://api.github.com/repos/vogdb/cm-janus/releases{/id}","created_at":"2015-10-22T14:11:13Z","updated_at":"2015-10-28T11:09:07Z","pushed_at":"2015-11-03T10:18:44Z","git_url":"git://github.com/vogdb/cm-janus.git","ssh_url":"git@github.com:vogdb/cm-janus.git","clone_url":"https://github.com/vogdb/cm-janus.git","svn_url":"https://github.com/vogdb/cm-janus","homepage":null,"size":167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cargomedia:master","ref":"master","sha":"aaba28721a36cfaa77b40a46bf899a74c179effe","user":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"repo":{"id":44678874,"name":"cm-janus","full_name":"cargomedia/cm-janus","owner":{"login":"cargomedia","id":1699929,"avatar_url":"https://avatars.githubusercontent.com/u/1699929?v=3","gravatar_id":"","url":"https://api.github.com/users/cargomedia","html_url":"https://github.com/cargomedia","followers_url":"https://api.github.com/users/cargomedia/followers","following_url":"https://api.github.com/users/cargomedia/following{/other_user}","gists_url":"https://api.github.com/users/cargomedia/gists{/gist_id}","starred_url":"https://api.github.com/users/cargomedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cargomedia/subscriptions","organizations_url":"https://api.github.com/users/cargomedia/orgs","repos_url":"https://api.github.com/users/cargomedia/repos","events_url":"https://api.github.com/users/cargomedia/events{/privacy}","received_events_url":"https://api.github.com/users/cargomedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cargomedia/cm-janus","description":"cm/janus bridge","fork":false,"url":"https://api.github.com/repos/cargomedia/cm-janus","forks_url":"https://api.github.com/repos/cargomedia/cm-janus/forks","keys_url":"https://api.github.com/repos/cargomedia/cm-janus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cargomedia/cm-janus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cargomedia/cm-janus/teams","hooks_url":"https://api.github.com/repos/cargomedia/cm-janus/hooks","issue_events_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/events{/number}","events_url":"https://api.github.com/repos/cargomedia/cm-janus/events","assignees_url":"https://api.github.com/repos/cargomedia/cm-janus/assignees{/user}","branches_url":"https://api.github.com/repos/cargomedia/cm-janus/branches{/branch}","tags_url":"https://api.github.com/repos/cargomedia/cm-janus/tags","blobs_url":"https://api.github.com/repos/cargomedia/cm-janus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cargomedia/cm-janus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cargomedia/cm-janus/git/refs{/sha}","trees_url":"https://api.github.com/repos/cargomedia/cm-janus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cargomedia/cm-janus/statuses/{sha}","languages_url":"https://api.github.com/repos/cargomedia/cm-janus/languages","stargazers_url":"https://api.github.com/repos/cargomedia/cm-janus/stargazers","contributors_url":"https://api.github.com/repos/cargomedia/cm-janus/contributors","subscribers_url":"https://api.github.com/repos/cargomedia/cm-janus/subscribers","subscription_url":"https://api.github.com/repos/cargomedia/cm-janus/subscription","commits_url":"https://api.github.com/repos/cargomedia/cm-janus/commits{/sha}","git_commits_url":"https://api.github.com/repos/cargomedia/cm-janus/git/commits{/sha}","comments_url":"https://api.github.com/repos/cargomedia/cm-janus/comments{/number}","issue_comment_url":"https://api.github.com/repos/cargomedia/cm-janus/issues/comments{/number}","contents_url":"https://api.github.com/repos/cargomedia/cm-janus/contents/{+path}","compare_url":"https://api.github.com/repos/cargomedia/cm-janus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cargomedia/cm-janus/merges","archive_url":"https://api.github.com/repos/cargomedia/cm-janus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cargomedia/cm-janus/downloads","issues_url":"https://api.github.com/repos/cargomedia/cm-janus/issues{/number}","pulls_url":"https://api.github.com/repos/cargomedia/cm-janus/pulls{/number}","milestones_url":"https://api.github.com/repos/cargomedia/cm-janus/milestones{/number}","notifications_url":"https://api.github.com/repos/cargomedia/cm-janus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cargomedia/cm-janus/labels{/name}","releases_url":"https://api.github.com/repos/cargomedia/cm-janus/releases{/id}","created_at":"2015-10-21T13:41:09Z","updated_at":"2015-10-28T10:07:39Z","pushed_at":"2015-11-03T09:57:59Z","git_url":"git://github.com/cargomedia/cm-janus.git","ssh_url":"git@github.com:cargomedia/cm-janus.git","clone_url":"https://github.com/cargomedia/cm-janus.git","svn_url":"https://github.com/cargomedia/cm-janus","homepage":null,"size":282,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8"},"html":{"href":"https://github.com/cargomedia/cm-janus/pull/8"},"issue":{"href":"https://api.github.com/repos/cargomedia/cm-janus/issues/8"},"comments":{"href":"https://api.github.com/repos/cargomedia/cm-janus/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cargomedia/cm-janus/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/cargomedia/cm-janus/statuses/99a31bfe253e5c46ac93c63493ebf41d04eaf194"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":7,"additions":103,"deletions":11,"changed_files":5}}