{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/947","labels_url":"https://api.github.com/repos/ripple/rippled/issues/947/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/947/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/947/events","html_url":"https://github.com/ripple/rippled/pull/947","id":63788706,"number":947,"title":"Remove transaction set acquire logic from consensus object","user":{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Howard","name":"Howard","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Mickey","name":"Mickey","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-23T17:49:12Z","updated_at":"2015-03-24T18:47:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/947","html_url":"https://github.com/ripple/rippled/pull/947","diff_url":"https://github.com/ripple/rippled/pull/947.diff","patch_url":"https://github.com/ripple/rippled/pull/947.patch"},"body":"This creates a new InboundTransactions object that handles transaction sets, removing this responsibility from the consensus object. The main benefit is that many inbound transaction operations no longer require the master lock.\r\n\r\nImprove logic to decide which peers to query, when to add more peers, and when to re-query existing peers.\r\n\r\nReviewers needed."},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/85639256","html_url":"https://github.com/ripple/rippled/pull/947#issuecomment-85639256","issue_url":"https://api.github.com/repos/ripple/rippled/issues/947","id":85639256,"user":{"login":"HowardHinnant","id":6708789,"avatar_url":"https://avatars.githubusercontent.com/u/6708789?v=3","gravatar_id":"","url":"https://api.github.com/users/HowardHinnant","html_url":"https://github.com/HowardHinnant","followers_url":"https://api.github.com/users/HowardHinnant/followers","following_url":"https://api.github.com/users/HowardHinnant/following{/other_user}","gists_url":"https://api.github.com/users/HowardHinnant/gists{/gist_id}","starred_url":"https://api.github.com/users/HowardHinnant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HowardHinnant/subscriptions","organizations_url":"https://api.github.com/users/HowardHinnant/orgs","repos_url":"https://api.github.com/users/HowardHinnant/repos","events_url":"https://api.github.com/users/HowardHinnant/events{/privacy}","received_events_url":"https://api.github.com/users/HowardHinnant/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T18:47:24Z","updated_at":"2015-03-24T18:47:24Z","body":":+1: This P/R builds with no warnings on OS X using `scons debug` which builds both unity and non-unity builds.  The nounity debug build passes unittest, npm, syncs and stops."}}