{"action":"created","comment":{"url":"https://api.github.com/repos/cerati/mictest/pulls/comments/38638633","id":38638633,"diff_hunk":"@@ -174,43 +160,29 @@ class Hit\n \n   ~Hit(){}\n \n-  const SVector3&     position()   const {return state_.parameters;}\n-  const SVector3&     parameters() const {return state_.parameters;}\n-  const SMatrixSym33& error()      const {return state_.errors;}\n+  const SVector3&  position()  const {return state_.parameters;}\n+  const SMatrixSym33& error()  const {return state_.errors;}\n+  const SVector3& parameters() const {return state_.parameters;}\n+  const float r() const {return std::sqrt(getRad2(state_.parameters.At(0),state_.parameters.At(1)));}\n+  const float x() const {return state_.parameters.At(0);}\n+  const float y() const {return state_.parameters.At(1);}\n+  const float z() const {return state_.parameters.At(2);}\n+  const float phi() const {return getPhi(state_.parameters.At(0),state_.parameters.At(1));}\n+  const float eta() const {return getEta(r(),z());}\n \n   // Non-const versions needed for CopyOut of Matriplex.\n   SVector3&     parameters_nc() {return state_.parameters;}\n   SMatrixSym33& error_nc()      {return state_.errors;}\n \n-  float r() const {\n-    return sqrt(state_.parameters.At(0)*state_.parameters.At(0) +\n-                state_.parameters.At(1)*state_.parameters.At(1));\n-  }\n-  float x() const {\n-    return state_.parameters.At(0);\n-  }\n-  float y() const {\n-    return state_.parameters.At(1);\n-  }\n-  float z() const {\n-    return state_.parameters.At(2);\n-  }\n-  float phi() const {\n-    return getPhi(state_.parameters.At(0), state_.parameters.At(1));\n-  }\n-  float eta() const {\n-    return getEta(state_.parameters.At(0), state_.parameters.At(1), state_.parameters.At(2));\n-  }\n-\n   const MeasurementState& measurementState() const {\n     return state_;\n   }\n \n   const MCHitInfo& mcHitInfo() const {return mcHitInfo_;}\n-  int mcTrackID() const {return mcHitInfo_.mcTrackID_;}\n-  int layer() const {return mcHitInfo_.layer_;}\n-  int ithLayerHit() const {return mcHitInfo_.ithLayerHit_;}\n-  int hitID() const {return mcHitInfo_.mcHitID_;}\n+  unsigned int mcTrackID() const {return mcHitInfo_.mcTrackID_;}\n+  unsigned int layer() const {return mcHitInfo_.layer_;}\n+  unsigned int ithLayerHit() const {return mcHitInfo_.ithLayerHit_;}\n+  unsigned int hitID() const {return mcHitInfo_.mcHitID_;}","path":"Hit.h","position":274,"original_position":274,"commit_id":"dd5d5c4a886be7c6db05810cd041c25a2c8fd3a4","original_commit_id":"10407c8336149d91329d11fd0de12e8ae47e7600","user":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"body":"@osschar @cerati  I will change these (and other unsigned ints I inserted) to ints.  This will be the biggest change.  I will get back to you when it is done.","created_at":"2015-09-03T12:13:18Z","updated_at":"2015-09-03T12:13:18Z","html_url":"https://github.com/cerati/mictest/pull/2#discussion_r38638633","pull_request_url":"https://api.github.com/repos/cerati/mictest/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/cerati/mictest/pulls/comments/38638633"},"html":{"href":"https://github.com/cerati/mictest/pull/2#discussion_r38638633"},"pull_request":{"href":"https://api.github.com/repos/cerati/mictest/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/cerati/mictest/pulls/2","id":43285167,"html_url":"https://github.com/cerati/mictest/pull/2","diff_url":"https://github.com/cerati/mictest/pull/2.diff","patch_url":"https://github.com/cerati/mictest/pull/2.patch","issue_url":"https://api.github.com/repos/cerati/mictest/issues/2","number":2,"state":"open","locked":false,"title":"Ttree merge 2","user":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"body":"Hi @dan131riley  @osschar  @cerati @pwittich @srlantz,\r\n\r\nHere is the beast of a pull request I am submitting.  This can be automatically merged, but again, we can discuss changes here.\r\n\r\nI can also make a README on how to use the validation tools I developed.  \r\n\r\nFor starters, ./main still spits out a valtree.root if ROOT is enabled for SMatrix code.  There are four trees:\r\ntree_br: much like Giuseppe's old branching studies, with some upgrades\r\nefftree: filled once per sim track, used for making efficiency plots, duplicate rates, pulls, resolutions, etc\r\nfaketree: filled once per seed, used for making fake rate plots (could also be used for pulls, resolutions)\r\nconfigtree: branches for most of the stuff in Config.h \r\n\r\nonce ./main is run, use:\r\n\r\nroot -l -b -q runValidation.C \r\n\r\nto produce a bunch of plots.  Takes about 20 seconds to produce them all.  runValidation.C allows you to specify the input file, output directory, and if you want to save the plots also as pdf/png/etc.  all plots stored in output root file with same name as output dir in the output dir.\r\n\r\nComments in TTreeValidation.cc explain the conventions for flags and filling.  Lots of ROOT branches to explore! (Check my new slides here as a demonstration of how convenient the branches are in making quick checks: https://www.dropbox.com/s/ec735zgy673i3j8/new_geo_losthits.pdf?dl=0)\r\n\r\nLastly, if you want to compare between \"releases\", use smatrixPlotComparison.C (specify ins/outs) to quickly compare efficiency/FR/DR/nHits between releases.  Could add pulls simply.  \r\n\r\n  Peace,\r\nKevin","created_at":"2015-08-25T13:26:46Z","updated_at":"2015-09-03T12:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e74789537993a1e04bca10bace3406d0450cc566","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cerati/mictest/pulls/2/commits","review_comments_url":"https://api.github.com/repos/cerati/mictest/pulls/2/comments","review_comment_url":"https://api.github.com/repos/cerati/mictest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerati/mictest/issues/2/comments","statuses_url":"https://api.github.com/repos/cerati/mictest/statuses/dd5d5c4a886be7c6db05810cd041c25a2c8fd3a4","head":{"label":"kmcdermo:ttree-merge-2","ref":"ttree-merge-2","sha":"dd5d5c4a886be7c6db05810cd041c25a2c8fd3a4","user":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"repo":{"id":21205359,"name":"mictest","full_name":"kmcdermo/mictest","owner":{"login":"kmcdermo","id":7645989,"avatar_url":"https://avatars.githubusercontent.com/u/7645989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmcdermo","html_url":"https://github.com/kmcdermo","followers_url":"https://api.github.com/users/kmcdermo/followers","following_url":"https://api.github.com/users/kmcdermo/following{/other_user}","gists_url":"https://api.github.com/users/kmcdermo/gists{/gist_id}","starred_url":"https://api.github.com/users/kmcdermo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmcdermo/subscriptions","organizations_url":"https://api.github.com/users/kmcdermo/orgs","repos_url":"https://api.github.com/users/kmcdermo/repos","events_url":"https://api.github.com/users/kmcdermo/events{/privacy}","received_events_url":"https://api.github.com/users/kmcdermo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmcdermo/mictest","description":"","fork":true,"url":"https://api.github.com/repos/kmcdermo/mictest","forks_url":"https://api.github.com/repos/kmcdermo/mictest/forks","keys_url":"https://api.github.com/repos/kmcdermo/mictest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmcdermo/mictest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmcdermo/mictest/teams","hooks_url":"https://api.github.com/repos/kmcdermo/mictest/hooks","issue_events_url":"https://api.github.com/repos/kmcdermo/mictest/issues/events{/number}","events_url":"https://api.github.com/repos/kmcdermo/mictest/events","assignees_url":"https://api.github.com/repos/kmcdermo/mictest/assignees{/user}","branches_url":"https://api.github.com/repos/kmcdermo/mictest/branches{/branch}","tags_url":"https://api.github.com/repos/kmcdermo/mictest/tags","blobs_url":"https://api.github.com/repos/kmcdermo/mictest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmcdermo/mictest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmcdermo/mictest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmcdermo/mictest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmcdermo/mictest/statuses/{sha}","languages_url":"https://api.github.com/repos/kmcdermo/mictest/languages","stargazers_url":"https://api.github.com/repos/kmcdermo/mictest/stargazers","contributors_url":"https://api.github.com/repos/kmcdermo/mictest/contributors","subscribers_url":"https://api.github.com/repos/kmcdermo/mictest/subscribers","subscription_url":"https://api.github.com/repos/kmcdermo/mictest/subscription","commits_url":"https://api.github.com/repos/kmcdermo/mictest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmcdermo/mictest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmcdermo/mictest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmcdermo/mictest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmcdermo/mictest/contents/{+path}","compare_url":"https://api.github.com/repos/kmcdermo/mictest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmcdermo/mictest/merges","archive_url":"https://api.github.com/repos/kmcdermo/mictest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmcdermo/mictest/downloads","issues_url":"https://api.github.com/repos/kmcdermo/mictest/issues{/number}","pulls_url":"https://api.github.com/repos/kmcdermo/mictest/pulls{/number}","milestones_url":"https://api.github.com/repos/kmcdermo/mictest/milestones{/number}","notifications_url":"https://api.github.com/repos/kmcdermo/mictest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmcdermo/mictest/labels{/name}","releases_url":"https://api.github.com/repos/kmcdermo/mictest/releases{/id}","created_at":"2014-06-25T14:07:20Z","updated_at":"2015-03-23T16:44:14Z","pushed_at":"2015-09-03T12:03:40Z","git_url":"git://github.com/kmcdermo/mictest.git","ssh_url":"git@github.com:kmcdermo/mictest.git","clone_url":"https://github.com/kmcdermo/mictest.git","svn_url":"https://github.com/kmcdermo/mictest","homepage":null,"size":1545,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"cerati:devel","ref":"devel","sha":"7c00b6fa87f4a7fab18df4ed65c28a8f03fb34bc","user":{"login":"cerati","id":4818458,"avatar_url":"https://avatars.githubusercontent.com/u/4818458?v=3","gravatar_id":"","url":"https://api.github.com/users/cerati","html_url":"https://github.com/cerati","followers_url":"https://api.github.com/users/cerati/followers","following_url":"https://api.github.com/users/cerati/following{/other_user}","gists_url":"https://api.github.com/users/cerati/gists{/gist_id}","starred_url":"https://api.github.com/users/cerati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerati/subscriptions","organizations_url":"https://api.github.com/users/cerati/orgs","repos_url":"https://api.github.com/users/cerati/repos","events_url":"https://api.github.com/users/cerati/events{/privacy}","received_events_url":"https://api.github.com/users/cerati/received_events","type":"User","site_admin":false},"repo":{"id":17191259,"name":"mictest","full_name":"cerati/mictest","owner":{"login":"cerati","id":4818458,"avatar_url":"https://avatars.githubusercontent.com/u/4818458?v=3","gravatar_id":"","url":"https://api.github.com/users/cerati","html_url":"https://github.com/cerati","followers_url":"https://api.github.com/users/cerati/followers","following_url":"https://api.github.com/users/cerati/following{/other_user}","gists_url":"https://api.github.com/users/cerati/gists{/gist_id}","starred_url":"https://api.github.com/users/cerati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerati/subscriptions","organizations_url":"https://api.github.com/users/cerati/orgs","repos_url":"https://api.github.com/users/cerati/repos","events_url":"https://api.github.com/users/cerati/events{/privacy}","received_events_url":"https://api.github.com/users/cerati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cerati/mictest","description":"","fork":false,"url":"https://api.github.com/repos/cerati/mictest","forks_url":"https://api.github.com/repos/cerati/mictest/forks","keys_url":"https://api.github.com/repos/cerati/mictest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerati/mictest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerati/mictest/teams","hooks_url":"https://api.github.com/repos/cerati/mictest/hooks","issue_events_url":"https://api.github.com/repos/cerati/mictest/issues/events{/number}","events_url":"https://api.github.com/repos/cerati/mictest/events","assignees_url":"https://api.github.com/repos/cerati/mictest/assignees{/user}","branches_url":"https://api.github.com/repos/cerati/mictest/branches{/branch}","tags_url":"https://api.github.com/repos/cerati/mictest/tags","blobs_url":"https://api.github.com/repos/cerati/mictest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerati/mictest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerati/mictest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerati/mictest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerati/mictest/statuses/{sha}","languages_url":"https://api.github.com/repos/cerati/mictest/languages","stargazers_url":"https://api.github.com/repos/cerati/mictest/stargazers","contributors_url":"https://api.github.com/repos/cerati/mictest/contributors","subscribers_url":"https://api.github.com/repos/cerati/mictest/subscribers","subscription_url":"https://api.github.com/repos/cerati/mictest/subscription","commits_url":"https://api.github.com/repos/cerati/mictest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerati/mictest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerati/mictest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerati/mictest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerati/mictest/contents/{+path}","compare_url":"https://api.github.com/repos/cerati/mictest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerati/mictest/merges","archive_url":"https://api.github.com/repos/cerati/mictest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerati/mictest/downloads","issues_url":"https://api.github.com/repos/cerati/mictest/issues{/number}","pulls_url":"https://api.github.com/repos/cerati/mictest/pulls{/number}","milestones_url":"https://api.github.com/repos/cerati/mictest/milestones{/number}","notifications_url":"https://api.github.com/repos/cerati/mictest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerati/mictest/labels{/name}","releases_url":"https://api.github.com/repos/cerati/mictest/releases{/id}","created_at":"2014-02-25T22:59:21Z","updated_at":"2015-07-30T10:21:15Z","pushed_at":"2015-09-03T12:03:40Z","git_url":"git://github.com/cerati/mictest.git","ssh_url":"git@github.com:cerati/mictest.git","clone_url":"https://github.com/cerati/mictest.git","svn_url":"https://github.com/cerati/mictest","homepage":null,"size":1983,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/cerati/mictest/pulls/2"},"html":{"href":"https://github.com/cerati/mictest/pull/2"},"issue":{"href":"https://api.github.com/repos/cerati/mictest/issues/2"},"comments":{"href":"https://api.github.com/repos/cerati/mictest/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/cerati/mictest/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/cerati/mictest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerati/mictest/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/cerati/mictest/statuses/dd5d5c4a886be7c6db05810cd041c25a2c8fd3a4"}}}}