{"action":"closed","number":8450,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450","id":31684974,"html_url":"https://github.com/cms-sw/cmssw/pull/8450","diff_url":"https://github.com/cms-sw/cmssw/pull/8450.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8450.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8450","number":8450,"state":"closed","locked":false,"title":"avoid copies of GenEvent and optimizing random number usage in DIGI step","user":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"body":"Roughly 10% improvement in mixing module time\r\n\r\nMain change are:\r\n 1) Avoid copying GenEvent when not needed\r\n\r\n 2) Avoid creating a random generator using it once. I'm lazy so used the static methods as done elsewhere in the digitizers. One can easily also make the RandPoissonQ object a member data with the same effect. RandPoissonQ does some setup assuming that the mu its given will be used over and over, so there is a CPU penalty for creating it and using it only once.","created_at":"2015-03-22T08:42:31Z","updated_at":"2015-03-26T19:34:17Z","closed_at":"2015-03-26T19:34:17Z","merged_at":"2015-03-26T19:34:17Z","merge_commit_sha":"7d5539d59ca9c3b8482d0ae9456835213552fe00","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":282,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-03-26T19:34:17Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8450/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/a2c40e42d88a1451a363fc4be8a25dbe85bc7fea","head":{"label":"davidlange6:74x_digiPerf1","ref":"74x_digiPerf1","sha":"a2c40e42d88a1451a363fc4be8a25dbe85bc7fea","user":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"repo":{"id":11532380,"name":"cmssw","full_name":"davidlange6/cmssw","owner":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidlange6/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/davidlange6/cmssw","forks_url":"https://api.github.com/repos/davidlange6/cmssw/forks","keys_url":"https://api.github.com/repos/davidlange6/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidlange6/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidlange6/cmssw/teams","hooks_url":"https://api.github.com/repos/davidlange6/cmssw/hooks","issue_events_url":"https://api.github.com/repos/davidlange6/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/davidlange6/cmssw/events","assignees_url":"https://api.github.com/repos/davidlange6/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/davidlange6/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/davidlange6/cmssw/tags","blobs_url":"https://api.github.com/repos/davidlange6/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidlange6/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidlange6/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidlange6/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidlange6/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/davidlange6/cmssw/languages","stargazers_url":"https://api.github.com/repos/davidlange6/cmssw/stargazers","contributors_url":"https://api.github.com/repos/davidlange6/cmssw/contributors","subscribers_url":"https://api.github.com/repos/davidlange6/cmssw/subscribers","subscription_url":"https://api.github.com/repos/davidlange6/cmssw/subscription","commits_url":"https://api.github.com/repos/davidlange6/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidlange6/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidlange6/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidlange6/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidlange6/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/davidlange6/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidlange6/cmssw/merges","archive_url":"https://api.github.com/repos/davidlange6/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidlange6/cmssw/downloads","issues_url":"https://api.github.com/repos/davidlange6/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/davidlange6/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/davidlange6/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/davidlange6/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidlange6/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/davidlange6/cmssw/releases{/id}","created_at":"2013-07-19T16:43:48Z","updated_at":"2014-06-17T05:44:59Z","pushed_at":"2015-03-22T13:37:27Z","git_url":"git://github.com/davidlange6/cmssw.git","ssh_url":"git@github.com:davidlange6/cmssw.git","clone_url":"https://github.com/davidlange6/cmssw.git","svn_url":"https://github.com/davidlange6/cmssw","homepage":"cms-sw.github.io/cmssw","size":678281,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_7_5_X","ref":"CMSSW_7_5_X","sha":"4fb0d4ca943cee8944afb9a2800b6830bd8ba8a2","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-03-26T19:34:00Z","pushed_at":"2015-03-26T19:34:18Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":926393,"stargazers_count":215,"watchers_count":215,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1319,"mirror_url":null,"open_issues_count":165,"forks":1319,"open_issues":165,"watchers":215,"default_branch":"CMSSW_7_5_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/8450"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8450"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/8450/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/8450/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/a2c40e42d88a1451a363fc4be8a25dbe85bc7fea"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"comments":17,"review_comments":0,"commits":1,"additions":14,"deletions":22,"changed_files":4}}