{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/46689917","id":46689917,"diff_hunk":"@@ -129,56 +131,26 @@ const Popover = React.createClass({\n   },\n \n   renderLayer() {\n-    const {\n+    let {\n+      animation,\n+      style,","path":"src/popover/popover.jsx","position":62,"original_position":62,"commit_id":"897635a04bed04c5f1f37f79a1b0d9e1628a3b16","original_commit_id":"897635a04bed04c5f1f37f79a1b0d9e1628a3b16","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"I think that we should add `children` and `...other`.","created_at":"2015-12-04T15:01:33Z","updated_at":"2015-12-04T15:01:33Z","html_url":"https://github.com/callemall/material-ui/pull/2367#discussion_r46689917","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/2367","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/46689917"},"html":{"href":"https://github.com/callemall/material-ui/pull/2367#discussion_r46689917"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2367"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/2367","id":52652375,"html_url":"https://github.com/callemall/material-ui/pull/2367","diff_url":"https://github.com/callemall/material-ui/pull/2367.diff","patch_url":"https://github.com/callemall/material-ui/pull/2367.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/2367","number":2367,"state":"open","locked":false,"title":"Popover animation flexibility","user":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"body":"This PR allows popover to be passed an animation component that is responsible for animating its open and close.\r\n\r\n@oliviertassinari I tried react-motion, but struggled to get it to work as I wanted, so I've just extracted the animation css parts.\r\n\r\nThe other weirdness is that the outer element needs to provide the border zDepth because the box-shadow on paper is effectively an overflow.","created_at":"2015-12-04T10:27:42Z","updated_at":"2015-12-04T15:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18f1d24f58376fa6cdb26e4e921a9e6d7f557bf4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/2367/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/2367/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/2367/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/897635a04bed04c5f1f37f79a1b0d9e1628a3b16","head":{"label":"chrismcv:pop-anim","ref":"pop-anim","sha":"897635a04bed04c5f1f37f79a1b0d9e1628a3b16","user":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"repo":{"id":36790524,"name":"material-ui","full_name":"chrismcv/material-ui","owner":{"login":"chrismcv","id":145466,"avatar_url":"https://avatars.githubusercontent.com/u/145466?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismcv","html_url":"https://github.com/chrismcv","followers_url":"https://api.github.com/users/chrismcv/followers","following_url":"https://api.github.com/users/chrismcv/following{/other_user}","gists_url":"https://api.github.com/users/chrismcv/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismcv/subscriptions","organizations_url":"https://api.github.com/users/chrismcv/orgs","repos_url":"https://api.github.com/users/chrismcv/repos","events_url":"https://api.github.com/users/chrismcv/events{/privacy}","received_events_url":"https://api.github.com/users/chrismcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrismcv/material-ui","description":"A Set of React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/chrismcv/material-ui","forks_url":"https://api.github.com/repos/chrismcv/material-ui/forks","keys_url":"https://api.github.com/repos/chrismcv/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrismcv/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrismcv/material-ui/teams","hooks_url":"https://api.github.com/repos/chrismcv/material-ui/hooks","issue_events_url":"https://api.github.com/repos/chrismcv/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/chrismcv/material-ui/events","assignees_url":"https://api.github.com/repos/chrismcv/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/chrismcv/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/chrismcv/material-ui/tags","blobs_url":"https://api.github.com/repos/chrismcv/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrismcv/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrismcv/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrismcv/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrismcv/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/chrismcv/material-ui/languages","stargazers_url":"https://api.github.com/repos/chrismcv/material-ui/stargazers","contributors_url":"https://api.github.com/repos/chrismcv/material-ui/contributors","subscribers_url":"https://api.github.com/repos/chrismcv/material-ui/subscribers","subscription_url":"https://api.github.com/repos/chrismcv/material-ui/subscription","commits_url":"https://api.github.com/repos/chrismcv/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrismcv/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrismcv/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrismcv/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrismcv/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/chrismcv/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrismcv/material-ui/merges","archive_url":"https://api.github.com/repos/chrismcv/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrismcv/material-ui/downloads","issues_url":"https://api.github.com/repos/chrismcv/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/chrismcv/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/chrismcv/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/chrismcv/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrismcv/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/chrismcv/material-ui/releases{/id}","created_at":"2015-06-03T08:32:01Z","updated_at":"2015-06-03T08:32:02Z","pushed_at":"2015-12-04T14:28:39Z","git_url":"git://github.com/chrismcv/material-ui.git","ssh_url":"git@github.com:chrismcv/material-ui.git","clone_url":"https://github.com/chrismcv/material-ui.git","svn_url":"https://github.com/chrismcv/material-ui","homepage":"http://material-ui.com","size":25782,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"901886bac02a17cc9c30848f1bb363a1c12781e0","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","created_at":"2014-08-18T19:11:54Z","updated_at":"2015-12-04T14:22:27Z","pushed_at":"2015-12-04T14:28:40Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":38816,"stargazers_count":12239,"watchers_count":12239,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1965,"mirror_url":null,"open_issues_count":490,"forks":1965,"open_issues":490,"watchers":12239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2367"},"html":{"href":"https://github.com/callemall/material-ui/pull/2367"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2367"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2367/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2367/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2367/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/897635a04bed04c5f1f37f79a1b0d9e1628a3b16"}}}}