{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/37074215","id":37074215,"diff_hunk":"@@ -23,14 +23,14 @@ define('buttons',\n         markBtnsAsUninstalled();\n     });\n \n-    function setInstallBtnState($button, text, cls) {\n+    function setInstallBtnState($button, css_class) {\n         // Sets install button state (its text and its classes, which\n         // currently determines its click handler).\n-        revertButton($button, text);\n-        $button.addClass(cls);\n+        revertButton($button);\n+        $button.addClass(css_class);\n     }\n \n-    function revertButton($button, text) {","path":"src/media/js/buttons.js","position":14,"original_position":14,"commit_id":"a833b931aa93b8a432a9df951e53a81fdd09d26d","original_commit_id":"a833b931aa93b8a432a9df951e53a81fdd09d26d","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"Since `revertButton()` was not using `text`, I removed it. For the same reason I removed it from `setInstallBtnState()` which was just passing it down to `revertButton()`.","created_at":"2015-08-14T13:10:04Z","updated_at":"2015-08-14T13:10:04Z","html_url":"https://github.com/mozilla/fireplace/pull/1440#discussion_r37074215","pull_request_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1440","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/37074215"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1440#discussion_r37074215"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1440"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/1440","id":42453808,"html_url":"https://github.com/mozilla/fireplace/pull/1440","diff_url":"https://github.com/mozilla/fireplace/pull/1440.diff","patch_url":"https://github.com/mozilla/fireplace/pull/1440.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/1440","number":1440,"state":"open","locked":false,"title":"Make ACL app install button spin when installing through activity (bug 1194464)","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"body":"https://bugzilla.mozilla.org/show_bug.cgi?id=1194464\r\n\r\nSince we don't have tests for webactivities (working on that) here is how to test manually:\r\n\r\n1. Load fireplace locally, paste in your console:\r\n`window.postMessage({'name': 'marketplace-openmobile-acl', data: {acl_version: 'P172R12;P172R12;'}}, 'http://localhost:8675')`\r\n2. Notice you are taken to the acl app detail page and the install button is spinning.\r\n3. Accept the install\r\n4. Notice that the app is launched and the button reverted back to an \"installed, open app\" state.","created_at":"2015-08-14T13:08:12Z","updated_at":"2015-08-14T13:10:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff25250cee9b302e9cdf9810a12b833f6a5cc8c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1440/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/1440/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/1440/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/a833b931aa93b8a432a9df951e53a81fdd09d26d","head":{"label":"diox:spin-install-button-when-installing-acl","ref":"spin-install-button-when-installing-acl","sha":"a833b931aa93b8a432a9df951e53a81fdd09d26d","user":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"repo":{"id":10312455,"name":"fireplace","full_name":"diox/fireplace","owner":{"login":"diox","id":187006,"avatar_url":"https://avatars.githubusercontent.com/u/187006?v=3","gravatar_id":"","url":"https://api.github.com/users/diox","html_url":"https://github.com/diox","followers_url":"https://api.github.com/users/diox/followers","following_url":"https://api.github.com/users/diox/following{/other_user}","gists_url":"https://api.github.com/users/diox/gists{/gist_id}","starred_url":"https://api.github.com/users/diox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diox/subscriptions","organizations_url":"https://api.github.com/users/diox/orgs","repos_url":"https://api.github.com/users/diox/repos","events_url":"https://api.github.com/users/diox/events{/privacy}","received_events_url":"https://api.github.com/users/diox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diox/fireplace","description":"Ignition, the Remix","fork":true,"url":"https://api.github.com/repos/diox/fireplace","forks_url":"https://api.github.com/repos/diox/fireplace/forks","keys_url":"https://api.github.com/repos/diox/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diox/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diox/fireplace/teams","hooks_url":"https://api.github.com/repos/diox/fireplace/hooks","issue_events_url":"https://api.github.com/repos/diox/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/diox/fireplace/events","assignees_url":"https://api.github.com/repos/diox/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/diox/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/diox/fireplace/tags","blobs_url":"https://api.github.com/repos/diox/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diox/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diox/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/diox/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diox/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/diox/fireplace/languages","stargazers_url":"https://api.github.com/repos/diox/fireplace/stargazers","contributors_url":"https://api.github.com/repos/diox/fireplace/contributors","subscribers_url":"https://api.github.com/repos/diox/fireplace/subscribers","subscription_url":"https://api.github.com/repos/diox/fireplace/subscription","commits_url":"https://api.github.com/repos/diox/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/diox/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/diox/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/diox/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/diox/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/diox/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diox/fireplace/merges","archive_url":"https://api.github.com/repos/diox/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diox/fireplace/downloads","issues_url":"https://api.github.com/repos/diox/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/diox/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/diox/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/diox/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diox/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/diox/fireplace/releases{/id}","created_at":"2013-05-27T10:09:58Z","updated_at":"2015-04-22T12:41:27Z","pushed_at":"2015-08-14T13:05:42Z","git_url":"git://github.com/diox/fireplace.git","ssh_url":"git@github.com:diox/fireplace.git","clone_url":"https://github.com/diox/fireplace.git","svn_url":"https://github.com/diox/fireplace","homepage":"https://marketplace.firefox.com/","size":38141,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"c1574aab21662605f0674c7affb4bfe9f336a13a","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2015-08-14T05:51:19Z","pushed_at":"2015-08-14T13:08:13Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":101818,"stargazers_count":73,"watchers_count":73,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":11,"forks":191,"open_issues":11,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1440"},"html":{"href":"https://github.com/mozilla/fireplace/pull/1440"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1440"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/1440/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1440/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/1440/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/a833b931aa93b8a432a9df951e53a81fdd09d26d"}}}}