{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/44980558","id":44980558,"diff_hunk":"@@ -166,10 +217,17 @@ def test_bgpneighbor_set_get_capability_negotiation\n     end\n   end\n \n-  def test_bgpneighbor_set_get_dynamic_capability\n+  def test_set_get_dynamic_capability\n     %w(default test_vrf).each do |vrf|\n-      neighbor = RouterBgpNeighbor.new(@@asn, vrf, @@addr)\n-      check = [true, false, neighbor.default_dynamic_capability]\n+      neighbor = create_neighbor(vrf)\n+      check = []\n+      if platform == :ios_xr","path":"tests/test_bgp_neighbor.rb","position":249,"original_position":249,"commit_id":"db9520b5478105d5ceedfd6dfa43f5aa25c68c29","original_commit_id":"db9520b5478105d5ceedfd6dfa43f5aa25c68c29","user":{"login":"RichWellum","id":10466025,"avatar_url":"https://avatars.githubusercontent.com/u/10466025?v=3","gravatar_id":"","url":"https://api.github.com/users/RichWellum","html_url":"https://github.com/RichWellum","followers_url":"https://api.github.com/users/RichWellum/followers","following_url":"https://api.github.com/users/RichWellum/following{/other_user}","gists_url":"https://api.github.com/users/RichWellum/gists{/gist_id}","starred_url":"https://api.github.com/users/RichWellum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichWellum/subscriptions","organizations_url":"https://api.github.com/users/RichWellum/orgs","repos_url":"https://api.github.com/users/RichWellum/repos","events_url":"https://api.github.com/users/RichWellum/events{/privacy}","received_events_url":"https://api.github.com/users/RichWellum/received_events","type":"User","site_admin":false},"body":"Do you need specify xr for these? Presumably they are supported on NX and will just pass. Less code...","created_at":"2015-11-16T20:47:19Z","updated_at":"2015-11-16T20:47:19Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/85#discussion_r44980558","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/44980558"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/85#discussion_r44980558"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85","id":50838568,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/85","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/85.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/85.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/85","number":85,"state":"open","locked":false,"title":"bgp-neighbor node-utils support for XR","user":{"login":"ceburkett","id":862510,"avatar_url":"https://avatars.githubusercontent.com/u/862510?v=3","gravatar_id":"","url":"https://api.github.com/users/ceburkett","html_url":"https://github.com/ceburkett","followers_url":"https://api.github.com/users/ceburkett/followers","following_url":"https://api.github.com/users/ceburkett/following{/other_user}","gists_url":"https://api.github.com/users/ceburkett/gists{/gist_id}","starred_url":"https://api.github.com/users/ceburkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceburkett/subscriptions","organizations_url":"https://api.github.com/users/ceburkett/orgs","repos_url":"https://api.github.com/users/ceburkett/repos","events_url":"https://api.github.com/users/ceburkett/events{/privacy}","received_events_url":"https://api.github.com/users/ceburkett/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-16T17:16:30Z","updated_at":"2015-11-16T20:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8559baa8b8d2f49266c08a7cdce3fed31c9a54d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/85/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/db9520b5478105d5ceedfd6dfa43f5aa25c68c29","head":{"label":"ceburkett:feature/grpc-bgp-neighbor","ref":"feature/grpc-bgp-neighbor","sha":"db9520b5478105d5ceedfd6dfa43f5aa25c68c29","user":{"login":"ceburkett","id":862510,"avatar_url":"https://avatars.githubusercontent.com/u/862510?v=3","gravatar_id":"","url":"https://api.github.com/users/ceburkett","html_url":"https://github.com/ceburkett","followers_url":"https://api.github.com/users/ceburkett/followers","following_url":"https://api.github.com/users/ceburkett/following{/other_user}","gists_url":"https://api.github.com/users/ceburkett/gists{/gist_id}","starred_url":"https://api.github.com/users/ceburkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceburkett/subscriptions","organizations_url":"https://api.github.com/users/ceburkett/orgs","repos_url":"https://api.github.com/users/ceburkett/repos","events_url":"https://api.github.com/users/ceburkett/events{/privacy}","received_events_url":"https://api.github.com/users/ceburkett/received_events","type":"User","site_admin":false},"repo":{"id":45565973,"name":"cisco-network-node-utils","full_name":"ceburkett/cisco-network-node-utils","owner":{"login":"ceburkett","id":862510,"avatar_url":"https://avatars.githubusercontent.com/u/862510?v=3","gravatar_id":"","url":"https://api.github.com/users/ceburkett","html_url":"https://github.com/ceburkett","followers_url":"https://api.github.com/users/ceburkett/followers","following_url":"https://api.github.com/users/ceburkett/following{/other_user}","gists_url":"https://api.github.com/users/ceburkett/gists{/gist_id}","starred_url":"https://api.github.com/users/ceburkett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceburkett/subscriptions","organizations_url":"https://api.github.com/users/ceburkett/orgs","repos_url":"https://api.github.com/users/ceburkett/repos","events_url":"https://api.github.com/users/ceburkett/events{/privacy}","received_events_url":"https://api.github.com/users/ceburkett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceburkett/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils","forks_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/ceburkett/cisco-network-node-utils/releases{/id}","created_at":"2015-11-04T20:38:17Z","updated_at":"2015-11-04T20:38:18Z","pushed_at":"2015-11-16T17:08:42Z","git_url":"git://github.com/ceburkett/cisco-network-node-utils.git","ssh_url":"git@github.com:ceburkett/cisco-network-node-utils.git","clone_url":"https://github.com/ceburkett/cisco-network-node-utils.git","svn_url":"https://github.com/ceburkett/cisco-network-node-utils","homepage":null,"size":1018,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:feature/grpc","ref":"feature/grpc","sha":"5361249f93ef0f5f286a576c9653c1519f4885e6","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-16T19:23:35Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":1831,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":2,"forks":23,"open_issues":2,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/85"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/85"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/db9520b5478105d5ceedfd6dfa43f5aa25c68c29"}}}}