{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3028","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3028/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3028/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3028/events","html_url":"https://github.com/zfsonlinux/zfs/pull/3028","id":55025707,"number":3028,"title":"Fix removal of SA in sa_modify_attrs()","user":{"login":"dweeezil","id":1432005,"avatar_url":"https://avatars.githubusercontent.com/u/1432005?v=3","gravatar_id":"","url":"https://api.github.com/users/dweeezil","html_url":"https://github.com/dweeezil","followers_url":"https://api.github.com/users/dweeezil/followers","following_url":"https://api.github.com/users/dweeezil/following{/other_user}","gists_url":"https://api.github.com/users/dweeezil/gists{/gist_id}","starred_url":"https://api.github.com/users/dweeezil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweeezil/subscriptions","organizations_url":"https://api.github.com/users/dweeezil/orgs","repos_url":"https://api.github.com/users/dweeezil/repos","events_url":"https://api.github.com/users/dweeezil/events{/privacy}","received_events_url":"https://api.github.com/users/dweeezil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-21T14:31:26Z","updated_at":"2015-01-21T14:32:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3028","html_url":"https://github.com/zfsonlinux/zfs/pull/3028","diff_url":"https://github.com/zfsonlinux/zfs/pull/3028.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3028.patch"},"body":"The sa_modify_attrs() function can add, remove or replace an SA.\r\nThe main loop in the function uses the index \"i\" to iterate over the\r\nexisting SAs and uses the index \"j\" for writing them into a new buffer\r\nbia SA_ADD_BULK_ATTR().  The write index, \"j\" is incremented on remove\r\n(SA_REMOVE) operations which leads to a corruption in the new SA buffer.\r\nThis patch remove the increment for SA_REMOVE operations."},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/70846668","html_url":"https://github.com/zfsonlinux/zfs/pull/3028#issuecomment-70846668","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3028","id":70846668,"user":{"login":"dweeezil","id":1432005,"avatar_url":"https://avatars.githubusercontent.com/u/1432005?v=3","gravatar_id":"","url":"https://api.github.com/users/dweeezil","html_url":"https://github.com/dweeezil","followers_url":"https://api.github.com/users/dweeezil/followers","following_url":"https://api.github.com/users/dweeezil/following{/other_user}","gists_url":"https://api.github.com/users/dweeezil/gists{/gist_id}","starred_url":"https://api.github.com/users/dweeezil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweeezil/subscriptions","organizations_url":"https://api.github.com/users/dweeezil/orgs","repos_url":"https://api.github.com/users/dweeezil/repos","events_url":"https://api.github.com/users/dweeezil/events{/privacy}","received_events_url":"https://api.github.com/users/dweeezil/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T14:32:39Z","updated_at":"2015-01-21T14:32:39Z","body":"Ugh, gonna fix a typo in the commit comment and re-push."}}