{"action":"created","issue":{"url":"https://api.github.com/repos/google/gumbo-parser/issues/295","labels_url":"https://api.github.com/repos/google/gumbo-parser/issues/295/labels{/name}","comments_url":"https://api.github.com/repos/google/gumbo-parser/issues/295/comments","events_url":"https://api.github.com/repos/google/gumbo-parser/issues/295/events","html_url":"https://github.com/google/gumbo-parser/pull/295","id":57839957,"number":295,"title":"gumbo-next","user":{"login":"vmg","id":42793,"avatar_url":"https://avatars.githubusercontent.com/u/42793?v=3","gravatar_id":"","url":"https://api.github.com/users/vmg","html_url":"https://github.com/vmg","followers_url":"https://api.github.com/users/vmg/followers","following_url":"https://api.github.com/users/vmg/following{/other_user}","gists_url":"https://api.github.com/users/vmg/gists{/gist_id}","starred_url":"https://api.github.com/users/vmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmg/subscriptions","organizations_url":"https://api.github.com/users/vmg/orgs","repos_url":"https://api.github.com/users/vmg/repos","events_url":"https://api.github.com/users/vmg/events{/privacy}","received_events_url":"https://api.github.com/users/vmg/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":26,"created_at":"2015-02-16T18:59:38Z","updated_at":"2015-02-19T14:26:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/gumbo-parser/pulls/295","html_url":"https://github.com/google/gumbo-parser/pull/295","diff_url":"https://github.com/google/gumbo-parser/pull/295.diff","patch_url":"https://github.com/google/gumbo-parser/pull/295.patch"},"body":"After @kevinhendricks kindly ported my TagSet patches on top of the current `template` branch, I've taken over and implemented the features that he requested (and that we had already implemented in our internal fork already ;)).\r\n\r\nThis branch enables support for Fragment Parsing and Templates and has 100% coverage on the html5lib 0.95 tests (including the fragment tests, which have now been enabled). It is also significantly faster in many parsing cases thanks to the new tag lookup machinery. Some further optimizations have not been ported yet.\r\n\r\nAs they say, you cannot make an omelette without breaking some eggs (or APIs in this case). In order to support the new features (and to keep parity with our internal fork), a couple external APIs have been broken. This makes this branch a good candidate for a \"development\" or \"next\" branch that hopefully will become part of Gumbo 1.0.\r\n\r\nEvery change, optimization and design decision has been carefully documented on the commit messages of my 4 patches. The remainder commits by @kevinhendricks are assumed \"correct\" insofar they are based on the existing `template` branch and are a rebase/backport (we've also extensively tested them, and I performed some cursory review).\r\n\r\nPlease consider this branch for merging. Thanks! :)\r\n\r\ncc @nostrademons @aroben "},"comment":{"url":"https://api.github.com/repos/google/gumbo-parser/issues/comments/75059860","html_url":"https://github.com/google/gumbo-parser/pull/295#issuecomment-75059860","issue_url":"https://api.github.com/repos/google/gumbo-parser/issues/295","id":75059860,"user":{"login":"kevinhendricks","id":8493752,"avatar_url":"https://avatars.githubusercontent.com/u/8493752?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinhendricks","html_url":"https://github.com/kevinhendricks","followers_url":"https://api.github.com/users/kevinhendricks/followers","following_url":"https://api.github.com/users/kevinhendricks/following{/other_user}","gists_url":"https://api.github.com/users/kevinhendricks/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinhendricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinhendricks/subscriptions","organizations_url":"https://api.github.com/users/kevinhendricks/orgs","repos_url":"https://api.github.com/users/kevinhendricks/repos","events_url":"https://api.github.com/users/kevinhendricks/events{/privacy}","received_events_url":"https://api.github.com/users/kevinhendricks/received_events","type":"User","site_admin":false},"created_at":"2015-02-19T14:26:49Z","updated_at":"2015-02-19T14:26:49Z","body":"Actually it does not.  I finally found the mph-1.2.tar.gz in an old ftp linux repository.  Once you have it, the generated code needs to be very slightly modified to allow for case conversion for lookup.  Since I use a larger recognized tag set, I will document the process in a README of some sort and post it for you.\n\nOne other side-effect is the need to use gnu sed when remaking the pieces as standard sed on BSD/Mac OSX will not work.  But since automake and friends, and etc do not exist as standard on MacOSX any way, this is minor.\n\nSent from my iPad\n\n> On Feb 18, 2015, at 11:37 PM, nostrademons <notifications@github.com> wrote:\n> \n> I assume 'mph' refers to CMPH, the C Minimal Perfect Hash library. I'd like to see a more thorough pointer in the source code as well.\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}