{"action":"created","comment":{"url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/comments/30823911","id":30823911,"diff_hunk":"@@ -52,23 +52,18 @@ produce but is invaluable when present.\n \n ## Clean Pull Requests\n \n-In an effort to keep the history clean, Pull Requests should be as concise as\n-possible. This means consolodating changes into logical groups; change to the\n-project, and documenation updates.\n+In an effort to keep maintain a clean history, Pull Requests should be as concise as\n+possible. Commits messages should follow established [commit message guidelines](http://www.tpope.net/node/106),\n+and should attempt to consolidate complete features into a single commit.\n \n-First commit should include:\n+A good pull request should contain each of the following elements:\n \n-  1. Code changes - typically in files located in `src/`\n-  2. Unit tests to support - typically in files located in `test/`\n+  1. Code changes - typically located in `src/`\n+  2. Supporting unit tests - typically located in `test/`\n   3. Version bump: major, minor, patch - in `package.json`\n-  4. Following [commit message guidelines](http://www.tpope.net/node/106)\n \n-Second commit should include:\n-\n-  1. `npm run doc`\n-  2. `npm run coverage`\n-\n-Documenation is generated by a tool, so checking a diff of generated files is,\n-to some degree, pointless\n-\n-Keeping these seperations in a Pull Request will help keep code reviews short.\n+Please avoid working directly on `master`. Feature branches are considered\n+preferable, to avoid falling behind HEAD in your fork, and to ensure logical","path":"CONTRIBUTING.md","position":60,"original_position":60,"commit_id":"7c32c12feb6f20edddff0e2580b0f1db391b7bb8","original_commit_id":"7c32c12feb6f20edddff0e2580b0f1db391b7bb8","user":{"login":"kalisjoshua","id":122826,"avatar_url":"https://avatars.githubusercontent.com/u/122826?v=3","gravatar_id":"","url":"https://api.github.com/users/kalisjoshua","html_url":"https://github.com/kalisjoshua","followers_url":"https://api.github.com/users/kalisjoshua/followers","following_url":"https://api.github.com/users/kalisjoshua/following{/other_user}","gists_url":"https://api.github.com/users/kalisjoshua/gists{/gist_id}","starred_url":"https://api.github.com/users/kalisjoshua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalisjoshua/subscriptions","organizations_url":"https://api.github.com/users/kalisjoshua/orgs","repos_url":"https://api.github.com/users/kalisjoshua/repos","events_url":"https://api.github.com/users/kalisjoshua/events{/privacy}","received_events_url":"https://api.github.com/users/kalisjoshua/received_events","type":"User","site_admin":false},"body":"HEAD should be master in this paragraph; HEAD is just the tip of the current branch.","created_at":"2015-05-21T17:15:23Z","updated_at":"2015-05-21T17:15:23Z","html_url":"https://github.com/QuickenLoans/ramllint/pull/13#discussion_r30823911","pull_request_url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/comments/30823911"},"html":{"href":"https://github.com/QuickenLoans/ramllint/pull/13#discussion_r30823911"},"pull_request":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13","id":35790126,"html_url":"https://github.com/QuickenLoans/ramllint/pull/13","diff_url":"https://github.com/QuickenLoans/ramllint/pull/13.diff","patch_url":"https://github.com/QuickenLoans/ramllint/pull/13.patch","issue_url":"https://api.github.com/repos/QuickenLoans/ramllint/issues/13","number":13,"state":"open","locked":false,"title":"Fix grammar errors, improve documentation","user":{"login":"jdpedrie","id":89034,"avatar_url":"https://avatars.githubusercontent.com/u/89034?v=3","gravatar_id":"","url":"https://api.github.com/users/jdpedrie","html_url":"https://github.com/jdpedrie","followers_url":"https://api.github.com/users/jdpedrie/followers","following_url":"https://api.github.com/users/jdpedrie/following{/other_user}","gists_url":"https://api.github.com/users/jdpedrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpedrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpedrie/subscriptions","organizations_url":"https://api.github.com/users/jdpedrie/orgs","repos_url":"https://api.github.com/users/jdpedrie/repos","events_url":"https://api.github.com/users/jdpedrie/events{/privacy}","received_events_url":"https://api.github.com/users/jdpedrie/received_events","type":"User","site_admin":false},"body":"Sorry for the flood of pull requests. I resolved a couple of spelling errors in the more recent changes, fixed a couple errors I introduced in my earlier changes to the documentation, and improved the overall wording of the documentation files.","created_at":"2015-05-20T01:07:05Z","updated_at":"2015-05-21T17:15:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0273ac17fc3d862cb732c05ee4eafd24cf6dbff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13/commits","review_comments_url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13/comments","review_comment_url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QuickenLoans/ramllint/issues/13/comments","statuses_url":"https://api.github.com/repos/QuickenLoans/ramllint/statuses/7c32c12feb6f20edddff0e2580b0f1db391b7bb8","head":{"label":"jdpedrie:doc-updates","ref":"doc-updates","sha":"7c32c12feb6f20edddff0e2580b0f1db391b7bb8","user":{"login":"jdpedrie","id":89034,"avatar_url":"https://avatars.githubusercontent.com/u/89034?v=3","gravatar_id":"","url":"https://api.github.com/users/jdpedrie","html_url":"https://github.com/jdpedrie","followers_url":"https://api.github.com/users/jdpedrie/followers","following_url":"https://api.github.com/users/jdpedrie/following{/other_user}","gists_url":"https://api.github.com/users/jdpedrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpedrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpedrie/subscriptions","organizations_url":"https://api.github.com/users/jdpedrie/orgs","repos_url":"https://api.github.com/users/jdpedrie/repos","events_url":"https://api.github.com/users/jdpedrie/events{/privacy}","received_events_url":"https://api.github.com/users/jdpedrie/received_events","type":"User","site_admin":false},"repo":{"id":35852720,"name":"ramllint","full_name":"jdpedrie/ramllint","owner":{"login":"jdpedrie","id":89034,"avatar_url":"https://avatars.githubusercontent.com/u/89034?v=3","gravatar_id":"","url":"https://api.github.com/users/jdpedrie","html_url":"https://github.com/jdpedrie","followers_url":"https://api.github.com/users/jdpedrie/followers","following_url":"https://api.github.com/users/jdpedrie/following{/other_user}","gists_url":"https://api.github.com/users/jdpedrie/gists{/gist_id}","starred_url":"https://api.github.com/users/jdpedrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdpedrie/subscriptions","organizations_url":"https://api.github.com/users/jdpedrie/orgs","repos_url":"https://api.github.com/users/jdpedrie/repos","events_url":"https://api.github.com/users/jdpedrie/events{/privacy}","received_events_url":"https://api.github.com/users/jdpedrie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdpedrie/ramllint","description":"RAML Linter","fork":true,"url":"https://api.github.com/repos/jdpedrie/ramllint","forks_url":"https://api.github.com/repos/jdpedrie/ramllint/forks","keys_url":"https://api.github.com/repos/jdpedrie/ramllint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdpedrie/ramllint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdpedrie/ramllint/teams","hooks_url":"https://api.github.com/repos/jdpedrie/ramllint/hooks","issue_events_url":"https://api.github.com/repos/jdpedrie/ramllint/issues/events{/number}","events_url":"https://api.github.com/repos/jdpedrie/ramllint/events","assignees_url":"https://api.github.com/repos/jdpedrie/ramllint/assignees{/user}","branches_url":"https://api.github.com/repos/jdpedrie/ramllint/branches{/branch}","tags_url":"https://api.github.com/repos/jdpedrie/ramllint/tags","blobs_url":"https://api.github.com/repos/jdpedrie/ramllint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdpedrie/ramllint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdpedrie/ramllint/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdpedrie/ramllint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdpedrie/ramllint/statuses/{sha}","languages_url":"https://api.github.com/repos/jdpedrie/ramllint/languages","stargazers_url":"https://api.github.com/repos/jdpedrie/ramllint/stargazers","contributors_url":"https://api.github.com/repos/jdpedrie/ramllint/contributors","subscribers_url":"https://api.github.com/repos/jdpedrie/ramllint/subscribers","subscription_url":"https://api.github.com/repos/jdpedrie/ramllint/subscription","commits_url":"https://api.github.com/repos/jdpedrie/ramllint/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdpedrie/ramllint/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdpedrie/ramllint/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdpedrie/ramllint/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdpedrie/ramllint/contents/{+path}","compare_url":"https://api.github.com/repos/jdpedrie/ramllint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdpedrie/ramllint/merges","archive_url":"https://api.github.com/repos/jdpedrie/ramllint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdpedrie/ramllint/downloads","issues_url":"https://api.github.com/repos/jdpedrie/ramllint/issues{/number}","pulls_url":"https://api.github.com/repos/jdpedrie/ramllint/pulls{/number}","milestones_url":"https://api.github.com/repos/jdpedrie/ramllint/milestones{/number}","notifications_url":"https://api.github.com/repos/jdpedrie/ramllint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdpedrie/ramllint/labels{/name}","releases_url":"https://api.github.com/repos/jdpedrie/ramllint/releases{/id}","created_at":"2015-05-19T01:45:52Z","updated_at":"2015-05-19T01:45:53Z","pushed_at":"2015-05-21T17:07:48Z","git_url":"git://github.com/jdpedrie/ramllint.git","ssh_url":"git@github.com:jdpedrie/ramllint.git","clone_url":"https://github.com/jdpedrie/ramllint.git","svn_url":"https://github.com/jdpedrie/ramllint","homepage":"http://quickenloans.github.io/ramllint/","size":1071,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QuickenLoans:master","ref":"master","sha":"6297211f2ea28ce2497377e2a53032d33f385e40","user":{"login":"QuickenLoans","id":1609849,"avatar_url":"https://avatars.githubusercontent.com/u/1609849?v=3","gravatar_id":"","url":"https://api.github.com/users/QuickenLoans","html_url":"https://github.com/QuickenLoans","followers_url":"https://api.github.com/users/QuickenLoans/followers","following_url":"https://api.github.com/users/QuickenLoans/following{/other_user}","gists_url":"https://api.github.com/users/QuickenLoans/gists{/gist_id}","starred_url":"https://api.github.com/users/QuickenLoans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuickenLoans/subscriptions","organizations_url":"https://api.github.com/users/QuickenLoans/orgs","repos_url":"https://api.github.com/users/QuickenLoans/repos","events_url":"https://api.github.com/users/QuickenLoans/events{/privacy}","received_events_url":"https://api.github.com/users/QuickenLoans/received_events","type":"Organization","site_admin":false},"repo":{"id":35832994,"name":"ramllint","full_name":"QuickenLoans/ramllint","owner":{"login":"QuickenLoans","id":1609849,"avatar_url":"https://avatars.githubusercontent.com/u/1609849?v=3","gravatar_id":"","url":"https://api.github.com/users/QuickenLoans","html_url":"https://github.com/QuickenLoans","followers_url":"https://api.github.com/users/QuickenLoans/followers","following_url":"https://api.github.com/users/QuickenLoans/following{/other_user}","gists_url":"https://api.github.com/users/QuickenLoans/gists{/gist_id}","starred_url":"https://api.github.com/users/QuickenLoans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuickenLoans/subscriptions","organizations_url":"https://api.github.com/users/QuickenLoans/orgs","repos_url":"https://api.github.com/users/QuickenLoans/repos","events_url":"https://api.github.com/users/QuickenLoans/events{/privacy}","received_events_url":"https://api.github.com/users/QuickenLoans/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuickenLoans/ramllint","description":"RAML Linter","fork":false,"url":"https://api.github.com/repos/QuickenLoans/ramllint","forks_url":"https://api.github.com/repos/QuickenLoans/ramllint/forks","keys_url":"https://api.github.com/repos/QuickenLoans/ramllint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuickenLoans/ramllint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuickenLoans/ramllint/teams","hooks_url":"https://api.github.com/repos/QuickenLoans/ramllint/hooks","issue_events_url":"https://api.github.com/repos/QuickenLoans/ramllint/issues/events{/number}","events_url":"https://api.github.com/repos/QuickenLoans/ramllint/events","assignees_url":"https://api.github.com/repos/QuickenLoans/ramllint/assignees{/user}","branches_url":"https://api.github.com/repos/QuickenLoans/ramllint/branches{/branch}","tags_url":"https://api.github.com/repos/QuickenLoans/ramllint/tags","blobs_url":"https://api.github.com/repos/QuickenLoans/ramllint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuickenLoans/ramllint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuickenLoans/ramllint/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuickenLoans/ramllint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuickenLoans/ramllint/statuses/{sha}","languages_url":"https://api.github.com/repos/QuickenLoans/ramllint/languages","stargazers_url":"https://api.github.com/repos/QuickenLoans/ramllint/stargazers","contributors_url":"https://api.github.com/repos/QuickenLoans/ramllint/contributors","subscribers_url":"https://api.github.com/repos/QuickenLoans/ramllint/subscribers","subscription_url":"https://api.github.com/repos/QuickenLoans/ramllint/subscription","commits_url":"https://api.github.com/repos/QuickenLoans/ramllint/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuickenLoans/ramllint/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuickenLoans/ramllint/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuickenLoans/ramllint/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuickenLoans/ramllint/contents/{+path}","compare_url":"https://api.github.com/repos/QuickenLoans/ramllint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuickenLoans/ramllint/merges","archive_url":"https://api.github.com/repos/QuickenLoans/ramllint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuickenLoans/ramllint/downloads","issues_url":"https://api.github.com/repos/QuickenLoans/ramllint/issues{/number}","pulls_url":"https://api.github.com/repos/QuickenLoans/ramllint/pulls{/number}","milestones_url":"https://api.github.com/repos/QuickenLoans/ramllint/milestones{/number}","notifications_url":"https://api.github.com/repos/QuickenLoans/ramllint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuickenLoans/ramllint/labels{/name}","releases_url":"https://api.github.com/repos/QuickenLoans/ramllint/releases{/id}","created_at":"2015-05-18T17:46:06Z","updated_at":"2015-05-20T15:22:34Z","pushed_at":"2015-05-21T17:07:48Z","git_url":"git://github.com/QuickenLoans/ramllint.git","ssh_url":"git@github.com:QuickenLoans/ramllint.git","clone_url":"https://github.com/QuickenLoans/ramllint.git","svn_url":"https://github.com/QuickenLoans/ramllint","homepage":"http://quickenloans.github.io/ramllint/","size":1484,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13"},"html":{"href":"https://github.com/QuickenLoans/ramllint/pull/13"},"issue":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/issues/13"},"comments":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/QuickenLoans/ramllint/statuses/7c32c12feb6f20edddff0e2580b0f1db391b7bb8"}}}}