{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47858559","id":47858559,"diff_hunk":"@@ -702,7 +702,8 @@ func (NodeSpec) SwaggerDoc() map[string]string {\n \n var map_NodeStatus = map[string]string{\n \t\"\":                \"NodeStatus is information about the current status of a node.\",\n-\t\"capacity\":        \"Capacity represents the available resources of a node. More info: http://releases.k8s.io/HEAD/docs/user-guide/persistent-volumes.md#capacity for more details.\",\n+\t\"capacity\":        \"Capacity represents the total resources of a node. More info: http://releases.k8s.io/HEAD/docs/user-guide/persistent-volumes.md#capacity for more details.\",","path":"pkg/api/v1/types_swagger_doc_generated.go","position":5,"original_position":5,"commit_id":"c47ef0675f992bf4b20033bb06540479b23fb3ea","original_commit_id":"c47ef0675f992bf4b20033bb06540479b23fb3ea","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"body":"Good question. It was there before, probably copied from the PersistentVolumeSpec.Capacity field. Removed.","created_at":"2015-12-17T01:16:40Z","updated_at":"2015-12-17T01:16:40Z","html_url":"https://github.com/kubernetes/kubernetes/pull/18611#discussion_r47858559","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/47858559"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18611#discussion_r47858559"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611","id":53463967,"html_url":"https://github.com/kubernetes/kubernetes/pull/18611","diff_url":"https://github.com/kubernetes/kubernetes/pull/18611.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/18611.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18611","number":18611,"state":"open","locked":false,"title":"Implement node Allocatable","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"body":"Add `kube-reserved` and `system-reserved` flags for configuration\r\nreserved resources for usage outside of kubernetes pods. Allocatable is\r\nprovided by the Kubelet according to the formula:\r\n```\r\nAllocatable = Capacity - KubeReserved - SystemReserved\r\n```\r\n\r\nIssue: https://github.com/kubernetes/kubernetes/issues/13984\r\n\r\nProposal: https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/node-allocatable.md\r\n\r\nIncludes commits from dependent PRs: https://github.com/kubernetes/kubernetes/pull/18189 and https://github.com/kubernetes/kubernetes/pull/18557\r\n\r\nRemaining work: set default value of kube-reserved based on predicted usage\r\n\r\n/cc @kubernetes/goog-node ","created_at":"2015-12-12T01:21:39Z","updated_at":"2015-12-17T01:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1af181789bc7369428d46b2cae9fb7b0a65b15e","assignee":{"login":"dchen1107","id":7740897,"avatar_url":"https://avatars.githubusercontent.com/u/7740897?v=3","gravatar_id":"","url":"https://api.github.com/users/dchen1107","html_url":"https://github.com/dchen1107","followers_url":"https://api.github.com/users/dchen1107/followers","following_url":"https://api.github.com/users/dchen1107/following{/other_user}","gists_url":"https://api.github.com/users/dchen1107/gists{/gist_id}","starred_url":"https://api.github.com/users/dchen1107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchen1107/subscriptions","organizations_url":"https://api.github.com/users/dchen1107/orgs","repos_url":"https://api.github.com/users/dchen1107/repos","events_url":"https://api.github.com/users/dchen1107/events{/privacy}","received_events_url":"https://api.github.com/users/dchen1107/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/18611/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c47ef0675f992bf4b20033bb06540479b23fb3ea","head":{"label":"timstclair:allocatable-impl2","ref":"allocatable-impl2","sha":"c47ef0675f992bf4b20033bb06540479b23fb3ea","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"repo":{"id":36760336,"name":"kubernetes","full_name":"timstclair/kubernetes","owner":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timstclair/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/timstclair/kubernetes","forks_url":"https://api.github.com/repos/timstclair/kubernetes/forks","keys_url":"https://api.github.com/repos/timstclair/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timstclair/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timstclair/kubernetes/teams","hooks_url":"https://api.github.com/repos/timstclair/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/timstclair/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/timstclair/kubernetes/events","assignees_url":"https://api.github.com/repos/timstclair/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/timstclair/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/timstclair/kubernetes/tags","blobs_url":"https://api.github.com/repos/timstclair/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timstclair/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timstclair/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/timstclair/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timstclair/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/timstclair/kubernetes/languages","stargazers_url":"https://api.github.com/repos/timstclair/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/timstclair/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/timstclair/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/timstclair/kubernetes/subscription","commits_url":"https://api.github.com/repos/timstclair/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/timstclair/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/timstclair/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/timstclair/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/timstclair/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/timstclair/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timstclair/kubernetes/merges","archive_url":"https://api.github.com/repos/timstclair/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timstclair/kubernetes/downloads","issues_url":"https://api.github.com/repos/timstclair/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/timstclair/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/timstclair/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/timstclair/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timstclair/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/timstclair/kubernetes/releases{/id}","created_at":"2015-06-02T20:36:50Z","updated_at":"2015-06-13T04:34:00Z","pushed_at":"2015-12-17T01:16:00Z","git_url":"git://github.com/timstclair/kubernetes.git","ssh_url":"git@github.com:timstclair/kubernetes.git","clone_url":"https://github.com/timstclair/kubernetes.git","svn_url":"https://github.com/timstclair/kubernetes","homepage":"http://kubernetes.io","size":140087,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3d24d25fd8f431dbc0040eccf19ff6a3f304bd31","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-12-16T22:48:57Z","pushed_at":"2015-12-17T01:07:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":293818,"stargazers_count":11772,"watchers_count":11772,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3223,"mirror_url":null,"open_issues_count":2573,"forks":3223,"open_issues":2573,"watchers":11772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/18611"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18611"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/18611/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/18611/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c47ef0675f992bf4b20033bb06540479b23fb3ea"}}}}