{"action":"created","comment":{"url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/comments/23805714","id":23805714,"diff_hunk":"@@ -0,0 +1,31 @@\n+#include \"RingData.h\"\n+\n+\n+ringData::ringData()\n+{\n+}\n+\n+\n+ringData::~ringData()\n+{\n+}\n+\n+std::vector<ringData::keyboard_value> ringData::getRingInVector()\n+{\n+    return*ringInVector;\n+}","path":"PMMain/Midas/MidasGUI/RingData.cpp","position":16,"original_position":16,"commit_id":"97438213e7cd0bd9fbc933c9335d8d5dbb78d1a0","original_commit_id":"97438213e7cd0bd9fbc933c9335d8d5dbb78d1a0","user":{"login":"jordenh","id":1761561,"avatar_url":"https://avatars.githubusercontent.com/u/1761561?v=3","gravatar_id":"","url":"https://api.github.com/users/jordenh","html_url":"https://github.com/jordenh","followers_url":"https://api.github.com/users/jordenh/followers","following_url":"https://api.github.com/users/jordenh/following{/other_user}","gists_url":"https://api.github.com/users/jordenh/gists{/gist_id}","starred_url":"https://api.github.com/users/jordenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordenh/subscriptions","organizations_url":"https://api.github.com/users/jordenh/orgs","repos_url":"https://api.github.com/users/jordenh/repos","events_url":"https://api.github.com/users/jordenh/events{/privacy}","received_events_url":"https://api.github.com/users/jordenh/received_events","type":"User","site_admin":false},"body":"Also, the function name could be like getRingInVectorHandle()","created_at":"2015-01-29T21:48:00Z","updated_at":"2015-01-29T21:48:00Z","html_url":"https://github.com/lordy1992/ProjectMidas/pull/32#discussion_r23805714","pull_request_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/comments/23805714"},"html":{"href":"https://github.com/lordy1992/ProjectMidas/pull/32#discussion_r23805714"},"pull_request":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32","id":28316730,"html_url":"https://github.com/lordy1992/ProjectMidas/pull/32","diff_url":"https://github.com/lordy1992/ProjectMidas/pull/32.diff","patch_url":"https://github.com/lordy1992/ProjectMidas/pull/32.patch","issue_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/32","number":32,"state":"open","locked":false,"title":"Keyboard gui backend","user":{"login":"owen927","id":6363117,"avatar_url":"https://avatars.githubusercontent.com/u/6363117?v=3","gravatar_id":"","url":"https://api.github.com/users/owen927","html_url":"https://github.com/owen927","followers_url":"https://api.github.com/users/owen927/followers","following_url":"https://api.github.com/users/owen927/following{/other_user}","gists_url":"https://api.github.com/users/owen927/gists{/gist_id}","starred_url":"https://api.github.com/users/owen927/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owen927/subscriptions","organizations_url":"https://api.github.com/users/owen927/orgs","repos_url":"https://api.github.com/users/owen927/repos","events_url":"https://api.github.com/users/owen927/events{/privacy}","received_events_url":"https://api.github.com/users/owen927/received_events","type":"User","site_admin":false},"body":"what's in this pull request:\r\nringData class + keyboardFileReader\r\nupdated myoTranslationFilter - now the calculation angle of myo for keySelect in done in the filter\r\nupdated SCDDigester - MidasMain now reads keyboard setup file, passes the data into SCDDigester\r\ndepends on user input(click/ hold )SCDDigester uses keySelectAngle and\r\nkybdGUISel to determine which char to output to send\r\nthe logics for determining the keySelectAngle will still need more work","created_at":"2015-01-29T21:33:45Z","updated_at":"2015-01-29T21:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31bd48961047a7639921d448b11d2cddc92acdb2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32/commits","review_comments_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32/comments","review_comment_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/32/comments","statuses_url":"https://api.github.com/repos/lordy1992/ProjectMidas/statuses/97438213e7cd0bd9fbc933c9335d8d5dbb78d1a0","head":{"label":"lordy1992:keyboardGUIBackend","ref":"keyboardGUIBackend","sha":"97438213e7cd0bd9fbc933c9335d8d5dbb78d1a0","user":{"login":"lordy1992","id":1761555,"avatar_url":"https://avatars.githubusercontent.com/u/1761555?v=3","gravatar_id":"","url":"https://api.github.com/users/lordy1992","html_url":"https://github.com/lordy1992","followers_url":"https://api.github.com/users/lordy1992/followers","following_url":"https://api.github.com/users/lordy1992/following{/other_user}","gists_url":"https://api.github.com/users/lordy1992/gists{/gist_id}","starred_url":"https://api.github.com/users/lordy1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordy1992/subscriptions","organizations_url":"https://api.github.com/users/lordy1992/orgs","repos_url":"https://api.github.com/users/lordy1992/repos","events_url":"https://api.github.com/users/lordy1992/events{/privacy}","received_events_url":"https://api.github.com/users/lordy1992/received_events","type":"User","site_admin":false},"repo":{"id":24390776,"name":"ProjectMidas","full_name":"lordy1992/ProjectMidas","owner":{"login":"lordy1992","id":1761555,"avatar_url":"https://avatars.githubusercontent.com/u/1761555?v=3","gravatar_id":"","url":"https://api.github.com/users/lordy1992","html_url":"https://github.com/lordy1992","followers_url":"https://api.github.com/users/lordy1992/followers","following_url":"https://api.github.com/users/lordy1992/following{/other_user}","gists_url":"https://api.github.com/users/lordy1992/gists{/gist_id}","starred_url":"https://api.github.com/users/lordy1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordy1992/subscriptions","organizations_url":"https://api.github.com/users/lordy1992/orgs","repos_url":"https://api.github.com/users/lordy1992/repos","events_url":"https://api.github.com/users/lordy1992/events{/privacy}","received_events_url":"https://api.github.com/users/lordy1992/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lordy1992/ProjectMidas","description":"A wearable interface for the Windows OS, replacing various peripherals.","fork":false,"url":"https://api.github.com/repos/lordy1992/ProjectMidas","forks_url":"https://api.github.com/repos/lordy1992/ProjectMidas/forks","keys_url":"https://api.github.com/repos/lordy1992/ProjectMidas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lordy1992/ProjectMidas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lordy1992/ProjectMidas/teams","hooks_url":"https://api.github.com/repos/lordy1992/ProjectMidas/hooks","issue_events_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/events{/number}","events_url":"https://api.github.com/repos/lordy1992/ProjectMidas/events","assignees_url":"https://api.github.com/repos/lordy1992/ProjectMidas/assignees{/user}","branches_url":"https://api.github.com/repos/lordy1992/ProjectMidas/branches{/branch}","tags_url":"https://api.github.com/repos/lordy1992/ProjectMidas/tags","blobs_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/refs{/sha}","trees_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lordy1992/ProjectMidas/statuses/{sha}","languages_url":"https://api.github.com/repos/lordy1992/ProjectMidas/languages","stargazers_url":"https://api.github.com/repos/lordy1992/ProjectMidas/stargazers","contributors_url":"https://api.github.com/repos/lordy1992/ProjectMidas/contributors","subscribers_url":"https://api.github.com/repos/lordy1992/ProjectMidas/subscribers","subscription_url":"https://api.github.com/repos/lordy1992/ProjectMidas/subscription","commits_url":"https://api.github.com/repos/lordy1992/ProjectMidas/commits{/sha}","git_commits_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/commits{/sha}","comments_url":"https://api.github.com/repos/lordy1992/ProjectMidas/comments{/number}","issue_comment_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/comments/{number}","contents_url":"https://api.github.com/repos/lordy1992/ProjectMidas/contents/{+path}","compare_url":"https://api.github.com/repos/lordy1992/ProjectMidas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lordy1992/ProjectMidas/merges","archive_url":"https://api.github.com/repos/lordy1992/ProjectMidas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lordy1992/ProjectMidas/downloads","issues_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues{/number}","pulls_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls{/number}","milestones_url":"https://api.github.com/repos/lordy1992/ProjectMidas/milestones{/number}","notifications_url":"https://api.github.com/repos/lordy1992/ProjectMidas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lordy1992/ProjectMidas/labels{/name}","releases_url":"https://api.github.com/repos/lordy1992/ProjectMidas/releases{/id}","created_at":"2014-09-23T21:53:17Z","updated_at":"2015-01-28T00:03:33Z","pushed_at":"2015-01-29T21:41:53Z","git_url":"git://github.com/lordy1992/ProjectMidas.git","ssh_url":"git@github.com:lordy1992/ProjectMidas.git","clone_url":"https://github.com/lordy1992/ProjectMidas.git","svn_url":"https://github.com/lordy1992/ProjectMidas","homepage":null,"size":50668,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"lordy1992:master","ref":"master","sha":"6da31f7c76ce6b5556e5572c482355257d7e219e","user":{"login":"lordy1992","id":1761555,"avatar_url":"https://avatars.githubusercontent.com/u/1761555?v=3","gravatar_id":"","url":"https://api.github.com/users/lordy1992","html_url":"https://github.com/lordy1992","followers_url":"https://api.github.com/users/lordy1992/followers","following_url":"https://api.github.com/users/lordy1992/following{/other_user}","gists_url":"https://api.github.com/users/lordy1992/gists{/gist_id}","starred_url":"https://api.github.com/users/lordy1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordy1992/subscriptions","organizations_url":"https://api.github.com/users/lordy1992/orgs","repos_url":"https://api.github.com/users/lordy1992/repos","events_url":"https://api.github.com/users/lordy1992/events{/privacy}","received_events_url":"https://api.github.com/users/lordy1992/received_events","type":"User","site_admin":false},"repo":{"id":24390776,"name":"ProjectMidas","full_name":"lordy1992/ProjectMidas","owner":{"login":"lordy1992","id":1761555,"avatar_url":"https://avatars.githubusercontent.com/u/1761555?v=3","gravatar_id":"","url":"https://api.github.com/users/lordy1992","html_url":"https://github.com/lordy1992","followers_url":"https://api.github.com/users/lordy1992/followers","following_url":"https://api.github.com/users/lordy1992/following{/other_user}","gists_url":"https://api.github.com/users/lordy1992/gists{/gist_id}","starred_url":"https://api.github.com/users/lordy1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordy1992/subscriptions","organizations_url":"https://api.github.com/users/lordy1992/orgs","repos_url":"https://api.github.com/users/lordy1992/repos","events_url":"https://api.github.com/users/lordy1992/events{/privacy}","received_events_url":"https://api.github.com/users/lordy1992/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lordy1992/ProjectMidas","description":"A wearable interface for the Windows OS, replacing various peripherals.","fork":false,"url":"https://api.github.com/repos/lordy1992/ProjectMidas","forks_url":"https://api.github.com/repos/lordy1992/ProjectMidas/forks","keys_url":"https://api.github.com/repos/lordy1992/ProjectMidas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lordy1992/ProjectMidas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lordy1992/ProjectMidas/teams","hooks_url":"https://api.github.com/repos/lordy1992/ProjectMidas/hooks","issue_events_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/events{/number}","events_url":"https://api.github.com/repos/lordy1992/ProjectMidas/events","assignees_url":"https://api.github.com/repos/lordy1992/ProjectMidas/assignees{/user}","branches_url":"https://api.github.com/repos/lordy1992/ProjectMidas/branches{/branch}","tags_url":"https://api.github.com/repos/lordy1992/ProjectMidas/tags","blobs_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/refs{/sha}","trees_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lordy1992/ProjectMidas/statuses/{sha}","languages_url":"https://api.github.com/repos/lordy1992/ProjectMidas/languages","stargazers_url":"https://api.github.com/repos/lordy1992/ProjectMidas/stargazers","contributors_url":"https://api.github.com/repos/lordy1992/ProjectMidas/contributors","subscribers_url":"https://api.github.com/repos/lordy1992/ProjectMidas/subscribers","subscription_url":"https://api.github.com/repos/lordy1992/ProjectMidas/subscription","commits_url":"https://api.github.com/repos/lordy1992/ProjectMidas/commits{/sha}","git_commits_url":"https://api.github.com/repos/lordy1992/ProjectMidas/git/commits{/sha}","comments_url":"https://api.github.com/repos/lordy1992/ProjectMidas/comments{/number}","issue_comment_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/comments/{number}","contents_url":"https://api.github.com/repos/lordy1992/ProjectMidas/contents/{+path}","compare_url":"https://api.github.com/repos/lordy1992/ProjectMidas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lordy1992/ProjectMidas/merges","archive_url":"https://api.github.com/repos/lordy1992/ProjectMidas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lordy1992/ProjectMidas/downloads","issues_url":"https://api.github.com/repos/lordy1992/ProjectMidas/issues{/number}","pulls_url":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls{/number}","milestones_url":"https://api.github.com/repos/lordy1992/ProjectMidas/milestones{/number}","notifications_url":"https://api.github.com/repos/lordy1992/ProjectMidas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lordy1992/ProjectMidas/labels{/name}","releases_url":"https://api.github.com/repos/lordy1992/ProjectMidas/releases{/id}","created_at":"2014-09-23T21:53:17Z","updated_at":"2015-01-28T00:03:33Z","pushed_at":"2015-01-29T21:41:53Z","git_url":"git://github.com/lordy1992/ProjectMidas.git","ssh_url":"git@github.com:lordy1992/ProjectMidas.git","clone_url":"https://github.com/lordy1992/ProjectMidas.git","svn_url":"https://github.com/lordy1992/ProjectMidas","homepage":null,"size":50668,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32"},"html":{"href":"https://github.com/lordy1992/ProjectMidas/pull/32"},"issue":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/32"},"comments":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/lordy1992/ProjectMidas/statuses/97438213e7cd0bd9fbc933c9335d8d5dbb78d1a0"}}}}