{"push_id":845716224,"size":61,"distinct_size":61,"ref":"refs/heads/filteringworkaround","head":"f124cd7f28bfd73b760d16b77cb97b631c074823","before":"68f298e4d61890a2ff62e8918b21467aedab0095","commits":[{"sha":"a95e0d726be4cfb9df4c098d798a684d152e2652","author":{"email":"d131939c23330f3c945ed5437217aca3c84079c2@gmail.com","name":"Jared Parsons"},"message":"Unix Mono change\n\nUse the same threads per CPU limit DNX uses.","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/a95e0d726be4cfb9df4c098d798a684d152e2652"},{"sha":"a18fa6b982ece3a98fd1f62a408896d2c5c163b8","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Add a command handler for pasting from interactive window","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/a18fa6b982ece3a98fd1f62a408896d2c5c163b8"},{"sha":"ff26a31046aa65060c4b812062b9eff3f4303543","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Make all operations in Paste a single undo transection","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/ff26a31046aa65060c4b812062b9eff3f4303543"},{"sha":"dbe613ff5fac9c4eb52e56e397a4a1019e041042","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Merge remote-tracking branch 'dotnet/stabilization' into FixUntoStable","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/dbe613ff5fac9c4eb52e56e397a4a1019e041042"},{"sha":"fa0e0b0747825cf956a6a0e0404612e98adcb041","author":{"email":"1c08efb9b3965701be9d700d9a6f481f1ffec3ea@teamcampbell.org","name":"Dustin Campbell"},"message":"Fix VB incorrectly reported redundant casts in compound assignment statements\n\nConsider the following code:\n\n```VB\nDim b As Byte\nb += CByte(1)\n```\n\nThe `CByte` cast can be removed if the Option Strict is Off. However, if Option Strict is On, the compiler\nproduces an error (\"Option Strict On disallows implicit conversions from 'Integer' to 'Byte'\").\n\nThe issue here is that compound statements are not considered by unnecessary cast detection. Unfortunately,\nsupporting is not as straight forward as I'd hoped for a couple of reasons:\n\n1. There is no compiler API to get the built-in operator used by a VB assignment statement. If there were, this\nwould be a straightforward fix since removing the cast results in the compiler choosing `System.Int32.op_Add(Int32, Int32)`\nrather than `System.Byte.op_Add(Byte, Byte)`.\n\n2. There is a hidden narrowing-numeric conversion of a constant value in the following code:\n\n```VB\nb += 1\n```\n\nUsing the compiler API to classify conversion from the expression `1` to the type of `b` results in a\nwidening-numeric conversion, which is misleading since the type of `1` is `System.Int32` and the type of `b`\nis `System.Byte`.\n\nFixing the problem requires two changes:\n\n1. Actually support assignment statements in the speculative analyzer and check to see if replacment would break\nthe compound assignment.\n2. Add a special case in the VB speculative analyzer in the case that Option Strict is not Off and the expression\nhas a constant value. In that case, we use a different compiler API to classify *the type of the expression* `1` to\nthe type of `b`, rather than classifying *the expression* `1` to the type of `b`.","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/fa0e0b0747825cf956a6a0e0404612e98adcb041"},{"sha":"77384e88cebd26785c95251c2304815c938d4fb7","author":{"email":"d730d825a7ed112a6b950b3a94d1011b757d272e@microsoft.com","name":"Cyrus Najmabadi"},"message":"Don't crash when we hear about very stale diagnostics for our current Document.","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/77384e88cebd26785c95251c2304815c938d4fb7"},{"sha":"439a3908e046ab56d5ceeaabff107fdaaa486e8a","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Create an `ITextBufferUndoManager` for each `LanguageBuffer`\n\nAlso add unti test.","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/439a3908e046ab56d5ceeaabff107fdaaa486e8a"},{"sha":"519859d825644020ec76231b3df48d38658e45dd","author":{"email":"4a8d3ac07592bba5205a9da73d77b800f0e41887@microsoft.com","name":"Tomas Matousek"},"message":"Update Microsoft.DiaSymReader.Native to 1.0.3","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/519859d825644020ec76231b3df48d38658e45dd"},{"sha":"d7f6bc5035ccb50e4e37c8626f1293c752f19ee8","author":{"email":"1c08efb9b3965701be9d700d9a6f481f1ffec3ea@teamcampbell.org","name":"Dustin Campbell"},"message":"Merge pull request #6361 from DustinCampbell/issue-2560\n\nFix VB incorrectly reported redundant casts in compound assignment statements","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/d7f6bc5035ccb50e4e37c8626f1293c752f19ee8"},{"sha":"ab6328f18173cce38b0fac5cd6053aa2f9042b45","author":{"email":"4a8d3ac07592bba5205a9da73d77b800f0e41887@microsoft.com","name":"Tomas Matousek"},"message":"Enable deterministic tests","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/ab6328f18173cce38b0fac5cd6053aa2f9042b45"},{"sha":"51769e6a2929153b0312591fa49898e46c990242","author":{"email":"4a8d3ac07592bba5205a9da73d77b800f0e41887@microsoft.com","name":"Tomas Matousek"},"message":"Update System.Reflection.Metadata to 1.1.0","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/51769e6a2929153b0312591fa49898e46c990242"},{"sha":"18d4f854900293aa6b8052966f6c530bf6ea8e18","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Add a command handler for pasting from interactive window","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/18d4f854900293aa6b8052966f6c530bf6ea8e18"},{"sha":"c0b63ecbdc46842394881438bac362cc58e74c4a","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Fix typo and add comments to `InteractivePasteCommandHandler`","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/c0b63ecbdc46842394881438bac362cc58e74c4a"},{"sha":"89022b1392c719421ee9bf398bdbbf7456a705eb","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Merge branch 'stabilization' into IntactivePasteMaster","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/89022b1392c719421ee9bf398bdbbf7456a705eb"},{"sha":"b78dd596b6301e2842d43bc6207f96dd0ca356be","author":{"email":"c8eebda5721871f2cc46d06a4352de00da72a01b@microsoft.com","name":"Gen Lu"},"message":"Merge remote-tracking branch 'dotnet/stabilization' into InteractivePasteStable","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/b78dd596b6301e2842d43bc6207f96dd0ca356be"},{"sha":"188f6a637845dfedc15f3502ec70180f52e11631","author":{"email":"4a8d3ac07592bba5205a9da73d77b800f0e41887@microsoft.com","name":"Tomas Matousek"},"message":"Implement metadata version supersession for script compilation","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/188f6a637845dfedc15f3502ec70180f52e11631"},{"sha":"c0947d4ed77c5575e1dee9f686af99695204fc04","author":{"email":"4fbe3a9246a95037cd16b91bb6d9711069f06b47@microsoft.com","name":"Kevin Pilch-Bisson"},"message":"Support Edit.NextMethod and Edit.PreviousMethod commands\n\nConflicts:\n\tsrc/EditorFeatures/Core/EditorFeatures.csproj","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/c0947d4ed77c5575e1dee9f686af99695204fc04"},{"sha":"fe411ba6548c8a9a6cef21cf6ba3166724acaf2e","author":{"email":"4fbe3a9246a95037cd16b91bb6d9711069f06b47@microsoft.com","name":"Kevin Pilch-Bisson"},"message":"Remove and sort usings","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/fe411ba6548c8a9a6cef21cf6ba3166724acaf2e"},{"sha":"07a1b289c834db2ae1efbcf5c546f4a849073e68","author":{"email":"4fbe3a9246a95037cd16b91bb6d9711069f06b47@microsoft.com","name":"Kevin Pilch-Bisson"},"message":"Add test files","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/07a1b289c834db2ae1efbcf5c546f4a849073e68"},{"sha":"ab9cd4cd31f57b4f820d1648096e87c2c3380ab4","author":{"email":"4fbe3a9246a95037cd16b91bb6d9711069f06b47@microsoft.com","name":"Kevin Pilch-Bisson"},"message":"First test.","distinct":true,"url":"https://api.github.com/repos/rchande/roslyn/commits/ab9cd4cd31f57b4f820d1648096e87c2c3380ab4"}]}