{"action":"created","issue":{"url":"https://api.github.com/repos/tgriesser/knex/issues/641","labels_url":"https://api.github.com/repos/tgriesser/knex/issues/641/labels{/name}","comments_url":"https://api.github.com/repos/tgriesser/knex/issues/641/comments","events_url":"https://api.github.com/repos/tgriesser/knex/issues/641/events","html_url":"https://github.com/tgriesser/knex/pull/641","id":55204885,"number":641,"title":"FoundationDB SQL Layer Adapter","user":{"login":"gjvargas","id":5428742,"avatar_url":"https://avatars.githubusercontent.com/u/5428742?v=3","gravatar_id":"","url":"https://api.github.com/users/gjvargas","html_url":"https://github.com/gjvargas","followers_url":"https://api.github.com/users/gjvargas/followers","following_url":"https://api.github.com/users/gjvargas/following{/other_user}","gists_url":"https://api.github.com/users/gjvargas/gists{/gist_id}","starred_url":"https://api.github.com/users/gjvargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjvargas/subscriptions","organizations_url":"https://api.github.com/users/gjvargas/orgs","repos_url":"https://api.github.com/users/gjvargas/repos","events_url":"https://api.github.com/users/gjvargas/events{/privacy}","received_events_url":"https://api.github.com/users/gjvargas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-01-22T20:32:25Z","updated_at":"2015-01-22T21:57:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgriesser/knex/pulls/641","html_url":"https://github.com/tgriesser/knex/pull/641","diff_url":"https://github.com/tgriesser/knex/pull/641.diff","patch_url":"https://github.com/tgriesser/knex/pull/641.patch"},"body":"I've added support for a FoundationDB SQL Layer knex adapter. I tried my best to follow the style of code throughout the project. The FDB SQL layer code was adapted from the PostgreSQL code. I also updated the test directory to include both unit tests and integration tests for the fdbsql adapter.\r\n\r\nFor more information about the newly supported database, see here: https://foundationdb.com/\r\n\r\nPleas don't hesitate to contact me for questions and comments.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/tgriesser/knex/issues/comments/71107407","html_url":"https://github.com/tgriesser/knex/pull/641#issuecomment-71107407","issue_url":"https://api.github.com/repos/tgriesser/knex/issues/641","id":71107407,"user":{"login":"tgriesser","id":154748,"avatar_url":"https://avatars.githubusercontent.com/u/154748?v=3","gravatar_id":"","url":"https://api.github.com/users/tgriesser","html_url":"https://github.com/tgriesser","followers_url":"https://api.github.com/users/tgriesser/followers","following_url":"https://api.github.com/users/tgriesser/following{/other_user}","gists_url":"https://api.github.com/users/tgriesser/gists{/gist_id}","starred_url":"https://api.github.com/users/tgriesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgriesser/subscriptions","organizations_url":"https://api.github.com/users/tgriesser/orgs","repos_url":"https://api.github.com/users/tgriesser/repos","events_url":"https://api.github.com/users/tgriesser/events{/privacy}","received_events_url":"https://api.github.com/users/tgriesser/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T21:57:45Z","updated_at":"2015-01-22T21:57:45Z","body":"What Ben failed to mention though, is awesome work on putting this together @gjvargas!\r\n\r\nKnex's internals are definitely getting a little hairy but should be looking really nice in the coming weeks as I'm going to dive back into things with a fresh look on modularity and coming up with an approach to use transducers throughout the codebase for consistent parsing and query generation.\r\n\r\nAll that said, Ben and I will take a look through and ask any questions."}}