{"action":"created","comment":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments/26908260","id":26908260,"diff_hunk":"@@ -333,6 +333,15 @@ native ActivateEntity(entity);\n native SetClientInfo(client, const String:key[], const String:value[]);\r\n \r\n /**\r\n+ * Something\r","path":"plugins/include/sdktools_functions.inc","position":null,"original_position":4,"commit_id":"53f9bb04023531ffa6e54634f67476e4f5322db5","original_commit_id":"885117fb661e8edc73289acb4e90ae6b1ece9cb0","user":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=3","gravatar_id":"","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"body":"Thanks. This is fixed now.","created_at":"2015-03-22T22:56:46Z","updated_at":"2015-03-22T22:56:46Z","html_url":"https://github.com/alliedmodders/sourcemod/pull/313#discussion_r26908260","pull_request_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313","_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments/26908260"},"html":{"href":"https://github.com/alliedmodders/sourcemod/pull/313#discussion_r26908260"},"pull_request":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313"}}},"pull_request":{"url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313","id":31696665,"html_url":"https://github.com/alliedmodders/sourcemod/pull/313","diff_url":"https://github.com/alliedmodders/sourcemod/pull/313.diff","patch_url":"https://github.com/alliedmodders/sourcemod/pull/313.patch","issue_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/313","number":313,"state":"open","locked":false,"title":"Add SetClientName native.","user":{"login":"psychonic","id":844118,"avatar_url":"https://avatars.githubusercontent.com/u/844118?v=3","gravatar_id":"","url":"https://api.github.com/users/psychonic","html_url":"https://github.com/psychonic","followers_url":"https://api.github.com/users/psychonic/followers","following_url":"https://api.github.com/users/psychonic/following{/other_user}","gists_url":"https://api.github.com/users/psychonic/gists{/gist_id}","starred_url":"https://api.github.com/users/psychonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychonic/subscriptions","organizations_url":"https://api.github.com/users/psychonic/orgs","repos_url":"https://api.github.com/users/psychonic/repos","events_url":"https://api.github.com/users/psychonic/events{/privacy}","received_events_url":"https://api.github.com/users/psychonic/received_events","type":"User","site_admin":false},"body":"Our current method for changing names (SetUserInfo), as implemented in the sm_rename command, does not work on the top three games by SM install count - TF2 (temporarily due to game bug, this works around), CS:S, and CS:GO. There may be others as well.\r\n\r\nBy implementing a new SetClientName native to wrap CBaseClient::SetName, we gain better game compatibility as well as bypass name change cooldown restrictions in the engine. SetName is one function earlier in the same vtable as SetUserInfo for every supported game, so there's very little extra support burden.\r\n\r\nI've also updated the playercommands plugin to use the new native for sm_rename. I removed the old, ep1-specific logic and message for name changes while dead, too. The game logic it was considering was actually specific to CS:S, not the ep1 base, and hasn't been present in CS:S since the Orangebox port years ago.\r\n\r\nHowever, due to some of the legacy code in CS:S, a hook on IVEngineServer::ClientCommand was added to block changes of the client \"name\" convar sent from the server. Any change to that client convar in Orangebox or later now resets the client's name to their Steam name.\r\n\r\n@GoD-Tony \r\n@KyleSanderson ","created_at":"2015-03-22T22:41:07Z","updated_at":"2015-03-22T22:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6fea01d03e4e16a695a3ad6c3fdf1f3728c9455","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313/commits","review_comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313/comments","review_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/313/comments","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/53f9bb04023531ffa6e54634f67476e4f5322db5","head":{"label":"alliedmodders:set-client-name","ref":"set-client-name","sha":"53f9bb04023531ffa6e54634f67476e4f5322db5","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","created_at":"2014-05-25T02:58:39Z","updated_at":"2015-03-21T22:54:09Z","pushed_at":"2015-03-22T22:56:15Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":50012,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":19,"forks":44,"open_issues":19,"watchers":98,"default_branch":"master"}},"base":{"label":"alliedmodders:master","ref":"master","sha":"4b8a581c9ada0d957b87ad1b7f50d20d7b5f830a","user":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"repo":{"id":20145274,"name":"sourcemod","full_name":"alliedmodders/sourcemod","owner":{"login":"alliedmodders","id":6601917,"avatar_url":"https://avatars.githubusercontent.com/u/6601917?v=3","gravatar_id":"","url":"https://api.github.com/users/alliedmodders","html_url":"https://github.com/alliedmodders","followers_url":"https://api.github.com/users/alliedmodders/followers","following_url":"https://api.github.com/users/alliedmodders/following{/other_user}","gists_url":"https://api.github.com/users/alliedmodders/gists{/gist_id}","starred_url":"https://api.github.com/users/alliedmodders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alliedmodders/subscriptions","organizations_url":"https://api.github.com/users/alliedmodders/orgs","repos_url":"https://api.github.com/users/alliedmodders/repos","events_url":"https://api.github.com/users/alliedmodders/events{/privacy}","received_events_url":"https://api.github.com/users/alliedmodders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alliedmodders/sourcemod","description":"SourceMod - Source Engine Scripting and Administration","fork":false,"url":"https://api.github.com/repos/alliedmodders/sourcemod","forks_url":"https://api.github.com/repos/alliedmodders/sourcemod/forks","keys_url":"https://api.github.com/repos/alliedmodders/sourcemod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alliedmodders/sourcemod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alliedmodders/sourcemod/teams","hooks_url":"https://api.github.com/repos/alliedmodders/sourcemod/hooks","issue_events_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/events{/number}","events_url":"https://api.github.com/repos/alliedmodders/sourcemod/events","assignees_url":"https://api.github.com/repos/alliedmodders/sourcemod/assignees{/user}","branches_url":"https://api.github.com/repos/alliedmodders/sourcemod/branches{/branch}","tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/tags","blobs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/refs{/sha}","trees_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/{sha}","languages_url":"https://api.github.com/repos/alliedmodders/sourcemod/languages","stargazers_url":"https://api.github.com/repos/alliedmodders/sourcemod/stargazers","contributors_url":"https://api.github.com/repos/alliedmodders/sourcemod/contributors","subscribers_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscribers","subscription_url":"https://api.github.com/repos/alliedmodders/sourcemod/subscription","commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/commits{/sha}","git_commits_url":"https://api.github.com/repos/alliedmodders/sourcemod/git/commits{/sha}","comments_url":"https://api.github.com/repos/alliedmodders/sourcemod/comments{/number}","issue_comment_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues/comments{/number}","contents_url":"https://api.github.com/repos/alliedmodders/sourcemod/contents/{+path}","compare_url":"https://api.github.com/repos/alliedmodders/sourcemod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alliedmodders/sourcemod/merges","archive_url":"https://api.github.com/repos/alliedmodders/sourcemod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alliedmodders/sourcemod/downloads","issues_url":"https://api.github.com/repos/alliedmodders/sourcemod/issues{/number}","pulls_url":"https://api.github.com/repos/alliedmodders/sourcemod/pulls{/number}","milestones_url":"https://api.github.com/repos/alliedmodders/sourcemod/milestones{/number}","notifications_url":"https://api.github.com/repos/alliedmodders/sourcemod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alliedmodders/sourcemod/labels{/name}","releases_url":"https://api.github.com/repos/alliedmodders/sourcemod/releases{/id}","created_at":"2014-05-25T02:58:39Z","updated_at":"2015-03-21T22:54:09Z","pushed_at":"2015-03-22T22:56:15Z","git_url":"git://github.com/alliedmodders/sourcemod.git","ssh_url":"git@github.com:alliedmodders/sourcemod.git","clone_url":"https://github.com/alliedmodders/sourcemod.git","svn_url":"https://github.com/alliedmodders/sourcemod","homepage":"http://www.sourcemod.net/","size":50012,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":19,"forks":44,"open_issues":19,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313"},"html":{"href":"https://github.com/alliedmodders/sourcemod/pull/313"},"issue":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/313"},"comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/alliedmodders/sourcemod/statuses/53f9bb04023531ffa6e54634f67476e4f5322db5"}}}}