{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/43057575","id":43057575,"diff_hunk":"@@ -3,49 +3,51 @@\n confine :except, :platform => ['windows']\n confine :except, :platform => /osx/ # See PUP-4823\n confine :except, :platform => /solaris/\n-confine :except, :platform => /aix/\n \n-fstab = '/etc/fstab'\n+require 'puppet/acceptance/mount_utils'\n+extend Puppet::Acceptance::MountUtils\n+\n name = \"pl#{rand(999999).to_i}\"\n \n agents.each do |agent|\n+  fs_file = filesystem_file(agent)\n+\n   teardown do\n-    #(teardown) restore the fstab file\n-    on(agent, \"mv /tmp/fstab #{fstab}\", :acceptable_exit_codes => (0..254))\n     #(teardown) umount disk image\n     on(agent, \"umount /#{name}\", :acceptable_exit_codes => (0..254))\n     #(teardown) delete disk image\n-    on(agent, \"rm /tmp/#{name}\", :acceptable_exit_codes => (0..254))\n+    if agent['platform'] =~ /aix/\n+      on(agent, \"yes | rmlv #{name}\")","path":"acceptance/tests/resource/mount/destroy.rb","position":23,"original_position":23,"commit_id":"9aa30fa62bf3b0a0d49845832329b85ce46f489a","original_commit_id":"9aa30fa62bf3b0a0d49845832329b85ce46f489a","user":{"login":"johnduarte","id":1040859,"avatar_url":"https://avatars.githubusercontent.com/u/1040859?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduarte","html_url":"https://github.com/johnduarte","followers_url":"https://api.github.com/users/johnduarte/followers","following_url":"https://api.github.com/users/johnduarte/following{/other_user}","gists_url":"https://api.github.com/users/johnduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduarte/subscriptions","organizations_url":"https://api.github.com/users/johnduarte/orgs","repos_url":"https://api.github.com/users/johnduarte/repos","events_url":"https://api.github.com/users/johnduarte/events{/privacy}","received_events_url":"https://api.github.com/users/johnduarte/received_events","type":"User","site_admin":false},"body":"Will this return a non-zero exit code if the logical volume was never created?","created_at":"2015-10-26T21:42:54Z","updated_at":"2015-10-26T21:42:54Z","html_url":"https://github.com/puppetlabs/puppet/pull/4363#discussion_r43057575","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/43057575"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4363#discussion_r43057575"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363","id":48274080,"html_url":"https://github.com/puppetlabs/puppet/pull/4363","diff_url":"https://github.com/puppetlabs/puppet/pull/4363.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/4363.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4363","number":4363,"state":"open","locked":false,"title":"(PUP-5339) Update mount tests to work in AIX","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"body":"(PUP-5339) Add mount_utils acceptance helper library\r\n\r\nThis commit adds new helpers to assist with dealing with mountpoints\r\nand fstab on testing hosts. It is used in the suite of mount resource tests.\r\n\r\n(PUP-5339) Update mount tests to work in AIX\r\n\r\nThis commit updates each of the mount resource tests to work in\r\nAIX. The main difference between AIX and regular Linuxes is that\r\nwe need to use `crfs` to properly create a filesystem. Slight\r\nmodifications have been made to deal with the small differences\r\nin setup before running puppet.\r\n","created_at":"2015-10-21T00:08:26Z","updated_at":"2015-10-26T21:42:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8714cac4079a0dfd4108006b631805b7ca6963ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/4363/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/9aa30fa62bf3b0a0d49845832329b85ce46f489a","head":{"label":"whopper:PUP-5339/stable/aix_mount_tests","ref":"PUP-5339/stable/aix_mount_tests","sha":"9aa30fa62bf3b0a0d49845832329b85ce46f489a","user":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"repo":{"id":4678592,"name":"puppet","full_name":"whopper/puppet","owner":{"login":"whopper","id":507621,"avatar_url":"https://avatars.githubusercontent.com/u/507621?v=3","gravatar_id":"","url":"https://api.github.com/users/whopper","html_url":"https://github.com/whopper","followers_url":"https://api.github.com/users/whopper/followers","following_url":"https://api.github.com/users/whopper/following{/other_user}","gists_url":"https://api.github.com/users/whopper/gists{/gist_id}","starred_url":"https://api.github.com/users/whopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whopper/subscriptions","organizations_url":"https://api.github.com/users/whopper/orgs","repos_url":"https://api.github.com/users/whopper/repos","events_url":"https://api.github.com/users/whopper/events{/privacy}","received_events_url":"https://api.github.com/users/whopper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whopper/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/whopper/puppet","forks_url":"https://api.github.com/repos/whopper/puppet/forks","keys_url":"https://api.github.com/repos/whopper/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whopper/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whopper/puppet/teams","hooks_url":"https://api.github.com/repos/whopper/puppet/hooks","issue_events_url":"https://api.github.com/repos/whopper/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/whopper/puppet/events","assignees_url":"https://api.github.com/repos/whopper/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/whopper/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/whopper/puppet/tags","blobs_url":"https://api.github.com/repos/whopper/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whopper/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whopper/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/whopper/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whopper/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/whopper/puppet/languages","stargazers_url":"https://api.github.com/repos/whopper/puppet/stargazers","contributors_url":"https://api.github.com/repos/whopper/puppet/contributors","subscribers_url":"https://api.github.com/repos/whopper/puppet/subscribers","subscription_url":"https://api.github.com/repos/whopper/puppet/subscription","commits_url":"https://api.github.com/repos/whopper/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/whopper/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/whopper/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/whopper/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/whopper/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/whopper/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whopper/puppet/merges","archive_url":"https://api.github.com/repos/whopper/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whopper/puppet/downloads","issues_url":"https://api.github.com/repos/whopper/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/whopper/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/whopper/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/whopper/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whopper/puppet/labels{/name}","releases_url":"https://api.github.com/repos/whopper/puppet/releases{/id}","created_at":"2012-06-15T18:31:29Z","updated_at":"2014-09-29T18:19:22Z","pushed_at":"2015-10-26T21:16:55Z","git_url":"git://github.com/whopper/puppet.git","ssh_url":"git@github.com:whopper/puppet.git","clone_url":"https://github.com/whopper/puppet.git","svn_url":"https://github.com/whopper/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":53853,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"puppetlabs:stable","ref":"stable","sha":"b88d6d8ed1a01c5f1d71883594d93e728e72380b","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","created_at":"2010-09-14T19:26:44Z","updated_at":"2015-10-24T04:17:53Z","pushed_at":"2015-10-26T21:16:56Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppetlabs.com/puppet/what-is-puppet","size":140298,"stargazers_count":3602,"watchers_count":3602,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1498,"mirror_url":null,"open_issues_count":31,"forks":1498,"open_issues":31,"watchers":3602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/4363"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4363"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/4363/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/4363/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/9aa30fa62bf3b0a0d49845832329b85ce46f489a"}}}}