{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/comments/42509761","id":42509761,"diff_hunk":"@@ -27,6 +27,9 @@ def self.instances\n         when /^olcSuffix: /\n           suffix = line.split(' ')[1]\n         when /^olcAccess: /\n+          if suffix == nil\n+              suffix = 'cn=config'","path":"lib/puppet/provider/openldap_access/olc.rb","position":5,"original_position":5,"commit_id":"37fa25573416dafc9cf0a6610b974f8d715a1d9b","original_commit_id":"37fa25573416dafc9cf0a6610b974f8d715a1d9b","user":{"login":"mcanevet","id":2950673,"avatar_url":"https://avatars.githubusercontent.com/u/2950673?v=3","gravatar_id":"","url":"https://api.github.com/users/mcanevet","html_url":"https://github.com/mcanevet","followers_url":"https://api.github.com/users/mcanevet/followers","following_url":"https://api.github.com/users/mcanevet/following{/other_user}","gists_url":"https://api.github.com/users/mcanevet/gists{/gist_id}","starred_url":"https://api.github.com/users/mcanevet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcanevet/subscriptions","organizations_url":"https://api.github.com/users/mcanevet/orgs","repos_url":"https://api.github.com/users/mcanevet/repos","events_url":"https://api.github.com/users/mcanevet/events{/privacy}","received_events_url":"https://api.github.com/users/mcanevet/received_events","type":"User","site_admin":false},"body":"Please use only 2sp","created_at":"2015-10-20T15:19:27Z","updated_at":"2015-10-20T15:19:27Z","html_url":"https://github.com/camptocamp/puppet-openldap/pull/93#discussion_r42509761","pull_request_url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/comments/42509761"},"html":{"href":"https://github.com/camptocamp/puppet-openldap/pull/93#discussion_r42509761"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93","id":48213084,"html_url":"https://github.com/camptocamp/puppet-openldap/pull/93","diff_url":"https://github.com/camptocamp/puppet-openldap/pull/93.diff","patch_url":"https://github.com/camptocamp/puppet-openldap/pull/93.patch","issue_url":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/93","number":93,"state":"open","locked":false,"title":"Refactor openldap::server::access","user":{"login":"kronos-pbrideau","id":1564589,"avatar_url":"https://avatars.githubusercontent.com/u/1564589?v=3","gravatar_id":"","url":"https://api.github.com/users/kronos-pbrideau","html_url":"https://github.com/kronos-pbrideau","followers_url":"https://api.github.com/users/kronos-pbrideau/followers","following_url":"https://api.github.com/users/kronos-pbrideau/following{/other_user}","gists_url":"https://api.github.com/users/kronos-pbrideau/gists{/gist_id}","starred_url":"https://api.github.com/users/kronos-pbrideau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronos-pbrideau/subscriptions","organizations_url":"https://api.github.com/users/kronos-pbrideau/orgs","repos_url":"https://api.github.com/users/kronos-pbrideau/repos","events_url":"https://api.github.com/users/kronos-pbrideau/events{/privacy}","received_events_url":"https://api.github.com/users/kronos-pbrideau/received_events","type":"User","site_admin":false},"body":"For #54 , here is what I have done with it.\r\n\r\nYou still can use the old syntax, but you now can do:\r\n\r\n```\r\nopenldap::server::access {\r\n  'acl 1' :\r\n    suffix   => 'dc=example,dc=com',\r\n    position => '1',\r\n    what     => 'attrs=userPassword,shadowLastChange',\r\n    by       => 'dn=\"cn=admin,dc=example,dc=com\"',\r\n    access   => 'write',\r\n}\r\n```\r\n\r\nAnd i've create a wrapper to use like so:\r\n```\r\n$acl_hash = {\r\n  'acl 1' => {\r\n    suffix   => 'dc=example,dc=com',\r\n    position => '1',\r\n    what     => 'attrs=userPassword,shadowLastChange',\r\n    by       => 'dn=\"cn=admin,dc=example,dc=com\"',\r\n    access   => 'write',\r\n  },\r\n}\r\n\r\n$acl_hash_keys = keys($acl_hash)\r\nopenldap::server::access_wrapper { $acl_hash_keys :\r\n  hash => $acl_hash,\r\n}\r\n```\r\n\r\nI've describe it into the README","created_at":"2015-10-20T15:03:37Z","updated_at":"2015-10-20T15:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"288cf496ab5f5868021686759d405dd5aa1969f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93/commits","review_comments_url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93/comments","review_comment_url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/93/comments","statuses_url":"https://api.github.com/repos/camptocamp/puppet-openldap/statuses/37fa25573416dafc9cf0a6610b974f8d715a1d9b","head":{"label":"kronos-pbrideau:patch-access","ref":"patch-access","sha":"37fa25573416dafc9cf0a6610b974f8d715a1d9b","user":{"login":"kronos-pbrideau","id":1564589,"avatar_url":"https://avatars.githubusercontent.com/u/1564589?v=3","gravatar_id":"","url":"https://api.github.com/users/kronos-pbrideau","html_url":"https://github.com/kronos-pbrideau","followers_url":"https://api.github.com/users/kronos-pbrideau/followers","following_url":"https://api.github.com/users/kronos-pbrideau/following{/other_user}","gists_url":"https://api.github.com/users/kronos-pbrideau/gists{/gist_id}","starred_url":"https://api.github.com/users/kronos-pbrideau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronos-pbrideau/subscriptions","organizations_url":"https://api.github.com/users/kronos-pbrideau/orgs","repos_url":"https://api.github.com/users/kronos-pbrideau/repos","events_url":"https://api.github.com/users/kronos-pbrideau/events{/privacy}","received_events_url":"https://api.github.com/users/kronos-pbrideau/received_events","type":"User","site_admin":false},"repo":{"id":34128126,"name":"puppet-openldap","full_name":"kronos-pbrideau/puppet-openldap","owner":{"login":"kronos-pbrideau","id":1564589,"avatar_url":"https://avatars.githubusercontent.com/u/1564589?v=3","gravatar_id":"","url":"https://api.github.com/users/kronos-pbrideau","html_url":"https://github.com/kronos-pbrideau","followers_url":"https://api.github.com/users/kronos-pbrideau/followers","following_url":"https://api.github.com/users/kronos-pbrideau/following{/other_user}","gists_url":"https://api.github.com/users/kronos-pbrideau/gists{/gist_id}","starred_url":"https://api.github.com/users/kronos-pbrideau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronos-pbrideau/subscriptions","organizations_url":"https://api.github.com/users/kronos-pbrideau/orgs","repos_url":"https://api.github.com/users/kronos-pbrideau/repos","events_url":"https://api.github.com/users/kronos-pbrideau/events{/privacy}","received_events_url":"https://api.github.com/users/kronos-pbrideau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kronos-pbrideau/puppet-openldap","description":"Manage OpenLDAP with Puppet","fork":true,"url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap","forks_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/forks","keys_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/teams","hooks_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/hooks","issue_events_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/issues/events{/number}","events_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/events","assignees_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/assignees{/user}","branches_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/branches{/branch}","tags_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/tags","blobs_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/statuses/{sha}","languages_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/languages","stargazers_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/stargazers","contributors_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/contributors","subscribers_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/subscribers","subscription_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/subscription","commits_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/contents/{+path}","compare_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/merges","archive_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/downloads","issues_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/issues{/number}","pulls_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/pulls{/number}","milestones_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/milestones{/number}","notifications_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/labels{/name}","releases_url":"https://api.github.com/repos/kronos-pbrideau/puppet-openldap/releases{/id}","created_at":"2015-04-17T16:42:05Z","updated_at":"2015-04-17T16:42:05Z","pushed_at":"2015-10-20T14:52:05Z","git_url":"git://github.com/kronos-pbrideau/puppet-openldap.git","ssh_url":"git@github.com:kronos-pbrideau/puppet-openldap.git","clone_url":"https://github.com/kronos-pbrideau/puppet-openldap.git","svn_url":"https://github.com/kronos-pbrideau/puppet-openldap","homepage":null,"size":536,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"43c948c41d9e70f23757f333c69cb1f9894b0cbf","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":16576257,"name":"puppet-openldap","full_name":"camptocamp/puppet-openldap","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/puppet-openldap","description":"Manage OpenLDAP with Puppet","fork":false,"url":"https://api.github.com/repos/camptocamp/puppet-openldap","forks_url":"https://api.github.com/repos/camptocamp/puppet-openldap/forks","keys_url":"https://api.github.com/repos/camptocamp/puppet-openldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/puppet-openldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/puppet-openldap/teams","hooks_url":"https://api.github.com/repos/camptocamp/puppet-openldap/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/puppet-openldap/events","assignees_url":"https://api.github.com/repos/camptocamp/puppet-openldap/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/puppet-openldap/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/puppet-openldap/tags","blobs_url":"https://api.github.com/repos/camptocamp/puppet-openldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/puppet-openldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/puppet-openldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/puppet-openldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/puppet-openldap/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/puppet-openldap/languages","stargazers_url":"https://api.github.com/repos/camptocamp/puppet-openldap/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/puppet-openldap/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/puppet-openldap/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/puppet-openldap/subscription","commits_url":"https://api.github.com/repos/camptocamp/puppet-openldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/puppet-openldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/puppet-openldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/puppet-openldap/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/puppet-openldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/puppet-openldap/merges","archive_url":"https://api.github.com/repos/camptocamp/puppet-openldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/puppet-openldap/downloads","issues_url":"https://api.github.com/repos/camptocamp/puppet-openldap/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/puppet-openldap/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/puppet-openldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/puppet-openldap/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/puppet-openldap/releases{/id}","created_at":"2014-02-06T10:42:49Z","updated_at":"2015-08-26T13:10:40Z","pushed_at":"2015-10-20T15:03:37Z","git_url":"git://github.com/camptocamp/puppet-openldap.git","ssh_url":"git@github.com:camptocamp/puppet-openldap.git","clone_url":"https://github.com/camptocamp/puppet-openldap.git","svn_url":"https://github.com/camptocamp/puppet-openldap","homepage":null,"size":2169,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":12,"forks":43,"open_issues":12,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93"},"html":{"href":"https://github.com/camptocamp/puppet-openldap/pull/93"},"issue":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/93"},"comments":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/puppet-openldap/statuses/37fa25573416dafc9cf0a6610b974f8d715a1d9b"}}}}