{"action":"created","issue":{"url":"https://api.github.com/repos/jrsmith3/tec/issues/55","labels_url":"https://api.github.com/repos/jrsmith3/tec/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/jrsmith3/tec/issues/55/comments","events_url":"https://api.github.com/repos/jrsmith3/tec/issues/55/events","html_url":"https://github.com/jrsmith3/tec/issues/55","id":54211258,"number":55,"title":"Convert some `TECBase` calc methods to attributes","user":{"login":"jrsmith3","id":204215,"avatar_url":"https://avatars.githubusercontent.com/u/204215?v=3","gravatar_id":"","url":"https://api.github.com/users/jrsmith3","html_url":"https://github.com/jrsmith3","followers_url":"https://api.github.com/users/jrsmith3/followers","following_url":"https://api.github.com/users/jrsmith3/following{/other_user}","gists_url":"https://api.github.com/users/jrsmith3/gists{/gist_id}","starred_url":"https://api.github.com/users/jrsmith3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrsmith3/subscriptions","organizations_url":"https://api.github.com/users/jrsmith3/orgs","repos_url":"https://api.github.com/users/jrsmith3/repos","events_url":"https://api.github.com/users/jrsmith3/events{/privacy}","received_events_url":"https://api.github.com/users/jrsmith3/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jrsmith3/tec/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/jrsmith3/tec/labels/wontfix","name":"wontfix","color":"ffffff"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-13T16:05:02Z","updated_at":"2015-01-13T23:16:57Z","closed_at":"2015-01-13T23:16:57Z","body":"Some of the calculator methods of the `TECBase` class would make more sense as attributes. For example, `calc_interelectrode_spacing` will likely never take an argument and would make more sense as an attribute named `interelectrode_dist`. These attributes would need to be [properties or descriptors](http://nbviewer.ipython.org/urls/gist.github.com/ChrisBeaumont/5758381/raw/descriptor_writeup.ipynb)\r\n\r\nAdvantages\r\n==========\r\n* Shorter names, I can drop the \"calc\" prefix and the \"()\" suffix.\r\n\r\nProblems\r\n========\r\n* How does one give an attribute a docstring?\r\n\r\nMethods to convert\r\n==================\r\n* `get_max_motive_ht`\r\n* `calc_interelectrode_spacing`\r\n* `calc_output_voltage`\r\n* `calc_contact_potential`\r\n* `calc_forward_current_density`\r\n* `calc_back_current_density`\r\n* `calc_output_current_density`\r\n* `calc_output_power_density`\r\n* `calc_carnot_efficiency`\r\n* `calc_efficiency`\r\n* `calc_heat_supply_rate`\r\n* `calc_electron_cooling_rate`\r\n* `calc_thermal_rad_rate`\r\n"},"comment":{"url":"https://api.github.com/repos/jrsmith3/tec/issues/comments/69840782","html_url":"https://github.com/jrsmith3/tec/issues/55#issuecomment-69840782","issue_url":"https://api.github.com/repos/jrsmith3/tec/issues/55","id":69840782,"user":{"login":"jrsmith3","id":204215,"avatar_url":"https://avatars.githubusercontent.com/u/204215?v=3","gravatar_id":"","url":"https://api.github.com/users/jrsmith3","html_url":"https://github.com/jrsmith3","followers_url":"https://api.github.com/users/jrsmith3/followers","following_url":"https://api.github.com/users/jrsmith3/following{/other_user}","gists_url":"https://api.github.com/users/jrsmith3/gists{/gist_id}","starred_url":"https://api.github.com/users/jrsmith3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrsmith3/subscriptions","organizations_url":"https://api.github.com/users/jrsmith3/orgs","repos_url":"https://api.github.com/users/jrsmith3/repos","events_url":"https://api.github.com/users/jrsmith3/events{/privacy}","received_events_url":"https://api.github.com/users/jrsmith3/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T23:16:57Z","updated_at":"2015-01-13T23:16:57Z","body":"Based on my prior comment, I've decided this refactor isn't a good idea."}}