{"action":"created","issue":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1510","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1510/labels{/name}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1510/comments","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1510/events","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1510","id":106187750,"number":1510,"title":"Added chat history to a room that is displayed on join","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-09-12T22:12:33Z","updated_at":"2015-09-14T17:58:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/1510","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1510","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/1510.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/1510.patch"},"body":"This PR adds room chat history that is presented on join. A new server info message type has been added to the protocol which is used for retaining room chat history that is now presented to users on join and will be used to also allow the moderator tool for looking up chat history to be developed later.\r\n\r\nCurrently the server only retains 100 messages on a per room basis.\r\nNote:  Older clients will not have the historic messages formatting in place and the historic messages will be presented in the same text/color as the default room join message till they upgrade there clients.\r\n\r\nThis should be the last thing need to fix #169 but it may be mentioned some were else as something nice to have (chat room history).\r\n\r\nOne feature added to the room history is the ability for each room to have its own amount of history defined to it.  See the sample servatrice.ini to see how to define the number of rooms historic chat information to store.  A column in the database rooms table has also been added for those using a database to store room information.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1361287/9837487/74b1f9a4-5a0e-11e5-935b-ba1866fa6a8c.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments/140160373","html_url":"https://github.com/Cockatrice/Cockatrice/pull/1510#issuecomment-140160373","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/1510","id":140160373,"user":{"login":"Daenyth","id":14644,"avatar_url":"https://avatars.githubusercontent.com/u/14644?v=3","gravatar_id":"","url":"https://api.github.com/users/Daenyth","html_url":"https://github.com/Daenyth","followers_url":"https://api.github.com/users/Daenyth/followers","following_url":"https://api.github.com/users/Daenyth/following{/other_user}","gists_url":"https://api.github.com/users/Daenyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Daenyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daenyth/subscriptions","organizations_url":"https://api.github.com/users/Daenyth/orgs","repos_url":"https://api.github.com/users/Daenyth/repos","events_url":"https://api.github.com/users/Daenyth/events{/privacy}","received_events_url":"https://api.github.com/users/Daenyth/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T17:58:56Z","updated_at":"2015-09-14T17:58:56Z","body":"I haven't dug into it yet, but what is the server storing if not UTC? On the client side that UTC needs to be translated to the local time, or you'll end up relaying false information to the users, or cases where the hour/minutes etc show up as times from the future (in local time perspective)"}}