{"action":"opened","number":47,"pull_request":{"url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47","id":28744566,"html_url":"https://github.com/Workiva/go-datastructures/pull/47","diff_url":"https://github.com/Workiva/go-datastructures/pull/47.diff","patch_url":"https://github.com/Workiva/go-datastructures/pull/47.patch","issue_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/47","number":47,"state":"open","locked":false,"title":"Palm","user":{"login":"dustinhiatt-wf","id":1457662,"avatar_url":"https://avatars.githubusercontent.com/u/1457662?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinhiatt-wf","html_url":"https://github.com/dustinhiatt-wf","followers_url":"https://api.github.com/users/dustinhiatt-wf/followers","following_url":"https://api.github.com/users/dustinhiatt-wf/following{/other_user}","gists_url":"https://api.github.com/users/dustinhiatt-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinhiatt-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinhiatt-wf/subscriptions","organizations_url":"https://api.github.com/users/dustinhiatt-wf/orgs","repos_url":"https://api.github.com/users/dustinhiatt-wf/repos","events_url":"https://api.github.com/users/dustinhiatt-wf/events{/privacy}","received_events_url":"https://api.github.com/users/dustinhiatt-wf/received_events","type":"User","site_admin":false},"body":"CODE REVIEW\r\n\r\nImplements a PALM B-tree (parallel architecture-friendly latch-free modifications).  I am aware of some areas of this code that can be improved to reduce repetition and improve performance, but again, this ends up being pretty dense code so I wanted to get it up.  We are getting killed right now on the Compare method as it's called on an interface and has to do a cast but without generics this is the only way to use this with multiple types of keys.  I am confident enough that I added a public constructor.  So far, we are about twice as fast as the B-plus tree when adding keys to an existing tree.  I think we can improve upon that by using indexed skiplists as the holder of keys instead of an array, which forces a memcopy.  The Intel version kept their data unordered in their leaves to avoid the memmove but I'd like to support efficient in-order range queries.\r\n\r\n@beaulyddon-wf @alexandercampbell-wf @tannermiller-wf @rosshendrickson-wf @ericolson-wf @stevenosborne-wf @tylertreat-wf ","created_at":"2015-02-05T17:37:45Z","updated_at":"2015-02-05T17:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47/commits","review_comments_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47/comments","review_comment_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/47/comments","statuses_url":"https://api.github.com/repos/Workiva/go-datastructures/statuses/66abce8dae8dc8188f00c6bb5932f719fe357324","head":{"label":"Workiva:palm","ref":"palm","sha":"66abce8dae8dc8188f00c6bb5932f719fe357324","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":25923208,"name":"go-datastructures","full_name":"Workiva/go-datastructures","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/go-datastructures","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/go-datastructures","forks_url":"https://api.github.com/repos/Workiva/go-datastructures/forks","keys_url":"https://api.github.com/repos/Workiva/go-datastructures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/go-datastructures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/go-datastructures/teams","hooks_url":"https://api.github.com/repos/Workiva/go-datastructures/hooks","issue_events_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/go-datastructures/events","assignees_url":"https://api.github.com/repos/Workiva/go-datastructures/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/go-datastructures/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/go-datastructures/tags","blobs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/go-datastructures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/go-datastructures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/go-datastructures/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/go-datastructures/languages","stargazers_url":"https://api.github.com/repos/Workiva/go-datastructures/stargazers","contributors_url":"https://api.github.com/repos/Workiva/go-datastructures/contributors","subscribers_url":"https://api.github.com/repos/Workiva/go-datastructures/subscribers","subscription_url":"https://api.github.com/repos/Workiva/go-datastructures/subscription","commits_url":"https://api.github.com/repos/Workiva/go-datastructures/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/go-datastructures/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/go-datastructures/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/comments/{number}","contents_url":"https://api.github.com/repos/Workiva/go-datastructures/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/go-datastructures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/go-datastructures/merges","archive_url":"https://api.github.com/repos/Workiva/go-datastructures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/go-datastructures/downloads","issues_url":"https://api.github.com/repos/Workiva/go-datastructures/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/go-datastructures/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/go-datastructures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/go-datastructures/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/go-datastructures/releases{/id}","created_at":"2014-10-29T13:55:17Z","updated_at":"2015-02-05T17:32:24Z","pushed_at":"2015-02-05T17:32:46Z","git_url":"git://github.com/Workiva/go-datastructures.git","ssh_url":"git@github.com:Workiva/go-datastructures.git","clone_url":"https://github.com/Workiva/go-datastructures.git","svn_url":"https://github.com/Workiva/go-datastructures","homepage":null,"size":7302,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"a13c5a9060d800cc44bf47473479aec326703c50","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":25923208,"name":"go-datastructures","full_name":"Workiva/go-datastructures","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars.githubusercontent.com/u/1087529?v=3","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/go-datastructures","description":"","fork":false,"url":"https://api.github.com/repos/Workiva/go-datastructures","forks_url":"https://api.github.com/repos/Workiva/go-datastructures/forks","keys_url":"https://api.github.com/repos/Workiva/go-datastructures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/go-datastructures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/go-datastructures/teams","hooks_url":"https://api.github.com/repos/Workiva/go-datastructures/hooks","issue_events_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/go-datastructures/events","assignees_url":"https://api.github.com/repos/Workiva/go-datastructures/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/go-datastructures/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/go-datastructures/tags","blobs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/go-datastructures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/go-datastructures/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/go-datastructures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/go-datastructures/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/go-datastructures/languages","stargazers_url":"https://api.github.com/repos/Workiva/go-datastructures/stargazers","contributors_url":"https://api.github.com/repos/Workiva/go-datastructures/contributors","subscribers_url":"https://api.github.com/repos/Workiva/go-datastructures/subscribers","subscription_url":"https://api.github.com/repos/Workiva/go-datastructures/subscription","commits_url":"https://api.github.com/repos/Workiva/go-datastructures/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/go-datastructures/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/go-datastructures/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/go-datastructures/issues/comments/{number}","contents_url":"https://api.github.com/repos/Workiva/go-datastructures/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/go-datastructures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/go-datastructures/merges","archive_url":"https://api.github.com/repos/Workiva/go-datastructures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/go-datastructures/downloads","issues_url":"https://api.github.com/repos/Workiva/go-datastructures/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/go-datastructures/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/go-datastructures/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/go-datastructures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/go-datastructures/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/go-datastructures/releases{/id}","created_at":"2014-10-29T13:55:17Z","updated_at":"2015-02-05T17:32:24Z","pushed_at":"2015-02-05T17:32:46Z","git_url":"git://github.com/Workiva/go-datastructures.git","ssh_url":"git@github.com:Workiva/go-datastructures.git","clone_url":"https://github.com/Workiva/go-datastructures.git","svn_url":"https://github.com/Workiva/go-datastructures","homepage":null,"size":7302,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47"},"html":{"href":"https://github.com/Workiva/go-datastructures/pull/47"},"issue":{"href":"https://api.github.com/repos/Workiva/go-datastructures/issues/47"},"comments":{"href":"https://api.github.com/repos/Workiva/go-datastructures/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Workiva/go-datastructures/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/go-datastructures/statuses/66abce8dae8dc8188f00c6bb5932f719fe357324"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":12,"additions":1022,"deletions":0,"changed_files":8}}