{"action":"created","comment":{"url":"https://api.github.com/repos/hsanson/vim-android/pulls/comments/47180656","id":47180656,"diff_hunk":"@@ -1,12 +1,6 @@\n if gradle#isGradleProject()\n-\n-  call gradle#setClassPath()","path":"after/ftplugin/xml.vim","position":3,"original_position":3,"commit_id":"b5ad210d55ba964aedfc1f6ff42e7cc04fe90a42","original_commit_id":"b5ad210d55ba964aedfc1f6ff42e7cc04fe90a42","user":{"login":"hsanson","id":900716,"avatar_url":"https://avatars.githubusercontent.com/u/900716?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanson","html_url":"https://github.com/hsanson","followers_url":"https://api.github.com/users/hsanson/followers","following_url":"https://api.github.com/users/hsanson/following{/other_user}","gists_url":"https://api.github.com/users/hsanson/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanson/subscriptions","organizations_url":"https://api.github.com/users/hsanson/orgs","repos_url":"https://api.github.com/users/hsanson/repos","events_url":"https://api.github.com/users/hsanson/events{/privacy}","received_events_url":"https://api.github.com/users/hsanson/received_events","type":"User","site_admin":false},"body":"For now revert back the deletes. It takes time because it is actually running gradle to detect if the project includes the android plugin and in the way finds out the target sdk version.\r\n\r\nMy plan is to implement this using neovim async or vimproc so it is done in the background. If everything works as advertised then there will be no lag at all in the future and we still get accurate android project detection. The previous heuristic based on parsing AndroidManifest.xml was failing for lots of cases.\r\n\r\nThe idea of using javacomplete2 may work but depending on a plugin that not everybody may use is not appealing. I personally don't use it so would be useless for me. If this is to be merged it must work as alternative and not as only way to get classpath information.","created_at":"2015-12-10T01:54:16Z","updated_at":"2015-12-10T01:54:16Z","html_url":"https://github.com/hsanson/vim-android/pull/29#discussion_r47180656","pull_request_url":"https://api.github.com/repos/hsanson/vim-android/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/comments/47180656"},"html":{"href":"https://github.com/hsanson/vim-android/pull/29#discussion_r47180656"},"pull_request":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/hsanson/vim-android/pulls/29","id":53072944,"html_url":"https://github.com/hsanson/vim-android/pull/29","diff_url":"https://github.com/hsanson/vim-android/pull/29.diff","patch_url":"https://github.com/hsanson/vim-android/pull/29.patch","issue_url":"https://api.github.com/repos/hsanson/vim-android/issues/29","number":29,"state":"open","locked":false,"title":"Upgraded XML completion","user":{"login":"DonnieWest","id":1453484,"avatar_url":"https://avatars.githubusercontent.com/u/1453484?v=3","gravatar_id":"","url":"https://api.github.com/users/DonnieWest","html_url":"https://github.com/DonnieWest","followers_url":"https://api.github.com/users/DonnieWest/followers","following_url":"https://api.github.com/users/DonnieWest/following{/other_user}","gists_url":"https://api.github.com/users/DonnieWest/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnieWest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnieWest/subscriptions","organizations_url":"https://api.github.com/users/DonnieWest/orgs","repos_url":"https://api.github.com/users/DonnieWest/repos","events_url":"https://api.github.com/users/DonnieWest/events{/privacy}","received_events_url":"https://api.github.com/users/DonnieWest/received_events","type":"User","site_admin":false},"body":"This commit enhances vim's native XML completion to account for most of\r\nthe keywords that an Android xml file will contain. This also removes\r\nwhere vim-android started classpath completion during an XML file. Since\r\nXML files can't currently use Java classpaths we can save that for when\r\na Java file is being editted so things don't slow down.","created_at":"2015-12-09T03:37:56Z","updated_at":"2015-12-10T01:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ad3823e424d762954d8a8b2c5c927788401a2e1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hsanson/vim-android/pulls/29/commits","review_comments_url":"https://api.github.com/repos/hsanson/vim-android/pulls/29/comments","review_comment_url":"https://api.github.com/repos/hsanson/vim-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hsanson/vim-android/issues/29/comments","statuses_url":"https://api.github.com/repos/hsanson/vim-android/statuses/b5ad210d55ba964aedfc1f6ff42e7cc04fe90a42","head":{"label":"DonnieWest:XmlCompletion","ref":"XmlCompletion","sha":"b5ad210d55ba964aedfc1f6ff42e7cc04fe90a42","user":{"login":"DonnieWest","id":1453484,"avatar_url":"https://avatars.githubusercontent.com/u/1453484?v=3","gravatar_id":"","url":"https://api.github.com/users/DonnieWest","html_url":"https://github.com/DonnieWest","followers_url":"https://api.github.com/users/DonnieWest/followers","following_url":"https://api.github.com/users/DonnieWest/following{/other_user}","gists_url":"https://api.github.com/users/DonnieWest/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnieWest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnieWest/subscriptions","organizations_url":"https://api.github.com/users/DonnieWest/orgs","repos_url":"https://api.github.com/users/DonnieWest/repos","events_url":"https://api.github.com/users/DonnieWest/events{/privacy}","received_events_url":"https://api.github.com/users/DonnieWest/received_events","type":"User","site_admin":false},"repo":{"id":47596666,"name":"vim-android","full_name":"DonnieWest/vim-android","owner":{"login":"DonnieWest","id":1453484,"avatar_url":"https://avatars.githubusercontent.com/u/1453484?v=3","gravatar_id":"","url":"https://api.github.com/users/DonnieWest","html_url":"https://github.com/DonnieWest","followers_url":"https://api.github.com/users/DonnieWest/followers","following_url":"https://api.github.com/users/DonnieWest/following{/other_user}","gists_url":"https://api.github.com/users/DonnieWest/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnieWest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnieWest/subscriptions","organizations_url":"https://api.github.com/users/DonnieWest/orgs","repos_url":"https://api.github.com/users/DonnieWest/repos","events_url":"https://api.github.com/users/DonnieWest/events{/privacy}","received_events_url":"https://api.github.com/users/DonnieWest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DonnieWest/vim-android","description":"Android development plugin for vim","fork":true,"url":"https://api.github.com/repos/DonnieWest/vim-android","forks_url":"https://api.github.com/repos/DonnieWest/vim-android/forks","keys_url":"https://api.github.com/repos/DonnieWest/vim-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonnieWest/vim-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonnieWest/vim-android/teams","hooks_url":"https://api.github.com/repos/DonnieWest/vim-android/hooks","issue_events_url":"https://api.github.com/repos/DonnieWest/vim-android/issues/events{/number}","events_url":"https://api.github.com/repos/DonnieWest/vim-android/events","assignees_url":"https://api.github.com/repos/DonnieWest/vim-android/assignees{/user}","branches_url":"https://api.github.com/repos/DonnieWest/vim-android/branches{/branch}","tags_url":"https://api.github.com/repos/DonnieWest/vim-android/tags","blobs_url":"https://api.github.com/repos/DonnieWest/vim-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonnieWest/vim-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonnieWest/vim-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonnieWest/vim-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonnieWest/vim-android/statuses/{sha}","languages_url":"https://api.github.com/repos/DonnieWest/vim-android/languages","stargazers_url":"https://api.github.com/repos/DonnieWest/vim-android/stargazers","contributors_url":"https://api.github.com/repos/DonnieWest/vim-android/contributors","subscribers_url":"https://api.github.com/repos/DonnieWest/vim-android/subscribers","subscription_url":"https://api.github.com/repos/DonnieWest/vim-android/subscription","commits_url":"https://api.github.com/repos/DonnieWest/vim-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonnieWest/vim-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonnieWest/vim-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonnieWest/vim-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonnieWest/vim-android/contents/{+path}","compare_url":"https://api.github.com/repos/DonnieWest/vim-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonnieWest/vim-android/merges","archive_url":"https://api.github.com/repos/DonnieWest/vim-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonnieWest/vim-android/downloads","issues_url":"https://api.github.com/repos/DonnieWest/vim-android/issues{/number}","pulls_url":"https://api.github.com/repos/DonnieWest/vim-android/pulls{/number}","milestones_url":"https://api.github.com/repos/DonnieWest/vim-android/milestones{/number}","notifications_url":"https://api.github.com/repos/DonnieWest/vim-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonnieWest/vim-android/labels{/name}","releases_url":"https://api.github.com/repos/DonnieWest/vim-android/releases{/id}","created_at":"2015-12-08T03:41:01Z","updated_at":"2015-12-08T03:41:02Z","pushed_at":"2015-12-09T03:56:57Z","git_url":"git://github.com/DonnieWest/vim-android.git","ssh_url":"git@github.com:DonnieWest/vim-android.git","clone_url":"https://github.com/DonnieWest/vim-android.git","svn_url":"https://github.com/DonnieWest/vim-android","homepage":null,"size":197,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hsanson:master","ref":"master","sha":"88cc401d064e07271d147dbfd9acf76fb580484a","user":{"login":"hsanson","id":900716,"avatar_url":"https://avatars.githubusercontent.com/u/900716?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanson","html_url":"https://github.com/hsanson","followers_url":"https://api.github.com/users/hsanson/followers","following_url":"https://api.github.com/users/hsanson/following{/other_user}","gists_url":"https://api.github.com/users/hsanson/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanson/subscriptions","organizations_url":"https://api.github.com/users/hsanson/orgs","repos_url":"https://api.github.com/users/hsanson/repos","events_url":"https://api.github.com/users/hsanson/events{/privacy}","received_events_url":"https://api.github.com/users/hsanson/received_events","type":"User","site_admin":false},"repo":{"id":8088951,"name":"vim-android","full_name":"hsanson/vim-android","owner":{"login":"hsanson","id":900716,"avatar_url":"https://avatars.githubusercontent.com/u/900716?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanson","html_url":"https://github.com/hsanson","followers_url":"https://api.github.com/users/hsanson/followers","following_url":"https://api.github.com/users/hsanson/following{/other_user}","gists_url":"https://api.github.com/users/hsanson/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanson/subscriptions","organizations_url":"https://api.github.com/users/hsanson/orgs","repos_url":"https://api.github.com/users/hsanson/repos","events_url":"https://api.github.com/users/hsanson/events{/privacy}","received_events_url":"https://api.github.com/users/hsanson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hsanson/vim-android","description":"Android development plugin for vim","fork":false,"url":"https://api.github.com/repos/hsanson/vim-android","forks_url":"https://api.github.com/repos/hsanson/vim-android/forks","keys_url":"https://api.github.com/repos/hsanson/vim-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hsanson/vim-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hsanson/vim-android/teams","hooks_url":"https://api.github.com/repos/hsanson/vim-android/hooks","issue_events_url":"https://api.github.com/repos/hsanson/vim-android/issues/events{/number}","events_url":"https://api.github.com/repos/hsanson/vim-android/events","assignees_url":"https://api.github.com/repos/hsanson/vim-android/assignees{/user}","branches_url":"https://api.github.com/repos/hsanson/vim-android/branches{/branch}","tags_url":"https://api.github.com/repos/hsanson/vim-android/tags","blobs_url":"https://api.github.com/repos/hsanson/vim-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hsanson/vim-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hsanson/vim-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/hsanson/vim-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hsanson/vim-android/statuses/{sha}","languages_url":"https://api.github.com/repos/hsanson/vim-android/languages","stargazers_url":"https://api.github.com/repos/hsanson/vim-android/stargazers","contributors_url":"https://api.github.com/repos/hsanson/vim-android/contributors","subscribers_url":"https://api.github.com/repos/hsanson/vim-android/subscribers","subscription_url":"https://api.github.com/repos/hsanson/vim-android/subscription","commits_url":"https://api.github.com/repos/hsanson/vim-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/hsanson/vim-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/hsanson/vim-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/hsanson/vim-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/hsanson/vim-android/contents/{+path}","compare_url":"https://api.github.com/repos/hsanson/vim-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hsanson/vim-android/merges","archive_url":"https://api.github.com/repos/hsanson/vim-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hsanson/vim-android/downloads","issues_url":"https://api.github.com/repos/hsanson/vim-android/issues{/number}","pulls_url":"https://api.github.com/repos/hsanson/vim-android/pulls{/number}","milestones_url":"https://api.github.com/repos/hsanson/vim-android/milestones{/number}","notifications_url":"https://api.github.com/repos/hsanson/vim-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hsanson/vim-android/labels{/name}","releases_url":"https://api.github.com/repos/hsanson/vim-android/releases{/id}","created_at":"2013-02-08T06:46:16Z","updated_at":"2015-12-06T17:26:27Z","pushed_at":"2015-12-10T00:04:54Z","git_url":"git://github.com/hsanson/vim-android.git","ssh_url":"git@github.com:hsanson/vim-android.git","clone_url":"https://github.com/hsanson/vim-android.git","svn_url":"https://github.com/hsanson/vim-android","homepage":null,"size":205,"stargazers_count":113,"watchers_count":113,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/29"},"html":{"href":"https://github.com/hsanson/vim-android/pull/29"},"issue":{"href":"https://api.github.com/repos/hsanson/vim-android/issues/29"},"comments":{"href":"https://api.github.com/repos/hsanson/vim-android/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hsanson/vim-android/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/hsanson/vim-android/statuses/b5ad210d55ba964aedfc1f6ff42e7cc04fe90a42"}}}}