{"action":"created","issue":{"url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85","labels_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85/comments","events_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85/events","html_url":"https://github.com/yiisoft/yii2-gii/pull/85","id":104241655,"number":85,"title":"CRUD code style fixes","user":{"login":"arogachev","id":8326201,"avatar_url":"https://avatars.githubusercontent.com/u/8326201?v=3","gravatar_id":"","url":"https://api.github.com/users/arogachev","html_url":"https://github.com/arogachev","followers_url":"https://api.github.com/users/arogachev/followers","following_url":"https://api.github.com/users/arogachev/following{/other_user}","gists_url":"https://api.github.com/users/arogachev/gists{/gist_id}","starred_url":"https://api.github.com/users/arogachev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arogachev/subscriptions","organizations_url":"https://api.github.com/users/arogachev/orgs","repos_url":"https://api.github.com/users/arogachev/repos","events_url":"https://api.github.com/users/arogachev/events{/privacy}","received_events_url":"https://api.github.com/users/arogachev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"samdark","id":47294,"avatar_url":"https://avatars.githubusercontent.com/u/47294?v=3","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-09-01T11:02:56Z","updated_at":"2015-09-01T11:38:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2-gii/pulls/85","html_url":"https://github.com/yiisoft/yii2-gii/pull/85","diff_url":"https://github.com/yiisoft/yii2-gii/pull/85.diff","patch_url":"https://github.com/yiisoft/yii2-gii/pull/85.patch"},"body":"- Corrected imports to be in alphabetical order.\r\n- Removed extra line breaks and added new.\r\n- When the number of params is 1, it should be \"one liner\" for more compact view (except very long line). If the user need to add more, he should add line breaks and extra comma on his own.\r\n- Corrected PHPDoc (missing `@inheritdoc`, `more explicit `@return`, missing `@throws`).\r\n- Prevented reaching max symbols limit in line.\r\n- Encoding of title is redundant by default, because this string is safe and managed by programmer, not user.\r\n- Removed extra concatenation with space.\r\n- Converted double quotes to single used in empty string (`''` instead of `\"\"`).\r\n- Capitalized comments.\r\n- Removed variable assignment in condition, I think it's bad practice and it's better to assign variable separately before, this makes code more clear and easier to read."},"comment":{"url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/comments/136683017","html_url":"https://github.com/yiisoft/yii2-gii/pull/85#issuecomment-136683017","issue_url":"https://api.github.com/repos/yiisoft/yii2-gii/issues/85","id":136683017,"user":{"login":"samdark","id":47294,"avatar_url":"https://avatars.githubusercontent.com/u/47294?v=3","gravatar_id":"","url":"https://api.github.com/users/samdark","html_url":"https://github.com/samdark","followers_url":"https://api.github.com/users/samdark/followers","following_url":"https://api.github.com/users/samdark/following{/other_user}","gists_url":"https://api.github.com/users/samdark/gists{/gist_id}","starred_url":"https://api.github.com/users/samdark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdark/subscriptions","organizations_url":"https://api.github.com/users/samdark/orgs","repos_url":"https://api.github.com/users/samdark/repos","events_url":"https://api.github.com/users/samdark/events{/privacy}","received_events_url":"https://api.github.com/users/samdark/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T11:38:28Z","updated_at":"2015-09-01T11:38:28Z","body":"> Encoding of title is redundant by default, because this string is safe and managed by programmer, not user.\r\n\r\nIt won't hurt to encode in this case. Using model title as part of the title is very likely."}}