{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/xtext/pulls/comments/28666408","id":28666408,"diff_hunk":"@@ -20,17 +21,37 @@ private TypeMatchFilters() {\n \t\tthrow new AssertionError(\"May not be instantiated.\");\n \t}\n \t\n+\t/**\n+\t * @deprecated use {@link #isNonInternal()} instead\n+\t */\n+\t@Deprecated\n \tpublic static ITypesProposalProvider.Filter all() {\n \t\treturn new All();\n \t}\n \t\n \t/**\n \t * @since 2.0\n+\t * @deprecated use {@link #isNonInternal(int)} instead\n \t */\n+\t@Deprecated\n \tpublic static ITypesProposalProvider.Filter all(int searchFor) {\n \t\treturn new All(searchFor);\n \t}\n \t\n+\t/**\n+\t * @since 2.9\n+\t */\n+\tpublic static ITypesProposalProvider.Filter isNonInternal() {\n+\t\treturn new IsNonInternal();\n+\t}\n+\t\n+\t/**\n+\t * @since 2.9\n+\t */\n+\tpublic static ITypesProposalProvider.Filter isNonInternal(int searchFor) {","path":"plugins/org.eclipse.xtext.common.types.ui/src/org/eclipse/xtext/common/types/xtext/ui/TypeMatchFilters.java","position":39,"original_position":39,"commit_id":"267544814fc1a0c8414ec047a49df614508ffab4","original_commit_id":"267544814fc1a0c8414ec047a49df614508ffab4","user":{"login":"szarnekow","id":375492,"avatar_url":"https://avatars.githubusercontent.com/u/375492?v=3","gravatar_id":"","url":"https://api.github.com/users/szarnekow","html_url":"https://github.com/szarnekow","followers_url":"https://api.github.com/users/szarnekow/followers","following_url":"https://api.github.com/users/szarnekow/following{/other_user}","gists_url":"https://api.github.com/users/szarnekow/gists{/gist_id}","starred_url":"https://api.github.com/users/szarnekow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szarnekow/subscriptions","organizations_url":"https://api.github.com/users/szarnekow/orgs","repos_url":"https://api.github.com/users/szarnekow/repos","events_url":"https://api.github.com/users/szarnekow/events{/privacy}","received_events_url":"https://api.github.com/users/szarnekow/received_events","type":"User","site_admin":false},"body":"Since there was some confusion about `all`, we should have javadoc on `isNonInternal`. Can we call the method `isNotInternal`?","created_at":"2015-04-20T06:37:38Z","updated_at":"2015-04-20T06:37:38Z","html_url":"https://github.com/eclipse/xtext/pull/25#discussion_r28666408","pull_request_url":"https://api.github.com/repos/eclipse/xtext/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/comments/28666408"},"html":{"href":"https://github.com/eclipse/xtext/pull/25#discussion_r28666408"},"pull_request":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/xtext/pulls/25","id":31119101,"html_url":"https://github.com/eclipse/xtext/pull/25","diff_url":"https://github.com/eclipse/xtext/pull/25.diff","patch_url":"https://github.com/eclipse/xtext/pull/25.patch","issue_url":"https://api.github.com/repos/eclipse/xtext/issues/25","number":25,"state":"open","locked":false,"title":"[bug 378057] type filter","user":{"login":"kthoms","id":265597,"avatar_url":"https://avatars.githubusercontent.com/u/265597?v=3","gravatar_id":"","url":"https://api.github.com/users/kthoms","html_url":"https://github.com/kthoms","followers_url":"https://api.github.com/users/kthoms/followers","following_url":"https://api.github.com/users/kthoms/following{/other_user}","gists_url":"https://api.github.com/users/kthoms/gists{/gist_id}","starred_url":"https://api.github.com/users/kthoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kthoms/subscriptions","organizations_url":"https://api.github.com/users/kthoms/orgs","repos_url":"https://api.github.com/users/kthoms/repos","events_url":"https://api.github.com/users/kthoms/events{/privacy}","received_events_url":"https://api.github.com/users/kthoms/received_events","type":"User","site_admin":false},"body":"This patch will add the methods isFilteredByPreference and isFilteredByDefault to TypeMatchFilters. isFilteredByPreference considers the JDT type filter preference.","created_at":"2015-03-13T11:43:55Z","updated_at":"2015-04-20T06:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69b063802f6d32ef9df3faa2131a28a723795bae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/xtext/pulls/25/commits","review_comments_url":"https://api.github.com/repos/eclipse/xtext/pulls/25/comments","review_comment_url":"https://api.github.com/repos/eclipse/xtext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/xtext/issues/25/comments","statuses_url":"https://api.github.com/repos/eclipse/xtext/statuses/267544814fc1a0c8414ec047a49df614508ffab4","head":{"label":"kthoms:bug378057-type-filter","ref":"bug378057-type-filter","sha":"267544814fc1a0c8414ec047a49df614508ffab4","user":{"login":"kthoms","id":265597,"avatar_url":"https://avatars.githubusercontent.com/u/265597?v=3","gravatar_id":"","url":"https://api.github.com/users/kthoms","html_url":"https://github.com/kthoms","followers_url":"https://api.github.com/users/kthoms/followers","following_url":"https://api.github.com/users/kthoms/following{/other_user}","gists_url":"https://api.github.com/users/kthoms/gists{/gist_id}","starred_url":"https://api.github.com/users/kthoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kthoms/subscriptions","organizations_url":"https://api.github.com/users/kthoms/orgs","repos_url":"https://api.github.com/users/kthoms/repos","events_url":"https://api.github.com/users/kthoms/events{/privacy}","received_events_url":"https://api.github.com/users/kthoms/received_events","type":"User","site_admin":false},"repo":{"id":2016727,"name":"xtext","full_name":"kthoms/xtext","owner":{"login":"kthoms","id":265597,"avatar_url":"https://avatars.githubusercontent.com/u/265597?v=3","gravatar_id":"","url":"https://api.github.com/users/kthoms","html_url":"https://github.com/kthoms","followers_url":"https://api.github.com/users/kthoms/followers","following_url":"https://api.github.com/users/kthoms/following{/other_user}","gists_url":"https://api.github.com/users/kthoms/gists{/gist_id}","starred_url":"https://api.github.com/users/kthoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kthoms/subscriptions","organizations_url":"https://api.github.com/users/kthoms/orgs","repos_url":"https://api.github.com/users/kthoms/repos","events_url":"https://api.github.com/users/kthoms/events{/privacy}","received_events_url":"https://api.github.com/users/kthoms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kthoms/xtext","description":"Xtext project repository (xtext)","fork":true,"url":"https://api.github.com/repos/kthoms/xtext","forks_url":"https://api.github.com/repos/kthoms/xtext/forks","keys_url":"https://api.github.com/repos/kthoms/xtext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kthoms/xtext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kthoms/xtext/teams","hooks_url":"https://api.github.com/repos/kthoms/xtext/hooks","issue_events_url":"https://api.github.com/repos/kthoms/xtext/issues/events{/number}","events_url":"https://api.github.com/repos/kthoms/xtext/events","assignees_url":"https://api.github.com/repos/kthoms/xtext/assignees{/user}","branches_url":"https://api.github.com/repos/kthoms/xtext/branches{/branch}","tags_url":"https://api.github.com/repos/kthoms/xtext/tags","blobs_url":"https://api.github.com/repos/kthoms/xtext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kthoms/xtext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kthoms/xtext/git/refs{/sha}","trees_url":"https://api.github.com/repos/kthoms/xtext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kthoms/xtext/statuses/{sha}","languages_url":"https://api.github.com/repos/kthoms/xtext/languages","stargazers_url":"https://api.github.com/repos/kthoms/xtext/stargazers","contributors_url":"https://api.github.com/repos/kthoms/xtext/contributors","subscribers_url":"https://api.github.com/repos/kthoms/xtext/subscribers","subscription_url":"https://api.github.com/repos/kthoms/xtext/subscription","commits_url":"https://api.github.com/repos/kthoms/xtext/commits{/sha}","git_commits_url":"https://api.github.com/repos/kthoms/xtext/git/commits{/sha}","comments_url":"https://api.github.com/repos/kthoms/xtext/comments{/number}","issue_comment_url":"https://api.github.com/repos/kthoms/xtext/issues/comments{/number}","contents_url":"https://api.github.com/repos/kthoms/xtext/contents/{+path}","compare_url":"https://api.github.com/repos/kthoms/xtext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kthoms/xtext/merges","archive_url":"https://api.github.com/repos/kthoms/xtext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kthoms/xtext/downloads","issues_url":"https://api.github.com/repos/kthoms/xtext/issues{/number}","pulls_url":"https://api.github.com/repos/kthoms/xtext/pulls{/number}","milestones_url":"https://api.github.com/repos/kthoms/xtext/milestones{/number}","notifications_url":"https://api.github.com/repos/kthoms/xtext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kthoms/xtext/labels{/name}","releases_url":"https://api.github.com/repos/kthoms/xtext/releases{/id}","created_at":"2011-07-08T07:48:31Z","updated_at":"2015-03-11T10:33:18Z","pushed_at":"2015-04-16T13:35:18Z","git_url":"git://github.com/kthoms/xtext.git","ssh_url":"git@github.com:kthoms/xtext.git","clone_url":"https://github.com/kthoms/xtext.git","svn_url":"https://github.com/kthoms/xtext","homepage":null,"size":448373,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"736a1a5c27b7843e5da7fc5206b24fdeac249187","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":1553758,"name":"xtext","full_name":"eclipse/xtext","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/xtext","description":"Xtext is a language development framework ","fork":false,"url":"https://api.github.com/repos/eclipse/xtext","forks_url":"https://api.github.com/repos/eclipse/xtext/forks","keys_url":"https://api.github.com/repos/eclipse/xtext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/xtext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/xtext/teams","hooks_url":"https://api.github.com/repos/eclipse/xtext/hooks","issue_events_url":"https://api.github.com/repos/eclipse/xtext/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/xtext/events","assignees_url":"https://api.github.com/repos/eclipse/xtext/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/xtext/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/xtext/tags","blobs_url":"https://api.github.com/repos/eclipse/xtext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/xtext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/xtext/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/xtext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/xtext/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/xtext/languages","stargazers_url":"https://api.github.com/repos/eclipse/xtext/stargazers","contributors_url":"https://api.github.com/repos/eclipse/xtext/contributors","subscribers_url":"https://api.github.com/repos/eclipse/xtext/subscribers","subscription_url":"https://api.github.com/repos/eclipse/xtext/subscription","commits_url":"https://api.github.com/repos/eclipse/xtext/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/xtext/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/xtext/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/xtext/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/xtext/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/xtext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/xtext/merges","archive_url":"https://api.github.com/repos/eclipse/xtext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/xtext/downloads","issues_url":"https://api.github.com/repos/eclipse/xtext/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/xtext/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/xtext/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/xtext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/xtext/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/xtext/releases{/id}","created_at":"2011-04-01T02:12:17Z","updated_at":"2015-04-20T06:29:42Z","pushed_at":"2015-04-20T06:29:42Z","git_url":"git://github.com/eclipse/xtext.git","ssh_url":"git@github.com:eclipse/xtext.git","clone_url":"https://github.com/eclipse/xtext.git","svn_url":"https://github.com/eclipse/xtext","homepage":"http://xtext.org","size":661101,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":5,"forks":54,"open_issues":5,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/25"},"html":{"href":"https://github.com/eclipse/xtext/pull/25"},"issue":{"href":"https://api.github.com/repos/eclipse/xtext/issues/25"},"comments":{"href":"https://api.github.com/repos/eclipse/xtext/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/xtext/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/xtext/statuses/267544814fc1a0c8414ec047a49df614508ffab4"}}}}