{"action":"created","issue":{"url":"https://api.github.com/repos/nette/tester/issues/198","labels_url":"https://api.github.com/repos/nette/tester/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/nette/tester/issues/198/comments","events_url":"https://api.github.com/repos/nette/tester/issues/198/events","html_url":"https://github.com/nette/tester/issues/198","id":54323019,"number":198,"title":"Fix documentation for Assert::fail","user":{"login":"Fuco1","id":2664959,"avatar_url":"https://avatars.githubusercontent.com/u/2664959?v=3","gravatar_id":"","url":"https://api.github.com/users/Fuco1","html_url":"https://github.com/Fuco1","followers_url":"https://api.github.com/users/Fuco1/followers","following_url":"https://api.github.com/users/Fuco1/following{/other_user}","gists_url":"https://api.github.com/users/Fuco1/gists{/gist_id}","starred_url":"https://api.github.com/users/Fuco1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fuco1/subscriptions","organizations_url":"https://api.github.com/users/Fuco1/orgs","repos_url":"https://api.github.com/users/Fuco1/repos","events_url":"https://api.github.com/users/Fuco1/events{/privacy}","received_events_url":"https://api.github.com/users/Fuco1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-14T13:42:08Z","updated_at":"2015-01-19T14:18:53Z","closed_at":null,"body":"The english (as well as czech) documentation for `Assert::fail` (http://tester.nette.org/en/#toc-assert-fail) lists the arguments as\r\n\r\n    Assert::fail($message, $expected = NULL, $actual = NULL)\r\n\r\nIn reality, they are swapped, see: https://github.com/nette/tester/blob/master/Tester/Framework/Assert.php#L423\r\n\r\nNow, I guess it is not possible to fix the code because that would break BC, but considering *all* other asserts have the order `$expected, $actual` this is very unexpected (and indeed brought me quite some headache until I figured I'd check the sources).  Is there some reasoning behind this choice?"},"comment":{"url":"https://api.github.com/repos/nette/tester/issues/comments/70498385","html_url":"https://github.com/nette/tester/issues/198#issuecomment-70498385","issue_url":"https://api.github.com/repos/nette/tester/issues/198","id":70498385,"user":{"login":"milo","id":439140,"avatar_url":"https://avatars.githubusercontent.com/u/439140?v=3","gravatar_id":"","url":"https://api.github.com/users/milo","html_url":"https://github.com/milo","followers_url":"https://api.github.com/users/milo/followers","following_url":"https://api.github.com/users/milo/following{/other_user}","gists_url":"https://api.github.com/users/milo/gists{/gist_id}","starred_url":"https://api.github.com/users/milo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milo/subscriptions","organizations_url":"https://api.github.com/users/milo/orgs","repos_url":"https://api.github.com/users/milo/repos","events_url":"https://api.github.com/users/milo/events{/privacy}","received_events_url":"https://api.github.com/users/milo/received_events","type":"User","site_admin":false},"created_at":"2015-01-19T14:18:53Z","updated_at":"2015-01-19T14:18:53Z","body":"Doc fixed. \r\n\r\nNot sure about the reason, but I often use `fail()` with an `$actual` only."}}