{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/23024507","id":23024507,"diff_hunk":"@@ -580,6 +598,18 @@ def eval(self):\n             now = int(time.time())\n             time_conflict = False\n \n+            if 'until' in data:\n+                if not _WHEN_SUPPORTED:\n+                    log.error('Missing python-dateutil.'\n+                              'Ignoring until.')\n+                else:\n+                    until__ = dateutil_parser.parse(data['until'])\n+                    until = int(time.mktime(until__.timetuple()))\n+\n+                    if until <= now:\n+                        log.debug('Until time has passed skipping job.')","path":"salt/utils/schedule.py","position":42,"original_position":42,"commit_id":"afbb0736fcb8c5406292694d48c0a5851b5f1289","original_commit_id":"f6f3e1432531ef632462060472acc1c99b4a8ce6","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"Good idea.  Let me look at adding that.","created_at":"2015-01-15T16:58:51Z","updated_at":"2015-01-15T16:58:51Z","html_url":"https://github.com/saltstack/salt/pull/19759#discussion_r23024507","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/19759","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/23024507"},"html":{"href":"https://github.com/saltstack/salt/pull/19759#discussion_r23024507"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/19759"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/19759","id":27443420,"html_url":"https://github.com/saltstack/salt/pull/19759","diff_url":"https://github.com/saltstack/salt/pull/19759.diff","patch_url":"https://github.com/saltstack/salt/pull/19759.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/19759","number":19759,"state":"open","locked":false,"title":"Additions to scheduler.","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"body":"Adding the ability to the salt schedule to specify an \"until\" option for jobs.","created_at":"2015-01-15T16:54:37Z","updated_at":"2015-01-15T16:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb5fd094135ad8a0123ac03c21fc731e203e8cfa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/19759/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/19759/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/19759/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/afbb0736fcb8c5406292694d48c0a5851b5f1289","head":{"label":"garethgreenaway:schedule_until_feature","ref":"schedule_until_feature","sha":"afbb0736fcb8c5406292694d48c0a5851b5f1289","user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"repo":{"id":29167950,"name":"salt","full_name":"garethgreenaway/salt","owner":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garethgreenaway/salt","description":"Infrastructure automation and management system","fork":true,"url":"https://api.github.com/repos/garethgreenaway/salt","forks_url":"https://api.github.com/repos/garethgreenaway/salt/forks","keys_url":"https://api.github.com/repos/garethgreenaway/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garethgreenaway/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garethgreenaway/salt/teams","hooks_url":"https://api.github.com/repos/garethgreenaway/salt/hooks","issue_events_url":"https://api.github.com/repos/garethgreenaway/salt/issues/events{/number}","events_url":"https://api.github.com/repos/garethgreenaway/salt/events","assignees_url":"https://api.github.com/repos/garethgreenaway/salt/assignees{/user}","branches_url":"https://api.github.com/repos/garethgreenaway/salt/branches{/branch}","tags_url":"https://api.github.com/repos/garethgreenaway/salt/tags","blobs_url":"https://api.github.com/repos/garethgreenaway/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garethgreenaway/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garethgreenaway/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/garethgreenaway/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garethgreenaway/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/garethgreenaway/salt/languages","stargazers_url":"https://api.github.com/repos/garethgreenaway/salt/stargazers","contributors_url":"https://api.github.com/repos/garethgreenaway/salt/contributors","subscribers_url":"https://api.github.com/repos/garethgreenaway/salt/subscribers","subscription_url":"https://api.github.com/repos/garethgreenaway/salt/subscription","commits_url":"https://api.github.com/repos/garethgreenaway/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/garethgreenaway/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/garethgreenaway/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/garethgreenaway/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/garethgreenaway/salt/contents/{+path}","compare_url":"https://api.github.com/repos/garethgreenaway/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garethgreenaway/salt/merges","archive_url":"https://api.github.com/repos/garethgreenaway/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garethgreenaway/salt/downloads","issues_url":"https://api.github.com/repos/garethgreenaway/salt/issues{/number}","pulls_url":"https://api.github.com/repos/garethgreenaway/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/garethgreenaway/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/garethgreenaway/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garethgreenaway/salt/labels{/name}","releases_url":"https://api.github.com/repos/garethgreenaway/salt/releases{/id}","created_at":"2015-01-13T02:07:04Z","updated_at":"2015-01-13T02:07:12Z","pushed_at":"2015-01-15T16:57:37Z","git_url":"git://github.com/garethgreenaway/salt.git","ssh_url":"git@github.com:garethgreenaway/salt.git","clone_url":"https://github.com/garethgreenaway/salt.git","svn_url":"https://github.com/garethgreenaway/salt","homepage":"saltstack.com","size":78260,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"f526f610413ea72ba77d1bd9b3001b6d594d287f","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Infrastructure automation and management system","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments/{number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","created_at":"2011-02-20T20:16:56Z","updated_at":"2015-01-15T16:28:50Z","pushed_at":"2015-01-15T16:18:43Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"saltstack.com","size":166793,"stargazers_count":4555,"watchers_count":4555,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1878,"mirror_url":null,"open_issues_count":2086,"forks":1878,"open_issues":2086,"watchers":4555,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/19759"},"html":{"href":"https://github.com/saltstack/salt/pull/19759"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/19759"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/19759/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/19759/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/19759/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/afbb0736fcb8c5406292694d48c0a5851b5f1289"}}}}