{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21","id":40218394,"html_url":"https://github.com/DATA-DOG/go-sqlmock/pull/21","diff_url":"https://github.com/DATA-DOG/go-sqlmock/pull/21.diff","patch_url":"https://github.com/DATA-DOG/go-sqlmock/pull/21.patch","issue_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/21","number":21,"state":"closed","locked":false,"title":"concurrency support, closes #20 and closes #9 and closes #15","user":{"login":"l3pp4rd","id":132389,"avatar_url":"https://avatars.githubusercontent.com/u/132389?v=3","gravatar_id":"","url":"https://api.github.com/users/l3pp4rd","html_url":"https://github.com/l3pp4rd","followers_url":"https://api.github.com/users/l3pp4rd/followers","following_url":"https://api.github.com/users/l3pp4rd/following{/other_user}","gists_url":"https://api.github.com/users/l3pp4rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l3pp4rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l3pp4rd/subscriptions","organizations_url":"https://api.github.com/users/l3pp4rd/orgs","repos_url":"https://api.github.com/users/l3pp4rd/repos","events_url":"https://api.github.com/users/l3pp4rd/events{/privacy}","received_events_url":"https://api.github.com/users/l3pp4rd/received_events","type":"User","site_admin":false},"body":"After some use cases and \r\n\r\nRefactor to support concurrency and multiple connections per mock database instance.\r\nWhen this branch will be merged, there will be **BC** break and a new major version bump.\r\n\r\nSolves the following issues:\r\n- [x] parallel tests, any number of mock databases, closes #9 extends and closes #10 \r\n- [x] since rows holds a connection reserved, allow to open any number of connections, closes #20 \r\n- [x] allow to expect database close to be called, closes #15 \r\n- [x] more expectations, for example allow for rows to return error at any point. closes #13 \r\n- [x] deprecated methods: **RowsFromCSVString** will be removed\r\n- [x] allow unordered expectation matching, support for goroutines, see [test](https://github.com/DATA-DOG/go-sqlmock/blob/refactor/sqlmock_test.go#L580).\r\n- [x] all possible places where values may be changed, should be available for mocking.\r\n- [x] more expressive errors\r\n- [x] documentation updated\r\n- [x] allow null values from csv string to be converted to nil. closes #22 ","created_at":"2015-07-17T10:25:14Z","updated_at":"2015-08-28T07:37:42Z","closed_at":"2015-08-28T07:37:42Z","merged_at":"2015-08-28T07:37:42Z","merge_commit_sha":"67506062d11f108fdbc10b9f07ab41295d49ffd4","assignee":null,"milestone":{"url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/milestones/1","html_url":"https://github.com/DATA-DOG/go-sqlmock/milestones/1.0.0","labels_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/milestones/1/labels","id":1065306,"number":1,"title":"1.0.0","description":"","creator":{"login":"l3pp4rd","id":132389,"avatar_url":"https://avatars.githubusercontent.com/u/132389?v=3","gravatar_id":"","url":"https://api.github.com/users/l3pp4rd","html_url":"https://github.com/l3pp4rd","followers_url":"https://api.github.com/users/l3pp4rd/followers","following_url":"https://api.github.com/users/l3pp4rd/following{/other_user}","gists_url":"https://api.github.com/users/l3pp4rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l3pp4rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l3pp4rd/subscriptions","organizations_url":"https://api.github.com/users/l3pp4rd/orgs","repos_url":"https://api.github.com/users/l3pp4rd/repos","events_url":"https://api.github.com/users/l3pp4rd/events{/privacy}","received_events_url":"https://api.github.com/users/l3pp4rd/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":7,"state":"open","created_at":"2015-04-13T15:36:55Z","updated_at":"2015-08-28T07:37:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21/commits","review_comments_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21/comments","review_comment_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/21/comments","statuses_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/statuses/32a1b9d93f8906a6a3905ff5532edded050a18e2","head":{"label":"DATA-DOG:refactor","ref":"refactor","sha":"32a1b9d93f8906a6a3905ff5532edded050a18e2","user":{"login":"DATA-DOG","id":6613360,"avatar_url":"https://avatars.githubusercontent.com/u/6613360?v=3","gravatar_id":"","url":"https://api.github.com/users/DATA-DOG","html_url":"https://github.com/DATA-DOG","followers_url":"https://api.github.com/users/DATA-DOG/followers","following_url":"https://api.github.com/users/DATA-DOG/following{/other_user}","gists_url":"https://api.github.com/users/DATA-DOG/gists{/gist_id}","starred_url":"https://api.github.com/users/DATA-DOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DATA-DOG/subscriptions","organizations_url":"https://api.github.com/users/DATA-DOG/orgs","repos_url":"https://api.github.com/users/DATA-DOG/repos","events_url":"https://api.github.com/users/DATA-DOG/events{/privacy}","received_events_url":"https://api.github.com/users/DATA-DOG/received_events","type":"Organization","site_admin":false},"repo":{"id":16607984,"name":"go-sqlmock","full_name":"DATA-DOG/go-sqlmock","owner":{"login":"DATA-DOG","id":6613360,"avatar_url":"https://avatars.githubusercontent.com/u/6613360?v=3","gravatar_id":"","url":"https://api.github.com/users/DATA-DOG","html_url":"https://github.com/DATA-DOG","followers_url":"https://api.github.com/users/DATA-DOG/followers","following_url":"https://api.github.com/users/DATA-DOG/following{/other_user}","gists_url":"https://api.github.com/users/DATA-DOG/gists{/gist_id}","starred_url":"https://api.github.com/users/DATA-DOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DATA-DOG/subscriptions","organizations_url":"https://api.github.com/users/DATA-DOG/orgs","repos_url":"https://api.github.com/users/DATA-DOG/repos","events_url":"https://api.github.com/users/DATA-DOG/events{/privacy}","received_events_url":"https://api.github.com/users/DATA-DOG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DATA-DOG/go-sqlmock","description":"Sql mock driver for golang to test database interactions","fork":false,"url":"https://api.github.com/repos/DATA-DOG/go-sqlmock","forks_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/forks","keys_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/teams","hooks_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/hooks","issue_events_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/events{/number}","events_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/events","assignees_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/assignees{/user}","branches_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/branches{/branch}","tags_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/tags","blobs_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/refs{/sha}","trees_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/statuses/{sha}","languages_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/languages","stargazers_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/stargazers","contributors_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/contributors","subscribers_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/subscribers","subscription_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/subscription","commits_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/commits{/sha}","git_commits_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/commits{/sha}","comments_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/comments{/number}","issue_comment_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/comments{/number}","contents_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/contents/{+path}","compare_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/merges","archive_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/downloads","issues_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues{/number}","pulls_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls{/number}","milestones_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/milestones{/number}","notifications_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/labels{/name}","releases_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/releases{/id}","created_at":"2014-02-07T07:59:29Z","updated_at":"2015-08-20T17:14:39Z","pushed_at":"2015-08-28T07:37:43Z","git_url":"git://github.com/DATA-DOG/go-sqlmock.git","ssh_url":"git@github.com:DATA-DOG/go-sqlmock.git","clone_url":"https://github.com/DATA-DOG/go-sqlmock.git","svn_url":"https://github.com/DATA-DOG/go-sqlmock","homepage":null,"size":368,"stargazers_count":114,"watchers_count":114,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":0,"forks":20,"open_issues":0,"watchers":114,"default_branch":"master"}},"base":{"label":"DATA-DOG:master","ref":"master","sha":"ed4836e31d3e9e77420e442ed9b864df55370ee0","user":{"login":"DATA-DOG","id":6613360,"avatar_url":"https://avatars.githubusercontent.com/u/6613360?v=3","gravatar_id":"","url":"https://api.github.com/users/DATA-DOG","html_url":"https://github.com/DATA-DOG","followers_url":"https://api.github.com/users/DATA-DOG/followers","following_url":"https://api.github.com/users/DATA-DOG/following{/other_user}","gists_url":"https://api.github.com/users/DATA-DOG/gists{/gist_id}","starred_url":"https://api.github.com/users/DATA-DOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DATA-DOG/subscriptions","organizations_url":"https://api.github.com/users/DATA-DOG/orgs","repos_url":"https://api.github.com/users/DATA-DOG/repos","events_url":"https://api.github.com/users/DATA-DOG/events{/privacy}","received_events_url":"https://api.github.com/users/DATA-DOG/received_events","type":"Organization","site_admin":false},"repo":{"id":16607984,"name":"go-sqlmock","full_name":"DATA-DOG/go-sqlmock","owner":{"login":"DATA-DOG","id":6613360,"avatar_url":"https://avatars.githubusercontent.com/u/6613360?v=3","gravatar_id":"","url":"https://api.github.com/users/DATA-DOG","html_url":"https://github.com/DATA-DOG","followers_url":"https://api.github.com/users/DATA-DOG/followers","following_url":"https://api.github.com/users/DATA-DOG/following{/other_user}","gists_url":"https://api.github.com/users/DATA-DOG/gists{/gist_id}","starred_url":"https://api.github.com/users/DATA-DOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DATA-DOG/subscriptions","organizations_url":"https://api.github.com/users/DATA-DOG/orgs","repos_url":"https://api.github.com/users/DATA-DOG/repos","events_url":"https://api.github.com/users/DATA-DOG/events{/privacy}","received_events_url":"https://api.github.com/users/DATA-DOG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DATA-DOG/go-sqlmock","description":"Sql mock driver for golang to test database interactions","fork":false,"url":"https://api.github.com/repos/DATA-DOG/go-sqlmock","forks_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/forks","keys_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/teams","hooks_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/hooks","issue_events_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/events{/number}","events_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/events","assignees_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/assignees{/user}","branches_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/branches{/branch}","tags_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/tags","blobs_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/refs{/sha}","trees_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/statuses/{sha}","languages_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/languages","stargazers_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/stargazers","contributors_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/contributors","subscribers_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/subscribers","subscription_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/subscription","commits_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/commits{/sha}","git_commits_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/git/commits{/sha}","comments_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/comments{/number}","issue_comment_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/comments{/number}","contents_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/contents/{+path}","compare_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/merges","archive_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/downloads","issues_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues{/number}","pulls_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls{/number}","milestones_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/milestones{/number}","notifications_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/labels{/name}","releases_url":"https://api.github.com/repos/DATA-DOG/go-sqlmock/releases{/id}","created_at":"2014-02-07T07:59:29Z","updated_at":"2015-08-20T17:14:39Z","pushed_at":"2015-08-28T07:37:43Z","git_url":"git://github.com/DATA-DOG/go-sqlmock.git","ssh_url":"git@github.com:DATA-DOG/go-sqlmock.git","clone_url":"https://github.com/DATA-DOG/go-sqlmock.git","svn_url":"https://github.com/DATA-DOG/go-sqlmock","homepage":null,"size":368,"stargazers_count":114,"watchers_count":114,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":0,"forks":20,"open_issues":0,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21"},"html":{"href":"https://github.com/DATA-DOG/go-sqlmock/pull/21"},"issue":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/21"},"comments":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/DATA-DOG/go-sqlmock/statuses/32a1b9d93f8906a6a3905ff5532edded050a18e2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"l3pp4rd","id":132389,"avatar_url":"https://avatars.githubusercontent.com/u/132389?v=3","gravatar_id":"","url":"https://api.github.com/users/l3pp4rd","html_url":"https://github.com/l3pp4rd","followers_url":"https://api.github.com/users/l3pp4rd/followers","following_url":"https://api.github.com/users/l3pp4rd/following{/other_user}","gists_url":"https://api.github.com/users/l3pp4rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l3pp4rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l3pp4rd/subscriptions","organizations_url":"https://api.github.com/users/l3pp4rd/orgs","repos_url":"https://api.github.com/users/l3pp4rd/repos","events_url":"https://api.github.com/users/l3pp4rd/events{/privacy}","received_events_url":"https://api.github.com/users/l3pp4rd/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":7,"additions":2013,"deletions":1200,"changed_files":25}}