{"action":"created","comment":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/46672453","id":46672453,"diff_hunk":"@@ -128,7 +128,7 @@ struct IntrinsicBase\n };\n \n /// Return the angle (degree) between two bearing vector rays\n-static double AngleBetweenRay(\n+static inline double AngleBetweenRay(","path":"src/openMVG/cameras/Camera_Intrinsics.hpp","position":5,"original_position":5,"commit_id":"eb52af6d8e9890771e70c29fbfb945cf0dde1bb4","original_commit_id":"eb52af6d8e9890771e70c29fbfb945cf0dde1bb4","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"No we should remove the static. It doesn't make sense to use that in header files.\r\nHere the inline was required to avoid compilation errors. But yes, we need to remove all \"static\" methods.\r\n","created_at":"2015-12-04T11:23:47Z","updated_at":"2015-12-04T11:23:47Z","html_url":"https://github.com/poparteu/openMVG/pull/79#discussion_r46672453","pull_request_url":"https://api.github.com/repos/poparteu/openMVG/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments/46672453"},"html":{"href":"https://github.com/poparteu/openMVG/pull/79#discussion_r46672453"},"pull_request":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/poparteu/openMVG/pulls/79","id":52656873,"html_url":"https://github.com/poparteu/openMVG/pull/79","diff_url":"https://github.com/poparteu/openMVG/pull/79.diff","patch_url":"https://github.com/poparteu/openMVG/pull/79.patch","issue_url":"https://api.github.com/repos/poparteu/openMVG/issues/79","number":79,"state":"open","locked":false,"title":"Fixes for RT camera tracking integration","user":{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false},"body":"Mainly build fixes.\r\n* don't propagate CCTag includes from openMVG headers\r\n* add time logging ability in the cctag extraction\r\n* fix some compilation warnings\r\n* adds a camera calibration application for live input","created_at":"2015-12-04T11:13:52Z","updated_at":"2015-12-04T11:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27b603a5f87eb35b7829e99a7fa369a7344366f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/poparteu/openMVG/pulls/79/commits","review_comments_url":"https://api.github.com/repos/poparteu/openMVG/pulls/79/comments","review_comment_url":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poparteu/openMVG/issues/79/comments","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/eb52af6d8e9890771e70c29fbfb945cf0dde1bb4","head":{"label":"poparteu:gort_integration","ref":"gort_integration","sha":"eb52af6d8e9890771e70c29fbfb945cf0dde1bb4","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","created_at":"2014-12-30T15:39:27Z","updated_at":"2015-10-13T16:02:24Z","pushed_at":"2015-12-04T11:13:53Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":22053,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":41,"forks":0,"open_issues":41,"watchers":1,"default_branch":"master"}},"base":{"label":"poparteu:popart_demo","ref":"popart_demo","sha":"0cec5373e44b105aa11ce0038ed9e698f5b20c38","user":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"poparteu/openMVG","owner":{"login":"poparteu","id":9333123,"avatar_url":"https://avatars.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/poparteu","html_url":"https://github.com/poparteu","followers_url":"https://api.github.com/users/poparteu/followers","following_url":"https://api.github.com/users/poparteu/following{/other_user}","gists_url":"https://api.github.com/users/poparteu/gists{/gist_id}","starred_url":"https://api.github.com/users/poparteu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poparteu/subscriptions","organizations_url":"https://api.github.com/users/poparteu/orgs","repos_url":"https://api.github.com/users/poparteu/repos","events_url":"https://api.github.com/users/poparteu/events{/privacy}","received_events_url":"https://api.github.com/users/poparteu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poparteu/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":true,"url":"https://api.github.com/repos/poparteu/openMVG","forks_url":"https://api.github.com/repos/poparteu/openMVG/forks","keys_url":"https://api.github.com/repos/poparteu/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poparteu/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poparteu/openMVG/teams","hooks_url":"https://api.github.com/repos/poparteu/openMVG/hooks","issue_events_url":"https://api.github.com/repos/poparteu/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/poparteu/openMVG/events","assignees_url":"https://api.github.com/repos/poparteu/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/poparteu/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/poparteu/openMVG/tags","blobs_url":"https://api.github.com/repos/poparteu/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poparteu/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poparteu/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/poparteu/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poparteu/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/poparteu/openMVG/languages","stargazers_url":"https://api.github.com/repos/poparteu/openMVG/stargazers","contributors_url":"https://api.github.com/repos/poparteu/openMVG/contributors","subscribers_url":"https://api.github.com/repos/poparteu/openMVG/subscribers","subscription_url":"https://api.github.com/repos/poparteu/openMVG/subscription","commits_url":"https://api.github.com/repos/poparteu/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/poparteu/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/poparteu/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/poparteu/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/poparteu/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/poparteu/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poparteu/openMVG/merges","archive_url":"https://api.github.com/repos/poparteu/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poparteu/openMVG/downloads","issues_url":"https://api.github.com/repos/poparteu/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/poparteu/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/poparteu/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/poparteu/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poparteu/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/poparteu/openMVG/releases{/id}","created_at":"2014-12-30T15:39:27Z","updated_at":"2015-10-13T16:02:24Z","pushed_at":"2015-12-04T11:13:53Z","git_url":"git://github.com/poparteu/openMVG.git","ssh_url":"git@github.com:poparteu/openMVG.git","clone_url":"https://github.com/poparteu/openMVG.git","svn_url":"https://github.com/poparteu/openMVG","homepage":"","size":22053,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":41,"forks":0,"open_issues":41,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/79"},"html":{"href":"https://github.com/poparteu/openMVG/pull/79"},"issue":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/79"},"comments":{"href":"https://api.github.com/repos/poparteu/openMVG/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poparteu/openMVG/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/poparteu/openMVG/statuses/eb52af6d8e9890771e70c29fbfb945cf0dde1bb4"}}}}