{"action":"created","comment":{"url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments/38854190","id":38854190,"diff_hunk":"@@ -17,22 +17,13 @@\n package org.intellij.erlang.jps.builder;\n \n import com.intellij.util.containers.ContainerUtil;\n-import com.intellij.util.xmlb.annotations.AbstractCollection;\n-import com.intellij.util.xmlb.annotations.Attribute;\n import com.intellij.util.xmlb.annotations.Tag;\n \n import java.util.List;\n \n @Tag(\"module\")\n-public class ErlangModuleBuildOrderDescriptor {\n-  @Attribute(\"name\")\n-  public String myModuleName = \"\";\n+public class ErlangModuleBuildOrder {\n+  public List<String> myOrderedErlangFilePaths = ContainerUtil.newArrayList();\n \n-  @Tag(\"erlangModules\")\n-  @AbstractCollection(surroundWithTag = false)\n-  public List<ErlangFileDescriptor> myOrderedErlangFilePaths = ContainerUtil.newArrayList();\n-\n-  @Tag(\"testErlangModules\")\n-  @AbstractCollection(surroundWithTag = false)\n-  public List<ErlangFileDescriptor> myOrderedErlangTestFilePaths = ContainerUtil.newArrayList();\n+  public List<String> myOrderedErlangTestFilePaths = ContainerUtil.newArrayList();","path":"jps-plugin/src/org/intellij/erlang/jps/builder/ErlangModuleBuildOrder.java","position":24,"original_position":24,"commit_id":"2b81c8cf65793883d83d8ad40247db609ee36a52","original_commit_id":"2b81c8cf65793883d83d8ad40247db609ee36a52","user":{"login":"deadok22","id":1259620,"avatar_url":"https://avatars.githubusercontent.com/u/1259620?v=3","gravatar_id":"","url":"https://api.github.com/users/deadok22","html_url":"https://github.com/deadok22","followers_url":"https://api.github.com/users/deadok22/followers","following_url":"https://api.github.com/users/deadok22/following{/other_user}","gists_url":"https://api.github.com/users/deadok22/gists{/gist_id}","starred_url":"https://api.github.com/users/deadok22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadok22/subscriptions","organizations_url":"https://api.github.com/users/deadok22/orgs","repos_url":"https://api.github.com/users/deadok22/repos","events_url":"https://api.github.com/users/deadok22/events{/privacy}","received_events_url":"https://api.github.com/users/deadok22/received_events","type":"User","site_admin":false},"body":"Why did you remove these annotations?","created_at":"2015-09-07T11:19:42Z","updated_at":"2015-09-07T11:19:42Z","html_url":"https://github.com/ignatov/intellij-erlang/pull/668#discussion_r38854190","pull_request_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments/38854190"},"html":{"href":"https://github.com/ignatov/intellij-erlang/pull/668#discussion_r38854190"},"pull_request":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668","id":42354671,"html_url":"https://github.com/ignatov/intellij-erlang/pull/668","diff_url":"https://github.com/ignatov/intellij-erlang/pull/668.diff","patch_url":"https://github.com/ignatov/intellij-erlang/pull/668.patch","issue_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/668","number":668,"state":"open","locked":false,"title":"#657  Fix problem with cross module dependencies.","user":{"login":"avesloguzova","id":5417013,"avatar_url":"https://avatars.githubusercontent.com/u/5417013?v=3","gravatar_id":"","url":"https://api.github.com/users/avesloguzova","html_url":"https://github.com/avesloguzova","followers_url":"https://api.github.com/users/avesloguzova/followers","following_url":"https://api.github.com/users/avesloguzova/following{/other_user}","gists_url":"https://api.github.com/users/avesloguzova/gists{/gist_id}","starred_url":"https://api.github.com/users/avesloguzova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avesloguzova/subscriptions","organizations_url":"https://api.github.com/users/avesloguzova/orgs","repos_url":"https://api.github.com/users/avesloguzova/repos","events_url":"https://api.github.com/users/avesloguzova/events{/privacy}","received_events_url":"https://api.github.com/users/avesloguzova/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-13T14:11:23Z","updated_at":"2015-09-07T11:19:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f80381a2ac575db0da5e07d76dfb2696e1c5333d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668/commits","review_comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668/comments","review_comment_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/668/comments","statuses_url":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/2b81c8cf65793883d83d8ad40247db609ee36a52","head":{"label":"avesloguzova:657","ref":"657","sha":"2b81c8cf65793883d83d8ad40247db609ee36a52","user":{"login":"avesloguzova","id":5417013,"avatar_url":"https://avatars.githubusercontent.com/u/5417013?v=3","gravatar_id":"","url":"https://api.github.com/users/avesloguzova","html_url":"https://github.com/avesloguzova","followers_url":"https://api.github.com/users/avesloguzova/followers","following_url":"https://api.github.com/users/avesloguzova/following{/other_user}","gists_url":"https://api.github.com/users/avesloguzova/gists{/gist_id}","starred_url":"https://api.github.com/users/avesloguzova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avesloguzova/subscriptions","organizations_url":"https://api.github.com/users/avesloguzova/orgs","repos_url":"https://api.github.com/users/avesloguzova/repos","events_url":"https://api.github.com/users/avesloguzova/events{/privacy}","received_events_url":"https://api.github.com/users/avesloguzova/received_events","type":"User","site_admin":false},"repo":{"id":38375394,"name":"intellij-erlang","full_name":"avesloguzova/intellij-erlang","owner":{"login":"avesloguzova","id":5417013,"avatar_url":"https://avatars.githubusercontent.com/u/5417013?v=3","gravatar_id":"","url":"https://api.github.com/users/avesloguzova","html_url":"https://github.com/avesloguzova","followers_url":"https://api.github.com/users/avesloguzova/followers","following_url":"https://api.github.com/users/avesloguzova/following{/other_user}","gists_url":"https://api.github.com/users/avesloguzova/gists{/gist_id}","starred_url":"https://api.github.com/users/avesloguzova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avesloguzova/subscriptions","organizations_url":"https://api.github.com/users/avesloguzova/orgs","repos_url":"https://api.github.com/users/avesloguzova/repos","events_url":"https://api.github.com/users/avesloguzova/events{/privacy}","received_events_url":"https://api.github.com/users/avesloguzova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avesloguzova/intellij-erlang","description":"Erlang IDE (IntelliJ-based)","fork":true,"url":"https://api.github.com/repos/avesloguzova/intellij-erlang","forks_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/forks","keys_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/teams","hooks_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/hooks","issue_events_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/issues/events{/number}","events_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/events","assignees_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/assignees{/user}","branches_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/branches{/branch}","tags_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/tags","blobs_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/statuses/{sha}","languages_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/languages","stargazers_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/stargazers","contributors_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/contributors","subscribers_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/subscribers","subscription_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/subscription","commits_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/contents/{+path}","compare_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/merges","archive_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/downloads","issues_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/issues{/number}","pulls_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/pulls{/number}","milestones_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/milestones{/number}","notifications_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/labels{/name}","releases_url":"https://api.github.com/repos/avesloguzova/intellij-erlang/releases{/id}","created_at":"2015-07-01T14:22:27Z","updated_at":"2015-07-01T14:22:30Z","pushed_at":"2015-09-07T09:49:54Z","git_url":"git://github.com/avesloguzova/intellij-erlang.git","ssh_url":"git@github.com:avesloguzova/intellij-erlang.git","clone_url":"https://github.com/avesloguzova/intellij-erlang.git","svn_url":"https://github.com/avesloguzova/intellij-erlang","homepage":"https://www.jetbrains.com/idea/features/erlang.html","size":69381,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ignatov:master","ref":"master","sha":"d04fa4cef2fd299de8d2cb2e1e67c75b28e23625","user":{"login":"ignatov","id":426890,"avatar_url":"https://avatars.githubusercontent.com/u/426890?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatov","html_url":"https://github.com/ignatov","followers_url":"https://api.github.com/users/ignatov/followers","following_url":"https://api.github.com/users/ignatov/following{/other_user}","gists_url":"https://api.github.com/users/ignatov/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatov/subscriptions","organizations_url":"https://api.github.com/users/ignatov/orgs","repos_url":"https://api.github.com/users/ignatov/repos","events_url":"https://api.github.com/users/ignatov/events{/privacy}","received_events_url":"https://api.github.com/users/ignatov/received_events","type":"User","site_admin":false},"repo":{"id":5168907,"name":"intellij-erlang","full_name":"ignatov/intellij-erlang","owner":{"login":"ignatov","id":426890,"avatar_url":"https://avatars.githubusercontent.com/u/426890?v=3","gravatar_id":"","url":"https://api.github.com/users/ignatov","html_url":"https://github.com/ignatov","followers_url":"https://api.github.com/users/ignatov/followers","following_url":"https://api.github.com/users/ignatov/following{/other_user}","gists_url":"https://api.github.com/users/ignatov/gists{/gist_id}","starred_url":"https://api.github.com/users/ignatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignatov/subscriptions","organizations_url":"https://api.github.com/users/ignatov/orgs","repos_url":"https://api.github.com/users/ignatov/repos","events_url":"https://api.github.com/users/ignatov/events{/privacy}","received_events_url":"https://api.github.com/users/ignatov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignatov/intellij-erlang","description":"Erlang IDE (IntelliJ-based)","fork":false,"url":"https://api.github.com/repos/ignatov/intellij-erlang","forks_url":"https://api.github.com/repos/ignatov/intellij-erlang/forks","keys_url":"https://api.github.com/repos/ignatov/intellij-erlang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignatov/intellij-erlang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignatov/intellij-erlang/teams","hooks_url":"https://api.github.com/repos/ignatov/intellij-erlang/hooks","issue_events_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/events{/number}","events_url":"https://api.github.com/repos/ignatov/intellij-erlang/events","assignees_url":"https://api.github.com/repos/ignatov/intellij-erlang/assignees{/user}","branches_url":"https://api.github.com/repos/ignatov/intellij-erlang/branches{/branch}","tags_url":"https://api.github.com/repos/ignatov/intellij-erlang/tags","blobs_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/{sha}","languages_url":"https://api.github.com/repos/ignatov/intellij-erlang/languages","stargazers_url":"https://api.github.com/repos/ignatov/intellij-erlang/stargazers","contributors_url":"https://api.github.com/repos/ignatov/intellij-erlang/contributors","subscribers_url":"https://api.github.com/repos/ignatov/intellij-erlang/subscribers","subscription_url":"https://api.github.com/repos/ignatov/intellij-erlang/subscription","commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignatov/intellij-erlang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignatov/intellij-erlang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignatov/intellij-erlang/contents/{+path}","compare_url":"https://api.github.com/repos/ignatov/intellij-erlang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignatov/intellij-erlang/merges","archive_url":"https://api.github.com/repos/ignatov/intellij-erlang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignatov/intellij-erlang/downloads","issues_url":"https://api.github.com/repos/ignatov/intellij-erlang/issues{/number}","pulls_url":"https://api.github.com/repos/ignatov/intellij-erlang/pulls{/number}","milestones_url":"https://api.github.com/repos/ignatov/intellij-erlang/milestones{/number}","notifications_url":"https://api.github.com/repos/ignatov/intellij-erlang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignatov/intellij-erlang/labels{/name}","releases_url":"https://api.github.com/repos/ignatov/intellij-erlang/releases{/id}","created_at":"2012-07-24T17:41:30Z","updated_at":"2015-09-02T17:41:38Z","pushed_at":"2015-09-07T09:49:55Z","git_url":"git://github.com/ignatov/intellij-erlang.git","ssh_url":"git@github.com:ignatov/intellij-erlang.git","clone_url":"https://github.com/ignatov/intellij-erlang.git","svn_url":"https://github.com/ignatov/intellij-erlang","homepage":"https://www.jetbrains.com/idea/features/erlang.html","size":74348,"stargazers_count":398,"watchers_count":398,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"open_issues_count":120,"forks":44,"open_issues":120,"watchers":398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668"},"html":{"href":"https://github.com/ignatov/intellij-erlang/pull/668"},"issue":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/issues/668"},"comments":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/ignatov/intellij-erlang/statuses/2b81c8cf65793883d83d8ad40247db609ee36a52"}}}}