{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/2249","labels_url":"https://api.github.com/repos/hypothesis/h/issues/2249/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/2249/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/2249/events","html_url":"https://github.com/hypothesis/h/pull/2249","id":79037216,"number":2249,"title":"Fix display regression on help/first-run pages","user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-21T15:08:49Z","updated_at":"2015-05-21T15:10:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/2249","html_url":"https://github.com/hypothesis/h/pull/2249","diff_url":"https://github.com/hypothesis/h/pull/2249.diff","patch_url":"https://github.com/hypothesis/h/pull/2249.patch"},"body":"So, once upon a time in the mists of yesteryear, the help/first-run page looked like this:\r\n\r\n![](https://d.pr/i/1aL2b+)\r\n\r\nNice, innit?\r\n\r\nWell unfortunately it now looks like this:\r\n\r\n![](http://d.pr/i/1kFwA+)\r\n\r\nNote, in particular:\r\n\r\n- misaligned logotype\r\n- text [for ants](http://i.imgur.com/EqLMD2w.jpg)\r\n- incorrect line-height (see bookmarklet button and the help text where the sidebar should go)\r\n\r\nTurns out, this is due to the bundling of `topbar.scss` by 1f4ac1b. For reasons that aren't clear to me, `topbar.scss` interferes with `font-size` on `body`, and commits a couple of other heinous crimes before getting on with what I assume it was supposed to be for, namely styling the top bar.\r\n\r\nAnyway, I've fixed this by:\r\n\r\n- moving the scope-creepy CSS from `topbar.scss` into `app.scss`\r\n- removing `app.scss` from the included code for the help page\r\n- turning `help-page.scss` into a new top-level stylesheet, to be used by... wait for it... the help page\r\n\r\nAnd here's what it looks like now:\r\n\r\n![](http://d.pr/i/10pqP+)\r\n\r\nAnd here's a diff between the \"before\" image (the first in this message) and the result of this PR:\r\n\r\n![](https://d.pr/i/1ddWY+)\r\n\r\nYou can see that the text has moved a few pixels down, but is otherwise unchanged. The movement of a few pixels is just a result of the styling of the header, which no longer relies on overriding styles from `app.scss`."},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/104313817","html_url":"https://github.com/hypothesis/h/pull/2249#issuecomment-104313817","issue_url":"https://api.github.com/repos/hypothesis/h/issues/2249","id":104313817,"user":{"login":"nickstenning","id":3602,"avatar_url":"https://avatars.githubusercontent.com/u/3602?v=3","gravatar_id":"","url":"https://api.github.com/users/nickstenning","html_url":"https://github.com/nickstenning","followers_url":"https://api.github.com/users/nickstenning/followers","following_url":"https://api.github.com/users/nickstenning/following{/other_user}","gists_url":"https://api.github.com/users/nickstenning/gists{/gist_id}","starred_url":"https://api.github.com/users/nickstenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickstenning/subscriptions","organizations_url":"https://api.github.com/users/nickstenning/orgs","repos_url":"https://api.github.com/users/nickstenning/repos","events_url":"https://api.github.com/users/nickstenning/events{/privacy}","received_events_url":"https://api.github.com/users/nickstenning/received_events","type":"User","site_admin":false},"created_at":"2015-05-21T15:10:24Z","updated_at":"2015-05-21T15:10:24Z","body":"FWIW I'm not sure I'm a fan of `pyramid_layout`. It seems to add rather a lot of overhead to making relatively straightforward changes such as this one, and it doesn't really seem to be doing that much for us at the moment. Thoughts on stripping it out and just relying on some template inheritance and webassets?"}}