{"action":"created","comment":{"url":"https://api.github.com/repos/pydata/pandas/pulls/comments/33864640","id":33864640,"diff_hunk":"@@ -887,7 +887,11 @@ def shift(self, periods, axis=0):\n         # that, handle boolean etc also\n         new_values, fill_value = com._maybe_upcast(self.values)\n         # make sure array sent to np.roll is c_contiguous\n-        f_ordered = new_values.flags.f_contiguous\n+\n+        f_ordered = False\n+        if not isinstance(new_values, Categorical):","path":"pandas/core/internals.py","position":7,"original_position":7,"commit_id":"d0594476679d4fdec1ad6492ef8835887c9f23ba","original_commit_id":"d0594476679d4fdec1ad6492ef8835887c9f23ba","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"just define ``.flags`` on ``Categorical``","created_at":"2015-07-03T13:45:48Z","updated_at":"2015-07-03T13:45:48Z","html_url":"https://github.com/pydata/pandas/pull/10498#discussion_r33864640","pull_request_url":"https://api.github.com/repos/pydata/pandas/pulls/10498","_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments/33864640"},"html":{"href":"https://github.com/pydata/pandas/pull/10498#discussion_r33864640"},"pull_request":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10498"}}},"pull_request":{"url":"https://api.github.com/repos/pydata/pandas/pulls/10498","id":39176227,"html_url":"https://github.com/pydata/pandas/pull/10498","diff_url":"https://github.com/pydata/pandas/pull/10498.diff","patch_url":"https://github.com/pydata/pandas/pull/10498.patch","issue_url":"https://api.github.com/repos/pydata/pandas/issues/10498","number":10498,"state":"open","locked":false,"title":"Add test and fix for categorical series .shift #10495.","user":{"login":"cottrell","id":223276,"avatar_url":"https://avatars.githubusercontent.com/u/223276?v=3","gravatar_id":"","url":"https://api.github.com/users/cottrell","html_url":"https://github.com/cottrell","followers_url":"https://api.github.com/users/cottrell/followers","following_url":"https://api.github.com/users/cottrell/following{/other_user}","gists_url":"https://api.github.com/users/cottrell/gists{/gist_id}","starred_url":"https://api.github.com/users/cottrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottrell/subscriptions","organizations_url":"https://api.github.com/users/cottrell/orgs","repos_url":"https://api.github.com/users/cottrell/repos","events_url":"https://api.github.com/users/cottrell/events{/privacy}","received_events_url":"https://api.github.com/users/cottrell/received_events","type":"User","site_admin":false},"body":"#10495 \r\n\r\nWaiting for Travis and will review further.","created_at":"2015-07-03T13:42:13Z","updated_at":"2015-07-03T13:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd49c27630200e28d8f91c51ab5c47489ccc201c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pydata/pandas/pulls/10498/commits","review_comments_url":"https://api.github.com/repos/pydata/pandas/pulls/10498/comments","review_comment_url":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydata/pandas/issues/10498/comments","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/d0594476679d4fdec1ad6492ef8835887c9f23ba","head":{"label":"cottrell:categ_shift","ref":"categ_shift","sha":"d0594476679d4fdec1ad6492ef8835887c9f23ba","user":{"login":"cottrell","id":223276,"avatar_url":"https://avatars.githubusercontent.com/u/223276?v=3","gravatar_id":"","url":"https://api.github.com/users/cottrell","html_url":"https://github.com/cottrell","followers_url":"https://api.github.com/users/cottrell/followers","following_url":"https://api.github.com/users/cottrell/following{/other_user}","gists_url":"https://api.github.com/users/cottrell/gists{/gist_id}","starred_url":"https://api.github.com/users/cottrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottrell/subscriptions","organizations_url":"https://api.github.com/users/cottrell/orgs","repos_url":"https://api.github.com/users/cottrell/repos","events_url":"https://api.github.com/users/cottrell/events{/privacy}","received_events_url":"https://api.github.com/users/cottrell/received_events","type":"User","site_admin":false},"repo":{"id":6312295,"name":"pandas","full_name":"cottrell/pandas","owner":{"login":"cottrell","id":223276,"avatar_url":"https://avatars.githubusercontent.com/u/223276?v=3","gravatar_id":"","url":"https://api.github.com/users/cottrell","html_url":"https://github.com/cottrell","followers_url":"https://api.github.com/users/cottrell/followers","following_url":"https://api.github.com/users/cottrell/following{/other_user}","gists_url":"https://api.github.com/users/cottrell/gists{/gist_id}","starred_url":"https://api.github.com/users/cottrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cottrell/subscriptions","organizations_url":"https://api.github.com/users/cottrell/orgs","repos_url":"https://api.github.com/users/cottrell/repos","events_url":"https://api.github.com/users/cottrell/events{/privacy}","received_events_url":"https://api.github.com/users/cottrell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cottrell/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/cottrell/pandas","forks_url":"https://api.github.com/repos/cottrell/pandas/forks","keys_url":"https://api.github.com/repos/cottrell/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cottrell/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cottrell/pandas/teams","hooks_url":"https://api.github.com/repos/cottrell/pandas/hooks","issue_events_url":"https://api.github.com/repos/cottrell/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/cottrell/pandas/events","assignees_url":"https://api.github.com/repos/cottrell/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/cottrell/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/cottrell/pandas/tags","blobs_url":"https://api.github.com/repos/cottrell/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cottrell/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cottrell/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/cottrell/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cottrell/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/cottrell/pandas/languages","stargazers_url":"https://api.github.com/repos/cottrell/pandas/stargazers","contributors_url":"https://api.github.com/repos/cottrell/pandas/contributors","subscribers_url":"https://api.github.com/repos/cottrell/pandas/subscribers","subscription_url":"https://api.github.com/repos/cottrell/pandas/subscription","commits_url":"https://api.github.com/repos/cottrell/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/cottrell/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/cottrell/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/cottrell/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/cottrell/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/cottrell/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cottrell/pandas/merges","archive_url":"https://api.github.com/repos/cottrell/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cottrell/pandas/downloads","issues_url":"https://api.github.com/repos/cottrell/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/cottrell/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/cottrell/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/cottrell/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cottrell/pandas/labels{/name}","releases_url":"https://api.github.com/repos/cottrell/pandas/releases{/id}","created_at":"2012-10-20T18:31:19Z","updated_at":"2015-01-10T18:14:40Z","pushed_at":"2015-07-03T13:40:22Z","git_url":"git://github.com/cottrell/pandas.git","ssh_url":"git@github.com:cottrell/pandas.git","clone_url":"https://github.com/cottrell/pandas.git","svn_url":"https://github.com/cottrell/pandas","homepage":"http://pandas.pydata.org","size":53975,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydata:master","ref":"master","sha":"bac025fff88a8e4ef59955cd86cc733a58464c0c","user":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pydata/pandas","owner":{"login":"pydata","id":1284191,"avatar_url":"https://avatars.githubusercontent.com/u/1284191?v=3","gravatar_id":"","url":"https://api.github.com/users/pydata","html_url":"https://github.com/pydata","followers_url":"https://api.github.com/users/pydata/followers","following_url":"https://api.github.com/users/pydata/following{/other_user}","gists_url":"https://api.github.com/users/pydata/gists{/gist_id}","starred_url":"https://api.github.com/users/pydata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydata/subscriptions","organizations_url":"https://api.github.com/users/pydata/orgs","repos_url":"https://api.github.com/users/pydata/repos","events_url":"https://api.github.com/users/pydata/events{/privacy}","received_events_url":"https://api.github.com/users/pydata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydata/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pydata/pandas","forks_url":"https://api.github.com/repos/pydata/pandas/forks","keys_url":"https://api.github.com/repos/pydata/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydata/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydata/pandas/teams","hooks_url":"https://api.github.com/repos/pydata/pandas/hooks","issue_events_url":"https://api.github.com/repos/pydata/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pydata/pandas/events","assignees_url":"https://api.github.com/repos/pydata/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pydata/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pydata/pandas/tags","blobs_url":"https://api.github.com/repos/pydata/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydata/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydata/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydata/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydata/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pydata/pandas/languages","stargazers_url":"https://api.github.com/repos/pydata/pandas/stargazers","contributors_url":"https://api.github.com/repos/pydata/pandas/contributors","subscribers_url":"https://api.github.com/repos/pydata/pandas/subscribers","subscription_url":"https://api.github.com/repos/pydata/pandas/subscription","commits_url":"https://api.github.com/repos/pydata/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydata/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydata/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydata/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydata/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pydata/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydata/pandas/merges","archive_url":"https://api.github.com/repos/pydata/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydata/pandas/downloads","issues_url":"https://api.github.com/repos/pydata/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pydata/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pydata/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pydata/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydata/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pydata/pandas/releases{/id}","created_at":"2010-08-24T01:37:33Z","updated_at":"2015-07-03T10:40:02Z","pushed_at":"2015-07-03T13:42:14Z","git_url":"git://github.com/pydata/pandas.git","ssh_url":"git@github.com:pydata/pandas.git","clone_url":"https://github.com/pydata/pandas.git","svn_url":"https://github.com/pydata/pandas","homepage":"http://pandas.pydata.org","size":146603,"stargazers_count":4596,"watchers_count":4596,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1731,"mirror_url":null,"open_issues_count":1461,"forks":1731,"open_issues":1461,"watchers":4596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10498"},"html":{"href":"https://github.com/pydata/pandas/pull/10498"},"issue":{"href":"https://api.github.com/repos/pydata/pandas/issues/10498"},"comments":{"href":"https://api.github.com/repos/pydata/pandas/issues/10498/comments"},"review_comments":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10498/comments"},"review_comment":{"href":"https://api.github.com/repos/pydata/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydata/pandas/pulls/10498/commits"},"statuses":{"href":"https://api.github.com/repos/pydata/pandas/statuses/d0594476679d4fdec1ad6492ef8835887c9f23ba"}}}}