{"action":"opened","number":1199,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199","id":31878189,"html_url":"https://github.com/D-Programming-Language/druntime/pull/1199","diff_url":"https://github.com/D-Programming-Language/druntime/pull/1199.diff","patch_url":"https://github.com/D-Programming-Language/druntime/pull/1199.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1199","number":1199,"state":"open","locked":false,"title":"gc.gc: Fix out-of-bounds pagetable access","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars.githubusercontent.com/u/160894?v=3","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"body":"The out-of-bounds access occurs 3 lines below:\r\n\r\n`pagetable[i + p]`\r\n\r\nWe never check that `i + p < npages`.\r\n\r\nThis patch also acts as a small optimization.\r\n\r\nFound using Vagrind: https://github.com/D-Programming-Language/druntime/pull/1197#issuecomment-85671211","created_at":"2015-03-24T22:50:35Z","updated_at":"2015-03-24T22:50:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1199/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/5b5932aa3fc2b7bfa29021ff385170b81d0d51c5","head":{"label":"CyberShadow:pull-20150324-224917","ref":"pull-20150324-224917","sha":"5b5932aa3fc2b7bfa29021ff385170b81d0d51c5","user":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars.githubusercontent.com/u/160894?v=3","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"repo":{"id":1737021,"name":"druntime","full_name":"CyberShadow/druntime","owner":{"login":"CyberShadow","id":160894,"avatar_url":"https://avatars.githubusercontent.com/u/160894?v=3","gravatar_id":"","url":"https://api.github.com/users/CyberShadow","html_url":"https://github.com/CyberShadow","followers_url":"https://api.github.com/users/CyberShadow/followers","following_url":"https://api.github.com/users/CyberShadow/following{/other_user}","gists_url":"https://api.github.com/users/CyberShadow/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberShadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberShadow/subscriptions","organizations_url":"https://api.github.com/users/CyberShadow/orgs","repos_url":"https://api.github.com/users/CyberShadow/repos","events_url":"https://api.github.com/users/CyberShadow/events{/privacy}","received_events_url":"https://api.github.com/users/CyberShadow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CyberShadow/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/CyberShadow/druntime","forks_url":"https://api.github.com/repos/CyberShadow/druntime/forks","keys_url":"https://api.github.com/repos/CyberShadow/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyberShadow/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyberShadow/druntime/teams","hooks_url":"https://api.github.com/repos/CyberShadow/druntime/hooks","issue_events_url":"https://api.github.com/repos/CyberShadow/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/CyberShadow/druntime/events","assignees_url":"https://api.github.com/repos/CyberShadow/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/CyberShadow/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/CyberShadow/druntime/tags","blobs_url":"https://api.github.com/repos/CyberShadow/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyberShadow/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyberShadow/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyberShadow/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyberShadow/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/CyberShadow/druntime/languages","stargazers_url":"https://api.github.com/repos/CyberShadow/druntime/stargazers","contributors_url":"https://api.github.com/repos/CyberShadow/druntime/contributors","subscribers_url":"https://api.github.com/repos/CyberShadow/druntime/subscribers","subscription_url":"https://api.github.com/repos/CyberShadow/druntime/subscription","commits_url":"https://api.github.com/repos/CyberShadow/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyberShadow/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyberShadow/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyberShadow/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyberShadow/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/CyberShadow/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyberShadow/druntime/merges","archive_url":"https://api.github.com/repos/CyberShadow/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyberShadow/druntime/downloads","issues_url":"https://api.github.com/repos/CyberShadow/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/CyberShadow/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/CyberShadow/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/CyberShadow/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyberShadow/druntime/labels{/name}","releases_url":"https://api.github.com/repos/CyberShadow/druntime/releases{/id}","created_at":"2011-05-12T06:03:34Z","updated_at":"2014-05-07T01:41:20Z","pushed_at":"2015-03-24T22:49:26Z","git_url":"git://github.com/CyberShadow/druntime.git","ssh_url":"git@github.com:CyberShadow/druntime.git","clone_url":"https://github.com/CyberShadow/druntime.git","svn_url":"https://github.com/CyberShadow/druntime","homepage":"d-programming-language.org","size":8606,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"95737c0d947fa9096de8e8123440fbc9ba0b9153","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"name":"druntime","full_name":"D-Programming-Language/druntime","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/druntime","forks_url":"https://api.github.com/repos/D-Programming-Language/druntime/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/druntime/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/druntime/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/druntime/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/druntime/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/druntime/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/druntime/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/druntime/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-Language/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/druntime/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/druntime/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/druntime/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/druntime/releases{/id}","created_at":"2011-01-15T07:01:38Z","updated_at":"2015-03-24T13:11:10Z","pushed_at":"2015-03-24T13:11:10Z","git_url":"git://github.com/D-Programming-Language/druntime.git","ssh_url":"git@github.com:D-Programming-Language/druntime.git","clone_url":"https://github.com/D-Programming-Language/druntime.git","svn_url":"https://github.com/D-Programming-Language/druntime","homepage":"dlang.org","size":17930,"stargazers_count":358,"watchers_count":358,"language":"D","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":233,"mirror_url":null,"open_issues_count":27,"forks":233,"open_issues":27,"watchers":358,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199"},"html":{"href":"https://github.com/D-Programming-Language/druntime/pull/1199"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1199"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1199/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1199/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/druntime/statuses/5b5932aa3fc2b7bfa29021ff385170b81d0d51c5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}