{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/43647029","id":43647029,"diff_hunk":"@@ -109,16 +109,16 @@ def validate_proposal_after_save proposal\n     servers = proposal[\"deployment\"][@bc_name][\"elements\"][\"rabbitmq-server\"]\n     unless servers.nil? || servers.first.nil? || !is_cluster?(servers.first)\n       storage_mode = attributes[\"ha\"][\"storage\"][\"mode\"]\n-      validation_error(\"Unknown mode for HA storage: #{storage_mode}.\") unless %w(shared drbd).include?(storage_mode)\n+      validation_error I18n.t(\"barclamp.#{@bc_name}.validation.unknown_mode\", storage_mode: storage_mode) unless %w(shared drbd).include?(storage_mode)\n \n       if storage_mode == \"shared\"\n-        validation_error(\"No device specified for shared storage.\") if attributes[\"ha\"][\"storage\"][\"shared\"][\"device\"].blank?\n-        validation_error(\"No filesystem type specified for shared storage.\") if attributes[\"ha\"][\"storage\"][\"shared\"][\"fstype\"].blank?\n+        validation_error I18n.t(\"barclamp.#{@bc_name}.validation.no_device\") if attributes[\"ha\"][\"storage\"][\"shared\"][\"device\"].blank?\n+        validation_error I18n.t(\"barclamp.#{@bc_name}.validation.no_filesystem\") if attributes[\"ha\"][\"storage\"][\"shared\"][\"fstype\"].blank?\n       elsif storage_mode == \"drbd\"\n         cluster = servers.first\n         role = available_clusters[cluster]\n-        validation_error(\"DRBD is not enabled for cluster #{cluster_name(cluster)}.\") unless role.default_attributes[\"pacemaker\"][\"drbd\"][\"enabled\"]\n-        validation_error(\"Invalid size for DRBD device.\") if attributes[\"ha\"][\"storage\"][\"drbd\"][\"size\"] <= 0\n+        validation_error I18n.t(\"barclamp.#{@bc_name}.validation.drbd\", cluster_name: cluster_name(cluster)) unless role.default_attributes[\"pacemaker\"][\"drbd\"][\"enabled\"]","path":"crowbar_framework/app/models/rabbitmq_service.rb","position":17,"original_position":17,"commit_id":"0517a6388b22f7bdca351fe572742c6c47c48fb6","original_commit_id":"0517a6388b22f7bdca351fe572742c6c47c48fb6","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Metrics/LineLength: Line is too long. [171/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)","created_at":"2015-11-02T16:25:16Z","updated_at":"2015-11-02T16:25:16Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/84#discussion_r43647029","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/43647029"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/84#discussion_r43647029"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84","id":49452306,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/84","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/84.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/84.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/84","number":84,"state":"open","locked":false,"title":"Move error strings in barclamps to i18n file","user":{"login":"vwallfahrer","id":6593189,"avatar_url":"https://avatars.githubusercontent.com/u/6593189?v=3","gravatar_id":"","url":"https://api.github.com/users/vwallfahrer","html_url":"https://github.com/vwallfahrer","followers_url":"https://api.github.com/users/vwallfahrer/followers","following_url":"https://api.github.com/users/vwallfahrer/following{/other_user}","gists_url":"https://api.github.com/users/vwallfahrer/gists{/gist_id}","starred_url":"https://api.github.com/users/vwallfahrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwallfahrer/subscriptions","organizations_url":"https://api.github.com/users/vwallfahrer/orgs","repos_url":"https://api.github.com/users/vwallfahrer/repos","events_url":"https://api.github.com/users/vwallfahrer/events{/privacy}","received_events_url":"https://api.github.com/users/vwallfahrer/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-02T16:25:08Z","updated_at":"2015-11-02T16:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e2c58e197ff0cab6b3a675ef0dfc69754c25f7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/84/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/0517a6388b22f7bdca351fe572742c6c47c48fb6","head":{"label":"vwallfahrer:i18n-file","ref":"i18n-file","sha":"0517a6388b22f7bdca351fe572742c6c47c48fb6","user":{"login":"vwallfahrer","id":6593189,"avatar_url":"https://avatars.githubusercontent.com/u/6593189?v=3","gravatar_id":"","url":"https://api.github.com/users/vwallfahrer","html_url":"https://github.com/vwallfahrer","followers_url":"https://api.github.com/users/vwallfahrer/followers","following_url":"https://api.github.com/users/vwallfahrer/following{/other_user}","gists_url":"https://api.github.com/users/vwallfahrer/gists{/gist_id}","starred_url":"https://api.github.com/users/vwallfahrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwallfahrer/subscriptions","organizations_url":"https://api.github.com/users/vwallfahrer/orgs","repos_url":"https://api.github.com/users/vwallfahrer/repos","events_url":"https://api.github.com/users/vwallfahrer/events{/privacy}","received_events_url":"https://api.github.com/users/vwallfahrer/received_events","type":"User","site_admin":false},"repo":{"id":42040207,"name":"crowbar-openstack","full_name":"vwallfahrer/crowbar-openstack","owner":{"login":"vwallfahrer","id":6593189,"avatar_url":"https://avatars.githubusercontent.com/u/6593189?v=3","gravatar_id":"","url":"https://api.github.com/users/vwallfahrer","html_url":"https://github.com/vwallfahrer","followers_url":"https://api.github.com/users/vwallfahrer/followers","following_url":"https://api.github.com/users/vwallfahrer/following{/other_user}","gists_url":"https://api.github.com/users/vwallfahrer/gists{/gist_id}","starred_url":"https://api.github.com/users/vwallfahrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwallfahrer/subscriptions","organizations_url":"https://api.github.com/users/vwallfahrer/orgs","repos_url":"https://api.github.com/users/vwallfahrer/repos","events_url":"https://api.github.com/users/vwallfahrer/events{/privacy}","received_events_url":"https://api.github.com/users/vwallfahrer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vwallfahrer/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack","forks_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/vwallfahrer/crowbar-openstack/releases{/id}","created_at":"2015-09-07T08:15:41Z","updated_at":"2015-09-07T08:15:43Z","pushed_at":"2015-11-02T16:24:32Z","git_url":"git://github.com/vwallfahrer/crowbar-openstack.git","ssh_url":"git@github.com:vwallfahrer/crowbar-openstack.git","clone_url":"https://github.com/vwallfahrer/crowbar-openstack.git","svn_url":"https://github.com/vwallfahrer/crowbar-openstack","homepage":null,"size":15187,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"2afc68a445b8a843b653c870c647a6964103d5d0","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","created_at":"2015-07-13T10:55:33Z","updated_at":"2015-10-29T15:37:49Z","pushed_at":"2015-11-02T16:25:08Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":16931,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":14,"forks":18,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/84"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/84"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/0517a6388b22f7bdca351fe572742c6c47c48fb6"}}}}