{"action":"opened","number":35,"pull_request":{"url":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35","id":53976586,"html_url":"https://github.com/dmzx/mChat-Extension/pull/35","diff_url":"https://github.com/dmzx/mChat-Extension/pull/35.diff","patch_url":"https://github.com/dmzx/mChat-Extension/pull/35.patch","issue_url":"https://api.github.com/repos/dmzx/mChat-Extension/issues/35","number":35,"state":"open","locked":false,"title":"Improved template code for mChat messages","user":{"login":"kasimi","id":6710357,"avatar_url":"https://avatars.githubusercontent.com/u/6710357?v=3","gravatar_id":"","url":"https://api.github.com/users/kasimi","html_url":"https://github.com/kasimi","followers_url":"https://api.github.com/users/kasimi/followers","following_url":"https://api.github.com/users/kasimi/following{/other_user}","gists_url":"https://api.github.com/users/kasimi/gists{/gist_id}","starred_url":"https://api.github.com/users/kasimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasimi/subscriptions","organizations_url":"https://api.github.com/users/kasimi/orgs","repos_url":"https://api.github.com/users/kasimi/repos","events_url":"https://api.github.com/users/kasimi/events{/privacy}","received_events_url":"https://api.github.com/users/kasimi/received_events","type":"User","site_admin":false},"body":"I have implemented the following improvements for mChat's message templates:\r\n\r\n1. Changed the following `mchatrow` keys in `render_helper.php`\r\n * renamed `U_USER_IDS` => `MCHAT_IS_POSTER`\r\n * renamed `U_USER_ID` => `MCHAT_PM`\r\n * removed `BOT_USER_ID`, identical to `U_VIEWPROFILE`\r\n2. Added new template variable `EXT_URL` that contains the extension's base path `./ext/dmzx/mchat/`\r\n3. Merged templates `mchat_avatar.html` and `mchat_no_avatar.html` to `mchat_messages.html`, fixing a couple inconsistencies between them\r\n * The Like icon on the right didn't show up when avatars were not displayed\r\n * The PM icon on the right didn't show up when avatars were not displayed, instead there was a (PM) link on the left next to the user name. This (PM) link has been removed, the icon on the right is now displayed correctly\r\n * Moved redundant JavaScript code in `insert_quote()` and `insert_like()` functions to `mChat.entityDecode()` in `mchat.js` and removed those functions\r\n * Moved all JavaScipt code from elements' `onclick` attributes to jQuery event bindings in `mchat.js`\r\n * Removed wrapping `<a>` tags from icons that solely execute JavaScript\r\n4. Removed unused language key `MCHAT_PM`\r\n\r\nI'd recommend testing this before merging. :innocent: \r\n","created_at":"2015-12-17T13:37:49Z","updated_at":"2015-12-17T13:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"322fe00cc29a2bac2281c64eb9a4e9ef8ba2233a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35/commits","review_comments_url":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35/comments","review_comment_url":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmzx/mChat-Extension/issues/35/comments","statuses_url":"https://api.github.com/repos/dmzx/mChat-Extension/statuses/b5b0c89175bbcdfeaead93d8d04ec298036dc93b","head":{"label":"kasimi:improve-message-template","ref":"improve-message-template","sha":"b5b0c89175bbcdfeaead93d8d04ec298036dc93b","user":{"login":"kasimi","id":6710357,"avatar_url":"https://avatars.githubusercontent.com/u/6710357?v=3","gravatar_id":"","url":"https://api.github.com/users/kasimi","html_url":"https://github.com/kasimi","followers_url":"https://api.github.com/users/kasimi/followers","following_url":"https://api.github.com/users/kasimi/following{/other_user}","gists_url":"https://api.github.com/users/kasimi/gists{/gist_id}","starred_url":"https://api.github.com/users/kasimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasimi/subscriptions","organizations_url":"https://api.github.com/users/kasimi/orgs","repos_url":"https://api.github.com/users/kasimi/repos","events_url":"https://api.github.com/users/kasimi/events{/privacy}","received_events_url":"https://api.github.com/users/kasimi/received_events","type":"User","site_admin":false},"repo":{"id":47918567,"name":"mChat-Extension","full_name":"kasimi/mChat-Extension","owner":{"login":"kasimi","id":6710357,"avatar_url":"https://avatars.githubusercontent.com/u/6710357?v=3","gravatar_id":"","url":"https://api.github.com/users/kasimi","html_url":"https://github.com/kasimi","followers_url":"https://api.github.com/users/kasimi/followers","following_url":"https://api.github.com/users/kasimi/following{/other_user}","gists_url":"https://api.github.com/users/kasimi/gists{/gist_id}","starred_url":"https://api.github.com/users/kasimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasimi/subscriptions","organizations_url":"https://api.github.com/users/kasimi/orgs","repos_url":"https://api.github.com/users/kasimi/repos","events_url":"https://api.github.com/users/kasimi/events{/privacy}","received_events_url":"https://api.github.com/users/kasimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kasimi/mChat-Extension","description":"phpBB mChat Extension 3.1.x","fork":true,"url":"https://api.github.com/repos/kasimi/mChat-Extension","forks_url":"https://api.github.com/repos/kasimi/mChat-Extension/forks","keys_url":"https://api.github.com/repos/kasimi/mChat-Extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasimi/mChat-Extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasimi/mChat-Extension/teams","hooks_url":"https://api.github.com/repos/kasimi/mChat-Extension/hooks","issue_events_url":"https://api.github.com/repos/kasimi/mChat-Extension/issues/events{/number}","events_url":"https://api.github.com/repos/kasimi/mChat-Extension/events","assignees_url":"https://api.github.com/repos/kasimi/mChat-Extension/assignees{/user}","branches_url":"https://api.github.com/repos/kasimi/mChat-Extension/branches{/branch}","tags_url":"https://api.github.com/repos/kasimi/mChat-Extension/tags","blobs_url":"https://api.github.com/repos/kasimi/mChat-Extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasimi/mChat-Extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasimi/mChat-Extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasimi/mChat-Extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasimi/mChat-Extension/statuses/{sha}","languages_url":"https://api.github.com/repos/kasimi/mChat-Extension/languages","stargazers_url":"https://api.github.com/repos/kasimi/mChat-Extension/stargazers","contributors_url":"https://api.github.com/repos/kasimi/mChat-Extension/contributors","subscribers_url":"https://api.github.com/repos/kasimi/mChat-Extension/subscribers","subscription_url":"https://api.github.com/repos/kasimi/mChat-Extension/subscription","commits_url":"https://api.github.com/repos/kasimi/mChat-Extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasimi/mChat-Extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasimi/mChat-Extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasimi/mChat-Extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/kasimi/mChat-Extension/contents/{+path}","compare_url":"https://api.github.com/repos/kasimi/mChat-Extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasimi/mChat-Extension/merges","archive_url":"https://api.github.com/repos/kasimi/mChat-Extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasimi/mChat-Extension/downloads","issues_url":"https://api.github.com/repos/kasimi/mChat-Extension/issues{/number}","pulls_url":"https://api.github.com/repos/kasimi/mChat-Extension/pulls{/number}","milestones_url":"https://api.github.com/repos/kasimi/mChat-Extension/milestones{/number}","notifications_url":"https://api.github.com/repos/kasimi/mChat-Extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasimi/mChat-Extension/labels{/name}","releases_url":"https://api.github.com/repos/kasimi/mChat-Extension/releases{/id}","created_at":"2015-12-13T12:36:40Z","updated_at":"2015-12-13T12:36:41Z","pushed_at":"2015-12-17T13:30:55Z","git_url":"git://github.com/kasimi/mChat-Extension.git","ssh_url":"git@github.com:kasimi/mChat-Extension.git","clone_url":"https://github.com/kasimi/mChat-Extension.git","svn_url":"https://github.com/kasimi/mChat-Extension","homepage":null,"size":579,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmzx:master","ref":"master","sha":"940c4d6c2283da36aede834b180ce93bc143ba53","user":{"login":"dmzx","id":6445099,"avatar_url":"https://avatars.githubusercontent.com/u/6445099?v=3","gravatar_id":"","url":"https://api.github.com/users/dmzx","html_url":"https://github.com/dmzx","followers_url":"https://api.github.com/users/dmzx/followers","following_url":"https://api.github.com/users/dmzx/following{/other_user}","gists_url":"https://api.github.com/users/dmzx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmzx/subscriptions","organizations_url":"https://api.github.com/users/dmzx/orgs","repos_url":"https://api.github.com/users/dmzx/repos","events_url":"https://api.github.com/users/dmzx/events{/privacy}","received_events_url":"https://api.github.com/users/dmzx/received_events","type":"User","site_admin":false},"repo":{"id":32077764,"name":"mChat-Extension","full_name":"dmzx/mChat-Extension","owner":{"login":"dmzx","id":6445099,"avatar_url":"https://avatars.githubusercontent.com/u/6445099?v=3","gravatar_id":"","url":"https://api.github.com/users/dmzx","html_url":"https://github.com/dmzx","followers_url":"https://api.github.com/users/dmzx/followers","following_url":"https://api.github.com/users/dmzx/following{/other_user}","gists_url":"https://api.github.com/users/dmzx/gists{/gist_id}","starred_url":"https://api.github.com/users/dmzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmzx/subscriptions","organizations_url":"https://api.github.com/users/dmzx/orgs","repos_url":"https://api.github.com/users/dmzx/repos","events_url":"https://api.github.com/users/dmzx/events{/privacy}","received_events_url":"https://api.github.com/users/dmzx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmzx/mChat-Extension","description":"phpBB mChat Extension 3.1.x","fork":false,"url":"https://api.github.com/repos/dmzx/mChat-Extension","forks_url":"https://api.github.com/repos/dmzx/mChat-Extension/forks","keys_url":"https://api.github.com/repos/dmzx/mChat-Extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmzx/mChat-Extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmzx/mChat-Extension/teams","hooks_url":"https://api.github.com/repos/dmzx/mChat-Extension/hooks","issue_events_url":"https://api.github.com/repos/dmzx/mChat-Extension/issues/events{/number}","events_url":"https://api.github.com/repos/dmzx/mChat-Extension/events","assignees_url":"https://api.github.com/repos/dmzx/mChat-Extension/assignees{/user}","branches_url":"https://api.github.com/repos/dmzx/mChat-Extension/branches{/branch}","tags_url":"https://api.github.com/repos/dmzx/mChat-Extension/tags","blobs_url":"https://api.github.com/repos/dmzx/mChat-Extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmzx/mChat-Extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmzx/mChat-Extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmzx/mChat-Extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmzx/mChat-Extension/statuses/{sha}","languages_url":"https://api.github.com/repos/dmzx/mChat-Extension/languages","stargazers_url":"https://api.github.com/repos/dmzx/mChat-Extension/stargazers","contributors_url":"https://api.github.com/repos/dmzx/mChat-Extension/contributors","subscribers_url":"https://api.github.com/repos/dmzx/mChat-Extension/subscribers","subscription_url":"https://api.github.com/repos/dmzx/mChat-Extension/subscription","commits_url":"https://api.github.com/repos/dmzx/mChat-Extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmzx/mChat-Extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmzx/mChat-Extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmzx/mChat-Extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmzx/mChat-Extension/contents/{+path}","compare_url":"https://api.github.com/repos/dmzx/mChat-Extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmzx/mChat-Extension/merges","archive_url":"https://api.github.com/repos/dmzx/mChat-Extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmzx/mChat-Extension/downloads","issues_url":"https://api.github.com/repos/dmzx/mChat-Extension/issues{/number}","pulls_url":"https://api.github.com/repos/dmzx/mChat-Extension/pulls{/number}","milestones_url":"https://api.github.com/repos/dmzx/mChat-Extension/milestones{/number}","notifications_url":"https://api.github.com/repos/dmzx/mChat-Extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmzx/mChat-Extension/labels{/name}","releases_url":"https://api.github.com/repos/dmzx/mChat-Extension/releases{/id}","created_at":"2015-03-12T13:15:21Z","updated_at":"2015-09-16T09:28:23Z","pushed_at":"2015-12-17T13:37:49Z","git_url":"git://github.com/dmzx/mChat-Extension.git","ssh_url":"git@github.com:dmzx/mChat-Extension.git","clone_url":"https://github.com/dmzx/mChat-Extension.git","svn_url":"https://github.com/dmzx/mChat-Extension","homepage":null,"size":569,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35"},"html":{"href":"https://github.com/dmzx/mChat-Extension/pull/35"},"issue":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/issues/35"},"comments":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/dmzx/mChat-Extension/statuses/b5b0c89175bbcdfeaead93d8d04ec298036dc93b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":101,"deletions":89,"changed_files":19}}