{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/36114657","id":36114657,"diff_hunk":"@@ -0,0 +1,157 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.reef.runtime.yarn.driver;\n+\n+import org.apache.hadoop.yarn.api.records.Container;\n+import org.apache.reef.driver.restart.DriverRestartManager;\n+import org.apache.reef.proto.ReefServiceProtos;\n+import org.apache.reef.runtime.common.driver.DriverStatusManager;\n+import org.apache.reef.runtime.common.driver.EvaluatorPreserver;\n+import org.apache.reef.runtime.common.driver.resourcemanager.ResourceStatusEventImpl;\n+import org.apache.reef.runtime.yarn.driver.parameters.YarnEvaluatorPreserver;\n+import org.apache.reef.driver.restart.RestartEvaluatorInfo;\n+import org.apache.reef.tang.annotations.Parameter;\n+\n+import javax.inject.Inject;\n+import java.util.*;\n+import java.util.logging.Level;\n+import java.util.logging.Logger;\n+\n+public final class YarnDriverRestartManager implements DriverRestartManager {","path":"lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/YarnDriverRestartManager.java","position":36,"original_position":36,"commit_id":"b166b1d417f6e906deed4bc699c34dc6dff0b3f7","original_commit_id":"b166b1d417f6e906deed4bc699c34dc6dff0b3f7","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars.githubusercontent.com/u/502371?v=3","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"Please add JavaDoc","created_at":"2015-08-03T18:25:28Z","updated_at":"2015-08-03T18:25:28Z","html_url":"https://github.com/apache/incubator-reef/pull/324#discussion_r36114657","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/36114657"},"html":{"href":"https://github.com/apache/incubator-reef/pull/324#discussion_r36114657"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/324","id":41297207,"html_url":"https://github.com/apache/incubator-reef/pull/324","diff_url":"https://github.com/apache/incubator-reef/pull/324.diff","patch_url":"https://github.com/apache/incubator-reef/pull/324.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/324","number":324,"state":"open","locked":false,"title":"[REEF-483] Add configuration in allowing other ways to preserve running evaluators aside from DFS","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"This addressed the issue by\r\n  * Creating DriverRestartManager interface and implementing YarnDriverRestartManager.\r\n  * Binding ServiceHandlers for operations that require the DriverRestartManager to record evaluators.\r\n\r\nJIRA:\r\n  [REEF-483](https://issues.apache.org/jira/browse/REEF-483)","created_at":"2015-07-31T00:36:06Z","updated_at":"2015-08-03T18:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adaf3ea05e082be3e3f74d7bf4e30152357f08f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/324/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/324/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/324/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/b166b1d417f6e906deed4bc699c34dc6dff0b3f7","head":{"label":"afchung:REEF-483","ref":"REEF-483","sha":"b166b1d417f6e906deed4bc699c34dc6dff0b3f7","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"repo":{"id":31485914,"name":"incubator-reef","full_name":"afchung/incubator-reef","owner":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afchung/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":true,"url":"https://api.github.com/repos/afchung/incubator-reef","forks_url":"https://api.github.com/repos/afchung/incubator-reef/forks","keys_url":"https://api.github.com/repos/afchung/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afchung/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afchung/incubator-reef/teams","hooks_url":"https://api.github.com/repos/afchung/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/afchung/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/afchung/incubator-reef/events","assignees_url":"https://api.github.com/repos/afchung/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/afchung/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/afchung/incubator-reef/tags","blobs_url":"https://api.github.com/repos/afchung/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afchung/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afchung/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/afchung/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afchung/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/afchung/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/afchung/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/afchung/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/afchung/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/afchung/incubator-reef/subscription","commits_url":"https://api.github.com/repos/afchung/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/afchung/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/afchung/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/afchung/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/afchung/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/afchung/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afchung/incubator-reef/merges","archive_url":"https://api.github.com/repos/afchung/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afchung/incubator-reef/downloads","issues_url":"https://api.github.com/repos/afchung/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/afchung/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/afchung/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/afchung/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afchung/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/afchung/incubator-reef/releases{/id}","created_at":"2015-03-01T03:44:31Z","updated_at":"2015-05-06T05:54:15Z","pushed_at":"2015-08-01T21:11:37Z","git_url":"git://github.com/afchung/incubator-reef.git","ssh_url":"git@github.com:afchung/incubator-reef.git","clone_url":"https://github.com/afchung/incubator-reef.git","svn_url":"https://github.com/afchung/incubator-reef","homepage":null,"size":30481,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"86413669ce69195c8af9d92c82ed251432a6504c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-07-03T08:22:28Z","pushed_at":"2015-08-03T07:45:04Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":42707,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":8,"forks":31,"open_issues":8,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/324"},"html":{"href":"https://github.com/apache/incubator-reef/pull/324"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/324"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/b166b1d417f6e906deed4bc699c34dc6dff0b3f7"}}}}