{"action":"created","comment":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/comments/37058400","id":37058400,"diff_hunk":"@@ -16,12 +32,13 @@ if ({(toLower (_sound select 0) find _x == (count toArray (_sound select 0) - co\n };\n \n // add default volume, pitch and distance\n-if (count _sound < 2) then {_sound pushBack 1};\n-if (count _sound < 3) then {_sound pushBack 1};\n-if (count _sound < 4) then {_sound pushBack 0};\n+_soundCount = count _sound;\n+if (_soundCount < 2) then {_sound pushBack 1};\n+if (_soundCount < 3) then {_sound pushBack 1};\n+if (_soundCount < 4) then {_sound pushBack 0};","path":"addons/safemode/functions/fnc_playChangeFiremodeSound.sqf","position":39,"original_position":39,"commit_id":"4babfa0bf8c3cb27dca8b25ead1ace0e3e2f6e9b","original_commit_id":"4babfa0bf8c3cb27dca8b25ead1ace0e3e2f6e9b","user":{"login":"commy2","id":6576312,"avatar_url":"https://avatars.githubusercontent.com/u/6576312?v=3","gravatar_id":"","url":"https://api.github.com/users/commy2","html_url":"https://github.com/commy2","followers_url":"https://api.github.com/users/commy2/followers","following_url":"https://api.github.com/users/commy2/following{/other_user}","gists_url":"https://api.github.com/users/commy2/gists{/gist_id}","starred_url":"https://api.github.com/users/commy2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commy2/subscriptions","organizations_url":"https://api.github.com/users/commy2/orgs","repos_url":"https://api.github.com/users/commy2/repos","events_url":"https://api.github.com/users/commy2/events{/privacy}","received_events_url":"https://api.github.com/users/commy2/received_events","type":"User","site_admin":false},"body":"This is wrong. `count _sound` increases after `pushBack`, but `_soundCount` does not.","created_at":"2015-08-14T08:35:57Z","updated_at":"2015-08-14T08:35:57Z","html_url":"https://github.com/acemod/ACE3/pull/2113#discussion_r37058400","pull_request_url":"https://api.github.com/repos/acemod/ACE3/pulls/2113","_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments/37058400"},"html":{"href":"https://github.com/acemod/ACE3/pull/2113#discussion_r37058400"},"pull_request":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2113"}}},"pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/2113","id":42138930,"html_url":"https://github.com/acemod/ACE3/pull/2113","diff_url":"https://github.com/acemod/ACE3/pull/2113.diff","patch_url":"https://github.com/acemod/ACE3/pull/2113.patch","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/2113","number":2113,"state":"open","locked":false,"title":"Code cleanup Safemode module","user":{"login":"MikeMatrix","id":1426581,"avatar_url":"https://avatars.githubusercontent.com/u/1426581?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMatrix","html_url":"https://github.com/MikeMatrix","followers_url":"https://api.github.com/users/MikeMatrix/followers","following_url":"https://api.github.com/users/MikeMatrix/following{/other_user}","gists_url":"https://api.github.com/users/MikeMatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMatrix/subscriptions","organizations_url":"https://api.github.com/users/MikeMatrix/orgs","repos_url":"https://api.github.com/users/MikeMatrix/repos","events_url":"https://api.github.com/users/MikeMatrix/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMatrix/received_events","type":"User","site_admin":false},"body":"Code Cleanup of the Safemode module","created_at":"2015-08-11T15:00:38Z","updated_at":"2015-08-14T08:35:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45a9d11e58b7638e22deff4b4ae28e5c8c458465","assignee":null,"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/6","html_url":"https://github.com/acemod/ACE3/milestones/3.3.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/6/labels","id":1120680,"number":6,"title":"3.3.0","description":"","creator":{"login":"bux578","id":1235520,"avatar_url":"https://avatars.githubusercontent.com/u/1235520?v=3","gravatar_id":"","url":"https://api.github.com/users/bux578","html_url":"https://github.com/bux578","followers_url":"https://api.github.com/users/bux578/followers","following_url":"https://api.github.com/users/bux578/following{/other_user}","gists_url":"https://api.github.com/users/bux578/gists{/gist_id}","starred_url":"https://api.github.com/users/bux578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bux578/subscriptions","organizations_url":"https://api.github.com/users/bux578/orgs","repos_url":"https://api.github.com/users/bux578/repos","events_url":"https://api.github.com/users/bux578/events{/privacy}","received_events_url":"https://api.github.com/users/bux578/received_events","type":"User","site_admin":false},"open_issues":126,"closed_issues":91,"state":"open","created_at":"2015-05-20T10:38:55Z","updated_at":"2015-08-14T07:39:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/acemod/ACE3/pulls/2113/commits","review_comments_url":"https://api.github.com/repos/acemod/ACE3/pulls/2113/comments","review_comment_url":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/2113/comments","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/4babfa0bf8c3cb27dca8b25ead1ace0e3e2f6e9b","head":{"label":"MikeMatrix:codeCleanupSafemode","ref":"codeCleanupSafemode","sha":"4babfa0bf8c3cb27dca8b25ead1ace0e3e2f6e9b","user":{"login":"MikeMatrix","id":1426581,"avatar_url":"https://avatars.githubusercontent.com/u/1426581?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMatrix","html_url":"https://github.com/MikeMatrix","followers_url":"https://api.github.com/users/MikeMatrix/followers","following_url":"https://api.github.com/users/MikeMatrix/following{/other_user}","gists_url":"https://api.github.com/users/MikeMatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMatrix/subscriptions","organizations_url":"https://api.github.com/users/MikeMatrix/orgs","repos_url":"https://api.github.com/users/MikeMatrix/repos","events_url":"https://api.github.com/users/MikeMatrix/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMatrix/received_events","type":"User","site_admin":false},"repo":{"id":40065021,"name":"ACE3","full_name":"MikeMatrix/ACE3","owner":{"login":"MikeMatrix","id":1426581,"avatar_url":"https://avatars.githubusercontent.com/u/1426581?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeMatrix","html_url":"https://github.com/MikeMatrix","followers_url":"https://api.github.com/users/MikeMatrix/followers","following_url":"https://api.github.com/users/MikeMatrix/following{/other_user}","gists_url":"https://api.github.com/users/MikeMatrix/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMatrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMatrix/subscriptions","organizations_url":"https://api.github.com/users/MikeMatrix/orgs","repos_url":"https://api.github.com/users/MikeMatrix/repos","events_url":"https://api.github.com/users/MikeMatrix/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMatrix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikeMatrix/ACE3","description":"Open-source realism mod for Arma 3","fork":true,"url":"https://api.github.com/repos/MikeMatrix/ACE3","forks_url":"https://api.github.com/repos/MikeMatrix/ACE3/forks","keys_url":"https://api.github.com/repos/MikeMatrix/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikeMatrix/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikeMatrix/ACE3/teams","hooks_url":"https://api.github.com/repos/MikeMatrix/ACE3/hooks","issue_events_url":"https://api.github.com/repos/MikeMatrix/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/MikeMatrix/ACE3/events","assignees_url":"https://api.github.com/repos/MikeMatrix/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/MikeMatrix/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/MikeMatrix/ACE3/tags","blobs_url":"https://api.github.com/repos/MikeMatrix/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikeMatrix/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikeMatrix/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikeMatrix/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikeMatrix/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/MikeMatrix/ACE3/languages","stargazers_url":"https://api.github.com/repos/MikeMatrix/ACE3/stargazers","contributors_url":"https://api.github.com/repos/MikeMatrix/ACE3/contributors","subscribers_url":"https://api.github.com/repos/MikeMatrix/ACE3/subscribers","subscription_url":"https://api.github.com/repos/MikeMatrix/ACE3/subscription","commits_url":"https://api.github.com/repos/MikeMatrix/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikeMatrix/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikeMatrix/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikeMatrix/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikeMatrix/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/MikeMatrix/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikeMatrix/ACE3/merges","archive_url":"https://api.github.com/repos/MikeMatrix/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikeMatrix/ACE3/downloads","issues_url":"https://api.github.com/repos/MikeMatrix/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/MikeMatrix/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/MikeMatrix/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/MikeMatrix/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikeMatrix/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/MikeMatrix/ACE3/releases{/id}","created_at":"2015-08-02T01:21:15Z","updated_at":"2015-08-02T01:21:20Z","pushed_at":"2015-08-12T08:06:55Z","git_url":"git://github.com/MikeMatrix/ACE3.git","ssh_url":"git@github.com:MikeMatrix/ACE3.git","clone_url":"https://github.com/MikeMatrix/ACE3.git","svn_url":"https://github.com/MikeMatrix/ACE3","homepage":"http://ace3mod.com/","size":221354,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"acemod:master","ref":"master","sha":"e5eaefafdbe6a94ff155202cdb082b5bfb231f53","user":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"repo":{"id":29069174,"name":"ACE3","full_name":"acemod/ACE3","owner":{"login":"acemod","id":11369030,"avatar_url":"https://avatars.githubusercontent.com/u/11369030?v=3","gravatar_id":"","url":"https://api.github.com/users/acemod","html_url":"https://github.com/acemod","followers_url":"https://api.github.com/users/acemod/followers","following_url":"https://api.github.com/users/acemod/following{/other_user}","gists_url":"https://api.github.com/users/acemod/gists{/gist_id}","starred_url":"https://api.github.com/users/acemod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acemod/subscriptions","organizations_url":"https://api.github.com/users/acemod/orgs","repos_url":"https://api.github.com/users/acemod/repos","events_url":"https://api.github.com/users/acemod/events{/privacy}","received_events_url":"https://api.github.com/users/acemod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/acemod/ACE3","description":"Open-source realism mod for Arma 3","fork":false,"url":"https://api.github.com/repos/acemod/ACE3","forks_url":"https://api.github.com/repos/acemod/ACE3/forks","keys_url":"https://api.github.com/repos/acemod/ACE3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acemod/ACE3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acemod/ACE3/teams","hooks_url":"https://api.github.com/repos/acemod/ACE3/hooks","issue_events_url":"https://api.github.com/repos/acemod/ACE3/issues/events{/number}","events_url":"https://api.github.com/repos/acemod/ACE3/events","assignees_url":"https://api.github.com/repos/acemod/ACE3/assignees{/user}","branches_url":"https://api.github.com/repos/acemod/ACE3/branches{/branch}","tags_url":"https://api.github.com/repos/acemod/ACE3/tags","blobs_url":"https://api.github.com/repos/acemod/ACE3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acemod/ACE3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acemod/ACE3/git/refs{/sha}","trees_url":"https://api.github.com/repos/acemod/ACE3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acemod/ACE3/statuses/{sha}","languages_url":"https://api.github.com/repos/acemod/ACE3/languages","stargazers_url":"https://api.github.com/repos/acemod/ACE3/stargazers","contributors_url":"https://api.github.com/repos/acemod/ACE3/contributors","subscribers_url":"https://api.github.com/repos/acemod/ACE3/subscribers","subscription_url":"https://api.github.com/repos/acemod/ACE3/subscription","commits_url":"https://api.github.com/repos/acemod/ACE3/commits{/sha}","git_commits_url":"https://api.github.com/repos/acemod/ACE3/git/commits{/sha}","comments_url":"https://api.github.com/repos/acemod/ACE3/comments{/number}","issue_comment_url":"https://api.github.com/repos/acemod/ACE3/issues/comments{/number}","contents_url":"https://api.github.com/repos/acemod/ACE3/contents/{+path}","compare_url":"https://api.github.com/repos/acemod/ACE3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acemod/ACE3/merges","archive_url":"https://api.github.com/repos/acemod/ACE3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acemod/ACE3/downloads","issues_url":"https://api.github.com/repos/acemod/ACE3/issues{/number}","pulls_url":"https://api.github.com/repos/acemod/ACE3/pulls{/number}","milestones_url":"https://api.github.com/repos/acemod/ACE3/milestones{/number}","notifications_url":"https://api.github.com/repos/acemod/ACE3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acemod/ACE3/labels{/name}","releases_url":"https://api.github.com/repos/acemod/ACE3/releases{/id}","created_at":"2015-01-10T19:59:12Z","updated_at":"2015-08-13T04:27:32Z","pushed_at":"2015-08-14T01:21:31Z","git_url":"git://github.com/acemod/ACE3.git","ssh_url":"git@github.com:acemod/ACE3.git","clone_url":"https://github.com/acemod/ACE3.git","svn_url":"https://github.com/acemod/ACE3","homepage":"http://ace3mod.com/","size":356649,"stargazers_count":286,"watchers_count":286,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":217,"mirror_url":null,"open_issues_count":266,"forks":217,"open_issues":266,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2113"},"html":{"href":"https://github.com/acemod/ACE3/pull/2113"},"issue":{"href":"https://api.github.com/repos/acemod/ACE3/issues/2113"},"comments":{"href":"https://api.github.com/repos/acemod/ACE3/issues/2113/comments"},"review_comments":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2113/comments"},"review_comment":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/acemod/ACE3/pulls/2113/commits"},"statuses":{"href":"https://api.github.com/repos/acemod/ACE3/statuses/4babfa0bf8c3cb27dca8b25ead1ace0e3e2f6e9b"}}}}