{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/3479","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/3479/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/3479/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/3479/events","html_url":"https://github.com/dotnet/corefx/pull/3479","id":108453051,"number":3479,"title":"Native: Multiple fixes","user":{"login":"jasonwilliams200OK","id":2031765,"avatar_url":"https://avatars.githubusercontent.com/u/2031765?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonwilliams200OK","html_url":"https://github.com/jasonwilliams200OK","followers_url":"https://api.github.com/users/jasonwilliams200OK/followers","following_url":"https://api.github.com/users/jasonwilliams200OK/following{/other_user}","gists_url":"https://api.github.com/users/jasonwilliams200OK/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonwilliams200OK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonwilliams200OK/subscriptions","organizations_url":"https://api.github.com/users/jasonwilliams200OK/orgs","repos_url":"https://api.github.com/users/jasonwilliams200OK/repos","events_url":"https://api.github.com/users/jasonwilliams200OK/events{/privacy}","received_events_url":"https://api.github.com/users/jasonwilliams200OK/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-26T09:55:03Z","updated_at":"2015-09-26T23:21:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/3479","html_url":"https://github.com/dotnet/corefx/pull/3479","diff_url":"https://github.com/dotnet/corefx/pull/3479.diff","patch_url":"https://github.com/dotnet/corefx/pull/3479.patch"},"body":"##### <del>067ea11</del> d9cf2d8\r\n\r\n* Fix wrong cast. Clang on FreeBSD caught this as error as `id_t` is not the type `[get/set]priority` functions are expecting:\r\n  * Linux man (uses `id_t who`): http://man7.org/linux/man-pages/man2/getpriority.2.html\r\n  * FreeBSD man (uses `int who`): https://www.freebsd.org/cgi/man.cgi?query=getpriority&sektion=2 (this applies to other BSDs as well, such as [DragonFly](https://www.dragonflybsd.org/cgi/web-man?command=getpriority&section=2) and [NetBSD](http://nixdoc.net/man-pages/NetBSD/man2/getpriority.2.html), except for [OpenBSD](http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man2/getpriority.2?query=getpriority), hence I've used <del>`#if !defined(BSD) ..`</del> `cmake_prototype_definition` to detect the correct prototype).\r\n\r\n##### <del>207d186</del> e348434\r\n\r\n* Removes unrequired dependencies from native ` src/Native/gen-buildsys-clang.sh`.\r\n  * It builds without llvm-* dependencies.\r\n  * Cleanup unused code blocks.\r\n  * Minor conditions and comment fixes."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/143504046","html_url":"https://github.com/dotnet/corefx/pull/3479#issuecomment-143504046","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/3479","id":143504046,"user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars.githubusercontent.com/u/75470?v=3","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"created_at":"2015-09-26T23:21:21Z","updated_at":"2015-09-26T23:21:21Z","body":"Nevermind the assert since it was already missing. (Aside: Note that sizeof() check isn't sufficient since it doesn't account for possible difference in signedness between int32_t and id_t). \r\n\r\nI'm going to make another change to make potentially narrowing conversions like that go through a helper and also avoids having to cmake configure every occurrence like this. It'll also help clean up some things in the crypto shim.\r\n\r\nThis LGTM once it gets through a successful CI."}}