{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/46372627","id":46372627,"diff_hunk":"@@ -865,7 +865,47 @@ if (contextVersion > 1) {\n \t    return gl.getQueryParameter(query, pname);\n \t}\n     );\n+\n+    debug(\"\");\n+    debug(\"Test getFragDataLocation\");\n+    var baseVertShader = '' +\n+    '#version 300 es\\n' +\n+    'uniform vec4 normal;\\n' +\n+    'in vec4 vertext;\\n' +\n+    'out vec4 position;\\n' +\n+    'void main (void)\\n' +\n+    '{\\n' +\n+    '       position = vec4(0.0);\\n' +\n+    '       gl_Position = vertext;\\n' +\n+    '}\\n';\n+    var baseFragShader = '' +\n+    '#version 300 es\\n' +\n+    'layout(location = 0) in lowp vec4 position;\\n' +\n+    'layout(location = 1) out mediump vec4 fragColor;\\n' +\n+    'void main (void)\\n' +\n+    '{\\n' +\n+    '       fragColor = position;\\n' +\n+    '}\\n';\n+    var vertShader = gl.createShader(gl.VERTEX_SHADER);\n+    gl.shaderSource(vertShader, baseVertShader);\n+    gl.compileShader(vertShader);\n+    shouldBe('gl.getShaderParameter(vertShader, gl.COMPILE_STATUS);', 'true');\n+    var fragShader = gl.createShader(gl.FRAGMENT_SHADER);\n+    gl.shaderSource(fragShader, baseFragShader);\n+    gl.compileShader(fragShader);\n+    shouldBe('gl.getShaderParameter(fragShader, gl.COMPILE_STATUS);', 'true');\n+    var program = gl.createProgram();\n+    gl.attachShader(program, vertShader);\n+    gl.attachShader(program, fragShader);\n+    gl.linkProgram(program);\n+    shouldBe('gl.getProgramParameter(program, gl.LINK_STATUS)','true');\n+    shouldBe('gl.getFragDataLocation(program, \"vertextColor\")', '-1');\n+    shouldBe('gl.getFragDataLocation(program, \"normal;\")', '-1');\n+    shouldBeNonZero('gl.getFragDataLocation(program, \"vertext\")');","path":"sdk/tests/js/tests/gl-object-get-calls.js","position":40,"original_position":40,"commit_id":"360f237ff01fc3d8507538b88e7596e47978f122","original_commit_id":"360f237ff01fc3d8507538b88e7596e47978f122","user":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"body":"So sorry, it should be normal.","created_at":"2015-12-02T03:02:35Z","updated_at":"2015-12-02T03:02:35Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/1339#discussion_r46372627","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/46372627"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1339#discussion_r46372627"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339","id":52347497,"html_url":"https://github.com/KhronosGroup/WebGL/pull/1339","diff_url":"https://github.com/KhronosGroup/WebGL/pull/1339.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/1339.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1339","number":1339,"state":"open","locked":false,"title":"Add getFragDataLocation to gl.object-get-call.js","user":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"body":"Please help review the code, thanks a lot~","created_at":"2015-12-02T02:55:30Z","updated_at":"2015-12-02T03:02:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b009647fd4d57dce45bdda806a2476fd631f9cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1339/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/360f237ff01fc3d8507538b88e7596e47978f122","head":{"label":"renchenglei:master","ref":"master","sha":"360f237ff01fc3d8507538b88e7596e47978f122","user":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"repo":{"id":40875255,"name":"WebGL","full_name":"renchenglei/WebGL","owner":{"login":"renchenglei","id":13829262,"avatar_url":"https://avatars.githubusercontent.com/u/13829262?v=3","gravatar_id":"","url":"https://api.github.com/users/renchenglei","html_url":"https://github.com/renchenglei","followers_url":"https://api.github.com/users/renchenglei/followers","following_url":"https://api.github.com/users/renchenglei/following{/other_user}","gists_url":"https://api.github.com/users/renchenglei/gists{/gist_id}","starred_url":"https://api.github.com/users/renchenglei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renchenglei/subscriptions","organizations_url":"https://api.github.com/users/renchenglei/orgs","repos_url":"https://api.github.com/users/renchenglei/repos","events_url":"https://api.github.com/users/renchenglei/events{/privacy}","received_events_url":"https://api.github.com/users/renchenglei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renchenglei/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/renchenglei/WebGL","forks_url":"https://api.github.com/repos/renchenglei/WebGL/forks","keys_url":"https://api.github.com/repos/renchenglei/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renchenglei/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renchenglei/WebGL/teams","hooks_url":"https://api.github.com/repos/renchenglei/WebGL/hooks","issue_events_url":"https://api.github.com/repos/renchenglei/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/renchenglei/WebGL/events","assignees_url":"https://api.github.com/repos/renchenglei/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/renchenglei/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/renchenglei/WebGL/tags","blobs_url":"https://api.github.com/repos/renchenglei/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renchenglei/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renchenglei/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/renchenglei/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renchenglei/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/renchenglei/WebGL/languages","stargazers_url":"https://api.github.com/repos/renchenglei/WebGL/stargazers","contributors_url":"https://api.github.com/repos/renchenglei/WebGL/contributors","subscribers_url":"https://api.github.com/repos/renchenglei/WebGL/subscribers","subscription_url":"https://api.github.com/repos/renchenglei/WebGL/subscription","commits_url":"https://api.github.com/repos/renchenglei/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/renchenglei/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/renchenglei/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/renchenglei/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/renchenglei/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/renchenglei/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renchenglei/WebGL/merges","archive_url":"https://api.github.com/repos/renchenglei/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renchenglei/WebGL/downloads","issues_url":"https://api.github.com/repos/renchenglei/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/renchenglei/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/renchenglei/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/renchenglei/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renchenglei/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/renchenglei/WebGL/releases{/id}","created_at":"2015-08-17T07:53:33Z","updated_at":"2015-08-17T07:53:54Z","pushed_at":"2015-12-01T08:14:21Z","git_url":"git://github.com/renchenglei/WebGL.git","ssh_url":"git@github.com:renchenglei/WebGL.git","clone_url":"https://github.com/renchenglei/WebGL.git","svn_url":"https://github.com/renchenglei/WebGL","homepage":null,"size":19619,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"ccbb62be8f6ec736d91c100be4aa3c5e285e6525","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","created_at":"2012-07-27T17:21:51Z","updated_at":"2015-12-01T22:04:58Z","pushed_at":"2015-12-02T02:55:30Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":26211,"stargazers_count":468,"watchers_count":468,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":48,"forks":257,"open_issues":48,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/1339"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1339"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/1339/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/1339/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/360f237ff01fc3d8507538b88e7596e47978f122"}}}}