{"action":"created","comment":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/39904233","id":39904233,"diff_hunk":"@@ -278,15 +278,15 @@ def __init__(self, logger = None, dbi = None, params = None):\n           \"\"\"CREATE TABLE wmbs_job (\n              id           INTEGER       PRIMARY KEY AUTO_INCREMENT,\n              jobgroup     INTEGER       NOT NULL,\n-             name         VARCHAR(255),\n+             name         VARCHAR(70),\n              state        INTEGER       NOT NULL,\n              state_time   INTEGER       NOT NULL,\n              retry_count  INTEGER       DEFAULT 0,\n              couch_record VARCHAR(255),\n              location     INTEGER,\n              outcome      INTEGER       DEFAULT 0,\n-             cache_dir    VARCHAR(767)  DEFAULT 'None',\n-             fwjr_path    VARCHAR(767),\n+             cache_dir    VARCHAR(70)  DEFAULT 'None',\n+             fwjr_path    VARCHAR(70),","path":"src/python/WMCore/WMBS/CreateWMBSBase.py","position":46,"original_position":46,"commit_id":"374a817fcf465dddc95c11d65a5a789c7f5bd5c8","original_commit_id":"44e4c881e3cb360856bcd62c1d699343e5c14a37","user":{"login":"vkuznet","id":125138,"avatar_url":"https://avatars.githubusercontent.com/u/125138?v=3","gravatar_id":"","url":"https://api.github.com/users/vkuznet","html_url":"https://github.com/vkuznet","followers_url":"https://api.github.com/users/vkuznet/followers","following_url":"https://api.github.com/users/vkuznet/following{/other_user}","gists_url":"https://api.github.com/users/vkuznet/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznet/subscriptions","organizations_url":"https://api.github.com/users/vkuznet/orgs","repos_url":"https://api.github.com/users/vkuznet/repos","events_url":"https://api.github.com/users/vkuznet/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznet/received_events","type":"User","site_admin":false},"body":"Dirk,\nwe discussed on a meeting that we WILL NOT do the actual merge until we resolve\nall issues and we agreed to do gradual adjustments.\nThe PR title reflect that:\nClean-up database usage in unittests, major upgrade do not merge\n\nIt does say *do not merge*.\n\nOn  0, Dirk Hufnagel <notifications@github.com> wrote:\n> >               state        INTEGER       NOT NULL,\n> >               state_time   INTEGER       NOT NULL,\n> >               retry_count  INTEGER       DEFAULT 0,\n> >               couch_record VARCHAR(255),\n> >               location     INTEGER,\n> >               outcome      INTEGER       DEFAULT 0,\n> > -             cache_dir    VARCHAR(767)  DEFAULT 'None',\n> > -             fwjr_path    VARCHAR(767),\n> > +             cache_dir    VARCHAR(70)  DEFAULT 'None',\n> > +             fwjr_path    VARCHAR(70),\n> \n> Just pointing out you can't commit any of these short column length because it'll break everything. If this is just an intermediate stage to get some tests to run, fine. But we can't forget about changing this back to longer columns.\n> \n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/dmwm/WMCore/pull/6260/files#r39899351\n","created_at":"2015-09-18T21:43:49Z","updated_at":"2015-09-18T21:43:49Z","html_url":"https://github.com/dmwm/WMCore/pull/6260#discussion_r39904233","pull_request_url":"https://api.github.com/repos/dmwm/WMCore/pulls/6260","_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments/39904233"},"html":{"href":"https://github.com/dmwm/WMCore/pull/6260#discussion_r39904233"},"pull_request":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/6260"}}},"pull_request":{"url":"https://api.github.com/repos/dmwm/WMCore/pulls/6260","id":45441897,"html_url":"https://github.com/dmwm/WMCore/pull/6260","diff_url":"https://github.com/dmwm/WMCore/pull/6260.diff","patch_url":"https://github.com/dmwm/WMCore/pull/6260.patch","issue_url":"https://api.github.com/repos/dmwm/WMCore/issues/6260","number":6260,"state":"open","locked":false,"title":"Clean-up database usage in unittests, major upgrade do not merge","user":{"login":"vkuznet","id":125138,"avatar_url":"https://avatars.githubusercontent.com/u/125138?v=3","gravatar_id":"","url":"https://api.github.com/users/vkuznet","html_url":"https://github.com/vkuznet","followers_url":"https://api.github.com/users/vkuznet/followers","following_url":"https://api.github.com/users/vkuznet/following{/other_user}","gists_url":"https://api.github.com/users/vkuznet/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznet/subscriptions","organizations_url":"https://api.github.com/users/vkuznet/orgs","repos_url":"https://api.github.com/users/vkuznet/repos","events_url":"https://api.github.com/users/vkuznet/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznet/received_events","type":"User","site_admin":false},"body":"Major upgrade: remove reallyDeleteMyDatabaseAfterEveryTest bot option and replace it with setUp/tearDown approach to setup/delete unittest databases for every unit test; re-factor DBCore class to use generators and be compatible with WMCore functionality; re-factor ResultSet to keep data instead of resultproxy objects; close all resultproxy objects once data is read from them; change logic of processData to use transaction (it as reversed); adjust all unit tests to create its own database for their test purposes","created_at":"2015-09-18T19:12:37Z","updated_at":"2015-09-18T21:43:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d21964b60cc0517e53473d11b467c2ac740e7138","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dmwm/WMCore/pulls/6260/commits","review_comments_url":"https://api.github.com/repos/dmwm/WMCore/pulls/6260/comments","review_comment_url":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmwm/WMCore/issues/6260/comments","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/374a817fcf465dddc95c11d65a5a789c7f5bd5c8","head":{"label":"vkuznet:fix-unittests","ref":"fix-unittests","sha":"374a817fcf465dddc95c11d65a5a789c7f5bd5c8","user":{"login":"vkuznet","id":125138,"avatar_url":"https://avatars.githubusercontent.com/u/125138?v=3","gravatar_id":"","url":"https://api.github.com/users/vkuznet","html_url":"https://github.com/vkuznet","followers_url":"https://api.github.com/users/vkuznet/followers","following_url":"https://api.github.com/users/vkuznet/following{/other_user}","gists_url":"https://api.github.com/users/vkuznet/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznet/subscriptions","organizations_url":"https://api.github.com/users/vkuznet/orgs","repos_url":"https://api.github.com/users/vkuznet/repos","events_url":"https://api.github.com/users/vkuznet/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznet/received_events","type":"User","site_admin":false},"repo":{"id":19494576,"name":"WMCore","full_name":"vkuznet/WMCore","owner":{"login":"vkuznet","id":125138,"avatar_url":"https://avatars.githubusercontent.com/u/125138?v=3","gravatar_id":"","url":"https://api.github.com/users/vkuznet","html_url":"https://github.com/vkuznet","followers_url":"https://api.github.com/users/vkuznet/followers","following_url":"https://api.github.com/users/vkuznet/following{/other_user}","gists_url":"https://api.github.com/users/vkuznet/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuznet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuznet/subscriptions","organizations_url":"https://api.github.com/users/vkuznet/orgs","repos_url":"https://api.github.com/users/vkuznet/repos","events_url":"https://api.github.com/users/vkuznet/events{/privacy}","received_events_url":"https://api.github.com/users/vkuznet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkuznet/WMCore","description":"WMCore","fork":true,"url":"https://api.github.com/repos/vkuznet/WMCore","forks_url":"https://api.github.com/repos/vkuznet/WMCore/forks","keys_url":"https://api.github.com/repos/vkuznet/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkuznet/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkuznet/WMCore/teams","hooks_url":"https://api.github.com/repos/vkuznet/WMCore/hooks","issue_events_url":"https://api.github.com/repos/vkuznet/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/vkuznet/WMCore/events","assignees_url":"https://api.github.com/repos/vkuznet/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/vkuznet/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/vkuznet/WMCore/tags","blobs_url":"https://api.github.com/repos/vkuznet/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkuznet/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkuznet/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkuznet/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkuznet/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/vkuznet/WMCore/languages","stargazers_url":"https://api.github.com/repos/vkuznet/WMCore/stargazers","contributors_url":"https://api.github.com/repos/vkuznet/WMCore/contributors","subscribers_url":"https://api.github.com/repos/vkuznet/WMCore/subscribers","subscription_url":"https://api.github.com/repos/vkuznet/WMCore/subscription","commits_url":"https://api.github.com/repos/vkuznet/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkuznet/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkuznet/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkuznet/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkuznet/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/vkuznet/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkuznet/WMCore/merges","archive_url":"https://api.github.com/repos/vkuznet/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkuznet/WMCore/downloads","issues_url":"https://api.github.com/repos/vkuznet/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/vkuznet/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/vkuznet/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/vkuznet/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkuznet/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/vkuznet/WMCore/releases{/id}","created_at":"2014-05-06T13:08:55Z","updated_at":"2015-05-08T14:47:14Z","pushed_at":"2015-09-18T20:23:59Z","git_url":"git://github.com/vkuznet/WMCore.git","ssh_url":"git@github.com:vkuznet/WMCore.git","clone_url":"https://github.com/vkuznet/WMCore.git","svn_url":"https://github.com/vkuznet/WMCore","homepage":"https://svnweb.cern.ch/trac/CMSDMWM/","size":24296,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmwm:master","ref":"master","sha":"223b6da25785d104a10cf2cf3f915bf7bcc1f618","user":{"login":"dmwm","id":988897,"avatar_url":"https://avatars.githubusercontent.com/u/988897?v=3","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"repo":{"id":2370458,"name":"WMCore","full_name":"dmwm/WMCore","owner":{"login":"dmwm","id":988897,"avatar_url":"https://avatars.githubusercontent.com/u/988897?v=3","gravatar_id":"","url":"https://api.github.com/users/dmwm","html_url":"https://github.com/dmwm","followers_url":"https://api.github.com/users/dmwm/followers","following_url":"https://api.github.com/users/dmwm/following{/other_user}","gists_url":"https://api.github.com/users/dmwm/gists{/gist_id}","starred_url":"https://api.github.com/users/dmwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmwm/subscriptions","organizations_url":"https://api.github.com/users/dmwm/orgs","repos_url":"https://api.github.com/users/dmwm/repos","events_url":"https://api.github.com/users/dmwm/events{/privacy}","received_events_url":"https://api.github.com/users/dmwm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmwm/WMCore","description":"WMCore","fork":false,"url":"https://api.github.com/repos/dmwm/WMCore","forks_url":"https://api.github.com/repos/dmwm/WMCore/forks","keys_url":"https://api.github.com/repos/dmwm/WMCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmwm/WMCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmwm/WMCore/teams","hooks_url":"https://api.github.com/repos/dmwm/WMCore/hooks","issue_events_url":"https://api.github.com/repos/dmwm/WMCore/issues/events{/number}","events_url":"https://api.github.com/repos/dmwm/WMCore/events","assignees_url":"https://api.github.com/repos/dmwm/WMCore/assignees{/user}","branches_url":"https://api.github.com/repos/dmwm/WMCore/branches{/branch}","tags_url":"https://api.github.com/repos/dmwm/WMCore/tags","blobs_url":"https://api.github.com/repos/dmwm/WMCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmwm/WMCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmwm/WMCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmwm/WMCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmwm/WMCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dmwm/WMCore/languages","stargazers_url":"https://api.github.com/repos/dmwm/WMCore/stargazers","contributors_url":"https://api.github.com/repos/dmwm/WMCore/contributors","subscribers_url":"https://api.github.com/repos/dmwm/WMCore/subscribers","subscription_url":"https://api.github.com/repos/dmwm/WMCore/subscription","commits_url":"https://api.github.com/repos/dmwm/WMCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmwm/WMCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmwm/WMCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmwm/WMCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmwm/WMCore/contents/{+path}","compare_url":"https://api.github.com/repos/dmwm/WMCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmwm/WMCore/merges","archive_url":"https://api.github.com/repos/dmwm/WMCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmwm/WMCore/downloads","issues_url":"https://api.github.com/repos/dmwm/WMCore/issues{/number}","pulls_url":"https://api.github.com/repos/dmwm/WMCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dmwm/WMCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dmwm/WMCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmwm/WMCore/labels{/name}","releases_url":"https://api.github.com/repos/dmwm/WMCore/releases{/id}","created_at":"2011-09-12T10:37:21Z","updated_at":"2015-05-08T18:42:10Z","pushed_at":"2015-09-18T21:18:56Z","git_url":"git://github.com/dmwm/WMCore.git","ssh_url":"git@github.com:dmwm/WMCore.git","clone_url":"https://github.com/dmwm/WMCore.git","svn_url":"https://github.com/dmwm/WMCore","homepage":"https://svnweb.cern.ch/trac/CMSDMWM/","size":63783,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":318,"forks":48,"open_issues":318,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/6260"},"html":{"href":"https://github.com/dmwm/WMCore/pull/6260"},"issue":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/6260"},"comments":{"href":"https://api.github.com/repos/dmwm/WMCore/issues/6260/comments"},"review_comments":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/6260/comments"},"review_comment":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmwm/WMCore/pulls/6260/commits"},"statuses":{"href":"https://api.github.com/repos/dmwm/WMCore/statuses/374a817fcf465dddc95c11d65a5a789c7f5bd5c8"}}}}