{"action":"created","issue":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/552","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/552/labels{/name}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/552/comments","events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/552/events","html_url":"https://github.com/OpenDungeons/OpenDungeons/issues/552","id":62424924,"number":552,"title":"Improve icon alignment in OpenDungeonsIcons.png","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/labels/Enhancement","name":"Enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/labels/Help%20wanted","name":"Help wanted","color":"159818"}],"state":"open","locked":false,"assignee":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/milestones/4","html_url":"https://github.com/OpenDungeons/OpenDungeons/milestones/0.5.0","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/milestones/4/labels","id":878113,"number":4,"title":"0.5.0","description":"This release is the continuation of the last release of the 0.4.x serie + a focus on finishing the base game play and using light and texture normals in a better way.\r\n\r\nThe most notable difference should be the addition of the Fog of War.","creator":{"login":"Bertram25","id":765917,"avatar_url":"https://avatars.githubusercontent.com/u/765917?v=3","gravatar_id":"","url":"https://api.github.com/users/Bertram25","html_url":"https://github.com/Bertram25","followers_url":"https://api.github.com/users/Bertram25/followers","following_url":"https://api.github.com/users/Bertram25/following{/other_user}","gists_url":"https://api.github.com/users/Bertram25/gists{/gist_id}","starred_url":"https://api.github.com/users/Bertram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bertram25/subscriptions","organizations_url":"https://api.github.com/users/Bertram25/orgs","repos_url":"https://api.github.com/users/Bertram25/repos","events_url":"https://api.github.com/users/Bertram25/events{/privacy}","received_events_url":"https://api.github.com/users/Bertram25/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":99,"state":"open","created_at":"2014-11-24T11:03:11Z","updated_at":"2015-03-17T15:17:00Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-03-17T15:16:59Z","updated_at":"2015-03-17T15:41:29Z","closed_at":null,"body":"I've had a closer look at our gui/OpenDungeonsIcons.png tileset, and I've noticed that the grid-alignment is not OCD-perfect ;-) Apart from the small 32x32 icons, all other icons should fit in a 64x64 frame, but I've noticed that some are not properly centred along a orthogonal grid with a base dimension of 64.\r\n\r\nSee the following screenshots taken in GIMP with the said grid.\r\nNote: the first and second screenshot have a grid offset of 32 px at the top to account for the row of 32x32 icons. It seems the icons at the bottom are more aligned as if there was no 32 px row, so I also made a screenshot with no grid offset.\r\n![icons1](https://cloud.githubusercontent.com/assets/4701338/6690342/5a5e2b6c-ccc0-11e4-9620-deb9917cd5f6.jpg)\r\n![icons2](https://cloud.githubusercontent.com/assets/4701338/6690344/5b44cb4e-ccc0-11e4-9191-72b6091d5507.jpg)\r\n![icons3](https://cloud.githubusercontent.com/assets/4701338/6690345/5c267eb8-ccc0-11e4-9967-70177a8daa99.jpg)\r\n\r\nYou can see for example that the gold tile is 63x64, and some other icons are not properly centred or do not fit in their supposed frame. I haven't looked at the CEGUI code yet, but my guess is that @Bertram25 used coordinates that were fitting, without forcefully checking that everything is centred on a 64x64 grid.\r\n\r\nIf you can confirm that, and point me to the relevant code that I'll have to edit if I move icons around, I propose to reorder the icons to fit on a 64x64 grid and let my OCD be at ease ;-)\r\nI would also propose to leave two rows on top for the 32x32 icons (even though the ones we are currently using fit on one row), this way we'll know that for the big icons, they always start at a multiple of 64, and not 64*n + 32.\r\n\r\nWDYT?"},"comment":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/comments/82421101","html_url":"https://github.com/OpenDungeons/OpenDungeons/issues/552#issuecomment-82421101","issue_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/552","id":82421101,"user":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T15:41:29Z","updated_at":"2015-03-17T15:41:29Z","body":"You should only have to mess with CEGUI files for most icons (text files easy to change in gui path).\r\nConcerning optional gui icons (like the green check), I'm not sure. I don't remember @Bertram25 PR but he should be able to tell you ^^"}}