{"action":"created","comment":{"url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/comments/35188723","id":35188723,"diff_hunk":"@@ -12,6 +12,10 @@\n \n @interface TNSTestNativeCallbacks : NSObject\n \n+typedef void (^TNSBlock)();\n+\n+@property(assign, nonatomic) TNSBlock block;","path":"tests/TestFixtures/TNSTestNativeCallbacks.h","position":6,"original_position":6,"commit_id":"e4802340c0b4b0ddbdb8d626090e24fab860c90d","original_commit_id":"e4802340c0b4b0ddbdb8d626090e24fab860c90d","user":{"login":"jasssonpet","id":305639,"avatar_url":"https://avatars.githubusercontent.com/u/305639?v=3","gravatar_id":"","url":"https://api.github.com/users/jasssonpet","html_url":"https://github.com/jasssonpet","followers_url":"https://api.github.com/users/jasssonpet/followers","following_url":"https://api.github.com/users/jasssonpet/following{/other_user}","gists_url":"https://api.github.com/users/jasssonpet/gists{/gist_id}","starred_url":"https://api.github.com/users/jasssonpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasssonpet/subscriptions","organizations_url":"https://api.github.com/users/jasssonpet/orgs","repos_url":"https://api.github.com/users/jasssonpet/repos","events_url":"https://api.github.com/users/jasssonpet/events{/privacy}","received_events_url":"https://api.github.com/users/jasssonpet/received_events","type":"User","site_admin":false},"body":"I would suggest to move this to `TNSObjCTypes.m` where we have tests like:\r\n* `methodWithNSDate`\r\n* `methodWithNSArray`\r\n* `methodWithNSDictionary`\r\n* `methodWithNSData`\r\n\r\nwhich test the same thing (that the object is the same).\r\n\r\nAlso removing the property from the header won't make the test fail, an is a bit brittle.","created_at":"2015-07-22T07:49:26Z","updated_at":"2015-07-22T07:49:26Z","html_url":"https://github.com/NativeScript/ios-runtime/pull/234#discussion_r35188723","pull_request_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/comments/35188723"},"html":{"href":"https://github.com/NativeScript/ios-runtime/pull/234#discussion_r35188723"},"pull_request":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234","id":40448518,"html_url":"https://github.com/NativeScript/ios-runtime/pull/234","diff_url":"https://github.com/NativeScript/ios-runtime/pull/234.diff","patch_url":"https://github.com/NativeScript/ios-runtime/pull/234.patch","issue_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/234","number":234,"state":"open","locked":false,"title":"JavaScript functions, when passed to Objective-C as blocks, will now round-trip back to JavaScript, as the initial function object.","user":{"login":"PanayotCankov","id":5919275,"avatar_url":"https://avatars.githubusercontent.com/u/5919275?v=3","gravatar_id":"","url":"https://api.github.com/users/PanayotCankov","html_url":"https://github.com/PanayotCankov","followers_url":"https://api.github.com/users/PanayotCankov/followers","following_url":"https://api.github.com/users/PanayotCankov/following{/other_user}","gists_url":"https://api.github.com/users/PanayotCankov/gists{/gist_id}","starred_url":"https://api.github.com/users/PanayotCankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanayotCankov/subscriptions","organizations_url":"https://api.github.com/users/PanayotCankov/orgs","repos_url":"https://api.github.com/users/PanayotCankov/repos","events_url":"https://api.github.com/users/PanayotCankov/events{/privacy}","received_events_url":"https://api.github.com/users/PanayotCankov/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-21T11:49:14Z","updated_at":"2015-07-22T07:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a110504f954b1e3d3b02b0f8133b1c28324d13","assignee":{"login":"PanayotCankov","id":5919275,"avatar_url":"https://avatars.githubusercontent.com/u/5919275?v=3","gravatar_id":"","url":"https://api.github.com/users/PanayotCankov","html_url":"https://github.com/PanayotCankov","followers_url":"https://api.github.com/users/PanayotCankov/followers","following_url":"https://api.github.com/users/PanayotCankov/following{/other_user}","gists_url":"https://api.github.com/users/PanayotCankov/gists{/gist_id}","starred_url":"https://api.github.com/users/PanayotCankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanayotCankov/subscriptions","organizations_url":"https://api.github.com/users/PanayotCankov/orgs","repos_url":"https://api.github.com/users/PanayotCankov/repos","events_url":"https://api.github.com/users/PanayotCankov/events{/privacy}","received_events_url":"https://api.github.com/users/PanayotCankov/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/NativeScript/ios-runtime/milestones/4","html_url":"https://github.com/NativeScript/ios-runtime/milestones/1.3.0%20(Under%20Review)","labels_url":"https://api.github.com/repos/NativeScript/ios-runtime/milestones/4/labels","id":1109711,"number":4,"title":"1.3.0 (Under Review)","description":"","creator":{"login":"PanayotCankov","id":5919275,"avatar_url":"https://avatars.githubusercontent.com/u/5919275?v=3","gravatar_id":"","url":"https://api.github.com/users/PanayotCankov","html_url":"https://github.com/PanayotCankov","followers_url":"https://api.github.com/users/PanayotCankov/followers","following_url":"https://api.github.com/users/PanayotCankov/following{/other_user}","gists_url":"https://api.github.com/users/PanayotCankov/gists{/gist_id}","starred_url":"https://api.github.com/users/PanayotCankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanayotCankov/subscriptions","organizations_url":"https://api.github.com/users/PanayotCankov/orgs","repos_url":"https://api.github.com/users/PanayotCankov/repos","events_url":"https://api.github.com/users/PanayotCankov/events{/privacy}","received_events_url":"https://api.github.com/users/PanayotCankov/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":0,"state":"open","created_at":"2015-05-14T06:41:22Z","updated_at":"2015-07-21T15:22:40Z","due_on":"2015-09-08T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234/commits","review_comments_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234/comments","review_comment_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/234/comments","statuses_url":"https://api.github.com/repos/NativeScript/ios-runtime/statuses/e4802340c0b4b0ddbdb8d626090e24fab860c90d","head":{"label":"NativeScript:roundtrip-block-functions","ref":"roundtrip-block-functions","sha":"e4802340c0b4b0ddbdb8d626090e24fab860c90d","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":29675401,"name":"ios-runtime","full_name":"NativeScript/ios-runtime","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/ios-runtime","description":"iOS runtime for NativeScript (based on JavaScriptCore)","fork":false,"url":"https://api.github.com/repos/NativeScript/ios-runtime","forks_url":"https://api.github.com/repos/NativeScript/ios-runtime/forks","keys_url":"https://api.github.com/repos/NativeScript/ios-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/ios-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/ios-runtime/teams","hooks_url":"https://api.github.com/repos/NativeScript/ios-runtime/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/ios-runtime/events","assignees_url":"https://api.github.com/repos/NativeScript/ios-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/ios-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/ios-runtime/tags","blobs_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/ios-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/ios-runtime/languages","stargazers_url":"https://api.github.com/repos/NativeScript/ios-runtime/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/ios-runtime/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/ios-runtime/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/ios-runtime/subscription","commits_url":"https://api.github.com/repos/NativeScript/ios-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/ios-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/ios-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/ios-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/ios-runtime/merges","archive_url":"https://api.github.com/repos/NativeScript/ios-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/ios-runtime/downloads","issues_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/ios-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/ios-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/ios-runtime/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/ios-runtime/releases{/id}","created_at":"2015-01-22T11:21:31Z","updated_at":"2015-07-09T17:01:45Z","pushed_at":"2015-07-22T07:23:47Z","git_url":"git://github.com/NativeScript/ios-runtime.git","ssh_url":"git@github.com:NativeScript/ios-runtime.git","clone_url":"https://github.com/NativeScript/ios-runtime.git","svn_url":"https://github.com/NativeScript/ios-runtime","homepage":"http://docs.nativescript.org/runtimes/ios","size":57828,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":67,"forks":10,"open_issues":67,"watchers":68,"default_branch":"master"}},"base":{"label":"NativeScript:master","ref":"master","sha":"0f67a2bb27c320e801fb7592bbcf39fe68729db0","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":29675401,"name":"ios-runtime","full_name":"NativeScript/ios-runtime","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/ios-runtime","description":"iOS runtime for NativeScript (based on JavaScriptCore)","fork":false,"url":"https://api.github.com/repos/NativeScript/ios-runtime","forks_url":"https://api.github.com/repos/NativeScript/ios-runtime/forks","keys_url":"https://api.github.com/repos/NativeScript/ios-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/ios-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/ios-runtime/teams","hooks_url":"https://api.github.com/repos/NativeScript/ios-runtime/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/ios-runtime/events","assignees_url":"https://api.github.com/repos/NativeScript/ios-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/ios-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/ios-runtime/tags","blobs_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/ios-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/ios-runtime/languages","stargazers_url":"https://api.github.com/repos/NativeScript/ios-runtime/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/ios-runtime/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/ios-runtime/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/ios-runtime/subscription","commits_url":"https://api.github.com/repos/NativeScript/ios-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/ios-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/ios-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/ios-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/ios-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/ios-runtime/merges","archive_url":"https://api.github.com/repos/NativeScript/ios-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/ios-runtime/downloads","issues_url":"https://api.github.com/repos/NativeScript/ios-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/ios-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/ios-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/ios-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/ios-runtime/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/ios-runtime/releases{/id}","created_at":"2015-01-22T11:21:31Z","updated_at":"2015-07-09T17:01:45Z","pushed_at":"2015-07-22T07:23:47Z","git_url":"git://github.com/NativeScript/ios-runtime.git","ssh_url":"git@github.com:NativeScript/ios-runtime.git","clone_url":"https://github.com/NativeScript/ios-runtime.git","svn_url":"https://github.com/NativeScript/ios-runtime","homepage":"http://docs.nativescript.org/runtimes/ios","size":57828,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":67,"forks":10,"open_issues":67,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234"},"html":{"href":"https://github.com/NativeScript/ios-runtime/pull/234"},"issue":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/issues/234"},"comments":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/ios-runtime/statuses/e4802340c0b4b0ddbdb8d626090e24fab860c90d"}}}}