{"action":"created","issue":{"url":"https://api.github.com/repos/stellar/stellar-core/issues/142","labels_url":"https://api.github.com/repos/stellar/stellar-core/issues/142/labels{/name}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/142/comments","events_url":"https://api.github.com/repos/stellar/stellar-core/issues/142/events","html_url":"https://github.com/stellar/stellar-core/issues/142","id":58136302,"number":142,"title":"Quote SQL identifiers to so we are explicit about casing","user":{"login":"nullstyle","id":366,"avatar_url":"https://avatars.githubusercontent.com/u/366?v=3","gravatar_id":"","url":"https://api.github.com/users/nullstyle","html_url":"https://github.com/nullstyle","followers_url":"https://api.github.com/users/nullstyle/followers","following_url":"https://api.github.com/users/nullstyle/following{/other_user}","gists_url":"https://api.github.com/users/nullstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/nullstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nullstyle/subscriptions","organizations_url":"https://api.github.com/users/nullstyle/orgs","repos_url":"https://api.github.com/users/nullstyle/repos","events_url":"https://api.github.com/users/nullstyle/events{/privacy}","received_events_url":"https://api.github.com/users/nullstyle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/stellar/stellar-core/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars.githubusercontent.com/u/4213763?v=3","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/stellar/stellar-core/milestones/5","html_url":"https://github.com/stellar/stellar-core/milestones/Production","labels_url":"https://api.github.com/repos/stellar/stellar-core/milestones/5/labels","id":1071387,"number":5,"title":"Production","description":"stellar-core network is on production for integrators.","creator":{"login":"bekkibolthouse","id":5542732,"avatar_url":"https://avatars.githubusercontent.com/u/5542732?v=3","gravatar_id":"","url":"https://api.github.com/users/bekkibolthouse","html_url":"https://github.com/bekkibolthouse","followers_url":"https://api.github.com/users/bekkibolthouse/followers","following_url":"https://api.github.com/users/bekkibolthouse/following{/other_user}","gists_url":"https://api.github.com/users/bekkibolthouse/gists{/gist_id}","starred_url":"https://api.github.com/users/bekkibolthouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bekkibolthouse/subscriptions","organizations_url":"https://api.github.com/users/bekkibolthouse/orgs","repos_url":"https://api.github.com/users/bekkibolthouse/repos","events_url":"https://api.github.com/users/bekkibolthouse/events{/privacy}","received_events_url":"https://api.github.com/users/bekkibolthouse/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":6,"state":"open","created_at":"2015-04-16T21:46:59Z","updated_at":"2015-05-19T21:56:39Z","due_on":"2015-06-15T07:00:00Z","closed_at":null},"comments":3,"created_at":"2015-02-18T22:07:13Z","updated_at":"2015-05-19T21:56:39Z","closed_at":"2015-05-19T21:56:39Z","body":"According to SQL-92, identifiers that are not quoted are case-insensitive.  Postgresql supports this by lower-casing all unquoted identifiers transparently.  Sqlite does not have this problem.\r\n\r\nUnfortunately some SQL toolkits (for example, both ActiveRecord and Sequel) will always quote identifiers for the SQL they produce.  To integrate with the hayashi DB, a developer will have to manually convert to the lower-cased form, which could be confusing (well, it certainly was for me).\r\n\r\nIMO, we should either:\r\n\r\n1.  Continue to use mixed casing in our SQL, but quote all identifiers such that casing is as expected\r\n2.  Do not rely upon casing, i.e. lowercase everything and use underscores for word separation."},"comment":{"url":"https://api.github.com/repos/stellar/stellar-core/issues/comments/103679446","html_url":"https://github.com/stellar/stellar-core/issues/142#issuecomment-103679446","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/142","id":103679446,"user":{"login":"MonsieurNicolas","id":4213763,"avatar_url":"https://avatars.githubusercontent.com/u/4213763?v=3","gravatar_id":"","url":"https://api.github.com/users/MonsieurNicolas","html_url":"https://github.com/MonsieurNicolas","followers_url":"https://api.github.com/users/MonsieurNicolas/followers","following_url":"https://api.github.com/users/MonsieurNicolas/following{/other_user}","gists_url":"https://api.github.com/users/MonsieurNicolas/gists{/gist_id}","starred_url":"https://api.github.com/users/MonsieurNicolas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MonsieurNicolas/subscriptions","organizations_url":"https://api.github.com/users/MonsieurNicolas/orgs","repos_url":"https://api.github.com/users/MonsieurNicolas/repos","events_url":"https://api.github.com/users/MonsieurNicolas/events{/privacy}","received_events_url":"https://api.github.com/users/MonsieurNicolas/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T21:56:39Z","updated_at":"2015-05-19T21:56:39Z","body":"no it is done - all lowercase now"}}