{"action":"closed","number":2295,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2295","id":34204171,"html_url":"https://github.com/dotnet/roslyn/pull/2295","diff_url":"https://github.com/dotnet/roslyn/pull/2295.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2295.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2295","number":2295,"state":"closed","locked":false,"title":"Change sibling check to use similarity instead of exact match","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"body":"Fix for #463 \r\n\r\nThe syntax differ algorithm tries to determine if an insert occurred by noticing that the old version of the sub-tree it is considering appears later in the local region of the new tree.  \r\n\r\nFor example, there used to be an 'X' here but now there is a 'Y'.  However, there is an 'X' that appears right after the 'Y'.  In this case, the algorithm decides that the 'Y' was inserted.  \r\n\r\nYet, the algorithm is easily fooled if the original has multiple of the same nodes. In this case, the original had 'XX' and the new tree has 'YX'.  Instead of assuming that the 'Y' was inserted and later deducing that an 'X' is missing (a delete), it is better to consider that the 'X' was turned into a 'Y'.\r\n\r\nThe original fix was to not consider the change an insert if the original tree had nearby duplicates. However, it required the green nodes to exactly match to consider the two nodes as duplicates.\r\n\r\nThe new fix changes what it means to be a duplicate. It now uses the same similarity measure that was used to determine if the old nodes has a match further on in the new tree, and only if this match is better than the similarity between the two old tree nodes does it determine that an insert has occurred.","created_at":"2015-04-27T19:58:53Z","updated_at":"2015-04-27T21:34:23Z","closed_at":"2015-04-27T21:34:23Z","merged_at":"2015-04-27T21:34:23Z","merge_commit_sha":"dc65c7c36c8511f9d3387fb63d859c065e4a7d6f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2295/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2295/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2295/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/ec08ef173ca38103f91f960d0a19ad78cc982739","head":{"label":"mattwar:Bug463","ref":"Bug463","sha":"ec08ef173ca38103f91f960d0a19ad78cc982739","user":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"repo":{"id":30200787,"name":"roslyn","full_name":"mattwar/roslyn","owner":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattwar/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/mattwar/roslyn","forks_url":"https://api.github.com/repos/mattwar/roslyn/forks","keys_url":"https://api.github.com/repos/mattwar/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattwar/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattwar/roslyn/teams","hooks_url":"https://api.github.com/repos/mattwar/roslyn/hooks","issue_events_url":"https://api.github.com/repos/mattwar/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/mattwar/roslyn/events","assignees_url":"https://api.github.com/repos/mattwar/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/mattwar/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/mattwar/roslyn/tags","blobs_url":"https://api.github.com/repos/mattwar/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattwar/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattwar/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattwar/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattwar/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/mattwar/roslyn/languages","stargazers_url":"https://api.github.com/repos/mattwar/roslyn/stargazers","contributors_url":"https://api.github.com/repos/mattwar/roslyn/contributors","subscribers_url":"https://api.github.com/repos/mattwar/roslyn/subscribers","subscription_url":"https://api.github.com/repos/mattwar/roslyn/subscription","commits_url":"https://api.github.com/repos/mattwar/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattwar/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattwar/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattwar/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattwar/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/mattwar/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattwar/roslyn/merges","archive_url":"https://api.github.com/repos/mattwar/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattwar/roslyn/downloads","issues_url":"https://api.github.com/repos/mattwar/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/mattwar/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/mattwar/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/mattwar/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattwar/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/mattwar/roslyn/releases{/id}","created_at":"2015-02-02T18:12:54Z","updated_at":"2015-04-27T17:59:48Z","pushed_at":"2015-04-27T19:39:20Z","git_url":"git://github.com/mattwar/roslyn.git","ssh_url":"git@github.com:mattwar/roslyn.git","clone_url":"https://github.com/mattwar/roslyn.git","svn_url":"https://github.com/mattwar/roslyn","homepage":"","size":68783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0e22aa8f937f626b87ca311a6327f9fc07962329","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-04-27T21:32:29Z","pushed_at":"2015-04-27T21:34:23Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":115957,"stargazers_count":2014,"watchers_count":2014,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":435,"mirror_url":null,"open_issues_count":757,"forks":435,"open_issues":757,"watchers":2014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2295"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2295"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2295"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2295/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2295/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2295/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/ec08ef173ca38103f91f960d0a19ad78cc982739"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattwar","id":3387305,"avatar_url":"https://avatars.githubusercontent.com/u/3387305?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwar","html_url":"https://github.com/mattwar","followers_url":"https://api.github.com/users/mattwar/followers","following_url":"https://api.github.com/users/mattwar/following{/other_user}","gists_url":"https://api.github.com/users/mattwar/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwar/subscriptions","organizations_url":"https://api.github.com/users/mattwar/orgs","repos_url":"https://api.github.com/users/mattwar/repos","events_url":"https://api.github.com/users/mattwar/events{/privacy}","received_events_url":"https://api.github.com/users/mattwar/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":52,"deletions":67,"changed_files":2}}