{"push_id":798321585,"size":1,"distinct_size":1,"ref":"refs/heads/release-0.7.x","head":"7dd1ea28113751f977c7f0169682a469d9b524e5","before":"6d018ec58b3248121dfe3cd35282e1e6ff112f69","commits":[{"sha":"7dd1ea28113751f977c7f0169682a469d9b524e5","author":{"email":"8ad00dfc12a2e7d2f39c6e16431645cadc755d84@gmail.com","name":"Griffin Myers"},"message":"Fix unicode-related error for SVN when using --repository-url option\n\nFix a lurking unicode string in get_repository_info() for specifying the\ndefault base_path. This could cause a crash in convert_to_absolute_paths() when\njoining with a filename containing non-UTF8 characters. This case was only\naccessible when the --repository-url option was specified.\n\nAdded a new test case to exercise this bug, and it failed as expected before\nthe fix was introduced.  Since this case requires --repository-url it is\nnecessary to update the testdata repository to contain a file with a non-UTF8\nfilename. Thus, I introduced revision 4 to the repo which adds a single file\nwith a non-UTF8 character in both its name and file contents.\n\nCausing HEAD of the testrepo to advance to r4 in turn caused the existing\ntest_diff_exclude() test to fail. This is because this test was modifying\nfoo.txt, which is already in the repo, which causes the diff signature to\nchange to indicate revision 4 versus 3. This is the only test case that has a\ndependency on the current HEAD revision number, so to prevent this regression\nfrom occurring again in the future, I altered the test to add a new new file\n(bar.txt) rather than modifying an existing file. This change in approach does\nnot impact the underlying purpose of the test. Note, since the diff signature\nfor file additions varies between SVN client versions the decorator is now\nutilized to generate the correct MD5 hash.\n\nTesting done:\nRan all unit tests under both SVN 1.6.23 and 1.7.14.\n\nFixes bug 3969.\n\nReviewed at https://reviews.reviewboard.org/r/7644/","distinct":true,"url":"https://api.github.com/repos/reviewboard/rbtools/commits/7dd1ea28113751f977c7f0169682a469d9b524e5"}]}