{"action":"created","issue":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3966","labels_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3966/labels{/name}","comments_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3966/comments","events_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3966/events","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3966","id":86136103,"number":3966,"title":"Fix the spectrum_ls implementation","user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-06-08T11:22:47Z","updated_at":"2015-06-08T14:13:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/pulls/3966","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3966","diff_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3966.diff","patch_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3966.patch"},"body":"Fixes #3964 \r\n\r\nThe current `spectrum_ls` is using `%F/%f` prompt codes. These don't seem to support 256 colors. This changes it to use the control sequences it's defined in `$FG`.\r\n\r\nAlso adjusts the spectrum_bls implementation so the leading number is not included in the coloration, to ensure that it's always readable, even when the background color being displayed is close to the foreground text color."},"comment":{"url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/comments/110008739","html_url":"https://github.com/robbyrussell/oh-my-zsh/pull/3966#issuecomment-110008739","issue_url":"https://api.github.com/repos/robbyrussell/oh-my-zsh/issues/3966","id":110008739,"user":{"login":"apjanke","id":2618447,"avatar_url":"https://avatars.githubusercontent.com/u/2618447?v=3","gravatar_id":"","url":"https://api.github.com/users/apjanke","html_url":"https://github.com/apjanke","followers_url":"https://api.github.com/users/apjanke/followers","following_url":"https://api.github.com/users/apjanke/following{/other_user}","gists_url":"https://api.github.com/users/apjanke/gists{/gist_id}","starred_url":"https://api.github.com/users/apjanke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apjanke/subscriptions","organizations_url":"https://api.github.com/users/apjanke/orgs","repos_url":"https://api.github.com/users/apjanke/repos","events_url":"https://api.github.com/users/apjanke/events{/privacy}","received_events_url":"https://api.github.com/users/apjanke/received_events","type":"User","site_admin":false},"created_at":"2015-06-08T14:13:11Z","updated_at":"2015-06-08T14:13:11Z","body":"I'm reopening this PR, because I think this is still the right implementation. \r\n\r\nEven though I could get the current implementation to display all 256 colors by tweaking my `$TERM` setting, `spectrum_ls` is part of `spectrum`, and it should expose exactly what `$FG` contains, not what Zsh's `%F` supports, even though in many cases they should be the same thing.\r\n\r\nThis change gets `spectrum_ls` to match `$FG` exactly, and to be consistent with the behavior of `spectrum_bls`."}}