{"action":"created","comment":{"url":"https://api.github.com/repos/cfengine/core/pulls/comments/28145854","id":28145854,"diff_hunk":"@@ -510,40 +510,76 @@ void InsertAfter(Item **filestart, Item *ptr, const char *string)\n     ip->classes = NULL;\n }\n \n+/**\n+ *  Splits a string containing a separator like ':' into a linked list of\n+ *  separate items,\n+ *\n+ *  @NOTE backslashes can be used to escape either the separator, or the\n+ *        backslash itself, e.g. \"\\:\" or \"\\\\\" (ofcourse proper C strings need\n+ *        double backslash).","path":"libpromises/item_lib.c","position":10,"original_position":10,"commit_id":"b6ebc0d20aec9e9b43b02cdbbdb8e7cb4cda6ecc","original_commit_id":"b6ebc0d20aec9e9b43b02cdbbdb8e7cb4cda6ecc","user":{"login":"ediosyncratic","id":2255042,"avatar_url":"https://avatars.githubusercontent.com/u/2255042?v=3","gravatar_id":"","url":"https://api.github.com/users/ediosyncratic","html_url":"https://github.com/ediosyncratic","followers_url":"https://api.github.com/users/ediosyncratic/followers","following_url":"https://api.github.com/users/ediosyncratic/following{/other_user}","gists_url":"https://api.github.com/users/ediosyncratic/gists{/gist_id}","starred_url":"https://api.github.com/users/ediosyncratic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ediosyncratic/subscriptions","organizations_url":"https://api.github.com/users/ediosyncratic/orgs","repos_url":"https://api.github.com/users/ediosyncratic/repos","events_url":"https://api.github.com/users/ediosyncratic/events{/privacy}","received_events_url":"https://api.github.com/users/ediosyncratic/received_events","type":"User","site_admin":false},"body":"Note that backslash cannot be used as separator.\r\nThis is unfortunate when you consider splitting a DOS-path to get a list of components.","created_at":"2015-04-10T13:56:45Z","updated_at":"2015-04-10T13:56:45Z","html_url":"https://github.com/cfengine/core/pull/2140#discussion_r28145854","pull_request_url":"https://api.github.com/repos/cfengine/core/pulls/2140","_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments/28145854"},"html":{"href":"https://github.com/cfengine/core/pull/2140#discussion_r28145854"},"pull_request":{"href":"https://api.github.com/repos/cfengine/core/pulls/2140"}}},"pull_request":{"url":"https://api.github.com/repos/cfengine/core/pulls/2140","id":31426738,"html_url":"https://github.com/cfengine/core/pull/2140","diff_url":"https://github.com/cfengine/core/pull/2140.diff","patch_url":"https://github.com/cfengine/core/pull/2140.patch","issue_url":"https://api.github.com/repos/cfengine/core/issues/2140","number":2140,"state":"closed","locked":false,"title":"SplitString() now works for all corner cases.","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-18T13:09:50Z","updated_at":"2015-04-10T13:56:45Z","closed_at":"2015-03-24T12:52:01Z","merged_at":"2015-03-24T12:52:01Z","merge_commit_sha":"7418903feeaf657afdbcc770b71e1788211bf7a5","assignee":{"login":"kacfengine","id":4037094,"avatar_url":"https://avatars.githubusercontent.com/u/4037094?v=3","gravatar_id":"","url":"https://api.github.com/users/kacfengine","html_url":"https://github.com/kacfengine","followers_url":"https://api.github.com/users/kacfengine/followers","following_url":"https://api.github.com/users/kacfengine/following{/other_user}","gists_url":"https://api.github.com/users/kacfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kacfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacfengine/subscriptions","organizations_url":"https://api.github.com/users/kacfengine/orgs","repos_url":"https://api.github.com/users/kacfengine/repos","events_url":"https://api.github.com/users/kacfengine/events{/privacy}","received_events_url":"https://api.github.com/users/kacfengine/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cfengine/core/pulls/2140/commits","review_comments_url":"https://api.github.com/repos/cfengine/core/pulls/2140/comments","review_comment_url":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cfengine/core/issues/2140/comments","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/b6ebc0d20aec9e9b43b02cdbbdb8e7cb4cda6ecc","head":{"label":"jimis:worr-4k_splitstring","ref":"worr-4k_splitstring","sha":"b6ebc0d20aec9e9b43b02cdbbdb8e7cb4cda6ecc","user":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"repo":{"id":8216817,"name":"core","full_name":"jimis/core","owner":{"login":"jimis","id":3584514,"avatar_url":"https://avatars.githubusercontent.com/u/3584514?v=3","gravatar_id":"","url":"https://api.github.com/users/jimis","html_url":"https://github.com/jimis","followers_url":"https://api.github.com/users/jimis/followers","following_url":"https://api.github.com/users/jimis/following{/other_user}","gists_url":"https://api.github.com/users/jimis/gists{/gist_id}","starred_url":"https://api.github.com/users/jimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimis/subscriptions","organizations_url":"https://api.github.com/users/jimis/orgs","repos_url":"https://api.github.com/users/jimis/repos","events_url":"https://api.github.com/users/jimis/events{/privacy}","received_events_url":"https://api.github.com/users/jimis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimis/core","description":"CFEngine Community","fork":true,"url":"https://api.github.com/repos/jimis/core","forks_url":"https://api.github.com/repos/jimis/core/forks","keys_url":"https://api.github.com/repos/jimis/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimis/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimis/core/teams","hooks_url":"https://api.github.com/repos/jimis/core/hooks","issue_events_url":"https://api.github.com/repos/jimis/core/issues/events{/number}","events_url":"https://api.github.com/repos/jimis/core/events","assignees_url":"https://api.github.com/repos/jimis/core/assignees{/user}","branches_url":"https://api.github.com/repos/jimis/core/branches{/branch}","tags_url":"https://api.github.com/repos/jimis/core/tags","blobs_url":"https://api.github.com/repos/jimis/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimis/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimis/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimis/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimis/core/statuses/{sha}","languages_url":"https://api.github.com/repos/jimis/core/languages","stargazers_url":"https://api.github.com/repos/jimis/core/stargazers","contributors_url":"https://api.github.com/repos/jimis/core/contributors","subscribers_url":"https://api.github.com/repos/jimis/core/subscribers","subscription_url":"https://api.github.com/repos/jimis/core/subscription","commits_url":"https://api.github.com/repos/jimis/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimis/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimis/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimis/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimis/core/contents/{+path}","compare_url":"https://api.github.com/repos/jimis/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimis/core/merges","archive_url":"https://api.github.com/repos/jimis/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimis/core/downloads","issues_url":"https://api.github.com/repos/jimis/core/issues{/number}","pulls_url":"https://api.github.com/repos/jimis/core/pulls{/number}","milestones_url":"https://api.github.com/repos/jimis/core/milestones{/number}","notifications_url":"https://api.github.com/repos/jimis/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimis/core/labels{/name}","releases_url":"https://api.github.com/repos/jimis/core/releases{/id}","created_at":"2013-02-15T10:54:22Z","updated_at":"2015-03-19T15:47:20Z","pushed_at":"2015-03-20T19:29:53Z","git_url":"git://github.com/jimis/core.git","ssh_url":"git@github.com:jimis/core.git","clone_url":"https://github.com/jimis/core.git","svn_url":"https://github.com/jimis/core","homepage":"https://cfengine.com/community/","size":53472,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cfengine:master","ref":"master","sha":"2071b487c910080200496be750a59066f2673715","user":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"repo":{"id":3543548,"name":"core","full_name":"cfengine/core","owner":{"login":"cfengine","id":1239823,"avatar_url":"https://avatars.githubusercontent.com/u/1239823?v=3","gravatar_id":"","url":"https://api.github.com/users/cfengine","html_url":"https://github.com/cfengine","followers_url":"https://api.github.com/users/cfengine/followers","following_url":"https://api.github.com/users/cfengine/following{/other_user}","gists_url":"https://api.github.com/users/cfengine/gists{/gist_id}","starred_url":"https://api.github.com/users/cfengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfengine/subscriptions","organizations_url":"https://api.github.com/users/cfengine/orgs","repos_url":"https://api.github.com/users/cfengine/repos","events_url":"https://api.github.com/users/cfengine/events{/privacy}","received_events_url":"https://api.github.com/users/cfengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cfengine/core","description":"CFEngine Community","fork":false,"url":"https://api.github.com/repos/cfengine/core","forks_url":"https://api.github.com/repos/cfengine/core/forks","keys_url":"https://api.github.com/repos/cfengine/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cfengine/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cfengine/core/teams","hooks_url":"https://api.github.com/repos/cfengine/core/hooks","issue_events_url":"https://api.github.com/repos/cfengine/core/issues/events{/number}","events_url":"https://api.github.com/repos/cfengine/core/events","assignees_url":"https://api.github.com/repos/cfengine/core/assignees{/user}","branches_url":"https://api.github.com/repos/cfengine/core/branches{/branch}","tags_url":"https://api.github.com/repos/cfengine/core/tags","blobs_url":"https://api.github.com/repos/cfengine/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cfengine/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cfengine/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cfengine/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cfengine/core/statuses/{sha}","languages_url":"https://api.github.com/repos/cfengine/core/languages","stargazers_url":"https://api.github.com/repos/cfengine/core/stargazers","contributors_url":"https://api.github.com/repos/cfengine/core/contributors","subscribers_url":"https://api.github.com/repos/cfengine/core/subscribers","subscription_url":"https://api.github.com/repos/cfengine/core/subscription","commits_url":"https://api.github.com/repos/cfengine/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cfengine/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cfengine/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cfengine/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cfengine/core/contents/{+path}","compare_url":"https://api.github.com/repos/cfengine/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cfengine/core/merges","archive_url":"https://api.github.com/repos/cfengine/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cfengine/core/downloads","issues_url":"https://api.github.com/repos/cfengine/core/issues{/number}","pulls_url":"https://api.github.com/repos/cfengine/core/pulls{/number}","milestones_url":"https://api.github.com/repos/cfengine/core/milestones{/number}","notifications_url":"https://api.github.com/repos/cfengine/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cfengine/core/labels{/name}","releases_url":"https://api.github.com/repos/cfengine/core/releases{/id}","created_at":"2012-02-25T09:19:05Z","updated_at":"2015-04-10T09:32:08Z","pushed_at":"2015-04-10T09:32:08Z","git_url":"git://github.com/cfengine/core.git","ssh_url":"git@github.com:cfengine/core.git","clone_url":"https://github.com/cfengine/core.git","svn_url":"https://github.com/cfengine/core","homepage":"https://cfengine.com/community/","size":94165,"stargazers_count":213,"watchers_count":213,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":27,"forks":134,"open_issues":27,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cfengine/core/pulls/2140"},"html":{"href":"https://github.com/cfengine/core/pull/2140"},"issue":{"href":"https://api.github.com/repos/cfengine/core/issues/2140"},"comments":{"href":"https://api.github.com/repos/cfengine/core/issues/2140/comments"},"review_comments":{"href":"https://api.github.com/repos/cfengine/core/pulls/2140/comments"},"review_comment":{"href":"https://api.github.com/repos/cfengine/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cfengine/core/pulls/2140/commits"},"statuses":{"href":"https://api.github.com/repos/cfengine/core/statuses/b6ebc0d20aec9e9b43b02cdbbdb8e7cb4cda6ecc"}}}}