{"action":"created","issue":{"url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/63","labels_url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/63/comments","events_url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/63/events","html_url":"https://github.com/KanoComputing/kano-burners/issues/63","id":105558572,"number":63,"title":"[Downloading] Remove pySmartDL if not used for downloading","user":{"login":"radujipa","id":3577547,"avatar_url":"https://avatars.githubusercontent.com/u/3577547?v=3","gravatar_id":"","url":"https://api.github.com/users/radujipa","html_url":"https://github.com/radujipa","followers_url":"https://api.github.com/users/radujipa/followers","following_url":"https://api.github.com/users/radujipa/following{/other_user}","gists_url":"https://api.github.com/users/radujipa/gists{/gist_id}","starred_url":"https://api.github.com/users/radujipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radujipa/subscriptions","organizations_url":"https://api.github.com/users/radujipa/orgs","repos_url":"https://api.github.com/users/radujipa/repos","events_url":"https://api.github.com/users/radujipa/events{/privacy}","received_events_url":"https://api.github.com/users/radujipa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/KanoComputing/kano-burners/labels/1%20-%20ToDo","name":"1 - ToDo","color":"f7c6c7"},{"url":"https://api.github.com/repos/KanoComputing/kano-burners/labels/development","name":"development","color":"fbca04"},{"url":"https://api.github.com/repos/KanoComputing/kano-burners/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/KanoComputing/kano-burners/labels/Med%20Prio","name":"Med Prio","color":"fffa04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-09T09:27:43Z","updated_at":"2015-09-09T10:16:37Z","closed_at":null,"body":"The project was changed to move away from `pySmartDL` and use `aria2` for downloading purposes.\r\n\r\nHowever, `pySmartDL` was not completely removed from the project and is creating additional python dependencies. (e.g. `concurrent` module, for which you would need to `pip install futures`) \r\n\r\n - [ ] Investigate current usage of `pySmartDL`\r\n - [ ] If `pySmartDL` is not being used for specifically downloading, remove it entirely\r\n - [ ] If `pySmartDL` is used for other operations (e.g. md5 checks), use lightweight alternatives (i.e. native python)\r\n - [ ] Update wiki pages to reflect changes"},"comment":{"url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/comments/138865412","html_url":"https://github.com/KanoComputing/kano-burners/issues/63#issuecomment-138865412","issue_url":"https://api.github.com/repos/KanoComputing/kano-burners/issues/63","id":138865412,"user":{"login":"radujipa","id":3577547,"avatar_url":"https://avatars.githubusercontent.com/u/3577547?v=3","gravatar_id":"","url":"https://api.github.com/users/radujipa","html_url":"https://github.com/radujipa","followers_url":"https://api.github.com/users/radujipa/followers","following_url":"https://api.github.com/users/radujipa/following{/other_user}","gists_url":"https://api.github.com/users/radujipa/gists{/gist_id}","starred_url":"https://api.github.com/users/radujipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radujipa/subscriptions","organizations_url":"https://api.github.com/users/radujipa/orgs","repos_url":"https://api.github.com/users/radujipa/repos","events_url":"https://api.github.com/users/radujipa/events{/privacy}","received_events_url":"https://api.github.com/users/radujipa/received_events","type":"User","site_admin":false},"created_at":"2015-09-09T10:16:37Z","updated_at":"2015-09-09T10:16:37Z","body":"At the moment, I believe there is an issue with the Linux version mainly because of `pyinstaller` since it doesn't seem to package `PyQt4`. This might need some further investigation as to whether this issue has been fixed, or perhaps the packaging process is different on Linux and has been wrong the whole time. I've opened another ticket https://github.com/KanoComputing/kano-burners/issues/64\r\n\r\n- Keeping `pySmartDL` for Linux creates additional nasty dependencies in OSX and Windows, and I would advise against it\r\n- It probably won't come as a surprise to the average Linux user to have to install a dependency for an app, so I like this alternative for the time being - in the future if we release the burners on `pip`, we could add `aria2` as a dependency\r\n\r\nI would also advise against dropping support for Linux, as the app works fine if run from source. For the tech savy, it may still prove a useful tool with the documentation in the wikis. We might even get external collaboration on it in that case."}}