{"action":"created","issue":{"url":"https://api.github.com/repos/ufz/ogs/issues/835","labels_url":"https://api.github.com/repos/ufz/ogs/issues/835/labels{/name}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/835/comments","events_url":"https://api.github.com/repos/ufz/ogs/issues/835/events","html_url":"https://github.com/ufz/ogs/pull/835","id":106959427,"number":835,"title":"Add a member to PETSc matrix for adding submatrix","user":{"login":"wenqing","id":1343839,"avatar_url":"https://avatars.githubusercontent.com/u/1343839?v=3","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-17T10:57:34Z","updated_at":"2015-09-18T07:16:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/835","html_url":"https://github.com/ufz/ogs/pull/835","diff_url":"https://github.com/ufz/ogs/pull/835.diff","patch_url":"https://github.com/ufz/ogs/pull/835.patch"},"body":"Add a member to PETSc matrix for adding submatrix with ghost entry checking.\r\nWith the change and the next two PRs, the ghost entry checking in PR #580 (https://github.com/ufz/ogs/pull/580/files#r39689719) under ifdef disappears.\r\n\r\nNext two PRs:\r\n1. In order to make consistency with the type of the submatrix argument in member ``add``,   the const modifier of the same argument of member ``add`` of other matrix classes will be removed. \r\n2. The const modifier of the same argument of member ``add`` of Vector classes will be removed too. \r\n"},"comment":{"url":"https://api.github.com/repos/ufz/ogs/issues/comments/141367740","html_url":"https://github.com/ufz/ogs/pull/835#issuecomment-141367740","issue_url":"https://api.github.com/repos/ufz/ogs/issues/835","id":141367740,"user":{"login":"chleh","id":10530151,"avatar_url":"https://avatars.githubusercontent.com/u/10530151?v=3","gravatar_id":"","url":"https://api.github.com/users/chleh","html_url":"https://github.com/chleh","followers_url":"https://api.github.com/users/chleh/followers","following_url":"https://api.github.com/users/chleh/following{/other_user}","gists_url":"https://api.github.com/users/chleh/gists{/gist_id}","starred_url":"https://api.github.com/users/chleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chleh/subscriptions","organizations_url":"https://api.github.com/users/chleh/orgs","repos_url":"https://api.github.com/users/chleh/repos","events_url":"https://api.github.com/users/chleh/events{/privacy}","received_events_url":"https://api.github.com/users/chleh/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T07:16:11Z","updated_at":"2015-09-18T07:16:11Z","body":"Concerning the announcement of your next two PRs:\r\nI am not very happy that te `add()` methods are about to change the matrix that is added to the global matrix. For example: When I call the `addToGlobal()` method of a local assembler I do not expect thet my locally assembled matrix might be changed while being added.\r\nSure, most of the time the locally assembled matrix will not be used anymore after being added to the global matrix. But if, e.g., I want to implement a Crank-Nicolson scheme, I also need the matrix from the previous timestep.\r\nI am not entirely sure whether this can be done entirely on the level of global matrices. Probably it can, then my concern is meaningless. But at least we should think about it. (Maybe you already have done so)"}}