{"action":"created","comment":{"url":"https://api.github.com/repos/vivianliang/downe.space/pulls/comments/46187468","id":46187468,"diff_hunk":"@@ -4,16 +4,97 @@ angular.module('downespace').directive 'filterEvents', ->\n   directive =\n     controller  : 'filterEventsController'\n     controllerAs: 'filterEvents'\n+    require     : '^eventList'\n     restrict    : 'E'\n     templateUrl : 'views/directives/filterevents.html'\n+    link        : (scope, element, attrs, eventList) ->\n+      scope.eventList = eventList","path":"appfiles/app/scripts/directives/filterevents.coffee","position":8,"original_position":8,"commit_id":"a627834c16025a0cec1aa0174945bfde7df55a5d","original_commit_id":"a627834c16025a0cec1aa0174945bfde7df55a5d","user":{"login":"mgeist","id":844637,"avatar_url":"https://avatars.githubusercontent.com/u/844637?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeist","html_url":"https://github.com/mgeist","followers_url":"https://api.github.com/users/mgeist/followers","following_url":"https://api.github.com/users/mgeist/following{/other_user}","gists_url":"https://api.github.com/users/mgeist/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeist/subscriptions","organizations_url":"https://api.github.com/users/mgeist/orgs","repos_url":"https://api.github.com/users/mgeist/repos","events_url":"https://api.github.com/users/mgeist/events{/privacy}","received_events_url":"https://api.github.com/users/mgeist/received_events","type":"User","site_admin":false},"body":"`scope.filterEvents.eventList = eventList`","created_at":"2015-11-30T19:10:02Z","updated_at":"2015-11-30T19:10:02Z","html_url":"https://github.com/vivianliang/downe.space/pull/27#discussion_r46187468","pull_request_url":"https://api.github.com/repos/vivianliang/downe.space/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/comments/46187468"},"html":{"href":"https://github.com/vivianliang/downe.space/pull/27#discussion_r46187468"},"pull_request":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/vivianliang/downe.space/pulls/27","id":52050451,"html_url":"https://github.com/vivianliang/downe.space/pull/27","diff_url":"https://github.com/vivianliang/downe.space/pull/27.diff","patch_url":"https://github.com/vivianliang/downe.space/pull/27.patch","issue_url":"https://api.github.com/repos/vivianliang/downe.space/issues/27","number":27,"state":"open","locked":false,"title":"[WIP] Add location filtering","user":{"login":"mgeist","id":844637,"avatar_url":"https://avatars.githubusercontent.com/u/844637?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeist","html_url":"https://github.com/mgeist","followers_url":"https://api.github.com/users/mgeist/followers","following_url":"https://api.github.com/users/mgeist/following{/other_user}","gists_url":"https://api.github.com/users/mgeist/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeist/subscriptions","organizations_url":"https://api.github.com/users/mgeist/orgs","repos_url":"https://api.github.com/users/mgeist/repos","events_url":"https://api.github.com/users/mgeist/events{/privacy}","received_events_url":"https://api.github.com/users/mgeist/received_events","type":"User","site_admin":false},"body":"This allows for filtering of events based\r\non location (in this case, lat/long coords).\r\nLat/long was chosen because address would require\r\nan extra API call that will eventually need\r\nto be done on the frontend anyway.\r\n\r\nTODO:\r\n- [ ] decouple logic between eventlist and filterevents directives in a sensible way\r\n- [ ] do we want to explicitly 'submit filters' or automatically load on change?\r\n- [ ] track if filters have been changed to properly reset pagination call\r\n- [x] frontend url params for filters\r\n- [ ] frontend unit tests","created_at":"2015-11-28T23:06:31Z","updated_at":"2015-11-30T19:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee1dcbe1fbbdb33b226a62a62d5bc0a2fcf509c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/vivianliang/downe.space/pulls/27/commits","review_comments_url":"https://api.github.com/repos/vivianliang/downe.space/pulls/27/comments","review_comment_url":"https://api.github.com/repos/vivianliang/downe.space/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vivianliang/downe.space/issues/27/comments","statuses_url":"https://api.github.com/repos/vivianliang/downe.space/statuses/a627834c16025a0cec1aa0174945bfde7df55a5d","head":{"label":"mgeist:filterLocation","ref":"filterLocation","sha":"a627834c16025a0cec1aa0174945bfde7df55a5d","user":{"login":"mgeist","id":844637,"avatar_url":"https://avatars.githubusercontent.com/u/844637?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeist","html_url":"https://github.com/mgeist","followers_url":"https://api.github.com/users/mgeist/followers","following_url":"https://api.github.com/users/mgeist/following{/other_user}","gists_url":"https://api.github.com/users/mgeist/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeist/subscriptions","organizations_url":"https://api.github.com/users/mgeist/orgs","repos_url":"https://api.github.com/users/mgeist/repos","events_url":"https://api.github.com/users/mgeist/events{/privacy}","received_events_url":"https://api.github.com/users/mgeist/received_events","type":"User","site_admin":false},"repo":{"id":45759938,"name":"downe.space","full_name":"mgeist/downe.space","owner":{"login":"mgeist","id":844637,"avatar_url":"https://avatars.githubusercontent.com/u/844637?v=3","gravatar_id":"","url":"https://api.github.com/users/mgeist","html_url":"https://github.com/mgeist","followers_url":"https://api.github.com/users/mgeist/followers","following_url":"https://api.github.com/users/mgeist/following{/other_user}","gists_url":"https://api.github.com/users/mgeist/gists{/gist_id}","starred_url":"https://api.github.com/users/mgeist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgeist/subscriptions","organizations_url":"https://api.github.com/users/mgeist/orgs","repos_url":"https://api.github.com/users/mgeist/repos","events_url":"https://api.github.com/users/mgeist/events{/privacy}","received_events_url":"https://api.github.com/users/mgeist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgeist/downe.space","description":"","fork":true,"url":"https://api.github.com/repos/mgeist/downe.space","forks_url":"https://api.github.com/repos/mgeist/downe.space/forks","keys_url":"https://api.github.com/repos/mgeist/downe.space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgeist/downe.space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgeist/downe.space/teams","hooks_url":"https://api.github.com/repos/mgeist/downe.space/hooks","issue_events_url":"https://api.github.com/repos/mgeist/downe.space/issues/events{/number}","events_url":"https://api.github.com/repos/mgeist/downe.space/events","assignees_url":"https://api.github.com/repos/mgeist/downe.space/assignees{/user}","branches_url":"https://api.github.com/repos/mgeist/downe.space/branches{/branch}","tags_url":"https://api.github.com/repos/mgeist/downe.space/tags","blobs_url":"https://api.github.com/repos/mgeist/downe.space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgeist/downe.space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgeist/downe.space/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgeist/downe.space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgeist/downe.space/statuses/{sha}","languages_url":"https://api.github.com/repos/mgeist/downe.space/languages","stargazers_url":"https://api.github.com/repos/mgeist/downe.space/stargazers","contributors_url":"https://api.github.com/repos/mgeist/downe.space/contributors","subscribers_url":"https://api.github.com/repos/mgeist/downe.space/subscribers","subscription_url":"https://api.github.com/repos/mgeist/downe.space/subscription","commits_url":"https://api.github.com/repos/mgeist/downe.space/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgeist/downe.space/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgeist/downe.space/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgeist/downe.space/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgeist/downe.space/contents/{+path}","compare_url":"https://api.github.com/repos/mgeist/downe.space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgeist/downe.space/merges","archive_url":"https://api.github.com/repos/mgeist/downe.space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgeist/downe.space/downloads","issues_url":"https://api.github.com/repos/mgeist/downe.space/issues{/number}","pulls_url":"https://api.github.com/repos/mgeist/downe.space/pulls{/number}","milestones_url":"https://api.github.com/repos/mgeist/downe.space/milestones{/number}","notifications_url":"https://api.github.com/repos/mgeist/downe.space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgeist/downe.space/labels{/name}","releases_url":"https://api.github.com/repos/mgeist/downe.space/releases{/id}","created_at":"2015-11-07T23:57:54Z","updated_at":"2015-11-07T23:57:55Z","pushed_at":"2015-11-30T03:26:36Z","git_url":"git://github.com/mgeist/downe.space.git","ssh_url":"git@github.com:mgeist/downe.space.git","clone_url":"https://github.com/mgeist/downe.space.git","svn_url":"https://github.com/mgeist/downe.space","homepage":null,"size":135,"stargazers_count":0,"watchers_count":0,"language":"ApacheConf","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vivianliang:master","ref":"master","sha":"da14ee088c486e451b9dd3109f275885cb42f88c","user":{"login":"vivianliang","id":4467143,"avatar_url":"https://avatars.githubusercontent.com/u/4467143?v=3","gravatar_id":"","url":"https://api.github.com/users/vivianliang","html_url":"https://github.com/vivianliang","followers_url":"https://api.github.com/users/vivianliang/followers","following_url":"https://api.github.com/users/vivianliang/following{/other_user}","gists_url":"https://api.github.com/users/vivianliang/gists{/gist_id}","starred_url":"https://api.github.com/users/vivianliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivianliang/subscriptions","organizations_url":"https://api.github.com/users/vivianliang/orgs","repos_url":"https://api.github.com/users/vivianliang/repos","events_url":"https://api.github.com/users/vivianliang/events{/privacy}","received_events_url":"https://api.github.com/users/vivianliang/received_events","type":"User","site_admin":false},"repo":{"id":41823479,"name":"downe.space","full_name":"vivianliang/downe.space","owner":{"login":"vivianliang","id":4467143,"avatar_url":"https://avatars.githubusercontent.com/u/4467143?v=3","gravatar_id":"","url":"https://api.github.com/users/vivianliang","html_url":"https://github.com/vivianliang","followers_url":"https://api.github.com/users/vivianliang/followers","following_url":"https://api.github.com/users/vivianliang/following{/other_user}","gists_url":"https://api.github.com/users/vivianliang/gists{/gist_id}","starred_url":"https://api.github.com/users/vivianliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivianliang/subscriptions","organizations_url":"https://api.github.com/users/vivianliang/orgs","repos_url":"https://api.github.com/users/vivianliang/repos","events_url":"https://api.github.com/users/vivianliang/events{/privacy}","received_events_url":"https://api.github.com/users/vivianliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vivianliang/downe.space","description":"","fork":false,"url":"https://api.github.com/repos/vivianliang/downe.space","forks_url":"https://api.github.com/repos/vivianliang/downe.space/forks","keys_url":"https://api.github.com/repos/vivianliang/downe.space/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vivianliang/downe.space/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vivianliang/downe.space/teams","hooks_url":"https://api.github.com/repos/vivianliang/downe.space/hooks","issue_events_url":"https://api.github.com/repos/vivianliang/downe.space/issues/events{/number}","events_url":"https://api.github.com/repos/vivianliang/downe.space/events","assignees_url":"https://api.github.com/repos/vivianliang/downe.space/assignees{/user}","branches_url":"https://api.github.com/repos/vivianliang/downe.space/branches{/branch}","tags_url":"https://api.github.com/repos/vivianliang/downe.space/tags","blobs_url":"https://api.github.com/repos/vivianliang/downe.space/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vivianliang/downe.space/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vivianliang/downe.space/git/refs{/sha}","trees_url":"https://api.github.com/repos/vivianliang/downe.space/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vivianliang/downe.space/statuses/{sha}","languages_url":"https://api.github.com/repos/vivianliang/downe.space/languages","stargazers_url":"https://api.github.com/repos/vivianliang/downe.space/stargazers","contributors_url":"https://api.github.com/repos/vivianliang/downe.space/contributors","subscribers_url":"https://api.github.com/repos/vivianliang/downe.space/subscribers","subscription_url":"https://api.github.com/repos/vivianliang/downe.space/subscription","commits_url":"https://api.github.com/repos/vivianliang/downe.space/commits{/sha}","git_commits_url":"https://api.github.com/repos/vivianliang/downe.space/git/commits{/sha}","comments_url":"https://api.github.com/repos/vivianliang/downe.space/comments{/number}","issue_comment_url":"https://api.github.com/repos/vivianliang/downe.space/issues/comments{/number}","contents_url":"https://api.github.com/repos/vivianliang/downe.space/contents/{+path}","compare_url":"https://api.github.com/repos/vivianliang/downe.space/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vivianliang/downe.space/merges","archive_url":"https://api.github.com/repos/vivianliang/downe.space/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vivianliang/downe.space/downloads","issues_url":"https://api.github.com/repos/vivianliang/downe.space/issues{/number}","pulls_url":"https://api.github.com/repos/vivianliang/downe.space/pulls{/number}","milestones_url":"https://api.github.com/repos/vivianliang/downe.space/milestones{/number}","notifications_url":"https://api.github.com/repos/vivianliang/downe.space/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vivianliang/downe.space/labels{/name}","releases_url":"https://api.github.com/repos/vivianliang/downe.space/releases{/id}","created_at":"2015-09-02T19:34:53Z","updated_at":"2015-11-01T00:00:31Z","pushed_at":"2015-11-30T03:44:27Z","git_url":"git://github.com/vivianliang/downe.space.git","ssh_url":"git@github.com:vivianliang/downe.space.git","clone_url":"https://github.com/vivianliang/downe.space.git","svn_url":"https://github.com/vivianliang/downe.space","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"ApacheConf","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/27"},"html":{"href":"https://github.com/vivianliang/downe.space/pull/27"},"issue":{"href":"https://api.github.com/repos/vivianliang/downe.space/issues/27"},"comments":{"href":"https://api.github.com/repos/vivianliang/downe.space/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vivianliang/downe.space/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/vivianliang/downe.space/statuses/a627834c16025a0cec1aa0174945bfde7df55a5d"}}}}