{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/24306883","id":24306883,"diff_hunk":"@@ -167,6 +167,13 @@\n     custom_title->setText(m_pConfig->getValueString(\n         ConfigKey(SHOUTCAST_PREF_KEY,\"custom_title\")));\n \n+    //Metadata format\n+    tmp_string = m_pConfig->getValueString(\n+        ConfigKey(SHOUTCAST_PREF_KEY,\"metadata_format\"));\n+    if (tmp_string.isEmpty())\n+        tmp_string = tr(\"$artist - $title\");","path":"src/dlgprefshoutcast.cpp","position":8,"original_position":8,"commit_id":"3b2fb57678e8dc689de1770e85a5fca1a6b3cc03","original_commit_id":"3b2fb57678e8dc689de1770e85a5fca1a6b3cc03","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"Whoops, no it does not. I don't think we should translate these either.","created_at":"2015-02-09T02:48:18Z","updated_at":"2015-02-09T02:48:18Z","html_url":"https://github.com/mixxxdj/mixxx/pull/166#discussion_r24306883","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/24306883"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/166#discussion_r24306883"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166","id":11880040,"html_url":"https://github.com/mixxxdj/mixxx/pull/166","diff_url":"https://github.com/mixxxdj/mixxx/pull/166.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/166.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/166","number":166,"state":"closed","locked":false,"title":"Added custom format for shout metadata","user":{"login":"darkelink","id":1815269,"avatar_url":"https://avatars.githubusercontent.com/u/1815269?v=3","gravatar_id":"","url":"https://api.github.com/users/darkelink","html_url":"https://github.com/darkelink","followers_url":"https://api.github.com/users/darkelink/followers","following_url":"https://api.github.com/users/darkelink/following{/other_user}","gists_url":"https://api.github.com/users/darkelink/gists{/gist_id}","starred_url":"https://api.github.com/users/darkelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkelink/subscriptions","organizations_url":"https://api.github.com/users/darkelink/orgs","repos_url":"https://api.github.com/users/darkelink/repos","events_url":"https://api.github.com/users/darkelink/events{/privacy}","received_events_url":"https://api.github.com/users/darkelink/received_events","type":"User","site_admin":false},"body":"This patch allows people to set custom metatdata formats for the shoutcast title field. Previously only 'artist - title' was allowed.\r\n\r\nThis patch makes the custom metatdata fields a bit redundant, but they have not been touched in case of specific use cases that I am not aware of.\r\n\r\nTested with shoutcast and Icecast 2.","created_at":"2014-01-26T04:55:06Z","updated_at":"2015-02-09T02:48:18Z","closed_at":"2014-02-19T19:52:17Z","merged_at":"2014-02-19T19:52:17Z","merge_commit_sha":"c02548bae853c0ac3f9a8b634a4bc062e000943f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/166/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/3b2fb57678e8dc689de1770e85a5fca1a6b3cc03","head":{"label":"darkelink:master","ref":"master","sha":"3b2fb57678e8dc689de1770e85a5fca1a6b3cc03","user":{"login":"darkelink","id":1815269,"avatar_url":"https://avatars.githubusercontent.com/u/1815269?v=3","gravatar_id":"","url":"https://api.github.com/users/darkelink","html_url":"https://github.com/darkelink","followers_url":"https://api.github.com/users/darkelink/followers","following_url":"https://api.github.com/users/darkelink/following{/other_user}","gists_url":"https://api.github.com/users/darkelink/gists{/gist_id}","starred_url":"https://api.github.com/users/darkelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkelink/subscriptions","organizations_url":"https://api.github.com/users/darkelink/orgs","repos_url":"https://api.github.com/users/darkelink/repos","events_url":"https://api.github.com/users/darkelink/events{/privacy}","received_events_url":"https://api.github.com/users/darkelink/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"mixxxdj:master","ref":"master","sha":"0d72011c50e69bddd99e012736ad217c82bdb28a","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/{number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","created_at":"2013-05-17T15:14:38Z","updated_at":"2015-02-09T01:03:46Z","pushed_at":"2015-02-09T01:03:46Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":312307,"stargazers_count":234,"watchers_count":234,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":36,"forks":190,"open_issues":36,"watchers":234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/166"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/166"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/3b2fb57678e8dc689de1770e85a5fca1a6b3cc03"}}}}