{"action":"created","issue":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/833","labels_url":"https://api.github.com/repos/dc-js/dc.js/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/dc-js/dc.js/issues/833/comments","events_url":"https://api.github.com/repos/dc-js/dc.js/issues/833/events","html_url":"https://github.com/dc-js/dc.js/pull/833","id":54147179,"number":833,"title":"Fixes Bug 776 - Provide API to remove renderlets","user":{"login":"mtraynham","id":5741321,"avatar_url":"https://avatars.githubusercontent.com/u/5741321?v=3","gravatar_id":"","url":"https://api.github.com/users/mtraynham","html_url":"https://github.com/mtraynham","followers_url":"https://api.github.com/users/mtraynham/followers","following_url":"https://api.github.com/users/mtraynham/following{/other_user}","gists_url":"https://api.github.com/users/mtraynham/gists{/gist_id}","starred_url":"https://api.github.com/users/mtraynham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtraynham/subscriptions","organizations_url":"https://api.github.com/users/mtraynham/orgs","repos_url":"https://api.github.com/users/mtraynham/repos","events_url":"https://api.github.com/users/mtraynham/events{/privacy}","received_events_url":"https://api.github.com/users/mtraynham/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/dc-js/dc.js/milestones/13","labels_url":"https://api.github.com/repos/dc-js/dc.js/milestones/13/labels","id":416264,"number":13,"title":"v2.0","description":"","creator":{"login":"jrideout","id":197338,"avatar_url":"https://avatars.githubusercontent.com/u/197338?v=3","gravatar_id":"","url":"https://api.github.com/users/jrideout","html_url":"https://github.com/jrideout","followers_url":"https://api.github.com/users/jrideout/followers","following_url":"https://api.github.com/users/jrideout/following{/other_user}","gists_url":"https://api.github.com/users/jrideout/gists{/gist_id}","starred_url":"https://api.github.com/users/jrideout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrideout/subscriptions","organizations_url":"https://api.github.com/users/jrideout/orgs","repos_url":"https://api.github.com/users/jrideout/repos","events_url":"https://api.github.com/users/jrideout/events{/privacy}","received_events_url":"https://api.github.com/users/jrideout/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":182,"state":"open","created_at":"2013-08-31T17:39:57Z","updated_at":"2015-01-18T02:13:03Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-01-13T03:34:21Z","updated_at":"2015-01-18T07:08:20Z","closed_at":"2015-01-18T01:38:22Z","pull_request":{"url":"https://api.github.com/repos/dc-js/dc.js/pulls/833","html_url":"https://github.com/dc-js/dc.js/pull/833","diff_url":"https://github.com/dc-js/dc.js/pull/833.diff","patch_url":"https://github.com/dc-js/dc.js/pull/833.patch"},"body":"Fixes Bug #776 \r\n\r\nThis change adds the following methods:\r\n- .addRenderlet\r\n- .removeRenderlet\r\n- .renderlets\r\n\r\nThis deprecates:\r\n- .renderlet (in favor of .addRenderlet, which it calls behind the scenes using `dc.utils.uniqueId` as the renderlet key)\r\n\r\nIf you are opposed, I'm fine with removing the `.renderlets` getter function.  I just thought it might be useful to trigger the renderlets at a time other than `render` and `redraw`, or specifically call a single renderlet.\r\n\r\n**Edit** Oop didn't see the other pull request #779 open :P  I would still say we need to keep backwards compatability for `.renderlet` and this uses `d3.dispatch` as @gordonwoodhull had suggested."},"comment":{"url":"https://api.github.com/repos/dc-js/dc.js/issues/comments/70398855","html_url":"https://github.com/dc-js/dc.js/pull/833#issuecomment-70398855","issue_url":"https://api.github.com/repos/dc-js/dc.js/issues/833","id":70398855,"user":{"login":"gordonwoodhull","id":1366709,"avatar_url":"https://avatars.githubusercontent.com/u/1366709?v=3","gravatar_id":"","url":"https://api.github.com/users/gordonwoodhull","html_url":"https://github.com/gordonwoodhull","followers_url":"https://api.github.com/users/gordonwoodhull/followers","following_url":"https://api.github.com/users/gordonwoodhull/following{/other_user}","gists_url":"https://api.github.com/users/gordonwoodhull/gists{/gist_id}","starred_url":"https://api.github.com/users/gordonwoodhull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordonwoodhull/subscriptions","organizations_url":"https://api.github.com/users/gordonwoodhull/orgs","repos_url":"https://api.github.com/users/gordonwoodhull/repos","events_url":"https://api.github.com/users/gordonwoodhull/events{/privacy}","received_events_url":"https://api.github.com/users/gordonwoodhull/received_events","type":"User","site_admin":false},"created_at":"2015-01-18T07:08:19Z","updated_at":"2015-01-18T07:08:19Z","body":"Looking at it more closely, renderlets don't offer anything you can't get from postRender or postRedraw. I think they only exist because those didn't used to use `d3.dispatch` either, so you couldn't add more than one."}}