{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/46247401","id":46247401,"diff_hunk":"@@ -202,6 +224,34 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.stackedMap'])\n           var modal = $modalStack.getTop();\n           if (modal) {\n             $modalStack.modalRendered(modal.key);\n+\n+            // get topmost modal object\n+            var bodyIsOverflowing;\n+            var modalIsOverflowing;\n+            \n+            // only when modal is attached to body\n+            if(modal.value.appendTo === 'body'){\n+              \n+              // check bodyOverflowing property that was set when opening modal\n+              if(modal.value.modalDomEl.bodyOverflowing){\n+                bodyIsOverflowing = true;\n+              }\n+\n+              // start - from adjustDialog method of modal.js of bootstrap\n+              // check if modal is overflowing\n+              modalIsOverflowing = element[0].scrollHeight > document.documentElement.clientHeight;","path":"src/modal/modal.js","position":53,"original_position":53,"commit_id":"b9e89e403904d92e08e286393df37444b1ddb2d2","original_commit_id":"b9e89e403904d92e08e286393df37444b1ddb2d2","user":{"login":"wesleycho","id":1703387,"avatar_url":"https://avatars.githubusercontent.com/u/1703387?v=3","gravatar_id":"","url":"https://api.github.com/users/wesleycho","html_url":"https://github.com/wesleycho","followers_url":"https://api.github.com/users/wesleycho/followers","following_url":"https://api.github.com/users/wesleycho/following{/other_user}","gists_url":"https://api.github.com/users/wesleycho/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleycho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleycho/subscriptions","organizations_url":"https://api.github.com/users/wesleycho/orgs","repos_url":"https://api.github.com/users/wesleycho/repos","events_url":"https://api.github.com/users/wesleycho/events{/privacy}","received_events_url":"https://api.github.com/users/wesleycho/received_events","type":"User","site_admin":false},"body":"Should use `$document[0].clientHeight`","created_at":"2015-12-01T07:36:29Z","updated_at":"2015-12-01T07:36:29Z","html_url":"https://github.com/angular-ui/bootstrap/pull/4782#discussion_r46247401","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/46247401"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/4782#discussion_r46247401"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782","id":49200645,"html_url":"https://github.com/angular-ui/bootstrap/pull/4782","diff_url":"https://github.com/angular-ui/bootstrap/pull/4782.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/4782.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4782","number":4782,"state":"open","locked":false,"title":"fix(modal): prevent body content shifting when vertical scrollbar","user":{"login":"kunal999","id":1834188,"avatar_url":"https://avatars.githubusercontent.com/u/1834188?v=3","gravatar_id":"","url":"https://api.github.com/users/kunal999","html_url":"https://github.com/kunal999","followers_url":"https://api.github.com/users/kunal999/followers","following_url":"https://api.github.com/users/kunal999/following{/other_user}","gists_url":"https://api.github.com/users/kunal999/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal999/subscriptions","organizations_url":"https://api.github.com/users/kunal999/orgs","repos_url":"https://api.github.com/users/kunal999/repos","events_url":"https://api.github.com/users/kunal999/events{/privacy}","received_events_url":"https://api.github.com/users/kunal999/received_events","type":"User","site_admin":false},"body":"Prevents page body content shifting to the right when modal is open (when appendTo is 'body')\r\n\r\nCloses #3714","created_at":"2015-10-29T21:12:14Z","updated_at":"2015-12-01T07:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b25880f30048bcdbcf774010436ede9be757a48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/4782/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/b9e89e403904d92e08e286393df37444b1ddb2d2","head":{"label":"kunal999:master","ref":"master","sha":"b9e89e403904d92e08e286393df37444b1ddb2d2","user":{"login":"kunal999","id":1834188,"avatar_url":"https://avatars.githubusercontent.com/u/1834188?v=3","gravatar_id":"","url":"https://api.github.com/users/kunal999","html_url":"https://github.com/kunal999","followers_url":"https://api.github.com/users/kunal999/followers","following_url":"https://api.github.com/users/kunal999/following{/other_user}","gists_url":"https://api.github.com/users/kunal999/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal999/subscriptions","organizations_url":"https://api.github.com/users/kunal999/orgs","repos_url":"https://api.github.com/users/kunal999/repos","events_url":"https://api.github.com/users/kunal999/events{/privacy}","received_events_url":"https://api.github.com/users/kunal999/received_events","type":"User","site_admin":false},"repo":{"id":45146744,"name":"bootstrap","full_name":"kunal999/bootstrap","owner":{"login":"kunal999","id":1834188,"avatar_url":"https://avatars.githubusercontent.com/u/1834188?v=3","gravatar_id":"","url":"https://api.github.com/users/kunal999","html_url":"https://github.com/kunal999","followers_url":"https://api.github.com/users/kunal999/followers","following_url":"https://api.github.com/users/kunal999/following{/other_user}","gists_url":"https://api.github.com/users/kunal999/gists{/gist_id}","starred_url":"https://api.github.com/users/kunal999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunal999/subscriptions","organizations_url":"https://api.github.com/users/kunal999/orgs","repos_url":"https://api.github.com/users/kunal999/repos","events_url":"https://api.github.com/users/kunal999/events{/privacy}","received_events_url":"https://api.github.com/users/kunal999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kunal999/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":true,"url":"https://api.github.com/repos/kunal999/bootstrap","forks_url":"https://api.github.com/repos/kunal999/bootstrap/forks","keys_url":"https://api.github.com/repos/kunal999/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kunal999/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kunal999/bootstrap/teams","hooks_url":"https://api.github.com/repos/kunal999/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/kunal999/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/kunal999/bootstrap/events","assignees_url":"https://api.github.com/repos/kunal999/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/kunal999/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/kunal999/bootstrap/tags","blobs_url":"https://api.github.com/repos/kunal999/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kunal999/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kunal999/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/kunal999/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kunal999/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/kunal999/bootstrap/languages","stargazers_url":"https://api.github.com/repos/kunal999/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/kunal999/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/kunal999/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/kunal999/bootstrap/subscription","commits_url":"https://api.github.com/repos/kunal999/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/kunal999/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/kunal999/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/kunal999/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/kunal999/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/kunal999/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kunal999/bootstrap/merges","archive_url":"https://api.github.com/repos/kunal999/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kunal999/bootstrap/downloads","issues_url":"https://api.github.com/repos/kunal999/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/kunal999/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/kunal999/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/kunal999/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kunal999/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/kunal999/bootstrap/releases{/id}","created_at":"2015-10-28T22:54:48Z","updated_at":"2015-10-28T22:54:50Z","pushed_at":"2015-10-30T20:26:55Z","git_url":"git://github.com/kunal999/bootstrap.git","ssh_url":"git@github.com:kunal999/bootstrap.git","clone_url":"https://github.com/kunal999/bootstrap.git","svn_url":"https://github.com/kunal999/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":7186,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"d859f42cc022a5d8779f1c7b358486bbdd04ed57","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-12-01T06:18:20Z","pushed_at":"2015-12-01T06:55:57Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":13683,"stargazers_count":10897,"watchers_count":10897,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5644,"mirror_url":null,"open_issues_count":106,"forks":5644,"open_issues":106,"watchers":10897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/4782"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/4782"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/4782/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/4782/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/b9e89e403904d92e08e286393df37444b1ddb2d2"}}}}