{"action":"created","issue":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/14","labels_url":"https://api.github.com/repos/kamailio/kamailio/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/kamailio/kamailio/issues/14/comments","events_url":"https://api.github.com/repos/kamailio/kamailio/issues/14/events","html_url":"https://github.com/kamailio/kamailio/pull/14","id":52819753,"number":14,"title":"Improve for correct working with all RADIUS AV pairs","user":{"login":"borikinternet","id":10058596,"avatar_url":"https://avatars.githubusercontent.com/u/10058596?v=3","gravatar_id":"","url":"https://api.github.com/users/borikinternet","html_url":"https://github.com/borikinternet","followers_url":"https://api.github.com/users/borikinternet/followers","following_url":"https://api.github.com/users/borikinternet/following{/other_user}","gists_url":"https://api.github.com/users/borikinternet/gists{/gist_id}","starred_url":"https://api.github.com/users/borikinternet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borikinternet/subscriptions","organizations_url":"https://api.github.com/users/borikinternet/orgs","repos_url":"https://api.github.com/users/borikinternet/repos","events_url":"https://api.github.com/users/borikinternet/events{/privacy}","received_events_url":"https://api.github.com/users/borikinternet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2014-12-24T13:44:45Z","updated_at":"2015-01-02T15:37:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kamailio/kamailio/pulls/14","html_url":"https://github.com/kamailio/kamailio/pull/14","diff_url":"https://github.com/kamailio/kamailio/pull/14.diff","patch_url":"https://github.com/kamailio/kamailio/pull/14.patch"},"body":"In this pull request I`d correct work with retrieved from RADIUS AV pairs for modules auth_radius, misc_radius and peering. Now this modules correctly put to $avp() all retrieved params:\r\n- integer name and integer value\r\n- integer name and string value\r\n- string name and integer value\r\n- string name and string value\r\n\r\nAll above said and for SIP-AVP params too."},"comment":{"url":"https://api.github.com/repos/kamailio/kamailio/issues/comments/68535016","html_url":"https://github.com/kamailio/kamailio/pull/14#issuecomment-68535016","issue_url":"https://api.github.com/repos/kamailio/kamailio/issues/14","id":68535016,"user":{"login":"borikinternet","id":10058596,"avatar_url":"https://avatars.githubusercontent.com/u/10058596?v=3","gravatar_id":"","url":"https://api.github.com/users/borikinternet","html_url":"https://github.com/borikinternet","followers_url":"https://api.github.com/users/borikinternet/followers","following_url":"https://api.github.com/users/borikinternet/following{/other_user}","gists_url":"https://api.github.com/users/borikinternet/gists{/gist_id}","starred_url":"https://api.github.com/users/borikinternet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borikinternet/subscriptions","organizations_url":"https://api.github.com/users/borikinternet/orgs","repos_url":"https://api.github.com/users/borikinternet/repos","events_url":"https://api.github.com/users/borikinternet/events{/privacy}","received_events_url":"https://api.github.com/users/borikinternet/received_events","type":"User","site_admin":false},"created_at":"2015-01-02T15:37:57Z","updated_at":"2015-01-02T15:37:57Z","body":"Thanks, your recomendations are implemented in new commits. Realy, I think, that free() is called in function, that destroys avp, but when I inspect usr_avp, I understood that I done a mistake. Similary, I added correct processing of malloc() errors, malloc() and free() was replaced to pkg_malloc() and pkg_free() respectively. I look at SIP-AVP processing and found one mistake (for '#' in string value case, I`m not considered this option), and this corrected too in new commits. In my oppinion, not using memory allocation in this section will be very traumatic for kamailio, because we don`t know, in which place in memory we place our string values.\r\n\r\nDiscussion question: some vendors (as Cisco) put name in value too. Cisco placed '=' between name part of value and value part of value. Some other vendors may put some other symbols. In my code I checking '=',':' and '#' by analogy with SIP-AVP pair syntax. Whether it is necessary or not?"}}