{"action":"created","comment":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/22694143","id":22694143,"diff_hunk":"@@ -39,6 +39,10 @@ def update\n     rescue\n       flash[:caution] = ts(\"Please select something first\")\n     end\n-    redirect_to user_inbox_path(@user, :filters => params[:filters])\n+    success_message = ts('Inbox successfully updated.')\n+    respond_to do |format|\n+      format.html { redirect_to request.referer || user_inbox_path(@user, filters: params[:filters]), notice: success_message }","path":"app/controllers/inbox_controller.rb","position":16,"original_position":16,"commit_id":"7652ec2cca7b994f3a07db369d5175bddd903b9c","original_commit_id":"7652ec2cca7b994f3a07db369d5175bddd903b9c","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [127/80]","created_at":"2015-01-09T00:19:49Z","updated_at":"2015-01-09T00:19:49Z","html_url":"https://github.com/otwcode/otwarchive/pull/1962#discussion_r22694143","pull_request_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962","_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/22694143"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/1962#discussion_r22694143"},"pull_request":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962"}}},"pull_request":{"url":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962","id":26629682,"html_url":"https://github.com/otwcode/otwarchive/pull/1962","diff_url":"https://github.com/otwcode/otwarchive/pull/1962.diff","patch_url":"https://github.com/otwcode/otwarchive/pull/1962.patch","issue_url":"https://api.github.com/repos/otwcode/otwarchive/issues/1962","number":1962,"state":"open","locked":false,"title":"4209 Homepage redesign","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"body":"https://code.google.com/p/otwarchive/issues/detail?id=4209\r\n\r\n**Logged out users (and admins) should get...**\r\n1. An introduction to the Archive\r\n2. Information about joining, along with a link to get an invitation or create an account when possible\r\n3. Links to the fandom/media categories (TV Shows, Movies, etc) so they can start browsing\r\n4. Links to the 3 most recent news posts along with when they were posted, how many comments they have, and preview text\r\n5. Twitter widget\r\n\r\n**Logged in users should get...**\r\n1. Links to the fandom/media categories (TV Shows, Movies, etc) so they can start browsing\r\n2. Links to the 3 most recent news posts along with when they were posted, how many comments they have, and preview text\r\n3. Up to 3 random (or pseudo-random) works they have marked for later, if they have them, along with the option to remove the works from their history\r\n4. Up to 3 unread inbox items, if they have them, along with options to reply/delete/mark read\r\n5. Twitter widget\r\n\r\n**Logged in users should also get...**\r\n1. The ability replace the links to the fandom/media categories with a list of canonical Favorite Tags, which can be added/removed using the Favorite/Unfavorite Tag button on a tag's works listing (e.g. http://test.ao3.org/tags/Testing/works)\r\n\r\n**This fixes some other issues in the process, yay!**\r\n* 4063 Users get redirected to the first page of their Inbox when deleting items https://code.google.com/p/otwarchive/issues/detail?id=4063\r\n  * This is fixed by the addition of `request.referrer` on [line 44 of the inbox controller](https://github.com/otwcode/otwarchive/pull/1962/files#diff-9ecf81897117f3a0c15ee6598b5e1830R44)\r\n* 4009 Users cannot delete items from their History when JavaScript is disabled https://code.google.com/p/otwarchive/issues/detail?id=4009\r\n  * This is fixed by removing the deletion confirmation from [line 47 of the reading blurb](https://github.com/otwcode/otwarchive/pull/1962/files#diff-659a009d345162aed7d04c3f01f09519L47) in order to allow for AJAX deletion of History items. The other solution to this problem would be to require the user to click through a second page confirming that they wanted to delete the History item. Requiring confirmation to remove an item from your History is the definition of overkill, since no significant data (i.e. the work itself) is deleted, and users frequently complain that it's too hard or slow to delete multiple items... and no one *reads* our confirmation messages anyway, as evidenced by how many users accidentally delete works. So it is my firm belief that this is the better solution. And I would also argue that there is precedent: we do not ask for confirmation when deleting comments from your inbox because, again, no significant data (i.e. the comment itself) is deleted.\r\n* 2439 Users get redirected to the first page of their History when deleting items https://code.google.com/p/otwarchive/issues/detail?id=2439\r\n  * This is fixed by the addition of `request.referrer` on [line 27 of the readings controller] (https://github.com/otwcode/otwarchive/pull/1962/files#diff-55294bffa60d88eb6746de712771142aR27) for success and on [line 34 of the readings controller](https://github.com/otwcode/otwarchive/pull/1962/files#diff-55294bffa60d88eb6746de712771142aR34) for failure\r\n\r\n**We'll also need to make these skin changes to Reversi through the admin interface**\r\nHeadings and faux-bullets to blue:\r\n```\r\n#header #greeting img,\r\n#header .heading a,\r\n#header .heading a:visited,\r\n#header .user a:hover,\r\n#header .user a:focus,\r\n#header .user .current,\r\n#header fieldset,\r\n#header form,\r\n#header p,\r\n#dashboard a:hover,\r\n.actions a:hover,\r\n.actions input:hover,\r\n.delete a,\r\nspan.delete,\r\nspan.unread,\r\n.replied,\r\nspan.claimed,\r\n.draggable,\r\n.droppable,\r\nspan.requested,\r\na.work,\r\n.blurb h4 a:link,\r\n.blurb h4 img,\r\n- .system .latest h3,\r\n- .system div.news h3,\r\n- .system .tweets h3,\r\n+ .splash .module h3,\r\n+ .splash .browse li a:before,\r\n.required,\r\n.error,\r\n.comment_error,\r\na.cloud7,\r\na.cloud8,\r\n#footer .actions .secondary a {\r\n  color: #5998D6;\r\n}\r\n```\r\nFavorite tag backgrounds to blue on hover:\r\n```\r\n#footer a:hover,\r\n#footer a:focus,\r\n.autocomplete .dropdown ul li:hover,\r\nli.selected,\r\na.tag:hover,\r\n.listbox .heading a.tag:visited:hover,\r\n.symbol .question,\r\n.qtip-content,\r\n+ .splash .favorite li:nth-of-type(odd) a:hover,\r\n+ .splash .favorite li:nth-of-type(odd) a:focus {\r\n  background: #5998D6;\r\n  color: #111;\r\n}\r\n```\r\nOdd favorite tag backgrounds to dark:\r\n```\r\n#header .dropdown .menu a:hover,\r\n#header .dropdown .menu a:focus,\r\n- .system .tweet_list li:nth-child(even),\r\n+ .splash .favorite li:nth-of-type(odd) a {\r\n  background: #111;\r\n}\r\n```\r\nNews post border color darker:\r\n```\r\n#header ul.primary,\r\n#footer,\r\n#dashboard ul,\r\ndl.meta,\r\n.group.listbox,\r\nfieldset fieldset.listbox,\r\n#main li.blurb,\r\nform blockquote.userstuff,\r\ndiv.comment,\r\nli.comment,\r\n.toggled form,\r\nform dl dt,\r\n#inner .module .heading,\r\n.bookmark .status span,\r\n+ .splash .news li {\r\n  border-color: #555;\r\n}\r\n```\r\nDynamic reply form to dark, which is also Issue 3708 https://code.google.com/p/otwarchive/issues/detail?id=3708\r\n```\r\nbody,\r\n.group,\r\n.group .group,\r\n.region,\r\n.flash,\r\nfieldset,\r\nfieldset fieldset ul,\r\nform dl,\r\ntextarea,\r\n#main .verbose legend,\r\n.verbose fieldset,\r\n.notice,\r\nul.notes,\r\ninput,\r\ntextarea,\r\ntable,\r\nth,\r\ntd:hover,\r\ntr:hover,\r\n.symbol .question:hover,\r\n#modal,\r\n.ui-sortable li,\r\n.required .autocomplete,\r\n.autocomplete .notice,\r\n.system .intro,\r\n.comment_error,\r\n+ div.dynamic,\r\n+ .dynamic form {\r\n  background: #333;\r\n  color: #eee;\r\n  border-color: #222;\r\n  outline: #111;\r\n  box-shadow: none;\r\n}\r\n```","created_at":"2014-12-29T01:02:02Z","updated_at":"2015-01-09T00:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf3d0736291436cb7a79074c95389ce5e39167f5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962/commits","review_comments_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962/comments","review_comment_url":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/{number}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/issues/1962/comments","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/7652ec2cca7b994f3a07db369d5175bddd903b9c","head":{"label":"sarken:issue_homepage_v2","ref":"issue_homepage_v2","sha":"7652ec2cca7b994f3a07db369d5175bddd903b9c","user":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"repo":{"id":2028681,"name":"otwarchive","full_name":"sarken/otwarchive","owner":{"login":"sarken","id":907055,"avatar_url":"https://avatars.githubusercontent.com/u/907055?v=3","gravatar_id":"","url":"https://api.github.com/users/sarken","html_url":"https://github.com/sarken","followers_url":"https://api.github.com/users/sarken/followers","following_url":"https://api.github.com/users/sarken/following{/other_user}","gists_url":"https://api.github.com/users/sarken/gists{/gist_id}","starred_url":"https://api.github.com/users/sarken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarken/subscriptions","organizations_url":"https://api.github.com/users/sarken/orgs","repos_url":"https://api.github.com/users/sarken/repos","events_url":"https://api.github.com/users/sarken/events{/privacy}","received_events_url":"https://api.github.com/users/sarken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarken/otwarchive","description":"The Organization for Transformative Works - Archive Project","fork":true,"url":"https://api.github.com/repos/sarken/otwarchive","forks_url":"https://api.github.com/repos/sarken/otwarchive/forks","keys_url":"https://api.github.com/repos/sarken/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarken/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarken/otwarchive/teams","hooks_url":"https://api.github.com/repos/sarken/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/sarken/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/sarken/otwarchive/events","assignees_url":"https://api.github.com/repos/sarken/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/sarken/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/sarken/otwarchive/tags","blobs_url":"https://api.github.com/repos/sarken/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarken/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarken/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarken/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarken/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/sarken/otwarchive/languages","stargazers_url":"https://api.github.com/repos/sarken/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/sarken/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/sarken/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/sarken/otwarchive/subscription","commits_url":"https://api.github.com/repos/sarken/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarken/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarken/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarken/otwarchive/issues/comments/{number}","contents_url":"https://api.github.com/repos/sarken/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/sarken/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarken/otwarchive/merges","archive_url":"https://api.github.com/repos/sarken/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarken/otwarchive/downloads","issues_url":"https://api.github.com/repos/sarken/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/sarken/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/sarken/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/sarken/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarken/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/sarken/otwarchive/releases{/id}","created_at":"2011-07-11T05:42:20Z","updated_at":"2015-01-08T08:35:40Z","pushed_at":"2015-01-09T00:19:38Z","git_url":"git://github.com/sarken/otwarchive.git","ssh_url":"git@github.com:sarken/otwarchive.git","clone_url":"https://github.com/sarken/otwarchive.git","svn_url":"https://github.com/sarken/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":50442,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"otwcode:master","ref":"master","sha":"c58edf86b78d52e3198201bfe3aa717d77196c82","user":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"repo":{"id":1338040,"name":"otwarchive","full_name":"otwcode/otwarchive","owner":{"login":"otwcode","id":408606,"avatar_url":"https://avatars.githubusercontent.com/u/408606?v=3","gravatar_id":"","url":"https://api.github.com/users/otwcode","html_url":"https://github.com/otwcode","followers_url":"https://api.github.com/users/otwcode/followers","following_url":"https://api.github.com/users/otwcode/following{/other_user}","gists_url":"https://api.github.com/users/otwcode/gists{/gist_id}","starred_url":"https://api.github.com/users/otwcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otwcode/subscriptions","organizations_url":"https://api.github.com/users/otwcode/orgs","repos_url":"https://api.github.com/users/otwcode/repos","events_url":"https://api.github.com/users/otwcode/events{/privacy}","received_events_url":"https://api.github.com/users/otwcode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otwcode/otwarchive","description":"The Organization for Transformative Works (OTW) - Archive Of Our Own (AO3) Project","fork":false,"url":"https://api.github.com/repos/otwcode/otwarchive","forks_url":"https://api.github.com/repos/otwcode/otwarchive/forks","keys_url":"https://api.github.com/repos/otwcode/otwarchive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otwcode/otwarchive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otwcode/otwarchive/teams","hooks_url":"https://api.github.com/repos/otwcode/otwarchive/hooks","issue_events_url":"https://api.github.com/repos/otwcode/otwarchive/issues/events{/number}","events_url":"https://api.github.com/repos/otwcode/otwarchive/events","assignees_url":"https://api.github.com/repos/otwcode/otwarchive/assignees{/user}","branches_url":"https://api.github.com/repos/otwcode/otwarchive/branches{/branch}","tags_url":"https://api.github.com/repos/otwcode/otwarchive/tags","blobs_url":"https://api.github.com/repos/otwcode/otwarchive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otwcode/otwarchive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otwcode/otwarchive/git/refs{/sha}","trees_url":"https://api.github.com/repos/otwcode/otwarchive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otwcode/otwarchive/statuses/{sha}","languages_url":"https://api.github.com/repos/otwcode/otwarchive/languages","stargazers_url":"https://api.github.com/repos/otwcode/otwarchive/stargazers","contributors_url":"https://api.github.com/repos/otwcode/otwarchive/contributors","subscribers_url":"https://api.github.com/repos/otwcode/otwarchive/subscribers","subscription_url":"https://api.github.com/repos/otwcode/otwarchive/subscription","commits_url":"https://api.github.com/repos/otwcode/otwarchive/commits{/sha}","git_commits_url":"https://api.github.com/repos/otwcode/otwarchive/git/commits{/sha}","comments_url":"https://api.github.com/repos/otwcode/otwarchive/comments{/number}","issue_comment_url":"https://api.github.com/repos/otwcode/otwarchive/issues/comments/{number}","contents_url":"https://api.github.com/repos/otwcode/otwarchive/contents/{+path}","compare_url":"https://api.github.com/repos/otwcode/otwarchive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otwcode/otwarchive/merges","archive_url":"https://api.github.com/repos/otwcode/otwarchive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otwcode/otwarchive/downloads","issues_url":"https://api.github.com/repos/otwcode/otwarchive/issues{/number}","pulls_url":"https://api.github.com/repos/otwcode/otwarchive/pulls{/number}","milestones_url":"https://api.github.com/repos/otwcode/otwarchive/milestones{/number}","notifications_url":"https://api.github.com/repos/otwcode/otwarchive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otwcode/otwarchive/labels{/name}","releases_url":"https://api.github.com/repos/otwcode/otwarchive/releases{/id}","created_at":"2011-02-07T14:50:58Z","updated_at":"2015-01-08T03:16:10Z","pushed_at":"2015-01-08T05:04:48Z","git_url":"git://github.com/otwcode/otwarchive.git","ssh_url":"git@github.com:otwcode/otwarchive.git","clone_url":"https://github.com/otwcode/otwarchive.git","svn_url":"https://github.com/otwcode/otwarchive","homepage":"http://transformativeworks.org/projects/archive","size":150740,"stargazers_count":133,"watchers_count":133,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":38,"forks":97,"open_issues":38,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962"},"html":{"href":"https://github.com/otwcode/otwarchive/pull/1962"},"issue":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/1962"},"comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/issues/1962/comments"},"review_comments":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962/comments"},"review_comment":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/otwcode/otwarchive/pulls/1962/commits"},"statuses":{"href":"https://api.github.com/repos/otwcode/otwarchive/statuses/7652ec2cca7b994f3a07db369d5175bddd903b9c"}}}}