{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/29","labels_url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/29/comments","events_url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/29/events","html_url":"https://github.com/ARMmbed/ble-examples/pull/29","id":117815391,"number":29,"title":"Split EddystoneService.h into multiple files","user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars.githubusercontent.com/u/3746901?v=3","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-19T13:39:22Z","updated_at":"2015-11-20T10:22:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/ble-examples/pulls/29","html_url":"https://github.com/ARMmbed/ble-examples/pull/29","diff_url":"https://github.com/ARMmbed/ble-examples/pull/29.diff","patch_url":"https://github.com/ARMmbed/ble-examples/pull/29.patch"},"body":"The EddystoneService.h contained the implementation of the whole service and became excessively large (over 1000 lines). For this reason, it was decided to split the class into its components. Now, each of the classes handling the individual frames are defined in a .h file and implemented in a .cpp file. Similarly, there is EddystoneService.h and EddystoneService.cpp containing declarations and definitions respectively. Finally, an extra header `EddystoneTypes.h` was created and included from all the other header files since it contains `typedef` and `const` declarations that are needed in multiple headers.\r\n@rgrover @jaustin "},"comment":{"url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/comments/158349451","html_url":"https://github.com/ARMmbed/ble-examples/pull/29#issuecomment-158349451","issue_url":"https://api.github.com/repos/ARMmbed/ble-examples/issues/29","id":158349451,"user":{"login":"rgrover","id":112704,"avatar_url":"https://avatars.githubusercontent.com/u/112704?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrover","html_url":"https://github.com/rgrover","followers_url":"https://api.github.com/users/rgrover/followers","following_url":"https://api.github.com/users/rgrover/following{/other_user}","gists_url":"https://api.github.com/users/rgrover/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrover/subscriptions","organizations_url":"https://api.github.com/users/rgrover/orgs","repos_url":"https://api.github.com/users/rgrover/repos","events_url":"https://api.github.com/users/rgrover/events{/privacy}","received_events_url":"https://api.github.com/users/rgrover/received_events","type":"User","site_admin":false},"created_at":"2015-11-20T10:22:00Z","updated_at":"2015-11-20T10:22:00Z","body":"ok. @jaustin has already given his OK contingent upon power profiling. I'll merge this."}}