{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/35185263","id":35185263,"diff_hunk":"@@ -568,6 +577,8 @@ static TEE_Result alloc_rsa_keypair(struct rsa_keypair *s,\n \t\tgoto err;\n \tif (!bn_alloc_max(&s->dq))\n \t\tgoto err;\n+\n+\ttee_ltc_acipher_postactions();","path":"core/lib/libtomcrypt/src/tee_ltc_provider.c","position":31,"original_position":31,"commit_id":"67c136ae394752694cc4af75f5ff25d89489ed1f","original_commit_id":"67c136ae394752694cc4af75f5ff25d89489ed1f","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"Wouldn't this trigger TEE_ASSERT in `tee_ltc_acipher_postactions()`?","created_at":"2015-07-22T06:39:53Z","updated_at":"2015-07-22T06:39:53Z","html_url":"https://github.com/OP-TEE/optee_os/pull/407#discussion_r35185263","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/35185263"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/407#discussion_r35185263"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407","id":40463675,"html_url":"https://github.com/OP-TEE/optee_os/pull/407","diff_url":"https://github.com/OP-TEE/optee_os/pull/407.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/407.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/407","number":407,"state":"open","locked":false,"title":"Add Post-Actions on acipher crypto algorithms","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"body":"In order to check that all temporary variables, used in\r\nacipher computation, are correctly released,\r\ntee_ltc_acipher_postactions() has been added. It raises\r\nan assert in case some temporary variables have not\r\nbeen released.\r\n\r\nSigned-off-by: Pascal Brand <pascal.brand@st.com>","created_at":"2015-07-21T14:32:42Z","updated_at":"2015-07-22T06:39:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c80228ede08a58cdad9214ca9d8707a24af804c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/407/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/67c136ae394752694cc4af75f5ff25d89489ed1f","head":{"label":"pascal-brand-st-dev:ecccheck","ref":"ecccheck","sha":"67c136ae394752694cc4af75f5ff25d89489ed1f","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"repo":{"id":20769654,"name":"optee_os","full_name":"pascal-brand-st-dev/optee_os","owner":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pascal-brand-st-dev/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os","forks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/forks","keys_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/teams","hooks_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/hooks","issue_events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/events","assignees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/tags","blobs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/languages","stargazers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/stargazers","contributors_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contributors","subscribers_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscribers","subscription_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/subscription","commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/merges","archive_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/downloads","issues_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/pascal-brand-st-dev/optee_os/releases{/id}","created_at":"2014-06-12T14:09:53Z","updated_at":"2015-04-28T06:00:43Z","pushed_at":"2015-07-21T14:32:15Z","git_url":"git://github.com/pascal-brand-st-dev/optee_os.git","ssh_url":"git@github.com:pascal-brand-st-dev/optee_os.git","clone_url":"https://github.com/pascal-brand-st-dev/optee_os.git","svn_url":"https://github.com/pascal-brand-st-dev/optee_os","homepage":null,"size":3886,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"e374ac3b7dec79acc68c1891e8b3092cd6ffc2cc","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-07-06T09:17:05Z","pushed_at":"2015-07-21T14:32:43Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":9783,"stargazers_count":54,"watchers_count":54,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":25,"forks":53,"open_issues":25,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/407"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/407"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/67c136ae394752694cc4af75f5ff25d89489ed1f"}}}}