{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/comments/35396317","id":35396317,"diff_hunk":"@@ -989,7 +989,10 @@ exports.connect = function(/* [port, host], options, cb */) {\n     var verifyError = socket._handle.verifyError();\n \n     // Verify that server's identity matches it's certificate's names\n-    if (!verifyError) {\n+    // Unless server has resumed our existing session\n+    if (!verifyError &&\n+        (!options.session ||\n+         Buffer.compare(options.session, socket.getSession()) !== 0)) {","path":"lib/_tls_wrap.js","position":8,"original_position":8,"commit_id":"ef37df25357f3222fe7a96b82279bb1c2c711b9d","original_commit_id":"ef37df25357f3222fe7a96b82279bb1c2c711b9d","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"Nope: https://gist.github.com/indutny/76579b69f072e3a25155","created_at":"2015-07-24T05:25:11Z","updated_at":"2015-07-24T05:25:11Z","html_url":"https://github.com/nodejs/io.js/pull/2228#discussion_r35396317","pull_request_url":"https://api.github.com/repos/nodejs/io.js/pulls/2228","_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments/35396317"},"html":{"href":"https://github.com/nodejs/io.js/pull/2228#discussion_r35396317"},"pull_request":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2228"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2228","id":40635899,"html_url":"https://github.com/nodejs/io.js/pull/2228","diff_url":"https://github.com/nodejs/io.js/pull/2228.diff","patch_url":"https://github.com/nodejs/io.js/pull/2228.patch","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2228","number":2228,"state":"open","locked":false,"title":"https: reuse TLS sessions in Agent","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"body":"Fix: #1499","created_at":"2015-07-23T04:20:31Z","updated_at":"2015-07-24T05:25:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b111a8c1ffbad972f5ede41fbcaf8408326e325","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/io.js/pulls/2228/commits","review_comments_url":"https://api.github.com/repos/nodejs/io.js/pulls/2228/comments","review_comment_url":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2228/comments","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/ef37df25357f3222fe7a96b82279bb1c2c711b9d","head":{"label":"indutny:fix/gh-1499","ref":"fix/gh-1499","sha":"ef37df25357f3222fe7a96b82279bb1c2c711b9d","user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"repo":{"id":27231488,"name":"io.js","full_name":"indutny/io.js","owner":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indutny/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/indutny/io.js","forks_url":"https://api.github.com/repos/indutny/io.js/forks","keys_url":"https://api.github.com/repos/indutny/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indutny/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indutny/io.js/teams","hooks_url":"https://api.github.com/repos/indutny/io.js/hooks","issue_events_url":"https://api.github.com/repos/indutny/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/indutny/io.js/events","assignees_url":"https://api.github.com/repos/indutny/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/indutny/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/indutny/io.js/tags","blobs_url":"https://api.github.com/repos/indutny/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indutny/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indutny/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/indutny/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indutny/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/indutny/io.js/languages","stargazers_url":"https://api.github.com/repos/indutny/io.js/stargazers","contributors_url":"https://api.github.com/repos/indutny/io.js/contributors","subscribers_url":"https://api.github.com/repos/indutny/io.js/subscribers","subscription_url":"https://api.github.com/repos/indutny/io.js/subscription","commits_url":"https://api.github.com/repos/indutny/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/indutny/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/indutny/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/indutny/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/indutny/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/indutny/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indutny/io.js/merges","archive_url":"https://api.github.com/repos/indutny/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indutny/io.js/downloads","issues_url":"https://api.github.com/repos/indutny/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/indutny/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/indutny/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/indutny/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indutny/io.js/labels{/name}","releases_url":"https://api.github.com/repos/indutny/io.js/releases{/id}","created_at":"2014-11-27T15:38:33Z","updated_at":"2015-02-18T15:41:43Z","pushed_at":"2015-07-23T18:13:56Z","git_url":"git://github.com/indutny/io.js.git","ssh_url":"git@github.com:indutny/io.js.git","clone_url":"https://github.com/indutny/io.js.git","svn_url":"https://github.com/indutny/io.js","homepage":null,"size":140221,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"v0.12"}},"base":{"label":"nodejs:master","ref":"master","sha":"eb35968de7a040d737f3280e9fed0b6edf566b2b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"nodejs/io.js","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/io.js","description":"Future Node.js releases will be based on io.js","fork":false,"url":"https://api.github.com/repos/nodejs/io.js","forks_url":"https://api.github.com/repos/nodejs/io.js/forks","keys_url":"https://api.github.com/repos/nodejs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/io.js/teams","hooks_url":"https://api.github.com/repos/nodejs/io.js/hooks","issue_events_url":"https://api.github.com/repos/nodejs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/io.js/events","assignees_url":"https://api.github.com/repos/nodejs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/io.js/tags","blobs_url":"https://api.github.com/repos/nodejs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/io.js/languages","stargazers_url":"https://api.github.com/repos/nodejs/io.js/stargazers","contributors_url":"https://api.github.com/repos/nodejs/io.js/contributors","subscribers_url":"https://api.github.com/repos/nodejs/io.js/subscribers","subscription_url":"https://api.github.com/repos/nodejs/io.js/subscription","commits_url":"https://api.github.com/repos/nodejs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/io.js/merges","archive_url":"https://api.github.com/repos/nodejs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/io.js/downloads","issues_url":"https://api.github.com/repos/nodejs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-07-24T02:16:29Z","pushed_at":"2015-07-24T02:42:17Z","git_url":"git://github.com/nodejs/io.js.git","ssh_url":"git@github.com:nodejs/io.js.git","clone_url":"https://github.com/nodejs/io.js.git","svn_url":"https://github.com/nodejs/io.js","homepage":"https://iojs.org","size":190496,"stargazers_count":12915,"watchers_count":12915,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1034,"mirror_url":null,"open_issues_count":287,"forks":1034,"open_issues":287,"watchers":12915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2228"},"html":{"href":"https://github.com/nodejs/io.js/pull/2228"},"issue":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2228"},"comments":{"href":"https://api.github.com/repos/nodejs/io.js/issues/2228/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2228/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/io.js/pulls/2228/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/io.js/statuses/ef37df25357f3222fe7a96b82279bb1c2c711b9d"}}}}