{"action":"created","issue":{"url":"https://api.github.com/repos/fesch/CanZE/issues/23","labels_url":"https://api.github.com/repos/fesch/CanZE/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/fesch/CanZE/issues/23/comments","events_url":"https://api.github.com/repos/fesch/CanZE/issues/23/events","html_url":"https://github.com/fesch/CanZE/issues/23","id":107406341,"number":23,"title":"Battery compartment temperatures not right on Fluence ZE","user":{"login":"yoh-there","id":4979670,"avatar_url":"https://avatars.githubusercontent.com/u/4979670?v=3","gravatar_id":"","url":"https://api.github.com/users/yoh-there","html_url":"https://github.com/yoh-there","followers_url":"https://api.github.com/users/yoh-there/followers","following_url":"https://api.github.com/users/yoh-there/following{/other_user}","gists_url":"https://api.github.com/users/yoh-there/gists{/gist_id}","starred_url":"https://api.github.com/users/yoh-there/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoh-there/subscriptions","organizations_url":"https://api.github.com/users/yoh-there/orgs","repos_url":"https://api.github.com/users/yoh-there/repos","events_url":"https://api.github.com/users/yoh-there/events{/privacy}","received_events_url":"https://api.github.com/users/yoh-there/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-09-20T17:38:24Z","updated_at":"2015-09-21T16:29:17Z","closed_at":null,"body":"[moved from another issue thread]\r\n=======\r\nsolmoller:\r\n(...) And I rarely get a sane temperature reading on the charging screen\r\n\r\n======\r\nyoh-there:\r\nThe sane part come form the Fluence ZE having only 4 compartment sensors instead of 12 and I have not made Zoe/Fluence variants. Your first 4 values should be \"sane\", but I would love to hear if the ARE sane!\r\n\r\n=======\r\nsolmoller:\r\nI've had sane results from sensors 7 and 12, but I think that it could be just random numbers now.. Any suggestions on how to dig out Fluence battery temps? Henrik\r\n\r\n=======\r\nyoh-there:\r\nSure! According to Alexandre, the Fluence's temperatures are given with request https://docs.google.com/spreadsheets/d/1p_zEgy8RqvTV79mT4HFdyKinz3l3q-WlECp_W2ymePM/edit#gid=651307834 79b/7bb, request 0x2104/0x6104 (same as Zoe), bit positions 32, 56, 80, 104, and an average in 12 Not that this is the same as the first 4 temperatures in the Zoe, so i would expect the first 4 to be right, and the next 8 to be nonsensical. Somebody should really integrate Alexandre's work in the main spreadsheet. What would be great if we then create two initialization variants of the Fields class. Note that there is a \"car\" column (Fluence/Zoe/Both) in the spreadsheet, so it is tedious, but not hard.\r\n\r\n=======\r\nfesch:\r\nThat right. I've already prepared the settings activity to let the user chose his \"car\" (Zoe or Fluence for now), so this deployment should not be that hard.\r\n\r\n=======\r\nMeanwhile i found the same - but I am not sure we draw the same conclusion: Zoe Battery T1 I read as 7bb.6104.32, Fluence I'd presume is 7bb.2104.32 Will test shortly\r\n\r\n=======\r\nyoh-there:\r\nNope, 21 is the request code, 61 the answer. The app uses only the reply code and uses internal tables to send the proper request.\r\n\r\n=======\r\nsolmoller:\r\nAh, never mind, I see in the Fields.java, that it may be me misreading the spreadsheets\r\n\r\n(...)\r\n\r\nOh, Henrik, I think I found it. For the Zoe, the temperatures have an offset of 40, so the real values can go from -40 to 215 ;-) The Fluence ZE does not have those offsets. I was looking at your values (your email of sept 14) and it completely makes sense. At that moment, your 4 compartment temps were 21, 20, 19, 19. So yes, we do need to work in the initialisation of Fields."},"comment":{"url":"https://api.github.com/repos/fesch/CanZE/issues/comments/142035145","html_url":"https://github.com/fesch/CanZE/issues/23#issuecomment-142035145","issue_url":"https://api.github.com/repos/fesch/CanZE/issues/23","id":142035145,"user":{"login":"yoh-there","id":4979670,"avatar_url":"https://avatars.githubusercontent.com/u/4979670?v=3","gravatar_id":"","url":"https://api.github.com/users/yoh-there","html_url":"https://github.com/yoh-there","followers_url":"https://api.github.com/users/yoh-there/followers","following_url":"https://api.github.com/users/yoh-there/following{/other_user}","gists_url":"https://api.github.com/users/yoh-there/gists{/gist_id}","starred_url":"https://api.github.com/users/yoh-there/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoh-there/subscriptions","organizations_url":"https://api.github.com/users/yoh-there/orgs","repos_url":"https://api.github.com/users/yoh-there/repos","events_url":"https://api.github.com/users/yoh-there/events{/privacy}","received_events_url":"https://api.github.com/users/yoh-there/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T16:29:17Z","updated_at":"2015-09-21T16:29:17Z","body":"I see the problem I think. Fluence = car 1 in the spreadsheet, 2 in the code and vice versa. I did that out of respect, Fluence ZE was born earlier ;-) Fixed it on the constants, comitted, pushed and issued a pull request.\r\n\r\n@Henrik, at the moment in driving and charging, I always set default values in the screens, it helps me debugging. It the 8 useless #T fields annoy you, we can simply change the default in strings.xml."}}