{"comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/comments/13468579","html_url":"https://github.com/alphagov/smart-answers/commit/16a8dd5fc815e2aede122ebeac64ba6642242fe9#commitcomment-13468579","id":13468579,"user":{"login":"tadast","id":218239,"avatar_url":"https://avatars.githubusercontent.com/u/218239?v=3","gravatar_id":"","url":"https://api.github.com/users/tadast","html_url":"https://github.com/tadast","followers_url":"https://api.github.com/users/tadast/followers","following_url":"https://api.github.com/users/tadast/following{/other_user}","gists_url":"https://api.github.com/users/tadast/gists{/gist_id}","starred_url":"https://api.github.com/users/tadast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadast/subscriptions","organizations_url":"https://api.github.com/users/tadast/orgs","repos_url":"https://api.github.com/users/tadast/repos","events_url":"https://api.github.com/users/tadast/events{/privacy}","received_events_url":"https://api.github.com/users/tadast/received_events","type":"User","site_admin":false},"position":13,"line":27,"path":"lib/smart_answer/calculators/state_pension_topup_calculator.rb","commit_id":"16a8dd5fc815e2aede122ebeac64ba6642242fe9","created_at":"2015-09-28T13:31:40Z","updated_at":"2015-09-28T13:31:40Z","body":"If I recall correctly we call this method first before we collect gender\nfrom the user. If dob > female_yougest_dob then we tell the user they're\ntoo young, because neither female nor male users qualify. Then later in the\nprocess we check again for male users only. Sorry if it doesn't make any\nsense, I'm replying from my phone without looking at the code :)\n\nOn Mon, 28 Sep 2015 at 12:45, James Mead <notifications@github.com> wrote:\n\n> It feels a bit weird that this defaults to gender = 'female'. I think it\n> makes sense in the context of FEMALE_YOUNGEST_DOB being later than\n> MALE_YOUNGEST_DOB, but it doesn't feel as if it is generally correct.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/alphagov/smart-answers/commit/16a8dd5fc815e2aede122ebeac64ba6642242fe9#commitcomment-13464346>\n> .\n>\n"}}