{"action":"created","comment":{"url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/comments/48249028","id":48249028,"diff_hunk":"@@ -104,6 +104,15 @@ -(instancetype)initWithTitle:(NSString *)title\n \treturn self;\n }\n \n+- (void)dealloc\n+{\n+    #if USE_UIALERTVIEW == 0","path":"OHAlertView/OHAlertView.m","position":6,"original_position":6,"commit_id":"260b46bc05f0b9e8d1c527e362576a506868dbc5","original_commit_id":"260b46bc05f0b9e8d1c527e362576a506868dbc5","user":{"login":"bill350","id":2437702,"avatar_url":"https://avatars.githubusercontent.com/u/2437702?v=3","gravatar_id":"","url":"https://api.github.com/users/bill350","html_url":"https://github.com/bill350","followers_url":"https://api.github.com/users/bill350/followers","following_url":"https://api.github.com/users/bill350/following{/other_user}","gists_url":"https://api.github.com/users/bill350/gists{/gist_id}","starred_url":"https://api.github.com/users/bill350/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill350/subscriptions","organizations_url":"https://api.github.com/users/bill350/orgs","repos_url":"https://api.github.com/users/bill350/repos","events_url":"https://api.github.com/users/bill350/events{/privacy}","received_events_url":"https://api.github.com/users/bill350/received_events","type":"User","site_admin":false},"body":"Yep but I prefer specify == term when using macros. Anyway, this is the same ;)","created_at":"2015-12-22T12:34:08Z","updated_at":"2015-12-22T12:34:08Z","html_url":"https://github.com/AliSoftware/OHAlertView/pull/8#discussion_r48249028","pull_request_url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/comments/48249028"},"html":{"href":"https://github.com/AliSoftware/OHAlertView/pull/8#discussion_r48249028"},"pull_request":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8","id":54235887,"html_url":"https://github.com/AliSoftware/OHAlertView/pull/8","diff_url":"https://github.com/AliSoftware/OHAlertView/pull/8.diff","patch_url":"https://github.com/AliSoftware/OHAlertView/pull/8.patch","issue_url":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/8","number":8,"state":"open","locked":false,"title":"Remove from NSNotificationCenter observing on dealloc","user":{"login":"bill350","id":2437702,"avatar_url":"https://avatars.githubusercontent.com/u/2437702?v=3","gravatar_id":"","url":"https://api.github.com/users/bill350","html_url":"https://github.com/bill350","followers_url":"https://api.github.com/users/bill350/followers","following_url":"https://api.github.com/users/bill350/following{/other_user}","gists_url":"https://api.github.com/users/bill350/gists{/gist_id}","starred_url":"https://api.github.com/users/bill350/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill350/subscriptions","organizations_url":"https://api.github.com/users/bill350/orgs","repos_url":"https://api.github.com/users/bill350/repos","events_url":"https://api.github.com/users/bill350/events{/privacy}","received_events_url":"https://api.github.com/users/bill350/received_events","type":"User","site_admin":false},"body":"This request removing NotificationCenter observing to avoid crashes on iOS8+ and assure that no observer still alive after OHAlertView deallocation.\r\n\r\nRelated issue : https://github.com/AliSoftware/OHAlertView/issues/7 \r\n\r\n","created_at":"2015-12-21T09:31:24Z","updated_at":"2015-12-22T12:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31ccf49639ec47f162bc264466ce299ba12aaa69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8/commits","review_comments_url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8/comments","review_comment_url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/8/comments","statuses_url":"https://api.github.com/repos/AliSoftware/OHAlertView/statuses/260b46bc05f0b9e8d1c527e362576a506868dbc5","head":{"label":"bill350:master","ref":"master","sha":"260b46bc05f0b9e8d1c527e362576a506868dbc5","user":{"login":"bill350","id":2437702,"avatar_url":"https://avatars.githubusercontent.com/u/2437702?v=3","gravatar_id":"","url":"https://api.github.com/users/bill350","html_url":"https://github.com/bill350","followers_url":"https://api.github.com/users/bill350/followers","following_url":"https://api.github.com/users/bill350/following{/other_user}","gists_url":"https://api.github.com/users/bill350/gists{/gist_id}","starred_url":"https://api.github.com/users/bill350/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill350/subscriptions","organizations_url":"https://api.github.com/users/bill350/orgs","repos_url":"https://api.github.com/users/bill350/repos","events_url":"https://api.github.com/users/bill350/events{/privacy}","received_events_url":"https://api.github.com/users/bill350/received_events","type":"User","site_admin":false},"repo":{"id":47565934,"name":"OHAlertView","full_name":"bill350/OHAlertView","owner":{"login":"bill350","id":2437702,"avatar_url":"https://avatars.githubusercontent.com/u/2437702?v=3","gravatar_id":"","url":"https://api.github.com/users/bill350","html_url":"https://github.com/bill350","followers_url":"https://api.github.com/users/bill350/followers","following_url":"https://api.github.com/users/bill350/following{/other_user}","gists_url":"https://api.github.com/users/bill350/gists{/gist_id}","starred_url":"https://api.github.com/users/bill350/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bill350/subscriptions","organizations_url":"https://api.github.com/users/bill350/orgs","repos_url":"https://api.github.com/users/bill350/repos","events_url":"https://api.github.com/users/bill350/events{/privacy}","received_events_url":"https://api.github.com/users/bill350/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bill350/OHAlertView","description":"UIAlertView subclass that uses blocks to handle its callback (which make the code much more easier and readable) ","fork":true,"url":"https://api.github.com/repos/bill350/OHAlertView","forks_url":"https://api.github.com/repos/bill350/OHAlertView/forks","keys_url":"https://api.github.com/repos/bill350/OHAlertView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bill350/OHAlertView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bill350/OHAlertView/teams","hooks_url":"https://api.github.com/repos/bill350/OHAlertView/hooks","issue_events_url":"https://api.github.com/repos/bill350/OHAlertView/issues/events{/number}","events_url":"https://api.github.com/repos/bill350/OHAlertView/events","assignees_url":"https://api.github.com/repos/bill350/OHAlertView/assignees{/user}","branches_url":"https://api.github.com/repos/bill350/OHAlertView/branches{/branch}","tags_url":"https://api.github.com/repos/bill350/OHAlertView/tags","blobs_url":"https://api.github.com/repos/bill350/OHAlertView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bill350/OHAlertView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bill350/OHAlertView/git/refs{/sha}","trees_url":"https://api.github.com/repos/bill350/OHAlertView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bill350/OHAlertView/statuses/{sha}","languages_url":"https://api.github.com/repos/bill350/OHAlertView/languages","stargazers_url":"https://api.github.com/repos/bill350/OHAlertView/stargazers","contributors_url":"https://api.github.com/repos/bill350/OHAlertView/contributors","subscribers_url":"https://api.github.com/repos/bill350/OHAlertView/subscribers","subscription_url":"https://api.github.com/repos/bill350/OHAlertView/subscription","commits_url":"https://api.github.com/repos/bill350/OHAlertView/commits{/sha}","git_commits_url":"https://api.github.com/repos/bill350/OHAlertView/git/commits{/sha}","comments_url":"https://api.github.com/repos/bill350/OHAlertView/comments{/number}","issue_comment_url":"https://api.github.com/repos/bill350/OHAlertView/issues/comments{/number}","contents_url":"https://api.github.com/repos/bill350/OHAlertView/contents/{+path}","compare_url":"https://api.github.com/repos/bill350/OHAlertView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bill350/OHAlertView/merges","archive_url":"https://api.github.com/repos/bill350/OHAlertView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bill350/OHAlertView/downloads","issues_url":"https://api.github.com/repos/bill350/OHAlertView/issues{/number}","pulls_url":"https://api.github.com/repos/bill350/OHAlertView/pulls{/number}","milestones_url":"https://api.github.com/repos/bill350/OHAlertView/milestones{/number}","notifications_url":"https://api.github.com/repos/bill350/OHAlertView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bill350/OHAlertView/labels{/name}","releases_url":"https://api.github.com/repos/bill350/OHAlertView/releases{/id}","created_at":"2015-12-07T16:54:00Z","updated_at":"2015-12-07T16:54:01Z","pushed_at":"2015-12-21T09:27:38Z","git_url":"git://github.com/bill350/OHAlertView.git","ssh_url":"git@github.com:bill350/OHAlertView.git","clone_url":"https://github.com/bill350/OHAlertView.git","svn_url":"https://github.com/bill350/OHAlertView","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AliSoftware:master","ref":"master","sha":"bc38906bf6ce0638d781c92f05c6f81a199fe26b","user":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"repo":{"id":11979652,"name":"OHAlertView","full_name":"AliSoftware/OHAlertView","owner":{"login":"AliSoftware","id":216089,"avatar_url":"https://avatars.githubusercontent.com/u/216089?v=3","gravatar_id":"","url":"https://api.github.com/users/AliSoftware","html_url":"https://github.com/AliSoftware","followers_url":"https://api.github.com/users/AliSoftware/followers","following_url":"https://api.github.com/users/AliSoftware/following{/other_user}","gists_url":"https://api.github.com/users/AliSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/AliSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliSoftware/subscriptions","organizations_url":"https://api.github.com/users/AliSoftware/orgs","repos_url":"https://api.github.com/users/AliSoftware/repos","events_url":"https://api.github.com/users/AliSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/AliSoftware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AliSoftware/OHAlertView","description":"UIAlertView subclass that uses blocks to handle its callback (which make the code much more easier and readable) ","fork":false,"url":"https://api.github.com/repos/AliSoftware/OHAlertView","forks_url":"https://api.github.com/repos/AliSoftware/OHAlertView/forks","keys_url":"https://api.github.com/repos/AliSoftware/OHAlertView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AliSoftware/OHAlertView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AliSoftware/OHAlertView/teams","hooks_url":"https://api.github.com/repos/AliSoftware/OHAlertView/hooks","issue_events_url":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/events{/number}","events_url":"https://api.github.com/repos/AliSoftware/OHAlertView/events","assignees_url":"https://api.github.com/repos/AliSoftware/OHAlertView/assignees{/user}","branches_url":"https://api.github.com/repos/AliSoftware/OHAlertView/branches{/branch}","tags_url":"https://api.github.com/repos/AliSoftware/OHAlertView/tags","blobs_url":"https://api.github.com/repos/AliSoftware/OHAlertView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AliSoftware/OHAlertView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AliSoftware/OHAlertView/git/refs{/sha}","trees_url":"https://api.github.com/repos/AliSoftware/OHAlertView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AliSoftware/OHAlertView/statuses/{sha}","languages_url":"https://api.github.com/repos/AliSoftware/OHAlertView/languages","stargazers_url":"https://api.github.com/repos/AliSoftware/OHAlertView/stargazers","contributors_url":"https://api.github.com/repos/AliSoftware/OHAlertView/contributors","subscribers_url":"https://api.github.com/repos/AliSoftware/OHAlertView/subscribers","subscription_url":"https://api.github.com/repos/AliSoftware/OHAlertView/subscription","commits_url":"https://api.github.com/repos/AliSoftware/OHAlertView/commits{/sha}","git_commits_url":"https://api.github.com/repos/AliSoftware/OHAlertView/git/commits{/sha}","comments_url":"https://api.github.com/repos/AliSoftware/OHAlertView/comments{/number}","issue_comment_url":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/comments{/number}","contents_url":"https://api.github.com/repos/AliSoftware/OHAlertView/contents/{+path}","compare_url":"https://api.github.com/repos/AliSoftware/OHAlertView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AliSoftware/OHAlertView/merges","archive_url":"https://api.github.com/repos/AliSoftware/OHAlertView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AliSoftware/OHAlertView/downloads","issues_url":"https://api.github.com/repos/AliSoftware/OHAlertView/issues{/number}","pulls_url":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls{/number}","milestones_url":"https://api.github.com/repos/AliSoftware/OHAlertView/milestones{/number}","notifications_url":"https://api.github.com/repos/AliSoftware/OHAlertView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AliSoftware/OHAlertView/labels{/name}","releases_url":"https://api.github.com/repos/AliSoftware/OHAlertView/releases{/id}","created_at":"2013-08-08T15:25:16Z","updated_at":"2015-09-15T08:40:55Z","pushed_at":"2015-12-21T09:31:24Z","git_url":"git://github.com/AliSoftware/OHAlertView.git","ssh_url":"git@github.com:AliSoftware/OHAlertView.git","clone_url":"https://github.com/AliSoftware/OHAlertView.git","svn_url":"https://github.com/AliSoftware/OHAlertView","homepage":null,"size":298,"stargazers_count":18,"watchers_count":18,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8"},"html":{"href":"https://github.com/AliSoftware/OHAlertView/pull/8"},"issue":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/8"},"comments":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/AliSoftware/OHAlertView/statuses/260b46bc05f0b9e8d1c527e362576a506868dbc5"}}}}