{"action":"created","issue":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7","labels_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/comments","events_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7/events","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7","id":121156150,"number":7,"title":"adding sqlserver","user":{"login":"luisrudge","id":941075,"avatar_url":"https://avatars.githubusercontent.com/u/941075?v=3","gravatar_id":"","url":"https://api.github.com/users/luisrudge","html_url":"https://github.com/luisrudge","followers_url":"https://api.github.com/users/luisrudge/followers","following_url":"https://api.github.com/users/luisrudge/following{/other_user}","gists_url":"https://api.github.com/users/luisrudge/gists{/gist_id}","starred_url":"https://api.github.com/users/luisrudge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisrudge/subscriptions","organizations_url":"https://api.github.com/users/luisrudge/orgs","repos_url":"https://api.github.com/users/luisrudge/repos","events_url":"https://api.github.com/users/luisrudge/events{/privacy}","received_events_url":"https://api.github.com/users/luisrudge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-12-09T04:13:32Z","updated_at":"2015-12-10T16:25:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/pulls/7","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7","diff_url":"https://github.com/sqlectron/sqlectron-core/pull/7.diff","patch_url":"https://github.com/sqlectron/sqlectron-core/pull/7.patch"},"body":"fix #2 \r\n\r\n# YO!\r\n All tests are passing :)\r\nhttps://ci.appveyor.com/project/luisrudge/sqlectron-core\r\n\r\nSo, let's discuss the PR.\r\n\r\nOnce the PR lands, you won't be able to run `npm test` anymore, because you don't have a sql and you can't run sql server via docker (yet). So, how we'll handle this?\r\nOne test command per db (pg, mysql sqlserver)?\r\nOne test command per env (unix, win)?\r\n\r\nIf you need some sql server credentials to test this, ping me on [twitter](https://twitter.com/luisrudge) and I can send you via DM."},"comment":{"url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/comments/163677317","html_url":"https://github.com/sqlectron/sqlectron-core/pull/7#issuecomment-163677317","issue_url":"https://api.github.com/repos/sqlectron/sqlectron-core/issues/7","id":163677317,"user":{"login":"maxcnunes","id":680356,"avatar_url":"https://avatars.githubusercontent.com/u/680356?v=3","gravatar_id":"","url":"https://api.github.com/users/maxcnunes","html_url":"https://github.com/maxcnunes","followers_url":"https://api.github.com/users/maxcnunes/followers","following_url":"https://api.github.com/users/maxcnunes/following{/other_user}","gists_url":"https://api.github.com/users/maxcnunes/gists{/gist_id}","starred_url":"https://api.github.com/users/maxcnunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxcnunes/subscriptions","organizations_url":"https://api.github.com/users/maxcnunes/orgs","repos_url":"https://api.github.com/users/maxcnunes/repos","events_url":"https://api.github.com/users/maxcnunes/events{/privacy}","received_events_url":"https://api.github.com/users/maxcnunes/received_events","type":"User","site_admin":false},"created_at":"2015-12-10T16:25:32Z","updated_at":"2015-12-10T16:25:32Z","body":"- [postgresql.js#L86](https://github.com/sqlectron/sqlectron-core/blob/master/src/db/clients/postgresql.js#L86) remove any existing break line or white space in the beginning of the query\r\n- [postgresql.js#L87](https://github.com/sqlectron/sqlectron-core/blob/master/src/db/clients/postgresql.js#L87) remove any existing break line or white space between the queries\r\n- [postgresql.js#L88](https://github.com/sqlectron/sqlectron-core/blob/master/src/db/clients/postgresql.js#L88) split up the queries\r\n\r\nWell, I would prefer a better approach. But currently I guess is the only option. At least I can't see any bad side affects using this approach."}}