{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/comments/23844135","id":23844135,"diff_hunk":"@@ -3433,7 +3438,9 @@ static void tklock_evctrl_rethink(void)\n \n     /* Grabbing touch input is always permitted, but ungrabbing\n      * only when proximity sensor is not covered */","path":"tklock.c","position":15,"original_position":15,"commit_id":"ab239fef2fc9113b7603fccfcae92001fcabcc20","original_commit_id":"ab239fef2fc9113b7603fccfcae92001fcabcc20","user":{"login":"pgerdt","id":2118674,"avatar_url":"https://avatars.githubusercontent.com/u/2118674?v=3","gravatar_id":"","url":"https://api.github.com/users/pgerdt","html_url":"https://github.com/pgerdt","followers_url":"https://api.github.com/users/pgerdt/followers","following_url":"https://api.github.com/users/pgerdt/following{/other_user}","gists_url":"https://api.github.com/users/pgerdt/gists{/gist_id}","starred_url":"https://api.github.com/users/pgerdt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgerdt/subscriptions","organizations_url":"https://api.github.com/users/pgerdt/orgs","repos_url":"https://api.github.com/users/pgerdt/repos","events_url":"https://api.github.com/users/pgerdt/events{/privacy}","received_events_url":"https://api.github.com/users/pgerdt/received_events","type":"User","site_admin":false},"body":"Should the documentation be updated to reflect the !proximity_blocks_touch?","created_at":"2015-01-30T14:14:43Z","updated_at":"2015-01-30T14:14:43Z","html_url":"https://github.com/nemomobile/mce/pull/242#discussion_r23844135","pull_request_url":"https://api.github.com/repos/nemomobile/mce/pulls/242","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments/23844135"},"html":{"href":"https://github.com/nemomobile/mce/pull/242#discussion_r23844135"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/242","id":28359790,"html_url":"https://github.com/nemomobile/mce/pull/242","diff_url":"https://github.com/nemomobile/mce/pull/242.diff","patch_url":"https://github.com/nemomobile/mce/pull/242.patch","issue_url":"https://api.github.com/repos/nemomobile/mce/issues/242","number":242,"state":"open","locked":false,"title":"Make touch input blocking by proximity sensor optional","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"body":"Many users have had problems with touch input immediately after bootup.\r\nIt is verly likely that it is caused by touch input getting blocked\r\nby the proximity sensor. Since there is not yet visual clues about the\r\nfact that it is happening, the users have no way of knowing what is\r\nhappening and how to remedy the situation.\r\n\r\nAlso porting projects where sensor adaptation is not fully working\r\nhave had trouble with this feature.\r\n\r\nAdd setting for enabling/disabling touch blocking by proximity sensor.\r\n\r\nDisable the feature by default.\r\n\r\nThe default can be changed via:\r\n  mcetool --set-ps-blocks-touch=<enabled|disabled>","created_at":"2015-01-30T13:07:31Z","updated_at":"2015-01-30T14:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37ff91ba3a07e882b82e3f4a743a4a4cfa219a56","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/mce/pulls/242/commits","review_comments_url":"https://api.github.com/repos/nemomobile/mce/pulls/242/comments","review_comment_url":"https://api.github.com/repos/nemomobile/mce/pulls/comments/{number}","comments_url":"https://api.github.com/repos/nemomobile/mce/issues/242/comments","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/ab239fef2fc9113b7603fccfcae92001fcabcc20","head":{"label":"spiiroin:jb25467_optional_ps_block","ref":"jb25467_optional_ps_block","sha":"ab239fef2fc9113b7603fccfcae92001fcabcc20","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"repo":{"id":6487031,"name":"mce","full_name":"spiiroin/mce","owner":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spiiroin/mce","description":"","fork":true,"url":"https://api.github.com/repos/spiiroin/mce","forks_url":"https://api.github.com/repos/spiiroin/mce/forks","keys_url":"https://api.github.com/repos/spiiroin/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiiroin/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiiroin/mce/teams","hooks_url":"https://api.github.com/repos/spiiroin/mce/hooks","issue_events_url":"https://api.github.com/repos/spiiroin/mce/issues/events{/number}","events_url":"https://api.github.com/repos/spiiroin/mce/events","assignees_url":"https://api.github.com/repos/spiiroin/mce/assignees{/user}","branches_url":"https://api.github.com/repos/spiiroin/mce/branches{/branch}","tags_url":"https://api.github.com/repos/spiiroin/mce/tags","blobs_url":"https://api.github.com/repos/spiiroin/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiiroin/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiiroin/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiiroin/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiiroin/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/spiiroin/mce/languages","stargazers_url":"https://api.github.com/repos/spiiroin/mce/stargazers","contributors_url":"https://api.github.com/repos/spiiroin/mce/contributors","subscribers_url":"https://api.github.com/repos/spiiroin/mce/subscribers","subscription_url":"https://api.github.com/repos/spiiroin/mce/subscription","commits_url":"https://api.github.com/repos/spiiroin/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiiroin/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiiroin/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiiroin/mce/issues/comments/{number}","contents_url":"https://api.github.com/repos/spiiroin/mce/contents/{+path}","compare_url":"https://api.github.com/repos/spiiroin/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiiroin/mce/merges","archive_url":"https://api.github.com/repos/spiiroin/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiiroin/mce/downloads","issues_url":"https://api.github.com/repos/spiiroin/mce/issues{/number}","pulls_url":"https://api.github.com/repos/spiiroin/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/spiiroin/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/spiiroin/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiiroin/mce/labels{/name}","releases_url":"https://api.github.com/repos/spiiroin/mce/releases{/id}","created_at":"2012-11-01T09:06:03Z","updated_at":"2015-01-29T09:38:23Z","pushed_at":"2015-01-30T13:45:41Z","git_url":"git://github.com/spiiroin/mce.git","ssh_url":"git@github.com:spiiroin/mce.git","clone_url":"https://github.com/spiiroin/mce.git","svn_url":"https://github.com/spiiroin/mce","homepage":null,"size":5610,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:update11","ref":"update11","sha":"c5af2da16885c7cffc59d80ecd26986a0c3302de","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":6041894,"name":"mce","full_name":"nemomobile/mce","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/mce","description":"","fork":false,"url":"https://api.github.com/repos/nemomobile/mce","forks_url":"https://api.github.com/repos/nemomobile/mce/forks","keys_url":"https://api.github.com/repos/nemomobile/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/mce/teams","hooks_url":"https://api.github.com/repos/nemomobile/mce/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/mce/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/mce/events","assignees_url":"https://api.github.com/repos/nemomobile/mce/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/mce/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/mce/tags","blobs_url":"https://api.github.com/repos/nemomobile/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/mce/languages","stargazers_url":"https://api.github.com/repos/nemomobile/mce/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/mce/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/mce/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/mce/subscription","commits_url":"https://api.github.com/repos/nemomobile/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/mce/issues/comments/{number}","contents_url":"https://api.github.com/repos/nemomobile/mce/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/mce/merges","archive_url":"https://api.github.com/repos/nemomobile/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/mce/downloads","issues_url":"https://api.github.com/repos/nemomobile/mce/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/mce/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/mce/releases{/id}","created_at":"2012-10-02T08:09:10Z","updated_at":"2015-01-30T07:46:31Z","pushed_at":"2015-01-30T07:46:38Z","git_url":"git://github.com/nemomobile/mce.git","ssh_url":"git@github.com:nemomobile/mce.git","clone_url":"https://github.com/nemomobile/mce.git","svn_url":"https://github.com/nemomobile/mce","homepage":null,"size":5838,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/242"},"html":{"href":"https://github.com/nemomobile/mce/pull/242"},"issue":{"href":"https://api.github.com/repos/nemomobile/mce/issues/242"},"comments":{"href":"https://api.github.com/repos/nemomobile/mce/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/mce/statuses/ab239fef2fc9113b7603fccfcae92001fcabcc20"}}}}