{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/42970646","id":42970646,"diff_hunk":"@@ -77,7 +79,9 @@ def check(self):\n         log.info(\"fs space: %s  needed: %s\", free, needed)\n         self.success = (free > needed)\n         if not self.success:\n-            self.deficit = needed - free\n+            required_space = Size(Decimal(needed) / Decimal(self.storage.rootDevice.format.MetadataSizeFactor))","path":"pyanaconda/ui/lib/space.py","position":14,"original_position":14,"commit_id":"f7582ee3262c910d529165891f067537e52de781","original_commit_id":"f7582ee3262c910d529165891f067537e52de781","user":{"login":"vpodzime","id":1044278,"avatar_url":"https://avatars.githubusercontent.com/u/1044278?v=3","gravatar_id":"","url":"https://api.github.com/users/vpodzime","html_url":"https://github.com/vpodzime","followers_url":"https://api.github.com/users/vpodzime/followers","following_url":"https://api.github.com/users/vpodzime/following{/other_user}","gists_url":"https://api.github.com/users/vpodzime/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodzime/subscriptions","organizations_url":"https://api.github.com/users/vpodzime/orgs","repos_url":"https://api.github.com/users/vpodzime/repos","events_url":"https://api.github.com/users/vpodzime/events{/privacy}","received_events_url":"https://api.github.com/users/vpodzime/received_events","type":"User","site_admin":false},"body":"Should these two really be divided? It doesn't make much sense to me. Also, this calculation should be put into a method with a reasonable name.","created_at":"2015-10-26T09:06:25Z","updated_at":"2015-10-26T09:06:25Z","html_url":"https://github.com/rhinstaller/anaconda/pull/424#discussion_r42970646","pull_request_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/42970646"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/424#discussion_r42970646"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424","id":48584851,"html_url":"https://github.com/rhinstaller/anaconda/pull/424","diff_url":"https://github.com/rhinstaller/anaconda/pull/424.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/424.patch","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/424","number":424,"state":"open","locked":false,"title":"Fix bad space needed messages","user":{"login":"jkonecny12","id":1643889,"avatar_url":"https://avatars.githubusercontent.com/u/1643889?v=3","gravatar_id":"","url":"https://api.github.com/users/jkonecny12","html_url":"https://github.com/jkonecny12","followers_url":"https://api.github.com/users/jkonecny12/followers","following_url":"https://api.github.com/users/jkonecny12/following{/other_user}","gists_url":"https://api.github.com/users/jkonecny12/gists{/gist_id}","starred_url":"https://api.github.com/users/jkonecny12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkonecny12/subscriptions","organizations_url":"https://api.github.com/users/jkonecny12/orgs","repos_url":"https://api.github.com/users/jkonecny12/repos","events_url":"https://api.github.com/users/jkonecny12/events{/privacy}","received_events_url":"https://api.github.com/users/jkonecny12/received_events","type":"User","site_admin":false},"body":"When we reduce metadata from device size in space check we also\r\nneed to tell user how much space he needs on root to get installation\r\ndone. That means we need to add metadata in count when calculating this\r\nspace deficit.\r\n\r\nI need this PR: https://github.com/rhinstaller/blivet/pull/255 in blivet to make this work.","created_at":"2015-10-23T14:13:49Z","updated_at":"2015-10-26T09:06:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c0db3dba466b2eca029ea53b753ae662331b5f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/424/comments","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/f7582ee3262c910d529165891f067537e52de781","head":{"label":"jkonecny12:master-fix-space-needed","ref":"master-fix-space-needed","sha":"f7582ee3262c910d529165891f067537e52de781","user":{"login":"jkonecny12","id":1643889,"avatar_url":"https://avatars.githubusercontent.com/u/1643889?v=3","gravatar_id":"","url":"https://api.github.com/users/jkonecny12","html_url":"https://github.com/jkonecny12","followers_url":"https://api.github.com/users/jkonecny12/followers","following_url":"https://api.github.com/users/jkonecny12/following{/other_user}","gists_url":"https://api.github.com/users/jkonecny12/gists{/gist_id}","starred_url":"https://api.github.com/users/jkonecny12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkonecny12/subscriptions","organizations_url":"https://api.github.com/users/jkonecny12/orgs","repos_url":"https://api.github.com/users/jkonecny12/repos","events_url":"https://api.github.com/users/jkonecny12/events{/privacy}","received_events_url":"https://api.github.com/users/jkonecny12/received_events","type":"User","site_admin":false},"repo":{"id":32858900,"name":"anaconda","full_name":"jkonecny12/anaconda","owner":{"login":"jkonecny12","id":1643889,"avatar_url":"https://avatars.githubusercontent.com/u/1643889?v=3","gravatar_id":"","url":"https://api.github.com/users/jkonecny12","html_url":"https://github.com/jkonecny12","followers_url":"https://api.github.com/users/jkonecny12/followers","following_url":"https://api.github.com/users/jkonecny12/following{/other_user}","gists_url":"https://api.github.com/users/jkonecny12/gists{/gist_id}","starred_url":"https://api.github.com/users/jkonecny12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkonecny12/subscriptions","organizations_url":"https://api.github.com/users/jkonecny12/orgs","repos_url":"https://api.github.com/users/jkonecny12/repos","events_url":"https://api.github.com/users/jkonecny12/events{/privacy}","received_events_url":"https://api.github.com/users/jkonecny12/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkonecny12/anaconda","description":"Graphical system installer","fork":true,"url":"https://api.github.com/repos/jkonecny12/anaconda","forks_url":"https://api.github.com/repos/jkonecny12/anaconda/forks","keys_url":"https://api.github.com/repos/jkonecny12/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkonecny12/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkonecny12/anaconda/teams","hooks_url":"https://api.github.com/repos/jkonecny12/anaconda/hooks","issue_events_url":"https://api.github.com/repos/jkonecny12/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/jkonecny12/anaconda/events","assignees_url":"https://api.github.com/repos/jkonecny12/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/jkonecny12/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/jkonecny12/anaconda/tags","blobs_url":"https://api.github.com/repos/jkonecny12/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkonecny12/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkonecny12/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkonecny12/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkonecny12/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/jkonecny12/anaconda/languages","stargazers_url":"https://api.github.com/repos/jkonecny12/anaconda/stargazers","contributors_url":"https://api.github.com/repos/jkonecny12/anaconda/contributors","subscribers_url":"https://api.github.com/repos/jkonecny12/anaconda/subscribers","subscription_url":"https://api.github.com/repos/jkonecny12/anaconda/subscription","commits_url":"https://api.github.com/repos/jkonecny12/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkonecny12/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkonecny12/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkonecny12/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkonecny12/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/jkonecny12/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkonecny12/anaconda/merges","archive_url":"https://api.github.com/repos/jkonecny12/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkonecny12/anaconda/downloads","issues_url":"https://api.github.com/repos/jkonecny12/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/jkonecny12/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/jkonecny12/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/jkonecny12/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkonecny12/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/jkonecny12/anaconda/releases{/id}","created_at":"2015-03-25T10:54:16Z","updated_at":"2015-05-06T12:43:59Z","pushed_at":"2015-10-23T14:11:38Z","git_url":"git://github.com/jkonecny12/anaconda.git","ssh_url":"git@github.com:jkonecny12/anaconda.git","clone_url":"https://github.com/jkonecny12/anaconda.git","svn_url":"https://github.com/jkonecny12/anaconda","homepage":null,"size":128179,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:master","ref":"master","sha":"d1450b50943ac5099e2315cce410230f7ed0b3b4","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":30210846,"name":"anaconda","full_name":"rhinstaller/anaconda","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/anaconda","description":"Graphical system installer","fork":false,"url":"https://api.github.com/repos/rhinstaller/anaconda","forks_url":"https://api.github.com/repos/rhinstaller/anaconda/forks","keys_url":"https://api.github.com/repos/rhinstaller/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/anaconda/teams","hooks_url":"https://api.github.com/repos/rhinstaller/anaconda/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/anaconda/events","assignees_url":"https://api.github.com/repos/rhinstaller/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/anaconda/tags","blobs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/anaconda/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/anaconda/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/anaconda/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/anaconda/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/anaconda/subscription","commits_url":"https://api.github.com/repos/rhinstaller/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/anaconda/merges","archive_url":"https://api.github.com/repos/rhinstaller/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/anaconda/downloads","issues_url":"https://api.github.com/repos/rhinstaller/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/anaconda/releases{/id}","created_at":"2015-02-02T21:56:45Z","updated_at":"2015-10-22T19:08:04Z","pushed_at":"2015-10-25T13:17:31Z","git_url":"git://github.com/rhinstaller/anaconda.git","ssh_url":"git@github.com:rhinstaller/anaconda.git","clone_url":"https://github.com/rhinstaller/anaconda.git","svn_url":"https://github.com/rhinstaller/anaconda","homepage":null,"size":167471,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":31,"forks":45,"open_issues":31,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/424"},"issue":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/424"},"comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/anaconda/statuses/f7582ee3262c910d529165891f067537e52de781"}}}}