{"action":"created","issue":{"url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/10","labels_url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/10/comments","events_url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/10/events","html_url":"https://github.com/respoke/node-respoke-admin/pull/10","id":113600386,"number":10,"title":"Fix settings on socket.io to use defaults and reuse the existing connection","user":{"login":"ruffrey","id":1668190,"avatar_url":"https://avatars.githubusercontent.com/u/1668190?v=3","gravatar_id":"","url":"https://api.github.com/users/ruffrey","html_url":"https://github.com/ruffrey","followers_url":"https://api.github.com/users/ruffrey/followers","following_url":"https://api.github.com/users/ruffrey/following{/other_user}","gists_url":"https://api.github.com/users/ruffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ruffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruffrey/subscriptions","organizations_url":"https://api.github.com/users/ruffrey/orgs","repos_url":"https://api.github.com/users/ruffrey/repos","events_url":"https://api.github.com/users/ruffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ruffrey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-27T14:43:18Z","updated_at":"2015-10-27T14:52:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/respoke/node-respoke-admin/pulls/10","html_url":"https://github.com/respoke/node-respoke-admin/pull/10","diff_url":"https://github.com/respoke/node-respoke-admin/pull/10.diff","patch_url":"https://github.com/respoke/node-respoke-admin/pull/10.patch"},"body":"MER-4413\r\n\r\n1. We should honor the connection timeout that the server sets. This was probably getting out of sync where the client was disconnecting or thought it was disconnected, so created a new connection, but the server (may have) kept the connection longer.\r\n2. `sync disconnect on unload` only applies to the browser\r\n3. Reuse the connection object instead of instantiating a new one. I am unsure why we opted to do this but it was almost certainly the source of the crash we've been seeing:\r\n\r\n```\r\nUncaught exception\r\n    TypeError: Cannot call method 'onClose' of null\r\n        at [object Object]._onTimeout (/Users/jeffparrish/apollo/node_modules/respoke-admin/node_modules/socket.io-client/lib/socket.js:281:22)\r\n        at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)\r\n```\r\n\r\nI was able to produce the crash before making the changes, and unable to produce it after, even doing many network disconnect and VPN cycles."},"comment":{"url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/comments/151528331","html_url":"https://github.com/respoke/node-respoke-admin/pull/10#issuecomment-151528331","issue_url":"https://api.github.com/repos/respoke/node-respoke-admin/issues/10","id":151528331,"user":{"login":"leedm777","id":133579,"avatar_url":"https://avatars.githubusercontent.com/u/133579?v=3","gravatar_id":"","url":"https://api.github.com/users/leedm777","html_url":"https://github.com/leedm777","followers_url":"https://api.github.com/users/leedm777/followers","following_url":"https://api.github.com/users/leedm777/following{/other_user}","gists_url":"https://api.github.com/users/leedm777/gists{/gist_id}","starred_url":"https://api.github.com/users/leedm777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leedm777/subscriptions","organizations_url":"https://api.github.com/users/leedm777/orgs","repos_url":"https://api.github.com/users/leedm777/repos","events_url":"https://api.github.com/users/leedm777/events{/privacy}","received_events_url":"https://api.github.com/users/leedm777/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T14:52:03Z","updated_at":"2015-10-27T14:52:03Z","body":"@ruffrey re: failing tests, I think that's because there's encrypted data (the app secret) that the fork can't access."}}