{"action":"created","issue":{"url":"https://api.github.com/repos/davisking/dlib/issues/4","labels_url":"https://api.github.com/repos/davisking/dlib/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/davisking/dlib/issues/4/comments","events_url":"https://api.github.com/repos/davisking/dlib/issues/4/events","html_url":"https://github.com/davisking/dlib/pull/4","id":53314187,"number":4,"title":"Adding Python-binding for find_candidate_object_locations","user":{"login":"vinhkhuc","id":914887,"avatar_url":"https://avatars.githubusercontent.com/u/914887?v=3","gravatar_id":"","url":"https://api.github.com/users/vinhkhuc","html_url":"https://github.com/vinhkhuc","followers_url":"https://api.github.com/users/vinhkhuc/followers","following_url":"https://api.github.com/users/vinhkhuc/following{/other_user}","gists_url":"https://api.github.com/users/vinhkhuc/gists{/gist_id}","starred_url":"https://api.github.com/users/vinhkhuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinhkhuc/subscriptions","organizations_url":"https://api.github.com/users/vinhkhuc/orgs","repos_url":"https://api.github.com/users/vinhkhuc/repos","events_url":"https://api.github.com/users/vinhkhuc/events{/privacy}","received_events_url":"https://api.github.com/users/vinhkhuc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-03T20:17:06Z","updated_at":"2015-01-04T04:38:06Z","closed_at":"2015-01-04T04:36:30Z","pull_request":{"url":"https://api.github.com/repos/davisking/dlib/pulls/4","html_url":"https://github.com/davisking/dlib/pull/4","diff_url":"https://github.com/davisking/dlib/pull/4.diff","patch_url":"https://github.com/davisking/dlib/pull/4.patch"},"body":"Hi Davis,\r\nThis PR is for adding find_candidate_object_locations() to dlib's Python API. An example of how to use it is also included. There are a couple of things that I'd like to mention:\r\n\r\n1) As shown in the comment, pykvals in the Python API is different from kvals in the C++ code. pykvals is actually a Python tuple (start, end, num) for linspace(start, end, num). I'm not sure whether dlib provides a Python object for matrix_range_exp.\r\n\r\n2) Locations of candidate objects (rects) should be the result of find_candidate_object_locations_py() rather than its argument. However, I think it's better to be consistent with dlib's C++ API.\r\n\r\nPlease take a look and let me know whether I need to change something.\r\nThanks."},"comment":{"url":"https://api.github.com/repos/davisking/dlib/issues/comments/68620820","html_url":"https://github.com/davisking/dlib/pull/4#issuecomment-68620820","issue_url":"https://api.github.com/repos/davisking/dlib/issues/4","id":68620820,"user":{"login":"davisking","id":6259399,"avatar_url":"https://avatars.githubusercontent.com/u/6259399?v=3","gravatar_id":"","url":"https://api.github.com/users/davisking","html_url":"https://github.com/davisking","followers_url":"https://api.github.com/users/davisking/followers","following_url":"https://api.github.com/users/davisking/following{/other_user}","gists_url":"https://api.github.com/users/davisking/gists{/gist_id}","starred_url":"https://api.github.com/users/davisking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davisking/subscriptions","organizations_url":"https://api.github.com/users/davisking/orgs","repos_url":"https://api.github.com/users/davisking/repos","events_url":"https://api.github.com/users/davisking/events{/privacy}","received_events_url":"https://api.github.com/users/davisking/received_events","type":"User","site_admin":false},"created_at":"2015-01-04T04:38:06Z","updated_at":"2015-01-04T04:38:06Z","body":"That's great, thanks for the patch.  I just merged it in."}}