{"action":"created","comment":{"url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/comments/48087972","id":48087972,"diff_hunk":"@@ -22,7 +22,106 @@ def verify_same_docs(expected_num_docs, doc_dict_one, doc_dict_two):\n     print(\" -> doc_dict_one == doc_dict_two expected (num_docs: {})\".format(expected_num_docs))\n \n \n-def verify_changes(users, expected_num_docs, expected_num_revisions, expected_docs):\n+def verify_docs_removed(users, expected_num_docs, expected_docs):","path":"lib/verify.py","position":5,"original_position":5,"commit_id":"9dafa9db60de07ac8ebd41775f061676670b53b9","original_commit_id":"9dafa9db60de07ac8ebd41775f061676670b53b9","user":{"login":"ashvindersingh","id":2374160,"avatar_url":"https://avatars.githubusercontent.com/u/2374160?v=3","gravatar_id":"","url":"https://api.github.com/users/ashvindersingh","html_url":"https://github.com/ashvindersingh","followers_url":"https://api.github.com/users/ashvindersingh/followers","following_url":"https://api.github.com/users/ashvindersingh/following{/other_user}","gists_url":"https://api.github.com/users/ashvindersingh/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvindersingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvindersingh/subscriptions","organizations_url":"https://api.github.com/users/ashvindersingh/orgs","repos_url":"https://api.github.com/users/ashvindersingh/repos","events_url":"https://api.github.com/users/ashvindersingh/events{/privacy}","received_events_url":"https://api.github.com/users/ashvindersingh/received_events","type":"User","site_admin":false},"body":"this function should verify that tombstone revision doesn't change after the doc has been marked deleted. ","created_at":"2015-12-19T02:54:06Z","updated_at":"2015-12-19T02:54:06Z","html_url":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67#discussion_r48087972","pull_request_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/comments/48087972"},"html":{"href":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67#discussion_r48087972"},"pull_request":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67","id":52458064,"html_url":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67","diff_url":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67.diff","patch_url":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67.patch","issue_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/67","number":67,"state":"open","locked":false,"title":"Sync sanity scenarios","user":{"login":"sethrosetter","id":1365736,"avatar_url":"https://avatars.githubusercontent.com/u/1365736?v=3","gravatar_id":"","url":"https://api.github.com/users/sethrosetter","html_url":"https://github.com/sethrosetter","followers_url":"https://api.github.com/users/sethrosetter/followers","following_url":"https://api.github.com/users/sethrosetter/following{/other_user}","gists_url":"https://api.github.com/users/sethrosetter/gists{/gist_id}","starred_url":"https://api.github.com/users/sethrosetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethrosetter/subscriptions","organizations_url":"https://api.github.com/users/sethrosetter/orgs","repos_url":"https://api.github.com/users/sethrosetter/repos","events_url":"https://api.github.com/users/sethrosetter/events{/privacy}","received_events_url":"https://api.github.com/users/sethrosetter/received_events","type":"User","site_admin":false},"body":"- Add sanity test for access() in sync function\r\n- Add sanity test for channel() in sync function\r\n- Add sanity test for role() in sync function\r\n- Add requireRoles() sanity test\r\n- Add ignore_rev_ids=False to verify changes. This is to ignore rev_id checking for the situation where the user verify their changes includes doc that they did not create or update\r\n- Add verify_docs_removed function (Needs REVIEW) to check a users changes feed that had documents in channels that were changed","created_at":"2015-12-02T21:39:14Z","updated_at":"2015-12-19T02:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef6914557c27d30c3a44e17abc9891407eb1fdf8","assignee":{"login":"ashvindersingh","id":2374160,"avatar_url":"https://avatars.githubusercontent.com/u/2374160?v=3","gravatar_id":"","url":"https://api.github.com/users/ashvindersingh","html_url":"https://github.com/ashvindersingh","followers_url":"https://api.github.com/users/ashvindersingh/followers","following_url":"https://api.github.com/users/ashvindersingh/following{/other_user}","gists_url":"https://api.github.com/users/ashvindersingh/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvindersingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvindersingh/subscriptions","organizations_url":"https://api.github.com/users/ashvindersingh/orgs","repos_url":"https://api.github.com/users/ashvindersingh/repos","events_url":"https://api.github.com/users/ashvindersingh/events{/privacy}","received_events_url":"https://api.github.com/users/ashvindersingh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67/commits","review_comments_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67/comments","review_comment_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/67/comments","statuses_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/statuses/9dafa9db60de07ac8ebd41775f061676670b53b9","head":{"label":"couchbaselabs:require-user-sync","ref":"require-user-sync","sha":"9dafa9db60de07ac8ebd41775f061676670b53b9","user":{"login":"couchbaselabs","id":636956,"avatar_url":"https://avatars.githubusercontent.com/u/636956?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbaselabs","html_url":"https://github.com/couchbaselabs","followers_url":"https://api.github.com/users/couchbaselabs/followers","following_url":"https://api.github.com/users/couchbaselabs/following{/other_user}","gists_url":"https://api.github.com/users/couchbaselabs/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbaselabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbaselabs/subscriptions","organizations_url":"https://api.github.com/users/couchbaselabs/orgs","repos_url":"https://api.github.com/users/couchbaselabs/repos","events_url":"https://api.github.com/users/couchbaselabs/events{/privacy}","received_events_url":"https://api.github.com/users/couchbaselabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45864773,"name":"sync-gateway-testcluster","full_name":"couchbaselabs/sync-gateway-testcluster","owner":{"login":"couchbaselabs","id":636956,"avatar_url":"https://avatars.githubusercontent.com/u/636956?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbaselabs","html_url":"https://github.com/couchbaselabs","followers_url":"https://api.github.com/users/couchbaselabs/followers","following_url":"https://api.github.com/users/couchbaselabs/following{/other_user}","gists_url":"https://api.github.com/users/couchbaselabs/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbaselabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbaselabs/subscriptions","organizations_url":"https://api.github.com/users/couchbaselabs/orgs","repos_url":"https://api.github.com/users/couchbaselabs/repos","events_url":"https://api.github.com/users/couchbaselabs/events{/privacy}","received_events_url":"https://api.github.com/users/couchbaselabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbaselabs/sync-gateway-testcluster","description":"Setup a Sync Gateway + Couchbase Server test cluster for functional and performance testing purposes ","fork":false,"url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster","forks_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/forks","keys_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/teams","hooks_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/hooks","issue_events_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/events{/number}","events_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/events","assignees_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/assignees{/user}","branches_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/branches{/branch}","tags_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/tags","blobs_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/languages","stargazers_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/stargazers","contributors_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/contributors","subscribers_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/subscribers","subscription_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/subscription","commits_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/contents/{+path}","compare_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/merges","archive_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/downloads","issues_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues{/number}","pulls_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/labels{/name}","releases_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/releases{/id}","created_at":"2015-11-09T20:28:01Z","updated_at":"2015-11-09T20:28:43Z","pushed_at":"2015-12-19T02:29:10Z","git_url":"git://github.com/couchbaselabs/sync-gateway-testcluster.git","ssh_url":"git@github.com:couchbaselabs/sync-gateway-testcluster.git","clone_url":"https://github.com/couchbaselabs/sync-gateway-testcluster.git","svn_url":"https://github.com/couchbaselabs/sync-gateway-testcluster","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":70,"forks":0,"open_issues":70,"watchers":0,"default_branch":"master"}},"base":{"label":"couchbaselabs:master","ref":"master","sha":"55ef9f3ccb5370b6b394a5ededc6b983eb75abb6","user":{"login":"couchbaselabs","id":636956,"avatar_url":"https://avatars.githubusercontent.com/u/636956?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbaselabs","html_url":"https://github.com/couchbaselabs","followers_url":"https://api.github.com/users/couchbaselabs/followers","following_url":"https://api.github.com/users/couchbaselabs/following{/other_user}","gists_url":"https://api.github.com/users/couchbaselabs/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbaselabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbaselabs/subscriptions","organizations_url":"https://api.github.com/users/couchbaselabs/orgs","repos_url":"https://api.github.com/users/couchbaselabs/repos","events_url":"https://api.github.com/users/couchbaselabs/events{/privacy}","received_events_url":"https://api.github.com/users/couchbaselabs/received_events","type":"Organization","site_admin":false},"repo":{"id":45864773,"name":"sync-gateway-testcluster","full_name":"couchbaselabs/sync-gateway-testcluster","owner":{"login":"couchbaselabs","id":636956,"avatar_url":"https://avatars.githubusercontent.com/u/636956?v=3","gravatar_id":"","url":"https://api.github.com/users/couchbaselabs","html_url":"https://github.com/couchbaselabs","followers_url":"https://api.github.com/users/couchbaselabs/followers","following_url":"https://api.github.com/users/couchbaselabs/following{/other_user}","gists_url":"https://api.github.com/users/couchbaselabs/gists{/gist_id}","starred_url":"https://api.github.com/users/couchbaselabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couchbaselabs/subscriptions","organizations_url":"https://api.github.com/users/couchbaselabs/orgs","repos_url":"https://api.github.com/users/couchbaselabs/repos","events_url":"https://api.github.com/users/couchbaselabs/events{/privacy}","received_events_url":"https://api.github.com/users/couchbaselabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/couchbaselabs/sync-gateway-testcluster","description":"Setup a Sync Gateway + Couchbase Server test cluster for functional and performance testing purposes ","fork":false,"url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster","forks_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/forks","keys_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/teams","hooks_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/hooks","issue_events_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/events{/number}","events_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/events","assignees_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/assignees{/user}","branches_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/branches{/branch}","tags_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/tags","blobs_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/languages","stargazers_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/stargazers","contributors_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/contributors","subscribers_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/subscribers","subscription_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/subscription","commits_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/contents/{+path}","compare_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/merges","archive_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/downloads","issues_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues{/number}","pulls_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/labels{/name}","releases_url":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/releases{/id}","created_at":"2015-11-09T20:28:01Z","updated_at":"2015-11-09T20:28:43Z","pushed_at":"2015-12-19T02:29:10Z","git_url":"git://github.com/couchbaselabs/sync-gateway-testcluster.git","ssh_url":"git@github.com:couchbaselabs/sync-gateway-testcluster.git","clone_url":"https://github.com/couchbaselabs/sync-gateway-testcluster.git","svn_url":"https://github.com/couchbaselabs/sync-gateway-testcluster","homepage":null,"size":343,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":70,"forks":0,"open_issues":70,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67"},"html":{"href":"https://github.com/couchbaselabs/sync-gateway-testcluster/pull/67"},"issue":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/67"},"comments":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/couchbaselabs/sync-gateway-testcluster/statuses/9dafa9db60de07ac8ebd41775f061676670b53b9"}}}}