{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/606","labels_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/606/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/606/comments","events_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/606/events","html_url":"https://github.com/dotnet/roslyn-analyzers/pull/606","id":118726318,"number":606,"title":"Tolerate non-source locations in DiagnosticExtensions","user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars.githubusercontent.com/u/75470?v=3","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-24T23:31:14Z","updated_at":"2015-11-25T01:12:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/pulls/606","html_url":"https://github.com/dotnet/roslyn-analyzers/pull/606","diff_url":"https://github.com/dotnet/roslyn-analyzers/pull/606.diff","patch_url":"https://github.com/dotnet/roslyn-analyzers/pull/606.patch"},"body":"We're experimenting with running symbol analysis against binaries and there were a couple of places in analyzer helpers that were assuming there was always a source location, which would cause some rules to crash just as they were reporting a diagnostic.\r\n\r\nI've followed the precedent set by `CreateDiagnostic(Location, DiagnosticDescriptor, object[])` which coerces the location to null when it's not in source and done the same when the `IEnumerable<Location>` variant gets a sequence where none of the locations are in source. We probably want to think about letting metadata locations through, but I'm starting with the least invasive change.\r\n\r\nI'm also curious why there are two very similar files in the repo and if there are plans to consolidate them.\r\n\r\n@srivatsn @michaelcfanning "},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/comments/159454019","html_url":"https://github.com/dotnet/roslyn-analyzers/pull/606#issuecomment-159454019","issue_url":"https://api.github.com/repos/dotnet/roslyn-analyzers/issues/606","id":159454019,"user":{"login":"nguerrera","id":75470,"avatar_url":"https://avatars.githubusercontent.com/u/75470?v=3","gravatar_id":"","url":"https://api.github.com/users/nguerrera","html_url":"https://github.com/nguerrera","followers_url":"https://api.github.com/users/nguerrera/followers","following_url":"https://api.github.com/users/nguerrera/following{/other_user}","gists_url":"https://api.github.com/users/nguerrera/gists{/gist_id}","starred_url":"https://api.github.com/users/nguerrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguerrera/subscriptions","organizations_url":"https://api.github.com/users/nguerrera/orgs","repos_url":"https://api.github.com/users/nguerrera/repos","events_url":"https://api.github.com/users/nguerrera/events{/privacy}","received_events_url":"https://api.github.com/users/nguerrera/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T01:12:52Z","updated_at":"2015-11-25T01:12:52Z","body":"@srivatsn I see. Should I make this change in the FxCop branch then to avoid merge conflicts?"}}