{"action":"created","issue":{"url":"https://api.github.com/repos/webcompat/webcompat.com/issues/712","labels_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/712/labels{/name}","comments_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/712/comments","events_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/712/events","html_url":"https://github.com/webcompat/webcompat.com/issues/712","id":108636159,"number":712,"title":"Mocking the GitHub communications for functional tests","user":{"login":"karlcow","id":505230,"avatar_url":"https://avatars.githubusercontent.com/u/505230?v=3","gravatar_id":"","url":"https://api.github.com/users/karlcow","html_url":"https://github.com/karlcow","followers_url":"https://api.github.com/users/karlcow/followers","following_url":"https://api.github.com/users/karlcow/following{/other_user}","gists_url":"https://api.github.com/users/karlcow/gists{/gist_id}","starred_url":"https://api.github.com/users/karlcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlcow/subscriptions","organizations_url":"https://api.github.com/users/karlcow/orgs","repos_url":"https://api.github.com/users/karlcow/repos","events_url":"https://api.github.com/users/karlcow/events{/privacy}","received_events_url":"https://api.github.com/users/karlcow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/webcompat/webcompat.com/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/webcompat/webcompat.com/labels/site-development","name":"site-development","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"miketaylr","id":67283,"avatar_url":"https://avatars.githubusercontent.com/u/67283?v=3","gravatar_id":"","url":"https://api.github.com/users/miketaylr","html_url":"https://github.com/miketaylr","followers_url":"https://api.github.com/users/miketaylr/followers","following_url":"https://api.github.com/users/miketaylr/following{/other_user}","gists_url":"https://api.github.com/users/miketaylr/gists{/gist_id}","starred_url":"https://api.github.com/users/miketaylr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miketaylr/subscriptions","organizations_url":"https://api.github.com/users/miketaylr/orgs","repos_url":"https://api.github.com/users/miketaylr/repos","events_url":"https://api.github.com/users/miketaylr/events{/privacy}","received_events_url":"https://api.github.com/users/miketaylr/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/webcompat/webcompat.com/milestones/28","html_url":"https://github.com/webcompat/webcompat.com/milestones/Paris%20Meeting%20September%202015","labels_url":"https://api.github.com/repos/webcompat/webcompat.com/milestones/28/labels","id":1326576,"number":28,"title":"Paris Meeting September 2015","description":null,"creator":{"login":"karlcow","id":505230,"avatar_url":"https://avatars.githubusercontent.com/u/505230?v=3","gravatar_id":"","url":"https://api.github.com/users/karlcow","html_url":"https://github.com/karlcow","followers_url":"https://api.github.com/users/karlcow/followers","following_url":"https://api.github.com/users/karlcow/following{/other_user}","gists_url":"https://api.github.com/users/karlcow/gists{/gist_id}","starred_url":"https://api.github.com/users/karlcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlcow/subscriptions","organizations_url":"https://api.github.com/users/karlcow/orgs","repos_url":"https://api.github.com/users/karlcow/repos","events_url":"https://api.github.com/users/karlcow/events{/privacy}","received_events_url":"https://api.github.com/users/karlcow/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":24,"state":"open","created_at":"2015-09-28T11:04:11Z","updated_at":"2015-10-09T11:43:15Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2015-09-28T11:03:47Z","updated_at":"2015-10-13T17:23:39Z","closed_at":null,"body":"When we are testing the UI with intern, we want to make sure that the UI reacts accordingly to what we want of the user experience. Right now, the tests are dependent of Github communication but it's not necessary most of the time for the suer experience. Communications issues in between webcompat and github have to be dealt with elsewhere. \r\n\r\n1. Mock all response from Github to WebCompat in intern (when possible)\r\n\r\nThere is two features which are currently directly talking to Github. \r\n* search everywhere (in progress)\r\n* load search results from URI bar\r\n\r\ndecided in Paris september 2015 at webcompat meeting  with @miketaylr "},"comment":{"url":"https://api.github.com/repos/webcompat/webcompat.com/issues/comments/147783788","html_url":"https://github.com/webcompat/webcompat.com/issues/712#issuecomment-147783788","issue_url":"https://api.github.com/repos/webcompat/webcompat.com/issues/712","id":147783788,"user":{"login":"miketaylr","id":67283,"avatar_url":"https://avatars.githubusercontent.com/u/67283?v=3","gravatar_id":"","url":"https://api.github.com/users/miketaylr","html_url":"https://github.com/miketaylr","followers_url":"https://api.github.com/users/miketaylr/followers","following_url":"https://api.github.com/users/miketaylr/following{/other_user}","gists_url":"https://api.github.com/users/miketaylr/gists{/gist_id}","starred_url":"https://api.github.com/users/miketaylr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miketaylr/subscriptions","organizations_url":"https://api.github.com/users/miketaylr/orgs","repos_url":"https://api.github.com/users/miketaylr/repos","events_url":"https://api.github.com/users/miketaylr/events{/privacy}","received_events_url":"https://api.github.com/users/miketaylr/received_events","type":"User","site_admin":false},"created_at":"2015-10-13T17:23:39Z","updated_at":"2015-10-13T17:23:39Z","body":"OK, I spent a few hours down the rabbit hole and am now opting for #1. ^_^\r\n\r\nThe tests that fail are the ones testing error situations--they don't even request data from GitHub. So it's a non-issue. If we do `webcompat.app.config['TESTING'] = False` in the test `setUp`, the @mockable_response` decorator won't have any effect."}}