{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/46011342","id":46011342,"diff_hunk":"@@ -230,13 +230,15 @@ export default ChartComponent.extend(FloatingTooltipMixin,\n     };\n   }),\n \n-  valueLabelAttrs: Ember.computed('xScale', 'barThickness', 'labelPadding', function() {\n+  valueLabelAttrs: Ember.computed('xScale', 'barThickness', 'labelPadding', 'hasNegativeValues', 'hasPositiveValues', function() {","path":"addon/components/horizontal-bar-chart.js","position":5,"original_position":5,"commit_id":"018ca1f61de122f1c563491b15d4f78cc2baad9c","original_commit_id":"018ca1f61de122f1c563491b15d4f78cc2baad9c","user":{"login":"xudaniel11work","id":14004102,"avatar_url":"https://avatars.githubusercontent.com/u/14004102?v=3","gravatar_id":"","url":"https://api.github.com/users/xudaniel11work","html_url":"https://github.com/xudaniel11work","followers_url":"https://api.github.com/users/xudaniel11work/followers","following_url":"https://api.github.com/users/xudaniel11work/following{/other_user}","gists_url":"https://api.github.com/users/xudaniel11work/gists{/gist_id}","starred_url":"https://api.github.com/users/xudaniel11work/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xudaniel11work/subscriptions","organizations_url":"https://api.github.com/users/xudaniel11work/orgs","repos_url":"https://api.github.com/users/xudaniel11work/repos","events_url":"https://api.github.com/users/xudaniel11work/events{/privacy}","received_events_url":"https://api.github.com/users/xudaniel11work/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2015-11-27T00:30:20Z","updated_at":"2015-11-27T00:30:20Z","html_url":"https://github.com/Addepar/ember-charts/pull/136#discussion_r46011342","pull_request_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments/46011342"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/136#discussion_r46011342"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-charts/pulls/136","id":51951156,"html_url":"https://github.com/Addepar/ember-charts/pull/136","diff_url":"https://github.com/Addepar/ember-charts/pull/136.diff","patch_url":"https://github.com/Addepar/ember-charts/pull/136.patch","issue_url":"https://api.github.com/repos/Addepar/ember-charts/issues/136","number":136,"state":"open","locked":false,"title":"Daniel/horizontal bar negative value labels","user":{"login":"xudaniel11work","id":14004102,"avatar_url":"https://avatars.githubusercontent.com/u/14004102?v=3","gravatar_id":"","url":"https://api.github.com/users/xudaniel11work","html_url":"https://github.com/xudaniel11work","followers_url":"https://api.github.com/users/xudaniel11work/followers","following_url":"https://api.github.com/users/xudaniel11work/following{/other_user}","gists_url":"https://api.github.com/users/xudaniel11work/gists{/gist_id}","starred_url":"https://api.github.com/users/xudaniel11work/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xudaniel11work/subscriptions","organizations_url":"https://api.github.com/users/xudaniel11work/orgs","repos_url":"https://api.github.com/users/xudaniel11work/repos","events_url":"https://api.github.com/users/xudaniel11work/events{/privacy}","received_events_url":"https://api.github.com/users/xudaniel11work/received_events","type":"User","site_admin":false},"body":"When a horizontal bar chart has all data less than or equal to zero, all grouping labels should be on the right and all value labels should be on the left. However, all rows with data = 0 used to have grouping labels on the left and value labels on the right. The PR fixes this pre-existing bug. \r\n\r\n@Addepar/fire , @philpee2 , @jordansmith42 \r\n\r\nBefore Change: Note that Label 1 and Label 6 are on the left instead of right when all data is <= 0\r\n<img width=\"711\" alt=\"screenshot 2015-11-26 15 42 02\" src=\"https://cloud.githubusercontent.com/assets/14004102/11431890/80c78dbc-9456-11e5-9d97-44985e1d5d75.png\">\r\n\r\nAfter Change: Note that Label 1 and Label 6 are with the rest of the labels when all data is <= 0\r\n<img width=\"707\" alt=\"screenshot 2015-11-26 15 45 39\" src=\"https://cloud.githubusercontent.com/assets/14004102/11431891/860ab876-9456-11e5-8e2e-9512b48eee39.png\">\r\n\r\nSame as before: For mixes of positive and negative data, rows with value of 0 will have the grouping label on the left and the value label on the right.\r\n<img width=\"709\" alt=\"screenshot 2015-11-26 15 54 50\" src=\"https://cloud.githubusercontent.com/assets/14004102/11431896/c7a44e28-9456-11e5-87a9-b66d6e6ebabb.png\">","created_at":"2015-11-27T00:02:12Z","updated_at":"2015-11-27T00:30:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cdf517585e8a332081e3f754897503d428cb1e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/136/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/136/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/issues/136/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/018ca1f61de122f1c563491b15d4f78cc2baad9c","head":{"label":"Addepar:daniel/horizontal-bar-negative-value-labels","ref":"daniel/horizontal-bar-negative-value-labels","sha":"018ca1f61de122f1c563491b15d4f78cc2baad9c","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-25T05:18:17Z","pushed_at":"2015-11-27T00:02:12Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8841,"stargazers_count":669,"watchers_count":669,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":18,"forks":99,"open_issues":18,"watchers":669,"default_branch":"master"}},"base":{"label":"Addepar:master","ref":"master","sha":"0b327516b5073867c016b0ca0e4409a438be4c77","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13790555,"name":"ember-charts","full_name":"Addepar/ember-charts","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-charts","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-charts","forks_url":"https://api.github.com/repos/Addepar/ember-charts/forks","keys_url":"https://api.github.com/repos/Addepar/ember-charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-charts/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-charts/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-charts/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-charts/events","assignees_url":"https://api.github.com/repos/Addepar/ember-charts/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-charts/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-charts/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-charts/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-charts/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-charts/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-charts/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-charts/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-charts/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Addepar/ember-charts/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-charts/merges","archive_url":"https://api.github.com/repos/Addepar/ember-charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-charts/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-charts/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-charts/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-charts/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-charts/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-charts/releases{/id}","created_at":"2013-10-23T01:27:05Z","updated_at":"2015-11-25T05:18:17Z","pushed_at":"2015-11-27T00:02:12Z","git_url":"git://github.com/Addepar/ember-charts.git","ssh_url":"git@github.com:Addepar/ember-charts.git","clone_url":"https://github.com/Addepar/ember-charts.git","svn_url":"https://github.com/Addepar/ember-charts","homepage":null,"size":8841,"stargazers_count":669,"watchers_count":669,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":18,"forks":99,"open_issues":18,"watchers":669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/136"},"html":{"href":"https://github.com/Addepar/ember-charts/pull/136"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/136"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-charts/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-charts/statuses/018ca1f61de122f1c563491b15d4f78cc2baad9c"}}}}