{"comment":{"url":"https://api.github.com/repos/splitrb/split/comments/14773273","html_url":"https://github.com/splitrb/split/commit/ff8fbff638797dd433550cfe57a302c19249d534#commitcomment-14773273","id":14773273,"user":{"login":"mcull","id":320219,"avatar_url":"https://avatars.githubusercontent.com/u/320219?v=3","gravatar_id":"","url":"https://api.github.com/users/mcull","html_url":"https://github.com/mcull","followers_url":"https://api.github.com/users/mcull/followers","following_url":"https://api.github.com/users/mcull/following{/other_user}","gists_url":"https://api.github.com/users/mcull/gists{/gist_id}","starred_url":"https://api.github.com/users/mcull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcull/subscriptions","organizations_url":"https://api.github.com/users/mcull/orgs","repos_url":"https://api.github.com/users/mcull/repos","events_url":"https://api.github.com/users/mcull/events{/privacy}","received_events_url":"https://api.github.com/users/mcull/received_events","type":"User","site_admin":false},"position":8,"line":67,"path":"lib/split/helper.rb","commit_id":"ff8fbff638797dd433550cfe57a302c19249d534","created_at":"2015-12-03T21:11:11Z","updated_at":"2015-12-03T21:11:11Z","body":"No, that would undo the performance gains and the point of passing in the alternatives in advance; the assumption is that any client that passes in the alternatives is explicitly trying to override the redis checks.   Not found in this case means it's genuinely not there--which is the case a lot of the time. (Think of experiments configured but off that a new user never got bickered into, or even ones that are on but the user hasn't been bucketed for, like sex toy margin exp or something. calling \"finish\" on a goal operates over all the experiments that have that goal, whether or not a user was assigned an alternative.).  \r\n\r\nSo...here, checking redis again will just again reveal that it's not there.  Think of the :alternatives hash as the result of calling ab_user[experimebt.key], but in batch, just a few cpu cycles ago. "}}