{"action":"created","comment":{"url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/46422722","id":46422722,"diff_hunk":"@@ -8,27 +8,25 @@\n   \"use strict\";\n \n   CKEDITOR.plugins.add('drupalentity', {\n-    // This plugin requires the Widgets System defined in the 'widget' plugin.\n     requires: 'widget',\n \n-    // The plugin initialization logic goes inside this method.\n     beforeInit: function (editor) {\n       // Configure CKEditor DTD for custom drupal-entity element.\n       // @see https://www.drupal.org/node/2448449#comment-9717735\n-      var dtd = CKEDITOR.dtd, tagName;\n-      dtd['drupal-entity'] = {'#': 1};\n-      // Register drupal-entity element as allowed child, in each tag that can\n-      // contain a div element.\n-      for (tagName in dtd) {\n-        if (dtd[tagName].div) {\n-          dtd[tagName]['drupal-entity'] = 1;\n-        }\n-      }\n-\n+      CKEDITOR.dtd['drupal-entity'] = {'#': 1};","path":"js/plugins/drupalentity/plugin.js","position":21,"original_position":21,"commit_id":"c812c803e88a785454fd61d215ee45929735c5b7","original_commit_id":"c812c803e88a785454fd61d215ee45929735c5b7","user":{"login":"mlewand","id":5353898,"avatar_url":"https://avatars.githubusercontent.com/u/5353898?v=3","gravatar_id":"","url":"https://api.github.com/users/mlewand","html_url":"https://github.com/mlewand","followers_url":"https://api.github.com/users/mlewand/followers","following_url":"https://api.github.com/users/mlewand/following{/other_user}","gists_url":"https://api.github.com/users/mlewand/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewand/subscriptions","organizations_url":"https://api.github.com/users/mlewand/orgs","repos_url":"https://api.github.com/users/mlewand/repos","events_url":"https://api.github.com/users/mlewand/events{/privacy}","received_events_url":"https://api.github.com/users/mlewand/received_events","type":"User","site_admin":false},"body":"As far as comments in Drupa tickets go, you also might want to nest `drupal-entity` elements, so you also need to change this line to:\r\n`CKEDITOR.dtd[ 'drupal-entity' ] = { '#': 1, 'drupal-entity': 1 };`","created_at":"2015-12-02T14:53:09Z","updated_at":"2015-12-02T14:53:09Z","html_url":"https://github.com/drupal-media/entity_embed/pull/179#discussion_r46422722","pull_request_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments/46422722"},"html":{"href":"https://github.com/drupal-media/entity_embed/pull/179#discussion_r46422722"},"pull_request":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179","id":44697672,"html_url":"https://github.com/drupal-media/entity_embed/pull/179","diff_url":"https://github.com/drupal-media/entity_embed/pull/179.diff","patch_url":"https://github.com/drupal-media/entity_embed/pull/179.patch","issue_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/179","number":179,"state":"open","locked":false,"title":"Update ckeditor plugin","user":{"login":"davereid","id":62967,"avatar_url":"https://avatars.githubusercontent.com/u/62967?v=3","gravatar_id":"","url":"https://api.github.com/users/davereid","html_url":"https://github.com/davereid","followers_url":"https://api.github.com/users/davereid/followers","following_url":"https://api.github.com/users/davereid/following{/other_user}","gists_url":"https://api.github.com/users/davereid/gists{/gist_id}","starred_url":"https://api.github.com/users/davereid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davereid/subscriptions","organizations_url":"https://api.github.com/users/davereid/orgs","repos_url":"https://api.github.com/users/davereid/repos","events_url":"https://api.github.com/users/davereid/events{/privacy}","received_events_url":"https://api.github.com/users/davereid/received_events","type":"User","site_admin":false},"body":"Trying to solve https://www.drupal.org/node/2554687","created_at":"2015-09-10T17:46:59Z","updated_at":"2015-12-02T14:53:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41ea063f2fa48f672eb9ae0b42ee063a8a60b144","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179/commits","review_comments_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179/comments","review_comment_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/179/comments","statuses_url":"https://api.github.com/repos/drupal-media/entity_embed/statuses/c812c803e88a785454fd61d215ee45929735c5b7","head":{"label":"drupal-media:fix-ckeditor-js","ref":"fix-ckeditor-js","sha":"c812c803e88a785454fd61d215ee45929735c5b7","user":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"repo":{"id":18717762,"name":"entity_embed","full_name":"drupal-media/entity_embed","owner":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupal-media/entity_embed","description":"Allows any entity to be embedded using a WYSIWYG and text format.","fork":false,"url":"https://api.github.com/repos/drupal-media/entity_embed","forks_url":"https://api.github.com/repos/drupal-media/entity_embed/forks","keys_url":"https://api.github.com/repos/drupal-media/entity_embed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupal-media/entity_embed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupal-media/entity_embed/teams","hooks_url":"https://api.github.com/repos/drupal-media/entity_embed/hooks","issue_events_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/events{/number}","events_url":"https://api.github.com/repos/drupal-media/entity_embed/events","assignees_url":"https://api.github.com/repos/drupal-media/entity_embed/assignees{/user}","branches_url":"https://api.github.com/repos/drupal-media/entity_embed/branches{/branch}","tags_url":"https://api.github.com/repos/drupal-media/entity_embed/tags","blobs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupal-media/entity_embed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupal-media/entity_embed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupal-media/entity_embed/statuses/{sha}","languages_url":"https://api.github.com/repos/drupal-media/entity_embed/languages","stargazers_url":"https://api.github.com/repos/drupal-media/entity_embed/stargazers","contributors_url":"https://api.github.com/repos/drupal-media/entity_embed/contributors","subscribers_url":"https://api.github.com/repos/drupal-media/entity_embed/subscribers","subscription_url":"https://api.github.com/repos/drupal-media/entity_embed/subscription","commits_url":"https://api.github.com/repos/drupal-media/entity_embed/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupal-media/entity_embed/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupal-media/entity_embed/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupal-media/entity_embed/contents/{+path}","compare_url":"https://api.github.com/repos/drupal-media/entity_embed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupal-media/entity_embed/merges","archive_url":"https://api.github.com/repos/drupal-media/entity_embed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupal-media/entity_embed/downloads","issues_url":"https://api.github.com/repos/drupal-media/entity_embed/issues{/number}","pulls_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls{/number}","milestones_url":"https://api.github.com/repos/drupal-media/entity_embed/milestones{/number}","notifications_url":"https://api.github.com/repos/drupal-media/entity_embed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupal-media/entity_embed/labels{/name}","releases_url":"https://api.github.com/repos/drupal-media/entity_embed/releases{/id}","created_at":"2014-04-13T00:08:52Z","updated_at":"2015-08-20T05:16:58Z","pushed_at":"2015-12-02T13:03:23Z","git_url":"git://github.com/drupal-media/entity_embed.git","ssh_url":"git@github.com:drupal-media/entity_embed.git","clone_url":"https://github.com/drupal-media/entity_embed.git","svn_url":"https://github.com/drupal-media/entity_embed","homepage":"https://www.drupal.org/project/entity_embed","size":751,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":12,"forks":28,"open_issues":12,"watchers":18,"default_branch":"8.x-1.x"}},"base":{"label":"drupal-media:8.x-1.x","ref":"8.x-1.x","sha":"2b8d7b3d8d20fec5dbb7d04b8fd8dff70379f3e6","user":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"repo":{"id":18717762,"name":"entity_embed","full_name":"drupal-media/entity_embed","owner":{"login":"drupal-media","id":7276699,"avatar_url":"https://avatars.githubusercontent.com/u/7276699?v=3","gravatar_id":"","url":"https://api.github.com/users/drupal-media","html_url":"https://github.com/drupal-media","followers_url":"https://api.github.com/users/drupal-media/followers","following_url":"https://api.github.com/users/drupal-media/following{/other_user}","gists_url":"https://api.github.com/users/drupal-media/gists{/gist_id}","starred_url":"https://api.github.com/users/drupal-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupal-media/subscriptions","organizations_url":"https://api.github.com/users/drupal-media/orgs","repos_url":"https://api.github.com/users/drupal-media/repos","events_url":"https://api.github.com/users/drupal-media/events{/privacy}","received_events_url":"https://api.github.com/users/drupal-media/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupal-media/entity_embed","description":"Allows any entity to be embedded using a WYSIWYG and text format.","fork":false,"url":"https://api.github.com/repos/drupal-media/entity_embed","forks_url":"https://api.github.com/repos/drupal-media/entity_embed/forks","keys_url":"https://api.github.com/repos/drupal-media/entity_embed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupal-media/entity_embed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupal-media/entity_embed/teams","hooks_url":"https://api.github.com/repos/drupal-media/entity_embed/hooks","issue_events_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/events{/number}","events_url":"https://api.github.com/repos/drupal-media/entity_embed/events","assignees_url":"https://api.github.com/repos/drupal-media/entity_embed/assignees{/user}","branches_url":"https://api.github.com/repos/drupal-media/entity_embed/branches{/branch}","tags_url":"https://api.github.com/repos/drupal-media/entity_embed/tags","blobs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupal-media/entity_embed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupal-media/entity_embed/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupal-media/entity_embed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupal-media/entity_embed/statuses/{sha}","languages_url":"https://api.github.com/repos/drupal-media/entity_embed/languages","stargazers_url":"https://api.github.com/repos/drupal-media/entity_embed/stargazers","contributors_url":"https://api.github.com/repos/drupal-media/entity_embed/contributors","subscribers_url":"https://api.github.com/repos/drupal-media/entity_embed/subscribers","subscription_url":"https://api.github.com/repos/drupal-media/entity_embed/subscription","commits_url":"https://api.github.com/repos/drupal-media/entity_embed/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupal-media/entity_embed/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupal-media/entity_embed/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupal-media/entity_embed/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupal-media/entity_embed/contents/{+path}","compare_url":"https://api.github.com/repos/drupal-media/entity_embed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupal-media/entity_embed/merges","archive_url":"https://api.github.com/repos/drupal-media/entity_embed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupal-media/entity_embed/downloads","issues_url":"https://api.github.com/repos/drupal-media/entity_embed/issues{/number}","pulls_url":"https://api.github.com/repos/drupal-media/entity_embed/pulls{/number}","milestones_url":"https://api.github.com/repos/drupal-media/entity_embed/milestones{/number}","notifications_url":"https://api.github.com/repos/drupal-media/entity_embed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupal-media/entity_embed/labels{/name}","releases_url":"https://api.github.com/repos/drupal-media/entity_embed/releases{/id}","created_at":"2014-04-13T00:08:52Z","updated_at":"2015-08-20T05:16:58Z","pushed_at":"2015-12-02T13:03:23Z","git_url":"git://github.com/drupal-media/entity_embed.git","ssh_url":"git@github.com:drupal-media/entity_embed.git","clone_url":"https://github.com/drupal-media/entity_embed.git","svn_url":"https://github.com/drupal-media/entity_embed","homepage":"https://www.drupal.org/project/entity_embed","size":751,"stargazers_count":18,"watchers_count":18,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":12,"forks":28,"open_issues":12,"watchers":18,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179"},"html":{"href":"https://github.com/drupal-media/entity_embed/pull/179"},"issue":{"href":"https://api.github.com/repos/drupal-media/entity_embed/issues/179"},"comments":{"href":"https://api.github.com/repos/drupal-media/entity_embed/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drupal-media/entity_embed/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/drupal-media/entity_embed/statuses/c812c803e88a785454fd61d215ee45929735c5b7"}}}}