{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/37826586","id":37826586,"diff_hunk":"@@ -33,20 +33,23 @@ module MiqVimVdlVcConnectionMod\n \t# The connection is specific to this VM, and should be closed by the caller when it\n \t# has finished accessing the VM's disk files.\n \t#\n-\tdef vdlVcConnection\n+\tdef vdlVcConnection(thumb_print)\n \t    require 'VixDiskLib'\n \t\n         VixDiskLib.init(lambda { |s| $vim_log.info  \"VMware(VixDiskLib): #{s}\" },\n                         lambda { |s| $vim_log.warn  \"VMware(VixDiskLib): #{s}\" },\n                         lambda { |s| $vim_log.error \"VMware(VixDiskLib): #{s}\" })\n \t    \n-\t\t$vim_log.info \"MiqVimVmMod.vdlVcConnection: #{invObj.server}\"\n-\t    VixDiskLib.connect(:serverName => invObj.server,\n-\t                       :vmxSpec    => vixVmxSpec,\n-                           :port       => 902,\n-                           :credType   => VixDiskLib_raw::VIXDISKLIB_CRED_UID,\n-                           :userName   => invObj.username,\n-                           :password   => invObj.password)\n-    end\n+\t\t$log.info \"MiqVimVdlVcConnectionMod.vdlVcConnection: server - #{invObj.server}\"\n+         thumb_print.to_cert","path":"gems/pending/VMwareWebService/MiqVimVdlMod.rb","position":30,"original_position":30,"commit_id":"ebde78e6b3bb2308680dde5216b093456b6d4d7c","original_commit_id":"ebde78e6b3bb2308680dde5216b093456b6d4d7c","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"This method name feels really weird...it sounds like you are getting a cert back, but then you never use it.  It turns out you are relying on it's side effect which is not clear.","created_at":"2015-08-25T02:14:20Z","updated_at":"2015-08-25T02:14:20Z","html_url":"https://github.com/ManageIQ/manageiq/pull/4026#discussion_r37826586","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/37826586"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4026#discussion_r37826586"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026","id":43221272,"html_url":"https://github.com/ManageIQ/manageiq/pull/4026","diff_url":"https://github.com/ManageIQ/manageiq/pull/4026.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4026.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4026","number":4026,"state":"open","locked":false,"title":"VDDK 6.0 Support","user":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"body":"Changes required to enable support for VixDiskLib Release 6.0.\r\nThis release makes use of the server SSL Certificate Thumbprint\r\nmandatory, while in previous releases the Thumbprint was optional.\r\nWe have added code to obtain the thumbprint of the server cert\r\nin two ways depending upon whether we are scanning via (ESX) host,\r\nor not, in which case we need to get the thumbprint for the Vcenter\r\nserver.  The thumbprint will be passed on the connect call regardless\r\nof the release of VixDiskLib.\r\n\r\nThe latest change to the ffi-vix_disk_lib gem is required for this\r\nchange - both so that Release 6.0 is enabled by the gem, and also so\r\nthe previous default port of 902, which is still required by prior\r\nrelease of the VDDK, is replaced by port 0 for Release 6.0.\r\n\r\n@roliveri @Fryguy Please review and merge if acceptable.  Thanks.","created_at":"2015-08-24T21:01:08Z","updated_at":"2015-08-25T02:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f77fbbaeff099b31e3d1233c06f18f6500f68cb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4026/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ebde78e6b3bb2308680dde5216b093456b6d4d7c","head":{"label":"jerryk55:vddk6.0_support","ref":"vddk6.0_support","sha":"ebde78e6b3bb2308680dde5216b093456b6d4d7c","user":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"repo":{"id":20811956,"name":"manageiq","full_name":"jerryk55/manageiq","owner":{"login":"jerryk55","id":6118503,"avatar_url":"https://avatars.githubusercontent.com/u/6118503?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryk55","html_url":"https://github.com/jerryk55","followers_url":"https://api.github.com/users/jerryk55/followers","following_url":"https://api.github.com/users/jerryk55/following{/other_user}","gists_url":"https://api.github.com/users/jerryk55/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryk55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryk55/subscriptions","organizations_url":"https://api.github.com/users/jerryk55/orgs","repos_url":"https://api.github.com/users/jerryk55/repos","events_url":"https://api.github.com/users/jerryk55/events{/privacy}","received_events_url":"https://api.github.com/users/jerryk55/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerryk55/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jerryk55/manageiq","forks_url":"https://api.github.com/repos/jerryk55/manageiq/forks","keys_url":"https://api.github.com/repos/jerryk55/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryk55/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryk55/manageiq/teams","hooks_url":"https://api.github.com/repos/jerryk55/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jerryk55/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jerryk55/manageiq/events","assignees_url":"https://api.github.com/repos/jerryk55/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jerryk55/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jerryk55/manageiq/tags","blobs_url":"https://api.github.com/repos/jerryk55/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryk55/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryk55/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryk55/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryk55/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryk55/manageiq/languages","stargazers_url":"https://api.github.com/repos/jerryk55/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jerryk55/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jerryk55/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jerryk55/manageiq/subscription","commits_url":"https://api.github.com/repos/jerryk55/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryk55/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryk55/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryk55/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryk55/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jerryk55/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryk55/manageiq/merges","archive_url":"https://api.github.com/repos/jerryk55/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryk55/manageiq/downloads","issues_url":"https://api.github.com/repos/jerryk55/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jerryk55/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryk55/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryk55/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryk55/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jerryk55/manageiq/releases{/id}","created_at":"2014-06-13T17:23:53Z","updated_at":"2014-06-18T03:00:23Z","pushed_at":"2015-08-24T20:58:05Z","git_url":"git://github.com/jerryk55/manageiq.git","ssh_url":"git@github.com:jerryk55/manageiq.git","clone_url":"https://github.com/jerryk55/manageiq.git","svn_url":"https://github.com/jerryk55/manageiq","homepage":null,"size":80782,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"63f51b726f62205e5fb29e26aff3aeb61c3aa318","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-08-20T09:13:01Z","pushed_at":"2015-08-25T00:41:32Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":151576,"stargazers_count":132,"watchers_count":132,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":392,"forks":142,"open_issues":392,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4026"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4026"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4026/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4026/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/ebde78e6b3bb2308680dde5216b093456b6d4d7c"}}}}