{"action":"created","comment":{"url":"https://api.github.com/repos/holidayextras/culture/pulls/comments/43696040","id":43696040,"diff_hunk":"@@ -35,29 +37,57 @@\n     \"no-array-constructor\": 2,\n     \"no-caller\": 2,\n     \"no-catch-shadow\": 0,\n+    \"no-cond-assign\": 2,\n+    \"no-constant-condition\": 2,\n+    \"no-control-regex\": 2,\n+    \"no-debugger\": 2,\n+    \"no-delete-var\": 2,\n+    \"no-dupe-args\": 2,\n+    \"no-dupe-keys\": 2,\n+    \"no-duplicate-case\": 2,\n     \"no-else-return\": 2,\n+    \"no-empty\": 2,\n+    \"no-empty-character-class\": 2,\n     \"no-empty-label\": 2,\n     \"no-eval\": 2,\n+    \"no-ex-assign\": 2,\n     \"no-extend-native\": 2,\n     \"no-extra-bind\": 2,\n+    \"no-extra-boolean-cast\": 2,\n     \"no-extra-parens\": [2, \"functions\"],\n+    \"no-extra-semi\": 2,\n+    \"no-extra-strict\": 2,\n+    \"no-fallthrough\": 2,\n+    \"no-func-assign\": 2,\n     \"no-implied-eval\": 2,\n+    \"no-inner-declarations\": [2, \"functions\"],\n+    \"no-invalid-regexp\": 2,\n+    \"no-irregular-whitespace\": 2,\n     \"no-iterator\": 2,\n     \"no-label-var\": 2,\n     \"no-labels\": 2,\n     \"no-lone-blocks\": 2,\n     \"no-loop-func\": 2,\n+    \"no-mixed-requires\": [2, false],","path":".eslintrc","position":51,"original_position":51,"commit_id":"f41204e03dbbabd896f9c5a34b3fdf797cf6ad58","original_commit_id":"f41204e03dbbabd896f9c5a34b3fdf797cf6ad58","user":{"login":"hx-markterry","id":3158640,"avatar_url":"https://avatars.githubusercontent.com/u/3158640?v=3","gravatar_id":"","url":"https://api.github.com/users/hx-markterry","html_url":"https://github.com/hx-markterry","followers_url":"https://api.github.com/users/hx-markterry/followers","following_url":"https://api.github.com/users/hx-markterry/following{/other_user}","gists_url":"https://api.github.com/users/hx-markterry/gists{/gist_id}","starred_url":"https://api.github.com/users/hx-markterry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hx-markterry/subscriptions","organizations_url":"https://api.github.com/users/hx-markterry/orgs","repos_url":"https://api.github.com/users/hx-markterry/repos","events_url":"https://api.github.com/users/hx-markterry/events{/privacy}","received_events_url":"https://api.github.com/users/hx-markterry/received_events","type":"User","site_admin":false},"body":"The boolean config of this rule is deprecated according to the docs, this way is preferred:\r\n\r\n    {\"grouping\": false}","created_at":"2015-11-02T22:56:48Z","updated_at":"2015-11-02T22:56:48Z","html_url":"https://github.com/holidayextras/culture/pull/59#discussion_r43696040","pull_request_url":"https://api.github.com/repos/holidayextras/culture/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/comments/43696040"},"html":{"href":"https://github.com/holidayextras/culture/pull/59#discussion_r43696040"},"pull_request":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/holidayextras/culture/pulls/59","id":49382241,"html_url":"https://github.com/holidayextras/culture/pull/59","diff_url":"https://github.com/holidayextras/culture/pull/59.diff","patch_url":"https://github.com/holidayextras/culture/pull/59.patch","issue_url":"https://api.github.com/repos/holidayextras/culture/issues/59","number":59,"state":"open","locked":false,"title":"New explicit rule set for ESLint 1.8.0.","user":{"login":"pmcnr-hx","id":10811943,"avatar_url":"https://avatars.githubusercontent.com/u/10811943?v=3","gravatar_id":"","url":"https://api.github.com/users/pmcnr-hx","html_url":"https://github.com/pmcnr-hx","followers_url":"https://api.github.com/users/pmcnr-hx/followers","following_url":"https://api.github.com/users/pmcnr-hx/following{/other_user}","gists_url":"https://api.github.com/users/pmcnr-hx/gists{/gist_id}","starred_url":"https://api.github.com/users/pmcnr-hx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmcnr-hx/subscriptions","organizations_url":"https://api.github.com/users/pmcnr-hx/orgs","repos_url":"https://api.github.com/users/pmcnr-hx/repos","events_url":"https://api.github.com/users/pmcnr-hx/events{/privacy}","received_events_url":"https://api.github.com/users/pmcnr-hx/received_events","type":"User","site_admin":false},"body":"This PR updates our recommend ESLint rule set with explicit rules for the recommendations generated by the latest ESLint release.\r\n\r\nThis is a pre-requisite for upgrading the ESLint version used by make-up which is now over 5 months old.\r\n\r\n* [ ] :+1: \r\n* [ ] :shipit: ","created_at":"2015-11-01T22:07:06Z","updated_at":"2015-11-02T22:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb90a09cd1769cb2545f3a33f6e1a725c87a4f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/holidayextras/culture/pulls/59/commits","review_comments_url":"https://api.github.com/repos/holidayextras/culture/pulls/59/comments","review_comment_url":"https://api.github.com/repos/holidayextras/culture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidayextras/culture/issues/59/comments","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/f41204e03dbbabd896f9c5a34b3fdf797cf6ad58","head":{"label":"holidayextras:eslint-1.8.0-ruleset","ref":"eslint-1.8.0-ruleset","sha":"f41204e03dbbabd896f9c5a34b3fdf797cf6ad58","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":35272731,"name":"culture","full_name":"holidayextras/culture","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/culture","description":"Coding culture for HX","fork":false,"url":"https://api.github.com/repos/holidayextras/culture","forks_url":"https://api.github.com/repos/holidayextras/culture/forks","keys_url":"https://api.github.com/repos/holidayextras/culture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/culture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/culture/teams","hooks_url":"https://api.github.com/repos/holidayextras/culture/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/culture/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/culture/events","assignees_url":"https://api.github.com/repos/holidayextras/culture/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/culture/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/culture/tags","blobs_url":"https://api.github.com/repos/holidayextras/culture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/culture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/culture/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/culture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/culture/languages","stargazers_url":"https://api.github.com/repos/holidayextras/culture/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/culture/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/culture/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/culture/subscription","commits_url":"https://api.github.com/repos/holidayextras/culture/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/culture/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/culture/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/culture/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/culture/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/culture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/culture/merges","archive_url":"https://api.github.com/repos/holidayextras/culture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/culture/downloads","issues_url":"https://api.github.com/repos/holidayextras/culture/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/culture/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/culture/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/culture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/culture/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/culture/releases{/id}","created_at":"2015-05-08T10:13:05Z","updated_at":"2015-09-24T09:57:20Z","pushed_at":"2015-11-02T12:37:56Z","git_url":"git://github.com/holidayextras/culture.git","ssh_url":"git@github.com:holidayextras/culture.git","clone_url":"https://github.com/holidayextras/culture.git","svn_url":"https://github.com/holidayextras/culture","homepage":null,"size":1361,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":7,"default_branch":"master"}},"base":{"label":"holidayextras:master","ref":"master","sha":"dc88c5addd6493f2c101e965ef9e164bde9beced","user":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"repo":{"id":35272731,"name":"culture","full_name":"holidayextras/culture","owner":{"login":"holidayextras","id":286993,"avatar_url":"https://avatars.githubusercontent.com/u/286993?v=3","gravatar_id":"","url":"https://api.github.com/users/holidayextras","html_url":"https://github.com/holidayextras","followers_url":"https://api.github.com/users/holidayextras/followers","following_url":"https://api.github.com/users/holidayextras/following{/other_user}","gists_url":"https://api.github.com/users/holidayextras/gists{/gist_id}","starred_url":"https://api.github.com/users/holidayextras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidayextras/subscriptions","organizations_url":"https://api.github.com/users/holidayextras/orgs","repos_url":"https://api.github.com/users/holidayextras/repos","events_url":"https://api.github.com/users/holidayextras/events{/privacy}","received_events_url":"https://api.github.com/users/holidayextras/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidayextras/culture","description":"Coding culture for HX","fork":false,"url":"https://api.github.com/repos/holidayextras/culture","forks_url":"https://api.github.com/repos/holidayextras/culture/forks","keys_url":"https://api.github.com/repos/holidayextras/culture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidayextras/culture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidayextras/culture/teams","hooks_url":"https://api.github.com/repos/holidayextras/culture/hooks","issue_events_url":"https://api.github.com/repos/holidayextras/culture/issues/events{/number}","events_url":"https://api.github.com/repos/holidayextras/culture/events","assignees_url":"https://api.github.com/repos/holidayextras/culture/assignees{/user}","branches_url":"https://api.github.com/repos/holidayextras/culture/branches{/branch}","tags_url":"https://api.github.com/repos/holidayextras/culture/tags","blobs_url":"https://api.github.com/repos/holidayextras/culture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidayextras/culture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidayextras/culture/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidayextras/culture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidayextras/culture/statuses/{sha}","languages_url":"https://api.github.com/repos/holidayextras/culture/languages","stargazers_url":"https://api.github.com/repos/holidayextras/culture/stargazers","contributors_url":"https://api.github.com/repos/holidayextras/culture/contributors","subscribers_url":"https://api.github.com/repos/holidayextras/culture/subscribers","subscription_url":"https://api.github.com/repos/holidayextras/culture/subscription","commits_url":"https://api.github.com/repos/holidayextras/culture/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidayextras/culture/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidayextras/culture/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidayextras/culture/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidayextras/culture/contents/{+path}","compare_url":"https://api.github.com/repos/holidayextras/culture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidayextras/culture/merges","archive_url":"https://api.github.com/repos/holidayextras/culture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidayextras/culture/downloads","issues_url":"https://api.github.com/repos/holidayextras/culture/issues{/number}","pulls_url":"https://api.github.com/repos/holidayextras/culture/pulls{/number}","milestones_url":"https://api.github.com/repos/holidayextras/culture/milestones{/number}","notifications_url":"https://api.github.com/repos/holidayextras/culture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidayextras/culture/labels{/name}","releases_url":"https://api.github.com/repos/holidayextras/culture/releases{/id}","created_at":"2015-05-08T10:13:05Z","updated_at":"2015-09-24T09:57:20Z","pushed_at":"2015-11-02T12:37:56Z","git_url":"git://github.com/holidayextras/culture.git","ssh_url":"git@github.com:holidayextras/culture.git","clone_url":"https://github.com/holidayextras/culture.git","svn_url":"https://github.com/holidayextras/culture","homepage":null,"size":1361,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/59"},"html":{"href":"https://github.com/holidayextras/culture/pull/59"},"issue":{"href":"https://api.github.com/repos/holidayextras/culture/issues/59"},"comments":{"href":"https://api.github.com/repos/holidayextras/culture/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidayextras/culture/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/holidayextras/culture/statuses/f41204e03dbbabd896f9c5a34b3fdf797cf6ad58"}}}}