{"push_id":633968202,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"3b57cd9d0eb5e302cfc78a16455139b93f11a0cf","before":"33d17c59821cf865525d26be8b8ecd3e1ad76146","commits":[{"sha":"3b57cd9d0eb5e302cfc78a16455139b93f11a0cf","author":{"email":"4f3407de78bccc8cc160ee4d278d5efe7162e6b5@natecollings.com","name":"Nate Collings"},"message":"Call destroy not destroy! on dependent children\n\nThis is a proposal for a possibly better solution to commit #13042.\nCurrently, Rails will raise ActiveRecord::RecordNotDestroyed if you call\ndestroy on a model, but that model has children with dependent: :destroy\nset, and those models fail to be destroyed. This causes issues if you\nneed to perform some action in the parent's before_destroy regardless of\nwhether the children fail to be destroyed.\n\nThis switches back to calling destroy instead of destroy! on the\nchildren. The original issue (#12812) is resolved in this commit by only\nraising an ActiveRecord::RecordNotSaved exception when you are replacing\na dependent: :destroy child, and not when calling destroy on the parent.","distinct":true,"url":"https://api.github.com/repos/naiyt/rails/commits/3b57cd9d0eb5e302cfc78a16455139b93f11a0cf"}]}