{"action":"created","comment":{"url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments/28286016","id":28286016,"diff_hunk":"@@ -760,6 +774,12 @@ class TrapDaemon(CollectorDaemon):\n \n     _frameworkFactoryName = \"nosip\"\n \n+    def __init__(self, *args, **kwargs):\n+        self._trapFilter = TrapFilter()\n+        zope.component.provideUtility(self._trapFilter, ICollectorEventTransformer)\n+        super(TrapDaemon, self).__init__(*args, **kwargs)\n+        self._trapFilter.initialize()","path":"Products/ZenEvents/zentrap.py","position":null,"original_position":82,"commit_id":"720a98efc1d52f48541f51d5e25ae76a6be985af","original_commit_id":"b33e1a7ef5ea34ec751c33be523f25a8af64846c","user":{"login":"tgjonestx","id":2204589,"avatar_url":"https://avatars.githubusercontent.com/u/2204589?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjonestx","html_url":"https://github.com/tgjonestx","followers_url":"https://api.github.com/users/tgjonestx/followers","following_url":"https://api.github.com/users/tgjonestx/following{/other_user}","gists_url":"https://api.github.com/users/tgjonestx/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjonestx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjonestx/subscriptions","organizations_url":"https://api.github.com/users/tgjonestx/orgs","repos_url":"https://api.github.com/users/tgjonestx/repos","events_url":"https://api.github.com/users/tgjonestx/events{/privacy}","received_events_url":"https://api.github.com/users/tgjonestx/received_events","type":"User","site_admin":false},"body":"The implementation in 36d5627 only half works - no error event is displayed in RM. Not sure what I'm missing","created_at":"2015-04-13T22:33:38Z","updated_at":"2015-04-13T22:33:38Z","html_url":"https://github.com/zenoss/zenoss-prodbin/pull/831#discussion_r28286016","pull_request_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831","_links":{"self":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments/28286016"},"html":{"href":"https://github.com/zenoss/zenoss-prodbin/pull/831#discussion_r28286016"},"pull_request":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831"}}},"pull_request":{"url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831","id":33192194,"html_url":"https://github.com/zenoss/zenoss-prodbin/pull/831","diff_url":"https://github.com/zenoss/zenoss-prodbin/pull/831.diff","patch_url":"https://github.com/zenoss/zenoss-prodbin/pull/831.patch","issue_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/831","number":831,"state":"open","locked":false,"title":"Filter SNMP traps in zentrap","user":{"login":"tgjonestx","id":2204589,"avatar_url":"https://avatars.githubusercontent.com/u/2204589?v=3","gravatar_id":"","url":"https://api.github.com/users/tgjonestx","html_url":"https://github.com/tgjonestx","followers_url":"https://api.github.com/users/tgjonestx/followers","following_url":"https://api.github.com/users/tgjonestx/following{/other_user}","gists_url":"https://api.github.com/users/tgjonestx/gists{/gist_id}","starred_url":"https://api.github.com/users/tgjonestx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgjonestx/subscriptions","organizations_url":"https://api.github.com/users/tgjonestx/orgs","repos_url":"https://api.github.com/users/tgjonestx/repos","events_url":"https://api.github.com/users/tgjonestx/events{/privacy}","received_events_url":"https://api.github.com/users/tgjonestx/received_events","type":"User","site_admin":false},"body":"A variation of the changes committed to a different release as part of ZEN-10260.\r\n\r\nFor default filter definition, see zentrap.filter.conf in this services [PR](https://github.com/zenoss/zenoss-service/pull/89)","created_at":"2015-04-13T18:54:37Z","updated_at":"2015-04-13T22:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46e65d4888d1f43df571700e1e858d9d26fbe7fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831/commits","review_comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831/comments","review_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/831/comments","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/720a98efc1d52f48541f51d5e25ae76a6be985af","head":{"label":"zenoss:features/snmpFilter","ref":"features/snmpFilter","sha":"720a98efc1d52f48541f51d5e25ae76a6be985af","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10389144,"name":"zenoss-prodbin","full_name":"zenoss/zenoss-prodbin","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/zenoss-prodbin","description":"Zenoss - zenoss-prodbin module","fork":false,"url":"https://api.github.com/repos/zenoss/zenoss-prodbin","forks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/forks","keys_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/teams","hooks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/hooks","issue_events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/events","assignees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/tags","blobs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/languages","stargazers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/stargazers","contributors_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contributors","subscribers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscribers","subscription_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscription","commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/merges","archive_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/downloads","issues_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/releases{/id}","created_at":"2013-05-30T18:36:05Z","updated_at":"2015-04-13T15:00:43Z","pushed_at":"2015-04-13T22:32:31Z","git_url":"git://github.com/zenoss/zenoss-prodbin.git","ssh_url":"git@github.com:zenoss/zenoss-prodbin.git","clone_url":"https://github.com/zenoss/zenoss-prodbin.git","svn_url":"https://github.com/zenoss/zenoss-prodbin","homepage":"http://www.zenoss.com","size":452382,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":8,"default_branch":"develop"}},"base":{"label":"zenoss:develop","ref":"develop","sha":"373dcee685725cc2aff16f66124778a566a81dac","user":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"repo":{"id":10389144,"name":"zenoss-prodbin","full_name":"zenoss/zenoss-prodbin","owner":{"login":"zenoss","id":243767,"avatar_url":"https://avatars.githubusercontent.com/u/243767?v=3","gravatar_id":"","url":"https://api.github.com/users/zenoss","html_url":"https://github.com/zenoss","followers_url":"https://api.github.com/users/zenoss/followers","following_url":"https://api.github.com/users/zenoss/following{/other_user}","gists_url":"https://api.github.com/users/zenoss/gists{/gist_id}","starred_url":"https://api.github.com/users/zenoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenoss/subscriptions","organizations_url":"https://api.github.com/users/zenoss/orgs","repos_url":"https://api.github.com/users/zenoss/repos","events_url":"https://api.github.com/users/zenoss/events{/privacy}","received_events_url":"https://api.github.com/users/zenoss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zenoss/zenoss-prodbin","description":"Zenoss - zenoss-prodbin module","fork":false,"url":"https://api.github.com/repos/zenoss/zenoss-prodbin","forks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/forks","keys_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/teams","hooks_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/hooks","issue_events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/events{/number}","events_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/events","assignees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/assignees{/user}","branches_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/branches{/branch}","tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/tags","blobs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/{sha}","languages_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/languages","stargazers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/stargazers","contributors_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contributors","subscribers_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscribers","subscription_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/subscription","commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/contents/{+path}","compare_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/merges","archive_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/downloads","issues_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues{/number}","pulls_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls{/number}","milestones_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/milestones{/number}","notifications_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/labels{/name}","releases_url":"https://api.github.com/repos/zenoss/zenoss-prodbin/releases{/id}","created_at":"2013-05-30T18:36:05Z","updated_at":"2015-04-13T15:00:43Z","pushed_at":"2015-04-13T22:32:31Z","git_url":"git://github.com/zenoss/zenoss-prodbin.git","ssh_url":"git@github.com:zenoss/zenoss-prodbin.git","clone_url":"https://github.com/zenoss/zenoss-prodbin.git","svn_url":"https://github.com/zenoss/zenoss-prodbin","homepage":"http://www.zenoss.com","size":452382,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831"},"html":{"href":"https://github.com/zenoss/zenoss-prodbin/pull/831"},"issue":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/831"},"comments":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/zenoss/zenoss-prodbin/statuses/720a98efc1d52f48541f51d5e25ae76a6be985af"}}}}