{"action":"closed","number":601,"pull_request":{"url":"https://api.github.com/repos/thumbor/thumbor/pulls/601","id":50558406,"html_url":"https://github.com/thumbor/thumbor/pull/601","diff_url":"https://github.com/thumbor/thumbor/pull/601.diff","patch_url":"https://github.com/thumbor/thumbor/pull/601.patch","issue_url":"https://api.github.com/repos/thumbor/thumbor/issues/601","number":601,"state":"closed","locked":false,"title":"Ignore escaping safe characters when quoting tornado URL","user":{"login":"abaldwin1","id":12577500,"avatar_url":"https://avatars.githubusercontent.com/u/12577500?v=3","gravatar_id":"","url":"https://api.github.com/users/abaldwin1","html_url":"https://github.com/abaldwin1","followers_url":"https://api.github.com/users/abaldwin1/followers","following_url":"https://api.github.com/users/abaldwin1/following{/other_user}","gists_url":"https://api.github.com/users/abaldwin1/gists{/gist_id}","starred_url":"https://api.github.com/users/abaldwin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaldwin1/subscriptions","organizations_url":"https://api.github.com/users/abaldwin1/orgs","repos_url":"https://api.github.com/users/abaldwin1/repos","events_url":"https://api.github.com/users/abaldwin1/events{/privacy}","received_events_url":"https://api.github.com/users/abaldwin1/received_events","type":"User","site_admin":false},"body":"Escaping the Tornado URL breaks HTTP loading of remote images. For example, /unsafe/200x200/https://example.com/image.jpg becomes /unsafe/200x200/https%3A//example.com/image.jpg.\r\n\r\nAnswer at http://stackoverflow.com/a/845595 cites an example fix in Python's urllib. That solution has been copied in this commit.","created_at":"2015-11-12T19:49:11Z","updated_at":"2015-12-01T21:29:59Z","closed_at":"2015-12-01T21:29:59Z","merged_at":null,"merge_commit_sha":"2ee0b8c084cae7faf682a47a69f945e3498c0754","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/thumbor/thumbor/pulls/601/commits","review_comments_url":"https://api.github.com/repos/thumbor/thumbor/pulls/601/comments","review_comment_url":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thumbor/thumbor/issues/601/comments","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/d98776bb061480f64e707ea10e1008ba614eb6e5","head":{"label":"abaldwin1:master","ref":"master","sha":"d98776bb061480f64e707ea10e1008ba614eb6e5","user":{"login":"abaldwin1","id":12577500,"avatar_url":"https://avatars.githubusercontent.com/u/12577500?v=3","gravatar_id":"","url":"https://api.github.com/users/abaldwin1","html_url":"https://github.com/abaldwin1","followers_url":"https://api.github.com/users/abaldwin1/followers","following_url":"https://api.github.com/users/abaldwin1/following{/other_user}","gists_url":"https://api.github.com/users/abaldwin1/gists{/gist_id}","starred_url":"https://api.github.com/users/abaldwin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaldwin1/subscriptions","organizations_url":"https://api.github.com/users/abaldwin1/orgs","repos_url":"https://api.github.com/users/abaldwin1/repos","events_url":"https://api.github.com/users/abaldwin1/events{/privacy}","received_events_url":"https://api.github.com/users/abaldwin1/received_events","type":"User","site_admin":false},"repo":{"id":42751558,"name":"thumbor","full_name":"abaldwin1/thumbor","owner":{"login":"abaldwin1","id":12577500,"avatar_url":"https://avatars.githubusercontent.com/u/12577500?v=3","gravatar_id":"","url":"https://api.github.com/users/abaldwin1","html_url":"https://github.com/abaldwin1","followers_url":"https://api.github.com/users/abaldwin1/followers","following_url":"https://api.github.com/users/abaldwin1/following{/other_user}","gists_url":"https://api.github.com/users/abaldwin1/gists{/gist_id}","starred_url":"https://api.github.com/users/abaldwin1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaldwin1/subscriptions","organizations_url":"https://api.github.com/users/abaldwin1/orgs","repos_url":"https://api.github.com/users/abaldwin1/repos","events_url":"https://api.github.com/users/abaldwin1/events{/privacy}","received_events_url":"https://api.github.com/users/abaldwin1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abaldwin1/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":true,"url":"https://api.github.com/repos/abaldwin1/thumbor","forks_url":"https://api.github.com/repos/abaldwin1/thumbor/forks","keys_url":"https://api.github.com/repos/abaldwin1/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abaldwin1/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abaldwin1/thumbor/teams","hooks_url":"https://api.github.com/repos/abaldwin1/thumbor/hooks","issue_events_url":"https://api.github.com/repos/abaldwin1/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/abaldwin1/thumbor/events","assignees_url":"https://api.github.com/repos/abaldwin1/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/abaldwin1/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/abaldwin1/thumbor/tags","blobs_url":"https://api.github.com/repos/abaldwin1/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abaldwin1/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abaldwin1/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/abaldwin1/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abaldwin1/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/abaldwin1/thumbor/languages","stargazers_url":"https://api.github.com/repos/abaldwin1/thumbor/stargazers","contributors_url":"https://api.github.com/repos/abaldwin1/thumbor/contributors","subscribers_url":"https://api.github.com/repos/abaldwin1/thumbor/subscribers","subscription_url":"https://api.github.com/repos/abaldwin1/thumbor/subscription","commits_url":"https://api.github.com/repos/abaldwin1/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/abaldwin1/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/abaldwin1/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/abaldwin1/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/abaldwin1/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/abaldwin1/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abaldwin1/thumbor/merges","archive_url":"https://api.github.com/repos/abaldwin1/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abaldwin1/thumbor/downloads","issues_url":"https://api.github.com/repos/abaldwin1/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/abaldwin1/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/abaldwin1/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/abaldwin1/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abaldwin1/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/abaldwin1/thumbor/releases{/id}","created_at":"2015-09-18T23:25:26Z","updated_at":"2015-09-18T23:25:28Z","pushed_at":"2015-12-01T21:29:58Z","git_url":"git://github.com/abaldwin1/thumbor.git","ssh_url":"git@github.com:abaldwin1/thumbor.git","clone_url":"https://github.com/abaldwin1/thumbor.git","svn_url":"https://github.com/abaldwin1/thumbor","homepage":"http://thumbor.org","size":9975,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thumbor:master","ref":"master","sha":"d98776bb061480f64e707ea10e1008ba614eb6e5","user":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars.githubusercontent.com/u/6918711?v=3","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"repo":{"id":1488139,"name":"thumbor","full_name":"thumbor/thumbor","owner":{"login":"thumbor","id":6918711,"avatar_url":"https://avatars.githubusercontent.com/u/6918711?v=3","gravatar_id":"","url":"https://api.github.com/users/thumbor","html_url":"https://github.com/thumbor","followers_url":"https://api.github.com/users/thumbor/followers","following_url":"https://api.github.com/users/thumbor/following{/other_user}","gists_url":"https://api.github.com/users/thumbor/gists{/gist_id}","starred_url":"https://api.github.com/users/thumbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thumbor/subscriptions","organizations_url":"https://api.github.com/users/thumbor/orgs","repos_url":"https://api.github.com/users/thumbor/repos","events_url":"https://api.github.com/users/thumbor/events{/privacy}","received_events_url":"https://api.github.com/users/thumbor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thumbor/thumbor","description":"thumbor is an open-source photo thumbnail service by globo.com","fork":false,"url":"https://api.github.com/repos/thumbor/thumbor","forks_url":"https://api.github.com/repos/thumbor/thumbor/forks","keys_url":"https://api.github.com/repos/thumbor/thumbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thumbor/thumbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thumbor/thumbor/teams","hooks_url":"https://api.github.com/repos/thumbor/thumbor/hooks","issue_events_url":"https://api.github.com/repos/thumbor/thumbor/issues/events{/number}","events_url":"https://api.github.com/repos/thumbor/thumbor/events","assignees_url":"https://api.github.com/repos/thumbor/thumbor/assignees{/user}","branches_url":"https://api.github.com/repos/thumbor/thumbor/branches{/branch}","tags_url":"https://api.github.com/repos/thumbor/thumbor/tags","blobs_url":"https://api.github.com/repos/thumbor/thumbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thumbor/thumbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thumbor/thumbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/thumbor/thumbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thumbor/thumbor/statuses/{sha}","languages_url":"https://api.github.com/repos/thumbor/thumbor/languages","stargazers_url":"https://api.github.com/repos/thumbor/thumbor/stargazers","contributors_url":"https://api.github.com/repos/thumbor/thumbor/contributors","subscribers_url":"https://api.github.com/repos/thumbor/thumbor/subscribers","subscription_url":"https://api.github.com/repos/thumbor/thumbor/subscription","commits_url":"https://api.github.com/repos/thumbor/thumbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/thumbor/thumbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/thumbor/thumbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/thumbor/thumbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/thumbor/thumbor/contents/{+path}","compare_url":"https://api.github.com/repos/thumbor/thumbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thumbor/thumbor/merges","archive_url":"https://api.github.com/repos/thumbor/thumbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thumbor/thumbor/downloads","issues_url":"https://api.github.com/repos/thumbor/thumbor/issues{/number}","pulls_url":"https://api.github.com/repos/thumbor/thumbor/pulls{/number}","milestones_url":"https://api.github.com/repos/thumbor/thumbor/milestones{/number}","notifications_url":"https://api.github.com/repos/thumbor/thumbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thumbor/thumbor/labels{/name}","releases_url":"https://api.github.com/repos/thumbor/thumbor/releases{/id}","created_at":"2011-03-16T17:30:05Z","updated_at":"2015-12-01T16:22:30Z","pushed_at":"2015-12-01T20:33:49Z","git_url":"git://github.com/thumbor/thumbor.git","ssh_url":"git@github.com:thumbor/thumbor.git","clone_url":"https://github.com/thumbor/thumbor.git","svn_url":"https://github.com/thumbor/thumbor","homepage":"http://thumbor.org","size":13347,"stargazers_count":3477,"watchers_count":3477,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":334,"mirror_url":null,"open_issues_count":84,"forks":334,"open_issues":84,"watchers":3477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/601"},"html":{"href":"https://github.com/thumbor/thumbor/pull/601"},"issue":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/601"},"comments":{"href":"https://api.github.com/repos/thumbor/thumbor/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thumbor/thumbor/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/thumbor/thumbor/statuses/d98776bb061480f64e707ea10e1008ba614eb6e5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}