{"action":"created","issue":{"url":"https://api.github.com/repos/lcobucci/jwt/issues/27","labels_url":"https://api.github.com/repos/lcobucci/jwt/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/lcobucci/jwt/issues/27/comments","events_url":"https://api.github.com/repos/lcobucci/jwt/issues/27/events","html_url":"https://github.com/lcobucci/jwt/issues/27","id":103923860,"number":27,"title":"Signer factory deleted !","user":{"login":"absolux","id":1226317,"avatar_url":"https://avatars.githubusercontent.com/u/1226317?v=3","gravatar_id":"","url":"https://api.github.com/users/absolux","html_url":"https://github.com/absolux","followers_url":"https://api.github.com/users/absolux/followers","following_url":"https://api.github.com/users/absolux/following{/other_user}","gists_url":"https://api.github.com/users/absolux/gists{/gist_id}","starred_url":"https://api.github.com/users/absolux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absolux/subscriptions","organizations_url":"https://api.github.com/users/absolux/orgs","repos_url":"https://api.github.com/users/absolux/repos","events_url":"https://api.github.com/users/absolux/events{/privacy}","received_events_url":"https://api.github.com/users/absolux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-30T13:29:28Z","updated_at":"2015-09-01T21:20:40Z","closed_at":"2015-09-01T21:20:40Z","body":"From a closed issue, the Signer Factory was deleted, for security reasons of course, but i think it still useful for signer creation, so instead of\r\n```php\r\n$signer = new Sha256();\r\n$builder = (new Builder())->sign($signer, 'some key');\r\n```\r\nwe can use a factory\r\n```php\r\n$builder->sign(Factory::create('HS256'), \"some key\");\r\n```\r\nfor example, it can be helpful when we use a configuration variable to store the signer id, like\r\n```php\r\n$signer = Factory::create(config('jwt.algo'));\r\n...\r\n$builder->sign($signer, \"key\");\r\n```"},"comment":{"url":"https://api.github.com/repos/lcobucci/jwt/issues/comments/136864379","html_url":"https://github.com/lcobucci/jwt/issues/27#issuecomment-136864379","issue_url":"https://api.github.com/repos/lcobucci/jwt/issues/27","id":136864379,"user":{"login":"absolux","id":1226317,"avatar_url":"https://avatars.githubusercontent.com/u/1226317?v=3","gravatar_id":"","url":"https://api.github.com/users/absolux","html_url":"https://github.com/absolux","followers_url":"https://api.github.com/users/absolux/followers","following_url":"https://api.github.com/users/absolux/following{/other_user}","gists_url":"https://api.github.com/users/absolux/gists{/gist_id}","starred_url":"https://api.github.com/users/absolux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absolux/subscriptions","organizations_url":"https://api.github.com/users/absolux/orgs","repos_url":"https://api.github.com/users/absolux/repos","events_url":"https://api.github.com/users/absolux/events{/privacy}","received_events_url":"https://api.github.com/users/absolux/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T21:20:40Z","updated_at":"2015-09-01T21:20:40Z","body":"I am using your package, in a laravel project, and i'll create a ServiceProvider to handle that.\r\n\r\nThank you."}}