{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8","id":39311742,"html_url":"https://github.com/HalfTime/angular-gizmos/pull/8","diff_url":"https://github.com/HalfTime/angular-gizmos/pull/8.diff","patch_url":"https://github.com/HalfTime/angular-gizmos/pull/8.patch","issue_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/8","number":8,"state":"closed","locked":false,"title":"Update text fit","user":{"login":"randallmeeker","id":2538537,"avatar_url":"https://avatars.githubusercontent.com/u/2538537?v=3","gravatar_id":"","url":"https://api.github.com/users/randallmeeker","html_url":"https://github.com/randallmeeker","followers_url":"https://api.github.com/users/randallmeeker/followers","following_url":"https://api.github.com/users/randallmeeker/following{/other_user}","gists_url":"https://api.github.com/users/randallmeeker/gists{/gist_id}","starred_url":"https://api.github.com/users/randallmeeker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randallmeeker/subscriptions","organizations_url":"https://api.github.com/users/randallmeeker/orgs","repos_url":"https://api.github.com/users/randallmeeker/repos","events_url":"https://api.github.com/users/randallmeeker/events{/privacy}","received_events_url":"https://api.github.com/users/randallmeeker/received_events","type":"User","site_admin":false},"body":"Updates\r\n\r\n* Added demo file in `/demos/text-fit.html`so that various use cases can be visualized and tested.\r\n* Solves current issues with text not being allowed to wrap properly. If text can not wrap then it will get really tiny to fit on one line and if in a group then all text will be that tiny.\r\n* better hidden - this will do a lot to patch up a lot of needless processing. Accurately checks for hidden elements. Does not matter if itself or parent or ancestor is hidden. This removes a bunch of retries, timeouts and needless console messages.\r\n* allows for padding - by using computed style on parents we can get accurate container height and width. This is slower than current version, but not really since the parent container is only measured once, and its accuracy outweighs the negative IMO. \r\n* quicker size guess - to go back and speed things up I added an algorithm that makes guessing a lot faster, basically by assuming that the largest the font can be is based on the container height and the spaces in the text. Spaces will make text wrap so you basically take height divided by potential line breaks. This is not as effective for long phrases but coupled with the options to set max height can brings guesses by 25% I have found.\r\n* even quicker size guess - I added an option that will quit guessing if the last two guesses are within a certain threshold defined by `options.accuracy`. You can set it to `.5` for instance to tell text-fit that once your guess get within a half of pixel, your probably good. Even setting it to a threshold of `1` is probably good for our purposes and will cut guessing by 50% I have found.\r\n* no more jquery - cause its not 2014 any more!\r\n\r\nStill looking into something for  #7 if necessary.\r\n\r\nBefore I submit this PR I want to add option to get all options from the text field group possibly, but people should feel free to start checking work.","created_at":"2015-07-06T21:17:12Z","updated_at":"2015-07-08T17:16:15Z","closed_at":"2015-07-08T17:16:15Z","merged_at":"2015-07-08T17:16:14Z","merge_commit_sha":"264e6b33821507c098567b16c4b41d1d64384e67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8/commits","review_comments_url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8/comments","review_comment_url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/8/comments","statuses_url":"https://api.github.com/repos/HalfTime/angular-gizmos/statuses/fc00a94bc9098d5ca8a558de76d6196326f8a62d","head":{"label":"HalfTime:update-text-fit","ref":"update-text-fit","sha":"fc00a94bc9098d5ca8a558de76d6196326f8a62d","user":{"login":"HalfTime","id":9747000,"avatar_url":"https://avatars.githubusercontent.com/u/9747000?v=3","gravatar_id":"","url":"https://api.github.com/users/HalfTime","html_url":"https://github.com/HalfTime","followers_url":"https://api.github.com/users/HalfTime/followers","following_url":"https://api.github.com/users/HalfTime/following{/other_user}","gists_url":"https://api.github.com/users/HalfTime/gists{/gist_id}","starred_url":"https://api.github.com/users/HalfTime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalfTime/subscriptions","organizations_url":"https://api.github.com/users/HalfTime/orgs","repos_url":"https://api.github.com/users/HalfTime/repos","events_url":"https://api.github.com/users/HalfTime/events{/privacy}","received_events_url":"https://api.github.com/users/HalfTime/received_events","type":"Organization","site_admin":false},"repo":{"id":32759809,"name":"angular-gizmos","full_name":"HalfTime/angular-gizmos","owner":{"login":"HalfTime","id":9747000,"avatar_url":"https://avatars.githubusercontent.com/u/9747000?v=3","gravatar_id":"","url":"https://api.github.com/users/HalfTime","html_url":"https://github.com/HalfTime","followers_url":"https://api.github.com/users/HalfTime/followers","following_url":"https://api.github.com/users/HalfTime/following{/other_user}","gists_url":"https://api.github.com/users/HalfTime/gists{/gist_id}","starred_url":"https://api.github.com/users/HalfTime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalfTime/subscriptions","organizations_url":"https://api.github.com/users/HalfTime/orgs","repos_url":"https://api.github.com/users/HalfTime/repos","events_url":"https://api.github.com/users/HalfTime/events{/privacy}","received_events_url":"https://api.github.com/users/HalfTime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HalfTime/angular-gizmos","description":"Some angular and other frontend (css, gulpfile) stuff.","fork":false,"url":"https://api.github.com/repos/HalfTime/angular-gizmos","forks_url":"https://api.github.com/repos/HalfTime/angular-gizmos/forks","keys_url":"https://api.github.com/repos/HalfTime/angular-gizmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HalfTime/angular-gizmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HalfTime/angular-gizmos/teams","hooks_url":"https://api.github.com/repos/HalfTime/angular-gizmos/hooks","issue_events_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/events{/number}","events_url":"https://api.github.com/repos/HalfTime/angular-gizmos/events","assignees_url":"https://api.github.com/repos/HalfTime/angular-gizmos/assignees{/user}","branches_url":"https://api.github.com/repos/HalfTime/angular-gizmos/branches{/branch}","tags_url":"https://api.github.com/repos/HalfTime/angular-gizmos/tags","blobs_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HalfTime/angular-gizmos/statuses/{sha}","languages_url":"https://api.github.com/repos/HalfTime/angular-gizmos/languages","stargazers_url":"https://api.github.com/repos/HalfTime/angular-gizmos/stargazers","contributors_url":"https://api.github.com/repos/HalfTime/angular-gizmos/contributors","subscribers_url":"https://api.github.com/repos/HalfTime/angular-gizmos/subscribers","subscription_url":"https://api.github.com/repos/HalfTime/angular-gizmos/subscription","commits_url":"https://api.github.com/repos/HalfTime/angular-gizmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/HalfTime/angular-gizmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/HalfTime/angular-gizmos/contents/{+path}","compare_url":"https://api.github.com/repos/HalfTime/angular-gizmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HalfTime/angular-gizmos/merges","archive_url":"https://api.github.com/repos/HalfTime/angular-gizmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HalfTime/angular-gizmos/downloads","issues_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues{/number}","pulls_url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls{/number}","milestones_url":"https://api.github.com/repos/HalfTime/angular-gizmos/milestones{/number}","notifications_url":"https://api.github.com/repos/HalfTime/angular-gizmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HalfTime/angular-gizmos/labels{/name}","releases_url":"https://api.github.com/repos/HalfTime/angular-gizmos/releases{/id}","created_at":"2015-03-23T21:25:52Z","updated_at":"2015-04-30T17:57:17Z","pushed_at":"2015-07-08T17:16:15Z","git_url":"git://github.com/HalfTime/angular-gizmos.git","ssh_url":"git@github.com:HalfTime/angular-gizmos.git","clone_url":"https://github.com/HalfTime/angular-gizmos.git","svn_url":"https://github.com/HalfTime/angular-gizmos","homepage":null,"size":448,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"HalfTime:master","ref":"master","sha":"74266c5194c06d534c69469a7ff05960d87a06c0","user":{"login":"HalfTime","id":9747000,"avatar_url":"https://avatars.githubusercontent.com/u/9747000?v=3","gravatar_id":"","url":"https://api.github.com/users/HalfTime","html_url":"https://github.com/HalfTime","followers_url":"https://api.github.com/users/HalfTime/followers","following_url":"https://api.github.com/users/HalfTime/following{/other_user}","gists_url":"https://api.github.com/users/HalfTime/gists{/gist_id}","starred_url":"https://api.github.com/users/HalfTime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalfTime/subscriptions","organizations_url":"https://api.github.com/users/HalfTime/orgs","repos_url":"https://api.github.com/users/HalfTime/repos","events_url":"https://api.github.com/users/HalfTime/events{/privacy}","received_events_url":"https://api.github.com/users/HalfTime/received_events","type":"Organization","site_admin":false},"repo":{"id":32759809,"name":"angular-gizmos","full_name":"HalfTime/angular-gizmos","owner":{"login":"HalfTime","id":9747000,"avatar_url":"https://avatars.githubusercontent.com/u/9747000?v=3","gravatar_id":"","url":"https://api.github.com/users/HalfTime","html_url":"https://github.com/HalfTime","followers_url":"https://api.github.com/users/HalfTime/followers","following_url":"https://api.github.com/users/HalfTime/following{/other_user}","gists_url":"https://api.github.com/users/HalfTime/gists{/gist_id}","starred_url":"https://api.github.com/users/HalfTime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalfTime/subscriptions","organizations_url":"https://api.github.com/users/HalfTime/orgs","repos_url":"https://api.github.com/users/HalfTime/repos","events_url":"https://api.github.com/users/HalfTime/events{/privacy}","received_events_url":"https://api.github.com/users/HalfTime/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HalfTime/angular-gizmos","description":"Some angular and other frontend (css, gulpfile) stuff.","fork":false,"url":"https://api.github.com/repos/HalfTime/angular-gizmos","forks_url":"https://api.github.com/repos/HalfTime/angular-gizmos/forks","keys_url":"https://api.github.com/repos/HalfTime/angular-gizmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HalfTime/angular-gizmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HalfTime/angular-gizmos/teams","hooks_url":"https://api.github.com/repos/HalfTime/angular-gizmos/hooks","issue_events_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/events{/number}","events_url":"https://api.github.com/repos/HalfTime/angular-gizmos/events","assignees_url":"https://api.github.com/repos/HalfTime/angular-gizmos/assignees{/user}","branches_url":"https://api.github.com/repos/HalfTime/angular-gizmos/branches{/branch}","tags_url":"https://api.github.com/repos/HalfTime/angular-gizmos/tags","blobs_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HalfTime/angular-gizmos/statuses/{sha}","languages_url":"https://api.github.com/repos/HalfTime/angular-gizmos/languages","stargazers_url":"https://api.github.com/repos/HalfTime/angular-gizmos/stargazers","contributors_url":"https://api.github.com/repos/HalfTime/angular-gizmos/contributors","subscribers_url":"https://api.github.com/repos/HalfTime/angular-gizmos/subscribers","subscription_url":"https://api.github.com/repos/HalfTime/angular-gizmos/subscription","commits_url":"https://api.github.com/repos/HalfTime/angular-gizmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/HalfTime/angular-gizmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/HalfTime/angular-gizmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/HalfTime/angular-gizmos/contents/{+path}","compare_url":"https://api.github.com/repos/HalfTime/angular-gizmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HalfTime/angular-gizmos/merges","archive_url":"https://api.github.com/repos/HalfTime/angular-gizmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HalfTime/angular-gizmos/downloads","issues_url":"https://api.github.com/repos/HalfTime/angular-gizmos/issues{/number}","pulls_url":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls{/number}","milestones_url":"https://api.github.com/repos/HalfTime/angular-gizmos/milestones{/number}","notifications_url":"https://api.github.com/repos/HalfTime/angular-gizmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HalfTime/angular-gizmos/labels{/name}","releases_url":"https://api.github.com/repos/HalfTime/angular-gizmos/releases{/id}","created_at":"2015-03-23T21:25:52Z","updated_at":"2015-04-30T17:57:17Z","pushed_at":"2015-07-08T17:16:15Z","git_url":"git://github.com/HalfTime/angular-gizmos.git","ssh_url":"git@github.com:HalfTime/angular-gizmos.git","clone_url":"https://github.com/HalfTime/angular-gizmos.git","svn_url":"https://github.com/HalfTime/angular-gizmos","homepage":null,"size":448,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8"},"html":{"href":"https://github.com/HalfTime/angular-gizmos/pull/8"},"issue":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/8"},"comments":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/HalfTime/angular-gizmos/statuses/fc00a94bc9098d5ca8a558de76d6196326f8a62d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nddeluca","id":903469,"avatar_url":"https://avatars.githubusercontent.com/u/903469?v=3","gravatar_id":"","url":"https://api.github.com/users/nddeluca","html_url":"https://github.com/nddeluca","followers_url":"https://api.github.com/users/nddeluca/followers","following_url":"https://api.github.com/users/nddeluca/following{/other_user}","gists_url":"https://api.github.com/users/nddeluca/gists{/gist_id}","starred_url":"https://api.github.com/users/nddeluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nddeluca/subscriptions","organizations_url":"https://api.github.com/users/nddeluca/orgs","repos_url":"https://api.github.com/users/nddeluca/repos","events_url":"https://api.github.com/users/nddeluca/events{/privacy}","received_events_url":"https://api.github.com/users/nddeluca/received_events","type":"User","site_admin":false},"comments":5,"review_comments":8,"commits":41,"additions":457,"deletions":202,"changed_files":9}}