{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/3149","labels_url":"https://api.github.com/repos/concrete5/concrete5/issues/3149/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/3149/comments","events_url":"https://api.github.com/repos/concrete5/concrete5/issues/3149/events","html_url":"https://github.com/concrete5/concrete5/issues/3149","id":118701588,"number":3149,"title":"Automatically Banned IPs not showing in Table","user":{"login":"jgruiz75","id":5349135,"avatar_url":"https://avatars.githubusercontent.com/u/5349135?v=3","gravatar_id":"","url":"https://api.github.com/users/jgruiz75","html_url":"https://github.com/jgruiz75","followers_url":"https://api.github.com/users/jgruiz75/followers","following_url":"https://api.github.com/users/jgruiz75/following{/other_user}","gists_url":"https://api.github.com/users/jgruiz75/gists{/gist_id}","starred_url":"https://api.github.com/users/jgruiz75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgruiz75/subscriptions","organizations_url":"https://api.github.com/users/jgruiz75/orgs","repos_url":"https://api.github.com/users/jgruiz75/repos","events_url":"https://api.github.com/users/jgruiz75/events{/privacy}","received_events_url":"https://api.github.com/users/jgruiz75/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/concrete5/concrete5/labels/inactive:to%20be%20verified","name":"inactive:to be verified","color":"fad8c7"},{"url":"https://api.github.com/repos/concrete5/concrete5/labels/type:bug","name":"type:bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-24T20:59:25Z","updated_at":"2015-12-23T19:32:22Z","closed_at":null,"body":"In the Automatically Banned IPs table on\r\n/index.php/dashboard/system/permissions/blacklist\r\ndoes not show banned IPs although in the table UserBannedIPs there are current entries (i.e., current bans that have not expired).\r\n\r\nCore Version - 5.7.5.2\r\nVersion Installed - 5.7.5.2\r\nDatabase Version - 20150731000000"},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5/issues/comments/166976421","html_url":"https://github.com/concrete5/concrete5/issues/3149#issuecomment-166976421","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/3149","id":166976421,"user":{"login":"joe-meyer","id":1292766,"avatar_url":"https://avatars.githubusercontent.com/u/1292766?v=3","gravatar_id":"","url":"https://api.github.com/users/joe-meyer","html_url":"https://github.com/joe-meyer","followers_url":"https://api.github.com/users/joe-meyer/followers","following_url":"https://api.github.com/users/joe-meyer/following{/other_user}","gists_url":"https://api.github.com/users/joe-meyer/gists{/gist_id}","starred_url":"https://api.github.com/users/joe-meyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joe-meyer/subscriptions","organizations_url":"https://api.github.com/users/joe-meyer/orgs","repos_url":"https://api.github.com/users/joe-meyer/repos","events_url":"https://api.github.com/users/joe-meyer/events{/privacy}","received_events_url":"https://api.github.com/users/joe-meyer/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T19:32:22Z","updated_at":"2015-12-23T19:32:22Z","body":"I can confirm this... Started working through it a little bit and then I got to the permenent ban section which brings up a problem.\r\n\r\nCurrently we have support for things like 192.168.1.*. The * poses some problems with IPv6 because with IPv6 it's dependent on knowing the trailing hextets. So for example \r\n\r\nIf I have the ip address `2001:0db8:85a3:0000:0000:0000:0000:7334` this can be shorthanded to `2001:0db8:85a3::7334'. The problem is when you do something like `2001:0db8:85a3::*` at which point one has absolutely no way of knowing does that mean block everything in under `2001:0db8:28a3:*` or does that mean block everything under `2001:0db8:85a3:0000:0000:0000:0000:*`. \r\n\r\nCouple possible solutions:\r\n* We could try and detect ipv4 addresses and apply rules to IPv4 differently than we do IPv6 which could let us keep the * around but could cause confusion if someone tries to use that notation with an IPv6 address. This probably leaves us with using CIDR notation for IPv6 stuff. (Not techy at all for IPv4 stuff but very techy for IPv6 stuff)\r\n* We could get rid of the * notation and instead force users to give the starting IP and ending IP address in the range. (Not very techy at all, but might require a bit of UI tweaking)\r\n* We could go to a CIDR notation (aka slash notation) so that the user defines the prefix and the subnet to which the IP block would apply to (very techy but no real UI changes required). An example of the CIDR notation would be `192.168.0.1/24` which would be the same as `192.168.0.*` or `10.0.0.1/8` would be the same as saying `10.*` \r\n\r\nMy working branch on this is currently over at https://github.com/ExchangeCore/concrete5/tree/ip-blacklist-fixes if anyone wants to toy around with what I've fixed so far."}}