{"action":"created","comment":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/comments/42777401","id":42777401,"diff_hunk":"@@ -855,14 +856,28 @@ int SigParse(DetectEngineCtx *de_ctx, Signature *s, char *sigstr, uint8_t addrs_\n          * output variable. */\n         do {\n             memset(output, 0x00, buffer_size);\n+            plist = s->list;\n             ret = SigParseOptions(de_ctx, s, input, output, buffer_size);\n             if (ret == 1) {\n+                /* Check for a transition out of a terminal state. */","path":"src/detect-parse.c","position":15,"original_position":15,"commit_id":"a155ebf03da17615e47a6d1d405bbe23a6d79391","original_commit_id":"a155ebf03da17615e47a6d1d405bbe23a6d79391","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"body":"maybe the SigMatch::idx field can help there","created_at":"2015-10-22T17:19:17Z","updated_at":"2015-10-22T17:19:17Z","html_url":"https://github.com/inliniac/suricata/pull/1690#discussion_r42777401","pull_request_url":"https://api.github.com/repos/inliniac/suricata/pulls/1690","_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments/42777401"},"html":{"href":"https://github.com/inliniac/suricata/pull/1690#discussion_r42777401"},"pull_request":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1690"}}},"pull_request":{"url":"https://api.github.com/repos/inliniac/suricata/pulls/1690","id":47929376,"html_url":"https://github.com/inliniac/suricata/pull/1690","diff_url":"https://github.com/inliniac/suricata/pull/1690.diff","patch_url":"https://github.com/inliniac/suricata/pull/1690.patch","issue_url":"https://api.github.com/repos/inliniac/suricata/issues/1690","number":1690,"state":"closed","locked":false,"title":"Issue 1282 - base64_decode and base64_data - v5","user":{"login":"jasonish","id":644115,"avatar_url":"https://avatars.githubusercontent.com/u/644115?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonish","html_url":"https://github.com/jasonish","followers_url":"https://api.github.com/users/jasonish/followers","following_url":"https://api.github.com/users/jasonish/following{/other_user}","gists_url":"https://api.github.com/users/jasonish/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonish/subscriptions","organizations_url":"https://api.github.com/users/jasonish/orgs","repos_url":"https://api.github.com/users/jasonish/repos","events_url":"https://api.github.com/users/jasonish/events{/privacy}","received_events_url":"https://api.github.com/users/jasonish/received_events","type":"User","site_admin":false},"body":"Snort compatible base64_decode and base64_data keywords.\r\n\r\nutil-base64 was updated to return what it has decoded when it hits an invalid character. This was required to match Snort's behaviour of base64_decode.\r\n\r\nUpdates from PR #1689 \r\n- Make the base64_data keyword terminal. Any change of list after base64_data will cause the rule to fail.\r\n- Checked against all VRT and ET Pro Snort rules.\r\n\r\nRedmine ticket: https://redmine.openinfosecfoundation.org/issues/1282\r\n\r\nBuildbot output:\r\n- PR jasonish-pcap: https://buildbot.openinfosecfoundation.org/builders/jasonish-pcap/builds/151\r\n- PR jasonish: https://buildbot.openinfosecfoundation.org/builders/jasonish/builds/152\r\n","created_at":"2015-10-16T16:07:43Z","updated_at":"2015-10-22T17:19:17Z","closed_at":"2015-10-21T15:22:51Z","merged_at":null,"merge_commit_sha":"71f742a95499938f3af6845d15fef00aa30d3c87","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inliniac/suricata/pulls/1690/commits","review_comments_url":"https://api.github.com/repos/inliniac/suricata/pulls/1690/comments","review_comment_url":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inliniac/suricata/issues/1690/comments","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/a155ebf03da17615e47a6d1d405bbe23a6d79391","head":{"label":"jasonish:issue-1282-base64_decode-5","ref":"issue-1282-base64_decode-5","sha":"a155ebf03da17615e47a6d1d405bbe23a6d79391","user":{"login":"jasonish","id":644115,"avatar_url":"https://avatars.githubusercontent.com/u/644115?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonish","html_url":"https://github.com/jasonish","followers_url":"https://api.github.com/users/jasonish/followers","following_url":"https://api.github.com/users/jasonish/following{/other_user}","gists_url":"https://api.github.com/users/jasonish/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonish/subscriptions","organizations_url":"https://api.github.com/users/jasonish/orgs","repos_url":"https://api.github.com/users/jasonish/repos","events_url":"https://api.github.com/users/jasonish/events{/privacy}","received_events_url":"https://api.github.com/users/jasonish/received_events","type":"User","site_admin":false},"repo":{"id":5414542,"name":"suricata","full_name":"jasonish/suricata","owner":{"login":"jasonish","id":644115,"avatar_url":"https://avatars.githubusercontent.com/u/644115?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonish","html_url":"https://github.com/jasonish","followers_url":"https://api.github.com/users/jasonish/followers","following_url":"https://api.github.com/users/jasonish/following{/other_user}","gists_url":"https://api.github.com/users/jasonish/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonish/subscriptions","organizations_url":"https://api.github.com/users/jasonish/orgs","repos_url":"https://api.github.com/users/jasonish/repos","events_url":"https://api.github.com/users/jasonish/events{/privacy}","received_events_url":"https://api.github.com/users/jasonish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonish/suricata","description":"Mirror of the official OISF Suricata git repository","fork":true,"url":"https://api.github.com/repos/jasonish/suricata","forks_url":"https://api.github.com/repos/jasonish/suricata/forks","keys_url":"https://api.github.com/repos/jasonish/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonish/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonish/suricata/teams","hooks_url":"https://api.github.com/repos/jasonish/suricata/hooks","issue_events_url":"https://api.github.com/repos/jasonish/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/jasonish/suricata/events","assignees_url":"https://api.github.com/repos/jasonish/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/jasonish/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/jasonish/suricata/tags","blobs_url":"https://api.github.com/repos/jasonish/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonish/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonish/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonish/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonish/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonish/suricata/languages","stargazers_url":"https://api.github.com/repos/jasonish/suricata/stargazers","contributors_url":"https://api.github.com/repos/jasonish/suricata/contributors","subscribers_url":"https://api.github.com/repos/jasonish/suricata/subscribers","subscription_url":"https://api.github.com/repos/jasonish/suricata/subscription","commits_url":"https://api.github.com/repos/jasonish/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonish/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonish/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonish/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonish/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/jasonish/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonish/suricata/merges","archive_url":"https://api.github.com/repos/jasonish/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonish/suricata/downloads","issues_url":"https://api.github.com/repos/jasonish/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/jasonish/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonish/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonish/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonish/suricata/labels{/name}","releases_url":"https://api.github.com/repos/jasonish/suricata/releases{/id}","created_at":"2012-08-14T15:13:38Z","updated_at":"2015-05-08T15:33:21Z","pushed_at":"2015-10-22T16:45:50Z","git_url":"git://github.com/jasonish/suricata.git","ssh_url":"git@github.com:jasonish/suricata.git","clone_url":"https://github.com/jasonish/suricata.git","svn_url":"https://github.com/jasonish/suricata","homepage":"http://www.openinfosecfoundation.org","size":42479,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inliniac:master","ref":"master","sha":"dcbbda505f1abb55739333de0c6c347e30cb5797","user":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"repo":{"id":5410234,"name":"suricata","full_name":"inliniac/suricata","owner":{"login":"inliniac","id":719366,"avatar_url":"https://avatars.githubusercontent.com/u/719366?v=3","gravatar_id":"","url":"https://api.github.com/users/inliniac","html_url":"https://github.com/inliniac","followers_url":"https://api.github.com/users/inliniac/followers","following_url":"https://api.github.com/users/inliniac/following{/other_user}","gists_url":"https://api.github.com/users/inliniac/gists{/gist_id}","starred_url":"https://api.github.com/users/inliniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inliniac/subscriptions","organizations_url":"https://api.github.com/users/inliniac/orgs","repos_url":"https://api.github.com/users/inliniac/repos","events_url":"https://api.github.com/users/inliniac/events{/privacy}","received_events_url":"https://api.github.com/users/inliniac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inliniac/suricata","description":"Mirror of the official OISF Suricata git repository","fork":false,"url":"https://api.github.com/repos/inliniac/suricata","forks_url":"https://api.github.com/repos/inliniac/suricata/forks","keys_url":"https://api.github.com/repos/inliniac/suricata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inliniac/suricata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inliniac/suricata/teams","hooks_url":"https://api.github.com/repos/inliniac/suricata/hooks","issue_events_url":"https://api.github.com/repos/inliniac/suricata/issues/events{/number}","events_url":"https://api.github.com/repos/inliniac/suricata/events","assignees_url":"https://api.github.com/repos/inliniac/suricata/assignees{/user}","branches_url":"https://api.github.com/repos/inliniac/suricata/branches{/branch}","tags_url":"https://api.github.com/repos/inliniac/suricata/tags","blobs_url":"https://api.github.com/repos/inliniac/suricata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inliniac/suricata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inliniac/suricata/git/refs{/sha}","trees_url":"https://api.github.com/repos/inliniac/suricata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inliniac/suricata/statuses/{sha}","languages_url":"https://api.github.com/repos/inliniac/suricata/languages","stargazers_url":"https://api.github.com/repos/inliniac/suricata/stargazers","contributors_url":"https://api.github.com/repos/inliniac/suricata/contributors","subscribers_url":"https://api.github.com/repos/inliniac/suricata/subscribers","subscription_url":"https://api.github.com/repos/inliniac/suricata/subscription","commits_url":"https://api.github.com/repos/inliniac/suricata/commits{/sha}","git_commits_url":"https://api.github.com/repos/inliniac/suricata/git/commits{/sha}","comments_url":"https://api.github.com/repos/inliniac/suricata/comments{/number}","issue_comment_url":"https://api.github.com/repos/inliniac/suricata/issues/comments{/number}","contents_url":"https://api.github.com/repos/inliniac/suricata/contents/{+path}","compare_url":"https://api.github.com/repos/inliniac/suricata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inliniac/suricata/merges","archive_url":"https://api.github.com/repos/inliniac/suricata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inliniac/suricata/downloads","issues_url":"https://api.github.com/repos/inliniac/suricata/issues{/number}","pulls_url":"https://api.github.com/repos/inliniac/suricata/pulls{/number}","milestones_url":"https://api.github.com/repos/inliniac/suricata/milestones{/number}","notifications_url":"https://api.github.com/repos/inliniac/suricata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inliniac/suricata/labels{/name}","releases_url":"https://api.github.com/repos/inliniac/suricata/releases{/id}","created_at":"2012-08-14T08:30:06Z","updated_at":"2015-10-20T09:31:40Z","pushed_at":"2015-10-22T15:22:42Z","git_url":"git://github.com/inliniac/suricata.git","ssh_url":"git@github.com:inliniac/suricata.git","clone_url":"https://github.com/inliniac/suricata.git","svn_url":"https://github.com/inliniac/suricata","homepage":"http://suricata-ids.org/","size":63845,"stargazers_count":207,"watchers_count":207,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"open_issues_count":29,"forks":191,"open_issues":29,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1690"},"html":{"href":"https://github.com/inliniac/suricata/pull/1690"},"issue":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1690"},"comments":{"href":"https://api.github.com/repos/inliniac/suricata/issues/1690/comments"},"review_comments":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1690/comments"},"review_comment":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inliniac/suricata/pulls/1690/commits"},"statuses":{"href":"https://api.github.com/repos/inliniac/suricata/statuses/a155ebf03da17615e47a6d1d405bbe23a6d79391"}}}}