{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments/43097767","id":43097767,"diff_hunk":"@@ -48,37 +48,38 @@\n   private static final int CUSTOM_CHUNK_SIZE = 2 * 1024 * 1024;\n   private static final Random RANDOM = new Random();\n \n-  private StorageOptions optionsMock;\n+  private StorageOptions options;\n   private StorageRpc storageRpcMock;\n   private BlobReadChannelImpl reader;\n \n   @Before\n   public void setUp() throws IOException, InterruptedException {\n-    optionsMock = EasyMock.createMock(StorageOptions.class);\n+    StorageRpcFactory rpcFactoryMock = EasyMock.createNiceMock(StorageRpcFactory.class);","path":"gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobReadChannelImplTest.java","position":42,"original_position":42,"commit_id":"8f5dee2caaf1643cedecc6f70a86fa91bb13070a","original_commit_id":"8f5dee2caaf1643cedecc6f70a86fa91bb13070a","user":{"login":"mziccard","id":450933,"avatar_url":"https://avatars.githubusercontent.com/u/450933?v=3","gravatar_id":"","url":"https://api.github.com/users/mziccard","html_url":"https://github.com/mziccard","followers_url":"https://api.github.com/users/mziccard/followers","following_url":"https://api.github.com/users/mziccard/following{/other_user}","gists_url":"https://api.github.com/users/mziccard/gists{/gist_id}","starred_url":"https://api.github.com/users/mziccard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mziccard/subscriptions","organizations_url":"https://api.github.com/users/mziccard/orgs","repos_url":"https://api.github.com/users/mziccard/repos","events_url":"https://api.github.com/users/mziccard/events{/privacy}","received_events_url":"https://api.github.com/users/mziccard/received_events","type":"User","site_admin":false},"body":"Why a nice mock here?","created_at":"2015-10-27T09:19:59Z","updated_at":"2015-10-27T09:19:59Z","html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296#discussion_r43097767","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments/43097767"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296#discussion_r43097767"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296","id":48772889,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296","diff_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296.diff","patch_url":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/296","number":296,"state":"open","locked":false,"title":"Remove Serializable from AuthCredentials, ServiceFactory and ServiceRpcFactory and set Factories in ServiceOptions","user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"body":"This should be a fix for issue #54 and also, hopefully, fix the last issues with #109.","created_at":"2015-10-26T17:44:54Z","updated_at":"2015-10-27T09:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3be274abe82f925143c78817f22cedc9727c5b43","assignee":{"login":"mziccard","id":450933,"avatar_url":"https://avatars.githubusercontent.com/u/450933?v=3","gravatar_id":"","url":"https://api.github.com/users/mziccard","html_url":"https://github.com/mziccard","followers_url":"https://api.github.com/users/mziccard/followers","following_url":"https://api.github.com/users/mziccard/following{/other_user}","gists_url":"https://api.github.com/users/mziccard/gists{/gist_id}","starred_url":"https://api.github.com/users/mziccard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mziccard/subscriptions","organizations_url":"https://api.github.com/users/mziccard/orgs","repos_url":"https://api.github.com/users/mziccard/repos","events_url":"https://api.github.com/users/mziccard/events{/privacy}","received_events_url":"https://api.github.com/users/mziccard/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/296/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/8f5dee2caaf1643cedecc6f70a86fa91bb13070a","head":{"label":"aozarov:master","ref":"master","sha":"8f5dee2caaf1643cedecc6f70a86fa91bb13070a","user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"repo":{"id":44983350,"name":"gcloud-java","full_name":"aozarov/gcloud-java","owner":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aozarov/gcloud-java","description":"Google Cloud Client Library for Java","fork":true,"url":"https://api.github.com/repos/aozarov/gcloud-java","forks_url":"https://api.github.com/repos/aozarov/gcloud-java/forks","keys_url":"https://api.github.com/repos/aozarov/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aozarov/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aozarov/gcloud-java/teams","hooks_url":"https://api.github.com/repos/aozarov/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/aozarov/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/aozarov/gcloud-java/events","assignees_url":"https://api.github.com/repos/aozarov/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/aozarov/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/aozarov/gcloud-java/tags","blobs_url":"https://api.github.com/repos/aozarov/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aozarov/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aozarov/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/aozarov/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aozarov/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/aozarov/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/aozarov/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/aozarov/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/aozarov/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/aozarov/gcloud-java/subscription","commits_url":"https://api.github.com/repos/aozarov/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/aozarov/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/aozarov/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/aozarov/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/aozarov/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/aozarov/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aozarov/gcloud-java/merges","archive_url":"https://api.github.com/repos/aozarov/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aozarov/gcloud-java/downloads","issues_url":"https://api.github.com/repos/aozarov/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/aozarov/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/aozarov/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/aozarov/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aozarov/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/aozarov/gcloud-java/releases{/id}","created_at":"2015-10-26T16:53:21Z","updated_at":"2015-10-26T16:53:27Z","pushed_at":"2015-10-26T20:11:30Z","git_url":"git://github.com/aozarov/gcloud-java.git","ssh_url":"git@github.com:aozarov/gcloud-java.git","clone_url":"https://github.com/aozarov/gcloud-java.git","svn_url":"https://github.com/aozarov/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":207352,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6e25709f99a32fa7a23357dc6ae97d4a0eb8ceea","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":26181278,"name":"gcloud-java","full_name":"GoogleCloudPlatform/gcloud-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/gcloud-java","description":"Google Cloud Client Library for Java","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/releases{/id}","created_at":"2014-11-04T17:57:16Z","updated_at":"2015-10-05T17:41:55Z","pushed_at":"2015-10-26T21:42:32Z","git_url":"git://github.com/GoogleCloudPlatform/gcloud-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/gcloud-java.git","clone_url":"https://github.com/GoogleCloudPlatform/gcloud-java.git","svn_url":"https://github.com/GoogleCloudPlatform/gcloud-java","homepage":"http://googlecloudplatform.github.io/gcloud-java/","size":207352,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":67,"forks":23,"open_issues":67,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296"},"html":{"href":"https://github.com/GoogleCloudPlatform/gcloud-java/pull/296"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/296"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/gcloud-java/statuses/8f5dee2caaf1643cedecc6f70a86fa91bb13070a"}}}}