{"action":"closed","number":3706,"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/3706","id":35564606,"html_url":"https://github.com/jekyll/jekyll/pull/3706","diff_url":"https://github.com/jekyll/jekyll/pull/3706.diff","patch_url":"https://github.com/jekyll/jekyll/pull/3706.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/3706","number":3706,"state":"closed","locked":false,"title":"Performance: Marshal metadata","user":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"body":"When doing some profiling, I noticed that for large sites, a considerable amount of time is spend in `read_metadata` and `write_metadata` of `Jekyll::Regenerator`. Most of that is in Psych (the YAML library that Jekyll uses).\r\n\r\nYou are probably not going to like this PR, since it's not backwards compatible, but I want to propose it anyway: Marshal is considerably faster and I don't really see why the metadata file needs to be human-readable.\r\n\r\nMy naive measurements: On a ~6000 pages site (which has a ~1MB metadata file with about 15k lines), this reduces the build time for incremental builds by about 400-500ms on my machine (from a total of about 5s).\r\n\r\n@parkr @envygeeks thoughts?","created_at":"2015-05-16T03:16:37Z","updated_at":"2015-05-18T14:17:42Z","closed_at":"2015-05-18T14:17:42Z","merged_at":"2015-05-18T14:17:42Z","merge_commit_sha":"a6665337f084a255c4e0989d25436828985e35b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3706/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/3706/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/3706/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/347448104317552ee48a19f3bbe6d761a58c64c6","head":{"label":"fw42:marshal_metadata","ref":"marshal_metadata","sha":"347448104317552ee48a19f3bbe6d761a58c64c6","user":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"repo":{"id":35707582,"name":"jekyll","full_name":"fw42/jekyll","owner":{"login":"fw42","id":2072686,"avatar_url":"https://avatars.githubusercontent.com/u/2072686?v=3","gravatar_id":"","url":"https://api.github.com/users/fw42","html_url":"https://github.com/fw42","followers_url":"https://api.github.com/users/fw42/followers","following_url":"https://api.github.com/users/fw42/following{/other_user}","gists_url":"https://api.github.com/users/fw42/gists{/gist_id}","starred_url":"https://api.github.com/users/fw42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fw42/subscriptions","organizations_url":"https://api.github.com/users/fw42/orgs","repos_url":"https://api.github.com/users/fw42/repos","events_url":"https://api.github.com/users/fw42/events{/privacy}","received_events_url":"https://api.github.com/users/fw42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fw42/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":true,"url":"https://api.github.com/repos/fw42/jekyll","forks_url":"https://api.github.com/repos/fw42/jekyll/forks","keys_url":"https://api.github.com/repos/fw42/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fw42/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fw42/jekyll/teams","hooks_url":"https://api.github.com/repos/fw42/jekyll/hooks","issue_events_url":"https://api.github.com/repos/fw42/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/fw42/jekyll/events","assignees_url":"https://api.github.com/repos/fw42/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/fw42/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/fw42/jekyll/tags","blobs_url":"https://api.github.com/repos/fw42/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fw42/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fw42/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/fw42/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fw42/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/fw42/jekyll/languages","stargazers_url":"https://api.github.com/repos/fw42/jekyll/stargazers","contributors_url":"https://api.github.com/repos/fw42/jekyll/contributors","subscribers_url":"https://api.github.com/repos/fw42/jekyll/subscribers","subscription_url":"https://api.github.com/repos/fw42/jekyll/subscription","commits_url":"https://api.github.com/repos/fw42/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/fw42/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/fw42/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/fw42/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/fw42/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/fw42/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fw42/jekyll/merges","archive_url":"https://api.github.com/repos/fw42/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fw42/jekyll/downloads","issues_url":"https://api.github.com/repos/fw42/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/fw42/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/fw42/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/fw42/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fw42/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/fw42/jekyll/releases{/id}","created_at":"2015-05-16T03:04:18Z","updated_at":"2015-05-16T03:04:21Z","pushed_at":"2015-05-18T14:02:54Z","git_url":"git://github.com/fw42/jekyll.git","ssh_url":"git@github.com:fw42/jekyll.git","clone_url":"https://github.com/fw42/jekyll.git","svn_url":"https://github.com/fw42/jekyll","homepage":"http://jekyllrb.com","size":37333,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"87829b3da1a40bbc1995ac0148d7fd020521696b","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars.githubusercontent.com/u/3083652?v=3","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":"Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","created_at":"2008-10-20T06:29:03Z","updated_at":"2015-05-18T13:49:19Z","pushed_at":"2015-05-18T14:17:42Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"http://jekyllrb.com","size":37333,"stargazers_count":19761,"watchers_count":19761,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4075,"mirror_url":null,"open_issues_count":83,"forks":4075,"open_issues":83,"watchers":19761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3706"},"html":{"href":"https://github.com/jekyll/jekyll/pull/3706"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3706"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/3706/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3706/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/3706/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/347448104317552ee48a19f3bbe6d761a58c64c6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"envygeeks","id":99763,"avatar_url":"https://avatars.githubusercontent.com/u/99763?v=3","gravatar_id":"","url":"https://api.github.com/users/envygeeks","html_url":"https://github.com/envygeeks","followers_url":"https://api.github.com/users/envygeeks/followers","following_url":"https://api.github.com/users/envygeeks/following{/other_user}","gists_url":"https://api.github.com/users/envygeeks/gists{/gist_id}","starred_url":"https://api.github.com/users/envygeeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envygeeks/subscriptions","organizations_url":"https://api.github.com/users/envygeeks/orgs","repos_url":"https://api.github.com/users/envygeeks/repos","events_url":"https://api.github.com/users/envygeeks/events{/privacy}","received_events_url":"https://api.github.com/users/envygeeks/received_events","type":"User","site_admin":false},"comments":12,"review_comments":0,"commits":1,"additions":20,"deletions":2,"changed_files":2}}