{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/618","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/618/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/618/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/618/events","html_url":"https://github.com/Microsoft/visualfsharp/pull/618","id":105252353,"number":618,"title":"fix ProductVersion file attribute","user":{"login":"enricosada","id":147243,"avatar_url":"https://avatars.githubusercontent.com/u/147243?v=3","gravatar_id":"","url":"https://api.github.com/users/enricosada","html_url":"https://github.com/enricosada","followers_url":"https://api.github.com/users/enricosada/followers","following_url":"https://api.github.com/users/enricosada/following{/other_user}","gists_url":"https://api.github.com/users/enricosada/gists{/gist_id}","starred_url":"https://api.github.com/users/enricosada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enricosada/subscriptions","organizations_url":"https://api.github.com/users/enricosada/orgs","repos_url":"https://api.github.com/users/enricosada/repos","events_url":"https://api.github.com/users/enricosada/events{/privacy}","received_events_url":"https://api.github.com/users/enricosada/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/visualfsharp/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-07T17:55:39Z","updated_at":"2015-09-08T18:59:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/618","html_url":"https://github.com/Microsoft/visualfsharp/pull/618","diff_url":"https://github.com/Microsoft/visualfsharp/pull/618.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/618.patch"},"body":"fix #605\r\n\r\nProductVersion should be set using the following fallback\r\nsequence:\r\n\r\n1. AssemblyInformationalVersionAttribute\r\n2. AssemblyFileVersionAttribute\r\n3. AssemblyVersionAttribute\r\n\r\nI changed visibility of some functions from private to internal because i needed to unit test the functions ( fsharp.compiler has already internalvisibleto attribute to fsharp.compiler.tests).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/138670749","html_url":"https://github.com/Microsoft/visualfsharp/pull/618#issuecomment-138670749","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/618","id":138670749,"user":{"login":"latkin","id":5943573,"avatar_url":"https://avatars.githubusercontent.com/u/5943573?v=3","gravatar_id":"","url":"https://api.github.com/users/latkin","html_url":"https://github.com/latkin","followers_url":"https://api.github.com/users/latkin/followers","following_url":"https://api.github.com/users/latkin/following{/other_user}","gists_url":"https://api.github.com/users/latkin/gists{/gist_id}","starred_url":"https://api.github.com/users/latkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latkin/subscriptions","organizations_url":"https://api.github.com/users/latkin/orgs","repos_url":"https://api.github.com/users/latkin/repos","events_url":"https://api.github.com/users/latkin/events{/privacy}","received_events_url":"https://api.github.com/users/latkin/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T18:59:47Z","updated_at":"2015-09-08T18:59:47Z","body":"Have you done testing around the auto-increment version format, with `*`, i.e. stuff like `\"1.2.*\"`. I forget at what level that is handled, but figured it would be related to this."}}