{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/788","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/788/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/788/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/788/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/788","id":96353017,"number":788,"title":"Events Tests","user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-07-21T15:55:51Z","updated_at":"2015-07-22T16:58:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/788","html_url":"https://github.com/cfpb/cfgov-refresh/pull/788","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/788.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/788.patch"},"body":"Added tests for events and events archive\r\n\r\n## Additions\r\n\r\n- Added page objects for both pages\r\n- Added specs for both pages\r\n\r\n## Removals\r\n\r\n- None\r\n\r\n## Changes\r\n\r\n- Updated the specs in `conf.js` because the shared spec was being fired on the desktop test, even though those tests had already been run in Chrome. Now the desktop test only runs the desktop spec\r\n\r\n## Testing\r\n\r\n- `grunt build && protractor ./tests/browser_tests/conf.js`\r\n\r\n## Review\r\n\r\n- @sebworks \r\n- @KimberlyMunoz \r\n- @anselmbradford \r\n- @imuchnik \r\n\r\n[Preview this PR without the whitespace changes](?w=0)\r\n\r\n## Notes\r\n\r\n- The tests hang and crash if you search for an element that doesn't exist. I wanted to search for the map on the archive page knowing it shouldn't be there, but it seems this is an issue that needs to be fixed first.\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/123791674","html_url":"https://github.com/cfpb/cfgov-refresh/pull/788#issuecomment-123791674","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/788","id":123791674,"user":{"login":"jimmynotjim","id":1280430,"avatar_url":"https://avatars.githubusercontent.com/u/1280430?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"created_at":"2015-07-22T16:58:32Z","updated_at":"2015-07-22T16:58:32Z","body":"@imuchnik I agree, but I think the file name matching the base directory for the type of content is plenty clear, and it's how the most everything is organized for the jinja templates.\r\n\r\nex: `page_events` and `shared_events` for `/events/...`; `page_offices` and `shared_offices` for `/offices/...` "}}