{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/36428627","id":36428627,"diff_hunk":"@@ -57,6 +58,7 @@ class CheckstylePlugin extends AbstractCodeQualityPlugin<Checkstyle> {\n             configProperties = { extension.configProperties }\n             ignoreFailures = { extension.ignoreFailures }\n             showViolations = { extension.showViolations }\n+            antClassName = { getAntClassForToolVersion(extension.toolVersion) }","path":"subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstylePlugin.groovy","position":12,"original_position":12,"commit_id":"4618b882d24c96f6f00efb484eefe231a9890722","original_commit_id":"4618b882d24c96f6f00efb484eefe231a9890722","user":{"login":"bigdaz","id":179734,"avatar_url":"https://avatars.githubusercontent.com/u/179734?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdaz","html_url":"https://github.com/bigdaz","followers_url":"https://api.github.com/users/bigdaz/followers","following_url":"https://api.github.com/users/bigdaz/following{/other_user}","gists_url":"https://api.github.com/users/bigdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdaz/subscriptions","organizations_url":"https://api.github.com/users/bigdaz/orgs","repos_url":"https://api.github.com/users/bigdaz/repos","events_url":"https://api.github.com/users/bigdaz/events{/privacy}","received_events_url":"https://api.github.com/users/bigdaz/received_events","type":"User","site_admin":false},"body":"Thinking about this a bit more, I think this logic should live inside the Checkstyle task and should not be exposed as a configuration option. As in, `org.gradle.api.plugins.quality.Checkstyle` should _just work_, for versions of Checkstyle in our supported range.\r\n\r\nOne reason for this is that the user can configure the checkstyle version without modifying `toolVersion`, by [adding dependencies to the `checkstyle` configuration directly](https://github.com/gradle/gradle/blob/master/subprojects/code-quality/src/integTest/groovy/org/gradle/api/plugins/quality/CheckstylePluginIntegrationTest.groovy#L38). I'm not certain how we can detect the version of checkstyle in the supplied Classpath: in the `PMD` task we are simply [relying on the version string being part of the jar name](https://github.com/gradle/gradle/blob/master/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/Pmd.groovy#L119-119).\r\n\r\nThat's not ideal: better would be to actually inspect the supplied files for an Ant task with the correct name, or perhaps the checkstyle jar file has some identifying metadata file that will make this easier.\r\n\r\nSo I propose that we remove this configuration option, and make the Checkstyle task work transparently for Checkstyle [5.0, 6.8.2].","created_at":"2015-08-06T15:33:36Z","updated_at":"2015-08-06T15:33:36Z","html_url":"https://github.com/gradle/gradle/pull/491#discussion_r36428627","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/491","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/36428627"},"html":{"href":"https://github.com/gradle/gradle/pull/491#discussion_r36428627"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/491"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/491","id":41643742,"html_url":"https://github.com/gradle/gradle/pull/491","diff_url":"https://github.com/gradle/gradle/pull/491.diff","patch_url":"https://github.com/gradle/gradle/pull/491.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/491","number":491,"state":"open","locked":false,"title":"Allowing gradle to use checkstyle 6.8+","user":{"login":"ethankhall","id":794802,"avatar_url":"https://avatars.githubusercontent.com/u/794802?v=3","gravatar_id":"","url":"https://api.github.com/users/ethankhall","html_url":"https://github.com/ethankhall","followers_url":"https://api.github.com/users/ethankhall/followers","following_url":"https://api.github.com/users/ethankhall/following{/other_user}","gists_url":"https://api.github.com/users/ethankhall/gists{/gist_id}","starred_url":"https://api.github.com/users/ethankhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethankhall/subscriptions","organizations_url":"https://api.github.com/users/ethankhall/orgs","repos_url":"https://api.github.com/users/ethankhall/repos","events_url":"https://api.github.com/users/ethankhall/events{/privacy}","received_events_url":"https://api.github.com/users/ethankhall/received_events","type":"User","site_admin":false},"body":"Fixes: https://issues.gradle.org/browse/GRADLE-3314 \r\n","created_at":"2015-08-05T05:12:04Z","updated_at":"2015-08-06T15:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c82b8cfde0e658ea80b17dee00e7e8d223a38941","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/491/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/491/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/491/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/4618b882d24c96f6f00efb484eefe231a9890722","head":{"label":"ethankhall:checkstyle-6.8-support","ref":"checkstyle-6.8-support","sha":"4618b882d24c96f6f00efb484eefe231a9890722","user":{"login":"ethankhall","id":794802,"avatar_url":"https://avatars.githubusercontent.com/u/794802?v=3","gravatar_id":"","url":"https://api.github.com/users/ethankhall","html_url":"https://github.com/ethankhall","followers_url":"https://api.github.com/users/ethankhall/followers","following_url":"https://api.github.com/users/ethankhall/following{/other_user}","gists_url":"https://api.github.com/users/ethankhall/gists{/gist_id}","starred_url":"https://api.github.com/users/ethankhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethankhall/subscriptions","organizations_url":"https://api.github.com/users/ethankhall/orgs","repos_url":"https://api.github.com/users/ethankhall/repos","events_url":"https://api.github.com/users/ethankhall/events{/privacy}","received_events_url":"https://api.github.com/users/ethankhall/received_events","type":"User","site_admin":false},"repo":{"id":33546095,"name":"gradle","full_name":"ethankhall/gradle","owner":{"login":"ethankhall","id":794802,"avatar_url":"https://avatars.githubusercontent.com/u/794802?v=3","gravatar_id":"","url":"https://api.github.com/users/ethankhall","html_url":"https://github.com/ethankhall","followers_url":"https://api.github.com/users/ethankhall/followers","following_url":"https://api.github.com/users/ethankhall/following{/other_user}","gists_url":"https://api.github.com/users/ethankhall/gists{/gist_id}","starred_url":"https://api.github.com/users/ethankhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethankhall/subscriptions","organizations_url":"https://api.github.com/users/ethankhall/orgs","repos_url":"https://api.github.com/users/ethankhall/repos","events_url":"https://api.github.com/users/ethankhall/events{/privacy}","received_events_url":"https://api.github.com/users/ethankhall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ethankhall/gradle","description":"A powerful build system for the JVM","fork":true,"url":"https://api.github.com/repos/ethankhall/gradle","forks_url":"https://api.github.com/repos/ethankhall/gradle/forks","keys_url":"https://api.github.com/repos/ethankhall/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethankhall/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethankhall/gradle/teams","hooks_url":"https://api.github.com/repos/ethankhall/gradle/hooks","issue_events_url":"https://api.github.com/repos/ethankhall/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/ethankhall/gradle/events","assignees_url":"https://api.github.com/repos/ethankhall/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/ethankhall/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/ethankhall/gradle/tags","blobs_url":"https://api.github.com/repos/ethankhall/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethankhall/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethankhall/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethankhall/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethankhall/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/ethankhall/gradle/languages","stargazers_url":"https://api.github.com/repos/ethankhall/gradle/stargazers","contributors_url":"https://api.github.com/repos/ethankhall/gradle/contributors","subscribers_url":"https://api.github.com/repos/ethankhall/gradle/subscribers","subscription_url":"https://api.github.com/repos/ethankhall/gradle/subscription","commits_url":"https://api.github.com/repos/ethankhall/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethankhall/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethankhall/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethankhall/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethankhall/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/ethankhall/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethankhall/gradle/merges","archive_url":"https://api.github.com/repos/ethankhall/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethankhall/gradle/downloads","issues_url":"https://api.github.com/repos/ethankhall/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/ethankhall/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/ethankhall/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/ethankhall/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethankhall/gradle/labels{/name}","releases_url":"https://api.github.com/repos/ethankhall/gradle/releases{/id}","created_at":"2015-04-07T13:52:30Z","updated_at":"2015-05-08T16:39:48Z","pushed_at":"2015-08-06T03:01:37Z","git_url":"git://github.com/ethankhall/gradle.git","ssh_url":"git@github.com:ethankhall/gradle.git","clone_url":"https://github.com/ethankhall/gradle.git","svn_url":"https://github.com/ethankhall/gradle","homepage":"www.gradle.org","size":108561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gradle:master","ref":"master","sha":"38e7cf8db8027683ca7c898b9e7fa6774b9bffff","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"A powerful build system for the JVM","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","created_at":"2009-09-09T18:27:19Z","updated_at":"2015-08-06T13:53:10Z","pushed_at":"2015-08-06T14:56:27Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"www.gradle.org","size":595407,"stargazers_count":2541,"watchers_count":2541,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1044,"mirror_url":null,"open_issues_count":41,"forks":1044,"open_issues":41,"watchers":2541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/491"},"html":{"href":"https://github.com/gradle/gradle/pull/491"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/491"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/4618b882d24c96f6f00efb484eefe231a9890722"}}}}