{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/jwilm/ycmd/pulls/1","id":53473780,"html_url":"https://github.com/jwilm/ycmd/pull/1","diff_url":"https://github.com/jwilm/ycmd/pull/1.diff","patch_url":"https://github.com/jwilm/ycmd/pull/1.patch","issue_url":"https://api.github.com/repos/jwilm/ycmd/issues/1","number":1,"state":"closed","locked":false,"title":"Improvements for rustc completer","user":{"login":"onur","id":345828,"avatar_url":"https://avatars.githubusercontent.com/u/345828?v=3","gravatar_id":"","url":"https://api.github.com/users/onur","html_url":"https://github.com/onur","followers_url":"https://api.github.com/users/onur/followers","following_url":"https://api.github.com/users/onur/following{/other_user}","gists_url":"https://api.github.com/users/onur/gists{/gist_id}","starred_url":"https://api.github.com/users/onur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onur/subscriptions","organizations_url":"https://api.github.com/users/onur/orgs","repos_url":"https://api.github.com/users/onur/repos","events_url":"https://api.github.com/users/onur/events{/privacy}","received_events_url":"https://api.github.com/users/onur/received_events","type":"User","site_admin":false},"body":"Hi. I just made some improvements to rustc_completer (But, I just saw @vheon's review in your PR Valloric/ycmd#268). I hope you can keep your focus on racerd (hopefully implement a cache) while I am working on this. And thanks for your amazing work, I can't wait for ycmd rust completion.\r\n\r\nChanges are listed below:\r\n\r\n* Add _FindRacerdBinary and _FindRustSrcPath methods to get racerd\r\n  binary path and rust source path from user options.\r\n* Raise errors in constructor, if anything goes wrong (racerd not\r\n  available or rust source is not available) ycmd will stop trying.\r\n* Start server on OnFileReadyToParse. racerd will only start if user\r\n  is editing a rust file.\r\n* Use utils.GetUnusedLocalhostPort() to get a random port and start\r\n  racerd with this port.\r\n* Use localhost and port from GetUnusedLocalhostPort for 'target'\r\n  variable instead of parsing racerd message.\r\n* Check phandle to determine ServerIsRunning.\r\n* Fix blank lines before methods.","created_at":"2015-12-12T10:51:59Z","updated_at":"2015-12-14T00:57:32Z","closed_at":"2015-12-14T00:57:32Z","merged_at":null,"merge_commit_sha":"c3a06a5d8e92838e19100ca1a7e9108cce9015c1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jwilm/ycmd/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jwilm/ycmd/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jwilm/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwilm/ycmd/issues/1/comments","statuses_url":"https://api.github.com/repos/jwilm/ycmd/statuses/9771046dca95d5f4d78aebac29b12777cb312244","head":{"label":"onur:rust-support-findracerdbinary","ref":"rust-support-findracerdbinary","sha":"9771046dca95d5f4d78aebac29b12777cb312244","user":{"login":"onur","id":345828,"avatar_url":"https://avatars.githubusercontent.com/u/345828?v=3","gravatar_id":"","url":"https://api.github.com/users/onur","html_url":"https://github.com/onur","followers_url":"https://api.github.com/users/onur/followers","following_url":"https://api.github.com/users/onur/following{/other_user}","gists_url":"https://api.github.com/users/onur/gists{/gist_id}","starred_url":"https://api.github.com/users/onur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onur/subscriptions","organizations_url":"https://api.github.com/users/onur/orgs","repos_url":"https://api.github.com/users/onur/repos","events_url":"https://api.github.com/users/onur/events{/privacy}","received_events_url":"https://api.github.com/users/onur/received_events","type":"User","site_admin":false},"repo":{"id":47873816,"name":"ycmd","full_name":"onur/ycmd","owner":{"login":"onur","id":345828,"avatar_url":"https://avatars.githubusercontent.com/u/345828?v=3","gravatar_id":"","url":"https://api.github.com/users/onur","html_url":"https://github.com/onur","followers_url":"https://api.github.com/users/onur/followers","following_url":"https://api.github.com/users/onur/following{/other_user}","gists_url":"https://api.github.com/users/onur/gists{/gist_id}","starred_url":"https://api.github.com/users/onur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onur/subscriptions","organizations_url":"https://api.github.com/users/onur/orgs","repos_url":"https://api.github.com/users/onur/repos","events_url":"https://api.github.com/users/onur/events{/privacy}","received_events_url":"https://api.github.com/users/onur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onur/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/onur/ycmd","forks_url":"https://api.github.com/repos/onur/ycmd/forks","keys_url":"https://api.github.com/repos/onur/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onur/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onur/ycmd/teams","hooks_url":"https://api.github.com/repos/onur/ycmd/hooks","issue_events_url":"https://api.github.com/repos/onur/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/onur/ycmd/events","assignees_url":"https://api.github.com/repos/onur/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/onur/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/onur/ycmd/tags","blobs_url":"https://api.github.com/repos/onur/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onur/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onur/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/onur/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onur/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/onur/ycmd/languages","stargazers_url":"https://api.github.com/repos/onur/ycmd/stargazers","contributors_url":"https://api.github.com/repos/onur/ycmd/contributors","subscribers_url":"https://api.github.com/repos/onur/ycmd/subscribers","subscription_url":"https://api.github.com/repos/onur/ycmd/subscription","commits_url":"https://api.github.com/repos/onur/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/onur/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/onur/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/onur/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/onur/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/onur/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onur/ycmd/merges","archive_url":"https://api.github.com/repos/onur/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onur/ycmd/downloads","issues_url":"https://api.github.com/repos/onur/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/onur/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/onur/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/onur/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onur/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/onur/ycmd/releases{/id}","created_at":"2015-12-12T10:25:12Z","updated_at":"2015-12-12T10:25:23Z","pushed_at":"2015-12-12T16:24:15Z","git_url":"git://github.com/onur/ycmd.git","ssh_url":"git@github.com:onur/ycmd.git","clone_url":"https://github.com/onur/ycmd.git","svn_url":"https://github.com/onur/ycmd","homepage":null,"size":10429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jwilm:rust-support","ref":"rust-support","sha":"981ccc6692c2fcfd6080605fa69ec7183514ea89","user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"repo":{"id":45623431,"name":"ycmd","full_name":"jwilm/ycmd","owner":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwilm/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/jwilm/ycmd","forks_url":"https://api.github.com/repos/jwilm/ycmd/forks","keys_url":"https://api.github.com/repos/jwilm/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwilm/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwilm/ycmd/teams","hooks_url":"https://api.github.com/repos/jwilm/ycmd/hooks","issue_events_url":"https://api.github.com/repos/jwilm/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/jwilm/ycmd/events","assignees_url":"https://api.github.com/repos/jwilm/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/jwilm/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/jwilm/ycmd/tags","blobs_url":"https://api.github.com/repos/jwilm/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwilm/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwilm/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwilm/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwilm/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/jwilm/ycmd/languages","stargazers_url":"https://api.github.com/repos/jwilm/ycmd/stargazers","contributors_url":"https://api.github.com/repos/jwilm/ycmd/contributors","subscribers_url":"https://api.github.com/repos/jwilm/ycmd/subscribers","subscription_url":"https://api.github.com/repos/jwilm/ycmd/subscription","commits_url":"https://api.github.com/repos/jwilm/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwilm/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwilm/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwilm/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwilm/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/jwilm/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwilm/ycmd/merges","archive_url":"https://api.github.com/repos/jwilm/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwilm/ycmd/downloads","issues_url":"https://api.github.com/repos/jwilm/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/jwilm/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/jwilm/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/jwilm/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwilm/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/jwilm/ycmd/releases{/id}","created_at":"2015-11-05T16:19:19Z","updated_at":"2015-12-11T11:50:05Z","pushed_at":"2015-12-12T16:24:15Z","git_url":"git://github.com/jwilm/ycmd.git","ssh_url":"git@github.com:jwilm/ycmd.git","clone_url":"https://github.com/jwilm/ycmd.git","svn_url":"https://github.com/jwilm/ycmd","homepage":null,"size":10420,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwilm/ycmd/pulls/1"},"html":{"href":"https://github.com/jwilm/ycmd/pull/1"},"issue":{"href":"https://api.github.com/repos/jwilm/ycmd/issues/1"},"comments":{"href":"https://api.github.com/repos/jwilm/ycmd/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jwilm/ycmd/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jwilm/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwilm/ycmd/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jwilm/ycmd/statuses/9771046dca95d5f4d78aebac29b12777cb312244"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":7,"commits":1,"additions":82,"deletions":46,"changed_files":3}}