{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/30518070","id":30518070,"diff_hunk":"@@ -355,6 +355,10 @@ static mca_btl_tcp_interface_t** mca_btl_tcp_retrieve_local_interfaces(void)\n             if (6 == mca_btl_tcp_component.tcp_disable_family) {\n                 continue;\n             }\n+            if (opal_net_islinklocal(&local_addr)) {","path":"opal/mca/btl/tcp/btl_tcp_proc.c","position":4,"original_position":4,"commit_id":"f0bd2814dd264e7e4bae6c62e1356f4dd6d8ea3a","original_commit_id":"f0bd2814dd264e7e4bae6c62e1356f4dd6d8ea3a","user":{"login":"jsquyres","id":617316,"avatar_url":"https://avatars.githubusercontent.com/u/617316?v=3","gravatar_id":"","url":"https://api.github.com/users/jsquyres","html_url":"https://github.com/jsquyres","followers_url":"https://api.github.com/users/jsquyres/followers","following_url":"https://api.github.com/users/jsquyres/following{/other_user}","gists_url":"https://api.github.com/users/jsquyres/gists{/gist_id}","starred_url":"https://api.github.com/users/jsquyres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsquyres/subscriptions","organizations_url":"https://api.github.com/users/jsquyres/orgs","repos_url":"https://api.github.com/users/jsquyres/repos","events_url":"https://api.github.com/users/jsquyres/events{/privacy}","received_events_url":"https://api.github.com/users/jsquyres/received_events","type":"User","site_admin":false},"body":"Per the comment below, if opal_net_islinklocal() grows to understand IPv4, we might as well move this check outside of the switch/case block and do it for both IPv4 and IPv6.","created_at":"2015-05-18T15:30:25Z","updated_at":"2015-05-18T15:30:25Z","html_url":"https://github.com/open-mpi/ompi/pull/591#discussion_r30518070","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/591","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/30518070"},"html":{"href":"https://github.com/open-mpi/ompi/pull/591#discussion_r30518070"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/591"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/591","id":35603694,"html_url":"https://github.com/open-mpi/ompi/pull/591","diff_url":"https://github.com/open-mpi/ompi/pull/591.diff","patch_url":"https://github.com/open-mpi/ompi/pull/591.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/591","number":591,"state":"open","locked":false,"title":"btl/tcp: ignore IPV6 link local addresses","user":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"body":"Refs open-mpi/ompi#585","created_at":"2015-05-18T05:32:23Z","updated_at":"2015-05-18T15:30:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b635bb0d18507b2aaee92a5715d24feab60aa1e","assignee":{"login":"bosilca","id":642701,"avatar_url":"https://avatars.githubusercontent.com/u/642701?v=3","gravatar_id":"","url":"https://api.github.com/users/bosilca","html_url":"https://github.com/bosilca","followers_url":"https://api.github.com/users/bosilca/followers","following_url":"https://api.github.com/users/bosilca/following{/other_user}","gists_url":"https://api.github.com/users/bosilca/gists{/gist_id}","starred_url":"https://api.github.com/users/bosilca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosilca/subscriptions","organizations_url":"https://api.github.com/users/bosilca/orgs","repos_url":"https://api.github.com/users/bosilca/repos","events_url":"https://api.github.com/users/bosilca/events{/privacy}","received_events_url":"https://api.github.com/users/bosilca/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/591/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/591/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/591/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/f0bd2814dd264e7e4bae6c62e1356f4dd6d8ea3a","head":{"label":"ggouaillardet:topic/ipv6_ignore_link_locak_addresses","ref":"topic/ipv6_ignore_link_locak_addresses","sha":"f0bd2814dd264e7e4bae6c62e1356f4dd6d8ea3a","user":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"repo":{"id":24743931,"name":"ompi","full_name":"ggouaillardet/ompi","owner":{"login":"ggouaillardet","id":7233259,"avatar_url":"https://avatars.githubusercontent.com/u/7233259?v=3","gravatar_id":"","url":"https://api.github.com/users/ggouaillardet","html_url":"https://github.com/ggouaillardet","followers_url":"https://api.github.com/users/ggouaillardet/followers","following_url":"https://api.github.com/users/ggouaillardet/following{/other_user}","gists_url":"https://api.github.com/users/ggouaillardet/gists{/gist_id}","starred_url":"https://api.github.com/users/ggouaillardet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggouaillardet/subscriptions","organizations_url":"https://api.github.com/users/ggouaillardet/orgs","repos_url":"https://api.github.com/users/ggouaillardet/repos","events_url":"https://api.github.com/users/ggouaillardet/events{/privacy}","received_events_url":"https://api.github.com/users/ggouaillardet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggouaillardet/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/ggouaillardet/ompi","forks_url":"https://api.github.com/repos/ggouaillardet/ompi/forks","keys_url":"https://api.github.com/repos/ggouaillardet/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggouaillardet/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggouaillardet/ompi/teams","hooks_url":"https://api.github.com/repos/ggouaillardet/ompi/hooks","issue_events_url":"https://api.github.com/repos/ggouaillardet/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/ggouaillardet/ompi/events","assignees_url":"https://api.github.com/repos/ggouaillardet/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/ggouaillardet/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/ggouaillardet/ompi/tags","blobs_url":"https://api.github.com/repos/ggouaillardet/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggouaillardet/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggouaillardet/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggouaillardet/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggouaillardet/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/ggouaillardet/ompi/languages","stargazers_url":"https://api.github.com/repos/ggouaillardet/ompi/stargazers","contributors_url":"https://api.github.com/repos/ggouaillardet/ompi/contributors","subscribers_url":"https://api.github.com/repos/ggouaillardet/ompi/subscribers","subscription_url":"https://api.github.com/repos/ggouaillardet/ompi/subscription","commits_url":"https://api.github.com/repos/ggouaillardet/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggouaillardet/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggouaillardet/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggouaillardet/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggouaillardet/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/ggouaillardet/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggouaillardet/ompi/merges","archive_url":"https://api.github.com/repos/ggouaillardet/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggouaillardet/ompi/downloads","issues_url":"https://api.github.com/repos/ggouaillardet/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/ggouaillardet/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/ggouaillardet/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/ggouaillardet/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggouaillardet/ompi/labels{/name}","releases_url":"https://api.github.com/repos/ggouaillardet/ompi/releases{/id}","created_at":"2014-10-03T02:05:35Z","updated_at":"2014-10-06T10:38:18Z","pushed_at":"2015-05-18T05:53:25Z","git_url":"git://github.com/ggouaillardet/ompi.git","ssh_url":"git@github.com:ggouaillardet/ompi.git","clone_url":"https://github.com/ggouaillardet/ompi.git","svn_url":"https://github.com/ggouaillardet/ompi","homepage":null,"size":77111,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"69f900ab9db58305c179ec25bf43a1541759e0bc","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","created_at":"2014-09-16T16:08:30Z","updated_at":"2015-05-12T17:12:47Z","pushed_at":"2015-05-18T12:52:38Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":102361,"stargazers_count":66,"watchers_count":66,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":219,"forks":62,"open_issues":219,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/591"},"html":{"href":"https://github.com/open-mpi/ompi/pull/591"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/591"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/f0bd2814dd264e7e4bae6c62e1356f4dd6d8ea3a"}}}}