{"action":"created","comment":{"url":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/48097876","id":48097876,"diff_hunk":"@@ -72,12 +89,34 @@ public void process(Element element, HasExtras holder) {\n \t\t}\n \n \t\tJFieldVar extraKeyStaticField = createStaticExtraField(holder, extraKey, fieldName);\n-\t\tinjectExtraInComponent(element, holder, extraKeyStaticField, fieldName);\n-\n \t\tif (holder instanceof HasIntentBuilder) {\n \t\t\tString docComment = getProcessingEnvironment().getElementUtils().getDocComment(element);\n-\t\t\tcreateIntentInjectionMethod(element, (HasIntentBuilder) holder, extraKeyStaticField, fieldName, docComment);\n+\t\t\tcreateIntentInjectionMethod(param, (HasIntentBuilder) holder, extraKeyStaticField, fieldName, docComment);\n \t\t}\n+\n+\t\tJMethod injectExtrasMethod = holder.getInjectExtrasMethod();\n+\t\tJVar extras = holder.getInjectExtras();\n+\n+\t\tDeclaredType enclosingClassType;\n+\t\tif (param.getKind() == ElementKind.PARAMETER) {","path":"AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannotations/internal/core/handler/ExtraHandler.java","position":84,"original_position":84,"commit_id":"eff292115f0251116f64c64c118c7408a6331594","original_commit_id":"eff292115f0251116f64c64c118c7408a6331594","user":{"login":"WonderCsabo","id":480485,"avatar_url":"https://avatars.githubusercontent.com/u/480485?v=3","gravatar_id":"","url":"https://api.github.com/users/WonderCsabo","html_url":"https://github.com/WonderCsabo","followers_url":"https://api.github.com/users/WonderCsabo/followers","following_url":"https://api.github.com/users/WonderCsabo/following{/other_user}","gists_url":"https://api.github.com/users/WonderCsabo/gists{/gist_id}","starred_url":"https://api.github.com/users/WonderCsabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WonderCsabo/subscriptions","organizations_url":"https://api.github.com/users/WonderCsabo/orgs","repos_url":"https://api.github.com/users/WonderCsabo/repos","events_url":"https://api.github.com/users/WonderCsabo/events{/privacy}","received_events_url":"https://api.github.com/users/WonderCsabo/received_events","type":"User","site_admin":false},"body":"OK, i searched through the code and the enclosing element is only queried here in this way, so this is not duplicated.","created_at":"2015-12-19T23:38:10Z","updated_at":"2015-12-19T23:38:10Z","html_url":"https://github.com/excilys/androidannotations/pull/1457#discussion_r48097876","pull_request_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1457","_links":{"self":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/comments/48097876"},"html":{"href":"https://github.com/excilys/androidannotations/pull/1457#discussion_r48097876"},"pull_request":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1457"}}},"pull_request":{"url":"https://api.github.com/repos/excilys/androidannotations/pulls/1457","id":37113827,"html_url":"https://github.com/excilys/androidannotations/pull/1457","diff_url":"https://github.com/excilys/androidannotations/pull/1457.diff","patch_url":"https://github.com/excilys/androidannotations/pull/1457.patch","issue_url":"https://api.github.com/repos/excilys/androidannotations/issues/1457","number":1457,"state":"open","locked":false,"title":"allow method injection #204","user":{"login":"dodgex","id":204013,"avatar_url":"https://avatars.githubusercontent.com/u/204013?v=3","gravatar_id":"","url":"https://api.github.com/users/dodgex","html_url":"https://github.com/dodgex","followers_url":"https://api.github.com/users/dodgex/followers","following_url":"https://api.github.com/users/dodgex/following{/other_user}","gists_url":"https://api.github.com/users/dodgex/gists{/gist_id}","starred_url":"https://api.github.com/users/dodgex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodgex/subscriptions","organizations_url":"https://api.github.com/users/dodgex/orgs","repos_url":"https://api.github.com/users/dodgex/repos","events_url":"https://api.github.com/users/dodgex/events{/privacy}","received_events_url":"https://api.github.com/users/dodgex/received_events","type":"User","site_admin":false},"body":"this is the WIP branch for method injection. in its initial implementation only for `@Bean` but planned to be expanded to most (if not all) injection related annotations.\r\n\r\n\r\n","created_at":"2015-06-07T21:34:29Z","updated_at":"2015-12-19T23:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b076201ce0f9704115458e8f3747bc2b3021807e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1457/commits","review_comments_url":"https://api.github.com/repos/excilys/androidannotations/pulls/1457/comments","review_comment_url":"https://api.github.com/repos/excilys/androidannotations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/excilys/androidannotations/issues/1457/comments","statuses_url":"https://api.github.com/repos/excilys/androidannotations/statuses/eff292115f0251116f64c64c118c7408a6331594","head":{"label":"dodgex:204_method_injection","ref":"204_method_injection","sha":"eff292115f0251116f64c64c118c7408a6331594","user":{"login":"dodgex","id":204013,"avatar_url":"https://avatars.githubusercontent.com/u/204013?v=3","gravatar_id":"","url":"https://api.github.com/users/dodgex","html_url":"https://github.com/dodgex","followers_url":"https://api.github.com/users/dodgex/followers","following_url":"https://api.github.com/users/dodgex/following{/other_user}","gists_url":"https://api.github.com/users/dodgex/gists{/gist_id}","starred_url":"https://api.github.com/users/dodgex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodgex/subscriptions","organizations_url":"https://api.github.com/users/dodgex/orgs","repos_url":"https://api.github.com/users/dodgex/repos","events_url":"https://api.github.com/users/dodgex/events{/privacy}","received_events_url":"https://api.github.com/users/dodgex/received_events","type":"User","site_admin":false},"repo":{"id":13364807,"name":"androidannotations","full_name":"dodgex/androidannotations","owner":{"login":"dodgex","id":204013,"avatar_url":"https://avatars.githubusercontent.com/u/204013?v=3","gravatar_id":"","url":"https://api.github.com/users/dodgex","html_url":"https://github.com/dodgex","followers_url":"https://api.github.com/users/dodgex/followers","following_url":"https://api.github.com/users/dodgex/following{/other_user}","gists_url":"https://api.github.com/users/dodgex/gists{/gist_id}","starred_url":"https://api.github.com/users/dodgex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dodgex/subscriptions","organizations_url":"https://api.github.com/users/dodgex/orgs","repos_url":"https://api.github.com/users/dodgex/repos","events_url":"https://api.github.com/users/dodgex/events{/privacy}","received_events_url":"https://api.github.com/users/dodgex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dodgex/androidannotations","description":"Fast Android Development. Easy maintainance.","fork":true,"url":"https://api.github.com/repos/dodgex/androidannotations","forks_url":"https://api.github.com/repos/dodgex/androidannotations/forks","keys_url":"https://api.github.com/repos/dodgex/androidannotations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dodgex/androidannotations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dodgex/androidannotations/teams","hooks_url":"https://api.github.com/repos/dodgex/androidannotations/hooks","issue_events_url":"https://api.github.com/repos/dodgex/androidannotations/issues/events{/number}","events_url":"https://api.github.com/repos/dodgex/androidannotations/events","assignees_url":"https://api.github.com/repos/dodgex/androidannotations/assignees{/user}","branches_url":"https://api.github.com/repos/dodgex/androidannotations/branches{/branch}","tags_url":"https://api.github.com/repos/dodgex/androidannotations/tags","blobs_url":"https://api.github.com/repos/dodgex/androidannotations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dodgex/androidannotations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dodgex/androidannotations/git/refs{/sha}","trees_url":"https://api.github.com/repos/dodgex/androidannotations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dodgex/androidannotations/statuses/{sha}","languages_url":"https://api.github.com/repos/dodgex/androidannotations/languages","stargazers_url":"https://api.github.com/repos/dodgex/androidannotations/stargazers","contributors_url":"https://api.github.com/repos/dodgex/androidannotations/contributors","subscribers_url":"https://api.github.com/repos/dodgex/androidannotations/subscribers","subscription_url":"https://api.github.com/repos/dodgex/androidannotations/subscription","commits_url":"https://api.github.com/repos/dodgex/androidannotations/commits{/sha}","git_commits_url":"https://api.github.com/repos/dodgex/androidannotations/git/commits{/sha}","comments_url":"https://api.github.com/repos/dodgex/androidannotations/comments{/number}","issue_comment_url":"https://api.github.com/repos/dodgex/androidannotations/issues/comments{/number}","contents_url":"https://api.github.com/repos/dodgex/androidannotations/contents/{+path}","compare_url":"https://api.github.com/repos/dodgex/androidannotations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dodgex/androidannotations/merges","archive_url":"https://api.github.com/repos/dodgex/androidannotations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dodgex/androidannotations/downloads","issues_url":"https://api.github.com/repos/dodgex/androidannotations/issues{/number}","pulls_url":"https://api.github.com/repos/dodgex/androidannotations/pulls{/number}","milestones_url":"https://api.github.com/repos/dodgex/androidannotations/milestones{/number}","notifications_url":"https://api.github.com/repos/dodgex/androidannotations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dodgex/androidannotations/labels{/name}","releases_url":"https://api.github.com/repos/dodgex/androidannotations/releases{/id}","created_at":"2013-10-06T16:13:51Z","updated_at":"2015-05-05T16:37:59Z","pushed_at":"2015-12-18T20:45:22Z","git_url":"git://github.com/dodgex/androidannotations.git","ssh_url":"git@github.com:dodgex/androidannotations.git","clone_url":"https://github.com/dodgex/androidannotations.git","svn_url":"https://github.com/dodgex/androidannotations","homepage":"http://androidannotations.org","size":21977,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"excilys:develop","ref":"develop","sha":"dcff10bcb0d42dea8e931fc5630864f4323def1b","user":{"login":"excilys","id":668697,"avatar_url":"https://avatars.githubusercontent.com/u/668697?v=3","gravatar_id":"","url":"https://api.github.com/users/excilys","html_url":"https://github.com/excilys","followers_url":"https://api.github.com/users/excilys/followers","following_url":"https://api.github.com/users/excilys/following{/other_user}","gists_url":"https://api.github.com/users/excilys/gists{/gist_id}","starred_url":"https://api.github.com/users/excilys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excilys/subscriptions","organizations_url":"https://api.github.com/users/excilys/orgs","repos_url":"https://api.github.com/users/excilys/repos","events_url":"https://api.github.com/users/excilys/events{/privacy}","received_events_url":"https://api.github.com/users/excilys/received_events","type":"Organization","site_admin":false},"repo":{"id":3116751,"name":"androidannotations","full_name":"excilys/androidannotations","owner":{"login":"excilys","id":668697,"avatar_url":"https://avatars.githubusercontent.com/u/668697?v=3","gravatar_id":"","url":"https://api.github.com/users/excilys","html_url":"https://github.com/excilys","followers_url":"https://api.github.com/users/excilys/followers","following_url":"https://api.github.com/users/excilys/following{/other_user}","gists_url":"https://api.github.com/users/excilys/gists{/gist_id}","starred_url":"https://api.github.com/users/excilys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excilys/subscriptions","organizations_url":"https://api.github.com/users/excilys/orgs","repos_url":"https://api.github.com/users/excilys/repos","events_url":"https://api.github.com/users/excilys/events{/privacy}","received_events_url":"https://api.github.com/users/excilys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excilys/androidannotations","description":"Fast Android Development. Easy maintainance.","fork":false,"url":"https://api.github.com/repos/excilys/androidannotations","forks_url":"https://api.github.com/repos/excilys/androidannotations/forks","keys_url":"https://api.github.com/repos/excilys/androidannotations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excilys/androidannotations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excilys/androidannotations/teams","hooks_url":"https://api.github.com/repos/excilys/androidannotations/hooks","issue_events_url":"https://api.github.com/repos/excilys/androidannotations/issues/events{/number}","events_url":"https://api.github.com/repos/excilys/androidannotations/events","assignees_url":"https://api.github.com/repos/excilys/androidannotations/assignees{/user}","branches_url":"https://api.github.com/repos/excilys/androidannotations/branches{/branch}","tags_url":"https://api.github.com/repos/excilys/androidannotations/tags","blobs_url":"https://api.github.com/repos/excilys/androidannotations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excilys/androidannotations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excilys/androidannotations/git/refs{/sha}","trees_url":"https://api.github.com/repos/excilys/androidannotations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excilys/androidannotations/statuses/{sha}","languages_url":"https://api.github.com/repos/excilys/androidannotations/languages","stargazers_url":"https://api.github.com/repos/excilys/androidannotations/stargazers","contributors_url":"https://api.github.com/repos/excilys/androidannotations/contributors","subscribers_url":"https://api.github.com/repos/excilys/androidannotations/subscribers","subscription_url":"https://api.github.com/repos/excilys/androidannotations/subscription","commits_url":"https://api.github.com/repos/excilys/androidannotations/commits{/sha}","git_commits_url":"https://api.github.com/repos/excilys/androidannotations/git/commits{/sha}","comments_url":"https://api.github.com/repos/excilys/androidannotations/comments{/number}","issue_comment_url":"https://api.github.com/repos/excilys/androidannotations/issues/comments{/number}","contents_url":"https://api.github.com/repos/excilys/androidannotations/contents/{+path}","compare_url":"https://api.github.com/repos/excilys/androidannotations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excilys/androidannotations/merges","archive_url":"https://api.github.com/repos/excilys/androidannotations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excilys/androidannotations/downloads","issues_url":"https://api.github.com/repos/excilys/androidannotations/issues{/number}","pulls_url":"https://api.github.com/repos/excilys/androidannotations/pulls{/number}","milestones_url":"https://api.github.com/repos/excilys/androidannotations/milestones{/number}","notifications_url":"https://api.github.com/repos/excilys/androidannotations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excilys/androidannotations/labels{/name}","releases_url":"https://api.github.com/repos/excilys/androidannotations/releases{/id}","created_at":"2012-01-06T08:48:03Z","updated_at":"2015-12-19T13:44:35Z","pushed_at":"2015-12-19T14:42:24Z","git_url":"git://github.com/excilys/androidannotations.git","ssh_url":"git@github.com:excilys/androidannotations.git","clone_url":"https://github.com/excilys/androidannotations.git","svn_url":"https://github.com/excilys/androidannotations","homepage":"http://androidannotations.org","size":23229,"stargazers_count":6635,"watchers_count":6635,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1910,"mirror_url":null,"open_issues_count":47,"forks":1910,"open_issues":47,"watchers":6635,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1457"},"html":{"href":"https://github.com/excilys/androidannotations/pull/1457"},"issue":{"href":"https://api.github.com/repos/excilys/androidannotations/issues/1457"},"comments":{"href":"https://api.github.com/repos/excilys/androidannotations/issues/1457/comments"},"review_comments":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1457/comments"},"review_comment":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/excilys/androidannotations/pulls/1457/commits"},"statuses":{"href":"https://api.github.com/repos/excilys/androidannotations/statuses/eff292115f0251116f64c64c118c7408a6331594"}}}}