{"action":"created","issue":{"url":"https://api.github.com/repos/fusionapp/fusion-index/issues/5","labels_url":"https://api.github.com/repos/fusionapp/fusion-index/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/fusionapp/fusion-index/issues/5/comments","events_url":"https://api.github.com/repos/fusionapp/fusion-index/issues/5/events","html_url":"https://github.com/fusionapp/fusion-index/pull/5","id":107625934,"number":5,"title":"Implement the search index.","user":{"login":"mithrandi","id":856430,"avatar_url":"https://avatars.githubusercontent.com/u/856430?v=3","gravatar_id":"","url":"https://api.github.com/users/mithrandi","html_url":"https://github.com/mithrandi","followers_url":"https://api.github.com/users/mithrandi/followers","following_url":"https://api.github.com/users/mithrandi/following{/other_user}","gists_url":"https://api.github.com/users/mithrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mithrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mithrandi/subscriptions","organizations_url":"https://api.github.com/users/mithrandi/orgs","repos_url":"https://api.github.com/users/mithrandi/repos","events_url":"https://api.github.com/users/mithrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mithrandi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-22T00:50:30Z","updated_at":"2015-09-22T19:53:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fusionapp/fusion-index/pulls/5","html_url":"https://github.com/fusionapp/fusion-index/pull/5","diff_url":"https://github.com/fusionapp/fusion-index/pull/5.diff","patch_url":"https://github.com/fusionapp/fusion-index/pull/5.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/fusionapp/fusion-index/5)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fusionapp/fusion-index/issues/comments/142400306","html_url":"https://github.com/fusionapp/fusion-index/pull/5#issuecomment-142400306","issue_url":"https://api.github.com/repos/fusionapp/fusion-index/issues/5","id":142400306,"user":{"login":"mithrandi","id":856430,"avatar_url":"https://avatars.githubusercontent.com/u/856430?v=3","gravatar_id":"","url":"https://api.github.com/users/mithrandi","html_url":"https://github.com/mithrandi","followers_url":"https://api.github.com/users/mithrandi/followers","following_url":"https://api.github.com/users/mithrandi/following{/other_user}","gists_url":"https://api.github.com/users/mithrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mithrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mithrandi/subscriptions","organizations_url":"https://api.github.com/users/mithrandi/orgs","repos_url":"https://api.github.com/users/mithrandi/repos","events_url":"https://api.github.com/users/mithrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mithrandi/received_events","type":"User","site_admin":false},"created_at":"2015-09-22T19:53:13Z","updated_at":"2015-09-22T19:53:13Z","body":"\n\n\n\nReview status: 3 of 7 files reviewed at latest revision, 5 unresolved discussions, some commit checks pending.\n\n---\n\n<sup>**[fusion_index/resource.py, line 79 \\[r2\\]](https://reviewable.io:443/reviews/fusionapp/fusion-index/5#-Jzpqajpo_9WqQGyHqYp)** ([raw file](https://github.com/fusionapp/fusion-index/blob/93afc4b3e71099335a778bd01a280d2c62f13c82/fusion_index/resource.py#L79)):</sup>\nI made the code catch the exception and return `NotFound`.\n\n---\n\n<sup>**[fusion_index/search.py, line 25 \\[r2\\]](https://reviewable.io:443/reviews/fusionapp/fusion-index/5#-Jzpy9_f5-Qm7QDIxgIy)** ([raw file](https://github.com/fusionapp/fusion-index/blob/93afc4b3e71099335a778bd01a280d2c62f13c82/fusion_index/search.py#L25)):</sup>\nAdded some missing prose here.\n\n---\n\n<sup>**[fusion_index/search.py, line 44 \\[r2\\]](https://reviewable.io:443/reviews/fusionapp/fusion-index/5#-JzpyxrBIIGto5Urtl26)** ([raw file](https://github.com/fusionapp/fusion-index/blob/93afc4b3e71099335a778bd01a280d2c62f13c82/fusion_index/search.py#L44)):</sup>\nGood point, I changed it here as well as in the lookup docs.\n\n---\n\n<sup>**[fusion_index/test/test_resource.py, line 103 \\[r2\\]](https://reviewable.io:443/reviews/fusionapp/fusion-index/5#-JzqU0ryvz4uzgOV-kzY)** ([raw file](https://github.com/fusionapp/fusion-index/blob/93afc4b3e71099335a778bd01a280d2c62f13c82/fusion_index/test/test_resource.py#L103)):</sup>\nI uppercased the names.\n\n---\n\n<sup>**[fusion_index/test/test_resource.py, line 301 \\[r2\\]](https://reviewable.io:443/reviews/fusionapp/fusion-index/5#-JzqUse2P6_5LPiIMTM8)** ([raw file](https://github.com/fusionapp/fusion-index/blob/93afc4b3e71099335a778bd01a280d2c62f13c82/fusion_index/test/test_resource.py#L301)):</sup>\nI added some logging testing to `test_exactAndPrefix` which does prefix tests, so there's a bit more coverage now.\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/fusionapp/fusion-index/5)\n<!-- Sent from Reviewable.io -->\n"}}