{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/8","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/8/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/8/events","html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/8","id":74980810,"number":8,"title":"[WIP] refactor plugin shutdown","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/labels/shutdown%20semantics","name":"shutdown semantics","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-05-10T19:13:10Z","updated_at":"2015-09-24T13:50:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/8","html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/8","diff_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/8.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/8.patch"},"body":"refactor for the new shutdown semantic.\r\n\r\nnote that the specs were not refactored as a whole be new specs were added, using the new style, based on the udp input specs. some TODOs have been commented to note some duplicate code and DRYing that we could do in a followup issue/PR."},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/comments/142933598","html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/8#issuecomment-142933598","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/8","id":142933598,"user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T13:50:37Z","updated_at":"2015-09-24T13:50:37Z","body":"Running with --debug I get it repeating the INFLIGHT EVENTS REPORT message\r\n\r\n```\r\nAccepted connection {:client=>\"127.0.0.1:62233\", :server=>\"0.0.0.0:48607\", :level=>:debug, :file=>\"logstash/inputs/tcp.rb\", :line=>\"177\", :method=>\"block in server_connection_thread\"}\r\nconfig LogStash::Codecs::Line/@charset = \"UTF-8\" {:level=>:debug, :file=>\"logstash/config/mixin.rb\", :line=>\"111\", :method=>\"block in config_init\"}\r\nstopping {:plugin=><LogStash::Inputs::Tcp port=>48607, debug=>false, codec=><LogStash::Codecs::Line charset=>\"UTF-8\">, host=>\"0.0.0.0\", data_timeout=>-1, mode=>\"server\", ssl_enable=>false, ssl_verify=>false, ssl_key_passphrase=><password>>, :level=>:debug, :file=>\"logstash/inputs/base.rb\", :line=>\"115\", :method=>\"do_stop\"}\r\n[\"INFLIGHT_EVENTS_REPORT\", \"2015-09-24T08:45:33-05:00\", {\"input_to_filter\"=>0, \"filter_to_output\"=>0, \"outputs\"=>[]}] {:level=>:warn, :file=>\"logstash/util/reporter.rb\", :line=>\"26\", :method=>\"report\"}\r\n[\"INFLIGHT_EVENTS_REPORT\", \"2015-09-24T08:45:33-05:00\", {\"input_to_filter\"=>0, \"filter_to_output\"=>0, \"outputs\"=>[]}] {:level=>:warn, :file=>\"logstash/util/reporter.rb\", :line=>\"26\", :method=>\"report\"}\r\n```\r\n\r\nThat's where it hangs"}}