{"action":"created","issue":{"url":"https://api.github.com/repos/ktbyers/netmiko/issues/133","labels_url":"https://api.github.com/repos/ktbyers/netmiko/issues/133/labels{/name}","comments_url":"https://api.github.com/repos/ktbyers/netmiko/issues/133/comments","events_url":"https://api.github.com/repos/ktbyers/netmiko/issues/133/events","html_url":"https://github.com/ktbyers/netmiko/pull/133","id":117537953,"number":133,"title":"OpenSSH Configuration Support (#131)","user":{"login":"coxley","id":8285973,"avatar_url":"https://avatars.githubusercontent.com/u/8285973?v=3","gravatar_id":"","url":"https://api.github.com/users/coxley","html_url":"https://github.com/coxley","followers_url":"https://api.github.com/users/coxley/followers","following_url":"https://api.github.com/users/coxley/following{/other_user}","gists_url":"https://api.github.com/users/coxley/gists{/gist_id}","starred_url":"https://api.github.com/users/coxley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coxley/subscriptions","organizations_url":"https://api.github.com/users/coxley/orgs","repos_url":"https://api.github.com/users/coxley/repos","events_url":"https://api.github.com/users/coxley/events{/privacy}","received_events_url":"https://api.github.com/users/coxley/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-11-18T08:28:31Z","updated_at":"2015-12-04T23:04:33Z","closed_at":"2015-12-04T23:03:31Z","pull_request":{"url":"https://api.github.com/repos/ktbyers/netmiko/pulls/133","html_url":"https://github.com/ktbyers/netmiko/pull/133","diff_url":"https://github.com/ktbyers/netmiko/pull/133.diff","patch_url":"https://github.com/ktbyers/netmiko/pull/133.patch"},"body":"This has been implemented by outsourcing paramiko.SSHClient.connect(**kwargs)\r\nto a private method ._return_config()\r\n\r\nNot only will this give a more central place to tweak client configuration in\r\nthe future, but it serves a nice place to do some conditions and openssh cfg\r\nfile reading thanks to paramiko.SSHConfig\r\n\r\nAs of this commit, ssh_config_path is an __init__ arg defaulting to ~/.ssh/config.\r\nIf an unparsable ssh config is passed, Exception will be thrown. We can easily\r\ncapture this and error something better if needed, but it's a straightfwd error.\r\n\r\nOn top of proxycommand support, there is now support for Host Aliasing within\r\na user SSH config. The only drawback/discussion might need of this is whether\r\nto log the provided hostname or the resolved one (and port).\r\n\r\nUsername will also be favored from the config if provided under the Host block."},"comment":{"url":"https://api.github.com/repos/ktbyers/netmiko/issues/comments/162105936","html_url":"https://github.com/ktbyers/netmiko/pull/133#issuecomment-162105936","issue_url":"https://api.github.com/repos/ktbyers/netmiko/issues/133","id":162105936,"user":{"login":"ktbyers","id":899716,"avatar_url":"https://avatars.githubusercontent.com/u/899716?v=3","gravatar_id":"","url":"https://api.github.com/users/ktbyers","html_url":"https://github.com/ktbyers","followers_url":"https://api.github.com/users/ktbyers/followers","following_url":"https://api.github.com/users/ktbyers/following{/other_user}","gists_url":"https://api.github.com/users/ktbyers/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbyers/subscriptions","organizations_url":"https://api.github.com/users/ktbyers/orgs","repos_url":"https://api.github.com/users/ktbyers/repos","events_url":"https://api.github.com/users/ktbyers/events{/privacy}","received_events_url":"https://api.github.com/users/ktbyers/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T23:04:33Z","updated_at":"2015-12-04T23:04:33Z","body":"@coxley I pushed up a possible solution to this. Please check as I changed things meaningfully. I haven't tested it against an SSH 'config' file.\r\n\r\nI am regression testing it now."}}