{"action":"closed","number":1032,"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032","id":29597161,"html_url":"https://github.com/tmpvar/jsdom/pull/1032","diff_url":"https://github.com/tmpvar/jsdom/pull/1032.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/1032.patch","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1032","number":1032,"state":"closed","locked":false,"title":"Location.prototype.reload leaks a global \"errors\"","user":{"login":"Sebmaster","id":347870,"avatar_url":"https://avatars.githubusercontent.com/u/347870?v=3","gravatar_id":"","url":"https://api.github.com/users/Sebmaster","html_url":"https://github.com/Sebmaster","followers_url":"https://api.github.com/users/Sebmaster/followers","following_url":"https://api.github.com/users/Sebmaster/following{/other_user}","gists_url":"https://api.github.com/users/Sebmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebmaster/subscriptions","organizations_url":"https://api.github.com/users/Sebmaster/orgs","repos_url":"https://api.github.com/users/Sebmaster/repos","events_url":"https://api.github.com/users/Sebmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Sebmaster/received_events","type":"User","site_admin":false},"body":"Hey,\r\n\r\nI'm not precisely sure why, but calling `window.location.reload` leaks `errors` to the global scope:\r\n\r\n```\r\n> require(\"jsdom\").jsdom().parentWindow.location.reload()\r\nundefined\r\n> global.errors\r\n[ { type: 'error',\r\n    message: 'NOT IMPLEMENTED: location.reload',\r\n    data: null } ]\r\n```\r\n\r\nAdding some sort of an automatic globals checking to your test suite can catch this quickly in the future.","created_at":"2015-02-19T09:38:12Z","updated_at":"2015-02-20T18:28:18Z","closed_at":"2015-02-20T18:28:18Z","merged_at":null,"merge_commit_sha":"de72757553c4e635ec2cc269fdf614ce370dc970","assignee":null,"milestone":{"url":"https://api.github.com/repos/tmpvar/jsdom/milestones/6","labels_url":"https://api.github.com/repos/tmpvar/jsdom/milestones/6/labels","id":988052,"number":6,"title":"3.x","description":"Maintenance patches for 3.x branch","creator":{"login":"Sebmaster","id":347870,"avatar_url":"https://avatars.githubusercontent.com/u/347870?v=3","gravatar_id":"","url":"https://api.github.com/users/Sebmaster","html_url":"https://github.com/Sebmaster","followers_url":"https://api.github.com/users/Sebmaster/followers","following_url":"https://api.github.com/users/Sebmaster/following{/other_user}","gists_url":"https://api.github.com/users/Sebmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/Sebmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sebmaster/subscriptions","organizations_url":"https://api.github.com/users/Sebmaster/orgs","repos_url":"https://api.github.com/users/Sebmaster/repos","events_url":"https://api.github.com/users/Sebmaster/events{/privacy}","received_events_url":"https://api.github.com/users/Sebmaster/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2015-02-20T09:48:00Z","updated_at":"2015-02-20T18:28:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1032/comments","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/095412c6e4f54200407a4317c648751394c1a794","head":{"label":"fix/global-errors","ref":"fix/global-errors","sha":"095412c6e4f54200407a4317c648751394c1a794","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2015-02-20T18:28:18Z","pushed_at":"2015-02-20T18:28:18Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":15882,"stargazers_count":3836,"watchers_count":3836,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":447,"mirror_url":null,"open_issues_count":128,"forks":447,"open_issues":128,"watchers":3836,"default_branch":"master"}},"base":{"label":"master","ref":"master","sha":"6d3e4792de14f9a0a05062492850f782c445b818","user":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"repo":{"id":478584,"name":"jsdom","full_name":"tmpvar/jsdom","owner":{"login":"tmpvar","id":46673,"avatar_url":"https://avatars.githubusercontent.com/u/46673?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpvar","html_url":"https://github.com/tmpvar","followers_url":"https://api.github.com/users/tmpvar/followers","following_url":"https://api.github.com/users/tmpvar/following{/other_user}","gists_url":"https://api.github.com/users/tmpvar/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpvar/subscriptions","organizations_url":"https://api.github.com/users/tmpvar/orgs","repos_url":"https://api.github.com/users/tmpvar/repos","events_url":"https://api.github.com/users/tmpvar/events{/privacy}","received_events_url":"https://api.github.com/users/tmpvar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmpvar/jsdom","description":"A javascript implementation of the DOM, for use with node.js.","fork":false,"url":"https://api.github.com/repos/tmpvar/jsdom","forks_url":"https://api.github.com/repos/tmpvar/jsdom/forks","keys_url":"https://api.github.com/repos/tmpvar/jsdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmpvar/jsdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmpvar/jsdom/teams","hooks_url":"https://api.github.com/repos/tmpvar/jsdom/hooks","issue_events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/events{/number}","events_url":"https://api.github.com/repos/tmpvar/jsdom/events","assignees_url":"https://api.github.com/repos/tmpvar/jsdom/assignees{/user}","branches_url":"https://api.github.com/repos/tmpvar/jsdom/branches{/branch}","tags_url":"https://api.github.com/repos/tmpvar/jsdom/tags","blobs_url":"https://api.github.com/repos/tmpvar/jsdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmpvar/jsdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmpvar/jsdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmpvar/jsdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmpvar/jsdom/statuses/{sha}","languages_url":"https://api.github.com/repos/tmpvar/jsdom/languages","stargazers_url":"https://api.github.com/repos/tmpvar/jsdom/stargazers","contributors_url":"https://api.github.com/repos/tmpvar/jsdom/contributors","subscribers_url":"https://api.github.com/repos/tmpvar/jsdom/subscribers","subscription_url":"https://api.github.com/repos/tmpvar/jsdom/subscription","commits_url":"https://api.github.com/repos/tmpvar/jsdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmpvar/jsdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments/{number}","contents_url":"https://api.github.com/repos/tmpvar/jsdom/contents/{+path}","compare_url":"https://api.github.com/repos/tmpvar/jsdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmpvar/jsdom/merges","archive_url":"https://api.github.com/repos/tmpvar/jsdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmpvar/jsdom/downloads","issues_url":"https://api.github.com/repos/tmpvar/jsdom/issues{/number}","pulls_url":"https://api.github.com/repos/tmpvar/jsdom/pulls{/number}","milestones_url":"https://api.github.com/repos/tmpvar/jsdom/milestones{/number}","notifications_url":"https://api.github.com/repos/tmpvar/jsdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmpvar/jsdom/labels{/name}","releases_url":"https://api.github.com/repos/tmpvar/jsdom/releases{/id}","created_at":"2010-01-19T06:55:19Z","updated_at":"2015-02-20T18:28:18Z","pushed_at":"2015-02-20T18:28:18Z","git_url":"git://github.com/tmpvar/jsdom.git","ssh_url":"git@github.com:tmpvar/jsdom.git","clone_url":"https://github.com/tmpvar/jsdom.git","svn_url":"https://github.com/tmpvar/jsdom","homepage":"","size":15882,"stargazers_count":3836,"watchers_count":3836,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":447,"mirror_url":null,"open_issues_count":128,"forks":447,"open_issues":128,"watchers":3836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032"},"html":{"href":"https://github.com/tmpvar/jsdom/pull/1032"},"issue":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1032"},"comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/tmpvar/jsdom/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/tmpvar/jsdom/statuses/095412c6e4f54200407a4317c648751394c1a794"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}