{"action":"created","comment":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/48389937","id":48389937,"diff_hunk":"@@ -89,42 +90,38 @@ bool SysAlarmsMessagingPlugin::initialize(const QStringList &arguments, QString\n  */\n void SysAlarmsMessagingPlugin::updateAlarms(UAVObject* systemAlarm)\n {\n-    Q_ASSERT(systemAlarm->getObjID() == SystemAlarms::OBJID);","path":"ground/gcs/src/plugins/sysalarmsmessaging/sysalarmsmessagingplugin.cpp","position":12,"original_position":12,"commit_id":"ce31fc09187638b2327c003690be24bb9310a93d","original_commit_id":"ce31fc09187638b2327c003690be24bb9310a93d","user":{"login":"mlyle","id":90903,"avatar_url":"https://avatars.githubusercontent.com/u/90903?v=3","gravatar_id":"","url":"https://api.github.com/users/mlyle","html_url":"https://github.com/mlyle","followers_url":"https://api.github.com/users/mlyle/followers","following_url":"https://api.github.com/users/mlyle/following{/other_user}","gists_url":"https://api.github.com/users/mlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/mlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlyle/subscriptions","organizations_url":"https://api.github.com/users/mlyle/orgs","repos_url":"https://api.github.com/users/mlyle/repos","events_url":"https://api.github.com/users/mlyle/events{/privacy}","received_events_url":"https://api.github.com/users/mlyle/received_events","type":"User","site_admin":false},"body":"The proper safe way is to use DEPENDPATH in the qt project files so that header dependencies aren't ignored like they are currently.","created_at":"2015-12-24T00:56:13Z","updated_at":"2015-12-24T00:56:13Z","html_url":"https://github.com/TauLabs/TauLabs/pull/2113#discussion_r48389937","pull_request_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113","_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments/48389937"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/2113#discussion_r48389937"},"pull_request":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113"}}},"pull_request":{"url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113","id":54516973,"html_url":"https://github.com/TauLabs/TauLabs/pull/2113","diff_url":"https://github.com/TauLabs/TauLabs/pull/2113.diff","patch_url":"https://github.com/TauLabs/TauLabs/pull/2113.patch","issue_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/2113","number":2113,"state":"open","locked":false,"title":"Sysalarms: only test the field named \"Alarm\"","user":{"login":"kubark42","id":1118185,"avatar_url":"https://avatars.githubusercontent.com/u/1118185?v=3","gravatar_id":"","url":"https://api.github.com/users/kubark42","html_url":"https://github.com/kubark42","followers_url":"https://api.github.com/users/kubark42/followers","following_url":"https://api.github.com/users/kubark42/following{/other_user}","gists_url":"https://api.github.com/users/kubark42/gists{/gist_id}","starred_url":"https://api.github.com/users/kubark42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubark42/subscriptions","organizations_url":"https://api.github.com/users/kubark42/orgs","repos_url":"https://api.github.com/users/kubark42/repos","events_url":"https://api.github.com/users/kubark42/events{/privacy}","received_events_url":"https://api.github.com/users/kubark42/received_events","type":"User","site_admin":false},"body":"Corrects a bug that I introduced years ago with the error codes, but it was only obvious earlier this year. \r\nThe problem was that the code was testing all the fields in the UAVObject, so the solution is to only test the \"Alarm\" field.\r\n\r\nSee https://github.com/d-ronin/dRonin/pull/310","created_at":"2015-12-24T00:06:55Z","updated_at":"2015-12-24T00:56:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8ff7d87cba0ef4f2cb1ec06eff4591f271173b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113/commits","review_comments_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113/comments","review_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/2113/comments","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/ce31fc09187638b2327c003690be24bb9310a93d","head":{"label":"cyphyworks:mpl-0warnin","ref":"mpl-0warnin","sha":"ce31fc09187638b2327c003690be24bb9310a93d","user":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"repo":{"id":41383980,"name":"TauLabs","full_name":"cyphyworks/TauLabs","owner":{"login":"cyphyworks","id":12955453,"avatar_url":"https://avatars.githubusercontent.com/u/12955453?v=3","gravatar_id":"","url":"https://api.github.com/users/cyphyworks","html_url":"https://github.com/cyphyworks","followers_url":"https://api.github.com/users/cyphyworks/followers","following_url":"https://api.github.com/users/cyphyworks/following{/other_user}","gists_url":"https://api.github.com/users/cyphyworks/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphyworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphyworks/subscriptions","organizations_url":"https://api.github.com/users/cyphyworks/orgs","repos_url":"https://api.github.com/users/cyphyworks/repos","events_url":"https://api.github.com/users/cyphyworks/events{/privacy}","received_events_url":"https://api.github.com/users/cyphyworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyphyworks/TauLabs","description":"","fork":true,"url":"https://api.github.com/repos/cyphyworks/TauLabs","forks_url":"https://api.github.com/repos/cyphyworks/TauLabs/forks","keys_url":"https://api.github.com/repos/cyphyworks/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyphyworks/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyphyworks/TauLabs/teams","hooks_url":"https://api.github.com/repos/cyphyworks/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/cyphyworks/TauLabs/events","assignees_url":"https://api.github.com/repos/cyphyworks/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/cyphyworks/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/tags","blobs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyphyworks/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/cyphyworks/TauLabs/languages","stargazers_url":"https://api.github.com/repos/cyphyworks/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/cyphyworks/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/cyphyworks/TauLabs/subscription","commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyphyworks/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyphyworks/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyphyworks/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/cyphyworks/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyphyworks/TauLabs/merges","archive_url":"https://api.github.com/repos/cyphyworks/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyphyworks/TauLabs/downloads","issues_url":"https://api.github.com/repos/cyphyworks/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/cyphyworks/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/cyphyworks/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/cyphyworks/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyphyworks/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/cyphyworks/TauLabs/releases{/id}","created_at":"2015-08-25T19:37:29Z","updated_at":"2015-08-25T20:03:35Z","pushed_at":"2015-12-23T23:32:28Z","git_url":"git://github.com/cyphyworks/TauLabs.git","ssh_url":"git@github.com:cyphyworks/TauLabs.git","clone_url":"https://github.com/cyphyworks/TauLabs.git","svn_url":"https://github.com/cyphyworks/TauLabs","homepage":"taulabs.org","size":210641,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TauLabs:next","ref":"next","sha":"42b395d1b8cb9c4d20179c57fa0352a3ee41b00c","user":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":6589168,"name":"TauLabs","full_name":"TauLabs/TauLabs","owner":{"login":"TauLabs","id":3201381,"avatar_url":"https://avatars.githubusercontent.com/u/3201381?v=3","gravatar_id":"","url":"https://api.github.com/users/TauLabs","html_url":"https://github.com/TauLabs","followers_url":"https://api.github.com/users/TauLabs/followers","following_url":"https://api.github.com/users/TauLabs/following{/other_user}","gists_url":"https://api.github.com/users/TauLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/TauLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TauLabs/subscriptions","organizations_url":"https://api.github.com/users/TauLabs/orgs","repos_url":"https://api.github.com/users/TauLabs/repos","events_url":"https://api.github.com/users/TauLabs/events{/privacy}","received_events_url":"https://api.github.com/users/TauLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TauLabs/TauLabs","description":"","fork":false,"url":"https://api.github.com/repos/TauLabs/TauLabs","forks_url":"https://api.github.com/repos/TauLabs/TauLabs/forks","keys_url":"https://api.github.com/repos/TauLabs/TauLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TauLabs/TauLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TauLabs/TauLabs/teams","hooks_url":"https://api.github.com/repos/TauLabs/TauLabs/hooks","issue_events_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/events{/number}","events_url":"https://api.github.com/repos/TauLabs/TauLabs/events","assignees_url":"https://api.github.com/repos/TauLabs/TauLabs/assignees{/user}","branches_url":"https://api.github.com/repos/TauLabs/TauLabs/branches{/branch}","tags_url":"https://api.github.com/repos/TauLabs/TauLabs/tags","blobs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TauLabs/TauLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TauLabs/TauLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TauLabs/TauLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TauLabs/TauLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/TauLabs/TauLabs/languages","stargazers_url":"https://api.github.com/repos/TauLabs/TauLabs/stargazers","contributors_url":"https://api.github.com/repos/TauLabs/TauLabs/contributors","subscribers_url":"https://api.github.com/repos/TauLabs/TauLabs/subscribers","subscription_url":"https://api.github.com/repos/TauLabs/TauLabs/subscription","commits_url":"https://api.github.com/repos/TauLabs/TauLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TauLabs/TauLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TauLabs/TauLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TauLabs/TauLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TauLabs/TauLabs/contents/{+path}","compare_url":"https://api.github.com/repos/TauLabs/TauLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TauLabs/TauLabs/merges","archive_url":"https://api.github.com/repos/TauLabs/TauLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TauLabs/TauLabs/downloads","issues_url":"https://api.github.com/repos/TauLabs/TauLabs/issues{/number}","pulls_url":"https://api.github.com/repos/TauLabs/TauLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/TauLabs/TauLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/TauLabs/TauLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TauLabs/TauLabs/labels{/name}","releases_url":"https://api.github.com/repos/TauLabs/TauLabs/releases{/id}","created_at":"2012-11-08T01:01:18Z","updated_at":"2015-12-18T17:15:57Z","pushed_at":"2015-12-24T00:09:32Z","git_url":"git://github.com/TauLabs/TauLabs.git","ssh_url":"git@github.com:TauLabs/TauLabs.git","clone_url":"https://github.com/TauLabs/TauLabs.git","svn_url":"https://github.com/TauLabs/TauLabs","homepage":"taulabs.org","size":279005,"stargazers_count":304,"watchers_count":304,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":344,"mirror_url":null,"open_issues_count":276,"forks":344,"open_issues":276,"watchers":304,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113"},"html":{"href":"https://github.com/TauLabs/TauLabs/pull/2113"},"issue":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/2113"},"comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/issues/2113/comments"},"review_comments":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113/comments"},"review_comment":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TauLabs/TauLabs/pulls/2113/commits"},"statuses":{"href":"https://api.github.com/repos/TauLabs/TauLabs/statuses/ce31fc09187638b2327c003690be24bb9310a93d"}}}}