{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/31766436","id":31766436,"diff_hunk":"@@ -830,7 +857,7 @@ final void incrementStreamableBytesForTree(int numBytes) {\n         /**\n          * Writes up to the number of bytes from the pending queue. May write less if limited by the writable window, by\n          * the number of pending writes available, or because a frame does not support splitting on arbitrary\n-         * boundaries.\n+         * boundaries. Will return -1 if there are no frames to write.","path":"codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java","position":178,"original_position":178,"commit_id":"677d54f612eb8911bf1085fa197cff21888b685c","original_commit_id":"677d54f612eb8911bf1085fa197cff21888b685c","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"nit `-1` ->  `{@code -1}`.","created_at":"2015-06-04T21:14:40Z","updated_at":"2015-06-04T21:14:40Z","html_url":"https://github.com/netty/netty/pull/3860#discussion_r31766436","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/3860","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/31766436"},"html":{"href":"https://github.com/netty/netty/pull/3860#discussion_r31766436"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/3860"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3860","id":36966883,"html_url":"https://github.com/netty/netty/pull/3860","diff_url":"https://github.com/netty/netty/pull/3860.diff","patch_url":"https://github.com/netty/netty/pull/3860.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3860","number":3860,"state":"open","locked":false,"title":"Make the flow-controllers more 'batchy'","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"body":"- Remote flow controller can merge small writes into a single DATA frame\r\n- Add listener to remote flow-controller that notifies the number of bytes written for a stream.\r\n- Local flow-controller defers writing WINDOW_UPDATE until asked to do so, this allows for a single WINDOW_UPDATE to be written per stream in a read-write cycle as opposed to one update each time the number of returned bytes triggers the threshold.\r\n\r\nThis will improve throughput in a number of ways\r\n- Coalescing payloads into a single DATA frame causes fewer onDataRead calls on the remote side\r\n- Applications can use the flow-controller listener to receive more granular notifications of written bytes rather than listening to each individual payload\r\n- Deferring WINDOW_UPDATE allows more flow-control to be returned to the remote side as all consumed bytes are returned and not just the amount consumed when the threshold was crossed.\r\n\r\nFixes\r\nhttps://github.com/netty/netty/issues/3852","created_at":"2015-06-04T19:01:54Z","updated_at":"2015-06-04T21:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"768ef4a464087222e381f6d440f99ab5ed964c54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/3860/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3860/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3860/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/677d54f612eb8911bf1085fa197cff21888b685c","head":{"label":"louiscryan:CoalescingFlowController","ref":"CoalescingFlowController","sha":"677d54f612eb8911bf1085fa197cff21888b685c","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"repo":{"id":29745959,"name":"netty","full_name":"louiscryan/netty","owner":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/louiscryan/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/louiscryan/netty","forks_url":"https://api.github.com/repos/louiscryan/netty/forks","keys_url":"https://api.github.com/repos/louiscryan/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/louiscryan/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/louiscryan/netty/teams","hooks_url":"https://api.github.com/repos/louiscryan/netty/hooks","issue_events_url":"https://api.github.com/repos/louiscryan/netty/issues/events{/number}","events_url":"https://api.github.com/repos/louiscryan/netty/events","assignees_url":"https://api.github.com/repos/louiscryan/netty/assignees{/user}","branches_url":"https://api.github.com/repos/louiscryan/netty/branches{/branch}","tags_url":"https://api.github.com/repos/louiscryan/netty/tags","blobs_url":"https://api.github.com/repos/louiscryan/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/louiscryan/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/louiscryan/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/louiscryan/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/louiscryan/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/louiscryan/netty/languages","stargazers_url":"https://api.github.com/repos/louiscryan/netty/stargazers","contributors_url":"https://api.github.com/repos/louiscryan/netty/contributors","subscribers_url":"https://api.github.com/repos/louiscryan/netty/subscribers","subscription_url":"https://api.github.com/repos/louiscryan/netty/subscription","commits_url":"https://api.github.com/repos/louiscryan/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/louiscryan/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/louiscryan/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/louiscryan/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/louiscryan/netty/contents/{+path}","compare_url":"https://api.github.com/repos/louiscryan/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/louiscryan/netty/merges","archive_url":"https://api.github.com/repos/louiscryan/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/louiscryan/netty/downloads","issues_url":"https://api.github.com/repos/louiscryan/netty/issues{/number}","pulls_url":"https://api.github.com/repos/louiscryan/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/louiscryan/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/louiscryan/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/louiscryan/netty/labels{/name}","releases_url":"https://api.github.com/repos/louiscryan/netty/releases{/id}","created_at":"2015-01-23T18:13:14Z","updated_at":"2015-05-04T20:10:55Z","pushed_at":"2015-06-04T20:30:01Z","git_url":"git://github.com/louiscryan/netty.git","ssh_url":"git@github.com:louiscryan/netty.git","clone_url":"https://github.com/louiscryan/netty.git","svn_url":"https://github.com/louiscryan/netty","homepage":"http://netty.io/","size":41786,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"e19e1e29d88e4a20324055bf3ad6f369daf15b67","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-06-04T15:45:40Z","pushed_at":"2015-06-04T20:30:06Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":131630,"stargazers_count":4721,"watchers_count":4721,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2326,"mirror_url":null,"open_issues_count":283,"forks":2326,"open_issues":283,"watchers":4721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3860"},"html":{"href":"https://github.com/netty/netty/pull/3860"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3860"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3860/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3860/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3860/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/677d54f612eb8911bf1085fa197cff21888b685c"}}}}