{"action":"created","comment":{"url":"https://api.github.com/repos/youtube/vitess/pulls/comments/33479919","id":33479919,"diff_hunk":"@@ -84,6 +85,11 @@ type RegisterVTGate func(vtgateservice.VTGateService)\n // RegisterVTGates stores register funcs for VTGate server.\n var RegisterVTGates []RegisterVTGate\n \n+var (\n+\t// RPCErrorOnlyInReply informs vtgateservice(s) about how to return errors.\n+\tRPCErrorOnlyInReply = flag.Bool(\"rpc-error-only-in-reply\", false, \"if true, supported RPC calls from vtgateservice(s) will only return errors as part of the RPC server response\")","path":"go/vt/vtgate/vtgate.go","position":14,"original_position":14,"commit_id":"bee894035b5641e13cc9f2fd46fde6f5182e7cb6","original_commit_id":"bee894035b5641e13cc9f2fd46fde6f5182e7cb6","user":{"login":"guoliang100","id":5091016,"avatar_url":"https://avatars.githubusercontent.com/u/5091016?v=3","gravatar_id":"","url":"https://api.github.com/users/guoliang100","html_url":"https://github.com/guoliang100","followers_url":"https://api.github.com/users/guoliang100/followers","following_url":"https://api.github.com/users/guoliang100/following{/other_user}","gists_url":"https://api.github.com/users/guoliang100/gists{/gist_id}","starred_url":"https://api.github.com/users/guoliang100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guoliang100/subscriptions","organizations_url":"https://api.github.com/users/guoliang100/orgs","repos_url":"https://api.github.com/users/guoliang100/repos","events_url":"https://api.github.com/users/guoliang100/events{/privacy}","received_events_url":"https://api.github.com/users/guoliang100/received_events","type":"User","site_admin":false},"body":"Please sync with Jeff, as he thinks we should pass the error back as return value as well.","created_at":"2015-06-29T16:02:59Z","updated_at":"2015-06-29T16:02:59Z","html_url":"https://github.com/youtube/vitess/pull/841#discussion_r33479919","pull_request_url":"https://api.github.com/repos/youtube/vitess/pulls/841","_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments/33479919"},"html":{"href":"https://github.com/youtube/vitess/pull/841#discussion_r33479919"},"pull_request":{"href":"https://api.github.com/repos/youtube/vitess/pulls/841"}}},"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/841","id":38746400,"html_url":"https://github.com/youtube/vitess/pull/841","diff_url":"https://github.com/youtube/vitess/pull/841.diff","patch_url":"https://github.com/youtube/vitess/pull/841.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/841","number":841,"state":"open","locked":false,"title":"Add RPC errors to some VTGate calls","user":{"login":"aaijazi","id":2326899,"avatar_url":"https://avatars.githubusercontent.com/u/2326899?v=3","gravatar_id":"","url":"https://api.github.com/users/aaijazi","html_url":"https://github.com/aaijazi","followers_url":"https://api.github.com/users/aaijazi/followers","following_url":"https://api.github.com/users/aaijazi/following{/other_user}","gists_url":"https://api.github.com/users/aaijazi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaijazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaijazi/subscriptions","organizations_url":"https://api.github.com/users/aaijazi/orgs","repos_url":"https://api.github.com/users/aaijazi/repos","events_url":"https://api.github.com/users/aaijazi/events{/privacy}","received_events_url":"https://api.github.com/users/aaijazi/received_events","type":"User","site_admin":false},"body":"@guoliang100 @alainjobart \r\n\r\nI added an RPCError field to all VTGate non-batch Execute* calls, and polished up tests etc. so that they should all be tested and working. Each change is in a small, self-contained commit for easy reviewing.\r\n\r\nNext, I'm going to do the same for the other non-streaming calls, and finally I'll change the streaming calls. @guoliang100, we should sync up about what changes I should make to Begin/Commit/Rollback.","created_at":"2015-06-29T07:04:15Z","updated_at":"2015-06-29T16:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8b7cf468723493323f1514681d808eb3723556f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/841/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/841/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/841/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/bee894035b5641e13cc9f2fd46fde6f5182e7cb6","head":{"label":"youtube:aaijazi_add_rpc_errors_to_vtgate","ref":"aaijazi_add_rpc_errors_to_vtgate","sha":"bee894035b5641e13cc9f2fd46fde6f5182e7cb6","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-06-27T20:52:55Z","pushed_at":"2015-06-29T07:04:15Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":66863,"stargazers_count":2607,"watchers_count":2607,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":317,"mirror_url":null,"open_issues_count":22,"forks":317,"open_issues":22,"watchers":2607,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"2a5a3b9a28b4db69441fc4da816b1ffe3c0b7cc9","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","created_at":"2013-06-27T21:20:28Z","updated_at":"2015-06-27T20:52:55Z","pushed_at":"2015-06-29T07:04:15Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":66863,"stargazers_count":2607,"watchers_count":2607,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":317,"mirror_url":null,"open_issues_count":22,"forks":317,"open_issues":22,"watchers":2607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/841"},"html":{"href":"https://github.com/youtube/vitess/pull/841"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/841"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/bee894035b5641e13cc9f2fd46fde6f5182e7cb6"}}}}