{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/26458639","id":26458639,"diff_hunk":"@@ -251,6 +251,11 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.position', 'ui.bootstrap\n         $setModelValue(originalScope, model);\n         modelCtrl.$setValidity('editable', true);\n \n+        if (modelCtrl.$$lastCommittedViewValue === modelCtrl.$viewValue) {\n+          // angular will check if model value changed to run validators, so we need to run it manually\n+          modelCtrl.$$runValidators(undefined, modelCtrl.$modelValue, modelCtrl.$viewValue, angular.noop);","path":"src/typeahead/typeahead.js","position":null,"original_position":6,"commit_id":"f0fe60b0c98d7f28d161eca7e969109379d4681f","original_commit_id":"7314b527423713d0d56a5d85a0fb07ec0aeb386d","user":{"login":"sagens42","id":3543513,"avatar_url":"https://avatars.githubusercontent.com/u/3543513?v=3","gravatar_id":"","url":"https://api.github.com/users/sagens42","html_url":"https://github.com/sagens42","followers_url":"https://api.github.com/users/sagens42/followers","following_url":"https://api.github.com/users/sagens42/following{/other_user}","gists_url":"https://api.github.com/users/sagens42/gists{/gist_id}","starred_url":"https://api.github.com/users/sagens42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagens42/subscriptions","organizations_url":"https://api.github.com/users/sagens42/orgs","repos_url":"https://api.github.com/users/sagens42/repos","events_url":"https://api.github.com/users/sagens42/events{/privacy}","received_events_url":"https://api.github.com/users/sagens42/received_events","type":"User","site_admin":false},"body":"Actually I think it's enough to run `$setValidity` for `parse` key","created_at":"2015-03-16T03:57:40Z","updated_at":"2015-03-16T03:57:40Z","html_url":"https://github.com/angular-ui/bootstrap/pull/3352#discussion_r26458639","pull_request_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments/26458639"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3352#discussion_r26458639"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352","id":30309152,"html_url":"https://github.com/angular-ui/bootstrap/pull/3352","diff_url":"https://github.com/angular-ui/bootstrap/pull/3352.diff","patch_url":"https://github.com/angular-ui/bootstrap/pull/3352.patch","issue_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3352","number":3352,"state":"open","locked":false,"title":"fix(typeahead): run validators manually on select","user":{"login":"sagens42","id":3543513,"avatar_url":"https://avatars.githubusercontent.com/u/3543513?v=3","gravatar_id":"","url":"https://api.github.com/users/sagens42","html_url":"https://github.com/sagens42","followers_url":"https://api.github.com/users/sagens42/followers","following_url":"https://api.github.com/users/sagens42/following{/other_user}","gists_url":"https://api.github.com/users/sagens42/gists{/gist_id}","starred_url":"https://api.github.com/users/sagens42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagens42/subscriptions","organizations_url":"https://api.github.com/users/sagens42/orgs","repos_url":"https://api.github.com/users/sagens42/repos","events_url":"https://api.github.com/users/sagens42/events{/privacy}","received_events_url":"https://api.github.com/users/sagens42/received_events","type":"User","site_admin":false},"body":"fix for #3311","created_at":"2015-03-02T18:50:17Z","updated_at":"2015-03-16T03:57:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28260b12aa61e1e508932e404d2d65602e32327a","assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/16","html_url":"https://github.com/angular-ui/bootstrap/milestones/0.13.0","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones/16/labels","id":868464,"number":16,"title":"0.13.0","description":"Milestone for minimal Angular 1.3.x support (Anything that's a genuine blocker for 1.3.x support)","creator":{"login":"chrisirhc","id":132584,"avatar_url":"https://avatars.githubusercontent.com/u/132584?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisirhc","html_url":"https://github.com/chrisirhc","followers_url":"https://api.github.com/users/chrisirhc/followers","following_url":"https://api.github.com/users/chrisirhc/following{/other_user}","gists_url":"https://api.github.com/users/chrisirhc/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisirhc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisirhc/subscriptions","organizations_url":"https://api.github.com/users/chrisirhc/orgs","repos_url":"https://api.github.com/users/chrisirhc/repos","events_url":"https://api.github.com/users/chrisirhc/events{/privacy}","received_events_url":"https://api.github.com/users/chrisirhc/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":32,"state":"open","created_at":"2014-11-16T20:41:18Z","updated_at":"2015-03-15T23:38:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352/commits","review_comments_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352/comments","review_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/3352/comments","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/f0fe60b0c98d7f28d161eca7e969109379d4681f","head":{"label":"sagens42:fix3311","ref":"fix3311","sha":"f0fe60b0c98d7f28d161eca7e969109379d4681f","user":{"login":"sagens42","id":3543513,"avatar_url":"https://avatars.githubusercontent.com/u/3543513?v=3","gravatar_id":"","url":"https://api.github.com/users/sagens42","html_url":"https://github.com/sagens42","followers_url":"https://api.github.com/users/sagens42/followers","following_url":"https://api.github.com/users/sagens42/following{/other_user}","gists_url":"https://api.github.com/users/sagens42/gists{/gist_id}","starred_url":"https://api.github.com/users/sagens42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagens42/subscriptions","organizations_url":"https://api.github.com/users/sagens42/orgs","repos_url":"https://api.github.com/users/sagens42/repos","events_url":"https://api.github.com/users/sagens42/events{/privacy}","received_events_url":"https://api.github.com/users/sagens42/received_events","type":"User","site_admin":false},"repo":{"id":21713208,"name":"bootstrap","full_name":"sagens42/bootstrap","owner":{"login":"sagens42","id":3543513,"avatar_url":"https://avatars.githubusercontent.com/u/3543513?v=3","gravatar_id":"","url":"https://api.github.com/users/sagens42","html_url":"https://github.com/sagens42","followers_url":"https://api.github.com/users/sagens42/followers","following_url":"https://api.github.com/users/sagens42/following{/other_user}","gists_url":"https://api.github.com/users/sagens42/gists{/gist_id}","starred_url":"https://api.github.com/users/sagens42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagens42/subscriptions","organizations_url":"https://api.github.com/users/sagens42/orgs","repos_url":"https://api.github.com/users/sagens42/repos","events_url":"https://api.github.com/users/sagens42/events{/privacy}","received_events_url":"https://api.github.com/users/sagens42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sagens42/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!","fork":true,"url":"https://api.github.com/repos/sagens42/bootstrap","forks_url":"https://api.github.com/repos/sagens42/bootstrap/forks","keys_url":"https://api.github.com/repos/sagens42/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sagens42/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sagens42/bootstrap/teams","hooks_url":"https://api.github.com/repos/sagens42/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/sagens42/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/sagens42/bootstrap/events","assignees_url":"https://api.github.com/repos/sagens42/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/sagens42/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/sagens42/bootstrap/tags","blobs_url":"https://api.github.com/repos/sagens42/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sagens42/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sagens42/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/sagens42/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sagens42/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/sagens42/bootstrap/languages","stargazers_url":"https://api.github.com/repos/sagens42/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/sagens42/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/sagens42/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/sagens42/bootstrap/subscription","commits_url":"https://api.github.com/repos/sagens42/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/sagens42/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/sagens42/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/sagens42/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/sagens42/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/sagens42/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sagens42/bootstrap/merges","archive_url":"https://api.github.com/repos/sagens42/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sagens42/bootstrap/downloads","issues_url":"https://api.github.com/repos/sagens42/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/sagens42/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/sagens42/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/sagens42/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sagens42/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/sagens42/bootstrap/releases{/id}","created_at":"2014-07-10T23:00:32Z","updated_at":"2014-07-10T19:32:50Z","pushed_at":"2015-03-16T03:55:21Z","git_url":"git://github.com/sagens42/bootstrap.git","ssh_url":"git@github.com:sagens42/bootstrap.git","clone_url":"https://github.com/sagens42/bootstrap.git","svn_url":"https://github.com/sagens42/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":3239,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:master","ref":"master","sha":"ab919f9f89aeaaa336b5d3fe1aed1e0617b5a482","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":6094683,"name":"bootstrap","full_name":"angular-ui/bootstrap","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/bootstrap","description":"Native AngularJS (Angular) directives for Bootstrap. Small footprint (5kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!","fork":false,"url":"https://api.github.com/repos/angular-ui/bootstrap","forks_url":"https://api.github.com/repos/angular-ui/bootstrap/forks","keys_url":"https://api.github.com/repos/angular-ui/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/bootstrap/teams","hooks_url":"https://api.github.com/repos/angular-ui/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/bootstrap/events","assignees_url":"https://api.github.com/repos/angular-ui/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/bootstrap/tags","blobs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/bootstrap/languages","stargazers_url":"https://api.github.com/repos/angular-ui/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/bootstrap/subscription","commits_url":"https://api.github.com/repos/angular-ui/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular-ui/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/bootstrap/merges","archive_url":"https://api.github.com/repos/angular-ui/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/bootstrap/downloads","issues_url":"https://api.github.com/repos/angular-ui/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/bootstrap/releases{/id}","created_at":"2012-10-05T18:27:01Z","updated_at":"2015-03-16T00:49:18Z","pushed_at":"2015-03-16T00:49:18Z","git_url":"git://github.com/angular-ui/bootstrap.git","ssh_url":"git@github.com:angular-ui/bootstrap.git","clone_url":"https://github.com/angular-ui/bootstrap.git","svn_url":"https://github.com/angular-ui/bootstrap","homepage":"http://angular-ui.github.io/bootstrap/","size":15679,"stargazers_count":8125,"watchers_count":8125,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4308,"mirror_url":null,"open_issues_count":706,"forks":4308,"open_issues":706,"watchers":8125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352"},"html":{"href":"https://github.com/angular-ui/bootstrap/pull/3352"},"issue":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3352"},"comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/issues/3352/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/bootstrap/pulls/3352/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/bootstrap/statuses/f0fe60b0c98d7f28d161eca7e969109379d4681f"}}}}