{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments/36801288","id":36801288,"diff_hunk":"@@ -23,6 +23,7 @@ def test_dict():\n     assert isinstance(json_obj['foo'], jsonref.JsonRef)\n \n     replace_jsonref_proxies(json_obj)\n+    assert not isinstance(json_obj['foo'], jsonref.JsonRef)\n     assert isinstance(json_obj['foo'], dict)\n ","path":"tests/spec/replace_jsonref_proxies_test.py","position":6,"original_position":6,"commit_id":"bbf3d9dc41e168eadf4ba1cdd1b1d273dd3e7a78","original_commit_id":"bbf3d9dc41e168eadf4ba1cdd1b1d273dd3e7a78","user":{"login":"analogue","id":26757,"avatar_url":"https://avatars.githubusercontent.com/u/26757?v=3","gravatar_id":"","url":"https://api.github.com/users/analogue","html_url":"https://github.com/analogue","followers_url":"https://api.github.com/users/analogue/followers","following_url":"https://api.github.com/users/analogue/following{/other_user}","gists_url":"https://api.github.com/users/analogue/gists{/gist_id}","starred_url":"https://api.github.com/users/analogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogue/subscriptions","organizations_url":"https://api.github.com/users/analogue/orgs","repos_url":"https://api.github.com/users/analogue/repos","events_url":"https://api.github.com/users/analogue/events{/privacy}","received_events_url":"https://api.github.com/users/analogue/received_events","type":"User","site_admin":false},"body":"Why not tighten it up to match the actual instance type since ```isinstance``` is true for subclassses as well. I  assume thats is why the original assertion didn't catch this? Something like \r\n\r\n```assert type(json_obj['foo']) == <actual type>```","created_at":"2015-08-11T21:26:35Z","updated_at":"2015-08-11T21:26:35Z","html_url":"https://github.com/Yelp/bravado-core/pull/41#discussion_r36801288","pull_request_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments/36801288"},"html":{"href":"https://github.com/Yelp/bravado-core/pull/41#discussion_r36801288"},"pull_request":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/bravado-core/pulls/41","id":42178537,"html_url":"https://github.com/Yelp/bravado-core/pull/41","diff_url":"https://github.com/Yelp/bravado-core/pull/41.diff","patch_url":"https://github.com/Yelp/bravado-core/pull/41.patch","issue_url":"https://api.github.com/repos/Yelp/bravado-core/issues/41","number":41,"state":"open","locked":false,"title":"Dereference elements from a list. Fixes #40.","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"body":"- Fixes #40\r\n- Dereference from dict was happening but not from list.\r\n- If `assert not isinstance(json_obj['foo'][0], jsonref.JsonRef)` was added at L93 to `tests/spec/replace_jsonref_proxies_test.py`, it would fail. It passes now.","created_at":"2015-08-11T21:11:28Z","updated_at":"2015-08-11T21:26:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a25a80d86a12e593ac31743d6047bbd7076eb047","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/41/commits","review_comments_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/41/comments","review_comment_url":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/bravado-core/issues/41/comments","statuses_url":"https://api.github.com/repos/Yelp/bravado-core/statuses/bbf3d9dc41e168eadf4ba1cdd1b1d273dd3e7a78","head":{"label":"prat0318:40_list_elements_dereference","ref":"40_list_elements_dereference","sha":"bbf3d9dc41e168eadf4ba1cdd1b1d273dd3e7a78","user":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"repo":{"id":38846518,"name":"bravado-core","full_name":"prat0318/bravado-core","owner":{"login":"prat0318","id":1528697,"avatar_url":"https://avatars.githubusercontent.com/u/1528697?v=3","gravatar_id":"","url":"https://api.github.com/users/prat0318","html_url":"https://github.com/prat0318","followers_url":"https://api.github.com/users/prat0318/followers","following_url":"https://api.github.com/users/prat0318/following{/other_user}","gists_url":"https://api.github.com/users/prat0318/gists{/gist_id}","starred_url":"https://api.github.com/users/prat0318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prat0318/subscriptions","organizations_url":"https://api.github.com/users/prat0318/orgs","repos_url":"https://api.github.com/users/prat0318/repos","events_url":"https://api.github.com/users/prat0318/events{/privacy}","received_events_url":"https://api.github.com/users/prat0318/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prat0318/bravado-core","description":"","fork":true,"url":"https://api.github.com/repos/prat0318/bravado-core","forks_url":"https://api.github.com/repos/prat0318/bravado-core/forks","keys_url":"https://api.github.com/repos/prat0318/bravado-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prat0318/bravado-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prat0318/bravado-core/teams","hooks_url":"https://api.github.com/repos/prat0318/bravado-core/hooks","issue_events_url":"https://api.github.com/repos/prat0318/bravado-core/issues/events{/number}","events_url":"https://api.github.com/repos/prat0318/bravado-core/events","assignees_url":"https://api.github.com/repos/prat0318/bravado-core/assignees{/user}","branches_url":"https://api.github.com/repos/prat0318/bravado-core/branches{/branch}","tags_url":"https://api.github.com/repos/prat0318/bravado-core/tags","blobs_url":"https://api.github.com/repos/prat0318/bravado-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prat0318/bravado-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prat0318/bravado-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/prat0318/bravado-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prat0318/bravado-core/statuses/{sha}","languages_url":"https://api.github.com/repos/prat0318/bravado-core/languages","stargazers_url":"https://api.github.com/repos/prat0318/bravado-core/stargazers","contributors_url":"https://api.github.com/repos/prat0318/bravado-core/contributors","subscribers_url":"https://api.github.com/repos/prat0318/bravado-core/subscribers","subscription_url":"https://api.github.com/repos/prat0318/bravado-core/subscription","commits_url":"https://api.github.com/repos/prat0318/bravado-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/prat0318/bravado-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/prat0318/bravado-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/prat0318/bravado-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/prat0318/bravado-core/contents/{+path}","compare_url":"https://api.github.com/repos/prat0318/bravado-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prat0318/bravado-core/merges","archive_url":"https://api.github.com/repos/prat0318/bravado-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prat0318/bravado-core/downloads","issues_url":"https://api.github.com/repos/prat0318/bravado-core/issues{/number}","pulls_url":"https://api.github.com/repos/prat0318/bravado-core/pulls{/number}","milestones_url":"https://api.github.com/repos/prat0318/bravado-core/milestones{/number}","notifications_url":"https://api.github.com/repos/prat0318/bravado-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prat0318/bravado-core/labels{/name}","releases_url":"https://api.github.com/repos/prat0318/bravado-core/releases{/id}","created_at":"2015-07-09T21:36:48Z","updated_at":"2015-07-09T21:36:48Z","pushed_at":"2015-08-11T21:10:00Z","git_url":"git://github.com/prat0318/bravado-core.git","ssh_url":"git@github.com:prat0318/bravado-core.git","clone_url":"https://github.com/prat0318/bravado-core.git","svn_url":"https://github.com/prat0318/bravado-core","homepage":null,"size":1031,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"34244e8a550cfc27db73bdee13f9a0289c52b845","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":33146014,"name":"bravado-core","full_name":"Yelp/bravado-core","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/bravado-core","description":"","fork":false,"url":"https://api.github.com/repos/Yelp/bravado-core","forks_url":"https://api.github.com/repos/Yelp/bravado-core/forks","keys_url":"https://api.github.com/repos/Yelp/bravado-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/bravado-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/bravado-core/teams","hooks_url":"https://api.github.com/repos/Yelp/bravado-core/hooks","issue_events_url":"https://api.github.com/repos/Yelp/bravado-core/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/bravado-core/events","assignees_url":"https://api.github.com/repos/Yelp/bravado-core/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/bravado-core/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/bravado-core/tags","blobs_url":"https://api.github.com/repos/Yelp/bravado-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/bravado-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/bravado-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/bravado-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/bravado-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/bravado-core/languages","stargazers_url":"https://api.github.com/repos/Yelp/bravado-core/stargazers","contributors_url":"https://api.github.com/repos/Yelp/bravado-core/contributors","subscribers_url":"https://api.github.com/repos/Yelp/bravado-core/subscribers","subscription_url":"https://api.github.com/repos/Yelp/bravado-core/subscription","commits_url":"https://api.github.com/repos/Yelp/bravado-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/bravado-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/bravado-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/bravado-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/bravado-core/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/bravado-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/bravado-core/merges","archive_url":"https://api.github.com/repos/Yelp/bravado-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/bravado-core/downloads","issues_url":"https://api.github.com/repos/Yelp/bravado-core/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/bravado-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/bravado-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/bravado-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/bravado-core/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/bravado-core/releases{/id}","created_at":"2015-03-30T20:23:27Z","updated_at":"2015-07-14T23:06:42Z","pushed_at":"2015-08-11T21:11:29Z","git_url":"git://github.com/Yelp/bravado-core.git","ssh_url":"git@github.com:Yelp/bravado-core.git","clone_url":"https://github.com/Yelp/bravado-core.git","svn_url":"https://github.com/Yelp/bravado-core","homepage":null,"size":1239,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/41"},"html":{"href":"https://github.com/Yelp/bravado-core/pull/41"},"issue":{"href":"https://api.github.com/repos/Yelp/bravado-core/issues/41"},"comments":{"href":"https://api.github.com/repos/Yelp/bravado-core/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/bravado-core/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/bravado-core/statuses/bbf3d9dc41e168eadf4ba1cdd1b1d273dd3e7a78"}}}}