{"action":"created","issue":{"url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/1","labels_url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/1/comments","events_url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/1/events","html_url":"https://github.com/etiktin/node-generate-evb/issues/1","id":105387485,"number":1,"title":"Question regarding the Docs and Enigma VB","user":{"login":"bendulum","id":2833178,"avatar_url":"https://avatars.githubusercontent.com/u/2833178?v=3","gravatar_id":"","url":"https://api.github.com/users/bendulum","html_url":"https://github.com/bendulum","followers_url":"https://api.github.com/users/bendulum/followers","following_url":"https://api.github.com/users/bendulum/following{/other_user}","gists_url":"https://api.github.com/users/bendulum/gists{/gist_id}","starred_url":"https://api.github.com/users/bendulum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendulum/subscriptions","organizations_url":"https://api.github.com/users/bendulum/orgs","repos_url":"https://api.github.com/users/bendulum/repos","events_url":"https://api.github.com/users/bendulum/events{/privacy}","received_events_url":"https://api.github.com/users/bendulum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-08T14:01:02Z","updated_at":"2015-09-08T14:43:36Z","closed_at":null,"body":"First off, thanks for creating this package. I have a question regarding its usage.\r\nI use electron and electron-packager to bundle my app.\r\nThe output directory contains a couple of dll files, locales and resources folders, .. and MyApp.exe which I can start the app with, which works fine.\r\nI have managed to create an installer from this directory using Inno Setup. Everything works fine this way as well.\r\nHowever, I'm trying to create a single portable executable now from that directory using Enigma Virtual Box. For that I'm using the enigmavirtualbox package and your generate-evb package. Unfortunately I get an error message when trying to open the final .exe: `Cannot find function ordinal 345 in library COMCTL32.dll`\r\n\r\n```javascript\r\nvar generateEvb = require('generate-evb');\r\nvar evb = path.resolve('./builds/windows/app.evb');\r\nvar exe = path.resolve('./builds/windows/MyAppBundled/MyApp.exe');\r\nvar result = path.resolve('./portable/MyApp.exe');\r\nvar input = path.resolve('./builds/windows/MyAppBundled');\r\ngenerateEvb(evb, exe, result, input);\r\n```\r\n\r\nMy questions is regarding the docs: _inputExe (String) - the input executable file path. Enigma packs the files from path2pack into a copy of this exe_\r\nDoes this mean that my `path2pack` directory must not contain the `inputExe` itself, which it does in my case? Is Enigma trying to copy my exe file into itself? How would I circumvent this?\r\n\r\nThis is probably not a problem with this package, but I thought you might have an idea! Thanks."},"comment":{"url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/comments/138588294","html_url":"https://github.com/etiktin/node-generate-evb/issues/1#issuecomment-138588294","issue_url":"https://api.github.com/repos/etiktin/node-generate-evb/issues/1","id":138588294,"user":{"login":"etiktin","id":4381579,"avatar_url":"https://avatars.githubusercontent.com/u/4381579?v=3","gravatar_id":"","url":"https://api.github.com/users/etiktin","html_url":"https://github.com/etiktin","followers_url":"https://api.github.com/users/etiktin/followers","following_url":"https://api.github.com/users/etiktin/following{/other_user}","gists_url":"https://api.github.com/users/etiktin/gists{/gist_id}","starred_url":"https://api.github.com/users/etiktin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiktin/subscriptions","organizations_url":"https://api.github.com/users/etiktin/orgs","repos_url":"https://api.github.com/users/etiktin/repos","events_url":"https://api.github.com/users/etiktin/events{/privacy}","received_events_url":"https://api.github.com/users/etiktin/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T14:43:36Z","updated_at":"2015-09-08T14:43:36Z","body":"Hi @bendulum, glad you find it useful :)\r\n\r\n> Does this mean that my path2pack directory must not contain the inputExe itself, which it does in my case?\r\n\r\nYes, you need to make sure that the `inputExe` is not in the `path2pack`. The way to do that currently is to copy the entire folder some where else without the `inputExe` and use that as your `path2pack`. To make it easier in the future, I'll add support for a filter callback.\r\n\r\nAnother thing to consider is that you don't need an asar when using EVB. So instead of holding your app specific code in `app.asar`, you should hold it in an `app` folder.\r\n\r\n> One problem remains, when moving the resulting single executable around it stops working, which might be due to absolute paths being used..\r\n\r\nThat's odd. I just tried to create a packed Electron app myself and it works fine when moved. What happens when you try to run it? If you don't see an exception, try to run it from cmd and maybe it will print something to the console."}}