{"action":"closed","number":146,"pull_request":{"url":"https://api.github.com/repos/optimizely/oui/pulls/146","id":48945517,"html_url":"https://github.com/optimizely/oui/pull/146","diff_url":"https://github.com/optimizely/oui/pull/146.diff","patch_url":"https://github.com/optimizely/oui/pull/146.patch","issue_url":"https://api.github.com/repos/optimizely/oui/issues/146","number":146,"state":"closed","locked":false,"title":"Table scroll","user":{"login":"tomgenoni","id":1171072,"avatar_url":"https://avatars.githubusercontent.com/u/1171072?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgenoni","html_url":"https://github.com/tomgenoni","followers_url":"https://api.github.com/users/tomgenoni/followers","following_url":"https://api.github.com/users/tomgenoni/following{/other_user}","gists_url":"https://api.github.com/users/tomgenoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgenoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgenoni/subscriptions","organizations_url":"https://api.github.com/users/tomgenoni/orgs","repos_url":"https://api.github.com/users/tomgenoni/repos","events_url":"https://api.github.com/users/tomgenoni/events{/privacy}","received_events_url":"https://api.github.com/users/tomgenoni/received_events","type":"User","site_admin":false},"body":"@tscanlin @kwalker3690 @danoc \r\n\r\nOpening PR for discussion, don't merge quite yet. :)\r\n\r\nThis version of the table scrollable is the cleanest I've come up with. But the downsides are:\r\n\r\n- It requires JS to test for \"always on\" scroll bars in OS X. This could be done once and stored in cookie...? This appears to be unavoidable, regardless of implementation.\r\n- Changes the default behavior of the table completely, converting to flexbox. No specific concern here other than it could lead to unknown bugs or unexpected behavior.\r\n- Requires a width on all `th` and `td` elements. \r\n\r\nThis is the cleanest implementation I could come up with but it makes me mildly nervous. Do we want to proceed? ","created_at":"2015-10-27T23:10:38Z","updated_at":"2015-10-29T20:25:50Z","closed_at":"2015-10-29T20:25:50Z","merged_at":"2015-10-29T20:25:50Z","merge_commit_sha":"bdf2d9afcafd8be01c2ae2f0c6ca6c4ee9eb28f3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/optimizely/oui/pulls/146/commits","review_comments_url":"https://api.github.com/repos/optimizely/oui/pulls/146/comments","review_comment_url":"https://api.github.com/repos/optimizely/oui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optimizely/oui/issues/146/comments","statuses_url":"https://api.github.com/repos/optimizely/oui/statuses/122e8c4f3d729aff42c54ecf18a838c8552d8ec2","head":{"label":"optimizely:table-scroll","ref":"table-scroll","sha":"122e8c4f3d729aff42c54ecf18a838c8552d8ec2","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":21479549,"name":"oui","full_name":"optimizely/oui","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/oui","description":"Refactored, component-based Sass/HTML","fork":false,"url":"https://api.github.com/repos/optimizely/oui","forks_url":"https://api.github.com/repos/optimizely/oui/forks","keys_url":"https://api.github.com/repos/optimizely/oui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/oui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/oui/teams","hooks_url":"https://api.github.com/repos/optimizely/oui/hooks","issue_events_url":"https://api.github.com/repos/optimizely/oui/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/oui/events","assignees_url":"https://api.github.com/repos/optimizely/oui/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/oui/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/oui/tags","blobs_url":"https://api.github.com/repos/optimizely/oui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/oui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/oui/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/oui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/oui/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/oui/languages","stargazers_url":"https://api.github.com/repos/optimizely/oui/stargazers","contributors_url":"https://api.github.com/repos/optimizely/oui/contributors","subscribers_url":"https://api.github.com/repos/optimizely/oui/subscribers","subscription_url":"https://api.github.com/repos/optimizely/oui/subscription","commits_url":"https://api.github.com/repos/optimizely/oui/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/oui/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/oui/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/oui/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/oui/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/oui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/oui/merges","archive_url":"https://api.github.com/repos/optimizely/oui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/oui/downloads","issues_url":"https://api.github.com/repos/optimizely/oui/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/oui/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/oui/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/oui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/oui/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/oui/releases{/id}","created_at":"2014-07-03T23:07:34Z","updated_at":"2015-10-27T18:31:40Z","pushed_at":"2015-10-29T20:25:50Z","git_url":"git://github.com/optimizely/oui.git","ssh_url":"git@github.com:optimizely/oui.git","clone_url":"https://github.com/optimizely/oui.git","svn_url":"https://github.com/optimizely/oui","homepage":"","size":5019,"stargazers_count":8,"watchers_count":8,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"optimizely:master","ref":"master","sha":"b1770093dfd76bf01a5afab909a36c21cde3a949","user":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"repo":{"id":21479549,"name":"oui","full_name":"optimizely/oui","owner":{"login":"optimizely","id":1274132,"avatar_url":"https://avatars.githubusercontent.com/u/1274132?v=3","gravatar_id":"","url":"https://api.github.com/users/optimizely","html_url":"https://github.com/optimizely","followers_url":"https://api.github.com/users/optimizely/followers","following_url":"https://api.github.com/users/optimizely/following{/other_user}","gists_url":"https://api.github.com/users/optimizely/gists{/gist_id}","starred_url":"https://api.github.com/users/optimizely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimizely/subscriptions","organizations_url":"https://api.github.com/users/optimizely/orgs","repos_url":"https://api.github.com/users/optimizely/repos","events_url":"https://api.github.com/users/optimizely/events{/privacy}","received_events_url":"https://api.github.com/users/optimizely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optimizely/oui","description":"Refactored, component-based Sass/HTML","fork":false,"url":"https://api.github.com/repos/optimizely/oui","forks_url":"https://api.github.com/repos/optimizely/oui/forks","keys_url":"https://api.github.com/repos/optimizely/oui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optimizely/oui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optimizely/oui/teams","hooks_url":"https://api.github.com/repos/optimizely/oui/hooks","issue_events_url":"https://api.github.com/repos/optimizely/oui/issues/events{/number}","events_url":"https://api.github.com/repos/optimizely/oui/events","assignees_url":"https://api.github.com/repos/optimizely/oui/assignees{/user}","branches_url":"https://api.github.com/repos/optimizely/oui/branches{/branch}","tags_url":"https://api.github.com/repos/optimizely/oui/tags","blobs_url":"https://api.github.com/repos/optimizely/oui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optimizely/oui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optimizely/oui/git/refs{/sha}","trees_url":"https://api.github.com/repos/optimizely/oui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optimizely/oui/statuses/{sha}","languages_url":"https://api.github.com/repos/optimizely/oui/languages","stargazers_url":"https://api.github.com/repos/optimizely/oui/stargazers","contributors_url":"https://api.github.com/repos/optimizely/oui/contributors","subscribers_url":"https://api.github.com/repos/optimizely/oui/subscribers","subscription_url":"https://api.github.com/repos/optimizely/oui/subscription","commits_url":"https://api.github.com/repos/optimizely/oui/commits{/sha}","git_commits_url":"https://api.github.com/repos/optimizely/oui/git/commits{/sha}","comments_url":"https://api.github.com/repos/optimizely/oui/comments{/number}","issue_comment_url":"https://api.github.com/repos/optimizely/oui/issues/comments{/number}","contents_url":"https://api.github.com/repos/optimizely/oui/contents/{+path}","compare_url":"https://api.github.com/repos/optimizely/oui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optimizely/oui/merges","archive_url":"https://api.github.com/repos/optimizely/oui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optimizely/oui/downloads","issues_url":"https://api.github.com/repos/optimizely/oui/issues{/number}","pulls_url":"https://api.github.com/repos/optimizely/oui/pulls{/number}","milestones_url":"https://api.github.com/repos/optimizely/oui/milestones{/number}","notifications_url":"https://api.github.com/repos/optimizely/oui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optimizely/oui/labels{/name}","releases_url":"https://api.github.com/repos/optimizely/oui/releases{/id}","created_at":"2014-07-03T23:07:34Z","updated_at":"2015-10-27T18:31:40Z","pushed_at":"2015-10-29T20:25:50Z","git_url":"git://github.com/optimizely/oui.git","ssh_url":"git@github.com:optimizely/oui.git","clone_url":"https://github.com/optimizely/oui.git","svn_url":"https://github.com/optimizely/oui","homepage":"","size":5019,"stargazers_count":8,"watchers_count":8,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optimizely/oui/pulls/146"},"html":{"href":"https://github.com/optimizely/oui/pull/146"},"issue":{"href":"https://api.github.com/repos/optimizely/oui/issues/146"},"comments":{"href":"https://api.github.com/repos/optimizely/oui/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/optimizely/oui/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/optimizely/oui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optimizely/oui/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/optimizely/oui/statuses/122e8c4f3d729aff42c54ecf18a838c8552d8ec2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomgenoni","id":1171072,"avatar_url":"https://avatars.githubusercontent.com/u/1171072?v=3","gravatar_id":"","url":"https://api.github.com/users/tomgenoni","html_url":"https://github.com/tomgenoni","followers_url":"https://api.github.com/users/tomgenoni/followers","following_url":"https://api.github.com/users/tomgenoni/following{/other_user}","gists_url":"https://api.github.com/users/tomgenoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tomgenoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomgenoni/subscriptions","organizations_url":"https://api.github.com/users/tomgenoni/orgs","repos_url":"https://api.github.com/users/tomgenoni/repos","events_url":"https://api.github.com/users/tomgenoni/events{/privacy}","received_events_url":"https://api.github.com/users/tomgenoni/received_events","type":"User","site_admin":false},"comments":5,"review_comments":8,"commits":6,"additions":198,"deletions":0,"changed_files":4}}