{"action":"created","comment":{"url":"https://api.github.com/repos/clappr/clappr/pulls/comments/46068268","id":46068268,"diff_hunk":"@@ -250,13 +250,23 @@ export default class Player extends BaseObject {\n     this.core.mediaControl.container.stop();\n   }\n \n+  \n+  /**\n+   * seeks the current video (`source`). For example, `player.seek(120)` will seek to second 120 (2minutes) of the current video.\n+   * @method seekSeconds\n+   * @param {Number} time should be a number between 0 and the video duration.\n+   */\n+  seek(time) {\n+    this.core.mediaControl.container.setCurrentTime(time, true);\n+  }\n+\n   /**\n    * seeks the current video (`source`). For example, `player.seek(50)` will seek to the middle of the current video.\n    * @method seek\n    * @param {Number} time should be a number between 0 and 100.\n    */\n-  seek(time) {\n-    this.core.mediaControl.container.setCurrentTime(time);\n+  seekPercentage(percentage) {\n+    this.core.mediaControl.container.setCurrentTime(percentage);","path":"src/components/player.js","position":22,"original_position":22,"commit_id":"8d06491e6366da04b38b9e176a1c229a1355f513","original_commit_id":"8d06491e6366da04b38b9e176a1c229a1355f513","user":{"login":"flavioribeiro","id":244265,"avatar_url":"https://avatars.githubusercontent.com/u/244265?v=3","gravatar_id":"","url":"https://api.github.com/users/flavioribeiro","html_url":"https://github.com/flavioribeiro","followers_url":"https://api.github.com/users/flavioribeiro/followers","following_url":"https://api.github.com/users/flavioribeiro/following{/other_user}","gists_url":"https://api.github.com/users/flavioribeiro/gists{/gist_id}","starred_url":"https://api.github.com/users/flavioribeiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavioribeiro/subscriptions","organizations_url":"https://api.github.com/users/flavioribeiro/orgs","repos_url":"https://api.github.com/users/flavioribeiro/repos","events_url":"https://api.github.com/users/flavioribeiro/events{/privacy}","received_events_url":"https://api.github.com/users/flavioribeiro/received_events","type":"User","site_admin":false},"body":"here, instead of calling `setCurrentTime()` we can create a new method on the container to avoid the flag and the `if`","created_at":"2015-11-27T19:53:20Z","updated_at":"2015-11-27T19:53:20Z","html_url":"https://github.com/clappr/clappr/pull/698#discussion_r46068268","pull_request_url":"https://api.github.com/repos/clappr/clappr/pulls/698","_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments/46068268"},"html":{"href":"https://github.com/clappr/clappr/pull/698#discussion_r46068268"},"pull_request":{"href":"https://api.github.com/repos/clappr/clappr/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/clappr/clappr/pulls/698","id":52020020,"html_url":"https://github.com/clappr/clappr/pull/698","diff_url":"https://github.com/clappr/clappr/pull/698.diff","patch_url":"https://github.com/clappr/clappr/pull/698.patch","issue_url":"https://api.github.com/repos/clappr/clappr/issues/698","number":698,"state":"open","locked":false,"title":"Refactored seek method  to accept values in seconds instead of percentage (fixes #654)","user":{"login":"dayvson","id":59447,"avatar_url":"https://avatars.githubusercontent.com/u/59447?v=3","gravatar_id":"","url":"https://api.github.com/users/dayvson","html_url":"https://github.com/dayvson","followers_url":"https://api.github.com/users/dayvson/followers","following_url":"https://api.github.com/users/dayvson/following{/other_user}","gists_url":"https://api.github.com/users/dayvson/gists{/gist_id}","starred_url":"https://api.github.com/users/dayvson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dayvson/subscriptions","organizations_url":"https://api.github.com/users/dayvson/orgs","repos_url":"https://api.github.com/users/dayvson/repos","events_url":"https://api.github.com/users/dayvson/events{/privacy}","received_events_url":"https://api.github.com/users/dayvson/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-27T19:12:31Z","updated_at":"2015-11-27T19:53:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db532fc63d6517b4db801b34993c4a26c3534cf1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clappr/clappr/pulls/698/commits","review_comments_url":"https://api.github.com/repos/clappr/clappr/pulls/698/comments","review_comment_url":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clappr/clappr/issues/698/comments","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/8d06491e6366da04b38b9e176a1c229a1355f513","head":{"label":"dayvson:master","ref":"master","sha":"8d06491e6366da04b38b9e176a1c229a1355f513","user":{"login":"dayvson","id":59447,"avatar_url":"https://avatars.githubusercontent.com/u/59447?v=3","gravatar_id":"","url":"https://api.github.com/users/dayvson","html_url":"https://github.com/dayvson","followers_url":"https://api.github.com/users/dayvson/followers","following_url":"https://api.github.com/users/dayvson/following{/other_user}","gists_url":"https://api.github.com/users/dayvson/gists{/gist_id}","starred_url":"https://api.github.com/users/dayvson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dayvson/subscriptions","organizations_url":"https://api.github.com/users/dayvson/orgs","repos_url":"https://api.github.com/users/dayvson/repos","events_url":"https://api.github.com/users/dayvson/events{/privacy}","received_events_url":"https://api.github.com/users/dayvson/received_events","type":"User","site_admin":false},"repo":{"id":43507027,"name":"clappr","full_name":"dayvson/clappr","owner":{"login":"dayvson","id":59447,"avatar_url":"https://avatars.githubusercontent.com/u/59447?v=3","gravatar_id":"","url":"https://api.github.com/users/dayvson","html_url":"https://github.com/dayvson","followers_url":"https://api.github.com/users/dayvson/followers","following_url":"https://api.github.com/users/dayvson/following{/other_user}","gists_url":"https://api.github.com/users/dayvson/gists{/gist_id}","starred_url":"https://api.github.com/users/dayvson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dayvson/subscriptions","organizations_url":"https://api.github.com/users/dayvson/orgs","repos_url":"https://api.github.com/users/dayvson/repos","events_url":"https://api.github.com/users/dayvson/events{/privacy}","received_events_url":"https://api.github.com/users/dayvson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dayvson/clappr","description":":clapper: An extensible media player for the web","fork":true,"url":"https://api.github.com/repos/dayvson/clappr","forks_url":"https://api.github.com/repos/dayvson/clappr/forks","keys_url":"https://api.github.com/repos/dayvson/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dayvson/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dayvson/clappr/teams","hooks_url":"https://api.github.com/repos/dayvson/clappr/hooks","issue_events_url":"https://api.github.com/repos/dayvson/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/dayvson/clappr/events","assignees_url":"https://api.github.com/repos/dayvson/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/dayvson/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/dayvson/clappr/tags","blobs_url":"https://api.github.com/repos/dayvson/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dayvson/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dayvson/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dayvson/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dayvson/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/dayvson/clappr/languages","stargazers_url":"https://api.github.com/repos/dayvson/clappr/stargazers","contributors_url":"https://api.github.com/repos/dayvson/clappr/contributors","subscribers_url":"https://api.github.com/repos/dayvson/clappr/subscribers","subscription_url":"https://api.github.com/repos/dayvson/clappr/subscription","commits_url":"https://api.github.com/repos/dayvson/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dayvson/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dayvson/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dayvson/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dayvson/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/dayvson/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dayvson/clappr/merges","archive_url":"https://api.github.com/repos/dayvson/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dayvson/clappr/downloads","issues_url":"https://api.github.com/repos/dayvson/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/dayvson/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/dayvson/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/dayvson/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dayvson/clappr/labels{/name}","releases_url":"https://api.github.com/repos/dayvson/clappr/releases{/id}","created_at":"2015-10-01T16:17:58Z","updated_at":"2015-10-01T16:18:00Z","pushed_at":"2015-11-27T19:09:31Z","git_url":"git://github.com/dayvson/clappr.git","ssh_url":"git@github.com:dayvson/clappr.git","clone_url":"https://github.com/dayvson/clappr.git","svn_url":"https://github.com/dayvson/clappr","homepage":"http://clappr.io","size":14636,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clappr:master","ref":"master","sha":"1f04d87ed2fbc4496d8e3b168d01399c29635b57","user":{"login":"clappr","id":10685859,"avatar_url":"https://avatars.githubusercontent.com/u/10685859?v=3","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"repo":{"id":16844474,"name":"clappr","full_name":"clappr/clappr","owner":{"login":"clappr","id":10685859,"avatar_url":"https://avatars.githubusercontent.com/u/10685859?v=3","gravatar_id":"","url":"https://api.github.com/users/clappr","html_url":"https://github.com/clappr","followers_url":"https://api.github.com/users/clappr/followers","following_url":"https://api.github.com/users/clappr/following{/other_user}","gists_url":"https://api.github.com/users/clappr/gists{/gist_id}","starred_url":"https://api.github.com/users/clappr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clappr/subscriptions","organizations_url":"https://api.github.com/users/clappr/orgs","repos_url":"https://api.github.com/users/clappr/repos","events_url":"https://api.github.com/users/clappr/events{/privacy}","received_events_url":"https://api.github.com/users/clappr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clappr/clappr","description":":clapper: An extensible media player for the web","fork":false,"url":"https://api.github.com/repos/clappr/clappr","forks_url":"https://api.github.com/repos/clappr/clappr/forks","keys_url":"https://api.github.com/repos/clappr/clappr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clappr/clappr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clappr/clappr/teams","hooks_url":"https://api.github.com/repos/clappr/clappr/hooks","issue_events_url":"https://api.github.com/repos/clappr/clappr/issues/events{/number}","events_url":"https://api.github.com/repos/clappr/clappr/events","assignees_url":"https://api.github.com/repos/clappr/clappr/assignees{/user}","branches_url":"https://api.github.com/repos/clappr/clappr/branches{/branch}","tags_url":"https://api.github.com/repos/clappr/clappr/tags","blobs_url":"https://api.github.com/repos/clappr/clappr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clappr/clappr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clappr/clappr/git/refs{/sha}","trees_url":"https://api.github.com/repos/clappr/clappr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clappr/clappr/statuses/{sha}","languages_url":"https://api.github.com/repos/clappr/clappr/languages","stargazers_url":"https://api.github.com/repos/clappr/clappr/stargazers","contributors_url":"https://api.github.com/repos/clappr/clappr/contributors","subscribers_url":"https://api.github.com/repos/clappr/clappr/subscribers","subscription_url":"https://api.github.com/repos/clappr/clappr/subscription","commits_url":"https://api.github.com/repos/clappr/clappr/commits{/sha}","git_commits_url":"https://api.github.com/repos/clappr/clappr/git/commits{/sha}","comments_url":"https://api.github.com/repos/clappr/clappr/comments{/number}","issue_comment_url":"https://api.github.com/repos/clappr/clappr/issues/comments{/number}","contents_url":"https://api.github.com/repos/clappr/clappr/contents/{+path}","compare_url":"https://api.github.com/repos/clappr/clappr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clappr/clappr/merges","archive_url":"https://api.github.com/repos/clappr/clappr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clappr/clappr/downloads","issues_url":"https://api.github.com/repos/clappr/clappr/issues{/number}","pulls_url":"https://api.github.com/repos/clappr/clappr/pulls{/number}","milestones_url":"https://api.github.com/repos/clappr/clappr/milestones{/number}","notifications_url":"https://api.github.com/repos/clappr/clappr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clappr/clappr/labels{/name}","releases_url":"https://api.github.com/repos/clappr/clappr/releases{/id}","created_at":"2014-02-14T17:36:40Z","updated_at":"2015-11-27T10:10:12Z","pushed_at":"2015-11-27T19:12:32Z","git_url":"git://github.com/clappr/clappr.git","ssh_url":"git@github.com:clappr/clappr.git","clone_url":"https://github.com/clappr/clappr.git","svn_url":"https://github.com/clappr/clappr","homepage":"http://clappr.io","size":96291,"stargazers_count":2505,"watchers_count":2505,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":70,"forks":238,"open_issues":70,"watchers":2505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clappr/clappr/pulls/698"},"html":{"href":"https://github.com/clappr/clappr/pull/698"},"issue":{"href":"https://api.github.com/repos/clappr/clappr/issues/698"},"comments":{"href":"https://api.github.com/repos/clappr/clappr/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/clappr/clappr/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/clappr/clappr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clappr/clappr/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/clappr/clappr/statuses/8d06491e6366da04b38b9e176a1c229a1355f513"}}}}