{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/mozilla/releasetasks/pulls/31","id":43076801,"html_url":"https://github.com/mozilla/releasetasks/pull/31","diff_url":"https://github.com/mozilla/releasetasks/pull/31.diff","patch_url":"https://github.com/mozilla/releasetasks/pull/31.patch","issue_url":"https://api.github.com/repos/mozilla/releasetasks/issues/31","number":31,"state":"closed","locked":false,"title":"Move back to l10n chunks, and set locales property","user":{"login":"bhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/bhearsum","html_url":"https://github.com/bhearsum","followers_url":"https://api.github.com/users/bhearsum/followers","following_url":"https://api.github.com/users/bhearsum/following{/other_user}","gists_url":"https://api.github.com/users/bhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/bhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhearsum/subscriptions","organizations_url":"https://api.github.com/users/bhearsum/orgs","repos_url":"https://api.github.com/users/bhearsum/repos","events_url":"https://api.github.com/users/bhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/bhearsum/received_events","type":"User","site_admin":false},"body":"Flagging @rail and @nthomas-mozilla for review.\r\n\r\nThis won't make l10n actually work, but it will get us chunking again, and set the required \"locales\" property. Jobs will still fail because en_us_binary_url is unset, but I think I'll tackle that in a subsequent patch - this one is big enough already.\r\n\r\nI'm not super happy with this...but it works. We seem to be getting close to the \"too much code in templates\" state, as evidenced by my needing to pass in chunkify and sorted to the template. I wonder if we should get rid of the top level task graph, and do the including of l10n and other tasks in Python code? That would let us do chunk iteration in Python code, and maybe get rid of the hacky include/indent stuff. I'm curious what you both think about that.\r\n\r\nAnother interesting thing about this patch is that it's our first example of builder name not matching what the slug is based on, since we need multiple task ids that all use the same builder. That's not a big deal, really, but perhaps noteworthy.","created_at":"2015-08-21T20:17:44Z","updated_at":"2015-09-08T17:52:10Z","closed_at":"2015-09-08T17:52:10Z","merged_at":"2015-09-08T17:52:10Z","merge_commit_sha":"8385524b220a61a55a3df1b233a54437a1ed9ee3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/releasetasks/pulls/31/commits","review_comments_url":"https://api.github.com/repos/mozilla/releasetasks/pulls/31/comments","review_comment_url":"https://api.github.com/repos/mozilla/releasetasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/releasetasks/issues/31/comments","statuses_url":"https://api.github.com/repos/mozilla/releasetasks/statuses/12e4722361f0dea2d0b6c6970aa162647d8b82a0","head":{"label":"bhearsum:l10n-chunks","ref":"l10n-chunks","sha":"12e4722361f0dea2d0b6c6970aa162647d8b82a0","user":{"login":"bhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/bhearsum","html_url":"https://github.com/bhearsum","followers_url":"https://api.github.com/users/bhearsum/followers","following_url":"https://api.github.com/users/bhearsum/following{/other_user}","gists_url":"https://api.github.com/users/bhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/bhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhearsum/subscriptions","organizations_url":"https://api.github.com/users/bhearsum/orgs","repos_url":"https://api.github.com/users/bhearsum/repos","events_url":"https://api.github.com/users/bhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/bhearsum/received_events","type":"User","site_admin":false},"repo":{"id":39789823,"name":"releasetasks","full_name":"bhearsum/releasetasks","owner":{"login":"bhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/bhearsum","html_url":"https://github.com/bhearsum","followers_url":"https://api.github.com/users/bhearsum/followers","following_url":"https://api.github.com/users/bhearsum/following{/other_user}","gists_url":"https://api.github.com/users/bhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/bhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhearsum/subscriptions","organizations_url":"https://api.github.com/users/bhearsum/orgs","repos_url":"https://api.github.com/users/bhearsum/repos","events_url":"https://api.github.com/users/bhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/bhearsum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhearsum/releasetasks","description":"","fork":true,"url":"https://api.github.com/repos/bhearsum/releasetasks","forks_url":"https://api.github.com/repos/bhearsum/releasetasks/forks","keys_url":"https://api.github.com/repos/bhearsum/releasetasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhearsum/releasetasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhearsum/releasetasks/teams","hooks_url":"https://api.github.com/repos/bhearsum/releasetasks/hooks","issue_events_url":"https://api.github.com/repos/bhearsum/releasetasks/issues/events{/number}","events_url":"https://api.github.com/repos/bhearsum/releasetasks/events","assignees_url":"https://api.github.com/repos/bhearsum/releasetasks/assignees{/user}","branches_url":"https://api.github.com/repos/bhearsum/releasetasks/branches{/branch}","tags_url":"https://api.github.com/repos/bhearsum/releasetasks/tags","blobs_url":"https://api.github.com/repos/bhearsum/releasetasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhearsum/releasetasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhearsum/releasetasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhearsum/releasetasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhearsum/releasetasks/statuses/{sha}","languages_url":"https://api.github.com/repos/bhearsum/releasetasks/languages","stargazers_url":"https://api.github.com/repos/bhearsum/releasetasks/stargazers","contributors_url":"https://api.github.com/repos/bhearsum/releasetasks/contributors","subscribers_url":"https://api.github.com/repos/bhearsum/releasetasks/subscribers","subscription_url":"https://api.github.com/repos/bhearsum/releasetasks/subscription","commits_url":"https://api.github.com/repos/bhearsum/releasetasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhearsum/releasetasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhearsum/releasetasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhearsum/releasetasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhearsum/releasetasks/contents/{+path}","compare_url":"https://api.github.com/repos/bhearsum/releasetasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhearsum/releasetasks/merges","archive_url":"https://api.github.com/repos/bhearsum/releasetasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhearsum/releasetasks/downloads","issues_url":"https://api.github.com/repos/bhearsum/releasetasks/issues{/number}","pulls_url":"https://api.github.com/repos/bhearsum/releasetasks/pulls{/number}","milestones_url":"https://api.github.com/repos/bhearsum/releasetasks/milestones{/number}","notifications_url":"https://api.github.com/repos/bhearsum/releasetasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhearsum/releasetasks/labels{/name}","releases_url":"https://api.github.com/repos/bhearsum/releasetasks/releases{/id}","created_at":"2015-07-27T18:04:33Z","updated_at":"2015-07-27T18:17:24Z","pushed_at":"2015-09-01T15:02:43Z","git_url":"git://github.com/bhearsum/releasetasks.git","ssh_url":"git@github.com:bhearsum/releasetasks.git","clone_url":"https://github.com/bhearsum/releasetasks.git","svn_url":"https://github.com/bhearsum/releasetasks","homepage":null,"size":194,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"3d3491268cba93fc7632fa7c0588db4898523821","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":39789703,"name":"releasetasks","full_name":"mozilla/releasetasks","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/releasetasks","description":"","fork":false,"url":"https://api.github.com/repos/mozilla/releasetasks","forks_url":"https://api.github.com/repos/mozilla/releasetasks/forks","keys_url":"https://api.github.com/repos/mozilla/releasetasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/releasetasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/releasetasks/teams","hooks_url":"https://api.github.com/repos/mozilla/releasetasks/hooks","issue_events_url":"https://api.github.com/repos/mozilla/releasetasks/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/releasetasks/events","assignees_url":"https://api.github.com/repos/mozilla/releasetasks/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/releasetasks/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/releasetasks/tags","blobs_url":"https://api.github.com/repos/mozilla/releasetasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/releasetasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/releasetasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/releasetasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/releasetasks/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/releasetasks/languages","stargazers_url":"https://api.github.com/repos/mozilla/releasetasks/stargazers","contributors_url":"https://api.github.com/repos/mozilla/releasetasks/contributors","subscribers_url":"https://api.github.com/repos/mozilla/releasetasks/subscribers","subscription_url":"https://api.github.com/repos/mozilla/releasetasks/subscription","commits_url":"https://api.github.com/repos/mozilla/releasetasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/releasetasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/releasetasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/releasetasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/releasetasks/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/releasetasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/releasetasks/merges","archive_url":"https://api.github.com/repos/mozilla/releasetasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/releasetasks/downloads","issues_url":"https://api.github.com/repos/mozilla/releasetasks/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/releasetasks/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/releasetasks/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/releasetasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/releasetasks/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/releasetasks/releases{/id}","created_at":"2015-07-27T18:01:42Z","updated_at":"2015-08-19T13:50:24Z","pushed_at":"2015-09-08T17:52:10Z","git_url":"git://github.com/mozilla/releasetasks.git","ssh_url":"git@github.com:mozilla/releasetasks.git","clone_url":"https://github.com/mozilla/releasetasks.git","svn_url":"https://github.com/mozilla/releasetasks","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/releasetasks/pulls/31"},"html":{"href":"https://github.com/mozilla/releasetasks/pull/31"},"issue":{"href":"https://api.github.com/repos/mozilla/releasetasks/issues/31"},"comments":{"href":"https://api.github.com/repos/mozilla/releasetasks/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/releasetasks/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/releasetasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/releasetasks/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/releasetasks/statuses/12e4722361f0dea2d0b6c6970aa162647d8b82a0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bhearsum","id":49649,"avatar_url":"https://avatars.githubusercontent.com/u/49649?v=3","gravatar_id":"","url":"https://api.github.com/users/bhearsum","html_url":"https://github.com/bhearsum","followers_url":"https://api.github.com/users/bhearsum/followers","following_url":"https://api.github.com/users/bhearsum/following{/other_user}","gists_url":"https://api.github.com/users/bhearsum/gists{/gist_id}","starred_url":"https://api.github.com/users/bhearsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhearsum/subscriptions","organizations_url":"https://api.github.com/users/bhearsum/orgs","repos_url":"https://api.github.com/users/bhearsum/repos","events_url":"https://api.github.com/users/bhearsum/events{/privacy}","received_events_url":"https://api.github.com/users/bhearsum/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":9,"additions":107,"deletions":17,"changed_files":5}}