{"action":"created","comment":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/40729756","id":40729756,"diff_hunk":"@@ -1349,7 +1351,7 @@ func (cst *consensusSetTester) testPaymentChannelBlocks() error {\n \t\t// txn needs to be fully custom. To get a custom txn, manually create an\n \t\t// address and then use the wallet to fund that address.\n \t\tchannelSize := types.NewCurrency64(10e3)\n-\t\tchannelFundingSK, channelFundingPK, err := crypto.GenerateSignatureKeys()","path":"modules/consensus/accept_test.go","position":38,"original_position":38,"commit_id":"29224d46f6458a4dca537517cf23f7622dd0e4c5","original_commit_id":"29224d46f6458a4dca537517cf23f7622dd0e4c5","user":{"login":"DavidVorick","id":2316841,"avatar_url":"https://avatars.githubusercontent.com/u/2316841?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidVorick","html_url":"https://github.com/DavidVorick","followers_url":"https://api.github.com/users/DavidVorick/followers","following_url":"https://api.github.com/users/DavidVorick/following{/other_user}","gists_url":"https://api.github.com/users/DavidVorick/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidVorick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidVorick/subscriptions","organizations_url":"https://api.github.com/users/DavidVorick/orgs","repos_url":"https://api.github.com/users/DavidVorick/repos","events_url":"https://api.github.com/users/DavidVorick/events{/privacy}","received_events_url":"https://api.github.com/users/DavidVorick/received_events","type":"User","site_admin":false},"body":"no need to change the library call.\r\n\r\nin the crypto package, define a struct that counts as the 'generic skg':\r\n\r\n```\r\nvar (\r\n    genericSKG SKG = NewSKG()\r\n)\r\n\r\nfunc GenerateSignatureKeys() stuff {\r\n    return gerenicSKG.Generate()\r\n}\r\n```","created_at":"2015-09-29T21:07:19Z","updated_at":"2015-09-29T21:07:19Z","html_url":"https://github.com/NebulousLabs/Sia/pull/800#discussion_r40729756","pull_request_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800","_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments/40729756"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/800#discussion_r40729756"},"pull_request":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800"}}},"pull_request":{"url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800","id":46105507,"html_url":"https://github.com/NebulousLabs/Sia/pull/800","diff_url":"https://github.com/NebulousLabs/Sia/pull/800.diff","patch_url":"https://github.com/NebulousLabs/Sia/pull/800.patch","issue_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/800","number":800,"state":"open","locked":false,"title":"Refactors crypto/signatures.go to use explicit interfaces and adds unit tests","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"body":"Refactors crypto.GenerateSignatureKeys and crypto.DeterministicSignatureKeys\r\nso that they now depend on explicit interfaces.\r\n\r\nAdds unit tests to exercise the new Generate and GenerateDeterministic\r\nfunctions.","created_at":"2015-09-27T18:07:06Z","updated_at":"2015-09-29T21:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98faf677bf71d8c877239f681dd22b052a3db9e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800/commits","review_comments_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800/comments","review_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/800/comments","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/29224d46f6458a4dca537517cf23f7622dd0e4c5","head":{"label":"mtlynch:crypto-refactor","ref":"crypto-refactor","sha":"29224d46f6458a4dca537517cf23f7622dd0e4c5","user":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"repo":{"id":41731429,"name":"Sia","full_name":"mtlynch/Sia","owner":{"login":"mtlynch","id":7783288,"avatar_url":"https://avatars.githubusercontent.com/u/7783288?v=3","gravatar_id":"","url":"https://api.github.com/users/mtlynch","html_url":"https://github.com/mtlynch","followers_url":"https://api.github.com/users/mtlynch/followers","following_url":"https://api.github.com/users/mtlynch/following{/other_user}","gists_url":"https://api.github.com/users/mtlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mtlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtlynch/subscriptions","organizations_url":"https://api.github.com/users/mtlynch/orgs","repos_url":"https://api.github.com/users/mtlynch/repos","events_url":"https://api.github.com/users/mtlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mtlynch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtlynch/Sia","description":"Blockchain-based marketplace for file storage","fork":true,"url":"https://api.github.com/repos/mtlynch/Sia","forks_url":"https://api.github.com/repos/mtlynch/Sia/forks","keys_url":"https://api.github.com/repos/mtlynch/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtlynch/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtlynch/Sia/teams","hooks_url":"https://api.github.com/repos/mtlynch/Sia/hooks","issue_events_url":"https://api.github.com/repos/mtlynch/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/mtlynch/Sia/events","assignees_url":"https://api.github.com/repos/mtlynch/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/mtlynch/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/mtlynch/Sia/tags","blobs_url":"https://api.github.com/repos/mtlynch/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtlynch/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtlynch/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtlynch/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtlynch/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/mtlynch/Sia/languages","stargazers_url":"https://api.github.com/repos/mtlynch/Sia/stargazers","contributors_url":"https://api.github.com/repos/mtlynch/Sia/contributors","subscribers_url":"https://api.github.com/repos/mtlynch/Sia/subscribers","subscription_url":"https://api.github.com/repos/mtlynch/Sia/subscription","commits_url":"https://api.github.com/repos/mtlynch/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtlynch/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtlynch/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtlynch/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtlynch/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/mtlynch/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtlynch/Sia/merges","archive_url":"https://api.github.com/repos/mtlynch/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtlynch/Sia/downloads","issues_url":"https://api.github.com/repos/mtlynch/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/mtlynch/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/mtlynch/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/mtlynch/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtlynch/Sia/labels{/name}","releases_url":"https://api.github.com/repos/mtlynch/Sia/releases{/id}","created_at":"2015-09-01T10:10:44Z","updated_at":"2015-09-01T10:10:45Z","pushed_at":"2015-09-27T18:10:05Z","git_url":"git://github.com/mtlynch/Sia.git","ssh_url":"git@github.com:mtlynch/Sia.git","clone_url":"https://github.com/mtlynch/Sia.git","svn_url":"https://github.com/mtlynch/Sia","homepage":"http://siacoin.com","size":5108,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NebulousLabs:master","ref":"master","sha":"0f434118ade023cf104faf3ac68d9e694c3164f9","user":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":25370072,"name":"Sia","full_name":"NebulousLabs/Sia","owner":{"login":"NebulousLabs","id":7471422,"avatar_url":"https://avatars.githubusercontent.com/u/7471422?v=3","gravatar_id":"","url":"https://api.github.com/users/NebulousLabs","html_url":"https://github.com/NebulousLabs","followers_url":"https://api.github.com/users/NebulousLabs/followers","following_url":"https://api.github.com/users/NebulousLabs/following{/other_user}","gists_url":"https://api.github.com/users/NebulousLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/NebulousLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NebulousLabs/subscriptions","organizations_url":"https://api.github.com/users/NebulousLabs/orgs","repos_url":"https://api.github.com/users/NebulousLabs/repos","events_url":"https://api.github.com/users/NebulousLabs/events{/privacy}","received_events_url":"https://api.github.com/users/NebulousLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NebulousLabs/Sia","description":"Blockchain-based marketplace for file storage","fork":false,"url":"https://api.github.com/repos/NebulousLabs/Sia","forks_url":"https://api.github.com/repos/NebulousLabs/Sia/forks","keys_url":"https://api.github.com/repos/NebulousLabs/Sia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NebulousLabs/Sia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NebulousLabs/Sia/teams","hooks_url":"https://api.github.com/repos/NebulousLabs/Sia/hooks","issue_events_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/events{/number}","events_url":"https://api.github.com/repos/NebulousLabs/Sia/events","assignees_url":"https://api.github.com/repos/NebulousLabs/Sia/assignees{/user}","branches_url":"https://api.github.com/repos/NebulousLabs/Sia/branches{/branch}","tags_url":"https://api.github.com/repos/NebulousLabs/Sia/tags","blobs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NebulousLabs/Sia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NebulousLabs/Sia/git/refs{/sha}","trees_url":"https://api.github.com/repos/NebulousLabs/Sia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NebulousLabs/Sia/statuses/{sha}","languages_url":"https://api.github.com/repos/NebulousLabs/Sia/languages","stargazers_url":"https://api.github.com/repos/NebulousLabs/Sia/stargazers","contributors_url":"https://api.github.com/repos/NebulousLabs/Sia/contributors","subscribers_url":"https://api.github.com/repos/NebulousLabs/Sia/subscribers","subscription_url":"https://api.github.com/repos/NebulousLabs/Sia/subscription","commits_url":"https://api.github.com/repos/NebulousLabs/Sia/commits{/sha}","git_commits_url":"https://api.github.com/repos/NebulousLabs/Sia/git/commits{/sha}","comments_url":"https://api.github.com/repos/NebulousLabs/Sia/comments{/number}","issue_comment_url":"https://api.github.com/repos/NebulousLabs/Sia/issues/comments{/number}","contents_url":"https://api.github.com/repos/NebulousLabs/Sia/contents/{+path}","compare_url":"https://api.github.com/repos/NebulousLabs/Sia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NebulousLabs/Sia/merges","archive_url":"https://api.github.com/repos/NebulousLabs/Sia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NebulousLabs/Sia/downloads","issues_url":"https://api.github.com/repos/NebulousLabs/Sia/issues{/number}","pulls_url":"https://api.github.com/repos/NebulousLabs/Sia/pulls{/number}","milestones_url":"https://api.github.com/repos/NebulousLabs/Sia/milestones{/number}","notifications_url":"https://api.github.com/repos/NebulousLabs/Sia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NebulousLabs/Sia/labels{/name}","releases_url":"https://api.github.com/repos/NebulousLabs/Sia/releases{/id}","created_at":"2014-10-17T17:50:25Z","updated_at":"2015-09-26T12:02:52Z","pushed_at":"2015-09-27T18:10:05Z","git_url":"git://github.com/NebulousLabs/Sia.git","ssh_url":"git@github.com:NebulousLabs/Sia.git","clone_url":"https://github.com/NebulousLabs/Sia.git","svn_url":"https://github.com/NebulousLabs/Sia","homepage":"http://siacoin.com","size":31752,"stargazers_count":96,"watchers_count":96,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":37,"forks":16,"open_issues":37,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800"},"html":{"href":"https://github.com/NebulousLabs/Sia/pull/800"},"issue":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/800"},"comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NebulousLabs/Sia/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/NebulousLabs/Sia/statuses/29224d46f6458a4dca537517cf23f7622dd0e4c5"}}}}