{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/comments/45218532","id":45218532,"diff_hunk":"@@ -17,7 +17,7 @@ class MatchElement extends PolymerElement {\n   MatchElement.created() : super.created();\n \n   @Observe('value, inputQuery')\n-  valueChanged(_, __) => Polymer.dom(root).innerHtml = highlightedValue;","path":"web/forms/implementing_simple_autocompletion/match_element.dart","position":4,"original_position":4,"commit_id":"bc5f3a8b6573350b444f77868909a63eb02a6679","original_commit_id":"bc5f3a8b6573350b444f77868909a63eb02a6679","user":{"login":"zoechi","id":405837,"avatar_url":"https://avatars.githubusercontent.com/u/405837?v=3","gravatar_id":"","url":"https://api.github.com/users/zoechi","html_url":"https://github.com/zoechi","followers_url":"https://api.github.com/users/zoechi/followers","following_url":"https://api.github.com/users/zoechi/following{/other_user}","gists_url":"https://api.github.com/users/zoechi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoechi/subscriptions","organizations_url":"https://api.github.com/users/zoechi/orgs","repos_url":"https://api.github.com/users/zoechi/repos","events_url":"https://api.github.com/users/zoechi/events{/privacy}","received_events_url":"https://api.github.com/users/zoechi/received_events","type":"User","site_admin":false},"body":"Actually I would just deprecate it in favor of `new PolymerXxx()`\r\n\r\nI don't know a use case where I would want the method accept either `Event` or `Element` because I don't know or don't care what type the value is that I actually hold, or even less where I don't expect a specific return type (`PolymerDom` or `PolymerEvent`) \r\n\r\nI also don't think that it is too important to have the same method as in JS.\r\nJust mention it in the docs.","created_at":"2015-11-18T16:04:02Z","updated_at":"2015-11-18T16:04:02Z","html_url":"https://github.com/dart-lang/polymer-dart-patterns/pull/37#discussion_r45218532","pull_request_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/comments/45218532"},"html":{"href":"https://github.com/dart-lang/polymer-dart-patterns/pull/37#discussion_r45218532"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37","id":51059045,"html_url":"https://github.com/dart-lang/polymer-dart-patterns/pull/37","diff_url":"https://github.com/dart-lang/polymer-dart-patterns/pull/37.diff","patch_url":"https://github.com/dart-lang/polymer-dart-patterns/pull/37.patch","issue_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/37","number":37,"state":"open","locked":false,"title":"- revive `observing_changes_to_light_dom_children` ...","user":{"login":"zoechi","id":405837,"avatar_url":"https://avatars.githubusercontent.com/u/405837?v=3","gravatar_id":"","url":"https://api.github.com/users/zoechi","html_url":"https://github.com/zoechi","followers_url":"https://api.github.com/users/zoechi/followers","following_url":"https://api.github.com/users/zoechi/following{/other_user}","gists_url":"https://api.github.com/users/zoechi/gists{/gist_id}","starred_url":"https://api.github.com/users/zoechi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoechi/subscriptions","organizations_url":"https://api.github.com/users/zoechi/orgs","repos_url":"https://api.github.com/users/zoechi/repos","events_url":"https://api.github.com/users/zoechi/events{/privacy}","received_events_url":"https://api.github.com/users/zoechi/received_events","type":"User","site_admin":false},"body":"- ...after `observeNodes` was added to Polymer\r\n- fix `styling_elements/using_host_with_pseudo_classes` to also work when built to JS\r\n- add `.analysis_options` for linter checks\r\n- update to latest polymer and polymer_elements\r\n- some strong-mode and linter warning fixes and other minor code improvements\r\n- change `(Polymer.dom(...) as PolymerDom)` to `new PolymerDom(...)`","created_at":"2015-11-18T09:16:39Z","updated_at":"2015-11-18T16:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4130720f3df468471079439afe6f79941d69d194","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37/commits","review_comments_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37/comments","review_comment_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/37/comments","statuses_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/statuses/bc5f3a8b6573350b444f77868909a63eb02a6679","head":{"label":"bwu-dart-contributing:0.17.0_advance","ref":"0.17.0_advance","sha":"bc5f3a8b6573350b444f77868909a63eb02a6679","user":{"login":"bwu-dart-contributing","id":12327325,"avatar_url":"https://avatars.githubusercontent.com/u/12327325?v=3","gravatar_id":"","url":"https://api.github.com/users/bwu-dart-contributing","html_url":"https://github.com/bwu-dart-contributing","followers_url":"https://api.github.com/users/bwu-dart-contributing/followers","following_url":"https://api.github.com/users/bwu-dart-contributing/following{/other_user}","gists_url":"https://api.github.com/users/bwu-dart-contributing/gists{/gist_id}","starred_url":"https://api.github.com/users/bwu-dart-contributing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwu-dart-contributing/subscriptions","organizations_url":"https://api.github.com/users/bwu-dart-contributing/orgs","repos_url":"https://api.github.com/users/bwu-dart-contributing/repos","events_url":"https://api.github.com/users/bwu-dart-contributing/events{/privacy}","received_events_url":"https://api.github.com/users/bwu-dart-contributing/received_events","type":"Organization","site_admin":false},"repo":{"id":42648708,"name":"polymer-dart-patterns","full_name":"bwu-dart-contributing/polymer-dart-patterns","owner":{"login":"bwu-dart-contributing","id":12327325,"avatar_url":"https://avatars.githubusercontent.com/u/12327325?v=3","gravatar_id":"","url":"https://api.github.com/users/bwu-dart-contributing","html_url":"https://github.com/bwu-dart-contributing","followers_url":"https://api.github.com/users/bwu-dart-contributing/followers","following_url":"https://api.github.com/users/bwu-dart-contributing/following{/other_user}","gists_url":"https://api.github.com/users/bwu-dart-contributing/gists{/gist_id}","starred_url":"https://api.github.com/users/bwu-dart-contributing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwu-dart-contributing/subscriptions","organizations_url":"https://api.github.com/users/bwu-dart-contributing/orgs","repos_url":"https://api.github.com/users/bwu-dart-contributing/repos","events_url":"https://api.github.com/users/bwu-dart-contributing/events{/privacy}","received_events_url":"https://api.github.com/users/bwu-dart-contributing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bwu-dart-contributing/polymer-dart-patterns","description":"Small, useful, snippets/samples that show how to do things the Polymer.dart way.","fork":true,"url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns","forks_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/forks","keys_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/teams","hooks_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/hooks","issue_events_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/issues/events{/number}","events_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/events","assignees_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/assignees{/user}","branches_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/branches{/branch}","tags_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/tags","blobs_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/languages","stargazers_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/stargazers","contributors_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/contributors","subscribers_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/subscribers","subscription_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/subscription","commits_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/contents/{+path}","compare_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/merges","archive_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/downloads","issues_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/issues{/number}","pulls_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/labels{/name}","releases_url":"https://api.github.com/repos/bwu-dart-contributing/polymer-dart-patterns/releases{/id}","created_at":"2015-09-17T09:58:46Z","updated_at":"2015-10-22T13:20:23Z","pushed_at":"2015-11-18T09:14:15Z","git_url":"git://github.com/bwu-dart-contributing/polymer-dart-patterns.git","ssh_url":"git@github.com:bwu-dart-contributing/polymer-dart-patterns.git","clone_url":"https://github.com/bwu-dart-contributing/polymer-dart-patterns.git","svn_url":"https://github.com/bwu-dart-contributing/polymer-dart-patterns","homepage":"","size":197,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"b8fab28bee014fa1a917182d4e188a8d9b319e76","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":23478992,"name":"polymer-dart-patterns","full_name":"dart-lang/polymer-dart-patterns","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/polymer-dart-patterns","description":"Small, useful, snippets/samples that show how to do things the Polymer.dart way.","fork":false,"url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns","forks_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/forks","keys_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/teams","hooks_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/events","assignees_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/tags","blobs_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/languages","stargazers_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/subscription","commits_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/merges","archive_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/downloads","issues_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/releases{/id}","created_at":"2014-08-29T21:59:56Z","updated_at":"2015-11-15T19:44:38Z","pushed_at":"2015-11-18T09:16:39Z","git_url":"git://github.com/dart-lang/polymer-dart-patterns.git","ssh_url":"git@github.com:dart-lang/polymer-dart-patterns.git","clone_url":"https://github.com/dart-lang/polymer-dart-patterns.git","svn_url":"https://github.com/dart-lang/polymer-dart-patterns","homepage":"","size":608,"stargazers_count":55,"watchers_count":55,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37"},"html":{"href":"https://github.com/dart-lang/polymer-dart-patterns/pull/37"},"issue":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/37"},"comments":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/polymer-dart-patterns/statuses/bc5f3a8b6573350b444f77868909a63eb02a6679"}}}}