{"action":"created","comment":{"url":"https://api.github.com/repos/pmem/valgrind/pulls/comments/34442370","id":34442370,"diff_hunk":"@@ -0,0 +1,20 @@\n+Number of stores not made persistent: 4\n+Stores not made persistent properly:\n+[0]    at 0x........: main (trans_expl.c:36)\n+\tAddress: 0x........\tsize: 1\tstate: DIRTY\n+[1]    at 0x........: main (trans_expl.c:37)\n+\tAddress: 0x........\tsize: 2\tstate: DIRTY\n+[2]    at 0x........: main (trans_expl.c:38)\n+\tAddress: 0x........\tsize: 4\tstate: DIRTY\n+[3]    at 0x........: main (trans_expl.c:43)\n+\tAddress: 0x........\tsize: 8\tstate: DIRTY\n+Total memory not made persistent: 15\n+\n+Number of stores made outside of transactions: 3","path":"pmemcheck/tests/trans_expl.stderr.exp","position":13,"original_position":13,"commit_id":"343c9d6031880e42dc469aa1a7375408f56c41f9","original_commit_id":"343c9d6031880e42dc469aa1a7375408f56c41f9","user":{"login":"krzycz","id":8184299,"avatar_url":"https://avatars.githubusercontent.com/u/8184299?v=3","gravatar_id":"","url":"https://api.github.com/users/krzycz","html_url":"https://github.com/krzycz","followers_url":"https://api.github.com/users/krzycz/followers","following_url":"https://api.github.com/users/krzycz/following{/other_user}","gists_url":"https://api.github.com/users/krzycz/gists{/gist_id}","starred_url":"https://api.github.com/users/krzycz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzycz/subscriptions","organizations_url":"https://api.github.com/users/krzycz/orgs","repos_url":"https://api.github.com/users/krzycz/repos","events_url":"https://api.github.com/users/krzycz/events{/privacy}","received_events_url":"https://api.github.com/users/krzycz/received_events","type":"User","site_admin":false},"body":"This is misleading - the stores were made within the TX, but the objects were not added to TX, prior to making a store.","created_at":"2015-07-13T08:36:06Z","updated_at":"2015-07-13T08:36:06Z","html_url":"https://github.com/pmem/valgrind/pull/18#discussion_r34442370","pull_request_url":"https://api.github.com/repos/pmem/valgrind/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/comments/34442370"},"html":{"href":"https://github.com/pmem/valgrind/pull/18#discussion_r34442370"},"pull_request":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/pmem/valgrind/pulls/18","id":39594227,"html_url":"https://github.com/pmem/valgrind/pull/18","diff_url":"https://github.com/pmem/valgrind/pull/18.diff","patch_url":"https://github.com/pmem/valgrind/pull/18.patch","issue_url":"https://api.github.com/repos/pmem/valgrind/issues/18","number":18,"state":"open","locked":false,"title":"pmemcheck: transaction support","user":{"login":"tomaszkapela","id":8526425,"avatar_url":"https://avatars.githubusercontent.com/u/8526425?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszkapela","html_url":"https://github.com/tomaszkapela","followers_url":"https://api.github.com/users/tomaszkapela/followers","following_url":"https://api.github.com/users/tomaszkapela/following{/other_user}","gists_url":"https://api.github.com/users/tomaszkapela/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszkapela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszkapela/subscriptions","organizations_url":"https://api.github.com/users/tomaszkapela/orgs","repos_url":"https://api.github.com/users/tomaszkapela/repos","events_url":"https://api.github.com/users/tomaszkapela/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszkapela/received_events","type":"User","site_admin":false},"body":"This commit introduces transaction support to pmemcheck. For more\r\ninformation please check out the documentation.","created_at":"2015-07-09T15:14:17Z","updated_at":"2015-07-13T08:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f29f3f064c0a531aca7242eb13c4f5744875a95d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pmem/valgrind/pulls/18/commits","review_comments_url":"https://api.github.com/repos/pmem/valgrind/pulls/18/comments","review_comment_url":"https://api.github.com/repos/pmem/valgrind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmem/valgrind/issues/18/comments","statuses_url":"https://api.github.com/repos/pmem/valgrind/statuses/343c9d6031880e42dc469aa1a7375408f56c41f9","head":{"label":"tomaszkapela:add-transaction-support","ref":"add-transaction-support","sha":"343c9d6031880e42dc469aa1a7375408f56c41f9","user":{"login":"tomaszkapela","id":8526425,"avatar_url":"https://avatars.githubusercontent.com/u/8526425?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszkapela","html_url":"https://github.com/tomaszkapela","followers_url":"https://api.github.com/users/tomaszkapela/followers","following_url":"https://api.github.com/users/tomaszkapela/following{/other_user}","gists_url":"https://api.github.com/users/tomaszkapela/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszkapela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszkapela/subscriptions","organizations_url":"https://api.github.com/users/tomaszkapela/orgs","repos_url":"https://api.github.com/users/tomaszkapela/repos","events_url":"https://api.github.com/users/tomaszkapela/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszkapela/received_events","type":"User","site_admin":false},"repo":{"id":32070266,"name":"valgrind","full_name":"tomaszkapela/valgrind","owner":{"login":"tomaszkapela","id":8526425,"avatar_url":"https://avatars.githubusercontent.com/u/8526425?v=3","gravatar_id":"","url":"https://api.github.com/users/tomaszkapela","html_url":"https://github.com/tomaszkapela","followers_url":"https://api.github.com/users/tomaszkapela/followers","following_url":"https://api.github.com/users/tomaszkapela/following{/other_user}","gists_url":"https://api.github.com/users/tomaszkapela/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszkapela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszkapela/subscriptions","organizations_url":"https://api.github.com/users/tomaszkapela/orgs","repos_url":"https://api.github.com/users/tomaszkapela/repos","events_url":"https://api.github.com/users/tomaszkapela/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszkapela/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomaszkapela/valgrind","description":"Enhanced valgrind for persistent memory","fork":true,"url":"https://api.github.com/repos/tomaszkapela/valgrind","forks_url":"https://api.github.com/repos/tomaszkapela/valgrind/forks","keys_url":"https://api.github.com/repos/tomaszkapela/valgrind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomaszkapela/valgrind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomaszkapela/valgrind/teams","hooks_url":"https://api.github.com/repos/tomaszkapela/valgrind/hooks","issue_events_url":"https://api.github.com/repos/tomaszkapela/valgrind/issues/events{/number}","events_url":"https://api.github.com/repos/tomaszkapela/valgrind/events","assignees_url":"https://api.github.com/repos/tomaszkapela/valgrind/assignees{/user}","branches_url":"https://api.github.com/repos/tomaszkapela/valgrind/branches{/branch}","tags_url":"https://api.github.com/repos/tomaszkapela/valgrind/tags","blobs_url":"https://api.github.com/repos/tomaszkapela/valgrind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomaszkapela/valgrind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomaszkapela/valgrind/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomaszkapela/valgrind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomaszkapela/valgrind/statuses/{sha}","languages_url":"https://api.github.com/repos/tomaszkapela/valgrind/languages","stargazers_url":"https://api.github.com/repos/tomaszkapela/valgrind/stargazers","contributors_url":"https://api.github.com/repos/tomaszkapela/valgrind/contributors","subscribers_url":"https://api.github.com/repos/tomaszkapela/valgrind/subscribers","subscription_url":"https://api.github.com/repos/tomaszkapela/valgrind/subscription","commits_url":"https://api.github.com/repos/tomaszkapela/valgrind/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomaszkapela/valgrind/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomaszkapela/valgrind/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomaszkapela/valgrind/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomaszkapela/valgrind/contents/{+path}","compare_url":"https://api.github.com/repos/tomaszkapela/valgrind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomaszkapela/valgrind/merges","archive_url":"https://api.github.com/repos/tomaszkapela/valgrind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomaszkapela/valgrind/downloads","issues_url":"https://api.github.com/repos/tomaszkapela/valgrind/issues{/number}","pulls_url":"https://api.github.com/repos/tomaszkapela/valgrind/pulls{/number}","milestones_url":"https://api.github.com/repos/tomaszkapela/valgrind/milestones{/number}","notifications_url":"https://api.github.com/repos/tomaszkapela/valgrind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomaszkapela/valgrind/labels{/name}","releases_url":"https://api.github.com/repos/tomaszkapela/valgrind/releases{/id}","created_at":"2015-03-12T10:09:50Z","updated_at":"2015-04-20T09:58:45Z","pushed_at":"2015-07-09T15:13:54Z","git_url":"git://github.com/tomaszkapela/valgrind.git","ssh_url":"git@github.com:tomaszkapela/valgrind.git","clone_url":"https://github.com/tomaszkapela/valgrind.git","svn_url":"https://github.com/tomaszkapela/valgrind","homepage":null,"size":13181,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"pmem"}},"base":{"label":"pmem:pmem","ref":"pmem","sha":"4235afb1bdf078446813767cc92fa5aefd7e0241","user":{"login":"pmem","id":4894933,"avatar_url":"https://avatars.githubusercontent.com/u/4894933?v=3","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"repo":{"id":31319719,"name":"valgrind","full_name":"pmem/valgrind","owner":{"login":"pmem","id":4894933,"avatar_url":"https://avatars.githubusercontent.com/u/4894933?v=3","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmem/valgrind","description":"Enhanced valgrind for persistent memory","fork":false,"url":"https://api.github.com/repos/pmem/valgrind","forks_url":"https://api.github.com/repos/pmem/valgrind/forks","keys_url":"https://api.github.com/repos/pmem/valgrind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmem/valgrind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmem/valgrind/teams","hooks_url":"https://api.github.com/repos/pmem/valgrind/hooks","issue_events_url":"https://api.github.com/repos/pmem/valgrind/issues/events{/number}","events_url":"https://api.github.com/repos/pmem/valgrind/events","assignees_url":"https://api.github.com/repos/pmem/valgrind/assignees{/user}","branches_url":"https://api.github.com/repos/pmem/valgrind/branches{/branch}","tags_url":"https://api.github.com/repos/pmem/valgrind/tags","blobs_url":"https://api.github.com/repos/pmem/valgrind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmem/valgrind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmem/valgrind/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmem/valgrind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmem/valgrind/statuses/{sha}","languages_url":"https://api.github.com/repos/pmem/valgrind/languages","stargazers_url":"https://api.github.com/repos/pmem/valgrind/stargazers","contributors_url":"https://api.github.com/repos/pmem/valgrind/contributors","subscribers_url":"https://api.github.com/repos/pmem/valgrind/subscribers","subscription_url":"https://api.github.com/repos/pmem/valgrind/subscription","commits_url":"https://api.github.com/repos/pmem/valgrind/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmem/valgrind/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmem/valgrind/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmem/valgrind/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmem/valgrind/contents/{+path}","compare_url":"https://api.github.com/repos/pmem/valgrind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmem/valgrind/merges","archive_url":"https://api.github.com/repos/pmem/valgrind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmem/valgrind/downloads","issues_url":"https://api.github.com/repos/pmem/valgrind/issues{/number}","pulls_url":"https://api.github.com/repos/pmem/valgrind/pulls{/number}","milestones_url":"https://api.github.com/repos/pmem/valgrind/milestones{/number}","notifications_url":"https://api.github.com/repos/pmem/valgrind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmem/valgrind/labels{/name}","releases_url":"https://api.github.com/repos/pmem/valgrind/releases{/id}","created_at":"2015-02-25T15:20:18Z","updated_at":"2015-04-20T14:28:06Z","pushed_at":"2015-07-09T15:14:17Z","git_url":"git://github.com/pmem/valgrind.git","ssh_url":"git@github.com:pmem/valgrind.git","clone_url":"https://github.com/pmem/valgrind.git","svn_url":"https://github.com/pmem/valgrind","homepage":null,"size":13312,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"pmem"}},"_links":{"self":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/18"},"html":{"href":"https://github.com/pmem/valgrind/pull/18"},"issue":{"href":"https://api.github.com/repos/pmem/valgrind/issues/18"},"comments":{"href":"https://api.github.com/repos/pmem/valgrind/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmem/valgrind/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/pmem/valgrind/statuses/343c9d6031880e42dc469aa1a7375408f56c41f9"}}}}