{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/44235238","id":44235238,"diff_hunk":"@@ -6,16 +6,22 @@\n #define TEMP_DIR_NAMES {\"$TMP\", \"$TEMP\", \"$USERPROFILE\", \"\"}\n #define TEMP_FILE_PATH_MAXLEN _MAX_PATH\n \n-// Defines needed to fix the build on Windows:\n-// - DFLT_DIR\n-// - DFLT_BDIR\n-// - DFLT_VDIR\n-// - EXRC_FILE\n-// - VIMRC_FILE\n-// - SYNTAX_FNAME\n-// - DFLT_HELPFILE\n-// - SYS_VIMRC_FILE\n-// - SPECIAL_WILDCHAR\n+// Windows system-dependent file names\n+#ifndef SYS_VIMRC_FILE\n+# define SYS_VIMRC_FILE \"$VIM\\\\sysinit.vim\"\n+#endif\n+#ifndef DFLT_HELPFILE\n+# define DFLT_HELPFILE  \"$VIMRUMTIME\\\\doc\\\\help.txt\"\n+#endif\n+#ifndef SYNTAX_FNAME\n+# define SYNTAX_FNAME   \"$VIMRUNTIME\\\\syntax\\\\%s.vim\"\n+#endif\n+#ifndef EXRC_FILE\n+# define EXRC_FILE      \"_exrc\"\n+#endif\n+#ifndef VIMRC_FILE\n+# define VIMRC_FILE     \"_nvimrc\"","path":"src/nvim/os/win_defs.h","position":28,"original_position":28,"commit_id":"a0ed78298833977c7620c7f2a703211ff73313ed","original_commit_id":"a0ed78298833977c7620c7f2a703211ff73313ed","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"Let's ditch the underscore prefix entirely on Windows. It's perfectly fine to use on all Windows versions we support. The minor quirks with dot-prefixed files in Windows Explorer do not justify the cross-platform inconsistency.","created_at":"2015-11-09T01:31:58Z","updated_at":"2015-11-09T01:31:58Z","html_url":"https://github.com/neovim/neovim/pull/3242#discussion_r44235238","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/3242","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/44235238"},"html":{"href":"https://github.com/neovim/neovim/pull/3242#discussion_r44235238"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/3242"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/3242","id":43360646,"html_url":"https://github.com/neovim/neovim/pull/3242","diff_url":"https://github.com/neovim/neovim/pull/3242.diff","patch_url":"https://github.com/neovim/neovim/pull/3242.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/3242","number":3242,"state":"open","locked":false,"title":"[RFC] Add path definitions in os/win_defs.h for Windows.","user":{"login":"sethjackson","id":6191831,"avatar_url":"https://avatars.githubusercontent.com/u/6191831?v=3","gravatar_id":"","url":"https://api.github.com/users/sethjackson","html_url":"https://github.com/sethjackson","followers_url":"https://api.github.com/users/sethjackson/followers","following_url":"https://api.github.com/users/sethjackson/following{/other_user}","gists_url":"https://api.github.com/users/sethjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/sethjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethjackson/subscriptions","organizations_url":"https://api.github.com/users/sethjackson/orgs","repos_url":"https://api.github.com/users/sethjackson/repos","events_url":"https://api.github.com/users/sethjackson/events{/privacy}","received_events_url":"https://api.github.com/users/sethjackson/received_events","type":"User","site_admin":false},"body":"Cherry picked from #810. Just the path definitions from equalsraf@5bdf72bd.\r\n\r\nI left out `DFLT_MAXMEM`, `DFLT_MAXMEMTOT`, the `*_FILE` defines, and `DFLT_ERRORFILE` as those are defined in `os/os_defs.h`.\r\n\r\nFurther I changed this:\r\n\r\n```\r\n#if !defined(USR_EXRC_FILE2)\r\n#    define USR_VIMRC_FILE2     \"~\\\\_nvim\\\\nvimrc\"\r\n#endif\r\n```\r\n\r\nto:\r\n\r\n```\r\n#ifndef USR_VIMRC_FILE2\r\n# define USR_VIMRC_FILE2 \"$HOME\\\\_nvim\\\\nvimrc\"\r\n#endif\r\n```\r\n\r\nWhich should be correct.","created_at":"2015-08-26T03:26:33Z","updated_at":"2015-11-09T01:31:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2382711181db8240727d7fee907641bb5ada65c3","assignee":null,"milestone":{"url":"https://api.github.com/repos/neovim/neovim/milestones/10","html_url":"https://github.com/neovim/neovim/milestones/0.2","labels_url":"https://api.github.com/repos/neovim/neovim/milestones/10/labels","id":1183808,"number":10,"title":"0.2","description":"beta release, codename: \"keanu\"","creator":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"open_issues":118,"closed_issues":36,"state":"open","created_at":"2015-06-27T19:05:24Z","updated_at":"2015-11-07T19:50:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/3242/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/3242/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/3242/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/a0ed78298833977c7620c7f2a703211ff73313ed","head":{"label":"sethjackson:vim-defs","ref":"vim-defs","sha":"a0ed78298833977c7620c7f2a703211ff73313ed","user":{"login":"sethjackson","id":6191831,"avatar_url":"https://avatars.githubusercontent.com/u/6191831?v=3","gravatar_id":"","url":"https://api.github.com/users/sethjackson","html_url":"https://github.com/sethjackson","followers_url":"https://api.github.com/users/sethjackson/followers","following_url":"https://api.github.com/users/sethjackson/following{/other_user}","gists_url":"https://api.github.com/users/sethjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/sethjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethjackson/subscriptions","organizations_url":"https://api.github.com/users/sethjackson/orgs","repos_url":"https://api.github.com/users/sethjackson/repos","events_url":"https://api.github.com/users/sethjackson/events{/privacy}","received_events_url":"https://api.github.com/users/sethjackson/received_events","type":"User","site_admin":false},"repo":{"id":41250560,"name":"neovim","full_name":"sethjackson/neovim","owner":{"login":"sethjackson","id":6191831,"avatar_url":"https://avatars.githubusercontent.com/u/6191831?v=3","gravatar_id":"","url":"https://api.github.com/users/sethjackson","html_url":"https://github.com/sethjackson","followers_url":"https://api.github.com/users/sethjackson/followers","following_url":"https://api.github.com/users/sethjackson/following{/other_user}","gists_url":"https://api.github.com/users/sethjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/sethjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethjackson/subscriptions","organizations_url":"https://api.github.com/users/sethjackson/orgs","repos_url":"https://api.github.com/users/sethjackson/repos","events_url":"https://api.github.com/users/sethjackson/events{/privacy}","received_events_url":"https://api.github.com/users/sethjackson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sethjackson/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":true,"url":"https://api.github.com/repos/sethjackson/neovim","forks_url":"https://api.github.com/repos/sethjackson/neovim/forks","keys_url":"https://api.github.com/repos/sethjackson/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sethjackson/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sethjackson/neovim/teams","hooks_url":"https://api.github.com/repos/sethjackson/neovim/hooks","issue_events_url":"https://api.github.com/repos/sethjackson/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/sethjackson/neovim/events","assignees_url":"https://api.github.com/repos/sethjackson/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/sethjackson/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/sethjackson/neovim/tags","blobs_url":"https://api.github.com/repos/sethjackson/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sethjackson/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sethjackson/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/sethjackson/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sethjackson/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/sethjackson/neovim/languages","stargazers_url":"https://api.github.com/repos/sethjackson/neovim/stargazers","contributors_url":"https://api.github.com/repos/sethjackson/neovim/contributors","subscribers_url":"https://api.github.com/repos/sethjackson/neovim/subscribers","subscription_url":"https://api.github.com/repos/sethjackson/neovim/subscription","commits_url":"https://api.github.com/repos/sethjackson/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/sethjackson/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/sethjackson/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/sethjackson/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/sethjackson/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/sethjackson/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sethjackson/neovim/merges","archive_url":"https://api.github.com/repos/sethjackson/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sethjackson/neovim/downloads","issues_url":"https://api.github.com/repos/sethjackson/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/sethjackson/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/sethjackson/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/sethjackson/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sethjackson/neovim/labels{/name}","releases_url":"https://api.github.com/repos/sethjackson/neovim/releases{/id}","created_at":"2015-08-23T13:27:37Z","updated_at":"2015-08-23T13:29:01Z","pushed_at":"2015-11-08T16:32:50Z","git_url":"git://github.com/sethjackson/neovim.git","ssh_url":"git@github.com:sethjackson/neovim.git","clone_url":"https://github.com/sethjackson/neovim.git","svn_url":"https://github.com/sethjackson/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":33508,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"f65e7bf30c8a00696d5740e35d0f84b9aa648b99","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-11-09T00:42:27Z","pushed_at":"2015-11-08T22:35:30Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":84902,"stargazers_count":16007,"watchers_count":16007,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1111,"mirror_url":null,"open_issues_count":561,"forks":1111,"open_issues":561,"watchers":16007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/3242"},"html":{"href":"https://github.com/neovim/neovim/pull/3242"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/3242"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/3242/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/3242/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/3242/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/a0ed78298833977c7620c7f2a703211ff73313ed"}}}}