{"action":"created","comment":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/38878193","id":38878193,"diff_hunk":"@@ -0,0 +1,47 @@\n+import React, { cloneElement } from 'react';\n+import classNames from 'classnames';\n+import BootstrapMixin from './BootstrapMixin';\n+import ValidComponentChildren from './utils/ValidComponentChildren';\n+\n+const Breadcrumb = React.createClass({\n+  mixins: [BootstrapMixin],\n+\n+  propTypes: {\n+    /**\n+     * CSS classes for the wrapper `ol` element\n+     */\n+    className: React.PropTypes.string,\n+    /**\n+     * HTML id for the wrapper `ol` element\n+     */\n+    id: React.PropTypes.string","path":"src/Breadcrumb.js","position":14,"original_position":17,"commit_id":"e41d38990e9bc1ea853f60f51abe474e19077041","original_commit_id":"b4803873f03f00160a5e53c111aa42543f06f297","user":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"body":"What's the point in specifying this as a propType though? You're not using it in the component code, nor attaching any special semantics to it - it's just getting passed through as an HTML attribute. Better to just drop this propType entirely.","created_at":"2015-09-07T19:57:21Z","updated_at":"2015-09-07T19:57:21Z","html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1273#discussion_r38878193","pull_request_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273","_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments/38878193"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/1273#discussion_r38878193"},"pull_request":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273"}}},"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273","id":43951965,"html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1273","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1273.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1273.patch","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1273","number":1273,"state":"open","locked":false,"title":"[added] Breadcrumb Component","user":{"login":"ycavatars","id":1477617,"avatar_url":"https://avatars.githubusercontent.com/u/1477617?v=3","gravatar_id":"","url":"https://api.github.com/users/ycavatars","html_url":"https://github.com/ycavatars","followers_url":"https://api.github.com/users/ycavatars/followers","following_url":"https://api.github.com/users/ycavatars/following{/other_user}","gists_url":"https://api.github.com/users/ycavatars/gists{/gist_id}","starred_url":"https://api.github.com/users/ycavatars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycavatars/subscriptions","organizations_url":"https://api.github.com/users/ycavatars/orgs","repos_url":"https://api.github.com/users/ycavatars/repos","events_url":"https://api.github.com/users/ycavatars/events{/privacy}","received_events_url":"https://api.github.com/users/ycavatars/received_events","type":"User","site_admin":false},"body":"I added `Breadcrumb` component for issue #56. Please review this request, thanks :)","created_at":"2015-09-02T04:02:43Z","updated_at":"2015-09-07T19:57:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba73bbebade28ba77e261bbf80f386ef1fbebcd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273/commits","review_comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273/comments","review_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1273/comments","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/e41d38990e9bc1ea853f60f51abe474e19077041","head":{"label":"ycavatars:feature/breadcrumb","ref":"feature/breadcrumb","sha":"e41d38990e9bc1ea853f60f51abe474e19077041","user":{"login":"ycavatars","id":1477617,"avatar_url":"https://avatars.githubusercontent.com/u/1477617?v=3","gravatar_id":"","url":"https://api.github.com/users/ycavatars","html_url":"https://github.com/ycavatars","followers_url":"https://api.github.com/users/ycavatars/followers","following_url":"https://api.github.com/users/ycavatars/following{/other_user}","gists_url":"https://api.github.com/users/ycavatars/gists{/gist_id}","starred_url":"https://api.github.com/users/ycavatars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycavatars/subscriptions","organizations_url":"https://api.github.com/users/ycavatars/orgs","repos_url":"https://api.github.com/users/ycavatars/repos","events_url":"https://api.github.com/users/ycavatars/events{/privacy}","received_events_url":"https://api.github.com/users/ycavatars/received_events","type":"User","site_admin":false},"repo":{"id":41395309,"name":"react-bootstrap","full_name":"ycavatars/react-bootstrap","owner":{"login":"ycavatars","id":1477617,"avatar_url":"https://avatars.githubusercontent.com/u/1477617?v=3","gravatar_id":"","url":"https://api.github.com/users/ycavatars","html_url":"https://github.com/ycavatars","followers_url":"https://api.github.com/users/ycavatars/followers","following_url":"https://api.github.com/users/ycavatars/following{/other_user}","gists_url":"https://api.github.com/users/ycavatars/gists{/gist_id}","starred_url":"https://api.github.com/users/ycavatars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ycavatars/subscriptions","organizations_url":"https://api.github.com/users/ycavatars/orgs","repos_url":"https://api.github.com/users/ycavatars/repos","events_url":"https://api.github.com/users/ycavatars/events{/privacy}","received_events_url":"https://api.github.com/users/ycavatars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ycavatars/react-bootstrap","description":"Bootstrap 3 components built with React","fork":true,"url":"https://api.github.com/repos/ycavatars/react-bootstrap","forks_url":"https://api.github.com/repos/ycavatars/react-bootstrap/forks","keys_url":"https://api.github.com/repos/ycavatars/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ycavatars/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ycavatars/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/ycavatars/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ycavatars/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ycavatars/react-bootstrap/events","assignees_url":"https://api.github.com/repos/ycavatars/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ycavatars/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ycavatars/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/ycavatars/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ycavatars/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ycavatars/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ycavatars/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ycavatars/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ycavatars/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ycavatars/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ycavatars/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ycavatars/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ycavatars/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/ycavatars/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ycavatars/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ycavatars/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ycavatars/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ycavatars/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ycavatars/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ycavatars/react-bootstrap/merges","archive_url":"https://api.github.com/repos/ycavatars/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ycavatars/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/ycavatars/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ycavatars/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ycavatars/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ycavatars/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ycavatars/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ycavatars/react-bootstrap/releases{/id}","created_at":"2015-08-26T00:37:07Z","updated_at":"2015-08-26T00:37:08Z","pushed_at":"2015-09-06T04:39:17Z","git_url":"git://github.com/ycavatars/react-bootstrap.git","ssh_url":"git@github.com:ycavatars/react-bootstrap.git","clone_url":"https://github.com/ycavatars/react-bootstrap.git","svn_url":"https://github.com/ycavatars/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":3701,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-bootstrap:master","ref":"master","sha":"d679b2b914e433ebeaa0e8456a201564ea5266e3","user":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":15480067,"name":"react-bootstrap","full_name":"react-bootstrap/react-bootstrap","owner":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-bootstrap/react-bootstrap","description":"Bootstrap 3 components built with React","fork":false,"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","forks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/forks","keys_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/events","assignees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/merges","archive_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/releases{/id}","created_at":"2013-12-27T19:06:07Z","updated_at":"2015-09-07T18:15:03Z","pushed_at":"2015-09-07T19:51:48Z","git_url":"git://github.com/react-bootstrap/react-bootstrap.git","ssh_url":"git@github.com:react-bootstrap/react-bootstrap.git","clone_url":"https://github.com/react-bootstrap/react-bootstrap.git","svn_url":"https://github.com/react-bootstrap/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":10333,"stargazers_count":3286,"watchers_count":3286,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"open_issues_count":78,"forks":551,"open_issues":78,"watchers":3286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/1273"},"issue":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1273"},"comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1273/comments"},"review_comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273/comments"},"review_comment":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1273/commits"},"statuses":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/e41d38990e9bc1ea853f60f51abe474e19077041"}}}}