{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4","id":41256801,"html_url":"https://github.com/letsencrypt/go-jose/pull/4","diff_url":"https://github.com/letsencrypt/go-jose/pull/4.diff","patch_url":"https://github.com/letsencrypt/go-jose/pull/4.patch","issue_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/4","number":4,"state":"closed","locked":false,"title":"Make serialization tolerant of missing protected header","user":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"body":"Currently, the library panics when it is asked to serialize a JWS object with no protected header. Instead, it should just not attempt to serialize the protected header, and the JSON serializer will then omit the corresponding field.","created_at":"2015-07-30T16:55:52Z","updated_at":"2015-07-30T17:44:01Z","closed_at":"2015-07-30T17:44:01Z","merged_at":"2015-07-30T17:44:01Z","merge_commit_sha":"4f881b709bdec5b2b973cdbac7487ad0edec7437","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/go-jose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/4/comments","statuses_url":"https://api.github.com/repos/letsencrypt/go-jose/statuses/584d07854c79c1397f3490038e65d733c96e0db7","head":{"label":"letsencrypt:avoid-panic","ref":"avoid-panic","sha":"584d07854c79c1397f3490038e65d733c96e0db7","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":39658104,"name":"go-jose","full_name":"letsencrypt/go-jose","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/go-jose","description":"Boulder's fork of Square's go-jose library. Contains a few changes needed for Boulder, pre upstreaming.","fork":true,"url":"https://api.github.com/repos/letsencrypt/go-jose","forks_url":"https://api.github.com/repos/letsencrypt/go-jose/forks","keys_url":"https://api.github.com/repos/letsencrypt/go-jose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/go-jose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/go-jose/teams","hooks_url":"https://api.github.com/repos/letsencrypt/go-jose/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/go-jose/events","assignees_url":"https://api.github.com/repos/letsencrypt/go-jose/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/go-jose/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/go-jose/tags","blobs_url":"https://api.github.com/repos/letsencrypt/go-jose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/go-jose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/go-jose/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/go-jose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/go-jose/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/go-jose/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/go-jose/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/go-jose/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/go-jose/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/go-jose/subscription","commits_url":"https://api.github.com/repos/letsencrypt/go-jose/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/go-jose/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/go-jose/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/go-jose/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/go-jose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/go-jose/merges","archive_url":"https://api.github.com/repos/letsencrypt/go-jose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/go-jose/downloads","issues_url":"https://api.github.com/repos/letsencrypt/go-jose/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/go-jose/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/go-jose/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/go-jose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/go-jose/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/go-jose/releases{/id}","created_at":"2015-07-24T21:15:16Z","updated_at":"2015-07-24T21:40:45Z","pushed_at":"2015-07-30T17:44:01Z","git_url":"git://github.com/letsencrypt/go-jose.git","ssh_url":"git@github.com:letsencrypt/go-jose.git","clone_url":"https://github.com/letsencrypt/go-jose.git","svn_url":"https://github.com/letsencrypt/go-jose","homepage":"https://godoc.org/github.com/square/go-jose","size":279,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"ed929ba3c826dbed7c66c97096cfaf2bfa35aa55","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":39658104,"name":"go-jose","full_name":"letsencrypt/go-jose","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/go-jose","description":"Boulder's fork of Square's go-jose library. Contains a few changes needed for Boulder, pre upstreaming.","fork":true,"url":"https://api.github.com/repos/letsencrypt/go-jose","forks_url":"https://api.github.com/repos/letsencrypt/go-jose/forks","keys_url":"https://api.github.com/repos/letsencrypt/go-jose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/go-jose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/go-jose/teams","hooks_url":"https://api.github.com/repos/letsencrypt/go-jose/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/go-jose/events","assignees_url":"https://api.github.com/repos/letsencrypt/go-jose/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/go-jose/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/go-jose/tags","blobs_url":"https://api.github.com/repos/letsencrypt/go-jose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/go-jose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/go-jose/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/go-jose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/go-jose/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/go-jose/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/go-jose/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/go-jose/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/go-jose/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/go-jose/subscription","commits_url":"https://api.github.com/repos/letsencrypt/go-jose/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/go-jose/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/go-jose/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/go-jose/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/go-jose/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/go-jose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/go-jose/merges","archive_url":"https://api.github.com/repos/letsencrypt/go-jose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/go-jose/downloads","issues_url":"https://api.github.com/repos/letsencrypt/go-jose/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/go-jose/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/go-jose/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/go-jose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/go-jose/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/go-jose/releases{/id}","created_at":"2015-07-24T21:15:16Z","updated_at":"2015-07-24T21:40:45Z","pushed_at":"2015-07-30T17:44:01Z","git_url":"git://github.com/letsencrypt/go-jose.git","ssh_url":"git@github.com:letsencrypt/go-jose.git","clone_url":"https://github.com/letsencrypt/go-jose.git","svn_url":"https://github.com/letsencrypt/go-jose","homepage":"https://godoc.org/github.com/square/go-jose","size":279,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4"},"html":{"href":"https://github.com/letsencrypt/go-jose/pull/4"},"issue":{"href":"https://api.github.com/repos/letsencrypt/go-jose/issues/4"},"comments":{"href":"https://api.github.com/repos/letsencrypt/go-jose/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/go-jose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/go-jose/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/go-jose/statuses/584d07854c79c1397f3490038e65d733c96e0db7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bifurcation","id":75597,"avatar_url":"https://avatars.githubusercontent.com/u/75597?v=3","gravatar_id":"","url":"https://api.github.com/users/bifurcation","html_url":"https://github.com/bifurcation","followers_url":"https://api.github.com/users/bifurcation/followers","following_url":"https://api.github.com/users/bifurcation/following{/other_user}","gists_url":"https://api.github.com/users/bifurcation/gists{/gist_id}","starred_url":"https://api.github.com/users/bifurcation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bifurcation/subscriptions","organizations_url":"https://api.github.com/users/bifurcation/orgs","repos_url":"https://api.github.com/users/bifurcation/repos","events_url":"https://api.github.com/users/bifurcation/events{/privacy}","received_events_url":"https://api.github.com/users/bifurcation/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"commits":3,"additions":14,"deletions":8,"changed_files":2}}