{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/comments/34131797","id":34131797,"diff_hunk":"@@ -19,15 +19,18 @@\n #import \"BaseCollectionViewFlowLayout.h\"\n #import \"BaseLayoutAttributes.h\"\n \n+static CGFloat const itemSpacing = 10.0f;\n+\n @interface BaseCollectionViewFlowLayout ()\n \n-@property (nonatomic) CGFloat width;\n+@property (nonatomic) CGFloat collectionViewWidth;\n+@property (nonatomic) CGFloat thumbnailWidth;\n \n @end\n \n @implementation BaseCollectionViewFlowLayout\n \n-- (instancetype)init\n+- (instancetype)initWithNumberOfColumns:(NSInteger)numberOfColumns itemHeight:(CGFloat)itemHeight shouldSwipeToDelete:(BOOL)shouldSwipeToDelete","path":"AlfrescoApp/View Controllers/FileFolder View Controller/BaseCollectionViewFlowLayout.m","position":17,"original_position":17,"commit_id":"e1d0ceaba892bd254034368f05f81199b000434d","original_commit_id":"e1d0ceaba892bd254034368f05f81199b000434d","user":{"login":"mikeh","id":48239,"avatar_url":"https://avatars.githubusercontent.com/u/48239?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeh","html_url":"https://github.com/mikeh","followers_url":"https://api.github.com/users/mikeh/followers","following_url":"https://api.github.com/users/mikeh/following{/other_user}","gists_url":"https://api.github.com/users/mikeh/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeh/subscriptions","organizations_url":"https://api.github.com/users/mikeh/orgs","repos_url":"https://api.github.com/users/mikeh/repos","events_url":"https://api.github.com/users/mikeh/events{/privacy}","received_events_url":"https://api.github.com/users/mikeh/received_events","type":"User","site_admin":false},"body":"Nothing wrong with this particularly, but I'd set defaults and keep it to an `init` method. Unless these parameters are changed a lot within the app it's going to need a lot of duplicate calling code to set this controller up. Public properties can be set after `init` to change the defaults.","created_at":"2015-07-08T09:52:06Z","updated_at":"2015-07-08T09:52:06Z","html_url":"https://github.com/Alfresco/alfresco-ios-app/pull/515#discussion_r34131797","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/comments/34131797"},"html":{"href":"https://github.com/Alfresco/alfresco-ios-app/pull/515#discussion_r34131797"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515","id":39458496,"html_url":"https://github.com/Alfresco/alfresco-ios-app/pull/515","diff_url":"https://github.com/Alfresco/alfresco-ios-app/pull/515.diff","patch_url":"https://github.com/Alfresco/alfresco-ios-app/pull/515.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/515","number":515,"state":"open","locked":false,"title":"Work for IOS-26 (Sprint 3 work)","user":{"login":"SilviuOdobescu","id":10714569,"avatar_url":"https://avatars.githubusercontent.com/u/10714569?v=3","gravatar_id":"","url":"https://api.github.com/users/SilviuOdobescu","html_url":"https://github.com/SilviuOdobescu","followers_url":"https://api.github.com/users/SilviuOdobescu/followers","following_url":"https://api.github.com/users/SilviuOdobescu/following{/other_user}","gists_url":"https://api.github.com/users/SilviuOdobescu/gists{/gist_id}","starred_url":"https://api.github.com/users/SilviuOdobescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilviuOdobescu/subscriptions","organizations_url":"https://api.github.com/users/SilviuOdobescu/orgs","repos_url":"https://api.github.com/users/SilviuOdobescu/repos","events_url":"https://api.github.com/users/SilviuOdobescu/events{/privacy}","received_events_url":"https://api.github.com/users/SilviuOdobescu/received_events","type":"User","site_admin":false},"body":"IOS-26 is work in progress.","created_at":"2015-07-08T09:41:01Z","updated_at":"2015-07-08T09:52:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c246df0dfdbe6a22af6b4a1273f2c14c0a1eb73f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/515/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/statuses/e1d0ceaba892bd254034368f05f81199b000434d","head":{"label":"SilviuOdobescu:GridViewFB","ref":"GridViewFB","sha":"e1d0ceaba892bd254034368f05f81199b000434d","user":{"login":"SilviuOdobescu","id":10714569,"avatar_url":"https://avatars.githubusercontent.com/u/10714569?v=3","gravatar_id":"","url":"https://api.github.com/users/SilviuOdobescu","html_url":"https://github.com/SilviuOdobescu","followers_url":"https://api.github.com/users/SilviuOdobescu/followers","following_url":"https://api.github.com/users/SilviuOdobescu/following{/other_user}","gists_url":"https://api.github.com/users/SilviuOdobescu/gists{/gist_id}","starred_url":"https://api.github.com/users/SilviuOdobescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilviuOdobescu/subscriptions","organizations_url":"https://api.github.com/users/SilviuOdobescu/orgs","repos_url":"https://api.github.com/users/SilviuOdobescu/repos","events_url":"https://api.github.com/users/SilviuOdobescu/events{/privacy}","received_events_url":"https://api.github.com/users/SilviuOdobescu/received_events","type":"User","site_admin":false},"repo":{"id":30745708,"name":"alfresco-ios-app","full_name":"SilviuOdobescu/alfresco-ios-app","owner":{"login":"SilviuOdobescu","id":10714569,"avatar_url":"https://avatars.githubusercontent.com/u/10714569?v=3","gravatar_id":"","url":"https://api.github.com/users/SilviuOdobescu","html_url":"https://github.com/SilviuOdobescu","followers_url":"https://api.github.com/users/SilviuOdobescu/followers","following_url":"https://api.github.com/users/SilviuOdobescu/following{/other_user}","gists_url":"https://api.github.com/users/SilviuOdobescu/gists{/gist_id}","starred_url":"https://api.github.com/users/SilviuOdobescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilviuOdobescu/subscriptions","organizations_url":"https://api.github.com/users/SilviuOdobescu/orgs","repos_url":"https://api.github.com/users/SilviuOdobescu/repos","events_url":"https://api.github.com/users/SilviuOdobescu/events{/privacy}","received_events_url":"https://api.github.com/users/SilviuOdobescu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SilviuOdobescu/alfresco-ios-app","description":"","fork":true,"url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app","forks_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/forks","keys_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/teams","hooks_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/hooks","issue_events_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/events","assignees_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/tags","blobs_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/languages","stargazers_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/stargazers","contributors_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/contributors","subscribers_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/subscribers","subscription_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/subscription","commits_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/merges","archive_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/downloads","issues_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/labels{/name}","releases_url":"https://api.github.com/repos/SilviuOdobescu/alfresco-ios-app/releases{/id}","created_at":"2015-02-13T07:38:58Z","updated_at":"2015-04-30T15:09:28Z","pushed_at":"2015-07-08T07:53:13Z","git_url":"git://github.com/SilviuOdobescu/alfresco-ios-app.git","ssh_url":"git@github.com:SilviuOdobescu/alfresco-ios-app.git","clone_url":"https://github.com/SilviuOdobescu/alfresco-ios-app.git","svn_url":"https://github.com/SilviuOdobescu/alfresco-ios-app","homepage":null,"size":40311,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alfresco:2.2-dev","ref":"2.2-dev","sha":"81fd46a5b91d99b07d144fa03238a0bb7e0d0a48","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":7003316,"name":"alfresco-ios-app","full_name":"Alfresco/alfresco-ios-app","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/alfresco-ios-app","description":"","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ios-app","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ios-app/releases{/id}","created_at":"2012-12-04T16:44:30Z","updated_at":"2015-06-29T03:04:20Z","pushed_at":"2015-07-08T09:41:01Z","git_url":"git://github.com/Alfresco/alfresco-ios-app.git","ssh_url":"git@github.com:Alfresco/alfresco-ios-app.git","clone_url":"https://github.com/Alfresco/alfresco-ios-app.git","svn_url":"https://github.com/Alfresco/alfresco-ios-app","homepage":null,"size":42910,"stargazers_count":13,"watchers_count":13,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515"},"html":{"href":"https://github.com/Alfresco/alfresco-ios-app/pull/515"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/515"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-ios-app/statuses/e1d0ceaba892bd254034368f05f81199b000434d"}}}}