{"action":"closed","number":2716,"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/2716","id":32434893,"html_url":"https://github.com/Theano/Theano/pull/2716","diff_url":"https://github.com/Theano/Theano/pull/2716.diff","patch_url":"https://github.com/Theano/Theano/pull/2716.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/2716","number":2716,"state":"closed","locked":false,"title":"Added support for negative axis in GpuCumsumOp","user":{"login":"MarcCote","id":660004,"avatar_url":"https://avatars.githubusercontent.com/u/660004?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcCote","html_url":"https://github.com/MarcCote","followers_url":"https://api.github.com/users/MarcCote/followers","following_url":"https://api.github.com/users/MarcCote/following{/other_user}","gists_url":"https://api.github.com/users/MarcCote/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcCote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcCote/subscriptions","organizations_url":"https://api.github.com/users/MarcCote/orgs","repos_url":"https://api.github.com/users/MarcCote/repos","events_url":"https://api.github.com/users/MarcCote/events{/privacy}","received_events_url":"https://api.github.com/users/MarcCote/received_events","type":"User","site_admin":false},"body":"When a negative axis is provided to `GpuCumsumOp`, `CumsumOp` or `CumprodOp`, it will be converted to its positive equivalent (inferred from the given input array). \r\n\r\nSince the axis conversion happens during ~~the making of the node~~ the generation of the C code, two `cumsum` nodes created using a 2D array and respectively `axis=1` and `axis=-1` ~~will~~ won't be equivalent (their hash ~~will~~ won't be the same).~~\r\n\r\nCloses #2715 \r\n\r\nEdit: Saying two `cumsum` nodes with different axis may be equivalent was based on a wrong assumption.","created_at":"2015-04-01T16:18:51Z","updated_at":"2015-04-01T23:38:28Z","closed_at":"2015-04-01T23:38:28Z","merged_at":"2015-04-01T23:38:27Z","merge_commit_sha":"15cc12ca32166a7c65043c263aad03d80989ea18","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/2716/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/2716/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/2716/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/68da6cb5209ee4bc6b037cec4cdad68487d2c72b","head":{"label":"MarcCote:fix_cumsum_negative_axis","ref":"fix_cumsum_negative_axis","sha":"68da6cb5209ee4bc6b037cec4cdad68487d2c72b","user":{"login":"MarcCote","id":660004,"avatar_url":"https://avatars.githubusercontent.com/u/660004?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcCote","html_url":"https://github.com/MarcCote","followers_url":"https://api.github.com/users/MarcCote/followers","following_url":"https://api.github.com/users/MarcCote/following{/other_user}","gists_url":"https://api.github.com/users/MarcCote/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcCote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcCote/subscriptions","organizations_url":"https://api.github.com/users/MarcCote/orgs","repos_url":"https://api.github.com/users/MarcCote/repos","events_url":"https://api.github.com/users/MarcCote/events{/privacy}","received_events_url":"https://api.github.com/users/MarcCote/received_events","type":"User","site_admin":false},"repo":{"id":16017638,"name":"Theano","full_name":"MarcCote/Theano","owner":{"login":"MarcCote","id":660004,"avatar_url":"https://avatars.githubusercontent.com/u/660004?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcCote","html_url":"https://github.com/MarcCote","followers_url":"https://api.github.com/users/MarcCote/followers","following_url":"https://api.github.com/users/MarcCote/following{/other_user}","gists_url":"https://api.github.com/users/MarcCote/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcCote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcCote/subscriptions","organizations_url":"https://api.github.com/users/MarcCote/orgs","repos_url":"https://api.github.com/users/MarcCote/repos","events_url":"https://api.github.com/users/MarcCote/events{/privacy}","received_events_url":"https://api.github.com/users/MarcCote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarcCote/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/MarcCote/Theano","forks_url":"https://api.github.com/repos/MarcCote/Theano/forks","keys_url":"https://api.github.com/repos/MarcCote/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarcCote/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarcCote/Theano/teams","hooks_url":"https://api.github.com/repos/MarcCote/Theano/hooks","issue_events_url":"https://api.github.com/repos/MarcCote/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/MarcCote/Theano/events","assignees_url":"https://api.github.com/repos/MarcCote/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/MarcCote/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/MarcCote/Theano/tags","blobs_url":"https://api.github.com/repos/MarcCote/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarcCote/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarcCote/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarcCote/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarcCote/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/MarcCote/Theano/languages","stargazers_url":"https://api.github.com/repos/MarcCote/Theano/stargazers","contributors_url":"https://api.github.com/repos/MarcCote/Theano/contributors","subscribers_url":"https://api.github.com/repos/MarcCote/Theano/subscribers","subscription_url":"https://api.github.com/repos/MarcCote/Theano/subscription","commits_url":"https://api.github.com/repos/MarcCote/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarcCote/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarcCote/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarcCote/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarcCote/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/MarcCote/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarcCote/Theano/merges","archive_url":"https://api.github.com/repos/MarcCote/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarcCote/Theano/downloads","issues_url":"https://api.github.com/repos/MarcCote/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/MarcCote/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/MarcCote/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/MarcCote/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarcCote/Theano/labels{/name}","releases_url":"https://api.github.com/repos/MarcCote/Theano/releases{/id}","created_at":"2014-01-18T02:39:02Z","updated_at":"2015-04-01T15:11:15Z","pushed_at":"2015-04-01T18:37:16Z","git_url":"git://github.com/MarcCote/Theano.git","ssh_url":"git@github.com:MarcCote/Theano.git","clone_url":"https://github.com/MarcCote/Theano.git","svn_url":"https://github.com/MarcCote/Theano","homepage":"http://www.deeplearning.net/software/theano","size":25452,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"e9328fdd00a8d1cb5a0185c08355462d2371340a","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","created_at":"2011-08-10T03:48:06Z","updated_at":"2015-04-01T23:38:28Z","pushed_at":"2015-04-01T23:38:28Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":43564,"stargazers_count":1331,"watchers_count":1331,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":490,"mirror_url":null,"open_issues_count":336,"forks":490,"open_issues":336,"watchers":1331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2716"},"html":{"href":"https://github.com/Theano/Theano/pull/2716"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/2716"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/2716/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2716/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/2716/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/68da6cb5209ee4bc6b037cec4cdad68487d2c72b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"comments":2,"review_comments":4,"commits":2,"additions":34,"deletions":21,"changed_files":4}}