{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7","id":46714938,"html_url":"https://github.com/mpcomplete/fireflies/pull/7","diff_url":"https://github.com/mpcomplete/fireflies/pull/7.diff","patch_url":"https://github.com/mpcomplete/fireflies/pull/7.patch","issue_url":"https://api.github.com/repos/mpcomplete/fireflies/issues/7","number":7,"state":"open","locked":false,"title":"Address G++ compile warnings","user":{"login":"hartwork","id":1577132,"avatar_url":"https://avatars.githubusercontent.com/u/1577132?v=3","gravatar_id":"","url":"https://api.github.com/users/hartwork","html_url":"https://github.com/hartwork","followers_url":"https://api.github.com/users/hartwork/followers","following_url":"https://api.github.com/users/hartwork/following{/other_user}","gists_url":"https://api.github.com/users/hartwork/gists{/gist_id}","starred_url":"https://api.github.com/users/hartwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartwork/subscriptions","organizations_url":"https://api.github.com/users/hartwork/orgs","repos_url":"https://api.github.com/users/hartwork/repos","events_url":"https://api.github.com/users/hartwork/events{/privacy}","received_events_url":"https://api.github.com/users/hartwork/received_events","type":"User","site_admin":false},"body":"* on re-definition of PACKAGE_* defines\r\n\r\n* \"anonymous type with no linkage used to declare variable\"\r\n\r\nmain.cc:24:31: warning: anonymous type with no linkage used to declare variable ‘<anonymous enum> canvas_type’ with linkage [enabled by default]\r\n enum {CANVAS_SDL, CANVAS_GLX} canvas_type = CANVAS_SDL;\r\n                               ^\r\n\r\n* \"deprecated conversion from string constant to ‘char*’\"\r\n\r\nmain.cc:209:1: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\n \"p=1, that simply means A is 5 times more likely to occur than B.\";\r\n ^\r\n\r\nmain.cc:380:76: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\n  canvas = new CanvasSDL(&scene, full_screen, mspf, \"Fireflies\", \"fireflies\");\r\n                                                                            ^\r\n\r\n* \"comparison between signed and unsigned integer expressions\"\r\n\r\nvroot.h:123:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    for (i = 0; i < numChildren; i++) {\r\n                    ^\r\n\r\n* \"deprecated conversion from string constant to ‘char*’\"\r\n\r\nraster.cxx:48:57: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\n static char *img_names[] = {\"PPM\", \"PNG\", \"TIFF\", \"JPEG\"};\r\n                                                         ^\r\nraster.cxx:48:57: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\nraster.cxx:48:57: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\nraster.cxx:48:57: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\nraster.cxx:49:53: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\n static char *img_ext[] = {\"ppm\", \"png\", \"tif\", \"jpg\"};\r\n                                                     ^\r\nraster.cxx:49:53: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\nraster.cxx:49:53: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\nraster.cxx:49:53: warning: deprecated conversion from string constant to ‘char*’ [-Wwrite-strings]\r\n\r\n* Resolve unused variable (and related dead code)\r\n\r\ncanvas_base.cc:63:6: warning: unused variable ‘first_tick’ [-Wunused-variable]\r\n  int first_tick = get_ms();\r\n      ^","created_at":"2015-10-03T22:36:35Z","updated_at":"2015-10-03T22:36:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7/commits","review_comments_url":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7/comments","review_comment_url":"https://api.github.com/repos/mpcomplete/fireflies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpcomplete/fireflies/issues/7/comments","statuses_url":"https://api.github.com/repos/mpcomplete/fireflies/statuses/a6837b0e6882f7ecff60ef51d732088af3c65c3f","head":{"label":"hartwork:fix-compile-warnings","ref":"fix-compile-warnings","sha":"a6837b0e6882f7ecff60ef51d732088af3c65c3f","user":{"login":"hartwork","id":1577132,"avatar_url":"https://avatars.githubusercontent.com/u/1577132?v=3","gravatar_id":"","url":"https://api.github.com/users/hartwork","html_url":"https://github.com/hartwork","followers_url":"https://api.github.com/users/hartwork/followers","following_url":"https://api.github.com/users/hartwork/following{/other_user}","gists_url":"https://api.github.com/users/hartwork/gists{/gist_id}","starred_url":"https://api.github.com/users/hartwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartwork/subscriptions","organizations_url":"https://api.github.com/users/hartwork/orgs","repos_url":"https://api.github.com/users/hartwork/repos","events_url":"https://api.github.com/users/hartwork/events{/privacy}","received_events_url":"https://api.github.com/users/hartwork/received_events","type":"User","site_admin":false},"repo":{"id":37149639,"name":"fireflies","full_name":"hartwork/fireflies","owner":{"login":"hartwork","id":1577132,"avatar_url":"https://avatars.githubusercontent.com/u/1577132?v=3","gravatar_id":"","url":"https://api.github.com/users/hartwork","html_url":"https://github.com/hartwork","followers_url":"https://api.github.com/users/hartwork/followers","following_url":"https://api.github.com/users/hartwork/following{/other_user}","gists_url":"https://api.github.com/users/hartwork/gists{/gist_id}","starred_url":"https://api.github.com/users/hartwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartwork/subscriptions","organizations_url":"https://api.github.com/users/hartwork/orgs","repos_url":"https://api.github.com/users/hartwork/repos","events_url":"https://api.github.com/users/hartwork/events{/privacy}","received_events_url":"https://api.github.com/users/hartwork/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hartwork/fireflies","description":"Fireflies Screensaver","fork":true,"url":"https://api.github.com/repos/hartwork/fireflies","forks_url":"https://api.github.com/repos/hartwork/fireflies/forks","keys_url":"https://api.github.com/repos/hartwork/fireflies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hartwork/fireflies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hartwork/fireflies/teams","hooks_url":"https://api.github.com/repos/hartwork/fireflies/hooks","issue_events_url":"https://api.github.com/repos/hartwork/fireflies/issues/events{/number}","events_url":"https://api.github.com/repos/hartwork/fireflies/events","assignees_url":"https://api.github.com/repos/hartwork/fireflies/assignees{/user}","branches_url":"https://api.github.com/repos/hartwork/fireflies/branches{/branch}","tags_url":"https://api.github.com/repos/hartwork/fireflies/tags","blobs_url":"https://api.github.com/repos/hartwork/fireflies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hartwork/fireflies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hartwork/fireflies/git/refs{/sha}","trees_url":"https://api.github.com/repos/hartwork/fireflies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hartwork/fireflies/statuses/{sha}","languages_url":"https://api.github.com/repos/hartwork/fireflies/languages","stargazers_url":"https://api.github.com/repos/hartwork/fireflies/stargazers","contributors_url":"https://api.github.com/repos/hartwork/fireflies/contributors","subscribers_url":"https://api.github.com/repos/hartwork/fireflies/subscribers","subscription_url":"https://api.github.com/repos/hartwork/fireflies/subscription","commits_url":"https://api.github.com/repos/hartwork/fireflies/commits{/sha}","git_commits_url":"https://api.github.com/repos/hartwork/fireflies/git/commits{/sha}","comments_url":"https://api.github.com/repos/hartwork/fireflies/comments{/number}","issue_comment_url":"https://api.github.com/repos/hartwork/fireflies/issues/comments{/number}","contents_url":"https://api.github.com/repos/hartwork/fireflies/contents/{+path}","compare_url":"https://api.github.com/repos/hartwork/fireflies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hartwork/fireflies/merges","archive_url":"https://api.github.com/repos/hartwork/fireflies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hartwork/fireflies/downloads","issues_url":"https://api.github.com/repos/hartwork/fireflies/issues{/number}","pulls_url":"https://api.github.com/repos/hartwork/fireflies/pulls{/number}","milestones_url":"https://api.github.com/repos/hartwork/fireflies/milestones{/number}","notifications_url":"https://api.github.com/repos/hartwork/fireflies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hartwork/fireflies/labels{/name}","releases_url":"https://api.github.com/repos/hartwork/fireflies/releases{/id}","created_at":"2015-06-09T18:14:24Z","updated_at":"2015-06-09T18:14:25Z","pushed_at":"2015-10-03T22:35:46Z","git_url":"git://github.com/hartwork/fireflies.git","ssh_url":"git@github.com:hartwork/fireflies.git","clone_url":"https://github.com/hartwork/fireflies.git","svn_url":"https://github.com/hartwork/fireflies","homepage":null,"size":334,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpcomplete:master","ref":"master","sha":"d563e8acb138592b9f580da839d6f8006146123c","user":{"login":"mpcomplete","id":1071986,"avatar_url":"https://avatars.githubusercontent.com/u/1071986?v=3","gravatar_id":"","url":"https://api.github.com/users/mpcomplete","html_url":"https://github.com/mpcomplete","followers_url":"https://api.github.com/users/mpcomplete/followers","following_url":"https://api.github.com/users/mpcomplete/following{/other_user}","gists_url":"https://api.github.com/users/mpcomplete/gists{/gist_id}","starred_url":"https://api.github.com/users/mpcomplete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpcomplete/subscriptions","organizations_url":"https://api.github.com/users/mpcomplete/orgs","repos_url":"https://api.github.com/users/mpcomplete/repos","events_url":"https://api.github.com/users/mpcomplete/events{/privacy}","received_events_url":"https://api.github.com/users/mpcomplete/received_events","type":"User","site_admin":false},"repo":{"id":34895137,"name":"fireflies","full_name":"mpcomplete/fireflies","owner":{"login":"mpcomplete","id":1071986,"avatar_url":"https://avatars.githubusercontent.com/u/1071986?v=3","gravatar_id":"","url":"https://api.github.com/users/mpcomplete","html_url":"https://github.com/mpcomplete","followers_url":"https://api.github.com/users/mpcomplete/followers","following_url":"https://api.github.com/users/mpcomplete/following{/other_user}","gists_url":"https://api.github.com/users/mpcomplete/gists{/gist_id}","starred_url":"https://api.github.com/users/mpcomplete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpcomplete/subscriptions","organizations_url":"https://api.github.com/users/mpcomplete/orgs","repos_url":"https://api.github.com/users/mpcomplete/repos","events_url":"https://api.github.com/users/mpcomplete/events{/privacy}","received_events_url":"https://api.github.com/users/mpcomplete/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpcomplete/fireflies","description":"Fireflies Screensaver","fork":false,"url":"https://api.github.com/repos/mpcomplete/fireflies","forks_url":"https://api.github.com/repos/mpcomplete/fireflies/forks","keys_url":"https://api.github.com/repos/mpcomplete/fireflies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpcomplete/fireflies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpcomplete/fireflies/teams","hooks_url":"https://api.github.com/repos/mpcomplete/fireflies/hooks","issue_events_url":"https://api.github.com/repos/mpcomplete/fireflies/issues/events{/number}","events_url":"https://api.github.com/repos/mpcomplete/fireflies/events","assignees_url":"https://api.github.com/repos/mpcomplete/fireflies/assignees{/user}","branches_url":"https://api.github.com/repos/mpcomplete/fireflies/branches{/branch}","tags_url":"https://api.github.com/repos/mpcomplete/fireflies/tags","blobs_url":"https://api.github.com/repos/mpcomplete/fireflies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpcomplete/fireflies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpcomplete/fireflies/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpcomplete/fireflies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpcomplete/fireflies/statuses/{sha}","languages_url":"https://api.github.com/repos/mpcomplete/fireflies/languages","stargazers_url":"https://api.github.com/repos/mpcomplete/fireflies/stargazers","contributors_url":"https://api.github.com/repos/mpcomplete/fireflies/contributors","subscribers_url":"https://api.github.com/repos/mpcomplete/fireflies/subscribers","subscription_url":"https://api.github.com/repos/mpcomplete/fireflies/subscription","commits_url":"https://api.github.com/repos/mpcomplete/fireflies/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpcomplete/fireflies/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpcomplete/fireflies/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpcomplete/fireflies/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpcomplete/fireflies/contents/{+path}","compare_url":"https://api.github.com/repos/mpcomplete/fireflies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpcomplete/fireflies/merges","archive_url":"https://api.github.com/repos/mpcomplete/fireflies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpcomplete/fireflies/downloads","issues_url":"https://api.github.com/repos/mpcomplete/fireflies/issues{/number}","pulls_url":"https://api.github.com/repos/mpcomplete/fireflies/pulls{/number}","milestones_url":"https://api.github.com/repos/mpcomplete/fireflies/milestones{/number}","notifications_url":"https://api.github.com/repos/mpcomplete/fireflies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpcomplete/fireflies/labels{/name}","releases_url":"https://api.github.com/repos/mpcomplete/fireflies/releases{/id}","created_at":"2015-05-01T08:32:55Z","updated_at":"2015-06-09T18:13:18Z","pushed_at":"2015-10-03T22:36:27Z","git_url":"git://github.com/mpcomplete/fireflies.git","ssh_url":"git@github.com:mpcomplete/fireflies.git","clone_url":"https://github.com/mpcomplete/fireflies.git","svn_url":"https://github.com/mpcomplete/fireflies","homepage":null,"size":408,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7"},"html":{"href":"https://github.com/mpcomplete/fireflies/pull/7"},"issue":{"href":"https://api.github.com/repos/mpcomplete/fireflies/issues/7"},"comments":{"href":"https://api.github.com/repos/mpcomplete/fireflies/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/mpcomplete/fireflies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpcomplete/fireflies/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/mpcomplete/fireflies/statuses/a6837b0e6882f7ecff60ef51d732088af3c65c3f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":14,"changed_files":7}}