{"action":"created","issue":{"url":"https://api.github.com/repos/zencart/zc-v1-series/issues/345","labels_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/345/labels{/name}","comments_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/345/comments","events_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/345/events","html_url":"https://github.com/zencart/zc-v1-series/pull/345","id":60711032,"number":345,"title":"Adds error checking to Min Values->Admin Usernames","user":{"login":"scottcwilson","id":4391638,"avatar_url":"https://avatars.githubusercontent.com/u/4391638?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcwilson","html_url":"https://github.com/scottcwilson","followers_url":"https://api.github.com/users/scottcwilson/followers","following_url":"https://api.github.com/users/scottcwilson/following{/other_user}","gists_url":"https://api.github.com/users/scottcwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcwilson/subscriptions","organizations_url":"https://api.github.com/users/scottcwilson/orgs","repos_url":"https://api.github.com/users/scottcwilson/repos","events_url":"https://api.github.com/users/scottcwilson/events{/privacy}","received_events_url":"https://api.github.com/users/scottcwilson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zencart/zc-v1-series/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-11T18:56:21Z","updated_at":"2015-03-12T17:57:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zencart/zc-v1-series/pulls/345","html_url":"https://github.com/zencart/zc-v1-series/pull/345","diff_url":"https://github.com/zencart/zc-v1-series/pull/345.diff","patch_url":"https://github.com/zencart/zc-v1-series/pull/345.patch"},"body":"Currently changing this value to something less than 4 is permitted but ignored.  This fix rejects the change.\r\n\r\nIf people like this I can extend it to do other things such as verify that min values/max values are numeric, etc. "},"comment":{"url":"https://api.github.com/repos/zencart/zc-v1-series/issues/comments/78548363","html_url":"https://github.com/zencart/zc-v1-series/pull/345#issuecomment-78548363","issue_url":"https://api.github.com/repos/zencart/zc-v1-series/issues/345","id":78548363,"user":{"login":"scottcwilson","id":4391638,"avatar_url":"https://avatars.githubusercontent.com/u/4391638?v=3","gravatar_id":"","url":"https://api.github.com/users/scottcwilson","html_url":"https://github.com/scottcwilson","followers_url":"https://api.github.com/users/scottcwilson/followers","following_url":"https://api.github.com/users/scottcwilson/following{/other_user}","gists_url":"https://api.github.com/users/scottcwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/scottcwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottcwilson/subscriptions","organizations_url":"https://api.github.com/users/scottcwilson/orgs","repos_url":"https://api.github.com/users/scottcwilson/repos","events_url":"https://api.github.com/users/scottcwilson/events{/privacy}","received_events_url":"https://api.github.com/users/scottcwilson/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T17:57:51Z","updated_at":"2015-03-12T17:57:51Z","body":"Alternately I could change the Admin User Creation facility to respect the\nvalue the user set and permit the creation of admin usernames like \"foo\" if\nthe min length value is 3.\n\nOn Thu, Mar 12, 2015 at 1:40 PM, Scott C Wilson <scottcwilson@gmail.com>\nwrote:\n\n> Would you accept the PR if I change gID/CID to configuration_group_title /\n> configuration_key or should I abandon it?\n>\n> On Thu, Mar 12, 2015 at 1:34 PM, Chris Brown <notifications@github.com>\n> wrote:\n>\n>> if ($gID == 2 && $cID == 59)\n>>\n>> You've hard-coded specific integers for gID and cID. Those are assigned\n>> by auto-increment in the db, and are not the canonical master.\n>> configuration_key would be the canonical master for cID. And for groups\n>> it's the non-multilingual-friendly configuration_group_title.\n>>\n>> —\n>> Reply to this email directly or view it on GitHub\n>> <https://github.com/zencart/zc-v1-series/pull/345#issuecomment-78540361>.\n>>\n>\n>\n"}}