{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/32415398","id":32415398,"diff_hunk":"@@ -0,0 +1,43 @@\n+require 'conversion_calculator'\n+require 'import_data'\n+require 'abanalyzer'\n+\n+RSpec.describe ConversionCalculator do\n+  before(:each) do\n+    @confidence = 0.95\n+    @a_conversion = 340\n+    @a_sample = 660\n+    @b_conversion = 380\n+    @b_sample = 728\n+    @data = ImportData.new('data_export_2015_06-3.json').data\n+    @calc = ConversionCalculator.new(@data)\n+  end\n+\n+  it \"#sample_size\" do\n+    expect(@calc.sample_size('A')).to eq @a_sample\n+    expect(@calc.sample_size('B')).to eq @b_sample\n+  end\n+\n+  it \"#conversion_num\" do\n+    expect(@calc.conversion_num('A')).to eq @a_conversion\n+    expect(@calc.conversion_num('B')).to eq @b_conversion\n+  end\n+\n+  it \"#non_conversion_num\" do\n+    expect(@calc.non_conversion_num('A')).to eq @a_sample - @a_conversion\n+    expect(@calc.non_conversion_num('B')).to eq @b_sample - @b_conversion\n+  end\n+\n+  it \"#conversion_rate\" do","path":"data_science/spec/conversion_calculator_spec.rb","position":31,"original_position":31,"commit_id":"c3988d39f33d48c0ed14376f897d9c14e2972f10","original_commit_id":"c3988d39f33d48c0ed14376f897d9c14e2972f10","user":{"login":"jmtai","id":1752795,"avatar_url":"https://avatars.githubusercontent.com/u/1752795?v=3","gravatar_id":"","url":"https://api.github.com/users/jmtai","html_url":"https://github.com/jmtai","followers_url":"https://api.github.com/users/jmtai/followers","following_url":"https://api.github.com/users/jmtai/following{/other_user}","gists_url":"https://api.github.com/users/jmtai/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtai/subscriptions","organizations_url":"https://api.github.com/users/jmtai/orgs","repos_url":"https://api.github.com/users/jmtai/repos","events_url":"https://api.github.com/users/jmtai/events{/privacy}","received_events_url":"https://api.github.com/users/jmtai/received_events","type":"User","site_admin":false},"body":"Is this test actually checking the conversion rate or is it actually the confidence interval?","created_at":"2015-06-15T12:46:21Z","updated_at":"2015-06-15T12:46:21Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/717#discussion_r32415398","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/32415398"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/717#discussion_r32415398"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717","id":37171592,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/717","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/717.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/717.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/717","number":717,"state":"open","locked":false,"title":"Data science","user":{"login":"hebelken","id":382596,"avatar_url":"https://avatars.githubusercontent.com/u/382596?v=3","gravatar_id":"","url":"https://api.github.com/users/hebelken","html_url":"https://github.com/hebelken","followers_url":"https://api.github.com/users/hebelken/followers","following_url":"https://api.github.com/users/hebelken/following{/other_user}","gists_url":"https://api.github.com/users/hebelken/gists{/gist_id}","starred_url":"https://api.github.com/users/hebelken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebelken/subscriptions","organizations_url":"https://api.github.com/users/hebelken/orgs","repos_url":"https://api.github.com/users/hebelken/repos","events_url":"https://api.github.com/users/hebelken/events{/privacy}","received_events_url":"https://api.github.com/users/hebelken/received_events","type":"User","site_admin":false},"body":"TDD try 1..\r\nNot using english tests.\r\n","created_at":"2015-06-08T16:29:31Z","updated_at":"2015-06-15T12:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6be758a3e1bb38cd0d1a2301b6605cdb7e07b659","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/717/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/c3988d39f33d48c0ed14376f897d9c14e2972f10","head":{"label":"hebelken:data_science","ref":"data_science","sha":"c3988d39f33d48c0ed14376f897d9c14e2972f10","user":{"login":"hebelken","id":382596,"avatar_url":"https://avatars.githubusercontent.com/u/382596?v=3","gravatar_id":"","url":"https://api.github.com/users/hebelken","html_url":"https://github.com/hebelken","followers_url":"https://api.github.com/users/hebelken/followers","following_url":"https://api.github.com/users/hebelken/following{/other_user}","gists_url":"https://api.github.com/users/hebelken/gists{/gist_id}","starred_url":"https://api.github.com/users/hebelken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebelken/subscriptions","organizations_url":"https://api.github.com/users/hebelken/orgs","repos_url":"https://api.github.com/users/hebelken/repos","events_url":"https://api.github.com/users/hebelken/events{/privacy}","received_events_url":"https://api.github.com/users/hebelken/received_events","type":"User","site_admin":false},"repo":{"id":35902373,"name":"level_up_exercises","full_name":"hebelken/level_up_exercises","owner":{"login":"hebelken","id":382596,"avatar_url":"https://avatars.githubusercontent.com/u/382596?v=3","gravatar_id":"","url":"https://api.github.com/users/hebelken","html_url":"https://github.com/hebelken","followers_url":"https://api.github.com/users/hebelken/followers","following_url":"https://api.github.com/users/hebelken/following{/other_user}","gists_url":"https://api.github.com/users/hebelken/gists{/gist_id}","starred_url":"https://api.github.com/users/hebelken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hebelken/subscriptions","organizations_url":"https://api.github.com/users/hebelken/orgs","repos_url":"https://api.github.com/users/hebelken/repos","events_url":"https://api.github.com/users/hebelken/events{/privacy}","received_events_url":"https://api.github.com/users/hebelken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hebelken/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/hebelken/level_up_exercises","forks_url":"https://api.github.com/repos/hebelken/level_up_exercises/forks","keys_url":"https://api.github.com/repos/hebelken/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hebelken/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hebelken/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/hebelken/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/hebelken/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/hebelken/level_up_exercises/events","assignees_url":"https://api.github.com/repos/hebelken/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/hebelken/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/hebelken/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/hebelken/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hebelken/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hebelken/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/hebelken/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hebelken/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/hebelken/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/hebelken/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/hebelken/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/hebelken/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/hebelken/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/hebelken/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/hebelken/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/hebelken/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/hebelken/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/hebelken/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/hebelken/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hebelken/level_up_exercises/merges","archive_url":"https://api.github.com/repos/hebelken/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hebelken/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/hebelken/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/hebelken/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/hebelken/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/hebelken/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hebelken/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/hebelken/level_up_exercises/releases{/id}","created_at":"2015-05-19T19:03:28Z","updated_at":"2015-05-19T19:03:28Z","pushed_at":"2015-06-08T16:23:24Z","git_url":"git://github.com/hebelken/level_up_exercises.git","ssh_url":"git@github.com:hebelken/level_up_exercises.git","clone_url":"https://github.com/hebelken/level_up_exercises.git","svn_url":"https://github.com/hebelken/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":347,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"057b4969214f82f6a79748501b269e1dc296f49b","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-06-08T20:58:20Z","pushed_at":"2015-06-13T16:10:00Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":151540,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":7,"forks":109,"open_issues":7,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/717"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/717"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/717/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/717/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/c3988d39f33d48c0ed14376f897d9c14e2972f10"}}}}