{"action":"created","issue":{"url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/140","labels_url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/140/comments","events_url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/140/events","html_url":"https://github.com/futuresimple/android-floating-action-button/issues/140","id":58533916,"number":140,"title":"Set minSdk 4 in library manifest","user":{"login":"adamsp","id":1720800,"avatar_url":"https://avatars.githubusercontent.com/u/1720800?v=3","gravatar_id":"","url":"https://api.github.com/users/adamsp","html_url":"https://github.com/adamsp","followers_url":"https://api.github.com/users/adamsp/followers","following_url":"https://api.github.com/users/adamsp/following{/other_user}","gists_url":"https://api.github.com/users/adamsp/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsp/subscriptions","organizations_url":"https://api.github.com/users/adamsp/orgs","repos_url":"https://api.github.com/users/adamsp/repos","events_url":"https://api.github.com/users/adamsp/events{/privacy}","received_events_url":"https://api.github.com/users/adamsp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-23T01:43:57Z","updated_at":"2015-02-23T02:07:57Z","closed_at":"2015-02-23T02:07:57Z","body":"I've had a bit of a surprise tonight. The manifest merger in the build process detected that there's no minSdk specified in the library manifest, and so it did this:\r\n```\r\nMERGED from com.getbase:floatingactionbutton:1.8.0:8:5\r\n\tandroid:targetSdkVersion\r\n\t\tINJECTED from AndroidManifest.xml:0:0\r\n\t\tINJECTED from AndroidManifest.xml:0:0\r\n\tandroid:minSdkVersion\r\n\t\tINJECTED from AndroidManifest.xml:0:0\r\n\t\tINJECTED from AndroidManifest.xml:0:0\r\nandroid:uses-permission#android.permission.WRITE_EXTERNAL_STORAGE\r\nIMPLIED from AndroidManifest.xml:2:1 reason: com.sefford has a targetSdkVersion < 4\r\nandroid:uses-permission#android.permission.READ_PHONE_STATE\r\nIMPLIED from AndroidManifest.xml:2:1 reason: com.sefford has a targetSdkVersion < 4\r\nandroid:uses-permission#android.permission.READ_EXTERNAL_STORAGE\r\nIMPLIED from AndroidManifest.xml:2:1 reason: com.sefford requested WRITE_EXTERNAL_STORAGE\r\n```\r\n\r\nThis means my no-permissions app suddenly requires these three extra permissions. Oops!\r\n\r\nThis is documented in the [manifest merger documentation](http://tools.android.com/tech-docs/new-build-system/user-guide/manifest-merger#TOC-Implicit-permissions-addition) - if no minSdk is set, it defaults to 1."},"comment":{"url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/comments/75480328","html_url":"https://github.com/futuresimple/android-floating-action-button/issues/140#issuecomment-75480328","issue_url":"https://api.github.com/repos/futuresimple/android-floating-action-button/issues/140","id":75480328,"user":{"login":"adamsp","id":1720800,"avatar_url":"https://avatars.githubusercontent.com/u/1720800?v=3","gravatar_id":"","url":"https://api.github.com/users/adamsp","html_url":"https://github.com/adamsp","followers_url":"https://api.github.com/users/adamsp/followers","following_url":"https://api.github.com/users/adamsp/following{/other_user}","gists_url":"https://api.github.com/users/adamsp/gists{/gist_id}","starred_url":"https://api.github.com/users/adamsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamsp/subscriptions","organizations_url":"https://api.github.com/users/adamsp/orgs","repos_url":"https://api.github.com/users/adamsp/repos","events_url":"https://api.github.com/users/adamsp/events{/privacy}","received_events_url":"https://api.github.com/users/adamsp/received_events","type":"User","site_admin":false},"created_at":"2015-02-23T02:07:57Z","updated_at":"2015-02-23T02:07:57Z","body":"Well, this is rather embarrassing - I read the first few lines, and then didn't notice that the problem was actually resulting from another library. That library has fixed itself, and I was using an old/out-of-date version. Oops."}}