{"action":"created","comment":{"url":"https://api.github.com/repos/enb-make/enb/pulls/comments/38737015","id":38737015,"diff_hunk":"@@ -5,17 +5,26 @@ var dropRequireCache = require('../../../lib/fs/drop-require-cache');\n describe('fs/async-fs', function () {\n     var previousLimit;\n     var asyncFsPath;\n-    var optionsSpy;\n+    var sandbox;\n \n     before(function () {\n+        sandbox = sinon.sandbox.create();\n         previousLimit = process.env.ENB_FILE_LIMIT;\n         asyncFsPath = path.join(__dirname, '../../../lib/fs/async-fs.js');\n-        optionsSpy = sinon.spy(vowFs, 'options');\n     });\n \n     beforeEach(function () {\n         dropRequireCache(require, asyncFsPath);\n-        optionsSpy.reset();\n+        sandbox.stub(vowFs);","path":"test/lib/fs/async-fs.js","position":17,"original_position":17,"commit_id":"47c1f9b228177a7a63f71911092024ca9932de1d","original_commit_id":"47c1f9b228177a7a63f71911092024ca9932de1d","user":{"login":"SwinX","id":854899,"avatar_url":"https://avatars.githubusercontent.com/u/854899?v=3","gravatar_id":"","url":"https://api.github.com/users/SwinX","html_url":"https://github.com/SwinX","followers_url":"https://api.github.com/users/SwinX/followers","following_url":"https://api.github.com/users/SwinX/following{/other_user}","gists_url":"https://api.github.com/users/SwinX/gists{/gist_id}","starred_url":"https://api.github.com/users/SwinX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwinX/subscriptions","organizations_url":"https://api.github.com/users/SwinX/orgs","repos_url":"https://api.github.com/users/SwinX/repos","events_url":"https://api.github.com/users/SwinX/events{/privacy}","received_events_url":"https://api.github.com/users/SwinX/received_events","type":"User","site_admin":false},"body":"Да, но всё же так на мой взгляд удобнее, ничего не забудешь заресторить и сразу стаб есть, если нужен ещё 1 метод. Плюс мока ни одного теста медленным не считает, в среднем на тест 5-10ms на локальной машине.","created_at":"2015-09-04T09:53:26Z","updated_at":"2015-09-04T09:53:26Z","html_url":"https://github.com/enb-make/enb/pull/338#discussion_r38737015","pull_request_url":"https://api.github.com/repos/enb-make/enb/pulls/338","_links":{"self":{"href":"https://api.github.com/repos/enb-make/enb/pulls/comments/38737015"},"html":{"href":"https://github.com/enb-make/enb/pull/338#discussion_r38737015"},"pull_request":{"href":"https://api.github.com/repos/enb-make/enb/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/enb-make/enb/pulls/338","id":43402972,"html_url":"https://github.com/enb-make/enb/pull/338","diff_url":"https://github.com/enb-make/enb/pull/338.diff","patch_url":"https://github.com/enb-make/enb/pull/338.patch","issue_url":"https://api.github.com/repos/enb-make/enb/issues/338","number":338,"state":"open","locked":false,"title":"Tests for make platform","user":{"login":"SwinX","id":854899,"avatar_url":"https://avatars.githubusercontent.com/u/854899?v=3","gravatar_id":"","url":"https://api.github.com/users/SwinX","html_url":"https://github.com/SwinX","followers_url":"https://api.github.com/users/SwinX/followers","following_url":"https://api.github.com/users/SwinX/following{/other_user}","gists_url":"https://api.github.com/users/SwinX/gists{/gist_id}","starred_url":"https://api.github.com/users/SwinX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwinX/subscriptions","organizations_url":"https://api.github.com/users/SwinX/orgs","repos_url":"https://api.github.com/users/SwinX/repos","events_url":"https://api.github.com/users/SwinX/events{/privacy}","received_events_url":"https://api.github.com/users/SwinX/received_events","type":"User","site_admin":false},"body":"Resolves #262 ","created_at":"2015-08-26T13:43:05Z","updated_at":"2015-09-04T09:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25055b2f2d8d320e9b281bebb852045774aa585","assignee":{"login":"SwinX","id":854899,"avatar_url":"https://avatars.githubusercontent.com/u/854899?v=3","gravatar_id":"","url":"https://api.github.com/users/SwinX","html_url":"https://github.com/SwinX","followers_url":"https://api.github.com/users/SwinX/followers","following_url":"https://api.github.com/users/SwinX/following{/other_user}","gists_url":"https://api.github.com/users/SwinX/gists{/gist_id}","starred_url":"https://api.github.com/users/SwinX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwinX/subscriptions","organizations_url":"https://api.github.com/users/SwinX/orgs","repos_url":"https://api.github.com/users/SwinX/repos","events_url":"https://api.github.com/users/SwinX/events{/privacy}","received_events_url":"https://api.github.com/users/SwinX/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/enb-make/enb/pulls/338/commits","review_comments_url":"https://api.github.com/repos/enb-make/enb/pulls/338/comments","review_comment_url":"https://api.github.com/repos/enb-make/enb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enb-make/enb/issues/338/comments","statuses_url":"https://api.github.com/repos/enb-make/enb/statuses/47c1f9b228177a7a63f71911092024ca9932de1d","head":{"label":"enb-make:issue-262","ref":"issue-262","sha":"47c1f9b228177a7a63f71911092024ca9932de1d","user":{"login":"enb-make","id":4427117,"avatar_url":"https://avatars.githubusercontent.com/u/4427117?v=3","gravatar_id":"","url":"https://api.github.com/users/enb-make","html_url":"https://github.com/enb-make","followers_url":"https://api.github.com/users/enb-make/followers","following_url":"https://api.github.com/users/enb-make/following{/other_user}","gists_url":"https://api.github.com/users/enb-make/gists{/gist_id}","starred_url":"https://api.github.com/users/enb-make/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enb-make/subscriptions","organizations_url":"https://api.github.com/users/enb-make/orgs","repos_url":"https://api.github.com/users/enb-make/repos","events_url":"https://api.github.com/users/enb-make/events{/privacy}","received_events_url":"https://api.github.com/users/enb-make/received_events","type":"Organization","site_admin":false},"repo":{"id":10054361,"name":"enb","full_name":"enb-make/enb","owner":{"login":"enb-make","id":4427117,"avatar_url":"https://avatars.githubusercontent.com/u/4427117?v=3","gravatar_id":"","url":"https://api.github.com/users/enb-make","html_url":"https://github.com/enb-make","followers_url":"https://api.github.com/users/enb-make/followers","following_url":"https://api.github.com/users/enb-make/following{/other_user}","gists_url":"https://api.github.com/users/enb-make/gists{/gist_id}","starred_url":"https://api.github.com/users/enb-make/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enb-make/subscriptions","organizations_url":"https://api.github.com/users/enb-make/orgs","repos_url":"https://api.github.com/users/enb-make/repos","events_url":"https://api.github.com/users/enb-make/events{/privacy}","received_events_url":"https://api.github.com/users/enb-make/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enb-make/enb","description":"Faster BEM/BEViS assembler","fork":false,"url":"https://api.github.com/repos/enb-make/enb","forks_url":"https://api.github.com/repos/enb-make/enb/forks","keys_url":"https://api.github.com/repos/enb-make/enb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enb-make/enb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enb-make/enb/teams","hooks_url":"https://api.github.com/repos/enb-make/enb/hooks","issue_events_url":"https://api.github.com/repos/enb-make/enb/issues/events{/number}","events_url":"https://api.github.com/repos/enb-make/enb/events","assignees_url":"https://api.github.com/repos/enb-make/enb/assignees{/user}","branches_url":"https://api.github.com/repos/enb-make/enb/branches{/branch}","tags_url":"https://api.github.com/repos/enb-make/enb/tags","blobs_url":"https://api.github.com/repos/enb-make/enb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enb-make/enb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enb-make/enb/git/refs{/sha}","trees_url":"https://api.github.com/repos/enb-make/enb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enb-make/enb/statuses/{sha}","languages_url":"https://api.github.com/repos/enb-make/enb/languages","stargazers_url":"https://api.github.com/repos/enb-make/enb/stargazers","contributors_url":"https://api.github.com/repos/enb-make/enb/contributors","subscribers_url":"https://api.github.com/repos/enb-make/enb/subscribers","subscription_url":"https://api.github.com/repos/enb-make/enb/subscription","commits_url":"https://api.github.com/repos/enb-make/enb/commits{/sha}","git_commits_url":"https://api.github.com/repos/enb-make/enb/git/commits{/sha}","comments_url":"https://api.github.com/repos/enb-make/enb/comments{/number}","issue_comment_url":"https://api.github.com/repos/enb-make/enb/issues/comments{/number}","contents_url":"https://api.github.com/repos/enb-make/enb/contents/{+path}","compare_url":"https://api.github.com/repos/enb-make/enb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enb-make/enb/merges","archive_url":"https://api.github.com/repos/enb-make/enb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enb-make/enb/downloads","issues_url":"https://api.github.com/repos/enb-make/enb/issues{/number}","pulls_url":"https://api.github.com/repos/enb-make/enb/pulls{/number}","milestones_url":"https://api.github.com/repos/enb-make/enb/milestones{/number}","notifications_url":"https://api.github.com/repos/enb-make/enb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enb-make/enb/labels{/name}","releases_url":"https://api.github.com/repos/enb-make/enb/releases{/id}","created_at":"2013-05-14T12:15:32Z","updated_at":"2015-08-01T18:56:54Z","pushed_at":"2015-09-03T14:49:59Z","git_url":"git://github.com/enb-make/enb.git","ssh_url":"git@github.com:enb-make/enb.git","clone_url":"https://github.com/enb-make/enb.git","svn_url":"https://github.com/enb-make/enb","homepage":"http://enb-make.info","size":4004,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":48,"forks":46,"open_issues":48,"watchers":98,"default_branch":"master"}},"base":{"label":"enb-make:master","ref":"master","sha":"78eb2fbfd79ae637045da4ea9b899de7d9fee280","user":{"login":"enb-make","id":4427117,"avatar_url":"https://avatars.githubusercontent.com/u/4427117?v=3","gravatar_id":"","url":"https://api.github.com/users/enb-make","html_url":"https://github.com/enb-make","followers_url":"https://api.github.com/users/enb-make/followers","following_url":"https://api.github.com/users/enb-make/following{/other_user}","gists_url":"https://api.github.com/users/enb-make/gists{/gist_id}","starred_url":"https://api.github.com/users/enb-make/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enb-make/subscriptions","organizations_url":"https://api.github.com/users/enb-make/orgs","repos_url":"https://api.github.com/users/enb-make/repos","events_url":"https://api.github.com/users/enb-make/events{/privacy}","received_events_url":"https://api.github.com/users/enb-make/received_events","type":"Organization","site_admin":false},"repo":{"id":10054361,"name":"enb","full_name":"enb-make/enb","owner":{"login":"enb-make","id":4427117,"avatar_url":"https://avatars.githubusercontent.com/u/4427117?v=3","gravatar_id":"","url":"https://api.github.com/users/enb-make","html_url":"https://github.com/enb-make","followers_url":"https://api.github.com/users/enb-make/followers","following_url":"https://api.github.com/users/enb-make/following{/other_user}","gists_url":"https://api.github.com/users/enb-make/gists{/gist_id}","starred_url":"https://api.github.com/users/enb-make/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enb-make/subscriptions","organizations_url":"https://api.github.com/users/enb-make/orgs","repos_url":"https://api.github.com/users/enb-make/repos","events_url":"https://api.github.com/users/enb-make/events{/privacy}","received_events_url":"https://api.github.com/users/enb-make/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enb-make/enb","description":"Faster BEM/BEViS assembler","fork":false,"url":"https://api.github.com/repos/enb-make/enb","forks_url":"https://api.github.com/repos/enb-make/enb/forks","keys_url":"https://api.github.com/repos/enb-make/enb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enb-make/enb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enb-make/enb/teams","hooks_url":"https://api.github.com/repos/enb-make/enb/hooks","issue_events_url":"https://api.github.com/repos/enb-make/enb/issues/events{/number}","events_url":"https://api.github.com/repos/enb-make/enb/events","assignees_url":"https://api.github.com/repos/enb-make/enb/assignees{/user}","branches_url":"https://api.github.com/repos/enb-make/enb/branches{/branch}","tags_url":"https://api.github.com/repos/enb-make/enb/tags","blobs_url":"https://api.github.com/repos/enb-make/enb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enb-make/enb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enb-make/enb/git/refs{/sha}","trees_url":"https://api.github.com/repos/enb-make/enb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enb-make/enb/statuses/{sha}","languages_url":"https://api.github.com/repos/enb-make/enb/languages","stargazers_url":"https://api.github.com/repos/enb-make/enb/stargazers","contributors_url":"https://api.github.com/repos/enb-make/enb/contributors","subscribers_url":"https://api.github.com/repos/enb-make/enb/subscribers","subscription_url":"https://api.github.com/repos/enb-make/enb/subscription","commits_url":"https://api.github.com/repos/enb-make/enb/commits{/sha}","git_commits_url":"https://api.github.com/repos/enb-make/enb/git/commits{/sha}","comments_url":"https://api.github.com/repos/enb-make/enb/comments{/number}","issue_comment_url":"https://api.github.com/repos/enb-make/enb/issues/comments{/number}","contents_url":"https://api.github.com/repos/enb-make/enb/contents/{+path}","compare_url":"https://api.github.com/repos/enb-make/enb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enb-make/enb/merges","archive_url":"https://api.github.com/repos/enb-make/enb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enb-make/enb/downloads","issues_url":"https://api.github.com/repos/enb-make/enb/issues{/number}","pulls_url":"https://api.github.com/repos/enb-make/enb/pulls{/number}","milestones_url":"https://api.github.com/repos/enb-make/enb/milestones{/number}","notifications_url":"https://api.github.com/repos/enb-make/enb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enb-make/enb/labels{/name}","releases_url":"https://api.github.com/repos/enb-make/enb/releases{/id}","created_at":"2013-05-14T12:15:32Z","updated_at":"2015-08-01T18:56:54Z","pushed_at":"2015-09-03T14:49:59Z","git_url":"git://github.com/enb-make/enb.git","ssh_url":"git@github.com:enb-make/enb.git","clone_url":"https://github.com/enb-make/enb.git","svn_url":"https://github.com/enb-make/enb","homepage":"http://enb-make.info","size":4004,"stargazers_count":98,"watchers_count":98,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":48,"forks":46,"open_issues":48,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enb-make/enb/pulls/338"},"html":{"href":"https://github.com/enb-make/enb/pull/338"},"issue":{"href":"https://api.github.com/repos/enb-make/enb/issues/338"},"comments":{"href":"https://api.github.com/repos/enb-make/enb/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/enb-make/enb/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/enb-make/enb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enb-make/enb/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/enb-make/enb/statuses/47c1f9b228177a7a63f71911092024ca9932de1d"}}}}