{"action":"created","comment":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/comments/36594925","id":36594925,"diff_hunk":"@@ -97,25 +110,35 @@ MODx.SearchBar = function(config) {\n                     this.tpl.type = null;\n                 }\n             }\n-            ,focus: this.focusBar\n-            ,blur: this.blurBar\n+            ,focus: {\n+                fn: function(){\n+                    this.focusBar();\n+                }\n+            }\n+            ,blur: {\n+                fn: function(){\n+                    this.blurBar()\n+                }\n+            }\n             ,scope: this\n         }\n+\n     });\n+\n     MODx.SearchBar.superclass.constructor.call(this, config);\n-    //this.setKeyMap();\n+    this.setKeyMap();","path":"manager/assets/modext/widgets/core/modx.searchbar.js","position":184,"original_position":184,"commit_id":"e785a34c4234c108b9e1434e1193742d04a9cfe3","original_commit_id":"e785a34c4234c108b9e1434e1193742d04a9cfe3","user":{"login":"pixelchutes","id":352182,"avatar_url":"https://avatars.githubusercontent.com/u/352182?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelchutes","html_url":"https://github.com/pixelchutes","followers_url":"https://api.github.com/users/pixelchutes/followers","following_url":"https://api.github.com/users/pixelchutes/following{/other_user}","gists_url":"https://api.github.com/users/pixelchutes/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelchutes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelchutes/subscriptions","organizations_url":"https://api.github.com/users/pixelchutes/orgs","repos_url":"https://api.github.com/users/pixelchutes/repos","events_url":"https://api.github.com/users/pixelchutes/events{/privacy}","received_events_url":"https://api.github.com/users/pixelchutes/received_events","type":"User","site_admin":false},"body":"I worry about this re-opening these: #11794 and #11828 -- however, I also would like this functionality restored. Not sure how to prevent this issue for impacted keyboard regions while still enabling this, unless the shortcut itself is changed to something non-conflicting?","created_at":"2015-08-09T23:00:16Z","updated_at":"2015-08-09T23:00:16Z","html_url":"https://github.com/modxcms/revolution/pull/12533#discussion_r36594925","pull_request_url":"https://api.github.com/repos/modxcms/revolution/pulls/12533","_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments/36594925"},"html":{"href":"https://github.com/modxcms/revolution/pull/12533#discussion_r36594925"},"pull_request":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12533"}}},"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12533","id":41569817,"html_url":"https://github.com/modxcms/revolution/pull/12533","diff_url":"https://github.com/modxcms/revolution/pull/12533.diff","patch_url":"https://github.com/modxcms/revolution/pull/12533.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12533","number":12533,"state":"open","locked":false,"title":"Advanced uberbar ","user":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"body":"This pull request follows #12515. Existing commits by @pepebe have been cherry-picked, and new ones will be added per the discussion in #12515. \r\n\r\n### What does it do ?\r\nAdds advanced capabilities to the uberbar, allowing granular search. \r\n\r\n### Why is it needed ?\r\nMaking the uberbar more useful than it already was, also incorporating the \r\n\r\n### Related issue(s)/PR(s)\r\n#12515, #12283, #11117,\r\nSomewhat related but not entirely: #11116, #12041\r\n\r\n### Work in Progress\r\n\r\n* [x] Loose search by default, typing in a partial name and getting relevant results is way more intuitive. Gotta think of the end user here too.\r\n* [x] Don't require closing colons. `Acc` (or `Acc*`) should be a valid search, rather than needing to use `Acc*:`.\r\n* [x] Similar to above, but when doing a specific search like `:r:pagetitle:acc` the last colon should also not be required to move to the next step; simply assume the current step is complete if there is a valid value.\r\n* [x] Some searches (`:u:*:m*:`) seem to break the output while more specific ones work (`:u:username:m*:`)\r\n* [x] The search processor needs to be refactored to make it more maintainable and less spaghetti ","created_at":"2015-08-04T13:33:09Z","updated_at":"2015-08-09T23:00:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0745b75f0ba3f26f086239ae9bfc5bd196e2acdb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/12533/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/12533/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12533/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/e785a34c4234c108b9e1434e1193742d04a9cfe3","head":{"label":"Mark-H:feature-advanced-uberbar","ref":"feature-advanced-uberbar","sha":"e785a34c4234c108b9e1434e1193742d04a9cfe3","user":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"repo":{"id":2056222,"name":"revolution","full_name":"Mark-H/revolution","owner":{"login":"Mark-H","id":312944,"avatar_url":"https://avatars.githubusercontent.com/u/312944?v=3","gravatar_id":"","url":"https://api.github.com/users/Mark-H","html_url":"https://github.com/Mark-H","followers_url":"https://api.github.com/users/Mark-H/followers","following_url":"https://api.github.com/users/Mark-H/following{/other_user}","gists_url":"https://api.github.com/users/Mark-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Mark-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mark-H/subscriptions","organizations_url":"https://api.github.com/users/Mark-H/orgs","repos_url":"https://api.github.com/users/Mark-H/repos","events_url":"https://api.github.com/users/Mark-H/events{/privacy}","received_events_url":"https://api.github.com/users/Mark-H/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mark-H/revolution","description":"MODx Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/Mark-H/revolution","forks_url":"https://api.github.com/repos/Mark-H/revolution/forks","keys_url":"https://api.github.com/repos/Mark-H/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mark-H/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mark-H/revolution/teams","hooks_url":"https://api.github.com/repos/Mark-H/revolution/hooks","issue_events_url":"https://api.github.com/repos/Mark-H/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/Mark-H/revolution/events","assignees_url":"https://api.github.com/repos/Mark-H/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/Mark-H/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/Mark-H/revolution/tags","blobs_url":"https://api.github.com/repos/Mark-H/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mark-H/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mark-H/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mark-H/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mark-H/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/Mark-H/revolution/languages","stargazers_url":"https://api.github.com/repos/Mark-H/revolution/stargazers","contributors_url":"https://api.github.com/repos/Mark-H/revolution/contributors","subscribers_url":"https://api.github.com/repos/Mark-H/revolution/subscribers","subscription_url":"https://api.github.com/repos/Mark-H/revolution/subscription","commits_url":"https://api.github.com/repos/Mark-H/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mark-H/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mark-H/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mark-H/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mark-H/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/Mark-H/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mark-H/revolution/merges","archive_url":"https://api.github.com/repos/Mark-H/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mark-H/revolution/downloads","issues_url":"https://api.github.com/repos/Mark-H/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/Mark-H/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/Mark-H/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/Mark-H/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mark-H/revolution/labels{/name}","releases_url":"https://api.github.com/repos/Mark-H/revolution/releases{/id}","created_at":"2011-07-16T00:26:41Z","updated_at":"2015-03-31T18:43:34Z","pushed_at":"2015-08-09T21:26:04Z","git_url":"git://github.com/Mark-H/revolution.git","ssh_url":"git@github.com:Mark-H/revolution.git","clone_url":"https://github.com/Mark-H/revolution.git","svn_url":"https://github.com/Mark-H/revolution","homepage":"http://rtfm.modx.com/display/revolution","size":46232,"stargazers_count":15,"watchers_count":15,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":15,"default_branch":"develop"}},"base":{"label":"modxcms:develop","ref":"develop","sha":"815339651d2c60f981c4c7a58c2825a88ccc5e8e","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Application Platform","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","created_at":"2010-07-29T21:03:57Z","updated_at":"2015-08-02T11:48:59Z","pushed_at":"2015-08-09T21:41:34Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":79694,"stargazers_count":692,"watchers_count":692,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":355,"mirror_url":null,"open_issues_count":902,"forks":355,"open_issues":902,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12533"},"html":{"href":"https://github.com/modxcms/revolution/pull/12533"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12533"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12533/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12533/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12533/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/e785a34c4234c108b9e1434e1193742d04a9cfe3"}}}}