{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/48257135","id":48257135,"diff_hunk":"@@ -1,3 +1,5 @@\n+{% set colors = { 'success': '#4F805D', 'warning': '#A46A1F', 'error': '#B0413E' } %}","path":"src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig","position":1,"original_position":1,"commit_id":"3607083f6ec4668bfe66f7b4efa068fc9a486798","original_commit_id":"3607083f6ec4668bfe66f7b4efa068fc9a486798","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"I suggest adding a comment saying this should stay in sync with the variable defined in ``profiler.css.twig`` (and having a similar comment there, so that both sides are warning people). I will avoid mistakes where only one of them is updated","created_at":"2015-12-22T14:29:19Z","updated_at":"2015-12-22T14:29:19Z","html_url":"https://github.com/symfony/symfony/pull/17109#discussion_r48257135","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/17109","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/48257135"},"html":{"href":"https://github.com/symfony/symfony/pull/17109#discussion_r48257135"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17109"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/17109","id":54373225,"html_url":"https://github.com/symfony/symfony/pull/17109","diff_url":"https://github.com/symfony/symfony/pull/17109.diff","patch_url":"https://github.com/symfony/symfony/pull/17109.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/17109","number":17109,"state":"open","locked":false,"title":"Improved the design of the web debug toolbar","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThis PR contains three little improvements:\r\n\r\n## 1) Icon size\r\n\r\nSomehow, the size of the icons wasn't limited properly. This makes them appear too big and unaligns text vertically:\r\n\r\n### Before\r\n\r\n![before_icon_size](https://cloud.githubusercontent.com/assets/73419/11956693/5dce6432-a8bc-11e5-9726-958bbf95e945.png)\r\n\r\n### After\r\n\r\n![after_icon_size](https://cloud.githubusercontent.com/assets/73419/11956696/5faba396-a8bc-11e5-8453-6d9601803335.png)\r\n\r\n## 2) Status blocks\r\n\r\nIt's very common to have single-digit and double-digit status blocks in some panels. Now they show a different width:\r\n\r\n![before_status_1](https://cloud.githubusercontent.com/assets/73419/11956743/affd180c-a8bc-11e5-8c53-044b60dad53e.png) ![before_status_2](https://cloud.githubusercontent.com/assets/73419/11956744/b0ed99c6-a8bc-11e5-83d6-7a926e780d14.png)\r\n\r\nNow we set a minimum-width that looks good for single and double digit values:\r\n\r\n![after_status_1](https://cloud.githubusercontent.com/assets/73419/11956766/dff29758-a8bc-11e5-9eea-f6204acb2794.png) ![after_status_2](https://cloud.githubusercontent.com/assets/73419/11956768/e1af5f68-a8bc-11e5-8d07-e6219a667529.png)\r\n\r\nAlthough this solution doesn't solve the case when some block displays three digits, I think we can safely ignore that edge case.\r\n\r\n## 3) Colors\r\n\r\nThe green/yellow/red colors of the toolbar were different from the green/yellow/red colors of the profiler. The reason is that we designed the toolbar first and separately from the profiler. The second (minor) issue is that green and yellow didn't have enough contrast (they didn't pass the WCAG accessibility check).\r\n\r\nSo I propose to slightly change the green and yellow colors and to use the same colors in the toolbar and the profiler.\r\n\r\n### Toolbar Before\r\n\r\n![before_colors](https://cloud.githubusercontent.com/assets/73419/11956842/83e1c618-a8bd-11e5-9ac0-b97de8e70ec3.png)\r\n\r\n### Toolbar After\r\n\r\n![after_colors](https://cloud.githubusercontent.com/assets/73419/11956844/86759af8-a8bd-11e5-83c5-7ce2f74d4b88.png)\r\n\r\n### Profiler Before\r\n\r\n![before_profiler_success](https://cloud.githubusercontent.com/assets/73419/11956864/c21889a8-a8bd-11e5-95ee-8d6103b6a26c.png)\r\n\r\n![before_profiler_warning](https://cloud.githubusercontent.com/assets/73419/11956866/c3240e62-a8bd-11e5-8797-de3481dd40a0.png)\r\n\r\n![before_profiler_error](https://cloud.githubusercontent.com/assets/73419/11956867/c4d7b25e-a8bd-11e5-9e7a-6519b34009de.png)\r\n\r\n### Profiler After\r\n\r\n![after_profiler_success](https://cloud.githubusercontent.com/assets/73419/11956887/ea5ceabc-a8bd-11e5-8373-492e838148ea.png)\r\n\r\n![after_profiler_warning](https://cloud.githubusercontent.com/assets/73419/11956888/eb3bf284-a8bd-11e5-8be6-93a91ed2ae0e.png)\r\n\r\n![after_profiler_error](https://cloud.githubusercontent.com/assets/73419/11956889/ed057b4e-a8bd-11e5-9533-a807d8547843.png)\r\n\r\nThe new colors pass the accessibility requirements:\r\n\r\n![color_accessibility_success](https://cloud.githubusercontent.com/assets/73419/11956894/03ccbd60-a8be-11e5-96d2-727bb9b62dc7.png)\r\n\r\n![color_accessibility_warning](https://cloud.githubusercontent.com/assets/73419/11956896/04d893f0-a8be-11e5-8c18-9515f624974a.png)\r\n\r\n![color_accessibility_error](https://cloud.githubusercontent.com/assets/73419/11956899/06cbc524-a8be-11e5-8622-e2b60da1c8b2.png)\r\n\r\n","created_at":"2015-12-22T14:11:26Z","updated_at":"2015-12-22T14:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a1269852260caf9aab5b2dbd400b076f2de1e8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/17109/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/17109/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/17109/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/3607083f6ec4668bfe66f7b4efa068fc9a486798","head":{"label":"javiereguiluz:improve_toolbar_design","ref":"improve_toolbar_design","sha":"3607083f6ec4668bfe66f7b4efa068fc9a486798","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":15188086,"name":"symfony","full_name":"javiereguiluz/symfony","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/javiereguiluz/symfony","forks_url":"https://api.github.com/repos/javiereguiluz/symfony/forks","keys_url":"https://api.github.com/repos/javiereguiluz/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/symfony/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/symfony/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/symfony/events","assignees_url":"https://api.github.com/repos/javiereguiluz/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/symfony/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/symfony/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/symfony/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/symfony/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/symfony/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/symfony/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/symfony/merges","archive_url":"https://api.github.com/repos/javiereguiluz/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/symfony/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/symfony/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/symfony/releases{/id}","created_at":"2013-12-14T15:54:02Z","updated_at":"2015-11-05T11:38:17Z","pushed_at":"2015-12-22T13:54:44Z","git_url":"git://github.com/javiereguiluz/symfony.git","ssh_url":"git@github.com:javiereguiluz/symfony.git","clone_url":"https://github.com/javiereguiluz/symfony.git","svn_url":"https://github.com/javiereguiluz/symfony","homepage":"symfony.com","size":63549,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"symfony:2.8","ref":"2.8","sha":"352049c505cd14346917108d764d1fa12ac9f1f0","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-12-22T13:33:58Z","pushed_at":"2015-12-22T14:11:26Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":97723,"stargazers_count":11361,"watchers_count":11361,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4487,"mirror_url":null,"open_issues_count":893,"forks":4487,"open_issues":893,"watchers":11361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17109"},"html":{"href":"https://github.com/symfony/symfony/pull/17109"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/17109"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/17109/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17109/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17109/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/3607083f6ec4668bfe66f7b4efa068fc9a486798"}}}}