{"action":"created","issue":{"url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/108","labels_url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/108/comments","events_url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/108/events","html_url":"https://github.com/hollandben/grunt-cache-bust/pull/108","id":57862596,"number":108,"title":"Allow for relative paths","user":{"login":"hollandben","id":1148714,"avatar_url":"https://avatars.githubusercontent.com/u/1148714?v=3","gravatar_id":"","url":"https://api.github.com/users/hollandben","html_url":"https://github.com/hollandben","followers_url":"https://api.github.com/users/hollandben/followers","following_url":"https://api.github.com/users/hollandben/following{/other_user}","gists_url":"https://api.github.com/users/hollandben/gists{/gist_id}","starred_url":"https://api.github.com/users/hollandben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hollandben/subscriptions","organizations_url":"https://api.github.com/users/hollandben/orgs","repos_url":"https://api.github.com/users/hollandben/repos","events_url":"https://api.github.com/users/hollandben/events{/privacy}","received_events_url":"https://api.github.com/users/hollandben/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-16T23:14:29Z","updated_at":"2015-02-17T17:58:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hollandben/grunt-cache-bust/pulls/108","html_url":"https://github.com/hollandben/grunt-cache-bust/pull/108","diff_url":"https://github.com/hollandben/grunt-cache-bust/pull/108.diff","patch_url":"https://github.com/hollandben/grunt-cache-bust/pull/108.patch"},"body":"Extending from @mbenna's PR at #100 which follows on from issue #91.\r\n\r\nThis PR allows for relative paths to work without the `baseDir` option interfering.\r\n\r\nAlso contains some clean up that will mostly be done in #107 \r\n\r\n**Note:** I still say that you should be using relative paths from the root for ease, i.e. `/path/to/assets`"},"comment":{"url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/comments/74716569","html_url":"https://github.com/hollandben/grunt-cache-bust/pull/108#issuecomment-74716569","issue_url":"https://api.github.com/repos/hollandben/grunt-cache-bust/issues/108","id":74716569,"user":{"login":"mbenna","id":1588707,"avatar_url":"https://avatars.githubusercontent.com/u/1588707?v=3","gravatar_id":"","url":"https://api.github.com/users/mbenna","html_url":"https://github.com/mbenna","followers_url":"https://api.github.com/users/mbenna/followers","following_url":"https://api.github.com/users/mbenna/following{/other_user}","gists_url":"https://api.github.com/users/mbenna/gists{/gist_id}","starred_url":"https://api.github.com/users/mbenna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbenna/subscriptions","organizations_url":"https://api.github.com/users/mbenna/orgs","repos_url":"https://api.github.com/users/mbenna/repos","events_url":"https://api.github.com/users/mbenna/events{/privacy}","received_events_url":"https://api.github.com/users/mbenna/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T17:58:06Z","updated_at":"2015-02-17T17:58:06Z","body":"Yes, I think you nailed the core issue, i.e. that relative paths need different handling than absolute paths when it comes to baseDir.\r\n\r\nre: relative vs. absolute... yes, I'd rather use absolute, however sometimes the project is served from root (e.g. http://project.com/index.html) and other times it's served from a subdirectory (e.g. http://testserver.com/projectname/index.html). Adding relative path support to cache busting was easier than getting the whole project always served from root. :)\r\n\r\nThanks again for your help on this. I'm really looking forward to getting these changes into production and therefore getting a much higher % of our assets using far future expiry!\r\n\r\nMike\r\n"}}