{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/47336103","id":47336103,"diff_hunk":"@@ -236,4 +236,15 @@ public static String getProductVersion(final Host.Record record) {\n         }\n         return prodVersion;\n     }\n+\n+    public static String getPVbootloaderArgs(String guestOS) {\n+        if (guestOS.startsWith(\"SUSE Linux Enterprise Server\")) {\n+            if (guestOS.contains(\"64-bit\")) {\n+                return \"--kernel /boot/vmlinuz-xen --ramdisk /boot/initrd-xen\";\n+            } else if (guestOS.contains(\"32-bit\")) {\n+                return \"--kernel /boot/vmlinuz-xenpae --ramdisk /boot/initrd-xenpae\";\n+            }\n+        }\n+        return \"\";\n+    }","path":"plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java","position":14,"original_position":14,"commit_id":"c05f55d0bb88bbf3c028ac909ff792d1c23dff7e","original_commit_id":"fa81844812a26832e42b31e415de66277c59e3c5","user":{"login":"SudharmaJain","id":12229259,"avatar_url":"https://avatars.githubusercontent.com/u/12229259?v=3","gravatar_id":"","url":"https://api.github.com/users/SudharmaJain","html_url":"https://github.com/SudharmaJain","followers_url":"https://api.github.com/users/SudharmaJain/followers","following_url":"https://api.github.com/users/SudharmaJain/following{/other_user}","gists_url":"https://api.github.com/users/SudharmaJain/gists{/gist_id}","starred_url":"https://api.github.com/users/SudharmaJain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SudharmaJain/subscriptions","organizations_url":"https://api.github.com/users/SudharmaJain/orgs","repos_url":"https://api.github.com/users/SudharmaJain/repos","events_url":"https://api.github.com/users/SudharmaJain/events{/privacy}","received_events_url":"https://api.github.com/users/SudharmaJain/received_events","type":"User","site_admin":false},"body":"Added a unit test to cover the newly added method.\r\n\r\nThanks,\r\nSudharma","created_at":"2015-12-11T09:41:17Z","updated_at":"2015-12-11T09:41:17Z","html_url":"https://github.com/apache/cloudstack/pull/1196#discussion_r47336103","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/1196","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/47336103"},"html":{"href":"https://github.com/apache/cloudstack/pull/1196#discussion_r47336103"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1196"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1196","id":53084450,"html_url":"https://github.com/apache/cloudstack/pull/1196","diff_url":"https://github.com/apache/cloudstack/pull/1196.diff","patch_url":"https://github.com/apache/cloudstack/pull/1196.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1196","number":1196,"state":"open","locked":false,"title":"CLOUDSTACK-9127 Missing PV-bootloader-args for \"SUSE Linux Enterprise…","user":{"login":"SudharmaJain","id":12229259,"avatar_url":"https://avatars.githubusercontent.com/u/12229259?v=3","gravatar_id":"","url":"https://api.github.com/users/SudharmaJain","html_url":"https://github.com/SudharmaJain","followers_url":"https://api.github.com/users/SudharmaJain/followers","following_url":"https://api.github.com/users/SudharmaJain/following{/other_user}","gists_url":"https://api.github.com/users/SudharmaJain/gists{/gist_id}","starred_url":"https://api.github.com/users/SudharmaJain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SudharmaJain/subscriptions","organizations_url":"https://api.github.com/users/SudharmaJain/orgs","repos_url":"https://api.github.com/users/SudharmaJain/repos","events_url":"https://api.github.com/users/SudharmaJain/events{/privacy}","received_events_url":"https://api.github.com/users/SudharmaJain/received_events","type":"User","site_admin":false},"body":"… Server 10 SP2 and SP3\"\r\n\r\nISSUE\r\n--------\r\nSTOP-START of SUSE Linux VMs fail, as PV-bootloader-args are missing during the start command.\r\nDESCRIPTION\r\n----------------------\r\nRepro steps\r\n1. Upload Suse ISO \r\n2. Create a VM with this ISO, and install it.\r\n3. Detach ISO from the VM. \r\n4. Reboot the VM, :>>>> This will work fine, as the pv-bootloader-args are not missing during reboot.\r\n5.Stop the VM from CCP(VM will get destroyed in Xencenter)\r\n6. Start the same VM from CCP , it will try to start but will fail.\r\n\r\nBefore Applying the fix\r\n--------------------------------\r\nBefore applying the starting the VM failed with following exception \r\ncom.cloud.utils.exception.CloudRuntimeException: Unable to start VM(i-2-6-VM) on host(7cfd6388-b763-4c09-b3a3-9679db2904a3) due to Task failed! Task record:                 uuid: 21a6799f-9523-7c0e-bb86-1de750a38d74\r\n           nameLabel: Async.VM.start_on\r\n     nameDescription:\r\n   allowedOperations: []\r\n   currentOperations: {}\r\n             created: Wed Dec 09 07:00:29 UTC 2015\r\n            finished: Wed Dec 09 07:00:31 UTC 2015\r\n              status: failure\r\n          residentOn: com.xensource.xenapi.Host@513d238c\r\n            progress: 1.0\r\n                type: <none/>\r\n              result:\r\n           errorInfo: [BOOTLOADER_FAILED, OpaqueRef:0b10b6ac-837d-29af-da9d-6ef1e11a064a, Unable to find partition containing kernel\r\n]\r\n         otherConfig: {}\r\n           subtaskOf: com.xensource.xenapi.Task@aaf13f6f\r\n            subtasks: []\r\n\r\n![image](https://cloud.githubusercontent.com/assets/12229259/11678758/bd0fc9aa-9e70-11e5-9687-c77bfecaa4dd.png)\r\n\r\n\r\nAfter Applying the fix\r\n--------------------------\r\nAfter applying the fix I am able to start the vm.\r\n![image](https://cloud.githubusercontent.com/assets/12229259/11678938/6d44f5b0-9e72-11e5-83b0-60a736408b4d.png)\r\n","created_at":"2015-12-09T07:15:13Z","updated_at":"2015-12-11T09:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d61dadc2d554b088e9df5d3cffef7870913b101","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1196/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/c05f55d0bb88bbf3c028ac909ff792d1c23dff7e","head":{"label":"SudharmaJain:cs-9127","ref":"cs-9127","sha":"c05f55d0bb88bbf3c028ac909ff792d1c23dff7e","user":{"login":"SudharmaJain","id":12229259,"avatar_url":"https://avatars.githubusercontent.com/u/12229259?v=3","gravatar_id":"","url":"https://api.github.com/users/SudharmaJain","html_url":"https://github.com/SudharmaJain","followers_url":"https://api.github.com/users/SudharmaJain/followers","following_url":"https://api.github.com/users/SudharmaJain/following{/other_user}","gists_url":"https://api.github.com/users/SudharmaJain/gists{/gist_id}","starred_url":"https://api.github.com/users/SudharmaJain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SudharmaJain/subscriptions","organizations_url":"https://api.github.com/users/SudharmaJain/orgs","repos_url":"https://api.github.com/users/SudharmaJain/repos","events_url":"https://api.github.com/users/SudharmaJain/events{/privacy}","received_events_url":"https://api.github.com/users/SudharmaJain/received_events","type":"User","site_admin":false},"repo":{"id":40481092,"name":"cloudstack","full_name":"SudharmaJain/cloudstack","owner":{"login":"SudharmaJain","id":12229259,"avatar_url":"https://avatars.githubusercontent.com/u/12229259?v=3","gravatar_id":"","url":"https://api.github.com/users/SudharmaJain","html_url":"https://github.com/SudharmaJain","followers_url":"https://api.github.com/users/SudharmaJain/followers","following_url":"https://api.github.com/users/SudharmaJain/following{/other_user}","gists_url":"https://api.github.com/users/SudharmaJain/gists{/gist_id}","starred_url":"https://api.github.com/users/SudharmaJain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SudharmaJain/subscriptions","organizations_url":"https://api.github.com/users/SudharmaJain/orgs","repos_url":"https://api.github.com/users/SudharmaJain/repos","events_url":"https://api.github.com/users/SudharmaJain/events{/privacy}","received_events_url":"https://api.github.com/users/SudharmaJain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SudharmaJain/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/SudharmaJain/cloudstack","forks_url":"https://api.github.com/repos/SudharmaJain/cloudstack/forks","keys_url":"https://api.github.com/repos/SudharmaJain/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SudharmaJain/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SudharmaJain/cloudstack/teams","hooks_url":"https://api.github.com/repos/SudharmaJain/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/SudharmaJain/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/SudharmaJain/cloudstack/events","assignees_url":"https://api.github.com/repos/SudharmaJain/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/SudharmaJain/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/SudharmaJain/cloudstack/tags","blobs_url":"https://api.github.com/repos/SudharmaJain/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SudharmaJain/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SudharmaJain/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/SudharmaJain/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SudharmaJain/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/SudharmaJain/cloudstack/languages","stargazers_url":"https://api.github.com/repos/SudharmaJain/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/SudharmaJain/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/SudharmaJain/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/SudharmaJain/cloudstack/subscription","commits_url":"https://api.github.com/repos/SudharmaJain/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/SudharmaJain/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/SudharmaJain/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/SudharmaJain/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/SudharmaJain/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/SudharmaJain/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SudharmaJain/cloudstack/merges","archive_url":"https://api.github.com/repos/SudharmaJain/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SudharmaJain/cloudstack/downloads","issues_url":"https://api.github.com/repos/SudharmaJain/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/SudharmaJain/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/SudharmaJain/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/SudharmaJain/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SudharmaJain/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/SudharmaJain/cloudstack/releases{/id}","created_at":"2015-08-10T12:22:45Z","updated_at":"2015-08-10T12:23:07Z","pushed_at":"2015-12-11T09:39:05Z","git_url":"git://github.com/SudharmaJain/cloudstack.git","ssh_url":"git@github.com:SudharmaJain/cloudstack.git","clone_url":"https://github.com/SudharmaJain/cloudstack.git","svn_url":"https://github.com/SudharmaJain/cloudstack","homepage":null,"size":499542,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"312b9aff9490214c51cf6adf90661262c3670cd3","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-12-07T05:28:02Z","pushed_at":"2015-12-11T09:39:05Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":507879,"stargazers_count":323,"watchers_count":323,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":415,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":142,"forks":415,"open_issues":142,"watchers":323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1196"},"html":{"href":"https://github.com/apache/cloudstack/pull/1196"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1196"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/c05f55d0bb88bbf3c028ac909ff792d1c23dff7e"}}}}