{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/46000701","id":46000701,"diff_hunk":"@@ -122,8 +122,8 @@ def lookup_key_description(lookup_key, matcher, inherited_value)\n       :matcher => matcher, :inherited_value => inherited_value }\n   end\n \n-  def lookup_key_warnings(required, overridden)\n-    return { :text => '', :icon => 'info-sign' } if overridden\n+  def lookup_key_warnings(required, has_value)","path":"app/helpers/lookup_keys_helper.rb","position":22,"original_position":22,"commit_id":"6625ff456eeeba2f624d291af87b2f3f23d2c000","original_commit_id":"6625ff456eeeba2f624d291af87b2f3f23d2c000","user":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars.githubusercontent.com/u/1540531?v=3","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"body":"`has_value` is a better name, since this means we need no warnings.","created_at":"2015-11-26T18:14:03Z","updated_at":"2015-11-26T18:14:03Z","html_url":"https://github.com/theforeman/foreman/pull/2935#discussion_r46000701","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2935","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/46000701"},"html":{"href":"https://github.com/theforeman/foreman/pull/2935#discussion_r46000701"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2935"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2935","id":51885476,"html_url":"https://github.com/theforeman/foreman/pull/2935","diff_url":"https://github.com/theforeman/foreman/pull/2935.diff","patch_url":"https://github.com/theforeman/foreman/pull/2935.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2935","number":2935,"state":"open","locked":false,"title":"Fixes #12609 - correctly display boolean parameters on host edit form","user":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars.githubusercontent.com/u/1540531?v=3","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"body":"Booleans were not displayed correctly in certain cases due to the fact\r\nthat `false.present? == false` and `lookup_value.value ||\r\ninherited_value == true` in case one of them is true.","created_at":"2015-11-26T08:49:57Z","updated_at":"2015-11-26T18:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5896fe06533f1d88e18062d009efcf5bfe184121","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2935/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2935/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2935/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/6625ff456eeeba2f624d291af87b2f3f23d2c000","head":{"label":"tbrisker:12609","ref":"12609","sha":"6625ff456eeeba2f624d291af87b2f3f23d2c000","user":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars.githubusercontent.com/u/1540531?v=3","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"repo":{"id":22373475,"name":"foreman","full_name":"tbrisker/foreman","owner":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars.githubusercontent.com/u/1540531?v=3","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbrisker/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/tbrisker/foreman","forks_url":"https://api.github.com/repos/tbrisker/foreman/forks","keys_url":"https://api.github.com/repos/tbrisker/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbrisker/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbrisker/foreman/teams","hooks_url":"https://api.github.com/repos/tbrisker/foreman/hooks","issue_events_url":"https://api.github.com/repos/tbrisker/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/tbrisker/foreman/events","assignees_url":"https://api.github.com/repos/tbrisker/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/tbrisker/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/tbrisker/foreman/tags","blobs_url":"https://api.github.com/repos/tbrisker/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbrisker/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbrisker/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbrisker/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbrisker/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/tbrisker/foreman/languages","stargazers_url":"https://api.github.com/repos/tbrisker/foreman/stargazers","contributors_url":"https://api.github.com/repos/tbrisker/foreman/contributors","subscribers_url":"https://api.github.com/repos/tbrisker/foreman/subscribers","subscription_url":"https://api.github.com/repos/tbrisker/foreman/subscription","commits_url":"https://api.github.com/repos/tbrisker/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbrisker/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbrisker/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbrisker/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbrisker/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/tbrisker/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbrisker/foreman/merges","archive_url":"https://api.github.com/repos/tbrisker/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbrisker/foreman/downloads","issues_url":"https://api.github.com/repos/tbrisker/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/tbrisker/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/tbrisker/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/tbrisker/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbrisker/foreman/labels{/name}","releases_url":"https://api.github.com/repos/tbrisker/foreman/releases{/id}","created_at":"2014-07-29T08:48:53Z","updated_at":"2015-04-14T08:07:54Z","pushed_at":"2015-11-26T14:06:19Z","git_url":"git://github.com/tbrisker/foreman.git","ssh_url":"git@github.com:tbrisker/foreman.git","clone_url":"https://github.com/tbrisker/foreman.git","svn_url":"https://github.com/tbrisker/foreman","homepage":"http://theforeman.org","size":28373,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"203c10d7add75f4bcc2817fa85e5680a01a4ab6b","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-11-26T14:09:38Z","pushed_at":"2015-11-26T17:36:26Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":53292,"stargazers_count":901,"watchers_count":901,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":454,"mirror_url":null,"open_issues_count":89,"forks":454,"open_issues":89,"watchers":901,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2935"},"html":{"href":"https://github.com/theforeman/foreman/pull/2935"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2935"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2935/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2935/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2935/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/6625ff456eeeba2f624d291af87b2f3f23d2c000"}}}}