{"action":"created","comment":{"url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/comments/43222801","id":43222801,"diff_hunk":"@@ -0,0 +1,93 @@\n+/** @babel */\n+\n+import stdPath from 'path';\n+\n+\n+/**\n+ * Generates the return value for the wrapper property on first access\n+ * and caches it on the object. All future calls return the cached value\n+ * instead of re-calculating it.\n+ */\n+export function cachedProperty(target, key, descriptor) {\n+    let getter = descriptor.get;\n+    let cached_key = `_${key}_cached`;","path":"lib/utils.js","position":null,"original_position":13,"commit_id":"1f6e369798794fad36ad10b00f64b54634a4651f","original_commit_id":"305b508ef2de8283bfd85598e0b4df8d94656626","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"Done!","created_at":"2015-10-28T06:57:49Z","updated_at":"2015-10-28T06:57:49Z","html_url":"https://github.com/Osmose/advanced-open-file/pull/62#discussion_r43222801","pull_request_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/comments/43222801"},"html":{"href":"https://github.com/Osmose/advanced-open-file/pull/62#discussion_r43222801"},"pull_request":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62","id":48832089,"html_url":"https://github.com/Osmose/advanced-open-file/pull/62","diff_url":"https://github.com/Osmose/advanced-open-file/pull/62.diff","patch_url":"https://github.com/Osmose/advanced-open-file/pull/62.patch","issue_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/62","number":62,"state":"open","locked":false,"title":"Rewrite the whole damn thing. In ES2015!","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"body":"I started rewriting chunks of the code that I wasn't happy with, and after a while I realized it was starting to look like MVC, so I split things up that way and ended up mostly happy with the result. There's a few things I'm still not entirely happy with (like certain parts of the Path class) and there's some improvements that will come later (using async file reading methods instead of synchronous ones) but I think this is ready for testing and releasing.\r\n\r\nI tried to stick with CoffeeScript but ended up switching to ES2015 via Babel after getting frustrated too many times with the syntax.\r\n\r\nI'm going to start working on specs for this next. I also need to go through and document things better. In the meantime, feedback from anyone who is willing to download this branch and test it out would be _greatly_ appreciated.\r\n\r\nCC @artagnon @Traverse @pimentel for feedback if you have time. :D\r\n\r\n@mythmon I'll probably be asking you for a review once the specs are done, but any early feedback is appreciated as well.","created_at":"2015-10-27T06:07:44Z","updated_at":"2015-10-28T06:57:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4455ca0d045c2b0c5ceda8c580dbe1efe369245","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62/commits","review_comments_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62/comments","review_comment_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/62/comments","statuses_url":"https://api.github.com/repos/Osmose/advanced-open-file/statuses/1f6e369798794fad36ad10b00f64b54634a4651f","head":{"label":"Osmose:refactor","ref":"refactor","sha":"1f6e369798794fad36ad10b00f64b54634a4651f","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"repo":{"id":36160410,"name":"advanced-open-file","full_name":"Osmose/advanced-open-file","owner":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Osmose/advanced-open-file","description":"Open files and folders in Atom easily.","fork":false,"url":"https://api.github.com/repos/Osmose/advanced-open-file","forks_url":"https://api.github.com/repos/Osmose/advanced-open-file/forks","keys_url":"https://api.github.com/repos/Osmose/advanced-open-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Osmose/advanced-open-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Osmose/advanced-open-file/teams","hooks_url":"https://api.github.com/repos/Osmose/advanced-open-file/hooks","issue_events_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/events{/number}","events_url":"https://api.github.com/repos/Osmose/advanced-open-file/events","assignees_url":"https://api.github.com/repos/Osmose/advanced-open-file/assignees{/user}","branches_url":"https://api.github.com/repos/Osmose/advanced-open-file/branches{/branch}","tags_url":"https://api.github.com/repos/Osmose/advanced-open-file/tags","blobs_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Osmose/advanced-open-file/statuses/{sha}","languages_url":"https://api.github.com/repos/Osmose/advanced-open-file/languages","stargazers_url":"https://api.github.com/repos/Osmose/advanced-open-file/stargazers","contributors_url":"https://api.github.com/repos/Osmose/advanced-open-file/contributors","subscribers_url":"https://api.github.com/repos/Osmose/advanced-open-file/subscribers","subscription_url":"https://api.github.com/repos/Osmose/advanced-open-file/subscription","commits_url":"https://api.github.com/repos/Osmose/advanced-open-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/Osmose/advanced-open-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/Osmose/advanced-open-file/contents/{+path}","compare_url":"https://api.github.com/repos/Osmose/advanced-open-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Osmose/advanced-open-file/merges","archive_url":"https://api.github.com/repos/Osmose/advanced-open-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Osmose/advanced-open-file/downloads","issues_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues{/number}","pulls_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls{/number}","milestones_url":"https://api.github.com/repos/Osmose/advanced-open-file/milestones{/number}","notifications_url":"https://api.github.com/repos/Osmose/advanced-open-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Osmose/advanced-open-file/labels{/name}","releases_url":"https://api.github.com/repos/Osmose/advanced-open-file/releases{/id}","created_at":"2015-05-24T07:02:28Z","updated_at":"2015-10-21T22:09:24Z","pushed_at":"2015-10-28T06:57:32Z","git_url":"git://github.com/Osmose/advanced-open-file.git","ssh_url":"git@github.com:Osmose/advanced-open-file.git","clone_url":"https://github.com/Osmose/advanced-open-file.git","svn_url":"https://github.com/Osmose/advanced-open-file","homepage":"https://atom.io/packages/advanced-open-file","size":634,"stargazers_count":16,"watchers_count":16,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":16,"default_branch":"master"}},"base":{"label":"Osmose:master","ref":"master","sha":"a7f0781b2fb87fff0ef6958f8187aecc941000ca","user":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"repo":{"id":36160410,"name":"advanced-open-file","full_name":"Osmose/advanced-open-file","owner":{"login":"Osmose","id":193106,"avatar_url":"https://avatars.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Osmose/advanced-open-file","description":"Open files and folders in Atom easily.","fork":false,"url":"https://api.github.com/repos/Osmose/advanced-open-file","forks_url":"https://api.github.com/repos/Osmose/advanced-open-file/forks","keys_url":"https://api.github.com/repos/Osmose/advanced-open-file/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Osmose/advanced-open-file/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Osmose/advanced-open-file/teams","hooks_url":"https://api.github.com/repos/Osmose/advanced-open-file/hooks","issue_events_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/events{/number}","events_url":"https://api.github.com/repos/Osmose/advanced-open-file/events","assignees_url":"https://api.github.com/repos/Osmose/advanced-open-file/assignees{/user}","branches_url":"https://api.github.com/repos/Osmose/advanced-open-file/branches{/branch}","tags_url":"https://api.github.com/repos/Osmose/advanced-open-file/tags","blobs_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/refs{/sha}","trees_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Osmose/advanced-open-file/statuses/{sha}","languages_url":"https://api.github.com/repos/Osmose/advanced-open-file/languages","stargazers_url":"https://api.github.com/repos/Osmose/advanced-open-file/stargazers","contributors_url":"https://api.github.com/repos/Osmose/advanced-open-file/contributors","subscribers_url":"https://api.github.com/repos/Osmose/advanced-open-file/subscribers","subscription_url":"https://api.github.com/repos/Osmose/advanced-open-file/subscription","commits_url":"https://api.github.com/repos/Osmose/advanced-open-file/commits{/sha}","git_commits_url":"https://api.github.com/repos/Osmose/advanced-open-file/git/commits{/sha}","comments_url":"https://api.github.com/repos/Osmose/advanced-open-file/comments{/number}","issue_comment_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues/comments{/number}","contents_url":"https://api.github.com/repos/Osmose/advanced-open-file/contents/{+path}","compare_url":"https://api.github.com/repos/Osmose/advanced-open-file/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Osmose/advanced-open-file/merges","archive_url":"https://api.github.com/repos/Osmose/advanced-open-file/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Osmose/advanced-open-file/downloads","issues_url":"https://api.github.com/repos/Osmose/advanced-open-file/issues{/number}","pulls_url":"https://api.github.com/repos/Osmose/advanced-open-file/pulls{/number}","milestones_url":"https://api.github.com/repos/Osmose/advanced-open-file/milestones{/number}","notifications_url":"https://api.github.com/repos/Osmose/advanced-open-file/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Osmose/advanced-open-file/labels{/name}","releases_url":"https://api.github.com/repos/Osmose/advanced-open-file/releases{/id}","created_at":"2015-05-24T07:02:28Z","updated_at":"2015-10-21T22:09:24Z","pushed_at":"2015-10-28T06:57:32Z","git_url":"git://github.com/Osmose/advanced-open-file.git","ssh_url":"git@github.com:Osmose/advanced-open-file.git","clone_url":"https://github.com/Osmose/advanced-open-file.git","svn_url":"https://github.com/Osmose/advanced-open-file","homepage":"https://atom.io/packages/advanced-open-file","size":634,"stargazers_count":16,"watchers_count":16,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":11,"forks":4,"open_issues":11,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62"},"html":{"href":"https://github.com/Osmose/advanced-open-file/pull/62"},"issue":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/issues/62"},"comments":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/Osmose/advanced-open-file/statuses/1f6e369798794fad36ad10b00f64b54634a4651f"}}}}