{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12","id":45725334,"html_url":"https://github.com/coinbase/multisig-tool/pull/12","diff_url":"https://github.com/coinbase/multisig-tool/pull/12.diff","patch_url":"https://github.com/coinbase/multisig-tool/pull/12.patch","issue_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/12","number":12,"state":"closed","locked":false,"title":"Validating user/shared seeds correspond to xpubkeys","user":{"login":"mihar","id":5446,"avatar_url":"https://avatars.githubusercontent.com/u/5446?v=3","gravatar_id":"","url":"https://api.github.com/users/mihar","html_url":"https://github.com/mihar","followers_url":"https://api.github.com/users/mihar/followers","following_url":"https://api.github.com/users/mihar/following{/other_user}","gists_url":"https://api.github.com/users/mihar/gists{/gist_id}","starred_url":"https://api.github.com/users/mihar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihar/subscriptions","organizations_url":"https://api.github.com/users/mihar/orgs","repos_url":"https://api.github.com/users/mihar/repos","events_url":"https://api.github.com/users/mihar/events{/privacy}","received_events_url":"https://api.github.com/users/mihar/received_events","type":"User","site_admin":false},"body":"We did not do any checking before whether the password the user provided\r\nresulted in a valid decrypted seed that corresponds to one of the\r\nxpubkeys.\r\n\r\nWe also did not check if the unencrypted user seed corresponds to one of\r\nthe xpubkeys.\r\n\r\nThis resulted in a bad UX whereas user error would result in weird\r\nerrors that seemed like a problem in the code.","created_at":"2015-09-22T22:29:22Z","updated_at":"2015-09-22T22:29:33Z","closed_at":"2015-09-22T22:29:33Z","merged_at":"2015-09-22T22:29:33Z","merge_commit_sha":"52fa9b18b97742c6e7e718e598f5284a1b5b9c89","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12/commits","review_comments_url":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12/comments","review_comment_url":"https://api.github.com/repos/coinbase/multisig-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/12/comments","statuses_url":"https://api.github.com/repos/coinbase/multisig-tool/statuses/0078ac3778c9644c10648e2d16801d70fc6362a3","head":{"label":"coinbase:seed_validation","ref":"seed_validation","sha":"0078ac3778c9644c10648e2d16801d70fc6362a3","user":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"repo":{"id":25503960,"name":"multisig-tool","full_name":"coinbase/multisig-tool","owner":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coinbase/multisig-tool","description":"Multisig Vault recovery tool","fork":false,"url":"https://api.github.com/repos/coinbase/multisig-tool","forks_url":"https://api.github.com/repos/coinbase/multisig-tool/forks","keys_url":"https://api.github.com/repos/coinbase/multisig-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coinbase/multisig-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coinbase/multisig-tool/teams","hooks_url":"https://api.github.com/repos/coinbase/multisig-tool/hooks","issue_events_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/events{/number}","events_url":"https://api.github.com/repos/coinbase/multisig-tool/events","assignees_url":"https://api.github.com/repos/coinbase/multisig-tool/assignees{/user}","branches_url":"https://api.github.com/repos/coinbase/multisig-tool/branches{/branch}","tags_url":"https://api.github.com/repos/coinbase/multisig-tool/tags","blobs_url":"https://api.github.com/repos/coinbase/multisig-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coinbase/multisig-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coinbase/multisig-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/coinbase/multisig-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coinbase/multisig-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/coinbase/multisig-tool/languages","stargazers_url":"https://api.github.com/repos/coinbase/multisig-tool/stargazers","contributors_url":"https://api.github.com/repos/coinbase/multisig-tool/contributors","subscribers_url":"https://api.github.com/repos/coinbase/multisig-tool/subscribers","subscription_url":"https://api.github.com/repos/coinbase/multisig-tool/subscription","commits_url":"https://api.github.com/repos/coinbase/multisig-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/coinbase/multisig-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/coinbase/multisig-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/coinbase/multisig-tool/contents/{+path}","compare_url":"https://api.github.com/repos/coinbase/multisig-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coinbase/multisig-tool/merges","archive_url":"https://api.github.com/repos/coinbase/multisig-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coinbase/multisig-tool/downloads","issues_url":"https://api.github.com/repos/coinbase/multisig-tool/issues{/number}","pulls_url":"https://api.github.com/repos/coinbase/multisig-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/coinbase/multisig-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/coinbase/multisig-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coinbase/multisig-tool/labels{/name}","releases_url":"https://api.github.com/repos/coinbase/multisig-tool/releases{/id}","created_at":"2014-10-21T05:23:58Z","updated_at":"2015-09-22T06:53:00Z","pushed_at":"2015-09-22T22:29:33Z","git_url":"git://github.com/coinbase/multisig-tool.git","ssh_url":"git@github.com:coinbase/multisig-tool.git","clone_url":"https://github.com/coinbase/multisig-tool.git","svn_url":"https://github.com/coinbase/multisig-tool","homepage":"http://coinbase.github.io/multisig-tool/","size":932,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":1,"forks":18,"open_issues":1,"watchers":44,"default_branch":"master"}},"base":{"label":"coinbase:master","ref":"master","sha":"1f88bf6842da46c07d33d3320e5b14d25a5d1eaa","user":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"repo":{"id":25503960,"name":"multisig-tool","full_name":"coinbase/multisig-tool","owner":{"login":"coinbase","id":1885080,"avatar_url":"https://avatars.githubusercontent.com/u/1885080?v=3","gravatar_id":"","url":"https://api.github.com/users/coinbase","html_url":"https://github.com/coinbase","followers_url":"https://api.github.com/users/coinbase/followers","following_url":"https://api.github.com/users/coinbase/following{/other_user}","gists_url":"https://api.github.com/users/coinbase/gists{/gist_id}","starred_url":"https://api.github.com/users/coinbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coinbase/subscriptions","organizations_url":"https://api.github.com/users/coinbase/orgs","repos_url":"https://api.github.com/users/coinbase/repos","events_url":"https://api.github.com/users/coinbase/events{/privacy}","received_events_url":"https://api.github.com/users/coinbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coinbase/multisig-tool","description":"Multisig Vault recovery tool","fork":false,"url":"https://api.github.com/repos/coinbase/multisig-tool","forks_url":"https://api.github.com/repos/coinbase/multisig-tool/forks","keys_url":"https://api.github.com/repos/coinbase/multisig-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coinbase/multisig-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coinbase/multisig-tool/teams","hooks_url":"https://api.github.com/repos/coinbase/multisig-tool/hooks","issue_events_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/events{/number}","events_url":"https://api.github.com/repos/coinbase/multisig-tool/events","assignees_url":"https://api.github.com/repos/coinbase/multisig-tool/assignees{/user}","branches_url":"https://api.github.com/repos/coinbase/multisig-tool/branches{/branch}","tags_url":"https://api.github.com/repos/coinbase/multisig-tool/tags","blobs_url":"https://api.github.com/repos/coinbase/multisig-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coinbase/multisig-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coinbase/multisig-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/coinbase/multisig-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coinbase/multisig-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/coinbase/multisig-tool/languages","stargazers_url":"https://api.github.com/repos/coinbase/multisig-tool/stargazers","contributors_url":"https://api.github.com/repos/coinbase/multisig-tool/contributors","subscribers_url":"https://api.github.com/repos/coinbase/multisig-tool/subscribers","subscription_url":"https://api.github.com/repos/coinbase/multisig-tool/subscription","commits_url":"https://api.github.com/repos/coinbase/multisig-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/coinbase/multisig-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/coinbase/multisig-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/coinbase/multisig-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/coinbase/multisig-tool/contents/{+path}","compare_url":"https://api.github.com/repos/coinbase/multisig-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coinbase/multisig-tool/merges","archive_url":"https://api.github.com/repos/coinbase/multisig-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coinbase/multisig-tool/downloads","issues_url":"https://api.github.com/repos/coinbase/multisig-tool/issues{/number}","pulls_url":"https://api.github.com/repos/coinbase/multisig-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/coinbase/multisig-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/coinbase/multisig-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coinbase/multisig-tool/labels{/name}","releases_url":"https://api.github.com/repos/coinbase/multisig-tool/releases{/id}","created_at":"2014-10-21T05:23:58Z","updated_at":"2015-09-22T06:53:00Z","pushed_at":"2015-09-22T22:29:33Z","git_url":"git://github.com/coinbase/multisig-tool.git","ssh_url":"git@github.com:coinbase/multisig-tool.git","clone_url":"https://github.com/coinbase/multisig-tool.git","svn_url":"https://github.com/coinbase/multisig-tool","homepage":"http://coinbase.github.io/multisig-tool/","size":932,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":1,"forks":18,"open_issues":1,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12"},"html":{"href":"https://github.com/coinbase/multisig-tool/pull/12"},"issue":{"href":"https://api.github.com/repos/coinbase/multisig-tool/issues/12"},"comments":{"href":"https://api.github.com/repos/coinbase/multisig-tool/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/coinbase/multisig-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coinbase/multisig-tool/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/coinbase/multisig-tool/statuses/0078ac3778c9644c10648e2d16801d70fc6362a3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mihar","id":5446,"avatar_url":"https://avatars.githubusercontent.com/u/5446?v=3","gravatar_id":"","url":"https://api.github.com/users/mihar","html_url":"https://github.com/mihar","followers_url":"https://api.github.com/users/mihar/followers","following_url":"https://api.github.com/users/mihar/following{/other_user}","gists_url":"https://api.github.com/users/mihar/gists{/gist_id}","starred_url":"https://api.github.com/users/mihar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihar/subscriptions","organizations_url":"https://api.github.com/users/mihar/orgs","repos_url":"https://api.github.com/users/mihar/repos","events_url":"https://api.github.com/users/mihar/events{/privacy}","received_events_url":"https://api.github.com/users/mihar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":62,"deletions":19,"changed_files":4}}