{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/22534937","id":22534937,"diff_hunk":"@@ -140,6 +194,16 @@ func InitDriver(job *engine.Job) engine.Status {\n \t\tif err := ioutil.WriteFile(\"/proc/sys/net/ipv4/ip_forward\", []byte{'1', '\\n'}, 0644); err != nil {\n \t\t\tjob.Logf(\"WARNING: unable to enable IPv4 forwarding: %s\\n\", err)\n \t\t}\n+\n+\t\tif enableIPv6 {\n+\t\t\t// Enable IPv6 forwarding\n+\t\t\tif err := ioutil.WriteFile(\"/proc/sys/net/ipv6/conf/default/forwarding\", []byte{'1', '\\n'}, 0644); err != nil {\n+\t\t\t\tjob.Logf(\"WARNING: unable to enable IPv6 default forwarding: %s\\n\", err)\n+\t\t\t}\n+\t\t\tif err := ioutil.WriteFile(\"/proc/sys/net/ipv6/conf/all/forwarding\", []byte{'1', '\\n'}, 0644); err != nil {","path":"daemon/networkdriver/bridge/driver.go","position":159,"original_position":159,"commit_id":"3c10e0d70e8049715b0d74026082ab72a7db2e31","original_commit_id":"3c10e0d70e8049715b0d74026082ab72a7db2e31","user":{"login":"tianon","id":161631,"avatar_url":"https://avatars.githubusercontent.com/u/161631?v=3","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},"body":"Ok, so let me paint this picture a different way (from the perspective of a prospective user):\r\n\r\n1. user has IPv6; they don't like configuration hassle, so they go the easy route and setup RA\r\n2. user now goes to http://whatismyv6.com and sees IPv6, knows they have IPv6, are happy :tada:\r\n3. user starts using Docker and thinks \"wow, this is cool, I wish it could use my IPv6!\"\r\n4. user notices that it has a toggle on the daemon to enable IPv6, so of course they go turn it on immediately, and they even hand it a `fixed-cidr` because they have one -- it's the one their router is handing out via RA\r\n5. user no longer has IPv6 on their computer thanks to RA being disabled by Docker","created_at":"2015-01-06T17:05:34Z","updated_at":"2015-01-06T17:05:34Z","html_url":"https://github.com/docker/docker/pull/8947#discussion_r22534937","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/8947","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/22534937"},"html":{"href":"https://github.com/docker/docker/pull/8947#discussion_r22534937"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/8947"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/8947","id":23842739,"html_url":"https://github.com/docker/docker/pull/8947","diff_url":"https://github.com/docker/docker/pull/8947.diff","patch_url":"https://github.com/docker/docker/pull/8947.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/8947","number":8947,"state":"open","locked":false,"title":"Adding IPv6 network support to docker daemon","user":{"login":"MalteJ","id":646688,"avatar_url":"https://avatars.githubusercontent.com/u/646688?v=3","gravatar_id":"","url":"https://api.github.com/users/MalteJ","html_url":"https://github.com/MalteJ","followers_url":"https://api.github.com/users/MalteJ/followers","following_url":"https://api.github.com/users/MalteJ/following{/other_user}","gists_url":"https://api.github.com/users/MalteJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MalteJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalteJ/subscriptions","organizations_url":"https://api.github.com/users/MalteJ/orgs","repos_url":"https://api.github.com/users/MalteJ/repos","events_url":"https://api.github.com/users/MalteJ/events{/privacy}","received_events_url":"https://api.github.com/users/MalteJ/received_events","type":"User","site_admin":false},"body":"This PR adds IPv6 support to the docker daemon.\r\nFeatures:\r\n- adding CLI flags `--ipv6` and `--fixed-cidr-v6`\r\n- Setting the bridge IPv6 to `fe80::1/64`. This IP will be used by the containers as gateway.\r\n- registers the fixed-cidr-v6 in the ipallocator\r\n\r\nMissing:\r\nTest and Documentation.\r\nFollow-up PR for enabling the container to use IPv6. (I have the code but still have to clean it up a bit and create a PR).\r\nI wanted to add them but #8896 popped up and I thought it would be a good idea to provide my code so we can compare and pick the best of both.\r\n\r\n**Update 2014-11-04**\r\n- Documentation is improving\r\n- Container IPv6 Implementation is included in this PR as a separate commit","created_at":"2014-11-04T16:16:36Z","updated_at":"2015-01-06T17:05:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7176c97a780df02ab0d4135627e8d3dbb2341a54","assignee":{"login":"jfrazelle","id":1445228,"avatar_url":"https://avatars.githubusercontent.com/u/1445228?v=3","gravatar_id":"","url":"https://api.github.com/users/jfrazelle","html_url":"https://github.com/jfrazelle","followers_url":"https://api.github.com/users/jfrazelle/followers","following_url":"https://api.github.com/users/jfrazelle/following{/other_user}","gists_url":"https://api.github.com/users/jfrazelle/gists{/gist_id}","starred_url":"https://api.github.com/users/jfrazelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfrazelle/subscriptions","organizations_url":"https://api.github.com/users/jfrazelle/orgs","repos_url":"https://api.github.com/users/jfrazelle/repos","events_url":"https://api.github.com/users/jfrazelle/events{/privacy}","received_events_url":"https://api.github.com/users/jfrazelle/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/34","labels_url":"https://api.github.com/repos/docker/docker/milestones/34/labels","id":906381,"number":34,"title":"1.5.0","description":"### NOTICE:\r\n\r\nIssues and PRs included in milestones are not a guarantee that they will be merged or included in a release. \r\n\r\n### RELEASE MANAGER:\r\n\r\n@icecrime will be the point of contact for the 1.5.0 release. \r\n\r\n### CODE FREEZE:\r\n\r\nCode freeze will begin on January 20th for the final features to be included in Docker 1.5.0.  Any features not merged by this time will not be included **or** considered for a release.  At this time a bump branch with the final commits for this release will be created and an RC will be pushed to https://test.docker.com for QA and testing in advance of the Feb. 3 release. date. ","creator":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars.githubusercontent.com/u/749551?v=3","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":8,"state":"open","created_at":"2014-12-16T23:52:21Z","updated_at":"2015-01-06T00:41:46Z","due_on":"2015-02-03T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/8947/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/8947/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments/{number}","comments_url":"https://api.github.com/repos/docker/docker/issues/8947/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/3c10e0d70e8049715b0d74026082ab72a7db2e31","head":{"label":"MalteJ:ipv6-daemon","ref":"ipv6-daemon","sha":"3c10e0d70e8049715b0d74026082ab72a7db2e31","user":{"login":"MalteJ","id":646688,"avatar_url":"https://avatars.githubusercontent.com/u/646688?v=3","gravatar_id":"","url":"https://api.github.com/users/MalteJ","html_url":"https://github.com/MalteJ","followers_url":"https://api.github.com/users/MalteJ/followers","following_url":"https://api.github.com/users/MalteJ/following{/other_user}","gists_url":"https://api.github.com/users/MalteJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MalteJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalteJ/subscriptions","organizations_url":"https://api.github.com/users/MalteJ/orgs","repos_url":"https://api.github.com/users/MalteJ/repos","events_url":"https://api.github.com/users/MalteJ/events{/privacy}","received_events_url":"https://api.github.com/users/MalteJ/received_events","type":"User","site_admin":false},"repo":{"id":24332204,"name":"docker","full_name":"MalteJ/docker","owner":{"login":"MalteJ","id":646688,"avatar_url":"https://avatars.githubusercontent.com/u/646688?v=3","gravatar_id":"","url":"https://api.github.com/users/MalteJ","html_url":"https://github.com/MalteJ","followers_url":"https://api.github.com/users/MalteJ/followers","following_url":"https://api.github.com/users/MalteJ/following{/other_user}","gists_url":"https://api.github.com/users/MalteJ/gists{/gist_id}","starred_url":"https://api.github.com/users/MalteJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalteJ/subscriptions","organizations_url":"https://api.github.com/users/MalteJ/orgs","repos_url":"https://api.github.com/users/MalteJ/repos","events_url":"https://api.github.com/users/MalteJ/events{/privacy}","received_events_url":"https://api.github.com/users/MalteJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MalteJ/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/MalteJ/docker","forks_url":"https://api.github.com/repos/MalteJ/docker/forks","keys_url":"https://api.github.com/repos/MalteJ/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MalteJ/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MalteJ/docker/teams","hooks_url":"https://api.github.com/repos/MalteJ/docker/hooks","issue_events_url":"https://api.github.com/repos/MalteJ/docker/issues/events{/number}","events_url":"https://api.github.com/repos/MalteJ/docker/events","assignees_url":"https://api.github.com/repos/MalteJ/docker/assignees{/user}","branches_url":"https://api.github.com/repos/MalteJ/docker/branches{/branch}","tags_url":"https://api.github.com/repos/MalteJ/docker/tags","blobs_url":"https://api.github.com/repos/MalteJ/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MalteJ/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MalteJ/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MalteJ/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MalteJ/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/MalteJ/docker/languages","stargazers_url":"https://api.github.com/repos/MalteJ/docker/stargazers","contributors_url":"https://api.github.com/repos/MalteJ/docker/contributors","subscribers_url":"https://api.github.com/repos/MalteJ/docker/subscribers","subscription_url":"https://api.github.com/repos/MalteJ/docker/subscription","commits_url":"https://api.github.com/repos/MalteJ/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MalteJ/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MalteJ/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MalteJ/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/MalteJ/docker/contents/{+path}","compare_url":"https://api.github.com/repos/MalteJ/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MalteJ/docker/merges","archive_url":"https://api.github.com/repos/MalteJ/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MalteJ/docker/downloads","issues_url":"https://api.github.com/repos/MalteJ/docker/issues{/number}","pulls_url":"https://api.github.com/repos/MalteJ/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/MalteJ/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/MalteJ/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MalteJ/docker/labels{/name}","releases_url":"https://api.github.com/repos/MalteJ/docker/releases{/id}","created_at":"2014-09-22T14:37:27Z","updated_at":"2014-09-22T14:46:32Z","pushed_at":"2015-01-06T00:26:08Z","git_url":"git://github.com/MalteJ/docker.git","ssh_url":"git@github.com:MalteJ/docker.git","clone_url":"https://github.com/MalteJ/docker.git","svn_url":"https://github.com/MalteJ/docker","homepage":"http://www.docker.com","size":38697,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"4235e2796ba19e50d6261489e817b8422ba43df0","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments/{number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-01-06T16:53:11Z","pushed_at":"2015-01-06T05:35:30Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":123245,"stargazers_count":18154,"watchers_count":18154,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3684,"mirror_url":null,"open_issues_count":1009,"forks":3684,"open_issues":1009,"watchers":18154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/8947"},"html":{"href":"https://github.com/docker/docker/pull/8947"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/8947"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/8947/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/8947/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/8947/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/3c10e0d70e8049715b0d74026082ab72a7db2e31"}}}}