{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/320","labels_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/320/comments","events_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/320/events","html_url":"https://github.com/apache/incubator-brooklyn/pull/320","id":48446912,"number":320,"title":"Refactor config methods","user":{"login":"aledsage","id":593113,"avatar_url":"https://avatars.githubusercontent.com/u/593113?v=3","gravatar_id":"","url":"https://api.github.com/users/aledsage","html_url":"https://github.com/aledsage","followers_url":"https://api.github.com/users/aledsage/followers","following_url":"https://api.github.com/users/aledsage/following{/other_user}","gists_url":"https://api.github.com/users/aledsage/gists{/gist_id}","starred_url":"https://api.github.com/users/aledsage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledsage/subscriptions","organizations_url":"https://api.github.com/users/aledsage/orgs","repos_url":"https://api.github.com/users/aledsage/repos","events_url":"https://api.github.com/users/aledsage/events{/privacy}","received_events_url":"https://api.github.com/users/aledsage/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2014-11-11T22:54:33Z","updated_at":"2015-02-18T11:48:31Z","closed_at":"2015-02-18T11:32:14Z","pull_request":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/pulls/320","html_url":"https://github.com/apache/incubator-brooklyn/pull/320","diff_url":"https://github.com/apache/incubator-brooklyn/pull/320.diff","patch_url":"https://github.com/apache/incubator-brooklyn/pull/320.patch"},"body":"Creates a BrooklynObject.config(), and deprecates the crazy number of inconsistent config accessor/setter methods we have on Entity/Location/Policy/Enricher.\r\n\r\nNote that `AbstractEntity`, `AbstractLocation` and `AbstractEntityAdjuct` all still have their own implementation of config. Until we delete the additional deprecated access/setter methods, it will be difficult to rationalise this down into a single implementation within `AbstractBrooklynObject`. I suggest we do that as soon as we begin work on 0.8.0-SNAPSHOT.\r\n\r\nPlease merge https://github.com/apache/incubator-brooklyn/pull/319 first (for the groovy version upgrade to 2.3.4). Without that, it fails to compile with `BrooklynObject.config()` returning `ConfigurationSupport` and `BrooklynObjectInternal.config()` returning the sub-class `ConfigurationSupportInternal`.\r\n\r\nWhen reviewing, please focus on the two commits `Add BrooklynObject.config()` and `Deprecate *Config methods in Location/Enricher/Policy`. The other commits contain a massive number of boring changes to make things use the new `config().set(key, val)` rather than the old `setConfig(key, val)` etc."},"comment":{"url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/comments/74851966","html_url":"https://github.com/apache/incubator-brooklyn/pull/320#issuecomment-74851966","issue_url":"https://api.github.com/repos/apache/incubator-brooklyn/issues/320","id":74851966,"user":{"login":"asfbot","id":5243949,"avatar_url":"https://avatars.githubusercontent.com/u/5243949?v=3","gravatar_id":"","url":"https://api.github.com/users/asfbot","html_url":"https://github.com/asfbot","followers_url":"https://api.github.com/users/asfbot/followers","following_url":"https://api.github.com/users/asfbot/following{/other_user}","gists_url":"https://api.github.com/users/asfbot/gists{/gist_id}","starred_url":"https://api.github.com/users/asfbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfbot/subscriptions","organizations_url":"https://api.github.com/users/asfbot/orgs","repos_url":"https://api.github.com/users/asfbot/repos","events_url":"https://api.github.com/users/asfbot/events{/privacy}","received_events_url":"https://api.github.com/users/asfbot/received_events","type":"User","site_admin":false},"created_at":"2015-02-18T11:48:31Z","updated_at":"2015-02-18T11:48:31Z","body":"[incubator-brooklyn-pull-requests #804](https://builds.apache.org/job/incubator-brooklyn-pull-requests/804/) SUCCESS\nThis pull request looks good"}}