{"action":"opened","issue":{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/3301","labels_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/3301/labels{/name}","comments_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/3301/comments","events_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/issues/3301/events","html_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/3301","id":64085900,"number":3301,"title":"Use empty() instead of strict type check in edd_get_payment_tax()","user":{"login":"pippinsplugins","id":1034109,"avatar_url":"https://avatars.githubusercontent.com/u/1034109?v=3","gravatar_id":"","url":"https://api.github.com/users/pippinsplugins","html_url":"https://github.com/pippinsplugins","followers_url":"https://api.github.com/users/pippinsplugins/followers","following_url":"https://api.github.com/users/pippinsplugins/following{/other_user}","gists_url":"https://api.github.com/users/pippinsplugins/gists{/gist_id}","starred_url":"https://api.github.com/users/pippinsplugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pippinsplugins/subscriptions","organizations_url":"https://api.github.com/users/pippinsplugins/orgs","repos_url":"https://api.github.com/users/pippinsplugins/repos","events_url":"https://api.github.com/users/pippinsplugins/events{/privacy}","received_events_url":"https://api.github.com/users/pippinsplugins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/labels/Bug","name":"Bug","color":"fc2929"},{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/labels/High%20Priority","name":"High Priority","color":"207005"},{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/labels/Taxes","name":"Taxes","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/milestones/97","html_url":"https://github.com/easydigitaldownloads/Easy-Digital-Downloads/milestones/2.3.5","labels_url":"https://api.github.com/repos/easydigitaldownloads/Easy-Digital-Downloads/milestones/97/labels","id":1031468,"number":97,"title":"2.3.5","description":null,"creator":{"login":"pippinsplugins","id":1034109,"avatar_url":"https://avatars.githubusercontent.com/u/1034109?v=3","gravatar_id":"","url":"https://api.github.com/users/pippinsplugins","html_url":"https://github.com/pippinsplugins","followers_url":"https://api.github.com/users/pippinsplugins/followers","following_url":"https://api.github.com/users/pippinsplugins/following{/other_user}","gists_url":"https://api.github.com/users/pippinsplugins/gists{/gist_id}","starred_url":"https://api.github.com/users/pippinsplugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pippinsplugins/subscriptions","organizations_url":"https://api.github.com/users/pippinsplugins/orgs","repos_url":"https://api.github.com/users/pippinsplugins/repos","events_url":"https://api.github.com/users/pippinsplugins/events{/privacy}","received_events_url":"https://api.github.com/users/pippinsplugins/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2015-03-20T18:12:12Z","updated_at":"2015-03-24T19:57:23Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2015-03-24T19:57:23Z","updated_at":"2015-03-24T19:57:23Z","closed_at":null,"body":"The `_edd_payment_tax` meta key was introduced in 2.3. In order to properly support payment records that don't have the `_edd_payment_tax` meta key stored, we have a fallback check in `edd_get_payment_tax()` that pulls the tax from `_edd_payment_meta` if the return on `_edd_payment_tax` is `false`.\r\n\r\nThis check is too strict sense the return from `get_post_meta()` won't be false if the meta key exists but has no value.\r\n\r\nWe should swap `if( false === $tax )` with `if( empty( $tax ) )`."}}