{"action":"created","issue":{"url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/37","labels_url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/37/comments","events_url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/37/events","html_url":"https://github.com/ortoo/node-redis-sentinel/issues/37","id":66682413,"number":37,"title":"Redis client crashes process when it attempts a retry.","user":{"login":"greim","id":317786,"avatar_url":"https://avatars.githubusercontent.com/u/317786?v=3","gravatar_id":"","url":"https://api.github.com/users/greim","html_url":"https://github.com/greim","followers_url":"https://api.github.com/users/greim/followers","following_url":"https://api.github.com/users/greim/following{/other_user}","gists_url":"https://api.github.com/users/greim/gists{/gist_id}","starred_url":"https://api.github.com/users/greim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greim/subscriptions","organizations_url":"https://api.github.com/users/greim/orgs","repos_url":"https://api.github.com/users/greim/repos","events_url":"https://api.github.com/users/greim/events{/privacy}","received_events_url":"https://api.github.com/users/greim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-06T19:13:09Z","updated_at":"2015-04-23T16:54:59Z","closed_at":null,"body":"As far as I can tell, this module uses the redis client's constructor instead of the factory function, so some internal setup gets missed and things break.\r\n\r\nThe problem is reported and described in more depth here: https://github.com/mranney/node_redis/issues/735 ...but it definitely affects users of this module."},"comment":{"url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/comments/95652301","html_url":"https://github.com/ortoo/node-redis-sentinel/issues/37#issuecomment-95652301","issue_url":"https://api.github.com/repos/ortoo/node-redis-sentinel/issues/37","id":95652301,"user":{"login":"aphorise","id":974854,"avatar_url":"https://avatars.githubusercontent.com/u/974854?v=3","gravatar_id":"","url":"https://api.github.com/users/aphorise","html_url":"https://github.com/aphorise","followers_url":"https://api.github.com/users/aphorise/followers","following_url":"https://api.github.com/users/aphorise/following{/other_user}","gists_url":"https://api.github.com/users/aphorise/gists{/gist_id}","starred_url":"https://api.github.com/users/aphorise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphorise/subscriptions","organizations_url":"https://api.github.com/users/aphorise/orgs","repos_url":"https://api.github.com/users/aphorise/repos","events_url":"https://api.github.com/users/aphorise/events{/privacy}","received_events_url":"https://api.github.com/users/aphorise/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T16:54:59Z","updated_at":"2015-04-23T16:54:59Z","body":"I can also confirm that there are issues with this module crashing clients during reconnection / re-switch.\r\n\r\nI've done a mock to demo:\r\nhttps://github.com/aphorise/redis-sentinel-sim\r\n\r\nIn my case I get unrelated  ```toString()``` error on an ```undefined```\r\n\r\nAre there any patch or fix?"}}