{"action":"created","issue":{"url":"https://api.github.com/repos/couchbase/sync_gateway/issues/971","labels_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/971/labels{/name}","comments_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/971/comments","events_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/971/events","html_url":"https://github.com/couchbase/sync_gateway/pull/971","id":92909032,"number":971,"title":"Added the following header to simple, longpoll and continuous HTTP _changes response","user":{"login":"ajres","id":7745210,"avatar_url":"https://avatars.githubusercontent.com/u/7745210?v=3","gravatar_id":"","url":"https://api.github.com/users/ajres","html_url":"https://github.com/ajres","followers_url":"https://api.github.com/users/ajres/followers","following_url":"https://api.github.com/users/ajres/following{/other_user}","gists_url":"https://api.github.com/users/ajres/gists{/gist_id}","starred_url":"https://api.github.com/users/ajres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajres/subscriptions","organizations_url":"https://api.github.com/users/ajres/orgs","repos_url":"https://api.github.com/users/ajres/repos","events_url":"https://api.github.com/users/ajres/events{/privacy}","received_events_url":"https://api.github.com/users/ajres/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/couchbase/sync_gateway/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-07-03T16:52:13Z","updated_at":"2015-07-31T16:49:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/couchbase/sync_gateway/pulls/971","html_url":"https://github.com/couchbase/sync_gateway/pull/971","diff_url":"https://github.com/couchbase/sync_gateway/pull/971.diff","patch_url":"https://github.com/couchbase/sync_gateway/pull/971.patch"},"body":"Added the following header to simple, longpoll and continuous HTTP _changes response\r\n\r\nThis should prevent all _changes responses and heartbeats being cached by intermediate proxies.\r\n\r\nFixes #945 \r\n\r\nh.setHeader(\"Cache-Control\", \"private, max-age=0, no-cache, no-store\")\r\n\r\nNot sure which testing strategy should be used for this, currently this is only covered by scenario testing, should we flag this for integration testing also?"},"comment":{"url":"https://api.github.com/repos/couchbase/sync_gateway/issues/comments/126750011","html_url":"https://github.com/couchbase/sync_gateway/pull/971#issuecomment-126750011","issue_url":"https://api.github.com/repos/couchbase/sync_gateway/issues/971","id":126750011,"user":{"login":"ajres","id":7745210,"avatar_url":"https://avatars.githubusercontent.com/u/7745210?v=3","gravatar_id":"","url":"https://api.github.com/users/ajres","html_url":"https://github.com/ajres","followers_url":"https://api.github.com/users/ajres/followers","following_url":"https://api.github.com/users/ajres/following{/other_user}","gists_url":"https://api.github.com/users/ajres/gists{/gist_id}","starred_url":"https://api.github.com/users/ajres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajres/subscriptions","organizations_url":"https://api.github.com/users/ajres/orgs","repos_url":"https://api.github.com/users/ajres/repos","events_url":"https://api.github.com/users/ajres/events{/privacy}","received_events_url":"https://api.github.com/users/ajres/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T16:49:34Z","updated_at":"2015-07-31T16:49:34Z","body":"Ran _changes load test in perfcluster, with nginx instance, configured with chunking,  in front of SG.\n\nObserved that when running SG build from master, _changes heartbeats were not propagated to test client.\n\nWhen running SG built from this feature branch, _changes heartbeats were propagated to the test client. This prevented the client sessions from timing out and new sessions being created."}}