{"action":"opened","issue":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/832","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/832/labels{/name}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/832/comments","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/832/events","html_url":"https://github.com/simplabs/ember-simple-auth/issues/832","id":124279469,"number":832,"title":"Ember-CLI test runner fails with simple-auth and browserify","user":{"login":"mmelvin0","id":762247,"avatar_url":"https://avatars.githubusercontent.com/u/762247?v=3","gravatar_id":"","url":"https://api.github.com/users/mmelvin0","html_url":"https://github.com/mmelvin0","followers_url":"https://api.github.com/users/mmelvin0/followers","following_url":"https://api.github.com/users/mmelvin0/following{/other_user}","gists_url":"https://api.github.com/users/mmelvin0/gists{/gist_id}","starred_url":"https://api.github.com/users/mmelvin0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmelvin0/subscriptions","organizations_url":"https://api.github.com/users/mmelvin0/orgs","repos_url":"https://api.github.com/users/mmelvin0/repos","events_url":"https://api.github.com/users/mmelvin0/events{/privacy}","received_events_url":"https://api.github.com/users/mmelvin0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-29T22:50:49Z","updated_at":"2015-12-29T22:50:49Z","closed_at":null,"body":"If I create a new app with Ember CLI 1.13.13 and add ember-browserify + ember-simple-auth, the test runner fails to load.\r\n\r\nI think this is because you have browserify.tests = true in your config/environment.js, but that shouldn't be the case for applications consuming browserify. Either adding browserify.tests = false to my application's config/environment.js or moving yours to tests/dummy/config/enviornment.js makes everything happy again.\r\n\r\nFrom my experimentation, this has to do with where browserify_stubs.js gets inserted into test-support.js when browserify.tests = true.\r\n\r\nAlso interesting to note if I downgrade ember-cli-qunit from ^1.0.4 (which currently evaluates to 1.1.0) to explicitly 1.0.4 the problem also goes away.\r\n\r\nHere's a simple Ember-CLI project demonstrating the issue: https://github.com/mmelvin0/simple-auth-browserify-test\r\n\r\nEven though I don't think it's the whole story, I don't think ember-simple-auth should be setting browserify.tests = true for every application that includes it, only for its own tests. I'll submit a pull request that changes that."}}