{"action":"created","comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/27885748","id":27885748,"diff_hunk":"@@ -112,19 +112,20 @@ CryptoDes3 crypto_des3_decrypt_init(const BYTE* key, const BYTE* ivec)\n \treturn des3;\n }\n \n-void crypto_des3_encrypt(CryptoDes3 des3, UINT32 length, const BYTE* in_data, BYTE* out_data)\n+BOOL crypto_des3_encrypt(CryptoDes3 des3, UINT32 length, const BYTE* in_data, BYTE* out_data)\n {\n \tint len;\n-\tEVP_EncryptUpdate(&des3->des3_ctx, out_data, &len, in_data, length);\n+\treturn EVP_EncryptUpdate(&des3->des3_ctx, out_data, &len, in_data, length) == 1;\n }\n \n-void crypto_des3_decrypt(CryptoDes3 des3, UINT32 length, const BYTE* in_data, BYTE* out_data)\n+BOOL crypto_des3_decrypt(CryptoDes3 des3, UINT32 length, const BYTE* in_data, BYTE* out_data)\n {\n \tint len;\n-\tEVP_DecryptUpdate(&des3->des3_ctx, out_data, &len, in_data, length);\n+\tint ret = EVP_DecryptUpdate(&des3->des3_ctx, out_data, &len, in_data, length);\n \n \tif (length != len)\n \t\tabort(); /* TODO */","path":"libfreerdp/crypto/crypto.c","position":20,"original_position":20,"commit_id":"8685a8e0a2021b31e209f6495a7887d13ce7f530","original_commit_id":"8685a8e0a2021b31e209f6495a7887d13ce7f530","user":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"body":"@nfedera this is definitely an unexpected result, that means some kind of corruption has occured.","created_at":"2015-04-07T15:00:09Z","updated_at":"2015-04-07T15:00:09Z","html_url":"https://github.com/FreeRDP/FreeRDP/pull/2513#discussion_r27885748","pull_request_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513","_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments/27885748"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2513#discussion_r27885748"},"pull_request":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513"}}},"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513","id":32403455,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/2513","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/2513.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/2513.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2513","number":2513,"state":"open","locked":false,"title":"License and security ret values","user":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"body":"A PR that checks return values in core/[license.c|security.c]","created_at":"2015-04-01T09:45:47Z","updated_at":"2015-04-07T15:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0a37ff8468aab84342485eab539ea18d1671cb9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2513/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/8685a8e0a2021b31e209f6495a7887d13ce7f530","head":{"label":"hardening:license_and_security_retValues","ref":"license_and_security_retValues","sha":"8685a8e0a2021b31e209f6495a7887d13ce7f530","user":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"repo":{"id":7547140,"name":"FreeRDP","full_name":"hardening/FreeRDP","owner":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hardening/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":true,"url":"https://api.github.com/repos/hardening/FreeRDP","forks_url":"https://api.github.com/repos/hardening/FreeRDP/forks","keys_url":"https://api.github.com/repos/hardening/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hardening/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hardening/FreeRDP/teams","hooks_url":"https://api.github.com/repos/hardening/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/hardening/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/hardening/FreeRDP/events","assignees_url":"https://api.github.com/repos/hardening/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/hardening/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/hardening/FreeRDP/tags","blobs_url":"https://api.github.com/repos/hardening/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hardening/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hardening/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/hardening/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hardening/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/hardening/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/hardening/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/hardening/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/hardening/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/hardening/FreeRDP/subscription","commits_url":"https://api.github.com/repos/hardening/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/hardening/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/hardening/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/hardening/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/hardening/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/hardening/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hardening/FreeRDP/merges","archive_url":"https://api.github.com/repos/hardening/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hardening/FreeRDP/downloads","issues_url":"https://api.github.com/repos/hardening/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/hardening/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/hardening/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/hardening/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hardening/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/hardening/FreeRDP/releases{/id}","created_at":"2013-01-10T19:30:13Z","updated_at":"2014-06-20T19:56:09Z","pushed_at":"2015-04-07T13:20:35Z","git_url":"git://github.com/hardening/FreeRDP.git","ssh_url":"git@github.com:hardening/FreeRDP.git","clone_url":"https://github.com/hardening/FreeRDP.git","svn_url":"https://github.com/hardening/FreeRDP","homepage":"http://www.freerdp.com/","size":28058,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"121ea2359550388b34bc36047eb404f90e504737","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars.githubusercontent.com/u/663376?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol client","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","created_at":"2011-06-30T19:14:15Z","updated_at":"2015-04-07T08:51:32Z","pushed_at":"2015-04-07T13:20:36Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":118374,"stargazers_count":916,"watchers_count":916,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"open_issues_count":541,"forks":586,"open_issues":541,"watchers":916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/2513"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2513"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2513/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/2513/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/8685a8e0a2021b31e209f6495a7887d13ce7f530"}}}}