{"action":"opened","number":2676,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676","id":53471311,"html_url":"https://github.com/ansible/ansible-modules-core/pull/2676","diff_url":"https://github.com/ansible/ansible-modules-core/pull/2676.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/2676.patch","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2676","number":2676,"state":"open","locked":false,"title":"make the system module call daemon-reload on systemctl control","user":{"login":"oaken-source","id":5459661,"avatar_url":"https://avatars.githubusercontent.com/u/5459661?v=3","gravatar_id":"","url":"https://api.github.com/users/oaken-source","html_url":"https://github.com/oaken-source","followers_url":"https://api.github.com/users/oaken-source/followers","following_url":"https://api.github.com/users/oaken-source/following{/other_user}","gists_url":"https://api.github.com/users/oaken-source/gists{/gist_id}","starred_url":"https://api.github.com/users/oaken-source/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaken-source/subscriptions","organizations_url":"https://api.github.com/users/oaken-source/orgs","repos_url":"https://api.github.com/users/oaken-source/repos","events_url":"https://api.github.com/users/oaken-source/events{/privacy}","received_events_url":"https://api.github.com/users/oaken-source/received_events","type":"User","site_admin":false},"body":"I would like to propose a change in the way the service module works on systemd based machines, like arch linux.\r\n\r\nWith systemd, when you change a service file on disk, systemctl will not pick up the new file, until you restart the machine or call `systemctl daemon-reload` explicitly. This can become a problem when you change e a service file significantly through ansible and then `service restart` the service, because the changes are not picked up and it could either fail, or worse, succeed with a warning the ansible user never sees and do something entirely unexpected.\r\n\r\nIMO, ansible should hide this complexity and call `systemctl daemon-reload` implicitly on control tasks. See the (very crude) attached patch.\r\n\r\nthis issue has been discussed in #191 and seems to have gained some support.","created_at":"2015-12-12T08:00:35Z","updated_at":"2015-12-12T08:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2676/comments","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/746da5b2d24ddaf17c577e1ede5a9ba6e12fb2b4","head":{"label":"oaken-source:devel","ref":"devel","sha":"746da5b2d24ddaf17c577e1ede5a9ba6e12fb2b4","user":{"login":"oaken-source","id":5459661,"avatar_url":"https://avatars.githubusercontent.com/u/5459661?v=3","gravatar_id":"","url":"https://api.github.com/users/oaken-source","html_url":"https://github.com/oaken-source","followers_url":"https://api.github.com/users/oaken-source/followers","following_url":"https://api.github.com/users/oaken-source/following{/other_user}","gists_url":"https://api.github.com/users/oaken-source/gists{/gist_id}","starred_url":"https://api.github.com/users/oaken-source/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaken-source/subscriptions","organizations_url":"https://api.github.com/users/oaken-source/orgs","repos_url":"https://api.github.com/users/oaken-source/repos","events_url":"https://api.github.com/users/oaken-source/events{/privacy}","received_events_url":"https://api.github.com/users/oaken-source/received_events","type":"User","site_admin":false},"repo":{"id":47868923,"name":"ansible-modules-core","full_name":"oaken-source/ansible-modules-core","owner":{"login":"oaken-source","id":5459661,"avatar_url":"https://avatars.githubusercontent.com/u/5459661?v=3","gravatar_id":"","url":"https://api.github.com/users/oaken-source","html_url":"https://github.com/oaken-source","followers_url":"https://api.github.com/users/oaken-source/followers","following_url":"https://api.github.com/users/oaken-source/following{/other_user}","gists_url":"https://api.github.com/users/oaken-source/gists{/gist_id}","starred_url":"https://api.github.com/users/oaken-source/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oaken-source/subscriptions","organizations_url":"https://api.github.com/users/oaken-source/orgs","repos_url":"https://api.github.com/users/oaken-source/repos","events_url":"https://api.github.com/users/oaken-source/events{/privacy}","received_events_url":"https://api.github.com/users/oaken-source/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oaken-source/ansible-modules-core","description":"Ansible modules - these modules ship with ansible","fork":true,"url":"https://api.github.com/repos/oaken-source/ansible-modules-core","forks_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/forks","keys_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/teams","hooks_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/hooks","issue_events_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/events","assignees_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/tags","blobs_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/languages","stargazers_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/stargazers","contributors_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/contributors","subscribers_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/subscribers","subscription_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/subscription","commits_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/merges","archive_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/downloads","issues_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/oaken-source/ansible-modules-core/releases{/id}","created_at":"2015-12-12T07:25:31Z","updated_at":"2015-12-12T07:25:33Z","pushed_at":"2015-12-12T07:45:10Z","git_url":"git://github.com/oaken-source/ansible-modules-core.git","ssh_url":"git@github.com:oaken-source/ansible-modules-core.git","clone_url":"https://github.com/oaken-source/ansible-modules-core.git","svn_url":"https://github.com/oaken-source/ansible-modules-core","homepage":"","size":8390,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"147668d9945c0f7031b1e09efbe48d4b8b78e0fb","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":24474126,"name":"ansible-modules-core","full_name":"ansible/ansible-modules-core","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible-modules-core","description":"Ansible modules - these modules ship with ansible","fork":false,"url":"https://api.github.com/repos/ansible/ansible-modules-core","forks_url":"https://api.github.com/repos/ansible/ansible-modules-core/forks","keys_url":"https://api.github.com/repos/ansible/ansible-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible-modules-core/teams","hooks_url":"https://api.github.com/repos/ansible/ansible-modules-core/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/events","assignees_url":"https://api.github.com/repos/ansible/ansible-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible-modules-core/tags","blobs_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible-modules-core/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible-modules-core/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible-modules-core/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible-modules-core/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible-modules-core/subscription","commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible-modules-core/merges","archive_url":"https://api.github.com/repos/ansible/ansible-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible-modules-core/downloads","issues_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible-modules-core/releases{/id}","created_at":"2014-09-25T20:28:25Z","updated_at":"2015-12-11T20:18:20Z","pushed_at":"2015-12-12T06:19:21Z","git_url":"git://github.com/ansible/ansible-modules-core.git","ssh_url":"git@github.com:ansible/ansible-modules-core.git","clone_url":"https://github.com/ansible/ansible-modules-core.git","svn_url":"https://github.com/ansible/ansible-modules-core","homepage":"","size":10431,"stargazers_count":505,"watchers_count":505,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1209,"mirror_url":null,"open_issues_count":839,"forks":1209,"open_issues":839,"watchers":505,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676"},"html":{"href":"https://github.com/ansible/ansible-modules-core/pull/2676"},"issue":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2676"},"comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2676/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2676/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible-modules-core/statuses/746da5b2d24ddaf17c577e1ede5a9ba6e12fb2b4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":0,"changed_files":1}}