{"action":"created","issue":{"url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/149","labels_url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/149/comments","events_url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/149/events","html_url":"https://github.com/Atmosphere/atmosphere-javascript/pull/149","id":57966738,"number":149,"title":"Use connectTimeout setting also for close requests","user":{"login":"ookke","id":237161,"avatar_url":"https://avatars.githubusercontent.com/u/237161?v=3","gravatar_id":"","url":"https://api.github.com/users/ookke","html_url":"https://github.com/ookke","followers_url":"https://api.github.com/users/ookke/followers","following_url":"https://api.github.com/users/ookke/following{/other_user}","gists_url":"https://api.github.com/users/ookke/gists{/gist_id}","starred_url":"https://api.github.com/users/ookke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ookke/subscriptions","organizations_url":"https://api.github.com/users/ookke/orgs","repos_url":"https://api.github.com/users/ookke/repos","events_url":"https://api.github.com/users/ookke/events{/privacy}","received_events_url":"https://api.github.com/users/ookke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-17T19:06:18Z","updated_at":"2015-02-17T19:07:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/pulls/149","html_url":"https://github.com/Atmosphere/atmosphere-javascript/pull/149","diff_url":"https://github.com/Atmosphere/atmosphere-javascript/pull/149.diff","patch_url":"https://github.com/Atmosphere/atmosphere-javascript/pull/149.patch"},"body":"Related to disconnect issue described in https://github.com/Atmosphere/atmosphere/issues/1863\r\n\r\nAvoids long-running synchronous XHR when an offline client tries to disconnect after it has already lost connection. Could also perhaps just use a hardcoded value for these close requests, in fact there even is a line at https://github.com/Atmosphere/atmosphere-javascript/blob/master/modules/javascript/src/main/webapp/javascript/atmosphere.js#L2529\r\nthat sets a 'timeout' property to 1000 for close requests that currently does nothing, perhaps 'connectTimeout' was intended?"},"comment":{"url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/comments/74729768","html_url":"https://github.com/Atmosphere/atmosphere-javascript/pull/149#issuecomment-74729768","issue_url":"https://api.github.com/repos/Atmosphere/atmosphere-javascript/issues/149","id":74729768,"user":{"login":"buildhive","id":1584733,"avatar_url":"https://avatars.githubusercontent.com/u/1584733?v=3","gravatar_id":"","url":"https://api.github.com/users/buildhive","html_url":"https://github.com/buildhive","followers_url":"https://api.github.com/users/buildhive/followers","following_url":"https://api.github.com/users/buildhive/following{/other_user}","gists_url":"https://api.github.com/users/buildhive/gists{/gist_id}","starred_url":"https://api.github.com/users/buildhive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildhive/subscriptions","organizations_url":"https://api.github.com/users/buildhive/orgs","repos_url":"https://api.github.com/users/buildhive/repos","events_url":"https://api.github.com/users/buildhive/events{/privacy}","received_events_url":"https://api.github.com/users/buildhive/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T19:07:21Z","updated_at":"2015-02-17T19:07:21Z","body":"[Atmosphere Framework » atmosphere-javascript #359](https://buildhive.cloudbees.com/job/Atmosphere/job/atmosphere-javascript/359/) SUCCESS\nThis pull request looks good\n[(what's this?)](https://www.cloudbees.com/what-is-buildhive)"}}