{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/1591","labels_url":"https://api.github.com/repos/php/php-src/issues/1591/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/1591/comments","events_url":"https://api.github.com/repos/php/php-src/issues/1591/events","html_url":"https://github.com/php/php-src/pull/1591","id":112802542,"number":1591,"title":"Fix #70769: Fix boolean conversion warnings","user":{"login":"c9s","id":50894,"avatar_url":"https://avatars.githubusercontent.com/u/50894?v=3","gravatar_id":"","url":"https://api.github.com/users/c9s","html_url":"https://github.com/c9s","followers_url":"https://api.github.com/users/c9s/followers","following_url":"https://api.github.com/users/c9s/following{/other_user}","gists_url":"https://api.github.com/users/c9s/gists{/gist_id}","starred_url":"https://api.github.com/users/c9s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c9s/subscriptions","organizations_url":"https://api.github.com/users/c9s/orgs","repos_url":"https://api.github.com/users/c9s/repos","events_url":"https://api.github.com/users/c9s/events{/privacy}","received_events_url":"https://api.github.com/users/c9s/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-22T13:23:46Z","updated_at":"2015-10-23T03:20:20Z","closed_at":"2015-10-23T03:20:20Z","pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1591","html_url":"https://github.com/php/php-src/pull/1591","diff_url":"https://github.com/php/php-src/pull/1591.diff","patch_url":"https://github.com/php/php-src/pull/1591.patch"},"body":"Summary:\r\n\r\nThere are conditions like:\r\n\r\n      if (&ce->function_table) {\r\n      }\r\n\r\nThe compiler complains and raises some warnings about boolean\r\nconversion:\r\n\r\n    warning: address of 'ce->constants_table' will always evaluate to\r\n    'true' [-Wpointer-bool-conversion]\r\n\r\nHowever ce->function_table is a HashTable member, referencing HashTable will always evaluate to true. This is confusing.\r\n\r\nSince the address of 'HashTable' will always evaluate to true. the\r\nconditions should be removed to avoid confusion. The scope is kept for local variables.\r\n\r\nPlatform:\r\n\r\n    OS X 10.11\r\n\r\nCompiler:\r\n\r\n    Apple LLVM version 7.0.0 (clang-700.0.72)\r\n    Target: x86_64-apple-darwin15.0.0\r\n    Thread model: posix"},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/150447114","html_url":"https://github.com/php/php-src/pull/1591#issuecomment-150447114","issue_url":"https://api.github.com/repos/php/php-src/issues/1591","id":150447114,"user":{"login":"laruence","id":382813,"avatar_url":"https://avatars.githubusercontent.com/u/382813?v=3","gravatar_id":"","url":"https://api.github.com/users/laruence","html_url":"https://github.com/laruence","followers_url":"https://api.github.com/users/laruence/followers","following_url":"https://api.github.com/users/laruence/following{/other_user}","gists_url":"https://api.github.com/users/laruence/gists{/gist_id}","starred_url":"https://api.github.com/users/laruence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laruence/subscriptions","organizations_url":"https://api.github.com/users/laruence/orgs","repos_url":"https://api.github.com/users/laruence/repos","events_url":"https://api.github.com/users/laruence/events{/privacy}","received_events_url":"https://api.github.com/users/laruence/received_events","type":"User","site_admin":false},"created_at":"2015-10-23T03:20:20Z","updated_at":"2015-10-23T03:20:20Z","body":"merged, thanks "}}