{"action":"created","comment":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/43006125","id":43006125,"diff_hunk":"@@ -83,14 +39,29 @@ def test_positive_create_basic(self, test_data):\n \n         \"\"\"\n         with Session(self.browser) as session:\n-            make_syncplan(\n-                session,\n-                org=self.organization.name,\n-                name=test_data['name'],\n-                description=test_data['desc'],\n-                sync_interval=test_data['interval'],\n-            )\n-            self.assertIsNotNone(self.syncplan.search(test_data['name']))\n+            for value in generate_strings_list():","path":"tests/foreman/ui/test_syncplan.py","position":106,"original_position":106,"commit_id":"974c30277dfdbbfd49707624b2f37cfa0228a3ec","original_commit_id":"974c30277dfdbbfd49707624b2f37cfa0228a3ec","user":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"body":"@oshtaier Note that previously name/desc/interval were being tested together in one single test case.  IMO this is not the best way.  Now I have split the tests into two - one testing name/desc and other testing the sync intervals.  So the coverage is not reduced.\r\n\r\nAlso I named the variable 'value' so I can reuse the same variable for both name and desc.","created_at":"2015-10-26T15:16:19Z","updated_at":"2015-10-26T15:16:19Z","html_url":"https://github.com/SatelliteQE/robottelo/pull/2937#discussion_r43006125","pull_request_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937","_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments/43006125"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/2937#discussion_r43006125"},"pull_request":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937"}}},"pull_request":{"url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937","id":48604321,"html_url":"https://github.com/SatelliteQE/robottelo/pull/2937","diff_url":"https://github.com/SatelliteQE/robottelo/pull/2937.diff","patch_url":"https://github.com/SatelliteQE/robottelo/pull/2937.patch","issue_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2937","number":2937,"state":"open","locked":false,"title":"ddt removal in ui sync plan tests","user":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"body":"Test results:\r\n```\r\n# nosetests tests/foreman/ui/test_syncplan.py\r\n\r\n----------------------------------------------------------------------\r\nRan 11 tests in 688.541s\r\n\r\nOK (skipped=1)\r\n```","created_at":"2015-10-23T16:59:31Z","updated_at":"2015-10-26T15:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95ccd718f758bf1f868ed99c3dd1d18dcd85f35f","assignee":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937/commits","review_comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937/comments","review_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2937/comments","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/974c30277dfdbbfd49707624b2f37cfa0228a3ec","head":{"label":"sthirugn:ddt_ui_syncplan","ref":"ddt_ui_syncplan","sha":"974c30277dfdbbfd49707624b2f37cfa0228a3ec","user":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"repo":{"id":13864436,"name":"robottelo","full_name":"sthirugn/robottelo","owner":{"login":"sthirugn","id":3309189,"avatar_url":"https://avatars.githubusercontent.com/u/3309189?v=3","gravatar_id":"","url":"https://api.github.com/users/sthirugn","html_url":"https://github.com/sthirugn","followers_url":"https://api.github.com/users/sthirugn/followers","following_url":"https://api.github.com/users/sthirugn/following{/other_user}","gists_url":"https://api.github.com/users/sthirugn/gists{/gist_id}","starred_url":"https://api.github.com/users/sthirugn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthirugn/subscriptions","organizations_url":"https://api.github.com/users/sthirugn/orgs","repos_url":"https://api.github.com/users/sthirugn/repos","events_url":"https://api.github.com/users/sthirugn/events{/privacy}","received_events_url":"https://api.github.com/users/sthirugn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sthirugn/robottelo","description":"An automation testing framework for the Katello project.","fork":true,"url":"https://api.github.com/repos/sthirugn/robottelo","forks_url":"https://api.github.com/repos/sthirugn/robottelo/forks","keys_url":"https://api.github.com/repos/sthirugn/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sthirugn/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sthirugn/robottelo/teams","hooks_url":"https://api.github.com/repos/sthirugn/robottelo/hooks","issue_events_url":"https://api.github.com/repos/sthirugn/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/sthirugn/robottelo/events","assignees_url":"https://api.github.com/repos/sthirugn/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/sthirugn/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/sthirugn/robottelo/tags","blobs_url":"https://api.github.com/repos/sthirugn/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sthirugn/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sthirugn/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sthirugn/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sthirugn/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/sthirugn/robottelo/languages","stargazers_url":"https://api.github.com/repos/sthirugn/robottelo/stargazers","contributors_url":"https://api.github.com/repos/sthirugn/robottelo/contributors","subscribers_url":"https://api.github.com/repos/sthirugn/robottelo/subscribers","subscription_url":"https://api.github.com/repos/sthirugn/robottelo/subscription","commits_url":"https://api.github.com/repos/sthirugn/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sthirugn/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sthirugn/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sthirugn/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sthirugn/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/sthirugn/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sthirugn/robottelo/merges","archive_url":"https://api.github.com/repos/sthirugn/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sthirugn/robottelo/downloads","issues_url":"https://api.github.com/repos/sthirugn/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/sthirugn/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/sthirugn/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/sthirugn/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sthirugn/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/sthirugn/robottelo/releases{/id}","created_at":"2013-10-25T15:26:34Z","updated_at":"2015-04-26T20:38:22Z","pushed_at":"2015-10-26T14:53:55Z","git_url":"git://github.com/sthirugn/robottelo.git","ssh_url":"git@github.com:sthirugn/robottelo.git","clone_url":"https://github.com/sthirugn/robottelo.git","svn_url":"https://github.com/sthirugn/robottelo","homepage":null,"size":10465,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SatelliteQE:master","ref":"master","sha":"e947268a41379c0e38140bb656e27b1386215721","user":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"repo":{"id":4000279,"name":"robottelo","full_name":"SatelliteQE/robottelo","owner":{"login":"SatelliteQE","id":8754276,"avatar_url":"https://avatars.githubusercontent.com/u/8754276?v=3","gravatar_id":"","url":"https://api.github.com/users/SatelliteQE","html_url":"https://github.com/SatelliteQE","followers_url":"https://api.github.com/users/SatelliteQE/followers","following_url":"https://api.github.com/users/SatelliteQE/following{/other_user}","gists_url":"https://api.github.com/users/SatelliteQE/gists{/gist_id}","starred_url":"https://api.github.com/users/SatelliteQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SatelliteQE/subscriptions","organizations_url":"https://api.github.com/users/SatelliteQE/orgs","repos_url":"https://api.github.com/users/SatelliteQE/repos","events_url":"https://api.github.com/users/SatelliteQE/events{/privacy}","received_events_url":"https://api.github.com/users/SatelliteQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SatelliteQE/robottelo","description":"Robottelo is a test suite which exercises The Foreman.","fork":false,"url":"https://api.github.com/repos/SatelliteQE/robottelo","forks_url":"https://api.github.com/repos/SatelliteQE/robottelo/forks","keys_url":"https://api.github.com/repos/SatelliteQE/robottelo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SatelliteQE/robottelo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SatelliteQE/robottelo/teams","hooks_url":"https://api.github.com/repos/SatelliteQE/robottelo/hooks","issue_events_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/events{/number}","events_url":"https://api.github.com/repos/SatelliteQE/robottelo/events","assignees_url":"https://api.github.com/repos/SatelliteQE/robottelo/assignees{/user}","branches_url":"https://api.github.com/repos/SatelliteQE/robottelo/branches{/branch}","tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/tags","blobs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/refs{/sha}","trees_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/{sha}","languages_url":"https://api.github.com/repos/SatelliteQE/robottelo/languages","stargazers_url":"https://api.github.com/repos/SatelliteQE/robottelo/stargazers","contributors_url":"https://api.github.com/repos/SatelliteQE/robottelo/contributors","subscribers_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscribers","subscription_url":"https://api.github.com/repos/SatelliteQE/robottelo/subscription","commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/commits{/sha}","git_commits_url":"https://api.github.com/repos/SatelliteQE/robottelo/git/commits{/sha}","comments_url":"https://api.github.com/repos/SatelliteQE/robottelo/comments{/number}","issue_comment_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues/comments{/number}","contents_url":"https://api.github.com/repos/SatelliteQE/robottelo/contents/{+path}","compare_url":"https://api.github.com/repos/SatelliteQE/robottelo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SatelliteQE/robottelo/merges","archive_url":"https://api.github.com/repos/SatelliteQE/robottelo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SatelliteQE/robottelo/downloads","issues_url":"https://api.github.com/repos/SatelliteQE/robottelo/issues{/number}","pulls_url":"https://api.github.com/repos/SatelliteQE/robottelo/pulls{/number}","milestones_url":"https://api.github.com/repos/SatelliteQE/robottelo/milestones{/number}","notifications_url":"https://api.github.com/repos/SatelliteQE/robottelo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SatelliteQE/robottelo/labels{/name}","releases_url":"https://api.github.com/repos/SatelliteQE/robottelo/releases{/id}","created_at":"2012-04-12T01:36:39Z","updated_at":"2015-08-04T16:49:37Z","pushed_at":"2015-10-26T14:53:55Z","git_url":"git://github.com/SatelliteQE/robottelo.git","ssh_url":"git@github.com:SatelliteQE/robottelo.git","clone_url":"https://github.com/SatelliteQE/robottelo.git","svn_url":"https://github.com/SatelliteQE/robottelo","homepage":"","size":20484,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":158,"forks":32,"open_issues":158,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937"},"html":{"href":"https://github.com/SatelliteQE/robottelo/pull/2937"},"issue":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2937"},"comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/issues/2937/comments"},"review_comments":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937/comments"},"review_comment":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/pulls/2937/commits"},"statuses":{"href":"https://api.github.com/repos/SatelliteQE/robottelo/statuses/974c30277dfdbbfd49707624b2f37cfa0228a3ec"}}}}