{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/38544429","id":38544429,"diff_hunk":"@@ -80,6 +82,32 @@\n       <scope>provided</scope>\n       <optional>true</optional><!-- no need to have this at runtime -->\n     </dependency>\n+    <!-- mark logging dependencies as provided by war -->\n+    <dependency>\n+      <groupId>org.slf4j</groupId>\n+      <artifactId>slf4j-api</artifactId>\n+      <version>${slf4jVersion}</version>\n+      <scope>provided</scope>","path":"plugins/pom.xml","position":18,"original_position":18,"commit_id":"ff36f58886ea4784125eb33e0e3c5c929706af61","original_commit_id":"ff36f58886ea4784125eb33e0e3c5c929706af61","user":{"login":"mfriedenhagen","id":125281,"avatar_url":"https://avatars.githubusercontent.com/u/125281?v=3","gravatar_id":"","url":"https://api.github.com/users/mfriedenhagen","html_url":"https://github.com/mfriedenhagen","followers_url":"https://api.github.com/users/mfriedenhagen/followers","following_url":"https://api.github.com/users/mfriedenhagen/following{/other_user}","gists_url":"https://api.github.com/users/mfriedenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/mfriedenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfriedenhagen/subscriptions","organizations_url":"https://api.github.com/users/mfriedenhagen/orgs","repos_url":"https://api.github.com/users/mfriedenhagen/repos","events_url":"https://api.github.com/users/mfriedenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/mfriedenhagen/received_events","type":"User","site_admin":false},"body":"I thought it would be a good idea to include this as a dependency, so people know, that they should use slf4j for their own logging purposes. As it is marked as provided, it will not be included in the HPI but is available during compile and test.","created_at":"2015-09-02T15:16:53Z","updated_at":"2015-09-02T15:16:53Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1816#discussion_r38544429","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/38544429"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1816#discussion_r38544429"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816","id":43924761,"html_url":"https://github.com/jenkinsci/jenkins/pull/1816","diff_url":"https://github.com/jenkinsci/jenkins/pull/1816.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1816.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1816","number":1816,"state":"open","locked":false,"title":"Use slf4j adapters for logging.","user":{"login":"mfriedenhagen","id":125281,"avatar_url":"https://avatars.githubusercontent.com/u/125281?v=3","gravatar_id":"","url":"https://api.github.com/users/mfriedenhagen","html_url":"https://github.com/mfriedenhagen","followers_url":"https://api.github.com/users/mfriedenhagen/followers","following_url":"https://api.github.com/users/mfriedenhagen/following{/other_user}","gists_url":"https://api.github.com/users/mfriedenhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/mfriedenhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfriedenhagen/subscriptions","organizations_url":"https://api.github.com/users/mfriedenhagen/orgs","repos_url":"https://api.github.com/users/mfriedenhagen/repos","events_url":"https://api.github.com/users/mfriedenhagen/events{/privacy}","received_events_url":"https://api.github.com/users/mfriedenhagen/received_events","type":"User","site_admin":false},"body":"- By introducing adapters for log4j and commons-logging and\r\n- including the original log4j and commons-logging dependencies as provided\r\nall logging should be redirected to slf4j and finally java.util.logging.\r\n\r\nThis is an enhancement to #1765","created_at":"2015-09-01T20:48:49Z","updated_at":"2015-09-02T15:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1d2c0783f9a59cc1beab192390e546c70a5efda","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1816/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/ff36f58886ea4784125eb33e0e3c5c929706af61","head":{"label":"1and1:fix-logging-dependencies-in-core","ref":"fix-logging-dependencies-in-core","sha":"ff36f58886ea4784125eb33e0e3c5c929706af61","user":{"login":"1and1","id":743115,"avatar_url":"https://avatars.githubusercontent.com/u/743115?v=3","gravatar_id":"","url":"https://api.github.com/users/1and1","html_url":"https://github.com/1and1","followers_url":"https://api.github.com/users/1and1/followers","following_url":"https://api.github.com/users/1and1/following{/other_user}","gists_url":"https://api.github.com/users/1and1/gists{/gist_id}","starred_url":"https://api.github.com/users/1and1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1and1/subscriptions","organizations_url":"https://api.github.com/users/1and1/orgs","repos_url":"https://api.github.com/users/1and1/repos","events_url":"https://api.github.com/users/1and1/events{/privacy}","received_events_url":"https://api.github.com/users/1and1/received_events","type":"Organization","site_admin":false},"repo":{"id":41663894,"name":"jenkins","full_name":"1and1/jenkins","owner":{"login":"1and1","id":743115,"avatar_url":"https://avatars.githubusercontent.com/u/743115?v=3","gravatar_id":"","url":"https://api.github.com/users/1and1","html_url":"https://github.com/1and1","followers_url":"https://api.github.com/users/1and1/followers","following_url":"https://api.github.com/users/1and1/following{/other_user}","gists_url":"https://api.github.com/users/1and1/gists{/gist_id}","starred_url":"https://api.github.com/users/1and1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1and1/subscriptions","organizations_url":"https://api.github.com/users/1and1/orgs","repos_url":"https://api.github.com/users/1and1/repos","events_url":"https://api.github.com/users/1and1/events{/privacy}","received_events_url":"https://api.github.com/users/1and1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/1and1/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/1and1/jenkins","forks_url":"https://api.github.com/repos/1and1/jenkins/forks","keys_url":"https://api.github.com/repos/1and1/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1and1/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1and1/jenkins/teams","hooks_url":"https://api.github.com/repos/1and1/jenkins/hooks","issue_events_url":"https://api.github.com/repos/1and1/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/1and1/jenkins/events","assignees_url":"https://api.github.com/repos/1and1/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/1and1/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/1and1/jenkins/tags","blobs_url":"https://api.github.com/repos/1and1/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1and1/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1and1/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/1and1/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1and1/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/1and1/jenkins/languages","stargazers_url":"https://api.github.com/repos/1and1/jenkins/stargazers","contributors_url":"https://api.github.com/repos/1and1/jenkins/contributors","subscribers_url":"https://api.github.com/repos/1and1/jenkins/subscribers","subscription_url":"https://api.github.com/repos/1and1/jenkins/subscription","commits_url":"https://api.github.com/repos/1and1/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/1and1/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/1and1/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/1and1/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/1and1/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/1and1/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1and1/jenkins/merges","archive_url":"https://api.github.com/repos/1and1/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1and1/jenkins/downloads","issues_url":"https://api.github.com/repos/1and1/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/1and1/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/1and1/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/1and1/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1and1/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/1and1/jenkins/releases{/id}","created_at":"2015-08-31T08:14:35Z","updated_at":"2015-08-31T08:14:58Z","pushed_at":"2015-09-02T06:48:10Z","git_url":"git://github.com/1and1/jenkins.git","ssh_url":"git@github.com:1and1/jenkins.git","clone_url":"https://github.com/1and1/jenkins.git","svn_url":"https://github.com/1and1/jenkins","homepage":"http://jenkins-ci.org/","size":88344,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"69a98484c8a879fef9532e68670e72f5d74267b7","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-09-02T09:13:02Z","pushed_at":"2015-09-02T10:24:12Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":450785,"stargazers_count":4465,"watchers_count":4465,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1989,"mirror_url":null,"open_issues_count":115,"forks":1989,"open_issues":115,"watchers":4465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1816"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1816"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/ff36f58886ea4784125eb33e0e3c5c929706af61"}}}}