{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Hosting/pulls/comments/27437096","id":27437096,"diff_hunk":"@@ -14,7 +14,10 @@ public Action<IApplicationBuilder> Configure(IApplicationBuilder app, Action<IAp\n             return builder =>\n             {\n                 app.UseMiddleware<RequestServicesContainerMiddleware>();\n-                next(builder);\n+                if (next != null)","path":"src/Microsoft.AspNet.Hosting/Internal/AutoRequestServicesStartupFilter.cs","position":5,"original_position":5,"commit_id":"6d7321154e9c15195f646aebac574c31c5f7973c","original_commit_id":"761295dec3697557ebd82593a748adc4f981b130","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars.githubusercontent.com/u/95136?v=3","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"next can be null?","created_at":"2015-03-30T22:13:30Z","updated_at":"2015-03-30T22:13:30Z","html_url":"https://github.com/aspnet/Hosting/pull/210#discussion_r27437096","pull_request_url":"https://api.github.com/repos/aspnet/Hosting/pulls/210","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/comments/27437096"},"html":{"href":"https://github.com/aspnet/Hosting/pull/210#discussion_r27437096"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Hosting/pulls/210","id":32056084,"html_url":"https://github.com/aspnet/Hosting/pull/210","diff_url":"https://github.com/aspnet/Hosting/pull/210.diff","patch_url":"https://github.com/aspnet/Hosting/pull/210.patch","issue_url":"https://api.github.com/repos/aspnet/Hosting/issues/210","number":210,"state":"open","locked":false,"title":"Hosting rework #3","user":{"login":"HaoK","id":6537861,"avatar_url":"https://avatars.githubusercontent.com/u/6537861?v=3","gravatar_id":"","url":"https://api.github.com/users/HaoK","html_url":"https://github.com/HaoK","followers_url":"https://api.github.com/users/HaoK/followers","following_url":"https://api.github.com/users/HaoK/following{/other_user}","gists_url":"https://api.github.com/users/HaoK/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoK/subscriptions","organizations_url":"https://api.github.com/users/HaoK/orgs","repos_url":"https://api.github.com/users/HaoK/repos","events_url":"https://api.github.com/users/HaoK/events{/privacy}","received_events_url":"https://api.github.com/users/HaoK/received_events","type":"User","site_admin":false},"body":"Incorporated @lodejard feedback:\r\n\r\nIntroduce static WebApplication which is the static helpers used to create hosting engines and factories\r\n- IHostingEngineFactory / IStartupLoader are the two hosting engine services which can be replaced\r\n- IHostingEngine/HostingEngine are the actual workers which (is the merged result of Engine/Context)\r\n- Nuked all of the wrapping service providers, made IHostingEnviroment get/set, and we now directly manipulate the instance.\r\n\r\ncc @davidfowl @lodejard ","created_at":"2015-03-26T20:17:22Z","updated_at":"2015-03-30T22:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23b8bd633f5acc7ed5e2f66c733f897b94b02bfa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Hosting/pulls/210/commits","review_comments_url":"https://api.github.com/repos/aspnet/Hosting/pulls/210/comments","review_comment_url":"https://api.github.com/repos/aspnet/Hosting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Hosting/issues/210/comments","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/6d7321154e9c15195f646aebac574c31c5f7973c","head":{"label":"aspnet:haok/3-20create","ref":"haok/3-20create","sha":"6d7321154e9c15195f646aebac574c31c5f7973c","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16630141,"name":"Hosting","full_name":"aspnet/Hosting","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Hosting","description":"Code for hosting and starting up an ASP.NET application.","fork":false,"url":"https://api.github.com/repos/aspnet/Hosting","forks_url":"https://api.github.com/repos/aspnet/Hosting/forks","keys_url":"https://api.github.com/repos/aspnet/Hosting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Hosting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Hosting/teams","hooks_url":"https://api.github.com/repos/aspnet/Hosting/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Hosting/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Hosting/events","assignees_url":"https://api.github.com/repos/aspnet/Hosting/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Hosting/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Hosting/tags","blobs_url":"https://api.github.com/repos/aspnet/Hosting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Hosting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Hosting/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Hosting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Hosting/languages","stargazers_url":"https://api.github.com/repos/aspnet/Hosting/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Hosting/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Hosting/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Hosting/subscription","commits_url":"https://api.github.com/repos/aspnet/Hosting/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Hosting/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Hosting/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Hosting/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Hosting/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Hosting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Hosting/merges","archive_url":"https://api.github.com/repos/aspnet/Hosting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Hosting/downloads","issues_url":"https://api.github.com/repos/aspnet/Hosting/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Hosting/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Hosting/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Hosting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Hosting/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Hosting/releases{/id}","created_at":"2014-02-07T22:58:12Z","updated_at":"2015-03-27T14:25:35Z","pushed_at":"2015-03-30T22:13:19Z","git_url":"git://github.com/aspnet/Hosting.git","ssh_url":"git@github.com:aspnet/Hosting.git","clone_url":"https://github.com/aspnet/Hosting.git","svn_url":"https://github.com/aspnet/Hosting","homepage":"","size":3368,"stargazers_count":92,"watchers_count":92,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":29,"forks":43,"open_issues":29,"watchers":92,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"78ba6f8a65dfa9bf0bdda7797ce0b8fd5a4176f0","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16630141,"name":"Hosting","full_name":"aspnet/Hosting","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Hosting","description":"Code for hosting and starting up an ASP.NET application.","fork":false,"url":"https://api.github.com/repos/aspnet/Hosting","forks_url":"https://api.github.com/repos/aspnet/Hosting/forks","keys_url":"https://api.github.com/repos/aspnet/Hosting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Hosting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Hosting/teams","hooks_url":"https://api.github.com/repos/aspnet/Hosting/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Hosting/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Hosting/events","assignees_url":"https://api.github.com/repos/aspnet/Hosting/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Hosting/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Hosting/tags","blobs_url":"https://api.github.com/repos/aspnet/Hosting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Hosting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Hosting/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Hosting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Hosting/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Hosting/languages","stargazers_url":"https://api.github.com/repos/aspnet/Hosting/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Hosting/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Hosting/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Hosting/subscription","commits_url":"https://api.github.com/repos/aspnet/Hosting/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Hosting/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Hosting/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Hosting/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Hosting/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Hosting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Hosting/merges","archive_url":"https://api.github.com/repos/aspnet/Hosting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Hosting/downloads","issues_url":"https://api.github.com/repos/aspnet/Hosting/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Hosting/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Hosting/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Hosting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Hosting/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Hosting/releases{/id}","created_at":"2014-02-07T22:58:12Z","updated_at":"2015-03-27T14:25:35Z","pushed_at":"2015-03-30T22:13:19Z","git_url":"git://github.com/aspnet/Hosting.git","ssh_url":"git@github.com:aspnet/Hosting.git","clone_url":"https://github.com/aspnet/Hosting.git","svn_url":"https://github.com/aspnet/Hosting","homepage":"","size":3368,"stargazers_count":92,"watchers_count":92,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":29,"forks":43,"open_issues":29,"watchers":92,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/210"},"html":{"href":"https://github.com/aspnet/Hosting/pull/210"},"issue":{"href":"https://api.github.com/repos/aspnet/Hosting/issues/210"},"comments":{"href":"https://api.github.com/repos/aspnet/Hosting/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Hosting/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Hosting/statuses/6d7321154e9c15195f646aebac574c31c5f7973c"}}}}