{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3040","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3040/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3040/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3040/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3040","id":115663350,"number":3040,"title":"storage/engine: benchmark MVCCComputeStats","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-11-07T12:42:10Z","updated_at":"2015-11-09T15:53:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3040","html_url":"https://github.com/cockroachdb/cockroach/pull/3040","diff_url":"https://github.com/cockroachdb/cockroach/pull/3040.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3040.patch"},"body":"```\r\nBenchmarkMVCCComputeStats1Version256Bytes     \t 1000000\t      1362 ns/op\t49265837.65 MB/s\r\nBenchmarkMVCCComputeStats10Versions256Bytes   \t 1000000\t      1436 ns/op\t46717366.40 MB/s\r\nBenchmarkMVCCComputeStats100Versions256Bytes  \t 1000000\t      1438 ns/op\t46666362.39 MB/s\r\nBenchmarkMVCCComputeStats1000Versions256Bytes \t 1000000\t      1420 ns/op\t47259039.12 MB/s\r\nBenchmarkMVCCComputeStats1Version1024Bytes    \t 1000000\t      1420 ns/op\t47243998.16 MB/s\r\nBenchmarkMVCCComputeStats10Versions1024Bytes  \t 1000000\t      1401 ns/op\t47872374.08 MB/s\r\nBenchmarkMVCCComputeStats100Versions1024Bytes \t 1000000\t      1449 ns/op\t46289748.37 MB/s\r\nBenchmarkMVCCComputeStats1000Versions1024Bytes\t 1000000\t      1426 ns/op\t47044731.69 MB/s\r\nBenchmarkMVCCComputeStats1Version2048Bytes    \t 1000000\t      1372 ns/op\t48882087.86 MB/s\r\nBenchmarkMVCCComputeStats10Versions2048Bytes  \t 1000000\t      1448 ns/op\t46344876.20 MB/s\r\nBenchmarkMVCCComputeStats100Versions2048Bytes \t 1000000\t      1456 ns/op\t46062404.90 MB/s\r\nBenchmarkMVCCComputeStats1000Versions2048Bytes\t 1000000\t      1426 ns/op\t47043569.49 MB/s\r\n```\r\n\r\nFixes #2963.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3040)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/155102738","html_url":"https://github.com/cockroachdb/cockroach/pull/3040#issuecomment-155102738","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3040","id":155102738,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T15:53:24Z","updated_at":"2015-11-09T15:53:24Z","body":"> Those MB/s numbers can't be correct.\r\nSomething weird with those benchmark numbers. 1400 ns/op is incredibly fast. I don't think the benchmark is doing what you think it is doing.\r\n\r\nYeah, agreed. Not sure what's up, though. I did verify that these RocksDB databases are ~64M on disk."}}