{"action":"created","issue":{"url":"https://api.github.com/repos/javalite/activejdbc/issues/409","labels_url":"https://api.github.com/repos/javalite/activejdbc/issues/409/labels{/name}","comments_url":"https://api.github.com/repos/javalite/activejdbc/issues/409/comments","events_url":"https://api.github.com/repos/javalite/activejdbc/issues/409/events","html_url":"https://github.com/javalite/activejdbc/issues/409","id":94990531,"number":409,"title":"Improve model flexiblility for inheritance","user":{"login":"vyemialyanchyk","id":642868,"avatar_url":"https://avatars.githubusercontent.com/u/642868?v=3","gravatar_id":"","url":"https://api.github.com/users/vyemialyanchyk","html_url":"https://github.com/vyemialyanchyk","followers_url":"https://api.github.com/users/vyemialyanchyk/followers","following_url":"https://api.github.com/users/vyemialyanchyk/following{/other_user}","gists_url":"https://api.github.com/users/vyemialyanchyk/gists{/gist_id}","starred_url":"https://api.github.com/users/vyemialyanchyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyemialyanchyk/subscriptions","organizations_url":"https://api.github.com/users/vyemialyanchyk/orgs","repos_url":"https://api.github.com/users/vyemialyanchyk/repos","events_url":"https://api.github.com/users/vyemialyanchyk/events{/privacy}","received_events_url":"https://api.github.com/users/vyemialyanchyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-07-14T16:55:40Z","updated_at":"2015-07-14T18:33:44Z","closed_at":null,"body":"Model has next private members:\r\n```java\r\nprivate Map<String, Object> attributes = new CaseInsensitiveMap<Object>();\r\nprivate final Set<String> dirtyAttributeNames = new CaseInsensitiveSet();\r\nprivate final Map<Class, Model> cachedParents = new HashMap<Class, Model>();\r\nprivate final Map<Class, List<Model>> cachedChildren = new HashMap<Class, List<Model>>();\r\n```\r\n\r\nHashMap is not a best choice for efficiency (in general CaseInsensitiveMap is the same HashMap). 'private' declaration here does not allow to select more effective structures. Is it possible to update Model so to get more flexible for extension? 'protected' or argument in constructor or setter would helps."},"comment":{"url":"https://api.github.com/repos/javalite/activejdbc/issues/comments/121334476","html_url":"https://github.com/javalite/activejdbc/issues/409#issuecomment-121334476","issue_url":"https://api.github.com/repos/javalite/activejdbc/issues/409","id":121334476,"user":{"login":"vyemialyanchyk","id":642868,"avatar_url":"https://avatars.githubusercontent.com/u/642868?v=3","gravatar_id":"","url":"https://api.github.com/users/vyemialyanchyk","html_url":"https://github.com/vyemialyanchyk","followers_url":"https://api.github.com/users/vyemialyanchyk/followers","following_url":"https://api.github.com/users/vyemialyanchyk/following{/other_user}","gists_url":"https://api.github.com/users/vyemialyanchyk/gists{/gist_id}","starred_url":"https://api.github.com/users/vyemialyanchyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyemialyanchyk/subscriptions","organizations_url":"https://api.github.com/users/vyemialyanchyk/orgs","repos_url":"https://api.github.com/users/vyemialyanchyk/repos","events_url":"https://api.github.com/users/vyemialyanchyk/events{/privacy}","received_events_url":"https://api.github.com/users/vyemialyanchyk/received_events","type":"User","site_admin":false},"created_at":"2015-07-14T18:33:44Z","updated_at":"2015-07-14T18:33:44Z","body":"Igor ))) I do not want to prove something, this is not discussion thing. for the cases when db connection is bottleneck HashMap and TreeMap and other structure use have no matter.\r\n\r\nI do not want to spend my time to prove efficience of data structure this is simple mathematics and expirience to use such structures.\r\n\r\nI just want to make activejdbc better and just suggest the things. You are project owner and you select what to accept and what do not.\r\n\r\nI know anyone is able to make suggestions, and help is always appreciated. I would like to help, but too much efforts requied to get code commit in trunk, so I prefere suggestions.\r\n\r\nOne code format (Oracle Java Code Conventions) all over the project would be initial step to encourage someone to commit.\r\n"}}