{"action":"created","comment":{"url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments/48523265","id":48523265,"diff_hunk":"@@ -399,12 +414,19 @@ private void GetEDSMSystems()\n                     DBUpdateEDDB(eddb);\n                 }\n \n-                string retstr = edsm.GetNewSystems(db);\n-                Invoke((MethodInvoker)delegate\n+                if (CanSkipSlowUpdates())\n                 {\n-                    TravelHistoryControl.LogText(retstr);\n-                });\n-\n+                    LogLine(\"Skipping loading updates (DEBUG option).\");\n+                    LogLine(\"  Need to turn this back on again? Look in the Settings tab.\");\n+                }\n+                else\n+                {\n+                    string retstr = edsm.GetNewSystems(db);\n+                    Invoke((MethodInvoker)delegate\n+                    {\n+                        TravelHistoryControl.LogText(retstr);\n+                    });","path":"EDDiscovery/EDDiscoveryForm.cs","position":86,"original_position":86,"commit_id":"071209a678dfa78b11e3ce845411c5d913a17014","original_commit_id":"071209a678dfa78b11e3ce845411c5d913a17014","user":{"login":"gregmalcolm","id":64433,"avatar_url":"https://avatars.githubusercontent.com/u/64433?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmalcolm","html_url":"https://github.com/gregmalcolm","followers_url":"https://api.github.com/users/gregmalcolm/followers","following_url":"https://api.github.com/users/gregmalcolm/following{/other_user}","gists_url":"https://api.github.com/users/gregmalcolm/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmalcolm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmalcolm/subscriptions","organizations_url":"https://api.github.com/users/gregmalcolm/orgs","repos_url":"https://api.github.com/users/gregmalcolm/repos","events_url":"https://api.github.com/users/gregmalcolm/events{/privacy}","received_events_url":"https://api.github.com/users/gregmalcolm/received_events","type":"User","site_admin":false},"body":"The \"diffs\" are a little hard to follow here, but its the `edsm.GetNewSystems(db)` part that getting optionally skipped over.","created_at":"2015-12-29T06:25:00Z","updated_at":"2015-12-29T06:25:00Z","html_url":"https://github.com/EDDiscovery/EDDiscovery/pull/37#discussion_r48523265","pull_request_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments/48523265"},"html":{"href":"https://github.com/EDDiscovery/EDDiscovery/pull/37#discussion_r48523265"},"pull_request":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37","id":54704593,"html_url":"https://github.com/EDDiscovery/EDDiscovery/pull/37","diff_url":"https://github.com/EDDiscovery/EDDiscovery/pull/37.diff","patch_url":"https://github.com/EDDiscovery/EDDiscovery/pull/37.patch","issue_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/37","number":37,"state":"open","locked":false,"title":"Allow devs to optionally skip over slow EDSM updates when in Develop build","user":{"login":"gregmalcolm","id":64433,"avatar_url":"https://avatars.githubusercontent.com/u/64433?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmalcolm","html_url":"https://github.com/gregmalcolm","followers_url":"https://api.github.com/users/gregmalcolm/followers","following_url":"https://api.github.com/users/gregmalcolm/following{/other_user}","gists_url":"https://api.github.com/users/gregmalcolm/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmalcolm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmalcolm/subscriptions","organizations_url":"https://api.github.com/users/gregmalcolm/orgs","repos_url":"https://api.github.com/users/gregmalcolm/repos","events_url":"https://api.github.com/users/gregmalcolm/events{/privacy}","received_events_url":"https://api.github.com/users/gregmalcolm/received_events","type":"User","site_admin":false},"body":"So, I was about to start hacking when I realized waiting on the full EDD Load process takes rather a long time. So... I've put together a proposed where in Debug build only a developer can flip a setting which allows them to skip over those pesky slow EDSM updates.\r\n\r\nIn my hubris I also made a number of minor tweaks while I was in the codes. I can go back and remove any you don't like:\r\n* Fixed a bug with \"Log EDSM requests\" checkbox not getting populated correctly on startup\r\n* Renamed `Form1_Load` event to `EDDiscoveryForm_Load`. I tweaked the setting to load through program.cs to enable this to work.\r\n* Renamed EDDConfig's `db` instance variable to `_db` to be match the code style of other instance variables.\r\n* Added a `LogLine` delegatation variant in EDD for when theres a single argument.","created_at":"2015-12-29T06:15:35Z","updated_at":"2015-12-29T06:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae6d6c90fc0cb3cd827af000d342371bd115c06c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37/commits","review_comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37/comments","review_comment_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/37/comments","statuses_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/071209a678dfa78b11e3ce845411c5d913a17014","head":{"label":"gregmalcolm:allow-devs-to-skip-over-update","ref":"allow-devs-to-skip-over-update","sha":"071209a678dfa78b11e3ce845411c5d913a17014","user":{"login":"gregmalcolm","id":64433,"avatar_url":"https://avatars.githubusercontent.com/u/64433?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmalcolm","html_url":"https://github.com/gregmalcolm","followers_url":"https://api.github.com/users/gregmalcolm/followers","following_url":"https://api.github.com/users/gregmalcolm/following{/other_user}","gists_url":"https://api.github.com/users/gregmalcolm/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmalcolm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmalcolm/subscriptions","organizations_url":"https://api.github.com/users/gregmalcolm/orgs","repos_url":"https://api.github.com/users/gregmalcolm/repos","events_url":"https://api.github.com/users/gregmalcolm/events{/privacy}","received_events_url":"https://api.github.com/users/gregmalcolm/received_events","type":"User","site_admin":false},"repo":{"id":48714240,"name":"EDDiscovery","full_name":"gregmalcolm/EDDiscovery","owner":{"login":"gregmalcolm","id":64433,"avatar_url":"https://avatars.githubusercontent.com/u/64433?v=3","gravatar_id":"","url":"https://api.github.com/users/gregmalcolm","html_url":"https://github.com/gregmalcolm","followers_url":"https://api.github.com/users/gregmalcolm/followers","following_url":"https://api.github.com/users/gregmalcolm/following{/other_user}","gists_url":"https://api.github.com/users/gregmalcolm/gists{/gist_id}","starred_url":"https://api.github.com/users/gregmalcolm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregmalcolm/subscriptions","organizations_url":"https://api.github.com/users/gregmalcolm/orgs","repos_url":"https://api.github.com/users/gregmalcolm/repos","events_url":"https://api.github.com/users/gregmalcolm/events{/privacy}","received_events_url":"https://api.github.com/users/gregmalcolm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregmalcolm/EDDiscovery","description":"Captains log and 3d star map for Elite Dangerous","fork":true,"url":"https://api.github.com/repos/gregmalcolm/EDDiscovery","forks_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/forks","keys_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/teams","hooks_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/hooks","issue_events_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/issues/events{/number}","events_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/events","assignees_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/assignees{/user}","branches_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/branches{/branch}","tags_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/tags","blobs_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/statuses/{sha}","languages_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/languages","stargazers_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/stargazers","contributors_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/contributors","subscribers_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/subscribers","subscription_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/subscription","commits_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/contents/{+path}","compare_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/merges","archive_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/downloads","issues_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/issues{/number}","pulls_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/pulls{/number}","milestones_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/milestones{/number}","notifications_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/labels{/name}","releases_url":"https://api.github.com/repos/gregmalcolm/EDDiscovery/releases{/id}","created_at":"2015-12-28T21:55:12Z","updated_at":"2015-12-28T21:55:14Z","pushed_at":"2015-12-29T06:05:13Z","git_url":"git://github.com/gregmalcolm/EDDiscovery.git","ssh_url":"git@github.com:gregmalcolm/EDDiscovery.git","clone_url":"https://github.com/gregmalcolm/EDDiscovery.git","svn_url":"https://github.com/gregmalcolm/EDDiscovery","homepage":null,"size":455496,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EDDiscovery:master","ref":"master","sha":"84d08972ce5c565565bb996defc07bf8c07bc450","user":{"login":"EDDiscovery","id":12028419,"avatar_url":"https://avatars.githubusercontent.com/u/12028419?v=3","gravatar_id":"","url":"https://api.github.com/users/EDDiscovery","html_url":"https://github.com/EDDiscovery","followers_url":"https://api.github.com/users/EDDiscovery/followers","following_url":"https://api.github.com/users/EDDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/EDDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/EDDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDDiscovery/subscriptions","organizations_url":"https://api.github.com/users/EDDiscovery/orgs","repos_url":"https://api.github.com/users/EDDiscovery/repos","events_url":"https://api.github.com/users/EDDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/EDDiscovery/received_events","type":"Organization","site_admin":false},"repo":{"id":34243409,"name":"EDDiscovery","full_name":"EDDiscovery/EDDiscovery","owner":{"login":"EDDiscovery","id":12028419,"avatar_url":"https://avatars.githubusercontent.com/u/12028419?v=3","gravatar_id":"","url":"https://api.github.com/users/EDDiscovery","html_url":"https://github.com/EDDiscovery","followers_url":"https://api.github.com/users/EDDiscovery/followers","following_url":"https://api.github.com/users/EDDiscovery/following{/other_user}","gists_url":"https://api.github.com/users/EDDiscovery/gists{/gist_id}","starred_url":"https://api.github.com/users/EDDiscovery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EDDiscovery/subscriptions","organizations_url":"https://api.github.com/users/EDDiscovery/orgs","repos_url":"https://api.github.com/users/EDDiscovery/repos","events_url":"https://api.github.com/users/EDDiscovery/events{/privacy}","received_events_url":"https://api.github.com/users/EDDiscovery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EDDiscovery/EDDiscovery","description":"Captains log and 3d star map for Elite Dangerous","fork":false,"url":"https://api.github.com/repos/EDDiscovery/EDDiscovery","forks_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/forks","keys_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/teams","hooks_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/hooks","issue_events_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/events{/number}","events_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/events","assignees_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/assignees{/user}","branches_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/branches{/branch}","tags_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/tags","blobs_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/{sha}","languages_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/languages","stargazers_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/stargazers","contributors_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/contributors","subscribers_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/subscribers","subscription_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/subscription","commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/contents/{+path}","compare_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/merges","archive_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/downloads","issues_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues{/number}","pulls_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls{/number}","milestones_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/milestones{/number}","notifications_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/labels{/name}","releases_url":"https://api.github.com/repos/EDDiscovery/EDDiscovery/releases{/id}","created_at":"2015-04-20T06:55:44Z","updated_at":"2015-12-28T20:30:18Z","pushed_at":"2015-12-29T06:15:35Z","git_url":"git://github.com/EDDiscovery/EDDiscovery.git","ssh_url":"git@github.com:EDDiscovery/EDDiscovery.git","clone_url":"https://github.com/EDDiscovery/EDDiscovery.git","svn_url":"https://github.com/EDDiscovery/EDDiscovery","homepage":null,"size":455580,"stargazers_count":23,"watchers_count":23,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37"},"html":{"href":"https://github.com/EDDiscovery/EDDiscovery/pull/37"},"issue":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/37"},"comments":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/EDDiscovery/EDDiscovery/statuses/071209a678dfa78b11e3ce845411c5d913a17014"}}}}