{"action":"created","comment":{"url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/comments/23305931","id":23305931,"diff_hunk":"@@ -0,0 +1,27 @@\n+<?php\n+\n+\n+namespace aik099\\PHPUnit\\MinkDriver;\n+\n+\n+use aik099\\PHPUnit\\BrowserConfiguration\\BrowserConfiguration;\n+use Behat\\Mink\\Driver\\GoutteDriver;\n+\n+class GoutteDriverFactory implements IMinkDriverFactory\n+{\n+\n+\t/**\n+\t * Return a new instance of the Goutte driver.\n+\t *\n+\t * @param BrowserConfiguration $browser The browser configuration.\n+\t *\n+\t * @return GoutteDriver\n+\t */\n+\tpublic function getInstance(BrowserConfiguration $browser)\n+\t{\n+\t\t$client = new \\Goutte\\Client();","path":"library/aik099/PHPUnit/MinkDriver/GoutteDriverFactory.php","position":null,"original_position":22,"commit_id":"7de3e8b667c48f874da81415bb2d60e535e53dd3","original_commit_id":"21910b17bee7aea01ccf315a284af88d80fb2b36","user":{"login":"Vinai","id":72463,"avatar_url":"https://avatars.githubusercontent.com/u/72463?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinai","html_url":"https://github.com/Vinai","followers_url":"https://api.github.com/users/Vinai/followers","following_url":"https://api.github.com/users/Vinai/following{/other_user}","gists_url":"https://api.github.com/users/Vinai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinai/subscriptions","organizations_url":"https://api.github.com/users/Vinai/orgs","repos_url":"https://api.github.com/users/Vinai/repos","events_url":"https://api.github.com/users/Vinai/events{/privacy}","received_events_url":"https://api.github.com/users/Vinai/received_events","type":"User","site_admin":false},"body":"I added the driver_options, but since I don't have any need to configure the driver, I don't want to implement the usecase. Someone who needs it can easily use the driver_options to implement it in a seperate PR.","created_at":"2015-01-21T15:22:30Z","updated_at":"2015-01-21T15:22:30Z","html_url":"https://github.com/minkphp/phpunit-mink/pull/30#discussion_r23305931","pull_request_url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/comments/23305931"},"html":{"href":"https://github.com/minkphp/phpunit-mink/pull/30#discussion_r23305931"},"pull_request":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30","id":27557317,"html_url":"https://github.com/minkphp/phpunit-mink/pull/30","diff_url":"https://github.com/minkphp/phpunit-mink/pull/30.diff","patch_url":"https://github.com/minkphp/phpunit-mink/pull/30.patch","issue_url":"https://api.github.com/repos/minkphp/phpunit-mink/issues/30","number":30,"state":"open","locked":false,"title":"Allow to specify mink driver in browser configuration","user":{"login":"Vinai","id":72463,"avatar_url":"https://avatars.githubusercontent.com/u/72463?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinai","html_url":"https://github.com/Vinai","followers_url":"https://api.github.com/users/Vinai/followers","following_url":"https://api.github.com/users/Vinai/following{/other_user}","gists_url":"https://api.github.com/users/Vinai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinai/subscriptions","organizations_url":"https://api.github.com/users/Vinai/orgs","repos_url":"https://api.github.com/users/Vinai/repos","events_url":"https://api.github.com/users/Vinai/events{/privacy}","received_events_url":"https://api.github.com/users/Vinai/received_events","type":"User","site_admin":false},"body":"* Add option to specify the mink driver as part of the browser configuration.\r\n* For backward compatibility defaults to Selenium2Driver.\r\n* Add Goutte and SahiDriver support.\r\n* Allows to register additional mink drivers.\r\n\r\nFor example, to configure a test to run with the Goutte driver, use\r\n\r\n```php\r\n    public static $browsers = [[\r\n        'browserName' => 'Goutte',\r\n        'minkDriverClass' => 'Behat\\\\Mink\\\\Driver\\\\GoutteDriver'\r\n    ]];\r\n```\r\n\r\nCloses #12","created_at":"2015-01-17T14:24:34Z","updated_at":"2015-01-21T15:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cd01887d03750c811c584534d57b729a8241c93","assignee":null,"milestone":{"url":"https://api.github.com/repos/minkphp/phpunit-mink/milestones/2","labels_url":"https://api.github.com/repos/minkphp/phpunit-mink/milestones/2/labels","id":940528,"number":2,"title":"2.1.0","description":"","creator":{"login":"aik099","id":1277526,"avatar_url":"https://avatars.githubusercontent.com/u/1277526?v=3","gravatar_id":"","url":"https://api.github.com/users/aik099","html_url":"https://github.com/aik099","followers_url":"https://api.github.com/users/aik099/followers","following_url":"https://api.github.com/users/aik099/following{/other_user}","gists_url":"https://api.github.com/users/aik099/gists{/gist_id}","starred_url":"https://api.github.com/users/aik099/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aik099/subscriptions","organizations_url":"https://api.github.com/users/aik099/orgs","repos_url":"https://api.github.com/users/aik099/repos","events_url":"https://api.github.com/users/aik099/events{/privacy}","received_events_url":"https://api.github.com/users/aik099/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2015-01-18T12:57:42Z","updated_at":"2015-01-20T17:17:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30/commits","review_comments_url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30/comments","review_comment_url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/comments/{number}","comments_url":"https://api.github.com/repos/minkphp/phpunit-mink/issues/30/comments","statuses_url":"https://api.github.com/repos/minkphp/phpunit-mink/statuses/7de3e8b667c48f874da81415bb2d60e535e53dd3","head":{"label":"Vinai:more-mink-drivers","ref":"more-mink-drivers","sha":"7de3e8b667c48f874da81415bb2d60e535e53dd3","user":{"login":"Vinai","id":72463,"avatar_url":"https://avatars.githubusercontent.com/u/72463?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinai","html_url":"https://github.com/Vinai","followers_url":"https://api.github.com/users/Vinai/followers","following_url":"https://api.github.com/users/Vinai/following{/other_user}","gists_url":"https://api.github.com/users/Vinai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinai/subscriptions","organizations_url":"https://api.github.com/users/Vinai/orgs","repos_url":"https://api.github.com/users/Vinai/repos","events_url":"https://api.github.com/users/Vinai/events{/privacy}","received_events_url":"https://api.github.com/users/Vinai/received_events","type":"User","site_admin":false},"repo":{"id":29387268,"name":"phpunit-mink","full_name":"Vinai/phpunit-mink","owner":{"login":"Vinai","id":72463,"avatar_url":"https://avatars.githubusercontent.com/u/72463?v=3","gravatar_id":"","url":"https://api.github.com/users/Vinai","html_url":"https://github.com/Vinai","followers_url":"https://api.github.com/users/Vinai/followers","following_url":"https://api.github.com/users/Vinai/following{/other_user}","gists_url":"https://api.github.com/users/Vinai/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinai/subscriptions","organizations_url":"https://api.github.com/users/Vinai/orgs","repos_url":"https://api.github.com/users/Vinai/repos","events_url":"https://api.github.com/users/Vinai/events{/privacy}","received_events_url":"https://api.github.com/users/Vinai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vinai/phpunit-mink","description":"Library for using Mink in PHPUnit tests. Supports session sharing between tests in a test case.","fork":true,"url":"https://api.github.com/repos/Vinai/phpunit-mink","forks_url":"https://api.github.com/repos/Vinai/phpunit-mink/forks","keys_url":"https://api.github.com/repos/Vinai/phpunit-mink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vinai/phpunit-mink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vinai/phpunit-mink/teams","hooks_url":"https://api.github.com/repos/Vinai/phpunit-mink/hooks","issue_events_url":"https://api.github.com/repos/Vinai/phpunit-mink/issues/events{/number}","events_url":"https://api.github.com/repos/Vinai/phpunit-mink/events","assignees_url":"https://api.github.com/repos/Vinai/phpunit-mink/assignees{/user}","branches_url":"https://api.github.com/repos/Vinai/phpunit-mink/branches{/branch}","tags_url":"https://api.github.com/repos/Vinai/phpunit-mink/tags","blobs_url":"https://api.github.com/repos/Vinai/phpunit-mink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vinai/phpunit-mink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vinai/phpunit-mink/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vinai/phpunit-mink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vinai/phpunit-mink/statuses/{sha}","languages_url":"https://api.github.com/repos/Vinai/phpunit-mink/languages","stargazers_url":"https://api.github.com/repos/Vinai/phpunit-mink/stargazers","contributors_url":"https://api.github.com/repos/Vinai/phpunit-mink/contributors","subscribers_url":"https://api.github.com/repos/Vinai/phpunit-mink/subscribers","subscription_url":"https://api.github.com/repos/Vinai/phpunit-mink/subscription","commits_url":"https://api.github.com/repos/Vinai/phpunit-mink/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vinai/phpunit-mink/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vinai/phpunit-mink/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vinai/phpunit-mink/issues/comments/{number}","contents_url":"https://api.github.com/repos/Vinai/phpunit-mink/contents/{+path}","compare_url":"https://api.github.com/repos/Vinai/phpunit-mink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vinai/phpunit-mink/merges","archive_url":"https://api.github.com/repos/Vinai/phpunit-mink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vinai/phpunit-mink/downloads","issues_url":"https://api.github.com/repos/Vinai/phpunit-mink/issues{/number}","pulls_url":"https://api.github.com/repos/Vinai/phpunit-mink/pulls{/number}","milestones_url":"https://api.github.com/repos/Vinai/phpunit-mink/milestones{/number}","notifications_url":"https://api.github.com/repos/Vinai/phpunit-mink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vinai/phpunit-mink/labels{/name}","releases_url":"https://api.github.com/repos/Vinai/phpunit-mink/releases{/id}","created_at":"2015-01-17T10:08:00Z","updated_at":"2015-01-21T14:49:27Z","pushed_at":"2015-01-21T14:49:27Z","git_url":"git://github.com/Vinai/phpunit-mink.git","ssh_url":"git@github.com:Vinai/phpunit-mink.git","clone_url":"https://github.com/Vinai/phpunit-mink.git","svn_url":"https://github.com/Vinai/phpunit-mink","homepage":"","size":480,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minkphp:master","ref":"master","sha":"cc6b1735d3795a215ff62ef2b1d2dc158e3e3274","user":{"login":"minkphp","id":10380339,"avatar_url":"https://avatars.githubusercontent.com/u/10380339?v=3","gravatar_id":"","url":"https://api.github.com/users/minkphp","html_url":"https://github.com/minkphp","followers_url":"https://api.github.com/users/minkphp/followers","following_url":"https://api.github.com/users/minkphp/following{/other_user}","gists_url":"https://api.github.com/users/minkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/minkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minkphp/subscriptions","organizations_url":"https://api.github.com/users/minkphp/orgs","repos_url":"https://api.github.com/users/minkphp/repos","events_url":"https://api.github.com/users/minkphp/events{/privacy}","received_events_url":"https://api.github.com/users/minkphp/received_events","type":"Organization","site_admin":false},"repo":{"id":10422557,"name":"phpunit-mink","full_name":"minkphp/phpunit-mink","owner":{"login":"minkphp","id":10380339,"avatar_url":"https://avatars.githubusercontent.com/u/10380339?v=3","gravatar_id":"","url":"https://api.github.com/users/minkphp","html_url":"https://github.com/minkphp","followers_url":"https://api.github.com/users/minkphp/followers","following_url":"https://api.github.com/users/minkphp/following{/other_user}","gists_url":"https://api.github.com/users/minkphp/gists{/gist_id}","starred_url":"https://api.github.com/users/minkphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minkphp/subscriptions","organizations_url":"https://api.github.com/users/minkphp/orgs","repos_url":"https://api.github.com/users/minkphp/repos","events_url":"https://api.github.com/users/minkphp/events{/privacy}","received_events_url":"https://api.github.com/users/minkphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minkphp/phpunit-mink","description":"Library for using Mink in PHPUnit tests. Supports session sharing between tests in a test case.","fork":false,"url":"https://api.github.com/repos/minkphp/phpunit-mink","forks_url":"https://api.github.com/repos/minkphp/phpunit-mink/forks","keys_url":"https://api.github.com/repos/minkphp/phpunit-mink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minkphp/phpunit-mink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minkphp/phpunit-mink/teams","hooks_url":"https://api.github.com/repos/minkphp/phpunit-mink/hooks","issue_events_url":"https://api.github.com/repos/minkphp/phpunit-mink/issues/events{/number}","events_url":"https://api.github.com/repos/minkphp/phpunit-mink/events","assignees_url":"https://api.github.com/repos/minkphp/phpunit-mink/assignees{/user}","branches_url":"https://api.github.com/repos/minkphp/phpunit-mink/branches{/branch}","tags_url":"https://api.github.com/repos/minkphp/phpunit-mink/tags","blobs_url":"https://api.github.com/repos/minkphp/phpunit-mink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minkphp/phpunit-mink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minkphp/phpunit-mink/git/refs{/sha}","trees_url":"https://api.github.com/repos/minkphp/phpunit-mink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minkphp/phpunit-mink/statuses/{sha}","languages_url":"https://api.github.com/repos/minkphp/phpunit-mink/languages","stargazers_url":"https://api.github.com/repos/minkphp/phpunit-mink/stargazers","contributors_url":"https://api.github.com/repos/minkphp/phpunit-mink/contributors","subscribers_url":"https://api.github.com/repos/minkphp/phpunit-mink/subscribers","subscription_url":"https://api.github.com/repos/minkphp/phpunit-mink/subscription","commits_url":"https://api.github.com/repos/minkphp/phpunit-mink/commits{/sha}","git_commits_url":"https://api.github.com/repos/minkphp/phpunit-mink/git/commits{/sha}","comments_url":"https://api.github.com/repos/minkphp/phpunit-mink/comments{/number}","issue_comment_url":"https://api.github.com/repos/minkphp/phpunit-mink/issues/comments/{number}","contents_url":"https://api.github.com/repos/minkphp/phpunit-mink/contents/{+path}","compare_url":"https://api.github.com/repos/minkphp/phpunit-mink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minkphp/phpunit-mink/merges","archive_url":"https://api.github.com/repos/minkphp/phpunit-mink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minkphp/phpunit-mink/downloads","issues_url":"https://api.github.com/repos/minkphp/phpunit-mink/issues{/number}","pulls_url":"https://api.github.com/repos/minkphp/phpunit-mink/pulls{/number}","milestones_url":"https://api.github.com/repos/minkphp/phpunit-mink/milestones{/number}","notifications_url":"https://api.github.com/repos/minkphp/phpunit-mink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minkphp/phpunit-mink/labels{/name}","releases_url":"https://api.github.com/repos/minkphp/phpunit-mink/releases{/id}","created_at":"2013-06-01T13:15:00Z","updated_at":"2015-01-20T08:01:44Z","pushed_at":"2015-01-20T08:01:42Z","git_url":"git://github.com/minkphp/phpunit-mink.git","ssh_url":"git@github.com:minkphp/phpunit-mink.git","clone_url":"https://github.com/minkphp/phpunit-mink.git","svn_url":"https://github.com/minkphp/phpunit-mink","homepage":"","size":1037,"stargazers_count":21,"watchers_count":21,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":15,"forks":5,"open_issues":15,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30"},"html":{"href":"https://github.com/minkphp/phpunit-mink/pull/30"},"issue":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/issues/30"},"comments":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/minkphp/phpunit-mink/statuses/7de3e8b667c48f874da81415bb2d60e535e53dd3"}}}}