{"action":"created","issue":{"url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/7","labels_url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/7/comments","events_url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/7/events","html_url":"https://github.com/MilkBowl/VaultAPI/pull/7","id":53616612,"number":7,"title":"Update readme to have less bad practices","user":{"login":"AdamQpzm","id":2895565,"avatar_url":"https://avatars.githubusercontent.com/u/2895565?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamQpzm","html_url":"https://github.com/AdamQpzm","followers_url":"https://api.github.com/users/AdamQpzm/followers","following_url":"https://api.github.com/users/AdamQpzm/following{/other_user}","gists_url":"https://api.github.com/users/AdamQpzm/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamQpzm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamQpzm/subscriptions","organizations_url":"https://api.github.com/users/AdamQpzm/orgs","repos_url":"https://api.github.com/users/AdamQpzm/repos","events_url":"https://api.github.com/users/AdamQpzm/events{/privacy}","received_events_url":"https://api.github.com/users/AdamQpzm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-01-07T10:10:28Z","updated_at":"2015-01-21T20:16:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MilkBowl/VaultAPI/pulls/7","html_url":"https://github.com/MilkBowl/VaultAPI/pull/7","diff_url":"https://github.com/MilkBowl/VaultAPI/pull/7.diff","patch_url":"https://github.com/MilkBowl/VaultAPI/pull/7.patch"},"body":"As I'm sure you're aware (being the creators of it) Vault is a very useful thing. As such, beginners often end up using Vault for their plugins fairly early in their development careers. Unfortunately, the example plugin found in the readme file has a lot of bad practices, which new developers inevitably end up copying, thinking it's the right thing to do if Vault is suggesting it.\r\n\r\nFor a fair while now, I've been correcting these beginners on their bad practices when I see them ask for help with their plugins. This I've been doing for a while, but I've finally decided to attack the problem at its source. Hopefully by removing these bad practices that are oh so common right now, less people will end up using them and then everyone wins! :)\r\n\r\nQuick summary of changes are outlined in the commit message."},"comment":{"url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/comments/70913088","html_url":"https://github.com/MilkBowl/VaultAPI/pull/7#issuecomment-70913088","issue_url":"https://api.github.com/repos/MilkBowl/VaultAPI/issues/7","id":70913088,"user":{"login":"Albioncode","id":5012279,"avatar_url":"https://avatars.githubusercontent.com/u/5012279?v=3","gravatar_id":"","url":"https://api.github.com/users/Albioncode","html_url":"https://github.com/Albioncode","followers_url":"https://api.github.com/users/Albioncode/followers","following_url":"https://api.github.com/users/Albioncode/following{/other_user}","gists_url":"https://api.github.com/users/Albioncode/gists{/gist_id}","starred_url":"https://api.github.com/users/Albioncode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Albioncode/subscriptions","organizations_url":"https://api.github.com/users/Albioncode/orgs","repos_url":"https://api.github.com/users/Albioncode/repos","events_url":"https://api.github.com/users/Albioncode/events{/privacy}","received_events_url":"https://api.github.com/users/Albioncode/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T20:16:13Z","updated_at":"2015-01-21T20:16:13Z","body":"> IMHO explaining what a \"RegisteredServiceProvider\" is would be beneficial as well\r\n\r\nAlthough the name does seem obvious I feel as if understanding what they're tampering with may encourage \"junior\" developers or at the least make them feel less intimidated, nice shout @1Rogue "}}