{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/1214","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1214/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1214/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1214/events","html_url":"https://github.com/chapel-lang/chapel/pull/1214","id":56270194,"number":1214,"title":"Fixing over-sensitivity to output code format in testmunge.prediff","user":{"login":"bradcray","id":7536222,"avatar_url":"https://avatars.githubusercontent.com/u/7536222?v=3","gravatar_id":"","url":"https://api.github.com/users/bradcray","html_url":"https://github.com/bradcray","followers_url":"https://api.github.com/users/bradcray/followers","following_url":"https://api.github.com/users/bradcray/following{/other_user}","gists_url":"https://api.github.com/users/bradcray/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcray/subscriptions","organizations_url":"https://api.github.com/users/bradcray/orgs","repos_url":"https://api.github.com/users/bradcray/repos","events_url":"https://api.github.com/users/bradcray/events{/privacy}","received_events_url":"https://api.github.com/users/bradcray/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-02-02T17:59:32Z","updated_at":"2015-02-03T00:18:10Z","closed_at":"2015-02-02T18:10:06Z","pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/1214","html_url":"https://github.com/chapel-lang/chapel/pull/1214","diff_url":"https://github.com/chapel-lang/chapel/pull/1214.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/1214.patch"},"body":"My previous prediff script for this test was too specific to a given\r\nformat of generated code which caused it to break for --no-local and\r\ngasnet testing.  Here, I'm making the test more general.  Previously,\r\nfor a given variable 'x' I was checking for 'x ' and 'x_chpl ' in the\r\ngenerated code depending on whether the --munge-user-idents flag was\r\nset or not.  Now I'm just checking for the presence/absence of\r\n'x_chpl' in the code depending on the state of the flag which should\r\nbe much more robust."},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/72567455","html_url":"https://github.com/chapel-lang/chapel/pull/1214#issuecomment-72567455","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/1214","id":72567455,"user":{"login":"ronawho","id":1588337,"avatar_url":"https://avatars.githubusercontent.com/u/1588337?v=3","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"created_at":"2015-02-03T00:18:10Z","updated_at":"2015-02-03T00:18:10Z","body":"Yeah we save the llvm bitcode (I used bytecode by mistake earlier, though it doesn't really matter) with --savec. \r\n\r\nI built llvm over lunch to check if it would work. --savec only saves the .bc (bitcode / binary format) file so you can't grep for \"thisNameProbablyWontConflictWithOthers_chpl\". If we saved the .ll or if we ran llvm-dis on the .bc first you could do it, but it doesn't seem worthwhile to me."}}