{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/22829","labels_url":"https://api.github.com/repos/saltstack/salt/issues/22829/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/22829/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/22829/events","html_url":"https://github.com/saltstack/salt/pull/22829","id":69337084,"number":22829,"title":"Always return a boolean in gen_locale()","user":{"login":"F30","id":2017238,"avatar_url":"https://avatars.githubusercontent.com/u/2017238?v=3","gravatar_id":"","url":"https://api.github.com/users/F30","html_url":"https://github.com/F30","followers_url":"https://api.github.com/users/F30/followers","following_url":"https://api.github.com/users/F30/following{/other_user}","gists_url":"https://api.github.com/users/F30/gists{/gist_id}","starred_url":"https://api.github.com/users/F30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F30/subscriptions","organizations_url":"https://api.github.com/users/F30/orgs","repos_url":"https://api.github.com/users/F30/repos","events_url":"https://api.github.com/users/F30/events{/privacy}","received_events_url":"https://api.github.com/users/F30/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bugfix%20-%20[Done]%20back-ported","name":"Bugfix - [Done] back-ported","color":"5319e7"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Minor%20Change","name":"Minor Change","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-04-18T18:55:18Z","updated_at":"2015-04-22T01:13:35Z","closed_at":"2015-04-21T03:58:43Z","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/22829","html_url":"https://github.com/saltstack/salt/pull/22829","diff_url":"https://github.com/saltstack/salt/pull/22829.diff","patch_url":"https://github.com/saltstack/salt/pull/22829.patch"},"body":"`states.locale.present()` already expects a boolean return value, which is probably the cause of #21140.\r\nJudging from #2417, there is no consensus on what modules should return. So I decided to adjust the module rather than the state and make it conistent within itself (`set_locale()` returns a boolean as well) and with the behavior an error (`False` is returned).\r\n\r\nI'm not very familiar with your release process, but from my understanding this should also get backported."},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/94990693","html_url":"https://github.com/saltstack/salt/pull/22829#issuecomment-94990693","issue_url":"https://api.github.com/repos/saltstack/salt/issues/22829","id":94990693,"user":{"login":"rallytime","id":6547906,"avatar_url":"https://avatars.githubusercontent.com/u/6547906?v=3","gravatar_id":"","url":"https://api.github.com/users/rallytime","html_url":"https://github.com/rallytime","followers_url":"https://api.github.com/users/rallytime/followers","following_url":"https://api.github.com/users/rallytime/following{/other_user}","gists_url":"https://api.github.com/users/rallytime/gists{/gist_id}","starred_url":"https://api.github.com/users/rallytime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rallytime/subscriptions","organizations_url":"https://api.github.com/users/rallytime/orgs","repos_url":"https://api.github.com/users/rallytime/repos","events_url":"https://api.github.com/users/rallytime/events{/privacy}","received_events_url":"https://api.github.com/users/rallytime/received_events","type":"User","site_admin":false},"created_at":"2015-04-22T01:13:35Z","updated_at":"2015-04-22T01:13:35Z","body":"The code that this fix touches has been refactored since 2014.7. A separate fix will likely have to be made to that branch."}}