{"action":"created","issue":{"url":"https://api.github.com/repos/google/incremental-dom/issues/112","labels_url":"https://api.github.com/repos/google/incremental-dom/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/google/incremental-dom/issues/112/comments","events_url":"https://api.github.com/repos/google/incremental-dom/issues/112/events","html_url":"https://github.com/google/incremental-dom/pull/112","id":102190136,"number":112,"title":"Fixing jsdoc/closure compiler type annotations","user":{"login":"markuskobler","id":61794,"avatar_url":"https://avatars.githubusercontent.com/u/61794?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskobler","html_url":"https://github.com/markuskobler","followers_url":"https://api.github.com/users/markuskobler/followers","following_url":"https://api.github.com/users/markuskobler/following{/other_user}","gists_url":"https://api.github.com/users/markuskobler/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskobler/subscriptions","organizations_url":"https://api.github.com/users/markuskobler/orgs","repos_url":"https://api.github.com/users/markuskobler/repos","events_url":"https://api.github.com/users/markuskobler/events{/privacy}","received_events_url":"https://api.github.com/users/markuskobler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-20T17:34:14Z","updated_at":"2015-08-23T02:26:36Z","closed_at":"2015-08-22T14:59:43Z","pull_request":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/112","html_url":"https://github.com/google/incremental-dom/pull/112","diff_url":"https://github.com/google/incremental-dom/pull/112.diff","patch_url":"https://github.com/google/incremental-dom/pull/112.patch"},"body":"Fixes a number of compiler warnings when using Closure Compiler on ADVANCED."},"comment":{"url":"https://api.github.com/repos/google/incremental-dom/issues/comments/133772803","html_url":"https://github.com/google/incremental-dom/pull/112#issuecomment-133772803","issue_url":"https://api.github.com/repos/google/incremental-dom/issues/112","id":133772803,"user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"created_at":"2015-08-23T02:26:36Z","updated_at":"2015-08-23T02:26:36Z","body":"> They aren't for the linter.\r\n\r\nThe code runs fine without the typehints, they're only there so the closure \"compiler\" can statically lint the code.\r\n\r\n> For example, that the return value of alignWIthDOM will be a Text for the text even though the return type is Node...\r\n\r\nThat's a failure of trying to shoehorn a type system into a dynamically typed language. If we're gonna take it down this road, write the code so inline hints are unnecessary. As it stands now, we're writing [unreadable code](https://github.com/google/incremental-dom/pull/110#issuecomment-133523993) to appease a linter."}}