{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom-shell/pulls/comments/27272962","id":27272962,"diff_hunk":"@@ -164,7 +164,12 @@ void OpenExternal(const GURL& url) {\n   }\n }\n \n-void MoveItemToTrash(const base::FilePath& path) {\n+bool MoveItemToTrash(const base::FilePath& path) {\n+  // On XP SHFileOperation will return ERROR_ACCESS_DENIED instead of","path":"atom/common/platform_util_win.cc","position":null,"original_position":6,"commit_id":"f2734151f7497d45925565751f3338968cc24a5f","original_commit_id":"82975e1e2dc901c38038cc9d6161cd191afe715b","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"haha :)","created_at":"2015-03-27T02:38:01Z","updated_at":"2015-03-27T02:38:01Z","html_url":"https://github.com/atom/atom-shell/pull/1311#discussion_r27272962","pull_request_url":"https://api.github.com/repos/atom/atom-shell/pulls/1311","_links":{"self":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/comments/27272962"},"html":{"href":"https://github.com/atom/atom-shell/pull/1311#discussion_r27272962"},"pull_request":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/1311"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom-shell/pulls/1311","id":32014126,"html_url":"https://github.com/atom/atom-shell/pull/1311","diff_url":"https://github.com/atom/atom-shell/pull/1311.diff","patch_url":"https://github.com/atom/atom-shell/pull/1311.patch","issue_url":"https://api.github.com/repos/atom/atom-shell/issues/1311","number":1311,"state":"open","locked":false,"title":"shell: return status for moveitemtotrash operation on windows","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Fixes #1014 , but any reason not use `base::DeleteFile` instead for all platforms ? ","created_at":"2015-03-26T12:50:09Z","updated_at":"2015-03-27T02:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c472cfb139de9751571ebcc128c9c36d96eb9cf5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom-shell/pulls/1311/commits","review_comments_url":"https://api.github.com/repos/atom/atom-shell/pulls/1311/comments","review_comment_url":"https://api.github.com/repos/atom/atom-shell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom-shell/issues/1311/comments","statuses_url":"https://api.github.com/repos/atom/atom-shell/statuses/f2734151f7497d45925565751f3338968cc24a5f","head":{"label":"deepak1556:api_shell_patch","ref":"api_shell_patch","sha":"f2734151f7497d45925565751f3338968cc24a5f","user":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"repo":{"id":19500833,"name":"atom-shell","full_name":"deepak1556/atom-shell","owner":{"login":"deepak1556","id":964386,"avatar_url":"https://avatars.githubusercontent.com/u/964386?v=3","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepak1556/atom-shell","description":"Cross-platform desktop application shell","fork":true,"url":"https://api.github.com/repos/deepak1556/atom-shell","forks_url":"https://api.github.com/repos/deepak1556/atom-shell/forks","keys_url":"https://api.github.com/repos/deepak1556/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepak1556/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepak1556/atom-shell/teams","hooks_url":"https://api.github.com/repos/deepak1556/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/deepak1556/atom-shell/events","assignees_url":"https://api.github.com/repos/deepak1556/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/deepak1556/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/deepak1556/atom-shell/tags","blobs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepak1556/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepak1556/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepak1556/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepak1556/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/deepak1556/atom-shell/languages","stargazers_url":"https://api.github.com/repos/deepak1556/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/deepak1556/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/deepak1556/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/deepak1556/atom-shell/subscription","commits_url":"https://api.github.com/repos/deepak1556/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepak1556/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepak1556/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepak1556/atom-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepak1556/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/deepak1556/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepak1556/atom-shell/merges","archive_url":"https://api.github.com/repos/deepak1556/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepak1556/atom-shell/downloads","issues_url":"https://api.github.com/repos/deepak1556/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/deepak1556/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/deepak1556/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/deepak1556/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepak1556/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/deepak1556/atom-shell/releases{/id}","created_at":"2014-05-06T15:58:25Z","updated_at":"2015-03-10T06:12:17Z","pushed_at":"2015-03-27T02:37:30Z","git_url":"git://github.com/deepak1556/atom-shell.git","ssh_url":"git@github.com:deepak1556/atom-shell.git","clone_url":"https://github.com/deepak1556/atom-shell.git","svn_url":"https://github.com/deepak1556/atom-shell","homepage":"","size":5787,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"2cdfef286ad95a69bd1aafb5e6e4b0ec8ef436b0","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"atom-shell","full_name":"atom/atom-shell","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom-shell","description":"Cross-platform desktop application shell","fork":false,"url":"https://api.github.com/repos/atom/atom-shell","forks_url":"https://api.github.com/repos/atom/atom-shell/forks","keys_url":"https://api.github.com/repos/atom/atom-shell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom-shell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom-shell/teams","hooks_url":"https://api.github.com/repos/atom/atom-shell/hooks","issue_events_url":"https://api.github.com/repos/atom/atom-shell/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom-shell/events","assignees_url":"https://api.github.com/repos/atom/atom-shell/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom-shell/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom-shell/tags","blobs_url":"https://api.github.com/repos/atom/atom-shell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom-shell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom-shell/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom-shell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom-shell/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom-shell/languages","stargazers_url":"https://api.github.com/repos/atom/atom-shell/stargazers","contributors_url":"https://api.github.com/repos/atom/atom-shell/contributors","subscribers_url":"https://api.github.com/repos/atom/atom-shell/subscribers","subscription_url":"https://api.github.com/repos/atom/atom-shell/subscription","commits_url":"https://api.github.com/repos/atom/atom-shell/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom-shell/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom-shell/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom-shell/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom-shell/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom-shell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom-shell/merges","archive_url":"https://api.github.com/repos/atom/atom-shell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom-shell/downloads","issues_url":"https://api.github.com/repos/atom/atom-shell/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom-shell/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom-shell/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom-shell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom-shell/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom-shell/releases{/id}","created_at":"2013-04-12T01:47:36Z","updated_at":"2015-03-27T01:46:11Z","pushed_at":"2015-03-27T02:37:31Z","git_url":"git://github.com/atom/atom-shell.git","ssh_url":"git@github.com:atom/atom-shell.git","clone_url":"https://github.com/atom/atom-shell.git","svn_url":"https://github.com/atom/atom-shell","homepage":"","size":17099,"stargazers_count":6024,"watchers_count":6024,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":496,"mirror_url":null,"open_issues_count":133,"forks":496,"open_issues":133,"watchers":6024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/1311"},"html":{"href":"https://github.com/atom/atom-shell/pull/1311"},"issue":{"href":"https://api.github.com/repos/atom/atom-shell/issues/1311"},"comments":{"href":"https://api.github.com/repos/atom/atom-shell/issues/1311/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/1311/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom-shell/pulls/1311/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom-shell/statuses/f2734151f7497d45925565751f3338968cc24a5f"}}}}