{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/933","labels_url":"https://api.github.com/repos/ripple/rippled/issues/933/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/933/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/933/events","html_url":"https://github.com/ripple/rippled/pull/933","id":62221474,"number":933,"title":"Pathfinding unit tests:","user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Howard","name":"Howard","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Rebase","name":"Rebase","color":"eb6420"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Scott.S","name":"Scott.S","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Tom","name":"Tom","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-03-16T22:04:20Z","updated_at":"2015-03-17T23:17:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/933","html_url":"https://github.com/ripple/rippled/pull/933","diff_url":"https://github.com/ripple/rippled/pull/933.diff","patch_url":"https://github.com/ripple/rippled/pull/933.patch"},"body":"* Refactor ripple path find to be more testable.\r\n* Reimplements the first 4 tests from `tests\\path-test.js`\r\n* Verify balances in Ledger test.\r\n\r\nReviewers: @HowardHinnant, @scottschurr, @rec \r\n\r\nBy way of background, my intention with these changes was to make debugging my changes for RIPD-655 easier. In the process of developing and validating the test functions, I started reimplementing the tests from `tests/path-test.js`. Even though it's not done, with RIPD-655 on hold for now, I figure the utility functions may be useful for other path-related tests. There are no RIPD-655-related changes in this PR. (Unsquashed changes are in https://github.com/ximinez/rippled/tree/x-path-unit.)"},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/82636160","html_url":"https://github.com/ripple/rippled/pull/933#issuecomment-82636160","issue_url":"https://api.github.com/repos/ripple/rippled/issues/933","id":82636160,"user":{"login":"nbougalis","id":5085415,"avatar_url":"https://avatars.githubusercontent.com/u/5085415?v=3","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"created_at":"2015-03-17T23:17:55Z","updated_at":"2015-03-17T23:17:55Z","body":"@HowardHinnant: I'll verify the `package.json` file for this repom but chances are that switching between branches got npm confused with two different versions of `assert-diff`."}}