{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxpay/issues/102","labels_url":"https://api.github.com/repos/mozilla/fxpay/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxpay/issues/102/comments","events_url":"https://api.github.com/repos/mozilla/fxpay/issues/102/events","html_url":"https://github.com/mozilla/fxpay/pull/102","id":67204846,"number":102,"title":"Build optimized file and wrap in UMD","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-04-08T19:48:27Z","updated_at":"2015-04-08T19:59:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/fxpay/pulls/102","html_url":"https://github.com/mozilla/fxpay/pull/102","diff_url":"https://github.com/mozilla/fxpay/pull/102.diff","patch_url":"https://github.com/mozilla/fxpay/pull/102.patch"},"body":"This builds the optimized file with r.js which builds a roll-up of all the modules and uses a tiny require stand-in (almond.js) to provide the amd API internally.\r\n\r\nThis is then wrapped in some UMD fragments so the result should work in both AMD + common JS and as a global. \r\n\r\nI've used the example apps to check it works. I was thinking we could move them to using requirejs like the tests but this is more like the real usage. I did move them to using the debug builds however.\r\n\r\nWe'll need to test this. It should mean that fireplace can now consume this as an AMD module. Right now the module exposed is anonymous, if that's a problem we could give it an id."},"comment":{"url":"https://api.github.com/repos/mozilla/fxpay/issues/comments/91018807","html_url":"https://github.com/mozilla/fxpay/pull/102#issuecomment-91018807","issue_url":"https://api.github.com/repos/mozilla/fxpay/issues/102","id":91018807,"user":{"login":"kumar303","id":55398,"avatar_url":"https://avatars.githubusercontent.com/u/55398?v=3","gravatar_id":"","url":"https://api.github.com/users/kumar303","html_url":"https://github.com/kumar303","followers_url":"https://api.github.com/users/kumar303/followers","following_url":"https://api.github.com/users/kumar303/following{/other_user}","gists_url":"https://api.github.com/users/kumar303/gists{/gist_id}","starred_url":"https://api.github.com/users/kumar303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumar303/subscriptions","organizations_url":"https://api.github.com/users/kumar303/orgs","repos_url":"https://api.github.com/users/kumar303/repos","events_url":"https://api.github.com/users/kumar303/events{/privacy}","received_events_url":"https://api.github.com/users/kumar303/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T19:59:52Z","updated_at":"2015-04-08T19:59:52Z","body":"I only see the debug file. Is the compressed ``fxpay.min.js`` coming in another patch?"}}