{"action":"created","issue":{"url":"https://api.github.com/repos/guzzle/guzzle/issues/1035","labels_url":"https://api.github.com/repos/guzzle/guzzle/issues/1035/labels{/name}","comments_url":"https://api.github.com/repos/guzzle/guzzle/issues/1035/comments","events_url":"https://api.github.com/repos/guzzle/guzzle/issues/1035/events","html_url":"https://github.com/guzzle/guzzle/issues/1035","id":70438143,"number":1035,"title":"getTransaction is protected and should be public","user":{"login":"rdohms","id":94331,"avatar_url":"https://avatars.githubusercontent.com/u/94331?v=3","gravatar_id":"","url":"https://api.github.com/users/rdohms","html_url":"https://github.com/rdohms","followers_url":"https://api.github.com/users/rdohms/followers","following_url":"https://api.github.com/users/rdohms/following{/other_user}","gists_url":"https://api.github.com/users/rdohms/gists{/gist_id}","starred_url":"https://api.github.com/users/rdohms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdohms/subscriptions","organizations_url":"https://api.github.com/users/rdohms/orgs","repos_url":"https://api.github.com/users/rdohms/repos","events_url":"https://api.github.com/users/rdohms/events{/privacy}","received_events_url":"https://api.github.com/users/rdohms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-23T15:16:37Z","updated_at":"2015-04-23T15:56:24Z","closed_at":null,"body":"Looking here: https://github.com/guzzle/guzzle/blob/master/src/Event/AbstractRequestEvent.php#L57\r\n\r\n`getTransaction` is a protected getter, of a protected property, which seems to be a mistake.\r\n\r\nShould this be public? My use case is lower down in using the guzzle-services library, i want to throw a custom exception but in order to not have it be wrapped by a CommandException i need to extend from it. This means i need the transaction to be fed into the exception, which due to the getter above i cannot get from the ErrorEvent.\r\n\r\nAny ideas?"},"comment":{"url":"https://api.github.com/repos/guzzle/guzzle/issues/comments/95632457","html_url":"https://github.com/guzzle/guzzle/issues/1035#issuecomment-95632457","issue_url":"https://api.github.com/repos/guzzle/guzzle/issues/1035","id":95632457,"user":{"login":"mtdowling","id":190930,"avatar_url":"https://avatars.githubusercontent.com/u/190930?v=3","gravatar_id":"","url":"https://api.github.com/users/mtdowling","html_url":"https://github.com/mtdowling","followers_url":"https://api.github.com/users/mtdowling/followers","following_url":"https://api.github.com/users/mtdowling/following{/other_user}","gists_url":"https://api.github.com/users/mtdowling/gists{/gist_id}","starred_url":"https://api.github.com/users/mtdowling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtdowling/subscriptions","organizations_url":"https://api.github.com/users/mtdowling/orgs","repos_url":"https://api.github.com/users/mtdowling/repos","events_url":"https://api.github.com/users/mtdowling/events{/privacy}","received_events_url":"https://api.github.com/users/mtdowling/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T15:56:23Z","updated_at":"2015-04-23T15:56:23Z","body":"I would be fine with it being public. \n\nWe've been doing a lot of discovery work in the AWS PHP SDK, and found the event/exception system wrapping exceptions quite hard to work with. We will likely be implementing something similar from the SDK into Guzzle services. I think Jeremy will be the lead on it.\n\n> On Apr 23, 2015, at 8:16 AM, Rafael Dohms <notifications@github.com> wrote:\n> \n> Looking here: https://github.com/guzzle/guzzle/blob/master/src/Event/AbstractRequestEvent.php#L57\n> \n> getTransaction is a protected getter, of a protected property, which seems to be a mistake.\n> \n> Should this be public? My use case is lower down in using the guzzle-services library, i want to throw a custom exception but in order to not have it be wrapped by a CommandException i need to extend from it. This means i need the transaction to be fed into the exception, which due to the getter above i cannot get from the ErrorEvent.\n> \n> Any ideas?\n> \n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}