{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/35260678","id":35260678,"diff_hunk":"@@ -43,7 +42,9 @@ case class Project(projectList: Seq[NamedExpression], child: SparkPlan) extends\n \n   protected override def doExecute(): RDD[InternalRow] = child.execute().mapPartitions { iter =>\n     val reusableProjection = buildProjection()\n-    iter.map(reusableProjection)\n+    val result = iter.map(reusableProjection)\n+    accumulators(\"numTuples\").asInstanceOf[Accumulator[Long]] += result.length","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala","position":31,"original_position":31,"commit_id":"1849fe3fc9761cfd27ea479757a5beeb5286e58f","original_commit_id":"1849fe3fc9761cfd27ea479757a5beeb5286e58f","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"body":"Also, it is not safe to call multiple methods on the same one-shot iterator.","created_at":"2015-07-22T20:38:02Z","updated_at":"2015-07-22T20:38:02Z","html_url":"https://github.com/apache/spark/pull/7590#discussion_r35260678","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7590","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/35260678"},"html":{"href":"https://github.com/apache/spark/pull/7590#discussion_r35260678"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7590"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7590","id":40535864,"html_url":"https://github.com/apache/spark/pull/7590","diff_url":"https://github.com/apache/spark/pull/7590.diff","patch_url":"https://github.com/apache/spark/pull/7590.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7590","number":7590,"state":"open","locked":false,"title":"[SPARK-8861][SQL]Add accumulators to SparkPlan operations","user":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"body":"Prototype implementations of metrics accumulator update included in a `LeafNode` (`LocalTableScan`) and a `UnaryNode` (`basicOperators#Project`). Will extend to other `SparkPlan` ops after initial review.\r\n\r\nNotes for reviewers:\r\n * Accumulator updates are currently achieved by prematurely calling actions, which is undesirable. Perhaps it may be better to instrument everything *except* for `LeafNode`s?","created_at":"2015-07-22T07:04:41Z","updated_at":"2015-07-22T20:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfc8573d2cd07010959fbc9edc575e8dd10a6838","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7590/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7590/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7590/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/1849fe3fc9761cfd27ea479757a5beeb5286e58f","head":{"label":"feynmanliang:SPARK-8856-SparkPlan-instrumentation","ref":"SPARK-8856-SparkPlan-instrumentation","sha":"1849fe3fc9761cfd27ea479757a5beeb5286e58f","user":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"repo":{"id":31143142,"name":"spark","full_name":"feynmanliang/spark","owner":{"login":"feynmanliang","id":990069,"avatar_url":"https://avatars.githubusercontent.com/u/990069?v=3","gravatar_id":"","url":"https://api.github.com/users/feynmanliang","html_url":"https://github.com/feynmanliang","followers_url":"https://api.github.com/users/feynmanliang/followers","following_url":"https://api.github.com/users/feynmanliang/following{/other_user}","gists_url":"https://api.github.com/users/feynmanliang/gists{/gist_id}","starred_url":"https://api.github.com/users/feynmanliang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feynmanliang/subscriptions","organizations_url":"https://api.github.com/users/feynmanliang/orgs","repos_url":"https://api.github.com/users/feynmanliang/repos","events_url":"https://api.github.com/users/feynmanliang/events{/privacy}","received_events_url":"https://api.github.com/users/feynmanliang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feynmanliang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/feynmanliang/spark","forks_url":"https://api.github.com/repos/feynmanliang/spark/forks","keys_url":"https://api.github.com/repos/feynmanliang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feynmanliang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feynmanliang/spark/teams","hooks_url":"https://api.github.com/repos/feynmanliang/spark/hooks","issue_events_url":"https://api.github.com/repos/feynmanliang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/feynmanliang/spark/events","assignees_url":"https://api.github.com/repos/feynmanliang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/feynmanliang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/feynmanliang/spark/tags","blobs_url":"https://api.github.com/repos/feynmanliang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feynmanliang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feynmanliang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/feynmanliang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feynmanliang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/feynmanliang/spark/languages","stargazers_url":"https://api.github.com/repos/feynmanliang/spark/stargazers","contributors_url":"https://api.github.com/repos/feynmanliang/spark/contributors","subscribers_url":"https://api.github.com/repos/feynmanliang/spark/subscribers","subscription_url":"https://api.github.com/repos/feynmanliang/spark/subscription","commits_url":"https://api.github.com/repos/feynmanliang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/feynmanliang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/feynmanliang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/feynmanliang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/feynmanliang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/feynmanliang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feynmanliang/spark/merges","archive_url":"https://api.github.com/repos/feynmanliang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feynmanliang/spark/downloads","issues_url":"https://api.github.com/repos/feynmanliang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/feynmanliang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/feynmanliang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/feynmanliang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feynmanliang/spark/labels{/name}","releases_url":"https://api.github.com/repos/feynmanliang/spark/releases{/id}","created_at":"2015-02-21T22:13:57Z","updated_at":"2015-02-21T22:14:17Z","pushed_at":"2015-07-22T18:04:21Z","git_url":"git://github.com/feynmanliang/spark.git","ssh_url":"git@github.com:feynmanliang/spark.git","clone_url":"https://github.com/feynmanliang/spark.git","svn_url":"https://github.com/feynmanliang/spark","homepage":null,"size":111713,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c03299a18b4e076cabb4b7833a1e7632c5c0dabe","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-07-22T19:22:27Z","pushed_at":"2015-07-22T20:28:24Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1577258,"stargazers_count":4827,"watchers_count":4827,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4336,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":335,"forks":4336,"open_issues":335,"watchers":4827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7590"},"html":{"href":"https://github.com/apache/spark/pull/7590"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7590"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7590/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7590/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7590/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/1849fe3fc9761cfd27ea479757a5beeb5286e58f"}}}}