{"action":"created","comment":{"url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/comments/29291390","id":29291390,"diff_hunk":"@@ -361,6 +361,25 @@ namespace RobotLocalization\n   }\n \n   template<typename T>\n+  std::string RosFilter<T>::tf2NameSanitizer(const std::string & param )\n+  {\n+    if(!tfPrefix_.empty())\n+    { // tf prefix is set\n+      if(param.at(0)=='/')\n+        return tfPrefix_ + param;\n+      else\n+        return tfPrefix_+ \"/\" + param;\n+    }else\n+    {\n+       // remove leading slash\n+       if(param.at(0)=='/')\n+        return param.substr(1);","path":"src/ros_filter.cpp","position":16,"original_position":16,"commit_id":"2a18eac643298571d4239ffcc0c4443da43b945b","original_commit_id":"2a18eac643298571d4239ffcc0c4443da43b945b","user":{"login":"ayrton04","id":5042191,"avatar_url":"https://avatars.githubusercontent.com/u/5042191?v=3","gravatar_id":"","url":"https://api.github.com/users/ayrton04","html_url":"https://github.com/ayrton04","followers_url":"https://api.github.com/users/ayrton04/followers","following_url":"https://api.github.com/users/ayrton04/following{/other_user}","gists_url":"https://api.github.com/users/ayrton04/gists{/gist_id}","starred_url":"https://api.github.com/users/ayrton04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayrton04/subscriptions","organizations_url":"https://api.github.com/users/ayrton04/orgs","repos_url":"https://api.github.com/users/ayrton04/repos","events_url":"https://api.github.com/users/ayrton04/events{/privacy}","received_events_url":"https://api.github.com/users/ayrton04/received_events","type":"User","site_admin":false},"body":"Two spaces for indentation, please","created_at":"2015-04-28T21:37:05Z","updated_at":"2015-04-28T21:37:05Z","html_url":"https://github.com/cra-ros-pkg/robot_localization/pull/170#discussion_r29291390","pull_request_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/comments/29291390"},"html":{"href":"https://github.com/cra-ros-pkg/robot_localization/pull/170#discussion_r29291390"},"pull_request":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170","id":33310022,"html_url":"https://github.com/cra-ros-pkg/robot_localization/pull/170","diff_url":"https://github.com/cra-ros-pkg/robot_localization/pull/170.diff","patch_url":"https://github.com/cra-ros-pkg/robot_localization/pull/170.patch","issue_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/170","number":170,"state":"open","locked":false,"title":"TF_prefix resolving fix. Frame_id name change to tf2 version.","user":{"login":"Lukx19","id":8864148,"avatar_url":"https://avatars.githubusercontent.com/u/8864148?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukx19","html_url":"https://github.com/Lukx19","followers_url":"https://api.github.com/users/Lukx19/followers","following_url":"https://api.github.com/users/Lukx19/following{/other_user}","gists_url":"https://api.github.com/users/Lukx19/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukx19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukx19/subscriptions","organizations_url":"https://api.github.com/users/Lukx19/orgs","repos_url":"https://api.github.com/users/Lukx19/repos","events_url":"https://api.github.com/users/Lukx19/events{/privacy}","received_events_url":"https://api.github.com/users/Lukx19/received_events","type":"User","site_admin":false},"body":"Fix of tf_prefix resolving. Previous implementation have looked up tf_prefix only in namespace of robot_localization node.  When this package was used with launch files with hierarchical structure and tf_prefix was on higher level than localization node then resolving didn't work. This fix guaranties that resolving starts at private namespace of localization node and continue upwards in hierarchy of launch files until it reach tf_prefix definition if any.\r\n\r\nImplementation of tf2 name sanitation. Function strips leading slash if any and in case of tf-prefix defined adds this prefix based on norm of ROS for tf2. http://wiki.ros.org/tf2/Migration\r\n\r\ntested in ROS Indigo","created_at":"2015-04-14T23:28:00Z","updated_at":"2015-04-28T21:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbee1b977a9979af0a504fb5ba96531a50c8694c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170/commits","review_comments_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170/comments","review_comment_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/170/comments","statuses_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/statuses/2a18eac643298571d4239ffcc0c4443da43b945b","head":{"label":"Lukx19:indigo-devel","ref":"indigo-devel","sha":"2a18eac643298571d4239ffcc0c4443da43b945b","user":{"login":"Lukx19","id":8864148,"avatar_url":"https://avatars.githubusercontent.com/u/8864148?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukx19","html_url":"https://github.com/Lukx19","followers_url":"https://api.github.com/users/Lukx19/followers","following_url":"https://api.github.com/users/Lukx19/following{/other_user}","gists_url":"https://api.github.com/users/Lukx19/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukx19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukx19/subscriptions","organizations_url":"https://api.github.com/users/Lukx19/orgs","repos_url":"https://api.github.com/users/Lukx19/repos","events_url":"https://api.github.com/users/Lukx19/events{/privacy}","received_events_url":"https://api.github.com/users/Lukx19/received_events","type":"User","site_admin":false},"repo":{"id":33949488,"name":"robot_localization","full_name":"Lukx19/robot_localization","owner":{"login":"Lukx19","id":8864148,"avatar_url":"https://avatars.githubusercontent.com/u/8864148?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukx19","html_url":"https://github.com/Lukx19","followers_url":"https://api.github.com/users/Lukx19/followers","following_url":"https://api.github.com/users/Lukx19/following{/other_user}","gists_url":"https://api.github.com/users/Lukx19/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukx19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukx19/subscriptions","organizations_url":"https://api.github.com/users/Lukx19/orgs","repos_url":"https://api.github.com/users/Lukx19/repos","events_url":"https://api.github.com/users/Lukx19/events{/privacy}","received_events_url":"https://api.github.com/users/Lukx19/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukx19/robot_localization","description":"robot_localization is a package of nonlinear state estimation nodes. The package was developed by Charles River Analytics, Inc.","fork":true,"url":"https://api.github.com/repos/Lukx19/robot_localization","forks_url":"https://api.github.com/repos/Lukx19/robot_localization/forks","keys_url":"https://api.github.com/repos/Lukx19/robot_localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukx19/robot_localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukx19/robot_localization/teams","hooks_url":"https://api.github.com/repos/Lukx19/robot_localization/hooks","issue_events_url":"https://api.github.com/repos/Lukx19/robot_localization/issues/events{/number}","events_url":"https://api.github.com/repos/Lukx19/robot_localization/events","assignees_url":"https://api.github.com/repos/Lukx19/robot_localization/assignees{/user}","branches_url":"https://api.github.com/repos/Lukx19/robot_localization/branches{/branch}","tags_url":"https://api.github.com/repos/Lukx19/robot_localization/tags","blobs_url":"https://api.github.com/repos/Lukx19/robot_localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukx19/robot_localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukx19/robot_localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukx19/robot_localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukx19/robot_localization/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukx19/robot_localization/languages","stargazers_url":"https://api.github.com/repos/Lukx19/robot_localization/stargazers","contributors_url":"https://api.github.com/repos/Lukx19/robot_localization/contributors","subscribers_url":"https://api.github.com/repos/Lukx19/robot_localization/subscribers","subscription_url":"https://api.github.com/repos/Lukx19/robot_localization/subscription","commits_url":"https://api.github.com/repos/Lukx19/robot_localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukx19/robot_localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukx19/robot_localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukx19/robot_localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukx19/robot_localization/contents/{+path}","compare_url":"https://api.github.com/repos/Lukx19/robot_localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukx19/robot_localization/merges","archive_url":"https://api.github.com/repos/Lukx19/robot_localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukx19/robot_localization/downloads","issues_url":"https://api.github.com/repos/Lukx19/robot_localization/issues{/number}","pulls_url":"https://api.github.com/repos/Lukx19/robot_localization/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukx19/robot_localization/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukx19/robot_localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukx19/robot_localization/labels{/name}","releases_url":"https://api.github.com/repos/Lukx19/robot_localization/releases{/id}","created_at":"2015-04-14T18:29:55Z","updated_at":"2015-04-14T18:29:56Z","pushed_at":"2015-04-27T20:03:11Z","git_url":"git://github.com/Lukx19/robot_localization.git","ssh_url":"git@github.com:Lukx19/robot_localization.git","clone_url":"https://github.com/Lukx19/robot_localization.git","svn_url":"https://github.com/Lukx19/robot_localization","homepage":"www.cra.com","size":9059,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cra-ros-pkg:indigo-devel","ref":"indigo-devel","sha":"7385c44b35a50ff0ff524a20cecfed6b63dcd57a","user":{"login":"cra-ros-pkg","id":6164287,"avatar_url":"https://avatars.githubusercontent.com/u/6164287?v=3","gravatar_id":"","url":"https://api.github.com/users/cra-ros-pkg","html_url":"https://github.com/cra-ros-pkg","followers_url":"https://api.github.com/users/cra-ros-pkg/followers","following_url":"https://api.github.com/users/cra-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/cra-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/cra-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cra-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/cra-ros-pkg/orgs","repos_url":"https://api.github.com/users/cra-ros-pkg/repos","events_url":"https://api.github.com/users/cra-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/cra-ros-pkg/received_events","type":"Organization","site_admin":false},"repo":{"id":18298873,"name":"robot_localization","full_name":"cra-ros-pkg/robot_localization","owner":{"login":"cra-ros-pkg","id":6164287,"avatar_url":"https://avatars.githubusercontent.com/u/6164287?v=3","gravatar_id":"","url":"https://api.github.com/users/cra-ros-pkg","html_url":"https://github.com/cra-ros-pkg","followers_url":"https://api.github.com/users/cra-ros-pkg/followers","following_url":"https://api.github.com/users/cra-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/cra-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/cra-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cra-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/cra-ros-pkg/orgs","repos_url":"https://api.github.com/users/cra-ros-pkg/repos","events_url":"https://api.github.com/users/cra-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/cra-ros-pkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cra-ros-pkg/robot_localization","description":"robot_localization is a package of nonlinear state estimation nodes. The package was developed by Charles River Analytics, Inc.","fork":false,"url":"https://api.github.com/repos/cra-ros-pkg/robot_localization","forks_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/forks","keys_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/teams","hooks_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/hooks","issue_events_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/events{/number}","events_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/events","assignees_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/assignees{/user}","branches_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/branches{/branch}","tags_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/tags","blobs_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/git/refs{/sha}","trees_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/statuses/{sha}","languages_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/languages","stargazers_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/stargazers","contributors_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/contributors","subscribers_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/subscribers","subscription_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/subscription","commits_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/commits{/sha}","git_commits_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/git/commits{/sha}","comments_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/comments{/number}","issue_comment_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/comments{/number}","contents_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/contents/{+path}","compare_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/merges","archive_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/downloads","issues_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues{/number}","pulls_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls{/number}","milestones_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/milestones{/number}","notifications_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/labels{/name}","releases_url":"https://api.github.com/repos/cra-ros-pkg/robot_localization/releases{/id}","created_at":"2014-03-31T15:54:51Z","updated_at":"2015-04-28T21:17:29Z","pushed_at":"2015-04-28T21:21:39Z","git_url":"git://github.com/cra-ros-pkg/robot_localization.git","ssh_url":"git@github.com:cra-ros-pkg/robot_localization.git","clone_url":"https://github.com/cra-ros-pkg/robot_localization.git","svn_url":"https://github.com/cra-ros-pkg/robot_localization","homepage":"www.cra.com","size":11387,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":7,"forks":26,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170"},"html":{"href":"https://github.com/cra-ros-pkg/robot_localization/pull/170"},"issue":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/170"},"comments":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/cra-ros-pkg/robot_localization/statuses/2a18eac643298571d4239ffcc0c4443da43b945b"}}}}