{"action":"opened","number":258,"pull_request":{"url":"https://api.github.com/repos/nickg/nvc/pulls/258","id":47604215,"html_url":"https://github.com/nickg/nvc/pull/258","diff_url":"https://github.com/nickg/nvc/pull/258.diff","patch_url":"https://github.com/nickg/nvc/pull/258.patch","issue_url":"https://api.github.com/repos/nickg/nvc/issues/258","number":258,"state":"open","locked":false,"title":"clean up interned strings","user":{"login":"mitchsm","id":13935572,"avatar_url":"https://avatars.githubusercontent.com/u/13935572?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchsm","html_url":"https://github.com/mitchsm","followers_url":"https://api.github.com/users/mitchsm/followers","following_url":"https://api.github.com/users/mitchsm/following{/other_user}","gists_url":"https://api.github.com/users/mitchsm/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchsm/subscriptions","organizations_url":"https://api.github.com/users/mitchsm/orgs","repos_url":"https://api.github.com/users/mitchsm/repos","events_url":"https://api.github.com/users/mitchsm/events{/privacy}","received_events_url":"https://api.github.com/users/mitchsm/received_events","type":"User","site_admin":false},"body":"Somewhat random, but I noticed there were repeats in the interned strings (elide_bounds, builtin, and last_value). Also found a few places they weren't being used.\r\nI'm not 100% sure on the change I made to opt.c. I think it was necessary to change \"last_value\" to \"LAST_VALUE\" since it's an attribute. I think that identifier is serving two purposes now: the VHDL attribute name and the internal attribute identifier. Let me know if I got that wrong...","created_at":"2015-10-14T00:04:06Z","updated_at":"2015-10-14T00:04:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nickg/nvc/pulls/258/commits","review_comments_url":"https://api.github.com/repos/nickg/nvc/pulls/258/comments","review_comment_url":"https://api.github.com/repos/nickg/nvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nickg/nvc/issues/258/comments","statuses_url":"https://api.github.com/repos/nickg/nvc/statuses/bff1b519d355f416b3776e75158dd33b9902a1d8","head":{"label":"mitchsm:cleanup-interned-strings","ref":"cleanup-interned-strings","sha":"bff1b519d355f416b3776e75158dd33b9902a1d8","user":{"login":"mitchsm","id":13935572,"avatar_url":"https://avatars.githubusercontent.com/u/13935572?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchsm","html_url":"https://github.com/mitchsm","followers_url":"https://api.github.com/users/mitchsm/followers","following_url":"https://api.github.com/users/mitchsm/following{/other_user}","gists_url":"https://api.github.com/users/mitchsm/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchsm/subscriptions","organizations_url":"https://api.github.com/users/mitchsm/orgs","repos_url":"https://api.github.com/users/mitchsm/repos","events_url":"https://api.github.com/users/mitchsm/events{/privacy}","received_events_url":"https://api.github.com/users/mitchsm/received_events","type":"User","site_admin":false},"repo":{"id":41837754,"name":"nvc","full_name":"mitchsm/nvc","owner":{"login":"mitchsm","id":13935572,"avatar_url":"https://avatars.githubusercontent.com/u/13935572?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchsm","html_url":"https://github.com/mitchsm","followers_url":"https://api.github.com/users/mitchsm/followers","following_url":"https://api.github.com/users/mitchsm/following{/other_user}","gists_url":"https://api.github.com/users/mitchsm/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchsm/subscriptions","organizations_url":"https://api.github.com/users/mitchsm/orgs","repos_url":"https://api.github.com/users/mitchsm/repos","events_url":"https://api.github.com/users/mitchsm/events{/privacy}","received_events_url":"https://api.github.com/users/mitchsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchsm/nvc","description":"VHDL compiler and simulator","fork":true,"url":"https://api.github.com/repos/mitchsm/nvc","forks_url":"https://api.github.com/repos/mitchsm/nvc/forks","keys_url":"https://api.github.com/repos/mitchsm/nvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchsm/nvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchsm/nvc/teams","hooks_url":"https://api.github.com/repos/mitchsm/nvc/hooks","issue_events_url":"https://api.github.com/repos/mitchsm/nvc/issues/events{/number}","events_url":"https://api.github.com/repos/mitchsm/nvc/events","assignees_url":"https://api.github.com/repos/mitchsm/nvc/assignees{/user}","branches_url":"https://api.github.com/repos/mitchsm/nvc/branches{/branch}","tags_url":"https://api.github.com/repos/mitchsm/nvc/tags","blobs_url":"https://api.github.com/repos/mitchsm/nvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchsm/nvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchsm/nvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchsm/nvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchsm/nvc/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchsm/nvc/languages","stargazers_url":"https://api.github.com/repos/mitchsm/nvc/stargazers","contributors_url":"https://api.github.com/repos/mitchsm/nvc/contributors","subscribers_url":"https://api.github.com/repos/mitchsm/nvc/subscribers","subscription_url":"https://api.github.com/repos/mitchsm/nvc/subscription","commits_url":"https://api.github.com/repos/mitchsm/nvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchsm/nvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchsm/nvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchsm/nvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchsm/nvc/contents/{+path}","compare_url":"https://api.github.com/repos/mitchsm/nvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchsm/nvc/merges","archive_url":"https://api.github.com/repos/mitchsm/nvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchsm/nvc/downloads","issues_url":"https://api.github.com/repos/mitchsm/nvc/issues{/number}","pulls_url":"https://api.github.com/repos/mitchsm/nvc/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchsm/nvc/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchsm/nvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchsm/nvc/labels{/name}","releases_url":"https://api.github.com/repos/mitchsm/nvc/releases{/id}","created_at":"2015-09-03T02:12:10Z","updated_at":"2015-09-11T20:45:52Z","pushed_at":"2015-10-13T23:52:38Z","git_url":"git://github.com/mitchsm/nvc.git","ssh_url":"git@github.com:mitchsm/nvc.git","clone_url":"https://github.com/mitchsm/nvc.git","svn_url":"https://github.com/mitchsm/nvc","homepage":"http://www.doof.me.uk/category/vhdl/","size":9890,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nickg:master","ref":"master","sha":"82e23e6082e642203b1bf2ec589c2870cd04332b","user":{"login":"nickg","id":11442,"avatar_url":"https://avatars.githubusercontent.com/u/11442?v=3","gravatar_id":"","url":"https://api.github.com/users/nickg","html_url":"https://github.com/nickg","followers_url":"https://api.github.com/users/nickg/followers","following_url":"https://api.github.com/users/nickg/following{/other_user}","gists_url":"https://api.github.com/users/nickg/gists{/gist_id}","starred_url":"https://api.github.com/users/nickg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickg/subscriptions","organizations_url":"https://api.github.com/users/nickg/orgs","repos_url":"https://api.github.com/users/nickg/repos","events_url":"https://api.github.com/users/nickg/events{/privacy}","received_events_url":"https://api.github.com/users/nickg/received_events","type":"User","site_admin":false},"repo":{"id":2715244,"name":"nvc","full_name":"nickg/nvc","owner":{"login":"nickg","id":11442,"avatar_url":"https://avatars.githubusercontent.com/u/11442?v=3","gravatar_id":"","url":"https://api.github.com/users/nickg","html_url":"https://github.com/nickg","followers_url":"https://api.github.com/users/nickg/followers","following_url":"https://api.github.com/users/nickg/following{/other_user}","gists_url":"https://api.github.com/users/nickg/gists{/gist_id}","starred_url":"https://api.github.com/users/nickg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickg/subscriptions","organizations_url":"https://api.github.com/users/nickg/orgs","repos_url":"https://api.github.com/users/nickg/repos","events_url":"https://api.github.com/users/nickg/events{/privacy}","received_events_url":"https://api.github.com/users/nickg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nickg/nvc","description":"VHDL compiler and simulator","fork":false,"url":"https://api.github.com/repos/nickg/nvc","forks_url":"https://api.github.com/repos/nickg/nvc/forks","keys_url":"https://api.github.com/repos/nickg/nvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nickg/nvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nickg/nvc/teams","hooks_url":"https://api.github.com/repos/nickg/nvc/hooks","issue_events_url":"https://api.github.com/repos/nickg/nvc/issues/events{/number}","events_url":"https://api.github.com/repos/nickg/nvc/events","assignees_url":"https://api.github.com/repos/nickg/nvc/assignees{/user}","branches_url":"https://api.github.com/repos/nickg/nvc/branches{/branch}","tags_url":"https://api.github.com/repos/nickg/nvc/tags","blobs_url":"https://api.github.com/repos/nickg/nvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nickg/nvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nickg/nvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nickg/nvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nickg/nvc/statuses/{sha}","languages_url":"https://api.github.com/repos/nickg/nvc/languages","stargazers_url":"https://api.github.com/repos/nickg/nvc/stargazers","contributors_url":"https://api.github.com/repos/nickg/nvc/contributors","subscribers_url":"https://api.github.com/repos/nickg/nvc/subscribers","subscription_url":"https://api.github.com/repos/nickg/nvc/subscription","commits_url":"https://api.github.com/repos/nickg/nvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nickg/nvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nickg/nvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nickg/nvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nickg/nvc/contents/{+path}","compare_url":"https://api.github.com/repos/nickg/nvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nickg/nvc/merges","archive_url":"https://api.github.com/repos/nickg/nvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nickg/nvc/downloads","issues_url":"https://api.github.com/repos/nickg/nvc/issues{/number}","pulls_url":"https://api.github.com/repos/nickg/nvc/pulls{/number}","milestones_url":"https://api.github.com/repos/nickg/nvc/milestones{/number}","notifications_url":"https://api.github.com/repos/nickg/nvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nickg/nvc/labels{/name}","releases_url":"https://api.github.com/repos/nickg/nvc/releases{/id}","created_at":"2011-11-05T13:13:19Z","updated_at":"2015-10-02T18:27:59Z","pushed_at":"2015-10-14T00:04:06Z","git_url":"git://github.com/nickg/nvc.git","ssh_url":"git@github.com:nickg/nvc.git","clone_url":"https://github.com/nickg/nvc.git","svn_url":"https://github.com/nickg/nvc","homepage":"http://www.doof.me.uk/category/vhdl/","size":12697,"stargazers_count":74,"watchers_count":74,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":23,"forks":10,"open_issues":23,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nickg/nvc/pulls/258"},"html":{"href":"https://github.com/nickg/nvc/pull/258"},"issue":{"href":"https://api.github.com/repos/nickg/nvc/issues/258"},"comments":{"href":"https://api.github.com/repos/nickg/nvc/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/nickg/nvc/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/nickg/nvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nickg/nvc/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/nickg/nvc/statuses/bff1b519d355f416b3776e75158dd33b9902a1d8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":22,"changed_files":5}}