{"action":"created","comment":{"url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/comments/38548626","id":38548626,"diff_hunk":"@@ -151,7 +151,7 @@ def get_azs(region = '') { :'Fn::GetAZs' => region } end\n def join(delim, *list)\n   case list.length\n     when 0 then ''\n-    when 1 then list[0]\n+    when 1 then join_list(delim, list[0])","path":"lib/cloudformation-ruby-dsl/dsl.rb","position":5,"original_position":5,"commit_id":"983099c3fa5c6433ea1bfec19ca601d4f7fa5fd9","original_commit_id":"983099c3fa5c6433ea1bfec19ca601d4f7fa5fd9","user":{"login":"zmingxie","id":1136583,"avatar_url":"https://avatars.githubusercontent.com/u/1136583?v=3","gravatar_id":"","url":"https://api.github.com/users/zmingxie","html_url":"https://github.com/zmingxie","followers_url":"https://api.github.com/users/zmingxie/followers","following_url":"https://api.github.com/users/zmingxie/following{/other_user}","gists_url":"https://api.github.com/users/zmingxie/gists{/gist_id}","starred_url":"https://api.github.com/users/zmingxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmingxie/subscriptions","organizations_url":"https://api.github.com/users/zmingxie/orgs","repos_url":"https://api.github.com/users/zmingxie/repos","events_url":"https://api.github.com/users/zmingxie/events{/privacy}","received_events_url":"https://api.github.com/users/zmingxie/received_events","type":"User","site_admin":false},"body":"Nope, I just double checked. How many elements do you have in your \"SecurityGroupIds\"? For my test, I only have 1 SG in the list.","created_at":"2015-09-02T15:47:04Z","updated_at":"2015-09-02T15:47:04Z","html_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60#discussion_r38548626","pull_request_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/comments/38548626"},"html":{"href":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60#discussion_r38548626"},"pull_request":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60","id":43442844,"html_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60","diff_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60.diff","patch_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60.patch","issue_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/60","number":60,"state":"open","locked":false,"title":"Fix join when the list only contains 1 element","user":{"login":"zmingxie","id":1136583,"avatar_url":"https://avatars.githubusercontent.com/u/1136583?v=3","gravatar_id":"","url":"https://api.github.com/users/zmingxie","html_url":"https://github.com/zmingxie","followers_url":"https://api.github.com/users/zmingxie/followers","following_url":"https://api.github.com/users/zmingxie/following{/other_user}","gists_url":"https://api.github.com/users/zmingxie/gists{/gist_id}","starred_url":"https://api.github.com/users/zmingxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmingxie/subscriptions","organizations_url":"https://api.github.com/users/zmingxie/orgs","repos_url":"https://api.github.com/users/zmingxie/repos","events_url":"https://api.github.com/users/zmingxie/events{/privacy}","received_events_url":"https://api.github.com/users/zmingxie/received_events","type":"User","site_admin":false},"body":"This is for https://github.com/bazaarvoice/cloudformation-ruby-dsl/issues/58","created_at":"2015-08-26T19:40:46Z","updated_at":"2015-09-02T15:47:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c299192591f631715a6cd0e1bcb85a32f4e9c27b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60/commits","review_comments_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60/comments","review_comment_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/60/comments","statuses_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/statuses/983099c3fa5c6433ea1bfec19ca601d4f7fa5fd9","head":{"label":"zmingxie:fixJoin","ref":"fixJoin","sha":"983099c3fa5c6433ea1bfec19ca601d4f7fa5fd9","user":{"login":"zmingxie","id":1136583,"avatar_url":"https://avatars.githubusercontent.com/u/1136583?v=3","gravatar_id":"","url":"https://api.github.com/users/zmingxie","html_url":"https://github.com/zmingxie","followers_url":"https://api.github.com/users/zmingxie/followers","following_url":"https://api.github.com/users/zmingxie/following{/other_user}","gists_url":"https://api.github.com/users/zmingxie/gists{/gist_id}","starred_url":"https://api.github.com/users/zmingxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmingxie/subscriptions","organizations_url":"https://api.github.com/users/zmingxie/orgs","repos_url":"https://api.github.com/users/zmingxie/repos","events_url":"https://api.github.com/users/zmingxie/events{/privacy}","received_events_url":"https://api.github.com/users/zmingxie/received_events","type":"User","site_admin":false},"repo":{"id":41445063,"name":"cloudformation-ruby-dsl","full_name":"zmingxie/cloudformation-ruby-dsl","owner":{"login":"zmingxie","id":1136583,"avatar_url":"https://avatars.githubusercontent.com/u/1136583?v=3","gravatar_id":"","url":"https://api.github.com/users/zmingxie","html_url":"https://github.com/zmingxie","followers_url":"https://api.github.com/users/zmingxie/followers","following_url":"https://api.github.com/users/zmingxie/following{/other_user}","gists_url":"https://api.github.com/users/zmingxie/gists{/gist_id}","starred_url":"https://api.github.com/users/zmingxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmingxie/subscriptions","organizations_url":"https://api.github.com/users/zmingxie/orgs","repos_url":"https://api.github.com/users/zmingxie/repos","events_url":"https://api.github.com/users/zmingxie/events{/privacy}","received_events_url":"https://api.github.com/users/zmingxie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmingxie/cloudformation-ruby-dsl","description":"Ruby DSL for creating Cloudformation templates","fork":true,"url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl","forks_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/forks","keys_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/teams","hooks_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/hooks","issue_events_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/issues/events{/number}","events_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/events","assignees_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/assignees{/user}","branches_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/branches{/branch}","tags_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/tags","blobs_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/statuses/{sha}","languages_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/languages","stargazers_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/stargazers","contributors_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/contributors","subscribers_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/subscribers","subscription_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/subscription","commits_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/contents/{+path}","compare_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/merges","archive_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/downloads","issues_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/issues{/number}","pulls_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/pulls{/number}","milestones_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/milestones{/number}","notifications_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/labels{/name}","releases_url":"https://api.github.com/repos/zmingxie/cloudformation-ruby-dsl/releases{/id}","created_at":"2015-08-26T19:16:55Z","updated_at":"2015-08-26T19:16:55Z","pushed_at":"2015-08-26T19:40:22Z","git_url":"git://github.com/zmingxie/cloudformation-ruby-dsl.git","ssh_url":"git@github.com:zmingxie/cloudformation-ruby-dsl.git","clone_url":"https://github.com/zmingxie/cloudformation-ruby-dsl.git","svn_url":"https://github.com/zmingxie/cloudformation-ruby-dsl","homepage":"","size":6603,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazaarvoice:master","ref":"master","sha":"e94ba1c78d6286bbbc6daa7a3416af3e3cce59b2","user":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"repo":{"id":17685763,"name":"cloudformation-ruby-dsl","full_name":"bazaarvoice/cloudformation-ruby-dsl","owner":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl","description":"Ruby DSL for creating Cloudformation templates","fork":false,"url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl","forks_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/forks","keys_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/teams","hooks_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/hooks","issue_events_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/events{/number}","events_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/events","assignees_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/assignees{/user}","branches_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/branches{/branch}","tags_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/tags","blobs_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/statuses/{sha}","languages_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/languages","stargazers_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/stargazers","contributors_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/contributors","subscribers_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/subscribers","subscription_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/subscription","commits_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/contents/{+path}","compare_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/merges","archive_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/downloads","issues_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues{/number}","pulls_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls{/number}","milestones_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/milestones{/number}","notifications_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/labels{/name}","releases_url":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/releases{/id}","created_at":"2014-03-12T22:05:28Z","updated_at":"2015-09-01T01:08:50Z","pushed_at":"2015-09-01T22:03:37Z","git_url":"git://github.com/bazaarvoice/cloudformation-ruby-dsl.git","ssh_url":"git@github.com:bazaarvoice/cloudformation-ruby-dsl.git","clone_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl.git","svn_url":"https://github.com/bazaarvoice/cloudformation-ruby-dsl","homepage":"","size":7014,"stargazers_count":91,"watchers_count":91,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":6,"forks":33,"open_issues":6,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60"},"html":{"href":"https://github.com/bazaarvoice/cloudformation-ruby-dsl/pull/60"},"issue":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/60"},"comments":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/bazaarvoice/cloudformation-ruby-dsl/statuses/983099c3fa5c6433ea1bfec19ca601d4f7fa5fd9"}}}}