{"action":"created","issue":{"url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3544","labels_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3544/labels{/name}","comments_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3544/comments","events_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3544/events","html_url":"https://github.com/pyrocms/pyrocms/issues/3544","id":109929625,"number":3544,"title":"PyroCMS 2.2.5 Update for Google Analytics Dashboard #3503","user":{"login":"ikoniqoz","id":3609155,"avatar_url":"https://avatars.githubusercontent.com/u/3609155?v=3","gravatar_id":"","url":"https://api.github.com/users/ikoniqoz","html_url":"https://github.com/ikoniqoz","followers_url":"https://api.github.com/users/ikoniqoz/followers","following_url":"https://api.github.com/users/ikoniqoz/following{/other_user}","gists_url":"https://api.github.com/users/ikoniqoz/gists{/gist_id}","starred_url":"https://api.github.com/users/ikoniqoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikoniqoz/subscriptions","organizations_url":"https://api.github.com/users/ikoniqoz/orgs","repos_url":"https://api.github.com/users/ikoniqoz/repos","events_url":"https://api.github.com/users/ikoniqoz/events{/privacy}","received_events_url":"https://api.github.com/users/ikoniqoz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2015-10-06T03:31:40Z","updated_at":"2015-10-27T02:01:42Z","closed_at":null,"body":"Background:\r\n1. I have already upgraded a PyroCMS 2.1.5 site to the latest following last merge on 14-AUG to include resolution for #3503. In this case, the GA Update appears to have been fully implemented OK.\r\n2. I have now updated a client's PyroCMS 2.2.5 site which was from prior to the #3503 merge AND I installed a NEW site based on the latest updates for #3503. On both occasions the update was not fully implemented.\r\n\r\nObservations:\r\nAll files for the updates were either updated or created. These included:\r\n- libraries/Analytics.php\r\n- libraries/Gapi.php  \r\n- migrations/130_alter_ga_settings.php   { NOTE the word \"alter\" first letter is not capitalised. }\r\n- plugins/integration.php\r\n\r\nHowever the  db fields were not updated according to the migrations file.  Is that what is supposed to happen ?\r\n\r\nI note that the Labels and Descriptions for the GA Email and GA Password fields in Dashboard -> Settings -> Integration are derived from the Settings Module's lang file (setting_lang.php) - not the settings db table which was not updated. So, to get the field Labels and Descriptions correct I had to manually edit the settings_lang.php file.\r\n\r\nOne other point is that I edited the ga_password field type in the  settings db table by changing it from password type to text type and I could then enter the path to the ga-key.p12 file.\r\n\r\nRight now, I do not know if these changes I have made to the client's site work as expected for the GA stuff as it has not yet been pushed thru to Production. Nevertheless, there is enough here to cause me some concern.\r\n\r\nBottom Line: Does anyone have PyroCMS 2.2.5 with the merge for #3503 from 14th Aug fully functional ?\r\n\r\nJust in case this is relevant, my dev system is Win7 with PHP 5.3.5"},"comment":{"url":"https://api.github.com/repos/pyrocms/pyrocms/issues/comments/151343050","html_url":"https://github.com/pyrocms/pyrocms/issues/3544#issuecomment-151343050","issue_url":"https://api.github.com/repos/pyrocms/pyrocms/issues/3544","id":151343050,"user":{"login":"ikoniqoz","id":3609155,"avatar_url":"https://avatars.githubusercontent.com/u/3609155?v=3","gravatar_id":"","url":"https://api.github.com/users/ikoniqoz","html_url":"https://github.com/ikoniqoz","followers_url":"https://api.github.com/users/ikoniqoz/followers","following_url":"https://api.github.com/users/ikoniqoz/following{/other_user}","gists_url":"https://api.github.com/users/ikoniqoz/gists{/gist_id}","starred_url":"https://api.github.com/users/ikoniqoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikoniqoz/subscriptions","organizations_url":"https://api.github.com/users/ikoniqoz/orgs","repos_url":"https://api.github.com/users/ikoniqoz/repos","events_url":"https://api.github.com/users/ikoniqoz/events{/privacy}","received_events_url":"https://api.github.com/users/ikoniqoz/received_events","type":"User","site_admin":false},"created_at":"2015-10-27T02:01:42Z","updated_at":"2015-10-27T02:01:42Z","body":"OK - Thanks. I missed editing that line."}}