{"action":"closed","issue":{"url":"https://api.github.com/repos/Xilinx/linux-xlnx/issues/67","labels_url":"https://api.github.com/repos/Xilinx/linux-xlnx/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/Xilinx/linux-xlnx/issues/67/comments","events_url":"https://api.github.com/repos/Xilinx/linux-xlnx/issues/67/events","html_url":"https://github.com/Xilinx/linux-xlnx/issues/67","id":110547403,"number":67,"title":"problems with xilinx_emacps.c and macb.c in xilinx-v2015.3","user":{"login":"pavel-demin","id":8037893,"avatar_url":"https://avatars.githubusercontent.com/u/8037893?v=3","gravatar_id":"","url":"https://api.github.com/users/pavel-demin","html_url":"https://github.com/pavel-demin","followers_url":"https://api.github.com/users/pavel-demin/followers","following_url":"https://api.github.com/users/pavel-demin/following{/other_user}","gists_url":"https://api.github.com/users/pavel-demin/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-demin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-demin/subscriptions","organizations_url":"https://api.github.com/users/pavel-demin/orgs","repos_url":"https://api.github.com/users/pavel-demin/repos","events_url":"https://api.github.com/users/pavel-demin/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-demin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-08T21:44:37Z","updated_at":"2015-10-12T19:28:12Z","closed_at":"2015-10-12T19:28:12Z","body":"Hello,\r\n\r\nI'm trying to upgrade my Linux kernel from xilinx-v2015.2 to xilinx-v2015.3 and I've found a couple of problems with [drivers/net/ethernet/xilinx/xilinx_emacps.c](https://github.com/Xilinx/linux-xlnx/blob/xilinx-v2015.3/drivers/net/ethernet/xilinx/xilinx_emacps.c) and [drivers/net/ethernet/cadence/macb.c](https://github.com/Xilinx/linux-xlnx/blob/xilinx-v2015.3/drivers/net/ethernet/cadence/macb.c):\r\n - I had to add ```#include <linux/timecounter.h>```, otherwise the build failed with ```error: implicit declaration of function 'timecounter_init'```,\r\n - during the shutdown, the ```macb``` driver crashes at [line 1708 ](https://github.com/Xilinx/linux-xlnx/blob/xilinx-v2015.3/drivers/net/ethernet/cadence/macb.c#L1708) when calling ```ptp_clock_unregister(bp->ptp_clock)```.\r\n\r\nI'm testing it on the Red Pitaya board.\r\n\r\nBest regards,\r\n\r\nPavel\r\n"}}