{"action":"opened","number":3079,"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/3079","id":51607401,"html_url":"https://github.com/Polymer/polymer/pull/3079","diff_url":"https://github.com/Polymer/polymer/pull/3079.diff","patch_url":"https://github.com/Polymer/polymer/pull/3079.patch","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/3079","number":3079,"state":"open","locked":false,"title":"loosen isLightDescendant's @param type to Node","user":{"login":"danbeam","id":251287,"avatar_url":"https://avatars.githubusercontent.com/u/251287?v=3","gravatar_id":"","url":"https://api.github.com/users/danbeam","html_url":"https://github.com/danbeam","followers_url":"https://api.github.com/users/danbeam/followers","following_url":"https://api.github.com/users/danbeam/following{/other_user}","gists_url":"https://api.github.com/users/danbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/danbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbeam/subscriptions","organizations_url":"https://api.github.com/users/danbeam/orgs","repos_url":"https://api.github.com/users/danbeam/repos","events_url":"https://api.github.com/users/danbeam/events{/privacy}","received_events_url":"https://api.github.com/users/danbeam/received_events","type":"User","site_admin":false},"body":"`isLightDescendant` doesn't use any `HTMLElement`'s API and can validly be simply `Node` when processing events on `document`.\r\n\r\nalso, I've removed the trailing `{...=}` because `Polymer.dom()` requires `?Node|?Event` as far as I can tell (from the externs) and `node` probably shouldn't be optional.  if somewhere really does use `.isLightDescendant()`, closure should let us know.\r\n\r\nnote: this doesn't address the `EventTarget` use-case (i.e. events on `window`).\r\n\r\n/cc @notwaldorf @sorvell ","created_at":"2015-11-24T01:54:27Z","updated_at":"2015-11-24T01:54:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer/pulls/3079/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer/pulls/3079/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/3079/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/c63579737e39e8c16191f1d5dc96067a110c57ca","head":{"label":"danbeam:patch-1","ref":"patch-1","sha":"c63579737e39e8c16191f1d5dc96067a110c57ca","user":{"login":"danbeam","id":251287,"avatar_url":"https://avatars.githubusercontent.com/u/251287?v=3","gravatar_id":"","url":"https://api.github.com/users/danbeam","html_url":"https://github.com/danbeam","followers_url":"https://api.github.com/users/danbeam/followers","following_url":"https://api.github.com/users/danbeam/following{/other_user}","gists_url":"https://api.github.com/users/danbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/danbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbeam/subscriptions","organizations_url":"https://api.github.com/users/danbeam/orgs","repos_url":"https://api.github.com/users/danbeam/repos","events_url":"https://api.github.com/users/danbeam/events{/privacy}","received_events_url":"https://api.github.com/users/danbeam/received_events","type":"User","site_admin":false},"repo":{"id":46759759,"name":"polymer","full_name":"danbeam/polymer","owner":{"login":"danbeam","id":251287,"avatar_url":"https://avatars.githubusercontent.com/u/251287?v=3","gravatar_id":"","url":"https://api.github.com/users/danbeam","html_url":"https://github.com/danbeam","followers_url":"https://api.github.com/users/danbeam/followers","following_url":"https://api.github.com/users/danbeam/following{/other_user}","gists_url":"https://api.github.com/users/danbeam/gists{/gist_id}","starred_url":"https://api.github.com/users/danbeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbeam/subscriptions","organizations_url":"https://api.github.com/users/danbeam/orgs","repos_url":"https://api.github.com/users/danbeam/repos","events_url":"https://api.github.com/users/danbeam/events{/privacy}","received_events_url":"https://api.github.com/users/danbeam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbeam/polymer","description":"Build modern apps using web components","fork":true,"url":"https://api.github.com/repos/danbeam/polymer","forks_url":"https://api.github.com/repos/danbeam/polymer/forks","keys_url":"https://api.github.com/repos/danbeam/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbeam/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbeam/polymer/teams","hooks_url":"https://api.github.com/repos/danbeam/polymer/hooks","issue_events_url":"https://api.github.com/repos/danbeam/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/danbeam/polymer/events","assignees_url":"https://api.github.com/repos/danbeam/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/danbeam/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/danbeam/polymer/tags","blobs_url":"https://api.github.com/repos/danbeam/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbeam/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbeam/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbeam/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbeam/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/danbeam/polymer/languages","stargazers_url":"https://api.github.com/repos/danbeam/polymer/stargazers","contributors_url":"https://api.github.com/repos/danbeam/polymer/contributors","subscribers_url":"https://api.github.com/repos/danbeam/polymer/subscribers","subscription_url":"https://api.github.com/repos/danbeam/polymer/subscription","commits_url":"https://api.github.com/repos/danbeam/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbeam/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbeam/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbeam/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbeam/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/danbeam/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbeam/polymer/merges","archive_url":"https://api.github.com/repos/danbeam/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbeam/polymer/downloads","issues_url":"https://api.github.com/repos/danbeam/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/danbeam/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/danbeam/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/danbeam/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbeam/polymer/labels{/name}","releases_url":"https://api.github.com/repos/danbeam/polymer/releases{/id}","created_at":"2015-11-24T01:45:54Z","updated_at":"2015-11-24T01:45:57Z","pushed_at":"2015-11-24T01:46:34Z","git_url":"git://github.com/danbeam/polymer.git","ssh_url":"git@github.com:danbeam/polymer.git","clone_url":"https://github.com/danbeam/polymer.git","svn_url":"https://github.com/danbeam/polymer","homepage":"https://www.polymer-project.org/1.0/","size":17614,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"e5fb166c509c89cff3b0f2ca797e74fbbd9edd42","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"name":"polymer","full_name":"Polymer/polymer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","created_at":"2012-08-23T20:56:30Z","updated_at":"2015-11-24T01:00:12Z","pushed_at":"2015-11-23T23:46:12Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/1.0/","size":20853,"stargazers_count":13336,"watchers_count":13336,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1327,"mirror_url":null,"open_issues_count":384,"forks":1327,"open_issues":384,"watchers":13336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/3079"},"html":{"href":"https://github.com/Polymer/polymer/pull/3079"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer/issues/3079"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer/issues/3079/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/3079/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/3079/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer/statuses/c63579737e39e8c16191f1d5dc96067a110c57ca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}