{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1","id":46569534,"html_url":"https://github.com/brightcove/videojs-omniture/pull/1","diff_url":"https://github.com/brightcove/videojs-omniture/pull/1.diff","patch_url":"https://github.com/brightcove/videojs-omniture/pull/1.patch","issue_url":"https://api.github.com/repos/brightcove/videojs-omniture/issues/1","number":1,"state":"closed","locked":false,"title":"Fix milestone tracking by removing unnecessary millisecond conversion.","user":{"login":"saramartinez","id":6402588,"avatar_url":"https://avatars.githubusercontent.com/u/6402588?v=3","gravatar_id":"","url":"https://api.github.com/users/saramartinez","html_url":"https://github.com/saramartinez","followers_url":"https://api.github.com/users/saramartinez/followers","following_url":"https://api.github.com/users/saramartinez/following{/other_user}","gists_url":"https://api.github.com/users/saramartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/saramartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saramartinez/subscriptions","organizations_url":"https://api.github.com/users/saramartinez/orgs","repos_url":"https://api.github.com/users/saramartinez/repos","events_url":"https://api.github.com/users/saramartinez/events{/privacy}","received_events_url":"https://api.github.com/users/saramartinez/received_events","type":"User","site_admin":false},"body":"Remove lines 661-663: The duration() method in videojs returns the video length in seconds, not milliseconds, so dividing by 1000 sets the video duration to a fraction, and all events would fire instantly since 25%, 50%, 75% of the full duration were always longer than the duration divided by 1000.\r\n\r\nLinter removed extra spaces in code.\r\n\r\nSame PR here and in BrightcoveOS/videojs-omniture since I'm not sure which one it kept up to date.","created_at":"2015-10-01T20:01:13Z","updated_at":"2015-12-08T00:41:06Z","closed_at":"2015-12-08T00:41:06Z","merged_at":"2015-12-08T00:41:06Z","merge_commit_sha":"24c45510b4d39c29c5314644737a993ab496c901","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1/commits","review_comments_url":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1/comments","review_comment_url":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brightcove/videojs-omniture/issues/1/comments","statuses_url":"https://api.github.com/repos/brightcove/videojs-omniture/statuses/425c8fdd95e6e732062f734f6990ef8f7f62e87a","head":{"label":"saramartinez:fix-milestone-tracking","ref":"fix-milestone-tracking","sha":"425c8fdd95e6e732062f734f6990ef8f7f62e87a","user":{"login":"saramartinez","id":6402588,"avatar_url":"https://avatars.githubusercontent.com/u/6402588?v=3","gravatar_id":"","url":"https://api.github.com/users/saramartinez","html_url":"https://github.com/saramartinez","followers_url":"https://api.github.com/users/saramartinez/followers","following_url":"https://api.github.com/users/saramartinez/following{/other_user}","gists_url":"https://api.github.com/users/saramartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/saramartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saramartinez/subscriptions","organizations_url":"https://api.github.com/users/saramartinez/orgs","repos_url":"https://api.github.com/users/saramartinez/repos","events_url":"https://api.github.com/users/saramartinez/events{/privacy}","received_events_url":"https://api.github.com/users/saramartinez/received_events","type":"User","site_admin":false},"repo":{"id":43517470,"name":"videojs-omniture-1","full_name":"saramartinez/videojs-omniture-1","owner":{"login":"saramartinez","id":6402588,"avatar_url":"https://avatars.githubusercontent.com/u/6402588?v=3","gravatar_id":"","url":"https://api.github.com/users/saramartinez","html_url":"https://github.com/saramartinez","followers_url":"https://api.github.com/users/saramartinez/followers","following_url":"https://api.github.com/users/saramartinez/following{/other_user}","gists_url":"https://api.github.com/users/saramartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/saramartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saramartinez/subscriptions","organizations_url":"https://api.github.com/users/saramartinez/orgs","repos_url":"https://api.github.com/users/saramartinez/repos","events_url":"https://api.github.com/users/saramartinez/events{/privacy}","received_events_url":"https://api.github.com/users/saramartinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saramartinez/videojs-omniture-1","description":"Adobe Omniture plugin for the Brightcove Player","fork":true,"url":"https://api.github.com/repos/saramartinez/videojs-omniture-1","forks_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/forks","keys_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/teams","hooks_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/hooks","issue_events_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/issues/events{/number}","events_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/events","assignees_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/assignees{/user}","branches_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/branches{/branch}","tags_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/tags","blobs_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/statuses/{sha}","languages_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/languages","stargazers_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/stargazers","contributors_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/contributors","subscribers_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/subscribers","subscription_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/subscription","commits_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/contents/{+path}","compare_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/merges","archive_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/downloads","issues_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/issues{/number}","pulls_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/pulls{/number}","milestones_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/milestones{/number}","notifications_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/labels{/name}","releases_url":"https://api.github.com/repos/saramartinez/videojs-omniture-1/releases{/id}","created_at":"2015-10-01T19:52:19Z","updated_at":"2015-10-01T19:52:20Z","pushed_at":"2015-10-01T20:00:09Z","git_url":"git://github.com/saramartinez/videojs-omniture-1.git","ssh_url":"git@github.com:saramartinez/videojs-omniture-1.git","clone_url":"https://github.com/saramartinez/videojs-omniture-1.git","svn_url":"https://github.com/saramartinez/videojs-omniture-1","homepage":null,"size":261,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brightcove:master","ref":"master","sha":"519e9405371c96b93599c0b787a2c82d14921240","user":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"repo":{"id":31383399,"name":"videojs-omniture","full_name":"brightcove/videojs-omniture","owner":{"login":"brightcove","id":277032,"avatar_url":"https://avatars.githubusercontent.com/u/277032?v=3","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brightcove/videojs-omniture","description":"Adobe Omniture plugin for the Brightcove Player","fork":false,"url":"https://api.github.com/repos/brightcove/videojs-omniture","forks_url":"https://api.github.com/repos/brightcove/videojs-omniture/forks","keys_url":"https://api.github.com/repos/brightcove/videojs-omniture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brightcove/videojs-omniture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brightcove/videojs-omniture/teams","hooks_url":"https://api.github.com/repos/brightcove/videojs-omniture/hooks","issue_events_url":"https://api.github.com/repos/brightcove/videojs-omniture/issues/events{/number}","events_url":"https://api.github.com/repos/brightcove/videojs-omniture/events","assignees_url":"https://api.github.com/repos/brightcove/videojs-omniture/assignees{/user}","branches_url":"https://api.github.com/repos/brightcove/videojs-omniture/branches{/branch}","tags_url":"https://api.github.com/repos/brightcove/videojs-omniture/tags","blobs_url":"https://api.github.com/repos/brightcove/videojs-omniture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brightcove/videojs-omniture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brightcove/videojs-omniture/git/refs{/sha}","trees_url":"https://api.github.com/repos/brightcove/videojs-omniture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brightcove/videojs-omniture/statuses/{sha}","languages_url":"https://api.github.com/repos/brightcove/videojs-omniture/languages","stargazers_url":"https://api.github.com/repos/brightcove/videojs-omniture/stargazers","contributors_url":"https://api.github.com/repos/brightcove/videojs-omniture/contributors","subscribers_url":"https://api.github.com/repos/brightcove/videojs-omniture/subscribers","subscription_url":"https://api.github.com/repos/brightcove/videojs-omniture/subscription","commits_url":"https://api.github.com/repos/brightcove/videojs-omniture/commits{/sha}","git_commits_url":"https://api.github.com/repos/brightcove/videojs-omniture/git/commits{/sha}","comments_url":"https://api.github.com/repos/brightcove/videojs-omniture/comments{/number}","issue_comment_url":"https://api.github.com/repos/brightcove/videojs-omniture/issues/comments{/number}","contents_url":"https://api.github.com/repos/brightcove/videojs-omniture/contents/{+path}","compare_url":"https://api.github.com/repos/brightcove/videojs-omniture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brightcove/videojs-omniture/merges","archive_url":"https://api.github.com/repos/brightcove/videojs-omniture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brightcove/videojs-omniture/downloads","issues_url":"https://api.github.com/repos/brightcove/videojs-omniture/issues{/number}","pulls_url":"https://api.github.com/repos/brightcove/videojs-omniture/pulls{/number}","milestones_url":"https://api.github.com/repos/brightcove/videojs-omniture/milestones{/number}","notifications_url":"https://api.github.com/repos/brightcove/videojs-omniture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brightcove/videojs-omniture/labels{/name}","releases_url":"https://api.github.com/repos/brightcove/videojs-omniture/releases{/id}","created_at":"2015-02-26T18:59:11Z","updated_at":"2015-09-28T20:16:14Z","pushed_at":"2015-12-08T00:41:06Z","git_url":"git://github.com/brightcove/videojs-omniture.git","ssh_url":"git@github.com:brightcove/videojs-omniture.git","clone_url":"https://github.com/brightcove/videojs-omniture.git","svn_url":"https://github.com/brightcove/videojs-omniture","homepage":null,"size":335,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1"},"html":{"href":"https://github.com/brightcove/videojs-omniture/pull/1"},"issue":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/issues/1"},"comments":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/brightcove/videojs-omniture/statuses/425c8fdd95e6e732062f734f6990ef8f7f62e87a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"commits":1,"additions":22,"deletions":25,"changed_files":1}}