{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2","id":53174132,"html_url":"https://github.com/hedefalk/ensime-atom/pull/2","diff_url":"https://github.com/hedefalk/ensime-atom/pull/2.diff","patch_url":"https://github.com/hedefalk/ensime-atom/pull/2.patch","issue_url":"https://api.github.com/repos/hedefalk/ensime-atom/issues/2","number":2,"state":"open","locked":false,"title":"Feature / inline warnings and errors","user":{"login":"jeffwilde","id":6980603,"avatar_url":"https://avatars.githubusercontent.com/u/6980603?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffwilde","html_url":"https://github.com/jeffwilde","followers_url":"https://api.github.com/users/jeffwilde/followers","following_url":"https://api.github.com/users/jeffwilde/following{/other_user}","gists_url":"https://api.github.com/users/jeffwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwilde/subscriptions","organizations_url":"https://api.github.com/users/jeffwilde/orgs","repos_url":"https://api.github.com/users/jeffwilde/repos","events_url":"https://api.github.com/users/jeffwilde/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwilde/received_events","type":"User","site_admin":false},"body":"This pull request adds inline error/warning underlines and gutter markings. \r\n\r\nBy way of gif:\r\n![demo-inlines](https://cloud.githubusercontent.com/assets/6980603/11697315/0b5312a0-9e87-11e5-8263-9621628f62ac.gif)\r\n\r\nImplicit markers were also cleaned-up a bit, bringing the styling into-line with the errors/warnings.\r\n\r\nI made a decision to put the message dispatching into the main ensime controller in the `statusbarOutput` method, knowing that the intention is to pull out this functionality into a separate separate concern—i.e. some sort of \"central dispatch\". I viewed this as a better move than adding complication to the `TypeChecking` class, which seems best suited to controlling the bottom pane view for now. \r\n\r\nIf that decision turns out to be controversial, I'm happy to push the dispatch back into the `TypeChecking` class.","created_at":"2015-12-09T20:36:15Z","updated_at":"2015-12-09T20:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2/commits","review_comments_url":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2/comments","review_comment_url":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hedefalk/ensime-atom/issues/2/comments","statuses_url":"https://api.github.com/repos/hedefalk/ensime-atom/statuses/f18d90d76ef3a931f6f9723c93b3924208a57cd9","head":{"label":"jeffwilde:feature/inline-warnings-and-errors","ref":"feature/inline-warnings-and-errors","sha":"f18d90d76ef3a931f6f9723c93b3924208a57cd9","user":{"login":"jeffwilde","id":6980603,"avatar_url":"https://avatars.githubusercontent.com/u/6980603?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffwilde","html_url":"https://github.com/jeffwilde","followers_url":"https://api.github.com/users/jeffwilde/followers","following_url":"https://api.github.com/users/jeffwilde/following{/other_user}","gists_url":"https://api.github.com/users/jeffwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwilde/subscriptions","organizations_url":"https://api.github.com/users/jeffwilde/orgs","repos_url":"https://api.github.com/users/jeffwilde/repos","events_url":"https://api.github.com/users/jeffwilde/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwilde/received_events","type":"User","site_admin":false},"repo":{"id":47698309,"name":"ensime-atom","full_name":"jeffwilde/ensime-atom","owner":{"login":"jeffwilde","id":6980603,"avatar_url":"https://avatars.githubusercontent.com/u/6980603?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffwilde","html_url":"https://github.com/jeffwilde","followers_url":"https://api.github.com/users/jeffwilde/followers","following_url":"https://api.github.com/users/jeffwilde/following{/other_user}","gists_url":"https://api.github.com/users/jeffwilde/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffwilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffwilde/subscriptions","organizations_url":"https://api.github.com/users/jeffwilde/orgs","repos_url":"https://api.github.com/users/jeffwilde/repos","events_url":"https://api.github.com/users/jeffwilde/events{/privacy}","received_events_url":"https://api.github.com/users/jeffwilde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffwilde/ensime-atom","description":"","fork":true,"url":"https://api.github.com/repos/jeffwilde/ensime-atom","forks_url":"https://api.github.com/repos/jeffwilde/ensime-atom/forks","keys_url":"https://api.github.com/repos/jeffwilde/ensime-atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffwilde/ensime-atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffwilde/ensime-atom/teams","hooks_url":"https://api.github.com/repos/jeffwilde/ensime-atom/hooks","issue_events_url":"https://api.github.com/repos/jeffwilde/ensime-atom/issues/events{/number}","events_url":"https://api.github.com/repos/jeffwilde/ensime-atom/events","assignees_url":"https://api.github.com/repos/jeffwilde/ensime-atom/assignees{/user}","branches_url":"https://api.github.com/repos/jeffwilde/ensime-atom/branches{/branch}","tags_url":"https://api.github.com/repos/jeffwilde/ensime-atom/tags","blobs_url":"https://api.github.com/repos/jeffwilde/ensime-atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffwilde/ensime-atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffwilde/ensime-atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffwilde/ensime-atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffwilde/ensime-atom/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffwilde/ensime-atom/languages","stargazers_url":"https://api.github.com/repos/jeffwilde/ensime-atom/stargazers","contributors_url":"https://api.github.com/repos/jeffwilde/ensime-atom/contributors","subscribers_url":"https://api.github.com/repos/jeffwilde/ensime-atom/subscribers","subscription_url":"https://api.github.com/repos/jeffwilde/ensime-atom/subscription","commits_url":"https://api.github.com/repos/jeffwilde/ensime-atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffwilde/ensime-atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffwilde/ensime-atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffwilde/ensime-atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffwilde/ensime-atom/contents/{+path}","compare_url":"https://api.github.com/repos/jeffwilde/ensime-atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffwilde/ensime-atom/merges","archive_url":"https://api.github.com/repos/jeffwilde/ensime-atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffwilde/ensime-atom/downloads","issues_url":"https://api.github.com/repos/jeffwilde/ensime-atom/issues{/number}","pulls_url":"https://api.github.com/repos/jeffwilde/ensime-atom/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffwilde/ensime-atom/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffwilde/ensime-atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffwilde/ensime-atom/labels{/name}","releases_url":"https://api.github.com/repos/jeffwilde/ensime-atom/releases{/id}","created_at":"2015-12-09T15:03:03Z","updated_at":"2015-12-09T15:03:04Z","pushed_at":"2015-12-09T19:46:24Z","git_url":"git://github.com/jeffwilde/ensime-atom.git","ssh_url":"git@github.com:jeffwilde/ensime-atom.git","clone_url":"https://github.com/jeffwilde/ensime-atom.git","svn_url":"https://github.com/jeffwilde/ensime-atom","homepage":null,"size":200,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hedefalk:feature/multiple_folders","ref":"feature/multiple_folders","sha":"74e93974aea988918c78659a2761a295839ed108","user":{"login":"hedefalk","id":116520,"avatar_url":"https://avatars.githubusercontent.com/u/116520?v=3","gravatar_id":"","url":"https://api.github.com/users/hedefalk","html_url":"https://github.com/hedefalk","followers_url":"https://api.github.com/users/hedefalk/followers","following_url":"https://api.github.com/users/hedefalk/following{/other_user}","gists_url":"https://api.github.com/users/hedefalk/gists{/gist_id}","starred_url":"https://api.github.com/users/hedefalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedefalk/subscriptions","organizations_url":"https://api.github.com/users/hedefalk/orgs","repos_url":"https://api.github.com/users/hedefalk/repos","events_url":"https://api.github.com/users/hedefalk/events{/privacy}","received_events_url":"https://api.github.com/users/hedefalk/received_events","type":"User","site_admin":false},"repo":{"id":37685980,"name":"ensime-atom","full_name":"hedefalk/ensime-atom","owner":{"login":"hedefalk","id":116520,"avatar_url":"https://avatars.githubusercontent.com/u/116520?v=3","gravatar_id":"","url":"https://api.github.com/users/hedefalk","html_url":"https://github.com/hedefalk","followers_url":"https://api.github.com/users/hedefalk/followers","following_url":"https://api.github.com/users/hedefalk/following{/other_user}","gists_url":"https://api.github.com/users/hedefalk/gists{/gist_id}","starred_url":"https://api.github.com/users/hedefalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hedefalk/subscriptions","organizations_url":"https://api.github.com/users/hedefalk/orgs","repos_url":"https://api.github.com/users/hedefalk/repos","events_url":"https://api.github.com/users/hedefalk/events{/privacy}","received_events_url":"https://api.github.com/users/hedefalk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hedefalk/ensime-atom","description":"","fork":true,"url":"https://api.github.com/repos/hedefalk/ensime-atom","forks_url":"https://api.github.com/repos/hedefalk/ensime-atom/forks","keys_url":"https://api.github.com/repos/hedefalk/ensime-atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hedefalk/ensime-atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hedefalk/ensime-atom/teams","hooks_url":"https://api.github.com/repos/hedefalk/ensime-atom/hooks","issue_events_url":"https://api.github.com/repos/hedefalk/ensime-atom/issues/events{/number}","events_url":"https://api.github.com/repos/hedefalk/ensime-atom/events","assignees_url":"https://api.github.com/repos/hedefalk/ensime-atom/assignees{/user}","branches_url":"https://api.github.com/repos/hedefalk/ensime-atom/branches{/branch}","tags_url":"https://api.github.com/repos/hedefalk/ensime-atom/tags","blobs_url":"https://api.github.com/repos/hedefalk/ensime-atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hedefalk/ensime-atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hedefalk/ensime-atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/hedefalk/ensime-atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hedefalk/ensime-atom/statuses/{sha}","languages_url":"https://api.github.com/repos/hedefalk/ensime-atom/languages","stargazers_url":"https://api.github.com/repos/hedefalk/ensime-atom/stargazers","contributors_url":"https://api.github.com/repos/hedefalk/ensime-atom/contributors","subscribers_url":"https://api.github.com/repos/hedefalk/ensime-atom/subscribers","subscription_url":"https://api.github.com/repos/hedefalk/ensime-atom/subscription","commits_url":"https://api.github.com/repos/hedefalk/ensime-atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/hedefalk/ensime-atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/hedefalk/ensime-atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/hedefalk/ensime-atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/hedefalk/ensime-atom/contents/{+path}","compare_url":"https://api.github.com/repos/hedefalk/ensime-atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hedefalk/ensime-atom/merges","archive_url":"https://api.github.com/repos/hedefalk/ensime-atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hedefalk/ensime-atom/downloads","issues_url":"https://api.github.com/repos/hedefalk/ensime-atom/issues{/number}","pulls_url":"https://api.github.com/repos/hedefalk/ensime-atom/pulls{/number}","milestones_url":"https://api.github.com/repos/hedefalk/ensime-atom/milestones{/number}","notifications_url":"https://api.github.com/repos/hedefalk/ensime-atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hedefalk/ensime-atom/labels{/name}","releases_url":"https://api.github.com/repos/hedefalk/ensime-atom/releases{/id}","created_at":"2015-06-18T21:26:58Z","updated_at":"2015-06-18T21:26:58Z","pushed_at":"2015-12-07T17:11:49Z","git_url":"git://github.com/hedefalk/ensime-atom.git","ssh_url":"git@github.com:hedefalk/ensime-atom.git","clone_url":"https://github.com/hedefalk/ensime-atom.git","svn_url":"https://github.com/hedefalk/ensime-atom","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2"},"html":{"href":"https://github.com/hedefalk/ensime-atom/pull/2"},"issue":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/issues/2"},"comments":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/hedefalk/ensime-atom/statuses/f18d90d76ef3a931f6f9723c93b3924208a57cd9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":154,"deletions":81,"changed_files":6}}