{"action":"opened","number":781,"pull_request":{"url":"https://api.github.com/repos/rack/rack/pulls/781","id":26947412,"html_url":"https://github.com/rack/rack/pull/781","diff_url":"https://github.com/rack/rack/pull/781.diff","patch_url":"https://github.com/rack/rack/pull/781.patch","issue_url":"https://api.github.com/repos/rack/rack/issues/781","number":781,"state":"open","locked":false,"title":"Fix semicolons as separators for GET","user":{"login":"Nyoho","id":118150,"avatar_url":"https://avatars.githubusercontent.com/u/118150?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyoho","html_url":"https://github.com/Nyoho","followers_url":"https://api.github.com/users/Nyoho/followers","following_url":"https://api.github.com/users/Nyoho/following{/other_user}","gists_url":"https://api.github.com/users/Nyoho/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyoho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyoho/subscriptions","organizations_url":"https://api.github.com/users/Nyoho/orgs","repos_url":"https://api.github.com/users/Nyoho/repos","events_url":"https://api.github.com/users/Nyoho/events{/privacy}","received_events_url":"https://api.github.com/users/Nyoho/received_events","type":"User","site_admin":false},"body":"Fix to use semicolons as separators for GET not for POST.\r\n\r\n(cf. issue: Truncation of POST data on semicolon during param processing (unencoding?)  https://github.com/rack/rack/issues/543)\r\n\r\nA semicolon ';' should be used as a separator according to a W3.org recommendation\r\nhttp://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2\r\n\r\nThe commit https://github.com/rack/rack/commit/71c69113f269f04207157bee6c197b5675f3df61 was the one for only POST not for GET, but the test was written for GET, which is kind of a discrepancy.","created_at":"2015-01-07T09:56:08Z","updated_at":"2015-01-07T09:56:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rack/rack/pulls/781/commits","review_comments_url":"https://api.github.com/repos/rack/rack/pulls/781/comments","review_comment_url":"https://api.github.com/repos/rack/rack/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rack/rack/issues/781/comments","statuses_url":"https://api.github.com/repos/rack/rack/statuses/6af5f928f3a860e9bb74fc0bdd83b30be9d722a9","head":{"label":"Nyoho:fix-separator-semicolon-GET","ref":"fix-separator-semicolon-GET","sha":"6af5f928f3a860e9bb74fc0bdd83b30be9d722a9","user":{"login":"Nyoho","id":118150,"avatar_url":"https://avatars.githubusercontent.com/u/118150?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyoho","html_url":"https://github.com/Nyoho","followers_url":"https://api.github.com/users/Nyoho/followers","following_url":"https://api.github.com/users/Nyoho/following{/other_user}","gists_url":"https://api.github.com/users/Nyoho/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyoho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyoho/subscriptions","organizations_url":"https://api.github.com/users/Nyoho/orgs","repos_url":"https://api.github.com/users/Nyoho/repos","events_url":"https://api.github.com/users/Nyoho/events{/privacy}","received_events_url":"https://api.github.com/users/Nyoho/received_events","type":"User","site_admin":false},"repo":{"id":28900992,"name":"rack","full_name":"Nyoho/rack","owner":{"login":"Nyoho","id":118150,"avatar_url":"https://avatars.githubusercontent.com/u/118150?v=3","gravatar_id":"","url":"https://api.github.com/users/Nyoho","html_url":"https://github.com/Nyoho","followers_url":"https://api.github.com/users/Nyoho/followers","following_url":"https://api.github.com/users/Nyoho/following{/other_user}","gists_url":"https://api.github.com/users/Nyoho/gists{/gist_id}","starred_url":"https://api.github.com/users/Nyoho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nyoho/subscriptions","organizations_url":"https://api.github.com/users/Nyoho/orgs","repos_url":"https://api.github.com/users/Nyoho/repos","events_url":"https://api.github.com/users/Nyoho/events{/privacy}","received_events_url":"https://api.github.com/users/Nyoho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nyoho/rack","description":"a modular Ruby webserver interface","fork":true,"url":"https://api.github.com/repos/Nyoho/rack","forks_url":"https://api.github.com/repos/Nyoho/rack/forks","keys_url":"https://api.github.com/repos/Nyoho/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nyoho/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nyoho/rack/teams","hooks_url":"https://api.github.com/repos/Nyoho/rack/hooks","issue_events_url":"https://api.github.com/repos/Nyoho/rack/issues/events{/number}","events_url":"https://api.github.com/repos/Nyoho/rack/events","assignees_url":"https://api.github.com/repos/Nyoho/rack/assignees{/user}","branches_url":"https://api.github.com/repos/Nyoho/rack/branches{/branch}","tags_url":"https://api.github.com/repos/Nyoho/rack/tags","blobs_url":"https://api.github.com/repos/Nyoho/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nyoho/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nyoho/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nyoho/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nyoho/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/Nyoho/rack/languages","stargazers_url":"https://api.github.com/repos/Nyoho/rack/stargazers","contributors_url":"https://api.github.com/repos/Nyoho/rack/contributors","subscribers_url":"https://api.github.com/repos/Nyoho/rack/subscribers","subscription_url":"https://api.github.com/repos/Nyoho/rack/subscription","commits_url":"https://api.github.com/repos/Nyoho/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nyoho/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nyoho/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nyoho/rack/issues/comments/{number}","contents_url":"https://api.github.com/repos/Nyoho/rack/contents/{+path}","compare_url":"https://api.github.com/repos/Nyoho/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nyoho/rack/merges","archive_url":"https://api.github.com/repos/Nyoho/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nyoho/rack/downloads","issues_url":"https://api.github.com/repos/Nyoho/rack/issues{/number}","pulls_url":"https://api.github.com/repos/Nyoho/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/Nyoho/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/Nyoho/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nyoho/rack/labels{/name}","releases_url":"https://api.github.com/repos/Nyoho/rack/releases{/id}","created_at":"2015-01-07T06:05:02Z","updated_at":"2015-01-07T06:05:03Z","pushed_at":"2015-01-07T06:17:50Z","git_url":"git://github.com/Nyoho/rack.git","ssh_url":"git@github.com:Nyoho/rack.git","clone_url":"https://github.com/Nyoho/rack.git","svn_url":"https://github.com/Nyoho/rack","homepage":"http://rack.github.io/","size":5659,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rack:master","ref":"master","sha":"ed9050876dfa2418613db05fb52015dc97cb78fb","user":{"login":"rack","id":42379,"avatar_url":"https://avatars.githubusercontent.com/u/42379?v=3","gravatar_id":"","url":"https://api.github.com/users/rack","html_url":"https://github.com/rack","followers_url":"https://api.github.com/users/rack/followers","following_url":"https://api.github.com/users/rack/following{/other_user}","gists_url":"https://api.github.com/users/rack/gists{/gist_id}","starred_url":"https://api.github.com/users/rack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack/subscriptions","organizations_url":"https://api.github.com/users/rack/orgs","repos_url":"https://api.github.com/users/rack/repos","events_url":"https://api.github.com/users/rack/events{/privacy}","received_events_url":"https://api.github.com/users/rack/received_events","type":"Organization","site_admin":false},"repo":{"id":96071,"name":"rack","full_name":"rack/rack","owner":{"login":"rack","id":42379,"avatar_url":"https://avatars.githubusercontent.com/u/42379?v=3","gravatar_id":"","url":"https://api.github.com/users/rack","html_url":"https://github.com/rack","followers_url":"https://api.github.com/users/rack/followers","following_url":"https://api.github.com/users/rack/following{/other_user}","gists_url":"https://api.github.com/users/rack/gists{/gist_id}","starred_url":"https://api.github.com/users/rack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack/subscriptions","organizations_url":"https://api.github.com/users/rack/orgs","repos_url":"https://api.github.com/users/rack/repos","events_url":"https://api.github.com/users/rack/events{/privacy}","received_events_url":"https://api.github.com/users/rack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rack/rack","description":"a modular Ruby webserver interface","fork":false,"url":"https://api.github.com/repos/rack/rack","forks_url":"https://api.github.com/repos/rack/rack/forks","keys_url":"https://api.github.com/repos/rack/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rack/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rack/rack/teams","hooks_url":"https://api.github.com/repos/rack/rack/hooks","issue_events_url":"https://api.github.com/repos/rack/rack/issues/events{/number}","events_url":"https://api.github.com/repos/rack/rack/events","assignees_url":"https://api.github.com/repos/rack/rack/assignees{/user}","branches_url":"https://api.github.com/repos/rack/rack/branches{/branch}","tags_url":"https://api.github.com/repos/rack/rack/tags","blobs_url":"https://api.github.com/repos/rack/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rack/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rack/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rack/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rack/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/rack/rack/languages","stargazers_url":"https://api.github.com/repos/rack/rack/stargazers","contributors_url":"https://api.github.com/repos/rack/rack/contributors","subscribers_url":"https://api.github.com/repos/rack/rack/subscribers","subscription_url":"https://api.github.com/repos/rack/rack/subscription","commits_url":"https://api.github.com/repos/rack/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rack/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rack/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rack/rack/issues/comments/{number}","contents_url":"https://api.github.com/repos/rack/rack/contents/{+path}","compare_url":"https://api.github.com/repos/rack/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rack/rack/merges","archive_url":"https://api.github.com/repos/rack/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rack/rack/downloads","issues_url":"https://api.github.com/repos/rack/rack/issues{/number}","pulls_url":"https://api.github.com/repos/rack/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/rack/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/rack/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rack/rack/labels{/name}","releases_url":"https://api.github.com/repos/rack/rack/releases{/id}","created_at":"2008-12-24T03:03:12Z","updated_at":"2015-01-07T09:50:29Z","pushed_at":"2015-01-06T18:26:22Z","git_url":"git://github.com/rack/rack.git","ssh_url":"git@github.com:rack/rack.git","clone_url":"https://github.com/rack/rack.git","svn_url":"https://github.com/rack/rack","homepage":"http://rack.github.io/","size":5659,"stargazers_count":2131,"watchers_count":2131,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":837,"mirror_url":null,"open_issues_count":46,"forks":837,"open_issues":46,"watchers":2131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rack/rack/pulls/781"},"html":{"href":"https://github.com/rack/rack/pull/781"},"issue":{"href":"https://api.github.com/repos/rack/rack/issues/781"},"comments":{"href":"https://api.github.com/repos/rack/rack/issues/781/comments"},"review_comments":{"href":"https://api.github.com/repos/rack/rack/pulls/781/comments"},"review_comment":{"href":"https://api.github.com/repos/rack/rack/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rack/rack/pulls/781/commits"},"statuses":{"href":"https://api.github.com/repos/rack/rack/statuses/6af5f928f3a860e9bb74fc0bdd83b30be9d722a9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":10,"changed_files":2}}