{"action":"created","issue":{"url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/18","labels_url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/18/comments","events_url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/18/events","html_url":"https://github.com/datamade/municipal-scrapers-us/issues/18","id":101683719,"number":18,"title":"Data modeling help","user":{"login":"fgregg","id":536941,"avatar_url":"https://avatars.githubusercontent.com/u/536941?v=3","gravatar_id":"","url":"https://api.github.com/users/fgregg","html_url":"https://github.com/fgregg","followers_url":"https://api.github.com/users/fgregg/followers","following_url":"https://api.github.com/users/fgregg/following{/other_user}","gists_url":"https://api.github.com/users/fgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/fgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgregg/subscriptions","organizations_url":"https://api.github.com/users/fgregg/orgs","repos_url":"https://api.github.com/users/fgregg/repos","events_url":"https://api.github.com/users/fgregg/events{/privacy}","received_events_url":"https://api.github.com/users/fgregg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-18T15:29:54Z","updated_at":"2015-08-18T20:52:56Z","closed_at":null,"body":"Hi @davidmooreppf, the scraper does a fair amount of data modeling that could use your expertise. First, we classify legislation type:\r\n\r\nhttps://github.com/datamade/municipal-scrapers-us/blob/master/nyc/bills.py#L103-L112\r\n\r\nThe capitalized terms are the types as they appear in NYC legistar, the lower case terms are the types that are opencivicdata knows about: https://github.com/opencivicdata/python-opencivicdata-django/blob/master/opencivicdata/common.py#L71-L90\r\n\r\nFor many of the NYC legislative types, there does not appear to be a corresponding class in OCD. These are given the `None` type. @davidmooreppf can you see if this looks correct.\r\n\r\nSecond, we do the same thing with bill action types:\r\nhttps://github.com/datamade/municipal-scrapers-us/blob/master/nyc/bills.py#L115-L146\r\n\r\nThe bill actions that OCD knows about is here: https://github.com/opencivicdata/python-opencivicdata-django/blob/master/opencivicdata/common.py#L103-L128\r\n\r\nCan you check to see if these look right."},"comment":{"url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/comments/132347460","html_url":"https://github.com/datamade/municipal-scrapers-us/issues/18#issuecomment-132347460","issue_url":"https://api.github.com/repos/datamade/municipal-scrapers-us/issues/18","id":132347460,"user":{"login":"fgregg","id":536941,"avatar_url":"https://avatars.githubusercontent.com/u/536941?v=3","gravatar_id":"","url":"https://api.github.com/users/fgregg","html_url":"https://github.com/fgregg","followers_url":"https://api.github.com/users/fgregg/followers","following_url":"https://api.github.com/users/fgregg/following{/other_user}","gists_url":"https://api.github.com/users/fgregg/gists{/gist_id}","starred_url":"https://api.github.com/users/fgregg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgregg/subscriptions","organizations_url":"https://api.github.com/users/fgregg/orgs","repos_url":"https://api.github.com/users/fgregg/repos","events_url":"https://api.github.com/users/fgregg/events{/privacy}","received_events_url":"https://api.github.com/users/fgregg/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T20:52:55Z","updated_at":"2015-08-18T20:52:55Z","body":"Cool, and what about the action types?\n\nOn Tue, Aug 18, 2015 at 3:51 PM David Moore <notifications@github.com>\nwrote:\n\n> Just going through the 17 types in NYC Legistar, then, aiming for same\n> format - so the Legistar types are there, at least, to change or edit later\n> if an attorney suggests so - it's possible that some of these map to OCD\n> types and I just don't know about the technical language now - anyway:\n>\n> BILL_TYPES = {'City Agency Report': None,\n> 'Commissioner of Deeds': None,\n> 'Communication': None,\n> 'Introduction': 'bill',\n> 'Land Use Application': None,\n> 'Land Use Call-Up': None,\n> 'Local Law': None,\n> 'Local Laws 2014': None,\n> 'Local Laws 2015': None,\n> 'Mayor's Message': None,\n> 'Oversight': None,\n> 'Petition': None,\n> 'Resolution': 'resolution',\n> 'SLR': None,\n> 'Special Event': None,\n> 'Tour': None,\n> 'Town Hall Meeting': None}\n>\n> ... that covers the 17 existing types in current Legistar drop-down.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/datamade/municipal-scrapers-us/issues/18#issuecomment-132347216>\n> .\n>\n"}}