{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/finagle/issues/401","labels_url":"https://api.github.com/repos/twitter/finagle/issues/401/labels{/name}","comments_url":"https://api.github.com/repos/twitter/finagle/issues/401/comments","events_url":"https://api.github.com/repos/twitter/finagle/issues/401/events","html_url":"https://github.com/twitter/finagle/pull/401","id":96929040,"number":401,"title":"Server-side wire tracing.","user":{"login":"olix0r","id":240738,"avatar_url":"https://avatars.githubusercontent.com/u/240738?v=3","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/twitter/finagle/labels/Ship%20It","name":"Ship It","color":"4099FF"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-07-23T23:50:52Z","updated_at":"2015-10-19T23:30:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/finagle/pulls/401","html_url":"https://github.com/twitter/finagle/pull/401","diff_url":"https://github.com/twitter/finagle/pull/401.diff","patch_url":"https://github.com/twitter/finagle/pull/401.patch"},"body":"Problem:\r\n\r\nClients annotate WireSend and WireRecv at the bottom of the finagle\r\nstack.  There is no analog on the server-side (i.e. a top-of-the-stack\r\nindicator).\r\n\r\nFurthermore, it looks like WireTracingFilter.module was using the\r\nClientTracingFilter.role instead of WireTracingFilter.role. This may\r\ncause client tracing issues?\r\n\r\nSolution:\r\n\r\nIntroduce WireTracingFilter.serverModule at the top of the default\r\nserver stack.  This module installs a filter that annotates WireRecv\r\non receipt and WireSend on success.\r\n\r\nResult:\r\n\r\nTracers have a definitive 'top of stack' marker."},"comment":{"url":"https://api.github.com/repos/twitter/finagle/issues/comments/149376023","html_url":"https://github.com/twitter/finagle/pull/401#issuecomment-149376023","issue_url":"https://api.github.com/repos/twitter/finagle/issues/401","id":149376023,"user":{"login":"mosesn","id":156562,"avatar_url":"https://avatars.githubusercontent.com/u/156562?v=3","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"created_at":"2015-10-19T23:30:26Z","updated_at":"2015-10-19T23:30:26Z","body":"Hmm, many of our protocols are still sending responses over the wire when we see a failure though, right?  Like we still say ServerSend on the server side."}}