{"action":"created","issue":{"url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/57","labels_url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/57/comments","events_url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/57/events","html_url":"https://github.com/stevekane/promise-it-wont-hurt/pull/57","id":105733340,"number":57,"title":"Remove q entirely","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-10T05:16:54Z","updated_at":"2015-09-10T06:59:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/pulls/57","html_url":"https://github.com/stevekane/promise-it-wont-hurt/pull/57","diff_url":"https://github.com/stevekane/promise-it-wont-hurt/pull/57.diff","patch_url":"https://github.com/stevekane/promise-it-wont-hurt/pull/57.patch"},"body":"I started with the `no-q` branch (with commits from @TimothyGu and @tdd already in it) and went and finished up the de-q-ifying of the workshop.\r\n\r\nAlthough I think the version I'm submitting here is usable, I ran into some definite problems that other people will be able to improve or help me improve. The crux of my issue is this: I don't know French.\r\n\r\nThis meant that as I updated `problem.md` files, I was really only either removing obsolete text or else making very minor modifications, because otherwise I could not keep `problem.fr.md` synchronized with the English version.\r\n\r\nSo, this version of the workshop has the following shortcomings:\r\n\r\n* Inadequate description/explanation/exercise for `Promise.prototype.catch()` and `Promise.all()`\r\n* `setTimeout()` instructions for `multiple_promises` exercise isn't quite right. Solution doesn't do it as a single `setTimeout()`. It's two `setTimeouts()` now, one in each Promise constructor. Instructions should be changed to reflect current solution. (Or the solution could be changed, although how to make it work with native Promises following *all* of the instructions in the `problem.md` was not obvious to me.)\r\n* `fetch_json` problem now requires knowing a little something about the `http` module. And I didn't know how to say that in French, so it's not indicated in the instructions. Actually, this would be an awesome example for wrapping something like request in a promisify library or something like that. But again: French. So, you got the implementation that's there. Anyway, even though the instructions say the implementation is simple...it's not that simple. Certainly not as simple as the previous version. Just need a promises-based implementation/wrapper of `request` or something like that. But the obstacle here for me: I do not have the ability to include that in the French instructions.\r\n* `do_some_work` needs instructions updated to tell the user to start more or less with the previous exercise. Or maybe the `promisifiedHttpRequest` I wrote in the solution should be its own npm module that can be used in `fetch_json` and `do_some_work` to make it more like the original using `q-io`. Actually, there is all but certainly already a module like that. Just need to use it. And put it in the instructions. In two languages. One of which I don't know. Because I am a detestable monolingual dolt. (Actually, if it were Spanish, I'd take a crack at it. And probably mess it up. But I know enough to mess it up at least. Hey, look at me ramble about things that aren't really relevant. Time to move on.)\r\n\r\nIt would be great if someone could work through the workshop and keep a running list of notes about stuff that should be changed/improved/updated/expanded/tweaked. @bengl, I am looking in your direction.\r\n"},"comment":{"url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/comments/139133651","html_url":"https://github.com/stevekane/promise-it-wont-hurt/pull/57#issuecomment-139133651","issue_url":"https://api.github.com/repos/stevekane/promise-it-wont-hurt/issues/57","id":139133651,"user":{"login":"bengl","id":110455,"avatar_url":"https://avatars.githubusercontent.com/u/110455?v=3","gravatar_id":"","url":"https://api.github.com/users/bengl","html_url":"https://github.com/bengl","followers_url":"https://api.github.com/users/bengl/followers","following_url":"https://api.github.com/users/bengl/following{/other_user}","gists_url":"https://api.github.com/users/bengl/gists{/gist_id}","starred_url":"https://api.github.com/users/bengl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengl/subscriptions","organizations_url":"https://api.github.com/users/bengl/orgs","repos_url":"https://api.github.com/users/bengl/repos","events_url":"https://api.github.com/users/bengl/events{/privacy}","received_events_url":"https://api.github.com/users/bengl/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T06:59:12Z","updated_at":"2015-09-10T06:59:12Z","body":"My French isn't what it used to be, but I can certainly take a crack at it, with the crutches that are Google Translate and French Wikipedia. If you want to make further changes to the English `md` files in further commits, I'm happy to add French versions of the changes wherever I'm capable."}}