{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/30464645","id":30464645,"diff_hunk":"@@ -464,7 +464,11 @@ static void handle_request(Channel *channel, msgpack_object *request)\n   }\n \n   Array args = ARRAY_DICT_INIT;\n-  msgpack_rpc_to_array(msgpack_rpc_args(request), &args);\n+  if (!msgpack_rpc_to_array(msgpack_rpc_args(request), &args)) {\n+    handler.fn = msgpack_rpc_handle_invalid_arguments;","path":"src/nvim/msgpack_rpc/channel.c","position":6,"original_position":6,"commit_id":"f9ba489d0424d46c0e15f62b79181a27cb423a66","original_commit_id":"f9ba489d0424d46c0e15f62b79181a27cb423a66","user":{"login":"oni-link","id":2077655,"avatar_url":"https://avatars.githubusercontent.com/u/2077655?v=3","gravatar_id":"","url":"https://api.github.com/users/oni-link","html_url":"https://github.com/oni-link","followers_url":"https://api.github.com/users/oni-link/followers","following_url":"https://api.github.com/users/oni-link/following{/other_user}","gists_url":"https://api.github.com/users/oni-link/gists{/gist_id}","starred_url":"https://api.github.com/users/oni-link/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oni-link/subscriptions","organizations_url":"https://api.github.com/users/oni-link/orgs","repos_url":"https://api.github.com/users/oni-link/repos","events_url":"https://api.github.com/users/oni-link/events{/privacy}","received_events_url":"https://api.github.com/users/oni-link/received_events","type":"User","site_admin":false},"body":"Handler for missing method could be replaced by this. Has \"invalid arguments\" priority over \"missing methods\"?","created_at":"2015-05-16T20:59:14Z","updated_at":"2015-05-16T20:59:14Z","html_url":"https://github.com/neovim/neovim/pull/2664#discussion_r30464645","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/2664","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/30464645"},"html":{"href":"https://github.com/neovim/neovim/pull/2664#discussion_r30464645"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2664"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/2664","id":35523231,"html_url":"https://github.com/neovim/neovim/pull/2664","diff_url":"https://github.com/neovim/neovim/pull/2664.diff","patch_url":"https://github.com/neovim/neovim/pull/2664.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/2664","number":2664,"state":"open","locked":false,"title":"[RFC] msgpack-rpc: handle failure to convert method arguments","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"body":"The conversion from msgpack rpc objects to nvim api Objects might fail, but this error is ignored, so confusing errors might instead be reported in the generated wrapper functions. (but I don't think it could lead to a crash). \r\n\r\nI discovered this because I sent an invalid buffer object to `buffer_get_line`, but instead nvim complained on the second `Integer` parameter.","created_at":"2015-05-15T15:28:19Z","updated_at":"2015-05-16T20:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885e3b5e502c116ddf85179ffa1d4abf9f720a22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/2664/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/2664/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/2664/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/f9ba489d0424d46c0e15f62b79181a27cb423a66","head":{"label":"bfredl:invalidrpc","ref":"invalidrpc","sha":"f9ba489d0424d46c0e15f62b79181a27cb423a66","user":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"repo":{"id":21050434,"name":"neovim","full_name":"bfredl/neovim","owner":{"login":"bfredl","id":1363104,"avatar_url":"https://avatars.githubusercontent.com/u/1363104?v=3","gravatar_id":"","url":"https://api.github.com/users/bfredl","html_url":"https://github.com/bfredl","followers_url":"https://api.github.com/users/bfredl/followers","following_url":"https://api.github.com/users/bfredl/following{/other_user}","gists_url":"https://api.github.com/users/bfredl/gists{/gist_id}","starred_url":"https://api.github.com/users/bfredl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfredl/subscriptions","organizations_url":"https://api.github.com/users/bfredl/orgs","repos_url":"https://api.github.com/users/bfredl/repos","events_url":"https://api.github.com/users/bfredl/events{/privacy}","received_events_url":"https://api.github.com/users/bfredl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bfredl/neovim","description":"vim's rebirth for the 21st century","fork":true,"url":"https://api.github.com/repos/bfredl/neovim","forks_url":"https://api.github.com/repos/bfredl/neovim/forks","keys_url":"https://api.github.com/repos/bfredl/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bfredl/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bfredl/neovim/teams","hooks_url":"https://api.github.com/repos/bfredl/neovim/hooks","issue_events_url":"https://api.github.com/repos/bfredl/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/bfredl/neovim/events","assignees_url":"https://api.github.com/repos/bfredl/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/bfredl/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/bfredl/neovim/tags","blobs_url":"https://api.github.com/repos/bfredl/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bfredl/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bfredl/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bfredl/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bfredl/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/bfredl/neovim/languages","stargazers_url":"https://api.github.com/repos/bfredl/neovim/stargazers","contributors_url":"https://api.github.com/repos/bfredl/neovim/contributors","subscribers_url":"https://api.github.com/repos/bfredl/neovim/subscribers","subscription_url":"https://api.github.com/repos/bfredl/neovim/subscription","commits_url":"https://api.github.com/repos/bfredl/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bfredl/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bfredl/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bfredl/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bfredl/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/bfredl/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bfredl/neovim/merges","archive_url":"https://api.github.com/repos/bfredl/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bfredl/neovim/downloads","issues_url":"https://api.github.com/repos/bfredl/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/bfredl/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/bfredl/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/bfredl/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bfredl/neovim/labels{/name}","releases_url":"https://api.github.com/repos/bfredl/neovim/releases{/id}","created_at":"2014-06-20T19:51:31Z","updated_at":"2014-06-20T19:51:31Z","pushed_at":"2015-05-16T09:09:44Z","git_url":"git://github.com/bfredl/neovim.git","ssh_url":"git@github.com:bfredl/neovim.git","clone_url":"https://github.com/bfredl/neovim.git","svn_url":"https://github.com/bfredl/neovim","homepage":"http://neovim.org/","size":31704,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"6f72f56492c0948371c746356458c1693efa85a3","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"ambitious Vim-fork focused on extensibility and agility. Please consider helping sustain Neovim development! https://salt.bountysource.com/teams/neovim","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-05-16T20:46:22Z","pushed_at":"2015-05-16T20:56:26Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.io","size":74062,"stargazers_count":13345,"watchers_count":13345,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":912,"mirror_url":null,"open_issues_count":488,"forks":912,"open_issues":488,"watchers":13345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2664"},"html":{"href":"https://github.com/neovim/neovim/pull/2664"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/2664"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/2664/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2664/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/2664/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/f9ba489d0424d46c0e15f62b79181a27cb423a66"}}}}