{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34599116","id":34599116,"diff_hunk":"@@ -83,9 +83,13 @@ $ kubectl rolling-update update-demo-nautilus --update-period=10s -f examples/up\n The rolling-update command in kubectl will do 2 things:\n \n 1. Create a new [replication controller](../../docs/replication-controller.md) with a pod template that uses the new image (`gcr.io/google_containers/update-demo:kitten`)\n-2. Scale the old and new replication controllers until the new controller replaces the old. This will kill the current pods one at a time, spinnning up new ones to replace them.\n+2. Scale the old and new replication controllers until the new controller replaces the old. This will kill the current pods one at a time, spinning up new ones to replace them.\n \n Watch the [demo website](http://localhost:8001/static/index.html), it will update one pod every 10 seconds until all of the pods have the new image.\n+Note that the new replication controller definition does not include the replica count, so","path":"examples/update-demo/README.md","position":8,"original_position":8,"commit_id":"0d3aa63b035365c416bc1c48354b8149d6f33681","original_commit_id":"0d3aa63b035365c416bc1c48354b8149d6f33681","user":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"body":"I would suggest using a kubectl built from HEAD","created_at":"2015-07-14T18:04:28Z","updated_at":"2015-07-14T18:04:28Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219#discussion_r34599116","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/34599116"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219#discussion_r34599116"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219","id":39902740,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11219","number":11219,"state":"open","locked":false,"title":"clarify rolling update procedure when # replicas is not specified","user":{"login":"marekbiskup","id":11961560,"avatar_url":"https://avatars.githubusercontent.com/u/11961560?v=3","gravatar_id":"","url":"https://api.github.com/users/marekbiskup","html_url":"https://github.com/marekbiskup","followers_url":"https://api.github.com/users/marekbiskup/followers","following_url":"https://api.github.com/users/marekbiskup/following{/other_user}","gists_url":"https://api.github.com/users/marekbiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/marekbiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekbiskup/subscriptions","organizations_url":"https://api.github.com/users/marekbiskup/orgs","repos_url":"https://api.github.com/users/marekbiskup/repos","events_url":"https://api.github.com/users/marekbiskup/events{/privacy}","received_events_url":"https://api.github.com/users/marekbiskup/received_events","type":"User","site_admin":false},"body":"I found this behavior quite surprising, so I decided to document it.\r\n\r\ncc @bgrant0607 (maybe we want to change it and leave the replica count the same as before?)","created_at":"2015-07-14T10:38:11Z","updated_at":"2015-07-14T18:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a06bc37ee1dea0c7d719d7b40b75153c7f6bc25e","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11219/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/0d3aa63b035365c416bc1c48354b8149d6f33681","head":{"label":"marekbiskup:clarify-rolling-update-procedure","ref":"clarify-rolling-update-procedure","sha":"0d3aa63b035365c416bc1c48354b8149d6f33681","user":{"login":"marekbiskup","id":11961560,"avatar_url":"https://avatars.githubusercontent.com/u/11961560?v=3","gravatar_id":"","url":"https://api.github.com/users/marekbiskup","html_url":"https://github.com/marekbiskup","followers_url":"https://api.github.com/users/marekbiskup/followers","following_url":"https://api.github.com/users/marekbiskup/following{/other_user}","gists_url":"https://api.github.com/users/marekbiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/marekbiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekbiskup/subscriptions","organizations_url":"https://api.github.com/users/marekbiskup/orgs","repos_url":"https://api.github.com/users/marekbiskup/repos","events_url":"https://api.github.com/users/marekbiskup/events{/privacy}","received_events_url":"https://api.github.com/users/marekbiskup/received_events","type":"User","site_admin":false},"repo":{"id":33994952,"name":"kubernetes","full_name":"marekbiskup/kubernetes","owner":{"login":"marekbiskup","id":11961560,"avatar_url":"https://avatars.githubusercontent.com/u/11961560?v=3","gravatar_id":"","url":"https://api.github.com/users/marekbiskup","html_url":"https://github.com/marekbiskup","followers_url":"https://api.github.com/users/marekbiskup/followers","following_url":"https://api.github.com/users/marekbiskup/following{/other_user}","gists_url":"https://api.github.com/users/marekbiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/marekbiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekbiskup/subscriptions","organizations_url":"https://api.github.com/users/marekbiskup/orgs","repos_url":"https://api.github.com/users/marekbiskup/repos","events_url":"https://api.github.com/users/marekbiskup/events{/privacy}","received_events_url":"https://api.github.com/users/marekbiskup/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marekbiskup/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/marekbiskup/kubernetes","forks_url":"https://api.github.com/repos/marekbiskup/kubernetes/forks","keys_url":"https://api.github.com/repos/marekbiskup/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marekbiskup/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marekbiskup/kubernetes/teams","hooks_url":"https://api.github.com/repos/marekbiskup/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/marekbiskup/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/marekbiskup/kubernetes/events","assignees_url":"https://api.github.com/repos/marekbiskup/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/marekbiskup/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/marekbiskup/kubernetes/tags","blobs_url":"https://api.github.com/repos/marekbiskup/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marekbiskup/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marekbiskup/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/marekbiskup/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marekbiskup/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/marekbiskup/kubernetes/languages","stargazers_url":"https://api.github.com/repos/marekbiskup/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/marekbiskup/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/marekbiskup/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/marekbiskup/kubernetes/subscription","commits_url":"https://api.github.com/repos/marekbiskup/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/marekbiskup/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/marekbiskup/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/marekbiskup/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/marekbiskup/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/marekbiskup/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marekbiskup/kubernetes/merges","archive_url":"https://api.github.com/repos/marekbiskup/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marekbiskup/kubernetes/downloads","issues_url":"https://api.github.com/repos/marekbiskup/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/marekbiskup/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/marekbiskup/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/marekbiskup/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marekbiskup/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/marekbiskup/kubernetes/releases{/id}","created_at":"2015-04-15T13:19:46Z","updated_at":"2015-04-15T13:19:50Z","pushed_at":"2015-07-14T10:36:35Z","git_url":"git://github.com/marekbiskup/kubernetes.git","ssh_url":"git@github.com:marekbiskup/kubernetes.git","clone_url":"https://github.com/marekbiskup/kubernetes.git","svn_url":"https://github.com/marekbiskup/kubernetes","homepage":"http://kubernetes.io","size":90427,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"c6161824db3784e6156131307a5e94647e5557fd","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-07-14T15:57:20Z","pushed_at":"2015-07-14T17:51:25Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":314252,"stargazers_count":8906,"watchers_count":8906,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2017,"mirror_url":null,"open_issues_count":1600,"forks":2017,"open_issues":1600,"watchers":8906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/11219"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11219"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/11219/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/11219/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/0d3aa63b035365c416bc1c48354b8149d6f33681"}}}}