{"action":"opened","number":1146,"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/1146","id":30433551,"html_url":"https://github.com/keystonejs/keystone/pull/1146","diff_url":"https://github.com/keystonejs/keystone/pull/1146.diff","patch_url":"https://github.com/keystonejs/keystone/pull/1146.patch","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/1146","number":1146,"state":"open","locked":false,"title":"Markdown respects height config","user":{"login":"tivac","id":49545,"avatar_url":"https://avatars.githubusercontent.com/u/49545?v=3","gravatar_id":"","url":"https://api.github.com/users/tivac","html_url":"https://github.com/tivac","followers_url":"https://api.github.com/users/tivac/followers","following_url":"https://api.github.com/users/tivac/following{/other_user}","gists_url":"https://api.github.com/users/tivac/gists{/gist_id}","starred_url":"https://api.github.com/users/tivac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tivac/subscriptions","organizations_url":"https://api.github.com/users/tivac/orgs","repos_url":"https://api.github.com/users/tivac/repos","events_url":"https://api.github.com/users/tivac/events{/privacy}","received_events_url":"https://api.github.com/users/tivac/received_events","type":"User","site_admin":false},"body":"Told markdown it should respect the `height` option that was already being managed on the server but not sent to the client. Then passed it through to the markdown editor so it'd respect it.\r\n\r\nAlso taught markdown fields how not to be `wysiwyg` but kept existing behavior of defaulting to `wysiwyg`. Doing this required slightly more work than a usual option (because of backcompat & falsiness) but isn't super-scary or anything. Height is also maintained when `wysiwyg` is disabled.\r\n\r\nAlso sending `toolbarOptions` down to the client. It was in the docs but as far as I can tell it wasn't plumbed through in the React component for markdown fields. Only supporting `toolbarOptions.hiddenButtons` for now since that is all that is in the docs.\r\n\r\nMarkdownField.js has no client tests, so I haven't written any.","created_at":"2015-03-04T02:32:37Z","updated_at":"2015-03-04T02:32:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/keystonejs/keystone/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/keystonejs/keystone/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/1146/comments","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/6c909ef8718c444066f6b6bc9f9b0a33dba1606c","head":{"label":"tivac:markdown-respect-height","ref":"markdown-respect-height","sha":"6c909ef8718c444066f6b6bc9f9b0a33dba1606c","user":{"login":"tivac","id":49545,"avatar_url":"https://avatars.githubusercontent.com/u/49545?v=3","gravatar_id":"","url":"https://api.github.com/users/tivac","html_url":"https://github.com/tivac","followers_url":"https://api.github.com/users/tivac/followers","following_url":"https://api.github.com/users/tivac/following{/other_user}","gists_url":"https://api.github.com/users/tivac/gists{/gist_id}","starred_url":"https://api.github.com/users/tivac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tivac/subscriptions","organizations_url":"https://api.github.com/users/tivac/orgs","repos_url":"https://api.github.com/users/tivac/repos","events_url":"https://api.github.com/users/tivac/events{/privacy}","received_events_url":"https://api.github.com/users/tivac/received_events","type":"User","site_admin":false},"repo":{"id":31621846,"name":"keystone","full_name":"tivac/keystone","owner":{"login":"tivac","id":49545,"avatar_url":"https://avatars.githubusercontent.com/u/49545?v=3","gravatar_id":"","url":"https://api.github.com/users/tivac","html_url":"https://github.com/tivac","followers_url":"https://api.github.com/users/tivac/followers","following_url":"https://api.github.com/users/tivac/following{/other_user}","gists_url":"https://api.github.com/users/tivac/gists{/gist_id}","starred_url":"https://api.github.com/users/tivac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tivac/subscriptions","organizations_url":"https://api.github.com/users/tivac/orgs","repos_url":"https://api.github.com/users/tivac/repos","events_url":"https://api.github.com/users/tivac/events{/privacy}","received_events_url":"https://api.github.com/users/tivac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tivac/keystone","description":"node.js cms and web app framework","fork":true,"url":"https://api.github.com/repos/tivac/keystone","forks_url":"https://api.github.com/repos/tivac/keystone/forks","keys_url":"https://api.github.com/repos/tivac/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tivac/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tivac/keystone/teams","hooks_url":"https://api.github.com/repos/tivac/keystone/hooks","issue_events_url":"https://api.github.com/repos/tivac/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/tivac/keystone/events","assignees_url":"https://api.github.com/repos/tivac/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/tivac/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/tivac/keystone/tags","blobs_url":"https://api.github.com/repos/tivac/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tivac/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tivac/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/tivac/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tivac/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/tivac/keystone/languages","stargazers_url":"https://api.github.com/repos/tivac/keystone/stargazers","contributors_url":"https://api.github.com/repos/tivac/keystone/contributors","subscribers_url":"https://api.github.com/repos/tivac/keystone/subscribers","subscription_url":"https://api.github.com/repos/tivac/keystone/subscription","commits_url":"https://api.github.com/repos/tivac/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/tivac/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/tivac/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/tivac/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/tivac/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/tivac/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tivac/keystone/merges","archive_url":"https://api.github.com/repos/tivac/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tivac/keystone/downloads","issues_url":"https://api.github.com/repos/tivac/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/tivac/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/tivac/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/tivac/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tivac/keystone/labels{/name}","releases_url":"https://api.github.com/repos/tivac/keystone/releases{/id}","created_at":"2015-03-03T21:18:34Z","updated_at":"2015-03-04T01:49:38Z","pushed_at":"2015-03-04T02:29:55Z","git_url":"git://github.com/tivac/keystone.git","ssh_url":"git@github.com:tivac/keystone.git","clone_url":"https://github.com/tivac/keystone.git","svn_url":"https://github.com/tivac/keystone","homepage":"http://www.keystonejs.com","size":20753,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keystonejs:master","ref":"master","sha":"4ffc0676cac02f21203faa65bad05071661f3355","user":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"avatar_url":"https://avatars.githubusercontent.com/u/6118534?v=3","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"node.js cms and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","created_at":"2013-07-02T05:01:55Z","updated_at":"2015-03-04T01:43:56Z","pushed_at":"2015-03-04T01:43:55Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":20753,"stargazers_count":2759,"watchers_count":2759,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":468,"mirror_url":null,"open_issues_count":313,"forks":468,"open_issues":313,"watchers":2759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/1146"},"html":{"href":"https://github.com/keystonejs/keystone/pull/1146"},"issue":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/1146"},"comments":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/keystonejs/keystone/statuses/6c909ef8718c444066f6b6bc9f9b0a33dba1606c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":3,"changed_files":2}}