{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/17071","labels_url":"https://api.github.com/repos/owncloud/core/issues/17071/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/17071/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/17071/events","html_url":"https://github.com/owncloud/core/pull/17071","id":90066319,"number":17071,"title":"fix getUsersSharingFile with locking","user":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/3%20-%20To%20Review","name":"3 - To Review","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/31","html_url":"https://github.com/owncloud/core/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/core/milestones/31/labels","id":912160,"number":31,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":1519,"state":"open","created_at":"2014-12-22T12:04:01Z","updated_at":"2015-06-26T14:05:10Z","due_on":"2015-07-07T04:00:00Z","closed_at":null},"comments":19,"created_at":"2015-06-22T10:43:22Z","updated_at":"2015-06-26T15:10:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/17071","html_url":"https://github.com/owncloud/core/pull/17071","diff_url":"https://github.com/owncloud/core/pull/17071.diff","patch_url":"https://github.com/owncloud/core/pull/17071.patch"},"body":"Possible fix for #17029 \r\n\r\nI still can reproduce 17029 myself...\r\n\r\n@nickvergessen @PVince81 please test"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/115722104","html_url":"https://github.com/owncloud/core/pull/17071#issuecomment-115722104","issue_url":"https://api.github.com/repos/owncloud/core/issues/17071","id":115722104,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2015-06-26T15:10:06Z","updated_at":"2015-06-26T15:10:06Z","body":"No stray keys after run 1.\r\n\r\n- Run 2: on master: fail\r\n\r\nBut no stray keys now. (note: in my previous test runs I got the \"Connection Closed\" error, maybe that left stray keys)\r\n\r\n- Run 3: on this PR: fails now `('Connection aborted.', BadStatusLine(\"''\",)) `\r\n\r\nThere are 4 stray keys in redis, I leave them there.\r\nRestart apache2.\r\n\r\n- Run 4: on this PR: fail\r\n\r\nNow I remove the stray keys with `flushall`\r\n\r\n- Run 5: on this PR: success\r\n\r\n@nickvergessen can you make sure that there are no stray keys in your redis before you run the test ?\r\nI remember you mentionned having the \"BadStatusLine\" error a few times. That one would leak keys that then influence the outcome of subsequent tests.\r\n\r\nAnd I think this is the explanation for the randomness.\r\n\r\n@nickvergessen did you see any \"BadStatusLine\" failures in your most recent loop test ? If possible, would be good to see if keys were leaked between runs."}}