{"action":"created","comment":{"url":"https://api.github.com/repos/typesafehub/config/pulls/comments/27265045","id":27265045,"diff_hunk":"@@ -197,7 +211,7 @@ private ConfigException parseError(String message) {\n         }\n \n         private ConfigException parseError(String message, Throwable cause) {\n-            return new ConfigException.Parse(SimpleConfigOrigin.newSimple(\"\"), message, cause);\n+            return new ConfigException.Parse(SimpleConfigOrigin.newSimple(\"\").withLineNumber(lineNumber), message, cause);","path":"config/src/main/java/com/typesafe/config/impl/ConfigDocumentParser.java","position":64,"original_position":64,"commit_id":"368ad614f851a997a845b578091d099d1fc98192","original_commit_id":"368ad614f851a997a845b578091d099d1fc98192","user":{"login":"havocp","id":218689,"avatar_url":"https://avatars.githubusercontent.com/u/218689?v=3","gravatar_id":"","url":"https://api.github.com/users/havocp","html_url":"https://github.com/havocp","followers_url":"https://api.github.com/users/havocp/followers","following_url":"https://api.github.com/users/havocp/following{/other_user}","gists_url":"https://api.github.com/users/havocp/gists{/gist_id}","starred_url":"https://api.github.com/users/havocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/havocp/subscriptions","organizations_url":"https://api.github.com/users/havocp/orgs","repos_url":"https://api.github.com/users/havocp/repos","events_url":"https://api.github.com/users/havocp/events{/privacy}","received_events_url":"https://api.github.com/users/havocp/received_events","type":"User","site_admin":false},"body":"the old parser has a `baseOrigin` passed in, rather than making up this `newSimple(\"\")` origin - I would think ConfigDocumentParser.parse should take an origin too? then you don't have to make one up here. If the `newSimple(\"\")` origin escapes into public API, then we probably need a test that it doesn't... we shouldn't ever be returning an empty/useless origin like that.","created_at":"2015-03-26T23:08:17Z","updated_at":"2015-03-26T23:08:17Z","html_url":"https://github.com/typesafehub/config/pull/287#discussion_r27265045","pull_request_url":"https://api.github.com/repos/typesafehub/config/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/typesafehub/config/pulls/comments/27265045"},"html":{"href":"https://github.com/typesafehub/config/pull/287#discussion_r27265045"},"pull_request":{"href":"https://api.github.com/repos/typesafehub/config/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/typesafehub/config/pulls/287","id":32067740,"html_url":"https://github.com/typesafehub/config/pull/287","diff_url":"https://github.com/typesafehub/config/pull/287.diff","patch_url":"https://github.com/typesafehub/config/pull/287.patch","issue_url":"https://api.github.com/repos/typesafehub/config/issues/287","number":287,"state":"open","locked":false,"title":"Refactor Parser","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"body":"This PR refactors the Parser to parse Config Nodes rather than Tokens. It also contains some fixes for bugs found in the ConfigDocumentParser while performing the refactoring.","created_at":"2015-03-26T22:27:18Z","updated_at":"2015-03-26T23:08:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6804aa96a37f75d06559df8b01d3d63a63d6ce1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/typesafehub/config/pulls/287/commits","review_comments_url":"https://api.github.com/repos/typesafehub/config/pulls/287/comments","review_comment_url":"https://api.github.com/repos/typesafehub/config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typesafehub/config/issues/287/comments","statuses_url":"https://api.github.com/repos/typesafehub/config/statuses/368ad614f851a997a845b578091d099d1fc98192","head":{"label":"fpringvaldsen:task/integrate-ConfigDocument","ref":"task/integrate-ConfigDocument","sha":"368ad614f851a997a845b578091d099d1fc98192","user":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"repo":{"id":31284302,"name":"config","full_name":"fpringvaldsen/config","owner":{"login":"fpringvaldsen","id":5620801,"avatar_url":"https://avatars.githubusercontent.com/u/5620801?v=3","gravatar_id":"","url":"https://api.github.com/users/fpringvaldsen","html_url":"https://github.com/fpringvaldsen","followers_url":"https://api.github.com/users/fpringvaldsen/followers","following_url":"https://api.github.com/users/fpringvaldsen/following{/other_user}","gists_url":"https://api.github.com/users/fpringvaldsen/gists{/gist_id}","starred_url":"https://api.github.com/users/fpringvaldsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpringvaldsen/subscriptions","organizations_url":"https://api.github.com/users/fpringvaldsen/orgs","repos_url":"https://api.github.com/users/fpringvaldsen/repos","events_url":"https://api.github.com/users/fpringvaldsen/events{/privacy}","received_events_url":"https://api.github.com/users/fpringvaldsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fpringvaldsen/config","description":"Configuration library for JVM languages","fork":true,"url":"https://api.github.com/repos/fpringvaldsen/config","forks_url":"https://api.github.com/repos/fpringvaldsen/config/forks","keys_url":"https://api.github.com/repos/fpringvaldsen/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fpringvaldsen/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fpringvaldsen/config/teams","hooks_url":"https://api.github.com/repos/fpringvaldsen/config/hooks","issue_events_url":"https://api.github.com/repos/fpringvaldsen/config/issues/events{/number}","events_url":"https://api.github.com/repos/fpringvaldsen/config/events","assignees_url":"https://api.github.com/repos/fpringvaldsen/config/assignees{/user}","branches_url":"https://api.github.com/repos/fpringvaldsen/config/branches{/branch}","tags_url":"https://api.github.com/repos/fpringvaldsen/config/tags","blobs_url":"https://api.github.com/repos/fpringvaldsen/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fpringvaldsen/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fpringvaldsen/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/fpringvaldsen/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fpringvaldsen/config/statuses/{sha}","languages_url":"https://api.github.com/repos/fpringvaldsen/config/languages","stargazers_url":"https://api.github.com/repos/fpringvaldsen/config/stargazers","contributors_url":"https://api.github.com/repos/fpringvaldsen/config/contributors","subscribers_url":"https://api.github.com/repos/fpringvaldsen/config/subscribers","subscription_url":"https://api.github.com/repos/fpringvaldsen/config/subscription","commits_url":"https://api.github.com/repos/fpringvaldsen/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/fpringvaldsen/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/fpringvaldsen/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/fpringvaldsen/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/fpringvaldsen/config/contents/{+path}","compare_url":"https://api.github.com/repos/fpringvaldsen/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fpringvaldsen/config/merges","archive_url":"https://api.github.com/repos/fpringvaldsen/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fpringvaldsen/config/downloads","issues_url":"https://api.github.com/repos/fpringvaldsen/config/issues{/number}","pulls_url":"https://api.github.com/repos/fpringvaldsen/config/pulls{/number}","milestones_url":"https://api.github.com/repos/fpringvaldsen/config/milestones{/number}","notifications_url":"https://api.github.com/repos/fpringvaldsen/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fpringvaldsen/config/labels{/name}","releases_url":"https://api.github.com/repos/fpringvaldsen/config/releases{/id}","created_at":"2015-02-24T22:03:27Z","updated_at":"2015-03-24T20:11:30Z","pushed_at":"2015-03-26T22:26:31Z","git_url":"git://github.com/fpringvaldsen/config.git","ssh_url":"git@github.com:fpringvaldsen/config.git","clone_url":"https://github.com/fpringvaldsen/config.git","svn_url":"https://github.com/fpringvaldsen/config","homepage":"http://typesafe.com","size":4240,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typesafehub:master","ref":"master","sha":"a3c255e50ab48a225c7e87268f2aa0c1fc3601df","user":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"repo":{"id":2923236,"name":"config","full_name":"typesafehub/config","owner":{"login":"typesafehub","id":784923,"avatar_url":"https://avatars.githubusercontent.com/u/784923?v=3","gravatar_id":"","url":"https://api.github.com/users/typesafehub","html_url":"https://github.com/typesafehub","followers_url":"https://api.github.com/users/typesafehub/followers","following_url":"https://api.github.com/users/typesafehub/following{/other_user}","gists_url":"https://api.github.com/users/typesafehub/gists{/gist_id}","starred_url":"https://api.github.com/users/typesafehub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typesafehub/subscriptions","organizations_url":"https://api.github.com/users/typesafehub/orgs","repos_url":"https://api.github.com/users/typesafehub/repos","events_url":"https://api.github.com/users/typesafehub/events{/privacy}","received_events_url":"https://api.github.com/users/typesafehub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typesafehub/config","description":"Configuration library for JVM languages","fork":false,"url":"https://api.github.com/repos/typesafehub/config","forks_url":"https://api.github.com/repos/typesafehub/config/forks","keys_url":"https://api.github.com/repos/typesafehub/config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typesafehub/config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typesafehub/config/teams","hooks_url":"https://api.github.com/repos/typesafehub/config/hooks","issue_events_url":"https://api.github.com/repos/typesafehub/config/issues/events{/number}","events_url":"https://api.github.com/repos/typesafehub/config/events","assignees_url":"https://api.github.com/repos/typesafehub/config/assignees{/user}","branches_url":"https://api.github.com/repos/typesafehub/config/branches{/branch}","tags_url":"https://api.github.com/repos/typesafehub/config/tags","blobs_url":"https://api.github.com/repos/typesafehub/config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typesafehub/config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typesafehub/config/git/refs{/sha}","trees_url":"https://api.github.com/repos/typesafehub/config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typesafehub/config/statuses/{sha}","languages_url":"https://api.github.com/repos/typesafehub/config/languages","stargazers_url":"https://api.github.com/repos/typesafehub/config/stargazers","contributors_url":"https://api.github.com/repos/typesafehub/config/contributors","subscribers_url":"https://api.github.com/repos/typesafehub/config/subscribers","subscription_url":"https://api.github.com/repos/typesafehub/config/subscription","commits_url":"https://api.github.com/repos/typesafehub/config/commits{/sha}","git_commits_url":"https://api.github.com/repos/typesafehub/config/git/commits{/sha}","comments_url":"https://api.github.com/repos/typesafehub/config/comments{/number}","issue_comment_url":"https://api.github.com/repos/typesafehub/config/issues/comments{/number}","contents_url":"https://api.github.com/repos/typesafehub/config/contents/{+path}","compare_url":"https://api.github.com/repos/typesafehub/config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typesafehub/config/merges","archive_url":"https://api.github.com/repos/typesafehub/config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typesafehub/config/downloads","issues_url":"https://api.github.com/repos/typesafehub/config/issues{/number}","pulls_url":"https://api.github.com/repos/typesafehub/config/pulls{/number}","milestones_url":"https://api.github.com/repos/typesafehub/config/milestones{/number}","notifications_url":"https://api.github.com/repos/typesafehub/config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typesafehub/config/labels{/name}","releases_url":"https://api.github.com/repos/typesafehub/config/releases{/id}","created_at":"2011-12-06T08:02:29Z","updated_at":"2015-03-26T18:37:30Z","pushed_at":"2015-03-26T22:27:18Z","git_url":"git://github.com/typesafehub/config.git","ssh_url":"git@github.com:typesafehub/config.git","clone_url":"https://github.com/typesafehub/config.git","svn_url":"https://github.com/typesafehub/config","homepage":"http://typesafe.com","size":6687,"stargazers_count":1177,"watchers_count":1177,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":44,"forks":178,"open_issues":44,"watchers":1177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typesafehub/config/pulls/287"},"html":{"href":"https://github.com/typesafehub/config/pull/287"},"issue":{"href":"https://api.github.com/repos/typesafehub/config/issues/287"},"comments":{"href":"https://api.github.com/repos/typesafehub/config/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/typesafehub/config/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/typesafehub/config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typesafehub/config/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/typesafehub/config/statuses/368ad614f851a997a845b578091d099d1fc98192"}}}}