{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/43236912","id":43236912,"diff_hunk":"@@ -86,18 +86,39 @@ define(\n \t * Init submit action\n \t */\n \tfunction initSubmit() {\n-\t\t$('#editform').submit(function(e) {\n-\t\t\tvar hiddenInput = ace.getInput().val(ace.getContent());\n+\t\t$('#editform').submit(function (e) {\n+\t\t\tvar hiddenInput = ace.getInput().val(ace.getContent()),\n+\t\t\t\t$editForm = $(this);\n \n \t\t\tdisableBeforeUnload = true;\n \n-\t\t\t$(this).unbind('submit').append(hiddenInput).submit();\n-\n \t\t\te.preventDefault();\n+\n+\t\t\t/* Allow TemplateClassification extension to break submit */\n+\t\t\tif (win.enableTemplateClassificationEditorPlugin === true) {\n+\t\t\t\trequire(['TemplateClassificationModalForce'], function forceTemplateClassificationModal(tcForce) {\n+\t\t\t\t\tif (tcForce.forceType() === true) {\n+\t\t\t\t\t\treturn;\n+\t\t\t\t\t} else {\n+\t\t\t\t\t\tfinishSubmit($editForm, hiddenInput);\n+\t\t\t\t\t}\n+\t\t\t\t});\n+\t\t\t} else {\n+\t\t\t\tfinishSubmit($editForm, hiddenInput);\n+\t\t\t}\n \t\t});\n \t}\n \n \t/**\n+\t * Submit form with hidden field\n+\t * @param {jQuery} $editForm\n+\t * @param {jQuery} hiddenInput\n+\t */\n+\tfunction finishSubmit($editForm, hiddenInput) {\n+\t\t$editForm.unbind('submit').append(hiddenInput).submit();","path":"extensions/wikia/EditPageLayout/js/editor/AceEditor.js","position":37,"original_position":37,"commit_id":"73883fca0c85a7ace80b1ad8e305520c345b2918","original_commit_id":"73883fca0c85a7ace80b1ad8e305520c345b2918","user":{"login":"bkoval","id":2035428,"avatar_url":"https://avatars.githubusercontent.com/u/2035428?v=3","gravatar_id":"","url":"https://api.github.com/users/bkoval","html_url":"https://github.com/bkoval","followers_url":"https://api.github.com/users/bkoval/followers","following_url":"https://api.github.com/users/bkoval/following{/other_user}","gists_url":"https://api.github.com/users/bkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/bkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkoval/subscriptions","organizations_url":"https://api.github.com/users/bkoval/orgs","repos_url":"https://api.github.com/users/bkoval/repos","events_url":"https://api.github.com/users/bkoval/events{/privacy}","received_events_url":"https://api.github.com/users/bkoval/received_events","type":"User","site_admin":false},"body":"If hiddenInput is a jQuery object, I would consider adding a \"$\" sign before it's name, by convention, as you do with editForm.","created_at":"2015-10-28T10:16:06Z","updated_at":"2015-10-28T10:16:06Z","html_url":"https://github.com/Wikia/app/pull/8901#discussion_r43236912","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8901","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/43236912"},"html":{"href":"https://github.com/Wikia/app/pull/8901#discussion_r43236912"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8901"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8901","id":48874765,"html_url":"https://github.com/Wikia/app/pull/8901","diff_url":"https://github.com/Wikia/app/pull/8901.diff","patch_url":"https://github.com/Wikia/app/pull/8901.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8901","number":8901,"state":"open","locked":false,"title":"Ce 2894 modal labeling","user":{"login":"kamilkoterba","id":2316139,"avatar_url":"https://avatars.githubusercontent.com/u/2316139?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilkoterba","html_url":"https://github.com/kamilkoterba","followers_url":"https://api.github.com/users/kamilkoterba/followers","following_url":"https://api.github.com/users/kamilkoterba/following{/other_user}","gists_url":"https://api.github.com/users/kamilkoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilkoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilkoterba/subscriptions","organizations_url":"https://api.github.com/users/kamilkoterba/orgs","repos_url":"https://api.github.com/users/kamilkoterba/repos","events_url":"https://api.github.com/users/kamilkoterba/events{/privacy}","received_events_url":"https://api.github.com/users/kamilkoterba/received_events","type":"User","site_admin":false},"body":"**DO NOT MEGRE BEFORE https://github.com/Wikia/app/pull/8805**\r\n[Compare with parent branch](https://github.com/Wikia/app/compare/CE-2834...CE-2894-modal-labeling)\r\n\r\nAdded TemplateClassificationLabeling extension that provides buttons, titles and subtitles for modal depending on context.\r\n\r\nAdded support for force modal on publish in ACE editor.\r\n\r\nhttps://wikia-inc.atlassian.net/browse/CE-2894\r\n\r\n@Wikia/community-engineering ","created_at":"2015-10-27T14:06:56Z","updated_at":"2015-10-28T10:16:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0be1059dd0fd7b7c28f485a2ca8babc00c153af3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8901/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8901/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8901/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/73883fca0c85a7ace80b1ad8e305520c345b2918","head":{"label":"Wikia:CE-2894-modal-labeling","ref":"CE-2894-modal-labeling","sha":"73883fca0c85a7ace80b1ad8e305520c345b2918","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-10-28T06:31:02Z","pushed_at":"2015-10-28T10:04:27Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1685416,"stargazers_count":92,"watchers_count":92,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":68,"forks":70,"open_issues":68,"watchers":92,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"4dac987d6de5c4792e332a66f869b7317bf128d5","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-10-28T06:31:02Z","pushed_at":"2015-10-28T10:04:27Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1685416,"stargazers_count":92,"watchers_count":92,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":68,"forks":70,"open_issues":68,"watchers":92,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8901"},"html":{"href":"https://github.com/Wikia/app/pull/8901"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8901"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8901/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8901/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8901/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/73883fca0c85a7ace80b1ad8e305520c345b2918"}}}}