{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/32461596","id":32461596,"diff_hunk":"@@ -1,10 +1,12 @@\n var assert = require('assert');\n-var debug = require('debug')('strong-pm:test');\n var path = require('path');\n var util = require('util');\n \n require('shelljs/global');\n \n+// XXX should be a way to ignore specific shelljs globals","path":"test/helper.js","position":8,"original_position":8,"commit_id":"909164472327c14d7f15b7623cf9f686f7160077","original_commit_id":"3a199f55b61ffad919ca3d6ec5ee7698dd44de76","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"But note that what I really want is to get this onto master ASAP, so linting always happens on test, and this doesn't happen by accident: https://github.com/strongloop/strong-pm/blame/3bafbe266c800bec7c1203570bcfcd081615fec4/test/test-service-manager.js#L12-L13\r\n\r\n(fixed in this branch)","created_at":"2015-06-15T20:16:14Z","updated_at":"2015-06-15T20:16:14Z","html_url":"https://github.com/strongloop/strong-pm/pull/239#discussion_r32461596","pull_request_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments/32461596"},"html":{"href":"https://github.com/strongloop/strong-pm/pull/239#discussion_r32461596"},"pull_request":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-pm/pulls/239","id":37507783,"html_url":"https://github.com/strongloop/strong-pm/pull/239","diff_url":"https://github.com/strongloop/strong-pm/pull/239.diff","patch_url":"https://github.com/strongloop/strong-pm/pull/239.patch","issue_url":"https://api.github.com/repos/strongloop/strong-pm/issues/239","number":239,"state":"open","locked":false,"title":"test: passing eslint","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-11T20:57:07Z","updated_at":"2015-06-15T20:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187076d30abcd02481a70a32476c48dba69b3a62","assignee":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/239/commits","review_comments_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/239/comments","review_comment_url":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/issues/239/comments","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/909164472327c14d7f15b7623cf9f686f7160077","head":{"label":"strongloop:lint-tests","ref":"lint-tests","sha":"909164472327c14d7f15b7623cf9f686f7160077","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20460946,"name":"strong-pm","full_name":"strongloop/strong-pm","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-pm","description":"deployer for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-pm","forks_url":"https://api.github.com/repos/strongloop/strong-pm/forks","keys_url":"https://api.github.com/repos/strongloop/strong-pm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-pm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-pm/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-pm/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-pm/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-pm/events","assignees_url":"https://api.github.com/repos/strongloop/strong-pm/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-pm/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-pm/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-pm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-pm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-pm/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-pm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-pm/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-pm/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-pm/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-pm/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-pm/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-pm/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-pm/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-pm/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-pm/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-pm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-pm/merges","archive_url":"https://api.github.com/repos/strongloop/strong-pm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-pm/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-pm/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-pm/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-pm/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-pm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-pm/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-pm/releases{/id}","created_at":"2014-06-03T21:48:54Z","updated_at":"2015-06-12T11:30:54Z","pushed_at":"2015-06-15T20:12:48Z","git_url":"git://github.com/strongloop/strong-pm.git","ssh_url":"git@github.com:strongloop/strong-pm.git","clone_url":"https://github.com/strongloop/strong-pm.git","svn_url":"https://github.com/strongloop/strong-pm","homepage":"http://strong-pm.io","size":4516,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":33,"forks":13,"open_issues":33,"watchers":112,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"9874f0a8326a3b78a18148b5c6ce84c77362269f","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":20460946,"name":"strong-pm","full_name":"strongloop/strong-pm","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars.githubusercontent.com/u/3020012?v=3","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/strong-pm","description":"deployer for node applications","fork":false,"url":"https://api.github.com/repos/strongloop/strong-pm","forks_url":"https://api.github.com/repos/strongloop/strong-pm/forks","keys_url":"https://api.github.com/repos/strongloop/strong-pm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/strong-pm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/strong-pm/teams","hooks_url":"https://api.github.com/repos/strongloop/strong-pm/hooks","issue_events_url":"https://api.github.com/repos/strongloop/strong-pm/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/strong-pm/events","assignees_url":"https://api.github.com/repos/strongloop/strong-pm/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/strong-pm/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/strong-pm/tags","blobs_url":"https://api.github.com/repos/strongloop/strong-pm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/strong-pm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/strong-pm/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/strong-pm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/strong-pm/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/strong-pm/languages","stargazers_url":"https://api.github.com/repos/strongloop/strong-pm/stargazers","contributors_url":"https://api.github.com/repos/strongloop/strong-pm/contributors","subscribers_url":"https://api.github.com/repos/strongloop/strong-pm/subscribers","subscription_url":"https://api.github.com/repos/strongloop/strong-pm/subscription","commits_url":"https://api.github.com/repos/strongloop/strong-pm/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/strong-pm/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/strong-pm/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/strong-pm/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/strong-pm/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/strong-pm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/strong-pm/merges","archive_url":"https://api.github.com/repos/strongloop/strong-pm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/strong-pm/downloads","issues_url":"https://api.github.com/repos/strongloop/strong-pm/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/strong-pm/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/strong-pm/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/strong-pm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/strong-pm/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/strong-pm/releases{/id}","created_at":"2014-06-03T21:48:54Z","updated_at":"2015-06-12T11:30:54Z","pushed_at":"2015-06-15T20:12:48Z","git_url":"git://github.com/strongloop/strong-pm.git","ssh_url":"git@github.com:strongloop/strong-pm.git","clone_url":"https://github.com/strongloop/strong-pm.git","svn_url":"https://github.com/strongloop/strong-pm","homepage":"http://strong-pm.io","size":4516,"stargazers_count":112,"watchers_count":112,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":33,"forks":13,"open_issues":33,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/239"},"html":{"href":"https://github.com/strongloop/strong-pm/pull/239"},"issue":{"href":"https://api.github.com/repos/strongloop/strong-pm/issues/239"},"comments":{"href":"https://api.github.com/repos/strongloop/strong-pm/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/strong-pm/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/strong-pm/statuses/909164472327c14d7f15b7623cf9f686f7160077"}}}}