{"action":"closed","number":1000,"pull_request":{"url":"https://api.github.com/repos/CanalTP/navitia/pulls/1000","id":33435197,"html_url":"https://github.com/CanalTP/navitia/pull/1000","diff_url":"https://github.com/CanalTP/navitia/pull/1000.diff","patch_url":"https://github.com/CanalTP/navitia/pull/1000.patch","issue_url":"https://api.github.com/repos/CanalTP/navitia/issues/1000","number":1000,"state":"closed","locked":false,"title":"ed2nav: fix bug with lacking edges on street network","user":{"login":"kinnou02","id":448185,"avatar_url":"https://avatars.githubusercontent.com/u/448185?v=3","gravatar_id":"","url":"https://api.github.com/users/kinnou02","html_url":"https://github.com/kinnou02","followers_url":"https://api.github.com/users/kinnou02/followers","following_url":"https://api.github.com/users/kinnou02/following{/other_user}","gists_url":"https://api.github.com/users/kinnou02/gists{/gist_id}","starred_url":"https://api.github.com/users/kinnou02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinnou02/subscriptions","organizations_url":"https://api.github.com/users/kinnou02/orgs","repos_url":"https://api.github.com/users/kinnou02/repos","events_url":"https://api.github.com/users/kinnou02/events{/privacy}","received_events_url":"https://api.github.com/users/kinnou02/received_events","type":"User","site_admin":false},"body":"When choosing nodes to be ignored in the graph we were using the\r\nvertex_t of the node and not it's id, so we were deleting the wrong\r\nnode, that caused some edge to be deleted too.\r\n\r\nIronically when removing small connected component we were in fact\r\nrandomly created some of them.\r\n\r\nRefer to: http://jira.canaltp.fr/browse/NAVITIAII-1691","created_at":"2015-04-16T09:58:59Z","updated_at":"2015-04-17T07:09:43Z","closed_at":"2015-04-17T07:09:43Z","merged_at":"2015-04-17T07:09:43Z","merge_commit_sha":"f69f879d672ad933fa8f1386a238f2757a5aed1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1000/commits","review_comments_url":"https://api.github.com/repos/CanalTP/navitia/pulls/1000/comments","review_comment_url":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/navitia/issues/1000/comments","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/ce1e12339b38f8f00c3a54200b335c09d6e2ba75","head":{"label":"kinnou02:loosing_edges","ref":"loosing_edges","sha":"ce1e12339b38f8f00c3a54200b335c09d6e2ba75","user":{"login":"kinnou02","id":448185,"avatar_url":"https://avatars.githubusercontent.com/u/448185?v=3","gravatar_id":"","url":"https://api.github.com/users/kinnou02","html_url":"https://github.com/kinnou02","followers_url":"https://api.github.com/users/kinnou02/followers","following_url":"https://api.github.com/users/kinnou02/following{/other_user}","gists_url":"https://api.github.com/users/kinnou02/gists{/gist_id}","starred_url":"https://api.github.com/users/kinnou02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinnou02/subscriptions","organizations_url":"https://api.github.com/users/kinnou02/orgs","repos_url":"https://api.github.com/users/kinnou02/repos","events_url":"https://api.github.com/users/kinnou02/events{/privacy}","received_events_url":"https://api.github.com/users/kinnou02/received_events","type":"User","site_admin":false},"repo":{"id":19144326,"name":"navitia","full_name":"kinnou02/navitia","owner":{"login":"kinnou02","id":448185,"avatar_url":"https://avatars.githubusercontent.com/u/448185?v=3","gravatar_id":"","url":"https://api.github.com/users/kinnou02","html_url":"https://github.com/kinnou02","followers_url":"https://api.github.com/users/kinnou02/followers","following_url":"https://api.github.com/users/kinnou02/following{/other_user}","gists_url":"https://api.github.com/users/kinnou02/gists{/gist_id}","starred_url":"https://api.github.com/users/kinnou02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinnou02/subscriptions","organizations_url":"https://api.github.com/users/kinnou02/orgs","repos_url":"https://api.github.com/users/kinnou02/repos","events_url":"https://api.github.com/users/kinnou02/events{/privacy}","received_events_url":"https://api.github.com/users/kinnou02/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinnou02/navitia","description":"","fork":true,"url":"https://api.github.com/repos/kinnou02/navitia","forks_url":"https://api.github.com/repos/kinnou02/navitia/forks","keys_url":"https://api.github.com/repos/kinnou02/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinnou02/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinnou02/navitia/teams","hooks_url":"https://api.github.com/repos/kinnou02/navitia/hooks","issue_events_url":"https://api.github.com/repos/kinnou02/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/kinnou02/navitia/events","assignees_url":"https://api.github.com/repos/kinnou02/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/kinnou02/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/kinnou02/navitia/tags","blobs_url":"https://api.github.com/repos/kinnou02/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinnou02/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinnou02/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinnou02/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinnou02/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/kinnou02/navitia/languages","stargazers_url":"https://api.github.com/repos/kinnou02/navitia/stargazers","contributors_url":"https://api.github.com/repos/kinnou02/navitia/contributors","subscribers_url":"https://api.github.com/repos/kinnou02/navitia/subscribers","subscription_url":"https://api.github.com/repos/kinnou02/navitia/subscription","commits_url":"https://api.github.com/repos/kinnou02/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinnou02/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinnou02/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinnou02/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinnou02/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/kinnou02/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinnou02/navitia/merges","archive_url":"https://api.github.com/repos/kinnou02/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinnou02/navitia/downloads","issues_url":"https://api.github.com/repos/kinnou02/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/kinnou02/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/kinnou02/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/kinnou02/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinnou02/navitia/labels{/name}","releases_url":"https://api.github.com/repos/kinnou02/navitia/releases{/id}","created_at":"2014-04-25T11:49:18Z","updated_at":"2015-04-02T13:46:49Z","pushed_at":"2015-04-16T15:34:39Z","git_url":"git://github.com/kinnou02/navitia.git","ssh_url":"git@github.com:kinnou02/navitia.git","clone_url":"https://github.com/kinnou02/navitia.git","svn_url":"https://github.com/kinnou02/navitia","homepage":"http://www.navitia.io/","size":25223,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"CanalTP:dev","ref":"dev","sha":"264d194f5ad26e222cdc4a4150e2fa05e3002797","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":10797333,"name":"navitia","full_name":"CanalTP/navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/navitia","description":"The REST API to build cool stuff with public transport","fork":false,"url":"https://api.github.com/repos/CanalTP/navitia","forks_url":"https://api.github.com/repos/CanalTP/navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/navitia/releases{/id}","created_at":"2013-06-19T15:34:30Z","updated_at":"2015-04-17T07:09:43Z","pushed_at":"2015-04-17T07:09:43Z","git_url":"git://github.com/CanalTP/navitia.git","ssh_url":"git@github.com:CanalTP/navitia.git","clone_url":"https://github.com/CanalTP/navitia.git","svn_url":"https://github.com/CanalTP/navitia","homepage":"http://www.navitia.io","size":33850,"stargazers_count":95,"watchers_count":95,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":11,"forks":27,"open_issues":11,"watchers":95,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1000"},"html":{"href":"https://github.com/CanalTP/navitia/pull/1000"},"issue":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1000"},"comments":{"href":"https://api.github.com/repos/CanalTP/navitia/issues/1000/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1000/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/navitia/pulls/1000/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/navitia/statuses/ce1e12339b38f8f00c3a54200b335c09d6e2ba75"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"antoine-de","id":3987698,"avatar_url":"https://avatars.githubusercontent.com/u/3987698?v=3","gravatar_id":"","url":"https://api.github.com/users/antoine-de","html_url":"https://github.com/antoine-de","followers_url":"https://api.github.com/users/antoine-de/followers","following_url":"https://api.github.com/users/antoine-de/following{/other_user}","gists_url":"https://api.github.com/users/antoine-de/gists{/gist_id}","starred_url":"https://api.github.com/users/antoine-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoine-de/subscriptions","organizations_url":"https://api.github.com/users/antoine-de/orgs","repos_url":"https://api.github.com/users/antoine-de/repos","events_url":"https://api.github.com/users/antoine-de/events{/privacy}","received_events_url":"https://api.github.com/users/antoine-de/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":3,"additions":23,"deletions":16,"changed_files":4}}