{"action":"created","issue":{"url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/2","labels_url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/2/comments","events_url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/2/events","html_url":"https://github.com/FreightAgent/freight-tools/pull/2","id":84570248,"number":2,"title":"Source hardening","user":{"login":"shaded-enmity","id":572844,"avatar_url":"https://avatars.githubusercontent.com/u/572844?v=3","gravatar_id":"","url":"https://api.github.com/users/shaded-enmity","html_url":"https://github.com/shaded-enmity","followers_url":"https://api.github.com/users/shaded-enmity/followers","following_url":"https://api.github.com/users/shaded-enmity/following{/other_user}","gists_url":"https://api.github.com/users/shaded-enmity/gists{/gist_id}","starred_url":"https://api.github.com/users/shaded-enmity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaded-enmity/subscriptions","organizations_url":"https://api.github.com/users/shaded-enmity/orgs","repos_url":"https://api.github.com/users/shaded-enmity/repos","events_url":"https://api.github.com/users/shaded-enmity/events{/privacy}","received_events_url":"https://api.github.com/users/shaded-enmity/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-06-03T13:40:48Z","updated_at":"2015-06-11T12:57:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FreightAgent/freight-tools/pulls/2","html_url":"https://github.com/FreightAgent/freight-tools/pull/2","diff_url":"https://github.com/FreightAgent/freight-tools/pull/2.diff","patch_url":"https://github.com/FreightAgent/freight-tools/pull/2.patch"},"body":"Hey,\r\n\r\nthis patchset contains a bunch of code changes to make the code more robust and resilient:\r\n\r\n* added safe `strjoin` family of functions\r\n* added `attribute((cleanup))` destructors\r\n* added checks for `strdup` allocation success\r\n* removed `ptr != NULL` checks from `alloca`'d pointers as they are invalid\r\n* replaced `*printf*` family of functions with `strjoin`/`strjoina`\r\n* added a few tests for the common functions\r\n\r\nWhat I have on my radar:\r\n* use prepared statements for database interactions *or* escape all parameters to queries\r\n* add more `size_t` wrapping checks to the common functions\r\n* handle external processes better\r\n* fix spelling (`tennant` -> `tenant`)"},"comment":{"url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/comments/111123443","html_url":"https://github.com/FreightAgent/freight-tools/pull/2#issuecomment-111123443","issue_url":"https://api.github.com/repos/FreightAgent/freight-tools/issues/2","id":111123443,"user":{"login":"nhorman","id":1032926,"avatar_url":"https://avatars.githubusercontent.com/u/1032926?v=3","gravatar_id":"","url":"https://api.github.com/users/nhorman","html_url":"https://github.com/nhorman","followers_url":"https://api.github.com/users/nhorman/followers","following_url":"https://api.github.com/users/nhorman/following{/other_user}","gists_url":"https://api.github.com/users/nhorman/gists{/gist_id}","starred_url":"https://api.github.com/users/nhorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhorman/subscriptions","organizations_url":"https://api.github.com/users/nhorman/orgs","repos_url":"https://api.github.com/users/nhorman/repos","events_url":"https://api.github.com/users/nhorman/events{/privacy}","received_events_url":"https://api.github.com/users/nhorman/received_events","type":"User","site_admin":false},"created_at":"2015-06-11T12:57:47Z","updated_at":"2015-06-11T12:57:47Z","body":"awesome!  Let me know when its ready to review/pull"}}