{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/badboy/nobsign/pulls/1","id":48547779,"html_url":"https://github.com/badboy/nobsign/pull/1","diff_url":"https://github.com/badboy/nobsign/pull/1.diff","patch_url":"https://github.com/badboy/nobsign/pull/1.patch","issue_url":"https://api.github.com/repos/badboy/nobsign/issues/1","number":1,"state":"open","locked":false,"title":"Use *ring* in the canonical way.","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"body":"1. Do HMAC verification using |ring::hmac::verify| as recommended in\r\nthe *ring* documentation. This allows the dependency on\r\nconstant_time_eq to be dropped.\r\n\r\n2. Instead of creating a temporary HMAC key in each sign/verify\r\noperation, calculate the HMAC key once and reuse the same key multiple\r\ntimes. This is more efficient as the creation of an HMAC key is not\r\nfree.\r\n\r\n3. Do not store |salt| seperately. |salt| has already been mixed into\r\n|s_key| and |v_key| so it isn't needed any more.","created_at":"2015-10-23T06:57:57Z","updated_at":"2015-10-23T06:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/badboy/nobsign/pulls/1/commits","review_comments_url":"https://api.github.com/repos/badboy/nobsign/pulls/1/comments","review_comment_url":"https://api.github.com/repos/badboy/nobsign/pulls/comments{/number}","comments_url":"https://api.github.com/repos/badboy/nobsign/issues/1/comments","statuses_url":"https://api.github.com/repos/badboy/nobsign/statuses/d0bc9435b4a5088e920f008515c85e3291ae3c9a","head":{"label":"briansmith:canonical_ring_usage","ref":"canonical_ring_usage","sha":"d0bc9435b4a5088e920f008515c85e3291ae3c9a","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":44796122,"name":"nobsign","full_name":"briansmith/nobsign","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/nobsign","description":"A simple but effective sign library, written in Rust","fork":true,"url":"https://api.github.com/repos/briansmith/nobsign","forks_url":"https://api.github.com/repos/briansmith/nobsign/forks","keys_url":"https://api.github.com/repos/briansmith/nobsign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/nobsign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/nobsign/teams","hooks_url":"https://api.github.com/repos/briansmith/nobsign/hooks","issue_events_url":"https://api.github.com/repos/briansmith/nobsign/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/nobsign/events","assignees_url":"https://api.github.com/repos/briansmith/nobsign/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/nobsign/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/nobsign/tags","blobs_url":"https://api.github.com/repos/briansmith/nobsign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/nobsign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/nobsign/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/nobsign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/nobsign/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/nobsign/languages","stargazers_url":"https://api.github.com/repos/briansmith/nobsign/stargazers","contributors_url":"https://api.github.com/repos/briansmith/nobsign/contributors","subscribers_url":"https://api.github.com/repos/briansmith/nobsign/subscribers","subscription_url":"https://api.github.com/repos/briansmith/nobsign/subscription","commits_url":"https://api.github.com/repos/briansmith/nobsign/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/nobsign/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/nobsign/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/nobsign/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/nobsign/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/nobsign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/nobsign/merges","archive_url":"https://api.github.com/repos/briansmith/nobsign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/nobsign/downloads","issues_url":"https://api.github.com/repos/briansmith/nobsign/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/nobsign/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/nobsign/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/nobsign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/nobsign/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/nobsign/releases{/id}","created_at":"2015-10-23T06:55:38Z","updated_at":"2015-10-23T06:55:38Z","pushed_at":"2015-10-23T06:56:29Z","git_url":"git://github.com/briansmith/nobsign.git","ssh_url":"git@github.com:briansmith/nobsign.git","clone_url":"https://github.com/briansmith/nobsign.git","svn_url":"https://github.com/briansmith/nobsign","homepage":"http://badboy.github.io/nobsign/","size":1381,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"badboy:master","ref":"master","sha":"ca549d19ceb3e59b15d35854d91bd5af621dccbb","user":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"repo":{"id":44176448,"name":"nobsign","full_name":"badboy/nobsign","owner":{"login":"badboy","id":2129,"avatar_url":"https://avatars.githubusercontent.com/u/2129?v=3","gravatar_id":"","url":"https://api.github.com/users/badboy","html_url":"https://github.com/badboy","followers_url":"https://api.github.com/users/badboy/followers","following_url":"https://api.github.com/users/badboy/following{/other_user}","gists_url":"https://api.github.com/users/badboy/gists{/gist_id}","starred_url":"https://api.github.com/users/badboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badboy/subscriptions","organizations_url":"https://api.github.com/users/badboy/orgs","repos_url":"https://api.github.com/users/badboy/repos","events_url":"https://api.github.com/users/badboy/events{/privacy}","received_events_url":"https://api.github.com/users/badboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/badboy/nobsign","description":"A simple but effective sign library, written in Rust","fork":false,"url":"https://api.github.com/repos/badboy/nobsign","forks_url":"https://api.github.com/repos/badboy/nobsign/forks","keys_url":"https://api.github.com/repos/badboy/nobsign/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badboy/nobsign/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badboy/nobsign/teams","hooks_url":"https://api.github.com/repos/badboy/nobsign/hooks","issue_events_url":"https://api.github.com/repos/badboy/nobsign/issues/events{/number}","events_url":"https://api.github.com/repos/badboy/nobsign/events","assignees_url":"https://api.github.com/repos/badboy/nobsign/assignees{/user}","branches_url":"https://api.github.com/repos/badboy/nobsign/branches{/branch}","tags_url":"https://api.github.com/repos/badboy/nobsign/tags","blobs_url":"https://api.github.com/repos/badboy/nobsign/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badboy/nobsign/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badboy/nobsign/git/refs{/sha}","trees_url":"https://api.github.com/repos/badboy/nobsign/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badboy/nobsign/statuses/{sha}","languages_url":"https://api.github.com/repos/badboy/nobsign/languages","stargazers_url":"https://api.github.com/repos/badboy/nobsign/stargazers","contributors_url":"https://api.github.com/repos/badboy/nobsign/contributors","subscribers_url":"https://api.github.com/repos/badboy/nobsign/subscribers","subscription_url":"https://api.github.com/repos/badboy/nobsign/subscription","commits_url":"https://api.github.com/repos/badboy/nobsign/commits{/sha}","git_commits_url":"https://api.github.com/repos/badboy/nobsign/git/commits{/sha}","comments_url":"https://api.github.com/repos/badboy/nobsign/comments{/number}","issue_comment_url":"https://api.github.com/repos/badboy/nobsign/issues/comments{/number}","contents_url":"https://api.github.com/repos/badboy/nobsign/contents/{+path}","compare_url":"https://api.github.com/repos/badboy/nobsign/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badboy/nobsign/merges","archive_url":"https://api.github.com/repos/badboy/nobsign/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badboy/nobsign/downloads","issues_url":"https://api.github.com/repos/badboy/nobsign/issues{/number}","pulls_url":"https://api.github.com/repos/badboy/nobsign/pulls{/number}","milestones_url":"https://api.github.com/repos/badboy/nobsign/milestones{/number}","notifications_url":"https://api.github.com/repos/badboy/nobsign/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badboy/nobsign/labels{/name}","releases_url":"https://api.github.com/repos/badboy/nobsign/releases{/id}","created_at":"2015-10-13T12:59:53Z","updated_at":"2015-10-21T12:30:09Z","pushed_at":"2015-10-16T22:01:35Z","git_url":"git://github.com/badboy/nobsign.git","ssh_url":"git@github.com:badboy/nobsign.git","clone_url":"https://github.com/badboy/nobsign.git","svn_url":"https://github.com/badboy/nobsign","homepage":"http://badboy.github.io/nobsign/","size":1381,"stargazers_count":5,"watchers_count":5,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/badboy/nobsign/pulls/1"},"html":{"href":"https://github.com/badboy/nobsign/pull/1"},"issue":{"href":"https://api.github.com/repos/badboy/nobsign/issues/1"},"comments":{"href":"https://api.github.com/repos/badboy/nobsign/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/badboy/nobsign/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/badboy/nobsign/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/badboy/nobsign/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/badboy/nobsign/statuses/d0bc9435b4a5088e920f008515c85e3291ae3c9a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":24,"changed_files":2}}