{"action":"created","comment":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments/29759503","id":29759503,"diff_hunk":"@@ -40,6 +40,14 @@ Library ethif\n   Modules:            Ethif\n   BuildDepends:       tcpip,io-page,mirage-types,ipaddr,cstruct,lwt\n \n+Library arpv4\n+  CompiledObject:     best\n+  Path:               lib\n+  Findlibparent:      tcpip\n+  Findlibname:        arpv4\n+  Modules:            Arpv4\n+  BuildDepends:       tcpip,io-page,mirage-types,ipaddr,cstruct,lwt\n+","path":"_oasis","position":11,"original_position":11,"commit_id":"584f7da0cb9a504c0bd92590441b9a3d3ffd85ed","original_commit_id":"584f7da0cb9a504c0bd92590441b9a3d3ffd85ed","user":{"login":"samoht","id":103693,"avatar_url":"https://avatars.githubusercontent.com/u/103693?v=3","gravatar_id":"","url":"https://api.github.com/users/samoht","html_url":"https://github.com/samoht","followers_url":"https://api.github.com/users/samoht/followers","following_url":"https://api.github.com/users/samoht/following{/other_user}","gists_url":"https://api.github.com/users/samoht/gists{/gist_id}","starred_url":"https://api.github.com/users/samoht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samoht/subscriptions","organizations_url":"https://api.github.com/users/samoht/orgs","repos_url":"https://api.github.com/users/samoht/repos","events_url":"https://api.github.com/users/samoht/events{/privacy}","received_events_url":"https://api.github.com/users/samoht/received_events","type":"User","site_admin":false},"body":"I think you also need to remove `Arp` from the list of packages in `ipv4`","created_at":"2015-05-06T13:51:57Z","updated_at":"2015-05-06T13:51:57Z","html_url":"https://github.com/mirage/mirage-tcpip/pull/134#discussion_r29759503","pull_request_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments/29759503"},"html":{"href":"https://github.com/mirage/mirage-tcpip/pull/134#discussion_r29759503"},"pull_request":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134","id":34812746,"html_url":"https://github.com/mirage/mirage-tcpip/pull/134","diff_url":"https://github.com/mirage/mirage-tcpip/pull/134.diff","patch_url":"https://github.com/mirage/mirage-tcpip/pull/134.patch","issue_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/134","number":134,"state":"open","locked":false,"title":"Expose Arpv4.Make functor; require arp argument for Ipv4.connect","user":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars.githubusercontent.com/u/4086825?v=3","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"body":"Pull ARP out of ipv4 and make it externally usable.  Require explicit arp.t argument for Ipv4.connect .\r\n\r\nNeeds to be merged in tandem with https://github.com/mirage/mirage/pull/400 .","created_at":"2015-05-06T12:45:40Z","updated_at":"2015-05-06T13:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"156074301095da35d487e57410101c4274555308","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134/commits","review_comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134/comments","review_comment_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/134/comments","statuses_url":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/584f7da0cb9a504c0bd92590441b9a3d3ffd85ed","head":{"label":"yomimono:separate_arp","ref":"separate_arp","sha":"584f7da0cb9a504c0bd92590441b9a3d3ffd85ed","user":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars.githubusercontent.com/u/4086825?v=3","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"repo":{"id":18845501,"name":"mirage-tcpip","full_name":"yomimono/mirage-tcpip","owner":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars.githubusercontent.com/u/4086825?v=3","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yomimono/mirage-tcpip","description":"TCP/IP networking stack in pure OCaml, using the Mirage platform libraries.  Includes Ethernet, DHCP, ARP and TCP/IPv4 support.","fork":true,"url":"https://api.github.com/repos/yomimono/mirage-tcpip","forks_url":"https://api.github.com/repos/yomimono/mirage-tcpip/forks","keys_url":"https://api.github.com/repos/yomimono/mirage-tcpip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yomimono/mirage-tcpip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yomimono/mirage-tcpip/teams","hooks_url":"https://api.github.com/repos/yomimono/mirage-tcpip/hooks","issue_events_url":"https://api.github.com/repos/yomimono/mirage-tcpip/issues/events{/number}","events_url":"https://api.github.com/repos/yomimono/mirage-tcpip/events","assignees_url":"https://api.github.com/repos/yomimono/mirage-tcpip/assignees{/user}","branches_url":"https://api.github.com/repos/yomimono/mirage-tcpip/branches{/branch}","tags_url":"https://api.github.com/repos/yomimono/mirage-tcpip/tags","blobs_url":"https://api.github.com/repos/yomimono/mirage-tcpip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yomimono/mirage-tcpip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yomimono/mirage-tcpip/git/refs{/sha}","trees_url":"https://api.github.com/repos/yomimono/mirage-tcpip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yomimono/mirage-tcpip/statuses/{sha}","languages_url":"https://api.github.com/repos/yomimono/mirage-tcpip/languages","stargazers_url":"https://api.github.com/repos/yomimono/mirage-tcpip/stargazers","contributors_url":"https://api.github.com/repos/yomimono/mirage-tcpip/contributors","subscribers_url":"https://api.github.com/repos/yomimono/mirage-tcpip/subscribers","subscription_url":"https://api.github.com/repos/yomimono/mirage-tcpip/subscription","commits_url":"https://api.github.com/repos/yomimono/mirage-tcpip/commits{/sha}","git_commits_url":"https://api.github.com/repos/yomimono/mirage-tcpip/git/commits{/sha}","comments_url":"https://api.github.com/repos/yomimono/mirage-tcpip/comments{/number}","issue_comment_url":"https://api.github.com/repos/yomimono/mirage-tcpip/issues/comments{/number}","contents_url":"https://api.github.com/repos/yomimono/mirage-tcpip/contents/{+path}","compare_url":"https://api.github.com/repos/yomimono/mirage-tcpip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yomimono/mirage-tcpip/merges","archive_url":"https://api.github.com/repos/yomimono/mirage-tcpip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yomimono/mirage-tcpip/downloads","issues_url":"https://api.github.com/repos/yomimono/mirage-tcpip/issues{/number}","pulls_url":"https://api.github.com/repos/yomimono/mirage-tcpip/pulls{/number}","milestones_url":"https://api.github.com/repos/yomimono/mirage-tcpip/milestones{/number}","notifications_url":"https://api.github.com/repos/yomimono/mirage-tcpip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yomimono/mirage-tcpip/labels{/name}","releases_url":"https://api.github.com/repos/yomimono/mirage-tcpip/releases{/id}","created_at":"2014-04-16T15:43:05Z","updated_at":"2014-07-01T16:18:16Z","pushed_at":"2015-05-06T13:15:40Z","git_url":"git://github.com/yomimono/mirage-tcpip.git","ssh_url":"git@github.com:yomimono/mirage-tcpip.git","clone_url":"https://github.com/yomimono/mirage-tcpip.git","svn_url":"https://github.com/yomimono/mirage-tcpip","homepage":"http://www.openmirage.org/","size":1302,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"b6ca1ddb189bf2c2b81c050428a233de1c4371fd","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":4724712,"name":"mirage-tcpip","full_name":"mirage/mirage-tcpip","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/mirage-tcpip","description":"TCP/IP networking stack in pure OCaml, using the Mirage platform libraries.  Includes Ethernet, DHCP, ARP and TCP/IPv4 support.","fork":false,"url":"https://api.github.com/repos/mirage/mirage-tcpip","forks_url":"https://api.github.com/repos/mirage/mirage-tcpip/forks","keys_url":"https://api.github.com/repos/mirage/mirage-tcpip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/mirage-tcpip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/mirage-tcpip/teams","hooks_url":"https://api.github.com/repos/mirage/mirage-tcpip/hooks","issue_events_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/mirage-tcpip/events","assignees_url":"https://api.github.com/repos/mirage/mirage-tcpip/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/mirage-tcpip/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/mirage-tcpip/tags","blobs_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/mirage-tcpip/languages","stargazers_url":"https://api.github.com/repos/mirage/mirage-tcpip/stargazers","contributors_url":"https://api.github.com/repos/mirage/mirage-tcpip/contributors","subscribers_url":"https://api.github.com/repos/mirage/mirage-tcpip/subscribers","subscription_url":"https://api.github.com/repos/mirage/mirage-tcpip/subscription","commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/mirage-tcpip/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/mirage-tcpip/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirage/mirage-tcpip/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/mirage-tcpip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/mirage-tcpip/merges","archive_url":"https://api.github.com/repos/mirage/mirage-tcpip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/mirage-tcpip/downloads","issues_url":"https://api.github.com/repos/mirage/mirage-tcpip/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/mirage-tcpip/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/mirage-tcpip/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/mirage-tcpip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/mirage-tcpip/labels{/name}","releases_url":"https://api.github.com/repos/mirage/mirage-tcpip/releases{/id}","created_at":"2012-06-20T09:53:17Z","updated_at":"2015-05-05T17:23:18Z","pushed_at":"2015-05-06T13:15:41Z","git_url":"git://github.com/mirage/mirage-tcpip.git","ssh_url":"git@github.com:mirage/mirage-tcpip.git","clone_url":"https://github.com/mirage/mirage-tcpip.git","svn_url":"https://github.com/mirage/mirage-tcpip","homepage":"http://www.openmirage.org/","size":2950,"stargazers_count":45,"watchers_count":45,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":20,"forks":20,"open_issues":20,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134"},"html":{"href":"https://github.com/mirage/mirage-tcpip/pull/134"},"issue":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/issues/134"},"comments":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/mirage-tcpip/statuses/584f7da0cb9a504c0bd92590441b9a3d3ffd85ed"}}}}