{"action":"created","comment":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/22580142","id":22580142,"diff_hunk":"@@ -16,15 +16,28 @@\n class error_collector\n {\n \tvar $errors;\n+\tvar $error_types;\n \n-\tfunction __construct()\n+\t/**\n+\t * Constructor.\n+\t *\n+\t * The variable $error_types may be set to a mask of PHP error types that\n+\t * the collector should keep, e.g. `E_ALL`. If unset, the current value of\n+\t * the error_reporting() function will be used to determine which errors\n+\t * the collector will keep.\n+\t *\n+\t * @see PHPBB3-13306","path":"phpBB/phpbb/error_collector.php","position":15,"original_position":15,"commit_id":"8a9c2c055c7fbc199bad3e6fbfb0235a910b87e2","original_commit_id":"8a9c2c055c7fbc199bad3e6fbfb0235a910b87e2","user":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"body":"From time to time we do (but more in tests), and I don't think it's bad.","created_at":"2015-01-07T10:41:12Z","updated_at":"2015-01-07T10:41:12Z","html_url":"https://github.com/phpbb/phpbb/pull/3128#discussion_r22580142","pull_request_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3128","_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/22580142"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3128#discussion_r22580142"},"pull_request":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3128"}}},"pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/3128","id":24188683,"html_url":"https://github.com/phpbb/phpbb/pull/3128","diff_url":"https://github.com/phpbb/phpbb/pull/3128.diff","patch_url":"https://github.com/phpbb/phpbb/pull/3128.patch","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/3128","number":3128,"state":"open","locked":false,"title":"[ticket/13306] add error level to collector","user":{"login":"omniError","id":1885212,"avatar_url":"https://avatars.githubusercontent.com/u/1885212?v=3","gravatar_id":"","url":"https://api.github.com/users/omniError","html_url":"https://github.com/omniError","followers_url":"https://api.github.com/users/omniError/followers","following_url":"https://api.github.com/users/omniError/following{/other_user}","gists_url":"https://api.github.com/users/omniError/gists{/gist_id}","starred_url":"https://api.github.com/users/omniError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omniError/subscriptions","organizations_url":"https://api.github.com/users/omniError/orgs","repos_url":"https://api.github.com/users/omniError/repos","events_url":"https://api.github.com/users/omniError/events{/privacy}","received_events_url":"https://api.github.com/users/omniError/received_events","type":"User","site_admin":false},"body":"https://tracker.phpbb.com/browse/PHPBB3-13306\r\n\r\nPHPBB3-13306","created_at":"2014-11-11T00:05:40Z","updated_at":"2015-01-07T10:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93a261c5dde501baec3e85eb8adcc8d908205dd3","assignee":null,"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/4","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/4/labels","id":876171,"number":4,"title":"3.1.3","description":null,"creator":{"login":"nickvergessen","id":213943,"avatar_url":"https://avatars.githubusercontent.com/u/213943?v=3","gravatar_id":"","url":"https://api.github.com/users/nickvergessen","html_url":"https://github.com/nickvergessen","followers_url":"https://api.github.com/users/nickvergessen/followers","following_url":"https://api.github.com/users/nickvergessen/following{/other_user}","gists_url":"https://api.github.com/users/nickvergessen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickvergessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickvergessen/subscriptions","organizations_url":"https://api.github.com/users/nickvergessen/orgs","repos_url":"https://api.github.com/users/nickvergessen/repos","events_url":"https://api.github.com/users/nickvergessen/events{/privacy}","received_events_url":"https://api.github.com/users/nickvergessen/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":42,"state":"open","created_at":"2014-11-21T18:27:08Z","updated_at":"2015-01-06T20:46:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3128/commits","review_comments_url":"https://api.github.com/repos/phpbb/phpbb/pulls/3128/comments","review_comment_url":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/3128/comments","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/8a9c2c055c7fbc199bad3e6fbfb0235a910b87e2","head":{"label":"omniError:ticket/13306","ref":"ticket/13306","sha":"8a9c2c055c7fbc199bad3e6fbfb0235a910b87e2","user":{"login":"omniError","id":1885212,"avatar_url":"https://avatars.githubusercontent.com/u/1885212?v=3","gravatar_id":"","url":"https://api.github.com/users/omniError","html_url":"https://github.com/omniError","followers_url":"https://api.github.com/users/omniError/followers","following_url":"https://api.github.com/users/omniError/following{/other_user}","gists_url":"https://api.github.com/users/omniError/gists{/gist_id}","starred_url":"https://api.github.com/users/omniError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omniError/subscriptions","organizations_url":"https://api.github.com/users/omniError/orgs","repos_url":"https://api.github.com/users/omniError/repos","events_url":"https://api.github.com/users/omniError/events{/privacy}","received_events_url":"https://api.github.com/users/omniError/received_events","type":"User","site_admin":false},"repo":{"id":21797141,"name":"phpbb","full_name":"omniError/phpbb","owner":{"login":"omniError","id":1885212,"avatar_url":"https://avatars.githubusercontent.com/u/1885212?v=3","gravatar_id":"","url":"https://api.github.com/users/omniError","html_url":"https://github.com/omniError","followers_url":"https://api.github.com/users/omniError/followers","following_url":"https://api.github.com/users/omniError/following{/other_user}","gists_url":"https://api.github.com/users/omniError/gists{/gist_id}","starred_url":"https://api.github.com/users/omniError/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omniError/subscriptions","organizations_url":"https://api.github.com/users/omniError/orgs","repos_url":"https://api.github.com/users/omniError/repos","events_url":"https://api.github.com/users/omniError/events{/privacy}","received_events_url":"https://api.github.com/users/omniError/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/omniError/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":true,"url":"https://api.github.com/repos/omniError/phpbb","forks_url":"https://api.github.com/repos/omniError/phpbb/forks","keys_url":"https://api.github.com/repos/omniError/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omniError/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omniError/phpbb/teams","hooks_url":"https://api.github.com/repos/omniError/phpbb/hooks","issue_events_url":"https://api.github.com/repos/omniError/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/omniError/phpbb/events","assignees_url":"https://api.github.com/repos/omniError/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/omniError/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/omniError/phpbb/tags","blobs_url":"https://api.github.com/repos/omniError/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omniError/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omniError/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/omniError/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omniError/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/omniError/phpbb/languages","stargazers_url":"https://api.github.com/repos/omniError/phpbb/stargazers","contributors_url":"https://api.github.com/repos/omniError/phpbb/contributors","subscribers_url":"https://api.github.com/repos/omniError/phpbb/subscribers","subscription_url":"https://api.github.com/repos/omniError/phpbb/subscription","commits_url":"https://api.github.com/repos/omniError/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/omniError/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/omniError/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/omniError/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/omniError/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/omniError/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omniError/phpbb/merges","archive_url":"https://api.github.com/repos/omniError/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omniError/phpbb/downloads","issues_url":"https://api.github.com/repos/omniError/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/omniError/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/omniError/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/omniError/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omniError/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/omniError/phpbb/releases{/id}","created_at":"2014-07-13T18:24:50Z","updated_at":"2015-01-06T20:42:47Z","pushed_at":"2015-01-06T20:59:49Z","git_url":"git://github.com/omniError/phpbb.git","ssh_url":"git@github.com:omniError/phpbb.git","clone_url":"https://github.com/omniError/phpbb.git","svn_url":"https://github.com/omniError/phpbb","homepage":"http://www.phpbb.com","size":49192,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop-ascraeus"}},"base":{"label":"phpbb:develop-ascraeus","ref":"develop-ascraeus","sha":"c9db08873f1e1d9f9f89da181d5aa374464fc250","user":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"repo":{"id":541983,"name":"phpbb","full_name":"phpbb/phpbb","owner":{"login":"phpbb","id":176697,"avatar_url":"https://avatars.githubusercontent.com/u/176697?v=3","gravatar_id":"","url":"https://api.github.com/users/phpbb","html_url":"https://github.com/phpbb","followers_url":"https://api.github.com/users/phpbb/followers","following_url":"https://api.github.com/users/phpbb/following{/other_user}","gists_url":"https://api.github.com/users/phpbb/gists{/gist_id}","starred_url":"https://api.github.com/users/phpbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phpbb/subscriptions","organizations_url":"https://api.github.com/users/phpbb/orgs","repos_url":"https://api.github.com/users/phpbb/repos","events_url":"https://api.github.com/users/phpbb/events{/privacy}","received_events_url":"https://api.github.com/users/phpbb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phpbb/phpbb","description":" phpBB 3 Development: phpBB is a popular open-source bulletin board written in PHP. This repository also contains the history of version 2.","fork":false,"url":"https://api.github.com/repos/phpbb/phpbb","forks_url":"https://api.github.com/repos/phpbb/phpbb/forks","keys_url":"https://api.github.com/repos/phpbb/phpbb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phpbb/phpbb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phpbb/phpbb/teams","hooks_url":"https://api.github.com/repos/phpbb/phpbb/hooks","issue_events_url":"https://api.github.com/repos/phpbb/phpbb/issues/events{/number}","events_url":"https://api.github.com/repos/phpbb/phpbb/events","assignees_url":"https://api.github.com/repos/phpbb/phpbb/assignees{/user}","branches_url":"https://api.github.com/repos/phpbb/phpbb/branches{/branch}","tags_url":"https://api.github.com/repos/phpbb/phpbb/tags","blobs_url":"https://api.github.com/repos/phpbb/phpbb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phpbb/phpbb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phpbb/phpbb/git/refs{/sha}","trees_url":"https://api.github.com/repos/phpbb/phpbb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phpbb/phpbb/statuses/{sha}","languages_url":"https://api.github.com/repos/phpbb/phpbb/languages","stargazers_url":"https://api.github.com/repos/phpbb/phpbb/stargazers","contributors_url":"https://api.github.com/repos/phpbb/phpbb/contributors","subscribers_url":"https://api.github.com/repos/phpbb/phpbb/subscribers","subscription_url":"https://api.github.com/repos/phpbb/phpbb/subscription","commits_url":"https://api.github.com/repos/phpbb/phpbb/commits{/sha}","git_commits_url":"https://api.github.com/repos/phpbb/phpbb/git/commits{/sha}","comments_url":"https://api.github.com/repos/phpbb/phpbb/comments{/number}","issue_comment_url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/{number}","contents_url":"https://api.github.com/repos/phpbb/phpbb/contents/{+path}","compare_url":"https://api.github.com/repos/phpbb/phpbb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phpbb/phpbb/merges","archive_url":"https://api.github.com/repos/phpbb/phpbb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phpbb/phpbb/downloads","issues_url":"https://api.github.com/repos/phpbb/phpbb/issues{/number}","pulls_url":"https://api.github.com/repos/phpbb/phpbb/pulls{/number}","milestones_url":"https://api.github.com/repos/phpbb/phpbb/milestones{/number}","notifications_url":"https://api.github.com/repos/phpbb/phpbb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phpbb/phpbb/labels{/name}","releases_url":"https://api.github.com/repos/phpbb/phpbb/releases{/id}","created_at":"2010-03-01T22:33:17Z","updated_at":"2015-01-06T10:29:41Z","pushed_at":"2015-01-06T10:29:40Z","git_url":"git://github.com/phpbb/phpbb.git","ssh_url":"git@github.com:phpbb/phpbb.git","clone_url":"https://github.com/phpbb/phpbb.git","svn_url":"https://github.com/phpbb/phpbb","homepage":"http://www.phpbb.com","size":100607,"stargazers_count":702,"watchers_count":702,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":411,"mirror_url":null,"open_issues_count":69,"forks":411,"open_issues":69,"watchers":702,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3128"},"html":{"href":"https://github.com/phpbb/phpbb/pull/3128"},"issue":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3128"},"comments":{"href":"https://api.github.com/repos/phpbb/phpbb/issues/3128/comments"},"review_comments":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3128/comments"},"review_comment":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phpbb/phpbb/pulls/3128/commits"},"statuses":{"href":"https://api.github.com/repos/phpbb/phpbb/statuses/8a9c2c055c7fbc199bad3e6fbfb0235a910b87e2"}}}}