{"action":"closed","number":3057,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/3057","id":36089435,"html_url":"https://github.com/dotnet/roslyn/pull/3057","diff_url":"https://github.com/dotnet/roslyn/pull/3057.diff","patch_url":"https://github.com/dotnet/roslyn/pull/3057.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/3057","number":3057,"state":"closed","locked":false,"title":"Stabilization Port -- NavBar: Guard against symbol navigation on non-symbol items","user":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"body":"Fixes internal TFS bug #1174848\r\n\r\nWhen a Navigation Bar item is chosen, like the NavigationBarSymbolItem\r\nrepresenting a particular member, we present the set of chosen items\r\n(for project, type, and member) as base NavigationBarItems with the text\r\ndisplay properties & tracking spans *copied* out of the real\r\nNavigationBarSymbolItem to remove any display indentation and to make\r\nsure the Navigation Bar does not hold on to old symbols, etc.\r\nWhen the Navigation Bar is expanded, we present real\r\nNavigationBarSymbolItems again and when they are chosen we perform the\r\nappropriate symbolic navigation.\r\n\r\nHowever, there is a moment after an item is chosen where we have\r\nreplaced the real NavigationBarSymbolItem with its NavigationBarItem\r\ncopy, but the Navigation Bar is still allowing clicks to the item to\r\ncount as navigation (rather than expansion of the collapsed list). When\r\nthis happens, we see NavigateToItem called on a base NavigationBarItem\r\nand crash because we believe it will be a NavigationBarSymbolItem.\r\n\r\nThe base NavigationBarItem was being used for multiple purposes, so this\r\nchange makes it abstract and introduces NavigationBarPresentedItem for the\r\npurposes described above and NavigationBarActionlessItem which can be used\r\nfor items that legitimately produce no action when selected (used in some\r\nVB event scenarios). The NavigationBarController now rejects any attempts\r\nto select a NavigationBarPresentedItem so that the\r\nINavigationBarItemService implementers will not have to deal with them.","created_at":"2015-05-23T16:02:27Z","updated_at":"2015-05-23T16:56:10Z","closed_at":"2015-05-23T16:56:10Z","merged_at":"2015-05-23T16:56:10Z","merge_commit_sha":"558daade8e5f43393ad3c6894c68be9039df02bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/3057/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/3057/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/3057/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/1303ece069e27986253a1c6b39f0531bbf11bec9","head":{"label":"dpoeschl:FixNavigationBarCrashPort","ref":"FixNavigationBarCrashPort","sha":"1303ece069e27986253a1c6b39f0531bbf11bec9","user":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"repo":{"id":30046829,"name":"roslyn","full_name":"dpoeschl/roslyn","owner":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpoeschl/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/dpoeschl/roslyn","forks_url":"https://api.github.com/repos/dpoeschl/roslyn/forks","keys_url":"https://api.github.com/repos/dpoeschl/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpoeschl/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpoeschl/roslyn/teams","hooks_url":"https://api.github.com/repos/dpoeschl/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dpoeschl/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dpoeschl/roslyn/events","assignees_url":"https://api.github.com/repos/dpoeschl/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dpoeschl/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dpoeschl/roslyn/tags","blobs_url":"https://api.github.com/repos/dpoeschl/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpoeschl/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpoeschl/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpoeschl/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpoeschl/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dpoeschl/roslyn/languages","stargazers_url":"https://api.github.com/repos/dpoeschl/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dpoeschl/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dpoeschl/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dpoeschl/roslyn/subscription","commits_url":"https://api.github.com/repos/dpoeschl/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpoeschl/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpoeschl/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpoeschl/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpoeschl/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dpoeschl/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpoeschl/roslyn/merges","archive_url":"https://api.github.com/repos/dpoeschl/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpoeschl/roslyn/downloads","issues_url":"https://api.github.com/repos/dpoeschl/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dpoeschl/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dpoeschl/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dpoeschl/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpoeschl/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dpoeschl/roslyn/releases{/id}","created_at":"2015-01-29T23:37:29Z","updated_at":"2015-03-18T18:28:52Z","pushed_at":"2015-05-23T16:01:53Z","git_url":"git://github.com/dpoeschl/roslyn.git","ssh_url":"git@github.com:dpoeschl/roslyn.git","clone_url":"https://github.com/dpoeschl/roslyn.git","svn_url":"https://github.com/dpoeschl/roslyn","homepage":"","size":76654,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:stabilization","ref":"stabilization","sha":"aaab3130010345715bc49088102466c951c061ff","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-23T14:56:20Z","pushed_at":"2015-05-23T16:56:10Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":139595,"stargazers_count":2356,"watchers_count":2356,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":503,"mirror_url":null,"open_issues_count":862,"forks":503,"open_issues":862,"watchers":2356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3057"},"html":{"href":"https://github.com/dotnet/roslyn/pull/3057"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/3057"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/3057/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3057/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/3057/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/1303ece069e27986253a1c6b39f0531bbf11bec9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dpoeschl","id":235241,"avatar_url":"https://avatars.githubusercontent.com/u/235241?v=3","gravatar_id":"","url":"https://api.github.com/users/dpoeschl","html_url":"https://github.com/dpoeschl","followers_url":"https://api.github.com/users/dpoeschl/followers","following_url":"https://api.github.com/users/dpoeschl/following{/other_user}","gists_url":"https://api.github.com/users/dpoeschl/gists{/gist_id}","starred_url":"https://api.github.com/users/dpoeschl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpoeschl/subscriptions","organizations_url":"https://api.github.com/users/dpoeschl/orgs","repos_url":"https://api.github.com/users/dpoeschl/repos","events_url":"https://api.github.com/users/dpoeschl/events{/privacy}","received_events_url":"https://api.github.com/users/dpoeschl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":80,"deletions":5,"changed_files":6}}