{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/28962782","id":28962782,"diff_hunk":"@@ -12,10 +12,25 @@ import (\n \t\"strings\"\n \t\"time\"\n \n+\t\"github.com/docker/docker/engine\"\n \t\"github.com/docker/libtrust\"\n \t\"github.com/go-check/check\"\n )\n \n+const (\n+\terrBadCertificate = \"remote error: bad certificate\"\n+\terrCaUnknown      = \"x509: certificate signed by unknown authority\"\n+\n+\ttestDaemonProto          = \"tcp\"\n+\ttestDaemonHttpsAddr      = \"localhost:4271\"\n+\ttestDaemonRogueHttpsAddr = \"localhost:4272\"\n+)\n+\n+var (","path":"integration-cli/docker_cli_daemon_test.go","position":18,"original_position":18,"commit_id":"93ed3d7e2f6a4f48796ccd6f3553a085792ae9f8","original_commit_id":"93ed3d7e2f6a4f48796ccd6f3553a085792ae9f8","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"These shouldn't be needed.","created_at":"2015-04-23T13:41:02Z","updated_at":"2015-04-23T13:41:02Z","html_url":"https://github.com/docker/docker/pull/12575#discussion_r28962782","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/12575","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/28962782"},"html":{"href":"https://github.com/docker/docker/pull/12575#discussion_r28962782"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/12575"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/12575","id":33716341,"html_url":"https://github.com/docker/docker/pull/12575","diff_url":"https://github.com/docker/docker/pull/12575.diff","patch_url":"https://github.com/docker/docker/pull/12575.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/12575","number":12575,"state":"open","locked":false,"title":"Move https tests as unit tests under client","user":{"login":"brahmaroutu","id":5403596,"avatar_url":"https://avatars.githubusercontent.com/u/5403596?v=3","gravatar_id":"","url":"https://api.github.com/users/brahmaroutu","html_url":"https://github.com/brahmaroutu","followers_url":"https://api.github.com/users/brahmaroutu/followers","following_url":"https://api.github.com/users/brahmaroutu/following{/other_user}","gists_url":"https://api.github.com/users/brahmaroutu/gists{/gist_id}","starred_url":"https://api.github.com/users/brahmaroutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brahmaroutu/subscriptions","organizations_url":"https://api.github.com/users/brahmaroutu/orgs","repos_url":"https://api.github.com/users/brahmaroutu/repos","events_url":"https://api.github.com/users/brahmaroutu/events{/privacy}","received_events_url":"https://api.github.com/users/brahmaroutu/received_events","type":"User","site_admin":false},"body":"Addresses #12255\r\nSigned-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>\r\n\r\n\r\nPlease note that the fixtures are only used by the client test and I moved it into that directory for convenience. Also same is true with the methods like spawnLegitHttpsDaemon, spawnRogueHttpsDaemon. If you think we can reuse that code at some place I can move it under utils package or pkg/unit-test-utils or something.","created_at":"2015-04-20T23:29:50Z","updated_at":"2015-04-23T13:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3421f85e72e012d24e780c0c36e4c0d24ffc7114","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/12575/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/12575/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/12575/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/93ed3d7e2f6a4f48796ccd6f3553a085792ae9f8","head":{"label":"brahmaroutu:integration_test7_12255","ref":"integration_test7_12255","sha":"93ed3d7e2f6a4f48796ccd6f3553a085792ae9f8","user":{"login":"brahmaroutu","id":5403596,"avatar_url":"https://avatars.githubusercontent.com/u/5403596?v=3","gravatar_id":"","url":"https://api.github.com/users/brahmaroutu","html_url":"https://github.com/brahmaroutu","followers_url":"https://api.github.com/users/brahmaroutu/followers","following_url":"https://api.github.com/users/brahmaroutu/following{/other_user}","gists_url":"https://api.github.com/users/brahmaroutu/gists{/gist_id}","starred_url":"https://api.github.com/users/brahmaroutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brahmaroutu/subscriptions","organizations_url":"https://api.github.com/users/brahmaroutu/orgs","repos_url":"https://api.github.com/users/brahmaroutu/repos","events_url":"https://api.github.com/users/brahmaroutu/events{/privacy}","received_events_url":"https://api.github.com/users/brahmaroutu/received_events","type":"User","site_admin":false},"repo":{"id":23947795,"name":"docker","full_name":"brahmaroutu/docker","owner":{"login":"brahmaroutu","id":5403596,"avatar_url":"https://avatars.githubusercontent.com/u/5403596?v=3","gravatar_id":"","url":"https://api.github.com/users/brahmaroutu","html_url":"https://github.com/brahmaroutu","followers_url":"https://api.github.com/users/brahmaroutu/followers","following_url":"https://api.github.com/users/brahmaroutu/following{/other_user}","gists_url":"https://api.github.com/users/brahmaroutu/gists{/gist_id}","starred_url":"https://api.github.com/users/brahmaroutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brahmaroutu/subscriptions","organizations_url":"https://api.github.com/users/brahmaroutu/orgs","repos_url":"https://api.github.com/users/brahmaroutu/repos","events_url":"https://api.github.com/users/brahmaroutu/events{/privacy}","received_events_url":"https://api.github.com/users/brahmaroutu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brahmaroutu/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/brahmaroutu/docker","forks_url":"https://api.github.com/repos/brahmaroutu/docker/forks","keys_url":"https://api.github.com/repos/brahmaroutu/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brahmaroutu/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brahmaroutu/docker/teams","hooks_url":"https://api.github.com/repos/brahmaroutu/docker/hooks","issue_events_url":"https://api.github.com/repos/brahmaroutu/docker/issues/events{/number}","events_url":"https://api.github.com/repos/brahmaroutu/docker/events","assignees_url":"https://api.github.com/repos/brahmaroutu/docker/assignees{/user}","branches_url":"https://api.github.com/repos/brahmaroutu/docker/branches{/branch}","tags_url":"https://api.github.com/repos/brahmaroutu/docker/tags","blobs_url":"https://api.github.com/repos/brahmaroutu/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brahmaroutu/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brahmaroutu/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/brahmaroutu/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brahmaroutu/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/brahmaroutu/docker/languages","stargazers_url":"https://api.github.com/repos/brahmaroutu/docker/stargazers","contributors_url":"https://api.github.com/repos/brahmaroutu/docker/contributors","subscribers_url":"https://api.github.com/repos/brahmaroutu/docker/subscribers","subscription_url":"https://api.github.com/repos/brahmaroutu/docker/subscription","commits_url":"https://api.github.com/repos/brahmaroutu/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/brahmaroutu/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/brahmaroutu/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/brahmaroutu/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/brahmaroutu/docker/contents/{+path}","compare_url":"https://api.github.com/repos/brahmaroutu/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brahmaroutu/docker/merges","archive_url":"https://api.github.com/repos/brahmaroutu/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brahmaroutu/docker/downloads","issues_url":"https://api.github.com/repos/brahmaroutu/docker/issues{/number}","pulls_url":"https://api.github.com/repos/brahmaroutu/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/brahmaroutu/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/brahmaroutu/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brahmaroutu/docker/labels{/name}","releases_url":"https://api.github.com/repos/brahmaroutu/docker/releases{/id}","created_at":"2014-09-12T05:17:02Z","updated_at":"2015-04-23T04:39:22Z","pushed_at":"2015-04-23T05:06:11Z","git_url":"git://github.com/brahmaroutu/docker.git","ssh_url":"git@github.com:brahmaroutu/docker.git","clone_url":"https://github.com/brahmaroutu/docker.git","svn_url":"https://github.com/brahmaroutu/docker","homepage":"http://www.docker.com","size":51584,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ccbb93e1cd38ad0a38455ad054b170f444aa9da3","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-04-23T12:56:19Z","pushed_at":"2015-04-23T13:26:20Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":186541,"stargazers_count":21089,"watchers_count":21089,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4867,"mirror_url":null,"open_issues_count":936,"forks":4867,"open_issues":936,"watchers":21089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/12575"},"html":{"href":"https://github.com/docker/docker/pull/12575"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/12575"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/12575/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/12575/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/12575/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/93ed3d7e2f6a4f48796ccd6f3553a085792ae9f8"}}}}