{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69","id":37513788,"html_url":"https://github.com/nowsecure/datagrid-gtk3/pull/69","diff_url":"https://github.com/nowsecure/datagrid-gtk3/pull/69.diff","patch_url":"https://github.com/nowsecure/datagrid-gtk3/pull/69.patch","issue_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/69","number":69,"state":"closed","locked":false,"title":"Possible fix for a rare segmentation fault","user":{"login":"hackedbellini","id":134025,"avatar_url":"https://avatars.githubusercontent.com/u/134025?v=3","gravatar_id":"","url":"https://api.github.com/users/hackedbellini","html_url":"https://github.com/hackedbellini","followers_url":"https://api.github.com/users/hackedbellini/followers","following_url":"https://api.github.com/users/hackedbellini/following{/other_user}","gists_url":"https://api.github.com/users/hackedbellini/gists{/gist_id}","starred_url":"https://api.github.com/users/hackedbellini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackedbellini/subscriptions","organizations_url":"https://api.github.com/users/hackedbellini/orgs","repos_url":"https://api.github.com/users/hackedbellini/repos","events_url":"https://api.github.com/users/hackedbellini/events{/privacy}","received_events_url":"https://api.github.com/users/hackedbellini/received_events","type":"User","site_admin":false},"body":"Datagrid will segfault on some _very rare_ occasions. Tracking it with\r\ngdb showed that the crash happened when calling IconView.choose_icon.\r\n\r\nOne of the possible reasons for this would be 2 threads accessing\r\nthe same object at the same time. So, the issue might be solved\r\nby using another IconTheme instead of the default one.\r\n\r\nAlso, do a little optimization by caching the icon_filename based\r\non the file mime type.\r\n\r\n@tomanderson2 like I said to you on slack, this should solve the problem! If not, we can try to disable the \"load images on another thread\" (by setting [this](https://github.com/nowsecure/datagrid-gtk3/blob/master/datagrid_gtk3/ui/grid.py#L1569) to `False`) to test if the issue vanishes.","created_at":"2015-06-11T22:04:14Z","updated_at":"2015-06-12T14:59:00Z","closed_at":"2015-06-12T14:59:00Z","merged_at":"2015-06-12T14:59:00Z","merge_commit_sha":"86fe58ba872d155ea29b1d79752b9b3bd234bca8","assignee":{"login":"hackedbellini","id":134025,"avatar_url":"https://avatars.githubusercontent.com/u/134025?v=3","gravatar_id":"","url":"https://api.github.com/users/hackedbellini","html_url":"https://github.com/hackedbellini","followers_url":"https://api.github.com/users/hackedbellini/followers","following_url":"https://api.github.com/users/hackedbellini/following{/other_user}","gists_url":"https://api.github.com/users/hackedbellini/gists{/gist_id}","starred_url":"https://api.github.com/users/hackedbellini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackedbellini/subscriptions","organizations_url":"https://api.github.com/users/hackedbellini/orgs","repos_url":"https://api.github.com/users/hackedbellini/repos","events_url":"https://api.github.com/users/hackedbellini/events{/privacy}","received_events_url":"https://api.github.com/users/hackedbellini/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69/commits","review_comments_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69/comments","review_comment_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/69/comments","statuses_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/statuses/6f794edf77716c499a3315ae11dba8eb9150ee53","head":{"label":"nowsecure:segfault","ref":"segfault","sha":"6f794edf77716c499a3315ae11dba8eb9150ee53","user":{"login":"nowsecure","id":9845651,"avatar_url":"https://avatars.githubusercontent.com/u/9845651?v=3","gravatar_id":"","url":"https://api.github.com/users/nowsecure","html_url":"https://github.com/nowsecure","followers_url":"https://api.github.com/users/nowsecure/followers","following_url":"https://api.github.com/users/nowsecure/following{/other_user}","gists_url":"https://api.github.com/users/nowsecure/gists{/gist_id}","starred_url":"https://api.github.com/users/nowsecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nowsecure/subscriptions","organizations_url":"https://api.github.com/users/nowsecure/orgs","repos_url":"https://api.github.com/users/nowsecure/repos","events_url":"https://api.github.com/users/nowsecure/events{/privacy}","received_events_url":"https://api.github.com/users/nowsecure/received_events","type":"Organization","site_admin":false},"repo":{"id":29144664,"name":"datagrid-gtk3","full_name":"nowsecure/datagrid-gtk3","owner":{"login":"nowsecure","id":9845651,"avatar_url":"https://avatars.githubusercontent.com/u/9845651?v=3","gravatar_id":"","url":"https://api.github.com/users/nowsecure","html_url":"https://github.com/nowsecure","followers_url":"https://api.github.com/users/nowsecure/followers","following_url":"https://api.github.com/users/nowsecure/following{/other_user}","gists_url":"https://api.github.com/users/nowsecure/gists{/gist_id}","starred_url":"https://api.github.com/users/nowsecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nowsecure/subscriptions","organizations_url":"https://api.github.com/users/nowsecure/orgs","repos_url":"https://api.github.com/users/nowsecure/repos","events_url":"https://api.github.com/users/nowsecure/events{/privacy}","received_events_url":"https://api.github.com/users/nowsecure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nowsecure/datagrid-gtk3","description":"MVC framework for working with the Gtk3 TreeView widget","fork":false,"url":"https://api.github.com/repos/nowsecure/datagrid-gtk3","forks_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/forks","keys_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/teams","hooks_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/hooks","issue_events_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/events{/number}","events_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/events","assignees_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/assignees{/user}","branches_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/branches{/branch}","tags_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/tags","blobs_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/refs{/sha}","trees_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/statuses/{sha}","languages_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/languages","stargazers_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/stargazers","contributors_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/contributors","subscribers_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/subscribers","subscription_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/subscription","commits_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/commits{/sha}","git_commits_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/commits{/sha}","comments_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/comments{/number}","issue_comment_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/comments{/number}","contents_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/contents/{+path}","compare_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/merges","archive_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/downloads","issues_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues{/number}","pulls_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls{/number}","milestones_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/milestones{/number}","notifications_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/labels{/name}","releases_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/releases{/id}","created_at":"2015-01-12T16:27:45Z","updated_at":"2015-04-27T16:44:48Z","pushed_at":"2015-06-12T14:59:00Z","git_url":"git://github.com/nowsecure/datagrid-gtk3.git","ssh_url":"git@github.com:nowsecure/datagrid-gtk3.git","clone_url":"https://github.com/nowsecure/datagrid-gtk3.git","svn_url":"https://github.com/nowsecure/datagrid-gtk3","homepage":"","size":3492,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"nowsecure:master","ref":"master","sha":"f3888079fc8b2eb48a9b2b2cc19ae0e970b342a7","user":{"login":"nowsecure","id":9845651,"avatar_url":"https://avatars.githubusercontent.com/u/9845651?v=3","gravatar_id":"","url":"https://api.github.com/users/nowsecure","html_url":"https://github.com/nowsecure","followers_url":"https://api.github.com/users/nowsecure/followers","following_url":"https://api.github.com/users/nowsecure/following{/other_user}","gists_url":"https://api.github.com/users/nowsecure/gists{/gist_id}","starred_url":"https://api.github.com/users/nowsecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nowsecure/subscriptions","organizations_url":"https://api.github.com/users/nowsecure/orgs","repos_url":"https://api.github.com/users/nowsecure/repos","events_url":"https://api.github.com/users/nowsecure/events{/privacy}","received_events_url":"https://api.github.com/users/nowsecure/received_events","type":"Organization","site_admin":false},"repo":{"id":29144664,"name":"datagrid-gtk3","full_name":"nowsecure/datagrid-gtk3","owner":{"login":"nowsecure","id":9845651,"avatar_url":"https://avatars.githubusercontent.com/u/9845651?v=3","gravatar_id":"","url":"https://api.github.com/users/nowsecure","html_url":"https://github.com/nowsecure","followers_url":"https://api.github.com/users/nowsecure/followers","following_url":"https://api.github.com/users/nowsecure/following{/other_user}","gists_url":"https://api.github.com/users/nowsecure/gists{/gist_id}","starred_url":"https://api.github.com/users/nowsecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nowsecure/subscriptions","organizations_url":"https://api.github.com/users/nowsecure/orgs","repos_url":"https://api.github.com/users/nowsecure/repos","events_url":"https://api.github.com/users/nowsecure/events{/privacy}","received_events_url":"https://api.github.com/users/nowsecure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nowsecure/datagrid-gtk3","description":"MVC framework for working with the Gtk3 TreeView widget","fork":false,"url":"https://api.github.com/repos/nowsecure/datagrid-gtk3","forks_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/forks","keys_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/teams","hooks_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/hooks","issue_events_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/events{/number}","events_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/events","assignees_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/assignees{/user}","branches_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/branches{/branch}","tags_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/tags","blobs_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/refs{/sha}","trees_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/statuses/{sha}","languages_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/languages","stargazers_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/stargazers","contributors_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/contributors","subscribers_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/subscribers","subscription_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/subscription","commits_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/commits{/sha}","git_commits_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/git/commits{/sha}","comments_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/comments{/number}","issue_comment_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/comments{/number}","contents_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/contents/{+path}","compare_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/merges","archive_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/downloads","issues_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues{/number}","pulls_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls{/number}","milestones_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/milestones{/number}","notifications_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/labels{/name}","releases_url":"https://api.github.com/repos/nowsecure/datagrid-gtk3/releases{/id}","created_at":"2015-01-12T16:27:45Z","updated_at":"2015-04-27T16:44:48Z","pushed_at":"2015-06-12T14:59:00Z","git_url":"git://github.com/nowsecure/datagrid-gtk3.git","ssh_url":"git@github.com:nowsecure/datagrid-gtk3.git","clone_url":"https://github.com/nowsecure/datagrid-gtk3.git","svn_url":"https://github.com/nowsecure/datagrid-gtk3","homepage":"","size":3492,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69"},"html":{"href":"https://github.com/nowsecure/datagrid-gtk3/pull/69"},"issue":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/69"},"comments":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/nowsecure/datagrid-gtk3/statuses/6f794edf77716c499a3315ae11dba8eb9150ee53"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hackedbellini","id":134025,"avatar_url":"https://avatars.githubusercontent.com/u/134025?v=3","gravatar_id":"","url":"https://api.github.com/users/hackedbellini","html_url":"https://github.com/hackedbellini","followers_url":"https://api.github.com/users/hackedbellini/followers","following_url":"https://api.github.com/users/hackedbellini/following{/other_user}","gists_url":"https://api.github.com/users/hackedbellini/gists{/gist_id}","starred_url":"https://api.github.com/users/hackedbellini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackedbellini/subscriptions","organizations_url":"https://api.github.com/users/hackedbellini/orgs","repos_url":"https://api.github.com/users/hackedbellini/repos","events_url":"https://api.github.com/users/hackedbellini/events{/privacy}","received_events_url":"https://api.github.com/users/hackedbellini/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":17,"deletions":8,"changed_files":1}}