{"action":"created","comment":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/comments/26103974","id":26103974,"diff_hunk":"@@ -151,7 +151,7 @@ ol.renderer.Layer.prototype.loadImage = function(image) {\n     // listener (a noop if the listener was already registered)\n     goog.asserts.assert(imageState == ol.ImageState.IDLE ||\n         imageState == ol.ImageState.LOADING);\n-    goog.events.listenOnce(image, goog.events.EventType.CHANGE,\n+    goog.events.listen(image, goog.events.EventType.CHANGE,","path":"src/ol/renderer/layerrenderer.js","position":5,"original_position":5,"commit_id":"2cc5cea098cb0507fb023e5eac2d30a4dc85c2f1","original_commit_id":"2cc5cea098cb0507fb023e5eac2d30a4dc85c2f1","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars.githubusercontent.com/u/319678?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"But registerDisposable only associates the image with the source so that the image gets disposed when the source gets disposed? Though I am not sure when or if the source will be disposed.\r\nI'll investigate a bit more to confirm the GC cleans up.","created_at":"2015-03-10T08:09:34Z","updated_at":"2015-03-10T08:09:34Z","html_url":"https://github.com/openlayers/ol3/pull/3305#discussion_r26103974","pull_request_url":"https://api.github.com/repos/openlayers/ol3/pulls/3305","_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments/26103974"},"html":{"href":"https://github.com/openlayers/ol3/pull/3305#discussion_r26103974"},"pull_request":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/3305"}}},"pull_request":{"url":"https://api.github.com/repos/openlayers/ol3/pulls/3305","id":30401436,"html_url":"https://github.com/openlayers/ol3/pull/3305","diff_url":"https://github.com/openlayers/ol3/pull/3305.diff","patch_url":"https://github.com/openlayers/ol3/pull/3305.patch","issue_url":"https://api.github.com/repos/openlayers/ol3/issues/3305","number":3305,"state":"open","locked":false,"title":"Add image loading events to image sources","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars.githubusercontent.com/u/319678?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"This follows up on #3248 and adds support for image based sources as well.","created_at":"2015-03-03T18:54:16Z","updated_at":"2015-03-10T08:09:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbbc6285d432e44a0fdc7bd3094085bf680a44a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openlayers/ol3/pulls/3305/commits","review_comments_url":"https://api.github.com/repos/openlayers/ol3/pulls/3305/comments","review_comment_url":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openlayers/ol3/issues/3305/comments","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/2cc5cea098cb0507fb023e5eac2d30a4dc85c2f1","head":{"label":"bartvde:image-load-events","ref":"image-load-events","sha":"2cc5cea098cb0507fb023e5eac2d30a4dc85c2f1","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars.githubusercontent.com/u/319678?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"repo":{"id":7622951,"name":"ol3","full_name":"bartvde/ol3","owner":{"login":"bartvde","id":319678,"avatar_url":"https://avatars.githubusercontent.com/u/319678?v=3","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartvde/ol3","description":"OpenLayers 3","fork":true,"url":"https://api.github.com/repos/bartvde/ol3","forks_url":"https://api.github.com/repos/bartvde/ol3/forks","keys_url":"https://api.github.com/repos/bartvde/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartvde/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartvde/ol3/teams","hooks_url":"https://api.github.com/repos/bartvde/ol3/hooks","issue_events_url":"https://api.github.com/repos/bartvde/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/bartvde/ol3/events","assignees_url":"https://api.github.com/repos/bartvde/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/bartvde/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/bartvde/ol3/tags","blobs_url":"https://api.github.com/repos/bartvde/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartvde/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartvde/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartvde/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartvde/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/bartvde/ol3/languages","stargazers_url":"https://api.github.com/repos/bartvde/ol3/stargazers","contributors_url":"https://api.github.com/repos/bartvde/ol3/contributors","subscribers_url":"https://api.github.com/repos/bartvde/ol3/subscribers","subscription_url":"https://api.github.com/repos/bartvde/ol3/subscription","commits_url":"https://api.github.com/repos/bartvde/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartvde/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartvde/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartvde/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartvde/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/bartvde/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartvde/ol3/merges","archive_url":"https://api.github.com/repos/bartvde/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartvde/ol3/downloads","issues_url":"https://api.github.com/repos/bartvde/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/bartvde/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/bartvde/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/bartvde/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartvde/ol3/labels{/name}","releases_url":"https://api.github.com/repos/bartvde/ol3/releases{/id}","created_at":"2013-01-15T10:39:47Z","updated_at":"2015-03-03T15:29:01Z","pushed_at":"2015-03-04T21:06:44Z","git_url":"git://github.com/bartvde/ol3.git","ssh_url":"git@github.com:bartvde/ol3.git","clone_url":"https://github.com/bartvde/ol3.git","svn_url":"https://github.com/bartvde/ol3","homepage":null,"size":29726,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openlayers:master","ref":"master","sha":"a629be0e2ea569c8b233680112b37b41e405109f","user":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"repo":{"id":4723248,"name":"ol3","full_name":"openlayers/ol3","owner":{"login":"openlayers","id":240579,"avatar_url":"https://avatars.githubusercontent.com/u/240579?v=3","gravatar_id":"","url":"https://api.github.com/users/openlayers","html_url":"https://github.com/openlayers","followers_url":"https://api.github.com/users/openlayers/followers","following_url":"https://api.github.com/users/openlayers/following{/other_user}","gists_url":"https://api.github.com/users/openlayers/gists{/gist_id}","starred_url":"https://api.github.com/users/openlayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openlayers/subscriptions","organizations_url":"https://api.github.com/users/openlayers/orgs","repos_url":"https://api.github.com/users/openlayers/repos","events_url":"https://api.github.com/users/openlayers/events{/privacy}","received_events_url":"https://api.github.com/users/openlayers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openlayers/ol3","description":"OpenLayers 3","fork":false,"url":"https://api.github.com/repos/openlayers/ol3","forks_url":"https://api.github.com/repos/openlayers/ol3/forks","keys_url":"https://api.github.com/repos/openlayers/ol3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openlayers/ol3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openlayers/ol3/teams","hooks_url":"https://api.github.com/repos/openlayers/ol3/hooks","issue_events_url":"https://api.github.com/repos/openlayers/ol3/issues/events{/number}","events_url":"https://api.github.com/repos/openlayers/ol3/events","assignees_url":"https://api.github.com/repos/openlayers/ol3/assignees{/user}","branches_url":"https://api.github.com/repos/openlayers/ol3/branches{/branch}","tags_url":"https://api.github.com/repos/openlayers/ol3/tags","blobs_url":"https://api.github.com/repos/openlayers/ol3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openlayers/ol3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openlayers/ol3/git/refs{/sha}","trees_url":"https://api.github.com/repos/openlayers/ol3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openlayers/ol3/statuses/{sha}","languages_url":"https://api.github.com/repos/openlayers/ol3/languages","stargazers_url":"https://api.github.com/repos/openlayers/ol3/stargazers","contributors_url":"https://api.github.com/repos/openlayers/ol3/contributors","subscribers_url":"https://api.github.com/repos/openlayers/ol3/subscribers","subscription_url":"https://api.github.com/repos/openlayers/ol3/subscription","commits_url":"https://api.github.com/repos/openlayers/ol3/commits{/sha}","git_commits_url":"https://api.github.com/repos/openlayers/ol3/git/commits{/sha}","comments_url":"https://api.github.com/repos/openlayers/ol3/comments{/number}","issue_comment_url":"https://api.github.com/repos/openlayers/ol3/issues/comments{/number}","contents_url":"https://api.github.com/repos/openlayers/ol3/contents/{+path}","compare_url":"https://api.github.com/repos/openlayers/ol3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openlayers/ol3/merges","archive_url":"https://api.github.com/repos/openlayers/ol3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openlayers/ol3/downloads","issues_url":"https://api.github.com/repos/openlayers/ol3/issues{/number}","pulls_url":"https://api.github.com/repos/openlayers/ol3/pulls{/number}","milestones_url":"https://api.github.com/repos/openlayers/ol3/milestones{/number}","notifications_url":"https://api.github.com/repos/openlayers/ol3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openlayers/ol3/labels{/name}","releases_url":"https://api.github.com/repos/openlayers/ol3/releases{/id}","created_at":"2012-06-20T06:53:59Z","updated_at":"2015-03-10T00:42:09Z","pushed_at":"2015-03-09T16:15:20Z","git_url":"git://github.com/openlayers/ol3.git","ssh_url":"git@github.com:openlayers/ol3.git","clone_url":"https://github.com/openlayers/ol3.git","svn_url":"https://github.com/openlayers/ol3","homepage":"http://openlayers.org","size":68787,"stargazers_count":1008,"watchers_count":1008,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":597,"mirror_url":null,"open_issues_count":287,"forks":597,"open_issues":287,"watchers":1008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/3305"},"html":{"href":"https://github.com/openlayers/ol3/pull/3305"},"issue":{"href":"https://api.github.com/repos/openlayers/ol3/issues/3305"},"comments":{"href":"https://api.github.com/repos/openlayers/ol3/issues/3305/comments"},"review_comments":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/3305/comments"},"review_comment":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openlayers/ol3/pulls/3305/commits"},"statuses":{"href":"https://api.github.com/repos/openlayers/ol3/statuses/2cc5cea098cb0507fb023e5eac2d30a4dc85c2f1"}}}}