{"action":"created","comment":{"url":"https://api.github.com/repos/pbs/pycaption/pulls/comments/45466460","id":45466460,"diff_hunk":"@@ -217,6 +240,15 @@ def _format_timestamp(self, value, msec_separator=None):\n         return u'0' + str_value\n \n \n+class CaptionList(list):","path":"pycaption/base.py","position":52,"original_position":52,"commit_id":"5c38167d7349b0df2a14cb65bad77ae3e755cb98","original_commit_id":"5c38167d7349b0df2a14cb65bad77ae3e755cb98","user":{"login":"vladiibine","id":6544669,"avatar_url":"https://avatars.githubusercontent.com/u/6544669?v=3","gravatar_id":"","url":"https://api.github.com/users/vladiibine","html_url":"https://github.com/vladiibine","followers_url":"https://api.github.com/users/vladiibine/followers","following_url":"https://api.github.com/users/vladiibine/following{/other_user}","gists_url":"https://api.github.com/users/vladiibine/gists{/gist_id}","starred_url":"https://api.github.com/users/vladiibine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladiibine/subscriptions","organizations_url":"https://api.github.com/users/vladiibine/orgs","repos_url":"https://api.github.com/users/vladiibine/repos","events_url":"https://api.github.com/users/vladiibine/events{/privacy}","received_events_url":"https://api.github.com/users/vladiibine/received_events","type":"User","site_admin":false},"body":"This class belongs more into the `specialized_collections` module","created_at":"2015-11-20T13:06:47Z","updated_at":"2015-11-20T13:06:47Z","html_url":"https://github.com/pbs/pycaption/pull/120#discussion_r45466460","pull_request_url":"https://api.github.com/repos/pbs/pycaption/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/comments/45466460"},"html":{"href":"https://github.com/pbs/pycaption/pull/120#discussion_r45466460"},"pull_request":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/pbs/pycaption/pulls/120","id":51225607,"html_url":"https://github.com/pbs/pycaption/pull/120","diff_url":"https://github.com/pbs/pycaption/pull/120.diff","patch_url":"https://github.com/pbs/pycaption/pull/120.patch","issue_url":"https://api.github.com/repos/pbs/pycaption/issues/120","number":120,"state":"open","locked":false,"title":"Caption init","user":{"login":"arielpontes","id":1641431,"avatar_url":"https://avatars.githubusercontent.com/u/1641431?v=3","gravatar_id":"","url":"https://api.github.com/users/arielpontes","html_url":"https://github.com/arielpontes","followers_url":"https://api.github.com/users/arielpontes/followers","following_url":"https://api.github.com/users/arielpontes/following{/other_user}","gists_url":"https://api.github.com/users/arielpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/arielpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielpontes/subscriptions","organizations_url":"https://api.github.com/users/arielpontes/orgs","repos_url":"https://api.github.com/users/arielpontes/repos","events_url":"https://api.github.com/users/arielpontes/events{/privacy}","received_events_url":"https://api.github.com/users/arielpontes/received_events","type":"User","site_admin":false},"body":"Currently Caption objects are created empty and are initialized afterwards. This causes the initialization code to be duplicated whenever such objects are created and makes refactoring extremely difficult because if something changes in the initialization logic, the change might have to be done in multiple places. This pull requests moves the initialization to the __init__ method, which exists exactly for this purpose.","created_at":"2015-11-19T14:02:46Z","updated_at":"2015-11-20T13:06:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f0d7b41f8f5b8bb12ed7442e3a01451354d7f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pbs/pycaption/pulls/120/commits","review_comments_url":"https://api.github.com/repos/pbs/pycaption/pulls/120/comments","review_comment_url":"https://api.github.com/repos/pbs/pycaption/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pbs/pycaption/issues/120/comments","statuses_url":"https://api.github.com/repos/pbs/pycaption/statuses/5c38167d7349b0df2a14cb65bad77ae3e755cb98","head":{"label":"arielpontes:caption-init","ref":"caption-init","sha":"5c38167d7349b0df2a14cb65bad77ae3e755cb98","user":{"login":"arielpontes","id":1641431,"avatar_url":"https://avatars.githubusercontent.com/u/1641431?v=3","gravatar_id":"","url":"https://api.github.com/users/arielpontes","html_url":"https://github.com/arielpontes","followers_url":"https://api.github.com/users/arielpontes/followers","following_url":"https://api.github.com/users/arielpontes/following{/other_user}","gists_url":"https://api.github.com/users/arielpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/arielpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielpontes/subscriptions","organizations_url":"https://api.github.com/users/arielpontes/orgs","repos_url":"https://api.github.com/users/arielpontes/repos","events_url":"https://api.github.com/users/arielpontes/events{/privacy}","received_events_url":"https://api.github.com/users/arielpontes/received_events","type":"User","site_admin":false},"repo":{"id":32785272,"name":"pycaption","full_name":"arielpontes/pycaption","owner":{"login":"arielpontes","id":1641431,"avatar_url":"https://avatars.githubusercontent.com/u/1641431?v=3","gravatar_id":"","url":"https://api.github.com/users/arielpontes","html_url":"https://github.com/arielpontes","followers_url":"https://api.github.com/users/arielpontes/followers","following_url":"https://api.github.com/users/arielpontes/following{/other_user}","gists_url":"https://api.github.com/users/arielpontes/gists{/gist_id}","starred_url":"https://api.github.com/users/arielpontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielpontes/subscriptions","organizations_url":"https://api.github.com/users/arielpontes/orgs","repos_url":"https://api.github.com/users/arielpontes/repos","events_url":"https://api.github.com/users/arielpontes/events{/privacy}","received_events_url":"https://api.github.com/users/arielpontes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arielpontes/pycaption","description":"Python module to read/write popular video caption formats","fork":true,"url":"https://api.github.com/repos/arielpontes/pycaption","forks_url":"https://api.github.com/repos/arielpontes/pycaption/forks","keys_url":"https://api.github.com/repos/arielpontes/pycaption/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arielpontes/pycaption/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arielpontes/pycaption/teams","hooks_url":"https://api.github.com/repos/arielpontes/pycaption/hooks","issue_events_url":"https://api.github.com/repos/arielpontes/pycaption/issues/events{/number}","events_url":"https://api.github.com/repos/arielpontes/pycaption/events","assignees_url":"https://api.github.com/repos/arielpontes/pycaption/assignees{/user}","branches_url":"https://api.github.com/repos/arielpontes/pycaption/branches{/branch}","tags_url":"https://api.github.com/repos/arielpontes/pycaption/tags","blobs_url":"https://api.github.com/repos/arielpontes/pycaption/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arielpontes/pycaption/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arielpontes/pycaption/git/refs{/sha}","trees_url":"https://api.github.com/repos/arielpontes/pycaption/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arielpontes/pycaption/statuses/{sha}","languages_url":"https://api.github.com/repos/arielpontes/pycaption/languages","stargazers_url":"https://api.github.com/repos/arielpontes/pycaption/stargazers","contributors_url":"https://api.github.com/repos/arielpontes/pycaption/contributors","subscribers_url":"https://api.github.com/repos/arielpontes/pycaption/subscribers","subscription_url":"https://api.github.com/repos/arielpontes/pycaption/subscription","commits_url":"https://api.github.com/repos/arielpontes/pycaption/commits{/sha}","git_commits_url":"https://api.github.com/repos/arielpontes/pycaption/git/commits{/sha}","comments_url":"https://api.github.com/repos/arielpontes/pycaption/comments{/number}","issue_comment_url":"https://api.github.com/repos/arielpontes/pycaption/issues/comments{/number}","contents_url":"https://api.github.com/repos/arielpontes/pycaption/contents/{+path}","compare_url":"https://api.github.com/repos/arielpontes/pycaption/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arielpontes/pycaption/merges","archive_url":"https://api.github.com/repos/arielpontes/pycaption/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arielpontes/pycaption/downloads","issues_url":"https://api.github.com/repos/arielpontes/pycaption/issues{/number}","pulls_url":"https://api.github.com/repos/arielpontes/pycaption/pulls{/number}","milestones_url":"https://api.github.com/repos/arielpontes/pycaption/milestones{/number}","notifications_url":"https://api.github.com/repos/arielpontes/pycaption/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arielpontes/pycaption/labels{/name}","releases_url":"https://api.github.com/repos/arielpontes/pycaption/releases{/id}","created_at":"2015-03-24T08:11:43Z","updated_at":"2015-03-24T08:11:44Z","pushed_at":"2015-11-19T13:58:18Z","git_url":"git://github.com/arielpontes/pycaption.git","ssh_url":"git@github.com:arielpontes/pycaption.git","clone_url":"https://github.com/arielpontes/pycaption.git","svn_url":"https://github.com/arielpontes/pycaption","homepage":"","size":1087,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pbs:master","ref":"master","sha":"5c2d04716302db3a7607deb7da693e0bff70184f","user":{"login":"pbs","id":547533,"avatar_url":"https://avatars.githubusercontent.com/u/547533?v=3","gravatar_id":"","url":"https://api.github.com/users/pbs","html_url":"https://github.com/pbs","followers_url":"https://api.github.com/users/pbs/followers","following_url":"https://api.github.com/users/pbs/following{/other_user}","gists_url":"https://api.github.com/users/pbs/gists{/gist_id}","starred_url":"https://api.github.com/users/pbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbs/subscriptions","organizations_url":"https://api.github.com/users/pbs/orgs","repos_url":"https://api.github.com/users/pbs/repos","events_url":"https://api.github.com/users/pbs/events{/privacy}","received_events_url":"https://api.github.com/users/pbs/received_events","type":"Organization","site_admin":false},"repo":{"id":4519236,"name":"pycaption","full_name":"pbs/pycaption","owner":{"login":"pbs","id":547533,"avatar_url":"https://avatars.githubusercontent.com/u/547533?v=3","gravatar_id":"","url":"https://api.github.com/users/pbs","html_url":"https://github.com/pbs","followers_url":"https://api.github.com/users/pbs/followers","following_url":"https://api.github.com/users/pbs/following{/other_user}","gists_url":"https://api.github.com/users/pbs/gists{/gist_id}","starred_url":"https://api.github.com/users/pbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbs/subscriptions","organizations_url":"https://api.github.com/users/pbs/orgs","repos_url":"https://api.github.com/users/pbs/repos","events_url":"https://api.github.com/users/pbs/events{/privacy}","received_events_url":"https://api.github.com/users/pbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pbs/pycaption","description":"Python module to read/write popular video caption formats","fork":false,"url":"https://api.github.com/repos/pbs/pycaption","forks_url":"https://api.github.com/repos/pbs/pycaption/forks","keys_url":"https://api.github.com/repos/pbs/pycaption/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbs/pycaption/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbs/pycaption/teams","hooks_url":"https://api.github.com/repos/pbs/pycaption/hooks","issue_events_url":"https://api.github.com/repos/pbs/pycaption/issues/events{/number}","events_url":"https://api.github.com/repos/pbs/pycaption/events","assignees_url":"https://api.github.com/repos/pbs/pycaption/assignees{/user}","branches_url":"https://api.github.com/repos/pbs/pycaption/branches{/branch}","tags_url":"https://api.github.com/repos/pbs/pycaption/tags","blobs_url":"https://api.github.com/repos/pbs/pycaption/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbs/pycaption/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbs/pycaption/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbs/pycaption/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbs/pycaption/statuses/{sha}","languages_url":"https://api.github.com/repos/pbs/pycaption/languages","stargazers_url":"https://api.github.com/repos/pbs/pycaption/stargazers","contributors_url":"https://api.github.com/repos/pbs/pycaption/contributors","subscribers_url":"https://api.github.com/repos/pbs/pycaption/subscribers","subscription_url":"https://api.github.com/repos/pbs/pycaption/subscription","commits_url":"https://api.github.com/repos/pbs/pycaption/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbs/pycaption/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbs/pycaption/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbs/pycaption/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbs/pycaption/contents/{+path}","compare_url":"https://api.github.com/repos/pbs/pycaption/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbs/pycaption/merges","archive_url":"https://api.github.com/repos/pbs/pycaption/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbs/pycaption/downloads","issues_url":"https://api.github.com/repos/pbs/pycaption/issues{/number}","pulls_url":"https://api.github.com/repos/pbs/pycaption/pulls{/number}","milestones_url":"https://api.github.com/repos/pbs/pycaption/milestones{/number}","notifications_url":"https://api.github.com/repos/pbs/pycaption/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbs/pycaption/labels{/name}","releases_url":"https://api.github.com/repos/pbs/pycaption/releases{/id}","created_at":"2012-06-01T12:11:46Z","updated_at":"2015-10-29T13:40:44Z","pushed_at":"2015-11-20T12:40:48Z","git_url":"git://github.com/pbs/pycaption.git","ssh_url":"git@github.com:pbs/pycaption.git","clone_url":"https://github.com/pbs/pycaption.git","svn_url":"https://github.com/pbs/pycaption","homepage":"","size":1375,"stargazers_count":76,"watchers_count":76,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":28,"forks":46,"open_issues":28,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/120"},"html":{"href":"https://github.com/pbs/pycaption/pull/120"},"issue":{"href":"https://api.github.com/repos/pbs/pycaption/issues/120"},"comments":{"href":"https://api.github.com/repos/pbs/pycaption/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pbs/pycaption/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/pbs/pycaption/statuses/5c38167d7349b0df2a14cb65bad77ae3e755cb98"}}}}