{"action":"created","issue":{"url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/355","labels_url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/355/labels{/name}","comments_url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/355/comments","events_url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/355/events","html_url":"https://github.com/dragonjet/KC3Kai/issues/355","id":96514346,"number":355,"title":"Translation Mechanism Change","user":{"login":"dragonjet","id":557312,"avatar_url":"https://avatars.githubusercontent.com/u/557312?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonjet","html_url":"https://github.com/dragonjet","followers_url":"https://api.github.com/users/dragonjet/followers","following_url":"https://api.github.com/users/dragonjet/following{/other_user}","gists_url":"https://api.github.com/users/dragonjet/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonjet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonjet/subscriptions","organizations_url":"https://api.github.com/users/dragonjet/orgs","repos_url":"https://api.github.com/users/dragonjet/repos","events_url":"https://api.github.com/users/dragonjet/events{/privacy}","received_events_url":"https://api.github.com/users/dragonjet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dragonjet/KC3Kai/labels/rework","name":"rework","color":"5319e7"},{"url":"https://api.github.com/repos/dragonjet/KC3Kai/labels/translation","name":"translation","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-07-22T08:59:07Z","updated_at":"2015-07-24T01:55:40Z","closed_at":null,"body":"#### To everyone:\r\nAs of f693393bcb912a0223293df76818d667f0683705\r\n\r\nI'll be pushing a change in our translation mechanism. This is derived from @Diablohu's enhancements which use **synchronous ajax** to load json files. I moved the json loader function from `Meta.js` to `Translation.js`.\r\n\r\nAdditionally,  `Meta.js` receives data directly not via callback but by return value since its synchronous anyway. e.g.:\r\n```\r\nthis._ship = KC3Translation.getJSON(repo, 'ships');\r\n```\r\n\r\nAlso, it does not extend the English counterparts, for reasons stated on a section below\r\n\r\n#### To translators:\r\n\r\nThe main difference for translators is that `developers.json` and `settings.json` no longer need to be inside your localized folder.\r\n\r\nThese two files are now common files for all languages and moved to `\\src\\data\\`, **not under `\\src\\data\\translations\\xx\\`**. To be able to provide translations to itss labels, all of those words were moved to `terms.json`.\r\n\r\nSorry for the inconvenience but those who already have existing translations for `developers.json` and `settings.json`, I ask that you copy paste the words into your `terms.json`. You may check `en` folder's `terms.json` to copy the variable names such as `SettingsCraftBox`, etc.\r\n\r\ne.g. ca2b2113243ab45afd7f430b84a589f06a340fca\r\n```\r\n\"SettingsGameInfo\" : \"Game Information\",\r\n\"SettingsConstructionFaces\" : \"Construction Faces\",\r\n\"SettingsCraftBox\" : \"Crafting Results\",\r\n\"SettingsCompass\" : \"Compass and Enemy\",\r\n\"SettingsBattleData\" : \"Battle Environment\",\r\n\"SettingsBossComp\" : \"Boss Composition\",\r\n```\r\n\r\n#### Reasons and Advantages\r\n* **About merging all developers and settings**: Now you do not need to subscribe to changes in `developers.json` and `settings.json`. You mostly just need to monitor `terms.json` from now on, which is an evolving file anyways and will get more words in the near future either way, esp when we apply TL to strategy room.\r\n* **About not extending English data**: It is intended that if a file or word is missing from a language, it will show up as a variable such as `MenuSettingsDesc`, and not its English counterpart. This is to let users know that the translation is either new or not yet done, and not conceiving it as a bug that we missed the word somewhere.\r\n* **Other notes**: `Theme` names are really not translated. They are names. So \"Dark Theme\" is called \"Dark Theme\" on the choices in all languages. A \"V-Ten\" theme is also \"V-Ten\" in all languages.\r\n\r\n#### Tag\r\n@nicky008 @kololz @Diablohu @freezebear @hufuhufu @vrarara @Arkayda963 @RanFoxRun @bamboo3250\r\n\r\nI have already started a sample for `jp`, hope @nicky008 can continue copying, and there are also new words like \"*Coders*\", \"*None*\", etc\r\n\r\nSorry for the inconvenience."},"comment":{"url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/comments/124290687","html_url":"https://github.com/dragonjet/KC3Kai/issues/355#issuecomment-124290687","issue_url":"https://api.github.com/repos/dragonjet/KC3Kai/issues/355","id":124290687,"user":{"login":"nicky008","id":10517990,"avatar_url":"https://avatars.githubusercontent.com/u/10517990?v=3","gravatar_id":"","url":"https://api.github.com/users/nicky008","html_url":"https://github.com/nicky008","followers_url":"https://api.github.com/users/nicky008/followers","following_url":"https://api.github.com/users/nicky008/following{/other_user}","gists_url":"https://api.github.com/users/nicky008/gists{/gist_id}","starred_url":"https://api.github.com/users/nicky008/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicky008/subscriptions","organizations_url":"https://api.github.com/users/nicky008/orgs","repos_url":"https://api.github.com/users/nicky008/repos","events_url":"https://api.github.com/users/nicky008/events{/privacy}","received_events_url":"https://api.github.com/users/nicky008/received_events","type":"User","site_admin":false},"created_at":"2015-07-24T01:55:40Z","updated_at":"2015-07-24T01:55:40Z","body":"@dragonjet I think, for now, just decreasing `font-size` is still enough for mine. "}}