{"action":"created","comment":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/comments/37404089","id":37404089,"diff_hunk":"@@ -5719,6 +5747,21 @@ static const mce_opt_t options[] =\n                         \"set the delay for dumping core from unresponsive lipstick\\n\"\n         },\n         {\n+                .name        = \"set-input-policy-mode\",\n+                .with_arg    = xmce_set_input_policy_mode,\n+                .values      = \"enabled|disabled\",\n+                .usage       =\n+                        \"allow/deny grabbing of input devices based on input policy\\n\"\n+                        \"\\n\"\n+                        \"Normally this should be always set to 'enabled'.\\n\"","path":"tools/mcetool.c","position":52,"original_position":52,"commit_id":"ccc324d65e26453f5625f86c67201ac3116a1556","original_commit_id":"ccc324d65e26453f5625f86c67201ac3116a1556","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"body":"When display is powered up, the touch input grab is kept until mce thinks\r\na) the display is no longer touched by finger or palm (jolla has palm detection)\r\nb) proximity sensor is not covered (optional)\r\nc) lid sensor says the display is not covered (nexus5 etc)\r\n\r\nIn practice would:\r\n* make stray input during in-call blanking more possible when proximity sensor is briefly uncovered while the device is held at ear.\r\n* break the \"lpm\" mode (where only mce is supposed to handle touch events)","created_at":"2015-08-19T11:26:12Z","updated_at":"2015-08-19T11:26:12Z","html_url":"https://github.com/nemomobile/mce/pull/310#discussion_r37404089","pull_request_url":"https://api.github.com/repos/nemomobile/mce/pulls/310","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments/37404089"},"html":{"href":"https://github.com/nemomobile/mce/pull/310#discussion_r37404089"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/nemomobile/mce/pulls/310","id":42801262,"html_url":"https://github.com/nemomobile/mce/pull/310","diff_url":"https://github.com/nemomobile/mce/pull/310.diff","patch_url":"https://github.com/nemomobile/mce/pull/310.patch","issue_url":"https://api.github.com/repos/nemomobile/mce/issues/310","number":310,"state":"open","locked":false,"title":"Add setting to disable input device grabbing","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-19T10:59:38Z","updated_at":"2015-08-19T11:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"464997c1c522fbcf1110b3816306de98c2256c25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nemomobile/mce/pulls/310/commits","review_comments_url":"https://api.github.com/repos/nemomobile/mce/pulls/310/comments","review_comment_url":"https://api.github.com/repos/nemomobile/mce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nemomobile/mce/issues/310/comments","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/ccc324d65e26453f5625f86c67201ac3116a1556","head":{"label":"spiiroin:mer1250_input_policy_toggle","ref":"mer1250_input_policy_toggle","sha":"ccc324d65e26453f5625f86c67201ac3116a1556","user":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"repo":{"id":6487031,"name":"mce","full_name":"spiiroin/mce","owner":{"login":"spiiroin","id":2470051,"avatar_url":"https://avatars.githubusercontent.com/u/2470051?v=3","gravatar_id":"","url":"https://api.github.com/users/spiiroin","html_url":"https://github.com/spiiroin","followers_url":"https://api.github.com/users/spiiroin/followers","following_url":"https://api.github.com/users/spiiroin/following{/other_user}","gists_url":"https://api.github.com/users/spiiroin/gists{/gist_id}","starred_url":"https://api.github.com/users/spiiroin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiiroin/subscriptions","organizations_url":"https://api.github.com/users/spiiroin/orgs","repos_url":"https://api.github.com/users/spiiroin/repos","events_url":"https://api.github.com/users/spiiroin/events{/privacy}","received_events_url":"https://api.github.com/users/spiiroin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spiiroin/mce","description":"","fork":true,"url":"https://api.github.com/repos/spiiroin/mce","forks_url":"https://api.github.com/repos/spiiroin/mce/forks","keys_url":"https://api.github.com/repos/spiiroin/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spiiroin/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spiiroin/mce/teams","hooks_url":"https://api.github.com/repos/spiiroin/mce/hooks","issue_events_url":"https://api.github.com/repos/spiiroin/mce/issues/events{/number}","events_url":"https://api.github.com/repos/spiiroin/mce/events","assignees_url":"https://api.github.com/repos/spiiroin/mce/assignees{/user}","branches_url":"https://api.github.com/repos/spiiroin/mce/branches{/branch}","tags_url":"https://api.github.com/repos/spiiroin/mce/tags","blobs_url":"https://api.github.com/repos/spiiroin/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spiiroin/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spiiroin/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/spiiroin/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spiiroin/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/spiiroin/mce/languages","stargazers_url":"https://api.github.com/repos/spiiroin/mce/stargazers","contributors_url":"https://api.github.com/repos/spiiroin/mce/contributors","subscribers_url":"https://api.github.com/repos/spiiroin/mce/subscribers","subscription_url":"https://api.github.com/repos/spiiroin/mce/subscription","commits_url":"https://api.github.com/repos/spiiroin/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/spiiroin/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/spiiroin/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/spiiroin/mce/issues/comments{/number}","contents_url":"https://api.github.com/repos/spiiroin/mce/contents/{+path}","compare_url":"https://api.github.com/repos/spiiroin/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spiiroin/mce/merges","archive_url":"https://api.github.com/repos/spiiroin/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spiiroin/mce/downloads","issues_url":"https://api.github.com/repos/spiiroin/mce/issues{/number}","pulls_url":"https://api.github.com/repos/spiiroin/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/spiiroin/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/spiiroin/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spiiroin/mce/labels{/name}","releases_url":"https://api.github.com/repos/spiiroin/mce/releases{/id}","created_at":"2012-11-01T09:06:03Z","updated_at":"2015-05-07T10:50:35Z","pushed_at":"2015-08-19T10:58:57Z","git_url":"git://github.com/spiiroin/mce.git","ssh_url":"git@github.com:spiiroin/mce.git","clone_url":"https://github.com/spiiroin/mce.git","svn_url":"https://github.com/spiiroin/mce","homepage":null,"size":6903,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nemomobile:master","ref":"master","sha":"01706a110bc3e18a895b278a935da374aaa7980b","user":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"repo":{"id":6041894,"name":"mce","full_name":"nemomobile/mce","owner":{"login":"nemomobile","id":1088947,"avatar_url":"https://avatars.githubusercontent.com/u/1088947?v=3","gravatar_id":"","url":"https://api.github.com/users/nemomobile","html_url":"https://github.com/nemomobile","followers_url":"https://api.github.com/users/nemomobile/followers","following_url":"https://api.github.com/users/nemomobile/following{/other_user}","gists_url":"https://api.github.com/users/nemomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nemomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemomobile/subscriptions","organizations_url":"https://api.github.com/users/nemomobile/orgs","repos_url":"https://api.github.com/users/nemomobile/repos","events_url":"https://api.github.com/users/nemomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nemomobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nemomobile/mce","description":"","fork":false,"url":"https://api.github.com/repos/nemomobile/mce","forks_url":"https://api.github.com/repos/nemomobile/mce/forks","keys_url":"https://api.github.com/repos/nemomobile/mce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemomobile/mce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemomobile/mce/teams","hooks_url":"https://api.github.com/repos/nemomobile/mce/hooks","issue_events_url":"https://api.github.com/repos/nemomobile/mce/issues/events{/number}","events_url":"https://api.github.com/repos/nemomobile/mce/events","assignees_url":"https://api.github.com/repos/nemomobile/mce/assignees{/user}","branches_url":"https://api.github.com/repos/nemomobile/mce/branches{/branch}","tags_url":"https://api.github.com/repos/nemomobile/mce/tags","blobs_url":"https://api.github.com/repos/nemomobile/mce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemomobile/mce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemomobile/mce/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemomobile/mce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemomobile/mce/statuses/{sha}","languages_url":"https://api.github.com/repos/nemomobile/mce/languages","stargazers_url":"https://api.github.com/repos/nemomobile/mce/stargazers","contributors_url":"https://api.github.com/repos/nemomobile/mce/contributors","subscribers_url":"https://api.github.com/repos/nemomobile/mce/subscribers","subscription_url":"https://api.github.com/repos/nemomobile/mce/subscription","commits_url":"https://api.github.com/repos/nemomobile/mce/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemomobile/mce/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemomobile/mce/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemomobile/mce/issues/comments{/number}","contents_url":"https://api.github.com/repos/nemomobile/mce/contents/{+path}","compare_url":"https://api.github.com/repos/nemomobile/mce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemomobile/mce/merges","archive_url":"https://api.github.com/repos/nemomobile/mce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemomobile/mce/downloads","issues_url":"https://api.github.com/repos/nemomobile/mce/issues{/number}","pulls_url":"https://api.github.com/repos/nemomobile/mce/pulls{/number}","milestones_url":"https://api.github.com/repos/nemomobile/mce/milestones{/number}","notifications_url":"https://api.github.com/repos/nemomobile/mce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemomobile/mce/labels{/name}","releases_url":"https://api.github.com/repos/nemomobile/mce/releases{/id}","created_at":"2012-10-02T08:09:10Z","updated_at":"2015-05-18T06:54:18Z","pushed_at":"2015-08-19T10:59:40Z","git_url":"git://github.com/nemomobile/mce.git","ssh_url":"git@github.com:nemomobile/mce.git","clone_url":"https://github.com/nemomobile/mce.git","svn_url":"https://github.com/nemomobile/mce","homepage":null,"size":7083,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/310"},"html":{"href":"https://github.com/nemomobile/mce/pull/310"},"issue":{"href":"https://api.github.com/repos/nemomobile/mce/issues/310"},"comments":{"href":"https://api.github.com/repos/nemomobile/mce/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nemomobile/mce/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/nemomobile/mce/statuses/ccc324d65e26453f5625f86c67201ac3116a1556"}}}}