{"action":"created","issue":{"url":"https://api.github.com/repos/esvit/ng-table/issues/501","labels_url":"https://api.github.com/repos/esvit/ng-table/issues/501/labels{/name}","comments_url":"https://api.github.com/repos/esvit/ng-table/issues/501/comments","events_url":"https://api.github.com/repos/esvit/ng-table/issues/501/events","html_url":"https://github.com/esvit/ng-table/pull/501","id":53807752,"number":501,"title":"add multi-column sorting from @demands (issue #160) on v0.4.0 branch","user":{"login":"tb","id":71683,"avatar_url":"https://avatars.githubusercontent.com/u/71683?v=3","gravatar_id":"","url":"https://api.github.com/users/tb","html_url":"https://github.com/tb","followers_url":"https://api.github.com/users/tb/followers","following_url":"https://api.github.com/users/tb/following{/other_user}","gists_url":"https://api.github.com/users/tb/gists{/gist_id}","starred_url":"https://api.github.com/users/tb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tb/subscriptions","organizations_url":"https://api.github.com/users/tb/orgs","repos_url":"https://api.github.com/users/tb/repos","events_url":"https://api.github.com/users/tb/events{/privacy}","received_events_url":"https://api.github.com/users/tb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-08T22:10:06Z","updated_at":"2015-05-15T09:50:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/esvit/ng-table/pulls/501","html_url":"https://github.com/esvit/ng-table/pull/501","diff_url":"https://github.com/esvit/ng-table/pull/501.diff","patch_url":"https://github.com/esvit/ng-table/pull/501.patch"},"body":"- [x] merge @demands fix for #160 into @esvit v0.4.0 branch\r\n- [x] check tests\r\n- [x] add example for multi-column sorting\r\n- [x] check multi-column sorting works with url example\r\n- example 4.3\r\n  - [ ] find better fix then setTimeout\r\n- example 5.2\r\n  - [ ] verify it works (php request fails)\r\n-  example 5.8\r\n  - [ ] update header markup + make sortBy() work\r\n- review code fragment removed during merge\r\n  - [ ] https://github.com/tb/ng-table/compare/v0.4.0?expand=1#diff-6aca4bc06732c0635eb9860dc6cd040fL499"},"comment":{"url":"https://api.github.com/repos/esvit/ng-table/issues/comments/102348620","html_url":"https://github.com/esvit/ng-table/pull/501#issuecomment-102348620","issue_url":"https://api.github.com/repos/esvit/ng-table/issues/501","id":102348620,"user":{"login":"tb","id":71683,"avatar_url":"https://avatars.githubusercontent.com/u/71683?v=3","gravatar_id":"","url":"https://api.github.com/users/tb","html_url":"https://github.com/tb","followers_url":"https://api.github.com/users/tb/followers","following_url":"https://api.github.com/users/tb/following{/other_user}","gists_url":"https://api.github.com/users/tb/gists{/gist_id}","starred_url":"https://api.github.com/users/tb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tb/subscriptions","organizations_url":"https://api.github.com/users/tb/orgs","repos_url":"https://api.github.com/users/tb/repos","events_url":"https://api.github.com/users/tb/events{/privacy}","received_events_url":"https://api.github.com/users/tb/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T09:50:33Z","updated_at":"2015-05-15T09:50:33Z","body":"I was able to overwrite orderBy with my custom code that uses setting like: ```date_status: [\"date\", \"status\"]``` and when we do ```params.sorting(date_status: 'desc')```\r\ncustom ```orderBy()``` function returns ```[\"-date\", \"-status\"] (instead of [\"-date_status\"])```\r\nthis is much less invasive change to code base, allows us to use latest ng-table 0.5.* so I guess this pull request can be dropped."}}