{"action":"created","issue":{"url":"https://api.github.com/repos/mochajs/mocha/issues/1524","labels_url":"https://api.github.com/repos/mochajs/mocha/issues/1524/labels{/name}","comments_url":"https://api.github.com/repos/mochajs/mocha/issues/1524/comments","events_url":"https://api.github.com/repos/mochajs/mocha/issues/1524/events","html_url":"https://github.com/mochajs/mocha/issues/1524","id":56210000,"number":1524,"title":"Ensure done() is being called within tests","user":{"login":"Soviut","id":226882,"avatar_url":"https://avatars.githubusercontent.com/u/226882?v=3","gravatar_id":"","url":"https://api.github.com/users/Soviut","html_url":"https://github.com/Soviut","followers_url":"https://api.github.com/users/Soviut/followers","following_url":"https://api.github.com/users/Soviut/following{/other_user}","gists_url":"https://api.github.com/users/Soviut/gists{/gist_id}","starred_url":"https://api.github.com/users/Soviut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soviut/subscriptions","organizations_url":"https://api.github.com/users/Soviut/orgs","repos_url":"https://api.github.com/users/Soviut/repos","events_url":"https://api.github.com/users/Soviut/events{/privacy}","received_events_url":"https://api.github.com/users/Soviut/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mochajs/mocha/labels/Feature","name":"Feature","color":"207de5"},{"url":"https://api.github.com/repos/mochajs/mocha/labels/PR%20PLEASE","name":"PR PLEASE","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-02T08:52:06Z","updated_at":"2015-02-06T03:16:44Z","closed_at":null,"body":"As was discussed in https://github.com/mochajs/mocha/issues/1503 it would be good to scan each test to make sure the `done()` callback is actually called. An appropriate error should be thrown if the callback is missing.\r\n\r\nFor background, forgetting to add `done()` results in a somewhat ambiguous timeout error on a test, this would make things more specific and easier to debug."},"comment":{"url":"https://api.github.com/repos/mochajs/mocha/issues/comments/73176705","html_url":"https://github.com/mochajs/mocha/issues/1524#issuecomment-73176705","issue_url":"https://api.github.com/repos/mochajs/mocha/issues/1524","id":73176705,"user":{"login":"scott2449","id":584673,"avatar_url":"https://avatars.githubusercontent.com/u/584673?v=3","gravatar_id":"","url":"https://api.github.com/users/scott2449","html_url":"https://github.com/scott2449","followers_url":"https://api.github.com/users/scott2449/followers","following_url":"https://api.github.com/users/scott2449/following{/other_user}","gists_url":"https://api.github.com/users/scott2449/gists{/gist_id}","starred_url":"https://api.github.com/users/scott2449/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scott2449/subscriptions","organizations_url":"https://api.github.com/users/scott2449/orgs","repos_url":"https://api.github.com/users/scott2449/repos","events_url":"https://api.github.com/users/scott2449/events{/privacy}","received_events_url":"https://api.github.com/users/scott2449/received_events","type":"User","site_admin":false},"created_at":"2015-02-06T03:16:44Z","updated_at":"2015-02-06T03:16:44Z","body":"no no no I'm just noting a reminder to make sure the pretty error is only throw if no done AND no promise. I can imagine someone submitting a PR who's not a promise person and releasing a bugged version not even realizing it :smile: I know that's something I would do ..."}}