{"action":"created","issue":{"url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/128","labels_url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/128/comments","events_url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/128/events","html_url":"https://github.com/AllenFang/react-bootstrap-table/issues/128","id":115943491,"number":128,"title":"rowClick executes both onSelectRow and onRowClick","user":{"login":"tbaeg","id":3709748,"avatar_url":"https://avatars.githubusercontent.com/u/3709748?v=3","gravatar_id":"","url":"https://api.github.com/users/tbaeg","html_url":"https://github.com/tbaeg","followers_url":"https://api.github.com/users/tbaeg/followers","following_url":"https://api.github.com/users/tbaeg/following{/other_user}","gists_url":"https://api.github.com/users/tbaeg/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaeg/subscriptions","organizations_url":"https://api.github.com/users/tbaeg/orgs","repos_url":"https://api.github.com/users/tbaeg/repos","events_url":"https://api.github.com/users/tbaeg/events{/privacy}","received_events_url":"https://api.github.com/users/tbaeg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-09T19:09:33Z","updated_at":"2015-11-10T02:45:14Z","closed_at":null,"body":"When I click the checkbox element it should only tigger the `onSelectRow` function. It executes both `onRowClick` and on `onSelectRow`. Found the problem.. silly issue!\r\n\r\nThis is wrong..\r\n```\r\n  rowClick(e){\r\n    if(e.target.tagName !== \"INPUT\")\r\n      if (this.props.selectRow && this.props.selectRow.clickToSelect) this.props.onSelectRow(e.currentTarget.rowIndex, !this.props.isSelected);\r\n      if (this.props.onRowClick) this.props.onRowClick(e.currentTarget.rowIndex);\r\n  }\r\n```\r\n\r\nShould be..\r\n```\r\n  rowClick(e){\r\n    if(e.target.tagName !== \"INPUT\") {\r\n      if (this.props.selectRow && this.props.selectRow.clickToSelect) this.props.onSelectRow(e.currentTarget.rowIndex, !this.props.isSelected);\r\n      if (this.props.onRowClick) this.props.onRowClick(e.currentTarget.rowIndex);\r\n    }\r\n  }\r\n```\r\n\r\nOr else there is some very weird behavior.\r\n\r\nBraces are important, ha. \r\n"},"comment":{"url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/comments/155265979","html_url":"https://github.com/AllenFang/react-bootstrap-table/issues/128#issuecomment-155265979","issue_url":"https://api.github.com/repos/AllenFang/react-bootstrap-table/issues/128","id":155265979,"user":{"login":"AllenFang","id":5351390,"avatar_url":"https://avatars.githubusercontent.com/u/5351390?v=3","gravatar_id":"","url":"https://api.github.com/users/AllenFang","html_url":"https://github.com/AllenFang","followers_url":"https://api.github.com/users/AllenFang/followers","following_url":"https://api.github.com/users/AllenFang/following{/other_user}","gists_url":"https://api.github.com/users/AllenFang/gists{/gist_id}","starred_url":"https://api.github.com/users/AllenFang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllenFang/subscriptions","organizations_url":"https://api.github.com/users/AllenFang/orgs","repos_url":"https://api.github.com/users/AllenFang/repos","events_url":"https://api.github.com/users/AllenFang/events{/privacy}","received_events_url":"https://api.github.com/users/AllenFang/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T02:45:14Z","updated_at":"2015-11-10T02:45:14Z","body":"oh god, I can't believe I make this shame mistake ;(  "}}