{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/46190627","id":46190627,"diff_hunk":"@@ -259,6 +296,21 @@ class Mesh: public HybridObject {\n \n     const BoundingVolume& getBoundingVolume();\n \n+    bool hasBones() const {\n+        return vertexBoneData_.getNumBones();\n+    }\n+\n+    void setBones(std::vector<Bone*>&& bones) {\n+        vertexBoneData_.setBones(std::move(bones));\n+        shouldResetBoneBuffers = true;\n+    }\n+\n+    VertexBoneData &getVertexBoneData() {\n+        return vertexBoneData_;\n+    }","path":"GVRf/Framework/jni/objects/mesh.h","position":94,"original_position":94,"commit_id":"63685e3406345ac9a8556432caf5e2f1e3340ec5","original_commit_id":"63685e3406345ac9a8556432caf5e2f1e3340ec5","user":{"login":"Vittalbabu","id":13738187,"avatar_url":"https://avatars.githubusercontent.com/u/13738187?v=3","gravatar_id":"","url":"https://api.github.com/users/Vittalbabu","html_url":"https://github.com/Vittalbabu","followers_url":"https://api.github.com/users/Vittalbabu/followers","following_url":"https://api.github.com/users/Vittalbabu/following{/other_user}","gists_url":"https://api.github.com/users/Vittalbabu/gists{/gist_id}","starred_url":"https://api.github.com/users/Vittalbabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vittalbabu/subscriptions","organizations_url":"https://api.github.com/users/Vittalbabu/orgs","repos_url":"https://api.github.com/users/Vittalbabu/repos","events_url":"https://api.github.com/users/Vittalbabu/events{/privacy}","received_events_url":"https://api.github.com/users/Vittalbabu/received_events","type":"User","site_admin":false},"body":"Should this be a const ref? Do we expect the callers to modify vertexBoneData_?","created_at":"2015-11-30T19:31:31Z","updated_at":"2015-11-30T19:31:31Z","html_url":"https://github.com/Samsung/GearVRf/pull/318#discussion_r46190627","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/46190627"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/318#discussion_r46190627"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/318","id":51855546,"html_url":"https://github.com/Samsung/GearVRf/pull/318","diff_url":"https://github.com/Samsung/GearVRf/pull/318.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/318.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/318","number":318,"state":"open","locked":false,"title":"Add support for skeletal animation","user":{"login":"danke-sra","id":13282142,"avatar_url":"https://avatars.githubusercontent.com/u/13282142?v=3","gravatar_id":"","url":"https://api.github.com/users/danke-sra","html_url":"https://github.com/danke-sra","followers_url":"https://api.github.com/users/danke-sra/followers","following_url":"https://api.github.com/users/danke-sra/following{/other_user}","gists_url":"https://api.github.com/users/danke-sra/gists{/gist_id}","starred_url":"https://api.github.com/users/danke-sra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danke-sra/subscriptions","organizations_url":"https://api.github.com/users/danke-sra/orgs","repos_url":"https://api.github.com/users/danke-sra/repos","events_url":"https://api.github.com/users/danke-sra/events{/privacy}","received_events_url":"https://api.github.com/users/danke-sra/received_events","type":"User","site_admin":false},"body":"- Add GVRBone and GVRBoneWeight and correpsonding native impl.\r\n- Add GVRSkeleton to construct skeleton from a rigged model\r\n- Modified assimp shader to animate mesh\r\n- Add pretty print for GVRSceneObject for debugging scene graphs.\r\n- Add a template GVRKeyFrameAnimation to hold animation\r\n\r\n- Add a sample app (working in progress, pending animation import)\r\n- Dependency on JOML (refactoring to use Android OpenGL Matrix).","created_at":"2015-11-25T22:59:34Z","updated_at":"2015-11-30T19:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53664956f1507251f536baf04ba451ddce62705d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/318/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/318/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/318/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/63685e3406345ac9a8556432caf5e2f1e3340ec5","head":{"label":"danke-sra:skeletal","ref":"skeletal","sha":"63685e3406345ac9a8556432caf5e2f1e3340ec5","user":{"login":"danke-sra","id":13282142,"avatar_url":"https://avatars.githubusercontent.com/u/13282142?v=3","gravatar_id":"","url":"https://api.github.com/users/danke-sra","html_url":"https://github.com/danke-sra","followers_url":"https://api.github.com/users/danke-sra/followers","following_url":"https://api.github.com/users/danke-sra/following{/other_user}","gists_url":"https://api.github.com/users/danke-sra/gists{/gist_id}","starred_url":"https://api.github.com/users/danke-sra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danke-sra/subscriptions","organizations_url":"https://api.github.com/users/danke-sra/orgs","repos_url":"https://api.github.com/users/danke-sra/repos","events_url":"https://api.github.com/users/danke-sra/events{/privacy}","received_events_url":"https://api.github.com/users/danke-sra/received_events","type":"User","site_admin":false},"repo":{"id":39859371,"name":"GearVRf","full_name":"danke-sra/GearVRf","owner":{"login":"danke-sra","id":13282142,"avatar_url":"https://avatars.githubusercontent.com/u/13282142?v=3","gravatar_id":"","url":"https://api.github.com/users/danke-sra","html_url":"https://github.com/danke-sra","followers_url":"https://api.github.com/users/danke-sra/followers","following_url":"https://api.github.com/users/danke-sra/following{/other_user}","gists_url":"https://api.github.com/users/danke-sra/gists{/gist_id}","starred_url":"https://api.github.com/users/danke-sra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danke-sra/subscriptions","organizations_url":"https://api.github.com/users/danke-sra/orgs","repos_url":"https://api.github.com/users/danke-sra/repos","events_url":"https://api.github.com/users/danke-sra/events{/privacy}","received_events_url":"https://api.github.com/users/danke-sra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danke-sra/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/danke-sra/GearVRf","forks_url":"https://api.github.com/repos/danke-sra/GearVRf/forks","keys_url":"https://api.github.com/repos/danke-sra/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danke-sra/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danke-sra/GearVRf/teams","hooks_url":"https://api.github.com/repos/danke-sra/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/danke-sra/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/danke-sra/GearVRf/events","assignees_url":"https://api.github.com/repos/danke-sra/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/danke-sra/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/danke-sra/GearVRf/tags","blobs_url":"https://api.github.com/repos/danke-sra/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danke-sra/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danke-sra/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/danke-sra/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danke-sra/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/danke-sra/GearVRf/languages","stargazers_url":"https://api.github.com/repos/danke-sra/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/danke-sra/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/danke-sra/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/danke-sra/GearVRf/subscription","commits_url":"https://api.github.com/repos/danke-sra/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/danke-sra/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/danke-sra/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/danke-sra/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/danke-sra/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/danke-sra/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danke-sra/GearVRf/merges","archive_url":"https://api.github.com/repos/danke-sra/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danke-sra/GearVRf/downloads","issues_url":"https://api.github.com/repos/danke-sra/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/danke-sra/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/danke-sra/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/danke-sra/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danke-sra/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/danke-sra/GearVRf/releases{/id}","created_at":"2015-07-28T21:46:53Z","updated_at":"2015-07-28T21:47:05Z","pushed_at":"2015-11-25T22:56:26Z","git_url":"git://github.com/danke-sra/GearVRf.git","ssh_url":"git@github.com:danke-sra/GearVRf.git","clone_url":"https://github.com/danke-sra/GearVRf.git","svn_url":"https://github.com/danke-sra/GearVRf","homepage":"http://www.gearvrf.org","size":626476,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"8bda8c317f8e592943769b301ee76883dcc58255","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","created_at":"2015-03-25T02:02:18Z","updated_at":"2015-11-24T12:38:58Z","pushed_at":"2015-11-30T16:27:00Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":630764,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":63,"forks":71,"open_issues":63,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/318"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/318"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/318"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/63685e3406345ac9a8556432caf5e2f1e3340ec5"}}}}