{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/26620238","id":26620238,"diff_hunk":"@@ -317,92 +317,94 @@ namespace Microsoft.VisualStudio.FSharp.ProjectSystem\n             if dirty then isDirty <- dirty            \n         \n         /// Updates list of binding redirects to the config file. Content of list is governed by the major version of target framework.\n-        /// Current redirects: 2.0 -> \"2.0.0.0\" to \"2.3.0.0\". 4.0 or greater - \"2.0.0.0\" to \"4.3.0.0\", \"2.3.5.0\" to \"4.3.0.0\", \"4.0.0.0\" to \"4.3.0.0\"\n-        member x.EnsureHasBindingRedirects(majorVersion) =\n+        member x.EnsureHasBindingRedirects(majorVersion, minorVersion, targetFSharpCoreVersion, autoGenerateBindingRedirects) =\n \n-            // some helpers to simplify work with XLinq\n-            let xname = System.Xml.Linq.XName.Get\n-            let xnameAsmV1 name = xname (\"{urn:schemas-microsoft-com:asm.v1}\" + name)\n+            if not autoGenerateBindingRedirects then\n+                // some helpers to simplify work with XLinq\n+                let xname = System.Xml.Linq.XName.Get\n+                let xnameAsmV1 name = xname (\"{urn:schemas-microsoft-com:asm.v1}\" + name)\n \n-            let fsCoreAttributes = \n-                [\n-                    xname \"name\", \"FSharp.Core\"\n-                    xname \"publicKeyToken\", Microsoft.VisualStudio.FSharp.ProjectSystem.Utilities.FsCorePublicKeyToken\n-                    xname \"culture\", \"neutral\"\n-                ]\n-\n-            // depending on major version of target framework we need to populate corresponding binding redirects in config\n-            let redirects = \n-                if majorVersion >= 4 then\n-                    [\n-                        \"2.0.0.0\", \"4.3.0.0\"\n-                        \"2.3.5.0\", \"4.3.0.0\"\n-                        \"4.0.0.0\", \"4.3.0.0\"\n-                    ]\n-                else\n+                let fsCoreAttributes = \n                     [\n-                        \"2.0.0.0\", \"2.3.0.0\"\n+                        xname \"name\", \"FSharp.Core\"\n+                        xname \"publicKeyToken\", Microsoft.VisualStudio.FSharp.ProjectSystem.Utilities.FsCorePublicKeyToken\n+                        xname \"culture\", \"neutral\"\n                     ]\n \n-            let OldVersion = \"oldVersion\"\n-            let NewVersion = \"newVersion\"\n-            let BindingRedirect = \"bindingRedirect\"\n-            let DependentAssembly = \"dependentAssembly\"\n-            let AssemblyIdentity = \"assemblyIdentity\"\n+                // depending on major version of target framework we need to populate corresponding binding redirects in config\n+                let redirects = \n+                    if majorVersion >= 4 then\n+                        [\n+                            \"2.0.0.0\", targetFSharpCoreVersion","path":"vsintegration/src/vs/FsPkgs/FSharp.Project/FS/AppConfigHelper.fs","position":49,"original_position":49,"commit_id":"1bc99dc5eaf1812a2251765f65f4c32137732dbd","original_commit_id":"1bc99dc5eaf1812a2251765f65f4c32137732dbd","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"The existing code didn't redirect, but I agree there is a good argument for redirecting the portables that also target the desktop ... which is to say all of them.\r\n\r\nGood eyes.","created_at":"2015-03-17T21:51:15Z","updated_at":"2015-03-17T21:51:15Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/308#discussion_r26620238","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/26620238"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/308#discussion_r26620238"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308","id":31289538,"html_url":"https://github.com/Microsoft/visualfsharp/pull/308","diff_url":"https://github.com/Microsoft/visualfsharp/pull/308.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/308.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/308","number":308,"state":"open","locked":false,"title":"Fixes #283","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"body":"Ensures that when the F# project system updates the app.config file for the project.  It correctly handles the binding redirects.\r\n\r\n1.  If autogeneratebindingredirects is set in the project then the project system leaves it to the build.\r\n2.  For projects without autogeneratebindingredirects it adds a bindingredirect for fsharp.core for each\r\n    possible version of fsharp.core, depending on the target framework\r\n\r\nNote:  much of the delta is merely additional whitespace.","created_at":"2015-03-16T22:06:21Z","updated_at":"2015-03-17T21:51:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"890d89b5931e7585c89d63672bfb82bc5fc520fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/308/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/1bc99dc5eaf1812a2251765f65f4c32137732dbd","head":{"label":"KevinRansom:issue283","ref":"issue283","sha":"1bc99dc5eaf1812a2251765f65f4c32137732dbd","user":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"repo":{"id":30044748,"name":"visualfsharp","full_name":"KevinRansom/visualfsharp","owner":{"login":"KevinRansom","id":5175830,"avatar_url":"https://avatars.githubusercontent.com/u/5175830?v=3","gravatar_id":"","url":"https://api.github.com/users/KevinRansom","html_url":"https://github.com/KevinRansom","followers_url":"https://api.github.com/users/KevinRansom/followers","following_url":"https://api.github.com/users/KevinRansom/following{/other_user}","gists_url":"https://api.github.com/users/KevinRansom/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinRansom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinRansom/subscriptions","organizations_url":"https://api.github.com/users/KevinRansom/orgs","repos_url":"https://api.github.com/users/KevinRansom/repos","events_url":"https://api.github.com/users/KevinRansom/events{/privacy}","received_events_url":"https://api.github.com/users/KevinRansom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KevinRansom/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/KevinRansom/visualfsharp","forks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/forks","keys_url":"https://api.github.com/repos/KevinRansom/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinRansom/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinRansom/visualfsharp/teams","hooks_url":"https://api.github.com/repos/KevinRansom/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/KevinRansom/visualfsharp/events","assignees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/KevinRansom/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/tags","blobs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinRansom/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinRansom/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/KevinRansom/visualfsharp/subscription","commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinRansom/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinRansom/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinRansom/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/KevinRansom/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinRansom/visualfsharp/merges","archive_url":"https://api.github.com/repos/KevinRansom/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinRansom/visualfsharp/downloads","issues_url":"https://api.github.com/repos/KevinRansom/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/KevinRansom/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinRansom/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinRansom/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinRansom/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/KevinRansom/visualfsharp/releases{/id}","created_at":"2015-01-29T22:35:46Z","updated_at":"2015-03-11T21:03:50Z","pushed_at":"2015-03-17T19:20:28Z","git_url":"git://github.com/KevinRansom/visualfsharp.git","ssh_url":"git@github.com:KevinRansom/visualfsharp.git","clone_url":"https://github.com/KevinRansom/visualfsharp.git","svn_url":"https://github.com/KevinRansom/visualfsharp","homepage":null,"size":49123,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fsharp4"}},"base":{"label":"Microsoft:fsharp4","ref":"fsharp4","sha":"f4624304561b6913b853f534c07cf73900596254","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","created_at":"2015-01-10T05:58:43Z","updated_at":"2015-03-17T21:33:56Z","pushed_at":"2015-03-17T21:33:56Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":51661,"stargazers_count":332,"watchers_count":332,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":111,"forks":52,"open_issues":111,"watchers":332,"default_branch":"fsharp4"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/308"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/308"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/1bc99dc5eaf1812a2251765f65f4c32137732dbd"}}}}