{"action":"closed","number":154,"pull_request":{"url":"https://api.github.com/repos/uber/ringpop/pulls/154","id":43393286,"html_url":"https://github.com/uber/ringpop/pull/154","diff_url":"https://github.com/uber/ringpop/pull/154.diff","patch_url":"https://github.com/uber/ringpop/pull/154.patch","issue_url":"https://api.github.com/repos/uber/ringpop/issues/154","number":154,"state":"closed","locked":false,"title":"All sorts of leaky tests weren't properly cleaning up","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"Fixes for tests that weren't cleaning up their Ringpop instance. This left leaky timers and only became a problem because of upcoming flap damp scoring code. Trust me on this ;)\r\n\r\n@benfleis @danielheller @CorgiMan ","created_at":"2015-08-26T11:55:50Z","updated_at":"2015-08-26T12:03:58Z","closed_at":"2015-08-26T12:03:58Z","merged_at":"2015-08-26T12:03:58Z","merge_commit_sha":"3cd48f7e14ecef035ff72ef473379440e777460c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/ringpop/pulls/154/commits","review_comments_url":"https://api.github.com/repos/uber/ringpop/pulls/154/comments","review_comment_url":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/ringpop/issues/154/comments","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/2962f8a827b303365d67ee0317dd45ab95df01cf","head":{"label":"uber:leaky","ref":"leaky","sha":"2962f8a827b303365d67ee0317dd45ab95df01cf","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-08-26T10:38:30Z","pushed_at":"2015-08-26T12:03:58Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":3232,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":182,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"d089c6e6bb9c52aa581b54be3e25405c25fe57ad","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":29378455,"name":"ringpop","full_name":"uber/ringpop","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/ringpop","description":"Scalable, fault-tolerant application-layer sharding","fork":false,"url":"https://api.github.com/repos/uber/ringpop","forks_url":"https://api.github.com/repos/uber/ringpop/forks","keys_url":"https://api.github.com/repos/uber/ringpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/ringpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/ringpop/teams","hooks_url":"https://api.github.com/repos/uber/ringpop/hooks","issue_events_url":"https://api.github.com/repos/uber/ringpop/issues/events{/number}","events_url":"https://api.github.com/repos/uber/ringpop/events","assignees_url":"https://api.github.com/repos/uber/ringpop/assignees{/user}","branches_url":"https://api.github.com/repos/uber/ringpop/branches{/branch}","tags_url":"https://api.github.com/repos/uber/ringpop/tags","blobs_url":"https://api.github.com/repos/uber/ringpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/ringpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/ringpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/ringpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/ringpop/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/ringpop/languages","stargazers_url":"https://api.github.com/repos/uber/ringpop/stargazers","contributors_url":"https://api.github.com/repos/uber/ringpop/contributors","subscribers_url":"https://api.github.com/repos/uber/ringpop/subscribers","subscription_url":"https://api.github.com/repos/uber/ringpop/subscription","commits_url":"https://api.github.com/repos/uber/ringpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/ringpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/ringpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/ringpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/ringpop/contents/{+path}","compare_url":"https://api.github.com/repos/uber/ringpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/ringpop/merges","archive_url":"https://api.github.com/repos/uber/ringpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/ringpop/downloads","issues_url":"https://api.github.com/repos/uber/ringpop/issues{/number}","pulls_url":"https://api.github.com/repos/uber/ringpop/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/ringpop/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/ringpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/ringpop/labels{/name}","releases_url":"https://api.github.com/repos/uber/ringpop/releases{/id}","created_at":"2015-01-17T03:26:35Z","updated_at":"2015-08-26T10:38:30Z","pushed_at":"2015-08-26T12:03:58Z","git_url":"git://github.com/uber/ringpop.git","ssh_url":"git@github.com:uber/ringpop.git","clone_url":"https://github.com/uber/ringpop.git","svn_url":"https://github.com/uber/ringpop","homepage":"","size":3232,"stargazers_count":182,"watchers_count":182,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/ringpop/pulls/154"},"html":{"href":"https://github.com/uber/ringpop/pull/154"},"issue":{"href":"https://api.github.com/repos/uber/ringpop/issues/154"},"comments":{"href":"https://api.github.com/repos/uber/ringpop/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/ringpop/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/ringpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/ringpop/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/uber/ringpop/statuses/2962f8a827b303365d67ee0317dd45ab95df01cf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":68,"deletions":71,"changed_files":5}}