{"comment":{"url":"https://api.github.com/repos/kwizart/libglvnd/comments/9706751","html_url":"https://github.com/kwizart/libglvnd/commit/43917c86170c0742ec32f7748e4056dc1757e336#commitcomment-9706751","id":9706751,"user":{"login":"aaronp24","id":343551,"avatar_url":"https://avatars.githubusercontent.com/u/343551?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronp24","html_url":"https://github.com/aaronp24","followers_url":"https://api.github.com/users/aaronp24/followers","following_url":"https://api.github.com/users/aaronp24/following{/other_user}","gists_url":"https://api.github.com/users/aaronp24/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronp24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronp24/subscriptions","organizations_url":"https://api.github.com/users/aaronp24/orgs","repos_url":"https://api.github.com/users/aaronp24/repos","events_url":"https://api.github.com/users/aaronp24/events{/privacy}","received_events_url":"https://api.github.com/users/aaronp24/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"43917c86170c0742ec32f7748e4056dc1757e336","created_at":"2015-02-11T23:33:00Z","updated_at":"2015-02-11T23:33:00Z","body":"At NVIDIA we typically use specific features checks for things like this to make the code clearer.  E.g.,\r\n\r\n    #define XGLV_ABI_HAS_LOAD_EXTENSION_LIST          (GET_ABI_MAJOR(ABI_VIDEODRV_VERSION) >= 17)\r\n    ...\r\n    #if XGLV_ABI_HAS_LOAD_EXTENSION_LIST\r\n        LoadExtensionList(&glvExtensionModule, 1, False);\r\n    #else\r\n        LoadExtension(&glvExtensionModule, False);\r\n    #endif\r\n\r\nA numeric version check is probably fine, but we've been burned by that sort of thing so much in the past that I'd be more comfortable with an ABI check."}}