{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/672","labels_url":"https://api.github.com/repos/minetest/minetest_game/issues/672/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest_game/issues/672/comments","events_url":"https://api.github.com/repos/minetest/minetest_game/issues/672/events","html_url":"https://github.com/minetest/minetest_game/pull/672","id":106110946,"number":672,"title":"water mist","user":{"login":"pinkysnowman","id":11590875,"avatar_url":"https://avatars.githubusercontent.com/u/11590875?v=3","gravatar_id":"","url":"https://api.github.com/users/pinkysnowman","html_url":"https://github.com/pinkysnowman","followers_url":"https://api.github.com/users/pinkysnowman/followers","following_url":"https://api.github.com/users/pinkysnowman/following{/other_user}","gists_url":"https://api.github.com/users/pinkysnowman/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkysnowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkysnowman/subscriptions","organizations_url":"https://api.github.com/users/pinkysnowman/orgs","repos_url":"https://api.github.com/users/pinkysnowman/repos","events_url":"https://api.github.com/users/pinkysnowman/events{/privacy}","received_events_url":"https://api.github.com/users/pinkysnowman/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/minetest/minetest_game/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-09-11T23:14:59Z","updated_at":"2015-09-14T05:23:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest_game/pulls/672","html_url":"https://github.com/minetest/minetest_game/pull/672","diff_url":"https://github.com/minetest/minetest_game/pull/672.diff","patch_url":"https://github.com/minetest/minetest_game/pull/672.patch"},"body":"Added water mist particle effects to enhance waterfalls and other water features.\r\n![screenshot_20150911_192515](https://cloud.githubusercontent.com/assets/11590875/9828410/f06d021e-58ba-11e5-8fb7-cdba7f05f567.png)\r\n![screenshot_20150911_192504](https://cloud.githubusercontent.com/assets/11590875/9828412/f38519b4-58ba-11e5-91ba-96ad6c308036.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/minetest/minetest_game/issues/comments/139963260","html_url":"https://github.com/minetest/minetest_game/pull/672#issuecomment-139963260","issue_url":"https://api.github.com/repos/minetest/minetest_game/issues/672","id":139963260,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T05:23:27Z","updated_at":"2015-09-14T05:23:27Z","body":"I feel this is best as a mod since it's a special visual feature that's triggered in rare circumstances.\r\nAn ABM on flowing water creates a processing load that in most worlds, most of the time, is doing nothing, i don't think this should be forced on everyone by default, for example i would rather not use it to improve performance.\r\nParticles in Minetest are currently heavy, this feature creates 33 per node with collision detection.\r\nThis looks good under a waterfall, but in many situations, like a small stream of water running into a pool, spray like this would be unsuitable."}}