{"action":"created","comment":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/42932619","id":42932619,"diff_hunk":"@@ -53,6 +53,21 @@ set(tests\n         test_sockopt_hwm\n         test_heartbeats\n         test_poller\n+        test_atomics\n+        test_bind_src_address\n+        test_capabilities\n+        test_ipc_wildcard","path":"tests/CMakeLists.txt","position":7,"original_position":7,"commit_id":"9930f1fc20bb24ef657c84335cd82c7b7d40aae8","original_commit_id":"9930f1fc20bb24ef657c84335cd82c7b7d40aae8","user":{"login":"madebr","id":4138939,"avatar_url":"https://avatars.githubusercontent.com/u/4138939?v=3","gravatar_id":"","url":"https://api.github.com/users/madebr","html_url":"https://github.com/madebr","followers_url":"https://api.github.com/users/madebr/followers","following_url":"https://api.github.com/users/madebr/following{/other_user}","gists_url":"https://api.github.com/users/madebr/gists{/gist_id}","starred_url":"https://api.github.com/users/madebr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebr/subscriptions","organizations_url":"https://api.github.com/users/madebr/orgs","repos_url":"https://api.github.com/users/madebr/repos","events_url":"https://api.github.com/users/madebr/events{/privacy}","received_events_url":"https://api.github.com/users/madebr/received_events","type":"User","site_admin":false},"body":"That can be arranged.\r\nPlease review all the tests in `tests/CMakeLists.txt`.\r\nMight it be possible that a test is only included in the Linux section while the feature-under-test has a Windows implementation?","created_at":"2015-10-24T10:21:10Z","updated_at":"2015-10-24T10:21:10Z","html_url":"https://github.com/zeromq/libzmq/pull/1620#discussion_r42932619","pull_request_url":"https://api.github.com/repos/zeromq/libzmq/pulls/1620","_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/42932619"},"html":{"href":"https://github.com/zeromq/libzmq/pull/1620#discussion_r42932619"},"pull_request":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1620"}}},"pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/1620","id":48638709,"html_url":"https://github.com/zeromq/libzmq/pull/1620","diff_url":"https://github.com/zeromq/libzmq/pull/1620.diff","patch_url":"https://github.com/zeromq/libzmq/pull/1620.patch","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/1620","number":1620,"state":"closed","locked":false,"title":"CTest: add all sources in tests folder to CTest","user":{"login":"madebr","id":4138939,"avatar_url":"https://avatars.githubusercontent.com/u/4138939?v=3","gravatar_id":"","url":"https://api.github.com/users/madebr","html_url":"https://github.com/madebr","followers_url":"https://api.github.com/users/madebr/followers","following_url":"https://api.github.com/users/madebr/following{/other_user}","gists_url":"https://api.github.com/users/madebr/gists{/gist_id}","starred_url":"https://api.github.com/users/madebr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebr/subscriptions","organizations_url":"https://api.github.com/users/madebr/orgs","repos_url":"https://api.github.com/users/madebr/repos","events_url":"https://api.github.com/users/madebr/events{/privacy}","received_events_url":"https://api.github.com/users/madebr/received_events","type":"User","site_admin":false},"body":"Changes introduced by this PR:\r\n- CMake: Build with both libsodium and tweetNaCL\r\n- In the tests folder, there were some `test_XXX.cpp` files which were not included in CTest. I have checked which tests could be compiled on Linux and which one could be compiled on Windows. I have added them to the correct category (I think).\r\n  * In addition to this, CMake will test whether there is a test_XXX.cpp present in the tests folder that is not known to CTest. If so, a developper warning will be shown. Hopefully, this feature will avoid having a test not run on the CI.\r\n  * **Main problem is that some of these tests fail.**\r\n\r\nThe following tests fail on both Linux and Windows:\r\n58 - test_pair_tipc (OTHER_FAULT)\r\n59 - test_reqrep_device_tipc (OTHER_FAULT)\r\n60 - test_reqrep_tipc (OTHER_FAULT)\r\n62 - test_router_mandatory_tipc (OTHER_FAULT)\r\n65 - test_sub_forward_tipc (OTHER_FAULT)\r\n\r\nThe following tests fail only on Windows:\r\n56 - test_ipc_wildcard (Timeout)\r\n63 - test_srcfd (OTHER_FAULT)\r\n66 - test_xpub_manual (OTHER_FAULT)\r\n\r\nThe following tests fail only on Linux:\r\n77 - test_connect_delay_tipc (OTHER_FAULT)\r\n78 - test_shutdown_stress_tipc (OTHER_FAULT)\r\n81 - test_term_endpoint_tipc (OTHER_FAULT)\r\n\r\nappveyor output:\r\nhttps://ci.appveyor.com/project/madebr/libzmq/build/build-32","created_at":"2015-10-23T22:49:06Z","updated_at":"2015-10-24T10:21:10Z","closed_at":"2015-10-24T10:19:10Z","merged_at":"2015-10-24T10:19:10Z","merge_commit_sha":"02c3d522d0e9f19ce549057fefef9303fe6f88a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/libzmq/pulls/1620/commits","review_comments_url":"https://api.github.com/repos/zeromq/libzmq/pulls/1620/comments","review_comment_url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/1620/comments","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/9930f1fc20bb24ef657c84335cd82c7b7d40aae8","head":{"label":"madebr:ctest_missing_tests","ref":"ctest_missing_tests","sha":"9930f1fc20bb24ef657c84335cd82c7b7d40aae8","user":{"login":"madebr","id":4138939,"avatar_url":"https://avatars.githubusercontent.com/u/4138939?v=3","gravatar_id":"","url":"https://api.github.com/users/madebr","html_url":"https://github.com/madebr","followers_url":"https://api.github.com/users/madebr/followers","following_url":"https://api.github.com/users/madebr/following{/other_user}","gists_url":"https://api.github.com/users/madebr/gists{/gist_id}","starred_url":"https://api.github.com/users/madebr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebr/subscriptions","organizations_url":"https://api.github.com/users/madebr/orgs","repos_url":"https://api.github.com/users/madebr/repos","events_url":"https://api.github.com/users/madebr/events{/privacy}","received_events_url":"https://api.github.com/users/madebr/received_events","type":"User","site_admin":false},"repo":{"id":44777085,"name":"libzmq","full_name":"madebr/libzmq","owner":{"login":"madebr","id":4138939,"avatar_url":"https://avatars.githubusercontent.com/u/4138939?v=3","gravatar_id":"","url":"https://api.github.com/users/madebr","html_url":"https://github.com/madebr","followers_url":"https://api.github.com/users/madebr/followers","following_url":"https://api.github.com/users/madebr/following{/other_user}","gists_url":"https://api.github.com/users/madebr/gists{/gist_id}","starred_url":"https://api.github.com/users/madebr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madebr/subscriptions","organizations_url":"https://api.github.com/users/madebr/orgs","repos_url":"https://api.github.com/users/madebr/repos","events_url":"https://api.github.com/users/madebr/events{/privacy}","received_events_url":"https://api.github.com/users/madebr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madebr/libzmq","description":"ZeroMQ core engine in C++","fork":true,"url":"https://api.github.com/repos/madebr/libzmq","forks_url":"https://api.github.com/repos/madebr/libzmq/forks","keys_url":"https://api.github.com/repos/madebr/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madebr/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madebr/libzmq/teams","hooks_url":"https://api.github.com/repos/madebr/libzmq/hooks","issue_events_url":"https://api.github.com/repos/madebr/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/madebr/libzmq/events","assignees_url":"https://api.github.com/repos/madebr/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/madebr/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/madebr/libzmq/tags","blobs_url":"https://api.github.com/repos/madebr/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madebr/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madebr/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/madebr/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madebr/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/madebr/libzmq/languages","stargazers_url":"https://api.github.com/repos/madebr/libzmq/stargazers","contributors_url":"https://api.github.com/repos/madebr/libzmq/contributors","subscribers_url":"https://api.github.com/repos/madebr/libzmq/subscribers","subscription_url":"https://api.github.com/repos/madebr/libzmq/subscription","commits_url":"https://api.github.com/repos/madebr/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/madebr/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/madebr/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/madebr/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/madebr/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/madebr/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madebr/libzmq/merges","archive_url":"https://api.github.com/repos/madebr/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madebr/libzmq/downloads","issues_url":"https://api.github.com/repos/madebr/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/madebr/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/madebr/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/madebr/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madebr/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/madebr/libzmq/releases{/id}","created_at":"2015-10-22T22:32:10Z","updated_at":"2015-10-22T22:32:13Z","pushed_at":"2015-10-23T22:20:56Z","git_url":"git://github.com/madebr/libzmq.git","ssh_url":"git@github.com:madebr/libzmq.git","clone_url":"https://github.com/madebr/libzmq.git","svn_url":"https://github.com/madebr/libzmq","homepage":"http://www.zeromq.org","size":14353,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"7fe032180ad52b68568ad55970be039f45c2d153","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":263379,"name":"libzmq","full_name":"zeromq/libzmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars.githubusercontent.com/u/109777?v=3","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/libzmq","description":"ZeroMQ core engine in C++","fork":false,"url":"https://api.github.com/repos/zeromq/libzmq","forks_url":"https://api.github.com/repos/zeromq/libzmq/forks","keys_url":"https://api.github.com/repos/zeromq/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/libzmq/teams","hooks_url":"https://api.github.com/repos/zeromq/libzmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/libzmq/events","assignees_url":"https://api.github.com/repos/zeromq/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/libzmq/tags","blobs_url":"https://api.github.com/repos/zeromq/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/libzmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/libzmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/libzmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/libzmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/libzmq/subscription","commits_url":"https://api.github.com/repos/zeromq/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/libzmq/merges","archive_url":"https://api.github.com/repos/zeromq/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/libzmq/downloads","issues_url":"https://api.github.com/repos/zeromq/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/libzmq/releases{/id}","created_at":"2009-07-29T09:56:41Z","updated_at":"2015-10-23T19:27:56Z","pushed_at":"2015-10-24T10:19:11Z","git_url":"git://github.com/zeromq/libzmq.git","ssh_url":"git@github.com:zeromq/libzmq.git","clone_url":"https://github.com/zeromq/libzmq.git","svn_url":"https://github.com/zeromq/libzmq","homepage":"http://www.zeromq.org","size":19430,"stargazers_count":2073,"watchers_count":2073,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":634,"mirror_url":null,"open_issues_count":157,"forks":634,"open_issues":157,"watchers":2073,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1620"},"html":{"href":"https://github.com/zeromq/libzmq/pull/1620"},"issue":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/1620"},"comments":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/1620/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1620/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/1620/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/libzmq/statuses/9930f1fc20bb24ef657c84335cd82c7b7d40aae8"}}}}