{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/34818028","id":34818028,"diff_hunk":"@@ -1339,29 +1342,59 @@ static HMODULE LOADLoadLibrary(LPCSTR shortAsciiName, BOOL fDynamic)\n     // See if file can be dlopen()ed; this should work even if it's already loaded\n     {\n         // See GetProcAddress for an explanation why we leave the PAL.\n-        PAL_LeaveHolder holder;\n-        dl_handle = dlopen(shortAsciiName, RTLD_LAZY | RTLD_NOLOAD); \n-        if (!dl_handle)\n+        PAL_LeaveHolder holder; \n+        \n+        // Try to dlopen the module with appropriate variations on the name.\n+        // P/Invokes are often declared with shortened versions of the real library\n+        // name, such as without the extension or without the \"lib\" prefix.\n+        // We try to open with such variations on the original.\n+        int endsWithSuffix = FALSE, startsWithPrefixOrIsAbsolute = FALSE;\n+        size_t shortAsciiNameLen = 0;\n+        int i;\n+        for (i = 1; i <= 4; i++) // four cases: original, with prefix, with suffix, with both prefix and suffix\n         {\n-            dl_handle = dlopen(shortAsciiName, RTLD_LAZY);\n-        }\n+            const char* filename = NULL;\n+            switch (i)\n+            {\n+                case 1: // original name\n+                    filename = shortAsciiName;\n+                    break;\n+\n+                case 2: // with prefix prepended","path":"src/pal/src/loader/module.cpp","position":37,"original_position":37,"commit_id":"f5b17e642224b573a3ed81d693cf76b9b6918f74","original_commit_id":"f5b17e642224b573a3ed81d693cf76b9b6918f74","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Any library that doesn't begin with \"lib\", such as \"CoreFoundation\" on OS X.","created_at":"2015-07-16T18:02:34Z","updated_at":"2015-07-16T18:02:34Z","html_url":"https://github.com/dotnet/coreclr/pull/1248#discussion_r34818028","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1248","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/34818028"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1248#discussion_r34818028"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1248"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1248","id":40141479,"html_url":"https://github.com/dotnet/coreclr/pull/1248","diff_url":"https://github.com/dotnet/coreclr/pull/1248.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1248.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1248","number":1248,"state":"open","locked":false,"title":"Update DllImport name logic to support lack of \"lib\" prefix","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Today the runtime supports automatically appending an appropriate suffix (e.g. \".so\", \".dylib\", etc.) for the library name provided to DllImport.  This commit adds support for also prepending the\r\nstandard library prefix \"lib\".\r\n\r\nThiis is meant to help with situations like that in #1244.  It is in addition to whatever solution might be implemented to help with #444 and #930.","created_at":"2015-07-16T15:24:20Z","updated_at":"2015-07-16T18:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ff097ca3d5f9fc483c7bc9a636fffe9cb0ac0ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1248/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1248/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1248/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/f5b17e642224b573a3ed81d693cf76b9b6918f74","head":{"label":"stephentoub:dllimport_prefix_suffix","ref":"dllimport_prefix_suffix","sha":"f5b17e642224b573a3ed81d693cf76b9b6918f74","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"repo":{"id":30271698,"name":"coreclr","full_name":"stephentoub/coreclr","owner":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephentoub/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/stephentoub/coreclr","forks_url":"https://api.github.com/repos/stephentoub/coreclr/forks","keys_url":"https://api.github.com/repos/stephentoub/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephentoub/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephentoub/coreclr/teams","hooks_url":"https://api.github.com/repos/stephentoub/coreclr/hooks","issue_events_url":"https://api.github.com/repos/stephentoub/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/stephentoub/coreclr/events","assignees_url":"https://api.github.com/repos/stephentoub/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/stephentoub/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/stephentoub/coreclr/tags","blobs_url":"https://api.github.com/repos/stephentoub/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephentoub/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephentoub/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephentoub/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephentoub/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/stephentoub/coreclr/languages","stargazers_url":"https://api.github.com/repos/stephentoub/coreclr/stargazers","contributors_url":"https://api.github.com/repos/stephentoub/coreclr/contributors","subscribers_url":"https://api.github.com/repos/stephentoub/coreclr/subscribers","subscription_url":"https://api.github.com/repos/stephentoub/coreclr/subscription","commits_url":"https://api.github.com/repos/stephentoub/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephentoub/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephentoub/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephentoub/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephentoub/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/stephentoub/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephentoub/coreclr/merges","archive_url":"https://api.github.com/repos/stephentoub/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephentoub/coreclr/downloads","issues_url":"https://api.github.com/repos/stephentoub/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/stephentoub/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/stephentoub/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/stephentoub/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephentoub/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/stephentoub/coreclr/releases{/id}","created_at":"2015-02-04T00:05:29Z","updated_at":"2015-05-08T16:03:09Z","pushed_at":"2015-07-16T15:22:19Z","git_url":"git://github.com/stephentoub/coreclr.git","ssh_url":"git@github.com:stephentoub/coreclr.git","clone_url":"https://github.com/stephentoub/coreclr.git","svn_url":"https://github.com/stephentoub/coreclr","homepage":"","size":36116,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9d1baf5921040dd364fc7cbf9271541c4a26c287","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-07-16T14:29:46Z","pushed_at":"2015-07-16T16:45:22Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/core/","size":51577,"stargazers_count":4844,"watchers_count":4844,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":951,"mirror_url":null,"open_issues_count":214,"forks":951,"open_issues":214,"watchers":4844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1248"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1248"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1248"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1248/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1248/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1248/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/f5b17e642224b573a3ed81d693cf76b9b6918f74"}}}}