{"action":"created","comment":{"url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments/27652224","id":27652224,"diff_hunk":"@@ -137,7 +137,7 @@ import GHC.Generics\n newtype NodeId = NodeId { nodeAddress :: NT.EndPointAddress }\n   deriving (Eq, Ord, Typeable, Data, Generic)\n instance Binary NodeId where\n-instance NFData NodeId\n+instance NFData NodeId where rnf (NodeId a) = rnf a `seq` ()","path":"src/Control/Distributed/Process/Internal/Types.hs","position":5,"original_position":5,"commit_id":"42e733aa5075aafa94344b7609f173f44d1c64b5","original_commit_id":"42e733aa5075aafa94344b7609f173f44d1c64b5","user":{"login":"mboes","id":51356,"avatar_url":"https://avatars.githubusercontent.com/u/51356?v=3","gravatar_id":"","url":"https://api.github.com/users/mboes","html_url":"https://github.com/mboes","followers_url":"https://api.github.com/users/mboes/followers","following_url":"https://api.github.com/users/mboes/following{/other_user}","gists_url":"https://api.github.com/users/mboes/gists{/gist_id}","starred_url":"https://api.github.com/users/mboes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboes/subscriptions","organizations_url":"https://api.github.com/users/mboes/orgs","repos_url":"https://api.github.com/users/mboes/repos","events_url":"https://api.github.com/users/mboes/events{/privacy}","received_events_url":"https://api.github.com/users/mboes/received_events","type":"User","site_admin":false},"body":"We should depend on deepseq>=1.4 and drop the `where rnf (NodeId a) = rnf a seq ()`.\r\n\r\nhttp://hackage.haskell.org/package/deepseq-1.4.1.1/docs/Control-DeepSeq.html#t:NFData\r\n\r\nUnless I'm misunderstanding the point of this change?","created_at":"2015-04-02T12:31:00Z","updated_at":"2015-04-02T12:31:00Z","html_url":"https://github.com/haskell-distributed/distributed-process/pull/189#discussion_r27652224","pull_request_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments/27652224"},"html":{"href":"https://github.com/haskell-distributed/distributed-process/pull/189#discussion_r27652224"},"pull_request":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189","id":31451090,"html_url":"https://github.com/haskell-distributed/distributed-process/pull/189","diff_url":"https://github.com/haskell-distributed/distributed-process/pull/189.diff","patch_url":"https://github.com/haskell-distributed/distributed-process/pull/189.patch","issue_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/189","number":189,"state":"open","locked":false,"title":"Add compatibility with ghc-7.10","user":{"login":"qnikst","id":170227,"avatar_url":"https://avatars.githubusercontent.com/u/170227?v=3","gravatar_id":"","url":"https://api.github.com/users/qnikst","html_url":"https://github.com/qnikst","followers_url":"https://api.github.com/users/qnikst/followers","following_url":"https://api.github.com/users/qnikst/following{/other_user}","gists_url":"https://api.github.com/users/qnikst/gists{/gist_id}","starred_url":"https://api.github.com/users/qnikst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qnikst/subscriptions","organizations_url":"https://api.github.com/users/qnikst/orgs","repos_url":"https://api.github.com/users/qnikst/repos","events_url":"https://api.github.com/users/qnikst/events{/privacy}","received_events_url":"https://api.github.com/users/qnikst/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-18T17:18:02Z","updated_at":"2015-04-02T12:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c83cf78555a5f3df095f1fbb2b9446458232219","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189/commits","review_comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189/comments","review_comment_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/189/comments","statuses_url":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/42e733aa5075aafa94344b7609f173f44d1c64b5","head":{"label":"tweag:ghc-7.10","ref":"ghc-7.10","sha":"42e733aa5075aafa94344b7609f173f44d1c64b5","user":{"login":"tweag","id":6057932,"avatar_url":"https://avatars.githubusercontent.com/u/6057932?v=3","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"repo":{"id":17485460,"name":"distributed-process","full_name":"tweag/distributed-process","owner":{"login":"tweag","id":6057932,"avatar_url":"https://avatars.githubusercontent.com/u/6057932?v=3","gravatar_id":"","url":"https://api.github.com/users/tweag","html_url":"https://github.com/tweag","followers_url":"https://api.github.com/users/tweag/followers","following_url":"https://api.github.com/users/tweag/following{/other_user}","gists_url":"https://api.github.com/users/tweag/gists{/gist_id}","starred_url":"https://api.github.com/users/tweag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweag/subscriptions","organizations_url":"https://api.github.com/users/tweag/orgs","repos_url":"https://api.github.com/users/tweag/repos","events_url":"https://api.github.com/users/tweag/events{/privacy}","received_events_url":"https://api.github.com/users/tweag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tweag/distributed-process","description":"Cloud Haskell Core Library","fork":true,"url":"https://api.github.com/repos/tweag/distributed-process","forks_url":"https://api.github.com/repos/tweag/distributed-process/forks","keys_url":"https://api.github.com/repos/tweag/distributed-process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweag/distributed-process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweag/distributed-process/teams","hooks_url":"https://api.github.com/repos/tweag/distributed-process/hooks","issue_events_url":"https://api.github.com/repos/tweag/distributed-process/issues/events{/number}","events_url":"https://api.github.com/repos/tweag/distributed-process/events","assignees_url":"https://api.github.com/repos/tweag/distributed-process/assignees{/user}","branches_url":"https://api.github.com/repos/tweag/distributed-process/branches{/branch}","tags_url":"https://api.github.com/repos/tweag/distributed-process/tags","blobs_url":"https://api.github.com/repos/tweag/distributed-process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweag/distributed-process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweag/distributed-process/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweag/distributed-process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweag/distributed-process/statuses/{sha}","languages_url":"https://api.github.com/repos/tweag/distributed-process/languages","stargazers_url":"https://api.github.com/repos/tweag/distributed-process/stargazers","contributors_url":"https://api.github.com/repos/tweag/distributed-process/contributors","subscribers_url":"https://api.github.com/repos/tweag/distributed-process/subscribers","subscription_url":"https://api.github.com/repos/tweag/distributed-process/subscription","commits_url":"https://api.github.com/repos/tweag/distributed-process/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweag/distributed-process/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweag/distributed-process/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweag/distributed-process/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweag/distributed-process/contents/{+path}","compare_url":"https://api.github.com/repos/tweag/distributed-process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweag/distributed-process/merges","archive_url":"https://api.github.com/repos/tweag/distributed-process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweag/distributed-process/downloads","issues_url":"https://api.github.com/repos/tweag/distributed-process/issues{/number}","pulls_url":"https://api.github.com/repos/tweag/distributed-process/pulls{/number}","milestones_url":"https://api.github.com/repos/tweag/distributed-process/milestones{/number}","notifications_url":"https://api.github.com/repos/tweag/distributed-process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweag/distributed-process/labels{/name}","releases_url":"https://api.github.com/repos/tweag/distributed-process/releases{/id}","created_at":"2014-03-06T17:05:23Z","updated_at":"2015-04-01T11:37:41Z","pushed_at":"2015-04-01T13:31:21Z","git_url":"git://github.com/tweag/distributed-process.git","ssh_url":"git@github.com:tweag/distributed-process.git","clone_url":"https://github.com/tweag/distributed-process.git","svn_url":"https://github.com/tweag/distributed-process","homepage":"http://haskell-distributed.github.com","size":4674,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"haskell-distributed:master","ref":"master","sha":"d87528c6c6e7cafbd3068983cbb17b48a61dd797","user":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"repo":{"id":2836059,"name":"distributed-process","full_name":"haskell-distributed/distributed-process","owner":{"login":"haskell-distributed","id":1215670,"avatar_url":"https://avatars.githubusercontent.com/u/1215670?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell-distributed","html_url":"https://github.com/haskell-distributed","followers_url":"https://api.github.com/users/haskell-distributed/followers","following_url":"https://api.github.com/users/haskell-distributed/following{/other_user}","gists_url":"https://api.github.com/users/haskell-distributed/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell-distributed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell-distributed/subscriptions","organizations_url":"https://api.github.com/users/haskell-distributed/orgs","repos_url":"https://api.github.com/users/haskell-distributed/repos","events_url":"https://api.github.com/users/haskell-distributed/events{/privacy}","received_events_url":"https://api.github.com/users/haskell-distributed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell-distributed/distributed-process","description":"Cloud Haskell Core Library","fork":false,"url":"https://api.github.com/repos/haskell-distributed/distributed-process","forks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/forks","keys_url":"https://api.github.com/repos/haskell-distributed/distributed-process/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell-distributed/distributed-process/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell-distributed/distributed-process/teams","hooks_url":"https://api.github.com/repos/haskell-distributed/distributed-process/hooks","issue_events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/events{/number}","events_url":"https://api.github.com/repos/haskell-distributed/distributed-process/events","assignees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/assignees{/user}","branches_url":"https://api.github.com/repos/haskell-distributed/distributed-process/branches{/branch}","tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/tags","blobs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell-distributed/distributed-process/languages","stargazers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/stargazers","contributors_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contributors","subscribers_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscribers","subscription_url":"https://api.github.com/repos/haskell-distributed/distributed-process/subscription","commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell-distributed/distributed-process/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell-distributed/distributed-process/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell-distributed/distributed-process/contents/{+path}","compare_url":"https://api.github.com/repos/haskell-distributed/distributed-process/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell-distributed/distributed-process/merges","archive_url":"https://api.github.com/repos/haskell-distributed/distributed-process/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell-distributed/distributed-process/downloads","issues_url":"https://api.github.com/repos/haskell-distributed/distributed-process/issues{/number}","pulls_url":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell-distributed/distributed-process/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell-distributed/distributed-process/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell-distributed/distributed-process/labels{/name}","releases_url":"https://api.github.com/repos/haskell-distributed/distributed-process/releases{/id}","created_at":"2011-11-23T13:59:00Z","updated_at":"2015-04-01T01:32:35Z","pushed_at":"2015-04-01T13:30:45Z","git_url":"git://github.com/haskell-distributed/distributed-process.git","ssh_url":"git@github.com:haskell-distributed/distributed-process.git","clone_url":"https://github.com/haskell-distributed/distributed-process.git","svn_url":"https://github.com/haskell-distributed/distributed-process","homepage":"http://haskell-distributed.github.com","size":6013,"stargazers_count":328,"watchers_count":328,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":58,"forks":54,"open_issues":58,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189"},"html":{"href":"https://github.com/haskell-distributed/distributed-process/pull/189"},"issue":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/189"},"comments":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/haskell-distributed/distributed-process/statuses/42e733aa5075aafa94344b7609f173f44d1c64b5"}}}}