{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/25566423","id":25566423,"diff_hunk":"@@ -934,12 +934,13 @@ fn trans_args_under_call_abi<'blk, 'tcx>(\n                     |srcval| {\n                         adt::trans_field_ptr(bcx, repr_ptr, srcval, 0, i)\n                     });\n-                let arg_datum = arg_datum.to_expr_datum();\n-                let arg_datum =\n-                    unpack_datum!(bcx, arg_datum.to_rvalue_datum(bcx, \"arg\"));\n-                let arg_datum =\n-                    unpack_datum!(bcx, arg_datum.to_appropriate_datum(bcx));\n-                llargs.push(arg_datum.add_clean(bcx.fcx, arg_cleanup_scope));\n+                llargs.push(unpack_result!(bcx, {\n+                    trans_arg_datum(bcx,\n+                                    field_types[i],","path":"src/librustc_trans/trans/callee.rs","position":12,"original_position":12,"commit_id":"7bccf74bf0fa7faea36f81037237236d55d9819e","original_commit_id":"7bccf74bf0fa7faea36f81037237236d55d9819e","user":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"body":"Couldn't this whole `for` loop be written as `llargs.extend(field_types.map(|field_ty| ...))`?","created_at":"2015-03-01T11:29:44Z","updated_at":"2015-03-01T11:29:44Z","html_url":"https://github.com/rust-lang/rust/pull/22923#discussion_r25566423","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/22923","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/25566423"},"html":{"href":"https://github.com/rust-lang/rust/pull/22923#discussion_r25566423"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22923"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/22923","id":30240492,"html_url":"https://github.com/rust-lang/rust/pull/22923","diff_url":"https://github.com/rust-lang/rust/pull/22923.diff","patch_url":"https://github.com/rust-lang/rust/pull/22923.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/22923","number":22923,"state":"open","locked":false,"title":"Use trans_arg_datum in trans_args_under_call_abi","user":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=3","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"body":"The logic for the argument translation was duplicated here.","created_at":"2015-03-01T11:13:54Z","updated_at":"2015-03-01T11:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daa61a9d6d828dc7acb22b70a265c4acbfc5b2dd","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/22923/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/22923/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/22923/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/7bccf74bf0fa7faea36f81037237236d55d9819e","head":{"label":"dotdash:trans_arg","ref":"trans_arg","sha":"7bccf74bf0fa7faea36f81037237236d55d9819e","user":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=3","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"repo":{"id":9376483,"name":"rust","full_name":"dotdash/rust","owner":{"login":"dotdash","id":230962,"avatar_url":"https://avatars.githubusercontent.com/u/230962?v=3","gravatar_id":"","url":"https://api.github.com/users/dotdash","html_url":"https://github.com/dotdash","followers_url":"https://api.github.com/users/dotdash/followers","following_url":"https://api.github.com/users/dotdash/following{/other_user}","gists_url":"https://api.github.com/users/dotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/dotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotdash/subscriptions","organizations_url":"https://api.github.com/users/dotdash/orgs","repos_url":"https://api.github.com/users/dotdash/repos","events_url":"https://api.github.com/users/dotdash/events{/privacy}","received_events_url":"https://api.github.com/users/dotdash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotdash/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/dotdash/rust","forks_url":"https://api.github.com/repos/dotdash/rust/forks","keys_url":"https://api.github.com/repos/dotdash/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotdash/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotdash/rust/teams","hooks_url":"https://api.github.com/repos/dotdash/rust/hooks","issue_events_url":"https://api.github.com/repos/dotdash/rust/issues/events{/number}","events_url":"https://api.github.com/repos/dotdash/rust/events","assignees_url":"https://api.github.com/repos/dotdash/rust/assignees{/user}","branches_url":"https://api.github.com/repos/dotdash/rust/branches{/branch}","tags_url":"https://api.github.com/repos/dotdash/rust/tags","blobs_url":"https://api.github.com/repos/dotdash/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotdash/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotdash/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotdash/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotdash/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/dotdash/rust/languages","stargazers_url":"https://api.github.com/repos/dotdash/rust/stargazers","contributors_url":"https://api.github.com/repos/dotdash/rust/contributors","subscribers_url":"https://api.github.com/repos/dotdash/rust/subscribers","subscription_url":"https://api.github.com/repos/dotdash/rust/subscription","commits_url":"https://api.github.com/repos/dotdash/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotdash/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotdash/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotdash/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotdash/rust/contents/{+path}","compare_url":"https://api.github.com/repos/dotdash/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotdash/rust/merges","archive_url":"https://api.github.com/repos/dotdash/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotdash/rust/downloads","issues_url":"https://api.github.com/repos/dotdash/rust/issues{/number}","pulls_url":"https://api.github.com/repos/dotdash/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/dotdash/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/dotdash/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotdash/rust/labels{/name}","releases_url":"https://api.github.com/repos/dotdash/rust/releases{/id}","created_at":"2013-04-11T17:43:47Z","updated_at":"2014-07-18T19:57:47Z","pushed_at":"2015-03-01T11:13:43Z","git_url":"git://github.com/dotdash/rust.git","ssh_url":"git@github.com:dotdash/rust.git","clone_url":"https://github.com/dotdash/rust.git","svn_url":"https://github.com/dotdash/rust","homepage":"http://www.rust-lang.org","size":244271,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0905c8a5ec856a6b972fcb239df2b8f6e82d2418","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-03-01T11:25:11Z","pushed_at":"2015-03-01T11:25:13Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":495731,"stargazers_count":9574,"watchers_count":9574,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1850,"mirror_url":null,"open_issues_count":1969,"forks":1850,"open_issues":1969,"watchers":9574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22923"},"html":{"href":"https://github.com/rust-lang/rust/pull/22923"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22923"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/22923/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22923/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/22923/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/7bccf74bf0fa7faea36f81037237236d55d9819e"}}}}