{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/1620","labels_url":"https://api.github.com/repos/rust-lang/cargo/issues/1620/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/1620/comments","events_url":"https://api.github.com/repos/rust-lang/cargo/issues/1620/events","html_url":"https://github.com/rust-lang/cargo/pull/1620","id":77301353,"number":1620,"title":"Added some checks for empty package and target names.","user":{"login":"Eljay","id":6574,"avatar_url":"https://avatars.githubusercontent.com/u/6574?v=3","gravatar_id":"","url":"https://api.github.com/users/Eljay","html_url":"https://github.com/Eljay","followers_url":"https://api.github.com/users/Eljay/followers","following_url":"https://api.github.com/users/Eljay/following{/other_user}","gists_url":"https://api.github.com/users/Eljay/gists{/gist_id}","starred_url":"https://api.github.com/users/Eljay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eljay/subscriptions","organizations_url":"https://api.github.com/users/Eljay/orgs","repos_url":"https://api.github.com/users/Eljay/repos","events_url":"https://api.github.com/users/Eljay/events{/privacy}","received_events_url":"https://api.github.com/users/Eljay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"wycats","id":4,"avatar_url":"https://avatars.githubusercontent.com/u/4?v=3","gravatar_id":"","url":"https://api.github.com/users/wycats","html_url":"https://github.com/wycats","followers_url":"https://api.github.com/users/wycats/followers","following_url":"https://api.github.com/users/wycats/following{/other_user}","gists_url":"https://api.github.com/users/wycats/gists{/gist_id}","starred_url":"https://api.github.com/users/wycats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wycats/subscriptions","organizations_url":"https://api.github.com/users/wycats/orgs","repos_url":"https://api.github.com/users/wycats/repos","events_url":"https://api.github.com/users/wycats/events{/privacy}","received_events_url":"https://api.github.com/users/wycats/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2015-05-17T12:35:52Z","updated_at":"2015-05-17T20:20:05Z","closed_at":"2015-05-17T20:20:05Z","pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/1620","html_url":"https://github.com/rust-lang/cargo/pull/1620","diff_url":"https://github.com/rust-lang/cargo/pull/1620.diff","patch_url":"https://github.com/rust-lang/cargo/pull/1620.patch"},"body":"Some simple validation for package/target names. Currently failure for these cases happens later in rustc (e.g. \"crate name must not be empty\") or at the os level (e.g. \"Is a directory\" error when package name is empty on linux). Better to handle this earlier so it's consistent across platforms.\r\n\r\nStill could do with a lot of validation for invalid characters etc. though."},"comment":{"url":"https://api.github.com/repos/rust-lang/cargo/issues/comments/102847858","html_url":"https://github.com/rust-lang/cargo/pull/1620#issuecomment-102847858","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/1620","id":102847858,"user":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"created_at":"2015-05-17T20:20:03Z","updated_at":"2015-05-17T20:20:03Z","body":":sunny: Test successful - [cargo-linux-32](http://buildbot.rust-lang.org/builders/cargo-linux-32/builds/1120), [cargo-linux-64](http://buildbot.rust-lang.org/builders/cargo-linux-64/builds/1111), [cargo-mac-32](http://buildbot.rust-lang.org/builders/cargo-mac-32/builds/1118), [cargo-mac-64](http://buildbot.rust-lang.org/builders/cargo-mac-64/builds/1114), [cargo-win-32](http://buildbot.rust-lang.org/builders/cargo-win-32/builds/1006), [cargo-win-64](http://buildbot.rust-lang.org/builders/cargo-win-64/builds/649)"}}