{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/guides/issues/514","labels_url":"https://api.github.com/repos/emberjs/guides/issues/514/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/guides/issues/514/comments","events_url":"https://api.github.com/repos/emberjs/guides/issues/514/events","html_url":"https://github.com/emberjs/guides/issues/514","id":98584749,"number":514,"title":"Search results have unversioned links","user":{"login":"michaelrkn","id":1266530,"avatar_url":"https://avatars.githubusercontent.com/u/1266530?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelrkn","html_url":"https://github.com/michaelrkn","followers_url":"https://api.github.com/users/michaelrkn/followers","following_url":"https://api.github.com/users/michaelrkn/following{/other_user}","gists_url":"https://api.github.com/users/michaelrkn/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelrkn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelrkn/subscriptions","organizations_url":"https://api.github.com/users/michaelrkn/orgs","repos_url":"https://api.github.com/users/michaelrkn/repos","events_url":"https://api.github.com/users/michaelrkn/events{/privacy}","received_events_url":"https://api.github.com/users/michaelrkn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/emberjs/guides/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/emberjs/guides/labels/infrastructure","name":"infrastructure","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-08-02T05:12:15Z","updated_at":"2015-10-02T08:20:33Z","closed_at":null,"body":"1. Go to http://guides.emberjs.com/. \r\n2. Type a term like \"Ember\" in the search box. Don't press the down arrow key. Press Enter. A modal opens.\r\n3. Click a link. \r\n\r\nExpected behavior: You are taken to a URL with the version number, eg http://guides.emberjs.com/v1.13.0/getting-started/. \r\n\r\nActual behavior: You are taken to a URL with the version number, eg http://guides.emberjs.com/getting-started.\r\n\r\nThis issue is not present if you enter a search term, use the down arrow to navigate through the results, and press Enter.\r\n\r\nThis issue is present in the 1.13 and 1.12 guides, making me think (/hope) that I did not introduce it myself when updating search.\r\n\r\nVersions 1.10 and 1.11 of the guides simply refresh the page when you press Enter without pressing the down arrow... I'm not sure what's going on there."},"comment":{"url":"https://api.github.com/repos/emberjs/guides/issues/comments/144956851","html_url":"https://github.com/emberjs/guides/issues/514#issuecomment-144956851","issue_url":"https://api.github.com/repos/emberjs/guides/issues/514","id":144956851,"user":{"login":"kevinkucharczyk","id":3127419,"avatar_url":"https://avatars.githubusercontent.com/u/3127419?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkucharczyk","html_url":"https://github.com/kevinkucharczyk","followers_url":"https://api.github.com/users/kevinkucharczyk/followers","following_url":"https://api.github.com/users/kevinkucharczyk/following{/other_user}","gists_url":"https://api.github.com/users/kevinkucharczyk/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkucharczyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkucharczyk/subscriptions","organizations_url":"https://api.github.com/users/kevinkucharczyk/orgs","repos_url":"https://api.github.com/users/kevinkucharczyk/repos","events_url":"https://api.github.com/users/kevinkucharczyk/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkucharczyk/received_events","type":"User","site_admin":false},"created_at":"2015-10-02T08:20:33Z","updated_at":"2015-10-02T08:20:33Z","body":"Thank you for your help, @anthias!\r\n\r\nUnfortunately, overriding the `getUrlFromItem` function doesn't seem to have any effect. I think the search overlay is rendered using the request data directly - so the urls are populated just as they are received from the server.\r\n\r\nFurthermore, I don't know how we could execute code after Swiftype has loaded - we are appending embed.js, which again is appending a couple of other sources - is there a sensible way to determine when the sources from embed.js are loaded, in order for us to execute more JS?"}}