{"action":"created","issue":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/381","labels_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/381/labels{/name}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/381/comments","events_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/381/events","html_url":"https://github.com/hummingbird-me/hummingbird/pull/381","id":54870652,"number":381,"title":"Replace HasCurrentUser mixin with injection","user":{"login":"NuckChorris","id":430411,"avatar_url":"https://avatars.githubusercontent.com/u/430411?v=3","gravatar_id":"","url":"https://api.github.com/users/NuckChorris","html_url":"https://github.com/NuckChorris","followers_url":"https://api.github.com/users/NuckChorris/followers","following_url":"https://api.github.com/users/NuckChorris/following{/other_user}","gists_url":"https://api.github.com/users/NuckChorris/gists{/gist_id}","starred_url":"https://api.github.com/users/NuckChorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuckChorris/subscriptions","organizations_url":"https://api.github.com/users/NuckChorris/orgs","repos_url":"https://api.github.com/users/NuckChorris/repos","events_url":"https://api.github.com/users/NuckChorris/events{/privacy}","received_events_url":"https://api.github.com/users/NuckChorris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-20T11:12:10Z","updated_at":"2015-02-17T09:57:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/381","html_url":"https://github.com/hummingbird-me/hummingbird/pull/381","diff_url":"https://github.com/hummingbird-me/hummingbird/pull/381.diff","patch_url":"https://github.com/hummingbird-me/hummingbird/pull/381.patch"},"body":"We were basically mixing HasCurrentUser into everything anyways so I figured \"let's just inject it into the controllers and get it over with\"\r\n\r\n<strike>I'm making a big assumption that Ember lazily injects to solve infinite recursion problems, but I think it's fairly safe.  We'll know for sure once Travis builds it.</strike>\r\n\r\nEvidently I was wrong, I'll switch this to an ObjectProxy-based service (those are an official role now) since ObjectController is deprecated anyways.  Not a complex refactor.\r\n\r\nOh and on the topic of injection, we can probably reenable model injection in app.js now that the patch landed for that"},"comment":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/comments/74642889","html_url":"https://github.com/hummingbird-me/hummingbird/pull/381#issuecomment-74642889","issue_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/381","id":74642889,"user":{"login":"vikhyat","id":31063,"avatar_url":"https://avatars.githubusercontent.com/u/31063?v=3","gravatar_id":"","url":"https://api.github.com/users/vikhyat","html_url":"https://github.com/vikhyat","followers_url":"https://api.github.com/users/vikhyat/followers","following_url":"https://api.github.com/users/vikhyat/following{/other_user}","gists_url":"https://api.github.com/users/vikhyat/gists{/gist_id}","starred_url":"https://api.github.com/users/vikhyat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikhyat/subscriptions","organizations_url":"https://api.github.com/users/vikhyat/orgs","repos_url":"https://api.github.com/users/vikhyat/repos","events_url":"https://api.github.com/users/vikhyat/events{/privacy}","received_events_url":"https://api.github.com/users/vikhyat/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T09:57:25Z","updated_at":"2015-02-17T09:57:25Z","body":"`ObjectProxy` approach works well, I used that in a different Ember app a few months ago."}}