{"action":"created","comment":{"url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/comments/38953741","id":38953741,"diff_hunk":"@@ -46,7 +47,7 @@\n     private static final String REDHAT_RELEASE_FILE = \"/etc/redhat-release\";\n     private static final String[] DEFAULT_REDHAT_VARIANTS = {\"rhel\", \"fedora\"};\n \n-    protected void detect(Properties props) {\n+    protected void detect(Properties props, List<String> classifierWithLikes) {","path":"src/main/java/kr/motd/maven/os/Detector.java","position":13,"original_position":13,"commit_id":"6ffa3052a7262d1b53c105d5032aa1bc84c649a7","original_commit_id":"6ffa3052a7262d1b53c105d5032aa1bc84c649a7","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"I actually want it to be a list since I want it clear that iteration order matters.","created_at":"2015-09-08T17:24:10Z","updated_at":"2015-09-08T17:24:10Z","html_url":"https://github.com/trustin/os-maven-plugin/pull/13#discussion_r38953741","pull_request_url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/comments/38953741"},"html":{"href":"https://github.com/trustin/os-maven-plugin/pull/13#discussion_r38953741"},"pull_request":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13","id":43792272,"html_url":"https://github.com/trustin/os-maven-plugin/pull/13","diff_url":"https://github.com/trustin/os-maven-plugin/pull/13.diff","patch_url":"https://github.com/trustin/os-maven-plugin/pull/13.patch","issue_url":"https://api.github.com/repos/trustin/os-maven-plugin/issues/13","number":13,"state":"open","locked":false,"title":"Support custom classifiers using likes","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"Fixes #12","created_at":"2015-08-31T18:12:50Z","updated_at":"2015-09-08T17:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b90e28b5cef4a83aea170dded258a4cd9db80736","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trustin/os-maven-plugin/issues/13/comments","statuses_url":"https://api.github.com/repos/trustin/os-maven-plugin/statuses/6ffa3052a7262d1b53c105d5032aa1bc84c649a7","head":{"label":"nmittler:like_classifier","ref":"like_classifier","sha":"6ffa3052a7262d1b53c105d5032aa1bc84c649a7","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"repo":{"id":39091563,"name":"os-maven-plugin","full_name":"nmittler/os-maven-plugin","owner":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nmittler/os-maven-plugin","description":"A Maven plugin that sets various useful properties detected from ${os.name} and ${os.arch} properties.","fork":true,"url":"https://api.github.com/repos/nmittler/os-maven-plugin","forks_url":"https://api.github.com/repos/nmittler/os-maven-plugin/forks","keys_url":"https://api.github.com/repos/nmittler/os-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nmittler/os-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nmittler/os-maven-plugin/teams","hooks_url":"https://api.github.com/repos/nmittler/os-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/nmittler/os-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/nmittler/os-maven-plugin/events","assignees_url":"https://api.github.com/repos/nmittler/os-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/nmittler/os-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/nmittler/os-maven-plugin/tags","blobs_url":"https://api.github.com/repos/nmittler/os-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nmittler/os-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nmittler/os-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/nmittler/os-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nmittler/os-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/nmittler/os-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/nmittler/os-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/nmittler/os-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/nmittler/os-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/nmittler/os-maven-plugin/subscription","commits_url":"https://api.github.com/repos/nmittler/os-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/nmittler/os-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/nmittler/os-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/nmittler/os-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/nmittler/os-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/nmittler/os-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nmittler/os-maven-plugin/merges","archive_url":"https://api.github.com/repos/nmittler/os-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nmittler/os-maven-plugin/downloads","issues_url":"https://api.github.com/repos/nmittler/os-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/nmittler/os-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/nmittler/os-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/nmittler/os-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nmittler/os-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/nmittler/os-maven-plugin/releases{/id}","created_at":"2015-07-14T18:00:07Z","updated_at":"2015-07-14T18:00:07Z","pushed_at":"2015-08-31T20:17:36Z","git_url":"git://github.com/nmittler/os-maven-plugin.git","ssh_url":"git@github.com:nmittler/os-maven-plugin.git","clone_url":"https://github.com/nmittler/os-maven-plugin.git","svn_url":"https://github.com/nmittler/os-maven-plugin","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trustin:master","ref":"master","sha":"b01b8ecffae1cc46b67abcd8567e6c537b032573","user":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"repo":{"id":19308738,"name":"os-maven-plugin","full_name":"trustin/os-maven-plugin","owner":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trustin/os-maven-plugin","description":"A Maven plugin that sets various useful properties detected from ${os.name} and ${os.arch} properties.","fork":false,"url":"https://api.github.com/repos/trustin/os-maven-plugin","forks_url":"https://api.github.com/repos/trustin/os-maven-plugin/forks","keys_url":"https://api.github.com/repos/trustin/os-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trustin/os-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trustin/os-maven-plugin/teams","hooks_url":"https://api.github.com/repos/trustin/os-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/trustin/os-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/trustin/os-maven-plugin/events","assignees_url":"https://api.github.com/repos/trustin/os-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/trustin/os-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/trustin/os-maven-plugin/tags","blobs_url":"https://api.github.com/repos/trustin/os-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trustin/os-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trustin/os-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/trustin/os-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trustin/os-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/trustin/os-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/trustin/os-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/trustin/os-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/trustin/os-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/trustin/os-maven-plugin/subscription","commits_url":"https://api.github.com/repos/trustin/os-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/trustin/os-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/trustin/os-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/trustin/os-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/trustin/os-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/trustin/os-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trustin/os-maven-plugin/merges","archive_url":"https://api.github.com/repos/trustin/os-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trustin/os-maven-plugin/downloads","issues_url":"https://api.github.com/repos/trustin/os-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/trustin/os-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/trustin/os-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/trustin/os-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trustin/os-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/trustin/os-maven-plugin/releases{/id}","created_at":"2014-04-30T09:32:24Z","updated_at":"2015-09-07T19:09:36Z","pushed_at":"2015-08-31T20:17:36Z","git_url":"git://github.com/trustin/os-maven-plugin.git","ssh_url":"git@github.com:trustin/os-maven-plugin.git","clone_url":"https://github.com/trustin/os-maven-plugin.git","svn_url":"https://github.com/trustin/os-maven-plugin","homepage":"","size":555,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13"},"html":{"href":"https://github.com/trustin/os-maven-plugin/pull/13"},"issue":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/issues/13"},"comments":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/trustin/os-maven-plugin/statuses/6ffa3052a7262d1b53c105d5032aa1bc84c649a7"}}}}